Geant4 Cross Reference |
1 # Category param History << 1 $Id: History,v 1.39 2008-03-26 14:54:40 gcosmo Exp $ >> 2 ------------------------------------------------------------------- 2 3 3 See `CONTRIBUTING.rst` for details of **requir << 4 ========================================================= 4 which **must** added in reverse chronological << 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP 5 It must **not** be used as a substitute for wr << 6 ========================================================= >> 7 >> 8 Category History file >> 9 --------------------- >> 10 This file should be used by G4 developers and category coordinators >> 11 to briefly summarize all major modifications introduced in the code >> 12 and keep track of all category-tags. >> 13 It DOES NOT substitute the CVS log-message one should put at every >> 14 committal in the CVS repository ! >> 15 >> 16 ---------------------------------------------------------- >> 17 * Reverse chronological order (last date on top), please * >> 18 ---------------------------------------------------------- 6 19 7 ---------------------------------------------- << 20 Feb. 11, 2011, M. Verderi (param-V09-03-00) 8 << 9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) << 10 - In G4GlobalFastSimulationManager: << 11 use G4ThreadLocalSingleton to avoid undelete << 12 << 13 ## 2023-10-18 Ben Morgan (param-V11-01-03) << 14 - Apply standard and extended clang-tidy fixes << 15 - Mark empty/obsolete functions as deprecated << 16 << 17 ## 2023-10-16 Ben Morgan (param-V11-01-02) << 18 - Apply standard clang-format-ing. << 19 - Normal order accessors and docstrings. << 20 << 21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) << 22 - In G4FastTrack, removed references to G4Touc << 23 which is now deprecated. << 24 << 25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 << 26 - Added missing virtual destructor to G4VFastS << 27 << 28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) << 29 - Fixed compilation warnings for implicit type << 30 << 31 ## 2022-10-27 Makoto Asai (param-V11-00-03) << 32 - G4FastSimHitMaker - making compatible to com << 33 << 34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 << 35 - G4FastStep - delete copy constructor and ope << 36 << 37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) << 38 - Adding the 'flush' method to the fast simula << 39 This method allows to process the input buff << 40 the end of the G4 event. It is used when par << 41 The 'flash' is triggered inside the event lo << 42 The fast simulation model may add secondarie << 43 by Geant4. << 44 << 45 ## 2021-12-10 Ben Morgan (param-V11-00-00) << 46 - Change to new Markdown History format << 47 << 48 --- << 49 << 50 # History entries prior to 11.0 << 51 << 52 April 16, 2021 Ben Morgan (param-V10-07-00) << 53 - Migrate build to modular CMake API << 54 << 55 October 5, 2020, A. Zaborowska (param-V10-06-0 << 56 - Introduce general facilities based on GFlash << 57 to facilitate multiple hit (energy & positio << 58 from fast simulation models. << 59 << 60 September 9, 2020, G. Cosmo (param-V10-06-02) << 61 - Fixed minor Coverity defect for uninitialise << 62 << 63 April 21, 2020, A. Zaborowska (param-V10-06-01 << 64 - Sanity check for root logical volumes for re << 65 UI command /param/showSetup works also if no << 66 << 67 March 26, 2020, I. Semeniouk (param-V10-06-00) << 68 - G4FastSimulationHelper : merge ActivateFastS << 69 - G4FastSimulationManager.hh, G4VFastSimulatio << 70 redefinition of G4Envelope type << 71 << 72 October 30, 2019, A. Zaborowska (param-v10-05- << 73 - Register G4FastSimulationManagerProcess with << 74 G4FastSimulationManagerHelper to ensure it i << 75 invoked for a given step (ExclusivelyForced) << 76 StronglyForced processes will be considered. << 77 << 78 December 19, 2017, G. Cosmo (param-V10-04-00) << 79 - Fixed self-consistency in G4FastSimulationVe << 80 Thanks to Raphael Isemann for reporting this << 81 << 82 November 03, 2016, M. Verderi (param-V10-02-01 << 83 - New G4FastSimulationManagerHelper utility fo << 84 adding G4FastSimulationManagerProcess to a << 85 process manager. << 86 << 87 November 02, 2016, M. Verderi (param-V10-02-00 << 88 - fix various Coverity defects. << 89 << 90 March 27, 2013, M. Verderi (param-V09-06-00) << 91 - remove unused field 'fOnBoundary' in G4FastS << 92 as this was causing a warning from clang. << 93 << 94 July 10, 2012, G. Cosmo (param-V09-05-00) << 95 - Explicitly use inclusion of headers for syst << 96 constants, in plan to remove implicit inclus << 97 << 98 September 30, 2011, M. Verderi (param-V09-04-0 << 99 - Added missing new header file (G4FastSimulat << 100 sources.cmake. << 101 << 102 September 30, 2011, M. Verderi (param-V09-04-0 << 103 - Migration to new G4Exception scheme. << 104 - what is V09-04-01 tag ? << 105 << 106 February 11, 2011, M. Verderi (param-V09-04-00 << 107 - Implementation of method 21 - Implementation of method 108 void ProposePrimaryTrackFinalKineticEnergy ( 22 void ProposePrimaryTrackFinalKineticEnergy (G4double); 109 was missing : modified file G4FastStep.icc 23 was missing : modified file G4FastStep.icc 110 24 111 March 13, 2008, G. Cosmo (param-V09-01-00) << 25 March 13 2008, G. Cosmo (param-V09-01-00) 112 - Cleared compilation warnings in G4FastSimula 26 - Cleared compilation warnings in G4FastSimulationManagerProcess and 113 G4FastSimulationMessenger on gcc-4.3.0 for a 27 G4FastSimulationMessenger on gcc-4.3.0 for ambiguous use of 114 parentheses in nested if-else statements. 28 parentheses in nested if-else statements. 115 29 116 November 30, 2007, M. Verderi << 30 November 30 2007, M. Verderi 117 - Add Along methods to G4FSMP process 31 - Add Along methods to G4FSMP process 118 - tag as param-V09-00-01 32 - tag as param-V09-00-01 119 33 120 November 30, 2007, M. Verderi << 34 November 30 2007, M. Verderi 121 - minor corrections to G4FastSimulationManager << 35 - minor corrections to G4FastSimulationManagerProcess.hh/.cc : 122 * add call fPathFinder->prepareNewrack(...) 36 * add call fPathFinder->prepareNewrack(...) 123 * deactivate ghost navigator in EndOfTracki 37 * deactivate ghost navigator in EndOfTracking(..) method 124 - tag as param-V09-00-00 38 - tag as param-V09-00-00 125 39 126 May 18, 2007, M. Verderi 40 May 18, 2007, M. Verderi 127 - tag as param-V08-03-00 41 - tag as param-V08-03-00 128 42 129 May 11, 2007, M. Verderi 43 May 11, 2007, M. Verderi 130 - remove include/G4FastSimulationManagerProces 44 - remove include/G4FastSimulationManagerProcess81.hh 131 include/G4FlavoredParallelWorld.hh 45 include/G4FlavoredParallelWorld.hh 132 include/G4GFSManager81.hh 46 include/G4GFSManager81.hh 133 src/G4FastSimulationManagerProcess81. 47 src/G4FastSimulationManagerProcess81.cc 134 src/G4GFSManager81.cc 48 src/G4GFSManager81.cc 135 49 136 50 137 November 10, 2006, M. Verderi - param-V08-01-0 51 November 10, 2006, M. Verderi - param-V08-01-00 138 - Limited number of warning messages printed b 52 - Limited number of warning messages printed by the 139 G4GlobalFastSimulationManager. 53 G4GlobalFastSimulationManager. 140 - Renamed G4FastSimulationManagerProcess_forCo 54 - Renamed G4FastSimulationManagerProcess_forCoupledTransportation with 141 G4FastSimulationManagerProcess81. 55 G4FastSimulationManagerProcess81. 142 In addition, this class can now handle the c 56 In addition, this class can now handle the case of Navigator index=0, 143 i.e., the navigator for tracking, regardless 57 i.e., the navigator for tracking, regardless the G4Transportation or 144 G4CoupledTransportation is used. (For other 58 G4CoupledTransportation is used. (For other navigators, there is 145 of course no choice, and G4CoupledTransporta 59 of course no choice, and G4CoupledTransportation is necessary.) 146 60 147 November 3, 2006 M. Verderi 61 November 3, 2006 M. Verderi 148 - Introduced G4FastSimulationManagerProcess_fo 62 - Introduced G4FastSimulationManagerProcess_forCoupledTransportation class for 149 handling fast simulation in new parallel geo 63 handling fast simulation in new parallel geometry scheme. This requires 150 the G4CoupledTransportation to be active. 64 the G4CoupledTransportation to be active. 151 - Introduced G4GFSManager81 class that gathers 65 - Introduced G4GFSManager81 class that gathers the future code to become the 152 default at next major release in the G4Globa 66 default at next major release in the G4GlobalFastSimulationManager class. 153 - G4FastSimulationManager: adapted to new sche 67 - G4FastSimulationManager: adapted to new scheme. Still has old code for 154 backward compatibilty. 68 backward compatibilty. 155 - G4FastSimulationManagerProcess: mostly the s 69 - G4FastSimulationManagerProcess: mostly the same, apart from a small bug fix. 156 - G4FastSimulationMessenger: new command creat 70 - G4FastSimulationMessenger: new command created "/param/showSetup", useful 157 to show the fast simulation setup (region, m 71 to show the fast simulation setup (region, models, processes, etc...) 158 It is only valid for geometry closed state. 72 It is only valid for geometry closed state. Desirable to have interactive 159 command in the run manager for this. 73 command in the run manager for this. 160 74 161 November 25, 2005, M.Verderi - param-V07-01-0 75 November 25, 2005, M.Verderi - param-V07-01-04 162 - put back Makoto's change: StartTracking(G4Tr 76 - put back Makoto's change: StartTracking(G4Track*) 163 77 164 November 25, 2005, M Verderi - param-V07-01-03 78 November 25, 2005, M Verderi - param-V07-01-03 165 - Make ghost functionnality available with G4R 79 - Make ghost functionnality available with G4Region 166 - ** Note ** Change back StartTracking(G4Track 80 - ** Note ** Change back StartTracking(G4Track*) -> StartTracking() in G4FSMP 167 StartTracking(G4Track*) was intro 81 StartTracking(G4Track*) was introduced in param-V07-01-02 168 because (I guess) of procman-V07-01-01 82 because (I guess) of procman-V07-01-01 169 This is to make param-V07-01-03 compatible w 83 This is to make param-V07-01-03 compatible with geant4-07-01-ref-05 170 84 171 November 21, 2005 M.Asai - param-V07-01-02 85 November 21, 2005 M.Asai - param-V07-01-02 172 - Fix warning message. 86 - Fix warning message. 173 87 174 November 02, 2005 G.Cosmo - param-V07-01-01 88 November 02, 2005 G.Cosmo - param-V07-01-01 175 - Corrected setting of envelope volumes and so 89 - Corrected setting of envelope volumes and solid in G4FastTrack. 176 - Migrated old scheme for G4Exception and some 90 - Migrated old scheme for G4Exception and some cosmetics... 177 91 178 October 28, 2005 M.Asai - param-V07-01-00 92 October 28, 2005 M.Asai - param-V07-01-00 179 - Working tag for merging "envelope" to G4Regi 93 - Working tag for merging "envelope" to G4Region. 180 94 181 December 07, 2004 G. Cosmo - param-V06-02-01 95 December 07, 2004 G. Cosmo - param-V06-02-01 182 - Implemented migration to <cmath>. 96 - Implemented migration to <cmath>. 183 97 184 November 26, 2004 M. Verderi - param-V06-02-00 98 November 26, 2004 M. Verderi - param-V06-02-00 185 - Implemented migration to new G4VParticleChan 99 - Implemented migration to new G4VParticleChange interfaces. 186 100 187 December 12, 2003 G. Cosmo - param-V06-00-00 101 December 12, 2003 G. Cosmo - param-V06-00-00 188 - G4FastSimulationVector.icc: use std_pvector: 102 - G4FastSimulationVector.icc: use std_pvector:: scope for calls to 189 base class. Fixes compilation problem on Int 103 base class. Fixes compilation problem on Intel-icc compiler. 190 104 191 November 10, 2003 G. Cosmo - param-V05-02-01 105 November 10, 2003 G. Cosmo - param-V05-02-01 192 - G4FastTrack: use G4Navigator::CreateTouchabl 106 - G4FastTrack: use G4Navigator::CreateTouchableHistoryHandle() instead of 193 CreateTouchableHistory() in method FRecordsA 107 CreateTouchableHistory() in method FRecordsAffineTransformation(). 194 108 195 October 4, 2003 G. Cosmo - param-V05-02-00 109 October 4, 2003 G. Cosmo - param-V05-02-00 196 - Modified GNUmakefile: 110 - Modified GNUmakefile: 197 o added dependency to new module "geometry/n 111 o added dependency to new module "geometry/navigation". 198 - Coworks with "geometry-V05-02-00" and "digit 112 - Coworks with "geometry-V05-02-00" and "digits_hits-V05-02-00". 199 113 200 May 21, 2003 G. Cosmo - param-V05-01-00 114 May 21, 2003 G. Cosmo - param-V05-01-00 201 o Fixed pedantic warnings on Linux-g++ 115 o Fixed pedantic warnings on Linux-g++. 202 o Call base class in copy-constructor 116 o Call base class in copy-constructor of G4FastStep. 203 117 204 Nov 20, 2002 G. Cosmo - param-V04-01-02 118 Nov 20, 2002 G. Cosmo - param-V04-01-02 205 o Patched access to public static data in G4 119 o Patched access to public static data in G4FastStep.cc 206 and G4GlobalFastSimulationManager.cc to al 120 and G4GlobalFastSimulationManager.cc to allow porting on 207 Windows DLLs. 121 Windows DLLs. 208 122 209 Nov 15, 2002 S. Sadilov - param-V04-01-01 123 Nov 15, 2002 S. Sadilov - param-V04-01-01 210 o Fixed compilation problems on Windows in 124 o Fixed compilation problems on Windows in 211 G4FastSimulationManager.cc and G4GlobalFas 125 G4FastSimulationManager.cc and G4GlobalFastSimulationManager.cc 212 126 213 Nov 02, 2002 M. Verderi - param-V04-01-00 127 Nov 02, 2002 M. Verderi - param-V04-01-00 214 o Add method to retrieve G4VFastSimulationMo 128 o Add method to retrieve G4VFastSimulationModel by name. 215 The user's method is in G4GlobalFastSimula 129 The user's method is in G4GlobalFastSimulationManager: 216 130 217 GetFastSimulationModel(); 131 GetFastSimulationModel(); 218 132 219 it is accompagnied by same methods name in 133 it is accompagnied by same methods name in 220 G4FastSimulationManager class. 134 G4FastSimulationManager class. 221 135 222 o Add "test" directory, used to test above f 136 o Add "test" directory, used to test above feature. 223 137 224 Oct 26, 2001 M. Verderi - param-V03-02-00 138 Oct 26, 2001 M. Verderi - param-V03-02-00 225 Fixes to clear warnings produced with gcc-2. 139 Fixes to clear warnings produced with gcc-2.95.2: 226 - loop index, where comparison with method " 140 - loop index, where comparison with method "size()" of 227 G4std::vector<T>, changed: int -> size_t << 141 G4std::vector<T>, changed: int -> size_t 228 - change "if ( a=b ) {..}" by "if ( (a=b) ) 142 - change "if ( a=b ) {..}" by "if ( (a=b) ) {...}" 229 this makes the compiler sure you want to mak 143 this makes the compiler sure you want to make an 230 assignement in the "if" condition 144 assignement in the "if" condition 231 - re-order initialisations of a few variable 145 - re-order initialisations of a few variables in constructors 232 to match the declaration order. 146 to match the declaration order. 233 Some warnings still exist, but regard the G4 147 Some warnings still exist, but regard the G4Propagator of geometry. 234 148 235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 149 Apr 3, 2001 J. Apostolakis - param-V03-00-00 236 - Modified G4FastSimulationManagerProcess call 150 - Modified G4FastSimulationManagerProcess call to PropagatorInField ComputeStep 237 to use new interface with G4FieldTrack (in 151 to use new interface with G4FieldTrack (in place of now obsolete interface.) 238 152 239 Nov 14, 2000 G. Cosmo - param-V02-00-01 153 Nov 14, 2000 G. Cosmo - param-V02-00-01 240 - Moved specific parameterisation models to th 154 - Moved specific parameterisation models to the new top category 241 "parameterisations". Moved files: 155 "parameterisations". Moved files: 242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm 156 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRmodel[.hh.cc], 243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster 157 G4IrregularXrayTRmodel[.hh.cc], G4PAIclusterModel[.hh.cc], 244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr 158 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXrayTRmodel[.hh.cc], 245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode 159 G4RegularXrayTRmodel[.hh.cc], G4VClusterModel[.hh.cc], 246 G4VXrayTRmodel[.hh.cc]. 160 G4VXrayTRmodel[.hh.cc]. 247 - Cleaned-up GNUmakefile of non necessary depe 161 - Cleaned-up GNUmakefile of non necessary dependencies. 248 162 249 Aug 03, 2000 G. Cosmo - param-V02-00-00r 163 Aug 03, 2000 G. Cosmo - param-V02-00-00r 250 - Changed RandGauss to G4RandGauss in G4Irregu 164 - Changed RandGauss to G4RandGauss in G4IrregularXrayTRmodel.cc and 251 G4VXrayTRmodel.cc to fix events' reproducibi 165 G4VXrayTRmodel.cc to fix events' reproducibility problem. 252 - G4VXrayTRmodel.cc: fix to class destructor ( 166 - G4VXrayTRmodel.cc: fix to class destructor (V.Grichine) 253 167 254 Jun 15, 2000 G. Cosmo - param-V01-01-04 168 Jun 15, 2000 G. Cosmo - param-V01-01-04 255 - The tag coworks with global-V01-01-04 and ma 169 - The tag coworks with global-V01-01-04 and materials-V01-01-00: 256 o Fixed usage of G4complex type for ISO and 170 o Fixed usage of G4complex type for ISO and non-ISO compilers. 257 Affected files: G4FoamXrayTRmodel.cc, G4Ga 171 Affected files: G4FoamXrayTRmodel.cc, G4GamDistrXrayTRmodel.cc, G4PlateIrrGasXrayTRmodel.cc 258 and G4RegularXrayTRmodel.c 172 and G4RegularXrayTRmodel.cc. 259 In case of G4complex types passed to mathe 173 In case of G4complex types passed to mathematical functions, use G4std:: prefix. 260 o Fixed usage of G4Integrator class, now cha 174 o Fixed usage of G4Integrator class, now changed to templated to allow porting of the 261 code on SUN-CC compiler which does not imp 175 code on SUN-CC compiler which does not implement templated member functions. 262 Affected files: G4VXrayTRmodel[.hh.cc] 176 Affected files: G4VXrayTRmodel[.hh.cc] 263 177 264 Jun 6, 2000 M. Verderi & P. Mora de Freitas 178 Jun 6, 2000 M. Verderi & P. Mora de Freitas 265 - fixed compilation errors with HP-aCC for the 179 - fixed compilation errors with HP-aCC for the files G4RegularXrayTRmodel.cc, 266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod 180 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmodel.cc. 267 181 268 May 30, 2000 M. Verderi & P. Mora de Freitas 182 May 30, 2000 M. Verderi & P. Mora de Freitas 269 183 270 - parameterisation category is now RW free. 184 - parameterisation category is now RW free. 271 185 272 September 16, 1999 M. Verderi & P. Mora de Fre 186 September 16, 1999 M. Verderi & P. Mora de Freitas 273 187 274 - Fixed bug in G4FastStep::CheckIt() method. 188 - Fixed bug in G4FastStep::CheckIt() method. 275 189 276 April 19, 1999 M. Verderi & P. Mora de Freitas 190 April 19, 1999 M. Verderi & P. Mora de Freitas 277 191 278 Changes in G4FastStep to co-work with track-01 192 Changes in G4FastStep to co-work with track-01-00-04: 279 193 280 1) The method void CheckIt(const G4Track&) bec << 194 1) The method void CheckIt(const G4Track&) becomes 281 G4bool CheckIt(const G4Track&); 195 G4bool CheckIt(const G4Track&); 282 2) The FAST_STEP_DEBUG compiling option disapp 196 2) The FAST_STEP_DEBUG compiling option disappears; 283 3) Call to CheckIt controled by the G4VParticl 197 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute. 284 198 285 Miscellaneous: the declaration "G4double mass 199 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh 286 corrected to G4double mass =...". 200 corrected to G4double mass =...". 287 201 288 April 15, 1999 M. Verderi & P. Mora de Freitas 202 April 15, 1999 M. Verderi & P. Mora de Freitas 289 203 290 Tasks to decouple visualization from processes 204 Tasks to decouple visualization from processes/parameterisation: 291 205 292 1) G4GlobalFastSimulationManager now inherites 206 1) G4GlobalFastSimulationManager now inherites from the intercoms/ 293 G4VGlobalFastSimulationManager to allow visual << 207 G4VGlobalFastSimulationManager to allow visualisation to get a 294 concrete instance pointer to the G4GlobalFastS 208 concrete instance pointer to the G4GlobalFastSimulationManager, 295 if any. 209 if any. 296 210 297 2) G4FlavoredParallelWorld now inherites from 211 2) G4FlavoredParallelWorld now inherites from the intercoms/ 298 G4VFlavoredParallelWorld, a pure virtual abstr 212 G4VFlavoredParallelWorld, a pure virtual abstract class to interface 299 parameterisation with visualization. 213 parameterisation with visualization. 300 214 301 Co-works with intercoms-01-00-01 tag 215 Co-works with intercoms-01-00-01 tag 302 216 303 Modified files: 217 Modified files: 304 --------------- 218 --------------- 305 G4FlavoredParallelWorld.hh 219 G4FlavoredParallelWorld.hh 306 G4GlobalFastSimulationManager.hh 220 G4GlobalFastSimulationManager.hh 307 G4GlobalFastSimulationManager.cc 221 G4GlobalFastSimulationManager.cc 308 222 309 Done, tested, system-tested on HP-aCC with exe 223 Done, tested, system-tested on HP-aCC with exemple N05. 310 224 311 April 14, 1999 M. Verderi & P. Mora de Freitas 225 April 14, 1999 M. Verderi & P. Mora de Freitas 312 226 313 Several consolidation tasks (thanks to G. Cosm 227 Several consolidation tasks (thanks to G. Cosmo): 314 228 315 1) Warning: << 229 1) Warning: 316 ----------- 230 ----------- 317 231 318 Pointers usage 232 Pointers usage 319 233 320 - Setting pointers to 0 after delete: 234 - Setting pointers to 0 after delete: 321 235 322 delete pA; 236 delete pA; 323 pA = 0; 237 pA = 0; 324 238 325 - Avoid to use "NULL". 239 - Avoid to use "NULL". 326 240 327 Modified files: 241 Modified files: 328 --------------- 242 --------------- 329 G4FastSimulationManager.hh 243 G4FastSimulationManager.hh 330 G4FastTrack.hh 244 G4FastTrack.hh 331 G4FlavoredParallelWorld.hh 245 G4FlavoredParallelWorld.hh 332 G4FastSimulationManager.cc 246 G4FastSimulationManager.cc 333 G4FastSimulationMessenger.cc 247 G4FastSimulationMessenger.cc 334 G4FastSimulationManagerProcess.cc 248 G4FastSimulationManagerProcess.cc 335 G4FastTrack.cc 249 G4FastTrack.cc 336 G4GlobalFastSimulationManager.cc 250 G4GlobalFastSimulationManager.cc 337 G4VFastSimulationModel.cc 251 G4VFastSimulationModel.cc 338 252 339 Status: << 253 Status: 340 ------- 254 ------- 341 Done, tested, system-tested on HP-aCC with exe 255 Done, tested, system-tested on HP-aCC with exemple N05. 342 256 343 2) Warning: 257 2) Warning: 344 ----------- 258 ----------- 345 include/G4FastSimulationManager.hh:163 259 include/G4FastSimulationManager.hh:163 346 Public member functions shall always retur 260 Public member functions shall always return const handles to member data 347 Severe violation: Universal Coding Standar 261 Severe violation: Universal Coding Standards item 18 348 262 349 offending code: 263 offending code: 350 --------------- 264 --------------- 351 inline G4VParticleChange* G4FastSimulationMana 265 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange() 352 { 266 { 353 return &fFastStep; 267 return &fFastStep; 354 } 268 } 355 269 356 Diagnostic: 270 Diagnostic: 357 ---------- 271 ---------- 358 272 359 Called by the G4FastSimulationManagerProcess << 273 Called by the G4FastSimulationManagerProcess to return it in the 360 PostStepDoIt call. << 274 PostStepDoIt call. 361 275 362 Action: 276 Action: 363 ------- 277 ------- 364 The G4FastSimulationManager::GettheParticleCha 278 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any 365 more. The G4VParticleChange* is now returned d 279 more. The G4VParticleChange* is now returned directly when invoking the 366 G4FastSimulationManager::InvokePostStepDoIt() 280 G4FastSimulationManager::InvokePostStepDoIt() and 367 G4FastSimulationManager::InvokeAtRestDoIt() me 281 G4FastSimulationManager::InvokeAtRestDoIt() methodes. 368 282 369 Modified files: 283 Modified files: 370 --------------- 284 --------------- 371 G4FastSimulationManager.hh 285 G4FastSimulationManager.hh 372 G4FastSimulationManager.cc 286 G4FastSimulationManager.cc 373 G4FastSimulationManagerProcess.cc 287 G4FastSimulationManagerProcess.cc 374 288 375 Status: << 289 Status: 376 ------- 290 ------- 377 Done, tested, system-tested on HP-aCC with exe 291 Done, tested, system-tested on HP-aCC with exemple N05. 378 292 379 3) Warning: 293 3) Warning: 380 ----------- 294 ----------- 381 include/G4FastSimulationManagerProcess.hh:52 295 include/G4FastSimulationManagerProcess.hh:52 382 If a class has virtual functions it shall 296 If a class has virtual functions it shall have a virtual destructor 383 Severe violation: Universal Coding Standar 297 Severe violation: Universal Coding Standards item 17 384 class G4FastSimulationManagerProcess has v 298 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor. 385 299 386 offending code: 300 offending code: 387 --------------- 301 --------------- 388 ~G4FastSimulationManagerProcess(); 302 ~G4FastSimulationManagerProcess(); 389 303 390 Diagnostic: 304 Diagnostic: 391 ---------- 305 ---------- 392 Nobody should inherites from G4FastSimulatio << 306 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual 393 is added. 307 is added. 394 308 395 Action: 309 Action: 396 ------- 310 ------- 397 virtual ~G4FastSimulationManagerProcess(); 311 virtual ~G4FastSimulationManagerProcess(); 398 312 399 Modified files: 313 Modified files: 400 --------------- 314 --------------- 401 G4FastSimulationManagerProcess.hh 315 G4FastSimulationManagerProcess.hh 402 316 403 Status: << 317 Status: 404 ------- 318 ------- 405 Done. 319 Done. 406 320 407 4) Warning: 321 4) Warning: 408 ----------- 322 ----------- 409 include/G4FastSimulationMessenger.hh:36 323 include/G4FastSimulationMessenger.hh:36 410 If a class has virtual functions it shall 324 If a class has virtual functions it shall have a virtual destructor 411 Severe violation: Universal Coding Standar 325 Severe violation: Universal Coding Standards item 17 412 class G4FastSimulationMessenger has virtua 326 class G4FastSimulationMessenger has virtual functions without a virtual destructor. 413 327 414 328 415 offending code: 329 offending code: 416 --------------- 330 --------------- 417 ~G4FastSimulationMessenger(); 331 ~G4FastSimulationMessenger(); 418 332 419 Diagnostic: 333 Diagnostic: 420 ---------- 334 ---------- 421 Nobody should inherites from G4FastSimulatio << 335 Nobody should inherites from G4FastSimulationMessenger BUT for virtual 422 is added. 336 is added. 423 337 424 Action: 338 Action: 425 ------- 339 ------- 426 virtual ~G4FastSimulationMessenger(); 340 virtual ~G4FastSimulationMessenger(); 427 341 428 Modified files: 342 Modified files: 429 --------------- 343 --------------- 430 G4FastSimulationMessenger.hh 344 G4FastSimulationMessenger.hh 431 345 432 Status: << 346 Status: 433 ------- 347 ------- 434 Done. 348 Done. 435 349 436 5) Warning: 350 5) Warning: 437 ----------- 351 ----------- 438 include/G4FastStep.hh:224 352 include/G4FastStep.hh:224 439 Operator= should call base class operator= 353 Operator= should call base class operator= 440 Possible severe violation: Effective C++ i 354 Possible severe violation: Effective C++ item 16 441 operator= in class G4FastStep, should call 355 operator= in class G4FastStep, should call operator= in base class G4VParticleChange 442 356 443 offending code: 357 offending code: 444 --------------- 358 --------------- 445 G4FastStep & G4FastStep::operator=(const G4Fas 359 G4FastStep & G4FastStep::operator=(const G4FastStep &right) 446 { 360 { 447 if (this != &right) 361 if (this != &right) 448 { 362 { 449 theListOfSecondaries = right.th 363 theListOfSecondaries = right.theListOfSecondaries; 450 theSizeOftheListOfSecondaries = right.th 364 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries; 451 theNumberOfSecondaries = right.th 365 theNumberOfSecondaries = right.theNumberOfSecondaries; 452 theStatusChange = right.th 366 theStatusChange = right.theStatusChange; 453 theMomentumChange = right.th 367 theMomentumChange = right.theMomentumChange; 454 thePolarizationChange = right.th 368 thePolarizationChange = right.thePolarizationChange; 455 thePositionChange = right.th 369 thePositionChange = right.thePositionChange; 456 theTimeChange = right.th 370 theTimeChange = right.theTimeChange; 457 theEnergyChange = right.th 371 theEnergyChange = right.theEnergyChange; 458 theTrueStepLength = right.th 372 theTrueStepLength = right.theTrueStepLength; 459 theLocalEnergyDeposit = right.th 373 theLocalEnergyDeposit = right.theLocalEnergyDeposit; 460 theSteppingControlFlag = right.th 374 theSteppingControlFlag = right.theSteppingControlFlag; 461 theWeightChange = right.th 375 theWeightChange = right.theWeightChange; 462 } 376 } 463 return *this; 377 return *this; 464 } 378 } 465 379 466 Diagnostic: 380 Diagnostic: 467 ---------- 381 ---------- 468 Bug detected. 382 Bug detected. 469 383 470 Action: 384 Action: 471 ------- 385 ------- 472 Insert the call 386 Insert the call 473 G4VParticleChange::operator=(right); 387 G4VParticleChange::operator=(right); 474 388 475 Status: 389 Status: 476 ------- 390 ------- 477 Done, tested, system-tested on HP-aCC with e 391 Done, tested, system-tested on HP-aCC with exemple N05. 478 392 479 Modified files: 393 Modified files: 480 --------------- 394 --------------- 481 G4FastStep.cc 395 G4FastStep.cc 482 396 483 6) Warning: 397 6) Warning: 484 ----------- 398 ----------- 485 include/G4FastStep.hh:59 399 include/G4FastStep.hh:59 486 Avoid data members in the public interface 400 Avoid data members in the public interface 487 Violation: Effective C++ item 20 401 Violation: Effective C++ item 20 488 Public data members for class G4FastStep: 402 Public data members for class G4FastStep: 489 debugFlag 403 debugFlag 490 404 491 405 492 offending code: 406 offending code: 493 --------------- 407 --------------- 494 public: 408 public: 495 ... 409 ... 496 G4bool debugFlag; 410 G4bool debugFlag; 497 411 498 Diagnostic: 412 Diagnostic: 499 ---------- 413 ---------- 500 Historical usage. 414 Historical usage. 501 415 502 Action: 416 Action: 503 ------- 417 ------- 504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 418 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file. 505 419 506 Modified files: 420 Modified files: 507 --------------- 421 --------------- 508 G4FastStep.hh, G4FastStep.cc 422 G4FastStep.hh, G4FastStep.cc 509 423 510 Status: 424 Status: 511 ------- 425 ------- 512 Done, tested, system-tested on HP-aCC with e 426 Done, tested, system-tested on HP-aCC with exemple N05. 513 427 514 7) Warning: 428 7) Warning: 515 ----------- 429 ----------- 516 include/G4FastStep.hh:59 430 include/G4FastStep.hh:59 517 If a class has virtual functions it shall 431 If a class has virtual functions it shall have a virtual destructor 518 Severe violation: Universal Coding Standar 432 Severe violation: Universal Coding Standards item 17 519 class G4FastStep has virtual functions wit 433 class G4FastStep has virtual functions without a virtual destructor. 520 434 521 435 522 offending code: 436 offending code: 523 --------------- 437 --------------- 524 ~G4FastStep(); 438 ~G4FastStep(); 525 439 526 Diagnostic: 440 Diagnostic: 527 ---------- 441 ---------- 528 Nobody should inherites from G4FastStep BUT 442 Nobody should inherites from G4FastStep BUT virtual added. 529 443 530 Action: 444 Action: 531 ------- 445 ------- 532 virtual ~G4FastStep(); 446 virtual ~G4FastStep(); 533 447 534 Modified files: 448 Modified files: 535 --------------- 449 --------------- 536 G4FastStep.hh 450 G4FastStep.hh 537 451 538 Status: 452 Status: 539 ------- 453 ------- 540 Done, tested, system-tested on HP-aCC with e 454 Done, tested, system-tested on HP-aCC with exemple N05. 541 455 542 456 543 December 7, 1998 M. Verderi 457 December 7, 1998 M. Verderi 544 G4FastSimulationManagerProcess class: 458 G4FastSimulationManagerProcess class: 545 Fixes made for ghost navigation with 459 Fixes made for ghost navigation with 546 mag-field: 460 mag-field: 547 LocateGlobalPointAndUpdateTouchable is 461 LocateGlobalPointAndUpdateTouchable is 548 always used (in not the Locate...Setup 462 always used (in not the Locate...Setup 549 method) 463 method) 550 In PostStepDoIt: correction of position and 464 In PostStepDoIt: correction of position and 551 direction of the track are made when << 465 direction of the track are made when 552 possible in case of mag-field. 466 possible in case of mag-field. 553 This correction comes from the fact that a 467 This correction comes from the fact that a 554 small discrepancy appears on those quantitie 468 small discrepancy appears on those quantities 555 because of the numerical integration along 469 because of the numerical integration along 556 the field on the track path: the G4FSMP 470 the field on the track path: the G4FSMP 557 proposes a curve-length, the transportation 471 proposes a curve-length, the transportation 558 moves the track along this curve, however 472 moves the track along this curve, however 559 the end point position and direction are 473 the end point position and direction are 560 slightly different from those expected by 474 slightly different from those expected by 561 the G4FSMP when it proposed the length. 475 the G4FSMP when it proposed the length. 562 476 563 November 20,1998 M. Verderi 477 November 20,1998 M. Verderi 564 G4FastStep class: 478 G4FastStep class: 565 Remove track/G4BiasingTag.hh dependancy (ob 479 Remove track/G4BiasingTag.hh dependancy (obsolete). 566 Adapted to new shceme of Event Biasing mech 480 Adapted to new shceme of Event Biasing mechanism, 567 consistently with track-00-04-01 tag. 481 consistently with track-00-04-01 tag. 568 482 569 November 11,1998 M. Verderi 483 November 11,1998 M. Verderi 570 Merge of param-00-03-02 & param-00-03-02a i 484 Merge of param-00-03-02 & param-00-03-02a into 571 param-00-03-04a (hopefully...) 485 param-00-03-04a (hopefully...) 572 The point is the chnage of signature in the 486 The point is the chnage of signature in the 573 LocateGlobalPointAndSetup(..) of the G4Navi 487 LocateGlobalPointAndSetup(..) of the G4Navigator making use now 574 of the track direction. The G4FastSimulatio 488 of the track direction. The G4FastSimulationManagerProcess is 575 changed accordingly: 489 changed accordingly: 576 fGhostNavigator.LocateGlobalPointAndSetup(t 490 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true); 577 491 578 492 579 November 6, 1998 M. Verderi 493 November 6, 1998 M. Verderi 580 - Extension of the G4FastStep to allow the 494 - Extension of the G4FastStep to allow the biasing technic. 581 Changes are made in: 495 Changes are made in: 582 - G4FastStep.hh/.icc: 496 - G4FastStep.hh/.icc: 583 new member G4BiasingTa 497 new member G4BiasingTag fBiasTag; 584 new method SetPrimaryT 498 new method SetPrimaryTrackFinalBiasingTag 585 ( G4BiasingTag 499 ( G4BiasingTag aTag ); 586 - G4FastStep.cc: 500 - G4FastStep.cc: 587 Initialize(); 501 Initialize(); 588 operator=; << 502 operator=; 589 UpdateForPostStep(); 503 UpdateForPostStep(); 590 UpdateForAtRest(); << 504 UpdateForAtRest(); 591 505 592 October 26, 1998 P.Mora de Freitas 506 October 26, 1998 P.Mora de Freitas 593 - G4FastSimulationManagerProcess and G4Fast 507 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal 594 with at rest parameterisations also when 508 with at rest parameterisations also when using parallel geometry. 595 509 596 October 8, 1998 P.Mora de Freitas 510 October 8, 1998 P.Mora de Freitas 597 - The G4VFastSimulationModel::IsApplicable( 511 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual 598 methode. 512 methode. 599 - G4FastSimulationManager optimisation: 513 - G4FastSimulationManager optimisation: 600 - New G4ParticleDefinition* fLastCrossedP 514 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps 601 the last particle type with touched the 515 the last particle type with touched the envelope; 602 - New G4RWTPtrOrderedVector<G4VFastSimula 516 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList 603 data member, keeps the model list of th << 517 data member, keeps the model list of the applicable models for 604 the actual fLastCrossedParticle particl 518 the actual fLastCrossedParticle particle type; 605 - Changes in the PostStepGetFastSimulatio << 519 - Changes in the PostStepGetFastSimulationManagerTrigger() and 606 AtRestGetFastSimulationManagerTrigger() << 520 AtRestGetFastSimulationManagerTrigger()methodes to update the 607 fApplicableModelList when needed (fLast 521 fApplicableModelList when needed (fLastCrossedParticle != 608 the actual tracked particle); 522 the actual tracked particle); 609 - Changes in the << 523 - Changes in the 610 G4FastSimulationManager() (Constructor) 524 G4FastSimulationManager() (Constructor) 611 ActivateFastSimulationModel(), 525 ActivateFastSimulationModel(), 612 InActivateFastSimulationModel(), 526 InActivateFastSimulationModel(), 613 AtRestGetFastSimulationManagerTrigger(), 527 AtRestGetFastSimulationManagerTrigger(), 614 AddFastSimulationModel(), 528 AddFastSimulationModel(), 615 RemoveFastSimulationModel() 529 RemoveFastSimulationModel() 616 methodes to set the fLastCrossedParticle to 530 methodes to set the fLastCrossedParticle to NULL, forcing the 617 fApplicableModelList to be rebuilt. 531 fApplicableModelList to be rebuilt. 618 532 619 September 22, 1998 P.Mora de Freitas 533 September 22, 1998 P.Mora de Freitas 620 Fixed bug in parallel navigation. << 534 Fixed bug in parallel navigation. 621 File touched: G4FastSimulationManagerProces 535 File touched: G4FastSimulationManagerProcess.cc 622 Tested on HP-aCC. 536 Tested on HP-aCC. 623 537 624 September 17, 1998 P.Mora de Freitas 538 September 17, 1998 P.Mora de Freitas 625 G4FastSimulationManager::RemoveFastSimulati 539 G4FastSimulationManager::RemoveFastSimulationModel() updated to look 626 for also in the fInactivatedModels list. 540 for also in the fInactivatedModels list. 627 541 628 Tested on HP-aCC. 542 Tested on HP-aCC. 629 543 630 September 16, 1998 P.Mora de Freitas 544 September 16, 1998 P.Mora de Freitas 631 New /param/ control commands: 545 New /param/ control commands: 632 546 633 /param/ActivateModel <ModelName> 547 /param/ActivateModel <ModelName> 634 /param/InActivateModel <ModelName> 548 /param/InActivateModel <ModelName> 635 549 636 Activate or inactivate a given parameterisat 550 Activate or inactivate a given parameterisation model. 637 551 638 Tested on HP-aCC. 552 Tested on HP-aCC. 639 553 640 August 21, 1998 P.Mora de Freitas 554 August 21, 1998 P.Mora de Freitas 641 G4FastSimulationManagerProcess's G4ProcessTy 555 G4FastSimulationManagerProcess's G4ProcessType set to 642 fParameterisation, accordingly with procman-00 556 fParameterisation, accordingly with procman-00-02-03. 643 557 644 Tested on HP-aCC. 558 Tested on HP-aCC. 645 559 646 August 12, 1998 P.Mora de Freitas 560 August 12, 1998 P.Mora de Freitas 647 Improved the "close parameterisation control << 561 Improved the "close parameterisation control" to 648 562 649 1) avoid the close looping when unnecessary 563 1) avoid the close looping when unnecessary (mostly cases); 650 2) force re-close when necessary (insert/rem 564 2) force re-close when necessary (insert/remove ghosts). 651 565 652 Changes: 566 Changes: 653 567 654 1) the G4GlobalFastSimulationManager::fClose << 568 1) the G4GlobalFastSimulationManager::fClosed is now initialised 655 to true by the G4GlobalFastSimulationMana 569 to true by the G4GlobalFastSimulationManager constructor; 656 570 657 2) new method << 571 2) new method 658 572 659 void << 573 void 660 G4GlobalFastSimulationManager::FastSimula 574 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed(); 661 575 662 called by the AddGhostPlacement and Remov << 576 called by the AddGhostPlacement and RemoveGhostPlacement 663 G4FastSimulationManager methods to set fa 577 G4FastSimulationManager methods to set false the fClosed flag; 664 578 665 3) changes in the G4GlobalFastSimulationMana 579 3) changes in the G4GlobalFastSimulationManager::Notify method 666 to deal with these changes. 580 to deal with these changes. 667 581 668 Tested on HP-aCC. 582 Tested on HP-aCC. 669 583 670 August 11, 1998 P.Mora de Freitas 584 August 11, 1998 P.Mora de Freitas 671 Fix to the G4FastStep::KillPrimaryTrack() me 585 Fix to the G4FastStep::KillPrimaryTrack() method to drop the 672 nonsense line 586 nonsense line 673 587 674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 588 SetMomentumChange(0.,0.,0.) ; /* necessary ? */ 675 589 676 Tested on HP-aCC. 590 Tested on HP-aCC. 677 (Thanks to Willy Langeveld) 591 (Thanks to Willy Langeveld) 678 592 679 593 680 August 10, 1998 P.Mora de Freitas 594 August 10, 1998 P.Mora de Freitas 681 Fix to the SetPrimaryTrackFinalKineticEnergy 595 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method 682 from the G4FastStep class the SetMomentumChang 596 from the G4FastStep class the SetMomentumChange() call to insure that 683 the new momentum direction is a unit vector (a << 597 the new momentum direction is a unit vector (as asked by the 684 G4DynamicParticle::SetMomentumDirection method 598 G4DynamicParticle::SetMomentumDirection method). 685 599 686 Touched files: G4FastStep.hh (improved comme 600 Touched files: G4FastStep.hh (improved comments) 687 G4FastStep.cc (fixed) 601 G4FastStep.cc (fixed) 688 602 689 Tested on HP-aCC. 603 Tested on HP-aCC. 690 (Thanks to Willy Langeveld) 604 (Thanks to Willy Langeveld) 691 605 692 August 7, 1998 P.Mora de Freitas 606 August 7, 1998 P.Mora de Freitas 693 New /param/ commands directory with the comm 607 New /param/ commands directory with the commands: 694 608 695 /param/listEnvelopes [ParticleName] 609 /param/listEnvelopes [ParticleName] 696 610 697 - List all the envelope names for a given pa 611 - List all the envelope names for a given particle 698 (or for all particles if without parameter 612 (or for all particles if without parameters). 699 613 700 /param/listModels [EnvelopeName] 614 /param/listModels [EnvelopeName] 701 615 702 - List all the Model names for a given envel 616 - List all the Model names for a given envelope 703 (or for all envelopes if without parameter 617 (or for all envelopes if without parameters). 704 618 705 /param/listIsApplicable [ModelName] 619 /param/listIsApplicable [ModelName] 706 620 707 - List all the particle names a given model 621 - List all the particle names a given model is applicable 708 (or for all models if without parameters). 622 (or for all models if without parameters). 709 623 710 624 711 August 7, 1998 P.Mora de Freitas 625 August 7, 1998 P.Mora de Freitas 712 History file Created. 626 History file Created.