Geant4 Cross Reference |
1 # Category param History << 1 $Id: History,v 1.39 2008/03/26 14:54:40 gcosmo Exp $ >> 2 ------------------------------------------------------------------- 2 3 3 See `CONTRIBUTING.rst` for details of **requir << 4 ========================================================= 4 which **must** added in reverse chronological << 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP 5 It must **not** be used as a substitute for wr << 6 ========================================================= >> 7 >> 8 Category History file >> 9 --------------------- >> 10 This file should be used by G4 developers and category coordinators >> 11 to briefly summarize all major modifications introduced in the code >> 12 and keep track of all category-tags. >> 13 It DOES NOT substitute the CVS log-message one should put at every >> 14 committal in the CVS repository ! >> 15 >> 16 ---------------------------------------------------------- >> 17 * Reverse chronological order (last date on top), please * >> 18 ---------------------------------------------------------- 6 19 7 ---------------------------------------------- << 20 March 13 2008, G. Cosmo (param-V09-01-00) 8 << 9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) << 10 - In G4GlobalFastSimulationManager: << 11 use G4ThreadLocalSingleton to avoid undelete << 12 << 13 ## 2023-10-18 Ben Morgan (param-V11-01-03) << 14 - Apply standard and extended clang-tidy fixes << 15 - Mark empty/obsolete functions as deprecated << 16 << 17 ## 2023-10-16 Ben Morgan (param-V11-01-02) << 18 - Apply standard clang-format-ing. << 19 - Normal order accessors and docstrings. << 20 << 21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) << 22 - In G4FastTrack, removed references to G4Touc << 23 which is now deprecated. << 24 << 25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 << 26 - Added missing virtual destructor to G4VFastS << 27 << 28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) << 29 - Fixed compilation warnings for implicit type << 30 << 31 ## 2022-10-27 Makoto Asai (param-V11-00-03) << 32 - G4FastSimHitMaker - making compatible to com << 33 << 34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 << 35 - G4FastStep - delete copy constructor and ope << 36 << 37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) << 38 - Adding the 'flush' method to the fast simula << 39 This method allows to process the input buff << 40 the end of the G4 event. It is used when par << 41 The 'flash' is triggered inside the event lo << 42 The fast simulation model may add secondarie << 43 by Geant4. << 44 << 45 ## 2021-12-10 Ben Morgan (param-V11-00-00) << 46 - Change to new Markdown History format << 47 << 48 --- << 49 << 50 # History entries prior to 11.0 << 51 << 52 April 16, 2021 Ben Morgan (param-V10-07-00) << 53 - Migrate build to modular CMake API << 54 << 55 October 5, 2020, A. Zaborowska (param-V10-06-0 << 56 - Introduce general facilities based on GFlash << 57 to facilitate multiple hit (energy & positio << 58 from fast simulation models. << 59 << 60 September 9, 2020, G. Cosmo (param-V10-06-02) << 61 - Fixed minor Coverity defect for uninitialise << 62 << 63 April 21, 2020, A. Zaborowska (param-V10-06-01 << 64 - Sanity check for root logical volumes for re << 65 UI command /param/showSetup works also if no << 66 << 67 March 26, 2020, I. Semeniouk (param-V10-06-00) << 68 - G4FastSimulationHelper : merge ActivateFastS << 69 - G4FastSimulationManager.hh, G4VFastSimulatio << 70 redefinition of G4Envelope type << 71 << 72 October 30, 2019, A. Zaborowska (param-v10-05- << 73 - Register G4FastSimulationManagerProcess with << 74 G4FastSimulationManagerHelper to ensure it i << 75 invoked for a given step (ExclusivelyForced) << 76 StronglyForced processes will be considered. << 77 << 78 December 19, 2017, G. Cosmo (param-V10-04-00) << 79 - Fixed self-consistency in G4FastSimulationVe << 80 Thanks to Raphael Isemann for reporting this << 81 << 82 November 03, 2016, M. Verderi (param-V10-02-01 << 83 - New G4FastSimulationManagerHelper utility fo << 84 adding G4FastSimulationManagerProcess to a << 85 process manager. << 86 << 87 November 02, 2016, M. Verderi (param-V10-02-00 << 88 - fix various Coverity defects. << 89 << 90 March 27, 2013, M. Verderi (param-V09-06-00) << 91 - remove unused field 'fOnBoundary' in G4FastS << 92 as this was causing a warning from clang. << 93 << 94 July 10, 2012, G. Cosmo (param-V09-05-00) << 95 - Explicitly use inclusion of headers for syst << 96 constants, in plan to remove implicit inclus << 97 << 98 September 30, 2011, M. Verderi (param-V09-04-0 << 99 - Added missing new header file (G4FastSimulat << 100 sources.cmake. << 101 << 102 September 30, 2011, M. Verderi (param-V09-04-0 << 103 - Migration to new G4Exception scheme. << 104 - what is V09-04-01 tag ? << 105 << 106 February 11, 2011, M. Verderi (param-V09-04-00 << 107 - Implementation of method << 108 void ProposePrimaryTrackFinalKineticEnergy ( << 109 was missing : modified file G4FastStep.icc << 110 << 111 March 13, 2008, G. Cosmo (param-V09-01-00) << 112 - Cleared compilation warnings in G4FastSimula 21 - Cleared compilation warnings in G4FastSimulationManagerProcess and 113 G4FastSimulationMessenger on gcc-4.3.0 for a 22 G4FastSimulationMessenger on gcc-4.3.0 for ambiguous use of 114 parentheses in nested if-else statements. 23 parentheses in nested if-else statements. 115 24 116 November 30, 2007, M. Verderi << 25 November 30 2007, M. Verderi 117 - Add Along methods to G4FSMP process 26 - Add Along methods to G4FSMP process 118 - tag as param-V09-00-01 27 - tag as param-V09-00-01 119 28 120 November 30, 2007, M. Verderi << 29 November 30 2007, M. Verderi 121 - minor corrections to G4FastSimulationManager << 30 - minor corrections to G4FastSimulationManagerProcess.hh/.cc : 122 * add call fPathFinder->prepareNewrack(...) 31 * add call fPathFinder->prepareNewrack(...) 123 * deactivate ghost navigator in EndOfTracki 32 * deactivate ghost navigator in EndOfTracking(..) method 124 - tag as param-V09-00-00 33 - tag as param-V09-00-00 125 34 126 May 18, 2007, M. Verderi 35 May 18, 2007, M. Verderi 127 - tag as param-V08-03-00 36 - tag as param-V08-03-00 128 37 129 May 11, 2007, M. Verderi 38 May 11, 2007, M. Verderi 130 - remove include/G4FastSimulationManagerProces 39 - remove include/G4FastSimulationManagerProcess81.hh 131 include/G4FlavoredParallelWorld.hh 40 include/G4FlavoredParallelWorld.hh 132 include/G4GFSManager81.hh 41 include/G4GFSManager81.hh 133 src/G4FastSimulationManagerProcess81. 42 src/G4FastSimulationManagerProcess81.cc 134 src/G4GFSManager81.cc 43 src/G4GFSManager81.cc 135 44 136 45 137 November 10, 2006, M. Verderi - param-V08-01-0 46 November 10, 2006, M. Verderi - param-V08-01-00 138 - Limited number of warning messages printed b 47 - Limited number of warning messages printed by the 139 G4GlobalFastSimulationManager. 48 G4GlobalFastSimulationManager. 140 - Renamed G4FastSimulationManagerProcess_forCo 49 - Renamed G4FastSimulationManagerProcess_forCoupledTransportation with 141 G4FastSimulationManagerProcess81. 50 G4FastSimulationManagerProcess81. 142 In addition, this class can now handle the c 51 In addition, this class can now handle the case of Navigator index=0, 143 i.e., the navigator for tracking, regardless 52 i.e., the navigator for tracking, regardless the G4Transportation or 144 G4CoupledTransportation is used. (For other 53 G4CoupledTransportation is used. (For other navigators, there is 145 of course no choice, and G4CoupledTransporta 54 of course no choice, and G4CoupledTransportation is necessary.) 146 55 147 November 3, 2006 M. Verderi 56 November 3, 2006 M. Verderi 148 - Introduced G4FastSimulationManagerProcess_fo 57 - Introduced G4FastSimulationManagerProcess_forCoupledTransportation class for 149 handling fast simulation in new parallel geo 58 handling fast simulation in new parallel geometry scheme. This requires 150 the G4CoupledTransportation to be active. 59 the G4CoupledTransportation to be active. 151 - Introduced G4GFSManager81 class that gathers 60 - Introduced G4GFSManager81 class that gathers the future code to become the 152 default at next major release in the G4Globa 61 default at next major release in the G4GlobalFastSimulationManager class. 153 - G4FastSimulationManager: adapted to new sche 62 - G4FastSimulationManager: adapted to new scheme. Still has old code for 154 backward compatibilty. 63 backward compatibilty. 155 - G4FastSimulationManagerProcess: mostly the s 64 - G4FastSimulationManagerProcess: mostly the same, apart from a small bug fix. 156 - G4FastSimulationMessenger: new command creat 65 - G4FastSimulationMessenger: new command created "/param/showSetup", useful 157 to show the fast simulation setup (region, m 66 to show the fast simulation setup (region, models, processes, etc...) 158 It is only valid for geometry closed state. 67 It is only valid for geometry closed state. Desirable to have interactive 159 command in the run manager for this. 68 command in the run manager for this. 160 69 161 November 25, 2005, M.Verderi - param-V07-01-0 70 November 25, 2005, M.Verderi - param-V07-01-04 162 - put back Makoto's change: StartTracking(G4Tr 71 - put back Makoto's change: StartTracking(G4Track*) 163 72 164 November 25, 2005, M Verderi - param-V07-01-03 73 November 25, 2005, M Verderi - param-V07-01-03 165 - Make ghost functionnality available with G4R 74 - Make ghost functionnality available with G4Region 166 - ** Note ** Change back StartTracking(G4Track 75 - ** Note ** Change back StartTracking(G4Track*) -> StartTracking() in G4FSMP 167 StartTracking(G4Track*) was intro 76 StartTracking(G4Track*) was introduced in param-V07-01-02 168 because (I guess) of procman-V07-01-01 77 because (I guess) of procman-V07-01-01 169 This is to make param-V07-01-03 compatible w 78 This is to make param-V07-01-03 compatible with geant4-07-01-ref-05 170 79 171 November 21, 2005 M.Asai - param-V07-01-02 80 November 21, 2005 M.Asai - param-V07-01-02 172 - Fix warning message. 81 - Fix warning message. 173 82 174 November 02, 2005 G.Cosmo - param-V07-01-01 83 November 02, 2005 G.Cosmo - param-V07-01-01 175 - Corrected setting of envelope volumes and so 84 - Corrected setting of envelope volumes and solid in G4FastTrack. 176 - Migrated old scheme for G4Exception and some 85 - Migrated old scheme for G4Exception and some cosmetics... 177 86 178 October 28, 2005 M.Asai - param-V07-01-00 87 October 28, 2005 M.Asai - param-V07-01-00 179 - Working tag for merging "envelope" to G4Regi 88 - Working tag for merging "envelope" to G4Region. 180 89 181 December 07, 2004 G. Cosmo - param-V06-02-01 90 December 07, 2004 G. Cosmo - param-V06-02-01 182 - Implemented migration to <cmath>. 91 - Implemented migration to <cmath>. 183 92 184 November 26, 2004 M. Verderi - param-V06-02-00 93 November 26, 2004 M. Verderi - param-V06-02-00 185 - Implemented migration to new G4VParticleChan 94 - Implemented migration to new G4VParticleChange interfaces. 186 95 187 December 12, 2003 G. Cosmo - param-V06-00-00 96 December 12, 2003 G. Cosmo - param-V06-00-00 188 - G4FastSimulationVector.icc: use std_pvector: 97 - G4FastSimulationVector.icc: use std_pvector:: scope for calls to 189 base class. Fixes compilation problem on Int 98 base class. Fixes compilation problem on Intel-icc compiler. 190 99 191 November 10, 2003 G. Cosmo - param-V05-02-01 100 November 10, 2003 G. Cosmo - param-V05-02-01 192 - G4FastTrack: use G4Navigator::CreateTouchabl 101 - G4FastTrack: use G4Navigator::CreateTouchableHistoryHandle() instead of 193 CreateTouchableHistory() in method FRecordsA 102 CreateTouchableHistory() in method FRecordsAffineTransformation(). 194 103 195 October 4, 2003 G. Cosmo - param-V05-02-00 104 October 4, 2003 G. Cosmo - param-V05-02-00 196 - Modified GNUmakefile: 105 - Modified GNUmakefile: 197 o added dependency to new module "geometry/n 106 o added dependency to new module "geometry/navigation". 198 - Coworks with "geometry-V05-02-00" and "digit 107 - Coworks with "geometry-V05-02-00" and "digits_hits-V05-02-00". 199 108 200 May 21, 2003 G. Cosmo - param-V05-01-00 109 May 21, 2003 G. Cosmo - param-V05-01-00 201 o Fixed pedantic warnings on Linux-g++ 110 o Fixed pedantic warnings on Linux-g++. 202 o Call base class in copy-constructor 111 o Call base class in copy-constructor of G4FastStep. 203 112 204 Nov 20, 2002 G. Cosmo - param-V04-01-02 113 Nov 20, 2002 G. Cosmo - param-V04-01-02 205 o Patched access to public static data in G4 114 o Patched access to public static data in G4FastStep.cc 206 and G4GlobalFastSimulationManager.cc to al 115 and G4GlobalFastSimulationManager.cc to allow porting on 207 Windows DLLs. 116 Windows DLLs. 208 117 209 Nov 15, 2002 S. Sadilov - param-V04-01-01 118 Nov 15, 2002 S. Sadilov - param-V04-01-01 210 o Fixed compilation problems on Windows in 119 o Fixed compilation problems on Windows in 211 G4FastSimulationManager.cc and G4GlobalFas 120 G4FastSimulationManager.cc and G4GlobalFastSimulationManager.cc 212 121 213 Nov 02, 2002 M. Verderi - param-V04-01-00 122 Nov 02, 2002 M. Verderi - param-V04-01-00 214 o Add method to retrieve G4VFastSimulationMo 123 o Add method to retrieve G4VFastSimulationModel by name. 215 The user's method is in G4GlobalFastSimula 124 The user's method is in G4GlobalFastSimulationManager: 216 125 217 GetFastSimulationModel(); 126 GetFastSimulationModel(); 218 127 219 it is accompagnied by same methods name in 128 it is accompagnied by same methods name in 220 G4FastSimulationManager class. 129 G4FastSimulationManager class. 221 130 222 o Add "test" directory, used to test above f 131 o Add "test" directory, used to test above feature. 223 132 224 Oct 26, 2001 M. Verderi - param-V03-02-00 133 Oct 26, 2001 M. Verderi - param-V03-02-00 225 Fixes to clear warnings produced with gcc-2. 134 Fixes to clear warnings produced with gcc-2.95.2: 226 - loop index, where comparison with method " 135 - loop index, where comparison with method "size()" of 227 G4std::vector<T>, changed: int -> size_t << 136 G4std::vector<T>, changed: int -> size_t 228 - change "if ( a=b ) {..}" by "if ( (a=b) ) 137 - change "if ( a=b ) {..}" by "if ( (a=b) ) {...}" 229 this makes the compiler sure you want to mak 138 this makes the compiler sure you want to make an 230 assignement in the "if" condition 139 assignement in the "if" condition 231 - re-order initialisations of a few variable 140 - re-order initialisations of a few variables in constructors 232 to match the declaration order. 141 to match the declaration order. 233 Some warnings still exist, but regard the G4 142 Some warnings still exist, but regard the G4Propagator of geometry. 234 143 235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 144 Apr 3, 2001 J. Apostolakis - param-V03-00-00 236 - Modified G4FastSimulationManagerProcess call 145 - Modified G4FastSimulationManagerProcess call to PropagatorInField ComputeStep 237 to use new interface with G4FieldTrack (in 146 to use new interface with G4FieldTrack (in place of now obsolete interface.) 238 147 239 Nov 14, 2000 G. Cosmo - param-V02-00-01 148 Nov 14, 2000 G. Cosmo - param-V02-00-01 240 - Moved specific parameterisation models to th 149 - Moved specific parameterisation models to the new top category 241 "parameterisations". Moved files: 150 "parameterisations". Moved files: 242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm 151 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRmodel[.hh.cc], 243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster 152 G4IrregularXrayTRmodel[.hh.cc], G4PAIclusterModel[.hh.cc], 244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr 153 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXrayTRmodel[.hh.cc], 245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode 154 G4RegularXrayTRmodel[.hh.cc], G4VClusterModel[.hh.cc], 246 G4VXrayTRmodel[.hh.cc]. 155 G4VXrayTRmodel[.hh.cc]. 247 - Cleaned-up GNUmakefile of non necessary depe 156 - Cleaned-up GNUmakefile of non necessary dependencies. 248 157 249 Aug 03, 2000 G. Cosmo - param-V02-00-00r 158 Aug 03, 2000 G. Cosmo - param-V02-00-00r 250 - Changed RandGauss to G4RandGauss in G4Irregu 159 - Changed RandGauss to G4RandGauss in G4IrregularXrayTRmodel.cc and 251 G4VXrayTRmodel.cc to fix events' reproducibi 160 G4VXrayTRmodel.cc to fix events' reproducibility problem. 252 - G4VXrayTRmodel.cc: fix to class destructor ( 161 - G4VXrayTRmodel.cc: fix to class destructor (V.Grichine) 253 162 254 Jun 15, 2000 G. Cosmo - param-V01-01-04 163 Jun 15, 2000 G. Cosmo - param-V01-01-04 255 - The tag coworks with global-V01-01-04 and ma 164 - The tag coworks with global-V01-01-04 and materials-V01-01-00: 256 o Fixed usage of G4complex type for ISO and 165 o Fixed usage of G4complex type for ISO and non-ISO compilers. 257 Affected files: G4FoamXrayTRmodel.cc, G4Ga 166 Affected files: G4FoamXrayTRmodel.cc, G4GamDistrXrayTRmodel.cc, G4PlateIrrGasXrayTRmodel.cc 258 and G4RegularXrayTRmodel.c 167 and G4RegularXrayTRmodel.cc. 259 In case of G4complex types passed to mathe 168 In case of G4complex types passed to mathematical functions, use G4std:: prefix. 260 o Fixed usage of G4Integrator class, now cha 169 o Fixed usage of G4Integrator class, now changed to templated to allow porting of the 261 code on SUN-CC compiler which does not imp 170 code on SUN-CC compiler which does not implement templated member functions. 262 Affected files: G4VXrayTRmodel[.hh.cc] 171 Affected files: G4VXrayTRmodel[.hh.cc] 263 172 264 Jun 6, 2000 M. Verderi & P. Mora de Freitas 173 Jun 6, 2000 M. Verderi & P. Mora de Freitas 265 - fixed compilation errors with HP-aCC for the 174 - fixed compilation errors with HP-aCC for the files G4RegularXrayTRmodel.cc, 266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod 175 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmodel.cc. 267 176 268 May 30, 2000 M. Verderi & P. Mora de Freitas 177 May 30, 2000 M. Verderi & P. Mora de Freitas 269 178 270 - parameterisation category is now RW free. 179 - parameterisation category is now RW free. 271 180 272 September 16, 1999 M. Verderi & P. Mora de Fre 181 September 16, 1999 M. Verderi & P. Mora de Freitas 273 182 274 - Fixed bug in G4FastStep::CheckIt() method. 183 - Fixed bug in G4FastStep::CheckIt() method. 275 184 276 April 19, 1999 M. Verderi & P. Mora de Freitas 185 April 19, 1999 M. Verderi & P. Mora de Freitas 277 186 278 Changes in G4FastStep to co-work with track-01 187 Changes in G4FastStep to co-work with track-01-00-04: 279 188 280 1) The method void CheckIt(const G4Track&) bec << 189 1) The method void CheckIt(const G4Track&) becomes 281 G4bool CheckIt(const G4Track&); 190 G4bool CheckIt(const G4Track&); 282 2) The FAST_STEP_DEBUG compiling option disapp 191 2) The FAST_STEP_DEBUG compiling option disappears; 283 3) Call to CheckIt controled by the G4VParticl 192 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute. 284 193 285 Miscellaneous: the declaration "G4double mass 194 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh 286 corrected to G4double mass =...". 195 corrected to G4double mass =...". 287 196 288 April 15, 1999 M. Verderi & P. Mora de Freitas 197 April 15, 1999 M. Verderi & P. Mora de Freitas 289 198 290 Tasks to decouple visualization from processes 199 Tasks to decouple visualization from processes/parameterisation: 291 200 292 1) G4GlobalFastSimulationManager now inherites 201 1) G4GlobalFastSimulationManager now inherites from the intercoms/ 293 G4VGlobalFastSimulationManager to allow visual << 202 G4VGlobalFastSimulationManager to allow visualisation to get a 294 concrete instance pointer to the G4GlobalFastS 203 concrete instance pointer to the G4GlobalFastSimulationManager, 295 if any. 204 if any. 296 205 297 2) G4FlavoredParallelWorld now inherites from 206 2) G4FlavoredParallelWorld now inherites from the intercoms/ 298 G4VFlavoredParallelWorld, a pure virtual abstr 207 G4VFlavoredParallelWorld, a pure virtual abstract class to interface 299 parameterisation with visualization. 208 parameterisation with visualization. 300 209 301 Co-works with intercoms-01-00-01 tag 210 Co-works with intercoms-01-00-01 tag 302 211 303 Modified files: 212 Modified files: 304 --------------- 213 --------------- 305 G4FlavoredParallelWorld.hh 214 G4FlavoredParallelWorld.hh 306 G4GlobalFastSimulationManager.hh 215 G4GlobalFastSimulationManager.hh 307 G4GlobalFastSimulationManager.cc 216 G4GlobalFastSimulationManager.cc 308 217 309 Done, tested, system-tested on HP-aCC with exe 218 Done, tested, system-tested on HP-aCC with exemple N05. 310 219 311 April 14, 1999 M. Verderi & P. Mora de Freitas 220 April 14, 1999 M. Verderi & P. Mora de Freitas 312 221 313 Several consolidation tasks (thanks to G. Cosm 222 Several consolidation tasks (thanks to G. Cosmo): 314 223 315 1) Warning: << 224 1) Warning: 316 ----------- 225 ----------- 317 226 318 Pointers usage 227 Pointers usage 319 228 320 - Setting pointers to 0 after delete: 229 - Setting pointers to 0 after delete: 321 230 322 delete pA; 231 delete pA; 323 pA = 0; 232 pA = 0; 324 233 325 - Avoid to use "NULL". 234 - Avoid to use "NULL". 326 235 327 Modified files: 236 Modified files: 328 --------------- 237 --------------- 329 G4FastSimulationManager.hh 238 G4FastSimulationManager.hh 330 G4FastTrack.hh 239 G4FastTrack.hh 331 G4FlavoredParallelWorld.hh 240 G4FlavoredParallelWorld.hh 332 G4FastSimulationManager.cc 241 G4FastSimulationManager.cc 333 G4FastSimulationMessenger.cc 242 G4FastSimulationMessenger.cc 334 G4FastSimulationManagerProcess.cc 243 G4FastSimulationManagerProcess.cc 335 G4FastTrack.cc 244 G4FastTrack.cc 336 G4GlobalFastSimulationManager.cc 245 G4GlobalFastSimulationManager.cc 337 G4VFastSimulationModel.cc 246 G4VFastSimulationModel.cc 338 247 339 Status: << 248 Status: 340 ------- 249 ------- 341 Done, tested, system-tested on HP-aCC with exe 250 Done, tested, system-tested on HP-aCC with exemple N05. 342 251 343 2) Warning: 252 2) Warning: 344 ----------- 253 ----------- 345 include/G4FastSimulationManager.hh:163 254 include/G4FastSimulationManager.hh:163 346 Public member functions shall always retur 255 Public member functions shall always return const handles to member data 347 Severe violation: Universal Coding Standar 256 Severe violation: Universal Coding Standards item 18 348 257 349 offending code: 258 offending code: 350 --------------- 259 --------------- 351 inline G4VParticleChange* G4FastSimulationMana 260 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange() 352 { 261 { 353 return &fFastStep; 262 return &fFastStep; 354 } 263 } 355 264 356 Diagnostic: 265 Diagnostic: 357 ---------- 266 ---------- 358 267 359 Called by the G4FastSimulationManagerProcess << 268 Called by the G4FastSimulationManagerProcess to return it in the 360 PostStepDoIt call. << 269 PostStepDoIt call. 361 270 362 Action: 271 Action: 363 ------- 272 ------- 364 The G4FastSimulationManager::GettheParticleCha 273 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any 365 more. The G4VParticleChange* is now returned d 274 more. The G4VParticleChange* is now returned directly when invoking the 366 G4FastSimulationManager::InvokePostStepDoIt() 275 G4FastSimulationManager::InvokePostStepDoIt() and 367 G4FastSimulationManager::InvokeAtRestDoIt() me 276 G4FastSimulationManager::InvokeAtRestDoIt() methodes. 368 277 369 Modified files: 278 Modified files: 370 --------------- 279 --------------- 371 G4FastSimulationManager.hh 280 G4FastSimulationManager.hh 372 G4FastSimulationManager.cc 281 G4FastSimulationManager.cc 373 G4FastSimulationManagerProcess.cc 282 G4FastSimulationManagerProcess.cc 374 283 375 Status: << 284 Status: 376 ------- 285 ------- 377 Done, tested, system-tested on HP-aCC with exe 286 Done, tested, system-tested on HP-aCC with exemple N05. 378 287 379 3) Warning: 288 3) Warning: 380 ----------- 289 ----------- 381 include/G4FastSimulationManagerProcess.hh:52 290 include/G4FastSimulationManagerProcess.hh:52 382 If a class has virtual functions it shall 291 If a class has virtual functions it shall have a virtual destructor 383 Severe violation: Universal Coding Standar 292 Severe violation: Universal Coding Standards item 17 384 class G4FastSimulationManagerProcess has v 293 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor. 385 294 386 offending code: 295 offending code: 387 --------------- 296 --------------- 388 ~G4FastSimulationManagerProcess(); 297 ~G4FastSimulationManagerProcess(); 389 298 390 Diagnostic: 299 Diagnostic: 391 ---------- 300 ---------- 392 Nobody should inherites from G4FastSimulatio << 301 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual 393 is added. 302 is added. 394 303 395 Action: 304 Action: 396 ------- 305 ------- 397 virtual ~G4FastSimulationManagerProcess(); 306 virtual ~G4FastSimulationManagerProcess(); 398 307 399 Modified files: 308 Modified files: 400 --------------- 309 --------------- 401 G4FastSimulationManagerProcess.hh 310 G4FastSimulationManagerProcess.hh 402 311 403 Status: << 312 Status: 404 ------- 313 ------- 405 Done. 314 Done. 406 315 407 4) Warning: 316 4) Warning: 408 ----------- 317 ----------- 409 include/G4FastSimulationMessenger.hh:36 318 include/G4FastSimulationMessenger.hh:36 410 If a class has virtual functions it shall 319 If a class has virtual functions it shall have a virtual destructor 411 Severe violation: Universal Coding Standar 320 Severe violation: Universal Coding Standards item 17 412 class G4FastSimulationMessenger has virtua 321 class G4FastSimulationMessenger has virtual functions without a virtual destructor. 413 322 414 323 415 offending code: 324 offending code: 416 --------------- 325 --------------- 417 ~G4FastSimulationMessenger(); 326 ~G4FastSimulationMessenger(); 418 327 419 Diagnostic: 328 Diagnostic: 420 ---------- 329 ---------- 421 Nobody should inherites from G4FastSimulatio << 330 Nobody should inherites from G4FastSimulationMessenger BUT for virtual 422 is added. 331 is added. 423 332 424 Action: 333 Action: 425 ------- 334 ------- 426 virtual ~G4FastSimulationMessenger(); 335 virtual ~G4FastSimulationMessenger(); 427 336 428 Modified files: 337 Modified files: 429 --------------- 338 --------------- 430 G4FastSimulationMessenger.hh 339 G4FastSimulationMessenger.hh 431 340 432 Status: << 341 Status: 433 ------- 342 ------- 434 Done. 343 Done. 435 344 436 5) Warning: 345 5) Warning: 437 ----------- 346 ----------- 438 include/G4FastStep.hh:224 347 include/G4FastStep.hh:224 439 Operator= should call base class operator= 348 Operator= should call base class operator= 440 Possible severe violation: Effective C++ i 349 Possible severe violation: Effective C++ item 16 441 operator= in class G4FastStep, should call 350 operator= in class G4FastStep, should call operator= in base class G4VParticleChange 442 351 443 offending code: 352 offending code: 444 --------------- 353 --------------- 445 G4FastStep & G4FastStep::operator=(const G4Fas 354 G4FastStep & G4FastStep::operator=(const G4FastStep &right) 446 { 355 { 447 if (this != &right) 356 if (this != &right) 448 { 357 { 449 theListOfSecondaries = right.th 358 theListOfSecondaries = right.theListOfSecondaries; 450 theSizeOftheListOfSecondaries = right.th 359 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries; 451 theNumberOfSecondaries = right.th 360 theNumberOfSecondaries = right.theNumberOfSecondaries; 452 theStatusChange = right.th 361 theStatusChange = right.theStatusChange; 453 theMomentumChange = right.th 362 theMomentumChange = right.theMomentumChange; 454 thePolarizationChange = right.th 363 thePolarizationChange = right.thePolarizationChange; 455 thePositionChange = right.th 364 thePositionChange = right.thePositionChange; 456 theTimeChange = right.th 365 theTimeChange = right.theTimeChange; 457 theEnergyChange = right.th 366 theEnergyChange = right.theEnergyChange; 458 theTrueStepLength = right.th 367 theTrueStepLength = right.theTrueStepLength; 459 theLocalEnergyDeposit = right.th 368 theLocalEnergyDeposit = right.theLocalEnergyDeposit; 460 theSteppingControlFlag = right.th 369 theSteppingControlFlag = right.theSteppingControlFlag; 461 theWeightChange = right.th 370 theWeightChange = right.theWeightChange; 462 } 371 } 463 return *this; 372 return *this; 464 } 373 } 465 374 466 Diagnostic: 375 Diagnostic: 467 ---------- 376 ---------- 468 Bug detected. 377 Bug detected. 469 378 470 Action: 379 Action: 471 ------- 380 ------- 472 Insert the call 381 Insert the call 473 G4VParticleChange::operator=(right); 382 G4VParticleChange::operator=(right); 474 383 475 Status: 384 Status: 476 ------- 385 ------- 477 Done, tested, system-tested on HP-aCC with e 386 Done, tested, system-tested on HP-aCC with exemple N05. 478 387 479 Modified files: 388 Modified files: 480 --------------- 389 --------------- 481 G4FastStep.cc 390 G4FastStep.cc 482 391 483 6) Warning: 392 6) Warning: 484 ----------- 393 ----------- 485 include/G4FastStep.hh:59 394 include/G4FastStep.hh:59 486 Avoid data members in the public interface 395 Avoid data members in the public interface 487 Violation: Effective C++ item 20 396 Violation: Effective C++ item 20 488 Public data members for class G4FastStep: 397 Public data members for class G4FastStep: 489 debugFlag 398 debugFlag 490 399 491 400 492 offending code: 401 offending code: 493 --------------- 402 --------------- 494 public: 403 public: 495 ... 404 ... 496 G4bool debugFlag; 405 G4bool debugFlag; 497 406 498 Diagnostic: 407 Diagnostic: 499 ---------- 408 ---------- 500 Historical usage. 409 Historical usage. 501 410 502 Action: 411 Action: 503 ------- 412 ------- 504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 413 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file. 505 414 506 Modified files: 415 Modified files: 507 --------------- 416 --------------- 508 G4FastStep.hh, G4FastStep.cc 417 G4FastStep.hh, G4FastStep.cc 509 418 510 Status: 419 Status: 511 ------- 420 ------- 512 Done, tested, system-tested on HP-aCC with e 421 Done, tested, system-tested on HP-aCC with exemple N05. 513 422 514 7) Warning: 423 7) Warning: 515 ----------- 424 ----------- 516 include/G4FastStep.hh:59 425 include/G4FastStep.hh:59 517 If a class has virtual functions it shall 426 If a class has virtual functions it shall have a virtual destructor 518 Severe violation: Universal Coding Standar 427 Severe violation: Universal Coding Standards item 17 519 class G4FastStep has virtual functions wit 428 class G4FastStep has virtual functions without a virtual destructor. 520 429 521 430 522 offending code: 431 offending code: 523 --------------- 432 --------------- 524 ~G4FastStep(); 433 ~G4FastStep(); 525 434 526 Diagnostic: 435 Diagnostic: 527 ---------- 436 ---------- 528 Nobody should inherites from G4FastStep BUT 437 Nobody should inherites from G4FastStep BUT virtual added. 529 438 530 Action: 439 Action: 531 ------- 440 ------- 532 virtual ~G4FastStep(); 441 virtual ~G4FastStep(); 533 442 534 Modified files: 443 Modified files: 535 --------------- 444 --------------- 536 G4FastStep.hh 445 G4FastStep.hh 537 446 538 Status: 447 Status: 539 ------- 448 ------- 540 Done, tested, system-tested on HP-aCC with e 449 Done, tested, system-tested on HP-aCC with exemple N05. 541 450 542 451 543 December 7, 1998 M. Verderi 452 December 7, 1998 M. Verderi 544 G4FastSimulationManagerProcess class: 453 G4FastSimulationManagerProcess class: 545 Fixes made for ghost navigation with 454 Fixes made for ghost navigation with 546 mag-field: 455 mag-field: 547 LocateGlobalPointAndUpdateTouchable is 456 LocateGlobalPointAndUpdateTouchable is 548 always used (in not the Locate...Setup 457 always used (in not the Locate...Setup 549 method) 458 method) 550 In PostStepDoIt: correction of position and 459 In PostStepDoIt: correction of position and 551 direction of the track are made when << 460 direction of the track are made when 552 possible in case of mag-field. 461 possible in case of mag-field. 553 This correction comes from the fact that a 462 This correction comes from the fact that a 554 small discrepancy appears on those quantitie 463 small discrepancy appears on those quantities 555 because of the numerical integration along 464 because of the numerical integration along 556 the field on the track path: the G4FSMP 465 the field on the track path: the G4FSMP 557 proposes a curve-length, the transportation 466 proposes a curve-length, the transportation 558 moves the track along this curve, however 467 moves the track along this curve, however 559 the end point position and direction are 468 the end point position and direction are 560 slightly different from those expected by 469 slightly different from those expected by 561 the G4FSMP when it proposed the length. 470 the G4FSMP when it proposed the length. 562 471 563 November 20,1998 M. Verderi 472 November 20,1998 M. Verderi 564 G4FastStep class: 473 G4FastStep class: 565 Remove track/G4BiasingTag.hh dependancy (ob 474 Remove track/G4BiasingTag.hh dependancy (obsolete). 566 Adapted to new shceme of Event Biasing mech 475 Adapted to new shceme of Event Biasing mechanism, 567 consistently with track-00-04-01 tag. 476 consistently with track-00-04-01 tag. 568 477 569 November 11,1998 M. Verderi 478 November 11,1998 M. Verderi 570 Merge of param-00-03-02 & param-00-03-02a i 479 Merge of param-00-03-02 & param-00-03-02a into 571 param-00-03-04a (hopefully...) 480 param-00-03-04a (hopefully...) 572 The point is the chnage of signature in the 481 The point is the chnage of signature in the 573 LocateGlobalPointAndSetup(..) of the G4Navi 482 LocateGlobalPointAndSetup(..) of the G4Navigator making use now 574 of the track direction. The G4FastSimulatio 483 of the track direction. The G4FastSimulationManagerProcess is 575 changed accordingly: 484 changed accordingly: 576 fGhostNavigator.LocateGlobalPointAndSetup(t 485 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true); 577 486 578 487 579 November 6, 1998 M. Verderi 488 November 6, 1998 M. Verderi 580 - Extension of the G4FastStep to allow the 489 - Extension of the G4FastStep to allow the biasing technic. 581 Changes are made in: 490 Changes are made in: 582 - G4FastStep.hh/.icc: 491 - G4FastStep.hh/.icc: 583 new member G4BiasingTa 492 new member G4BiasingTag fBiasTag; 584 new method SetPrimaryT 493 new method SetPrimaryTrackFinalBiasingTag 585 ( G4BiasingTag 494 ( G4BiasingTag aTag ); 586 - G4FastStep.cc: 495 - G4FastStep.cc: 587 Initialize(); 496 Initialize(); 588 operator=; << 497 operator=; 589 UpdateForPostStep(); 498 UpdateForPostStep(); 590 UpdateForAtRest(); << 499 UpdateForAtRest(); 591 500 592 October 26, 1998 P.Mora de Freitas 501 October 26, 1998 P.Mora de Freitas 593 - G4FastSimulationManagerProcess and G4Fast 502 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal 594 with at rest parameterisations also when 503 with at rest parameterisations also when using parallel geometry. 595 504 596 October 8, 1998 P.Mora de Freitas 505 October 8, 1998 P.Mora de Freitas 597 - The G4VFastSimulationModel::IsApplicable( 506 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual 598 methode. 507 methode. 599 - G4FastSimulationManager optimisation: 508 - G4FastSimulationManager optimisation: 600 - New G4ParticleDefinition* fLastCrossedP 509 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps 601 the last particle type with touched the 510 the last particle type with touched the envelope; 602 - New G4RWTPtrOrderedVector<G4VFastSimula 511 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList 603 data member, keeps the model list of th << 512 data member, keeps the model list of the applicable models for 604 the actual fLastCrossedParticle particl 513 the actual fLastCrossedParticle particle type; 605 - Changes in the PostStepGetFastSimulatio << 514 - Changes in the PostStepGetFastSimulationManagerTrigger() and 606 AtRestGetFastSimulationManagerTrigger() << 515 AtRestGetFastSimulationManagerTrigger()methodes to update the 607 fApplicableModelList when needed (fLast 516 fApplicableModelList when needed (fLastCrossedParticle != 608 the actual tracked particle); 517 the actual tracked particle); 609 - Changes in the << 518 - Changes in the 610 G4FastSimulationManager() (Constructor) 519 G4FastSimulationManager() (Constructor) 611 ActivateFastSimulationModel(), 520 ActivateFastSimulationModel(), 612 InActivateFastSimulationModel(), 521 InActivateFastSimulationModel(), 613 AtRestGetFastSimulationManagerTrigger(), 522 AtRestGetFastSimulationManagerTrigger(), 614 AddFastSimulationModel(), 523 AddFastSimulationModel(), 615 RemoveFastSimulationModel() 524 RemoveFastSimulationModel() 616 methodes to set the fLastCrossedParticle to 525 methodes to set the fLastCrossedParticle to NULL, forcing the 617 fApplicableModelList to be rebuilt. 526 fApplicableModelList to be rebuilt. 618 527 619 September 22, 1998 P.Mora de Freitas 528 September 22, 1998 P.Mora de Freitas 620 Fixed bug in parallel navigation. << 529 Fixed bug in parallel navigation. 621 File touched: G4FastSimulationManagerProces 530 File touched: G4FastSimulationManagerProcess.cc 622 Tested on HP-aCC. 531 Tested on HP-aCC. 623 532 624 September 17, 1998 P.Mora de Freitas 533 September 17, 1998 P.Mora de Freitas 625 G4FastSimulationManager::RemoveFastSimulati 534 G4FastSimulationManager::RemoveFastSimulationModel() updated to look 626 for also in the fInactivatedModels list. 535 for also in the fInactivatedModels list. 627 536 628 Tested on HP-aCC. 537 Tested on HP-aCC. 629 538 630 September 16, 1998 P.Mora de Freitas 539 September 16, 1998 P.Mora de Freitas 631 New /param/ control commands: 540 New /param/ control commands: 632 541 633 /param/ActivateModel <ModelName> 542 /param/ActivateModel <ModelName> 634 /param/InActivateModel <ModelName> 543 /param/InActivateModel <ModelName> 635 544 636 Activate or inactivate a given parameterisat 545 Activate or inactivate a given parameterisation model. 637 546 638 Tested on HP-aCC. 547 Tested on HP-aCC. 639 548 640 August 21, 1998 P.Mora de Freitas 549 August 21, 1998 P.Mora de Freitas 641 G4FastSimulationManagerProcess's G4ProcessTy 550 G4FastSimulationManagerProcess's G4ProcessType set to 642 fParameterisation, accordingly with procman-00 551 fParameterisation, accordingly with procman-00-02-03. 643 552 644 Tested on HP-aCC. 553 Tested on HP-aCC. 645 554 646 August 12, 1998 P.Mora de Freitas 555 August 12, 1998 P.Mora de Freitas 647 Improved the "close parameterisation control << 556 Improved the "close parameterisation control" to 648 557 649 1) avoid the close looping when unnecessary 558 1) avoid the close looping when unnecessary (mostly cases); 650 2) force re-close when necessary (insert/rem 559 2) force re-close when necessary (insert/remove ghosts). 651 560 652 Changes: 561 Changes: 653 562 654 1) the G4GlobalFastSimulationManager::fClose << 563 1) the G4GlobalFastSimulationManager::fClosed is now initialised 655 to true by the G4GlobalFastSimulationMana 564 to true by the G4GlobalFastSimulationManager constructor; 656 565 657 2) new method << 566 2) new method 658 567 659 void << 568 void 660 G4GlobalFastSimulationManager::FastSimula 569 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed(); 661 570 662 called by the AddGhostPlacement and Remov << 571 called by the AddGhostPlacement and RemoveGhostPlacement 663 G4FastSimulationManager methods to set fa 572 G4FastSimulationManager methods to set false the fClosed flag; 664 573 665 3) changes in the G4GlobalFastSimulationMana 574 3) changes in the G4GlobalFastSimulationManager::Notify method 666 to deal with these changes. 575 to deal with these changes. 667 576 668 Tested on HP-aCC. 577 Tested on HP-aCC. 669 578 670 August 11, 1998 P.Mora de Freitas 579 August 11, 1998 P.Mora de Freitas 671 Fix to the G4FastStep::KillPrimaryTrack() me 580 Fix to the G4FastStep::KillPrimaryTrack() method to drop the 672 nonsense line 581 nonsense line 673 582 674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 583 SetMomentumChange(0.,0.,0.) ; /* necessary ? */ 675 584 676 Tested on HP-aCC. 585 Tested on HP-aCC. 677 (Thanks to Willy Langeveld) 586 (Thanks to Willy Langeveld) 678 587 679 588 680 August 10, 1998 P.Mora de Freitas 589 August 10, 1998 P.Mora de Freitas 681 Fix to the SetPrimaryTrackFinalKineticEnergy 590 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method 682 from the G4FastStep class the SetMomentumChang 591 from the G4FastStep class the SetMomentumChange() call to insure that 683 the new momentum direction is a unit vector (a << 592 the new momentum direction is a unit vector (as asked by the 684 G4DynamicParticle::SetMomentumDirection method 593 G4DynamicParticle::SetMomentumDirection method). 685 594 686 Touched files: G4FastStep.hh (improved comme 595 Touched files: G4FastStep.hh (improved comments) 687 G4FastStep.cc (fixed) 596 G4FastStep.cc (fixed) 688 597 689 Tested on HP-aCC. 598 Tested on HP-aCC. 690 (Thanks to Willy Langeveld) 599 (Thanks to Willy Langeveld) 691 600 692 August 7, 1998 P.Mora de Freitas 601 August 7, 1998 P.Mora de Freitas 693 New /param/ commands directory with the comm 602 New /param/ commands directory with the commands: 694 603 695 /param/listEnvelopes [ParticleName] 604 /param/listEnvelopes [ParticleName] 696 605 697 - List all the envelope names for a given pa 606 - List all the envelope names for a given particle 698 (or for all particles if without parameter 607 (or for all particles if without parameters). 699 608 700 /param/listModels [EnvelopeName] 609 /param/listModels [EnvelopeName] 701 610 702 - List all the Model names for a given envel 611 - List all the Model names for a given envelope 703 (or for all envelopes if without parameter 612 (or for all envelopes if without parameters). 704 613 705 /param/listIsApplicable [ModelName] 614 /param/listIsApplicable [ModelName] 706 615 707 - List all the particle names a given model 616 - List all the particle names a given model is applicable 708 (or for all models if without parameters). 617 (or for all models if without parameters). 709 618 710 619 711 August 7, 1998 P.Mora de Freitas 620 August 7, 1998 P.Mora de Freitas 712 History file Created. 621 History file Created.