Geant4 Cross Reference |
1 # Category param History << 1 $Id: History,v 1.37.2.2 2008/04/23 08:51:21 gcosmo Exp $ >> 2 ------------------------------------------------------------------- 2 3 3 See `CONTRIBUTING.rst` for details of **requir << 4 ========================================================= 4 which **must** added in reverse chronological << 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP 5 It must **not** be used as a substitute for wr << 6 ========================================================= >> 7 >> 8 Category History file >> 9 --------------------- >> 10 This file should be used by G4 developers and category coordinators >> 11 to briefly summarize all major modifications introduced in the code >> 12 and keep track of all category-tags. >> 13 It DOES NOT substitute the CVS log-message one should put at every >> 14 committal in the CVS repository ! >> 15 >> 16 ---------------------------------------------------------- >> 17 * Reverse chronological order (last date on top), please * >> 18 ---------------------------------------------------------- >> 19 >> 20 April 23 2008, G. Cosmo (param-V09-00-02) >> 21 - Tag for release 9.1.p02. >> 22 >> 23 March 13 2008, G. Cosmo (param-V09-01-00) >> 24 - Cleared compilation warnings in G4GeometryManager on gcc-4.3.0 for >> 25 ambiguous use of parentheses in nested if-else statements. 6 26 7 ---------------------------------------------- << 27 November 30 2007, M. Verderi 8 << 9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) << 10 - In G4GlobalFastSimulationManager: << 11 use G4ThreadLocalSingleton to avoid undelete << 12 << 13 ## 2023-10-18 Ben Morgan (param-V11-01-03) << 14 - Apply standard and extended clang-tidy fixes << 15 - Mark empty/obsolete functions as deprecated << 16 << 17 ## 2023-10-16 Ben Morgan (param-V11-01-02) << 18 - Apply standard clang-format-ing. << 19 - Normal order accessors and docstrings. << 20 << 21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) << 22 - In G4FastTrack, removed references to G4Touc << 23 which is now deprecated. << 24 << 25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 << 26 - Added missing virtual destructor to G4VFastS << 27 << 28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) << 29 - Fixed compilation warnings for implicit type << 30 << 31 ## 2022-10-27 Makoto Asai (param-V11-00-03) << 32 - G4FastSimHitMaker - making compatible to com << 33 << 34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 << 35 - G4FastStep - delete copy constructor and ope << 36 << 37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) << 38 - Adding the 'flush' method to the fast simula << 39 This method allows to process the input buff << 40 the end of the G4 event. It is used when par << 41 The 'flash' is triggered inside the event lo << 42 The fast simulation model may add secondarie << 43 by Geant4. << 44 << 45 ## 2021-12-10 Ben Morgan (param-V11-00-00) << 46 - Change to new Markdown History format << 47 << 48 --- << 49 << 50 # History entries prior to 11.0 << 51 << 52 April 16, 2021 Ben Morgan (param-V10-07-00) << 53 - Migrate build to modular CMake API << 54 << 55 October 5, 2020, A. Zaborowska (param-V10-06-0 << 56 - Introduce general facilities based on GFlash << 57 to facilitate multiple hit (energy & positio << 58 from fast simulation models. << 59 << 60 September 9, 2020, G. Cosmo (param-V10-06-02) << 61 - Fixed minor Coverity defect for uninitialise << 62 << 63 April 21, 2020, A. Zaborowska (param-V10-06-01 << 64 - Sanity check for root logical volumes for re << 65 UI command /param/showSetup works also if no << 66 << 67 March 26, 2020, I. Semeniouk (param-V10-06-00) << 68 - G4FastSimulationHelper : merge ActivateFastS << 69 - G4FastSimulationManager.hh, G4VFastSimulatio << 70 redefinition of G4Envelope type << 71 << 72 October 30, 2019, A. Zaborowska (param-v10-05- << 73 - Register G4FastSimulationManagerProcess with << 74 G4FastSimulationManagerHelper to ensure it i << 75 invoked for a given step (ExclusivelyForced) << 76 StronglyForced processes will be considered. << 77 << 78 December 19, 2017, G. Cosmo (param-V10-04-00) << 79 - Fixed self-consistency in G4FastSimulationVe << 80 Thanks to Raphael Isemann for reporting this << 81 << 82 November 03, 2016, M. Verderi (param-V10-02-01 << 83 - New G4FastSimulationManagerHelper utility fo << 84 adding G4FastSimulationManagerProcess to a << 85 process manager. << 86 << 87 November 02, 2016, M. Verderi (param-V10-02-00 << 88 - fix various Coverity defects. << 89 << 90 March 27, 2013, M. Verderi (param-V09-06-00) << 91 - remove unused field 'fOnBoundary' in G4FastS << 92 as this was causing a warning from clang. << 93 << 94 July 10, 2012, G. Cosmo (param-V09-05-00) << 95 - Explicitly use inclusion of headers for syst << 96 constants, in plan to remove implicit inclus << 97 << 98 September 30, 2011, M. Verderi (param-V09-04-0 << 99 - Added missing new header file (G4FastSimulat << 100 sources.cmake. << 101 << 102 September 30, 2011, M. Verderi (param-V09-04-0 << 103 - Migration to new G4Exception scheme. << 104 - what is V09-04-01 tag ? << 105 << 106 February 11, 2011, M. Verderi (param-V09-04-00 << 107 - Implementation of method << 108 void ProposePrimaryTrackFinalKineticEnergy ( << 109 was missing : modified file G4FastStep.icc << 110 << 111 March 13, 2008, G. Cosmo (param-V09-01-00) << 112 - Cleared compilation warnings in G4FastSimula << 113 G4FastSimulationMessenger on gcc-4.3.0 for a << 114 parentheses in nested if-else statements. << 115 << 116 November 30, 2007, M. Verderi << 117 - Add Along methods to G4FSMP process 28 - Add Along methods to G4FSMP process 118 - tag as param-V09-00-01 29 - tag as param-V09-00-01 119 30 120 November 30, 2007, M. Verderi << 31 November 30 2007, M. Verderi 121 - minor corrections to G4FastSimulationManager << 32 - minor corrections to G4FastSimulationManagerProcess.hh/.cc : 122 * add call fPathFinder->prepareNewrack(...) 33 * add call fPathFinder->prepareNewrack(...) 123 * deactivate ghost navigator in EndOfTracki 34 * deactivate ghost navigator in EndOfTracking(..) method 124 - tag as param-V09-00-00 35 - tag as param-V09-00-00 125 36 126 May 18, 2007, M. Verderi 37 May 18, 2007, M. Verderi 127 - tag as param-V08-03-00 38 - tag as param-V08-03-00 128 39 129 May 11, 2007, M. Verderi 40 May 11, 2007, M. Verderi 130 - remove include/G4FastSimulationManagerProces 41 - remove include/G4FastSimulationManagerProcess81.hh 131 include/G4FlavoredParallelWorld.hh 42 include/G4FlavoredParallelWorld.hh 132 include/G4GFSManager81.hh 43 include/G4GFSManager81.hh 133 src/G4FastSimulationManagerProcess81. 44 src/G4FastSimulationManagerProcess81.cc 134 src/G4GFSManager81.cc 45 src/G4GFSManager81.cc 135 46 136 47 137 November 10, 2006, M. Verderi - param-V08-01-0 48 November 10, 2006, M. Verderi - param-V08-01-00 138 - Limited number of warning messages printed b 49 - Limited number of warning messages printed by the 139 G4GlobalFastSimulationManager. 50 G4GlobalFastSimulationManager. 140 - Renamed G4FastSimulationManagerProcess_forCo 51 - Renamed G4FastSimulationManagerProcess_forCoupledTransportation with 141 G4FastSimulationManagerProcess81. 52 G4FastSimulationManagerProcess81. 142 In addition, this class can now handle the c 53 In addition, this class can now handle the case of Navigator index=0, 143 i.e., the navigator for tracking, regardless 54 i.e., the navigator for tracking, regardless the G4Transportation or 144 G4CoupledTransportation is used. (For other 55 G4CoupledTransportation is used. (For other navigators, there is 145 of course no choice, and G4CoupledTransporta 56 of course no choice, and G4CoupledTransportation is necessary.) 146 57 147 November 3, 2006 M. Verderi 58 November 3, 2006 M. Verderi 148 - Introduced G4FastSimulationManagerProcess_fo 59 - Introduced G4FastSimulationManagerProcess_forCoupledTransportation class for 149 handling fast simulation in new parallel geo 60 handling fast simulation in new parallel geometry scheme. This requires 150 the G4CoupledTransportation to be active. 61 the G4CoupledTransportation to be active. 151 - Introduced G4GFSManager81 class that gathers 62 - Introduced G4GFSManager81 class that gathers the future code to become the 152 default at next major release in the G4Globa 63 default at next major release in the G4GlobalFastSimulationManager class. 153 - G4FastSimulationManager: adapted to new sche 64 - G4FastSimulationManager: adapted to new scheme. Still has old code for 154 backward compatibilty. 65 backward compatibilty. 155 - G4FastSimulationManagerProcess: mostly the s 66 - G4FastSimulationManagerProcess: mostly the same, apart from a small bug fix. 156 - G4FastSimulationMessenger: new command creat 67 - G4FastSimulationMessenger: new command created "/param/showSetup", useful 157 to show the fast simulation setup (region, m 68 to show the fast simulation setup (region, models, processes, etc...) 158 It is only valid for geometry closed state. 69 It is only valid for geometry closed state. Desirable to have interactive 159 command in the run manager for this. 70 command in the run manager for this. 160 71 161 November 25, 2005, M.Verderi - param-V07-01-0 72 November 25, 2005, M.Verderi - param-V07-01-04 162 - put back Makoto's change: StartTracking(G4Tr 73 - put back Makoto's change: StartTracking(G4Track*) 163 74 164 November 25, 2005, M Verderi - param-V07-01-03 75 November 25, 2005, M Verderi - param-V07-01-03 165 - Make ghost functionnality available with G4R 76 - Make ghost functionnality available with G4Region 166 - ** Note ** Change back StartTracking(G4Track 77 - ** Note ** Change back StartTracking(G4Track*) -> StartTracking() in G4FSMP 167 StartTracking(G4Track*) was intro 78 StartTracking(G4Track*) was introduced in param-V07-01-02 168 because (I guess) of procman-V07-01-01 79 because (I guess) of procman-V07-01-01 169 This is to make param-V07-01-03 compatible w 80 This is to make param-V07-01-03 compatible with geant4-07-01-ref-05 170 81 171 November 21, 2005 M.Asai - param-V07-01-02 82 November 21, 2005 M.Asai - param-V07-01-02 172 - Fix warning message. 83 - Fix warning message. 173 84 174 November 02, 2005 G.Cosmo - param-V07-01-01 85 November 02, 2005 G.Cosmo - param-V07-01-01 175 - Corrected setting of envelope volumes and so 86 - Corrected setting of envelope volumes and solid in G4FastTrack. 176 - Migrated old scheme for G4Exception and some 87 - Migrated old scheme for G4Exception and some cosmetics... 177 88 178 October 28, 2005 M.Asai - param-V07-01-00 89 October 28, 2005 M.Asai - param-V07-01-00 179 - Working tag for merging "envelope" to G4Regi 90 - Working tag for merging "envelope" to G4Region. 180 91 181 December 07, 2004 G. Cosmo - param-V06-02-01 92 December 07, 2004 G. Cosmo - param-V06-02-01 182 - Implemented migration to <cmath>. 93 - Implemented migration to <cmath>. 183 94 184 November 26, 2004 M. Verderi - param-V06-02-00 95 November 26, 2004 M. Verderi - param-V06-02-00 185 - Implemented migration to new G4VParticleChan 96 - Implemented migration to new G4VParticleChange interfaces. 186 97 187 December 12, 2003 G. Cosmo - param-V06-00-00 98 December 12, 2003 G. Cosmo - param-V06-00-00 188 - G4FastSimulationVector.icc: use std_pvector: 99 - G4FastSimulationVector.icc: use std_pvector:: scope for calls to 189 base class. Fixes compilation problem on Int 100 base class. Fixes compilation problem on Intel-icc compiler. 190 101 191 November 10, 2003 G. Cosmo - param-V05-02-01 102 November 10, 2003 G. Cosmo - param-V05-02-01 192 - G4FastTrack: use G4Navigator::CreateTouchabl 103 - G4FastTrack: use G4Navigator::CreateTouchableHistoryHandle() instead of 193 CreateTouchableHistory() in method FRecordsA 104 CreateTouchableHistory() in method FRecordsAffineTransformation(). 194 105 195 October 4, 2003 G. Cosmo - param-V05-02-00 106 October 4, 2003 G. Cosmo - param-V05-02-00 196 - Modified GNUmakefile: 107 - Modified GNUmakefile: 197 o added dependency to new module "geometry/n 108 o added dependency to new module "geometry/navigation". 198 - Coworks with "geometry-V05-02-00" and "digit 109 - Coworks with "geometry-V05-02-00" and "digits_hits-V05-02-00". 199 110 200 May 21, 2003 G. Cosmo - param-V05-01-00 111 May 21, 2003 G. Cosmo - param-V05-01-00 201 o Fixed pedantic warnings on Linux-g++ 112 o Fixed pedantic warnings on Linux-g++. 202 o Call base class in copy-constructor 113 o Call base class in copy-constructor of G4FastStep. 203 114 204 Nov 20, 2002 G. Cosmo - param-V04-01-02 115 Nov 20, 2002 G. Cosmo - param-V04-01-02 205 o Patched access to public static data in G4 116 o Patched access to public static data in G4FastStep.cc 206 and G4GlobalFastSimulationManager.cc to al 117 and G4GlobalFastSimulationManager.cc to allow porting on 207 Windows DLLs. 118 Windows DLLs. 208 119 209 Nov 15, 2002 S. Sadilov - param-V04-01-01 120 Nov 15, 2002 S. Sadilov - param-V04-01-01 210 o Fixed compilation problems on Windows in 121 o Fixed compilation problems on Windows in 211 G4FastSimulationManager.cc and G4GlobalFas 122 G4FastSimulationManager.cc and G4GlobalFastSimulationManager.cc 212 123 213 Nov 02, 2002 M. Verderi - param-V04-01-00 124 Nov 02, 2002 M. Verderi - param-V04-01-00 214 o Add method to retrieve G4VFastSimulationMo 125 o Add method to retrieve G4VFastSimulationModel by name. 215 The user's method is in G4GlobalFastSimula 126 The user's method is in G4GlobalFastSimulationManager: 216 127 217 GetFastSimulationModel(); 128 GetFastSimulationModel(); 218 129 219 it is accompagnied by same methods name in 130 it is accompagnied by same methods name in 220 G4FastSimulationManager class. 131 G4FastSimulationManager class. 221 132 222 o Add "test" directory, used to test above f 133 o Add "test" directory, used to test above feature. 223 134 224 Oct 26, 2001 M. Verderi - param-V03-02-00 135 Oct 26, 2001 M. Verderi - param-V03-02-00 225 Fixes to clear warnings produced with gcc-2. 136 Fixes to clear warnings produced with gcc-2.95.2: 226 - loop index, where comparison with method " 137 - loop index, where comparison with method "size()" of 227 G4std::vector<T>, changed: int -> size_t << 138 G4std::vector<T>, changed: int -> size_t 228 - change "if ( a=b ) {..}" by "if ( (a=b) ) 139 - change "if ( a=b ) {..}" by "if ( (a=b) ) {...}" 229 this makes the compiler sure you want to mak 140 this makes the compiler sure you want to make an 230 assignement in the "if" condition 141 assignement in the "if" condition 231 - re-order initialisations of a few variable 142 - re-order initialisations of a few variables in constructors 232 to match the declaration order. 143 to match the declaration order. 233 Some warnings still exist, but regard the G4 144 Some warnings still exist, but regard the G4Propagator of geometry. 234 145 235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 146 Apr 3, 2001 J. Apostolakis - param-V03-00-00 236 - Modified G4FastSimulationManagerProcess call 147 - Modified G4FastSimulationManagerProcess call to PropagatorInField ComputeStep 237 to use new interface with G4FieldTrack (in 148 to use new interface with G4FieldTrack (in place of now obsolete interface.) 238 149 239 Nov 14, 2000 G. Cosmo - param-V02-00-01 150 Nov 14, 2000 G. Cosmo - param-V02-00-01 240 - Moved specific parameterisation models to th 151 - Moved specific parameterisation models to the new top category 241 "parameterisations". Moved files: 152 "parameterisations". Moved files: 242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm 153 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRmodel[.hh.cc], 243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster 154 G4IrregularXrayTRmodel[.hh.cc], G4PAIclusterModel[.hh.cc], 244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr 155 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXrayTRmodel[.hh.cc], 245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode 156 G4RegularXrayTRmodel[.hh.cc], G4VClusterModel[.hh.cc], 246 G4VXrayTRmodel[.hh.cc]. 157 G4VXrayTRmodel[.hh.cc]. 247 - Cleaned-up GNUmakefile of non necessary depe 158 - Cleaned-up GNUmakefile of non necessary dependencies. 248 159 249 Aug 03, 2000 G. Cosmo - param-V02-00-00r 160 Aug 03, 2000 G. Cosmo - param-V02-00-00r 250 - Changed RandGauss to G4RandGauss in G4Irregu 161 - Changed RandGauss to G4RandGauss in G4IrregularXrayTRmodel.cc and 251 G4VXrayTRmodel.cc to fix events' reproducibi 162 G4VXrayTRmodel.cc to fix events' reproducibility problem. 252 - G4VXrayTRmodel.cc: fix to class destructor ( 163 - G4VXrayTRmodel.cc: fix to class destructor (V.Grichine) 253 164 254 Jun 15, 2000 G. Cosmo - param-V01-01-04 165 Jun 15, 2000 G. Cosmo - param-V01-01-04 255 - The tag coworks with global-V01-01-04 and ma 166 - The tag coworks with global-V01-01-04 and materials-V01-01-00: 256 o Fixed usage of G4complex type for ISO and 167 o Fixed usage of G4complex type for ISO and non-ISO compilers. 257 Affected files: G4FoamXrayTRmodel.cc, G4Ga 168 Affected files: G4FoamXrayTRmodel.cc, G4GamDistrXrayTRmodel.cc, G4PlateIrrGasXrayTRmodel.cc 258 and G4RegularXrayTRmodel.c 169 and G4RegularXrayTRmodel.cc. 259 In case of G4complex types passed to mathe 170 In case of G4complex types passed to mathematical functions, use G4std:: prefix. 260 o Fixed usage of G4Integrator class, now cha 171 o Fixed usage of G4Integrator class, now changed to templated to allow porting of the 261 code on SUN-CC compiler which does not imp 172 code on SUN-CC compiler which does not implement templated member functions. 262 Affected files: G4VXrayTRmodel[.hh.cc] 173 Affected files: G4VXrayTRmodel[.hh.cc] 263 174 264 Jun 6, 2000 M. Verderi & P. Mora de Freitas 175 Jun 6, 2000 M. Verderi & P. Mora de Freitas 265 - fixed compilation errors with HP-aCC for the 176 - fixed compilation errors with HP-aCC for the files G4RegularXrayTRmodel.cc, 266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod 177 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmodel.cc. 267 178 268 May 30, 2000 M. Verderi & P. Mora de Freitas 179 May 30, 2000 M. Verderi & P. Mora de Freitas 269 180 270 - parameterisation category is now RW free. 181 - parameterisation category is now RW free. 271 182 272 September 16, 1999 M. Verderi & P. Mora de Fre 183 September 16, 1999 M. Verderi & P. Mora de Freitas 273 184 274 - Fixed bug in G4FastStep::CheckIt() method. 185 - Fixed bug in G4FastStep::CheckIt() method. 275 186 276 April 19, 1999 M. Verderi & P. Mora de Freitas 187 April 19, 1999 M. Verderi & P. Mora de Freitas 277 188 278 Changes in G4FastStep to co-work with track-01 189 Changes in G4FastStep to co-work with track-01-00-04: 279 190 280 1) The method void CheckIt(const G4Track&) bec << 191 1) The method void CheckIt(const G4Track&) becomes 281 G4bool CheckIt(const G4Track&); 192 G4bool CheckIt(const G4Track&); 282 2) The FAST_STEP_DEBUG compiling option disapp 193 2) The FAST_STEP_DEBUG compiling option disappears; 283 3) Call to CheckIt controled by the G4VParticl 194 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute. 284 195 285 Miscellaneous: the declaration "G4double mass 196 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh 286 corrected to G4double mass =...". 197 corrected to G4double mass =...". 287 198 288 April 15, 1999 M. Verderi & P. Mora de Freitas 199 April 15, 1999 M. Verderi & P. Mora de Freitas 289 200 290 Tasks to decouple visualization from processes 201 Tasks to decouple visualization from processes/parameterisation: 291 202 292 1) G4GlobalFastSimulationManager now inherites 203 1) G4GlobalFastSimulationManager now inherites from the intercoms/ 293 G4VGlobalFastSimulationManager to allow visual << 204 G4VGlobalFastSimulationManager to allow visualisation to get a 294 concrete instance pointer to the G4GlobalFastS 205 concrete instance pointer to the G4GlobalFastSimulationManager, 295 if any. 206 if any. 296 207 297 2) G4FlavoredParallelWorld now inherites from 208 2) G4FlavoredParallelWorld now inherites from the intercoms/ 298 G4VFlavoredParallelWorld, a pure virtual abstr 209 G4VFlavoredParallelWorld, a pure virtual abstract class to interface 299 parameterisation with visualization. 210 parameterisation with visualization. 300 211 301 Co-works with intercoms-01-00-01 tag 212 Co-works with intercoms-01-00-01 tag 302 213 303 Modified files: 214 Modified files: 304 --------------- 215 --------------- 305 G4FlavoredParallelWorld.hh 216 G4FlavoredParallelWorld.hh 306 G4GlobalFastSimulationManager.hh 217 G4GlobalFastSimulationManager.hh 307 G4GlobalFastSimulationManager.cc 218 G4GlobalFastSimulationManager.cc 308 219 309 Done, tested, system-tested on HP-aCC with exe 220 Done, tested, system-tested on HP-aCC with exemple N05. 310 221 311 April 14, 1999 M. Verderi & P. Mora de Freitas 222 April 14, 1999 M. Verderi & P. Mora de Freitas 312 223 313 Several consolidation tasks (thanks to G. Cosm 224 Several consolidation tasks (thanks to G. Cosmo): 314 225 315 1) Warning: << 226 1) Warning: 316 ----------- 227 ----------- 317 228 318 Pointers usage 229 Pointers usage 319 230 320 - Setting pointers to 0 after delete: 231 - Setting pointers to 0 after delete: 321 232 322 delete pA; 233 delete pA; 323 pA = 0; 234 pA = 0; 324 235 325 - Avoid to use "NULL". 236 - Avoid to use "NULL". 326 237 327 Modified files: 238 Modified files: 328 --------------- 239 --------------- 329 G4FastSimulationManager.hh 240 G4FastSimulationManager.hh 330 G4FastTrack.hh 241 G4FastTrack.hh 331 G4FlavoredParallelWorld.hh 242 G4FlavoredParallelWorld.hh 332 G4FastSimulationManager.cc 243 G4FastSimulationManager.cc 333 G4FastSimulationMessenger.cc 244 G4FastSimulationMessenger.cc 334 G4FastSimulationManagerProcess.cc 245 G4FastSimulationManagerProcess.cc 335 G4FastTrack.cc 246 G4FastTrack.cc 336 G4GlobalFastSimulationManager.cc 247 G4GlobalFastSimulationManager.cc 337 G4VFastSimulationModel.cc 248 G4VFastSimulationModel.cc 338 249 339 Status: << 250 Status: 340 ------- 251 ------- 341 Done, tested, system-tested on HP-aCC with exe 252 Done, tested, system-tested on HP-aCC with exemple N05. 342 253 343 2) Warning: 254 2) Warning: 344 ----------- 255 ----------- 345 include/G4FastSimulationManager.hh:163 256 include/G4FastSimulationManager.hh:163 346 Public member functions shall always retur 257 Public member functions shall always return const handles to member data 347 Severe violation: Universal Coding Standar 258 Severe violation: Universal Coding Standards item 18 348 259 349 offending code: 260 offending code: 350 --------------- 261 --------------- 351 inline G4VParticleChange* G4FastSimulationMana 262 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange() 352 { 263 { 353 return &fFastStep; 264 return &fFastStep; 354 } 265 } 355 266 356 Diagnostic: 267 Diagnostic: 357 ---------- 268 ---------- 358 269 359 Called by the G4FastSimulationManagerProcess << 270 Called by the G4FastSimulationManagerProcess to return it in the 360 PostStepDoIt call. << 271 PostStepDoIt call. 361 272 362 Action: 273 Action: 363 ------- 274 ------- 364 The G4FastSimulationManager::GettheParticleCha 275 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any 365 more. The G4VParticleChange* is now returned d 276 more. The G4VParticleChange* is now returned directly when invoking the 366 G4FastSimulationManager::InvokePostStepDoIt() 277 G4FastSimulationManager::InvokePostStepDoIt() and 367 G4FastSimulationManager::InvokeAtRestDoIt() me 278 G4FastSimulationManager::InvokeAtRestDoIt() methodes. 368 279 369 Modified files: 280 Modified files: 370 --------------- 281 --------------- 371 G4FastSimulationManager.hh 282 G4FastSimulationManager.hh 372 G4FastSimulationManager.cc 283 G4FastSimulationManager.cc 373 G4FastSimulationManagerProcess.cc 284 G4FastSimulationManagerProcess.cc 374 285 375 Status: << 286 Status: 376 ------- 287 ------- 377 Done, tested, system-tested on HP-aCC with exe 288 Done, tested, system-tested on HP-aCC with exemple N05. 378 289 379 3) Warning: 290 3) Warning: 380 ----------- 291 ----------- 381 include/G4FastSimulationManagerProcess.hh:52 292 include/G4FastSimulationManagerProcess.hh:52 382 If a class has virtual functions it shall 293 If a class has virtual functions it shall have a virtual destructor 383 Severe violation: Universal Coding Standar 294 Severe violation: Universal Coding Standards item 17 384 class G4FastSimulationManagerProcess has v 295 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor. 385 296 386 offending code: 297 offending code: 387 --------------- 298 --------------- 388 ~G4FastSimulationManagerProcess(); 299 ~G4FastSimulationManagerProcess(); 389 300 390 Diagnostic: 301 Diagnostic: 391 ---------- 302 ---------- 392 Nobody should inherites from G4FastSimulatio << 303 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual 393 is added. 304 is added. 394 305 395 Action: 306 Action: 396 ------- 307 ------- 397 virtual ~G4FastSimulationManagerProcess(); 308 virtual ~G4FastSimulationManagerProcess(); 398 309 399 Modified files: 310 Modified files: 400 --------------- 311 --------------- 401 G4FastSimulationManagerProcess.hh 312 G4FastSimulationManagerProcess.hh 402 313 403 Status: << 314 Status: 404 ------- 315 ------- 405 Done. 316 Done. 406 317 407 4) Warning: 318 4) Warning: 408 ----------- 319 ----------- 409 include/G4FastSimulationMessenger.hh:36 320 include/G4FastSimulationMessenger.hh:36 410 If a class has virtual functions it shall 321 If a class has virtual functions it shall have a virtual destructor 411 Severe violation: Universal Coding Standar 322 Severe violation: Universal Coding Standards item 17 412 class G4FastSimulationMessenger has virtua 323 class G4FastSimulationMessenger has virtual functions without a virtual destructor. 413 324 414 325 415 offending code: 326 offending code: 416 --------------- 327 --------------- 417 ~G4FastSimulationMessenger(); 328 ~G4FastSimulationMessenger(); 418 329 419 Diagnostic: 330 Diagnostic: 420 ---------- 331 ---------- 421 Nobody should inherites from G4FastSimulatio << 332 Nobody should inherites from G4FastSimulationMessenger BUT for virtual 422 is added. 333 is added. 423 334 424 Action: 335 Action: 425 ------- 336 ------- 426 virtual ~G4FastSimulationMessenger(); 337 virtual ~G4FastSimulationMessenger(); 427 338 428 Modified files: 339 Modified files: 429 --------------- 340 --------------- 430 G4FastSimulationMessenger.hh 341 G4FastSimulationMessenger.hh 431 342 432 Status: << 343 Status: 433 ------- 344 ------- 434 Done. 345 Done. 435 346 436 5) Warning: 347 5) Warning: 437 ----------- 348 ----------- 438 include/G4FastStep.hh:224 349 include/G4FastStep.hh:224 439 Operator= should call base class operator= 350 Operator= should call base class operator= 440 Possible severe violation: Effective C++ i 351 Possible severe violation: Effective C++ item 16 441 operator= in class G4FastStep, should call 352 operator= in class G4FastStep, should call operator= in base class G4VParticleChange 442 353 443 offending code: 354 offending code: 444 --------------- 355 --------------- 445 G4FastStep & G4FastStep::operator=(const G4Fas 356 G4FastStep & G4FastStep::operator=(const G4FastStep &right) 446 { 357 { 447 if (this != &right) 358 if (this != &right) 448 { 359 { 449 theListOfSecondaries = right.th 360 theListOfSecondaries = right.theListOfSecondaries; 450 theSizeOftheListOfSecondaries = right.th 361 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries; 451 theNumberOfSecondaries = right.th 362 theNumberOfSecondaries = right.theNumberOfSecondaries; 452 theStatusChange = right.th 363 theStatusChange = right.theStatusChange; 453 theMomentumChange = right.th 364 theMomentumChange = right.theMomentumChange; 454 thePolarizationChange = right.th 365 thePolarizationChange = right.thePolarizationChange; 455 thePositionChange = right.th 366 thePositionChange = right.thePositionChange; 456 theTimeChange = right.th 367 theTimeChange = right.theTimeChange; 457 theEnergyChange = right.th 368 theEnergyChange = right.theEnergyChange; 458 theTrueStepLength = right.th 369 theTrueStepLength = right.theTrueStepLength; 459 theLocalEnergyDeposit = right.th 370 theLocalEnergyDeposit = right.theLocalEnergyDeposit; 460 theSteppingControlFlag = right.th 371 theSteppingControlFlag = right.theSteppingControlFlag; 461 theWeightChange = right.th 372 theWeightChange = right.theWeightChange; 462 } 373 } 463 return *this; 374 return *this; 464 } 375 } 465 376 466 Diagnostic: 377 Diagnostic: 467 ---------- 378 ---------- 468 Bug detected. 379 Bug detected. 469 380 470 Action: 381 Action: 471 ------- 382 ------- 472 Insert the call 383 Insert the call 473 G4VParticleChange::operator=(right); 384 G4VParticleChange::operator=(right); 474 385 475 Status: 386 Status: 476 ------- 387 ------- 477 Done, tested, system-tested on HP-aCC with e 388 Done, tested, system-tested on HP-aCC with exemple N05. 478 389 479 Modified files: 390 Modified files: 480 --------------- 391 --------------- 481 G4FastStep.cc 392 G4FastStep.cc 482 393 483 6) Warning: 394 6) Warning: 484 ----------- 395 ----------- 485 include/G4FastStep.hh:59 396 include/G4FastStep.hh:59 486 Avoid data members in the public interface 397 Avoid data members in the public interface 487 Violation: Effective C++ item 20 398 Violation: Effective C++ item 20 488 Public data members for class G4FastStep: 399 Public data members for class G4FastStep: 489 debugFlag 400 debugFlag 490 401 491 402 492 offending code: 403 offending code: 493 --------------- 404 --------------- 494 public: 405 public: 495 ... 406 ... 496 G4bool debugFlag; 407 G4bool debugFlag; 497 408 498 Diagnostic: 409 Diagnostic: 499 ---------- 410 ---------- 500 Historical usage. 411 Historical usage. 501 412 502 Action: 413 Action: 503 ------- 414 ------- 504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 415 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file. 505 416 506 Modified files: 417 Modified files: 507 --------------- 418 --------------- 508 G4FastStep.hh, G4FastStep.cc 419 G4FastStep.hh, G4FastStep.cc 509 420 510 Status: 421 Status: 511 ------- 422 ------- 512 Done, tested, system-tested on HP-aCC with e 423 Done, tested, system-tested on HP-aCC with exemple N05. 513 424 514 7) Warning: 425 7) Warning: 515 ----------- 426 ----------- 516 include/G4FastStep.hh:59 427 include/G4FastStep.hh:59 517 If a class has virtual functions it shall 428 If a class has virtual functions it shall have a virtual destructor 518 Severe violation: Universal Coding Standar 429 Severe violation: Universal Coding Standards item 17 519 class G4FastStep has virtual functions wit 430 class G4FastStep has virtual functions without a virtual destructor. 520 431 521 432 522 offending code: 433 offending code: 523 --------------- 434 --------------- 524 ~G4FastStep(); 435 ~G4FastStep(); 525 436 526 Diagnostic: 437 Diagnostic: 527 ---------- 438 ---------- 528 Nobody should inherites from G4FastStep BUT 439 Nobody should inherites from G4FastStep BUT virtual added. 529 440 530 Action: 441 Action: 531 ------- 442 ------- 532 virtual ~G4FastStep(); 443 virtual ~G4FastStep(); 533 444 534 Modified files: 445 Modified files: 535 --------------- 446 --------------- 536 G4FastStep.hh 447 G4FastStep.hh 537 448 538 Status: 449 Status: 539 ------- 450 ------- 540 Done, tested, system-tested on HP-aCC with e 451 Done, tested, system-tested on HP-aCC with exemple N05. 541 452 542 453 543 December 7, 1998 M. Verderi 454 December 7, 1998 M. Verderi 544 G4FastSimulationManagerProcess class: 455 G4FastSimulationManagerProcess class: 545 Fixes made for ghost navigation with 456 Fixes made for ghost navigation with 546 mag-field: 457 mag-field: 547 LocateGlobalPointAndUpdateTouchable is 458 LocateGlobalPointAndUpdateTouchable is 548 always used (in not the Locate...Setup 459 always used (in not the Locate...Setup 549 method) 460 method) 550 In PostStepDoIt: correction of position and 461 In PostStepDoIt: correction of position and 551 direction of the track are made when << 462 direction of the track are made when 552 possible in case of mag-field. 463 possible in case of mag-field. 553 This correction comes from the fact that a 464 This correction comes from the fact that a 554 small discrepancy appears on those quantitie 465 small discrepancy appears on those quantities 555 because of the numerical integration along 466 because of the numerical integration along 556 the field on the track path: the G4FSMP 467 the field on the track path: the G4FSMP 557 proposes a curve-length, the transportation 468 proposes a curve-length, the transportation 558 moves the track along this curve, however 469 moves the track along this curve, however 559 the end point position and direction are 470 the end point position and direction are 560 slightly different from those expected by 471 slightly different from those expected by 561 the G4FSMP when it proposed the length. 472 the G4FSMP when it proposed the length. 562 473 563 November 20,1998 M. Verderi 474 November 20,1998 M. Verderi 564 G4FastStep class: 475 G4FastStep class: 565 Remove track/G4BiasingTag.hh dependancy (ob 476 Remove track/G4BiasingTag.hh dependancy (obsolete). 566 Adapted to new shceme of Event Biasing mech 477 Adapted to new shceme of Event Biasing mechanism, 567 consistently with track-00-04-01 tag. 478 consistently with track-00-04-01 tag. 568 479 569 November 11,1998 M. Verderi 480 November 11,1998 M. Verderi 570 Merge of param-00-03-02 & param-00-03-02a i 481 Merge of param-00-03-02 & param-00-03-02a into 571 param-00-03-04a (hopefully...) 482 param-00-03-04a (hopefully...) 572 The point is the chnage of signature in the 483 The point is the chnage of signature in the 573 LocateGlobalPointAndSetup(..) of the G4Navi 484 LocateGlobalPointAndSetup(..) of the G4Navigator making use now 574 of the track direction. The G4FastSimulatio 485 of the track direction. The G4FastSimulationManagerProcess is 575 changed accordingly: 486 changed accordingly: 576 fGhostNavigator.LocateGlobalPointAndSetup(t 487 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true); 577 488 578 489 579 November 6, 1998 M. Verderi 490 November 6, 1998 M. Verderi 580 - Extension of the G4FastStep to allow the 491 - Extension of the G4FastStep to allow the biasing technic. 581 Changes are made in: 492 Changes are made in: 582 - G4FastStep.hh/.icc: 493 - G4FastStep.hh/.icc: 583 new member G4BiasingTa 494 new member G4BiasingTag fBiasTag; 584 new method SetPrimaryT 495 new method SetPrimaryTrackFinalBiasingTag 585 ( G4BiasingTag 496 ( G4BiasingTag aTag ); 586 - G4FastStep.cc: 497 - G4FastStep.cc: 587 Initialize(); 498 Initialize(); 588 operator=; << 499 operator=; 589 UpdateForPostStep(); 500 UpdateForPostStep(); 590 UpdateForAtRest(); << 501 UpdateForAtRest(); 591 502 592 October 26, 1998 P.Mora de Freitas 503 October 26, 1998 P.Mora de Freitas 593 - G4FastSimulationManagerProcess and G4Fast 504 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal 594 with at rest parameterisations also when 505 with at rest parameterisations also when using parallel geometry. 595 506 596 October 8, 1998 P.Mora de Freitas 507 October 8, 1998 P.Mora de Freitas 597 - The G4VFastSimulationModel::IsApplicable( 508 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual 598 methode. 509 methode. 599 - G4FastSimulationManager optimisation: 510 - G4FastSimulationManager optimisation: 600 - New G4ParticleDefinition* fLastCrossedP 511 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps 601 the last particle type with touched the 512 the last particle type with touched the envelope; 602 - New G4RWTPtrOrderedVector<G4VFastSimula 513 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList 603 data member, keeps the model list of th << 514 data member, keeps the model list of the applicable models for 604 the actual fLastCrossedParticle particl 515 the actual fLastCrossedParticle particle type; 605 - Changes in the PostStepGetFastSimulatio << 516 - Changes in the PostStepGetFastSimulationManagerTrigger() and 606 AtRestGetFastSimulationManagerTrigger() << 517 AtRestGetFastSimulationManagerTrigger()methodes to update the 607 fApplicableModelList when needed (fLast 518 fApplicableModelList when needed (fLastCrossedParticle != 608 the actual tracked particle); 519 the actual tracked particle); 609 - Changes in the << 520 - Changes in the 610 G4FastSimulationManager() (Constructor) 521 G4FastSimulationManager() (Constructor) 611 ActivateFastSimulationModel(), 522 ActivateFastSimulationModel(), 612 InActivateFastSimulationModel(), 523 InActivateFastSimulationModel(), 613 AtRestGetFastSimulationManagerTrigger(), 524 AtRestGetFastSimulationManagerTrigger(), 614 AddFastSimulationModel(), 525 AddFastSimulationModel(), 615 RemoveFastSimulationModel() 526 RemoveFastSimulationModel() 616 methodes to set the fLastCrossedParticle to 527 methodes to set the fLastCrossedParticle to NULL, forcing the 617 fApplicableModelList to be rebuilt. 528 fApplicableModelList to be rebuilt. 618 529 619 September 22, 1998 P.Mora de Freitas 530 September 22, 1998 P.Mora de Freitas 620 Fixed bug in parallel navigation. << 531 Fixed bug in parallel navigation. 621 File touched: G4FastSimulationManagerProces 532 File touched: G4FastSimulationManagerProcess.cc 622 Tested on HP-aCC. 533 Tested on HP-aCC. 623 534 624 September 17, 1998 P.Mora de Freitas 535 September 17, 1998 P.Mora de Freitas 625 G4FastSimulationManager::RemoveFastSimulati 536 G4FastSimulationManager::RemoveFastSimulationModel() updated to look 626 for also in the fInactivatedModels list. 537 for also in the fInactivatedModels list. 627 538 628 Tested on HP-aCC. 539 Tested on HP-aCC. 629 540 630 September 16, 1998 P.Mora de Freitas 541 September 16, 1998 P.Mora de Freitas 631 New /param/ control commands: 542 New /param/ control commands: 632 543 633 /param/ActivateModel <ModelName> 544 /param/ActivateModel <ModelName> 634 /param/InActivateModel <ModelName> 545 /param/InActivateModel <ModelName> 635 546 636 Activate or inactivate a given parameterisat 547 Activate or inactivate a given parameterisation model. 637 548 638 Tested on HP-aCC. 549 Tested on HP-aCC. 639 550 640 August 21, 1998 P.Mora de Freitas 551 August 21, 1998 P.Mora de Freitas 641 G4FastSimulationManagerProcess's G4ProcessTy 552 G4FastSimulationManagerProcess's G4ProcessType set to 642 fParameterisation, accordingly with procman-00 553 fParameterisation, accordingly with procman-00-02-03. 643 554 644 Tested on HP-aCC. 555 Tested on HP-aCC. 645 556 646 August 12, 1998 P.Mora de Freitas 557 August 12, 1998 P.Mora de Freitas 647 Improved the "close parameterisation control << 558 Improved the "close parameterisation control" to 648 559 649 1) avoid the close looping when unnecessary 560 1) avoid the close looping when unnecessary (mostly cases); 650 2) force re-close when necessary (insert/rem 561 2) force re-close when necessary (insert/remove ghosts). 651 562 652 Changes: 563 Changes: 653 564 654 1) the G4GlobalFastSimulationManager::fClose << 565 1) the G4GlobalFastSimulationManager::fClosed is now initialised 655 to true by the G4GlobalFastSimulationMana 566 to true by the G4GlobalFastSimulationManager constructor; 656 567 657 2) new method << 568 2) new method 658 569 659 void << 570 void 660 G4GlobalFastSimulationManager::FastSimula 571 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed(); 661 572 662 called by the AddGhostPlacement and Remov << 573 called by the AddGhostPlacement and RemoveGhostPlacement 663 G4FastSimulationManager methods to set fa 574 G4FastSimulationManager methods to set false the fClosed flag; 664 575 665 3) changes in the G4GlobalFastSimulationMana 576 3) changes in the G4GlobalFastSimulationManager::Notify method 666 to deal with these changes. 577 to deal with these changes. 667 578 668 Tested on HP-aCC. 579 Tested on HP-aCC. 669 580 670 August 11, 1998 P.Mora de Freitas 581 August 11, 1998 P.Mora de Freitas 671 Fix to the G4FastStep::KillPrimaryTrack() me 582 Fix to the G4FastStep::KillPrimaryTrack() method to drop the 672 nonsense line 583 nonsense line 673 584 674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 585 SetMomentumChange(0.,0.,0.) ; /* necessary ? */ 675 586 676 Tested on HP-aCC. 587 Tested on HP-aCC. 677 (Thanks to Willy Langeveld) 588 (Thanks to Willy Langeveld) 678 589 679 590 680 August 10, 1998 P.Mora de Freitas 591 August 10, 1998 P.Mora de Freitas 681 Fix to the SetPrimaryTrackFinalKineticEnergy 592 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method 682 from the G4FastStep class the SetMomentumChang 593 from the G4FastStep class the SetMomentumChange() call to insure that 683 the new momentum direction is a unit vector (a << 594 the new momentum direction is a unit vector (as asked by the 684 G4DynamicParticle::SetMomentumDirection method 595 G4DynamicParticle::SetMomentumDirection method). 685 596 686 Touched files: G4FastStep.hh (improved comme 597 Touched files: G4FastStep.hh (improved comments) 687 G4FastStep.cc (fixed) 598 G4FastStep.cc (fixed) 688 599 689 Tested on HP-aCC. 600 Tested on HP-aCC. 690 (Thanks to Willy Langeveld) 601 (Thanks to Willy Langeveld) 691 602 692 August 7, 1998 P.Mora de Freitas 603 August 7, 1998 P.Mora de Freitas 693 New /param/ commands directory with the comm 604 New /param/ commands directory with the commands: 694 605 695 /param/listEnvelopes [ParticleName] 606 /param/listEnvelopes [ParticleName] 696 607 697 - List all the envelope names for a given pa 608 - List all the envelope names for a given particle 698 (or for all particles if without parameter 609 (or for all particles if without parameters). 699 610 700 /param/listModels [EnvelopeName] 611 /param/listModels [EnvelopeName] 701 612 702 - List all the Model names for a given envel 613 - List all the Model names for a given envelope 703 (or for all envelopes if without parameter 614 (or for all envelopes if without parameters). 704 615 705 /param/listIsApplicable [ModelName] 616 /param/listIsApplicable [ModelName] 706 617 707 - List all the particle names a given model 618 - List all the particle names a given model is applicable 708 (or for all models if without parameters). 619 (or for all models if without parameters). 709 620 710 621 711 August 7, 1998 P.Mora de Freitas 622 August 7, 1998 P.Mora de Freitas 712 History file Created. 623 History file Created.