Geant4 Cross Reference |
1 # Category param History << 1 $Id: History,v 1.37 2007/11/30 18:05:14 mverderi Exp $ >> 2 ------------------------------------------------------------------- 2 3 3 See `CONTRIBUTING.rst` for details of **requir << 4 ========================================================= 4 which **must** added in reverse chronological << 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP 5 It must **not** be used as a substitute for wr << 6 ========================================================= >> 7 >> 8 Category History file >> 9 --------------------- >> 10 This file should be used by G4 developers and category coordinators >> 11 to briefly summarize all major modifications introduced in the code >> 12 and keep track of all category-tags. >> 13 It DOES NOT substitute the CVS log-message one should put at every >> 14 committal in the CVS repository ! >> 15 >> 16 ---------------------------------------------------------- >> 17 * Reverse chronological order (last date on top), please * >> 18 ---------------------------------------------------------- 6 19 7 ---------------------------------------------- << 20 November 30 2007, M. Verderi 8 << 9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) << 10 - In G4GlobalFastSimulationManager: << 11 use G4ThreadLocalSingleton to avoid undelete << 12 << 13 ## 2023-10-18 Ben Morgan (param-V11-01-03) << 14 - Apply standard and extended clang-tidy fixes << 15 - Mark empty/obsolete functions as deprecated << 16 << 17 ## 2023-10-16 Ben Morgan (param-V11-01-02) << 18 - Apply standard clang-format-ing. << 19 - Normal order accessors and docstrings. << 20 << 21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) << 22 - In G4FastTrack, removed references to G4Touc << 23 which is now deprecated. << 24 << 25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 << 26 - Added missing virtual destructor to G4VFastS << 27 << 28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) << 29 - Fixed compilation warnings for implicit type << 30 << 31 ## 2022-10-27 Makoto Asai (param-V11-00-03) << 32 - G4FastSimHitMaker - making compatible to com << 33 << 34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 << 35 - G4FastStep - delete copy constructor and ope << 36 << 37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) << 38 - Adding the 'flush' method to the fast simula << 39 This method allows to process the input buff << 40 the end of the G4 event. It is used when par << 41 The 'flash' is triggered inside the event lo << 42 The fast simulation model may add secondarie << 43 by Geant4. << 44 << 45 ## 2021-12-10 Ben Morgan (param-V11-00-00) << 46 - Change to new Markdown History format << 47 << 48 --- << 49 << 50 # History entries prior to 11.0 << 51 << 52 April 16, 2021 Ben Morgan (param-V10-07-00) << 53 - Migrate build to modular CMake API << 54 << 55 October 5, 2020, A. Zaborowska (param-V10-06-0 << 56 - Introduce general facilities based on GFlash << 57 to facilitate multiple hit (energy & positio << 58 from fast simulation models. << 59 << 60 September 9, 2020, G. Cosmo (param-V10-06-02) << 61 - Fixed minor Coverity defect for uninitialise << 62 << 63 April 21, 2020, A. Zaborowska (param-V10-06-01 << 64 - Sanity check for root logical volumes for re << 65 UI command /param/showSetup works also if no << 66 << 67 March 26, 2020, I. Semeniouk (param-V10-06-00) << 68 - G4FastSimulationHelper : merge ActivateFastS << 69 - G4FastSimulationManager.hh, G4VFastSimulatio << 70 redefinition of G4Envelope type << 71 << 72 October 30, 2019, A. Zaborowska (param-v10-05- << 73 - Register G4FastSimulationManagerProcess with << 74 G4FastSimulationManagerHelper to ensure it i << 75 invoked for a given step (ExclusivelyForced) << 76 StronglyForced processes will be considered. << 77 << 78 December 19, 2017, G. Cosmo (param-V10-04-00) << 79 - Fixed self-consistency in G4FastSimulationVe << 80 Thanks to Raphael Isemann for reporting this << 81 << 82 November 03, 2016, M. Verderi (param-V10-02-01 << 83 - New G4FastSimulationManagerHelper utility fo << 84 adding G4FastSimulationManagerProcess to a << 85 process manager. << 86 << 87 November 02, 2016, M. Verderi (param-V10-02-00 << 88 - fix various Coverity defects. << 89 << 90 March 27, 2013, M. Verderi (param-V09-06-00) << 91 - remove unused field 'fOnBoundary' in G4FastS << 92 as this was causing a warning from clang. << 93 << 94 July 10, 2012, G. Cosmo (param-V09-05-00) << 95 - Explicitly use inclusion of headers for syst << 96 constants, in plan to remove implicit inclus << 97 << 98 September 30, 2011, M. Verderi (param-V09-04-0 << 99 - Added missing new header file (G4FastSimulat << 100 sources.cmake. << 101 << 102 September 30, 2011, M. Verderi (param-V09-04-0 << 103 - Migration to new G4Exception scheme. << 104 - what is V09-04-01 tag ? << 105 << 106 February 11, 2011, M. Verderi (param-V09-04-00 << 107 - Implementation of method << 108 void ProposePrimaryTrackFinalKineticEnergy ( << 109 was missing : modified file G4FastStep.icc << 110 << 111 March 13, 2008, G. Cosmo (param-V09-01-00) << 112 - Cleared compilation warnings in G4FastSimula << 113 G4FastSimulationMessenger on gcc-4.3.0 for a << 114 parentheses in nested if-else statements. << 115 << 116 November 30, 2007, M. Verderi << 117 - Add Along methods to G4FSMP process 21 - Add Along methods to G4FSMP process 118 - tag as param-V09-00-01 22 - tag as param-V09-00-01 119 23 120 November 30, 2007, M. Verderi << 24 November 30 2007, M. Verderi 121 - minor corrections to G4FastSimulationManager << 25 - minor corrections to G4FastSimulationManagerProcess.hh/.cc : 122 * add call fPathFinder->prepareNewrack(...) 26 * add call fPathFinder->prepareNewrack(...) 123 * deactivate ghost navigator in EndOfTracki 27 * deactivate ghost navigator in EndOfTracking(..) method 124 - tag as param-V09-00-00 28 - tag as param-V09-00-00 125 29 126 May 18, 2007, M. Verderi 30 May 18, 2007, M. Verderi 127 - tag as param-V08-03-00 31 - tag as param-V08-03-00 128 32 129 May 11, 2007, M. Verderi 33 May 11, 2007, M. Verderi 130 - remove include/G4FastSimulationManagerProces 34 - remove include/G4FastSimulationManagerProcess81.hh 131 include/G4FlavoredParallelWorld.hh 35 include/G4FlavoredParallelWorld.hh 132 include/G4GFSManager81.hh 36 include/G4GFSManager81.hh 133 src/G4FastSimulationManagerProcess81. 37 src/G4FastSimulationManagerProcess81.cc 134 src/G4GFSManager81.cc 38 src/G4GFSManager81.cc 135 39 136 40 137 November 10, 2006, M. Verderi - param-V08-01-0 41 November 10, 2006, M. Verderi - param-V08-01-00 138 - Limited number of warning messages printed b 42 - Limited number of warning messages printed by the 139 G4GlobalFastSimulationManager. 43 G4GlobalFastSimulationManager. 140 - Renamed G4FastSimulationManagerProcess_forCo 44 - Renamed G4FastSimulationManagerProcess_forCoupledTransportation with 141 G4FastSimulationManagerProcess81. 45 G4FastSimulationManagerProcess81. 142 In addition, this class can now handle the c 46 In addition, this class can now handle the case of Navigator index=0, 143 i.e., the navigator for tracking, regardless 47 i.e., the navigator for tracking, regardless the G4Transportation or 144 G4CoupledTransportation is used. (For other 48 G4CoupledTransportation is used. (For other navigators, there is 145 of course no choice, and G4CoupledTransporta 49 of course no choice, and G4CoupledTransportation is necessary.) 146 50 147 November 3, 2006 M. Verderi 51 November 3, 2006 M. Verderi 148 - Introduced G4FastSimulationManagerProcess_fo 52 - Introduced G4FastSimulationManagerProcess_forCoupledTransportation class for 149 handling fast simulation in new parallel geo 53 handling fast simulation in new parallel geometry scheme. This requires 150 the G4CoupledTransportation to be active. 54 the G4CoupledTransportation to be active. 151 - Introduced G4GFSManager81 class that gathers 55 - Introduced G4GFSManager81 class that gathers the future code to become the 152 default at next major release in the G4Globa 56 default at next major release in the G4GlobalFastSimulationManager class. 153 - G4FastSimulationManager: adapted to new sche 57 - G4FastSimulationManager: adapted to new scheme. Still has old code for 154 backward compatibilty. 58 backward compatibilty. 155 - G4FastSimulationManagerProcess: mostly the s 59 - G4FastSimulationManagerProcess: mostly the same, apart from a small bug fix. 156 - G4FastSimulationMessenger: new command creat 60 - G4FastSimulationMessenger: new command created "/param/showSetup", useful 157 to show the fast simulation setup (region, m 61 to show the fast simulation setup (region, models, processes, etc...) 158 It is only valid for geometry closed state. 62 It is only valid for geometry closed state. Desirable to have interactive 159 command in the run manager for this. 63 command in the run manager for this. 160 64 161 November 25, 2005, M.Verderi - param-V07-01-0 65 November 25, 2005, M.Verderi - param-V07-01-04 162 - put back Makoto's change: StartTracking(G4Tr 66 - put back Makoto's change: StartTracking(G4Track*) 163 67 164 November 25, 2005, M Verderi - param-V07-01-03 68 November 25, 2005, M Verderi - param-V07-01-03 165 - Make ghost functionnality available with G4R 69 - Make ghost functionnality available with G4Region 166 - ** Note ** Change back StartTracking(G4Track 70 - ** Note ** Change back StartTracking(G4Track*) -> StartTracking() in G4FSMP 167 StartTracking(G4Track*) was intro 71 StartTracking(G4Track*) was introduced in param-V07-01-02 168 because (I guess) of procman-V07-01-01 72 because (I guess) of procman-V07-01-01 169 This is to make param-V07-01-03 compatible w 73 This is to make param-V07-01-03 compatible with geant4-07-01-ref-05 170 74 171 November 21, 2005 M.Asai - param-V07-01-02 75 November 21, 2005 M.Asai - param-V07-01-02 172 - Fix warning message. 76 - Fix warning message. 173 77 174 November 02, 2005 G.Cosmo - param-V07-01-01 78 November 02, 2005 G.Cosmo - param-V07-01-01 175 - Corrected setting of envelope volumes and so 79 - Corrected setting of envelope volumes and solid in G4FastTrack. 176 - Migrated old scheme for G4Exception and some 80 - Migrated old scheme for G4Exception and some cosmetics... 177 81 178 October 28, 2005 M.Asai - param-V07-01-00 82 October 28, 2005 M.Asai - param-V07-01-00 179 - Working tag for merging "envelope" to G4Regi 83 - Working tag for merging "envelope" to G4Region. 180 84 181 December 07, 2004 G. Cosmo - param-V06-02-01 85 December 07, 2004 G. Cosmo - param-V06-02-01 182 - Implemented migration to <cmath>. 86 - Implemented migration to <cmath>. 183 87 184 November 26, 2004 M. Verderi - param-V06-02-00 88 November 26, 2004 M. Verderi - param-V06-02-00 185 - Implemented migration to new G4VParticleChan 89 - Implemented migration to new G4VParticleChange interfaces. 186 90 187 December 12, 2003 G. Cosmo - param-V06-00-00 91 December 12, 2003 G. Cosmo - param-V06-00-00 188 - G4FastSimulationVector.icc: use std_pvector: 92 - G4FastSimulationVector.icc: use std_pvector:: scope for calls to 189 base class. Fixes compilation problem on Int 93 base class. Fixes compilation problem on Intel-icc compiler. 190 94 191 November 10, 2003 G. Cosmo - param-V05-02-01 95 November 10, 2003 G. Cosmo - param-V05-02-01 192 - G4FastTrack: use G4Navigator::CreateTouchabl 96 - G4FastTrack: use G4Navigator::CreateTouchableHistoryHandle() instead of 193 CreateTouchableHistory() in method FRecordsA 97 CreateTouchableHistory() in method FRecordsAffineTransformation(). 194 98 195 October 4, 2003 G. Cosmo - param-V05-02-00 99 October 4, 2003 G. Cosmo - param-V05-02-00 196 - Modified GNUmakefile: 100 - Modified GNUmakefile: 197 o added dependency to new module "geometry/n 101 o added dependency to new module "geometry/navigation". 198 - Coworks with "geometry-V05-02-00" and "digit 102 - Coworks with "geometry-V05-02-00" and "digits_hits-V05-02-00". 199 103 200 May 21, 2003 G. Cosmo - param-V05-01-00 104 May 21, 2003 G. Cosmo - param-V05-01-00 201 o Fixed pedantic warnings on Linux-g++ 105 o Fixed pedantic warnings on Linux-g++. 202 o Call base class in copy-constructor 106 o Call base class in copy-constructor of G4FastStep. 203 107 204 Nov 20, 2002 G. Cosmo - param-V04-01-02 108 Nov 20, 2002 G. Cosmo - param-V04-01-02 205 o Patched access to public static data in G4 109 o Patched access to public static data in G4FastStep.cc 206 and G4GlobalFastSimulationManager.cc to al 110 and G4GlobalFastSimulationManager.cc to allow porting on 207 Windows DLLs. 111 Windows DLLs. 208 112 209 Nov 15, 2002 S. Sadilov - param-V04-01-01 113 Nov 15, 2002 S. Sadilov - param-V04-01-01 210 o Fixed compilation problems on Windows in 114 o Fixed compilation problems on Windows in 211 G4FastSimulationManager.cc and G4GlobalFas 115 G4FastSimulationManager.cc and G4GlobalFastSimulationManager.cc 212 116 213 Nov 02, 2002 M. Verderi - param-V04-01-00 117 Nov 02, 2002 M. Verderi - param-V04-01-00 214 o Add method to retrieve G4VFastSimulationMo 118 o Add method to retrieve G4VFastSimulationModel by name. 215 The user's method is in G4GlobalFastSimula 119 The user's method is in G4GlobalFastSimulationManager: 216 120 217 GetFastSimulationModel(); 121 GetFastSimulationModel(); 218 122 219 it is accompagnied by same methods name in 123 it is accompagnied by same methods name in 220 G4FastSimulationManager class. 124 G4FastSimulationManager class. 221 125 222 o Add "test" directory, used to test above f 126 o Add "test" directory, used to test above feature. 223 127 224 Oct 26, 2001 M. Verderi - param-V03-02-00 128 Oct 26, 2001 M. Verderi - param-V03-02-00 225 Fixes to clear warnings produced with gcc-2. 129 Fixes to clear warnings produced with gcc-2.95.2: 226 - loop index, where comparison with method " 130 - loop index, where comparison with method "size()" of 227 G4std::vector<T>, changed: int -> size_t << 131 G4std::vector<T>, changed: int -> size_t 228 - change "if ( a=b ) {..}" by "if ( (a=b) ) 132 - change "if ( a=b ) {..}" by "if ( (a=b) ) {...}" 229 this makes the compiler sure you want to mak 133 this makes the compiler sure you want to make an 230 assignement in the "if" condition 134 assignement in the "if" condition 231 - re-order initialisations of a few variable 135 - re-order initialisations of a few variables in constructors 232 to match the declaration order. 136 to match the declaration order. 233 Some warnings still exist, but regard the G4 137 Some warnings still exist, but regard the G4Propagator of geometry. 234 138 235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 139 Apr 3, 2001 J. Apostolakis - param-V03-00-00 236 - Modified G4FastSimulationManagerProcess call 140 - Modified G4FastSimulationManagerProcess call to PropagatorInField ComputeStep 237 to use new interface with G4FieldTrack (in 141 to use new interface with G4FieldTrack (in place of now obsolete interface.) 238 142 239 Nov 14, 2000 G. Cosmo - param-V02-00-01 143 Nov 14, 2000 G. Cosmo - param-V02-00-01 240 - Moved specific parameterisation models to th 144 - Moved specific parameterisation models to the new top category 241 "parameterisations". Moved files: 145 "parameterisations". Moved files: 242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm 146 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRmodel[.hh.cc], 243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster 147 G4IrregularXrayTRmodel[.hh.cc], G4PAIclusterModel[.hh.cc], 244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr 148 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXrayTRmodel[.hh.cc], 245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode 149 G4RegularXrayTRmodel[.hh.cc], G4VClusterModel[.hh.cc], 246 G4VXrayTRmodel[.hh.cc]. 150 G4VXrayTRmodel[.hh.cc]. 247 - Cleaned-up GNUmakefile of non necessary depe 151 - Cleaned-up GNUmakefile of non necessary dependencies. 248 152 249 Aug 03, 2000 G. Cosmo - param-V02-00-00r 153 Aug 03, 2000 G. Cosmo - param-V02-00-00r 250 - Changed RandGauss to G4RandGauss in G4Irregu 154 - Changed RandGauss to G4RandGauss in G4IrregularXrayTRmodel.cc and 251 G4VXrayTRmodel.cc to fix events' reproducibi 155 G4VXrayTRmodel.cc to fix events' reproducibility problem. 252 - G4VXrayTRmodel.cc: fix to class destructor ( 156 - G4VXrayTRmodel.cc: fix to class destructor (V.Grichine) 253 157 254 Jun 15, 2000 G. Cosmo - param-V01-01-04 158 Jun 15, 2000 G. Cosmo - param-V01-01-04 255 - The tag coworks with global-V01-01-04 and ma 159 - The tag coworks with global-V01-01-04 and materials-V01-01-00: 256 o Fixed usage of G4complex type for ISO and 160 o Fixed usage of G4complex type for ISO and non-ISO compilers. 257 Affected files: G4FoamXrayTRmodel.cc, G4Ga 161 Affected files: G4FoamXrayTRmodel.cc, G4GamDistrXrayTRmodel.cc, G4PlateIrrGasXrayTRmodel.cc 258 and G4RegularXrayTRmodel.c 162 and G4RegularXrayTRmodel.cc. 259 In case of G4complex types passed to mathe 163 In case of G4complex types passed to mathematical functions, use G4std:: prefix. 260 o Fixed usage of G4Integrator class, now cha 164 o Fixed usage of G4Integrator class, now changed to templated to allow porting of the 261 code on SUN-CC compiler which does not imp 165 code on SUN-CC compiler which does not implement templated member functions. 262 Affected files: G4VXrayTRmodel[.hh.cc] 166 Affected files: G4VXrayTRmodel[.hh.cc] 263 167 264 Jun 6, 2000 M. Verderi & P. Mora de Freitas 168 Jun 6, 2000 M. Verderi & P. Mora de Freitas 265 - fixed compilation errors with HP-aCC for the 169 - fixed compilation errors with HP-aCC for the files G4RegularXrayTRmodel.cc, 266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod 170 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmodel.cc. 267 171 268 May 30, 2000 M. Verderi & P. Mora de Freitas 172 May 30, 2000 M. Verderi & P. Mora de Freitas 269 173 270 - parameterisation category is now RW free. 174 - parameterisation category is now RW free. 271 175 272 September 16, 1999 M. Verderi & P. Mora de Fre 176 September 16, 1999 M. Verderi & P. Mora de Freitas 273 177 274 - Fixed bug in G4FastStep::CheckIt() method. 178 - Fixed bug in G4FastStep::CheckIt() method. 275 179 276 April 19, 1999 M. Verderi & P. Mora de Freitas 180 April 19, 1999 M. Verderi & P. Mora de Freitas 277 181 278 Changes in G4FastStep to co-work with track-01 182 Changes in G4FastStep to co-work with track-01-00-04: 279 183 280 1) The method void CheckIt(const G4Track&) bec << 184 1) The method void CheckIt(const G4Track&) becomes 281 G4bool CheckIt(const G4Track&); 185 G4bool CheckIt(const G4Track&); 282 2) The FAST_STEP_DEBUG compiling option disapp 186 2) The FAST_STEP_DEBUG compiling option disappears; 283 3) Call to CheckIt controled by the G4VParticl 187 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute. 284 188 285 Miscellaneous: the declaration "G4double mass 189 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh 286 corrected to G4double mass =...". 190 corrected to G4double mass =...". 287 191 288 April 15, 1999 M. Verderi & P. Mora de Freitas 192 April 15, 1999 M. Verderi & P. Mora de Freitas 289 193 290 Tasks to decouple visualization from processes 194 Tasks to decouple visualization from processes/parameterisation: 291 195 292 1) G4GlobalFastSimulationManager now inherites 196 1) G4GlobalFastSimulationManager now inherites from the intercoms/ 293 G4VGlobalFastSimulationManager to allow visual << 197 G4VGlobalFastSimulationManager to allow visualisation to get a 294 concrete instance pointer to the G4GlobalFastS 198 concrete instance pointer to the G4GlobalFastSimulationManager, 295 if any. 199 if any. 296 200 297 2) G4FlavoredParallelWorld now inherites from 201 2) G4FlavoredParallelWorld now inherites from the intercoms/ 298 G4VFlavoredParallelWorld, a pure virtual abstr 202 G4VFlavoredParallelWorld, a pure virtual abstract class to interface 299 parameterisation with visualization. 203 parameterisation with visualization. 300 204 301 Co-works with intercoms-01-00-01 tag 205 Co-works with intercoms-01-00-01 tag 302 206 303 Modified files: 207 Modified files: 304 --------------- 208 --------------- 305 G4FlavoredParallelWorld.hh 209 G4FlavoredParallelWorld.hh 306 G4GlobalFastSimulationManager.hh 210 G4GlobalFastSimulationManager.hh 307 G4GlobalFastSimulationManager.cc 211 G4GlobalFastSimulationManager.cc 308 212 309 Done, tested, system-tested on HP-aCC with exe 213 Done, tested, system-tested on HP-aCC with exemple N05. 310 214 311 April 14, 1999 M. Verderi & P. Mora de Freitas 215 April 14, 1999 M. Verderi & P. Mora de Freitas 312 216 313 Several consolidation tasks (thanks to G. Cosm 217 Several consolidation tasks (thanks to G. Cosmo): 314 218 315 1) Warning: << 219 1) Warning: 316 ----------- 220 ----------- 317 221 318 Pointers usage 222 Pointers usage 319 223 320 - Setting pointers to 0 after delete: 224 - Setting pointers to 0 after delete: 321 225 322 delete pA; 226 delete pA; 323 pA = 0; 227 pA = 0; 324 228 325 - Avoid to use "NULL". 229 - Avoid to use "NULL". 326 230 327 Modified files: 231 Modified files: 328 --------------- 232 --------------- 329 G4FastSimulationManager.hh 233 G4FastSimulationManager.hh 330 G4FastTrack.hh 234 G4FastTrack.hh 331 G4FlavoredParallelWorld.hh 235 G4FlavoredParallelWorld.hh 332 G4FastSimulationManager.cc 236 G4FastSimulationManager.cc 333 G4FastSimulationMessenger.cc 237 G4FastSimulationMessenger.cc 334 G4FastSimulationManagerProcess.cc 238 G4FastSimulationManagerProcess.cc 335 G4FastTrack.cc 239 G4FastTrack.cc 336 G4GlobalFastSimulationManager.cc 240 G4GlobalFastSimulationManager.cc 337 G4VFastSimulationModel.cc 241 G4VFastSimulationModel.cc 338 242 339 Status: << 243 Status: 340 ------- 244 ------- 341 Done, tested, system-tested on HP-aCC with exe 245 Done, tested, system-tested on HP-aCC with exemple N05. 342 246 343 2) Warning: 247 2) Warning: 344 ----------- 248 ----------- 345 include/G4FastSimulationManager.hh:163 249 include/G4FastSimulationManager.hh:163 346 Public member functions shall always retur 250 Public member functions shall always return const handles to member data 347 Severe violation: Universal Coding Standar 251 Severe violation: Universal Coding Standards item 18 348 252 349 offending code: 253 offending code: 350 --------------- 254 --------------- 351 inline G4VParticleChange* G4FastSimulationMana 255 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange() 352 { 256 { 353 return &fFastStep; 257 return &fFastStep; 354 } 258 } 355 259 356 Diagnostic: 260 Diagnostic: 357 ---------- 261 ---------- 358 262 359 Called by the G4FastSimulationManagerProcess << 263 Called by the G4FastSimulationManagerProcess to return it in the 360 PostStepDoIt call. << 264 PostStepDoIt call. 361 265 362 Action: 266 Action: 363 ------- 267 ------- 364 The G4FastSimulationManager::GettheParticleCha 268 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any 365 more. The G4VParticleChange* is now returned d 269 more. The G4VParticleChange* is now returned directly when invoking the 366 G4FastSimulationManager::InvokePostStepDoIt() 270 G4FastSimulationManager::InvokePostStepDoIt() and 367 G4FastSimulationManager::InvokeAtRestDoIt() me 271 G4FastSimulationManager::InvokeAtRestDoIt() methodes. 368 272 369 Modified files: 273 Modified files: 370 --------------- 274 --------------- 371 G4FastSimulationManager.hh 275 G4FastSimulationManager.hh 372 G4FastSimulationManager.cc 276 G4FastSimulationManager.cc 373 G4FastSimulationManagerProcess.cc 277 G4FastSimulationManagerProcess.cc 374 278 375 Status: << 279 Status: 376 ------- 280 ------- 377 Done, tested, system-tested on HP-aCC with exe 281 Done, tested, system-tested on HP-aCC with exemple N05. 378 282 379 3) Warning: 283 3) Warning: 380 ----------- 284 ----------- 381 include/G4FastSimulationManagerProcess.hh:52 285 include/G4FastSimulationManagerProcess.hh:52 382 If a class has virtual functions it shall 286 If a class has virtual functions it shall have a virtual destructor 383 Severe violation: Universal Coding Standar 287 Severe violation: Universal Coding Standards item 17 384 class G4FastSimulationManagerProcess has v 288 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor. 385 289 386 offending code: 290 offending code: 387 --------------- 291 --------------- 388 ~G4FastSimulationManagerProcess(); 292 ~G4FastSimulationManagerProcess(); 389 293 390 Diagnostic: 294 Diagnostic: 391 ---------- 295 ---------- 392 Nobody should inherites from G4FastSimulatio << 296 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual 393 is added. 297 is added. 394 298 395 Action: 299 Action: 396 ------- 300 ------- 397 virtual ~G4FastSimulationManagerProcess(); 301 virtual ~G4FastSimulationManagerProcess(); 398 302 399 Modified files: 303 Modified files: 400 --------------- 304 --------------- 401 G4FastSimulationManagerProcess.hh 305 G4FastSimulationManagerProcess.hh 402 306 403 Status: << 307 Status: 404 ------- 308 ------- 405 Done. 309 Done. 406 310 407 4) Warning: 311 4) Warning: 408 ----------- 312 ----------- 409 include/G4FastSimulationMessenger.hh:36 313 include/G4FastSimulationMessenger.hh:36 410 If a class has virtual functions it shall 314 If a class has virtual functions it shall have a virtual destructor 411 Severe violation: Universal Coding Standar 315 Severe violation: Universal Coding Standards item 17 412 class G4FastSimulationMessenger has virtua 316 class G4FastSimulationMessenger has virtual functions without a virtual destructor. 413 317 414 318 415 offending code: 319 offending code: 416 --------------- 320 --------------- 417 ~G4FastSimulationMessenger(); 321 ~G4FastSimulationMessenger(); 418 322 419 Diagnostic: 323 Diagnostic: 420 ---------- 324 ---------- 421 Nobody should inherites from G4FastSimulatio << 325 Nobody should inherites from G4FastSimulationMessenger BUT for virtual 422 is added. 326 is added. 423 327 424 Action: 328 Action: 425 ------- 329 ------- 426 virtual ~G4FastSimulationMessenger(); 330 virtual ~G4FastSimulationMessenger(); 427 331 428 Modified files: 332 Modified files: 429 --------------- 333 --------------- 430 G4FastSimulationMessenger.hh 334 G4FastSimulationMessenger.hh 431 335 432 Status: << 336 Status: 433 ------- 337 ------- 434 Done. 338 Done. 435 339 436 5) Warning: 340 5) Warning: 437 ----------- 341 ----------- 438 include/G4FastStep.hh:224 342 include/G4FastStep.hh:224 439 Operator= should call base class operator= 343 Operator= should call base class operator= 440 Possible severe violation: Effective C++ i 344 Possible severe violation: Effective C++ item 16 441 operator= in class G4FastStep, should call 345 operator= in class G4FastStep, should call operator= in base class G4VParticleChange 442 346 443 offending code: 347 offending code: 444 --------------- 348 --------------- 445 G4FastStep & G4FastStep::operator=(const G4Fas 349 G4FastStep & G4FastStep::operator=(const G4FastStep &right) 446 { 350 { 447 if (this != &right) 351 if (this != &right) 448 { 352 { 449 theListOfSecondaries = right.th 353 theListOfSecondaries = right.theListOfSecondaries; 450 theSizeOftheListOfSecondaries = right.th 354 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries; 451 theNumberOfSecondaries = right.th 355 theNumberOfSecondaries = right.theNumberOfSecondaries; 452 theStatusChange = right.th 356 theStatusChange = right.theStatusChange; 453 theMomentumChange = right.th 357 theMomentumChange = right.theMomentumChange; 454 thePolarizationChange = right.th 358 thePolarizationChange = right.thePolarizationChange; 455 thePositionChange = right.th 359 thePositionChange = right.thePositionChange; 456 theTimeChange = right.th 360 theTimeChange = right.theTimeChange; 457 theEnergyChange = right.th 361 theEnergyChange = right.theEnergyChange; 458 theTrueStepLength = right.th 362 theTrueStepLength = right.theTrueStepLength; 459 theLocalEnergyDeposit = right.th 363 theLocalEnergyDeposit = right.theLocalEnergyDeposit; 460 theSteppingControlFlag = right.th 364 theSteppingControlFlag = right.theSteppingControlFlag; 461 theWeightChange = right.th 365 theWeightChange = right.theWeightChange; 462 } 366 } 463 return *this; 367 return *this; 464 } 368 } 465 369 466 Diagnostic: 370 Diagnostic: 467 ---------- 371 ---------- 468 Bug detected. 372 Bug detected. 469 373 470 Action: 374 Action: 471 ------- 375 ------- 472 Insert the call 376 Insert the call 473 G4VParticleChange::operator=(right); 377 G4VParticleChange::operator=(right); 474 378 475 Status: 379 Status: 476 ------- 380 ------- 477 Done, tested, system-tested on HP-aCC with e 381 Done, tested, system-tested on HP-aCC with exemple N05. 478 382 479 Modified files: 383 Modified files: 480 --------------- 384 --------------- 481 G4FastStep.cc 385 G4FastStep.cc 482 386 483 6) Warning: 387 6) Warning: 484 ----------- 388 ----------- 485 include/G4FastStep.hh:59 389 include/G4FastStep.hh:59 486 Avoid data members in the public interface 390 Avoid data members in the public interface 487 Violation: Effective C++ item 20 391 Violation: Effective C++ item 20 488 Public data members for class G4FastStep: 392 Public data members for class G4FastStep: 489 debugFlag 393 debugFlag 490 394 491 395 492 offending code: 396 offending code: 493 --------------- 397 --------------- 494 public: 398 public: 495 ... 399 ... 496 G4bool debugFlag; 400 G4bool debugFlag; 497 401 498 Diagnostic: 402 Diagnostic: 499 ---------- 403 ---------- 500 Historical usage. 404 Historical usage. 501 405 502 Action: 406 Action: 503 ------- 407 ------- 504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 408 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file. 505 409 506 Modified files: 410 Modified files: 507 --------------- 411 --------------- 508 G4FastStep.hh, G4FastStep.cc 412 G4FastStep.hh, G4FastStep.cc 509 413 510 Status: 414 Status: 511 ------- 415 ------- 512 Done, tested, system-tested on HP-aCC with e 416 Done, tested, system-tested on HP-aCC with exemple N05. 513 417 514 7) Warning: 418 7) Warning: 515 ----------- 419 ----------- 516 include/G4FastStep.hh:59 420 include/G4FastStep.hh:59 517 If a class has virtual functions it shall 421 If a class has virtual functions it shall have a virtual destructor 518 Severe violation: Universal Coding Standar 422 Severe violation: Universal Coding Standards item 17 519 class G4FastStep has virtual functions wit 423 class G4FastStep has virtual functions without a virtual destructor. 520 424 521 425 522 offending code: 426 offending code: 523 --------------- 427 --------------- 524 ~G4FastStep(); 428 ~G4FastStep(); 525 429 526 Diagnostic: 430 Diagnostic: 527 ---------- 431 ---------- 528 Nobody should inherites from G4FastStep BUT 432 Nobody should inherites from G4FastStep BUT virtual added. 529 433 530 Action: 434 Action: 531 ------- 435 ------- 532 virtual ~G4FastStep(); 436 virtual ~G4FastStep(); 533 437 534 Modified files: 438 Modified files: 535 --------------- 439 --------------- 536 G4FastStep.hh 440 G4FastStep.hh 537 441 538 Status: 442 Status: 539 ------- 443 ------- 540 Done, tested, system-tested on HP-aCC with e 444 Done, tested, system-tested on HP-aCC with exemple N05. 541 445 542 446 543 December 7, 1998 M. Verderi 447 December 7, 1998 M. Verderi 544 G4FastSimulationManagerProcess class: 448 G4FastSimulationManagerProcess class: 545 Fixes made for ghost navigation with 449 Fixes made for ghost navigation with 546 mag-field: 450 mag-field: 547 LocateGlobalPointAndUpdateTouchable is 451 LocateGlobalPointAndUpdateTouchable is 548 always used (in not the Locate...Setup 452 always used (in not the Locate...Setup 549 method) 453 method) 550 In PostStepDoIt: correction of position and 454 In PostStepDoIt: correction of position and 551 direction of the track are made when << 455 direction of the track are made when 552 possible in case of mag-field. 456 possible in case of mag-field. 553 This correction comes from the fact that a 457 This correction comes from the fact that a 554 small discrepancy appears on those quantitie 458 small discrepancy appears on those quantities 555 because of the numerical integration along 459 because of the numerical integration along 556 the field on the track path: the G4FSMP 460 the field on the track path: the G4FSMP 557 proposes a curve-length, the transportation 461 proposes a curve-length, the transportation 558 moves the track along this curve, however 462 moves the track along this curve, however 559 the end point position and direction are 463 the end point position and direction are 560 slightly different from those expected by 464 slightly different from those expected by 561 the G4FSMP when it proposed the length. 465 the G4FSMP when it proposed the length. 562 466 563 November 20,1998 M. Verderi 467 November 20,1998 M. Verderi 564 G4FastStep class: 468 G4FastStep class: 565 Remove track/G4BiasingTag.hh dependancy (ob 469 Remove track/G4BiasingTag.hh dependancy (obsolete). 566 Adapted to new shceme of Event Biasing mech 470 Adapted to new shceme of Event Biasing mechanism, 567 consistently with track-00-04-01 tag. 471 consistently with track-00-04-01 tag. 568 472 569 November 11,1998 M. Verderi 473 November 11,1998 M. Verderi 570 Merge of param-00-03-02 & param-00-03-02a i 474 Merge of param-00-03-02 & param-00-03-02a into 571 param-00-03-04a (hopefully...) 475 param-00-03-04a (hopefully...) 572 The point is the chnage of signature in the 476 The point is the chnage of signature in the 573 LocateGlobalPointAndSetup(..) of the G4Navi 477 LocateGlobalPointAndSetup(..) of the G4Navigator making use now 574 of the track direction. The G4FastSimulatio 478 of the track direction. The G4FastSimulationManagerProcess is 575 changed accordingly: 479 changed accordingly: 576 fGhostNavigator.LocateGlobalPointAndSetup(t 480 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true); 577 481 578 482 579 November 6, 1998 M. Verderi 483 November 6, 1998 M. Verderi 580 - Extension of the G4FastStep to allow the 484 - Extension of the G4FastStep to allow the biasing technic. 581 Changes are made in: 485 Changes are made in: 582 - G4FastStep.hh/.icc: 486 - G4FastStep.hh/.icc: 583 new member G4BiasingTa 487 new member G4BiasingTag fBiasTag; 584 new method SetPrimaryT 488 new method SetPrimaryTrackFinalBiasingTag 585 ( G4BiasingTag 489 ( G4BiasingTag aTag ); 586 - G4FastStep.cc: 490 - G4FastStep.cc: 587 Initialize(); 491 Initialize(); 588 operator=; << 492 operator=; 589 UpdateForPostStep(); 493 UpdateForPostStep(); 590 UpdateForAtRest(); << 494 UpdateForAtRest(); 591 495 592 October 26, 1998 P.Mora de Freitas 496 October 26, 1998 P.Mora de Freitas 593 - G4FastSimulationManagerProcess and G4Fast 497 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal 594 with at rest parameterisations also when 498 with at rest parameterisations also when using parallel geometry. 595 499 596 October 8, 1998 P.Mora de Freitas 500 October 8, 1998 P.Mora de Freitas 597 - The G4VFastSimulationModel::IsApplicable( 501 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual 598 methode. 502 methode. 599 - G4FastSimulationManager optimisation: 503 - G4FastSimulationManager optimisation: 600 - New G4ParticleDefinition* fLastCrossedP 504 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps 601 the last particle type with touched the 505 the last particle type with touched the envelope; 602 - New G4RWTPtrOrderedVector<G4VFastSimula 506 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList 603 data member, keeps the model list of th << 507 data member, keeps the model list of the applicable models for 604 the actual fLastCrossedParticle particl 508 the actual fLastCrossedParticle particle type; 605 - Changes in the PostStepGetFastSimulatio << 509 - Changes in the PostStepGetFastSimulationManagerTrigger() and 606 AtRestGetFastSimulationManagerTrigger() << 510 AtRestGetFastSimulationManagerTrigger()methodes to update the 607 fApplicableModelList when needed (fLast 511 fApplicableModelList when needed (fLastCrossedParticle != 608 the actual tracked particle); 512 the actual tracked particle); 609 - Changes in the << 513 - Changes in the 610 G4FastSimulationManager() (Constructor) 514 G4FastSimulationManager() (Constructor) 611 ActivateFastSimulationModel(), 515 ActivateFastSimulationModel(), 612 InActivateFastSimulationModel(), 516 InActivateFastSimulationModel(), 613 AtRestGetFastSimulationManagerTrigger(), 517 AtRestGetFastSimulationManagerTrigger(), 614 AddFastSimulationModel(), 518 AddFastSimulationModel(), 615 RemoveFastSimulationModel() 519 RemoveFastSimulationModel() 616 methodes to set the fLastCrossedParticle to 520 methodes to set the fLastCrossedParticle to NULL, forcing the 617 fApplicableModelList to be rebuilt. 521 fApplicableModelList to be rebuilt. 618 522 619 September 22, 1998 P.Mora de Freitas 523 September 22, 1998 P.Mora de Freitas 620 Fixed bug in parallel navigation. << 524 Fixed bug in parallel navigation. 621 File touched: G4FastSimulationManagerProces 525 File touched: G4FastSimulationManagerProcess.cc 622 Tested on HP-aCC. 526 Tested on HP-aCC. 623 527 624 September 17, 1998 P.Mora de Freitas 528 September 17, 1998 P.Mora de Freitas 625 G4FastSimulationManager::RemoveFastSimulati 529 G4FastSimulationManager::RemoveFastSimulationModel() updated to look 626 for also in the fInactivatedModels list. 530 for also in the fInactivatedModels list. 627 531 628 Tested on HP-aCC. 532 Tested on HP-aCC. 629 533 630 September 16, 1998 P.Mora de Freitas 534 September 16, 1998 P.Mora de Freitas 631 New /param/ control commands: 535 New /param/ control commands: 632 536 633 /param/ActivateModel <ModelName> 537 /param/ActivateModel <ModelName> 634 /param/InActivateModel <ModelName> 538 /param/InActivateModel <ModelName> 635 539 636 Activate or inactivate a given parameterisat 540 Activate or inactivate a given parameterisation model. 637 541 638 Tested on HP-aCC. 542 Tested on HP-aCC. 639 543 640 August 21, 1998 P.Mora de Freitas 544 August 21, 1998 P.Mora de Freitas 641 G4FastSimulationManagerProcess's G4ProcessTy 545 G4FastSimulationManagerProcess's G4ProcessType set to 642 fParameterisation, accordingly with procman-00 546 fParameterisation, accordingly with procman-00-02-03. 643 547 644 Tested on HP-aCC. 548 Tested on HP-aCC. 645 549 646 August 12, 1998 P.Mora de Freitas 550 August 12, 1998 P.Mora de Freitas 647 Improved the "close parameterisation control << 551 Improved the "close parameterisation control" to 648 552 649 1) avoid the close looping when unnecessary 553 1) avoid the close looping when unnecessary (mostly cases); 650 2) force re-close when necessary (insert/rem 554 2) force re-close when necessary (insert/remove ghosts). 651 555 652 Changes: 556 Changes: 653 557 654 1) the G4GlobalFastSimulationManager::fClose << 558 1) the G4GlobalFastSimulationManager::fClosed is now initialised 655 to true by the G4GlobalFastSimulationMana 559 to true by the G4GlobalFastSimulationManager constructor; 656 560 657 2) new method << 561 2) new method 658 562 659 void << 563 void 660 G4GlobalFastSimulationManager::FastSimula 564 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed(); 661 565 662 called by the AddGhostPlacement and Remov << 566 called by the AddGhostPlacement and RemoveGhostPlacement 663 G4FastSimulationManager methods to set fa 567 G4FastSimulationManager methods to set false the fClosed flag; 664 568 665 3) changes in the G4GlobalFastSimulationMana 569 3) changes in the G4GlobalFastSimulationManager::Notify method 666 to deal with these changes. 570 to deal with these changes. 667 571 668 Tested on HP-aCC. 572 Tested on HP-aCC. 669 573 670 August 11, 1998 P.Mora de Freitas 574 August 11, 1998 P.Mora de Freitas 671 Fix to the G4FastStep::KillPrimaryTrack() me 575 Fix to the G4FastStep::KillPrimaryTrack() method to drop the 672 nonsense line 576 nonsense line 673 577 674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 578 SetMomentumChange(0.,0.,0.) ; /* necessary ? */ 675 579 676 Tested on HP-aCC. 580 Tested on HP-aCC. 677 (Thanks to Willy Langeveld) 581 (Thanks to Willy Langeveld) 678 582 679 583 680 August 10, 1998 P.Mora de Freitas 584 August 10, 1998 P.Mora de Freitas 681 Fix to the SetPrimaryTrackFinalKineticEnergy 585 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method 682 from the G4FastStep class the SetMomentumChang 586 from the G4FastStep class the SetMomentumChange() call to insure that 683 the new momentum direction is a unit vector (a << 587 the new momentum direction is a unit vector (as asked by the 684 G4DynamicParticle::SetMomentumDirection method 588 G4DynamicParticle::SetMomentumDirection method). 685 589 686 Touched files: G4FastStep.hh (improved comme 590 Touched files: G4FastStep.hh (improved comments) 687 G4FastStep.cc (fixed) 591 G4FastStep.cc (fixed) 688 592 689 Tested on HP-aCC. 593 Tested on HP-aCC. 690 (Thanks to Willy Langeveld) 594 (Thanks to Willy Langeveld) 691 595 692 August 7, 1998 P.Mora de Freitas 596 August 7, 1998 P.Mora de Freitas 693 New /param/ commands directory with the comm 597 New /param/ commands directory with the commands: 694 598 695 /param/listEnvelopes [ParticleName] 599 /param/listEnvelopes [ParticleName] 696 600 697 - List all the envelope names for a given pa 601 - List all the envelope names for a given particle 698 (or for all particles if without parameter 602 (or for all particles if without parameters). 699 603 700 /param/listModels [EnvelopeName] 604 /param/listModels [EnvelopeName] 701 605 702 - List all the Model names for a given envel 606 - List all the Model names for a given envelope 703 (or for all envelopes if without parameter 607 (or for all envelopes if without parameters). 704 608 705 /param/listIsApplicable [ModelName] 609 /param/listIsApplicable [ModelName] 706 610 707 - List all the particle names a given model 611 - List all the particle names a given model is applicable 708 (or for all models if without parameters). 612 (or for all models if without parameters). 709 613 710 614 711 August 7, 1998 P.Mora de Freitas 615 August 7, 1998 P.Mora de Freitas 712 History file Created. 616 History file Created.