Geant4 Cross Reference |
1 # Category param History << 1 $Id: History,v 1.35 2007/05/18 15:25:29 mverderi Exp $ >> 2 ------------------------------------------------------------------- 2 3 3 See `CONTRIBUTING.rst` for details of **requir << 4 ========================================================= 4 which **must** added in reverse chronological << 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP 5 It must **not** be used as a substitute for wr << 6 ========================================================= 6 << 7 7 ---------------------------------------------- << 8 Category History file 8 << 9 --------------------- 9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) << 10 This file should be used by G4 developers and category coordinators 10 - In G4GlobalFastSimulationManager: << 11 to briefly summarize all major modifications introduced in the code 11 use G4ThreadLocalSingleton to avoid undelete << 12 and keep track of all category-tags. 12 << 13 It DOES NOT substitute the CVS log-message one should put at every 13 ## 2023-10-18 Ben Morgan (param-V11-01-03) << 14 committal in the CVS repository ! 14 - Apply standard and extended clang-tidy fixes << 15 15 - Mark empty/obsolete functions as deprecated << 16 ---------------------------------------------------------- 16 << 17 * Reverse chronological order (last date on top), please * 17 ## 2023-10-16 Ben Morgan (param-V11-01-02) << 18 ---------------------------------------------------------- 18 - Apply standard clang-format-ing. << 19 - Normal order accessors and docstrings. << 20 << 21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) << 22 - In G4FastTrack, removed references to G4Touc << 23 which is now deprecated. << 24 << 25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 << 26 - Added missing virtual destructor to G4VFastS << 27 << 28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) << 29 - Fixed compilation warnings for implicit type << 30 << 31 ## 2022-10-27 Makoto Asai (param-V11-00-03) << 32 - G4FastSimHitMaker - making compatible to com << 33 << 34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 << 35 - G4FastStep - delete copy constructor and ope << 36 << 37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) << 38 - Adding the 'flush' method to the fast simula << 39 This method allows to process the input buff << 40 the end of the G4 event. It is used when par << 41 The 'flash' is triggered inside the event lo << 42 The fast simulation model may add secondarie << 43 by Geant4. << 44 << 45 ## 2021-12-10 Ben Morgan (param-V11-00-00) << 46 - Change to new Markdown History format << 47 << 48 --- << 49 << 50 # History entries prior to 11.0 << 51 << 52 April 16, 2021 Ben Morgan (param-V10-07-00) << 53 - Migrate build to modular CMake API << 54 << 55 October 5, 2020, A. Zaborowska (param-V10-06-0 << 56 - Introduce general facilities based on GFlash << 57 to facilitate multiple hit (energy & positio << 58 from fast simulation models. << 59 << 60 September 9, 2020, G. Cosmo (param-V10-06-02) << 61 - Fixed minor Coverity defect for uninitialise << 62 << 63 April 21, 2020, A. Zaborowska (param-V10-06-01 << 64 - Sanity check for root logical volumes for re << 65 UI command /param/showSetup works also if no << 66 << 67 March 26, 2020, I. Semeniouk (param-V10-06-00) << 68 - G4FastSimulationHelper : merge ActivateFastS << 69 - G4FastSimulationManager.hh, G4VFastSimulatio << 70 redefinition of G4Envelope type << 71 << 72 October 30, 2019, A. Zaborowska (param-v10-05- << 73 - Register G4FastSimulationManagerProcess with << 74 G4FastSimulationManagerHelper to ensure it i << 75 invoked for a given step (ExclusivelyForced) << 76 StronglyForced processes will be considered. << 77 << 78 December 19, 2017, G. Cosmo (param-V10-04-00) << 79 - Fixed self-consistency in G4FastSimulationVe << 80 Thanks to Raphael Isemann for reporting this << 81 << 82 November 03, 2016, M. Verderi (param-V10-02-01 << 83 - New G4FastSimulationManagerHelper utility fo << 84 adding G4FastSimulationManagerProcess to a << 85 process manager. << 86 << 87 November 02, 2016, M. Verderi (param-V10-02-00 << 88 - fix various Coverity defects. << 89 << 90 March 27, 2013, M. Verderi (param-V09-06-00) << 91 - remove unused field 'fOnBoundary' in G4FastS << 92 as this was causing a warning from clang. << 93 << 94 July 10, 2012, G. Cosmo (param-V09-05-00) << 95 - Explicitly use inclusion of headers for syst << 96 constants, in plan to remove implicit inclus << 97 << 98 September 30, 2011, M. Verderi (param-V09-04-0 << 99 - Added missing new header file (G4FastSimulat << 100 sources.cmake. << 101 << 102 September 30, 2011, M. Verderi (param-V09-04-0 << 103 - Migration to new G4Exception scheme. << 104 - what is V09-04-01 tag ? << 105 << 106 February 11, 2011, M. Verderi (param-V09-04-00 << 107 - Implementation of method << 108 void ProposePrimaryTrackFinalKineticEnergy ( << 109 was missing : modified file G4FastStep.icc << 110 << 111 March 13, 2008, G. Cosmo (param-V09-01-00) << 112 - Cleared compilation warnings in G4FastSimula << 113 G4FastSimulationMessenger on gcc-4.3.0 for a << 114 parentheses in nested if-else statements. << 115 << 116 November 30, 2007, M. Verderi << 117 - Add Along methods to G4FSMP process << 118 - tag as param-V09-00-01 << 119 << 120 November 30, 2007, M. Verderi << 121 - minor corrections to G4FastSimulationManager << 122 * add call fPathFinder->prepareNewrack(...) << 123 * deactivate ghost navigator in EndOfTracki << 124 - tag as param-V09-00-00 << 125 19 126 May 18, 2007, M. Verderi 20 May 18, 2007, M. Verderi 127 - tag as param-V08-03-00 21 - tag as param-V08-03-00 128 22 129 May 11, 2007, M. Verderi 23 May 11, 2007, M. Verderi 130 - remove include/G4FastSimulationManagerProces 24 - remove include/G4FastSimulationManagerProcess81.hh 131 include/G4FlavoredParallelWorld.hh 25 include/G4FlavoredParallelWorld.hh 132 include/G4GFSManager81.hh 26 include/G4GFSManager81.hh 133 src/G4FastSimulationManagerProcess81. 27 src/G4FastSimulationManagerProcess81.cc 134 src/G4GFSManager81.cc 28 src/G4GFSManager81.cc 135 29 136 30 137 November 10, 2006, M. Verderi - param-V08-01-0 31 November 10, 2006, M. Verderi - param-V08-01-00 138 - Limited number of warning messages printed b 32 - Limited number of warning messages printed by the 139 G4GlobalFastSimulationManager. 33 G4GlobalFastSimulationManager. 140 - Renamed G4FastSimulationManagerProcess_forCo 34 - Renamed G4FastSimulationManagerProcess_forCoupledTransportation with 141 G4FastSimulationManagerProcess81. 35 G4FastSimulationManagerProcess81. 142 In addition, this class can now handle the c 36 In addition, this class can now handle the case of Navigator index=0, 143 i.e., the navigator for tracking, regardless 37 i.e., the navigator for tracking, regardless the G4Transportation or 144 G4CoupledTransportation is used. (For other 38 G4CoupledTransportation is used. (For other navigators, there is 145 of course no choice, and G4CoupledTransporta 39 of course no choice, and G4CoupledTransportation is necessary.) 146 40 147 November 3, 2006 M. Verderi 41 November 3, 2006 M. Verderi 148 - Introduced G4FastSimulationManagerProcess_fo 42 - Introduced G4FastSimulationManagerProcess_forCoupledTransportation class for 149 handling fast simulation in new parallel geo 43 handling fast simulation in new parallel geometry scheme. This requires 150 the G4CoupledTransportation to be active. 44 the G4CoupledTransportation to be active. 151 - Introduced G4GFSManager81 class that gathers 45 - Introduced G4GFSManager81 class that gathers the future code to become the 152 default at next major release in the G4Globa 46 default at next major release in the G4GlobalFastSimulationManager class. 153 - G4FastSimulationManager: adapted to new sche 47 - G4FastSimulationManager: adapted to new scheme. Still has old code for 154 backward compatibilty. 48 backward compatibilty. 155 - G4FastSimulationManagerProcess: mostly the s 49 - G4FastSimulationManagerProcess: mostly the same, apart from a small bug fix. 156 - G4FastSimulationMessenger: new command creat 50 - G4FastSimulationMessenger: new command created "/param/showSetup", useful 157 to show the fast simulation setup (region, m 51 to show the fast simulation setup (region, models, processes, etc...) 158 It is only valid for geometry closed state. 52 It is only valid for geometry closed state. Desirable to have interactive 159 command in the run manager for this. 53 command in the run manager for this. 160 54 161 November 25, 2005, M.Verderi - param-V07-01-0 55 November 25, 2005, M.Verderi - param-V07-01-04 162 - put back Makoto's change: StartTracking(G4Tr 56 - put back Makoto's change: StartTracking(G4Track*) 163 57 164 November 25, 2005, M Verderi - param-V07-01-03 58 November 25, 2005, M Verderi - param-V07-01-03 165 - Make ghost functionnality available with G4R 59 - Make ghost functionnality available with G4Region 166 - ** Note ** Change back StartTracking(G4Track 60 - ** Note ** Change back StartTracking(G4Track*) -> StartTracking() in G4FSMP 167 StartTracking(G4Track*) was intro 61 StartTracking(G4Track*) was introduced in param-V07-01-02 168 because (I guess) of procman-V07-01-01 62 because (I guess) of procman-V07-01-01 169 This is to make param-V07-01-03 compatible w 63 This is to make param-V07-01-03 compatible with geant4-07-01-ref-05 170 64 171 November 21, 2005 M.Asai - param-V07-01-02 65 November 21, 2005 M.Asai - param-V07-01-02 172 - Fix warning message. 66 - Fix warning message. 173 67 174 November 02, 2005 G.Cosmo - param-V07-01-01 68 November 02, 2005 G.Cosmo - param-V07-01-01 175 - Corrected setting of envelope volumes and so 69 - Corrected setting of envelope volumes and solid in G4FastTrack. 176 - Migrated old scheme for G4Exception and some 70 - Migrated old scheme for G4Exception and some cosmetics... 177 71 178 October 28, 2005 M.Asai - param-V07-01-00 72 October 28, 2005 M.Asai - param-V07-01-00 179 - Working tag for merging "envelope" to G4Regi 73 - Working tag for merging "envelope" to G4Region. 180 74 181 December 07, 2004 G. Cosmo - param-V06-02-01 75 December 07, 2004 G. Cosmo - param-V06-02-01 182 - Implemented migration to <cmath>. 76 - Implemented migration to <cmath>. 183 77 184 November 26, 2004 M. Verderi - param-V06-02-00 78 November 26, 2004 M. Verderi - param-V06-02-00 185 - Implemented migration to new G4VParticleChan 79 - Implemented migration to new G4VParticleChange interfaces. 186 80 187 December 12, 2003 G. Cosmo - param-V06-00-00 81 December 12, 2003 G. Cosmo - param-V06-00-00 188 - G4FastSimulationVector.icc: use std_pvector: 82 - G4FastSimulationVector.icc: use std_pvector:: scope for calls to 189 base class. Fixes compilation problem on Int 83 base class. Fixes compilation problem on Intel-icc compiler. 190 84 191 November 10, 2003 G. Cosmo - param-V05-02-01 85 November 10, 2003 G. Cosmo - param-V05-02-01 192 - G4FastTrack: use G4Navigator::CreateTouchabl 86 - G4FastTrack: use G4Navigator::CreateTouchableHistoryHandle() instead of 193 CreateTouchableHistory() in method FRecordsA 87 CreateTouchableHistory() in method FRecordsAffineTransformation(). 194 88 195 October 4, 2003 G. Cosmo - param-V05-02-00 89 October 4, 2003 G. Cosmo - param-V05-02-00 196 - Modified GNUmakefile: 90 - Modified GNUmakefile: 197 o added dependency to new module "geometry/n 91 o added dependency to new module "geometry/navigation". 198 - Coworks with "geometry-V05-02-00" and "digit 92 - Coworks with "geometry-V05-02-00" and "digits_hits-V05-02-00". 199 93 200 May 21, 2003 G. Cosmo - param-V05-01-00 94 May 21, 2003 G. Cosmo - param-V05-01-00 201 o Fixed pedantic warnings on Linux-g++ 95 o Fixed pedantic warnings on Linux-g++. 202 o Call base class in copy-constructor 96 o Call base class in copy-constructor of G4FastStep. 203 97 204 Nov 20, 2002 G. Cosmo - param-V04-01-02 98 Nov 20, 2002 G. Cosmo - param-V04-01-02 205 o Patched access to public static data in G4 99 o Patched access to public static data in G4FastStep.cc 206 and G4GlobalFastSimulationManager.cc to al 100 and G4GlobalFastSimulationManager.cc to allow porting on 207 Windows DLLs. 101 Windows DLLs. 208 102 209 Nov 15, 2002 S. Sadilov - param-V04-01-01 103 Nov 15, 2002 S. Sadilov - param-V04-01-01 210 o Fixed compilation problems on Windows in 104 o Fixed compilation problems on Windows in 211 G4FastSimulationManager.cc and G4GlobalFas 105 G4FastSimulationManager.cc and G4GlobalFastSimulationManager.cc 212 106 213 Nov 02, 2002 M. Verderi - param-V04-01-00 107 Nov 02, 2002 M. Verderi - param-V04-01-00 214 o Add method to retrieve G4VFastSimulationMo 108 o Add method to retrieve G4VFastSimulationModel by name. 215 The user's method is in G4GlobalFastSimula 109 The user's method is in G4GlobalFastSimulationManager: 216 110 217 GetFastSimulationModel(); 111 GetFastSimulationModel(); 218 112 219 it is accompagnied by same methods name in 113 it is accompagnied by same methods name in 220 G4FastSimulationManager class. 114 G4FastSimulationManager class. 221 115 222 o Add "test" directory, used to test above f 116 o Add "test" directory, used to test above feature. 223 117 224 Oct 26, 2001 M. Verderi - param-V03-02-00 118 Oct 26, 2001 M. Verderi - param-V03-02-00 225 Fixes to clear warnings produced with gcc-2. 119 Fixes to clear warnings produced with gcc-2.95.2: 226 - loop index, where comparison with method " 120 - loop index, where comparison with method "size()" of 227 G4std::vector<T>, changed: int -> size_t << 121 G4std::vector<T>, changed: int -> size_t 228 - change "if ( a=b ) {..}" by "if ( (a=b) ) 122 - change "if ( a=b ) {..}" by "if ( (a=b) ) {...}" 229 this makes the compiler sure you want to mak 123 this makes the compiler sure you want to make an 230 assignement in the "if" condition 124 assignement in the "if" condition 231 - re-order initialisations of a few variable 125 - re-order initialisations of a few variables in constructors 232 to match the declaration order. 126 to match the declaration order. 233 Some warnings still exist, but regard the G4 127 Some warnings still exist, but regard the G4Propagator of geometry. 234 128 235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 129 Apr 3, 2001 J. Apostolakis - param-V03-00-00 236 - Modified G4FastSimulationManagerProcess call 130 - Modified G4FastSimulationManagerProcess call to PropagatorInField ComputeStep 237 to use new interface with G4FieldTrack (in 131 to use new interface with G4FieldTrack (in place of now obsolete interface.) 238 132 239 Nov 14, 2000 G. Cosmo - param-V02-00-01 133 Nov 14, 2000 G. Cosmo - param-V02-00-01 240 - Moved specific parameterisation models to th 134 - Moved specific parameterisation models to the new top category 241 "parameterisations". Moved files: 135 "parameterisations". Moved files: 242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm 136 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRmodel[.hh.cc], 243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster 137 G4IrregularXrayTRmodel[.hh.cc], G4PAIclusterModel[.hh.cc], 244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr 138 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXrayTRmodel[.hh.cc], 245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode 139 G4RegularXrayTRmodel[.hh.cc], G4VClusterModel[.hh.cc], 246 G4VXrayTRmodel[.hh.cc]. 140 G4VXrayTRmodel[.hh.cc]. 247 - Cleaned-up GNUmakefile of non necessary depe 141 - Cleaned-up GNUmakefile of non necessary dependencies. 248 142 249 Aug 03, 2000 G. Cosmo - param-V02-00-00r 143 Aug 03, 2000 G. Cosmo - param-V02-00-00r 250 - Changed RandGauss to G4RandGauss in G4Irregu 144 - Changed RandGauss to G4RandGauss in G4IrregularXrayTRmodel.cc and 251 G4VXrayTRmodel.cc to fix events' reproducibi 145 G4VXrayTRmodel.cc to fix events' reproducibility problem. 252 - G4VXrayTRmodel.cc: fix to class destructor ( 146 - G4VXrayTRmodel.cc: fix to class destructor (V.Grichine) 253 147 254 Jun 15, 2000 G. Cosmo - param-V01-01-04 148 Jun 15, 2000 G. Cosmo - param-V01-01-04 255 - The tag coworks with global-V01-01-04 and ma 149 - The tag coworks with global-V01-01-04 and materials-V01-01-00: 256 o Fixed usage of G4complex type for ISO and 150 o Fixed usage of G4complex type for ISO and non-ISO compilers. 257 Affected files: G4FoamXrayTRmodel.cc, G4Ga 151 Affected files: G4FoamXrayTRmodel.cc, G4GamDistrXrayTRmodel.cc, G4PlateIrrGasXrayTRmodel.cc 258 and G4RegularXrayTRmodel.c 152 and G4RegularXrayTRmodel.cc. 259 In case of G4complex types passed to mathe 153 In case of G4complex types passed to mathematical functions, use G4std:: prefix. 260 o Fixed usage of G4Integrator class, now cha 154 o Fixed usage of G4Integrator class, now changed to templated to allow porting of the 261 code on SUN-CC compiler which does not imp 155 code on SUN-CC compiler which does not implement templated member functions. 262 Affected files: G4VXrayTRmodel[.hh.cc] 156 Affected files: G4VXrayTRmodel[.hh.cc] 263 157 264 Jun 6, 2000 M. Verderi & P. Mora de Freitas 158 Jun 6, 2000 M. Verderi & P. Mora de Freitas 265 - fixed compilation errors with HP-aCC for the 159 - fixed compilation errors with HP-aCC for the files G4RegularXrayTRmodel.cc, 266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod 160 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmodel.cc. 267 161 268 May 30, 2000 M. Verderi & P. Mora de Freitas 162 May 30, 2000 M. Verderi & P. Mora de Freitas 269 163 270 - parameterisation category is now RW free. 164 - parameterisation category is now RW free. 271 165 272 September 16, 1999 M. Verderi & P. Mora de Fre 166 September 16, 1999 M. Verderi & P. Mora de Freitas 273 167 274 - Fixed bug in G4FastStep::CheckIt() method. 168 - Fixed bug in G4FastStep::CheckIt() method. 275 169 276 April 19, 1999 M. Verderi & P. Mora de Freitas 170 April 19, 1999 M. Verderi & P. Mora de Freitas 277 171 278 Changes in G4FastStep to co-work with track-01 172 Changes in G4FastStep to co-work with track-01-00-04: 279 173 280 1) The method void CheckIt(const G4Track&) bec << 174 1) The method void CheckIt(const G4Track&) becomes 281 G4bool CheckIt(const G4Track&); 175 G4bool CheckIt(const G4Track&); 282 2) The FAST_STEP_DEBUG compiling option disapp 176 2) The FAST_STEP_DEBUG compiling option disappears; 283 3) Call to CheckIt controled by the G4VParticl 177 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute. 284 178 285 Miscellaneous: the declaration "G4double mass 179 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh 286 corrected to G4double mass =...". 180 corrected to G4double mass =...". 287 181 288 April 15, 1999 M. Verderi & P. Mora de Freitas 182 April 15, 1999 M. Verderi & P. Mora de Freitas 289 183 290 Tasks to decouple visualization from processes 184 Tasks to decouple visualization from processes/parameterisation: 291 185 292 1) G4GlobalFastSimulationManager now inherites 186 1) G4GlobalFastSimulationManager now inherites from the intercoms/ 293 G4VGlobalFastSimulationManager to allow visual << 187 G4VGlobalFastSimulationManager to allow visualisation to get a 294 concrete instance pointer to the G4GlobalFastS 188 concrete instance pointer to the G4GlobalFastSimulationManager, 295 if any. 189 if any. 296 190 297 2) G4FlavoredParallelWorld now inherites from 191 2) G4FlavoredParallelWorld now inherites from the intercoms/ 298 G4VFlavoredParallelWorld, a pure virtual abstr 192 G4VFlavoredParallelWorld, a pure virtual abstract class to interface 299 parameterisation with visualization. 193 parameterisation with visualization. 300 194 301 Co-works with intercoms-01-00-01 tag 195 Co-works with intercoms-01-00-01 tag 302 196 303 Modified files: 197 Modified files: 304 --------------- 198 --------------- 305 G4FlavoredParallelWorld.hh 199 G4FlavoredParallelWorld.hh 306 G4GlobalFastSimulationManager.hh 200 G4GlobalFastSimulationManager.hh 307 G4GlobalFastSimulationManager.cc 201 G4GlobalFastSimulationManager.cc 308 202 309 Done, tested, system-tested on HP-aCC with exe 203 Done, tested, system-tested on HP-aCC with exemple N05. 310 204 311 April 14, 1999 M. Verderi & P. Mora de Freitas 205 April 14, 1999 M. Verderi & P. Mora de Freitas 312 206 313 Several consolidation tasks (thanks to G. Cosm 207 Several consolidation tasks (thanks to G. Cosmo): 314 208 315 1) Warning: << 209 1) Warning: 316 ----------- 210 ----------- 317 211 318 Pointers usage 212 Pointers usage 319 213 320 - Setting pointers to 0 after delete: 214 - Setting pointers to 0 after delete: 321 215 322 delete pA; 216 delete pA; 323 pA = 0; 217 pA = 0; 324 218 325 - Avoid to use "NULL". 219 - Avoid to use "NULL". 326 220 327 Modified files: 221 Modified files: 328 --------------- 222 --------------- 329 G4FastSimulationManager.hh 223 G4FastSimulationManager.hh 330 G4FastTrack.hh 224 G4FastTrack.hh 331 G4FlavoredParallelWorld.hh 225 G4FlavoredParallelWorld.hh 332 G4FastSimulationManager.cc 226 G4FastSimulationManager.cc 333 G4FastSimulationMessenger.cc 227 G4FastSimulationMessenger.cc 334 G4FastSimulationManagerProcess.cc 228 G4FastSimulationManagerProcess.cc 335 G4FastTrack.cc 229 G4FastTrack.cc 336 G4GlobalFastSimulationManager.cc 230 G4GlobalFastSimulationManager.cc 337 G4VFastSimulationModel.cc 231 G4VFastSimulationModel.cc 338 232 339 Status: << 233 Status: 340 ------- 234 ------- 341 Done, tested, system-tested on HP-aCC with exe 235 Done, tested, system-tested on HP-aCC with exemple N05. 342 236 343 2) Warning: 237 2) Warning: 344 ----------- 238 ----------- 345 include/G4FastSimulationManager.hh:163 239 include/G4FastSimulationManager.hh:163 346 Public member functions shall always retur 240 Public member functions shall always return const handles to member data 347 Severe violation: Universal Coding Standar 241 Severe violation: Universal Coding Standards item 18 348 242 349 offending code: 243 offending code: 350 --------------- 244 --------------- 351 inline G4VParticleChange* G4FastSimulationMana 245 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange() 352 { 246 { 353 return &fFastStep; 247 return &fFastStep; 354 } 248 } 355 249 356 Diagnostic: 250 Diagnostic: 357 ---------- 251 ---------- 358 252 359 Called by the G4FastSimulationManagerProcess << 253 Called by the G4FastSimulationManagerProcess to return it in the 360 PostStepDoIt call. << 254 PostStepDoIt call. 361 255 362 Action: 256 Action: 363 ------- 257 ------- 364 The G4FastSimulationManager::GettheParticleCha 258 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any 365 more. The G4VParticleChange* is now returned d 259 more. The G4VParticleChange* is now returned directly when invoking the 366 G4FastSimulationManager::InvokePostStepDoIt() 260 G4FastSimulationManager::InvokePostStepDoIt() and 367 G4FastSimulationManager::InvokeAtRestDoIt() me 261 G4FastSimulationManager::InvokeAtRestDoIt() methodes. 368 262 369 Modified files: 263 Modified files: 370 --------------- 264 --------------- 371 G4FastSimulationManager.hh 265 G4FastSimulationManager.hh 372 G4FastSimulationManager.cc 266 G4FastSimulationManager.cc 373 G4FastSimulationManagerProcess.cc 267 G4FastSimulationManagerProcess.cc 374 268 375 Status: << 269 Status: 376 ------- 270 ------- 377 Done, tested, system-tested on HP-aCC with exe 271 Done, tested, system-tested on HP-aCC with exemple N05. 378 272 379 3) Warning: 273 3) Warning: 380 ----------- 274 ----------- 381 include/G4FastSimulationManagerProcess.hh:52 275 include/G4FastSimulationManagerProcess.hh:52 382 If a class has virtual functions it shall 276 If a class has virtual functions it shall have a virtual destructor 383 Severe violation: Universal Coding Standar 277 Severe violation: Universal Coding Standards item 17 384 class G4FastSimulationManagerProcess has v 278 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor. 385 279 386 offending code: 280 offending code: 387 --------------- 281 --------------- 388 ~G4FastSimulationManagerProcess(); 282 ~G4FastSimulationManagerProcess(); 389 283 390 Diagnostic: 284 Diagnostic: 391 ---------- 285 ---------- 392 Nobody should inherites from G4FastSimulatio << 286 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual 393 is added. 287 is added. 394 288 395 Action: 289 Action: 396 ------- 290 ------- 397 virtual ~G4FastSimulationManagerProcess(); 291 virtual ~G4FastSimulationManagerProcess(); 398 292 399 Modified files: 293 Modified files: 400 --------------- 294 --------------- 401 G4FastSimulationManagerProcess.hh 295 G4FastSimulationManagerProcess.hh 402 296 403 Status: << 297 Status: 404 ------- 298 ------- 405 Done. 299 Done. 406 300 407 4) Warning: 301 4) Warning: 408 ----------- 302 ----------- 409 include/G4FastSimulationMessenger.hh:36 303 include/G4FastSimulationMessenger.hh:36 410 If a class has virtual functions it shall 304 If a class has virtual functions it shall have a virtual destructor 411 Severe violation: Universal Coding Standar 305 Severe violation: Universal Coding Standards item 17 412 class G4FastSimulationMessenger has virtua 306 class G4FastSimulationMessenger has virtual functions without a virtual destructor. 413 307 414 308 415 offending code: 309 offending code: 416 --------------- 310 --------------- 417 ~G4FastSimulationMessenger(); 311 ~G4FastSimulationMessenger(); 418 312 419 Diagnostic: 313 Diagnostic: 420 ---------- 314 ---------- 421 Nobody should inherites from G4FastSimulatio << 315 Nobody should inherites from G4FastSimulationMessenger BUT for virtual 422 is added. 316 is added. 423 317 424 Action: 318 Action: 425 ------- 319 ------- 426 virtual ~G4FastSimulationMessenger(); 320 virtual ~G4FastSimulationMessenger(); 427 321 428 Modified files: 322 Modified files: 429 --------------- 323 --------------- 430 G4FastSimulationMessenger.hh 324 G4FastSimulationMessenger.hh 431 325 432 Status: << 326 Status: 433 ------- 327 ------- 434 Done. 328 Done. 435 329 436 5) Warning: 330 5) Warning: 437 ----------- 331 ----------- 438 include/G4FastStep.hh:224 332 include/G4FastStep.hh:224 439 Operator= should call base class operator= 333 Operator= should call base class operator= 440 Possible severe violation: Effective C++ i 334 Possible severe violation: Effective C++ item 16 441 operator= in class G4FastStep, should call 335 operator= in class G4FastStep, should call operator= in base class G4VParticleChange 442 336 443 offending code: 337 offending code: 444 --------------- 338 --------------- 445 G4FastStep & G4FastStep::operator=(const G4Fas 339 G4FastStep & G4FastStep::operator=(const G4FastStep &right) 446 { 340 { 447 if (this != &right) 341 if (this != &right) 448 { 342 { 449 theListOfSecondaries = right.th 343 theListOfSecondaries = right.theListOfSecondaries; 450 theSizeOftheListOfSecondaries = right.th 344 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries; 451 theNumberOfSecondaries = right.th 345 theNumberOfSecondaries = right.theNumberOfSecondaries; 452 theStatusChange = right.th 346 theStatusChange = right.theStatusChange; 453 theMomentumChange = right.th 347 theMomentumChange = right.theMomentumChange; 454 thePolarizationChange = right.th 348 thePolarizationChange = right.thePolarizationChange; 455 thePositionChange = right.th 349 thePositionChange = right.thePositionChange; 456 theTimeChange = right.th 350 theTimeChange = right.theTimeChange; 457 theEnergyChange = right.th 351 theEnergyChange = right.theEnergyChange; 458 theTrueStepLength = right.th 352 theTrueStepLength = right.theTrueStepLength; 459 theLocalEnergyDeposit = right.th 353 theLocalEnergyDeposit = right.theLocalEnergyDeposit; 460 theSteppingControlFlag = right.th 354 theSteppingControlFlag = right.theSteppingControlFlag; 461 theWeightChange = right.th 355 theWeightChange = right.theWeightChange; 462 } 356 } 463 return *this; 357 return *this; 464 } 358 } 465 359 466 Diagnostic: 360 Diagnostic: 467 ---------- 361 ---------- 468 Bug detected. 362 Bug detected. 469 363 470 Action: 364 Action: 471 ------- 365 ------- 472 Insert the call 366 Insert the call 473 G4VParticleChange::operator=(right); 367 G4VParticleChange::operator=(right); 474 368 475 Status: 369 Status: 476 ------- 370 ------- 477 Done, tested, system-tested on HP-aCC with e 371 Done, tested, system-tested on HP-aCC with exemple N05. 478 372 479 Modified files: 373 Modified files: 480 --------------- 374 --------------- 481 G4FastStep.cc 375 G4FastStep.cc 482 376 483 6) Warning: 377 6) Warning: 484 ----------- 378 ----------- 485 include/G4FastStep.hh:59 379 include/G4FastStep.hh:59 486 Avoid data members in the public interface 380 Avoid data members in the public interface 487 Violation: Effective C++ item 20 381 Violation: Effective C++ item 20 488 Public data members for class G4FastStep: 382 Public data members for class G4FastStep: 489 debugFlag 383 debugFlag 490 384 491 385 492 offending code: 386 offending code: 493 --------------- 387 --------------- 494 public: 388 public: 495 ... 389 ... 496 G4bool debugFlag; 390 G4bool debugFlag; 497 391 498 Diagnostic: 392 Diagnostic: 499 ---------- 393 ---------- 500 Historical usage. 394 Historical usage. 501 395 502 Action: 396 Action: 503 ------- 397 ------- 504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 398 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file. 505 399 506 Modified files: 400 Modified files: 507 --------------- 401 --------------- 508 G4FastStep.hh, G4FastStep.cc 402 G4FastStep.hh, G4FastStep.cc 509 403 510 Status: 404 Status: 511 ------- 405 ------- 512 Done, tested, system-tested on HP-aCC with e 406 Done, tested, system-tested on HP-aCC with exemple N05. 513 407 514 7) Warning: 408 7) Warning: 515 ----------- 409 ----------- 516 include/G4FastStep.hh:59 410 include/G4FastStep.hh:59 517 If a class has virtual functions it shall 411 If a class has virtual functions it shall have a virtual destructor 518 Severe violation: Universal Coding Standar 412 Severe violation: Universal Coding Standards item 17 519 class G4FastStep has virtual functions wit 413 class G4FastStep has virtual functions without a virtual destructor. 520 414 521 415 522 offending code: 416 offending code: 523 --------------- 417 --------------- 524 ~G4FastStep(); 418 ~G4FastStep(); 525 419 526 Diagnostic: 420 Diagnostic: 527 ---------- 421 ---------- 528 Nobody should inherites from G4FastStep BUT 422 Nobody should inherites from G4FastStep BUT virtual added. 529 423 530 Action: 424 Action: 531 ------- 425 ------- 532 virtual ~G4FastStep(); 426 virtual ~G4FastStep(); 533 427 534 Modified files: 428 Modified files: 535 --------------- 429 --------------- 536 G4FastStep.hh 430 G4FastStep.hh 537 431 538 Status: 432 Status: 539 ------- 433 ------- 540 Done, tested, system-tested on HP-aCC with e 434 Done, tested, system-tested on HP-aCC with exemple N05. 541 435 542 436 543 December 7, 1998 M. Verderi 437 December 7, 1998 M. Verderi 544 G4FastSimulationManagerProcess class: 438 G4FastSimulationManagerProcess class: 545 Fixes made for ghost navigation with 439 Fixes made for ghost navigation with 546 mag-field: 440 mag-field: 547 LocateGlobalPointAndUpdateTouchable is 441 LocateGlobalPointAndUpdateTouchable is 548 always used (in not the Locate...Setup 442 always used (in not the Locate...Setup 549 method) 443 method) 550 In PostStepDoIt: correction of position and 444 In PostStepDoIt: correction of position and 551 direction of the track are made when << 445 direction of the track are made when 552 possible in case of mag-field. 446 possible in case of mag-field. 553 This correction comes from the fact that a 447 This correction comes from the fact that a 554 small discrepancy appears on those quantitie 448 small discrepancy appears on those quantities 555 because of the numerical integration along 449 because of the numerical integration along 556 the field on the track path: the G4FSMP 450 the field on the track path: the G4FSMP 557 proposes a curve-length, the transportation 451 proposes a curve-length, the transportation 558 moves the track along this curve, however 452 moves the track along this curve, however 559 the end point position and direction are 453 the end point position and direction are 560 slightly different from those expected by 454 slightly different from those expected by 561 the G4FSMP when it proposed the length. 455 the G4FSMP when it proposed the length. 562 456 563 November 20,1998 M. Verderi 457 November 20,1998 M. Verderi 564 G4FastStep class: 458 G4FastStep class: 565 Remove track/G4BiasingTag.hh dependancy (ob 459 Remove track/G4BiasingTag.hh dependancy (obsolete). 566 Adapted to new shceme of Event Biasing mech 460 Adapted to new shceme of Event Biasing mechanism, 567 consistently with track-00-04-01 tag. 461 consistently with track-00-04-01 tag. 568 462 569 November 11,1998 M. Verderi 463 November 11,1998 M. Verderi 570 Merge of param-00-03-02 & param-00-03-02a i 464 Merge of param-00-03-02 & param-00-03-02a into 571 param-00-03-04a (hopefully...) 465 param-00-03-04a (hopefully...) 572 The point is the chnage of signature in the 466 The point is the chnage of signature in the 573 LocateGlobalPointAndSetup(..) of the G4Navi 467 LocateGlobalPointAndSetup(..) of the G4Navigator making use now 574 of the track direction. The G4FastSimulatio 468 of the track direction. The G4FastSimulationManagerProcess is 575 changed accordingly: 469 changed accordingly: 576 fGhostNavigator.LocateGlobalPointAndSetup(t 470 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true); 577 471 578 472 579 November 6, 1998 M. Verderi 473 November 6, 1998 M. Verderi 580 - Extension of the G4FastStep to allow the 474 - Extension of the G4FastStep to allow the biasing technic. 581 Changes are made in: 475 Changes are made in: 582 - G4FastStep.hh/.icc: 476 - G4FastStep.hh/.icc: 583 new member G4BiasingTa 477 new member G4BiasingTag fBiasTag; 584 new method SetPrimaryT 478 new method SetPrimaryTrackFinalBiasingTag 585 ( G4BiasingTag 479 ( G4BiasingTag aTag ); 586 - G4FastStep.cc: 480 - G4FastStep.cc: 587 Initialize(); 481 Initialize(); 588 operator=; << 482 operator=; 589 UpdateForPostStep(); 483 UpdateForPostStep(); 590 UpdateForAtRest(); << 484 UpdateForAtRest(); 591 485 592 October 26, 1998 P.Mora de Freitas 486 October 26, 1998 P.Mora de Freitas 593 - G4FastSimulationManagerProcess and G4Fast 487 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal 594 with at rest parameterisations also when 488 with at rest parameterisations also when using parallel geometry. 595 489 596 October 8, 1998 P.Mora de Freitas 490 October 8, 1998 P.Mora de Freitas 597 - The G4VFastSimulationModel::IsApplicable( 491 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual 598 methode. 492 methode. 599 - G4FastSimulationManager optimisation: 493 - G4FastSimulationManager optimisation: 600 - New G4ParticleDefinition* fLastCrossedP 494 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps 601 the last particle type with touched the 495 the last particle type with touched the envelope; 602 - New G4RWTPtrOrderedVector<G4VFastSimula 496 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList 603 data member, keeps the model list of th << 497 data member, keeps the model list of the applicable models for 604 the actual fLastCrossedParticle particl 498 the actual fLastCrossedParticle particle type; 605 - Changes in the PostStepGetFastSimulatio << 499 - Changes in the PostStepGetFastSimulationManagerTrigger() and 606 AtRestGetFastSimulationManagerTrigger() << 500 AtRestGetFastSimulationManagerTrigger()methodes to update the 607 fApplicableModelList when needed (fLast 501 fApplicableModelList when needed (fLastCrossedParticle != 608 the actual tracked particle); 502 the actual tracked particle); 609 - Changes in the << 503 - Changes in the 610 G4FastSimulationManager() (Constructor) 504 G4FastSimulationManager() (Constructor) 611 ActivateFastSimulationModel(), 505 ActivateFastSimulationModel(), 612 InActivateFastSimulationModel(), 506 InActivateFastSimulationModel(), 613 AtRestGetFastSimulationManagerTrigger(), 507 AtRestGetFastSimulationManagerTrigger(), 614 AddFastSimulationModel(), 508 AddFastSimulationModel(), 615 RemoveFastSimulationModel() 509 RemoveFastSimulationModel() 616 methodes to set the fLastCrossedParticle to 510 methodes to set the fLastCrossedParticle to NULL, forcing the 617 fApplicableModelList to be rebuilt. 511 fApplicableModelList to be rebuilt. 618 512 619 September 22, 1998 P.Mora de Freitas 513 September 22, 1998 P.Mora de Freitas 620 Fixed bug in parallel navigation. << 514 Fixed bug in parallel navigation. 621 File touched: G4FastSimulationManagerProces 515 File touched: G4FastSimulationManagerProcess.cc 622 Tested on HP-aCC. 516 Tested on HP-aCC. 623 517 624 September 17, 1998 P.Mora de Freitas 518 September 17, 1998 P.Mora de Freitas 625 G4FastSimulationManager::RemoveFastSimulati 519 G4FastSimulationManager::RemoveFastSimulationModel() updated to look 626 for also in the fInactivatedModels list. 520 for also in the fInactivatedModels list. 627 521 628 Tested on HP-aCC. 522 Tested on HP-aCC. 629 523 630 September 16, 1998 P.Mora de Freitas 524 September 16, 1998 P.Mora de Freitas 631 New /param/ control commands: 525 New /param/ control commands: 632 526 633 /param/ActivateModel <ModelName> 527 /param/ActivateModel <ModelName> 634 /param/InActivateModel <ModelName> 528 /param/InActivateModel <ModelName> 635 529 636 Activate or inactivate a given parameterisat 530 Activate or inactivate a given parameterisation model. 637 531 638 Tested on HP-aCC. 532 Tested on HP-aCC. 639 533 640 August 21, 1998 P.Mora de Freitas 534 August 21, 1998 P.Mora de Freitas 641 G4FastSimulationManagerProcess's G4ProcessTy 535 G4FastSimulationManagerProcess's G4ProcessType set to 642 fParameterisation, accordingly with procman-00 536 fParameterisation, accordingly with procman-00-02-03. 643 537 644 Tested on HP-aCC. 538 Tested on HP-aCC. 645 539 646 August 12, 1998 P.Mora de Freitas 540 August 12, 1998 P.Mora de Freitas 647 Improved the "close parameterisation control << 541 Improved the "close parameterisation control" to 648 542 649 1) avoid the close looping when unnecessary 543 1) avoid the close looping when unnecessary (mostly cases); 650 2) force re-close when necessary (insert/rem 544 2) force re-close when necessary (insert/remove ghosts). 651 545 652 Changes: 546 Changes: 653 547 654 1) the G4GlobalFastSimulationManager::fClose << 548 1) the G4GlobalFastSimulationManager::fClosed is now initialised 655 to true by the G4GlobalFastSimulationMana 549 to true by the G4GlobalFastSimulationManager constructor; 656 550 657 2) new method << 551 2) new method 658 552 659 void << 553 void 660 G4GlobalFastSimulationManager::FastSimula 554 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed(); 661 555 662 called by the AddGhostPlacement and Remov << 556 called by the AddGhostPlacement and RemoveGhostPlacement 663 G4FastSimulationManager methods to set fa 557 G4FastSimulationManager methods to set false the fClosed flag; 664 558 665 3) changes in the G4GlobalFastSimulationMana 559 3) changes in the G4GlobalFastSimulationManager::Notify method 666 to deal with these changes. 560 to deal with these changes. 667 561 668 Tested on HP-aCC. 562 Tested on HP-aCC. 669 563 670 August 11, 1998 P.Mora de Freitas 564 August 11, 1998 P.Mora de Freitas 671 Fix to the G4FastStep::KillPrimaryTrack() me 565 Fix to the G4FastStep::KillPrimaryTrack() method to drop the 672 nonsense line 566 nonsense line 673 567 674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 568 SetMomentumChange(0.,0.,0.) ; /* necessary ? */ 675 569 676 Tested on HP-aCC. 570 Tested on HP-aCC. 677 (Thanks to Willy Langeveld) 571 (Thanks to Willy Langeveld) 678 572 679 573 680 August 10, 1998 P.Mora de Freitas 574 August 10, 1998 P.Mora de Freitas 681 Fix to the SetPrimaryTrackFinalKineticEnergy 575 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method 682 from the G4FastStep class the SetMomentumChang 576 from the G4FastStep class the SetMomentumChange() call to insure that 683 the new momentum direction is a unit vector (a << 577 the new momentum direction is a unit vector (as asked by the 684 G4DynamicParticle::SetMomentumDirection method 578 G4DynamicParticle::SetMomentumDirection method). 685 579 686 Touched files: G4FastStep.hh (improved comme 580 Touched files: G4FastStep.hh (improved comments) 687 G4FastStep.cc (fixed) 581 G4FastStep.cc (fixed) 688 582 689 Tested on HP-aCC. 583 Tested on HP-aCC. 690 (Thanks to Willy Langeveld) 584 (Thanks to Willy Langeveld) 691 585 692 August 7, 1998 P.Mora de Freitas 586 August 7, 1998 P.Mora de Freitas 693 New /param/ commands directory with the comm 587 New /param/ commands directory with the commands: 694 588 695 /param/listEnvelopes [ParticleName] 589 /param/listEnvelopes [ParticleName] 696 590 697 - List all the envelope names for a given pa 591 - List all the envelope names for a given particle 698 (or for all particles if without parameter 592 (or for all particles if without parameters). 699 593 700 /param/listModels [EnvelopeName] 594 /param/listModels [EnvelopeName] 701 595 702 - List all the Model names for a given envel 596 - List all the Model names for a given envelope 703 (or for all envelopes if without parameter 597 (or for all envelopes if without parameters). 704 598 705 /param/listIsApplicable [ModelName] 599 /param/listIsApplicable [ModelName] 706 600 707 - List all the particle names a given model 601 - List all the particle names a given model is applicable 708 (or for all models if without parameters). 602 (or for all models if without parameters). 709 603 710 604 711 August 7, 1998 P.Mora de Freitas 605 August 7, 1998 P.Mora de Freitas 712 History file Created. 606 History file Created.