Geant4 Cross Reference |
1 # Category param History << 1 $Id: History,v 1.33 2006/11/14 08:56:49 gcosmo Exp $ 2 << 2 ------------------------------------------------------------------- 3 See `CONTRIBUTING.rst` for details of **requir << 4 which **must** added in reverse chronological << 5 It must **not** be used as a substitute for wr << 6 << 7 ---------------------------------------------- << 8 << 9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) << 10 - In G4GlobalFastSimulationManager: << 11 use G4ThreadLocalSingleton to avoid undelete << 12 << 13 ## 2023-10-18 Ben Morgan (param-V11-01-03) << 14 - Apply standard and extended clang-tidy fixes << 15 - Mark empty/obsolete functions as deprecated << 16 << 17 ## 2023-10-16 Ben Morgan (param-V11-01-02) << 18 - Apply standard clang-format-ing. << 19 - Normal order accessors and docstrings. << 20 << 21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) << 22 - In G4FastTrack, removed references to G4Touc << 23 which is now deprecated. << 24 << 25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 << 26 - Added missing virtual destructor to G4VFastS << 27 << 28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) << 29 - Fixed compilation warnings for implicit type << 30 << 31 ## 2022-10-27 Makoto Asai (param-V11-00-03) << 32 - G4FastSimHitMaker - making compatible to com << 33 << 34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 << 35 - G4FastStep - delete copy constructor and ope << 36 << 37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) << 38 - Adding the 'flush' method to the fast simula << 39 This method allows to process the input buff << 40 the end of the G4 event. It is used when par << 41 The 'flash' is triggered inside the event lo << 42 The fast simulation model may add secondarie << 43 by Geant4. << 44 << 45 ## 2021-12-10 Ben Morgan (param-V11-00-00) << 46 - Change to new Markdown History format << 47 << 48 --- << 49 << 50 # History entries prior to 11.0 << 51 << 52 April 16, 2021 Ben Morgan (param-V10-07-00) << 53 - Migrate build to modular CMake API << 54 << 55 October 5, 2020, A. Zaborowska (param-V10-06-0 << 56 - Introduce general facilities based on GFlash << 57 to facilitate multiple hit (energy & positio << 58 from fast simulation models. << 59 << 60 September 9, 2020, G. Cosmo (param-V10-06-02) << 61 - Fixed minor Coverity defect for uninitialise << 62 << 63 April 21, 2020, A. Zaborowska (param-V10-06-01 << 64 - Sanity check for root logical volumes for re << 65 UI command /param/showSetup works also if no << 66 << 67 March 26, 2020, I. Semeniouk (param-V10-06-00) << 68 - G4FastSimulationHelper : merge ActivateFastS << 69 - G4FastSimulationManager.hh, G4VFastSimulatio << 70 redefinition of G4Envelope type << 71 << 72 October 30, 2019, A. Zaborowska (param-v10-05- << 73 - Register G4FastSimulationManagerProcess with << 74 G4FastSimulationManagerHelper to ensure it i << 75 invoked for a given step (ExclusivelyForced) << 76 StronglyForced processes will be considered. << 77 << 78 December 19, 2017, G. Cosmo (param-V10-04-00) << 79 - Fixed self-consistency in G4FastSimulationVe << 80 Thanks to Raphael Isemann for reporting this << 81 << 82 November 03, 2016, M. Verderi (param-V10-02-01 << 83 - New G4FastSimulationManagerHelper utility fo << 84 adding G4FastSimulationManagerProcess to a << 85 process manager. << 86 << 87 November 02, 2016, M. Verderi (param-V10-02-00 << 88 - fix various Coverity defects. << 89 << 90 March 27, 2013, M. Verderi (param-V09-06-00) << 91 - remove unused field 'fOnBoundary' in G4FastS << 92 as this was causing a warning from clang. << 93 << 94 July 10, 2012, G. Cosmo (param-V09-05-00) << 95 - Explicitly use inclusion of headers for syst << 96 constants, in plan to remove implicit inclus << 97 << 98 September 30, 2011, M. Verderi (param-V09-04-0 << 99 - Added missing new header file (G4FastSimulat << 100 sources.cmake. << 101 << 102 September 30, 2011, M. Verderi (param-V09-04-0 << 103 - Migration to new G4Exception scheme. << 104 - what is V09-04-01 tag ? << 105 << 106 February 11, 2011, M. Verderi (param-V09-04-00 << 107 - Implementation of method << 108 void ProposePrimaryTrackFinalKineticEnergy ( << 109 was missing : modified file G4FastStep.icc << 110 << 111 March 13, 2008, G. Cosmo (param-V09-01-00) << 112 - Cleared compilation warnings in G4FastSimula << 113 G4FastSimulationMessenger on gcc-4.3.0 for a << 114 parentheses in nested if-else statements. << 115 << 116 November 30, 2007, M. Verderi << 117 - Add Along methods to G4FSMP process << 118 - tag as param-V09-00-01 << 119 << 120 November 30, 2007, M. Verderi << 121 - minor corrections to G4FastSimulationManager << 122 * add call fPathFinder->prepareNewrack(...) << 123 * deactivate ghost navigator in EndOfTracki << 124 - tag as param-V09-00-00 << 125 << 126 May 18, 2007, M. Verderi << 127 - tag as param-V08-03-00 << 128 << 129 May 11, 2007, M. Verderi << 130 - remove include/G4FastSimulationManagerProces << 131 include/G4FlavoredParallelWorld.hh << 132 include/G4GFSManager81.hh << 133 src/G4FastSimulationManagerProcess81. << 134 src/G4GFSManager81.cc << 135 3 >> 4 ========================================================= >> 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP >> 6 ========================================================= >> 7 >> 8 Category History file >> 9 --------------------- >> 10 This file should be used by G4 developers and category coordinators >> 11 to briefly summarize all major modifications introduced in the code >> 12 and keep track of all category-tags. >> 13 It DOES NOT substitute the CVS log-message one should put at every >> 14 committal in the CVS repository ! >> 15 >> 16 ---------------------------------------------------------- >> 17 * Reverse chronological order (last date on top), please * >> 18 ---------------------------------------------------------- 136 19 137 November 10, 2006, M. Verderi - param-V08-01-0 20 November 10, 2006, M. Verderi - param-V08-01-00 138 - Limited number of warning messages printed b 21 - Limited number of warning messages printed by the 139 G4GlobalFastSimulationManager. 22 G4GlobalFastSimulationManager. 140 - Renamed G4FastSimulationManagerProcess_forCo 23 - Renamed G4FastSimulationManagerProcess_forCoupledTransportation with 141 G4FastSimulationManagerProcess81. 24 G4FastSimulationManagerProcess81. 142 In addition, this class can now handle the c 25 In addition, this class can now handle the case of Navigator index=0, 143 i.e., the navigator for tracking, regardless 26 i.e., the navigator for tracking, regardless the G4Transportation or 144 G4CoupledTransportation is used. (For other 27 G4CoupledTransportation is used. (For other navigators, there is 145 of course no choice, and G4CoupledTransporta 28 of course no choice, and G4CoupledTransportation is necessary.) 146 29 147 November 3, 2006 M. Verderi 30 November 3, 2006 M. Verderi 148 - Introduced G4FastSimulationManagerProcess_fo 31 - Introduced G4FastSimulationManagerProcess_forCoupledTransportation class for 149 handling fast simulation in new parallel geo 32 handling fast simulation in new parallel geometry scheme. This requires 150 the G4CoupledTransportation to be active. 33 the G4CoupledTransportation to be active. 151 - Introduced G4GFSManager81 class that gathers 34 - Introduced G4GFSManager81 class that gathers the future code to become the 152 default at next major release in the G4Globa 35 default at next major release in the G4GlobalFastSimulationManager class. 153 - G4FastSimulationManager: adapted to new sche 36 - G4FastSimulationManager: adapted to new scheme. Still has old code for 154 backward compatibilty. 37 backward compatibilty. 155 - G4FastSimulationManagerProcess: mostly the s 38 - G4FastSimulationManagerProcess: mostly the same, apart from a small bug fix. 156 - G4FastSimulationMessenger: new command creat 39 - G4FastSimulationMessenger: new command created "/param/showSetup", useful 157 to show the fast simulation setup (region, m 40 to show the fast simulation setup (region, models, processes, etc...) 158 It is only valid for geometry closed state. 41 It is only valid for geometry closed state. Desirable to have interactive 159 command in the run manager for this. 42 command in the run manager for this. 160 43 161 November 25, 2005, M.Verderi - param-V07-01-0 44 November 25, 2005, M.Verderi - param-V07-01-04 162 - put back Makoto's change: StartTracking(G4Tr 45 - put back Makoto's change: StartTracking(G4Track*) 163 46 164 November 25, 2005, M Verderi - param-V07-01-03 47 November 25, 2005, M Verderi - param-V07-01-03 165 - Make ghost functionnality available with G4R 48 - Make ghost functionnality available with G4Region 166 - ** Note ** Change back StartTracking(G4Track 49 - ** Note ** Change back StartTracking(G4Track*) -> StartTracking() in G4FSMP 167 StartTracking(G4Track*) was intro 50 StartTracking(G4Track*) was introduced in param-V07-01-02 168 because (I guess) of procman-V07-01-01 51 because (I guess) of procman-V07-01-01 169 This is to make param-V07-01-03 compatible w 52 This is to make param-V07-01-03 compatible with geant4-07-01-ref-05 170 53 171 November 21, 2005 M.Asai - param-V07-01-02 54 November 21, 2005 M.Asai - param-V07-01-02 172 - Fix warning message. 55 - Fix warning message. 173 56 174 November 02, 2005 G.Cosmo - param-V07-01-01 57 November 02, 2005 G.Cosmo - param-V07-01-01 175 - Corrected setting of envelope volumes and so 58 - Corrected setting of envelope volumes and solid in G4FastTrack. 176 - Migrated old scheme for G4Exception and some 59 - Migrated old scheme for G4Exception and some cosmetics... 177 60 178 October 28, 2005 M.Asai - param-V07-01-00 61 October 28, 2005 M.Asai - param-V07-01-00 179 - Working tag for merging "envelope" to G4Regi 62 - Working tag for merging "envelope" to G4Region. 180 63 181 December 07, 2004 G. Cosmo - param-V06-02-01 64 December 07, 2004 G. Cosmo - param-V06-02-01 182 - Implemented migration to <cmath>. 65 - Implemented migration to <cmath>. 183 66 184 November 26, 2004 M. Verderi - param-V06-02-00 67 November 26, 2004 M. Verderi - param-V06-02-00 185 - Implemented migration to new G4VParticleChan 68 - Implemented migration to new G4VParticleChange interfaces. 186 69 187 December 12, 2003 G. Cosmo - param-V06-00-00 70 December 12, 2003 G. Cosmo - param-V06-00-00 188 - G4FastSimulationVector.icc: use std_pvector: 71 - G4FastSimulationVector.icc: use std_pvector:: scope for calls to 189 base class. Fixes compilation problem on Int 72 base class. Fixes compilation problem on Intel-icc compiler. 190 73 191 November 10, 2003 G. Cosmo - param-V05-02-01 74 November 10, 2003 G. Cosmo - param-V05-02-01 192 - G4FastTrack: use G4Navigator::CreateTouchabl 75 - G4FastTrack: use G4Navigator::CreateTouchableHistoryHandle() instead of 193 CreateTouchableHistory() in method FRecordsA 76 CreateTouchableHistory() in method FRecordsAffineTransformation(). 194 77 195 October 4, 2003 G. Cosmo - param-V05-02-00 78 October 4, 2003 G. Cosmo - param-V05-02-00 196 - Modified GNUmakefile: 79 - Modified GNUmakefile: 197 o added dependency to new module "geometry/n 80 o added dependency to new module "geometry/navigation". 198 - Coworks with "geometry-V05-02-00" and "digit 81 - Coworks with "geometry-V05-02-00" and "digits_hits-V05-02-00". 199 82 200 May 21, 2003 G. Cosmo - param-V05-01-00 83 May 21, 2003 G. Cosmo - param-V05-01-00 201 o Fixed pedantic warnings on Linux-g++ 84 o Fixed pedantic warnings on Linux-g++. 202 o Call base class in copy-constructor 85 o Call base class in copy-constructor of G4FastStep. 203 86 204 Nov 20, 2002 G. Cosmo - param-V04-01-02 87 Nov 20, 2002 G. Cosmo - param-V04-01-02 205 o Patched access to public static data in G4 88 o Patched access to public static data in G4FastStep.cc 206 and G4GlobalFastSimulationManager.cc to al 89 and G4GlobalFastSimulationManager.cc to allow porting on 207 Windows DLLs. 90 Windows DLLs. 208 91 209 Nov 15, 2002 S. Sadilov - param-V04-01-01 92 Nov 15, 2002 S. Sadilov - param-V04-01-01 210 o Fixed compilation problems on Windows in 93 o Fixed compilation problems on Windows in 211 G4FastSimulationManager.cc and G4GlobalFas 94 G4FastSimulationManager.cc and G4GlobalFastSimulationManager.cc 212 95 213 Nov 02, 2002 M. Verderi - param-V04-01-00 96 Nov 02, 2002 M. Verderi - param-V04-01-00 214 o Add method to retrieve G4VFastSimulationMo 97 o Add method to retrieve G4VFastSimulationModel by name. 215 The user's method is in G4GlobalFastSimula 98 The user's method is in G4GlobalFastSimulationManager: 216 99 217 GetFastSimulationModel(); 100 GetFastSimulationModel(); 218 101 219 it is accompagnied by same methods name in 102 it is accompagnied by same methods name in 220 G4FastSimulationManager class. 103 G4FastSimulationManager class. 221 104 222 o Add "test" directory, used to test above f 105 o Add "test" directory, used to test above feature. 223 106 224 Oct 26, 2001 M. Verderi - param-V03-02-00 107 Oct 26, 2001 M. Verderi - param-V03-02-00 225 Fixes to clear warnings produced with gcc-2. 108 Fixes to clear warnings produced with gcc-2.95.2: 226 - loop index, where comparison with method " 109 - loop index, where comparison with method "size()" of 227 G4std::vector<T>, changed: int -> size_t << 110 G4std::vector<T>, changed: int -> size_t 228 - change "if ( a=b ) {..}" by "if ( (a=b) ) 111 - change "if ( a=b ) {..}" by "if ( (a=b) ) {...}" 229 this makes the compiler sure you want to mak 112 this makes the compiler sure you want to make an 230 assignement in the "if" condition 113 assignement in the "if" condition 231 - re-order initialisations of a few variable 114 - re-order initialisations of a few variables in constructors 232 to match the declaration order. 115 to match the declaration order. 233 Some warnings still exist, but regard the G4 116 Some warnings still exist, but regard the G4Propagator of geometry. 234 117 235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 118 Apr 3, 2001 J. Apostolakis - param-V03-00-00 236 - Modified G4FastSimulationManagerProcess call 119 - Modified G4FastSimulationManagerProcess call to PropagatorInField ComputeStep 237 to use new interface with G4FieldTrack (in 120 to use new interface with G4FieldTrack (in place of now obsolete interface.) 238 121 239 Nov 14, 2000 G. Cosmo - param-V02-00-01 122 Nov 14, 2000 G. Cosmo - param-V02-00-01 240 - Moved specific parameterisation models to th 123 - Moved specific parameterisation models to the new top category 241 "parameterisations". Moved files: 124 "parameterisations". Moved files: 242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm 125 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRmodel[.hh.cc], 243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster 126 G4IrregularXrayTRmodel[.hh.cc], G4PAIclusterModel[.hh.cc], 244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr 127 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXrayTRmodel[.hh.cc], 245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode 128 G4RegularXrayTRmodel[.hh.cc], G4VClusterModel[.hh.cc], 246 G4VXrayTRmodel[.hh.cc]. 129 G4VXrayTRmodel[.hh.cc]. 247 - Cleaned-up GNUmakefile of non necessary depe 130 - Cleaned-up GNUmakefile of non necessary dependencies. 248 131 249 Aug 03, 2000 G. Cosmo - param-V02-00-00r 132 Aug 03, 2000 G. Cosmo - param-V02-00-00r 250 - Changed RandGauss to G4RandGauss in G4Irregu 133 - Changed RandGauss to G4RandGauss in G4IrregularXrayTRmodel.cc and 251 G4VXrayTRmodel.cc to fix events' reproducibi 134 G4VXrayTRmodel.cc to fix events' reproducibility problem. 252 - G4VXrayTRmodel.cc: fix to class destructor ( 135 - G4VXrayTRmodel.cc: fix to class destructor (V.Grichine) 253 136 254 Jun 15, 2000 G. Cosmo - param-V01-01-04 137 Jun 15, 2000 G. Cosmo - param-V01-01-04 255 - The tag coworks with global-V01-01-04 and ma 138 - The tag coworks with global-V01-01-04 and materials-V01-01-00: 256 o Fixed usage of G4complex type for ISO and 139 o Fixed usage of G4complex type for ISO and non-ISO compilers. 257 Affected files: G4FoamXrayTRmodel.cc, G4Ga 140 Affected files: G4FoamXrayTRmodel.cc, G4GamDistrXrayTRmodel.cc, G4PlateIrrGasXrayTRmodel.cc 258 and G4RegularXrayTRmodel.c 141 and G4RegularXrayTRmodel.cc. 259 In case of G4complex types passed to mathe 142 In case of G4complex types passed to mathematical functions, use G4std:: prefix. 260 o Fixed usage of G4Integrator class, now cha 143 o Fixed usage of G4Integrator class, now changed to templated to allow porting of the 261 code on SUN-CC compiler which does not imp 144 code on SUN-CC compiler which does not implement templated member functions. 262 Affected files: G4VXrayTRmodel[.hh.cc] 145 Affected files: G4VXrayTRmodel[.hh.cc] 263 146 264 Jun 6, 2000 M. Verderi & P. Mora de Freitas 147 Jun 6, 2000 M. Verderi & P. Mora de Freitas 265 - fixed compilation errors with HP-aCC for the 148 - fixed compilation errors with HP-aCC for the files G4RegularXrayTRmodel.cc, 266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod 149 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmodel.cc. 267 150 268 May 30, 2000 M. Verderi & P. Mora de Freitas 151 May 30, 2000 M. Verderi & P. Mora de Freitas 269 152 270 - parameterisation category is now RW free. 153 - parameterisation category is now RW free. 271 154 272 September 16, 1999 M. Verderi & P. Mora de Fre 155 September 16, 1999 M. Verderi & P. Mora de Freitas 273 156 274 - Fixed bug in G4FastStep::CheckIt() method. 157 - Fixed bug in G4FastStep::CheckIt() method. 275 158 276 April 19, 1999 M. Verderi & P. Mora de Freitas 159 April 19, 1999 M. Verderi & P. Mora de Freitas 277 160 278 Changes in G4FastStep to co-work with track-01 161 Changes in G4FastStep to co-work with track-01-00-04: 279 162 280 1) The method void CheckIt(const G4Track&) bec << 163 1) The method void CheckIt(const G4Track&) becomes 281 G4bool CheckIt(const G4Track&); 164 G4bool CheckIt(const G4Track&); 282 2) The FAST_STEP_DEBUG compiling option disapp 165 2) The FAST_STEP_DEBUG compiling option disappears; 283 3) Call to CheckIt controled by the G4VParticl 166 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute. 284 167 285 Miscellaneous: the declaration "G4double mass 168 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh 286 corrected to G4double mass =...". 169 corrected to G4double mass =...". 287 170 288 April 15, 1999 M. Verderi & P. Mora de Freitas 171 April 15, 1999 M. Verderi & P. Mora de Freitas 289 172 290 Tasks to decouple visualization from processes 173 Tasks to decouple visualization from processes/parameterisation: 291 174 292 1) G4GlobalFastSimulationManager now inherites 175 1) G4GlobalFastSimulationManager now inherites from the intercoms/ 293 G4VGlobalFastSimulationManager to allow visual << 176 G4VGlobalFastSimulationManager to allow visualisation to get a 294 concrete instance pointer to the G4GlobalFastS 177 concrete instance pointer to the G4GlobalFastSimulationManager, 295 if any. 178 if any. 296 179 297 2) G4FlavoredParallelWorld now inherites from 180 2) G4FlavoredParallelWorld now inherites from the intercoms/ 298 G4VFlavoredParallelWorld, a pure virtual abstr 181 G4VFlavoredParallelWorld, a pure virtual abstract class to interface 299 parameterisation with visualization. 182 parameterisation with visualization. 300 183 301 Co-works with intercoms-01-00-01 tag 184 Co-works with intercoms-01-00-01 tag 302 185 303 Modified files: 186 Modified files: 304 --------------- 187 --------------- 305 G4FlavoredParallelWorld.hh 188 G4FlavoredParallelWorld.hh 306 G4GlobalFastSimulationManager.hh 189 G4GlobalFastSimulationManager.hh 307 G4GlobalFastSimulationManager.cc 190 G4GlobalFastSimulationManager.cc 308 191 309 Done, tested, system-tested on HP-aCC with exe 192 Done, tested, system-tested on HP-aCC with exemple N05. 310 193 311 April 14, 1999 M. Verderi & P. Mora de Freitas 194 April 14, 1999 M. Verderi & P. Mora de Freitas 312 195 313 Several consolidation tasks (thanks to G. Cosm 196 Several consolidation tasks (thanks to G. Cosmo): 314 197 315 1) Warning: << 198 1) Warning: 316 ----------- 199 ----------- 317 200 318 Pointers usage 201 Pointers usage 319 202 320 - Setting pointers to 0 after delete: 203 - Setting pointers to 0 after delete: 321 204 322 delete pA; 205 delete pA; 323 pA = 0; 206 pA = 0; 324 207 325 - Avoid to use "NULL". 208 - Avoid to use "NULL". 326 209 327 Modified files: 210 Modified files: 328 --------------- 211 --------------- 329 G4FastSimulationManager.hh 212 G4FastSimulationManager.hh 330 G4FastTrack.hh 213 G4FastTrack.hh 331 G4FlavoredParallelWorld.hh 214 G4FlavoredParallelWorld.hh 332 G4FastSimulationManager.cc 215 G4FastSimulationManager.cc 333 G4FastSimulationMessenger.cc 216 G4FastSimulationMessenger.cc 334 G4FastSimulationManagerProcess.cc 217 G4FastSimulationManagerProcess.cc 335 G4FastTrack.cc 218 G4FastTrack.cc 336 G4GlobalFastSimulationManager.cc 219 G4GlobalFastSimulationManager.cc 337 G4VFastSimulationModel.cc 220 G4VFastSimulationModel.cc 338 221 339 Status: << 222 Status: 340 ------- 223 ------- 341 Done, tested, system-tested on HP-aCC with exe 224 Done, tested, system-tested on HP-aCC with exemple N05. 342 225 343 2) Warning: 226 2) Warning: 344 ----------- 227 ----------- 345 include/G4FastSimulationManager.hh:163 228 include/G4FastSimulationManager.hh:163 346 Public member functions shall always retur 229 Public member functions shall always return const handles to member data 347 Severe violation: Universal Coding Standar 230 Severe violation: Universal Coding Standards item 18 348 231 349 offending code: 232 offending code: 350 --------------- 233 --------------- 351 inline G4VParticleChange* G4FastSimulationMana 234 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange() 352 { 235 { 353 return &fFastStep; 236 return &fFastStep; 354 } 237 } 355 238 356 Diagnostic: 239 Diagnostic: 357 ---------- 240 ---------- 358 241 359 Called by the G4FastSimulationManagerProcess << 242 Called by the G4FastSimulationManagerProcess to return it in the 360 PostStepDoIt call. << 243 PostStepDoIt call. 361 244 362 Action: 245 Action: 363 ------- 246 ------- 364 The G4FastSimulationManager::GettheParticleCha 247 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any 365 more. The G4VParticleChange* is now returned d 248 more. The G4VParticleChange* is now returned directly when invoking the 366 G4FastSimulationManager::InvokePostStepDoIt() 249 G4FastSimulationManager::InvokePostStepDoIt() and 367 G4FastSimulationManager::InvokeAtRestDoIt() me 250 G4FastSimulationManager::InvokeAtRestDoIt() methodes. 368 251 369 Modified files: 252 Modified files: 370 --------------- 253 --------------- 371 G4FastSimulationManager.hh 254 G4FastSimulationManager.hh 372 G4FastSimulationManager.cc 255 G4FastSimulationManager.cc 373 G4FastSimulationManagerProcess.cc 256 G4FastSimulationManagerProcess.cc 374 257 375 Status: << 258 Status: 376 ------- 259 ------- 377 Done, tested, system-tested on HP-aCC with exe 260 Done, tested, system-tested on HP-aCC with exemple N05. 378 261 379 3) Warning: 262 3) Warning: 380 ----------- 263 ----------- 381 include/G4FastSimulationManagerProcess.hh:52 264 include/G4FastSimulationManagerProcess.hh:52 382 If a class has virtual functions it shall 265 If a class has virtual functions it shall have a virtual destructor 383 Severe violation: Universal Coding Standar 266 Severe violation: Universal Coding Standards item 17 384 class G4FastSimulationManagerProcess has v 267 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor. 385 268 386 offending code: 269 offending code: 387 --------------- 270 --------------- 388 ~G4FastSimulationManagerProcess(); 271 ~G4FastSimulationManagerProcess(); 389 272 390 Diagnostic: 273 Diagnostic: 391 ---------- 274 ---------- 392 Nobody should inherites from G4FastSimulatio << 275 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual 393 is added. 276 is added. 394 277 395 Action: 278 Action: 396 ------- 279 ------- 397 virtual ~G4FastSimulationManagerProcess(); 280 virtual ~G4FastSimulationManagerProcess(); 398 281 399 Modified files: 282 Modified files: 400 --------------- 283 --------------- 401 G4FastSimulationManagerProcess.hh 284 G4FastSimulationManagerProcess.hh 402 285 403 Status: << 286 Status: 404 ------- 287 ------- 405 Done. 288 Done. 406 289 407 4) Warning: 290 4) Warning: 408 ----------- 291 ----------- 409 include/G4FastSimulationMessenger.hh:36 292 include/G4FastSimulationMessenger.hh:36 410 If a class has virtual functions it shall 293 If a class has virtual functions it shall have a virtual destructor 411 Severe violation: Universal Coding Standar 294 Severe violation: Universal Coding Standards item 17 412 class G4FastSimulationMessenger has virtua 295 class G4FastSimulationMessenger has virtual functions without a virtual destructor. 413 296 414 297 415 offending code: 298 offending code: 416 --------------- 299 --------------- 417 ~G4FastSimulationMessenger(); 300 ~G4FastSimulationMessenger(); 418 301 419 Diagnostic: 302 Diagnostic: 420 ---------- 303 ---------- 421 Nobody should inherites from G4FastSimulatio << 304 Nobody should inherites from G4FastSimulationMessenger BUT for virtual 422 is added. 305 is added. 423 306 424 Action: 307 Action: 425 ------- 308 ------- 426 virtual ~G4FastSimulationMessenger(); 309 virtual ~G4FastSimulationMessenger(); 427 310 428 Modified files: 311 Modified files: 429 --------------- 312 --------------- 430 G4FastSimulationMessenger.hh 313 G4FastSimulationMessenger.hh 431 314 432 Status: << 315 Status: 433 ------- 316 ------- 434 Done. 317 Done. 435 318 436 5) Warning: 319 5) Warning: 437 ----------- 320 ----------- 438 include/G4FastStep.hh:224 321 include/G4FastStep.hh:224 439 Operator= should call base class operator= 322 Operator= should call base class operator= 440 Possible severe violation: Effective C++ i 323 Possible severe violation: Effective C++ item 16 441 operator= in class G4FastStep, should call 324 operator= in class G4FastStep, should call operator= in base class G4VParticleChange 442 325 443 offending code: 326 offending code: 444 --------------- 327 --------------- 445 G4FastStep & G4FastStep::operator=(const G4Fas 328 G4FastStep & G4FastStep::operator=(const G4FastStep &right) 446 { 329 { 447 if (this != &right) 330 if (this != &right) 448 { 331 { 449 theListOfSecondaries = right.th 332 theListOfSecondaries = right.theListOfSecondaries; 450 theSizeOftheListOfSecondaries = right.th 333 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries; 451 theNumberOfSecondaries = right.th 334 theNumberOfSecondaries = right.theNumberOfSecondaries; 452 theStatusChange = right.th 335 theStatusChange = right.theStatusChange; 453 theMomentumChange = right.th 336 theMomentumChange = right.theMomentumChange; 454 thePolarizationChange = right.th 337 thePolarizationChange = right.thePolarizationChange; 455 thePositionChange = right.th 338 thePositionChange = right.thePositionChange; 456 theTimeChange = right.th 339 theTimeChange = right.theTimeChange; 457 theEnergyChange = right.th 340 theEnergyChange = right.theEnergyChange; 458 theTrueStepLength = right.th 341 theTrueStepLength = right.theTrueStepLength; 459 theLocalEnergyDeposit = right.th 342 theLocalEnergyDeposit = right.theLocalEnergyDeposit; 460 theSteppingControlFlag = right.th 343 theSteppingControlFlag = right.theSteppingControlFlag; 461 theWeightChange = right.th 344 theWeightChange = right.theWeightChange; 462 } 345 } 463 return *this; 346 return *this; 464 } 347 } 465 348 466 Diagnostic: 349 Diagnostic: 467 ---------- 350 ---------- 468 Bug detected. 351 Bug detected. 469 352 470 Action: 353 Action: 471 ------- 354 ------- 472 Insert the call 355 Insert the call 473 G4VParticleChange::operator=(right); 356 G4VParticleChange::operator=(right); 474 357 475 Status: 358 Status: 476 ------- 359 ------- 477 Done, tested, system-tested on HP-aCC with e 360 Done, tested, system-tested on HP-aCC with exemple N05. 478 361 479 Modified files: 362 Modified files: 480 --------------- 363 --------------- 481 G4FastStep.cc 364 G4FastStep.cc 482 365 483 6) Warning: 366 6) Warning: 484 ----------- 367 ----------- 485 include/G4FastStep.hh:59 368 include/G4FastStep.hh:59 486 Avoid data members in the public interface 369 Avoid data members in the public interface 487 Violation: Effective C++ item 20 370 Violation: Effective C++ item 20 488 Public data members for class G4FastStep: 371 Public data members for class G4FastStep: 489 debugFlag 372 debugFlag 490 373 491 374 492 offending code: 375 offending code: 493 --------------- 376 --------------- 494 public: 377 public: 495 ... 378 ... 496 G4bool debugFlag; 379 G4bool debugFlag; 497 380 498 Diagnostic: 381 Diagnostic: 499 ---------- 382 ---------- 500 Historical usage. 383 Historical usage. 501 384 502 Action: 385 Action: 503 ------- 386 ------- 504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 387 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file. 505 388 506 Modified files: 389 Modified files: 507 --------------- 390 --------------- 508 G4FastStep.hh, G4FastStep.cc 391 G4FastStep.hh, G4FastStep.cc 509 392 510 Status: 393 Status: 511 ------- 394 ------- 512 Done, tested, system-tested on HP-aCC with e 395 Done, tested, system-tested on HP-aCC with exemple N05. 513 396 514 7) Warning: 397 7) Warning: 515 ----------- 398 ----------- 516 include/G4FastStep.hh:59 399 include/G4FastStep.hh:59 517 If a class has virtual functions it shall 400 If a class has virtual functions it shall have a virtual destructor 518 Severe violation: Universal Coding Standar 401 Severe violation: Universal Coding Standards item 17 519 class G4FastStep has virtual functions wit 402 class G4FastStep has virtual functions without a virtual destructor. 520 403 521 404 522 offending code: 405 offending code: 523 --------------- 406 --------------- 524 ~G4FastStep(); 407 ~G4FastStep(); 525 408 526 Diagnostic: 409 Diagnostic: 527 ---------- 410 ---------- 528 Nobody should inherites from G4FastStep BUT 411 Nobody should inherites from G4FastStep BUT virtual added. 529 412 530 Action: 413 Action: 531 ------- 414 ------- 532 virtual ~G4FastStep(); 415 virtual ~G4FastStep(); 533 416 534 Modified files: 417 Modified files: 535 --------------- 418 --------------- 536 G4FastStep.hh 419 G4FastStep.hh 537 420 538 Status: 421 Status: 539 ------- 422 ------- 540 Done, tested, system-tested on HP-aCC with e 423 Done, tested, system-tested on HP-aCC with exemple N05. 541 424 542 425 543 December 7, 1998 M. Verderi 426 December 7, 1998 M. Verderi 544 G4FastSimulationManagerProcess class: 427 G4FastSimulationManagerProcess class: 545 Fixes made for ghost navigation with 428 Fixes made for ghost navigation with 546 mag-field: 429 mag-field: 547 LocateGlobalPointAndUpdateTouchable is 430 LocateGlobalPointAndUpdateTouchable is 548 always used (in not the Locate...Setup 431 always used (in not the Locate...Setup 549 method) 432 method) 550 In PostStepDoIt: correction of position and 433 In PostStepDoIt: correction of position and 551 direction of the track are made when << 434 direction of the track are made when 552 possible in case of mag-field. 435 possible in case of mag-field. 553 This correction comes from the fact that a 436 This correction comes from the fact that a 554 small discrepancy appears on those quantitie 437 small discrepancy appears on those quantities 555 because of the numerical integration along 438 because of the numerical integration along 556 the field on the track path: the G4FSMP 439 the field on the track path: the G4FSMP 557 proposes a curve-length, the transportation 440 proposes a curve-length, the transportation 558 moves the track along this curve, however 441 moves the track along this curve, however 559 the end point position and direction are 442 the end point position and direction are 560 slightly different from those expected by 443 slightly different from those expected by 561 the G4FSMP when it proposed the length. 444 the G4FSMP when it proposed the length. 562 445 563 November 20,1998 M. Verderi 446 November 20,1998 M. Verderi 564 G4FastStep class: 447 G4FastStep class: 565 Remove track/G4BiasingTag.hh dependancy (ob 448 Remove track/G4BiasingTag.hh dependancy (obsolete). 566 Adapted to new shceme of Event Biasing mech 449 Adapted to new shceme of Event Biasing mechanism, 567 consistently with track-00-04-01 tag. 450 consistently with track-00-04-01 tag. 568 451 569 November 11,1998 M. Verderi 452 November 11,1998 M. Verderi 570 Merge of param-00-03-02 & param-00-03-02a i 453 Merge of param-00-03-02 & param-00-03-02a into 571 param-00-03-04a (hopefully...) 454 param-00-03-04a (hopefully...) 572 The point is the chnage of signature in the 455 The point is the chnage of signature in the 573 LocateGlobalPointAndSetup(..) of the G4Navi 456 LocateGlobalPointAndSetup(..) of the G4Navigator making use now 574 of the track direction. The G4FastSimulatio 457 of the track direction. The G4FastSimulationManagerProcess is 575 changed accordingly: 458 changed accordingly: 576 fGhostNavigator.LocateGlobalPointAndSetup(t 459 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true); 577 460 578 461 579 November 6, 1998 M. Verderi 462 November 6, 1998 M. Verderi 580 - Extension of the G4FastStep to allow the 463 - Extension of the G4FastStep to allow the biasing technic. 581 Changes are made in: 464 Changes are made in: 582 - G4FastStep.hh/.icc: 465 - G4FastStep.hh/.icc: 583 new member G4BiasingTa 466 new member G4BiasingTag fBiasTag; 584 new method SetPrimaryT 467 new method SetPrimaryTrackFinalBiasingTag 585 ( G4BiasingTag 468 ( G4BiasingTag aTag ); 586 - G4FastStep.cc: 469 - G4FastStep.cc: 587 Initialize(); 470 Initialize(); 588 operator=; << 471 operator=; 589 UpdateForPostStep(); 472 UpdateForPostStep(); 590 UpdateForAtRest(); << 473 UpdateForAtRest(); 591 474 592 October 26, 1998 P.Mora de Freitas 475 October 26, 1998 P.Mora de Freitas 593 - G4FastSimulationManagerProcess and G4Fast 476 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal 594 with at rest parameterisations also when 477 with at rest parameterisations also when using parallel geometry. 595 478 596 October 8, 1998 P.Mora de Freitas 479 October 8, 1998 P.Mora de Freitas 597 - The G4VFastSimulationModel::IsApplicable( 480 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual 598 methode. 481 methode. 599 - G4FastSimulationManager optimisation: 482 - G4FastSimulationManager optimisation: 600 - New G4ParticleDefinition* fLastCrossedP 483 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps 601 the last particle type with touched the 484 the last particle type with touched the envelope; 602 - New G4RWTPtrOrderedVector<G4VFastSimula 485 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList 603 data member, keeps the model list of th << 486 data member, keeps the model list of the applicable models for 604 the actual fLastCrossedParticle particl 487 the actual fLastCrossedParticle particle type; 605 - Changes in the PostStepGetFastSimulatio << 488 - Changes in the PostStepGetFastSimulationManagerTrigger() and 606 AtRestGetFastSimulationManagerTrigger() << 489 AtRestGetFastSimulationManagerTrigger()methodes to update the 607 fApplicableModelList when needed (fLast 490 fApplicableModelList when needed (fLastCrossedParticle != 608 the actual tracked particle); 491 the actual tracked particle); 609 - Changes in the << 492 - Changes in the 610 G4FastSimulationManager() (Constructor) 493 G4FastSimulationManager() (Constructor) 611 ActivateFastSimulationModel(), 494 ActivateFastSimulationModel(), 612 InActivateFastSimulationModel(), 495 InActivateFastSimulationModel(), 613 AtRestGetFastSimulationManagerTrigger(), 496 AtRestGetFastSimulationManagerTrigger(), 614 AddFastSimulationModel(), 497 AddFastSimulationModel(), 615 RemoveFastSimulationModel() 498 RemoveFastSimulationModel() 616 methodes to set the fLastCrossedParticle to 499 methodes to set the fLastCrossedParticle to NULL, forcing the 617 fApplicableModelList to be rebuilt. 500 fApplicableModelList to be rebuilt. 618 501 619 September 22, 1998 P.Mora de Freitas 502 September 22, 1998 P.Mora de Freitas 620 Fixed bug in parallel navigation. << 503 Fixed bug in parallel navigation. 621 File touched: G4FastSimulationManagerProces 504 File touched: G4FastSimulationManagerProcess.cc 622 Tested on HP-aCC. 505 Tested on HP-aCC. 623 506 624 September 17, 1998 P.Mora de Freitas 507 September 17, 1998 P.Mora de Freitas 625 G4FastSimulationManager::RemoveFastSimulati 508 G4FastSimulationManager::RemoveFastSimulationModel() updated to look 626 for also in the fInactivatedModels list. 509 for also in the fInactivatedModels list. 627 510 628 Tested on HP-aCC. 511 Tested on HP-aCC. 629 512 630 September 16, 1998 P.Mora de Freitas 513 September 16, 1998 P.Mora de Freitas 631 New /param/ control commands: 514 New /param/ control commands: 632 515 633 /param/ActivateModel <ModelName> 516 /param/ActivateModel <ModelName> 634 /param/InActivateModel <ModelName> 517 /param/InActivateModel <ModelName> 635 518 636 Activate or inactivate a given parameterisat 519 Activate or inactivate a given parameterisation model. 637 520 638 Tested on HP-aCC. 521 Tested on HP-aCC. 639 522 640 August 21, 1998 P.Mora de Freitas 523 August 21, 1998 P.Mora de Freitas 641 G4FastSimulationManagerProcess's G4ProcessTy 524 G4FastSimulationManagerProcess's G4ProcessType set to 642 fParameterisation, accordingly with procman-00 525 fParameterisation, accordingly with procman-00-02-03. 643 526 644 Tested on HP-aCC. 527 Tested on HP-aCC. 645 528 646 August 12, 1998 P.Mora de Freitas 529 August 12, 1998 P.Mora de Freitas 647 Improved the "close parameterisation control << 530 Improved the "close parameterisation control" to 648 531 649 1) avoid the close looping when unnecessary 532 1) avoid the close looping when unnecessary (mostly cases); 650 2) force re-close when necessary (insert/rem 533 2) force re-close when necessary (insert/remove ghosts). 651 534 652 Changes: 535 Changes: 653 536 654 1) the G4GlobalFastSimulationManager::fClose << 537 1) the G4GlobalFastSimulationManager::fClosed is now initialised 655 to true by the G4GlobalFastSimulationMana 538 to true by the G4GlobalFastSimulationManager constructor; 656 539 657 2) new method << 540 2) new method 658 541 659 void << 542 void 660 G4GlobalFastSimulationManager::FastSimula 543 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed(); 661 544 662 called by the AddGhostPlacement and Remov << 545 called by the AddGhostPlacement and RemoveGhostPlacement 663 G4FastSimulationManager methods to set fa 546 G4FastSimulationManager methods to set false the fClosed flag; 664 547 665 3) changes in the G4GlobalFastSimulationMana 548 3) changes in the G4GlobalFastSimulationManager::Notify method 666 to deal with these changes. 549 to deal with these changes. 667 550 668 Tested on HP-aCC. 551 Tested on HP-aCC. 669 552 670 August 11, 1998 P.Mora de Freitas 553 August 11, 1998 P.Mora de Freitas 671 Fix to the G4FastStep::KillPrimaryTrack() me 554 Fix to the G4FastStep::KillPrimaryTrack() method to drop the 672 nonsense line 555 nonsense line 673 556 674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 557 SetMomentumChange(0.,0.,0.) ; /* necessary ? */ 675 558 676 Tested on HP-aCC. 559 Tested on HP-aCC. 677 (Thanks to Willy Langeveld) 560 (Thanks to Willy Langeveld) 678 561 679 562 680 August 10, 1998 P.Mora de Freitas 563 August 10, 1998 P.Mora de Freitas 681 Fix to the SetPrimaryTrackFinalKineticEnergy 564 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method 682 from the G4FastStep class the SetMomentumChang 565 from the G4FastStep class the SetMomentumChange() call to insure that 683 the new momentum direction is a unit vector (a << 566 the new momentum direction is a unit vector (as asked by the 684 G4DynamicParticle::SetMomentumDirection method 567 G4DynamicParticle::SetMomentumDirection method). 685 568 686 Touched files: G4FastStep.hh (improved comme 569 Touched files: G4FastStep.hh (improved comments) 687 G4FastStep.cc (fixed) 570 G4FastStep.cc (fixed) 688 571 689 Tested on HP-aCC. 572 Tested on HP-aCC. 690 (Thanks to Willy Langeveld) 573 (Thanks to Willy Langeveld) 691 574 692 August 7, 1998 P.Mora de Freitas 575 August 7, 1998 P.Mora de Freitas 693 New /param/ commands directory with the comm 576 New /param/ commands directory with the commands: 694 577 695 /param/listEnvelopes [ParticleName] 578 /param/listEnvelopes [ParticleName] 696 579 697 - List all the envelope names for a given pa 580 - List all the envelope names for a given particle 698 (or for all particles if without parameter 581 (or for all particles if without parameters). 699 582 700 /param/listModels [EnvelopeName] 583 /param/listModels [EnvelopeName] 701 584 702 - List all the Model names for a given envel 585 - List all the Model names for a given envelope 703 (or for all envelopes if without parameter 586 (or for all envelopes if without parameters). 704 587 705 /param/listIsApplicable [ModelName] 588 /param/listIsApplicable [ModelName] 706 589 707 - List all the particle names a given model 590 - List all the particle names a given model is applicable 708 (or for all models if without parameters). 591 (or for all models if without parameters). 709 592 710 593 711 August 7, 1998 P.Mora de Freitas 594 August 7, 1998 P.Mora de Freitas 712 History file Created. 595 History file Created.