| Geant4 Cross Reference |
1 # Category param History << 1 $Id: History,v 1.28 2005/11/26 00:47:54 mverderi Exp $
>> 2 -------------------------------------------------------------------
2 3
3 See `CONTRIBUTING.rst` for details of **requir << 4 =========================================================
4 which **must** added in reverse chronological << 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP
5 It must **not** be used as a substitute for wr << 6 =========================================================
6 << 7
7 ---------------------------------------------- << 8 Category History file
8 << 9 ---------------------
9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) << 10 This file should be used by G4 developers and category coordinators
10 - In G4GlobalFastSimulationManager: << 11 to briefly summarize all major modifications introduced in the code
11 use G4ThreadLocalSingleton to avoid undelete << 12 and keep track of all category-tags.
12 << 13 It DOES NOT substitute the CVS log-message one should put at every
13 ## 2023-10-18 Ben Morgan (param-V11-01-03) << 14 committal in the CVS repository !
14 - Apply standard and extended clang-tidy fixes << 15
15 - Mark empty/obsolete functions as deprecated << 16 ----------------------------------------------------------
16 << 17 * Reverse chronological order (last date on top), please *
17 ## 2023-10-16 Ben Morgan (param-V11-01-02) << 18 ----------------------------------------------------------
18 - Apply standard clang-format-ing. <<
19 - Normal order accessors and docstrings. <<
20 <<
21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) <<
22 - In G4FastTrack, removed references to G4Touc <<
23 which is now deprecated. <<
24 <<
25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 <<
26 - Added missing virtual destructor to G4VFastS <<
27 <<
28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) <<
29 - Fixed compilation warnings for implicit type <<
30 <<
31 ## 2022-10-27 Makoto Asai (param-V11-00-03) <<
32 - G4FastSimHitMaker - making compatible to com <<
33 <<
34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 <<
35 - G4FastStep - delete copy constructor and ope <<
36 <<
37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) <<
38 - Adding the 'flush' method to the fast simula <<
39 This method allows to process the input buff <<
40 the end of the G4 event. It is used when par <<
41 The 'flash' is triggered inside the event lo <<
42 The fast simulation model may add secondarie <<
43 by Geant4. <<
44 <<
45 ## 2021-12-10 Ben Morgan (param-V11-00-00) <<
46 - Change to new Markdown History format <<
47 <<
48 --- <<
49 <<
50 # History entries prior to 11.0 <<
51 <<
52 April 16, 2021 Ben Morgan (param-V10-07-00) <<
53 - Migrate build to modular CMake API <<
54 <<
55 October 5, 2020, A. Zaborowska (param-V10-06-0 <<
56 - Introduce general facilities based on GFlash <<
57 to facilitate multiple hit (energy & positio <<
58 from fast simulation models. <<
59 <<
60 September 9, 2020, G. Cosmo (param-V10-06-02) <<
61 - Fixed minor Coverity defect for uninitialise <<
62 <<
63 April 21, 2020, A. Zaborowska (param-V10-06-01 <<
64 - Sanity check for root logical volumes for re <<
65 UI command /param/showSetup works also if no <<
66 <<
67 March 26, 2020, I. Semeniouk (param-V10-06-00) <<
68 - G4FastSimulationHelper : merge ActivateFastS <<
69 - G4FastSimulationManager.hh, G4VFastSimulatio <<
70 redefinition of G4Envelope type <<
71 <<
72 October 30, 2019, A. Zaborowska (param-v10-05- <<
73 - Register G4FastSimulationManagerProcess with <<
74 G4FastSimulationManagerHelper to ensure it i <<
75 invoked for a given step (ExclusivelyForced) <<
76 StronglyForced processes will be considered. <<
77 <<
78 December 19, 2017, G. Cosmo (param-V10-04-00) <<
79 - Fixed self-consistency in G4FastSimulationVe <<
80 Thanks to Raphael Isemann for reporting this <<
81 <<
82 November 03, 2016, M. Verderi (param-V10-02-01 <<
83 - New G4FastSimulationManagerHelper utility fo <<
84 adding G4FastSimulationManagerProcess to a <<
85 process manager. <<
86 <<
87 November 02, 2016, M. Verderi (param-V10-02-00 <<
88 - fix various Coverity defects. <<
89 <<
90 March 27, 2013, M. Verderi (param-V09-06-00) <<
91 - remove unused field 'fOnBoundary' in G4FastS <<
92 as this was causing a warning from clang. <<
93 <<
94 July 10, 2012, G. Cosmo (param-V09-05-00) <<
95 - Explicitly use inclusion of headers for syst <<
96 constants, in plan to remove implicit inclus <<
97 <<
98 September 30, 2011, M. Verderi (param-V09-04-0 <<
99 - Added missing new header file (G4FastSimulat <<
100 sources.cmake. <<
101 <<
102 September 30, 2011, M. Verderi (param-V09-04-0 <<
103 - Migration to new G4Exception scheme. <<
104 - what is V09-04-01 tag ? <<
105 <<
106 February 11, 2011, M. Verderi (param-V09-04-00 <<
107 - Implementation of method <<
108 void ProposePrimaryTrackFinalKineticEnergy ( <<
109 was missing : modified file G4FastStep.icc <<
110 <<
111 March 13, 2008, G. Cosmo (param-V09-01-00) <<
112 - Cleared compilation warnings in G4FastSimula <<
113 G4FastSimulationMessenger on gcc-4.3.0 for a <<
114 parentheses in nested if-else statements. <<
115 <<
116 November 30, 2007, M. Verderi <<
117 - Add Along methods to G4FSMP process <<
118 - tag as param-V09-00-01 <<
119 <<
120 November 30, 2007, M. Verderi <<
121 - minor corrections to G4FastSimulationManager <<
122 * add call fPathFinder->prepareNewrack(...) <<
123 * deactivate ghost navigator in EndOfTracki <<
124 - tag as param-V09-00-00 <<
125 <<
126 May 18, 2007, M. Verderi <<
127 - tag as param-V08-03-00 <<
128 <<
129 May 11, 2007, M. Verderi <<
130 - remove include/G4FastSimulationManagerProces <<
131 include/G4FlavoredParallelWorld.hh <<
132 include/G4GFSManager81.hh <<
133 src/G4FastSimulationManagerProcess81. <<
134 src/G4GFSManager81.cc <<
135 <<
136 <<
137 November 10, 2006, M. Verderi - param-V08-01-0 <<
138 - Limited number of warning messages printed b <<
139 G4GlobalFastSimulationManager. <<
140 - Renamed G4FastSimulationManagerProcess_forCo <<
141 G4FastSimulationManagerProcess81. <<
142 In addition, this class can now handle the c <<
143 i.e., the navigator for tracking, regardless <<
144 G4CoupledTransportation is used. (For other <<
145 of course no choice, and G4CoupledTransporta <<
146 <<
147 November 3, 2006 M. Verderi <<
148 - Introduced G4FastSimulationManagerProcess_fo <<
149 handling fast simulation in new parallel geo <<
150 the G4CoupledTransportation to be active. <<
151 - Introduced G4GFSManager81 class that gathers <<
152 default at next major release in the G4Globa <<
153 - G4FastSimulationManager: adapted to new sche <<
154 backward compatibilty. <<
155 - G4FastSimulationManagerProcess: mostly the s <<
156 - G4FastSimulationMessenger: new command creat <<
157 to show the fast simulation setup (region, m <<
158 It is only valid for geometry closed state. <<
159 command in the run manager for this. <<
160 19
161 November 25, 2005, M.Verderi - param-V07-01-0 << 20 November 25, 2005, M. Verderi param-V07-01-04
162 - put back Makoto's change: StartTracking(G4Tr 21 - put back Makoto's change: StartTracking(G4Track*)
163 22
164 November 25, 2005, M Verderi - param-V07-01-03 << 23 November 25, 2005, M. Verderi param-V07-01-03
165 - Make ghost functionnality available with G4R 24 - Make ghost functionnality available with G4Region
166 - ** Note ** Change back StartTracking(G4Track 25 - ** Note ** Change back StartTracking(G4Track*) -> StartTracking() in G4FSMP
167 StartTracking(G4Track*) was intro 26 StartTracking(G4Track*) was introduced in param-V07-01-02
168 because (I guess) of procman-V07-01-01 27 because (I guess) of procman-V07-01-01
169 This is to make param-V07-01-03 compatible w 28 This is to make param-V07-01-03 compatible with geant4-07-01-ref-05
170 29
171 November 21, 2005 M.Asai - param-V07-01-02 30 November 21, 2005 M.Asai - param-V07-01-02
172 - Fix warning message. 31 - Fix warning message.
173 32
174 November 02, 2005 G.Cosmo - param-V07-01-01 33 November 02, 2005 G.Cosmo - param-V07-01-01
175 - Corrected setting of envelope volumes and so 34 - Corrected setting of envelope volumes and solid in G4FastTrack.
176 - Migrated old scheme for G4Exception and some 35 - Migrated old scheme for G4Exception and some cosmetics...
177 36
178 October 28, 2005 M.Asai - param-V07-01-00 37 October 28, 2005 M.Asai - param-V07-01-00
179 - Working tag for merging "envelope" to G4Regi 38 - Working tag for merging "envelope" to G4Region.
180 39
181 December 07, 2004 G. Cosmo - param-V06-02-01 40 December 07, 2004 G. Cosmo - param-V06-02-01
182 - Implemented migration to <cmath>. 41 - Implemented migration to <cmath>.
183 42
184 November 26, 2004 M. Verderi - param-V06-02-00 43 November 26, 2004 M. Verderi - param-V06-02-00
185 - Implemented migration to new G4VParticleChan 44 - Implemented migration to new G4VParticleChange interfaces.
186 45
187 December 12, 2003 G. Cosmo - param-V06-00-00 46 December 12, 2003 G. Cosmo - param-V06-00-00
188 - G4FastSimulationVector.icc: use std_pvector: 47 - G4FastSimulationVector.icc: use std_pvector:: scope for calls to
189 base class. Fixes compilation problem on Int 48 base class. Fixes compilation problem on Intel-icc compiler.
190 49
191 November 10, 2003 G. Cosmo - param-V05-02-01 50 November 10, 2003 G. Cosmo - param-V05-02-01
192 - G4FastTrack: use G4Navigator::CreateTouchabl 51 - G4FastTrack: use G4Navigator::CreateTouchableHistoryHandle() instead of
193 CreateTouchableHistory() in method FRecordsA 52 CreateTouchableHistory() in method FRecordsAffineTransformation().
194 53
195 October 4, 2003 G. Cosmo - param-V05-02-00 54 October 4, 2003 G. Cosmo - param-V05-02-00
196 - Modified GNUmakefile: 55 - Modified GNUmakefile:
197 o added dependency to new module "geometry/n 56 o added dependency to new module "geometry/navigation".
198 - Coworks with "geometry-V05-02-00" and "digit 57 - Coworks with "geometry-V05-02-00" and "digits_hits-V05-02-00".
199 58
200 May 21, 2003 G. Cosmo - param-V05-01-00 59 May 21, 2003 G. Cosmo - param-V05-01-00
201 o Fixed pedantic warnings on Linux-g++ 60 o Fixed pedantic warnings on Linux-g++.
202 o Call base class in copy-constructor 61 o Call base class in copy-constructor of G4FastStep.
203 62
204 Nov 20, 2002 G. Cosmo - param-V04-01-02 63 Nov 20, 2002 G. Cosmo - param-V04-01-02
205 o Patched access to public static data in G4 64 o Patched access to public static data in G4FastStep.cc
206 and G4GlobalFastSimulationManager.cc to al 65 and G4GlobalFastSimulationManager.cc to allow porting on
207 Windows DLLs. 66 Windows DLLs.
208 67
209 Nov 15, 2002 S. Sadilov - param-V04-01-01 68 Nov 15, 2002 S. Sadilov - param-V04-01-01
210 o Fixed compilation problems on Windows in 69 o Fixed compilation problems on Windows in
211 G4FastSimulationManager.cc and G4GlobalFas 70 G4FastSimulationManager.cc and G4GlobalFastSimulationManager.cc
212 71
213 Nov 02, 2002 M. Verderi - param-V04-01-00 72 Nov 02, 2002 M. Verderi - param-V04-01-00
214 o Add method to retrieve G4VFastSimulationMo 73 o Add method to retrieve G4VFastSimulationModel by name.
215 The user's method is in G4GlobalFastSimula 74 The user's method is in G4GlobalFastSimulationManager:
216 75
217 GetFastSimulationModel(); 76 GetFastSimulationModel();
218 77
219 it is accompagnied by same methods name in 78 it is accompagnied by same methods name in
220 G4FastSimulationManager class. 79 G4FastSimulationManager class.
221 80
222 o Add "test" directory, used to test above f 81 o Add "test" directory, used to test above feature.
223 82
224 Oct 26, 2001 M. Verderi - param-V03-02-00 83 Oct 26, 2001 M. Verderi - param-V03-02-00
225 Fixes to clear warnings produced with gcc-2. 84 Fixes to clear warnings produced with gcc-2.95.2:
226 - loop index, where comparison with method " 85 - loop index, where comparison with method "size()" of
227 G4std::vector<T>, changed: int -> size_t << 86 G4std::vector<T>, changed: int -> size_t
228 - change "if ( a=b ) {..}" by "if ( (a=b) ) 87 - change "if ( a=b ) {..}" by "if ( (a=b) ) {...}"
229 this makes the compiler sure you want to mak 88 this makes the compiler sure you want to make an
230 assignement in the "if" condition 89 assignement in the "if" condition
231 - re-order initialisations of a few variable 90 - re-order initialisations of a few variables in constructors
232 to match the declaration order. 91 to match the declaration order.
233 Some warnings still exist, but regard the G4 92 Some warnings still exist, but regard the G4Propagator of geometry.
234 93
235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 94 Apr 3, 2001 J. Apostolakis - param-V03-00-00
236 - Modified G4FastSimulationManagerProcess call 95 - Modified G4FastSimulationManagerProcess call to PropagatorInField ComputeStep
237 to use new interface with G4FieldTrack (in 96 to use new interface with G4FieldTrack (in place of now obsolete interface.)
238 97
239 Nov 14, 2000 G. Cosmo - param-V02-00-01 98 Nov 14, 2000 G. Cosmo - param-V02-00-01
240 - Moved specific parameterisation models to th 99 - Moved specific parameterisation models to the new top category
241 "parameterisations". Moved files: 100 "parameterisations". Moved files:
242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm 101 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRmodel[.hh.cc],
243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster 102 G4IrregularXrayTRmodel[.hh.cc], G4PAIclusterModel[.hh.cc],
244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr 103 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXrayTRmodel[.hh.cc],
245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode 104 G4RegularXrayTRmodel[.hh.cc], G4VClusterModel[.hh.cc],
246 G4VXrayTRmodel[.hh.cc]. 105 G4VXrayTRmodel[.hh.cc].
247 - Cleaned-up GNUmakefile of non necessary depe 106 - Cleaned-up GNUmakefile of non necessary dependencies.
248 107
249 Aug 03, 2000 G. Cosmo - param-V02-00-00r 108 Aug 03, 2000 G. Cosmo - param-V02-00-00r
250 - Changed RandGauss to G4RandGauss in G4Irregu 109 - Changed RandGauss to G4RandGauss in G4IrregularXrayTRmodel.cc and
251 G4VXrayTRmodel.cc to fix events' reproducibi 110 G4VXrayTRmodel.cc to fix events' reproducibility problem.
252 - G4VXrayTRmodel.cc: fix to class destructor ( 111 - G4VXrayTRmodel.cc: fix to class destructor (V.Grichine)
253 112
254 Jun 15, 2000 G. Cosmo - param-V01-01-04 113 Jun 15, 2000 G. Cosmo - param-V01-01-04
255 - The tag coworks with global-V01-01-04 and ma 114 - The tag coworks with global-V01-01-04 and materials-V01-01-00:
256 o Fixed usage of G4complex type for ISO and 115 o Fixed usage of G4complex type for ISO and non-ISO compilers.
257 Affected files: G4FoamXrayTRmodel.cc, G4Ga 116 Affected files: G4FoamXrayTRmodel.cc, G4GamDistrXrayTRmodel.cc, G4PlateIrrGasXrayTRmodel.cc
258 and G4RegularXrayTRmodel.c 117 and G4RegularXrayTRmodel.cc.
259 In case of G4complex types passed to mathe 118 In case of G4complex types passed to mathematical functions, use G4std:: prefix.
260 o Fixed usage of G4Integrator class, now cha 119 o Fixed usage of G4Integrator class, now changed to templated to allow porting of the
261 code on SUN-CC compiler which does not imp 120 code on SUN-CC compiler which does not implement templated member functions.
262 Affected files: G4VXrayTRmodel[.hh.cc] 121 Affected files: G4VXrayTRmodel[.hh.cc]
263 122
264 Jun 6, 2000 M. Verderi & P. Mora de Freitas 123 Jun 6, 2000 M. Verderi & P. Mora de Freitas
265 - fixed compilation errors with HP-aCC for the 124 - fixed compilation errors with HP-aCC for the files G4RegularXrayTRmodel.cc,
266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod 125 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmodel.cc.
267 126
268 May 30, 2000 M. Verderi & P. Mora de Freitas 127 May 30, 2000 M. Verderi & P. Mora de Freitas
269 128
270 - parameterisation category is now RW free. 129 - parameterisation category is now RW free.
271 130
272 September 16, 1999 M. Verderi & P. Mora de Fre 131 September 16, 1999 M. Verderi & P. Mora de Freitas
273 132
274 - Fixed bug in G4FastStep::CheckIt() method. 133 - Fixed bug in G4FastStep::CheckIt() method.
275 134
276 April 19, 1999 M. Verderi & P. Mora de Freitas 135 April 19, 1999 M. Verderi & P. Mora de Freitas
277 136
278 Changes in G4FastStep to co-work with track-01 137 Changes in G4FastStep to co-work with track-01-00-04:
279 138
280 1) The method void CheckIt(const G4Track&) bec << 139 1) The method void CheckIt(const G4Track&) becomes
281 G4bool CheckIt(const G4Track&); 140 G4bool CheckIt(const G4Track&);
282 2) The FAST_STEP_DEBUG compiling option disapp 141 2) The FAST_STEP_DEBUG compiling option disappears;
283 3) Call to CheckIt controled by the G4VParticl 142 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute.
284 143
285 Miscellaneous: the declaration "G4double mass 144 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh
286 corrected to G4double mass =...". 145 corrected to G4double mass =...".
287 146
288 April 15, 1999 M. Verderi & P. Mora de Freitas 147 April 15, 1999 M. Verderi & P. Mora de Freitas
289 148
290 Tasks to decouple visualization from processes 149 Tasks to decouple visualization from processes/parameterisation:
291 150
292 1) G4GlobalFastSimulationManager now inherites 151 1) G4GlobalFastSimulationManager now inherites from the intercoms/
293 G4VGlobalFastSimulationManager to allow visual << 152 G4VGlobalFastSimulationManager to allow visualisation to get a
294 concrete instance pointer to the G4GlobalFastS 153 concrete instance pointer to the G4GlobalFastSimulationManager,
295 if any. 154 if any.
296 155
297 2) G4FlavoredParallelWorld now inherites from 156 2) G4FlavoredParallelWorld now inherites from the intercoms/
298 G4VFlavoredParallelWorld, a pure virtual abstr 157 G4VFlavoredParallelWorld, a pure virtual abstract class to interface
299 parameterisation with visualization. 158 parameterisation with visualization.
300 159
301 Co-works with intercoms-01-00-01 tag 160 Co-works with intercoms-01-00-01 tag
302 161
303 Modified files: 162 Modified files:
304 --------------- 163 ---------------
305 G4FlavoredParallelWorld.hh 164 G4FlavoredParallelWorld.hh
306 G4GlobalFastSimulationManager.hh 165 G4GlobalFastSimulationManager.hh
307 G4GlobalFastSimulationManager.cc 166 G4GlobalFastSimulationManager.cc
308 167
309 Done, tested, system-tested on HP-aCC with exe 168 Done, tested, system-tested on HP-aCC with exemple N05.
310 169
311 April 14, 1999 M. Verderi & P. Mora de Freitas 170 April 14, 1999 M. Verderi & P. Mora de Freitas
312 171
313 Several consolidation tasks (thanks to G. Cosm 172 Several consolidation tasks (thanks to G. Cosmo):
314 173
315 1) Warning: << 174 1) Warning:
316 ----------- 175 -----------
317 176
318 Pointers usage 177 Pointers usage
319 178
320 - Setting pointers to 0 after delete: 179 - Setting pointers to 0 after delete:
321 180
322 delete pA; 181 delete pA;
323 pA = 0; 182 pA = 0;
324 183
325 - Avoid to use "NULL". 184 - Avoid to use "NULL".
326 185
327 Modified files: 186 Modified files:
328 --------------- 187 ---------------
329 G4FastSimulationManager.hh 188 G4FastSimulationManager.hh
330 G4FastTrack.hh 189 G4FastTrack.hh
331 G4FlavoredParallelWorld.hh 190 G4FlavoredParallelWorld.hh
332 G4FastSimulationManager.cc 191 G4FastSimulationManager.cc
333 G4FastSimulationMessenger.cc 192 G4FastSimulationMessenger.cc
334 G4FastSimulationManagerProcess.cc 193 G4FastSimulationManagerProcess.cc
335 G4FastTrack.cc 194 G4FastTrack.cc
336 G4GlobalFastSimulationManager.cc 195 G4GlobalFastSimulationManager.cc
337 G4VFastSimulationModel.cc 196 G4VFastSimulationModel.cc
338 197
339 Status: << 198 Status:
340 ------- 199 -------
341 Done, tested, system-tested on HP-aCC with exe 200 Done, tested, system-tested on HP-aCC with exemple N05.
342 201
343 2) Warning: 202 2) Warning:
344 ----------- 203 -----------
345 include/G4FastSimulationManager.hh:163 204 include/G4FastSimulationManager.hh:163
346 Public member functions shall always retur 205 Public member functions shall always return const handles to member data
347 Severe violation: Universal Coding Standar 206 Severe violation: Universal Coding Standards item 18
348 207
349 offending code: 208 offending code:
350 --------------- 209 ---------------
351 inline G4VParticleChange* G4FastSimulationMana 210 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange()
352 { 211 {
353 return &fFastStep; 212 return &fFastStep;
354 } 213 }
355 214
356 Diagnostic: 215 Diagnostic:
357 ---------- 216 ----------
358 217
359 Called by the G4FastSimulationManagerProcess << 218 Called by the G4FastSimulationManagerProcess to return it in the
360 PostStepDoIt call. << 219 PostStepDoIt call.
361 220
362 Action: 221 Action:
363 ------- 222 -------
364 The G4FastSimulationManager::GettheParticleCha 223 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any
365 more. The G4VParticleChange* is now returned d 224 more. The G4VParticleChange* is now returned directly when invoking the
366 G4FastSimulationManager::InvokePostStepDoIt() 225 G4FastSimulationManager::InvokePostStepDoIt() and
367 G4FastSimulationManager::InvokeAtRestDoIt() me 226 G4FastSimulationManager::InvokeAtRestDoIt() methodes.
368 227
369 Modified files: 228 Modified files:
370 --------------- 229 ---------------
371 G4FastSimulationManager.hh 230 G4FastSimulationManager.hh
372 G4FastSimulationManager.cc 231 G4FastSimulationManager.cc
373 G4FastSimulationManagerProcess.cc 232 G4FastSimulationManagerProcess.cc
374 233
375 Status: << 234 Status:
376 ------- 235 -------
377 Done, tested, system-tested on HP-aCC with exe 236 Done, tested, system-tested on HP-aCC with exemple N05.
378 237
379 3) Warning: 238 3) Warning:
380 ----------- 239 -----------
381 include/G4FastSimulationManagerProcess.hh:52 240 include/G4FastSimulationManagerProcess.hh:52
382 If a class has virtual functions it shall 241 If a class has virtual functions it shall have a virtual destructor
383 Severe violation: Universal Coding Standar 242 Severe violation: Universal Coding Standards item 17
384 class G4FastSimulationManagerProcess has v 243 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor.
385 244
386 offending code: 245 offending code:
387 --------------- 246 ---------------
388 ~G4FastSimulationManagerProcess(); 247 ~G4FastSimulationManagerProcess();
389 248
390 Diagnostic: 249 Diagnostic:
391 ---------- 250 ----------
392 Nobody should inherites from G4FastSimulatio << 251 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual
393 is added. 252 is added.
394 253
395 Action: 254 Action:
396 ------- 255 -------
397 virtual ~G4FastSimulationManagerProcess(); 256 virtual ~G4FastSimulationManagerProcess();
398 257
399 Modified files: 258 Modified files:
400 --------------- 259 ---------------
401 G4FastSimulationManagerProcess.hh 260 G4FastSimulationManagerProcess.hh
402 261
403 Status: << 262 Status:
404 ------- 263 -------
405 Done. 264 Done.
406 265
407 4) Warning: 266 4) Warning:
408 ----------- 267 -----------
409 include/G4FastSimulationMessenger.hh:36 268 include/G4FastSimulationMessenger.hh:36
410 If a class has virtual functions it shall 269 If a class has virtual functions it shall have a virtual destructor
411 Severe violation: Universal Coding Standar 270 Severe violation: Universal Coding Standards item 17
412 class G4FastSimulationMessenger has virtua 271 class G4FastSimulationMessenger has virtual functions without a virtual destructor.
413 272
414 273
415 offending code: 274 offending code:
416 --------------- 275 ---------------
417 ~G4FastSimulationMessenger(); 276 ~G4FastSimulationMessenger();
418 277
419 Diagnostic: 278 Diagnostic:
420 ---------- 279 ----------
421 Nobody should inherites from G4FastSimulatio << 280 Nobody should inherites from G4FastSimulationMessenger BUT for virtual
422 is added. 281 is added.
423 282
424 Action: 283 Action:
425 ------- 284 -------
426 virtual ~G4FastSimulationMessenger(); 285 virtual ~G4FastSimulationMessenger();
427 286
428 Modified files: 287 Modified files:
429 --------------- 288 ---------------
430 G4FastSimulationMessenger.hh 289 G4FastSimulationMessenger.hh
431 290
432 Status: << 291 Status:
433 ------- 292 -------
434 Done. 293 Done.
435 294
436 5) Warning: 295 5) Warning:
437 ----------- 296 -----------
438 include/G4FastStep.hh:224 297 include/G4FastStep.hh:224
439 Operator= should call base class operator= 298 Operator= should call base class operator=
440 Possible severe violation: Effective C++ i 299 Possible severe violation: Effective C++ item 16
441 operator= in class G4FastStep, should call 300 operator= in class G4FastStep, should call operator= in base class G4VParticleChange
442 301
443 offending code: 302 offending code:
444 --------------- 303 ---------------
445 G4FastStep & G4FastStep::operator=(const G4Fas 304 G4FastStep & G4FastStep::operator=(const G4FastStep &right)
446 { 305 {
447 if (this != &right) 306 if (this != &right)
448 { 307 {
449 theListOfSecondaries = right.th 308 theListOfSecondaries = right.theListOfSecondaries;
450 theSizeOftheListOfSecondaries = right.th 309 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries;
451 theNumberOfSecondaries = right.th 310 theNumberOfSecondaries = right.theNumberOfSecondaries;
452 theStatusChange = right.th 311 theStatusChange = right.theStatusChange;
453 theMomentumChange = right.th 312 theMomentumChange = right.theMomentumChange;
454 thePolarizationChange = right.th 313 thePolarizationChange = right.thePolarizationChange;
455 thePositionChange = right.th 314 thePositionChange = right.thePositionChange;
456 theTimeChange = right.th 315 theTimeChange = right.theTimeChange;
457 theEnergyChange = right.th 316 theEnergyChange = right.theEnergyChange;
458 theTrueStepLength = right.th 317 theTrueStepLength = right.theTrueStepLength;
459 theLocalEnergyDeposit = right.th 318 theLocalEnergyDeposit = right.theLocalEnergyDeposit;
460 theSteppingControlFlag = right.th 319 theSteppingControlFlag = right.theSteppingControlFlag;
461 theWeightChange = right.th 320 theWeightChange = right.theWeightChange;
462 } 321 }
463 return *this; 322 return *this;
464 } 323 }
465 324
466 Diagnostic: 325 Diagnostic:
467 ---------- 326 ----------
468 Bug detected. 327 Bug detected.
469 328
470 Action: 329 Action:
471 ------- 330 -------
472 Insert the call 331 Insert the call
473 G4VParticleChange::operator=(right); 332 G4VParticleChange::operator=(right);
474 333
475 Status: 334 Status:
476 ------- 335 -------
477 Done, tested, system-tested on HP-aCC with e 336 Done, tested, system-tested on HP-aCC with exemple N05.
478 337
479 Modified files: 338 Modified files:
480 --------------- 339 ---------------
481 G4FastStep.cc 340 G4FastStep.cc
482 341
483 6) Warning: 342 6) Warning:
484 ----------- 343 -----------
485 include/G4FastStep.hh:59 344 include/G4FastStep.hh:59
486 Avoid data members in the public interface 345 Avoid data members in the public interface
487 Violation: Effective C++ item 20 346 Violation: Effective C++ item 20
488 Public data members for class G4FastStep: 347 Public data members for class G4FastStep:
489 debugFlag 348 debugFlag
490 349
491 350
492 offending code: 351 offending code:
493 --------------- 352 ---------------
494 public: 353 public:
495 ... 354 ...
496 G4bool debugFlag; 355 G4bool debugFlag;
497 356
498 Diagnostic: 357 Diagnostic:
499 ---------- 358 ----------
500 Historical usage. 359 Historical usage.
501 360
502 Action: 361 Action:
503 ------- 362 -------
504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 363 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file.
505 364
506 Modified files: 365 Modified files:
507 --------------- 366 ---------------
508 G4FastStep.hh, G4FastStep.cc 367 G4FastStep.hh, G4FastStep.cc
509 368
510 Status: 369 Status:
511 ------- 370 -------
512 Done, tested, system-tested on HP-aCC with e 371 Done, tested, system-tested on HP-aCC with exemple N05.
513 372
514 7) Warning: 373 7) Warning:
515 ----------- 374 -----------
516 include/G4FastStep.hh:59 375 include/G4FastStep.hh:59
517 If a class has virtual functions it shall 376 If a class has virtual functions it shall have a virtual destructor
518 Severe violation: Universal Coding Standar 377 Severe violation: Universal Coding Standards item 17
519 class G4FastStep has virtual functions wit 378 class G4FastStep has virtual functions without a virtual destructor.
520 379
521 380
522 offending code: 381 offending code:
523 --------------- 382 ---------------
524 ~G4FastStep(); 383 ~G4FastStep();
525 384
526 Diagnostic: 385 Diagnostic:
527 ---------- 386 ----------
528 Nobody should inherites from G4FastStep BUT 387 Nobody should inherites from G4FastStep BUT virtual added.
529 388
530 Action: 389 Action:
531 ------- 390 -------
532 virtual ~G4FastStep(); 391 virtual ~G4FastStep();
533 392
534 Modified files: 393 Modified files:
535 --------------- 394 ---------------
536 G4FastStep.hh 395 G4FastStep.hh
537 396
538 Status: 397 Status:
539 ------- 398 -------
540 Done, tested, system-tested on HP-aCC with e 399 Done, tested, system-tested on HP-aCC with exemple N05.
541 400
542 401
543 December 7, 1998 M. Verderi 402 December 7, 1998 M. Verderi
544 G4FastSimulationManagerProcess class: 403 G4FastSimulationManagerProcess class:
545 Fixes made for ghost navigation with 404 Fixes made for ghost navigation with
546 mag-field: 405 mag-field:
547 LocateGlobalPointAndUpdateTouchable is 406 LocateGlobalPointAndUpdateTouchable is
548 always used (in not the Locate...Setup 407 always used (in not the Locate...Setup
549 method) 408 method)
550 In PostStepDoIt: correction of position and 409 In PostStepDoIt: correction of position and
551 direction of the track are made when << 410 direction of the track are made when
552 possible in case of mag-field. 411 possible in case of mag-field.
553 This correction comes from the fact that a 412 This correction comes from the fact that a
554 small discrepancy appears on those quantitie 413 small discrepancy appears on those quantities
555 because of the numerical integration along 414 because of the numerical integration along
556 the field on the track path: the G4FSMP 415 the field on the track path: the G4FSMP
557 proposes a curve-length, the transportation 416 proposes a curve-length, the transportation
558 moves the track along this curve, however 417 moves the track along this curve, however
559 the end point position and direction are 418 the end point position and direction are
560 slightly different from those expected by 419 slightly different from those expected by
561 the G4FSMP when it proposed the length. 420 the G4FSMP when it proposed the length.
562 421
563 November 20,1998 M. Verderi 422 November 20,1998 M. Verderi
564 G4FastStep class: 423 G4FastStep class:
565 Remove track/G4BiasingTag.hh dependancy (ob 424 Remove track/G4BiasingTag.hh dependancy (obsolete).
566 Adapted to new shceme of Event Biasing mech 425 Adapted to new shceme of Event Biasing mechanism,
567 consistently with track-00-04-01 tag. 426 consistently with track-00-04-01 tag.
568 427
569 November 11,1998 M. Verderi 428 November 11,1998 M. Verderi
570 Merge of param-00-03-02 & param-00-03-02a i 429 Merge of param-00-03-02 & param-00-03-02a into
571 param-00-03-04a (hopefully...) 430 param-00-03-04a (hopefully...)
572 The point is the chnage of signature in the 431 The point is the chnage of signature in the
573 LocateGlobalPointAndSetup(..) of the G4Navi 432 LocateGlobalPointAndSetup(..) of the G4Navigator making use now
574 of the track direction. The G4FastSimulatio 433 of the track direction. The G4FastSimulationManagerProcess is
575 changed accordingly: 434 changed accordingly:
576 fGhostNavigator.LocateGlobalPointAndSetup(t 435 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true);
577 436
578 437
579 November 6, 1998 M. Verderi 438 November 6, 1998 M. Verderi
580 - Extension of the G4FastStep to allow the 439 - Extension of the G4FastStep to allow the biasing technic.
581 Changes are made in: 440 Changes are made in:
582 - G4FastStep.hh/.icc: 441 - G4FastStep.hh/.icc:
583 new member G4BiasingTa 442 new member G4BiasingTag fBiasTag;
584 new method SetPrimaryT 443 new method SetPrimaryTrackFinalBiasingTag
585 ( G4BiasingTag 444 ( G4BiasingTag aTag );
586 - G4FastStep.cc: 445 - G4FastStep.cc:
587 Initialize(); 446 Initialize();
588 operator=; << 447 operator=;
589 UpdateForPostStep(); 448 UpdateForPostStep();
590 UpdateForAtRest(); << 449 UpdateForAtRest();
591 450
592 October 26, 1998 P.Mora de Freitas 451 October 26, 1998 P.Mora de Freitas
593 - G4FastSimulationManagerProcess and G4Fast 452 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal
594 with at rest parameterisations also when 453 with at rest parameterisations also when using parallel geometry.
595 454
596 October 8, 1998 P.Mora de Freitas 455 October 8, 1998 P.Mora de Freitas
597 - The G4VFastSimulationModel::IsApplicable( 456 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual
598 methode. 457 methode.
599 - G4FastSimulationManager optimisation: 458 - G4FastSimulationManager optimisation:
600 - New G4ParticleDefinition* fLastCrossedP 459 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps
601 the last particle type with touched the 460 the last particle type with touched the envelope;
602 - New G4RWTPtrOrderedVector<G4VFastSimula 461 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList
603 data member, keeps the model list of th << 462 data member, keeps the model list of the applicable models for
604 the actual fLastCrossedParticle particl 463 the actual fLastCrossedParticle particle type;
605 - Changes in the PostStepGetFastSimulatio << 464 - Changes in the PostStepGetFastSimulationManagerTrigger() and
606 AtRestGetFastSimulationManagerTrigger() << 465 AtRestGetFastSimulationManagerTrigger()methodes to update the
607 fApplicableModelList when needed (fLast 466 fApplicableModelList when needed (fLastCrossedParticle !=
608 the actual tracked particle); 467 the actual tracked particle);
609 - Changes in the << 468 - Changes in the
610 G4FastSimulationManager() (Constructor) 469 G4FastSimulationManager() (Constructor)
611 ActivateFastSimulationModel(), 470 ActivateFastSimulationModel(),
612 InActivateFastSimulationModel(), 471 InActivateFastSimulationModel(),
613 AtRestGetFastSimulationManagerTrigger(), 472 AtRestGetFastSimulationManagerTrigger(),
614 AddFastSimulationModel(), 473 AddFastSimulationModel(),
615 RemoveFastSimulationModel() 474 RemoveFastSimulationModel()
616 methodes to set the fLastCrossedParticle to 475 methodes to set the fLastCrossedParticle to NULL, forcing the
617 fApplicableModelList to be rebuilt. 476 fApplicableModelList to be rebuilt.
618 477
619 September 22, 1998 P.Mora de Freitas 478 September 22, 1998 P.Mora de Freitas
620 Fixed bug in parallel navigation. << 479 Fixed bug in parallel navigation.
621 File touched: G4FastSimulationManagerProces 480 File touched: G4FastSimulationManagerProcess.cc
622 Tested on HP-aCC. 481 Tested on HP-aCC.
623 482
624 September 17, 1998 P.Mora de Freitas 483 September 17, 1998 P.Mora de Freitas
625 G4FastSimulationManager::RemoveFastSimulati 484 G4FastSimulationManager::RemoveFastSimulationModel() updated to look
626 for also in the fInactivatedModels list. 485 for also in the fInactivatedModels list.
627 486
628 Tested on HP-aCC. 487 Tested on HP-aCC.
629 488
630 September 16, 1998 P.Mora de Freitas 489 September 16, 1998 P.Mora de Freitas
631 New /param/ control commands: 490 New /param/ control commands:
632 491
633 /param/ActivateModel <ModelName> 492 /param/ActivateModel <ModelName>
634 /param/InActivateModel <ModelName> 493 /param/InActivateModel <ModelName>
635 494
636 Activate or inactivate a given parameterisat 495 Activate or inactivate a given parameterisation model.
637 496
638 Tested on HP-aCC. 497 Tested on HP-aCC.
639 498
640 August 21, 1998 P.Mora de Freitas 499 August 21, 1998 P.Mora de Freitas
641 G4FastSimulationManagerProcess's G4ProcessTy 500 G4FastSimulationManagerProcess's G4ProcessType set to
642 fParameterisation, accordingly with procman-00 501 fParameterisation, accordingly with procman-00-02-03.
643 502
644 Tested on HP-aCC. 503 Tested on HP-aCC.
645 504
646 August 12, 1998 P.Mora de Freitas 505 August 12, 1998 P.Mora de Freitas
647 Improved the "close parameterisation control << 506 Improved the "close parameterisation control" to
648 507
649 1) avoid the close looping when unnecessary 508 1) avoid the close looping when unnecessary (mostly cases);
650 2) force re-close when necessary (insert/rem 509 2) force re-close when necessary (insert/remove ghosts).
651 510
652 Changes: 511 Changes:
653 512
654 1) the G4GlobalFastSimulationManager::fClose << 513 1) the G4GlobalFastSimulationManager::fClosed is now initialised
655 to true by the G4GlobalFastSimulationMana 514 to true by the G4GlobalFastSimulationManager constructor;
656 515
657 2) new method << 516 2) new method
658 517
659 void << 518 void
660 G4GlobalFastSimulationManager::FastSimula 519 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed();
661 520
662 called by the AddGhostPlacement and Remov << 521 called by the AddGhostPlacement and RemoveGhostPlacement
663 G4FastSimulationManager methods to set fa 522 G4FastSimulationManager methods to set false the fClosed flag;
664 523
665 3) changes in the G4GlobalFastSimulationMana 524 3) changes in the G4GlobalFastSimulationManager::Notify method
666 to deal with these changes. 525 to deal with these changes.
667 526
668 Tested on HP-aCC. 527 Tested on HP-aCC.
669 528
670 August 11, 1998 P.Mora de Freitas 529 August 11, 1998 P.Mora de Freitas
671 Fix to the G4FastStep::KillPrimaryTrack() me 530 Fix to the G4FastStep::KillPrimaryTrack() method to drop the
672 nonsense line 531 nonsense line
673 532
674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 533 SetMomentumChange(0.,0.,0.) ; /* necessary ? */
675 534
676 Tested on HP-aCC. 535 Tested on HP-aCC.
677 (Thanks to Willy Langeveld) 536 (Thanks to Willy Langeveld)
678 537
679 538
680 August 10, 1998 P.Mora de Freitas 539 August 10, 1998 P.Mora de Freitas
681 Fix to the SetPrimaryTrackFinalKineticEnergy 540 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method
682 from the G4FastStep class the SetMomentumChang 541 from the G4FastStep class the SetMomentumChange() call to insure that
683 the new momentum direction is a unit vector (a << 542 the new momentum direction is a unit vector (as asked by the
684 G4DynamicParticle::SetMomentumDirection method 543 G4DynamicParticle::SetMomentumDirection method).
685 544
686 Touched files: G4FastStep.hh (improved comme 545 Touched files: G4FastStep.hh (improved comments)
687 G4FastStep.cc (fixed) 546 G4FastStep.cc (fixed)
688 547
689 Tested on HP-aCC. 548 Tested on HP-aCC.
690 (Thanks to Willy Langeveld) 549 (Thanks to Willy Langeveld)
691 550
692 August 7, 1998 P.Mora de Freitas 551 August 7, 1998 P.Mora de Freitas
693 New /param/ commands directory with the comm 552 New /param/ commands directory with the commands:
694 553
695 /param/listEnvelopes [ParticleName] 554 /param/listEnvelopes [ParticleName]
696 555
697 - List all the envelope names for a given pa 556 - List all the envelope names for a given particle
698 (or for all particles if without parameter 557 (or for all particles if without parameters).
699 558
700 /param/listModels [EnvelopeName] 559 /param/listModels [EnvelopeName]
701 560
702 - List all the Model names for a given envel 561 - List all the Model names for a given envelope
703 (or for all envelopes if without parameter 562 (or for all envelopes if without parameters).
704 563
705 /param/listIsApplicable [ModelName] 564 /param/listIsApplicable [ModelName]
706 565
707 - List all the particle names a given model 566 - List all the particle names a given model is applicable
708 (or for all models if without parameters). 567 (or for all models if without parameters).
709 568
710 569
711 August 7, 1998 P.Mora de Freitas 570 August 7, 1998 P.Mora de Freitas
712 History file Created. 571 History file Created.