| Geant4 Cross Reference |
1 # Category param History << 1 $Id: History,v 1.22 2004/12/07 08:22:11 gcosmo Exp $
>> 2 -------------------------------------------------------------------
2 3
3 See `CONTRIBUTING.rst` for details of **requir << 4 =========================================================
4 which **must** added in reverse chronological << 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP
5 It must **not** be used as a substitute for wr << 6 =========================================================
6 << 7
7 ---------------------------------------------- << 8 Category History file
8 << 9 ---------------------
9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) << 10 This file should be used by G4 developers and category coordinators
10 - In G4GlobalFastSimulationManager: << 11 to briefly summarize all major modifications introduced in the code
11 use G4ThreadLocalSingleton to avoid undelete << 12 and keep track of all category-tags.
12 << 13 It DOES NOT substitute the CVS log-message one should put at every
13 ## 2023-10-18 Ben Morgan (param-V11-01-03) << 14 committal in the CVS repository !
14 - Apply standard and extended clang-tidy fixes << 15
15 - Mark empty/obsolete functions as deprecated << 16 ----------------------------------------------------------
16 << 17 * Reverse chronological order (last date on top), please *
17 ## 2023-10-16 Ben Morgan (param-V11-01-02) << 18 ----------------------------------------------------------
18 - Apply standard clang-format-ing. <<
19 - Normal order accessors and docstrings. <<
20 <<
21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) <<
22 - In G4FastTrack, removed references to G4Touc <<
23 which is now deprecated. <<
24 <<
25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 <<
26 - Added missing virtual destructor to G4VFastS <<
27 <<
28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) <<
29 - Fixed compilation warnings for implicit type <<
30 <<
31 ## 2022-10-27 Makoto Asai (param-V11-00-03) <<
32 - G4FastSimHitMaker - making compatible to com <<
33 <<
34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 <<
35 - G4FastStep - delete copy constructor and ope <<
36 <<
37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) <<
38 - Adding the 'flush' method to the fast simula <<
39 This method allows to process the input buff <<
40 the end of the G4 event. It is used when par <<
41 The 'flash' is triggered inside the event lo <<
42 The fast simulation model may add secondarie <<
43 by Geant4. <<
44 <<
45 ## 2021-12-10 Ben Morgan (param-V11-00-00) <<
46 - Change to new Markdown History format <<
47 <<
48 --- <<
49 <<
50 # History entries prior to 11.0 <<
51 <<
52 April 16, 2021 Ben Morgan (param-V10-07-00) <<
53 - Migrate build to modular CMake API <<
54 <<
55 October 5, 2020, A. Zaborowska (param-V10-06-0 <<
56 - Introduce general facilities based on GFlash <<
57 to facilitate multiple hit (energy & positio <<
58 from fast simulation models. <<
59 <<
60 September 9, 2020, G. Cosmo (param-V10-06-02) <<
61 - Fixed minor Coverity defect for uninitialise <<
62 <<
63 April 21, 2020, A. Zaborowska (param-V10-06-01 <<
64 - Sanity check for root logical volumes for re <<
65 UI command /param/showSetup works also if no <<
66 <<
67 March 26, 2020, I. Semeniouk (param-V10-06-00) <<
68 - G4FastSimulationHelper : merge ActivateFastS <<
69 - G4FastSimulationManager.hh, G4VFastSimulatio <<
70 redefinition of G4Envelope type <<
71 <<
72 October 30, 2019, A. Zaborowska (param-v10-05- <<
73 - Register G4FastSimulationManagerProcess with <<
74 G4FastSimulationManagerHelper to ensure it i <<
75 invoked for a given step (ExclusivelyForced) <<
76 StronglyForced processes will be considered. <<
77 <<
78 December 19, 2017, G. Cosmo (param-V10-04-00) <<
79 - Fixed self-consistency in G4FastSimulationVe <<
80 Thanks to Raphael Isemann for reporting this <<
81 <<
82 November 03, 2016, M. Verderi (param-V10-02-01 <<
83 - New G4FastSimulationManagerHelper utility fo <<
84 adding G4FastSimulationManagerProcess to a <<
85 process manager. <<
86 <<
87 November 02, 2016, M. Verderi (param-V10-02-00 <<
88 - fix various Coverity defects. <<
89 <<
90 March 27, 2013, M. Verderi (param-V09-06-00) <<
91 - remove unused field 'fOnBoundary' in G4FastS <<
92 as this was causing a warning from clang. <<
93 <<
94 July 10, 2012, G. Cosmo (param-V09-05-00) <<
95 - Explicitly use inclusion of headers for syst <<
96 constants, in plan to remove implicit inclus <<
97 <<
98 September 30, 2011, M. Verderi (param-V09-04-0 <<
99 - Added missing new header file (G4FastSimulat <<
100 sources.cmake. <<
101 <<
102 September 30, 2011, M. Verderi (param-V09-04-0 <<
103 - Migration to new G4Exception scheme. <<
104 - what is V09-04-01 tag ? <<
105 <<
106 February 11, 2011, M. Verderi (param-V09-04-00 <<
107 - Implementation of method <<
108 void ProposePrimaryTrackFinalKineticEnergy ( <<
109 was missing : modified file G4FastStep.icc <<
110 <<
111 March 13, 2008, G. Cosmo (param-V09-01-00) <<
112 - Cleared compilation warnings in G4FastSimula <<
113 G4FastSimulationMessenger on gcc-4.3.0 for a <<
114 parentheses in nested if-else statements. <<
115 <<
116 November 30, 2007, M. Verderi <<
117 - Add Along methods to G4FSMP process <<
118 - tag as param-V09-00-01 <<
119 <<
120 November 30, 2007, M. Verderi <<
121 - minor corrections to G4FastSimulationManager <<
122 * add call fPathFinder->prepareNewrack(...) <<
123 * deactivate ghost navigator in EndOfTracki <<
124 - tag as param-V09-00-00 <<
125 <<
126 May 18, 2007, M. Verderi <<
127 - tag as param-V08-03-00 <<
128 <<
129 May 11, 2007, M. Verderi <<
130 - remove include/G4FastSimulationManagerProces <<
131 include/G4FlavoredParallelWorld.hh <<
132 include/G4GFSManager81.hh <<
133 src/G4FastSimulationManagerProcess81. <<
134 src/G4GFSManager81.cc <<
135 <<
136 <<
137 November 10, 2006, M. Verderi - param-V08-01-0 <<
138 - Limited number of warning messages printed b <<
139 G4GlobalFastSimulationManager. <<
140 - Renamed G4FastSimulationManagerProcess_forCo <<
141 G4FastSimulationManagerProcess81. <<
142 In addition, this class can now handle the c <<
143 i.e., the navigator for tracking, regardless <<
144 G4CoupledTransportation is used. (For other <<
145 of course no choice, and G4CoupledTransporta <<
146 <<
147 November 3, 2006 M. Verderi <<
148 - Introduced G4FastSimulationManagerProcess_fo <<
149 handling fast simulation in new parallel geo <<
150 the G4CoupledTransportation to be active. <<
151 - Introduced G4GFSManager81 class that gathers <<
152 default at next major release in the G4Globa <<
153 - G4FastSimulationManager: adapted to new sche <<
154 backward compatibilty. <<
155 - G4FastSimulationManagerProcess: mostly the s <<
156 - G4FastSimulationMessenger: new command creat <<
157 to show the fast simulation setup (region, m <<
158 It is only valid for geometry closed state. <<
159 command in the run manager for this. <<
160 <<
161 November 25, 2005, M.Verderi - param-V07-01-0 <<
162 - put back Makoto's change: StartTracking(G4Tr <<
163 <<
164 November 25, 2005, M Verderi - param-V07-01-03 <<
165 - Make ghost functionnality available with G4R <<
166 - ** Note ** Change back StartTracking(G4Track <<
167 StartTracking(G4Track*) was intro <<
168 because (I guess) of procman-V07-01-01 <<
169 This is to make param-V07-01-03 compatible w <<
170 <<
171 November 21, 2005 M.Asai - param-V07-01-02 <<
172 - Fix warning message. <<
173 <<
174 November 02, 2005 G.Cosmo - param-V07-01-01 <<
175 - Corrected setting of envelope volumes and so <<
176 - Migrated old scheme for G4Exception and some <<
177 <<
178 October 28, 2005 M.Asai - param-V07-01-00 <<
179 - Working tag for merging "envelope" to G4Regi <<
180 19
181 December 07, 2004 G. Cosmo - param-V06-02-01 20 December 07, 2004 G. Cosmo - param-V06-02-01
182 - Implemented migration to <cmath>. 21 - Implemented migration to <cmath>.
183 22
184 November 26, 2004 M. Verderi - param-V06-02-00 23 November 26, 2004 M. Verderi - param-V06-02-00
185 - Implemented migration to new G4VParticleChan 24 - Implemented migration to new G4VParticleChange interfaces.
186 25
187 December 12, 2003 G. Cosmo - param-V06-00-00 26 December 12, 2003 G. Cosmo - param-V06-00-00
188 - G4FastSimulationVector.icc: use std_pvector: 27 - G4FastSimulationVector.icc: use std_pvector:: scope for calls to
189 base class. Fixes compilation problem on Int 28 base class. Fixes compilation problem on Intel-icc compiler.
190 29
191 November 10, 2003 G. Cosmo - param-V05-02-01 30 November 10, 2003 G. Cosmo - param-V05-02-01
192 - G4FastTrack: use G4Navigator::CreateTouchabl 31 - G4FastTrack: use G4Navigator::CreateTouchableHistoryHandle() instead of
193 CreateTouchableHistory() in method FRecordsA 32 CreateTouchableHistory() in method FRecordsAffineTransformation().
194 33
195 October 4, 2003 G. Cosmo - param-V05-02-00 34 October 4, 2003 G. Cosmo - param-V05-02-00
196 - Modified GNUmakefile: 35 - Modified GNUmakefile:
197 o added dependency to new module "geometry/n 36 o added dependency to new module "geometry/navigation".
198 - Coworks with "geometry-V05-02-00" and "digit 37 - Coworks with "geometry-V05-02-00" and "digits_hits-V05-02-00".
199 38
200 May 21, 2003 G. Cosmo - param-V05-01-00 39 May 21, 2003 G. Cosmo - param-V05-01-00
201 o Fixed pedantic warnings on Linux-g++ 40 o Fixed pedantic warnings on Linux-g++.
202 o Call base class in copy-constructor 41 o Call base class in copy-constructor of G4FastStep.
203 42
204 Nov 20, 2002 G. Cosmo - param-V04-01-02 43 Nov 20, 2002 G. Cosmo - param-V04-01-02
205 o Patched access to public static data in G4 44 o Patched access to public static data in G4FastStep.cc
206 and G4GlobalFastSimulationManager.cc to al 45 and G4GlobalFastSimulationManager.cc to allow porting on
207 Windows DLLs. 46 Windows DLLs.
208 47
209 Nov 15, 2002 S. Sadilov - param-V04-01-01 48 Nov 15, 2002 S. Sadilov - param-V04-01-01
210 o Fixed compilation problems on Windows in 49 o Fixed compilation problems on Windows in
211 G4FastSimulationManager.cc and G4GlobalFas 50 G4FastSimulationManager.cc and G4GlobalFastSimulationManager.cc
212 51
213 Nov 02, 2002 M. Verderi - param-V04-01-00 52 Nov 02, 2002 M. Verderi - param-V04-01-00
214 o Add method to retrieve G4VFastSimulationMo 53 o Add method to retrieve G4VFastSimulationModel by name.
215 The user's method is in G4GlobalFastSimula 54 The user's method is in G4GlobalFastSimulationManager:
216 55
217 GetFastSimulationModel(); 56 GetFastSimulationModel();
218 57
219 it is accompagnied by same methods name in 58 it is accompagnied by same methods name in
220 G4FastSimulationManager class. 59 G4FastSimulationManager class.
221 60
222 o Add "test" directory, used to test above f 61 o Add "test" directory, used to test above feature.
223 62
224 Oct 26, 2001 M. Verderi - param-V03-02-00 63 Oct 26, 2001 M. Verderi - param-V03-02-00
225 Fixes to clear warnings produced with gcc-2. 64 Fixes to clear warnings produced with gcc-2.95.2:
226 - loop index, where comparison with method " 65 - loop index, where comparison with method "size()" of
227 G4std::vector<T>, changed: int -> size_t << 66 G4std::vector<T>, changed: int -> size_t
228 - change "if ( a=b ) {..}" by "if ( (a=b) ) 67 - change "if ( a=b ) {..}" by "if ( (a=b) ) {...}"
229 this makes the compiler sure you want to mak 68 this makes the compiler sure you want to make an
230 assignement in the "if" condition 69 assignement in the "if" condition
231 - re-order initialisations of a few variable 70 - re-order initialisations of a few variables in constructors
232 to match the declaration order. 71 to match the declaration order.
233 Some warnings still exist, but regard the G4 72 Some warnings still exist, but regard the G4Propagator of geometry.
234 73
235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 74 Apr 3, 2001 J. Apostolakis - param-V03-00-00
236 - Modified G4FastSimulationManagerProcess call 75 - Modified G4FastSimulationManagerProcess call to PropagatorInField ComputeStep
237 to use new interface with G4FieldTrack (in 76 to use new interface with G4FieldTrack (in place of now obsolete interface.)
238 77
239 Nov 14, 2000 G. Cosmo - param-V02-00-01 78 Nov 14, 2000 G. Cosmo - param-V02-00-01
240 - Moved specific parameterisation models to th 79 - Moved specific parameterisation models to the new top category
241 "parameterisations". Moved files: 80 "parameterisations". Moved files:
242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm 81 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRmodel[.hh.cc],
243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster 82 G4IrregularXrayTRmodel[.hh.cc], G4PAIclusterModel[.hh.cc],
244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr 83 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXrayTRmodel[.hh.cc],
245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode 84 G4RegularXrayTRmodel[.hh.cc], G4VClusterModel[.hh.cc],
246 G4VXrayTRmodel[.hh.cc]. 85 G4VXrayTRmodel[.hh.cc].
247 - Cleaned-up GNUmakefile of non necessary depe 86 - Cleaned-up GNUmakefile of non necessary dependencies.
248 87
249 Aug 03, 2000 G. Cosmo - param-V02-00-00r 88 Aug 03, 2000 G. Cosmo - param-V02-00-00r
250 - Changed RandGauss to G4RandGauss in G4Irregu 89 - Changed RandGauss to G4RandGauss in G4IrregularXrayTRmodel.cc and
251 G4VXrayTRmodel.cc to fix events' reproducibi 90 G4VXrayTRmodel.cc to fix events' reproducibility problem.
252 - G4VXrayTRmodel.cc: fix to class destructor ( 91 - G4VXrayTRmodel.cc: fix to class destructor (V.Grichine)
253 92
254 Jun 15, 2000 G. Cosmo - param-V01-01-04 93 Jun 15, 2000 G. Cosmo - param-V01-01-04
255 - The tag coworks with global-V01-01-04 and ma 94 - The tag coworks with global-V01-01-04 and materials-V01-01-00:
256 o Fixed usage of G4complex type for ISO and 95 o Fixed usage of G4complex type for ISO and non-ISO compilers.
257 Affected files: G4FoamXrayTRmodel.cc, G4Ga 96 Affected files: G4FoamXrayTRmodel.cc, G4GamDistrXrayTRmodel.cc, G4PlateIrrGasXrayTRmodel.cc
258 and G4RegularXrayTRmodel.c 97 and G4RegularXrayTRmodel.cc.
259 In case of G4complex types passed to mathe 98 In case of G4complex types passed to mathematical functions, use G4std:: prefix.
260 o Fixed usage of G4Integrator class, now cha 99 o Fixed usage of G4Integrator class, now changed to templated to allow porting of the
261 code on SUN-CC compiler which does not imp 100 code on SUN-CC compiler which does not implement templated member functions.
262 Affected files: G4VXrayTRmodel[.hh.cc] 101 Affected files: G4VXrayTRmodel[.hh.cc]
263 102
264 Jun 6, 2000 M. Verderi & P. Mora de Freitas 103 Jun 6, 2000 M. Verderi & P. Mora de Freitas
265 - fixed compilation errors with HP-aCC for the 104 - fixed compilation errors with HP-aCC for the files G4RegularXrayTRmodel.cc,
266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod 105 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmodel.cc.
267 106
268 May 30, 2000 M. Verderi & P. Mora de Freitas 107 May 30, 2000 M. Verderi & P. Mora de Freitas
269 108
270 - parameterisation category is now RW free. 109 - parameterisation category is now RW free.
271 110
272 September 16, 1999 M. Verderi & P. Mora de Fre 111 September 16, 1999 M. Verderi & P. Mora de Freitas
273 112
274 - Fixed bug in G4FastStep::CheckIt() method. 113 - Fixed bug in G4FastStep::CheckIt() method.
275 114
276 April 19, 1999 M. Verderi & P. Mora de Freitas 115 April 19, 1999 M. Verderi & P. Mora de Freitas
277 116
278 Changes in G4FastStep to co-work with track-01 117 Changes in G4FastStep to co-work with track-01-00-04:
279 118
280 1) The method void CheckIt(const G4Track&) bec << 119 1) The method void CheckIt(const G4Track&) becomes
281 G4bool CheckIt(const G4Track&); 120 G4bool CheckIt(const G4Track&);
282 2) The FAST_STEP_DEBUG compiling option disapp 121 2) The FAST_STEP_DEBUG compiling option disappears;
283 3) Call to CheckIt controled by the G4VParticl 122 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute.
284 123
285 Miscellaneous: the declaration "G4double mass 124 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh
286 corrected to G4double mass =...". 125 corrected to G4double mass =...".
287 126
288 April 15, 1999 M. Verderi & P. Mora de Freitas 127 April 15, 1999 M. Verderi & P. Mora de Freitas
289 128
290 Tasks to decouple visualization from processes 129 Tasks to decouple visualization from processes/parameterisation:
291 130
292 1) G4GlobalFastSimulationManager now inherites 131 1) G4GlobalFastSimulationManager now inherites from the intercoms/
293 G4VGlobalFastSimulationManager to allow visual << 132 G4VGlobalFastSimulationManager to allow visualisation to get a
294 concrete instance pointer to the G4GlobalFastS 133 concrete instance pointer to the G4GlobalFastSimulationManager,
295 if any. 134 if any.
296 135
297 2) G4FlavoredParallelWorld now inherites from 136 2) G4FlavoredParallelWorld now inherites from the intercoms/
298 G4VFlavoredParallelWorld, a pure virtual abstr 137 G4VFlavoredParallelWorld, a pure virtual abstract class to interface
299 parameterisation with visualization. 138 parameterisation with visualization.
300 139
301 Co-works with intercoms-01-00-01 tag 140 Co-works with intercoms-01-00-01 tag
302 141
303 Modified files: 142 Modified files:
304 --------------- 143 ---------------
305 G4FlavoredParallelWorld.hh 144 G4FlavoredParallelWorld.hh
306 G4GlobalFastSimulationManager.hh 145 G4GlobalFastSimulationManager.hh
307 G4GlobalFastSimulationManager.cc 146 G4GlobalFastSimulationManager.cc
308 147
309 Done, tested, system-tested on HP-aCC with exe 148 Done, tested, system-tested on HP-aCC with exemple N05.
310 149
311 April 14, 1999 M. Verderi & P. Mora de Freitas 150 April 14, 1999 M. Verderi & P. Mora de Freitas
312 151
313 Several consolidation tasks (thanks to G. Cosm 152 Several consolidation tasks (thanks to G. Cosmo):
314 153
315 1) Warning: << 154 1) Warning:
316 ----------- 155 -----------
317 156
318 Pointers usage 157 Pointers usage
319 158
320 - Setting pointers to 0 after delete: 159 - Setting pointers to 0 after delete:
321 160
322 delete pA; 161 delete pA;
323 pA = 0; 162 pA = 0;
324 163
325 - Avoid to use "NULL". 164 - Avoid to use "NULL".
326 165
327 Modified files: 166 Modified files:
328 --------------- 167 ---------------
329 G4FastSimulationManager.hh 168 G4FastSimulationManager.hh
330 G4FastTrack.hh 169 G4FastTrack.hh
331 G4FlavoredParallelWorld.hh 170 G4FlavoredParallelWorld.hh
332 G4FastSimulationManager.cc 171 G4FastSimulationManager.cc
333 G4FastSimulationMessenger.cc 172 G4FastSimulationMessenger.cc
334 G4FastSimulationManagerProcess.cc 173 G4FastSimulationManagerProcess.cc
335 G4FastTrack.cc 174 G4FastTrack.cc
336 G4GlobalFastSimulationManager.cc 175 G4GlobalFastSimulationManager.cc
337 G4VFastSimulationModel.cc 176 G4VFastSimulationModel.cc
338 177
339 Status: << 178 Status:
340 ------- 179 -------
341 Done, tested, system-tested on HP-aCC with exe 180 Done, tested, system-tested on HP-aCC with exemple N05.
342 181
343 2) Warning: 182 2) Warning:
344 ----------- 183 -----------
345 include/G4FastSimulationManager.hh:163 184 include/G4FastSimulationManager.hh:163
346 Public member functions shall always retur 185 Public member functions shall always return const handles to member data
347 Severe violation: Universal Coding Standar 186 Severe violation: Universal Coding Standards item 18
348 187
349 offending code: 188 offending code:
350 --------------- 189 ---------------
351 inline G4VParticleChange* G4FastSimulationMana 190 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange()
352 { 191 {
353 return &fFastStep; 192 return &fFastStep;
354 } 193 }
355 194
356 Diagnostic: 195 Diagnostic:
357 ---------- 196 ----------
358 197
359 Called by the G4FastSimulationManagerProcess << 198 Called by the G4FastSimulationManagerProcess to return it in the
360 PostStepDoIt call. << 199 PostStepDoIt call.
361 200
362 Action: 201 Action:
363 ------- 202 -------
364 The G4FastSimulationManager::GettheParticleCha 203 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any
365 more. The G4VParticleChange* is now returned d 204 more. The G4VParticleChange* is now returned directly when invoking the
366 G4FastSimulationManager::InvokePostStepDoIt() 205 G4FastSimulationManager::InvokePostStepDoIt() and
367 G4FastSimulationManager::InvokeAtRestDoIt() me 206 G4FastSimulationManager::InvokeAtRestDoIt() methodes.
368 207
369 Modified files: 208 Modified files:
370 --------------- 209 ---------------
371 G4FastSimulationManager.hh 210 G4FastSimulationManager.hh
372 G4FastSimulationManager.cc 211 G4FastSimulationManager.cc
373 G4FastSimulationManagerProcess.cc 212 G4FastSimulationManagerProcess.cc
374 213
375 Status: << 214 Status:
376 ------- 215 -------
377 Done, tested, system-tested on HP-aCC with exe 216 Done, tested, system-tested on HP-aCC with exemple N05.
378 217
379 3) Warning: 218 3) Warning:
380 ----------- 219 -----------
381 include/G4FastSimulationManagerProcess.hh:52 220 include/G4FastSimulationManagerProcess.hh:52
382 If a class has virtual functions it shall 221 If a class has virtual functions it shall have a virtual destructor
383 Severe violation: Universal Coding Standar 222 Severe violation: Universal Coding Standards item 17
384 class G4FastSimulationManagerProcess has v 223 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor.
385 224
386 offending code: 225 offending code:
387 --------------- 226 ---------------
388 ~G4FastSimulationManagerProcess(); 227 ~G4FastSimulationManagerProcess();
389 228
390 Diagnostic: 229 Diagnostic:
391 ---------- 230 ----------
392 Nobody should inherites from G4FastSimulatio << 231 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual
393 is added. 232 is added.
394 233
395 Action: 234 Action:
396 ------- 235 -------
397 virtual ~G4FastSimulationManagerProcess(); 236 virtual ~G4FastSimulationManagerProcess();
398 237
399 Modified files: 238 Modified files:
400 --------------- 239 ---------------
401 G4FastSimulationManagerProcess.hh 240 G4FastSimulationManagerProcess.hh
402 241
403 Status: << 242 Status:
404 ------- 243 -------
405 Done. 244 Done.
406 245
407 4) Warning: 246 4) Warning:
408 ----------- 247 -----------
409 include/G4FastSimulationMessenger.hh:36 248 include/G4FastSimulationMessenger.hh:36
410 If a class has virtual functions it shall 249 If a class has virtual functions it shall have a virtual destructor
411 Severe violation: Universal Coding Standar 250 Severe violation: Universal Coding Standards item 17
412 class G4FastSimulationMessenger has virtua 251 class G4FastSimulationMessenger has virtual functions without a virtual destructor.
413 252
414 253
415 offending code: 254 offending code:
416 --------------- 255 ---------------
417 ~G4FastSimulationMessenger(); 256 ~G4FastSimulationMessenger();
418 257
419 Diagnostic: 258 Diagnostic:
420 ---------- 259 ----------
421 Nobody should inherites from G4FastSimulatio << 260 Nobody should inherites from G4FastSimulationMessenger BUT for virtual
422 is added. 261 is added.
423 262
424 Action: 263 Action:
425 ------- 264 -------
426 virtual ~G4FastSimulationMessenger(); 265 virtual ~G4FastSimulationMessenger();
427 266
428 Modified files: 267 Modified files:
429 --------------- 268 ---------------
430 G4FastSimulationMessenger.hh 269 G4FastSimulationMessenger.hh
431 270
432 Status: << 271 Status:
433 ------- 272 -------
434 Done. 273 Done.
435 274
436 5) Warning: 275 5) Warning:
437 ----------- 276 -----------
438 include/G4FastStep.hh:224 277 include/G4FastStep.hh:224
439 Operator= should call base class operator= 278 Operator= should call base class operator=
440 Possible severe violation: Effective C++ i 279 Possible severe violation: Effective C++ item 16
441 operator= in class G4FastStep, should call 280 operator= in class G4FastStep, should call operator= in base class G4VParticleChange
442 281
443 offending code: 282 offending code:
444 --------------- 283 ---------------
445 G4FastStep & G4FastStep::operator=(const G4Fas 284 G4FastStep & G4FastStep::operator=(const G4FastStep &right)
446 { 285 {
447 if (this != &right) 286 if (this != &right)
448 { 287 {
449 theListOfSecondaries = right.th 288 theListOfSecondaries = right.theListOfSecondaries;
450 theSizeOftheListOfSecondaries = right.th 289 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries;
451 theNumberOfSecondaries = right.th 290 theNumberOfSecondaries = right.theNumberOfSecondaries;
452 theStatusChange = right.th 291 theStatusChange = right.theStatusChange;
453 theMomentumChange = right.th 292 theMomentumChange = right.theMomentumChange;
454 thePolarizationChange = right.th 293 thePolarizationChange = right.thePolarizationChange;
455 thePositionChange = right.th 294 thePositionChange = right.thePositionChange;
456 theTimeChange = right.th 295 theTimeChange = right.theTimeChange;
457 theEnergyChange = right.th 296 theEnergyChange = right.theEnergyChange;
458 theTrueStepLength = right.th 297 theTrueStepLength = right.theTrueStepLength;
459 theLocalEnergyDeposit = right.th 298 theLocalEnergyDeposit = right.theLocalEnergyDeposit;
460 theSteppingControlFlag = right.th 299 theSteppingControlFlag = right.theSteppingControlFlag;
461 theWeightChange = right.th 300 theWeightChange = right.theWeightChange;
462 } 301 }
463 return *this; 302 return *this;
464 } 303 }
465 304
466 Diagnostic: 305 Diagnostic:
467 ---------- 306 ----------
468 Bug detected. 307 Bug detected.
469 308
470 Action: 309 Action:
471 ------- 310 -------
472 Insert the call 311 Insert the call
473 G4VParticleChange::operator=(right); 312 G4VParticleChange::operator=(right);
474 313
475 Status: 314 Status:
476 ------- 315 -------
477 Done, tested, system-tested on HP-aCC with e 316 Done, tested, system-tested on HP-aCC with exemple N05.
478 317
479 Modified files: 318 Modified files:
480 --------------- 319 ---------------
481 G4FastStep.cc 320 G4FastStep.cc
482 321
483 6) Warning: 322 6) Warning:
484 ----------- 323 -----------
485 include/G4FastStep.hh:59 324 include/G4FastStep.hh:59
486 Avoid data members in the public interface 325 Avoid data members in the public interface
487 Violation: Effective C++ item 20 326 Violation: Effective C++ item 20
488 Public data members for class G4FastStep: 327 Public data members for class G4FastStep:
489 debugFlag 328 debugFlag
490 329
491 330
492 offending code: 331 offending code:
493 --------------- 332 ---------------
494 public: 333 public:
495 ... 334 ...
496 G4bool debugFlag; 335 G4bool debugFlag;
497 336
498 Diagnostic: 337 Diagnostic:
499 ---------- 338 ----------
500 Historical usage. 339 Historical usage.
501 340
502 Action: 341 Action:
503 ------- 342 -------
504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 343 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file.
505 344
506 Modified files: 345 Modified files:
507 --------------- 346 ---------------
508 G4FastStep.hh, G4FastStep.cc 347 G4FastStep.hh, G4FastStep.cc
509 348
510 Status: 349 Status:
511 ------- 350 -------
512 Done, tested, system-tested on HP-aCC with e 351 Done, tested, system-tested on HP-aCC with exemple N05.
513 352
514 7) Warning: 353 7) Warning:
515 ----------- 354 -----------
516 include/G4FastStep.hh:59 355 include/G4FastStep.hh:59
517 If a class has virtual functions it shall 356 If a class has virtual functions it shall have a virtual destructor
518 Severe violation: Universal Coding Standar 357 Severe violation: Universal Coding Standards item 17
519 class G4FastStep has virtual functions wit 358 class G4FastStep has virtual functions without a virtual destructor.
520 359
521 360
522 offending code: 361 offending code:
523 --------------- 362 ---------------
524 ~G4FastStep(); 363 ~G4FastStep();
525 364
526 Diagnostic: 365 Diagnostic:
527 ---------- 366 ----------
528 Nobody should inherites from G4FastStep BUT 367 Nobody should inherites from G4FastStep BUT virtual added.
529 368
530 Action: 369 Action:
531 ------- 370 -------
532 virtual ~G4FastStep(); 371 virtual ~G4FastStep();
533 372
534 Modified files: 373 Modified files:
535 --------------- 374 ---------------
536 G4FastStep.hh 375 G4FastStep.hh
537 376
538 Status: 377 Status:
539 ------- 378 -------
540 Done, tested, system-tested on HP-aCC with e 379 Done, tested, system-tested on HP-aCC with exemple N05.
541 380
542 381
543 December 7, 1998 M. Verderi 382 December 7, 1998 M. Verderi
544 G4FastSimulationManagerProcess class: 383 G4FastSimulationManagerProcess class:
545 Fixes made for ghost navigation with 384 Fixes made for ghost navigation with
546 mag-field: 385 mag-field:
547 LocateGlobalPointAndUpdateTouchable is 386 LocateGlobalPointAndUpdateTouchable is
548 always used (in not the Locate...Setup 387 always used (in not the Locate...Setup
549 method) 388 method)
550 In PostStepDoIt: correction of position and 389 In PostStepDoIt: correction of position and
551 direction of the track are made when << 390 direction of the track are made when
552 possible in case of mag-field. 391 possible in case of mag-field.
553 This correction comes from the fact that a 392 This correction comes from the fact that a
554 small discrepancy appears on those quantitie 393 small discrepancy appears on those quantities
555 because of the numerical integration along 394 because of the numerical integration along
556 the field on the track path: the G4FSMP 395 the field on the track path: the G4FSMP
557 proposes a curve-length, the transportation 396 proposes a curve-length, the transportation
558 moves the track along this curve, however 397 moves the track along this curve, however
559 the end point position and direction are 398 the end point position and direction are
560 slightly different from those expected by 399 slightly different from those expected by
561 the G4FSMP when it proposed the length. 400 the G4FSMP when it proposed the length.
562 401
563 November 20,1998 M. Verderi 402 November 20,1998 M. Verderi
564 G4FastStep class: 403 G4FastStep class:
565 Remove track/G4BiasingTag.hh dependancy (ob 404 Remove track/G4BiasingTag.hh dependancy (obsolete).
566 Adapted to new shceme of Event Biasing mech 405 Adapted to new shceme of Event Biasing mechanism,
567 consistently with track-00-04-01 tag. 406 consistently with track-00-04-01 tag.
568 407
569 November 11,1998 M. Verderi 408 November 11,1998 M. Verderi
570 Merge of param-00-03-02 & param-00-03-02a i 409 Merge of param-00-03-02 & param-00-03-02a into
571 param-00-03-04a (hopefully...) 410 param-00-03-04a (hopefully...)
572 The point is the chnage of signature in the 411 The point is the chnage of signature in the
573 LocateGlobalPointAndSetup(..) of the G4Navi 412 LocateGlobalPointAndSetup(..) of the G4Navigator making use now
574 of the track direction. The G4FastSimulatio 413 of the track direction. The G4FastSimulationManagerProcess is
575 changed accordingly: 414 changed accordingly:
576 fGhostNavigator.LocateGlobalPointAndSetup(t 415 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true);
577 416
578 417
579 November 6, 1998 M. Verderi 418 November 6, 1998 M. Verderi
580 - Extension of the G4FastStep to allow the 419 - Extension of the G4FastStep to allow the biasing technic.
581 Changes are made in: 420 Changes are made in:
582 - G4FastStep.hh/.icc: 421 - G4FastStep.hh/.icc:
583 new member G4BiasingTa 422 new member G4BiasingTag fBiasTag;
584 new method SetPrimaryT 423 new method SetPrimaryTrackFinalBiasingTag
585 ( G4BiasingTag 424 ( G4BiasingTag aTag );
586 - G4FastStep.cc: 425 - G4FastStep.cc:
587 Initialize(); 426 Initialize();
588 operator=; << 427 operator=;
589 UpdateForPostStep(); 428 UpdateForPostStep();
590 UpdateForAtRest(); << 429 UpdateForAtRest();
591 430
592 October 26, 1998 P.Mora de Freitas 431 October 26, 1998 P.Mora de Freitas
593 - G4FastSimulationManagerProcess and G4Fast 432 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal
594 with at rest parameterisations also when 433 with at rest parameterisations also when using parallel geometry.
595 434
596 October 8, 1998 P.Mora de Freitas 435 October 8, 1998 P.Mora de Freitas
597 - The G4VFastSimulationModel::IsApplicable( 436 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual
598 methode. 437 methode.
599 - G4FastSimulationManager optimisation: 438 - G4FastSimulationManager optimisation:
600 - New G4ParticleDefinition* fLastCrossedP 439 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps
601 the last particle type with touched the 440 the last particle type with touched the envelope;
602 - New G4RWTPtrOrderedVector<G4VFastSimula 441 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList
603 data member, keeps the model list of th << 442 data member, keeps the model list of the applicable models for
604 the actual fLastCrossedParticle particl 443 the actual fLastCrossedParticle particle type;
605 - Changes in the PostStepGetFastSimulatio << 444 - Changes in the PostStepGetFastSimulationManagerTrigger() and
606 AtRestGetFastSimulationManagerTrigger() << 445 AtRestGetFastSimulationManagerTrigger()methodes to update the
607 fApplicableModelList when needed (fLast 446 fApplicableModelList when needed (fLastCrossedParticle !=
608 the actual tracked particle); 447 the actual tracked particle);
609 - Changes in the << 448 - Changes in the
610 G4FastSimulationManager() (Constructor) 449 G4FastSimulationManager() (Constructor)
611 ActivateFastSimulationModel(), 450 ActivateFastSimulationModel(),
612 InActivateFastSimulationModel(), 451 InActivateFastSimulationModel(),
613 AtRestGetFastSimulationManagerTrigger(), 452 AtRestGetFastSimulationManagerTrigger(),
614 AddFastSimulationModel(), 453 AddFastSimulationModel(),
615 RemoveFastSimulationModel() 454 RemoveFastSimulationModel()
616 methodes to set the fLastCrossedParticle to 455 methodes to set the fLastCrossedParticle to NULL, forcing the
617 fApplicableModelList to be rebuilt. 456 fApplicableModelList to be rebuilt.
618 457
619 September 22, 1998 P.Mora de Freitas 458 September 22, 1998 P.Mora de Freitas
620 Fixed bug in parallel navigation. << 459 Fixed bug in parallel navigation.
621 File touched: G4FastSimulationManagerProces 460 File touched: G4FastSimulationManagerProcess.cc
622 Tested on HP-aCC. 461 Tested on HP-aCC.
623 462
624 September 17, 1998 P.Mora de Freitas 463 September 17, 1998 P.Mora de Freitas
625 G4FastSimulationManager::RemoveFastSimulati 464 G4FastSimulationManager::RemoveFastSimulationModel() updated to look
626 for also in the fInactivatedModels list. 465 for also in the fInactivatedModels list.
627 466
628 Tested on HP-aCC. 467 Tested on HP-aCC.
629 468
630 September 16, 1998 P.Mora de Freitas 469 September 16, 1998 P.Mora de Freitas
631 New /param/ control commands: 470 New /param/ control commands:
632 471
633 /param/ActivateModel <ModelName> 472 /param/ActivateModel <ModelName>
634 /param/InActivateModel <ModelName> 473 /param/InActivateModel <ModelName>
635 474
636 Activate or inactivate a given parameterisat 475 Activate or inactivate a given parameterisation model.
637 476
638 Tested on HP-aCC. 477 Tested on HP-aCC.
639 478
640 August 21, 1998 P.Mora de Freitas 479 August 21, 1998 P.Mora de Freitas
641 G4FastSimulationManagerProcess's G4ProcessTy 480 G4FastSimulationManagerProcess's G4ProcessType set to
642 fParameterisation, accordingly with procman-00 481 fParameterisation, accordingly with procman-00-02-03.
643 482
644 Tested on HP-aCC. 483 Tested on HP-aCC.
645 484
646 August 12, 1998 P.Mora de Freitas 485 August 12, 1998 P.Mora de Freitas
647 Improved the "close parameterisation control << 486 Improved the "close parameterisation control" to
648 487
649 1) avoid the close looping when unnecessary 488 1) avoid the close looping when unnecessary (mostly cases);
650 2) force re-close when necessary (insert/rem 489 2) force re-close when necessary (insert/remove ghosts).
651 490
652 Changes: 491 Changes:
653 492
654 1) the G4GlobalFastSimulationManager::fClose << 493 1) the G4GlobalFastSimulationManager::fClosed is now initialised
655 to true by the G4GlobalFastSimulationMana 494 to true by the G4GlobalFastSimulationManager constructor;
656 495
657 2) new method << 496 2) new method
658 497
659 void << 498 void
660 G4GlobalFastSimulationManager::FastSimula 499 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed();
661 500
662 called by the AddGhostPlacement and Remov << 501 called by the AddGhostPlacement and RemoveGhostPlacement
663 G4FastSimulationManager methods to set fa 502 G4FastSimulationManager methods to set false the fClosed flag;
664 503
665 3) changes in the G4GlobalFastSimulationMana 504 3) changes in the G4GlobalFastSimulationManager::Notify method
666 to deal with these changes. 505 to deal with these changes.
667 506
668 Tested on HP-aCC. 507 Tested on HP-aCC.
669 508
670 August 11, 1998 P.Mora de Freitas 509 August 11, 1998 P.Mora de Freitas
671 Fix to the G4FastStep::KillPrimaryTrack() me 510 Fix to the G4FastStep::KillPrimaryTrack() method to drop the
672 nonsense line 511 nonsense line
673 512
674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 513 SetMomentumChange(0.,0.,0.) ; /* necessary ? */
675 514
676 Tested on HP-aCC. 515 Tested on HP-aCC.
677 (Thanks to Willy Langeveld) 516 (Thanks to Willy Langeveld)
678 517
679 518
680 August 10, 1998 P.Mora de Freitas 519 August 10, 1998 P.Mora de Freitas
681 Fix to the SetPrimaryTrackFinalKineticEnergy 520 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method
682 from the G4FastStep class the SetMomentumChang 521 from the G4FastStep class the SetMomentumChange() call to insure that
683 the new momentum direction is a unit vector (a << 522 the new momentum direction is a unit vector (as asked by the
684 G4DynamicParticle::SetMomentumDirection method 523 G4DynamicParticle::SetMomentumDirection method).
685 524
686 Touched files: G4FastStep.hh (improved comme 525 Touched files: G4FastStep.hh (improved comments)
687 G4FastStep.cc (fixed) 526 G4FastStep.cc (fixed)
688 527
689 Tested on HP-aCC. 528 Tested on HP-aCC.
690 (Thanks to Willy Langeveld) 529 (Thanks to Willy Langeveld)
691 530
692 August 7, 1998 P.Mora de Freitas 531 August 7, 1998 P.Mora de Freitas
693 New /param/ commands directory with the comm 532 New /param/ commands directory with the commands:
694 533
695 /param/listEnvelopes [ParticleName] 534 /param/listEnvelopes [ParticleName]
696 535
697 - List all the envelope names for a given pa 536 - List all the envelope names for a given particle
698 (or for all particles if without parameter 537 (or for all particles if without parameters).
699 538
700 /param/listModels [EnvelopeName] 539 /param/listModels [EnvelopeName]
701 540
702 - List all the Model names for a given envel 541 - List all the Model names for a given envelope
703 (or for all envelopes if without parameter 542 (or for all envelopes if without parameters).
704 543
705 /param/listIsApplicable [ModelName] 544 /param/listIsApplicable [ModelName]
706 545
707 - List all the particle names a given model 546 - List all the particle names a given model is applicable
708 (or for all models if without parameters). 547 (or for all models if without parameters).
709 548
710 549
711 August 7, 1998 P.Mora de Freitas 550 August 7, 1998 P.Mora de Freitas
712 History file Created. 551 History file Created.