| Geant4 Cross Reference |
1 # Category param History << 1 $Id: History,v 1.20 2003/12/12 13:21:03 gcosmo Exp $
>> 2 -------------------------------------------------------------------
2 3
3 See `CONTRIBUTING.rst` for details of **requir << 4 =========================================================
4 which **must** added in reverse chronological << 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP
5 It must **not** be used as a substitute for wr << 6 =========================================================
6 << 7
7 ---------------------------------------------- << 8 Category History file
8 << 9 ---------------------
9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) << 10 This file should be used by G4 developers and category coordinators
10 - In G4GlobalFastSimulationManager: << 11 to briefly summarize all major modifications introduced in the code
11 use G4ThreadLocalSingleton to avoid undelete << 12 and keep track of all category-tags.
12 << 13 It DOES NOT substitute the CVS log-message one should put at every
13 ## 2023-10-18 Ben Morgan (param-V11-01-03) << 14 committal in the CVS repository !
14 - Apply standard and extended clang-tidy fixes << 15
15 - Mark empty/obsolete functions as deprecated << 16 ----------------------------------------------------------
16 << 17 * Reverse chronological order (last date on top), please *
17 ## 2023-10-16 Ben Morgan (param-V11-01-02) << 18 ----------------------------------------------------------
18 - Apply standard clang-format-ing. <<
19 - Normal order accessors and docstrings. <<
20 <<
21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) <<
22 - In G4FastTrack, removed references to G4Touc <<
23 which is now deprecated. <<
24 <<
25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 <<
26 - Added missing virtual destructor to G4VFastS <<
27 <<
28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) <<
29 - Fixed compilation warnings for implicit type <<
30 <<
31 ## 2022-10-27 Makoto Asai (param-V11-00-03) <<
32 - G4FastSimHitMaker - making compatible to com <<
33 <<
34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 <<
35 - G4FastStep - delete copy constructor and ope <<
36 <<
37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) <<
38 - Adding the 'flush' method to the fast simula <<
39 This method allows to process the input buff <<
40 the end of the G4 event. It is used when par <<
41 The 'flash' is triggered inside the event lo <<
42 The fast simulation model may add secondarie <<
43 by Geant4. <<
44 <<
45 ## 2021-12-10 Ben Morgan (param-V11-00-00) <<
46 - Change to new Markdown History format <<
47 <<
48 --- <<
49 <<
50 # History entries prior to 11.0 <<
51 <<
52 April 16, 2021 Ben Morgan (param-V10-07-00) <<
53 - Migrate build to modular CMake API <<
54 <<
55 October 5, 2020, A. Zaborowska (param-V10-06-0 <<
56 - Introduce general facilities based on GFlash <<
57 to facilitate multiple hit (energy & positio <<
58 from fast simulation models. <<
59 <<
60 September 9, 2020, G. Cosmo (param-V10-06-02) <<
61 - Fixed minor Coverity defect for uninitialise <<
62 <<
63 April 21, 2020, A. Zaborowska (param-V10-06-01 <<
64 - Sanity check for root logical volumes for re <<
65 UI command /param/showSetup works also if no <<
66 <<
67 March 26, 2020, I. Semeniouk (param-V10-06-00) <<
68 - G4FastSimulationHelper : merge ActivateFastS <<
69 - G4FastSimulationManager.hh, G4VFastSimulatio <<
70 redefinition of G4Envelope type <<
71 <<
72 October 30, 2019, A. Zaborowska (param-v10-05- <<
73 - Register G4FastSimulationManagerProcess with <<
74 G4FastSimulationManagerHelper to ensure it i <<
75 invoked for a given step (ExclusivelyForced) <<
76 StronglyForced processes will be considered. <<
77 <<
78 December 19, 2017, G. Cosmo (param-V10-04-00) <<
79 - Fixed self-consistency in G4FastSimulationVe <<
80 Thanks to Raphael Isemann for reporting this <<
81 <<
82 November 03, 2016, M. Verderi (param-V10-02-01 <<
83 - New G4FastSimulationManagerHelper utility fo <<
84 adding G4FastSimulationManagerProcess to a <<
85 process manager. <<
86 <<
87 November 02, 2016, M. Verderi (param-V10-02-00 <<
88 - fix various Coverity defects. <<
89 <<
90 March 27, 2013, M. Verderi (param-V09-06-00) <<
91 - remove unused field 'fOnBoundary' in G4FastS <<
92 as this was causing a warning from clang. <<
93 <<
94 July 10, 2012, G. Cosmo (param-V09-05-00) <<
95 - Explicitly use inclusion of headers for syst <<
96 constants, in plan to remove implicit inclus <<
97 <<
98 September 30, 2011, M. Verderi (param-V09-04-0 <<
99 - Added missing new header file (G4FastSimulat <<
100 sources.cmake. <<
101 <<
102 September 30, 2011, M. Verderi (param-V09-04-0 <<
103 - Migration to new G4Exception scheme. <<
104 - what is V09-04-01 tag ? <<
105 <<
106 February 11, 2011, M. Verderi (param-V09-04-00 <<
107 - Implementation of method <<
108 void ProposePrimaryTrackFinalKineticEnergy ( <<
109 was missing : modified file G4FastStep.icc <<
110 <<
111 March 13, 2008, G. Cosmo (param-V09-01-00) <<
112 - Cleared compilation warnings in G4FastSimula <<
113 G4FastSimulationMessenger on gcc-4.3.0 for a <<
114 parentheses in nested if-else statements. <<
115 <<
116 November 30, 2007, M. Verderi <<
117 - Add Along methods to G4FSMP process <<
118 - tag as param-V09-00-01 <<
119 <<
120 November 30, 2007, M. Verderi <<
121 - minor corrections to G4FastSimulationManager <<
122 * add call fPathFinder->prepareNewrack(...) <<
123 * deactivate ghost navigator in EndOfTracki <<
124 - tag as param-V09-00-00 <<
125 <<
126 May 18, 2007, M. Verderi <<
127 - tag as param-V08-03-00 <<
128 <<
129 May 11, 2007, M. Verderi <<
130 - remove include/G4FastSimulationManagerProces <<
131 include/G4FlavoredParallelWorld.hh <<
132 include/G4GFSManager81.hh <<
133 src/G4FastSimulationManagerProcess81. <<
134 src/G4GFSManager81.cc <<
135 <<
136 <<
137 November 10, 2006, M. Verderi - param-V08-01-0 <<
138 - Limited number of warning messages printed b <<
139 G4GlobalFastSimulationManager. <<
140 - Renamed G4FastSimulationManagerProcess_forCo <<
141 G4FastSimulationManagerProcess81. <<
142 In addition, this class can now handle the c <<
143 i.e., the navigator for tracking, regardless <<
144 G4CoupledTransportation is used. (For other <<
145 of course no choice, and G4CoupledTransporta <<
146 <<
147 November 3, 2006 M. Verderi <<
148 - Introduced G4FastSimulationManagerProcess_fo <<
149 handling fast simulation in new parallel geo <<
150 the G4CoupledTransportation to be active. <<
151 - Introduced G4GFSManager81 class that gathers <<
152 default at next major release in the G4Globa <<
153 - G4FastSimulationManager: adapted to new sche <<
154 backward compatibilty. <<
155 - G4FastSimulationManagerProcess: mostly the s <<
156 - G4FastSimulationMessenger: new command creat <<
157 to show the fast simulation setup (region, m <<
158 It is only valid for geometry closed state. <<
159 command in the run manager for this. <<
160 <<
161 November 25, 2005, M.Verderi - param-V07-01-0 <<
162 - put back Makoto's change: StartTracking(G4Tr <<
163 <<
164 November 25, 2005, M Verderi - param-V07-01-03 <<
165 - Make ghost functionnality available with G4R <<
166 - ** Note ** Change back StartTracking(G4Track <<
167 StartTracking(G4Track*) was intro <<
168 because (I guess) of procman-V07-01-01 <<
169 This is to make param-V07-01-03 compatible w <<
170 <<
171 November 21, 2005 M.Asai - param-V07-01-02 <<
172 - Fix warning message. <<
173 <<
174 November 02, 2005 G.Cosmo - param-V07-01-01 <<
175 - Corrected setting of envelope volumes and so <<
176 - Migrated old scheme for G4Exception and some <<
177 <<
178 October 28, 2005 M.Asai - param-V07-01-00 <<
179 - Working tag for merging "envelope" to G4Regi <<
180 <<
181 December 07, 2004 G. Cosmo - param-V06-02-01 <<
182 - Implemented migration to <cmath>. <<
183 <<
184 November 26, 2004 M. Verderi - param-V06-02-00 <<
185 - Implemented migration to new G4VParticleChan <<
186 19
187 December 12, 2003 G. Cosmo - param-V06-00-00 20 December 12, 2003 G. Cosmo - param-V06-00-00
188 - G4FastSimulationVector.icc: use std_pvector: 21 - G4FastSimulationVector.icc: use std_pvector:: scope for calls to
189 base class. Fixes compilation problem on Int 22 base class. Fixes compilation problem on Intel-icc compiler.
190 23
191 November 10, 2003 G. Cosmo - param-V05-02-01 24 November 10, 2003 G. Cosmo - param-V05-02-01
192 - G4FastTrack: use G4Navigator::CreateTouchabl 25 - G4FastTrack: use G4Navigator::CreateTouchableHistoryHandle() instead of
193 CreateTouchableHistory() in method FRecordsA 26 CreateTouchableHistory() in method FRecordsAffineTransformation().
194 27
195 October 4, 2003 G. Cosmo - param-V05-02-00 28 October 4, 2003 G. Cosmo - param-V05-02-00
196 - Modified GNUmakefile: 29 - Modified GNUmakefile:
197 o added dependency to new module "geometry/n 30 o added dependency to new module "geometry/navigation".
198 - Coworks with "geometry-V05-02-00" and "digit 31 - Coworks with "geometry-V05-02-00" and "digits_hits-V05-02-00".
199 32
200 May 21, 2003 G. Cosmo - param-V05-01-00 33 May 21, 2003 G. Cosmo - param-V05-01-00
201 o Fixed pedantic warnings on Linux-g++ 34 o Fixed pedantic warnings on Linux-g++.
202 o Call base class in copy-constructor 35 o Call base class in copy-constructor of G4FastStep.
203 36
204 Nov 20, 2002 G. Cosmo - param-V04-01-02 37 Nov 20, 2002 G. Cosmo - param-V04-01-02
205 o Patched access to public static data in G4 38 o Patched access to public static data in G4FastStep.cc
206 and G4GlobalFastSimulationManager.cc to al 39 and G4GlobalFastSimulationManager.cc to allow porting on
207 Windows DLLs. 40 Windows DLLs.
208 41
209 Nov 15, 2002 S. Sadilov - param-V04-01-01 42 Nov 15, 2002 S. Sadilov - param-V04-01-01
210 o Fixed compilation problems on Windows in 43 o Fixed compilation problems on Windows in
211 G4FastSimulationManager.cc and G4GlobalFas 44 G4FastSimulationManager.cc and G4GlobalFastSimulationManager.cc
212 45
213 Nov 02, 2002 M. Verderi - param-V04-01-00 46 Nov 02, 2002 M. Verderi - param-V04-01-00
214 o Add method to retrieve G4VFastSimulationMo 47 o Add method to retrieve G4VFastSimulationModel by name.
215 The user's method is in G4GlobalFastSimula 48 The user's method is in G4GlobalFastSimulationManager:
216 49
217 GetFastSimulationModel(); 50 GetFastSimulationModel();
218 51
219 it is accompagnied by same methods name in 52 it is accompagnied by same methods name in
220 G4FastSimulationManager class. 53 G4FastSimulationManager class.
221 54
222 o Add "test" directory, used to test above f 55 o Add "test" directory, used to test above feature.
223 56
224 Oct 26, 2001 M. Verderi - param-V03-02-00 57 Oct 26, 2001 M. Verderi - param-V03-02-00
225 Fixes to clear warnings produced with gcc-2. 58 Fixes to clear warnings produced with gcc-2.95.2:
226 - loop index, where comparison with method " 59 - loop index, where comparison with method "size()" of
227 G4std::vector<T>, changed: int -> size_t << 60 G4std::vector<T>, changed: int -> size_t
228 - change "if ( a=b ) {..}" by "if ( (a=b) ) 61 - change "if ( a=b ) {..}" by "if ( (a=b) ) {...}"
229 this makes the compiler sure you want to mak 62 this makes the compiler sure you want to make an
230 assignement in the "if" condition 63 assignement in the "if" condition
231 - re-order initialisations of a few variable 64 - re-order initialisations of a few variables in constructors
232 to match the declaration order. 65 to match the declaration order.
233 Some warnings still exist, but regard the G4 66 Some warnings still exist, but regard the G4Propagator of geometry.
234 67
235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 68 Apr 3, 2001 J. Apostolakis - param-V03-00-00
236 - Modified G4FastSimulationManagerProcess call 69 - Modified G4FastSimulationManagerProcess call to PropagatorInField ComputeStep
237 to use new interface with G4FieldTrack (in 70 to use new interface with G4FieldTrack (in place of now obsolete interface.)
238 71
239 Nov 14, 2000 G. Cosmo - param-V02-00-01 72 Nov 14, 2000 G. Cosmo - param-V02-00-01
240 - Moved specific parameterisation models to th 73 - Moved specific parameterisation models to the new top category
241 "parameterisations". Moved files: 74 "parameterisations". Moved files:
242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm 75 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRmodel[.hh.cc],
243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster 76 G4IrregularXrayTRmodel[.hh.cc], G4PAIclusterModel[.hh.cc],
244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr 77 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXrayTRmodel[.hh.cc],
245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode 78 G4RegularXrayTRmodel[.hh.cc], G4VClusterModel[.hh.cc],
246 G4VXrayTRmodel[.hh.cc]. 79 G4VXrayTRmodel[.hh.cc].
247 - Cleaned-up GNUmakefile of non necessary depe 80 - Cleaned-up GNUmakefile of non necessary dependencies.
248 81
249 Aug 03, 2000 G. Cosmo - param-V02-00-00r 82 Aug 03, 2000 G. Cosmo - param-V02-00-00r
250 - Changed RandGauss to G4RandGauss in G4Irregu 83 - Changed RandGauss to G4RandGauss in G4IrregularXrayTRmodel.cc and
251 G4VXrayTRmodel.cc to fix events' reproducibi 84 G4VXrayTRmodel.cc to fix events' reproducibility problem.
252 - G4VXrayTRmodel.cc: fix to class destructor ( 85 - G4VXrayTRmodel.cc: fix to class destructor (V.Grichine)
253 86
254 Jun 15, 2000 G. Cosmo - param-V01-01-04 87 Jun 15, 2000 G. Cosmo - param-V01-01-04
255 - The tag coworks with global-V01-01-04 and ma 88 - The tag coworks with global-V01-01-04 and materials-V01-01-00:
256 o Fixed usage of G4complex type for ISO and 89 o Fixed usage of G4complex type for ISO and non-ISO compilers.
257 Affected files: G4FoamXrayTRmodel.cc, G4Ga 90 Affected files: G4FoamXrayTRmodel.cc, G4GamDistrXrayTRmodel.cc, G4PlateIrrGasXrayTRmodel.cc
258 and G4RegularXrayTRmodel.c 91 and G4RegularXrayTRmodel.cc.
259 In case of G4complex types passed to mathe 92 In case of G4complex types passed to mathematical functions, use G4std:: prefix.
260 o Fixed usage of G4Integrator class, now cha 93 o Fixed usage of G4Integrator class, now changed to templated to allow porting of the
261 code on SUN-CC compiler which does not imp 94 code on SUN-CC compiler which does not implement templated member functions.
262 Affected files: G4VXrayTRmodel[.hh.cc] 95 Affected files: G4VXrayTRmodel[.hh.cc]
263 96
264 Jun 6, 2000 M. Verderi & P. Mora de Freitas 97 Jun 6, 2000 M. Verderi & P. Mora de Freitas
265 - fixed compilation errors with HP-aCC for the 98 - fixed compilation errors with HP-aCC for the files G4RegularXrayTRmodel.cc,
266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod 99 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmodel.cc.
267 100
268 May 30, 2000 M. Verderi & P. Mora de Freitas 101 May 30, 2000 M. Verderi & P. Mora de Freitas
269 102
270 - parameterisation category is now RW free. 103 - parameterisation category is now RW free.
271 104
272 September 16, 1999 M. Verderi & P. Mora de Fre 105 September 16, 1999 M. Verderi & P. Mora de Freitas
273 106
274 - Fixed bug in G4FastStep::CheckIt() method. 107 - Fixed bug in G4FastStep::CheckIt() method.
275 108
276 April 19, 1999 M. Verderi & P. Mora de Freitas 109 April 19, 1999 M. Verderi & P. Mora de Freitas
277 110
278 Changes in G4FastStep to co-work with track-01 111 Changes in G4FastStep to co-work with track-01-00-04:
279 112
280 1) The method void CheckIt(const G4Track&) bec << 113 1) The method void CheckIt(const G4Track&) becomes
281 G4bool CheckIt(const G4Track&); 114 G4bool CheckIt(const G4Track&);
282 2) The FAST_STEP_DEBUG compiling option disapp 115 2) The FAST_STEP_DEBUG compiling option disappears;
283 3) Call to CheckIt controled by the G4VParticl 116 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute.
284 117
285 Miscellaneous: the declaration "G4double mass 118 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh
286 corrected to G4double mass =...". 119 corrected to G4double mass =...".
287 120
288 April 15, 1999 M. Verderi & P. Mora de Freitas 121 April 15, 1999 M. Verderi & P. Mora de Freitas
289 122
290 Tasks to decouple visualization from processes 123 Tasks to decouple visualization from processes/parameterisation:
291 124
292 1) G4GlobalFastSimulationManager now inherites 125 1) G4GlobalFastSimulationManager now inherites from the intercoms/
293 G4VGlobalFastSimulationManager to allow visual << 126 G4VGlobalFastSimulationManager to allow visualisation to get a
294 concrete instance pointer to the G4GlobalFastS 127 concrete instance pointer to the G4GlobalFastSimulationManager,
295 if any. 128 if any.
296 129
297 2) G4FlavoredParallelWorld now inherites from 130 2) G4FlavoredParallelWorld now inherites from the intercoms/
298 G4VFlavoredParallelWorld, a pure virtual abstr 131 G4VFlavoredParallelWorld, a pure virtual abstract class to interface
299 parameterisation with visualization. 132 parameterisation with visualization.
300 133
301 Co-works with intercoms-01-00-01 tag 134 Co-works with intercoms-01-00-01 tag
302 135
303 Modified files: 136 Modified files:
304 --------------- 137 ---------------
305 G4FlavoredParallelWorld.hh 138 G4FlavoredParallelWorld.hh
306 G4GlobalFastSimulationManager.hh 139 G4GlobalFastSimulationManager.hh
307 G4GlobalFastSimulationManager.cc 140 G4GlobalFastSimulationManager.cc
308 141
309 Done, tested, system-tested on HP-aCC with exe 142 Done, tested, system-tested on HP-aCC with exemple N05.
310 143
311 April 14, 1999 M. Verderi & P. Mora de Freitas 144 April 14, 1999 M. Verderi & P. Mora de Freitas
312 145
313 Several consolidation tasks (thanks to G. Cosm 146 Several consolidation tasks (thanks to G. Cosmo):
314 147
315 1) Warning: << 148 1) Warning:
316 ----------- 149 -----------
317 150
318 Pointers usage 151 Pointers usage
319 152
320 - Setting pointers to 0 after delete: 153 - Setting pointers to 0 after delete:
321 154
322 delete pA; 155 delete pA;
323 pA = 0; 156 pA = 0;
324 157
325 - Avoid to use "NULL". 158 - Avoid to use "NULL".
326 159
327 Modified files: 160 Modified files:
328 --------------- 161 ---------------
329 G4FastSimulationManager.hh 162 G4FastSimulationManager.hh
330 G4FastTrack.hh 163 G4FastTrack.hh
331 G4FlavoredParallelWorld.hh 164 G4FlavoredParallelWorld.hh
332 G4FastSimulationManager.cc 165 G4FastSimulationManager.cc
333 G4FastSimulationMessenger.cc 166 G4FastSimulationMessenger.cc
334 G4FastSimulationManagerProcess.cc 167 G4FastSimulationManagerProcess.cc
335 G4FastTrack.cc 168 G4FastTrack.cc
336 G4GlobalFastSimulationManager.cc 169 G4GlobalFastSimulationManager.cc
337 G4VFastSimulationModel.cc 170 G4VFastSimulationModel.cc
338 171
339 Status: << 172 Status:
340 ------- 173 -------
341 Done, tested, system-tested on HP-aCC with exe 174 Done, tested, system-tested on HP-aCC with exemple N05.
342 175
343 2) Warning: 176 2) Warning:
344 ----------- 177 -----------
345 include/G4FastSimulationManager.hh:163 178 include/G4FastSimulationManager.hh:163
346 Public member functions shall always retur 179 Public member functions shall always return const handles to member data
347 Severe violation: Universal Coding Standar 180 Severe violation: Universal Coding Standards item 18
348 181
349 offending code: 182 offending code:
350 --------------- 183 ---------------
351 inline G4VParticleChange* G4FastSimulationMana 184 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange()
352 { 185 {
353 return &fFastStep; 186 return &fFastStep;
354 } 187 }
355 188
356 Diagnostic: 189 Diagnostic:
357 ---------- 190 ----------
358 191
359 Called by the G4FastSimulationManagerProcess << 192 Called by the G4FastSimulationManagerProcess to return it in the
360 PostStepDoIt call. << 193 PostStepDoIt call.
361 194
362 Action: 195 Action:
363 ------- 196 -------
364 The G4FastSimulationManager::GettheParticleCha 197 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any
365 more. The G4VParticleChange* is now returned d 198 more. The G4VParticleChange* is now returned directly when invoking the
366 G4FastSimulationManager::InvokePostStepDoIt() 199 G4FastSimulationManager::InvokePostStepDoIt() and
367 G4FastSimulationManager::InvokeAtRestDoIt() me 200 G4FastSimulationManager::InvokeAtRestDoIt() methodes.
368 201
369 Modified files: 202 Modified files:
370 --------------- 203 ---------------
371 G4FastSimulationManager.hh 204 G4FastSimulationManager.hh
372 G4FastSimulationManager.cc 205 G4FastSimulationManager.cc
373 G4FastSimulationManagerProcess.cc 206 G4FastSimulationManagerProcess.cc
374 207
375 Status: << 208 Status:
376 ------- 209 -------
377 Done, tested, system-tested on HP-aCC with exe 210 Done, tested, system-tested on HP-aCC with exemple N05.
378 211
379 3) Warning: 212 3) Warning:
380 ----------- 213 -----------
381 include/G4FastSimulationManagerProcess.hh:52 214 include/G4FastSimulationManagerProcess.hh:52
382 If a class has virtual functions it shall 215 If a class has virtual functions it shall have a virtual destructor
383 Severe violation: Universal Coding Standar 216 Severe violation: Universal Coding Standards item 17
384 class G4FastSimulationManagerProcess has v 217 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor.
385 218
386 offending code: 219 offending code:
387 --------------- 220 ---------------
388 ~G4FastSimulationManagerProcess(); 221 ~G4FastSimulationManagerProcess();
389 222
390 Diagnostic: 223 Diagnostic:
391 ---------- 224 ----------
392 Nobody should inherites from G4FastSimulatio << 225 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual
393 is added. 226 is added.
394 227
395 Action: 228 Action:
396 ------- 229 -------
397 virtual ~G4FastSimulationManagerProcess(); 230 virtual ~G4FastSimulationManagerProcess();
398 231
399 Modified files: 232 Modified files:
400 --------------- 233 ---------------
401 G4FastSimulationManagerProcess.hh 234 G4FastSimulationManagerProcess.hh
402 235
403 Status: << 236 Status:
404 ------- 237 -------
405 Done. 238 Done.
406 239
407 4) Warning: 240 4) Warning:
408 ----------- 241 -----------
409 include/G4FastSimulationMessenger.hh:36 242 include/G4FastSimulationMessenger.hh:36
410 If a class has virtual functions it shall 243 If a class has virtual functions it shall have a virtual destructor
411 Severe violation: Universal Coding Standar 244 Severe violation: Universal Coding Standards item 17
412 class G4FastSimulationMessenger has virtua 245 class G4FastSimulationMessenger has virtual functions without a virtual destructor.
413 246
414 247
415 offending code: 248 offending code:
416 --------------- 249 ---------------
417 ~G4FastSimulationMessenger(); 250 ~G4FastSimulationMessenger();
418 251
419 Diagnostic: 252 Diagnostic:
420 ---------- 253 ----------
421 Nobody should inherites from G4FastSimulatio << 254 Nobody should inherites from G4FastSimulationMessenger BUT for virtual
422 is added. 255 is added.
423 256
424 Action: 257 Action:
425 ------- 258 -------
426 virtual ~G4FastSimulationMessenger(); 259 virtual ~G4FastSimulationMessenger();
427 260
428 Modified files: 261 Modified files:
429 --------------- 262 ---------------
430 G4FastSimulationMessenger.hh 263 G4FastSimulationMessenger.hh
431 264
432 Status: << 265 Status:
433 ------- 266 -------
434 Done. 267 Done.
435 268
436 5) Warning: 269 5) Warning:
437 ----------- 270 -----------
438 include/G4FastStep.hh:224 271 include/G4FastStep.hh:224
439 Operator= should call base class operator= 272 Operator= should call base class operator=
440 Possible severe violation: Effective C++ i 273 Possible severe violation: Effective C++ item 16
441 operator= in class G4FastStep, should call 274 operator= in class G4FastStep, should call operator= in base class G4VParticleChange
442 275
443 offending code: 276 offending code:
444 --------------- 277 ---------------
445 G4FastStep & G4FastStep::operator=(const G4Fas 278 G4FastStep & G4FastStep::operator=(const G4FastStep &right)
446 { 279 {
447 if (this != &right) 280 if (this != &right)
448 { 281 {
449 theListOfSecondaries = right.th 282 theListOfSecondaries = right.theListOfSecondaries;
450 theSizeOftheListOfSecondaries = right.th 283 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries;
451 theNumberOfSecondaries = right.th 284 theNumberOfSecondaries = right.theNumberOfSecondaries;
452 theStatusChange = right.th 285 theStatusChange = right.theStatusChange;
453 theMomentumChange = right.th 286 theMomentumChange = right.theMomentumChange;
454 thePolarizationChange = right.th 287 thePolarizationChange = right.thePolarizationChange;
455 thePositionChange = right.th 288 thePositionChange = right.thePositionChange;
456 theTimeChange = right.th 289 theTimeChange = right.theTimeChange;
457 theEnergyChange = right.th 290 theEnergyChange = right.theEnergyChange;
458 theTrueStepLength = right.th 291 theTrueStepLength = right.theTrueStepLength;
459 theLocalEnergyDeposit = right.th 292 theLocalEnergyDeposit = right.theLocalEnergyDeposit;
460 theSteppingControlFlag = right.th 293 theSteppingControlFlag = right.theSteppingControlFlag;
461 theWeightChange = right.th 294 theWeightChange = right.theWeightChange;
462 } 295 }
463 return *this; 296 return *this;
464 } 297 }
465 298
466 Diagnostic: 299 Diagnostic:
467 ---------- 300 ----------
468 Bug detected. 301 Bug detected.
469 302
470 Action: 303 Action:
471 ------- 304 -------
472 Insert the call 305 Insert the call
473 G4VParticleChange::operator=(right); 306 G4VParticleChange::operator=(right);
474 307
475 Status: 308 Status:
476 ------- 309 -------
477 Done, tested, system-tested on HP-aCC with e 310 Done, tested, system-tested on HP-aCC with exemple N05.
478 311
479 Modified files: 312 Modified files:
480 --------------- 313 ---------------
481 G4FastStep.cc 314 G4FastStep.cc
482 315
483 6) Warning: 316 6) Warning:
484 ----------- 317 -----------
485 include/G4FastStep.hh:59 318 include/G4FastStep.hh:59
486 Avoid data members in the public interface 319 Avoid data members in the public interface
487 Violation: Effective C++ item 20 320 Violation: Effective C++ item 20
488 Public data members for class G4FastStep: 321 Public data members for class G4FastStep:
489 debugFlag 322 debugFlag
490 323
491 324
492 offending code: 325 offending code:
493 --------------- 326 ---------------
494 public: 327 public:
495 ... 328 ...
496 G4bool debugFlag; 329 G4bool debugFlag;
497 330
498 Diagnostic: 331 Diagnostic:
499 ---------- 332 ----------
500 Historical usage. 333 Historical usage.
501 334
502 Action: 335 Action:
503 ------- 336 -------
504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 337 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file.
505 338
506 Modified files: 339 Modified files:
507 --------------- 340 ---------------
508 G4FastStep.hh, G4FastStep.cc 341 G4FastStep.hh, G4FastStep.cc
509 342
510 Status: 343 Status:
511 ------- 344 -------
512 Done, tested, system-tested on HP-aCC with e 345 Done, tested, system-tested on HP-aCC with exemple N05.
513 346
514 7) Warning: 347 7) Warning:
515 ----------- 348 -----------
516 include/G4FastStep.hh:59 349 include/G4FastStep.hh:59
517 If a class has virtual functions it shall 350 If a class has virtual functions it shall have a virtual destructor
518 Severe violation: Universal Coding Standar 351 Severe violation: Universal Coding Standards item 17
519 class G4FastStep has virtual functions wit 352 class G4FastStep has virtual functions without a virtual destructor.
520 353
521 354
522 offending code: 355 offending code:
523 --------------- 356 ---------------
524 ~G4FastStep(); 357 ~G4FastStep();
525 358
526 Diagnostic: 359 Diagnostic:
527 ---------- 360 ----------
528 Nobody should inherites from G4FastStep BUT 361 Nobody should inherites from G4FastStep BUT virtual added.
529 362
530 Action: 363 Action:
531 ------- 364 -------
532 virtual ~G4FastStep(); 365 virtual ~G4FastStep();
533 366
534 Modified files: 367 Modified files:
535 --------------- 368 ---------------
536 G4FastStep.hh 369 G4FastStep.hh
537 370
538 Status: 371 Status:
539 ------- 372 -------
540 Done, tested, system-tested on HP-aCC with e 373 Done, tested, system-tested on HP-aCC with exemple N05.
541 374
542 375
543 December 7, 1998 M. Verderi 376 December 7, 1998 M. Verderi
544 G4FastSimulationManagerProcess class: 377 G4FastSimulationManagerProcess class:
545 Fixes made for ghost navigation with 378 Fixes made for ghost navigation with
546 mag-field: 379 mag-field:
547 LocateGlobalPointAndUpdateTouchable is 380 LocateGlobalPointAndUpdateTouchable is
548 always used (in not the Locate...Setup 381 always used (in not the Locate...Setup
549 method) 382 method)
550 In PostStepDoIt: correction of position and 383 In PostStepDoIt: correction of position and
551 direction of the track are made when << 384 direction of the track are made when
552 possible in case of mag-field. 385 possible in case of mag-field.
553 This correction comes from the fact that a 386 This correction comes from the fact that a
554 small discrepancy appears on those quantitie 387 small discrepancy appears on those quantities
555 because of the numerical integration along 388 because of the numerical integration along
556 the field on the track path: the G4FSMP 389 the field on the track path: the G4FSMP
557 proposes a curve-length, the transportation 390 proposes a curve-length, the transportation
558 moves the track along this curve, however 391 moves the track along this curve, however
559 the end point position and direction are 392 the end point position and direction are
560 slightly different from those expected by 393 slightly different from those expected by
561 the G4FSMP when it proposed the length. 394 the G4FSMP when it proposed the length.
562 395
563 November 20,1998 M. Verderi 396 November 20,1998 M. Verderi
564 G4FastStep class: 397 G4FastStep class:
565 Remove track/G4BiasingTag.hh dependancy (ob 398 Remove track/G4BiasingTag.hh dependancy (obsolete).
566 Adapted to new shceme of Event Biasing mech 399 Adapted to new shceme of Event Biasing mechanism,
567 consistently with track-00-04-01 tag. 400 consistently with track-00-04-01 tag.
568 401
569 November 11,1998 M. Verderi 402 November 11,1998 M. Verderi
570 Merge of param-00-03-02 & param-00-03-02a i 403 Merge of param-00-03-02 & param-00-03-02a into
571 param-00-03-04a (hopefully...) 404 param-00-03-04a (hopefully...)
572 The point is the chnage of signature in the 405 The point is the chnage of signature in the
573 LocateGlobalPointAndSetup(..) of the G4Navi 406 LocateGlobalPointAndSetup(..) of the G4Navigator making use now
574 of the track direction. The G4FastSimulatio 407 of the track direction. The G4FastSimulationManagerProcess is
575 changed accordingly: 408 changed accordingly:
576 fGhostNavigator.LocateGlobalPointAndSetup(t 409 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true);
577 410
578 411
579 November 6, 1998 M. Verderi 412 November 6, 1998 M. Verderi
580 - Extension of the G4FastStep to allow the 413 - Extension of the G4FastStep to allow the biasing technic.
581 Changes are made in: 414 Changes are made in:
582 - G4FastStep.hh/.icc: 415 - G4FastStep.hh/.icc:
583 new member G4BiasingTa 416 new member G4BiasingTag fBiasTag;
584 new method SetPrimaryT 417 new method SetPrimaryTrackFinalBiasingTag
585 ( G4BiasingTag 418 ( G4BiasingTag aTag );
586 - G4FastStep.cc: 419 - G4FastStep.cc:
587 Initialize(); 420 Initialize();
588 operator=; << 421 operator=;
589 UpdateForPostStep(); 422 UpdateForPostStep();
590 UpdateForAtRest(); << 423 UpdateForAtRest();
591 424
592 October 26, 1998 P.Mora de Freitas 425 October 26, 1998 P.Mora de Freitas
593 - G4FastSimulationManagerProcess and G4Fast 426 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal
594 with at rest parameterisations also when 427 with at rest parameterisations also when using parallel geometry.
595 428
596 October 8, 1998 P.Mora de Freitas 429 October 8, 1998 P.Mora de Freitas
597 - The G4VFastSimulationModel::IsApplicable( 430 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual
598 methode. 431 methode.
599 - G4FastSimulationManager optimisation: 432 - G4FastSimulationManager optimisation:
600 - New G4ParticleDefinition* fLastCrossedP 433 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps
601 the last particle type with touched the 434 the last particle type with touched the envelope;
602 - New G4RWTPtrOrderedVector<G4VFastSimula 435 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList
603 data member, keeps the model list of th << 436 data member, keeps the model list of the applicable models for
604 the actual fLastCrossedParticle particl 437 the actual fLastCrossedParticle particle type;
605 - Changes in the PostStepGetFastSimulatio << 438 - Changes in the PostStepGetFastSimulationManagerTrigger() and
606 AtRestGetFastSimulationManagerTrigger() << 439 AtRestGetFastSimulationManagerTrigger()methodes to update the
607 fApplicableModelList when needed (fLast 440 fApplicableModelList when needed (fLastCrossedParticle !=
608 the actual tracked particle); 441 the actual tracked particle);
609 - Changes in the << 442 - Changes in the
610 G4FastSimulationManager() (Constructor) 443 G4FastSimulationManager() (Constructor)
611 ActivateFastSimulationModel(), 444 ActivateFastSimulationModel(),
612 InActivateFastSimulationModel(), 445 InActivateFastSimulationModel(),
613 AtRestGetFastSimulationManagerTrigger(), 446 AtRestGetFastSimulationManagerTrigger(),
614 AddFastSimulationModel(), 447 AddFastSimulationModel(),
615 RemoveFastSimulationModel() 448 RemoveFastSimulationModel()
616 methodes to set the fLastCrossedParticle to 449 methodes to set the fLastCrossedParticle to NULL, forcing the
617 fApplicableModelList to be rebuilt. 450 fApplicableModelList to be rebuilt.
618 451
619 September 22, 1998 P.Mora de Freitas 452 September 22, 1998 P.Mora de Freitas
620 Fixed bug in parallel navigation. << 453 Fixed bug in parallel navigation.
621 File touched: G4FastSimulationManagerProces 454 File touched: G4FastSimulationManagerProcess.cc
622 Tested on HP-aCC. 455 Tested on HP-aCC.
623 456
624 September 17, 1998 P.Mora de Freitas 457 September 17, 1998 P.Mora de Freitas
625 G4FastSimulationManager::RemoveFastSimulati 458 G4FastSimulationManager::RemoveFastSimulationModel() updated to look
626 for also in the fInactivatedModels list. 459 for also in the fInactivatedModels list.
627 460
628 Tested on HP-aCC. 461 Tested on HP-aCC.
629 462
630 September 16, 1998 P.Mora de Freitas 463 September 16, 1998 P.Mora de Freitas
631 New /param/ control commands: 464 New /param/ control commands:
632 465
633 /param/ActivateModel <ModelName> 466 /param/ActivateModel <ModelName>
634 /param/InActivateModel <ModelName> 467 /param/InActivateModel <ModelName>
635 468
636 Activate or inactivate a given parameterisat 469 Activate or inactivate a given parameterisation model.
637 470
638 Tested on HP-aCC. 471 Tested on HP-aCC.
639 472
640 August 21, 1998 P.Mora de Freitas 473 August 21, 1998 P.Mora de Freitas
641 G4FastSimulationManagerProcess's G4ProcessTy 474 G4FastSimulationManagerProcess's G4ProcessType set to
642 fParameterisation, accordingly with procman-00 475 fParameterisation, accordingly with procman-00-02-03.
643 476
644 Tested on HP-aCC. 477 Tested on HP-aCC.
645 478
646 August 12, 1998 P.Mora de Freitas 479 August 12, 1998 P.Mora de Freitas
647 Improved the "close parameterisation control << 480 Improved the "close parameterisation control" to
648 481
649 1) avoid the close looping when unnecessary 482 1) avoid the close looping when unnecessary (mostly cases);
650 2) force re-close when necessary (insert/rem 483 2) force re-close when necessary (insert/remove ghosts).
651 484
652 Changes: 485 Changes:
653 486
654 1) the G4GlobalFastSimulationManager::fClose << 487 1) the G4GlobalFastSimulationManager::fClosed is now initialised
655 to true by the G4GlobalFastSimulationMana 488 to true by the G4GlobalFastSimulationManager constructor;
656 489
657 2) new method << 490 2) new method
658 491
659 void << 492 void
660 G4GlobalFastSimulationManager::FastSimula 493 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed();
661 494
662 called by the AddGhostPlacement and Remov << 495 called by the AddGhostPlacement and RemoveGhostPlacement
663 G4FastSimulationManager methods to set fa 496 G4FastSimulationManager methods to set false the fClosed flag;
664 497
665 3) changes in the G4GlobalFastSimulationMana 498 3) changes in the G4GlobalFastSimulationManager::Notify method
666 to deal with these changes. 499 to deal with these changes.
667 500
668 Tested on HP-aCC. 501 Tested on HP-aCC.
669 502
670 August 11, 1998 P.Mora de Freitas 503 August 11, 1998 P.Mora de Freitas
671 Fix to the G4FastStep::KillPrimaryTrack() me 504 Fix to the G4FastStep::KillPrimaryTrack() method to drop the
672 nonsense line 505 nonsense line
673 506
674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 507 SetMomentumChange(0.,0.,0.) ; /* necessary ? */
675 508
676 Tested on HP-aCC. 509 Tested on HP-aCC.
677 (Thanks to Willy Langeveld) 510 (Thanks to Willy Langeveld)
678 511
679 512
680 August 10, 1998 P.Mora de Freitas 513 August 10, 1998 P.Mora de Freitas
681 Fix to the SetPrimaryTrackFinalKineticEnergy 514 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method
682 from the G4FastStep class the SetMomentumChang 515 from the G4FastStep class the SetMomentumChange() call to insure that
683 the new momentum direction is a unit vector (a << 516 the new momentum direction is a unit vector (as asked by the
684 G4DynamicParticle::SetMomentumDirection method 517 G4DynamicParticle::SetMomentumDirection method).
685 518
686 Touched files: G4FastStep.hh (improved comme 519 Touched files: G4FastStep.hh (improved comments)
687 G4FastStep.cc (fixed) 520 G4FastStep.cc (fixed)
688 521
689 Tested on HP-aCC. 522 Tested on HP-aCC.
690 (Thanks to Willy Langeveld) 523 (Thanks to Willy Langeveld)
691 524
692 August 7, 1998 P.Mora de Freitas 525 August 7, 1998 P.Mora de Freitas
693 New /param/ commands directory with the comm 526 New /param/ commands directory with the commands:
694 527
695 /param/listEnvelopes [ParticleName] 528 /param/listEnvelopes [ParticleName]
696 529
697 - List all the envelope names for a given pa 530 - List all the envelope names for a given particle
698 (or for all particles if without parameter 531 (or for all particles if without parameters).
699 532
700 /param/listModels [EnvelopeName] 533 /param/listModels [EnvelopeName]
701 534
702 - List all the Model names for a given envel 535 - List all the Model names for a given envelope
703 (or for all envelopes if without parameter 536 (or for all envelopes if without parameters).
704 537
705 /param/listIsApplicable [ModelName] 538 /param/listIsApplicable [ModelName]
706 539
707 - List all the particle names a given model 540 - List all the particle names a given model is applicable
708 (or for all models if without parameters). 541 (or for all models if without parameters).
709 542
710 543
711 August 7, 1998 P.Mora de Freitas 544 August 7, 1998 P.Mora de Freitas
712 History file Created. 545 History file Created.