| Geant4 Cross Reference |
1 # Category param History << 1 $Id: History,v 1.19 2003/11/10 08:57:37 gcosmo Exp $
>> 2 -------------------------------------------------------------------
2 3
3 See `CONTRIBUTING.rst` for details of **requir << 4 =========================================================
4 which **must** added in reverse chronological << 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP
5 It must **not** be used as a substitute for wr << 6 =========================================================
6 << 7
7 ---------------------------------------------- << 8 Category History file
8 << 9 ---------------------
9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) << 10 This file should be used by G4 developers and category coordinators
10 - In G4GlobalFastSimulationManager: << 11 to briefly summarize all major modifications introduced in the code
11 use G4ThreadLocalSingleton to avoid undelete << 12 and keep track of all category-tags.
12 << 13 It DOES NOT substitute the CVS log-message one should put at every
13 ## 2023-10-18 Ben Morgan (param-V11-01-03) << 14 committal in the CVS repository !
14 - Apply standard and extended clang-tidy fixes << 15
15 - Mark empty/obsolete functions as deprecated << 16 ----------------------------------------------------------
16 << 17 * Reverse chronological order (last date on top), please *
17 ## 2023-10-16 Ben Morgan (param-V11-01-02) << 18 ----------------------------------------------------------
18 - Apply standard clang-format-ing. <<
19 - Normal order accessors and docstrings. <<
20 <<
21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) <<
22 - In G4FastTrack, removed references to G4Touc <<
23 which is now deprecated. <<
24 <<
25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 <<
26 - Added missing virtual destructor to G4VFastS <<
27 <<
28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) <<
29 - Fixed compilation warnings for implicit type <<
30 <<
31 ## 2022-10-27 Makoto Asai (param-V11-00-03) <<
32 - G4FastSimHitMaker - making compatible to com <<
33 <<
34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 <<
35 - G4FastStep - delete copy constructor and ope <<
36 <<
37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) <<
38 - Adding the 'flush' method to the fast simula <<
39 This method allows to process the input buff <<
40 the end of the G4 event. It is used when par <<
41 The 'flash' is triggered inside the event lo <<
42 The fast simulation model may add secondarie <<
43 by Geant4. <<
44 <<
45 ## 2021-12-10 Ben Morgan (param-V11-00-00) <<
46 - Change to new Markdown History format <<
47 <<
48 --- <<
49 <<
50 # History entries prior to 11.0 <<
51 <<
52 April 16, 2021 Ben Morgan (param-V10-07-00) <<
53 - Migrate build to modular CMake API <<
54 <<
55 October 5, 2020, A. Zaborowska (param-V10-06-0 <<
56 - Introduce general facilities based on GFlash <<
57 to facilitate multiple hit (energy & positio <<
58 from fast simulation models. <<
59 <<
60 September 9, 2020, G. Cosmo (param-V10-06-02) <<
61 - Fixed minor Coverity defect for uninitialise <<
62 <<
63 April 21, 2020, A. Zaborowska (param-V10-06-01 <<
64 - Sanity check for root logical volumes for re <<
65 UI command /param/showSetup works also if no <<
66 <<
67 March 26, 2020, I. Semeniouk (param-V10-06-00) <<
68 - G4FastSimulationHelper : merge ActivateFastS <<
69 - G4FastSimulationManager.hh, G4VFastSimulatio <<
70 redefinition of G4Envelope type <<
71 <<
72 October 30, 2019, A. Zaborowska (param-v10-05- <<
73 - Register G4FastSimulationManagerProcess with <<
74 G4FastSimulationManagerHelper to ensure it i <<
75 invoked for a given step (ExclusivelyForced) <<
76 StronglyForced processes will be considered. <<
77 <<
78 December 19, 2017, G. Cosmo (param-V10-04-00) <<
79 - Fixed self-consistency in G4FastSimulationVe <<
80 Thanks to Raphael Isemann for reporting this <<
81 <<
82 November 03, 2016, M. Verderi (param-V10-02-01 <<
83 - New G4FastSimulationManagerHelper utility fo <<
84 adding G4FastSimulationManagerProcess to a <<
85 process manager. <<
86 <<
87 November 02, 2016, M. Verderi (param-V10-02-00 <<
88 - fix various Coverity defects. <<
89 <<
90 March 27, 2013, M. Verderi (param-V09-06-00) <<
91 - remove unused field 'fOnBoundary' in G4FastS <<
92 as this was causing a warning from clang. <<
93 <<
94 July 10, 2012, G. Cosmo (param-V09-05-00) <<
95 - Explicitly use inclusion of headers for syst <<
96 constants, in plan to remove implicit inclus <<
97 <<
98 September 30, 2011, M. Verderi (param-V09-04-0 <<
99 - Added missing new header file (G4FastSimulat <<
100 sources.cmake. <<
101 <<
102 September 30, 2011, M. Verderi (param-V09-04-0 <<
103 - Migration to new G4Exception scheme. <<
104 - what is V09-04-01 tag ? <<
105 <<
106 February 11, 2011, M. Verderi (param-V09-04-00 <<
107 - Implementation of method <<
108 void ProposePrimaryTrackFinalKineticEnergy ( <<
109 was missing : modified file G4FastStep.icc <<
110 <<
111 March 13, 2008, G. Cosmo (param-V09-01-00) <<
112 - Cleared compilation warnings in G4FastSimula <<
113 G4FastSimulationMessenger on gcc-4.3.0 for a <<
114 parentheses in nested if-else statements. <<
115 <<
116 November 30, 2007, M. Verderi <<
117 - Add Along methods to G4FSMP process <<
118 - tag as param-V09-00-01 <<
119 <<
120 November 30, 2007, M. Verderi <<
121 - minor corrections to G4FastSimulationManager <<
122 * add call fPathFinder->prepareNewrack(...) <<
123 * deactivate ghost navigator in EndOfTracki <<
124 - tag as param-V09-00-00 <<
125 <<
126 May 18, 2007, M. Verderi <<
127 - tag as param-V08-03-00 <<
128 <<
129 May 11, 2007, M. Verderi <<
130 - remove include/G4FastSimulationManagerProces <<
131 include/G4FlavoredParallelWorld.hh <<
132 include/G4GFSManager81.hh <<
133 src/G4FastSimulationManagerProcess81. <<
134 src/G4GFSManager81.cc <<
135 <<
136 <<
137 November 10, 2006, M. Verderi - param-V08-01-0 <<
138 - Limited number of warning messages printed b <<
139 G4GlobalFastSimulationManager. <<
140 - Renamed G4FastSimulationManagerProcess_forCo <<
141 G4FastSimulationManagerProcess81. <<
142 In addition, this class can now handle the c <<
143 i.e., the navigator for tracking, regardless <<
144 G4CoupledTransportation is used. (For other <<
145 of course no choice, and G4CoupledTransporta <<
146 <<
147 November 3, 2006 M. Verderi <<
148 - Introduced G4FastSimulationManagerProcess_fo <<
149 handling fast simulation in new parallel geo <<
150 the G4CoupledTransportation to be active. <<
151 - Introduced G4GFSManager81 class that gathers <<
152 default at next major release in the G4Globa <<
153 - G4FastSimulationManager: adapted to new sche <<
154 backward compatibilty. <<
155 - G4FastSimulationManagerProcess: mostly the s <<
156 - G4FastSimulationMessenger: new command creat <<
157 to show the fast simulation setup (region, m <<
158 It is only valid for geometry closed state. <<
159 command in the run manager for this. <<
160 <<
161 November 25, 2005, M.Verderi - param-V07-01-0 <<
162 - put back Makoto's change: StartTracking(G4Tr <<
163 <<
164 November 25, 2005, M Verderi - param-V07-01-03 <<
165 - Make ghost functionnality available with G4R <<
166 - ** Note ** Change back StartTracking(G4Track <<
167 StartTracking(G4Track*) was intro <<
168 because (I guess) of procman-V07-01-01 <<
169 This is to make param-V07-01-03 compatible w <<
170 <<
171 November 21, 2005 M.Asai - param-V07-01-02 <<
172 - Fix warning message. <<
173 <<
174 November 02, 2005 G.Cosmo - param-V07-01-01 <<
175 - Corrected setting of envelope volumes and so <<
176 - Migrated old scheme for G4Exception and some <<
177 <<
178 October 28, 2005 M.Asai - param-V07-01-00 <<
179 - Working tag for merging "envelope" to G4Regi <<
180 <<
181 December 07, 2004 G. Cosmo - param-V06-02-01 <<
182 - Implemented migration to <cmath>. <<
183 <<
184 November 26, 2004 M. Verderi - param-V06-02-00 <<
185 - Implemented migration to new G4VParticleChan <<
186 <<
187 December 12, 2003 G. Cosmo - param-V06-00-00 <<
188 - G4FastSimulationVector.icc: use std_pvector: <<
189 base class. Fixes compilation problem on Int <<
190 19
191 November 10, 2003 G. Cosmo - param-V05-02-01 20 November 10, 2003 G. Cosmo - param-V05-02-01
192 - G4FastTrack: use G4Navigator::CreateTouchabl 21 - G4FastTrack: use G4Navigator::CreateTouchableHistoryHandle() instead of
193 CreateTouchableHistory() in method FRecordsA 22 CreateTouchableHistory() in method FRecordsAffineTransformation().
194 23
195 October 4, 2003 G. Cosmo - param-V05-02-00 24 October 4, 2003 G. Cosmo - param-V05-02-00
196 - Modified GNUmakefile: 25 - Modified GNUmakefile:
197 o added dependency to new module "geometry/n 26 o added dependency to new module "geometry/navigation".
198 - Coworks with "geometry-V05-02-00" and "digit 27 - Coworks with "geometry-V05-02-00" and "digits_hits-V05-02-00".
199 28
200 May 21, 2003 G. Cosmo - param-V05-01-00 29 May 21, 2003 G. Cosmo - param-V05-01-00
201 o Fixed pedantic warnings on Linux-g++ 30 o Fixed pedantic warnings on Linux-g++.
202 o Call base class in copy-constructor 31 o Call base class in copy-constructor of G4FastStep.
203 32
204 Nov 20, 2002 G. Cosmo - param-V04-01-02 33 Nov 20, 2002 G. Cosmo - param-V04-01-02
205 o Patched access to public static data in G4 34 o Patched access to public static data in G4FastStep.cc
206 and G4GlobalFastSimulationManager.cc to al 35 and G4GlobalFastSimulationManager.cc to allow porting on
207 Windows DLLs. 36 Windows DLLs.
208 37
209 Nov 15, 2002 S. Sadilov - param-V04-01-01 38 Nov 15, 2002 S. Sadilov - param-V04-01-01
210 o Fixed compilation problems on Windows in 39 o Fixed compilation problems on Windows in
211 G4FastSimulationManager.cc and G4GlobalFas 40 G4FastSimulationManager.cc and G4GlobalFastSimulationManager.cc
212 41
213 Nov 02, 2002 M. Verderi - param-V04-01-00 42 Nov 02, 2002 M. Verderi - param-V04-01-00
214 o Add method to retrieve G4VFastSimulationMo 43 o Add method to retrieve G4VFastSimulationModel by name.
215 The user's method is in G4GlobalFastSimula 44 The user's method is in G4GlobalFastSimulationManager:
216 45
217 GetFastSimulationModel(); 46 GetFastSimulationModel();
218 47
219 it is accompagnied by same methods name in 48 it is accompagnied by same methods name in
220 G4FastSimulationManager class. 49 G4FastSimulationManager class.
221 50
222 o Add "test" directory, used to test above f 51 o Add "test" directory, used to test above feature.
223 52
224 Oct 26, 2001 M. Verderi - param-V03-02-00 53 Oct 26, 2001 M. Verderi - param-V03-02-00
225 Fixes to clear warnings produced with gcc-2. 54 Fixes to clear warnings produced with gcc-2.95.2:
226 - loop index, where comparison with method " 55 - loop index, where comparison with method "size()" of
227 G4std::vector<T>, changed: int -> size_t << 56 G4std::vector<T>, changed: int -> size_t
228 - change "if ( a=b ) {..}" by "if ( (a=b) ) 57 - change "if ( a=b ) {..}" by "if ( (a=b) ) {...}"
229 this makes the compiler sure you want to mak 58 this makes the compiler sure you want to make an
230 assignement in the "if" condition 59 assignement in the "if" condition
231 - re-order initialisations of a few variable 60 - re-order initialisations of a few variables in constructors
232 to match the declaration order. 61 to match the declaration order.
233 Some warnings still exist, but regard the G4 62 Some warnings still exist, but regard the G4Propagator of geometry.
234 63
235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 64 Apr 3, 2001 J. Apostolakis - param-V03-00-00
236 - Modified G4FastSimulationManagerProcess call 65 - Modified G4FastSimulationManagerProcess call to PropagatorInField ComputeStep
237 to use new interface with G4FieldTrack (in 66 to use new interface with G4FieldTrack (in place of now obsolete interface.)
238 67
239 Nov 14, 2000 G. Cosmo - param-V02-00-01 68 Nov 14, 2000 G. Cosmo - param-V02-00-01
240 - Moved specific parameterisation models to th 69 - Moved specific parameterisation models to the new top category
241 "parameterisations". Moved files: 70 "parameterisations". Moved files:
242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm 71 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRmodel[.hh.cc],
243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster 72 G4IrregularXrayTRmodel[.hh.cc], G4PAIclusterModel[.hh.cc],
244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr 73 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXrayTRmodel[.hh.cc],
245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode 74 G4RegularXrayTRmodel[.hh.cc], G4VClusterModel[.hh.cc],
246 G4VXrayTRmodel[.hh.cc]. 75 G4VXrayTRmodel[.hh.cc].
247 - Cleaned-up GNUmakefile of non necessary depe 76 - Cleaned-up GNUmakefile of non necessary dependencies.
248 77
249 Aug 03, 2000 G. Cosmo - param-V02-00-00r 78 Aug 03, 2000 G. Cosmo - param-V02-00-00r
250 - Changed RandGauss to G4RandGauss in G4Irregu 79 - Changed RandGauss to G4RandGauss in G4IrregularXrayTRmodel.cc and
251 G4VXrayTRmodel.cc to fix events' reproducibi 80 G4VXrayTRmodel.cc to fix events' reproducibility problem.
252 - G4VXrayTRmodel.cc: fix to class destructor ( 81 - G4VXrayTRmodel.cc: fix to class destructor (V.Grichine)
253 82
254 Jun 15, 2000 G. Cosmo - param-V01-01-04 83 Jun 15, 2000 G. Cosmo - param-V01-01-04
255 - The tag coworks with global-V01-01-04 and ma 84 - The tag coworks with global-V01-01-04 and materials-V01-01-00:
256 o Fixed usage of G4complex type for ISO and 85 o Fixed usage of G4complex type for ISO and non-ISO compilers.
257 Affected files: G4FoamXrayTRmodel.cc, G4Ga 86 Affected files: G4FoamXrayTRmodel.cc, G4GamDistrXrayTRmodel.cc, G4PlateIrrGasXrayTRmodel.cc
258 and G4RegularXrayTRmodel.c 87 and G4RegularXrayTRmodel.cc.
259 In case of G4complex types passed to mathe 88 In case of G4complex types passed to mathematical functions, use G4std:: prefix.
260 o Fixed usage of G4Integrator class, now cha 89 o Fixed usage of G4Integrator class, now changed to templated to allow porting of the
261 code on SUN-CC compiler which does not imp 90 code on SUN-CC compiler which does not implement templated member functions.
262 Affected files: G4VXrayTRmodel[.hh.cc] 91 Affected files: G4VXrayTRmodel[.hh.cc]
263 92
264 Jun 6, 2000 M. Verderi & P. Mora de Freitas 93 Jun 6, 2000 M. Verderi & P. Mora de Freitas
265 - fixed compilation errors with HP-aCC for the 94 - fixed compilation errors with HP-aCC for the files G4RegularXrayTRmodel.cc,
266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod 95 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmodel.cc.
267 96
268 May 30, 2000 M. Verderi & P. Mora de Freitas 97 May 30, 2000 M. Verderi & P. Mora de Freitas
269 98
270 - parameterisation category is now RW free. 99 - parameterisation category is now RW free.
271 100
272 September 16, 1999 M. Verderi & P. Mora de Fre 101 September 16, 1999 M. Verderi & P. Mora de Freitas
273 102
274 - Fixed bug in G4FastStep::CheckIt() method. 103 - Fixed bug in G4FastStep::CheckIt() method.
275 104
276 April 19, 1999 M. Verderi & P. Mora de Freitas 105 April 19, 1999 M. Verderi & P. Mora de Freitas
277 106
278 Changes in G4FastStep to co-work with track-01 107 Changes in G4FastStep to co-work with track-01-00-04:
279 108
280 1) The method void CheckIt(const G4Track&) bec << 109 1) The method void CheckIt(const G4Track&) becomes
281 G4bool CheckIt(const G4Track&); 110 G4bool CheckIt(const G4Track&);
282 2) The FAST_STEP_DEBUG compiling option disapp 111 2) The FAST_STEP_DEBUG compiling option disappears;
283 3) Call to CheckIt controled by the G4VParticl 112 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute.
284 113
285 Miscellaneous: the declaration "G4double mass 114 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh
286 corrected to G4double mass =...". 115 corrected to G4double mass =...".
287 116
288 April 15, 1999 M. Verderi & P. Mora de Freitas 117 April 15, 1999 M. Verderi & P. Mora de Freitas
289 118
290 Tasks to decouple visualization from processes 119 Tasks to decouple visualization from processes/parameterisation:
291 120
292 1) G4GlobalFastSimulationManager now inherites 121 1) G4GlobalFastSimulationManager now inherites from the intercoms/
293 G4VGlobalFastSimulationManager to allow visual << 122 G4VGlobalFastSimulationManager to allow visualisation to get a
294 concrete instance pointer to the G4GlobalFastS 123 concrete instance pointer to the G4GlobalFastSimulationManager,
295 if any. 124 if any.
296 125
297 2) G4FlavoredParallelWorld now inherites from 126 2) G4FlavoredParallelWorld now inherites from the intercoms/
298 G4VFlavoredParallelWorld, a pure virtual abstr 127 G4VFlavoredParallelWorld, a pure virtual abstract class to interface
299 parameterisation with visualization. 128 parameterisation with visualization.
300 129
301 Co-works with intercoms-01-00-01 tag 130 Co-works with intercoms-01-00-01 tag
302 131
303 Modified files: 132 Modified files:
304 --------------- 133 ---------------
305 G4FlavoredParallelWorld.hh 134 G4FlavoredParallelWorld.hh
306 G4GlobalFastSimulationManager.hh 135 G4GlobalFastSimulationManager.hh
307 G4GlobalFastSimulationManager.cc 136 G4GlobalFastSimulationManager.cc
308 137
309 Done, tested, system-tested on HP-aCC with exe 138 Done, tested, system-tested on HP-aCC with exemple N05.
310 139
311 April 14, 1999 M. Verderi & P. Mora de Freitas 140 April 14, 1999 M. Verderi & P. Mora de Freitas
312 141
313 Several consolidation tasks (thanks to G. Cosm 142 Several consolidation tasks (thanks to G. Cosmo):
314 143
315 1) Warning: << 144 1) Warning:
316 ----------- 145 -----------
317 146
318 Pointers usage 147 Pointers usage
319 148
320 - Setting pointers to 0 after delete: 149 - Setting pointers to 0 after delete:
321 150
322 delete pA; 151 delete pA;
323 pA = 0; 152 pA = 0;
324 153
325 - Avoid to use "NULL". 154 - Avoid to use "NULL".
326 155
327 Modified files: 156 Modified files:
328 --------------- 157 ---------------
329 G4FastSimulationManager.hh 158 G4FastSimulationManager.hh
330 G4FastTrack.hh 159 G4FastTrack.hh
331 G4FlavoredParallelWorld.hh 160 G4FlavoredParallelWorld.hh
332 G4FastSimulationManager.cc 161 G4FastSimulationManager.cc
333 G4FastSimulationMessenger.cc 162 G4FastSimulationMessenger.cc
334 G4FastSimulationManagerProcess.cc 163 G4FastSimulationManagerProcess.cc
335 G4FastTrack.cc 164 G4FastTrack.cc
336 G4GlobalFastSimulationManager.cc 165 G4GlobalFastSimulationManager.cc
337 G4VFastSimulationModel.cc 166 G4VFastSimulationModel.cc
338 167
339 Status: << 168 Status:
340 ------- 169 -------
341 Done, tested, system-tested on HP-aCC with exe 170 Done, tested, system-tested on HP-aCC with exemple N05.
342 171
343 2) Warning: 172 2) Warning:
344 ----------- 173 -----------
345 include/G4FastSimulationManager.hh:163 174 include/G4FastSimulationManager.hh:163
346 Public member functions shall always retur 175 Public member functions shall always return const handles to member data
347 Severe violation: Universal Coding Standar 176 Severe violation: Universal Coding Standards item 18
348 177
349 offending code: 178 offending code:
350 --------------- 179 ---------------
351 inline G4VParticleChange* G4FastSimulationMana 180 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange()
352 { 181 {
353 return &fFastStep; 182 return &fFastStep;
354 } 183 }
355 184
356 Diagnostic: 185 Diagnostic:
357 ---------- 186 ----------
358 187
359 Called by the G4FastSimulationManagerProcess << 188 Called by the G4FastSimulationManagerProcess to return it in the
360 PostStepDoIt call. << 189 PostStepDoIt call.
361 190
362 Action: 191 Action:
363 ------- 192 -------
364 The G4FastSimulationManager::GettheParticleCha 193 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any
365 more. The G4VParticleChange* is now returned d 194 more. The G4VParticleChange* is now returned directly when invoking the
366 G4FastSimulationManager::InvokePostStepDoIt() 195 G4FastSimulationManager::InvokePostStepDoIt() and
367 G4FastSimulationManager::InvokeAtRestDoIt() me 196 G4FastSimulationManager::InvokeAtRestDoIt() methodes.
368 197
369 Modified files: 198 Modified files:
370 --------------- 199 ---------------
371 G4FastSimulationManager.hh 200 G4FastSimulationManager.hh
372 G4FastSimulationManager.cc 201 G4FastSimulationManager.cc
373 G4FastSimulationManagerProcess.cc 202 G4FastSimulationManagerProcess.cc
374 203
375 Status: << 204 Status:
376 ------- 205 -------
377 Done, tested, system-tested on HP-aCC with exe 206 Done, tested, system-tested on HP-aCC with exemple N05.
378 207
379 3) Warning: 208 3) Warning:
380 ----------- 209 -----------
381 include/G4FastSimulationManagerProcess.hh:52 210 include/G4FastSimulationManagerProcess.hh:52
382 If a class has virtual functions it shall 211 If a class has virtual functions it shall have a virtual destructor
383 Severe violation: Universal Coding Standar 212 Severe violation: Universal Coding Standards item 17
384 class G4FastSimulationManagerProcess has v 213 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor.
385 214
386 offending code: 215 offending code:
387 --------------- 216 ---------------
388 ~G4FastSimulationManagerProcess(); 217 ~G4FastSimulationManagerProcess();
389 218
390 Diagnostic: 219 Diagnostic:
391 ---------- 220 ----------
392 Nobody should inherites from G4FastSimulatio << 221 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual
393 is added. 222 is added.
394 223
395 Action: 224 Action:
396 ------- 225 -------
397 virtual ~G4FastSimulationManagerProcess(); 226 virtual ~G4FastSimulationManagerProcess();
398 227
399 Modified files: 228 Modified files:
400 --------------- 229 ---------------
401 G4FastSimulationManagerProcess.hh 230 G4FastSimulationManagerProcess.hh
402 231
403 Status: << 232 Status:
404 ------- 233 -------
405 Done. 234 Done.
406 235
407 4) Warning: 236 4) Warning:
408 ----------- 237 -----------
409 include/G4FastSimulationMessenger.hh:36 238 include/G4FastSimulationMessenger.hh:36
410 If a class has virtual functions it shall 239 If a class has virtual functions it shall have a virtual destructor
411 Severe violation: Universal Coding Standar 240 Severe violation: Universal Coding Standards item 17
412 class G4FastSimulationMessenger has virtua 241 class G4FastSimulationMessenger has virtual functions without a virtual destructor.
413 242
414 243
415 offending code: 244 offending code:
416 --------------- 245 ---------------
417 ~G4FastSimulationMessenger(); 246 ~G4FastSimulationMessenger();
418 247
419 Diagnostic: 248 Diagnostic:
420 ---------- 249 ----------
421 Nobody should inherites from G4FastSimulatio << 250 Nobody should inherites from G4FastSimulationMessenger BUT for virtual
422 is added. 251 is added.
423 252
424 Action: 253 Action:
425 ------- 254 -------
426 virtual ~G4FastSimulationMessenger(); 255 virtual ~G4FastSimulationMessenger();
427 256
428 Modified files: 257 Modified files:
429 --------------- 258 ---------------
430 G4FastSimulationMessenger.hh 259 G4FastSimulationMessenger.hh
431 260
432 Status: << 261 Status:
433 ------- 262 -------
434 Done. 263 Done.
435 264
436 5) Warning: 265 5) Warning:
437 ----------- 266 -----------
438 include/G4FastStep.hh:224 267 include/G4FastStep.hh:224
439 Operator= should call base class operator= 268 Operator= should call base class operator=
440 Possible severe violation: Effective C++ i 269 Possible severe violation: Effective C++ item 16
441 operator= in class G4FastStep, should call 270 operator= in class G4FastStep, should call operator= in base class G4VParticleChange
442 271
443 offending code: 272 offending code:
444 --------------- 273 ---------------
445 G4FastStep & G4FastStep::operator=(const G4Fas 274 G4FastStep & G4FastStep::operator=(const G4FastStep &right)
446 { 275 {
447 if (this != &right) 276 if (this != &right)
448 { 277 {
449 theListOfSecondaries = right.th 278 theListOfSecondaries = right.theListOfSecondaries;
450 theSizeOftheListOfSecondaries = right.th 279 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries;
451 theNumberOfSecondaries = right.th 280 theNumberOfSecondaries = right.theNumberOfSecondaries;
452 theStatusChange = right.th 281 theStatusChange = right.theStatusChange;
453 theMomentumChange = right.th 282 theMomentumChange = right.theMomentumChange;
454 thePolarizationChange = right.th 283 thePolarizationChange = right.thePolarizationChange;
455 thePositionChange = right.th 284 thePositionChange = right.thePositionChange;
456 theTimeChange = right.th 285 theTimeChange = right.theTimeChange;
457 theEnergyChange = right.th 286 theEnergyChange = right.theEnergyChange;
458 theTrueStepLength = right.th 287 theTrueStepLength = right.theTrueStepLength;
459 theLocalEnergyDeposit = right.th 288 theLocalEnergyDeposit = right.theLocalEnergyDeposit;
460 theSteppingControlFlag = right.th 289 theSteppingControlFlag = right.theSteppingControlFlag;
461 theWeightChange = right.th 290 theWeightChange = right.theWeightChange;
462 } 291 }
463 return *this; 292 return *this;
464 } 293 }
465 294
466 Diagnostic: 295 Diagnostic:
467 ---------- 296 ----------
468 Bug detected. 297 Bug detected.
469 298
470 Action: 299 Action:
471 ------- 300 -------
472 Insert the call 301 Insert the call
473 G4VParticleChange::operator=(right); 302 G4VParticleChange::operator=(right);
474 303
475 Status: 304 Status:
476 ------- 305 -------
477 Done, tested, system-tested on HP-aCC with e 306 Done, tested, system-tested on HP-aCC with exemple N05.
478 307
479 Modified files: 308 Modified files:
480 --------------- 309 ---------------
481 G4FastStep.cc 310 G4FastStep.cc
482 311
483 6) Warning: 312 6) Warning:
484 ----------- 313 -----------
485 include/G4FastStep.hh:59 314 include/G4FastStep.hh:59
486 Avoid data members in the public interface 315 Avoid data members in the public interface
487 Violation: Effective C++ item 20 316 Violation: Effective C++ item 20
488 Public data members for class G4FastStep: 317 Public data members for class G4FastStep:
489 debugFlag 318 debugFlag
490 319
491 320
492 offending code: 321 offending code:
493 --------------- 322 ---------------
494 public: 323 public:
495 ... 324 ...
496 G4bool debugFlag; 325 G4bool debugFlag;
497 326
498 Diagnostic: 327 Diagnostic:
499 ---------- 328 ----------
500 Historical usage. 329 Historical usage.
501 330
502 Action: 331 Action:
503 ------- 332 -------
504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 333 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file.
505 334
506 Modified files: 335 Modified files:
507 --------------- 336 ---------------
508 G4FastStep.hh, G4FastStep.cc 337 G4FastStep.hh, G4FastStep.cc
509 338
510 Status: 339 Status:
511 ------- 340 -------
512 Done, tested, system-tested on HP-aCC with e 341 Done, tested, system-tested on HP-aCC with exemple N05.
513 342
514 7) Warning: 343 7) Warning:
515 ----------- 344 -----------
516 include/G4FastStep.hh:59 345 include/G4FastStep.hh:59
517 If a class has virtual functions it shall 346 If a class has virtual functions it shall have a virtual destructor
518 Severe violation: Universal Coding Standar 347 Severe violation: Universal Coding Standards item 17
519 class G4FastStep has virtual functions wit 348 class G4FastStep has virtual functions without a virtual destructor.
520 349
521 350
522 offending code: 351 offending code:
523 --------------- 352 ---------------
524 ~G4FastStep(); 353 ~G4FastStep();
525 354
526 Diagnostic: 355 Diagnostic:
527 ---------- 356 ----------
528 Nobody should inherites from G4FastStep BUT 357 Nobody should inherites from G4FastStep BUT virtual added.
529 358
530 Action: 359 Action:
531 ------- 360 -------
532 virtual ~G4FastStep(); 361 virtual ~G4FastStep();
533 362
534 Modified files: 363 Modified files:
535 --------------- 364 ---------------
536 G4FastStep.hh 365 G4FastStep.hh
537 366
538 Status: 367 Status:
539 ------- 368 -------
540 Done, tested, system-tested on HP-aCC with e 369 Done, tested, system-tested on HP-aCC with exemple N05.
541 370
542 371
543 December 7, 1998 M. Verderi 372 December 7, 1998 M. Verderi
544 G4FastSimulationManagerProcess class: 373 G4FastSimulationManagerProcess class:
545 Fixes made for ghost navigation with 374 Fixes made for ghost navigation with
546 mag-field: 375 mag-field:
547 LocateGlobalPointAndUpdateTouchable is 376 LocateGlobalPointAndUpdateTouchable is
548 always used (in not the Locate...Setup 377 always used (in not the Locate...Setup
549 method) 378 method)
550 In PostStepDoIt: correction of position and 379 In PostStepDoIt: correction of position and
551 direction of the track are made when << 380 direction of the track are made when
552 possible in case of mag-field. 381 possible in case of mag-field.
553 This correction comes from the fact that a 382 This correction comes from the fact that a
554 small discrepancy appears on those quantitie 383 small discrepancy appears on those quantities
555 because of the numerical integration along 384 because of the numerical integration along
556 the field on the track path: the G4FSMP 385 the field on the track path: the G4FSMP
557 proposes a curve-length, the transportation 386 proposes a curve-length, the transportation
558 moves the track along this curve, however 387 moves the track along this curve, however
559 the end point position and direction are 388 the end point position and direction are
560 slightly different from those expected by 389 slightly different from those expected by
561 the G4FSMP when it proposed the length. 390 the G4FSMP when it proposed the length.
562 391
563 November 20,1998 M. Verderi 392 November 20,1998 M. Verderi
564 G4FastStep class: 393 G4FastStep class:
565 Remove track/G4BiasingTag.hh dependancy (ob 394 Remove track/G4BiasingTag.hh dependancy (obsolete).
566 Adapted to new shceme of Event Biasing mech 395 Adapted to new shceme of Event Biasing mechanism,
567 consistently with track-00-04-01 tag. 396 consistently with track-00-04-01 tag.
568 397
569 November 11,1998 M. Verderi 398 November 11,1998 M. Verderi
570 Merge of param-00-03-02 & param-00-03-02a i 399 Merge of param-00-03-02 & param-00-03-02a into
571 param-00-03-04a (hopefully...) 400 param-00-03-04a (hopefully...)
572 The point is the chnage of signature in the 401 The point is the chnage of signature in the
573 LocateGlobalPointAndSetup(..) of the G4Navi 402 LocateGlobalPointAndSetup(..) of the G4Navigator making use now
574 of the track direction. The G4FastSimulatio 403 of the track direction. The G4FastSimulationManagerProcess is
575 changed accordingly: 404 changed accordingly:
576 fGhostNavigator.LocateGlobalPointAndSetup(t 405 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true);
577 406
578 407
579 November 6, 1998 M. Verderi 408 November 6, 1998 M. Verderi
580 - Extension of the G4FastStep to allow the 409 - Extension of the G4FastStep to allow the biasing technic.
581 Changes are made in: 410 Changes are made in:
582 - G4FastStep.hh/.icc: 411 - G4FastStep.hh/.icc:
583 new member G4BiasingTa 412 new member G4BiasingTag fBiasTag;
584 new method SetPrimaryT 413 new method SetPrimaryTrackFinalBiasingTag
585 ( G4BiasingTag 414 ( G4BiasingTag aTag );
586 - G4FastStep.cc: 415 - G4FastStep.cc:
587 Initialize(); 416 Initialize();
588 operator=; << 417 operator=;
589 UpdateForPostStep(); 418 UpdateForPostStep();
590 UpdateForAtRest(); << 419 UpdateForAtRest();
591 420
592 October 26, 1998 P.Mora de Freitas 421 October 26, 1998 P.Mora de Freitas
593 - G4FastSimulationManagerProcess and G4Fast 422 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal
594 with at rest parameterisations also when 423 with at rest parameterisations also when using parallel geometry.
595 424
596 October 8, 1998 P.Mora de Freitas 425 October 8, 1998 P.Mora de Freitas
597 - The G4VFastSimulationModel::IsApplicable( 426 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual
598 methode. 427 methode.
599 - G4FastSimulationManager optimisation: 428 - G4FastSimulationManager optimisation:
600 - New G4ParticleDefinition* fLastCrossedP 429 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps
601 the last particle type with touched the 430 the last particle type with touched the envelope;
602 - New G4RWTPtrOrderedVector<G4VFastSimula 431 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList
603 data member, keeps the model list of th << 432 data member, keeps the model list of the applicable models for
604 the actual fLastCrossedParticle particl 433 the actual fLastCrossedParticle particle type;
605 - Changes in the PostStepGetFastSimulatio << 434 - Changes in the PostStepGetFastSimulationManagerTrigger() and
606 AtRestGetFastSimulationManagerTrigger() << 435 AtRestGetFastSimulationManagerTrigger()methodes to update the
607 fApplicableModelList when needed (fLast 436 fApplicableModelList when needed (fLastCrossedParticle !=
608 the actual tracked particle); 437 the actual tracked particle);
609 - Changes in the << 438 - Changes in the
610 G4FastSimulationManager() (Constructor) 439 G4FastSimulationManager() (Constructor)
611 ActivateFastSimulationModel(), 440 ActivateFastSimulationModel(),
612 InActivateFastSimulationModel(), 441 InActivateFastSimulationModel(),
613 AtRestGetFastSimulationManagerTrigger(), 442 AtRestGetFastSimulationManagerTrigger(),
614 AddFastSimulationModel(), 443 AddFastSimulationModel(),
615 RemoveFastSimulationModel() 444 RemoveFastSimulationModel()
616 methodes to set the fLastCrossedParticle to 445 methodes to set the fLastCrossedParticle to NULL, forcing the
617 fApplicableModelList to be rebuilt. 446 fApplicableModelList to be rebuilt.
618 447
619 September 22, 1998 P.Mora de Freitas 448 September 22, 1998 P.Mora de Freitas
620 Fixed bug in parallel navigation. << 449 Fixed bug in parallel navigation.
621 File touched: G4FastSimulationManagerProces 450 File touched: G4FastSimulationManagerProcess.cc
622 Tested on HP-aCC. 451 Tested on HP-aCC.
623 452
624 September 17, 1998 P.Mora de Freitas 453 September 17, 1998 P.Mora de Freitas
625 G4FastSimulationManager::RemoveFastSimulati 454 G4FastSimulationManager::RemoveFastSimulationModel() updated to look
626 for also in the fInactivatedModels list. 455 for also in the fInactivatedModels list.
627 456
628 Tested on HP-aCC. 457 Tested on HP-aCC.
629 458
630 September 16, 1998 P.Mora de Freitas 459 September 16, 1998 P.Mora de Freitas
631 New /param/ control commands: 460 New /param/ control commands:
632 461
633 /param/ActivateModel <ModelName> 462 /param/ActivateModel <ModelName>
634 /param/InActivateModel <ModelName> 463 /param/InActivateModel <ModelName>
635 464
636 Activate or inactivate a given parameterisat 465 Activate or inactivate a given parameterisation model.
637 466
638 Tested on HP-aCC. 467 Tested on HP-aCC.
639 468
640 August 21, 1998 P.Mora de Freitas 469 August 21, 1998 P.Mora de Freitas
641 G4FastSimulationManagerProcess's G4ProcessTy 470 G4FastSimulationManagerProcess's G4ProcessType set to
642 fParameterisation, accordingly with procman-00 471 fParameterisation, accordingly with procman-00-02-03.
643 472
644 Tested on HP-aCC. 473 Tested on HP-aCC.
645 474
646 August 12, 1998 P.Mora de Freitas 475 August 12, 1998 P.Mora de Freitas
647 Improved the "close parameterisation control << 476 Improved the "close parameterisation control" to
648 477
649 1) avoid the close looping when unnecessary 478 1) avoid the close looping when unnecessary (mostly cases);
650 2) force re-close when necessary (insert/rem 479 2) force re-close when necessary (insert/remove ghosts).
651 480
652 Changes: 481 Changes:
653 482
654 1) the G4GlobalFastSimulationManager::fClose << 483 1) the G4GlobalFastSimulationManager::fClosed is now initialised
655 to true by the G4GlobalFastSimulationMana 484 to true by the G4GlobalFastSimulationManager constructor;
656 485
657 2) new method << 486 2) new method
658 487
659 void << 488 void
660 G4GlobalFastSimulationManager::FastSimula 489 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed();
661 490
662 called by the AddGhostPlacement and Remov << 491 called by the AddGhostPlacement and RemoveGhostPlacement
663 G4FastSimulationManager methods to set fa 492 G4FastSimulationManager methods to set false the fClosed flag;
664 493
665 3) changes in the G4GlobalFastSimulationMana 494 3) changes in the G4GlobalFastSimulationManager::Notify method
666 to deal with these changes. 495 to deal with these changes.
667 496
668 Tested on HP-aCC. 497 Tested on HP-aCC.
669 498
670 August 11, 1998 P.Mora de Freitas 499 August 11, 1998 P.Mora de Freitas
671 Fix to the G4FastStep::KillPrimaryTrack() me 500 Fix to the G4FastStep::KillPrimaryTrack() method to drop the
672 nonsense line 501 nonsense line
673 502
674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 503 SetMomentumChange(0.,0.,0.) ; /* necessary ? */
675 504
676 Tested on HP-aCC. 505 Tested on HP-aCC.
677 (Thanks to Willy Langeveld) 506 (Thanks to Willy Langeveld)
678 507
679 508
680 August 10, 1998 P.Mora de Freitas 509 August 10, 1998 P.Mora de Freitas
681 Fix to the SetPrimaryTrackFinalKineticEnergy 510 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method
682 from the G4FastStep class the SetMomentumChang 511 from the G4FastStep class the SetMomentumChange() call to insure that
683 the new momentum direction is a unit vector (a << 512 the new momentum direction is a unit vector (as asked by the
684 G4DynamicParticle::SetMomentumDirection method 513 G4DynamicParticle::SetMomentumDirection method).
685 514
686 Touched files: G4FastStep.hh (improved comme 515 Touched files: G4FastStep.hh (improved comments)
687 G4FastStep.cc (fixed) 516 G4FastStep.cc (fixed)
688 517
689 Tested on HP-aCC. 518 Tested on HP-aCC.
690 (Thanks to Willy Langeveld) 519 (Thanks to Willy Langeveld)
691 520
692 August 7, 1998 P.Mora de Freitas 521 August 7, 1998 P.Mora de Freitas
693 New /param/ commands directory with the comm 522 New /param/ commands directory with the commands:
694 523
695 /param/listEnvelopes [ParticleName] 524 /param/listEnvelopes [ParticleName]
696 525
697 - List all the envelope names for a given pa 526 - List all the envelope names for a given particle
698 (or for all particles if without parameter 527 (or for all particles if without parameters).
699 528
700 /param/listModels [EnvelopeName] 529 /param/listModels [EnvelopeName]
701 530
702 - List all the Model names for a given envel 531 - List all the Model names for a given envelope
703 (or for all envelopes if without parameter 532 (or for all envelopes if without parameters).
704 533
705 /param/listIsApplicable [ModelName] 534 /param/listIsApplicable [ModelName]
706 535
707 - List all the particle names a given model 536 - List all the particle names a given model is applicable
708 (or for all models if without parameters). 537 (or for all models if without parameters).
709 538
710 539
711 August 7, 1998 P.Mora de Freitas 540 August 7, 1998 P.Mora de Freitas
712 History file Created. 541 History file Created.