| Geant4 Cross Reference |
1 # Category param History << 1 $Id: History,v 1.17 2003/05/21 16:32:35 gcosmo Exp $
>> 2 -------------------------------------------------------------------
2 3
3 See `CONTRIBUTING.rst` for details of **requir << 4 =========================================================
4 which **must** added in reverse chronological << 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP
5 It must **not** be used as a substitute for wr << 6 =========================================================
6 << 7
7 ---------------------------------------------- << 8 Category History file
8 << 9 ---------------------
9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) << 10 This file should be used by G4 developers and category coordinators
10 - In G4GlobalFastSimulationManager: << 11 to briefly summarize all major modifications introduced in the code
11 use G4ThreadLocalSingleton to avoid undelete << 12 and keep track of all category-tags.
12 << 13 It DOES NOT substitute the CVS log-message one should put at every
13 ## 2023-10-18 Ben Morgan (param-V11-01-03) << 14 committal in the CVS repository !
14 - Apply standard and extended clang-tidy fixes << 15
15 - Mark empty/obsolete functions as deprecated << 16 ----------------------------------------------------------
16 << 17 * Reverse chronological order (last date on top), please *
17 ## 2023-10-16 Ben Morgan (param-V11-01-02) << 18 ----------------------------------------------------------
18 - Apply standard clang-format-ing. <<
19 - Normal order accessors and docstrings. <<
20 <<
21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) <<
22 - In G4FastTrack, removed references to G4Touc <<
23 which is now deprecated. <<
24 <<
25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 <<
26 - Added missing virtual destructor to G4VFastS <<
27 <<
28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) <<
29 - Fixed compilation warnings for implicit type <<
30 <<
31 ## 2022-10-27 Makoto Asai (param-V11-00-03) <<
32 - G4FastSimHitMaker - making compatible to com <<
33 <<
34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 <<
35 - G4FastStep - delete copy constructor and ope <<
36 <<
37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) <<
38 - Adding the 'flush' method to the fast simula <<
39 This method allows to process the input buff <<
40 the end of the G4 event. It is used when par <<
41 The 'flash' is triggered inside the event lo <<
42 The fast simulation model may add secondarie <<
43 by Geant4. <<
44 <<
45 ## 2021-12-10 Ben Morgan (param-V11-00-00) <<
46 - Change to new Markdown History format <<
47 <<
48 --- <<
49 <<
50 # History entries prior to 11.0 <<
51 <<
52 April 16, 2021 Ben Morgan (param-V10-07-00) <<
53 - Migrate build to modular CMake API <<
54 <<
55 October 5, 2020, A. Zaborowska (param-V10-06-0 <<
56 - Introduce general facilities based on GFlash <<
57 to facilitate multiple hit (energy & positio <<
58 from fast simulation models. <<
59 <<
60 September 9, 2020, G. Cosmo (param-V10-06-02) <<
61 - Fixed minor Coverity defect for uninitialise <<
62 <<
63 April 21, 2020, A. Zaborowska (param-V10-06-01 <<
64 - Sanity check for root logical volumes for re <<
65 UI command /param/showSetup works also if no <<
66 <<
67 March 26, 2020, I. Semeniouk (param-V10-06-00) <<
68 - G4FastSimulationHelper : merge ActivateFastS <<
69 - G4FastSimulationManager.hh, G4VFastSimulatio <<
70 redefinition of G4Envelope type <<
71 <<
72 October 30, 2019, A. Zaborowska (param-v10-05- <<
73 - Register G4FastSimulationManagerProcess with <<
74 G4FastSimulationManagerHelper to ensure it i <<
75 invoked for a given step (ExclusivelyForced) <<
76 StronglyForced processes will be considered. <<
77 <<
78 December 19, 2017, G. Cosmo (param-V10-04-00) <<
79 - Fixed self-consistency in G4FastSimulationVe <<
80 Thanks to Raphael Isemann for reporting this <<
81 <<
82 November 03, 2016, M. Verderi (param-V10-02-01 <<
83 - New G4FastSimulationManagerHelper utility fo <<
84 adding G4FastSimulationManagerProcess to a <<
85 process manager. <<
86 <<
87 November 02, 2016, M. Verderi (param-V10-02-00 <<
88 - fix various Coverity defects. <<
89 <<
90 March 27, 2013, M. Verderi (param-V09-06-00) <<
91 - remove unused field 'fOnBoundary' in G4FastS <<
92 as this was causing a warning from clang. <<
93 <<
94 July 10, 2012, G. Cosmo (param-V09-05-00) <<
95 - Explicitly use inclusion of headers for syst <<
96 constants, in plan to remove implicit inclus <<
97 <<
98 September 30, 2011, M. Verderi (param-V09-04-0 <<
99 - Added missing new header file (G4FastSimulat <<
100 sources.cmake. <<
101 <<
102 September 30, 2011, M. Verderi (param-V09-04-0 <<
103 - Migration to new G4Exception scheme. <<
104 - what is V09-04-01 tag ? <<
105 <<
106 February 11, 2011, M. Verderi (param-V09-04-00 <<
107 - Implementation of method <<
108 void ProposePrimaryTrackFinalKineticEnergy ( <<
109 was missing : modified file G4FastStep.icc <<
110 <<
111 March 13, 2008, G. Cosmo (param-V09-01-00) <<
112 - Cleared compilation warnings in G4FastSimula <<
113 G4FastSimulationMessenger on gcc-4.3.0 for a <<
114 parentheses in nested if-else statements. <<
115 <<
116 November 30, 2007, M. Verderi <<
117 - Add Along methods to G4FSMP process <<
118 - tag as param-V09-00-01 <<
119 <<
120 November 30, 2007, M. Verderi <<
121 - minor corrections to G4FastSimulationManager <<
122 * add call fPathFinder->prepareNewrack(...) <<
123 * deactivate ghost navigator in EndOfTracki <<
124 - tag as param-V09-00-00 <<
125 <<
126 May 18, 2007, M. Verderi <<
127 - tag as param-V08-03-00 <<
128 <<
129 May 11, 2007, M. Verderi <<
130 - remove include/G4FastSimulationManagerProces <<
131 include/G4FlavoredParallelWorld.hh <<
132 include/G4GFSManager81.hh <<
133 src/G4FastSimulationManagerProcess81. <<
134 src/G4GFSManager81.cc <<
135 <<
136 <<
137 November 10, 2006, M. Verderi - param-V08-01-0 <<
138 - Limited number of warning messages printed b <<
139 G4GlobalFastSimulationManager. <<
140 - Renamed G4FastSimulationManagerProcess_forCo <<
141 G4FastSimulationManagerProcess81. <<
142 In addition, this class can now handle the c <<
143 i.e., the navigator for tracking, regardless <<
144 G4CoupledTransportation is used. (For other <<
145 of course no choice, and G4CoupledTransporta <<
146 <<
147 November 3, 2006 M. Verderi <<
148 - Introduced G4FastSimulationManagerProcess_fo <<
149 handling fast simulation in new parallel geo <<
150 the G4CoupledTransportation to be active. <<
151 - Introduced G4GFSManager81 class that gathers <<
152 default at next major release in the G4Globa <<
153 - G4FastSimulationManager: adapted to new sche <<
154 backward compatibilty. <<
155 - G4FastSimulationManagerProcess: mostly the s <<
156 - G4FastSimulationMessenger: new command creat <<
157 to show the fast simulation setup (region, m <<
158 It is only valid for geometry closed state. <<
159 command in the run manager for this. <<
160 <<
161 November 25, 2005, M.Verderi - param-V07-01-0 <<
162 - put back Makoto's change: StartTracking(G4Tr <<
163 <<
164 November 25, 2005, M Verderi - param-V07-01-03 <<
165 - Make ghost functionnality available with G4R <<
166 - ** Note ** Change back StartTracking(G4Track <<
167 StartTracking(G4Track*) was intro <<
168 because (I guess) of procman-V07-01-01 <<
169 This is to make param-V07-01-03 compatible w <<
170 <<
171 November 21, 2005 M.Asai - param-V07-01-02 <<
172 - Fix warning message. <<
173 <<
174 November 02, 2005 G.Cosmo - param-V07-01-01 <<
175 - Corrected setting of envelope volumes and so <<
176 - Migrated old scheme for G4Exception and some <<
177 <<
178 October 28, 2005 M.Asai - param-V07-01-00 <<
179 - Working tag for merging "envelope" to G4Regi <<
180 <<
181 December 07, 2004 G. Cosmo - param-V06-02-01 <<
182 - Implemented migration to <cmath>. <<
183 <<
184 November 26, 2004 M. Verderi - param-V06-02-00 <<
185 - Implemented migration to new G4VParticleChan <<
186 <<
187 December 12, 2003 G. Cosmo - param-V06-00-00 <<
188 - G4FastSimulationVector.icc: use std_pvector: <<
189 base class. Fixes compilation problem on Int <<
190 <<
191 November 10, 2003 G. Cosmo - param-V05-02-01 <<
192 - G4FastTrack: use G4Navigator::CreateTouchabl <<
193 CreateTouchableHistory() in method FRecordsA <<
194 <<
195 October 4, 2003 G. Cosmo - param-V05-02-00 <<
196 - Modified GNUmakefile: <<
197 o added dependency to new module "geometry/n <<
198 - Coworks with "geometry-V05-02-00" and "digit <<
199 19
200 May 21, 2003 G. Cosmo - param-V05-01-00 20 May 21, 2003 G. Cosmo - param-V05-01-00
201 o Fixed pedantic warnings on Linux-g++ 21 o Fixed pedantic warnings on Linux-g++.
202 o Call base class in copy-constructor 22 o Call base class in copy-constructor of G4FastStep.
203 23
204 Nov 20, 2002 G. Cosmo - param-V04-01-02 24 Nov 20, 2002 G. Cosmo - param-V04-01-02
205 o Patched access to public static data in G4 25 o Patched access to public static data in G4FastStep.cc
206 and G4GlobalFastSimulationManager.cc to al 26 and G4GlobalFastSimulationManager.cc to allow porting on
207 Windows DLLs. 27 Windows DLLs.
208 28
209 Nov 15, 2002 S. Sadilov - param-V04-01-01 29 Nov 15, 2002 S. Sadilov - param-V04-01-01
210 o Fixed compilation problems on Windows in 30 o Fixed compilation problems on Windows in
211 G4FastSimulationManager.cc and G4GlobalFas 31 G4FastSimulationManager.cc and G4GlobalFastSimulationManager.cc
212 32
213 Nov 02, 2002 M. Verderi - param-V04-01-00 33 Nov 02, 2002 M. Verderi - param-V04-01-00
214 o Add method to retrieve G4VFastSimulationMo 34 o Add method to retrieve G4VFastSimulationModel by name.
215 The user's method is in G4GlobalFastSimula 35 The user's method is in G4GlobalFastSimulationManager:
216 36
217 GetFastSimulationModel(); 37 GetFastSimulationModel();
218 38
219 it is accompagnied by same methods name in 39 it is accompagnied by same methods name in
220 G4FastSimulationManager class. 40 G4FastSimulationManager class.
221 41
222 o Add "test" directory, used to test above f 42 o Add "test" directory, used to test above feature.
223 43
224 Oct 26, 2001 M. Verderi - param-V03-02-00 44 Oct 26, 2001 M. Verderi - param-V03-02-00
225 Fixes to clear warnings produced with gcc-2. 45 Fixes to clear warnings produced with gcc-2.95.2:
226 - loop index, where comparison with method " 46 - loop index, where comparison with method "size()" of
227 G4std::vector<T>, changed: int -> size_t << 47 G4std::vector<T>, changed: int -> size_t
228 - change "if ( a=b ) {..}" by "if ( (a=b) ) 48 - change "if ( a=b ) {..}" by "if ( (a=b) ) {...}"
229 this makes the compiler sure you want to mak 49 this makes the compiler sure you want to make an
230 assignement in the "if" condition 50 assignement in the "if" condition
231 - re-order initialisations of a few variable 51 - re-order initialisations of a few variables in constructors
232 to match the declaration order. 52 to match the declaration order.
233 Some warnings still exist, but regard the G4 53 Some warnings still exist, but regard the G4Propagator of geometry.
234 54
235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 55 Apr 3, 2001 J. Apostolakis - param-V03-00-00
236 - Modified G4FastSimulationManagerProcess call 56 - Modified G4FastSimulationManagerProcess call to PropagatorInField ComputeStep
237 to use new interface with G4FieldTrack (in 57 to use new interface with G4FieldTrack (in place of now obsolete interface.)
238 58
239 Nov 14, 2000 G. Cosmo - param-V02-00-01 59 Nov 14, 2000 G. Cosmo - param-V02-00-01
240 - Moved specific parameterisation models to th 60 - Moved specific parameterisation models to the new top category
241 "parameterisations". Moved files: 61 "parameterisations". Moved files:
242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm 62 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRmodel[.hh.cc],
243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster 63 G4IrregularXrayTRmodel[.hh.cc], G4PAIclusterModel[.hh.cc],
244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr 64 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXrayTRmodel[.hh.cc],
245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode 65 G4RegularXrayTRmodel[.hh.cc], G4VClusterModel[.hh.cc],
246 G4VXrayTRmodel[.hh.cc]. 66 G4VXrayTRmodel[.hh.cc].
247 - Cleaned-up GNUmakefile of non necessary depe 67 - Cleaned-up GNUmakefile of non necessary dependencies.
248 68
249 Aug 03, 2000 G. Cosmo - param-V02-00-00r 69 Aug 03, 2000 G. Cosmo - param-V02-00-00r
250 - Changed RandGauss to G4RandGauss in G4Irregu 70 - Changed RandGauss to G4RandGauss in G4IrregularXrayTRmodel.cc and
251 G4VXrayTRmodel.cc to fix events' reproducibi 71 G4VXrayTRmodel.cc to fix events' reproducibility problem.
252 - G4VXrayTRmodel.cc: fix to class destructor ( 72 - G4VXrayTRmodel.cc: fix to class destructor (V.Grichine)
253 73
254 Jun 15, 2000 G. Cosmo - param-V01-01-04 74 Jun 15, 2000 G. Cosmo - param-V01-01-04
255 - The tag coworks with global-V01-01-04 and ma 75 - The tag coworks with global-V01-01-04 and materials-V01-01-00:
256 o Fixed usage of G4complex type for ISO and 76 o Fixed usage of G4complex type for ISO and non-ISO compilers.
257 Affected files: G4FoamXrayTRmodel.cc, G4Ga 77 Affected files: G4FoamXrayTRmodel.cc, G4GamDistrXrayTRmodel.cc, G4PlateIrrGasXrayTRmodel.cc
258 and G4RegularXrayTRmodel.c 78 and G4RegularXrayTRmodel.cc.
259 In case of G4complex types passed to mathe 79 In case of G4complex types passed to mathematical functions, use G4std:: prefix.
260 o Fixed usage of G4Integrator class, now cha 80 o Fixed usage of G4Integrator class, now changed to templated to allow porting of the
261 code on SUN-CC compiler which does not imp 81 code on SUN-CC compiler which does not implement templated member functions.
262 Affected files: G4VXrayTRmodel[.hh.cc] 82 Affected files: G4VXrayTRmodel[.hh.cc]
263 83
264 Jun 6, 2000 M. Verderi & P. Mora de Freitas 84 Jun 6, 2000 M. Verderi & P. Mora de Freitas
265 - fixed compilation errors with HP-aCC for the 85 - fixed compilation errors with HP-aCC for the files G4RegularXrayTRmodel.cc,
266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod 86 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmodel.cc.
267 87
268 May 30, 2000 M. Verderi & P. Mora de Freitas 88 May 30, 2000 M. Verderi & P. Mora de Freitas
269 89
270 - parameterisation category is now RW free. 90 - parameterisation category is now RW free.
271 91
272 September 16, 1999 M. Verderi & P. Mora de Fre 92 September 16, 1999 M. Verderi & P. Mora de Freitas
273 93
274 - Fixed bug in G4FastStep::CheckIt() method. 94 - Fixed bug in G4FastStep::CheckIt() method.
275 95
276 April 19, 1999 M. Verderi & P. Mora de Freitas 96 April 19, 1999 M. Verderi & P. Mora de Freitas
277 97
278 Changes in G4FastStep to co-work with track-01 98 Changes in G4FastStep to co-work with track-01-00-04:
279 99
280 1) The method void CheckIt(const G4Track&) bec << 100 1) The method void CheckIt(const G4Track&) becomes
281 G4bool CheckIt(const G4Track&); 101 G4bool CheckIt(const G4Track&);
282 2) The FAST_STEP_DEBUG compiling option disapp 102 2) The FAST_STEP_DEBUG compiling option disappears;
283 3) Call to CheckIt controled by the G4VParticl 103 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute.
284 104
285 Miscellaneous: the declaration "G4double mass 105 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh
286 corrected to G4double mass =...". 106 corrected to G4double mass =...".
287 107
288 April 15, 1999 M. Verderi & P. Mora de Freitas 108 April 15, 1999 M. Verderi & P. Mora de Freitas
289 109
290 Tasks to decouple visualization from processes 110 Tasks to decouple visualization from processes/parameterisation:
291 111
292 1) G4GlobalFastSimulationManager now inherites 112 1) G4GlobalFastSimulationManager now inherites from the intercoms/
293 G4VGlobalFastSimulationManager to allow visual << 113 G4VGlobalFastSimulationManager to allow visualisation to get a
294 concrete instance pointer to the G4GlobalFastS 114 concrete instance pointer to the G4GlobalFastSimulationManager,
295 if any. 115 if any.
296 116
297 2) G4FlavoredParallelWorld now inherites from 117 2) G4FlavoredParallelWorld now inherites from the intercoms/
298 G4VFlavoredParallelWorld, a pure virtual abstr 118 G4VFlavoredParallelWorld, a pure virtual abstract class to interface
299 parameterisation with visualization. 119 parameterisation with visualization.
300 120
301 Co-works with intercoms-01-00-01 tag 121 Co-works with intercoms-01-00-01 tag
302 122
303 Modified files: 123 Modified files:
304 --------------- 124 ---------------
305 G4FlavoredParallelWorld.hh 125 G4FlavoredParallelWorld.hh
306 G4GlobalFastSimulationManager.hh 126 G4GlobalFastSimulationManager.hh
307 G4GlobalFastSimulationManager.cc 127 G4GlobalFastSimulationManager.cc
308 128
309 Done, tested, system-tested on HP-aCC with exe 129 Done, tested, system-tested on HP-aCC with exemple N05.
310 130
311 April 14, 1999 M. Verderi & P. Mora de Freitas 131 April 14, 1999 M. Verderi & P. Mora de Freitas
312 132
313 Several consolidation tasks (thanks to G. Cosm 133 Several consolidation tasks (thanks to G. Cosmo):
314 134
315 1) Warning: << 135 1) Warning:
316 ----------- 136 -----------
317 137
318 Pointers usage 138 Pointers usage
319 139
320 - Setting pointers to 0 after delete: 140 - Setting pointers to 0 after delete:
321 141
322 delete pA; 142 delete pA;
323 pA = 0; 143 pA = 0;
324 144
325 - Avoid to use "NULL". 145 - Avoid to use "NULL".
326 146
327 Modified files: 147 Modified files:
328 --------------- 148 ---------------
329 G4FastSimulationManager.hh 149 G4FastSimulationManager.hh
330 G4FastTrack.hh 150 G4FastTrack.hh
331 G4FlavoredParallelWorld.hh 151 G4FlavoredParallelWorld.hh
332 G4FastSimulationManager.cc 152 G4FastSimulationManager.cc
333 G4FastSimulationMessenger.cc 153 G4FastSimulationMessenger.cc
334 G4FastSimulationManagerProcess.cc 154 G4FastSimulationManagerProcess.cc
335 G4FastTrack.cc 155 G4FastTrack.cc
336 G4GlobalFastSimulationManager.cc 156 G4GlobalFastSimulationManager.cc
337 G4VFastSimulationModel.cc 157 G4VFastSimulationModel.cc
338 158
339 Status: << 159 Status:
340 ------- 160 -------
341 Done, tested, system-tested on HP-aCC with exe 161 Done, tested, system-tested on HP-aCC with exemple N05.
342 162
343 2) Warning: 163 2) Warning:
344 ----------- 164 -----------
345 include/G4FastSimulationManager.hh:163 165 include/G4FastSimulationManager.hh:163
346 Public member functions shall always retur 166 Public member functions shall always return const handles to member data
347 Severe violation: Universal Coding Standar 167 Severe violation: Universal Coding Standards item 18
348 168
349 offending code: 169 offending code:
350 --------------- 170 ---------------
351 inline G4VParticleChange* G4FastSimulationMana 171 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange()
352 { 172 {
353 return &fFastStep; 173 return &fFastStep;
354 } 174 }
355 175
356 Diagnostic: 176 Diagnostic:
357 ---------- 177 ----------
358 178
359 Called by the G4FastSimulationManagerProcess << 179 Called by the G4FastSimulationManagerProcess to return it in the
360 PostStepDoIt call. << 180 PostStepDoIt call.
361 181
362 Action: 182 Action:
363 ------- 183 -------
364 The G4FastSimulationManager::GettheParticleCha 184 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any
365 more. The G4VParticleChange* is now returned d 185 more. The G4VParticleChange* is now returned directly when invoking the
366 G4FastSimulationManager::InvokePostStepDoIt() 186 G4FastSimulationManager::InvokePostStepDoIt() and
367 G4FastSimulationManager::InvokeAtRestDoIt() me 187 G4FastSimulationManager::InvokeAtRestDoIt() methodes.
368 188
369 Modified files: 189 Modified files:
370 --------------- 190 ---------------
371 G4FastSimulationManager.hh 191 G4FastSimulationManager.hh
372 G4FastSimulationManager.cc 192 G4FastSimulationManager.cc
373 G4FastSimulationManagerProcess.cc 193 G4FastSimulationManagerProcess.cc
374 194
375 Status: << 195 Status:
376 ------- 196 -------
377 Done, tested, system-tested on HP-aCC with exe 197 Done, tested, system-tested on HP-aCC with exemple N05.
378 198
379 3) Warning: 199 3) Warning:
380 ----------- 200 -----------
381 include/G4FastSimulationManagerProcess.hh:52 201 include/G4FastSimulationManagerProcess.hh:52
382 If a class has virtual functions it shall 202 If a class has virtual functions it shall have a virtual destructor
383 Severe violation: Universal Coding Standar 203 Severe violation: Universal Coding Standards item 17
384 class G4FastSimulationManagerProcess has v 204 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor.
385 205
386 offending code: 206 offending code:
387 --------------- 207 ---------------
388 ~G4FastSimulationManagerProcess(); 208 ~G4FastSimulationManagerProcess();
389 209
390 Diagnostic: 210 Diagnostic:
391 ---------- 211 ----------
392 Nobody should inherites from G4FastSimulatio << 212 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual
393 is added. 213 is added.
394 214
395 Action: 215 Action:
396 ------- 216 -------
397 virtual ~G4FastSimulationManagerProcess(); 217 virtual ~G4FastSimulationManagerProcess();
398 218
399 Modified files: 219 Modified files:
400 --------------- 220 ---------------
401 G4FastSimulationManagerProcess.hh 221 G4FastSimulationManagerProcess.hh
402 222
403 Status: << 223 Status:
404 ------- 224 -------
405 Done. 225 Done.
406 226
407 4) Warning: 227 4) Warning:
408 ----------- 228 -----------
409 include/G4FastSimulationMessenger.hh:36 229 include/G4FastSimulationMessenger.hh:36
410 If a class has virtual functions it shall 230 If a class has virtual functions it shall have a virtual destructor
411 Severe violation: Universal Coding Standar 231 Severe violation: Universal Coding Standards item 17
412 class G4FastSimulationMessenger has virtua 232 class G4FastSimulationMessenger has virtual functions without a virtual destructor.
413 233
414 234
415 offending code: 235 offending code:
416 --------------- 236 ---------------
417 ~G4FastSimulationMessenger(); 237 ~G4FastSimulationMessenger();
418 238
419 Diagnostic: 239 Diagnostic:
420 ---------- 240 ----------
421 Nobody should inherites from G4FastSimulatio << 241 Nobody should inherites from G4FastSimulationMessenger BUT for virtual
422 is added. 242 is added.
423 243
424 Action: 244 Action:
425 ------- 245 -------
426 virtual ~G4FastSimulationMessenger(); 246 virtual ~G4FastSimulationMessenger();
427 247
428 Modified files: 248 Modified files:
429 --------------- 249 ---------------
430 G4FastSimulationMessenger.hh 250 G4FastSimulationMessenger.hh
431 251
432 Status: << 252 Status:
433 ------- 253 -------
434 Done. 254 Done.
435 255
436 5) Warning: 256 5) Warning:
437 ----------- 257 -----------
438 include/G4FastStep.hh:224 258 include/G4FastStep.hh:224
439 Operator= should call base class operator= 259 Operator= should call base class operator=
440 Possible severe violation: Effective C++ i 260 Possible severe violation: Effective C++ item 16
441 operator= in class G4FastStep, should call 261 operator= in class G4FastStep, should call operator= in base class G4VParticleChange
442 262
443 offending code: 263 offending code:
444 --------------- 264 ---------------
445 G4FastStep & G4FastStep::operator=(const G4Fas 265 G4FastStep & G4FastStep::operator=(const G4FastStep &right)
446 { 266 {
447 if (this != &right) 267 if (this != &right)
448 { 268 {
449 theListOfSecondaries = right.th 269 theListOfSecondaries = right.theListOfSecondaries;
450 theSizeOftheListOfSecondaries = right.th 270 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries;
451 theNumberOfSecondaries = right.th 271 theNumberOfSecondaries = right.theNumberOfSecondaries;
452 theStatusChange = right.th 272 theStatusChange = right.theStatusChange;
453 theMomentumChange = right.th 273 theMomentumChange = right.theMomentumChange;
454 thePolarizationChange = right.th 274 thePolarizationChange = right.thePolarizationChange;
455 thePositionChange = right.th 275 thePositionChange = right.thePositionChange;
456 theTimeChange = right.th 276 theTimeChange = right.theTimeChange;
457 theEnergyChange = right.th 277 theEnergyChange = right.theEnergyChange;
458 theTrueStepLength = right.th 278 theTrueStepLength = right.theTrueStepLength;
459 theLocalEnergyDeposit = right.th 279 theLocalEnergyDeposit = right.theLocalEnergyDeposit;
460 theSteppingControlFlag = right.th 280 theSteppingControlFlag = right.theSteppingControlFlag;
461 theWeightChange = right.th 281 theWeightChange = right.theWeightChange;
462 } 282 }
463 return *this; 283 return *this;
464 } 284 }
465 285
466 Diagnostic: 286 Diagnostic:
467 ---------- 287 ----------
468 Bug detected. 288 Bug detected.
469 289
470 Action: 290 Action:
471 ------- 291 -------
472 Insert the call 292 Insert the call
473 G4VParticleChange::operator=(right); 293 G4VParticleChange::operator=(right);
474 294
475 Status: 295 Status:
476 ------- 296 -------
477 Done, tested, system-tested on HP-aCC with e 297 Done, tested, system-tested on HP-aCC with exemple N05.
478 298
479 Modified files: 299 Modified files:
480 --------------- 300 ---------------
481 G4FastStep.cc 301 G4FastStep.cc
482 302
483 6) Warning: 303 6) Warning:
484 ----------- 304 -----------
485 include/G4FastStep.hh:59 305 include/G4FastStep.hh:59
486 Avoid data members in the public interface 306 Avoid data members in the public interface
487 Violation: Effective C++ item 20 307 Violation: Effective C++ item 20
488 Public data members for class G4FastStep: 308 Public data members for class G4FastStep:
489 debugFlag 309 debugFlag
490 310
491 311
492 offending code: 312 offending code:
493 --------------- 313 ---------------
494 public: 314 public:
495 ... 315 ...
496 G4bool debugFlag; 316 G4bool debugFlag;
497 317
498 Diagnostic: 318 Diagnostic:
499 ---------- 319 ----------
500 Historical usage. 320 Historical usage.
501 321
502 Action: 322 Action:
503 ------- 323 -------
504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 324 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file.
505 325
506 Modified files: 326 Modified files:
507 --------------- 327 ---------------
508 G4FastStep.hh, G4FastStep.cc 328 G4FastStep.hh, G4FastStep.cc
509 329
510 Status: 330 Status:
511 ------- 331 -------
512 Done, tested, system-tested on HP-aCC with e 332 Done, tested, system-tested on HP-aCC with exemple N05.
513 333
514 7) Warning: 334 7) Warning:
515 ----------- 335 -----------
516 include/G4FastStep.hh:59 336 include/G4FastStep.hh:59
517 If a class has virtual functions it shall 337 If a class has virtual functions it shall have a virtual destructor
518 Severe violation: Universal Coding Standar 338 Severe violation: Universal Coding Standards item 17
519 class G4FastStep has virtual functions wit 339 class G4FastStep has virtual functions without a virtual destructor.
520 340
521 341
522 offending code: 342 offending code:
523 --------------- 343 ---------------
524 ~G4FastStep(); 344 ~G4FastStep();
525 345
526 Diagnostic: 346 Diagnostic:
527 ---------- 347 ----------
528 Nobody should inherites from G4FastStep BUT 348 Nobody should inherites from G4FastStep BUT virtual added.
529 349
530 Action: 350 Action:
531 ------- 351 -------
532 virtual ~G4FastStep(); 352 virtual ~G4FastStep();
533 353
534 Modified files: 354 Modified files:
535 --------------- 355 ---------------
536 G4FastStep.hh 356 G4FastStep.hh
537 357
538 Status: 358 Status:
539 ------- 359 -------
540 Done, tested, system-tested on HP-aCC with e 360 Done, tested, system-tested on HP-aCC with exemple N05.
541 361
542 362
543 December 7, 1998 M. Verderi 363 December 7, 1998 M. Verderi
544 G4FastSimulationManagerProcess class: 364 G4FastSimulationManagerProcess class:
545 Fixes made for ghost navigation with 365 Fixes made for ghost navigation with
546 mag-field: 366 mag-field:
547 LocateGlobalPointAndUpdateTouchable is 367 LocateGlobalPointAndUpdateTouchable is
548 always used (in not the Locate...Setup 368 always used (in not the Locate...Setup
549 method) 369 method)
550 In PostStepDoIt: correction of position and 370 In PostStepDoIt: correction of position and
551 direction of the track are made when << 371 direction of the track are made when
552 possible in case of mag-field. 372 possible in case of mag-field.
553 This correction comes from the fact that a 373 This correction comes from the fact that a
554 small discrepancy appears on those quantitie 374 small discrepancy appears on those quantities
555 because of the numerical integration along 375 because of the numerical integration along
556 the field on the track path: the G4FSMP 376 the field on the track path: the G4FSMP
557 proposes a curve-length, the transportation 377 proposes a curve-length, the transportation
558 moves the track along this curve, however 378 moves the track along this curve, however
559 the end point position and direction are 379 the end point position and direction are
560 slightly different from those expected by 380 slightly different from those expected by
561 the G4FSMP when it proposed the length. 381 the G4FSMP when it proposed the length.
562 382
563 November 20,1998 M. Verderi 383 November 20,1998 M. Verderi
564 G4FastStep class: 384 G4FastStep class:
565 Remove track/G4BiasingTag.hh dependancy (ob 385 Remove track/G4BiasingTag.hh dependancy (obsolete).
566 Adapted to new shceme of Event Biasing mech 386 Adapted to new shceme of Event Biasing mechanism,
567 consistently with track-00-04-01 tag. 387 consistently with track-00-04-01 tag.
568 388
569 November 11,1998 M. Verderi 389 November 11,1998 M. Verderi
570 Merge of param-00-03-02 & param-00-03-02a i 390 Merge of param-00-03-02 & param-00-03-02a into
571 param-00-03-04a (hopefully...) 391 param-00-03-04a (hopefully...)
572 The point is the chnage of signature in the 392 The point is the chnage of signature in the
573 LocateGlobalPointAndSetup(..) of the G4Navi 393 LocateGlobalPointAndSetup(..) of the G4Navigator making use now
574 of the track direction. The G4FastSimulatio 394 of the track direction. The G4FastSimulationManagerProcess is
575 changed accordingly: 395 changed accordingly:
576 fGhostNavigator.LocateGlobalPointAndSetup(t 396 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true);
577 397
578 398
579 November 6, 1998 M. Verderi 399 November 6, 1998 M. Verderi
580 - Extension of the G4FastStep to allow the 400 - Extension of the G4FastStep to allow the biasing technic.
581 Changes are made in: 401 Changes are made in:
582 - G4FastStep.hh/.icc: 402 - G4FastStep.hh/.icc:
583 new member G4BiasingTa 403 new member G4BiasingTag fBiasTag;
584 new method SetPrimaryT 404 new method SetPrimaryTrackFinalBiasingTag
585 ( G4BiasingTag 405 ( G4BiasingTag aTag );
586 - G4FastStep.cc: 406 - G4FastStep.cc:
587 Initialize(); 407 Initialize();
588 operator=; << 408 operator=;
589 UpdateForPostStep(); 409 UpdateForPostStep();
590 UpdateForAtRest(); << 410 UpdateForAtRest();
591 411
592 October 26, 1998 P.Mora de Freitas 412 October 26, 1998 P.Mora de Freitas
593 - G4FastSimulationManagerProcess and G4Fast 413 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal
594 with at rest parameterisations also when 414 with at rest parameterisations also when using parallel geometry.
595 415
596 October 8, 1998 P.Mora de Freitas 416 October 8, 1998 P.Mora de Freitas
597 - The G4VFastSimulationModel::IsApplicable( 417 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual
598 methode. 418 methode.
599 - G4FastSimulationManager optimisation: 419 - G4FastSimulationManager optimisation:
600 - New G4ParticleDefinition* fLastCrossedP 420 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps
601 the last particle type with touched the 421 the last particle type with touched the envelope;
602 - New G4RWTPtrOrderedVector<G4VFastSimula 422 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList
603 data member, keeps the model list of th << 423 data member, keeps the model list of the applicable models for
604 the actual fLastCrossedParticle particl 424 the actual fLastCrossedParticle particle type;
605 - Changes in the PostStepGetFastSimulatio << 425 - Changes in the PostStepGetFastSimulationManagerTrigger() and
606 AtRestGetFastSimulationManagerTrigger() << 426 AtRestGetFastSimulationManagerTrigger()methodes to update the
607 fApplicableModelList when needed (fLast 427 fApplicableModelList when needed (fLastCrossedParticle !=
608 the actual tracked particle); 428 the actual tracked particle);
609 - Changes in the << 429 - Changes in the
610 G4FastSimulationManager() (Constructor) 430 G4FastSimulationManager() (Constructor)
611 ActivateFastSimulationModel(), 431 ActivateFastSimulationModel(),
612 InActivateFastSimulationModel(), 432 InActivateFastSimulationModel(),
613 AtRestGetFastSimulationManagerTrigger(), 433 AtRestGetFastSimulationManagerTrigger(),
614 AddFastSimulationModel(), 434 AddFastSimulationModel(),
615 RemoveFastSimulationModel() 435 RemoveFastSimulationModel()
616 methodes to set the fLastCrossedParticle to 436 methodes to set the fLastCrossedParticle to NULL, forcing the
617 fApplicableModelList to be rebuilt. 437 fApplicableModelList to be rebuilt.
618 438
619 September 22, 1998 P.Mora de Freitas 439 September 22, 1998 P.Mora de Freitas
620 Fixed bug in parallel navigation. << 440 Fixed bug in parallel navigation.
621 File touched: G4FastSimulationManagerProces 441 File touched: G4FastSimulationManagerProcess.cc
622 Tested on HP-aCC. 442 Tested on HP-aCC.
623 443
624 September 17, 1998 P.Mora de Freitas 444 September 17, 1998 P.Mora de Freitas
625 G4FastSimulationManager::RemoveFastSimulati 445 G4FastSimulationManager::RemoveFastSimulationModel() updated to look
626 for also in the fInactivatedModels list. 446 for also in the fInactivatedModels list.
627 447
628 Tested on HP-aCC. 448 Tested on HP-aCC.
629 449
630 September 16, 1998 P.Mora de Freitas 450 September 16, 1998 P.Mora de Freitas
631 New /param/ control commands: 451 New /param/ control commands:
632 452
633 /param/ActivateModel <ModelName> 453 /param/ActivateModel <ModelName>
634 /param/InActivateModel <ModelName> 454 /param/InActivateModel <ModelName>
635 455
636 Activate or inactivate a given parameterisat 456 Activate or inactivate a given parameterisation model.
637 457
638 Tested on HP-aCC. 458 Tested on HP-aCC.
639 459
640 August 21, 1998 P.Mora de Freitas 460 August 21, 1998 P.Mora de Freitas
641 G4FastSimulationManagerProcess's G4ProcessTy 461 G4FastSimulationManagerProcess's G4ProcessType set to
642 fParameterisation, accordingly with procman-00 462 fParameterisation, accordingly with procman-00-02-03.
643 463
644 Tested on HP-aCC. 464 Tested on HP-aCC.
645 465
646 August 12, 1998 P.Mora de Freitas 466 August 12, 1998 P.Mora de Freitas
647 Improved the "close parameterisation control << 467 Improved the "close parameterisation control" to
648 468
649 1) avoid the close looping when unnecessary 469 1) avoid the close looping when unnecessary (mostly cases);
650 2) force re-close when necessary (insert/rem 470 2) force re-close when necessary (insert/remove ghosts).
651 471
652 Changes: 472 Changes:
653 473
654 1) the G4GlobalFastSimulationManager::fClose << 474 1) the G4GlobalFastSimulationManager::fClosed is now initialised
655 to true by the G4GlobalFastSimulationMana 475 to true by the G4GlobalFastSimulationManager constructor;
656 476
657 2) new method << 477 2) new method
658 478
659 void << 479 void
660 G4GlobalFastSimulationManager::FastSimula 480 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed();
661 481
662 called by the AddGhostPlacement and Remov << 482 called by the AddGhostPlacement and RemoveGhostPlacement
663 G4FastSimulationManager methods to set fa 483 G4FastSimulationManager methods to set false the fClosed flag;
664 484
665 3) changes in the G4GlobalFastSimulationMana 485 3) changes in the G4GlobalFastSimulationManager::Notify method
666 to deal with these changes. 486 to deal with these changes.
667 487
668 Tested on HP-aCC. 488 Tested on HP-aCC.
669 489
670 August 11, 1998 P.Mora de Freitas 490 August 11, 1998 P.Mora de Freitas
671 Fix to the G4FastStep::KillPrimaryTrack() me 491 Fix to the G4FastStep::KillPrimaryTrack() method to drop the
672 nonsense line 492 nonsense line
673 493
674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 494 SetMomentumChange(0.,0.,0.) ; /* necessary ? */
675 495
676 Tested on HP-aCC. 496 Tested on HP-aCC.
677 (Thanks to Willy Langeveld) 497 (Thanks to Willy Langeveld)
678 498
679 499
680 August 10, 1998 P.Mora de Freitas 500 August 10, 1998 P.Mora de Freitas
681 Fix to the SetPrimaryTrackFinalKineticEnergy 501 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method
682 from the G4FastStep class the SetMomentumChang 502 from the G4FastStep class the SetMomentumChange() call to insure that
683 the new momentum direction is a unit vector (a << 503 the new momentum direction is a unit vector (as asked by the
684 G4DynamicParticle::SetMomentumDirection method 504 G4DynamicParticle::SetMomentumDirection method).
685 505
686 Touched files: G4FastStep.hh (improved comme 506 Touched files: G4FastStep.hh (improved comments)
687 G4FastStep.cc (fixed) 507 G4FastStep.cc (fixed)
688 508
689 Tested on HP-aCC. 509 Tested on HP-aCC.
690 (Thanks to Willy Langeveld) 510 (Thanks to Willy Langeveld)
691 511
692 August 7, 1998 P.Mora de Freitas 512 August 7, 1998 P.Mora de Freitas
693 New /param/ commands directory with the comm 513 New /param/ commands directory with the commands:
694 514
695 /param/listEnvelopes [ParticleName] 515 /param/listEnvelopes [ParticleName]
696 516
697 - List all the envelope names for a given pa 517 - List all the envelope names for a given particle
698 (or for all particles if without parameter 518 (or for all particles if without parameters).
699 519
700 /param/listModels [EnvelopeName] 520 /param/listModels [EnvelopeName]
701 521
702 - List all the Model names for a given envel 522 - List all the Model names for a given envelope
703 (or for all envelopes if without parameter 523 (or for all envelopes if without parameters).
704 524
705 /param/listIsApplicable [ModelName] 525 /param/listIsApplicable [ModelName]
706 526
707 - List all the particle names a given model 527 - List all the particle names a given model is applicable
708 (or for all models if without parameters). 528 (or for all models if without parameters).
709 529
710 530
711 August 7, 1998 P.Mora de Freitas 531 August 7, 1998 P.Mora de Freitas
712 History file Created. 532 History file Created.