| Geant4 Cross Reference |
1 # Category param History << 1 $Id: History,v 1.16 2002/11/20 17:05:46 gcosmo Exp $
>> 2 -------------------------------------------------------------------
2 3
3 See `CONTRIBUTING.rst` for details of **requir << 4 =========================================================
4 which **must** added in reverse chronological << 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP
5 It must **not** be used as a substitute for wr << 6 =========================================================
6 << 7
7 ---------------------------------------------- << 8 Category History file
8 << 9 ---------------------
9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) << 10 This file should be used by G4 developers and category coordinators
10 - In G4GlobalFastSimulationManager: << 11 to briefly summarize all major modifications introduced in the code
11 use G4ThreadLocalSingleton to avoid undelete << 12 and keep track of all category-tags.
12 << 13 It DOES NOT substitute the CVS log-message one should put at every
13 ## 2023-10-18 Ben Morgan (param-V11-01-03) << 14 committal in the CVS repository !
14 - Apply standard and extended clang-tidy fixes << 15
15 - Mark empty/obsolete functions as deprecated << 16 ----------------------------------------------------------
16 << 17 * Reverse chronological order (last date on top), please *
17 ## 2023-10-16 Ben Morgan (param-V11-01-02) << 18 ----------------------------------------------------------
18 - Apply standard clang-format-ing. <<
19 - Normal order accessors and docstrings. <<
20 <<
21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) <<
22 - In G4FastTrack, removed references to G4Touc <<
23 which is now deprecated. <<
24 <<
25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 <<
26 - Added missing virtual destructor to G4VFastS <<
27 <<
28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) <<
29 - Fixed compilation warnings for implicit type <<
30 <<
31 ## 2022-10-27 Makoto Asai (param-V11-00-03) <<
32 - G4FastSimHitMaker - making compatible to com <<
33 <<
34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 <<
35 - G4FastStep - delete copy constructor and ope <<
36 <<
37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) <<
38 - Adding the 'flush' method to the fast simula <<
39 This method allows to process the input buff <<
40 the end of the G4 event. It is used when par <<
41 The 'flash' is triggered inside the event lo <<
42 The fast simulation model may add secondarie <<
43 by Geant4. <<
44 <<
45 ## 2021-12-10 Ben Morgan (param-V11-00-00) <<
46 - Change to new Markdown History format <<
47 <<
48 --- <<
49 <<
50 # History entries prior to 11.0 <<
51 <<
52 April 16, 2021 Ben Morgan (param-V10-07-00) <<
53 - Migrate build to modular CMake API <<
54 <<
55 October 5, 2020, A. Zaborowska (param-V10-06-0 <<
56 - Introduce general facilities based on GFlash <<
57 to facilitate multiple hit (energy & positio <<
58 from fast simulation models. <<
59 <<
60 September 9, 2020, G. Cosmo (param-V10-06-02) <<
61 - Fixed minor Coverity defect for uninitialise <<
62 <<
63 April 21, 2020, A. Zaborowska (param-V10-06-01 <<
64 - Sanity check for root logical volumes for re <<
65 UI command /param/showSetup works also if no <<
66 <<
67 March 26, 2020, I. Semeniouk (param-V10-06-00) <<
68 - G4FastSimulationHelper : merge ActivateFastS <<
69 - G4FastSimulationManager.hh, G4VFastSimulatio <<
70 redefinition of G4Envelope type <<
71 <<
72 October 30, 2019, A. Zaborowska (param-v10-05- <<
73 - Register G4FastSimulationManagerProcess with <<
74 G4FastSimulationManagerHelper to ensure it i <<
75 invoked for a given step (ExclusivelyForced) <<
76 StronglyForced processes will be considered. <<
77 <<
78 December 19, 2017, G. Cosmo (param-V10-04-00) <<
79 - Fixed self-consistency in G4FastSimulationVe <<
80 Thanks to Raphael Isemann for reporting this <<
81 <<
82 November 03, 2016, M. Verderi (param-V10-02-01 <<
83 - New G4FastSimulationManagerHelper utility fo <<
84 adding G4FastSimulationManagerProcess to a <<
85 process manager. <<
86 <<
87 November 02, 2016, M. Verderi (param-V10-02-00 <<
88 - fix various Coverity defects. <<
89 <<
90 March 27, 2013, M. Verderi (param-V09-06-00) <<
91 - remove unused field 'fOnBoundary' in G4FastS <<
92 as this was causing a warning from clang. <<
93 <<
94 July 10, 2012, G. Cosmo (param-V09-05-00) <<
95 - Explicitly use inclusion of headers for syst <<
96 constants, in plan to remove implicit inclus <<
97 <<
98 September 30, 2011, M. Verderi (param-V09-04-0 <<
99 - Added missing new header file (G4FastSimulat <<
100 sources.cmake. <<
101 <<
102 September 30, 2011, M. Verderi (param-V09-04-0 <<
103 - Migration to new G4Exception scheme. <<
104 - what is V09-04-01 tag ? <<
105 <<
106 February 11, 2011, M. Verderi (param-V09-04-00 <<
107 - Implementation of method <<
108 void ProposePrimaryTrackFinalKineticEnergy ( <<
109 was missing : modified file G4FastStep.icc <<
110 <<
111 March 13, 2008, G. Cosmo (param-V09-01-00) <<
112 - Cleared compilation warnings in G4FastSimula <<
113 G4FastSimulationMessenger on gcc-4.3.0 for a <<
114 parentheses in nested if-else statements. <<
115 <<
116 November 30, 2007, M. Verderi <<
117 - Add Along methods to G4FSMP process <<
118 - tag as param-V09-00-01 <<
119 <<
120 November 30, 2007, M. Verderi <<
121 - minor corrections to G4FastSimulationManager <<
122 * add call fPathFinder->prepareNewrack(...) <<
123 * deactivate ghost navigator in EndOfTracki <<
124 - tag as param-V09-00-00 <<
125 <<
126 May 18, 2007, M. Verderi <<
127 - tag as param-V08-03-00 <<
128 <<
129 May 11, 2007, M. Verderi <<
130 - remove include/G4FastSimulationManagerProces <<
131 include/G4FlavoredParallelWorld.hh <<
132 include/G4GFSManager81.hh <<
133 src/G4FastSimulationManagerProcess81. <<
134 src/G4GFSManager81.cc <<
135 <<
136 <<
137 November 10, 2006, M. Verderi - param-V08-01-0 <<
138 - Limited number of warning messages printed b <<
139 G4GlobalFastSimulationManager. <<
140 - Renamed G4FastSimulationManagerProcess_forCo <<
141 G4FastSimulationManagerProcess81. <<
142 In addition, this class can now handle the c <<
143 i.e., the navigator for tracking, regardless <<
144 G4CoupledTransportation is used. (For other <<
145 of course no choice, and G4CoupledTransporta <<
146 <<
147 November 3, 2006 M. Verderi <<
148 - Introduced G4FastSimulationManagerProcess_fo <<
149 handling fast simulation in new parallel geo <<
150 the G4CoupledTransportation to be active. <<
151 - Introduced G4GFSManager81 class that gathers <<
152 default at next major release in the G4Globa <<
153 - G4FastSimulationManager: adapted to new sche <<
154 backward compatibilty. <<
155 - G4FastSimulationManagerProcess: mostly the s <<
156 - G4FastSimulationMessenger: new command creat <<
157 to show the fast simulation setup (region, m <<
158 It is only valid for geometry closed state. <<
159 command in the run manager for this. <<
160 <<
161 November 25, 2005, M.Verderi - param-V07-01-0 <<
162 - put back Makoto's change: StartTracking(G4Tr <<
163 <<
164 November 25, 2005, M Verderi - param-V07-01-03 <<
165 - Make ghost functionnality available with G4R <<
166 - ** Note ** Change back StartTracking(G4Track <<
167 StartTracking(G4Track*) was intro <<
168 because (I guess) of procman-V07-01-01 <<
169 This is to make param-V07-01-03 compatible w <<
170 <<
171 November 21, 2005 M.Asai - param-V07-01-02 <<
172 - Fix warning message. <<
173 <<
174 November 02, 2005 G.Cosmo - param-V07-01-01 <<
175 - Corrected setting of envelope volumes and so <<
176 - Migrated old scheme for G4Exception and some <<
177 <<
178 October 28, 2005 M.Asai - param-V07-01-00 <<
179 - Working tag for merging "envelope" to G4Regi <<
180 <<
181 December 07, 2004 G. Cosmo - param-V06-02-01 <<
182 - Implemented migration to <cmath>. <<
183 <<
184 November 26, 2004 M. Verderi - param-V06-02-00 <<
185 - Implemented migration to new G4VParticleChan <<
186 <<
187 December 12, 2003 G. Cosmo - param-V06-00-00 <<
188 - G4FastSimulationVector.icc: use std_pvector: <<
189 base class. Fixes compilation problem on Int <<
190 <<
191 November 10, 2003 G. Cosmo - param-V05-02-01 <<
192 - G4FastTrack: use G4Navigator::CreateTouchabl <<
193 CreateTouchableHistory() in method FRecordsA <<
194 <<
195 October 4, 2003 G. Cosmo - param-V05-02-00 <<
196 - Modified GNUmakefile: <<
197 o added dependency to new module "geometry/n <<
198 - Coworks with "geometry-V05-02-00" and "digit <<
199 <<
200 May 21, 2003 G. Cosmo - param-V05-01-00 <<
201 o Fixed pedantic warnings on Linux-g++ <<
202 o Call base class in copy-constructor <<
203 19
204 Nov 20, 2002 G. Cosmo - param-V04-01-02 20 Nov 20, 2002 G. Cosmo - param-V04-01-02
205 o Patched access to public static data in G4 21 o Patched access to public static data in G4FastStep.cc
206 and G4GlobalFastSimulationManager.cc to al 22 and G4GlobalFastSimulationManager.cc to allow porting on
207 Windows DLLs. 23 Windows DLLs.
208 24
209 Nov 15, 2002 S. Sadilov - param-V04-01-01 25 Nov 15, 2002 S. Sadilov - param-V04-01-01
210 o Fixed compilation problems on Windows in 26 o Fixed compilation problems on Windows in
211 G4FastSimulationManager.cc and G4GlobalFas 27 G4FastSimulationManager.cc and G4GlobalFastSimulationManager.cc
212 28
213 Nov 02, 2002 M. Verderi - param-V04-01-00 29 Nov 02, 2002 M. Verderi - param-V04-01-00
214 o Add method to retrieve G4VFastSimulationMo 30 o Add method to retrieve G4VFastSimulationModel by name.
215 The user's method is in G4GlobalFastSimula 31 The user's method is in G4GlobalFastSimulationManager:
216 32
217 GetFastSimulationModel(); 33 GetFastSimulationModel();
218 34
219 it is accompagnied by same methods name in 35 it is accompagnied by same methods name in
220 G4FastSimulationManager class. 36 G4FastSimulationManager class.
221 37
222 o Add "test" directory, used to test above f 38 o Add "test" directory, used to test above feature.
223 39
224 Oct 26, 2001 M. Verderi - param-V03-02-00 40 Oct 26, 2001 M. Verderi - param-V03-02-00
225 Fixes to clear warnings produced with gcc-2. 41 Fixes to clear warnings produced with gcc-2.95.2:
226 - loop index, where comparison with method " 42 - loop index, where comparison with method "size()" of
227 G4std::vector<T>, changed: int -> size_t << 43 G4std::vector<T>, changed: int -> size_t
228 - change "if ( a=b ) {..}" by "if ( (a=b) ) 44 - change "if ( a=b ) {..}" by "if ( (a=b) ) {...}"
229 this makes the compiler sure you want to mak 45 this makes the compiler sure you want to make an
230 assignement in the "if" condition 46 assignement in the "if" condition
231 - re-order initialisations of a few variable 47 - re-order initialisations of a few variables in constructors
232 to match the declaration order. 48 to match the declaration order.
233 Some warnings still exist, but regard the G4 49 Some warnings still exist, but regard the G4Propagator of geometry.
234 50
235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 51 Apr 3, 2001 J. Apostolakis - param-V03-00-00
236 - Modified G4FastSimulationManagerProcess call 52 - Modified G4FastSimulationManagerProcess call to PropagatorInField ComputeStep
237 to use new interface with G4FieldTrack (in 53 to use new interface with G4FieldTrack (in place of now obsolete interface.)
238 54
239 Nov 14, 2000 G. Cosmo - param-V02-00-01 55 Nov 14, 2000 G. Cosmo - param-V02-00-01
240 - Moved specific parameterisation models to th 56 - Moved specific parameterisation models to the new top category
241 "parameterisations". Moved files: 57 "parameterisations". Moved files:
242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm 58 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRmodel[.hh.cc],
243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster 59 G4IrregularXrayTRmodel[.hh.cc], G4PAIclusterModel[.hh.cc],
244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr 60 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXrayTRmodel[.hh.cc],
245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode 61 G4RegularXrayTRmodel[.hh.cc], G4VClusterModel[.hh.cc],
246 G4VXrayTRmodel[.hh.cc]. 62 G4VXrayTRmodel[.hh.cc].
247 - Cleaned-up GNUmakefile of non necessary depe 63 - Cleaned-up GNUmakefile of non necessary dependencies.
248 64
249 Aug 03, 2000 G. Cosmo - param-V02-00-00r 65 Aug 03, 2000 G. Cosmo - param-V02-00-00r
250 - Changed RandGauss to G4RandGauss in G4Irregu 66 - Changed RandGauss to G4RandGauss in G4IrregularXrayTRmodel.cc and
251 G4VXrayTRmodel.cc to fix events' reproducibi 67 G4VXrayTRmodel.cc to fix events' reproducibility problem.
252 - G4VXrayTRmodel.cc: fix to class destructor ( 68 - G4VXrayTRmodel.cc: fix to class destructor (V.Grichine)
253 69
254 Jun 15, 2000 G. Cosmo - param-V01-01-04 70 Jun 15, 2000 G. Cosmo - param-V01-01-04
255 - The tag coworks with global-V01-01-04 and ma 71 - The tag coworks with global-V01-01-04 and materials-V01-01-00:
256 o Fixed usage of G4complex type for ISO and 72 o Fixed usage of G4complex type for ISO and non-ISO compilers.
257 Affected files: G4FoamXrayTRmodel.cc, G4Ga 73 Affected files: G4FoamXrayTRmodel.cc, G4GamDistrXrayTRmodel.cc, G4PlateIrrGasXrayTRmodel.cc
258 and G4RegularXrayTRmodel.c 74 and G4RegularXrayTRmodel.cc.
259 In case of G4complex types passed to mathe 75 In case of G4complex types passed to mathematical functions, use G4std:: prefix.
260 o Fixed usage of G4Integrator class, now cha 76 o Fixed usage of G4Integrator class, now changed to templated to allow porting of the
261 code on SUN-CC compiler which does not imp 77 code on SUN-CC compiler which does not implement templated member functions.
262 Affected files: G4VXrayTRmodel[.hh.cc] 78 Affected files: G4VXrayTRmodel[.hh.cc]
263 79
264 Jun 6, 2000 M. Verderi & P. Mora de Freitas 80 Jun 6, 2000 M. Verderi & P. Mora de Freitas
265 - fixed compilation errors with HP-aCC for the 81 - fixed compilation errors with HP-aCC for the files G4RegularXrayTRmodel.cc,
266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod 82 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmodel.cc.
267 83
268 May 30, 2000 M. Verderi & P. Mora de Freitas 84 May 30, 2000 M. Verderi & P. Mora de Freitas
269 85
270 - parameterisation category is now RW free. 86 - parameterisation category is now RW free.
271 87
272 September 16, 1999 M. Verderi & P. Mora de Fre 88 September 16, 1999 M. Verderi & P. Mora de Freitas
273 89
274 - Fixed bug in G4FastStep::CheckIt() method. 90 - Fixed bug in G4FastStep::CheckIt() method.
275 91
276 April 19, 1999 M. Verderi & P. Mora de Freitas 92 April 19, 1999 M. Verderi & P. Mora de Freitas
277 93
278 Changes in G4FastStep to co-work with track-01 94 Changes in G4FastStep to co-work with track-01-00-04:
279 95
280 1) The method void CheckIt(const G4Track&) bec << 96 1) The method void CheckIt(const G4Track&) becomes
281 G4bool CheckIt(const G4Track&); 97 G4bool CheckIt(const G4Track&);
282 2) The FAST_STEP_DEBUG compiling option disapp 98 2) The FAST_STEP_DEBUG compiling option disappears;
283 3) Call to CheckIt controled by the G4VParticl 99 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute.
284 100
285 Miscellaneous: the declaration "G4double mass 101 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh
286 corrected to G4double mass =...". 102 corrected to G4double mass =...".
287 103
288 April 15, 1999 M. Verderi & P. Mora de Freitas 104 April 15, 1999 M. Verderi & P. Mora de Freitas
289 105
290 Tasks to decouple visualization from processes 106 Tasks to decouple visualization from processes/parameterisation:
291 107
292 1) G4GlobalFastSimulationManager now inherites 108 1) G4GlobalFastSimulationManager now inherites from the intercoms/
293 G4VGlobalFastSimulationManager to allow visual << 109 G4VGlobalFastSimulationManager to allow visualisation to get a
294 concrete instance pointer to the G4GlobalFastS 110 concrete instance pointer to the G4GlobalFastSimulationManager,
295 if any. 111 if any.
296 112
297 2) G4FlavoredParallelWorld now inherites from 113 2) G4FlavoredParallelWorld now inherites from the intercoms/
298 G4VFlavoredParallelWorld, a pure virtual abstr 114 G4VFlavoredParallelWorld, a pure virtual abstract class to interface
299 parameterisation with visualization. 115 parameterisation with visualization.
300 116
301 Co-works with intercoms-01-00-01 tag 117 Co-works with intercoms-01-00-01 tag
302 118
303 Modified files: 119 Modified files:
304 --------------- 120 ---------------
305 G4FlavoredParallelWorld.hh 121 G4FlavoredParallelWorld.hh
306 G4GlobalFastSimulationManager.hh 122 G4GlobalFastSimulationManager.hh
307 G4GlobalFastSimulationManager.cc 123 G4GlobalFastSimulationManager.cc
308 124
309 Done, tested, system-tested on HP-aCC with exe 125 Done, tested, system-tested on HP-aCC with exemple N05.
310 126
311 April 14, 1999 M. Verderi & P. Mora de Freitas 127 April 14, 1999 M. Verderi & P. Mora de Freitas
312 128
313 Several consolidation tasks (thanks to G. Cosm 129 Several consolidation tasks (thanks to G. Cosmo):
314 130
315 1) Warning: << 131 1) Warning:
316 ----------- 132 -----------
317 133
318 Pointers usage 134 Pointers usage
319 135
320 - Setting pointers to 0 after delete: 136 - Setting pointers to 0 after delete:
321 137
322 delete pA; 138 delete pA;
323 pA = 0; 139 pA = 0;
324 140
325 - Avoid to use "NULL". 141 - Avoid to use "NULL".
326 142
327 Modified files: 143 Modified files:
328 --------------- 144 ---------------
329 G4FastSimulationManager.hh 145 G4FastSimulationManager.hh
330 G4FastTrack.hh 146 G4FastTrack.hh
331 G4FlavoredParallelWorld.hh 147 G4FlavoredParallelWorld.hh
332 G4FastSimulationManager.cc 148 G4FastSimulationManager.cc
333 G4FastSimulationMessenger.cc 149 G4FastSimulationMessenger.cc
334 G4FastSimulationManagerProcess.cc 150 G4FastSimulationManagerProcess.cc
335 G4FastTrack.cc 151 G4FastTrack.cc
336 G4GlobalFastSimulationManager.cc 152 G4GlobalFastSimulationManager.cc
337 G4VFastSimulationModel.cc 153 G4VFastSimulationModel.cc
338 154
339 Status: << 155 Status:
340 ------- 156 -------
341 Done, tested, system-tested on HP-aCC with exe 157 Done, tested, system-tested on HP-aCC with exemple N05.
342 158
343 2) Warning: 159 2) Warning:
344 ----------- 160 -----------
345 include/G4FastSimulationManager.hh:163 161 include/G4FastSimulationManager.hh:163
346 Public member functions shall always retur 162 Public member functions shall always return const handles to member data
347 Severe violation: Universal Coding Standar 163 Severe violation: Universal Coding Standards item 18
348 164
349 offending code: 165 offending code:
350 --------------- 166 ---------------
351 inline G4VParticleChange* G4FastSimulationMana 167 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange()
352 { 168 {
353 return &fFastStep; 169 return &fFastStep;
354 } 170 }
355 171
356 Diagnostic: 172 Diagnostic:
357 ---------- 173 ----------
358 174
359 Called by the G4FastSimulationManagerProcess << 175 Called by the G4FastSimulationManagerProcess to return it in the
360 PostStepDoIt call. << 176 PostStepDoIt call.
361 177
362 Action: 178 Action:
363 ------- 179 -------
364 The G4FastSimulationManager::GettheParticleCha 180 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any
365 more. The G4VParticleChange* is now returned d 181 more. The G4VParticleChange* is now returned directly when invoking the
366 G4FastSimulationManager::InvokePostStepDoIt() 182 G4FastSimulationManager::InvokePostStepDoIt() and
367 G4FastSimulationManager::InvokeAtRestDoIt() me 183 G4FastSimulationManager::InvokeAtRestDoIt() methodes.
368 184
369 Modified files: 185 Modified files:
370 --------------- 186 ---------------
371 G4FastSimulationManager.hh 187 G4FastSimulationManager.hh
372 G4FastSimulationManager.cc 188 G4FastSimulationManager.cc
373 G4FastSimulationManagerProcess.cc 189 G4FastSimulationManagerProcess.cc
374 190
375 Status: << 191 Status:
376 ------- 192 -------
377 Done, tested, system-tested on HP-aCC with exe 193 Done, tested, system-tested on HP-aCC with exemple N05.
378 194
379 3) Warning: 195 3) Warning:
380 ----------- 196 -----------
381 include/G4FastSimulationManagerProcess.hh:52 197 include/G4FastSimulationManagerProcess.hh:52
382 If a class has virtual functions it shall 198 If a class has virtual functions it shall have a virtual destructor
383 Severe violation: Universal Coding Standar 199 Severe violation: Universal Coding Standards item 17
384 class G4FastSimulationManagerProcess has v 200 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor.
385 201
386 offending code: 202 offending code:
387 --------------- 203 ---------------
388 ~G4FastSimulationManagerProcess(); 204 ~G4FastSimulationManagerProcess();
389 205
390 Diagnostic: 206 Diagnostic:
391 ---------- 207 ----------
392 Nobody should inherites from G4FastSimulatio << 208 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual
393 is added. 209 is added.
394 210
395 Action: 211 Action:
396 ------- 212 -------
397 virtual ~G4FastSimulationManagerProcess(); 213 virtual ~G4FastSimulationManagerProcess();
398 214
399 Modified files: 215 Modified files:
400 --------------- 216 ---------------
401 G4FastSimulationManagerProcess.hh 217 G4FastSimulationManagerProcess.hh
402 218
403 Status: << 219 Status:
404 ------- 220 -------
405 Done. 221 Done.
406 222
407 4) Warning: 223 4) Warning:
408 ----------- 224 -----------
409 include/G4FastSimulationMessenger.hh:36 225 include/G4FastSimulationMessenger.hh:36
410 If a class has virtual functions it shall 226 If a class has virtual functions it shall have a virtual destructor
411 Severe violation: Universal Coding Standar 227 Severe violation: Universal Coding Standards item 17
412 class G4FastSimulationMessenger has virtua 228 class G4FastSimulationMessenger has virtual functions without a virtual destructor.
413 229
414 230
415 offending code: 231 offending code:
416 --------------- 232 ---------------
417 ~G4FastSimulationMessenger(); 233 ~G4FastSimulationMessenger();
418 234
419 Diagnostic: 235 Diagnostic:
420 ---------- 236 ----------
421 Nobody should inherites from G4FastSimulatio << 237 Nobody should inherites from G4FastSimulationMessenger BUT for virtual
422 is added. 238 is added.
423 239
424 Action: 240 Action:
425 ------- 241 -------
426 virtual ~G4FastSimulationMessenger(); 242 virtual ~G4FastSimulationMessenger();
427 243
428 Modified files: 244 Modified files:
429 --------------- 245 ---------------
430 G4FastSimulationMessenger.hh 246 G4FastSimulationMessenger.hh
431 247
432 Status: << 248 Status:
433 ------- 249 -------
434 Done. 250 Done.
435 251
436 5) Warning: 252 5) Warning:
437 ----------- 253 -----------
438 include/G4FastStep.hh:224 254 include/G4FastStep.hh:224
439 Operator= should call base class operator= 255 Operator= should call base class operator=
440 Possible severe violation: Effective C++ i 256 Possible severe violation: Effective C++ item 16
441 operator= in class G4FastStep, should call 257 operator= in class G4FastStep, should call operator= in base class G4VParticleChange
442 258
443 offending code: 259 offending code:
444 --------------- 260 ---------------
445 G4FastStep & G4FastStep::operator=(const G4Fas 261 G4FastStep & G4FastStep::operator=(const G4FastStep &right)
446 { 262 {
447 if (this != &right) 263 if (this != &right)
448 { 264 {
449 theListOfSecondaries = right.th 265 theListOfSecondaries = right.theListOfSecondaries;
450 theSizeOftheListOfSecondaries = right.th 266 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries;
451 theNumberOfSecondaries = right.th 267 theNumberOfSecondaries = right.theNumberOfSecondaries;
452 theStatusChange = right.th 268 theStatusChange = right.theStatusChange;
453 theMomentumChange = right.th 269 theMomentumChange = right.theMomentumChange;
454 thePolarizationChange = right.th 270 thePolarizationChange = right.thePolarizationChange;
455 thePositionChange = right.th 271 thePositionChange = right.thePositionChange;
456 theTimeChange = right.th 272 theTimeChange = right.theTimeChange;
457 theEnergyChange = right.th 273 theEnergyChange = right.theEnergyChange;
458 theTrueStepLength = right.th 274 theTrueStepLength = right.theTrueStepLength;
459 theLocalEnergyDeposit = right.th 275 theLocalEnergyDeposit = right.theLocalEnergyDeposit;
460 theSteppingControlFlag = right.th 276 theSteppingControlFlag = right.theSteppingControlFlag;
461 theWeightChange = right.th 277 theWeightChange = right.theWeightChange;
462 } 278 }
463 return *this; 279 return *this;
464 } 280 }
465 281
466 Diagnostic: 282 Diagnostic:
467 ---------- 283 ----------
468 Bug detected. 284 Bug detected.
469 285
470 Action: 286 Action:
471 ------- 287 -------
472 Insert the call 288 Insert the call
473 G4VParticleChange::operator=(right); 289 G4VParticleChange::operator=(right);
474 290
475 Status: 291 Status:
476 ------- 292 -------
477 Done, tested, system-tested on HP-aCC with e 293 Done, tested, system-tested on HP-aCC with exemple N05.
478 294
479 Modified files: 295 Modified files:
480 --------------- 296 ---------------
481 G4FastStep.cc 297 G4FastStep.cc
482 298
483 6) Warning: 299 6) Warning:
484 ----------- 300 -----------
485 include/G4FastStep.hh:59 301 include/G4FastStep.hh:59
486 Avoid data members in the public interface 302 Avoid data members in the public interface
487 Violation: Effective C++ item 20 303 Violation: Effective C++ item 20
488 Public data members for class G4FastStep: 304 Public data members for class G4FastStep:
489 debugFlag 305 debugFlag
490 306
491 307
492 offending code: 308 offending code:
493 --------------- 309 ---------------
494 public: 310 public:
495 ... 311 ...
496 G4bool debugFlag; 312 G4bool debugFlag;
497 313
498 Diagnostic: 314 Diagnostic:
499 ---------- 315 ----------
500 Historical usage. 316 Historical usage.
501 317
502 Action: 318 Action:
503 ------- 319 -------
504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 320 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file.
505 321
506 Modified files: 322 Modified files:
507 --------------- 323 ---------------
508 G4FastStep.hh, G4FastStep.cc 324 G4FastStep.hh, G4FastStep.cc
509 325
510 Status: 326 Status:
511 ------- 327 -------
512 Done, tested, system-tested on HP-aCC with e 328 Done, tested, system-tested on HP-aCC with exemple N05.
513 329
514 7) Warning: 330 7) Warning:
515 ----------- 331 -----------
516 include/G4FastStep.hh:59 332 include/G4FastStep.hh:59
517 If a class has virtual functions it shall 333 If a class has virtual functions it shall have a virtual destructor
518 Severe violation: Universal Coding Standar 334 Severe violation: Universal Coding Standards item 17
519 class G4FastStep has virtual functions wit 335 class G4FastStep has virtual functions without a virtual destructor.
520 336
521 337
522 offending code: 338 offending code:
523 --------------- 339 ---------------
524 ~G4FastStep(); 340 ~G4FastStep();
525 341
526 Diagnostic: 342 Diagnostic:
527 ---------- 343 ----------
528 Nobody should inherites from G4FastStep BUT 344 Nobody should inherites from G4FastStep BUT virtual added.
529 345
530 Action: 346 Action:
531 ------- 347 -------
532 virtual ~G4FastStep(); 348 virtual ~G4FastStep();
533 349
534 Modified files: 350 Modified files:
535 --------------- 351 ---------------
536 G4FastStep.hh 352 G4FastStep.hh
537 353
538 Status: 354 Status:
539 ------- 355 -------
540 Done, tested, system-tested on HP-aCC with e 356 Done, tested, system-tested on HP-aCC with exemple N05.
541 357
542 358
543 December 7, 1998 M. Verderi 359 December 7, 1998 M. Verderi
544 G4FastSimulationManagerProcess class: 360 G4FastSimulationManagerProcess class:
545 Fixes made for ghost navigation with 361 Fixes made for ghost navigation with
546 mag-field: 362 mag-field:
547 LocateGlobalPointAndUpdateTouchable is 363 LocateGlobalPointAndUpdateTouchable is
548 always used (in not the Locate...Setup 364 always used (in not the Locate...Setup
549 method) 365 method)
550 In PostStepDoIt: correction of position and 366 In PostStepDoIt: correction of position and
551 direction of the track are made when << 367 direction of the track are made when
552 possible in case of mag-field. 368 possible in case of mag-field.
553 This correction comes from the fact that a 369 This correction comes from the fact that a
554 small discrepancy appears on those quantitie 370 small discrepancy appears on those quantities
555 because of the numerical integration along 371 because of the numerical integration along
556 the field on the track path: the G4FSMP 372 the field on the track path: the G4FSMP
557 proposes a curve-length, the transportation 373 proposes a curve-length, the transportation
558 moves the track along this curve, however 374 moves the track along this curve, however
559 the end point position and direction are 375 the end point position and direction are
560 slightly different from those expected by 376 slightly different from those expected by
561 the G4FSMP when it proposed the length. 377 the G4FSMP when it proposed the length.
562 378
563 November 20,1998 M. Verderi 379 November 20,1998 M. Verderi
564 G4FastStep class: 380 G4FastStep class:
565 Remove track/G4BiasingTag.hh dependancy (ob 381 Remove track/G4BiasingTag.hh dependancy (obsolete).
566 Adapted to new shceme of Event Biasing mech 382 Adapted to new shceme of Event Biasing mechanism,
567 consistently with track-00-04-01 tag. 383 consistently with track-00-04-01 tag.
568 384
569 November 11,1998 M. Verderi 385 November 11,1998 M. Verderi
570 Merge of param-00-03-02 & param-00-03-02a i 386 Merge of param-00-03-02 & param-00-03-02a into
571 param-00-03-04a (hopefully...) 387 param-00-03-04a (hopefully...)
572 The point is the chnage of signature in the 388 The point is the chnage of signature in the
573 LocateGlobalPointAndSetup(..) of the G4Navi 389 LocateGlobalPointAndSetup(..) of the G4Navigator making use now
574 of the track direction. The G4FastSimulatio 390 of the track direction. The G4FastSimulationManagerProcess is
575 changed accordingly: 391 changed accordingly:
576 fGhostNavigator.LocateGlobalPointAndSetup(t 392 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true);
577 393
578 394
579 November 6, 1998 M. Verderi 395 November 6, 1998 M. Verderi
580 - Extension of the G4FastStep to allow the 396 - Extension of the G4FastStep to allow the biasing technic.
581 Changes are made in: 397 Changes are made in:
582 - G4FastStep.hh/.icc: 398 - G4FastStep.hh/.icc:
583 new member G4BiasingTa 399 new member G4BiasingTag fBiasTag;
584 new method SetPrimaryT 400 new method SetPrimaryTrackFinalBiasingTag
585 ( G4BiasingTag 401 ( G4BiasingTag aTag );
586 - G4FastStep.cc: 402 - G4FastStep.cc:
587 Initialize(); 403 Initialize();
588 operator=; << 404 operator=;
589 UpdateForPostStep(); 405 UpdateForPostStep();
590 UpdateForAtRest(); << 406 UpdateForAtRest();
591 407
592 October 26, 1998 P.Mora de Freitas 408 October 26, 1998 P.Mora de Freitas
593 - G4FastSimulationManagerProcess and G4Fast 409 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal
594 with at rest parameterisations also when 410 with at rest parameterisations also when using parallel geometry.
595 411
596 October 8, 1998 P.Mora de Freitas 412 October 8, 1998 P.Mora de Freitas
597 - The G4VFastSimulationModel::IsApplicable( 413 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual
598 methode. 414 methode.
599 - G4FastSimulationManager optimisation: 415 - G4FastSimulationManager optimisation:
600 - New G4ParticleDefinition* fLastCrossedP 416 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps
601 the last particle type with touched the 417 the last particle type with touched the envelope;
602 - New G4RWTPtrOrderedVector<G4VFastSimula 418 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList
603 data member, keeps the model list of th << 419 data member, keeps the model list of the applicable models for
604 the actual fLastCrossedParticle particl 420 the actual fLastCrossedParticle particle type;
605 - Changes in the PostStepGetFastSimulatio << 421 - Changes in the PostStepGetFastSimulationManagerTrigger() and
606 AtRestGetFastSimulationManagerTrigger() << 422 AtRestGetFastSimulationManagerTrigger()methodes to update the
607 fApplicableModelList when needed (fLast 423 fApplicableModelList when needed (fLastCrossedParticle !=
608 the actual tracked particle); 424 the actual tracked particle);
609 - Changes in the << 425 - Changes in the
610 G4FastSimulationManager() (Constructor) 426 G4FastSimulationManager() (Constructor)
611 ActivateFastSimulationModel(), 427 ActivateFastSimulationModel(),
612 InActivateFastSimulationModel(), 428 InActivateFastSimulationModel(),
613 AtRestGetFastSimulationManagerTrigger(), 429 AtRestGetFastSimulationManagerTrigger(),
614 AddFastSimulationModel(), 430 AddFastSimulationModel(),
615 RemoveFastSimulationModel() 431 RemoveFastSimulationModel()
616 methodes to set the fLastCrossedParticle to 432 methodes to set the fLastCrossedParticle to NULL, forcing the
617 fApplicableModelList to be rebuilt. 433 fApplicableModelList to be rebuilt.
618 434
619 September 22, 1998 P.Mora de Freitas 435 September 22, 1998 P.Mora de Freitas
620 Fixed bug in parallel navigation. << 436 Fixed bug in parallel navigation.
621 File touched: G4FastSimulationManagerProces 437 File touched: G4FastSimulationManagerProcess.cc
622 Tested on HP-aCC. 438 Tested on HP-aCC.
623 439
624 September 17, 1998 P.Mora de Freitas 440 September 17, 1998 P.Mora de Freitas
625 G4FastSimulationManager::RemoveFastSimulati 441 G4FastSimulationManager::RemoveFastSimulationModel() updated to look
626 for also in the fInactivatedModels list. 442 for also in the fInactivatedModels list.
627 443
628 Tested on HP-aCC. 444 Tested on HP-aCC.
629 445
630 September 16, 1998 P.Mora de Freitas 446 September 16, 1998 P.Mora de Freitas
631 New /param/ control commands: 447 New /param/ control commands:
632 448
633 /param/ActivateModel <ModelName> 449 /param/ActivateModel <ModelName>
634 /param/InActivateModel <ModelName> 450 /param/InActivateModel <ModelName>
635 451
636 Activate or inactivate a given parameterisat 452 Activate or inactivate a given parameterisation model.
637 453
638 Tested on HP-aCC. 454 Tested on HP-aCC.
639 455
640 August 21, 1998 P.Mora de Freitas 456 August 21, 1998 P.Mora de Freitas
641 G4FastSimulationManagerProcess's G4ProcessTy 457 G4FastSimulationManagerProcess's G4ProcessType set to
642 fParameterisation, accordingly with procman-00 458 fParameterisation, accordingly with procman-00-02-03.
643 459
644 Tested on HP-aCC. 460 Tested on HP-aCC.
645 461
646 August 12, 1998 P.Mora de Freitas 462 August 12, 1998 P.Mora de Freitas
647 Improved the "close parameterisation control << 463 Improved the "close parameterisation control" to
648 464
649 1) avoid the close looping when unnecessary 465 1) avoid the close looping when unnecessary (mostly cases);
650 2) force re-close when necessary (insert/rem 466 2) force re-close when necessary (insert/remove ghosts).
651 467
652 Changes: 468 Changes:
653 469
654 1) the G4GlobalFastSimulationManager::fClose << 470 1) the G4GlobalFastSimulationManager::fClosed is now initialised
655 to true by the G4GlobalFastSimulationMana 471 to true by the G4GlobalFastSimulationManager constructor;
656 472
657 2) new method << 473 2) new method
658 474
659 void << 475 void
660 G4GlobalFastSimulationManager::FastSimula 476 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed();
661 477
662 called by the AddGhostPlacement and Remov << 478 called by the AddGhostPlacement and RemoveGhostPlacement
663 G4FastSimulationManager methods to set fa 479 G4FastSimulationManager methods to set false the fClosed flag;
664 480
665 3) changes in the G4GlobalFastSimulationMana 481 3) changes in the G4GlobalFastSimulationManager::Notify method
666 to deal with these changes. 482 to deal with these changes.
667 483
668 Tested on HP-aCC. 484 Tested on HP-aCC.
669 485
670 August 11, 1998 P.Mora de Freitas 486 August 11, 1998 P.Mora de Freitas
671 Fix to the G4FastStep::KillPrimaryTrack() me 487 Fix to the G4FastStep::KillPrimaryTrack() method to drop the
672 nonsense line 488 nonsense line
673 489
674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 490 SetMomentumChange(0.,0.,0.) ; /* necessary ? */
675 491
676 Tested on HP-aCC. 492 Tested on HP-aCC.
677 (Thanks to Willy Langeveld) 493 (Thanks to Willy Langeveld)
678 494
679 495
680 August 10, 1998 P.Mora de Freitas 496 August 10, 1998 P.Mora de Freitas
681 Fix to the SetPrimaryTrackFinalKineticEnergy 497 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method
682 from the G4FastStep class the SetMomentumChang 498 from the G4FastStep class the SetMomentumChange() call to insure that
683 the new momentum direction is a unit vector (a << 499 the new momentum direction is a unit vector (as asked by the
684 G4DynamicParticle::SetMomentumDirection method 500 G4DynamicParticle::SetMomentumDirection method).
685 501
686 Touched files: G4FastStep.hh (improved comme 502 Touched files: G4FastStep.hh (improved comments)
687 G4FastStep.cc (fixed) 503 G4FastStep.cc (fixed)
688 504
689 Tested on HP-aCC. 505 Tested on HP-aCC.
690 (Thanks to Willy Langeveld) 506 (Thanks to Willy Langeveld)
691 507
692 August 7, 1998 P.Mora de Freitas 508 August 7, 1998 P.Mora de Freitas
693 New /param/ commands directory with the comm 509 New /param/ commands directory with the commands:
694 510
695 /param/listEnvelopes [ParticleName] 511 /param/listEnvelopes [ParticleName]
696 512
697 - List all the envelope names for a given pa 513 - List all the envelope names for a given particle
698 (or for all particles if without parameter 514 (or for all particles if without parameters).
699 515
700 /param/listModels [EnvelopeName] 516 /param/listModels [EnvelopeName]
701 517
702 - List all the Model names for a given envel 518 - List all the Model names for a given envelope
703 (or for all envelopes if without parameter 519 (or for all envelopes if without parameters).
704 520
705 /param/listIsApplicable [ModelName] 521 /param/listIsApplicable [ModelName]
706 522
707 - List all the particle names a given model 523 - List all the particle names a given model is applicable
708 (or for all models if without parameters). 524 (or for all models if without parameters).
709 525
710 526
711 August 7, 1998 P.Mora de Freitas 527 August 7, 1998 P.Mora de Freitas
712 History file Created. 528 History file Created.