| Geant4 Cross Reference |
1 # Category param History << 1 $Id: History,v 1.14 2001/10/26 15:27:06 mverderi Exp $
>> 2 -------------------------------------------------------------------
2 3
3 See `CONTRIBUTING.rst` for details of **requir << 4 =========================================================
4 which **must** added in reverse chronological << 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP
5 It must **not** be used as a substitute for wr << 6 =========================================================
6 << 7
7 ---------------------------------------------- << 8 Category History file
8 << 9 ---------------------
9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) << 10 This file should be used by G4 developers and category coordinators
10 - In G4GlobalFastSimulationManager: << 11 to briefly summarize all major modifications introduced in the code
11 use G4ThreadLocalSingleton to avoid undelete << 12 and keep track of all category-tags.
12 << 13 It DOES NOT substitute the CVS log-message one should put at every
13 ## 2023-10-18 Ben Morgan (param-V11-01-03) << 14 committal in the CVS repository !
14 - Apply standard and extended clang-tidy fixes << 15
15 - Mark empty/obsolete functions as deprecated << 16 ----------------------------------------------------------
16 << 17 * Reverse chronological order (last date on top), please *
17 ## 2023-10-16 Ben Morgan (param-V11-01-02) << 18 ----------------------------------------------------------
18 - Apply standard clang-format-ing. <<
19 - Normal order accessors and docstrings. <<
20 <<
21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) <<
22 - In G4FastTrack, removed references to G4Touc <<
23 which is now deprecated. <<
24 <<
25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 <<
26 - Added missing virtual destructor to G4VFastS <<
27 <<
28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) <<
29 - Fixed compilation warnings for implicit type <<
30 <<
31 ## 2022-10-27 Makoto Asai (param-V11-00-03) <<
32 - G4FastSimHitMaker - making compatible to com <<
33 <<
34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 <<
35 - G4FastStep - delete copy constructor and ope <<
36 <<
37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) <<
38 - Adding the 'flush' method to the fast simula <<
39 This method allows to process the input buff <<
40 the end of the G4 event. It is used when par <<
41 The 'flash' is triggered inside the event lo <<
42 The fast simulation model may add secondarie <<
43 by Geant4. <<
44 <<
45 ## 2021-12-10 Ben Morgan (param-V11-00-00) <<
46 - Change to new Markdown History format <<
47 <<
48 --- <<
49 <<
50 # History entries prior to 11.0 <<
51 <<
52 April 16, 2021 Ben Morgan (param-V10-07-00) <<
53 - Migrate build to modular CMake API <<
54 <<
55 October 5, 2020, A. Zaborowska (param-V10-06-0 <<
56 - Introduce general facilities based on GFlash <<
57 to facilitate multiple hit (energy & positio <<
58 from fast simulation models. <<
59 <<
60 September 9, 2020, G. Cosmo (param-V10-06-02) <<
61 - Fixed minor Coverity defect for uninitialise <<
62 <<
63 April 21, 2020, A. Zaborowska (param-V10-06-01 <<
64 - Sanity check for root logical volumes for re <<
65 UI command /param/showSetup works also if no <<
66 <<
67 March 26, 2020, I. Semeniouk (param-V10-06-00) <<
68 - G4FastSimulationHelper : merge ActivateFastS <<
69 - G4FastSimulationManager.hh, G4VFastSimulatio <<
70 redefinition of G4Envelope type <<
71 <<
72 October 30, 2019, A. Zaborowska (param-v10-05- <<
73 - Register G4FastSimulationManagerProcess with <<
74 G4FastSimulationManagerHelper to ensure it i <<
75 invoked for a given step (ExclusivelyForced) <<
76 StronglyForced processes will be considered. <<
77 <<
78 December 19, 2017, G. Cosmo (param-V10-04-00) <<
79 - Fixed self-consistency in G4FastSimulationVe <<
80 Thanks to Raphael Isemann for reporting this <<
81 <<
82 November 03, 2016, M. Verderi (param-V10-02-01 <<
83 - New G4FastSimulationManagerHelper utility fo <<
84 adding G4FastSimulationManagerProcess to a <<
85 process manager. <<
86 <<
87 November 02, 2016, M. Verderi (param-V10-02-00 <<
88 - fix various Coverity defects. <<
89 <<
90 March 27, 2013, M. Verderi (param-V09-06-00) <<
91 - remove unused field 'fOnBoundary' in G4FastS <<
92 as this was causing a warning from clang. <<
93 <<
94 July 10, 2012, G. Cosmo (param-V09-05-00) <<
95 - Explicitly use inclusion of headers for syst <<
96 constants, in plan to remove implicit inclus <<
97 <<
98 September 30, 2011, M. Verderi (param-V09-04-0 <<
99 - Added missing new header file (G4FastSimulat <<
100 sources.cmake. <<
101 <<
102 September 30, 2011, M. Verderi (param-V09-04-0 <<
103 - Migration to new G4Exception scheme. <<
104 - what is V09-04-01 tag ? <<
105 <<
106 February 11, 2011, M. Verderi (param-V09-04-00 <<
107 - Implementation of method <<
108 void ProposePrimaryTrackFinalKineticEnergy ( <<
109 was missing : modified file G4FastStep.icc <<
110 <<
111 March 13, 2008, G. Cosmo (param-V09-01-00) <<
112 - Cleared compilation warnings in G4FastSimula <<
113 G4FastSimulationMessenger on gcc-4.3.0 for a <<
114 parentheses in nested if-else statements. <<
115 <<
116 November 30, 2007, M. Verderi <<
117 - Add Along methods to G4FSMP process <<
118 - tag as param-V09-00-01 <<
119 <<
120 November 30, 2007, M. Verderi <<
121 - minor corrections to G4FastSimulationManager <<
122 * add call fPathFinder->prepareNewrack(...) <<
123 * deactivate ghost navigator in EndOfTracki <<
124 - tag as param-V09-00-00 <<
125 <<
126 May 18, 2007, M. Verderi <<
127 - tag as param-V08-03-00 <<
128 <<
129 May 11, 2007, M. Verderi <<
130 - remove include/G4FastSimulationManagerProces <<
131 include/G4FlavoredParallelWorld.hh <<
132 include/G4GFSManager81.hh <<
133 src/G4FastSimulationManagerProcess81. <<
134 src/G4GFSManager81.cc <<
135 <<
136 <<
137 November 10, 2006, M. Verderi - param-V08-01-0 <<
138 - Limited number of warning messages printed b <<
139 G4GlobalFastSimulationManager. <<
140 - Renamed G4FastSimulationManagerProcess_forCo <<
141 G4FastSimulationManagerProcess81. <<
142 In addition, this class can now handle the c <<
143 i.e., the navigator for tracking, regardless <<
144 G4CoupledTransportation is used. (For other <<
145 of course no choice, and G4CoupledTransporta <<
146 <<
147 November 3, 2006 M. Verderi <<
148 - Introduced G4FastSimulationManagerProcess_fo <<
149 handling fast simulation in new parallel geo <<
150 the G4CoupledTransportation to be active. <<
151 - Introduced G4GFSManager81 class that gathers <<
152 default at next major release in the G4Globa <<
153 - G4FastSimulationManager: adapted to new sche <<
154 backward compatibilty. <<
155 - G4FastSimulationManagerProcess: mostly the s <<
156 - G4FastSimulationMessenger: new command creat <<
157 to show the fast simulation setup (region, m <<
158 It is only valid for geometry closed state. <<
159 command in the run manager for this. <<
160 <<
161 November 25, 2005, M.Verderi - param-V07-01-0 <<
162 - put back Makoto's change: StartTracking(G4Tr <<
163 <<
164 November 25, 2005, M Verderi - param-V07-01-03 <<
165 - Make ghost functionnality available with G4R <<
166 - ** Note ** Change back StartTracking(G4Track <<
167 StartTracking(G4Track*) was intro <<
168 because (I guess) of procman-V07-01-01 <<
169 This is to make param-V07-01-03 compatible w <<
170 <<
171 November 21, 2005 M.Asai - param-V07-01-02 <<
172 - Fix warning message. <<
173 <<
174 November 02, 2005 G.Cosmo - param-V07-01-01 <<
175 - Corrected setting of envelope volumes and so <<
176 - Migrated old scheme for G4Exception and some <<
177 <<
178 October 28, 2005 M.Asai - param-V07-01-00 <<
179 - Working tag for merging "envelope" to G4Regi <<
180 <<
181 December 07, 2004 G. Cosmo - param-V06-02-01 <<
182 - Implemented migration to <cmath>. <<
183 <<
184 November 26, 2004 M. Verderi - param-V06-02-00 <<
185 - Implemented migration to new G4VParticleChan <<
186 <<
187 December 12, 2003 G. Cosmo - param-V06-00-00 <<
188 - G4FastSimulationVector.icc: use std_pvector: <<
189 base class. Fixes compilation problem on Int <<
190 <<
191 November 10, 2003 G. Cosmo - param-V05-02-01 <<
192 - G4FastTrack: use G4Navigator::CreateTouchabl <<
193 CreateTouchableHistory() in method FRecordsA <<
194 <<
195 October 4, 2003 G. Cosmo - param-V05-02-00 <<
196 - Modified GNUmakefile: <<
197 o added dependency to new module "geometry/n <<
198 - Coworks with "geometry-V05-02-00" and "digit <<
199 <<
200 May 21, 2003 G. Cosmo - param-V05-01-00 <<
201 o Fixed pedantic warnings on Linux-g++ <<
202 o Call base class in copy-constructor <<
203 <<
204 Nov 20, 2002 G. Cosmo - param-V04-01-02 <<
205 o Patched access to public static data in G4 <<
206 and G4GlobalFastSimulationManager.cc to al <<
207 Windows DLLs. <<
208 <<
209 Nov 15, 2002 S. Sadilov - param-V04-01-01 <<
210 o Fixed compilation problems on Windows in <<
211 G4FastSimulationManager.cc and G4GlobalFas <<
212 <<
213 Nov 02, 2002 M. Verderi - param-V04-01-00 <<
214 o Add method to retrieve G4VFastSimulationMo <<
215 The user's method is in G4GlobalFastSimula <<
216 <<
217 GetFastSimulationModel(); <<
218 <<
219 it is accompagnied by same methods name in <<
220 G4FastSimulationManager class. <<
221 <<
222 o Add "test" directory, used to test above f <<
223 19
224 Oct 26, 2001 M. Verderi - param-V03-02-00 20 Oct 26, 2001 M. Verderi - param-V03-02-00
225 Fixes to clear warnings produced with gcc-2. 21 Fixes to clear warnings produced with gcc-2.95.2:
226 - loop index, where comparison with method " 22 - loop index, where comparison with method "size()" of
227 G4std::vector<T>, changed: int -> size_t << 23 G4std::vector<T>, changed: int -> size_t
228 - change "if ( a=b ) {..}" by "if ( (a=b) ) 24 - change "if ( a=b ) {..}" by "if ( (a=b) ) {...}"
229 this makes the compiler sure you want to mak 25 this makes the compiler sure you want to make an
230 assignement in the "if" condition 26 assignement in the "if" condition
231 - re-order initialisations of a few variable 27 - re-order initialisations of a few variables in constructors
232 to match the declaration order. 28 to match the declaration order.
233 Some warnings still exist, but regard the G4 29 Some warnings still exist, but regard the G4Propagator of geometry.
234 30
235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 31 Apr 3, 2001 J. Apostolakis - param-V03-00-00
236 - Modified G4FastSimulationManagerProcess call 32 - Modified G4FastSimulationManagerProcess call to PropagatorInField ComputeStep
237 to use new interface with G4FieldTrack (in 33 to use new interface with G4FieldTrack (in place of now obsolete interface.)
238 34
239 Nov 14, 2000 G. Cosmo - param-V02-00-01 35 Nov 14, 2000 G. Cosmo - param-V02-00-01
240 - Moved specific parameterisation models to th 36 - Moved specific parameterisation models to the new top category
241 "parameterisations". Moved files: 37 "parameterisations". Moved files:
242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm 38 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRmodel[.hh.cc],
243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster 39 G4IrregularXrayTRmodel[.hh.cc], G4PAIclusterModel[.hh.cc],
244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr 40 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXrayTRmodel[.hh.cc],
245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode 41 G4RegularXrayTRmodel[.hh.cc], G4VClusterModel[.hh.cc],
246 G4VXrayTRmodel[.hh.cc]. 42 G4VXrayTRmodel[.hh.cc].
247 - Cleaned-up GNUmakefile of non necessary depe 43 - Cleaned-up GNUmakefile of non necessary dependencies.
248 44
249 Aug 03, 2000 G. Cosmo - param-V02-00-00r 45 Aug 03, 2000 G. Cosmo - param-V02-00-00r
250 - Changed RandGauss to G4RandGauss in G4Irregu 46 - Changed RandGauss to G4RandGauss in G4IrregularXrayTRmodel.cc and
251 G4VXrayTRmodel.cc to fix events' reproducibi 47 G4VXrayTRmodel.cc to fix events' reproducibility problem.
252 - G4VXrayTRmodel.cc: fix to class destructor ( 48 - G4VXrayTRmodel.cc: fix to class destructor (V.Grichine)
253 49
254 Jun 15, 2000 G. Cosmo - param-V01-01-04 50 Jun 15, 2000 G. Cosmo - param-V01-01-04
255 - The tag coworks with global-V01-01-04 and ma 51 - The tag coworks with global-V01-01-04 and materials-V01-01-00:
256 o Fixed usage of G4complex type for ISO and 52 o Fixed usage of G4complex type for ISO and non-ISO compilers.
257 Affected files: G4FoamXrayTRmodel.cc, G4Ga 53 Affected files: G4FoamXrayTRmodel.cc, G4GamDistrXrayTRmodel.cc, G4PlateIrrGasXrayTRmodel.cc
258 and G4RegularXrayTRmodel.c 54 and G4RegularXrayTRmodel.cc.
259 In case of G4complex types passed to mathe 55 In case of G4complex types passed to mathematical functions, use G4std:: prefix.
260 o Fixed usage of G4Integrator class, now cha 56 o Fixed usage of G4Integrator class, now changed to templated to allow porting of the
261 code on SUN-CC compiler which does not imp 57 code on SUN-CC compiler which does not implement templated member functions.
262 Affected files: G4VXrayTRmodel[.hh.cc] 58 Affected files: G4VXrayTRmodel[.hh.cc]
263 59
264 Jun 6, 2000 M. Verderi & P. Mora de Freitas 60 Jun 6, 2000 M. Verderi & P. Mora de Freitas
265 - fixed compilation errors with HP-aCC for the 61 - fixed compilation errors with HP-aCC for the files G4RegularXrayTRmodel.cc,
266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod 62 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmodel.cc.
267 63
268 May 30, 2000 M. Verderi & P. Mora de Freitas 64 May 30, 2000 M. Verderi & P. Mora de Freitas
269 65
270 - parameterisation category is now RW free. 66 - parameterisation category is now RW free.
271 67
272 September 16, 1999 M. Verderi & P. Mora de Fre 68 September 16, 1999 M. Verderi & P. Mora de Freitas
273 69
274 - Fixed bug in G4FastStep::CheckIt() method. 70 - Fixed bug in G4FastStep::CheckIt() method.
275 71
276 April 19, 1999 M. Verderi & P. Mora de Freitas 72 April 19, 1999 M. Verderi & P. Mora de Freitas
277 73
278 Changes in G4FastStep to co-work with track-01 74 Changes in G4FastStep to co-work with track-01-00-04:
279 75
280 1) The method void CheckIt(const G4Track&) bec << 76 1) The method void CheckIt(const G4Track&) becomes
281 G4bool CheckIt(const G4Track&); 77 G4bool CheckIt(const G4Track&);
282 2) The FAST_STEP_DEBUG compiling option disapp 78 2) The FAST_STEP_DEBUG compiling option disappears;
283 3) Call to CheckIt controled by the G4VParticl 79 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute.
284 80
285 Miscellaneous: the declaration "G4double mass 81 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh
286 corrected to G4double mass =...". 82 corrected to G4double mass =...".
287 83
288 April 15, 1999 M. Verderi & P. Mora de Freitas 84 April 15, 1999 M. Verderi & P. Mora de Freitas
289 85
290 Tasks to decouple visualization from processes 86 Tasks to decouple visualization from processes/parameterisation:
291 87
292 1) G4GlobalFastSimulationManager now inherites 88 1) G4GlobalFastSimulationManager now inherites from the intercoms/
293 G4VGlobalFastSimulationManager to allow visual << 89 G4VGlobalFastSimulationManager to allow visualisation to get a
294 concrete instance pointer to the G4GlobalFastS 90 concrete instance pointer to the G4GlobalFastSimulationManager,
295 if any. 91 if any.
296 92
297 2) G4FlavoredParallelWorld now inherites from 93 2) G4FlavoredParallelWorld now inherites from the intercoms/
298 G4VFlavoredParallelWorld, a pure virtual abstr 94 G4VFlavoredParallelWorld, a pure virtual abstract class to interface
299 parameterisation with visualization. 95 parameterisation with visualization.
300 96
301 Co-works with intercoms-01-00-01 tag 97 Co-works with intercoms-01-00-01 tag
302 98
303 Modified files: 99 Modified files:
304 --------------- 100 ---------------
305 G4FlavoredParallelWorld.hh 101 G4FlavoredParallelWorld.hh
306 G4GlobalFastSimulationManager.hh 102 G4GlobalFastSimulationManager.hh
307 G4GlobalFastSimulationManager.cc 103 G4GlobalFastSimulationManager.cc
308 104
309 Done, tested, system-tested on HP-aCC with exe 105 Done, tested, system-tested on HP-aCC with exemple N05.
310 106
311 April 14, 1999 M. Verderi & P. Mora de Freitas 107 April 14, 1999 M. Verderi & P. Mora de Freitas
312 108
313 Several consolidation tasks (thanks to G. Cosm 109 Several consolidation tasks (thanks to G. Cosmo):
314 110
315 1) Warning: << 111 1) Warning:
316 ----------- 112 -----------
317 113
318 Pointers usage 114 Pointers usage
319 115
320 - Setting pointers to 0 after delete: 116 - Setting pointers to 0 after delete:
321 117
322 delete pA; 118 delete pA;
323 pA = 0; 119 pA = 0;
324 120
325 - Avoid to use "NULL". 121 - Avoid to use "NULL".
326 122
327 Modified files: 123 Modified files:
328 --------------- 124 ---------------
329 G4FastSimulationManager.hh 125 G4FastSimulationManager.hh
330 G4FastTrack.hh 126 G4FastTrack.hh
331 G4FlavoredParallelWorld.hh 127 G4FlavoredParallelWorld.hh
332 G4FastSimulationManager.cc 128 G4FastSimulationManager.cc
333 G4FastSimulationMessenger.cc 129 G4FastSimulationMessenger.cc
334 G4FastSimulationManagerProcess.cc 130 G4FastSimulationManagerProcess.cc
335 G4FastTrack.cc 131 G4FastTrack.cc
336 G4GlobalFastSimulationManager.cc 132 G4GlobalFastSimulationManager.cc
337 G4VFastSimulationModel.cc 133 G4VFastSimulationModel.cc
338 134
339 Status: << 135 Status:
340 ------- 136 -------
341 Done, tested, system-tested on HP-aCC with exe 137 Done, tested, system-tested on HP-aCC with exemple N05.
342 138
343 2) Warning: 139 2) Warning:
344 ----------- 140 -----------
345 include/G4FastSimulationManager.hh:163 141 include/G4FastSimulationManager.hh:163
346 Public member functions shall always retur 142 Public member functions shall always return const handles to member data
347 Severe violation: Universal Coding Standar 143 Severe violation: Universal Coding Standards item 18
348 144
349 offending code: 145 offending code:
350 --------------- 146 ---------------
351 inline G4VParticleChange* G4FastSimulationMana 147 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange()
352 { 148 {
353 return &fFastStep; 149 return &fFastStep;
354 } 150 }
355 151
356 Diagnostic: 152 Diagnostic:
357 ---------- 153 ----------
358 154
359 Called by the G4FastSimulationManagerProcess << 155 Called by the G4FastSimulationManagerProcess to return it in the
360 PostStepDoIt call. << 156 PostStepDoIt call.
361 157
362 Action: 158 Action:
363 ------- 159 -------
364 The G4FastSimulationManager::GettheParticleCha 160 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any
365 more. The G4VParticleChange* is now returned d 161 more. The G4VParticleChange* is now returned directly when invoking the
366 G4FastSimulationManager::InvokePostStepDoIt() 162 G4FastSimulationManager::InvokePostStepDoIt() and
367 G4FastSimulationManager::InvokeAtRestDoIt() me 163 G4FastSimulationManager::InvokeAtRestDoIt() methodes.
368 164
369 Modified files: 165 Modified files:
370 --------------- 166 ---------------
371 G4FastSimulationManager.hh 167 G4FastSimulationManager.hh
372 G4FastSimulationManager.cc 168 G4FastSimulationManager.cc
373 G4FastSimulationManagerProcess.cc 169 G4FastSimulationManagerProcess.cc
374 170
375 Status: << 171 Status:
376 ------- 172 -------
377 Done, tested, system-tested on HP-aCC with exe 173 Done, tested, system-tested on HP-aCC with exemple N05.
378 174
379 3) Warning: 175 3) Warning:
380 ----------- 176 -----------
381 include/G4FastSimulationManagerProcess.hh:52 177 include/G4FastSimulationManagerProcess.hh:52
382 If a class has virtual functions it shall 178 If a class has virtual functions it shall have a virtual destructor
383 Severe violation: Universal Coding Standar 179 Severe violation: Universal Coding Standards item 17
384 class G4FastSimulationManagerProcess has v 180 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor.
385 181
386 offending code: 182 offending code:
387 --------------- 183 ---------------
388 ~G4FastSimulationManagerProcess(); 184 ~G4FastSimulationManagerProcess();
389 185
390 Diagnostic: 186 Diagnostic:
391 ---------- 187 ----------
392 Nobody should inherites from G4FastSimulatio << 188 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual
393 is added. 189 is added.
394 190
395 Action: 191 Action:
396 ------- 192 -------
397 virtual ~G4FastSimulationManagerProcess(); 193 virtual ~G4FastSimulationManagerProcess();
398 194
399 Modified files: 195 Modified files:
400 --------------- 196 ---------------
401 G4FastSimulationManagerProcess.hh 197 G4FastSimulationManagerProcess.hh
402 198
403 Status: << 199 Status:
404 ------- 200 -------
405 Done. 201 Done.
406 202
407 4) Warning: 203 4) Warning:
408 ----------- 204 -----------
409 include/G4FastSimulationMessenger.hh:36 205 include/G4FastSimulationMessenger.hh:36
410 If a class has virtual functions it shall 206 If a class has virtual functions it shall have a virtual destructor
411 Severe violation: Universal Coding Standar 207 Severe violation: Universal Coding Standards item 17
412 class G4FastSimulationMessenger has virtua 208 class G4FastSimulationMessenger has virtual functions without a virtual destructor.
413 209
414 210
415 offending code: 211 offending code:
416 --------------- 212 ---------------
417 ~G4FastSimulationMessenger(); 213 ~G4FastSimulationMessenger();
418 214
419 Diagnostic: 215 Diagnostic:
420 ---------- 216 ----------
421 Nobody should inherites from G4FastSimulatio << 217 Nobody should inherites from G4FastSimulationMessenger BUT for virtual
422 is added. 218 is added.
423 219
424 Action: 220 Action:
425 ------- 221 -------
426 virtual ~G4FastSimulationMessenger(); 222 virtual ~G4FastSimulationMessenger();
427 223
428 Modified files: 224 Modified files:
429 --------------- 225 ---------------
430 G4FastSimulationMessenger.hh 226 G4FastSimulationMessenger.hh
431 227
432 Status: << 228 Status:
433 ------- 229 -------
434 Done. 230 Done.
435 231
436 5) Warning: 232 5) Warning:
437 ----------- 233 -----------
438 include/G4FastStep.hh:224 234 include/G4FastStep.hh:224
439 Operator= should call base class operator= 235 Operator= should call base class operator=
440 Possible severe violation: Effective C++ i 236 Possible severe violation: Effective C++ item 16
441 operator= in class G4FastStep, should call 237 operator= in class G4FastStep, should call operator= in base class G4VParticleChange
442 238
443 offending code: 239 offending code:
444 --------------- 240 ---------------
445 G4FastStep & G4FastStep::operator=(const G4Fas 241 G4FastStep & G4FastStep::operator=(const G4FastStep &right)
446 { 242 {
447 if (this != &right) 243 if (this != &right)
448 { 244 {
449 theListOfSecondaries = right.th 245 theListOfSecondaries = right.theListOfSecondaries;
450 theSizeOftheListOfSecondaries = right.th 246 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries;
451 theNumberOfSecondaries = right.th 247 theNumberOfSecondaries = right.theNumberOfSecondaries;
452 theStatusChange = right.th 248 theStatusChange = right.theStatusChange;
453 theMomentumChange = right.th 249 theMomentumChange = right.theMomentumChange;
454 thePolarizationChange = right.th 250 thePolarizationChange = right.thePolarizationChange;
455 thePositionChange = right.th 251 thePositionChange = right.thePositionChange;
456 theTimeChange = right.th 252 theTimeChange = right.theTimeChange;
457 theEnergyChange = right.th 253 theEnergyChange = right.theEnergyChange;
458 theTrueStepLength = right.th 254 theTrueStepLength = right.theTrueStepLength;
459 theLocalEnergyDeposit = right.th 255 theLocalEnergyDeposit = right.theLocalEnergyDeposit;
460 theSteppingControlFlag = right.th 256 theSteppingControlFlag = right.theSteppingControlFlag;
461 theWeightChange = right.th 257 theWeightChange = right.theWeightChange;
462 } 258 }
463 return *this; 259 return *this;
464 } 260 }
465 261
466 Diagnostic: 262 Diagnostic:
467 ---------- 263 ----------
468 Bug detected. 264 Bug detected.
469 265
470 Action: 266 Action:
471 ------- 267 -------
472 Insert the call 268 Insert the call
473 G4VParticleChange::operator=(right); 269 G4VParticleChange::operator=(right);
474 270
475 Status: 271 Status:
476 ------- 272 -------
477 Done, tested, system-tested on HP-aCC with e 273 Done, tested, system-tested on HP-aCC with exemple N05.
478 274
479 Modified files: 275 Modified files:
480 --------------- 276 ---------------
481 G4FastStep.cc 277 G4FastStep.cc
482 278
483 6) Warning: 279 6) Warning:
484 ----------- 280 -----------
485 include/G4FastStep.hh:59 281 include/G4FastStep.hh:59
486 Avoid data members in the public interface 282 Avoid data members in the public interface
487 Violation: Effective C++ item 20 283 Violation: Effective C++ item 20
488 Public data members for class G4FastStep: 284 Public data members for class G4FastStep:
489 debugFlag 285 debugFlag
490 286
491 287
492 offending code: 288 offending code:
493 --------------- 289 ---------------
494 public: 290 public:
495 ... 291 ...
496 G4bool debugFlag; 292 G4bool debugFlag;
497 293
498 Diagnostic: 294 Diagnostic:
499 ---------- 295 ----------
500 Historical usage. 296 Historical usage.
501 297
502 Action: 298 Action:
503 ------- 299 -------
504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 300 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file.
505 301
506 Modified files: 302 Modified files:
507 --------------- 303 ---------------
508 G4FastStep.hh, G4FastStep.cc 304 G4FastStep.hh, G4FastStep.cc
509 305
510 Status: 306 Status:
511 ------- 307 -------
512 Done, tested, system-tested on HP-aCC with e 308 Done, tested, system-tested on HP-aCC with exemple N05.
513 309
514 7) Warning: 310 7) Warning:
515 ----------- 311 -----------
516 include/G4FastStep.hh:59 312 include/G4FastStep.hh:59
517 If a class has virtual functions it shall 313 If a class has virtual functions it shall have a virtual destructor
518 Severe violation: Universal Coding Standar 314 Severe violation: Universal Coding Standards item 17
519 class G4FastStep has virtual functions wit 315 class G4FastStep has virtual functions without a virtual destructor.
520 316
521 317
522 offending code: 318 offending code:
523 --------------- 319 ---------------
524 ~G4FastStep(); 320 ~G4FastStep();
525 321
526 Diagnostic: 322 Diagnostic:
527 ---------- 323 ----------
528 Nobody should inherites from G4FastStep BUT 324 Nobody should inherites from G4FastStep BUT virtual added.
529 325
530 Action: 326 Action:
531 ------- 327 -------
532 virtual ~G4FastStep(); 328 virtual ~G4FastStep();
533 329
534 Modified files: 330 Modified files:
535 --------------- 331 ---------------
536 G4FastStep.hh 332 G4FastStep.hh
537 333
538 Status: 334 Status:
539 ------- 335 -------
540 Done, tested, system-tested on HP-aCC with e 336 Done, tested, system-tested on HP-aCC with exemple N05.
541 337
542 338
543 December 7, 1998 M. Verderi 339 December 7, 1998 M. Verderi
544 G4FastSimulationManagerProcess class: 340 G4FastSimulationManagerProcess class:
545 Fixes made for ghost navigation with 341 Fixes made for ghost navigation with
546 mag-field: 342 mag-field:
547 LocateGlobalPointAndUpdateTouchable is 343 LocateGlobalPointAndUpdateTouchable is
548 always used (in not the Locate...Setup 344 always used (in not the Locate...Setup
549 method) 345 method)
550 In PostStepDoIt: correction of position and 346 In PostStepDoIt: correction of position and
551 direction of the track are made when << 347 direction of the track are made when
552 possible in case of mag-field. 348 possible in case of mag-field.
553 This correction comes from the fact that a 349 This correction comes from the fact that a
554 small discrepancy appears on those quantitie 350 small discrepancy appears on those quantities
555 because of the numerical integration along 351 because of the numerical integration along
556 the field on the track path: the G4FSMP 352 the field on the track path: the G4FSMP
557 proposes a curve-length, the transportation 353 proposes a curve-length, the transportation
558 moves the track along this curve, however 354 moves the track along this curve, however
559 the end point position and direction are 355 the end point position and direction are
560 slightly different from those expected by 356 slightly different from those expected by
561 the G4FSMP when it proposed the length. 357 the G4FSMP when it proposed the length.
562 358
563 November 20,1998 M. Verderi 359 November 20,1998 M. Verderi
564 G4FastStep class: 360 G4FastStep class:
565 Remove track/G4BiasingTag.hh dependancy (ob 361 Remove track/G4BiasingTag.hh dependancy (obsolete).
566 Adapted to new shceme of Event Biasing mech 362 Adapted to new shceme of Event Biasing mechanism,
567 consistently with track-00-04-01 tag. 363 consistently with track-00-04-01 tag.
568 364
569 November 11,1998 M. Verderi 365 November 11,1998 M. Verderi
570 Merge of param-00-03-02 & param-00-03-02a i 366 Merge of param-00-03-02 & param-00-03-02a into
571 param-00-03-04a (hopefully...) 367 param-00-03-04a (hopefully...)
572 The point is the chnage of signature in the 368 The point is the chnage of signature in the
573 LocateGlobalPointAndSetup(..) of the G4Navi 369 LocateGlobalPointAndSetup(..) of the G4Navigator making use now
574 of the track direction. The G4FastSimulatio 370 of the track direction. The G4FastSimulationManagerProcess is
575 changed accordingly: 371 changed accordingly:
576 fGhostNavigator.LocateGlobalPointAndSetup(t 372 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true);
577 373
578 374
579 November 6, 1998 M. Verderi 375 November 6, 1998 M. Verderi
580 - Extension of the G4FastStep to allow the 376 - Extension of the G4FastStep to allow the biasing technic.
581 Changes are made in: 377 Changes are made in:
582 - G4FastStep.hh/.icc: 378 - G4FastStep.hh/.icc:
583 new member G4BiasingTa 379 new member G4BiasingTag fBiasTag;
584 new method SetPrimaryT 380 new method SetPrimaryTrackFinalBiasingTag
585 ( G4BiasingTag 381 ( G4BiasingTag aTag );
586 - G4FastStep.cc: 382 - G4FastStep.cc:
587 Initialize(); 383 Initialize();
588 operator=; << 384 operator=;
589 UpdateForPostStep(); 385 UpdateForPostStep();
590 UpdateForAtRest(); << 386 UpdateForAtRest();
591 387
592 October 26, 1998 P.Mora de Freitas 388 October 26, 1998 P.Mora de Freitas
593 - G4FastSimulationManagerProcess and G4Fast 389 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal
594 with at rest parameterisations also when 390 with at rest parameterisations also when using parallel geometry.
595 391
596 October 8, 1998 P.Mora de Freitas 392 October 8, 1998 P.Mora de Freitas
597 - The G4VFastSimulationModel::IsApplicable( 393 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual
598 methode. 394 methode.
599 - G4FastSimulationManager optimisation: 395 - G4FastSimulationManager optimisation:
600 - New G4ParticleDefinition* fLastCrossedP 396 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps
601 the last particle type with touched the 397 the last particle type with touched the envelope;
602 - New G4RWTPtrOrderedVector<G4VFastSimula 398 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList
603 data member, keeps the model list of th << 399 data member, keeps the model list of the applicable models for
604 the actual fLastCrossedParticle particl 400 the actual fLastCrossedParticle particle type;
605 - Changes in the PostStepGetFastSimulatio << 401 - Changes in the PostStepGetFastSimulationManagerTrigger() and
606 AtRestGetFastSimulationManagerTrigger() << 402 AtRestGetFastSimulationManagerTrigger()methodes to update the
607 fApplicableModelList when needed (fLast 403 fApplicableModelList when needed (fLastCrossedParticle !=
608 the actual tracked particle); 404 the actual tracked particle);
609 - Changes in the << 405 - Changes in the
610 G4FastSimulationManager() (Constructor) 406 G4FastSimulationManager() (Constructor)
611 ActivateFastSimulationModel(), 407 ActivateFastSimulationModel(),
612 InActivateFastSimulationModel(), 408 InActivateFastSimulationModel(),
613 AtRestGetFastSimulationManagerTrigger(), 409 AtRestGetFastSimulationManagerTrigger(),
614 AddFastSimulationModel(), 410 AddFastSimulationModel(),
615 RemoveFastSimulationModel() 411 RemoveFastSimulationModel()
616 methodes to set the fLastCrossedParticle to 412 methodes to set the fLastCrossedParticle to NULL, forcing the
617 fApplicableModelList to be rebuilt. 413 fApplicableModelList to be rebuilt.
618 414
619 September 22, 1998 P.Mora de Freitas 415 September 22, 1998 P.Mora de Freitas
620 Fixed bug in parallel navigation. << 416 Fixed bug in parallel navigation.
621 File touched: G4FastSimulationManagerProces 417 File touched: G4FastSimulationManagerProcess.cc
622 Tested on HP-aCC. 418 Tested on HP-aCC.
623 419
624 September 17, 1998 P.Mora de Freitas 420 September 17, 1998 P.Mora de Freitas
625 G4FastSimulationManager::RemoveFastSimulati 421 G4FastSimulationManager::RemoveFastSimulationModel() updated to look
626 for also in the fInactivatedModels list. 422 for also in the fInactivatedModels list.
627 423
628 Tested on HP-aCC. 424 Tested on HP-aCC.
629 425
630 September 16, 1998 P.Mora de Freitas 426 September 16, 1998 P.Mora de Freitas
631 New /param/ control commands: 427 New /param/ control commands:
632 428
633 /param/ActivateModel <ModelName> 429 /param/ActivateModel <ModelName>
634 /param/InActivateModel <ModelName> 430 /param/InActivateModel <ModelName>
635 431
636 Activate or inactivate a given parameterisat 432 Activate or inactivate a given parameterisation model.
637 433
638 Tested on HP-aCC. 434 Tested on HP-aCC.
639 435
640 August 21, 1998 P.Mora de Freitas 436 August 21, 1998 P.Mora de Freitas
641 G4FastSimulationManagerProcess's G4ProcessTy 437 G4FastSimulationManagerProcess's G4ProcessType set to
642 fParameterisation, accordingly with procman-00 438 fParameterisation, accordingly with procman-00-02-03.
643 439
644 Tested on HP-aCC. 440 Tested on HP-aCC.
645 441
646 August 12, 1998 P.Mora de Freitas 442 August 12, 1998 P.Mora de Freitas
647 Improved the "close parameterisation control << 443 Improved the "close parameterisation control" to
648 444
649 1) avoid the close looping when unnecessary 445 1) avoid the close looping when unnecessary (mostly cases);
650 2) force re-close when necessary (insert/rem 446 2) force re-close when necessary (insert/remove ghosts).
651 447
652 Changes: 448 Changes:
653 449
654 1) the G4GlobalFastSimulationManager::fClose << 450 1) the G4GlobalFastSimulationManager::fClosed is now initialised
655 to true by the G4GlobalFastSimulationMana 451 to true by the G4GlobalFastSimulationManager constructor;
656 452
657 2) new method << 453 2) new method
658 454
659 void << 455 void
660 G4GlobalFastSimulationManager::FastSimula 456 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed();
661 457
662 called by the AddGhostPlacement and Remov << 458 called by the AddGhostPlacement and RemoveGhostPlacement
663 G4FastSimulationManager methods to set fa 459 G4FastSimulationManager methods to set false the fClosed flag;
664 460
665 3) changes in the G4GlobalFastSimulationMana 461 3) changes in the G4GlobalFastSimulationManager::Notify method
666 to deal with these changes. 462 to deal with these changes.
667 463
668 Tested on HP-aCC. 464 Tested on HP-aCC.
669 465
670 August 11, 1998 P.Mora de Freitas 466 August 11, 1998 P.Mora de Freitas
671 Fix to the G4FastStep::KillPrimaryTrack() me 467 Fix to the G4FastStep::KillPrimaryTrack() method to drop the
672 nonsense line 468 nonsense line
673 469
674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 470 SetMomentumChange(0.,0.,0.) ; /* necessary ? */
675 471
676 Tested on HP-aCC. 472 Tested on HP-aCC.
677 (Thanks to Willy Langeveld) 473 (Thanks to Willy Langeveld)
678 474
679 475
680 August 10, 1998 P.Mora de Freitas 476 August 10, 1998 P.Mora de Freitas
681 Fix to the SetPrimaryTrackFinalKineticEnergy 477 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method
682 from the G4FastStep class the SetMomentumChang 478 from the G4FastStep class the SetMomentumChange() call to insure that
683 the new momentum direction is a unit vector (a << 479 the new momentum direction is a unit vector (as asked by the
684 G4DynamicParticle::SetMomentumDirection method 480 G4DynamicParticle::SetMomentumDirection method).
685 481
686 Touched files: G4FastStep.hh (improved comme 482 Touched files: G4FastStep.hh (improved comments)
687 G4FastStep.cc (fixed) 483 G4FastStep.cc (fixed)
688 484
689 Tested on HP-aCC. 485 Tested on HP-aCC.
690 (Thanks to Willy Langeveld) 486 (Thanks to Willy Langeveld)
691 487
692 August 7, 1998 P.Mora de Freitas 488 August 7, 1998 P.Mora de Freitas
693 New /param/ commands directory with the comm 489 New /param/ commands directory with the commands:
694 490
695 /param/listEnvelopes [ParticleName] 491 /param/listEnvelopes [ParticleName]
696 492
697 - List all the envelope names for a given pa 493 - List all the envelope names for a given particle
698 (or for all particles if without parameter 494 (or for all particles if without parameters).
699 495
700 /param/listModels [EnvelopeName] 496 /param/listModels [EnvelopeName]
701 497
702 - List all the Model names for a given envel 498 - List all the Model names for a given envelope
703 (or for all envelopes if without parameter 499 (or for all envelopes if without parameters).
704 500
705 /param/listIsApplicable [ModelName] 501 /param/listIsApplicable [ModelName]
706 502
707 - List all the particle names a given model 503 - List all the particle names a given model is applicable
708 (or for all models if without parameters). 504 (or for all models if without parameters).
709 505
710 506
711 August 7, 1998 P.Mora de Freitas 507 August 7, 1998 P.Mora de Freitas
712 History file Created. 508 History file Created.