| Geant4 Cross Reference |
1 # Category param History << 1 $Id: History,v 1.9 2000/06/15 17:38:13 gcosmo Exp $
>> 2 -------------------------------------------------------------------
2 3
3 See `CONTRIBUTING.rst` for details of **requir << 4 =========================================================
4 which **must** added in reverse chronological << 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP
5 It must **not** be used as a substitute for wr << 6 =========================================================
6 << 7
7 ---------------------------------------------- << 8 Category History file
8 << 9 ---------------------
9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) << 10 This file should be used by G4 developers and category coordinators
10 - In G4GlobalFastSimulationManager: << 11 to briefly summarize all major modifications introduced in the code
11 use G4ThreadLocalSingleton to avoid undelete << 12 and keep track of all category-tags.
12 << 13 It DOES NOT substitute the CVS log-message one should put at every
13 ## 2023-10-18 Ben Morgan (param-V11-01-03) << 14 committal in the CVS repository !
14 - Apply standard and extended clang-tidy fixes << 15
15 - Mark empty/obsolete functions as deprecated << 16 ----------------------------------------------------------
16 << 17 * Reverse chronological order (last date on top), please *
17 ## 2023-10-16 Ben Morgan (param-V11-01-02) << 18 ----------------------------------------------------------
18 - Apply standard clang-format-ing. <<
19 - Normal order accessors and docstrings. <<
20 <<
21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) <<
22 - In G4FastTrack, removed references to G4Touc <<
23 which is now deprecated. <<
24 <<
25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 <<
26 - Added missing virtual destructor to G4VFastS <<
27 <<
28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) <<
29 - Fixed compilation warnings for implicit type <<
30 <<
31 ## 2022-10-27 Makoto Asai (param-V11-00-03) <<
32 - G4FastSimHitMaker - making compatible to com <<
33 <<
34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 <<
35 - G4FastStep - delete copy constructor and ope <<
36 <<
37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) <<
38 - Adding the 'flush' method to the fast simula <<
39 This method allows to process the input buff <<
40 the end of the G4 event. It is used when par <<
41 The 'flash' is triggered inside the event lo <<
42 The fast simulation model may add secondarie <<
43 by Geant4. <<
44 <<
45 ## 2021-12-10 Ben Morgan (param-V11-00-00) <<
46 - Change to new Markdown History format <<
47 <<
48 --- <<
49 <<
50 # History entries prior to 11.0 <<
51 <<
52 April 16, 2021 Ben Morgan (param-V10-07-00) <<
53 - Migrate build to modular CMake API <<
54 <<
55 October 5, 2020, A. Zaborowska (param-V10-06-0 <<
56 - Introduce general facilities based on GFlash <<
57 to facilitate multiple hit (energy & positio <<
58 from fast simulation models. <<
59 <<
60 September 9, 2020, G. Cosmo (param-V10-06-02) <<
61 - Fixed minor Coverity defect for uninitialise <<
62 <<
63 April 21, 2020, A. Zaborowska (param-V10-06-01 <<
64 - Sanity check for root logical volumes for re <<
65 UI command /param/showSetup works also if no <<
66 <<
67 March 26, 2020, I. Semeniouk (param-V10-06-00) <<
68 - G4FastSimulationHelper : merge ActivateFastS <<
69 - G4FastSimulationManager.hh, G4VFastSimulatio <<
70 redefinition of G4Envelope type <<
71 <<
72 October 30, 2019, A. Zaborowska (param-v10-05- <<
73 - Register G4FastSimulationManagerProcess with <<
74 G4FastSimulationManagerHelper to ensure it i <<
75 invoked for a given step (ExclusivelyForced) <<
76 StronglyForced processes will be considered. <<
77 <<
78 December 19, 2017, G. Cosmo (param-V10-04-00) <<
79 - Fixed self-consistency in G4FastSimulationVe <<
80 Thanks to Raphael Isemann for reporting this <<
81 <<
82 November 03, 2016, M. Verderi (param-V10-02-01 <<
83 - New G4FastSimulationManagerHelper utility fo <<
84 adding G4FastSimulationManagerProcess to a <<
85 process manager. <<
86 <<
87 November 02, 2016, M. Verderi (param-V10-02-00 <<
88 - fix various Coverity defects. <<
89 <<
90 March 27, 2013, M. Verderi (param-V09-06-00) <<
91 - remove unused field 'fOnBoundary' in G4FastS <<
92 as this was causing a warning from clang. <<
93 <<
94 July 10, 2012, G. Cosmo (param-V09-05-00) <<
95 - Explicitly use inclusion of headers for syst <<
96 constants, in plan to remove implicit inclus <<
97 <<
98 September 30, 2011, M. Verderi (param-V09-04-0 <<
99 - Added missing new header file (G4FastSimulat <<
100 sources.cmake. <<
101 <<
102 September 30, 2011, M. Verderi (param-V09-04-0 <<
103 - Migration to new G4Exception scheme. <<
104 - what is V09-04-01 tag ? <<
105 <<
106 February 11, 2011, M. Verderi (param-V09-04-00 <<
107 - Implementation of method <<
108 void ProposePrimaryTrackFinalKineticEnergy ( <<
109 was missing : modified file G4FastStep.icc <<
110 <<
111 March 13, 2008, G. Cosmo (param-V09-01-00) <<
112 - Cleared compilation warnings in G4FastSimula <<
113 G4FastSimulationMessenger on gcc-4.3.0 for a <<
114 parentheses in nested if-else statements. <<
115 <<
116 November 30, 2007, M. Verderi <<
117 - Add Along methods to G4FSMP process <<
118 - tag as param-V09-00-01 <<
119 <<
120 November 30, 2007, M. Verderi <<
121 - minor corrections to G4FastSimulationManager <<
122 * add call fPathFinder->prepareNewrack(...) <<
123 * deactivate ghost navigator in EndOfTracki <<
124 - tag as param-V09-00-00 <<
125 <<
126 May 18, 2007, M. Verderi <<
127 - tag as param-V08-03-00 <<
128 <<
129 May 11, 2007, M. Verderi <<
130 - remove include/G4FastSimulationManagerProces <<
131 include/G4FlavoredParallelWorld.hh <<
132 include/G4GFSManager81.hh <<
133 src/G4FastSimulationManagerProcess81. <<
134 src/G4GFSManager81.cc <<
135 <<
136 <<
137 November 10, 2006, M. Verderi - param-V08-01-0 <<
138 - Limited number of warning messages printed b <<
139 G4GlobalFastSimulationManager. <<
140 - Renamed G4FastSimulationManagerProcess_forCo <<
141 G4FastSimulationManagerProcess81. <<
142 In addition, this class can now handle the c <<
143 i.e., the navigator for tracking, regardless <<
144 G4CoupledTransportation is used. (For other <<
145 of course no choice, and G4CoupledTransporta <<
146 <<
147 November 3, 2006 M. Verderi <<
148 - Introduced G4FastSimulationManagerProcess_fo <<
149 handling fast simulation in new parallel geo <<
150 the G4CoupledTransportation to be active. <<
151 - Introduced G4GFSManager81 class that gathers <<
152 default at next major release in the G4Globa <<
153 - G4FastSimulationManager: adapted to new sche <<
154 backward compatibilty. <<
155 - G4FastSimulationManagerProcess: mostly the s <<
156 - G4FastSimulationMessenger: new command creat <<
157 to show the fast simulation setup (region, m <<
158 It is only valid for geometry closed state. <<
159 command in the run manager for this. <<
160 <<
161 November 25, 2005, M.Verderi - param-V07-01-0 <<
162 - put back Makoto's change: StartTracking(G4Tr <<
163 <<
164 November 25, 2005, M Verderi - param-V07-01-03 <<
165 - Make ghost functionnality available with G4R <<
166 - ** Note ** Change back StartTracking(G4Track <<
167 StartTracking(G4Track*) was intro <<
168 because (I guess) of procman-V07-01-01 <<
169 This is to make param-V07-01-03 compatible w <<
170 <<
171 November 21, 2005 M.Asai - param-V07-01-02 <<
172 - Fix warning message. <<
173 <<
174 November 02, 2005 G.Cosmo - param-V07-01-01 <<
175 - Corrected setting of envelope volumes and so <<
176 - Migrated old scheme for G4Exception and some <<
177 <<
178 October 28, 2005 M.Asai - param-V07-01-00 <<
179 - Working tag for merging "envelope" to G4Regi <<
180 <<
181 December 07, 2004 G. Cosmo - param-V06-02-01 <<
182 - Implemented migration to <cmath>. <<
183 <<
184 November 26, 2004 M. Verderi - param-V06-02-00 <<
185 - Implemented migration to new G4VParticleChan <<
186 <<
187 December 12, 2003 G. Cosmo - param-V06-00-00 <<
188 - G4FastSimulationVector.icc: use std_pvector: <<
189 base class. Fixes compilation problem on Int <<
190 <<
191 November 10, 2003 G. Cosmo - param-V05-02-01 <<
192 - G4FastTrack: use G4Navigator::CreateTouchabl <<
193 CreateTouchableHistory() in method FRecordsA <<
194 <<
195 October 4, 2003 G. Cosmo - param-V05-02-00 <<
196 - Modified GNUmakefile: <<
197 o added dependency to new module "geometry/n <<
198 - Coworks with "geometry-V05-02-00" and "digit <<
199 <<
200 May 21, 2003 G. Cosmo - param-V05-01-00 <<
201 o Fixed pedantic warnings on Linux-g++ <<
202 o Call base class in copy-constructor <<
203 <<
204 Nov 20, 2002 G. Cosmo - param-V04-01-02 <<
205 o Patched access to public static data in G4 <<
206 and G4GlobalFastSimulationManager.cc to al <<
207 Windows DLLs. <<
208 <<
209 Nov 15, 2002 S. Sadilov - param-V04-01-01 <<
210 o Fixed compilation problems on Windows in <<
211 G4FastSimulationManager.cc and G4GlobalFas <<
212 <<
213 Nov 02, 2002 M. Verderi - param-V04-01-00 <<
214 o Add method to retrieve G4VFastSimulationMo <<
215 The user's method is in G4GlobalFastSimula <<
216 <<
217 GetFastSimulationModel(); <<
218 <<
219 it is accompagnied by same methods name in <<
220 G4FastSimulationManager class. <<
221 <<
222 o Add "test" directory, used to test above f <<
223 <<
224 Oct 26, 2001 M. Verderi - param-V03-02-00 <<
225 Fixes to clear warnings produced with gcc-2. <<
226 - loop index, where comparison with method " <<
227 G4std::vector<T>, changed: int -> size_t <<
228 - change "if ( a=b ) {..}" by "if ( (a=b) ) <<
229 this makes the compiler sure you want to mak <<
230 assignement in the "if" condition <<
231 - re-order initialisations of a few variable <<
232 to match the declaration order. <<
233 Some warnings still exist, but regard the G4 <<
234 <<
235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 <<
236 - Modified G4FastSimulationManagerProcess call <<
237 to use new interface with G4FieldTrack (in <<
238 <<
239 Nov 14, 2000 G. Cosmo - param-V02-00-01 <<
240 - Moved specific parameterisation models to th <<
241 "parameterisations". Moved files: <<
242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm <<
243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster <<
244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr <<
245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode <<
246 G4VXrayTRmodel[.hh.cc]. <<
247 - Cleaned-up GNUmakefile of non necessary depe <<
248 <<
249 Aug 03, 2000 G. Cosmo - param-V02-00-00r <<
250 - Changed RandGauss to G4RandGauss in G4Irregu <<
251 G4VXrayTRmodel.cc to fix events' reproducibi <<
252 - G4VXrayTRmodel.cc: fix to class destructor ( <<
253 19
254 Jun 15, 2000 G. Cosmo - param-V01-01-04 20 Jun 15, 2000 G. Cosmo - param-V01-01-04
255 - The tag coworks with global-V01-01-04 and ma 21 - The tag coworks with global-V01-01-04 and materials-V01-01-00:
256 o Fixed usage of G4complex type for ISO and 22 o Fixed usage of G4complex type for ISO and non-ISO compilers.
257 Affected files: G4FoamXrayTRmodel.cc, G4Ga 23 Affected files: G4FoamXrayTRmodel.cc, G4GamDistrXrayTRmodel.cc, G4PlateIrrGasXrayTRmodel.cc
258 and G4RegularXrayTRmodel.c 24 and G4RegularXrayTRmodel.cc.
259 In case of G4complex types passed to mathe 25 In case of G4complex types passed to mathematical functions, use G4std:: prefix.
260 o Fixed usage of G4Integrator class, now cha 26 o Fixed usage of G4Integrator class, now changed to templated to allow porting of the
261 code on SUN-CC compiler which does not imp 27 code on SUN-CC compiler which does not implement templated member functions.
262 Affected files: G4VXrayTRmodel[.hh.cc] 28 Affected files: G4VXrayTRmodel[.hh.cc]
263 29
264 Jun 6, 2000 M. Verderi & P. Mora de Freitas 30 Jun 6, 2000 M. Verderi & P. Mora de Freitas
265 - fixed compilation errors with HP-aCC for the 31 - fixed compilation errors with HP-aCC for the files G4RegularXrayTRmodel.cc,
266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod 32 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmodel.cc.
267 33
268 May 30, 2000 M. Verderi & P. Mora de Freitas 34 May 30, 2000 M. Verderi & P. Mora de Freitas
269 35
270 - parameterisation category is now RW free. 36 - parameterisation category is now RW free.
271 37
272 September 16, 1999 M. Verderi & P. Mora de Fre 38 September 16, 1999 M. Verderi & P. Mora de Freitas
273 39
274 - Fixed bug in G4FastStep::CheckIt() method. 40 - Fixed bug in G4FastStep::CheckIt() method.
275 41
276 April 19, 1999 M. Verderi & P. Mora de Freitas 42 April 19, 1999 M. Verderi & P. Mora de Freitas
277 43
278 Changes in G4FastStep to co-work with track-01 44 Changes in G4FastStep to co-work with track-01-00-04:
279 45
280 1) The method void CheckIt(const G4Track&) bec << 46 1) The method void CheckIt(const G4Track&) becomes
281 G4bool CheckIt(const G4Track&); 47 G4bool CheckIt(const G4Track&);
282 2) The FAST_STEP_DEBUG compiling option disapp 48 2) The FAST_STEP_DEBUG compiling option disappears;
283 3) Call to CheckIt controled by the G4VParticl 49 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute.
284 50
285 Miscellaneous: the declaration "G4double mass 51 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh
286 corrected to G4double mass =...". 52 corrected to G4double mass =...".
287 53
288 April 15, 1999 M. Verderi & P. Mora de Freitas 54 April 15, 1999 M. Verderi & P. Mora de Freitas
289 55
290 Tasks to decouple visualization from processes 56 Tasks to decouple visualization from processes/parameterisation:
291 57
292 1) G4GlobalFastSimulationManager now inherites 58 1) G4GlobalFastSimulationManager now inherites from the intercoms/
293 G4VGlobalFastSimulationManager to allow visual << 59 G4VGlobalFastSimulationManager to allow visualisation to get a
294 concrete instance pointer to the G4GlobalFastS 60 concrete instance pointer to the G4GlobalFastSimulationManager,
295 if any. 61 if any.
296 62
297 2) G4FlavoredParallelWorld now inherites from 63 2) G4FlavoredParallelWorld now inherites from the intercoms/
298 G4VFlavoredParallelWorld, a pure virtual abstr 64 G4VFlavoredParallelWorld, a pure virtual abstract class to interface
299 parameterisation with visualization. 65 parameterisation with visualization.
300 66
301 Co-works with intercoms-01-00-01 tag 67 Co-works with intercoms-01-00-01 tag
302 68
303 Modified files: 69 Modified files:
304 --------------- 70 ---------------
305 G4FlavoredParallelWorld.hh 71 G4FlavoredParallelWorld.hh
306 G4GlobalFastSimulationManager.hh 72 G4GlobalFastSimulationManager.hh
307 G4GlobalFastSimulationManager.cc 73 G4GlobalFastSimulationManager.cc
308 74
309 Done, tested, system-tested on HP-aCC with exe 75 Done, tested, system-tested on HP-aCC with exemple N05.
310 76
311 April 14, 1999 M. Verderi & P. Mora de Freitas 77 April 14, 1999 M. Verderi & P. Mora de Freitas
312 78
313 Several consolidation tasks (thanks to G. Cosm 79 Several consolidation tasks (thanks to G. Cosmo):
314 80
315 1) Warning: << 81 1) Warning:
316 ----------- 82 -----------
317 83
318 Pointers usage 84 Pointers usage
319 85
320 - Setting pointers to 0 after delete: 86 - Setting pointers to 0 after delete:
321 87
322 delete pA; 88 delete pA;
323 pA = 0; 89 pA = 0;
324 90
325 - Avoid to use "NULL". 91 - Avoid to use "NULL".
326 92
327 Modified files: 93 Modified files:
328 --------------- 94 ---------------
329 G4FastSimulationManager.hh 95 G4FastSimulationManager.hh
330 G4FastTrack.hh 96 G4FastTrack.hh
331 G4FlavoredParallelWorld.hh 97 G4FlavoredParallelWorld.hh
332 G4FastSimulationManager.cc 98 G4FastSimulationManager.cc
333 G4FastSimulationMessenger.cc 99 G4FastSimulationMessenger.cc
334 G4FastSimulationManagerProcess.cc 100 G4FastSimulationManagerProcess.cc
335 G4FastTrack.cc 101 G4FastTrack.cc
336 G4GlobalFastSimulationManager.cc 102 G4GlobalFastSimulationManager.cc
337 G4VFastSimulationModel.cc 103 G4VFastSimulationModel.cc
338 104
339 Status: << 105 Status:
340 ------- 106 -------
341 Done, tested, system-tested on HP-aCC with exe 107 Done, tested, system-tested on HP-aCC with exemple N05.
342 108
343 2) Warning: 109 2) Warning:
344 ----------- 110 -----------
345 include/G4FastSimulationManager.hh:163 111 include/G4FastSimulationManager.hh:163
346 Public member functions shall always retur 112 Public member functions shall always return const handles to member data
347 Severe violation: Universal Coding Standar 113 Severe violation: Universal Coding Standards item 18
348 114
349 offending code: 115 offending code:
350 --------------- 116 ---------------
351 inline G4VParticleChange* G4FastSimulationMana 117 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange()
352 { 118 {
353 return &fFastStep; 119 return &fFastStep;
354 } 120 }
355 121
356 Diagnostic: 122 Diagnostic:
357 ---------- 123 ----------
358 124
359 Called by the G4FastSimulationManagerProcess << 125 Called by the G4FastSimulationManagerProcess to return it in the
360 PostStepDoIt call. << 126 PostStepDoIt call.
361 127
362 Action: 128 Action:
363 ------- 129 -------
364 The G4FastSimulationManager::GettheParticleCha 130 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any
365 more. The G4VParticleChange* is now returned d 131 more. The G4VParticleChange* is now returned directly when invoking the
366 G4FastSimulationManager::InvokePostStepDoIt() 132 G4FastSimulationManager::InvokePostStepDoIt() and
367 G4FastSimulationManager::InvokeAtRestDoIt() me 133 G4FastSimulationManager::InvokeAtRestDoIt() methodes.
368 134
369 Modified files: 135 Modified files:
370 --------------- 136 ---------------
371 G4FastSimulationManager.hh 137 G4FastSimulationManager.hh
372 G4FastSimulationManager.cc 138 G4FastSimulationManager.cc
373 G4FastSimulationManagerProcess.cc 139 G4FastSimulationManagerProcess.cc
374 140
375 Status: << 141 Status:
376 ------- 142 -------
377 Done, tested, system-tested on HP-aCC with exe 143 Done, tested, system-tested on HP-aCC with exemple N05.
378 144
379 3) Warning: 145 3) Warning:
380 ----------- 146 -----------
381 include/G4FastSimulationManagerProcess.hh:52 147 include/G4FastSimulationManagerProcess.hh:52
382 If a class has virtual functions it shall 148 If a class has virtual functions it shall have a virtual destructor
383 Severe violation: Universal Coding Standar 149 Severe violation: Universal Coding Standards item 17
384 class G4FastSimulationManagerProcess has v 150 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor.
385 151
386 offending code: 152 offending code:
387 --------------- 153 ---------------
388 ~G4FastSimulationManagerProcess(); 154 ~G4FastSimulationManagerProcess();
389 155
390 Diagnostic: 156 Diagnostic:
391 ---------- 157 ----------
392 Nobody should inherites from G4FastSimulatio << 158 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual
393 is added. 159 is added.
394 160
395 Action: 161 Action:
396 ------- 162 -------
397 virtual ~G4FastSimulationManagerProcess(); 163 virtual ~G4FastSimulationManagerProcess();
398 164
399 Modified files: 165 Modified files:
400 --------------- 166 ---------------
401 G4FastSimulationManagerProcess.hh 167 G4FastSimulationManagerProcess.hh
402 168
403 Status: << 169 Status:
404 ------- 170 -------
405 Done. 171 Done.
406 172
407 4) Warning: 173 4) Warning:
408 ----------- 174 -----------
409 include/G4FastSimulationMessenger.hh:36 175 include/G4FastSimulationMessenger.hh:36
410 If a class has virtual functions it shall 176 If a class has virtual functions it shall have a virtual destructor
411 Severe violation: Universal Coding Standar 177 Severe violation: Universal Coding Standards item 17
412 class G4FastSimulationMessenger has virtua 178 class G4FastSimulationMessenger has virtual functions without a virtual destructor.
413 179
414 180
415 offending code: 181 offending code:
416 --------------- 182 ---------------
417 ~G4FastSimulationMessenger(); 183 ~G4FastSimulationMessenger();
418 184
419 Diagnostic: 185 Diagnostic:
420 ---------- 186 ----------
421 Nobody should inherites from G4FastSimulatio << 187 Nobody should inherites from G4FastSimulationMessenger BUT for virtual
422 is added. 188 is added.
423 189
424 Action: 190 Action:
425 ------- 191 -------
426 virtual ~G4FastSimulationMessenger(); 192 virtual ~G4FastSimulationMessenger();
427 193
428 Modified files: 194 Modified files:
429 --------------- 195 ---------------
430 G4FastSimulationMessenger.hh 196 G4FastSimulationMessenger.hh
431 197
432 Status: << 198 Status:
433 ------- 199 -------
434 Done. 200 Done.
435 201
436 5) Warning: 202 5) Warning:
437 ----------- 203 -----------
438 include/G4FastStep.hh:224 204 include/G4FastStep.hh:224
439 Operator= should call base class operator= 205 Operator= should call base class operator=
440 Possible severe violation: Effective C++ i 206 Possible severe violation: Effective C++ item 16
441 operator= in class G4FastStep, should call 207 operator= in class G4FastStep, should call operator= in base class G4VParticleChange
442 208
443 offending code: 209 offending code:
444 --------------- 210 ---------------
445 G4FastStep & G4FastStep::operator=(const G4Fas 211 G4FastStep & G4FastStep::operator=(const G4FastStep &right)
446 { 212 {
447 if (this != &right) 213 if (this != &right)
448 { 214 {
449 theListOfSecondaries = right.th 215 theListOfSecondaries = right.theListOfSecondaries;
450 theSizeOftheListOfSecondaries = right.th 216 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries;
451 theNumberOfSecondaries = right.th 217 theNumberOfSecondaries = right.theNumberOfSecondaries;
452 theStatusChange = right.th 218 theStatusChange = right.theStatusChange;
453 theMomentumChange = right.th 219 theMomentumChange = right.theMomentumChange;
454 thePolarizationChange = right.th 220 thePolarizationChange = right.thePolarizationChange;
455 thePositionChange = right.th 221 thePositionChange = right.thePositionChange;
456 theTimeChange = right.th 222 theTimeChange = right.theTimeChange;
457 theEnergyChange = right.th 223 theEnergyChange = right.theEnergyChange;
458 theTrueStepLength = right.th 224 theTrueStepLength = right.theTrueStepLength;
459 theLocalEnergyDeposit = right.th 225 theLocalEnergyDeposit = right.theLocalEnergyDeposit;
460 theSteppingControlFlag = right.th 226 theSteppingControlFlag = right.theSteppingControlFlag;
461 theWeightChange = right.th 227 theWeightChange = right.theWeightChange;
462 } 228 }
463 return *this; 229 return *this;
464 } 230 }
465 231
466 Diagnostic: 232 Diagnostic:
467 ---------- 233 ----------
468 Bug detected. 234 Bug detected.
469 235
470 Action: 236 Action:
471 ------- 237 -------
472 Insert the call 238 Insert the call
473 G4VParticleChange::operator=(right); 239 G4VParticleChange::operator=(right);
474 240
475 Status: 241 Status:
476 ------- 242 -------
477 Done, tested, system-tested on HP-aCC with e 243 Done, tested, system-tested on HP-aCC with exemple N05.
478 244
479 Modified files: 245 Modified files:
480 --------------- 246 ---------------
481 G4FastStep.cc 247 G4FastStep.cc
482 248
483 6) Warning: 249 6) Warning:
484 ----------- 250 -----------
485 include/G4FastStep.hh:59 251 include/G4FastStep.hh:59
486 Avoid data members in the public interface 252 Avoid data members in the public interface
487 Violation: Effective C++ item 20 253 Violation: Effective C++ item 20
488 Public data members for class G4FastStep: 254 Public data members for class G4FastStep:
489 debugFlag 255 debugFlag
490 256
491 257
492 offending code: 258 offending code:
493 --------------- 259 ---------------
494 public: 260 public:
495 ... 261 ...
496 G4bool debugFlag; 262 G4bool debugFlag;
497 263
498 Diagnostic: 264 Diagnostic:
499 ---------- 265 ----------
500 Historical usage. 266 Historical usage.
501 267
502 Action: 268 Action:
503 ------- 269 -------
504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 270 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file.
505 271
506 Modified files: 272 Modified files:
507 --------------- 273 ---------------
508 G4FastStep.hh, G4FastStep.cc 274 G4FastStep.hh, G4FastStep.cc
509 275
510 Status: 276 Status:
511 ------- 277 -------
512 Done, tested, system-tested on HP-aCC with e 278 Done, tested, system-tested on HP-aCC with exemple N05.
513 279
514 7) Warning: 280 7) Warning:
515 ----------- 281 -----------
516 include/G4FastStep.hh:59 282 include/G4FastStep.hh:59
517 If a class has virtual functions it shall 283 If a class has virtual functions it shall have a virtual destructor
518 Severe violation: Universal Coding Standar 284 Severe violation: Universal Coding Standards item 17
519 class G4FastStep has virtual functions wit 285 class G4FastStep has virtual functions without a virtual destructor.
520 286
521 287
522 offending code: 288 offending code:
523 --------------- 289 ---------------
524 ~G4FastStep(); 290 ~G4FastStep();
525 291
526 Diagnostic: 292 Diagnostic:
527 ---------- 293 ----------
528 Nobody should inherites from G4FastStep BUT 294 Nobody should inherites from G4FastStep BUT virtual added.
529 295
530 Action: 296 Action:
531 ------- 297 -------
532 virtual ~G4FastStep(); 298 virtual ~G4FastStep();
533 299
534 Modified files: 300 Modified files:
535 --------------- 301 ---------------
536 G4FastStep.hh 302 G4FastStep.hh
537 303
538 Status: 304 Status:
539 ------- 305 -------
540 Done, tested, system-tested on HP-aCC with e 306 Done, tested, system-tested on HP-aCC with exemple N05.
541 307
542 308
543 December 7, 1998 M. Verderi 309 December 7, 1998 M. Verderi
544 G4FastSimulationManagerProcess class: 310 G4FastSimulationManagerProcess class:
545 Fixes made for ghost navigation with 311 Fixes made for ghost navigation with
546 mag-field: 312 mag-field:
547 LocateGlobalPointAndUpdateTouchable is 313 LocateGlobalPointAndUpdateTouchable is
548 always used (in not the Locate...Setup 314 always used (in not the Locate...Setup
549 method) 315 method)
550 In PostStepDoIt: correction of position and 316 In PostStepDoIt: correction of position and
551 direction of the track are made when << 317 direction of the track are made when
552 possible in case of mag-field. 318 possible in case of mag-field.
553 This correction comes from the fact that a 319 This correction comes from the fact that a
554 small discrepancy appears on those quantitie 320 small discrepancy appears on those quantities
555 because of the numerical integration along 321 because of the numerical integration along
556 the field on the track path: the G4FSMP 322 the field on the track path: the G4FSMP
557 proposes a curve-length, the transportation 323 proposes a curve-length, the transportation
558 moves the track along this curve, however 324 moves the track along this curve, however
559 the end point position and direction are 325 the end point position and direction are
560 slightly different from those expected by 326 slightly different from those expected by
561 the G4FSMP when it proposed the length. 327 the G4FSMP when it proposed the length.
562 328
563 November 20,1998 M. Verderi 329 November 20,1998 M. Verderi
564 G4FastStep class: 330 G4FastStep class:
565 Remove track/G4BiasingTag.hh dependancy (ob 331 Remove track/G4BiasingTag.hh dependancy (obsolete).
566 Adapted to new shceme of Event Biasing mech 332 Adapted to new shceme of Event Biasing mechanism,
567 consistently with track-00-04-01 tag. 333 consistently with track-00-04-01 tag.
568 334
569 November 11,1998 M. Verderi 335 November 11,1998 M. Verderi
570 Merge of param-00-03-02 & param-00-03-02a i 336 Merge of param-00-03-02 & param-00-03-02a into
571 param-00-03-04a (hopefully...) 337 param-00-03-04a (hopefully...)
572 The point is the chnage of signature in the 338 The point is the chnage of signature in the
573 LocateGlobalPointAndSetup(..) of the G4Navi 339 LocateGlobalPointAndSetup(..) of the G4Navigator making use now
574 of the track direction. The G4FastSimulatio 340 of the track direction. The G4FastSimulationManagerProcess is
575 changed accordingly: 341 changed accordingly:
576 fGhostNavigator.LocateGlobalPointAndSetup(t 342 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true);
577 343
578 344
579 November 6, 1998 M. Verderi 345 November 6, 1998 M. Verderi
580 - Extension of the G4FastStep to allow the 346 - Extension of the G4FastStep to allow the biasing technic.
581 Changes are made in: 347 Changes are made in:
582 - G4FastStep.hh/.icc: 348 - G4FastStep.hh/.icc:
583 new member G4BiasingTa 349 new member G4BiasingTag fBiasTag;
584 new method SetPrimaryT 350 new method SetPrimaryTrackFinalBiasingTag
585 ( G4BiasingTag 351 ( G4BiasingTag aTag );
586 - G4FastStep.cc: 352 - G4FastStep.cc:
587 Initialize(); 353 Initialize();
588 operator=; << 354 operator=;
589 UpdateForPostStep(); 355 UpdateForPostStep();
590 UpdateForAtRest(); << 356 UpdateForAtRest();
591 357
592 October 26, 1998 P.Mora de Freitas 358 October 26, 1998 P.Mora de Freitas
593 - G4FastSimulationManagerProcess and G4Fast 359 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal
594 with at rest parameterisations also when 360 with at rest parameterisations also when using parallel geometry.
595 361
596 October 8, 1998 P.Mora de Freitas 362 October 8, 1998 P.Mora de Freitas
597 - The G4VFastSimulationModel::IsApplicable( 363 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual
598 methode. 364 methode.
599 - G4FastSimulationManager optimisation: 365 - G4FastSimulationManager optimisation:
600 - New G4ParticleDefinition* fLastCrossedP 366 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps
601 the last particle type with touched the 367 the last particle type with touched the envelope;
602 - New G4RWTPtrOrderedVector<G4VFastSimula 368 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList
603 data member, keeps the model list of th << 369 data member, keeps the model list of the applicable models for
604 the actual fLastCrossedParticle particl 370 the actual fLastCrossedParticle particle type;
605 - Changes in the PostStepGetFastSimulatio << 371 - Changes in the PostStepGetFastSimulationManagerTrigger() and
606 AtRestGetFastSimulationManagerTrigger() << 372 AtRestGetFastSimulationManagerTrigger()methodes to update the
607 fApplicableModelList when needed (fLast 373 fApplicableModelList when needed (fLastCrossedParticle !=
608 the actual tracked particle); 374 the actual tracked particle);
609 - Changes in the << 375 - Changes in the
610 G4FastSimulationManager() (Constructor) 376 G4FastSimulationManager() (Constructor)
611 ActivateFastSimulationModel(), 377 ActivateFastSimulationModel(),
612 InActivateFastSimulationModel(), 378 InActivateFastSimulationModel(),
613 AtRestGetFastSimulationManagerTrigger(), 379 AtRestGetFastSimulationManagerTrigger(),
614 AddFastSimulationModel(), 380 AddFastSimulationModel(),
615 RemoveFastSimulationModel() 381 RemoveFastSimulationModel()
616 methodes to set the fLastCrossedParticle to 382 methodes to set the fLastCrossedParticle to NULL, forcing the
617 fApplicableModelList to be rebuilt. 383 fApplicableModelList to be rebuilt.
618 384
619 September 22, 1998 P.Mora de Freitas 385 September 22, 1998 P.Mora de Freitas
620 Fixed bug in parallel navigation. << 386 Fixed bug in parallel navigation.
621 File touched: G4FastSimulationManagerProces 387 File touched: G4FastSimulationManagerProcess.cc
622 Tested on HP-aCC. 388 Tested on HP-aCC.
623 389
624 September 17, 1998 P.Mora de Freitas 390 September 17, 1998 P.Mora de Freitas
625 G4FastSimulationManager::RemoveFastSimulati 391 G4FastSimulationManager::RemoveFastSimulationModel() updated to look
626 for also in the fInactivatedModels list. 392 for also in the fInactivatedModels list.
627 393
628 Tested on HP-aCC. 394 Tested on HP-aCC.
629 395
630 September 16, 1998 P.Mora de Freitas 396 September 16, 1998 P.Mora de Freitas
631 New /param/ control commands: 397 New /param/ control commands:
632 398
633 /param/ActivateModel <ModelName> 399 /param/ActivateModel <ModelName>
634 /param/InActivateModel <ModelName> 400 /param/InActivateModel <ModelName>
635 401
636 Activate or inactivate a given parameterisat 402 Activate or inactivate a given parameterisation model.
637 403
638 Tested on HP-aCC. 404 Tested on HP-aCC.
639 405
640 August 21, 1998 P.Mora de Freitas 406 August 21, 1998 P.Mora de Freitas
641 G4FastSimulationManagerProcess's G4ProcessTy 407 G4FastSimulationManagerProcess's G4ProcessType set to
642 fParameterisation, accordingly with procman-00 408 fParameterisation, accordingly with procman-00-02-03.
643 409
644 Tested on HP-aCC. 410 Tested on HP-aCC.
645 411
646 August 12, 1998 P.Mora de Freitas 412 August 12, 1998 P.Mora de Freitas
647 Improved the "close parameterisation control << 413 Improved the "close parameterisation control" to
648 414
649 1) avoid the close looping when unnecessary 415 1) avoid the close looping when unnecessary (mostly cases);
650 2) force re-close when necessary (insert/rem 416 2) force re-close when necessary (insert/remove ghosts).
651 417
652 Changes: 418 Changes:
653 419
654 1) the G4GlobalFastSimulationManager::fClose << 420 1) the G4GlobalFastSimulationManager::fClosed is now initialised
655 to true by the G4GlobalFastSimulationMana 421 to true by the G4GlobalFastSimulationManager constructor;
656 422
657 2) new method << 423 2) new method
658 424
659 void << 425 void
660 G4GlobalFastSimulationManager::FastSimula 426 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed();
661 427
662 called by the AddGhostPlacement and Remov << 428 called by the AddGhostPlacement and RemoveGhostPlacement
663 G4FastSimulationManager methods to set fa 429 G4FastSimulationManager methods to set false the fClosed flag;
664 430
665 3) changes in the G4GlobalFastSimulationMana 431 3) changes in the G4GlobalFastSimulationManager::Notify method
666 to deal with these changes. 432 to deal with these changes.
667 433
668 Tested on HP-aCC. 434 Tested on HP-aCC.
669 435
670 August 11, 1998 P.Mora de Freitas 436 August 11, 1998 P.Mora de Freitas
671 Fix to the G4FastStep::KillPrimaryTrack() me 437 Fix to the G4FastStep::KillPrimaryTrack() method to drop the
672 nonsense line 438 nonsense line
673 439
674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 440 SetMomentumChange(0.,0.,0.) ; /* necessary ? */
675 441
676 Tested on HP-aCC. 442 Tested on HP-aCC.
677 (Thanks to Willy Langeveld) 443 (Thanks to Willy Langeveld)
678 444
679 445
680 August 10, 1998 P.Mora de Freitas 446 August 10, 1998 P.Mora de Freitas
681 Fix to the SetPrimaryTrackFinalKineticEnergy 447 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method
682 from the G4FastStep class the SetMomentumChang 448 from the G4FastStep class the SetMomentumChange() call to insure that
683 the new momentum direction is a unit vector (a << 449 the new momentum direction is a unit vector (as asked by the
684 G4DynamicParticle::SetMomentumDirection method 450 G4DynamicParticle::SetMomentumDirection method).
685 451
686 Touched files: G4FastStep.hh (improved comme 452 Touched files: G4FastStep.hh (improved comments)
687 G4FastStep.cc (fixed) 453 G4FastStep.cc (fixed)
688 454
689 Tested on HP-aCC. 455 Tested on HP-aCC.
690 (Thanks to Willy Langeveld) 456 (Thanks to Willy Langeveld)
691 457
692 August 7, 1998 P.Mora de Freitas 458 August 7, 1998 P.Mora de Freitas
693 New /param/ commands directory with the comm 459 New /param/ commands directory with the commands:
694 460
695 /param/listEnvelopes [ParticleName] 461 /param/listEnvelopes [ParticleName]
696 462
697 - List all the envelope names for a given pa 463 - List all the envelope names for a given particle
698 (or for all particles if without parameter 464 (or for all particles if without parameters).
699 465
700 /param/listModels [EnvelopeName] 466 /param/listModels [EnvelopeName]
701 467
702 - List all the Model names for a given envel 468 - List all the Model names for a given envelope
703 (or for all envelopes if without parameter 469 (or for all envelopes if without parameters).
704 470
705 /param/listIsApplicable [ModelName] 471 /param/listIsApplicable [ModelName]
706 472
707 - List all the particle names a given model 473 - List all the particle names a given model is applicable
708 (or for all models if without parameters). 474 (or for all models if without parameters).
709 475
710 476
711 August 7, 1998 P.Mora de Freitas 477 August 7, 1998 P.Mora de Freitas
712 History file Created. 478 History file Created.