Geant4 Cross Reference |
1 # Category param History << 1 ------------------------------------------------------------------- 2 2 3 See `CONTRIBUTING.rst` for details of **requir << 3 ========================================================= 4 which **must** added in reverse chronological << 4 Geant4 - an Object-Oriented Toolkit for Simulation in HEP 5 It must **not** be used as a substitute for wr << 5 ========================================================= 6 << 6 7 ---------------------------------------------- << 7 Category History file 8 << 8 --------------------- 9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) << 9 This file should be used by G4 developers and category coordinators 10 - In G4GlobalFastSimulationManager: << 10 to briefly summarize all major modifications introduced in the code 11 use G4ThreadLocalSingleton to avoid undelete << 11 and keep track of all category-tags. 12 << 12 It DOES NOT substitute the CVS log-message one should put at every 13 ## 2023-10-18 Ben Morgan (param-V11-01-03) << 13 committal in the CVS repository ! 14 - Apply standard and extended clang-tidy fixes << 14 15 - Mark empty/obsolete functions as deprecated << 15 ---------------------------------------------------------- 16 << 16 * Reverse chronological order (last date on top), please * 17 ## 2023-10-16 Ben Morgan (param-V11-01-02) << 17 ---------------------------------------------------------- 18 - Apply standard clang-format-ing. << 19 - Normal order accessors and docstrings. << 20 << 21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) << 22 - In G4FastTrack, removed references to G4Touc << 23 which is now deprecated. << 24 << 25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 << 26 - Added missing virtual destructor to G4VFastS << 27 << 28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) << 29 - Fixed compilation warnings for implicit type << 30 << 31 ## 2022-10-27 Makoto Asai (param-V11-00-03) << 32 - G4FastSimHitMaker - making compatible to com << 33 << 34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 << 35 - G4FastStep - delete copy constructor and ope << 36 << 37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) << 38 - Adding the 'flush' method to the fast simula << 39 This method allows to process the input buff << 40 the end of the G4 event. It is used when par << 41 The 'flash' is triggered inside the event lo << 42 The fast simulation model may add secondarie << 43 by Geant4. << 44 << 45 ## 2021-12-10 Ben Morgan (param-V11-00-00) << 46 - Change to new Markdown History format << 47 << 48 --- << 49 << 50 # History entries prior to 11.0 << 51 << 52 April 16, 2021 Ben Morgan (param-V10-07-00) << 53 - Migrate build to modular CMake API << 54 << 55 October 5, 2020, A. Zaborowska (param-V10-06-0 << 56 - Introduce general facilities based on GFlash << 57 to facilitate multiple hit (energy & positio << 58 from fast simulation models. << 59 << 60 September 9, 2020, G. Cosmo (param-V10-06-02) << 61 - Fixed minor Coverity defect for uninitialise << 62 << 63 April 21, 2020, A. Zaborowska (param-V10-06-01 << 64 - Sanity check for root logical volumes for re << 65 UI command /param/showSetup works also if no << 66 << 67 March 26, 2020, I. Semeniouk (param-V10-06-00) << 68 - G4FastSimulationHelper : merge ActivateFastS << 69 - G4FastSimulationManager.hh, G4VFastSimulatio << 70 redefinition of G4Envelope type << 71 18 72 October 30, 2019, A. Zaborowska (param-v10-05- 19 October 30, 2019, A. Zaborowska (param-v10-05-00) 73 - Register G4FastSimulationManagerProcess with 20 - Register G4FastSimulationManagerProcess with highest ordering in 74 G4FastSimulationManagerHelper to ensure it i 21 G4FastSimulationManagerHelper to ensure it is the only process 75 invoked for a given step (ExclusivelyForced) 22 invoked for a given step (ExclusivelyForced) and no other 76 StronglyForced processes will be considered. 23 StronglyForced processes will be considered. 77 24 78 December 19, 2017, G. Cosmo (param-V10-04-00) 25 December 19, 2017, G. Cosmo (param-V10-04-00) 79 - Fixed self-consistency in G4FastSimulationVe 26 - Fixed self-consistency in G4FastSimulationVector header (missing #include). 80 Thanks to Raphael Isemann for reporting this 27 Thanks to Raphael Isemann for reporting this. 81 28 82 November 03, 2016, M. Verderi (param-V10-02-01 29 November 03, 2016, M. Verderi (param-V10-02-01) 83 - New G4FastSimulationManagerHelper utility fo 30 - New G4FastSimulationManagerHelper utility for 84 adding G4FastSimulationManagerProcess to a 31 adding G4FastSimulationManagerProcess to a 85 process manager. 32 process manager. 86 33 87 November 02, 2016, M. Verderi (param-V10-02-00 34 November 02, 2016, M. Verderi (param-V10-02-00) 88 - fix various Coverity defects. 35 - fix various Coverity defects. 89 36 90 March 27, 2013, M. Verderi (param-V09-06-00) 37 March 27, 2013, M. Verderi (param-V09-06-00) 91 - remove unused field 'fOnBoundary' in G4FastS 38 - remove unused field 'fOnBoundary' in G4FastSimulationManagerProcess.hh 92 as this was causing a warning from clang. 39 as this was causing a warning from clang. 93 40 94 July 10, 2012, G. Cosmo (param-V09-05-00) 41 July 10, 2012, G. Cosmo (param-V09-05-00) 95 - Explicitly use inclusion of headers for syst 42 - Explicitly use inclusion of headers for system of units and physical 96 constants, in plan to remove implicit inclus 43 constants, in plan to remove implicit inclusion from globals.hh. 97 44 98 September 30, 2011, M. Verderi (param-V09-04-0 45 September 30, 2011, M. Verderi (param-V09-04-03) 99 - Added missing new header file (G4FastSimulat 46 - Added missing new header file (G4FastSimulationProcessType.hh) in 100 sources.cmake. 47 sources.cmake. 101 48 102 September 30, 2011, M. Verderi (param-V09-04-0 49 September 30, 2011, M. Verderi (param-V09-04-02) 103 - Migration to new G4Exception scheme. 50 - Migration to new G4Exception scheme. 104 - what is V09-04-01 tag ? 51 - what is V09-04-01 tag ? 105 52 106 February 11, 2011, M. Verderi (param-V09-04-00 53 February 11, 2011, M. Verderi (param-V09-04-00) 107 - Implementation of method 54 - Implementation of method 108 void ProposePrimaryTrackFinalKineticEnergy ( 55 void ProposePrimaryTrackFinalKineticEnergy (G4double); 109 was missing : modified file G4FastStep.icc 56 was missing : modified file G4FastStep.icc 110 57 111 March 13, 2008, G. Cosmo (param-V09-01-00) 58 March 13, 2008, G. Cosmo (param-V09-01-00) 112 - Cleared compilation warnings in G4FastSimula 59 - Cleared compilation warnings in G4FastSimulationManagerProcess and 113 G4FastSimulationMessenger on gcc-4.3.0 for a 60 G4FastSimulationMessenger on gcc-4.3.0 for ambiguous use of 114 parentheses in nested if-else statements. 61 parentheses in nested if-else statements. 115 62 116 November 30, 2007, M. Verderi 63 November 30, 2007, M. Verderi 117 - Add Along methods to G4FSMP process 64 - Add Along methods to G4FSMP process 118 - tag as param-V09-00-01 65 - tag as param-V09-00-01 119 66 120 November 30, 2007, M. Verderi 67 November 30, 2007, M. Verderi 121 - minor corrections to G4FastSimulationManager << 68 - minor corrections to G4FastSimulationManagerProcess.hh/.cc : 122 * add call fPathFinder->prepareNewrack(...) 69 * add call fPathFinder->prepareNewrack(...) 123 * deactivate ghost navigator in EndOfTracki 70 * deactivate ghost navigator in EndOfTracking(..) method 124 - tag as param-V09-00-00 71 - tag as param-V09-00-00 125 72 126 May 18, 2007, M. Verderi 73 May 18, 2007, M. Verderi 127 - tag as param-V08-03-00 74 - tag as param-V08-03-00 128 75 129 May 11, 2007, M. Verderi 76 May 11, 2007, M. Verderi 130 - remove include/G4FastSimulationManagerProces 77 - remove include/G4FastSimulationManagerProcess81.hh 131 include/G4FlavoredParallelWorld.hh 78 include/G4FlavoredParallelWorld.hh 132 include/G4GFSManager81.hh 79 include/G4GFSManager81.hh 133 src/G4FastSimulationManagerProcess81. 80 src/G4FastSimulationManagerProcess81.cc 134 src/G4GFSManager81.cc 81 src/G4GFSManager81.cc 135 82 136 83 137 November 10, 2006, M. Verderi - param-V08-01-0 84 November 10, 2006, M. Verderi - param-V08-01-00 138 - Limited number of warning messages printed b 85 - Limited number of warning messages printed by the 139 G4GlobalFastSimulationManager. 86 G4GlobalFastSimulationManager. 140 - Renamed G4FastSimulationManagerProcess_forCo 87 - Renamed G4FastSimulationManagerProcess_forCoupledTransportation with 141 G4FastSimulationManagerProcess81. 88 G4FastSimulationManagerProcess81. 142 In addition, this class can now handle the c 89 In addition, this class can now handle the case of Navigator index=0, 143 i.e., the navigator for tracking, regardless 90 i.e., the navigator for tracking, regardless the G4Transportation or 144 G4CoupledTransportation is used. (For other 91 G4CoupledTransportation is used. (For other navigators, there is 145 of course no choice, and G4CoupledTransporta 92 of course no choice, and G4CoupledTransportation is necessary.) 146 93 147 November 3, 2006 M. Verderi 94 November 3, 2006 M. Verderi 148 - Introduced G4FastSimulationManagerProcess_fo 95 - Introduced G4FastSimulationManagerProcess_forCoupledTransportation class for 149 handling fast simulation in new parallel geo 96 handling fast simulation in new parallel geometry scheme. This requires 150 the G4CoupledTransportation to be active. 97 the G4CoupledTransportation to be active. 151 - Introduced G4GFSManager81 class that gathers 98 - Introduced G4GFSManager81 class that gathers the future code to become the 152 default at next major release in the G4Globa 99 default at next major release in the G4GlobalFastSimulationManager class. 153 - G4FastSimulationManager: adapted to new sche 100 - G4FastSimulationManager: adapted to new scheme. Still has old code for 154 backward compatibilty. 101 backward compatibilty. 155 - G4FastSimulationManagerProcess: mostly the s 102 - G4FastSimulationManagerProcess: mostly the same, apart from a small bug fix. 156 - G4FastSimulationMessenger: new command creat 103 - G4FastSimulationMessenger: new command created "/param/showSetup", useful 157 to show the fast simulation setup (region, m 104 to show the fast simulation setup (region, models, processes, etc...) 158 It is only valid for geometry closed state. 105 It is only valid for geometry closed state. Desirable to have interactive 159 command in the run manager for this. 106 command in the run manager for this. 160 107 161 November 25, 2005, M.Verderi - param-V07-01-0 108 November 25, 2005, M.Verderi - param-V07-01-04 162 - put back Makoto's change: StartTracking(G4Tr 109 - put back Makoto's change: StartTracking(G4Track*) 163 110 164 November 25, 2005, M Verderi - param-V07-01-03 111 November 25, 2005, M Verderi - param-V07-01-03 165 - Make ghost functionnality available with G4R 112 - Make ghost functionnality available with G4Region 166 - ** Note ** Change back StartTracking(G4Track 113 - ** Note ** Change back StartTracking(G4Track*) -> StartTracking() in G4FSMP 167 StartTracking(G4Track*) was intro 114 StartTracking(G4Track*) was introduced in param-V07-01-02 168 because (I guess) of procman-V07-01-01 115 because (I guess) of procman-V07-01-01 169 This is to make param-V07-01-03 compatible w 116 This is to make param-V07-01-03 compatible with geant4-07-01-ref-05 170 117 171 November 21, 2005 M.Asai - param-V07-01-02 118 November 21, 2005 M.Asai - param-V07-01-02 172 - Fix warning message. 119 - Fix warning message. 173 120 174 November 02, 2005 G.Cosmo - param-V07-01-01 121 November 02, 2005 G.Cosmo - param-V07-01-01 175 - Corrected setting of envelope volumes and so 122 - Corrected setting of envelope volumes and solid in G4FastTrack. 176 - Migrated old scheme for G4Exception and some 123 - Migrated old scheme for G4Exception and some cosmetics... 177 124 178 October 28, 2005 M.Asai - param-V07-01-00 125 October 28, 2005 M.Asai - param-V07-01-00 179 - Working tag for merging "envelope" to G4Regi 126 - Working tag for merging "envelope" to G4Region. 180 127 181 December 07, 2004 G. Cosmo - param-V06-02-01 128 December 07, 2004 G. Cosmo - param-V06-02-01 182 - Implemented migration to <cmath>. 129 - Implemented migration to <cmath>. 183 130 184 November 26, 2004 M. Verderi - param-V06-02-00 131 November 26, 2004 M. Verderi - param-V06-02-00 185 - Implemented migration to new G4VParticleChan 132 - Implemented migration to new G4VParticleChange interfaces. 186 133 187 December 12, 2003 G. Cosmo - param-V06-00-00 134 December 12, 2003 G. Cosmo - param-V06-00-00 188 - G4FastSimulationVector.icc: use std_pvector: 135 - G4FastSimulationVector.icc: use std_pvector:: scope for calls to 189 base class. Fixes compilation problem on Int 136 base class. Fixes compilation problem on Intel-icc compiler. 190 137 191 November 10, 2003 G. Cosmo - param-V05-02-01 138 November 10, 2003 G. Cosmo - param-V05-02-01 192 - G4FastTrack: use G4Navigator::CreateTouchabl 139 - G4FastTrack: use G4Navigator::CreateTouchableHistoryHandle() instead of 193 CreateTouchableHistory() in method FRecordsA 140 CreateTouchableHistory() in method FRecordsAffineTransformation(). 194 141 195 October 4, 2003 G. Cosmo - param-V05-02-00 142 October 4, 2003 G. Cosmo - param-V05-02-00 196 - Modified GNUmakefile: 143 - Modified GNUmakefile: 197 o added dependency to new module "geometry/n 144 o added dependency to new module "geometry/navigation". 198 - Coworks with "geometry-V05-02-00" and "digit 145 - Coworks with "geometry-V05-02-00" and "digits_hits-V05-02-00". 199 146 200 May 21, 2003 G. Cosmo - param-V05-01-00 147 May 21, 2003 G. Cosmo - param-V05-01-00 201 o Fixed pedantic warnings on Linux-g++ 148 o Fixed pedantic warnings on Linux-g++. 202 o Call base class in copy-constructor 149 o Call base class in copy-constructor of G4FastStep. 203 150 204 Nov 20, 2002 G. Cosmo - param-V04-01-02 151 Nov 20, 2002 G. Cosmo - param-V04-01-02 205 o Patched access to public static data in G4 152 o Patched access to public static data in G4FastStep.cc 206 and G4GlobalFastSimulationManager.cc to al 153 and G4GlobalFastSimulationManager.cc to allow porting on 207 Windows DLLs. 154 Windows DLLs. 208 155 209 Nov 15, 2002 S. Sadilov - param-V04-01-01 156 Nov 15, 2002 S. Sadilov - param-V04-01-01 210 o Fixed compilation problems on Windows in 157 o Fixed compilation problems on Windows in 211 G4FastSimulationManager.cc and G4GlobalFas 158 G4FastSimulationManager.cc and G4GlobalFastSimulationManager.cc 212 159 213 Nov 02, 2002 M. Verderi - param-V04-01-00 160 Nov 02, 2002 M. Verderi - param-V04-01-00 214 o Add method to retrieve G4VFastSimulationMo 161 o Add method to retrieve G4VFastSimulationModel by name. 215 The user's method is in G4GlobalFastSimula 162 The user's method is in G4GlobalFastSimulationManager: 216 163 217 GetFastSimulationModel(); 164 GetFastSimulationModel(); 218 165 219 it is accompagnied by same methods name in 166 it is accompagnied by same methods name in 220 G4FastSimulationManager class. 167 G4FastSimulationManager class. 221 168 222 o Add "test" directory, used to test above f 169 o Add "test" directory, used to test above feature. 223 170 224 Oct 26, 2001 M. Verderi - param-V03-02-00 171 Oct 26, 2001 M. Verderi - param-V03-02-00 225 Fixes to clear warnings produced with gcc-2. 172 Fixes to clear warnings produced with gcc-2.95.2: 226 - loop index, where comparison with method " 173 - loop index, where comparison with method "size()" of 227 G4std::vector<T>, changed: int -> size_t << 174 G4std::vector<T>, changed: int -> size_t 228 - change "if ( a=b ) {..}" by "if ( (a=b) ) 175 - change "if ( a=b ) {..}" by "if ( (a=b) ) {...}" 229 this makes the compiler sure you want to mak 176 this makes the compiler sure you want to make an 230 assignement in the "if" condition 177 assignement in the "if" condition 231 - re-order initialisations of a few variable 178 - re-order initialisations of a few variables in constructors 232 to match the declaration order. 179 to match the declaration order. 233 Some warnings still exist, but regard the G4 180 Some warnings still exist, but regard the G4Propagator of geometry. 234 181 235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 182 Apr 3, 2001 J. Apostolakis - param-V03-00-00 236 - Modified G4FastSimulationManagerProcess call 183 - Modified G4FastSimulationManagerProcess call to PropagatorInField ComputeStep 237 to use new interface with G4FieldTrack (in 184 to use new interface with G4FieldTrack (in place of now obsolete interface.) 238 185 239 Nov 14, 2000 G. Cosmo - param-V02-00-01 186 Nov 14, 2000 G. Cosmo - param-V02-00-01 240 - Moved specific parameterisation models to th 187 - Moved specific parameterisation models to the new top category 241 "parameterisations". Moved files: 188 "parameterisations". Moved files: 242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm 189 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRmodel[.hh.cc], 243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster 190 G4IrregularXrayTRmodel[.hh.cc], G4PAIclusterModel[.hh.cc], 244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr 191 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXrayTRmodel[.hh.cc], 245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode 192 G4RegularXrayTRmodel[.hh.cc], G4VClusterModel[.hh.cc], 246 G4VXrayTRmodel[.hh.cc]. 193 G4VXrayTRmodel[.hh.cc]. 247 - Cleaned-up GNUmakefile of non necessary depe 194 - Cleaned-up GNUmakefile of non necessary dependencies. 248 195 249 Aug 03, 2000 G. Cosmo - param-V02-00-00r 196 Aug 03, 2000 G. Cosmo - param-V02-00-00r 250 - Changed RandGauss to G4RandGauss in G4Irregu 197 - Changed RandGauss to G4RandGauss in G4IrregularXrayTRmodel.cc and 251 G4VXrayTRmodel.cc to fix events' reproducibi 198 G4VXrayTRmodel.cc to fix events' reproducibility problem. 252 - G4VXrayTRmodel.cc: fix to class destructor ( 199 - G4VXrayTRmodel.cc: fix to class destructor (V.Grichine) 253 200 254 Jun 15, 2000 G. Cosmo - param-V01-01-04 201 Jun 15, 2000 G. Cosmo - param-V01-01-04 255 - The tag coworks with global-V01-01-04 and ma 202 - The tag coworks with global-V01-01-04 and materials-V01-01-00: 256 o Fixed usage of G4complex type for ISO and 203 o Fixed usage of G4complex type for ISO and non-ISO compilers. 257 Affected files: G4FoamXrayTRmodel.cc, G4Ga 204 Affected files: G4FoamXrayTRmodel.cc, G4GamDistrXrayTRmodel.cc, G4PlateIrrGasXrayTRmodel.cc 258 and G4RegularXrayTRmodel.c 205 and G4RegularXrayTRmodel.cc. 259 In case of G4complex types passed to mathe 206 In case of G4complex types passed to mathematical functions, use G4std:: prefix. 260 o Fixed usage of G4Integrator class, now cha 207 o Fixed usage of G4Integrator class, now changed to templated to allow porting of the 261 code on SUN-CC compiler which does not imp 208 code on SUN-CC compiler which does not implement templated member functions. 262 Affected files: G4VXrayTRmodel[.hh.cc] 209 Affected files: G4VXrayTRmodel[.hh.cc] 263 210 264 Jun 6, 2000 M. Verderi & P. Mora de Freitas 211 Jun 6, 2000 M. Verderi & P. Mora de Freitas 265 - fixed compilation errors with HP-aCC for the 212 - fixed compilation errors with HP-aCC for the files G4RegularXrayTRmodel.cc, 266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod 213 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmodel.cc. 267 214 268 May 30, 2000 M. Verderi & P. Mora de Freitas 215 May 30, 2000 M. Verderi & P. Mora de Freitas 269 216 270 - parameterisation category is now RW free. 217 - parameterisation category is now RW free. 271 218 272 September 16, 1999 M. Verderi & P. Mora de Fre 219 September 16, 1999 M. Verderi & P. Mora de Freitas 273 220 274 - Fixed bug in G4FastStep::CheckIt() method. 221 - Fixed bug in G4FastStep::CheckIt() method. 275 222 276 April 19, 1999 M. Verderi & P. Mora de Freitas 223 April 19, 1999 M. Verderi & P. Mora de Freitas 277 224 278 Changes in G4FastStep to co-work with track-01 225 Changes in G4FastStep to co-work with track-01-00-04: 279 226 280 1) The method void CheckIt(const G4Track&) bec << 227 1) The method void CheckIt(const G4Track&) becomes 281 G4bool CheckIt(const G4Track&); 228 G4bool CheckIt(const G4Track&); 282 2) The FAST_STEP_DEBUG compiling option disapp 229 2) The FAST_STEP_DEBUG compiling option disappears; 283 3) Call to CheckIt controled by the G4VParticl 230 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute. 284 231 285 Miscellaneous: the declaration "G4double mass 232 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh 286 corrected to G4double mass =...". 233 corrected to G4double mass =...". 287 234 288 April 15, 1999 M. Verderi & P. Mora de Freitas 235 April 15, 1999 M. Verderi & P. Mora de Freitas 289 236 290 Tasks to decouple visualization from processes 237 Tasks to decouple visualization from processes/parameterisation: 291 238 292 1) G4GlobalFastSimulationManager now inherites 239 1) G4GlobalFastSimulationManager now inherites from the intercoms/ 293 G4VGlobalFastSimulationManager to allow visual << 240 G4VGlobalFastSimulationManager to allow visualisation to get a 294 concrete instance pointer to the G4GlobalFastS 241 concrete instance pointer to the G4GlobalFastSimulationManager, 295 if any. 242 if any. 296 243 297 2) G4FlavoredParallelWorld now inherites from 244 2) G4FlavoredParallelWorld now inherites from the intercoms/ 298 G4VFlavoredParallelWorld, a pure virtual abstr 245 G4VFlavoredParallelWorld, a pure virtual abstract class to interface 299 parameterisation with visualization. 246 parameterisation with visualization. 300 247 301 Co-works with intercoms-01-00-01 tag 248 Co-works with intercoms-01-00-01 tag 302 249 303 Modified files: 250 Modified files: 304 --------------- 251 --------------- 305 G4FlavoredParallelWorld.hh 252 G4FlavoredParallelWorld.hh 306 G4GlobalFastSimulationManager.hh 253 G4GlobalFastSimulationManager.hh 307 G4GlobalFastSimulationManager.cc 254 G4GlobalFastSimulationManager.cc 308 255 309 Done, tested, system-tested on HP-aCC with exe 256 Done, tested, system-tested on HP-aCC with exemple N05. 310 257 311 April 14, 1999 M. Verderi & P. Mora de Freitas 258 April 14, 1999 M. Verderi & P. Mora de Freitas 312 259 313 Several consolidation tasks (thanks to G. Cosm 260 Several consolidation tasks (thanks to G. Cosmo): 314 261 315 1) Warning: << 262 1) Warning: 316 ----------- 263 ----------- 317 264 318 Pointers usage 265 Pointers usage 319 266 320 - Setting pointers to 0 after delete: 267 - Setting pointers to 0 after delete: 321 268 322 delete pA; 269 delete pA; 323 pA = 0; 270 pA = 0; 324 271 325 - Avoid to use "NULL". 272 - Avoid to use "NULL". 326 273 327 Modified files: 274 Modified files: 328 --------------- 275 --------------- 329 G4FastSimulationManager.hh 276 G4FastSimulationManager.hh 330 G4FastTrack.hh 277 G4FastTrack.hh 331 G4FlavoredParallelWorld.hh 278 G4FlavoredParallelWorld.hh 332 G4FastSimulationManager.cc 279 G4FastSimulationManager.cc 333 G4FastSimulationMessenger.cc 280 G4FastSimulationMessenger.cc 334 G4FastSimulationManagerProcess.cc 281 G4FastSimulationManagerProcess.cc 335 G4FastTrack.cc 282 G4FastTrack.cc 336 G4GlobalFastSimulationManager.cc 283 G4GlobalFastSimulationManager.cc 337 G4VFastSimulationModel.cc 284 G4VFastSimulationModel.cc 338 285 339 Status: << 286 Status: 340 ------- 287 ------- 341 Done, tested, system-tested on HP-aCC with exe 288 Done, tested, system-tested on HP-aCC with exemple N05. 342 289 343 2) Warning: 290 2) Warning: 344 ----------- 291 ----------- 345 include/G4FastSimulationManager.hh:163 292 include/G4FastSimulationManager.hh:163 346 Public member functions shall always retur 293 Public member functions shall always return const handles to member data 347 Severe violation: Universal Coding Standar 294 Severe violation: Universal Coding Standards item 18 348 295 349 offending code: 296 offending code: 350 --------------- 297 --------------- 351 inline G4VParticleChange* G4FastSimulationMana 298 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange() 352 { 299 { 353 return &fFastStep; 300 return &fFastStep; 354 } 301 } 355 302 356 Diagnostic: 303 Diagnostic: 357 ---------- 304 ---------- 358 305 359 Called by the G4FastSimulationManagerProcess << 306 Called by the G4FastSimulationManagerProcess to return it in the 360 PostStepDoIt call. << 307 PostStepDoIt call. 361 308 362 Action: 309 Action: 363 ------- 310 ------- 364 The G4FastSimulationManager::GettheParticleCha 311 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any 365 more. The G4VParticleChange* is now returned d 312 more. The G4VParticleChange* is now returned directly when invoking the 366 G4FastSimulationManager::InvokePostStepDoIt() 313 G4FastSimulationManager::InvokePostStepDoIt() and 367 G4FastSimulationManager::InvokeAtRestDoIt() me 314 G4FastSimulationManager::InvokeAtRestDoIt() methodes. 368 315 369 Modified files: 316 Modified files: 370 --------------- 317 --------------- 371 G4FastSimulationManager.hh 318 G4FastSimulationManager.hh 372 G4FastSimulationManager.cc 319 G4FastSimulationManager.cc 373 G4FastSimulationManagerProcess.cc 320 G4FastSimulationManagerProcess.cc 374 321 375 Status: << 322 Status: 376 ------- 323 ------- 377 Done, tested, system-tested on HP-aCC with exe 324 Done, tested, system-tested on HP-aCC with exemple N05. 378 325 379 3) Warning: 326 3) Warning: 380 ----------- 327 ----------- 381 include/G4FastSimulationManagerProcess.hh:52 328 include/G4FastSimulationManagerProcess.hh:52 382 If a class has virtual functions it shall 329 If a class has virtual functions it shall have a virtual destructor 383 Severe violation: Universal Coding Standar 330 Severe violation: Universal Coding Standards item 17 384 class G4FastSimulationManagerProcess has v 331 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor. 385 332 386 offending code: 333 offending code: 387 --------------- 334 --------------- 388 ~G4FastSimulationManagerProcess(); 335 ~G4FastSimulationManagerProcess(); 389 336 390 Diagnostic: 337 Diagnostic: 391 ---------- 338 ---------- 392 Nobody should inherites from G4FastSimulatio << 339 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual 393 is added. 340 is added. 394 341 395 Action: 342 Action: 396 ------- 343 ------- 397 virtual ~G4FastSimulationManagerProcess(); 344 virtual ~G4FastSimulationManagerProcess(); 398 345 399 Modified files: 346 Modified files: 400 --------------- 347 --------------- 401 G4FastSimulationManagerProcess.hh 348 G4FastSimulationManagerProcess.hh 402 349 403 Status: << 350 Status: 404 ------- 351 ------- 405 Done. 352 Done. 406 353 407 4) Warning: 354 4) Warning: 408 ----------- 355 ----------- 409 include/G4FastSimulationMessenger.hh:36 356 include/G4FastSimulationMessenger.hh:36 410 If a class has virtual functions it shall 357 If a class has virtual functions it shall have a virtual destructor 411 Severe violation: Universal Coding Standar 358 Severe violation: Universal Coding Standards item 17 412 class G4FastSimulationMessenger has virtua 359 class G4FastSimulationMessenger has virtual functions without a virtual destructor. 413 360 414 361 415 offending code: 362 offending code: 416 --------------- 363 --------------- 417 ~G4FastSimulationMessenger(); 364 ~G4FastSimulationMessenger(); 418 365 419 Diagnostic: 366 Diagnostic: 420 ---------- 367 ---------- 421 Nobody should inherites from G4FastSimulatio << 368 Nobody should inherites from G4FastSimulationMessenger BUT for virtual 422 is added. 369 is added. 423 370 424 Action: 371 Action: 425 ------- 372 ------- 426 virtual ~G4FastSimulationMessenger(); 373 virtual ~G4FastSimulationMessenger(); 427 374 428 Modified files: 375 Modified files: 429 --------------- 376 --------------- 430 G4FastSimulationMessenger.hh 377 G4FastSimulationMessenger.hh 431 378 432 Status: << 379 Status: 433 ------- 380 ------- 434 Done. 381 Done. 435 382 436 5) Warning: 383 5) Warning: 437 ----------- 384 ----------- 438 include/G4FastStep.hh:224 385 include/G4FastStep.hh:224 439 Operator= should call base class operator= 386 Operator= should call base class operator= 440 Possible severe violation: Effective C++ i 387 Possible severe violation: Effective C++ item 16 441 operator= in class G4FastStep, should call 388 operator= in class G4FastStep, should call operator= in base class G4VParticleChange 442 389 443 offending code: 390 offending code: 444 --------------- 391 --------------- 445 G4FastStep & G4FastStep::operator=(const G4Fas 392 G4FastStep & G4FastStep::operator=(const G4FastStep &right) 446 { 393 { 447 if (this != &right) 394 if (this != &right) 448 { 395 { 449 theListOfSecondaries = right.th 396 theListOfSecondaries = right.theListOfSecondaries; 450 theSizeOftheListOfSecondaries = right.th 397 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries; 451 theNumberOfSecondaries = right.th 398 theNumberOfSecondaries = right.theNumberOfSecondaries; 452 theStatusChange = right.th 399 theStatusChange = right.theStatusChange; 453 theMomentumChange = right.th 400 theMomentumChange = right.theMomentumChange; 454 thePolarizationChange = right.th 401 thePolarizationChange = right.thePolarizationChange; 455 thePositionChange = right.th 402 thePositionChange = right.thePositionChange; 456 theTimeChange = right.th 403 theTimeChange = right.theTimeChange; 457 theEnergyChange = right.th 404 theEnergyChange = right.theEnergyChange; 458 theTrueStepLength = right.th 405 theTrueStepLength = right.theTrueStepLength; 459 theLocalEnergyDeposit = right.th 406 theLocalEnergyDeposit = right.theLocalEnergyDeposit; 460 theSteppingControlFlag = right.th 407 theSteppingControlFlag = right.theSteppingControlFlag; 461 theWeightChange = right.th 408 theWeightChange = right.theWeightChange; 462 } 409 } 463 return *this; 410 return *this; 464 } 411 } 465 412 466 Diagnostic: 413 Diagnostic: 467 ---------- 414 ---------- 468 Bug detected. 415 Bug detected. 469 416 470 Action: 417 Action: 471 ------- 418 ------- 472 Insert the call 419 Insert the call 473 G4VParticleChange::operator=(right); 420 G4VParticleChange::operator=(right); 474 421 475 Status: 422 Status: 476 ------- 423 ------- 477 Done, tested, system-tested on HP-aCC with e 424 Done, tested, system-tested on HP-aCC with exemple N05. 478 425 479 Modified files: 426 Modified files: 480 --------------- 427 --------------- 481 G4FastStep.cc 428 G4FastStep.cc 482 429 483 6) Warning: 430 6) Warning: 484 ----------- 431 ----------- 485 include/G4FastStep.hh:59 432 include/G4FastStep.hh:59 486 Avoid data members in the public interface 433 Avoid data members in the public interface 487 Violation: Effective C++ item 20 434 Violation: Effective C++ item 20 488 Public data members for class G4FastStep: 435 Public data members for class G4FastStep: 489 debugFlag 436 debugFlag 490 437 491 438 492 offending code: 439 offending code: 493 --------------- 440 --------------- 494 public: 441 public: 495 ... 442 ... 496 G4bool debugFlag; 443 G4bool debugFlag; 497 444 498 Diagnostic: 445 Diagnostic: 499 ---------- 446 ---------- 500 Historical usage. 447 Historical usage. 501 448 502 Action: 449 Action: 503 ------- 450 ------- 504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 451 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file. 505 452 506 Modified files: 453 Modified files: 507 --------------- 454 --------------- 508 G4FastStep.hh, G4FastStep.cc 455 G4FastStep.hh, G4FastStep.cc 509 456 510 Status: 457 Status: 511 ------- 458 ------- 512 Done, tested, system-tested on HP-aCC with e 459 Done, tested, system-tested on HP-aCC with exemple N05. 513 460 514 7) Warning: 461 7) Warning: 515 ----------- 462 ----------- 516 include/G4FastStep.hh:59 463 include/G4FastStep.hh:59 517 If a class has virtual functions it shall 464 If a class has virtual functions it shall have a virtual destructor 518 Severe violation: Universal Coding Standar 465 Severe violation: Universal Coding Standards item 17 519 class G4FastStep has virtual functions wit 466 class G4FastStep has virtual functions without a virtual destructor. 520 467 521 468 522 offending code: 469 offending code: 523 --------------- 470 --------------- 524 ~G4FastStep(); 471 ~G4FastStep(); 525 472 526 Diagnostic: 473 Diagnostic: 527 ---------- 474 ---------- 528 Nobody should inherites from G4FastStep BUT 475 Nobody should inherites from G4FastStep BUT virtual added. 529 476 530 Action: 477 Action: 531 ------- 478 ------- 532 virtual ~G4FastStep(); 479 virtual ~G4FastStep(); 533 480 534 Modified files: 481 Modified files: 535 --------------- 482 --------------- 536 G4FastStep.hh 483 G4FastStep.hh 537 484 538 Status: 485 Status: 539 ------- 486 ------- 540 Done, tested, system-tested on HP-aCC with e 487 Done, tested, system-tested on HP-aCC with exemple N05. 541 488 542 489 543 December 7, 1998 M. Verderi 490 December 7, 1998 M. Verderi 544 G4FastSimulationManagerProcess class: 491 G4FastSimulationManagerProcess class: 545 Fixes made for ghost navigation with 492 Fixes made for ghost navigation with 546 mag-field: 493 mag-field: 547 LocateGlobalPointAndUpdateTouchable is 494 LocateGlobalPointAndUpdateTouchable is 548 always used (in not the Locate...Setup 495 always used (in not the Locate...Setup 549 method) 496 method) 550 In PostStepDoIt: correction of position and 497 In PostStepDoIt: correction of position and 551 direction of the track are made when << 498 direction of the track are made when 552 possible in case of mag-field. 499 possible in case of mag-field. 553 This correction comes from the fact that a 500 This correction comes from the fact that a 554 small discrepancy appears on those quantitie 501 small discrepancy appears on those quantities 555 because of the numerical integration along 502 because of the numerical integration along 556 the field on the track path: the G4FSMP 503 the field on the track path: the G4FSMP 557 proposes a curve-length, the transportation 504 proposes a curve-length, the transportation 558 moves the track along this curve, however 505 moves the track along this curve, however 559 the end point position and direction are 506 the end point position and direction are 560 slightly different from those expected by 507 slightly different from those expected by 561 the G4FSMP when it proposed the length. 508 the G4FSMP when it proposed the length. 562 509 563 November 20,1998 M. Verderi 510 November 20,1998 M. Verderi 564 G4FastStep class: 511 G4FastStep class: 565 Remove track/G4BiasingTag.hh dependancy (ob 512 Remove track/G4BiasingTag.hh dependancy (obsolete). 566 Adapted to new shceme of Event Biasing mech 513 Adapted to new shceme of Event Biasing mechanism, 567 consistently with track-00-04-01 tag. 514 consistently with track-00-04-01 tag. 568 515 569 November 11,1998 M. Verderi 516 November 11,1998 M. Verderi 570 Merge of param-00-03-02 & param-00-03-02a i 517 Merge of param-00-03-02 & param-00-03-02a into 571 param-00-03-04a (hopefully...) 518 param-00-03-04a (hopefully...) 572 The point is the chnage of signature in the 519 The point is the chnage of signature in the 573 LocateGlobalPointAndSetup(..) of the G4Navi 520 LocateGlobalPointAndSetup(..) of the G4Navigator making use now 574 of the track direction. The G4FastSimulatio 521 of the track direction. The G4FastSimulationManagerProcess is 575 changed accordingly: 522 changed accordingly: 576 fGhostNavigator.LocateGlobalPointAndSetup(t 523 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true); 577 524 578 525 579 November 6, 1998 M. Verderi 526 November 6, 1998 M. Verderi 580 - Extension of the G4FastStep to allow the 527 - Extension of the G4FastStep to allow the biasing technic. 581 Changes are made in: 528 Changes are made in: 582 - G4FastStep.hh/.icc: 529 - G4FastStep.hh/.icc: 583 new member G4BiasingTa 530 new member G4BiasingTag fBiasTag; 584 new method SetPrimaryT 531 new method SetPrimaryTrackFinalBiasingTag 585 ( G4BiasingTag 532 ( G4BiasingTag aTag ); 586 - G4FastStep.cc: 533 - G4FastStep.cc: 587 Initialize(); 534 Initialize(); 588 operator=; << 535 operator=; 589 UpdateForPostStep(); 536 UpdateForPostStep(); 590 UpdateForAtRest(); << 537 UpdateForAtRest(); 591 538 592 October 26, 1998 P.Mora de Freitas 539 October 26, 1998 P.Mora de Freitas 593 - G4FastSimulationManagerProcess and G4Fast 540 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal 594 with at rest parameterisations also when 541 with at rest parameterisations also when using parallel geometry. 595 542 596 October 8, 1998 P.Mora de Freitas 543 October 8, 1998 P.Mora de Freitas 597 - The G4VFastSimulationModel::IsApplicable( 544 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual 598 methode. 545 methode. 599 - G4FastSimulationManager optimisation: 546 - G4FastSimulationManager optimisation: 600 - New G4ParticleDefinition* fLastCrossedP 547 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps 601 the last particle type with touched the 548 the last particle type with touched the envelope; 602 - New G4RWTPtrOrderedVector<G4VFastSimula 549 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList 603 data member, keeps the model list of th << 550 data member, keeps the model list of the applicable models for 604 the actual fLastCrossedParticle particl 551 the actual fLastCrossedParticle particle type; 605 - Changes in the PostStepGetFastSimulatio << 552 - Changes in the PostStepGetFastSimulationManagerTrigger() and 606 AtRestGetFastSimulationManagerTrigger() << 553 AtRestGetFastSimulationManagerTrigger()methodes to update the 607 fApplicableModelList when needed (fLast 554 fApplicableModelList when needed (fLastCrossedParticle != 608 the actual tracked particle); 555 the actual tracked particle); 609 - Changes in the << 556 - Changes in the 610 G4FastSimulationManager() (Constructor) 557 G4FastSimulationManager() (Constructor) 611 ActivateFastSimulationModel(), 558 ActivateFastSimulationModel(), 612 InActivateFastSimulationModel(), 559 InActivateFastSimulationModel(), 613 AtRestGetFastSimulationManagerTrigger(), 560 AtRestGetFastSimulationManagerTrigger(), 614 AddFastSimulationModel(), 561 AddFastSimulationModel(), 615 RemoveFastSimulationModel() 562 RemoveFastSimulationModel() 616 methodes to set the fLastCrossedParticle to 563 methodes to set the fLastCrossedParticle to NULL, forcing the 617 fApplicableModelList to be rebuilt. 564 fApplicableModelList to be rebuilt. 618 565 619 September 22, 1998 P.Mora de Freitas 566 September 22, 1998 P.Mora de Freitas 620 Fixed bug in parallel navigation. << 567 Fixed bug in parallel navigation. 621 File touched: G4FastSimulationManagerProces 568 File touched: G4FastSimulationManagerProcess.cc 622 Tested on HP-aCC. 569 Tested on HP-aCC. 623 570 624 September 17, 1998 P.Mora de Freitas 571 September 17, 1998 P.Mora de Freitas 625 G4FastSimulationManager::RemoveFastSimulati 572 G4FastSimulationManager::RemoveFastSimulationModel() updated to look 626 for also in the fInactivatedModels list. 573 for also in the fInactivatedModels list. 627 574 628 Tested on HP-aCC. 575 Tested on HP-aCC. 629 576 630 September 16, 1998 P.Mora de Freitas 577 September 16, 1998 P.Mora de Freitas 631 New /param/ control commands: 578 New /param/ control commands: 632 579 633 /param/ActivateModel <ModelName> 580 /param/ActivateModel <ModelName> 634 /param/InActivateModel <ModelName> 581 /param/InActivateModel <ModelName> 635 582 636 Activate or inactivate a given parameterisat 583 Activate or inactivate a given parameterisation model. 637 584 638 Tested on HP-aCC. 585 Tested on HP-aCC. 639 586 640 August 21, 1998 P.Mora de Freitas 587 August 21, 1998 P.Mora de Freitas 641 G4FastSimulationManagerProcess's G4ProcessTy 588 G4FastSimulationManagerProcess's G4ProcessType set to 642 fParameterisation, accordingly with procman-00 589 fParameterisation, accordingly with procman-00-02-03. 643 590 644 Tested on HP-aCC. 591 Tested on HP-aCC. 645 592 646 August 12, 1998 P.Mora de Freitas 593 August 12, 1998 P.Mora de Freitas 647 Improved the "close parameterisation control << 594 Improved the "close parameterisation control" to 648 595 649 1) avoid the close looping when unnecessary 596 1) avoid the close looping when unnecessary (mostly cases); 650 2) force re-close when necessary (insert/rem 597 2) force re-close when necessary (insert/remove ghosts). 651 598 652 Changes: 599 Changes: 653 600 654 1) the G4GlobalFastSimulationManager::fClose << 601 1) the G4GlobalFastSimulationManager::fClosed is now initialised 655 to true by the G4GlobalFastSimulationMana 602 to true by the G4GlobalFastSimulationManager constructor; 656 603 657 2) new method << 604 2) new method 658 605 659 void << 606 void 660 G4GlobalFastSimulationManager::FastSimula 607 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed(); 661 608 662 called by the AddGhostPlacement and Remov << 609 called by the AddGhostPlacement and RemoveGhostPlacement 663 G4FastSimulationManager methods to set fa 610 G4FastSimulationManager methods to set false the fClosed flag; 664 611 665 3) changes in the G4GlobalFastSimulationMana 612 3) changes in the G4GlobalFastSimulationManager::Notify method 666 to deal with these changes. 613 to deal with these changes. 667 614 668 Tested on HP-aCC. 615 Tested on HP-aCC. 669 616 670 August 11, 1998 P.Mora de Freitas 617 August 11, 1998 P.Mora de Freitas 671 Fix to the G4FastStep::KillPrimaryTrack() me 618 Fix to the G4FastStep::KillPrimaryTrack() method to drop the 672 nonsense line 619 nonsense line 673 620 674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 621 SetMomentumChange(0.,0.,0.) ; /* necessary ? */ 675 622 676 Tested on HP-aCC. 623 Tested on HP-aCC. 677 (Thanks to Willy Langeveld) 624 (Thanks to Willy Langeveld) 678 625 679 626 680 August 10, 1998 P.Mora de Freitas 627 August 10, 1998 P.Mora de Freitas 681 Fix to the SetPrimaryTrackFinalKineticEnergy 628 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method 682 from the G4FastStep class the SetMomentumChang 629 from the G4FastStep class the SetMomentumChange() call to insure that 683 the new momentum direction is a unit vector (a << 630 the new momentum direction is a unit vector (as asked by the 684 G4DynamicParticle::SetMomentumDirection method 631 G4DynamicParticle::SetMomentumDirection method). 685 632 686 Touched files: G4FastStep.hh (improved comme 633 Touched files: G4FastStep.hh (improved comments) 687 G4FastStep.cc (fixed) 634 G4FastStep.cc (fixed) 688 635 689 Tested on HP-aCC. 636 Tested on HP-aCC. 690 (Thanks to Willy Langeveld) 637 (Thanks to Willy Langeveld) 691 638 692 August 7, 1998 P.Mora de Freitas 639 August 7, 1998 P.Mora de Freitas 693 New /param/ commands directory with the comm 640 New /param/ commands directory with the commands: 694 641 695 /param/listEnvelopes [ParticleName] 642 /param/listEnvelopes [ParticleName] 696 643 697 - List all the envelope names for a given pa 644 - List all the envelope names for a given particle 698 (or for all particles if without parameter 645 (or for all particles if without parameters). 699 646 700 /param/listModels [EnvelopeName] 647 /param/listModels [EnvelopeName] 701 648 702 - List all the Model names for a given envel 649 - List all the Model names for a given envelope 703 (or for all envelopes if without parameter 650 (or for all envelopes if without parameters). 704 651 705 /param/listIsApplicable [ModelName] 652 /param/listIsApplicable [ModelName] 706 653 707 - List all the particle names a given model 654 - List all the particle names a given model is applicable 708 (or for all models if without parameters). 655 (or for all models if without parameters). 709 656 710 657 711 August 7, 1998 P.Mora de Freitas 658 August 7, 1998 P.Mora de Freitas 712 History file Created. 659 History file Created.