| Geant4 Cross Reference |
1 # Category param History << 1 $Id: History 108538 2018-02-16 09:25:16Z gcosmo $
>> 2 -------------------------------------------------------------------
2 3
3 See `CONTRIBUTING.rst` for details of **requir << 4 =========================================================
4 which **must** added in reverse chronological << 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP
5 It must **not** be used as a substitute for wr << 6 =========================================================
6 << 7
7 ---------------------------------------------- << 8 Category History file
8 << 9 ---------------------
9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) << 10 This file should be used by G4 developers and category coordinators
10 - In G4GlobalFastSimulationManager: << 11 to briefly summarize all major modifications introduced in the code
11 use G4ThreadLocalSingleton to avoid undelete << 12 and keep track of all category-tags.
12 << 13 It DOES NOT substitute the CVS log-message one should put at every
13 ## 2023-10-18 Ben Morgan (param-V11-01-03) << 14 committal in the CVS repository !
14 - Apply standard and extended clang-tidy fixes << 15
15 - Mark empty/obsolete functions as deprecated << 16 ----------------------------------------------------------
16 << 17 * Reverse chronological order (last date on top), please *
17 ## 2023-10-16 Ben Morgan (param-V11-01-02) << 18 ----------------------------------------------------------
18 - Apply standard clang-format-ing. << 19
19 - Normal order accessors and docstrings. << 20 December 19, 2017, G. Cosmo (param-V10-03-00)
20 <<
21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) <<
22 - In G4FastTrack, removed references to G4Touc <<
23 which is now deprecated. <<
24 <<
25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 <<
26 - Added missing virtual destructor to G4VFastS <<
27 <<
28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) <<
29 - Fixed compilation warnings for implicit type <<
30 <<
31 ## 2022-10-27 Makoto Asai (param-V11-00-03) <<
32 - G4FastSimHitMaker - making compatible to com <<
33 <<
34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 <<
35 - G4FastStep - delete copy constructor and ope <<
36 <<
37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) <<
38 - Adding the 'flush' method to the fast simula <<
39 This method allows to process the input buff <<
40 the end of the G4 event. It is used when par <<
41 The 'flash' is triggered inside the event lo <<
42 The fast simulation model may add secondarie <<
43 by Geant4. <<
44 <<
45 ## 2021-12-10 Ben Morgan (param-V11-00-00) <<
46 - Change to new Markdown History format <<
47 <<
48 --- <<
49 <<
50 # History entries prior to 11.0 <<
51 <<
52 April 16, 2021 Ben Morgan (param-V10-07-00) <<
53 - Migrate build to modular CMake API <<
54 <<
55 October 5, 2020, A. Zaborowska (param-V10-06-0 <<
56 - Introduce general facilities based on GFlash <<
57 to facilitate multiple hit (energy & positio <<
58 from fast simulation models. <<
59 <<
60 September 9, 2020, G. Cosmo (param-V10-06-02) <<
61 - Fixed minor Coverity defect for uninitialise <<
62 <<
63 April 21, 2020, A. Zaborowska (param-V10-06-01 <<
64 - Sanity check for root logical volumes for re <<
65 UI command /param/showSetup works also if no <<
66 <<
67 March 26, 2020, I. Semeniouk (param-V10-06-00) <<
68 - G4FastSimulationHelper : merge ActivateFastS <<
69 - G4FastSimulationManager.hh, G4VFastSimulatio <<
70 redefinition of G4Envelope type <<
71 <<
72 October 30, 2019, A. Zaborowska (param-v10-05- <<
73 - Register G4FastSimulationManagerProcess with <<
74 G4FastSimulationManagerHelper to ensure it i <<
75 invoked for a given step (ExclusivelyForced) <<
76 StronglyForced processes will be considered. <<
77 <<
78 December 19, 2017, G. Cosmo (param-V10-04-00) <<
79 - Fixed self-consistency in G4FastSimulationVe 21 - Fixed self-consistency in G4FastSimulationVector header (missing #include).
80 Thanks to Raphael Isemann for reporting this 22 Thanks to Raphael Isemann for reporting this.
81 23
82 November 03, 2016, M. Verderi (param-V10-02-01 24 November 03, 2016, M. Verderi (param-V10-02-01)
83 - New G4FastSimulationManagerHelper utility fo 25 - New G4FastSimulationManagerHelper utility for
84 adding G4FastSimulationManagerProcess to a 26 adding G4FastSimulationManagerProcess to a
85 process manager. 27 process manager.
86 28
87 November 02, 2016, M. Verderi (param-V10-02-00 29 November 02, 2016, M. Verderi (param-V10-02-00)
88 - fix various Coverity defects. 30 - fix various Coverity defects.
89 31
90 March 27, 2013, M. Verderi (param-V09-06-00) 32 March 27, 2013, M. Verderi (param-V09-06-00)
91 - remove unused field 'fOnBoundary' in G4FastS 33 - remove unused field 'fOnBoundary' in G4FastSimulationManagerProcess.hh
92 as this was causing a warning from clang. 34 as this was causing a warning from clang.
93 35
94 July 10, 2012, G. Cosmo (param-V09-05-00) 36 July 10, 2012, G. Cosmo (param-V09-05-00)
95 - Explicitly use inclusion of headers for syst 37 - Explicitly use inclusion of headers for system of units and physical
96 constants, in plan to remove implicit inclus 38 constants, in plan to remove implicit inclusion from globals.hh.
97 39
98 September 30, 2011, M. Verderi (param-V09-04-0 40 September 30, 2011, M. Verderi (param-V09-04-03)
99 - Added missing new header file (G4FastSimulat 41 - Added missing new header file (G4FastSimulationProcessType.hh) in
100 sources.cmake. 42 sources.cmake.
101 43
102 September 30, 2011, M. Verderi (param-V09-04-0 44 September 30, 2011, M. Verderi (param-V09-04-02)
103 - Migration to new G4Exception scheme. 45 - Migration to new G4Exception scheme.
104 - what is V09-04-01 tag ? 46 - what is V09-04-01 tag ?
105 47
106 February 11, 2011, M. Verderi (param-V09-04-00 48 February 11, 2011, M. Verderi (param-V09-04-00)
107 - Implementation of method 49 - Implementation of method
108 void ProposePrimaryTrackFinalKineticEnergy ( 50 void ProposePrimaryTrackFinalKineticEnergy (G4double);
109 was missing : modified file G4FastStep.icc 51 was missing : modified file G4FastStep.icc
110 52
111 March 13, 2008, G. Cosmo (param-V09-01-00) 53 March 13, 2008, G. Cosmo (param-V09-01-00)
112 - Cleared compilation warnings in G4FastSimula 54 - Cleared compilation warnings in G4FastSimulationManagerProcess and
113 G4FastSimulationMessenger on gcc-4.3.0 for a 55 G4FastSimulationMessenger on gcc-4.3.0 for ambiguous use of
114 parentheses in nested if-else statements. 56 parentheses in nested if-else statements.
115 57
116 November 30, 2007, M. Verderi 58 November 30, 2007, M. Verderi
117 - Add Along methods to G4FSMP process 59 - Add Along methods to G4FSMP process
118 - tag as param-V09-00-01 60 - tag as param-V09-00-01
119 61
120 November 30, 2007, M. Verderi 62 November 30, 2007, M. Verderi
121 - minor corrections to G4FastSimulationManager << 63 - minor corrections to G4FastSimulationManagerProcess.hh/.cc :
122 * add call fPathFinder->prepareNewrack(...) 64 * add call fPathFinder->prepareNewrack(...)
123 * deactivate ghost navigator in EndOfTracki 65 * deactivate ghost navigator in EndOfTracking(..) method
124 - tag as param-V09-00-00 66 - tag as param-V09-00-00
125 67
126 May 18, 2007, M. Verderi 68 May 18, 2007, M. Verderi
127 - tag as param-V08-03-00 69 - tag as param-V08-03-00
128 70
129 May 11, 2007, M. Verderi 71 May 11, 2007, M. Verderi
130 - remove include/G4FastSimulationManagerProces 72 - remove include/G4FastSimulationManagerProcess81.hh
131 include/G4FlavoredParallelWorld.hh 73 include/G4FlavoredParallelWorld.hh
132 include/G4GFSManager81.hh 74 include/G4GFSManager81.hh
133 src/G4FastSimulationManagerProcess81. 75 src/G4FastSimulationManagerProcess81.cc
134 src/G4GFSManager81.cc 76 src/G4GFSManager81.cc
135 77
136 78
137 November 10, 2006, M. Verderi - param-V08-01-0 79 November 10, 2006, M. Verderi - param-V08-01-00
138 - Limited number of warning messages printed b 80 - Limited number of warning messages printed by the
139 G4GlobalFastSimulationManager. 81 G4GlobalFastSimulationManager.
140 - Renamed G4FastSimulationManagerProcess_forCo 82 - Renamed G4FastSimulationManagerProcess_forCoupledTransportation with
141 G4FastSimulationManagerProcess81. 83 G4FastSimulationManagerProcess81.
142 In addition, this class can now handle the c 84 In addition, this class can now handle the case of Navigator index=0,
143 i.e., the navigator for tracking, regardless 85 i.e., the navigator for tracking, regardless the G4Transportation or
144 G4CoupledTransportation is used. (For other 86 G4CoupledTransportation is used. (For other navigators, there is
145 of course no choice, and G4CoupledTransporta 87 of course no choice, and G4CoupledTransportation is necessary.)
146 88
147 November 3, 2006 M. Verderi 89 November 3, 2006 M. Verderi
148 - Introduced G4FastSimulationManagerProcess_fo 90 - Introduced G4FastSimulationManagerProcess_forCoupledTransportation class for
149 handling fast simulation in new parallel geo 91 handling fast simulation in new parallel geometry scheme. This requires
150 the G4CoupledTransportation to be active. 92 the G4CoupledTransportation to be active.
151 - Introduced G4GFSManager81 class that gathers 93 - Introduced G4GFSManager81 class that gathers the future code to become the
152 default at next major release in the G4Globa 94 default at next major release in the G4GlobalFastSimulationManager class.
153 - G4FastSimulationManager: adapted to new sche 95 - G4FastSimulationManager: adapted to new scheme. Still has old code for
154 backward compatibilty. 96 backward compatibilty.
155 - G4FastSimulationManagerProcess: mostly the s 97 - G4FastSimulationManagerProcess: mostly the same, apart from a small bug fix.
156 - G4FastSimulationMessenger: new command creat 98 - G4FastSimulationMessenger: new command created "/param/showSetup", useful
157 to show the fast simulation setup (region, m 99 to show the fast simulation setup (region, models, processes, etc...)
158 It is only valid for geometry closed state. 100 It is only valid for geometry closed state. Desirable to have interactive
159 command in the run manager for this. 101 command in the run manager for this.
160 102
161 November 25, 2005, M.Verderi - param-V07-01-0 103 November 25, 2005, M.Verderi - param-V07-01-04
162 - put back Makoto's change: StartTracking(G4Tr 104 - put back Makoto's change: StartTracking(G4Track*)
163 105
164 November 25, 2005, M Verderi - param-V07-01-03 106 November 25, 2005, M Verderi - param-V07-01-03
165 - Make ghost functionnality available with G4R 107 - Make ghost functionnality available with G4Region
166 - ** Note ** Change back StartTracking(G4Track 108 - ** Note ** Change back StartTracking(G4Track*) -> StartTracking() in G4FSMP
167 StartTracking(G4Track*) was intro 109 StartTracking(G4Track*) was introduced in param-V07-01-02
168 because (I guess) of procman-V07-01-01 110 because (I guess) of procman-V07-01-01
169 This is to make param-V07-01-03 compatible w 111 This is to make param-V07-01-03 compatible with geant4-07-01-ref-05
170 112
171 November 21, 2005 M.Asai - param-V07-01-02 113 November 21, 2005 M.Asai - param-V07-01-02
172 - Fix warning message. 114 - Fix warning message.
173 115
174 November 02, 2005 G.Cosmo - param-V07-01-01 116 November 02, 2005 G.Cosmo - param-V07-01-01
175 - Corrected setting of envelope volumes and so 117 - Corrected setting of envelope volumes and solid in G4FastTrack.
176 - Migrated old scheme for G4Exception and some 118 - Migrated old scheme for G4Exception and some cosmetics...
177 119
178 October 28, 2005 M.Asai - param-V07-01-00 120 October 28, 2005 M.Asai - param-V07-01-00
179 - Working tag for merging "envelope" to G4Regi 121 - Working tag for merging "envelope" to G4Region.
180 122
181 December 07, 2004 G. Cosmo - param-V06-02-01 123 December 07, 2004 G. Cosmo - param-V06-02-01
182 - Implemented migration to <cmath>. 124 - Implemented migration to <cmath>.
183 125
184 November 26, 2004 M. Verderi - param-V06-02-00 126 November 26, 2004 M. Verderi - param-V06-02-00
185 - Implemented migration to new G4VParticleChan 127 - Implemented migration to new G4VParticleChange interfaces.
186 128
187 December 12, 2003 G. Cosmo - param-V06-00-00 129 December 12, 2003 G. Cosmo - param-V06-00-00
188 - G4FastSimulationVector.icc: use std_pvector: 130 - G4FastSimulationVector.icc: use std_pvector:: scope for calls to
189 base class. Fixes compilation problem on Int 131 base class. Fixes compilation problem on Intel-icc compiler.
190 132
191 November 10, 2003 G. Cosmo - param-V05-02-01 133 November 10, 2003 G. Cosmo - param-V05-02-01
192 - G4FastTrack: use G4Navigator::CreateTouchabl 134 - G4FastTrack: use G4Navigator::CreateTouchableHistoryHandle() instead of
193 CreateTouchableHistory() in method FRecordsA 135 CreateTouchableHistory() in method FRecordsAffineTransformation().
194 136
195 October 4, 2003 G. Cosmo - param-V05-02-00 137 October 4, 2003 G. Cosmo - param-V05-02-00
196 - Modified GNUmakefile: 138 - Modified GNUmakefile:
197 o added dependency to new module "geometry/n 139 o added dependency to new module "geometry/navigation".
198 - Coworks with "geometry-V05-02-00" and "digit 140 - Coworks with "geometry-V05-02-00" and "digits_hits-V05-02-00".
199 141
200 May 21, 2003 G. Cosmo - param-V05-01-00 142 May 21, 2003 G. Cosmo - param-V05-01-00
201 o Fixed pedantic warnings on Linux-g++ 143 o Fixed pedantic warnings on Linux-g++.
202 o Call base class in copy-constructor 144 o Call base class in copy-constructor of G4FastStep.
203 145
204 Nov 20, 2002 G. Cosmo - param-V04-01-02 146 Nov 20, 2002 G. Cosmo - param-V04-01-02
205 o Patched access to public static data in G4 147 o Patched access to public static data in G4FastStep.cc
206 and G4GlobalFastSimulationManager.cc to al 148 and G4GlobalFastSimulationManager.cc to allow porting on
207 Windows DLLs. 149 Windows DLLs.
208 150
209 Nov 15, 2002 S. Sadilov - param-V04-01-01 151 Nov 15, 2002 S. Sadilov - param-V04-01-01
210 o Fixed compilation problems on Windows in 152 o Fixed compilation problems on Windows in
211 G4FastSimulationManager.cc and G4GlobalFas 153 G4FastSimulationManager.cc and G4GlobalFastSimulationManager.cc
212 154
213 Nov 02, 2002 M. Verderi - param-V04-01-00 155 Nov 02, 2002 M. Verderi - param-V04-01-00
214 o Add method to retrieve G4VFastSimulationMo 156 o Add method to retrieve G4VFastSimulationModel by name.
215 The user's method is in G4GlobalFastSimula 157 The user's method is in G4GlobalFastSimulationManager:
216 158
217 GetFastSimulationModel(); 159 GetFastSimulationModel();
218 160
219 it is accompagnied by same methods name in 161 it is accompagnied by same methods name in
220 G4FastSimulationManager class. 162 G4FastSimulationManager class.
221 163
222 o Add "test" directory, used to test above f 164 o Add "test" directory, used to test above feature.
223 165
224 Oct 26, 2001 M. Verderi - param-V03-02-00 166 Oct 26, 2001 M. Verderi - param-V03-02-00
225 Fixes to clear warnings produced with gcc-2. 167 Fixes to clear warnings produced with gcc-2.95.2:
226 - loop index, where comparison with method " 168 - loop index, where comparison with method "size()" of
227 G4std::vector<T>, changed: int -> size_t << 169 G4std::vector<T>, changed: int -> size_t
228 - change "if ( a=b ) {..}" by "if ( (a=b) ) 170 - change "if ( a=b ) {..}" by "if ( (a=b) ) {...}"
229 this makes the compiler sure you want to mak 171 this makes the compiler sure you want to make an
230 assignement in the "if" condition 172 assignement in the "if" condition
231 - re-order initialisations of a few variable 173 - re-order initialisations of a few variables in constructors
232 to match the declaration order. 174 to match the declaration order.
233 Some warnings still exist, but regard the G4 175 Some warnings still exist, but regard the G4Propagator of geometry.
234 176
235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 177 Apr 3, 2001 J. Apostolakis - param-V03-00-00
236 - Modified G4FastSimulationManagerProcess call 178 - Modified G4FastSimulationManagerProcess call to PropagatorInField ComputeStep
237 to use new interface with G4FieldTrack (in 179 to use new interface with G4FieldTrack (in place of now obsolete interface.)
238 180
239 Nov 14, 2000 G. Cosmo - param-V02-00-01 181 Nov 14, 2000 G. Cosmo - param-V02-00-01
240 - Moved specific parameterisation models to th 182 - Moved specific parameterisation models to the new top category
241 "parameterisations". Moved files: 183 "parameterisations". Moved files:
242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm 184 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRmodel[.hh.cc],
243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster 185 G4IrregularXrayTRmodel[.hh.cc], G4PAIclusterModel[.hh.cc],
244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr 186 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXrayTRmodel[.hh.cc],
245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode 187 G4RegularXrayTRmodel[.hh.cc], G4VClusterModel[.hh.cc],
246 G4VXrayTRmodel[.hh.cc]. 188 G4VXrayTRmodel[.hh.cc].
247 - Cleaned-up GNUmakefile of non necessary depe 189 - Cleaned-up GNUmakefile of non necessary dependencies.
248 190
249 Aug 03, 2000 G. Cosmo - param-V02-00-00r 191 Aug 03, 2000 G. Cosmo - param-V02-00-00r
250 - Changed RandGauss to G4RandGauss in G4Irregu 192 - Changed RandGauss to G4RandGauss in G4IrregularXrayTRmodel.cc and
251 G4VXrayTRmodel.cc to fix events' reproducibi 193 G4VXrayTRmodel.cc to fix events' reproducibility problem.
252 - G4VXrayTRmodel.cc: fix to class destructor ( 194 - G4VXrayTRmodel.cc: fix to class destructor (V.Grichine)
253 195
254 Jun 15, 2000 G. Cosmo - param-V01-01-04 196 Jun 15, 2000 G. Cosmo - param-V01-01-04
255 - The tag coworks with global-V01-01-04 and ma 197 - The tag coworks with global-V01-01-04 and materials-V01-01-00:
256 o Fixed usage of G4complex type for ISO and 198 o Fixed usage of G4complex type for ISO and non-ISO compilers.
257 Affected files: G4FoamXrayTRmodel.cc, G4Ga 199 Affected files: G4FoamXrayTRmodel.cc, G4GamDistrXrayTRmodel.cc, G4PlateIrrGasXrayTRmodel.cc
258 and G4RegularXrayTRmodel.c 200 and G4RegularXrayTRmodel.cc.
259 In case of G4complex types passed to mathe 201 In case of G4complex types passed to mathematical functions, use G4std:: prefix.
260 o Fixed usage of G4Integrator class, now cha 202 o Fixed usage of G4Integrator class, now changed to templated to allow porting of the
261 code on SUN-CC compiler which does not imp 203 code on SUN-CC compiler which does not implement templated member functions.
262 Affected files: G4VXrayTRmodel[.hh.cc] 204 Affected files: G4VXrayTRmodel[.hh.cc]
263 205
264 Jun 6, 2000 M. Verderi & P. Mora de Freitas 206 Jun 6, 2000 M. Verderi & P. Mora de Freitas
265 - fixed compilation errors with HP-aCC for the 207 - fixed compilation errors with HP-aCC for the files G4RegularXrayTRmodel.cc,
266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod 208 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmodel.cc.
267 209
268 May 30, 2000 M. Verderi & P. Mora de Freitas 210 May 30, 2000 M. Verderi & P. Mora de Freitas
269 211
270 - parameterisation category is now RW free. 212 - parameterisation category is now RW free.
271 213
272 September 16, 1999 M. Verderi & P. Mora de Fre 214 September 16, 1999 M. Verderi & P. Mora de Freitas
273 215
274 - Fixed bug in G4FastStep::CheckIt() method. 216 - Fixed bug in G4FastStep::CheckIt() method.
275 217
276 April 19, 1999 M. Verderi & P. Mora de Freitas 218 April 19, 1999 M. Verderi & P. Mora de Freitas
277 219
278 Changes in G4FastStep to co-work with track-01 220 Changes in G4FastStep to co-work with track-01-00-04:
279 221
280 1) The method void CheckIt(const G4Track&) bec << 222 1) The method void CheckIt(const G4Track&) becomes
281 G4bool CheckIt(const G4Track&); 223 G4bool CheckIt(const G4Track&);
282 2) The FAST_STEP_DEBUG compiling option disapp 224 2) The FAST_STEP_DEBUG compiling option disappears;
283 3) Call to CheckIt controled by the G4VParticl 225 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute.
284 226
285 Miscellaneous: the declaration "G4double mass 227 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh
286 corrected to G4double mass =...". 228 corrected to G4double mass =...".
287 229
288 April 15, 1999 M. Verderi & P. Mora de Freitas 230 April 15, 1999 M. Verderi & P. Mora de Freitas
289 231
290 Tasks to decouple visualization from processes 232 Tasks to decouple visualization from processes/parameterisation:
291 233
292 1) G4GlobalFastSimulationManager now inherites 234 1) G4GlobalFastSimulationManager now inherites from the intercoms/
293 G4VGlobalFastSimulationManager to allow visual << 235 G4VGlobalFastSimulationManager to allow visualisation to get a
294 concrete instance pointer to the G4GlobalFastS 236 concrete instance pointer to the G4GlobalFastSimulationManager,
295 if any. 237 if any.
296 238
297 2) G4FlavoredParallelWorld now inherites from 239 2) G4FlavoredParallelWorld now inherites from the intercoms/
298 G4VFlavoredParallelWorld, a pure virtual abstr 240 G4VFlavoredParallelWorld, a pure virtual abstract class to interface
299 parameterisation with visualization. 241 parameterisation with visualization.
300 242
301 Co-works with intercoms-01-00-01 tag 243 Co-works with intercoms-01-00-01 tag
302 244
303 Modified files: 245 Modified files:
304 --------------- 246 ---------------
305 G4FlavoredParallelWorld.hh 247 G4FlavoredParallelWorld.hh
306 G4GlobalFastSimulationManager.hh 248 G4GlobalFastSimulationManager.hh
307 G4GlobalFastSimulationManager.cc 249 G4GlobalFastSimulationManager.cc
308 250
309 Done, tested, system-tested on HP-aCC with exe 251 Done, tested, system-tested on HP-aCC with exemple N05.
310 252
311 April 14, 1999 M. Verderi & P. Mora de Freitas 253 April 14, 1999 M. Verderi & P. Mora de Freitas
312 254
313 Several consolidation tasks (thanks to G. Cosm 255 Several consolidation tasks (thanks to G. Cosmo):
314 256
315 1) Warning: << 257 1) Warning:
316 ----------- 258 -----------
317 259
318 Pointers usage 260 Pointers usage
319 261
320 - Setting pointers to 0 after delete: 262 - Setting pointers to 0 after delete:
321 263
322 delete pA; 264 delete pA;
323 pA = 0; 265 pA = 0;
324 266
325 - Avoid to use "NULL". 267 - Avoid to use "NULL".
326 268
327 Modified files: 269 Modified files:
328 --------------- 270 ---------------
329 G4FastSimulationManager.hh 271 G4FastSimulationManager.hh
330 G4FastTrack.hh 272 G4FastTrack.hh
331 G4FlavoredParallelWorld.hh 273 G4FlavoredParallelWorld.hh
332 G4FastSimulationManager.cc 274 G4FastSimulationManager.cc
333 G4FastSimulationMessenger.cc 275 G4FastSimulationMessenger.cc
334 G4FastSimulationManagerProcess.cc 276 G4FastSimulationManagerProcess.cc
335 G4FastTrack.cc 277 G4FastTrack.cc
336 G4GlobalFastSimulationManager.cc 278 G4GlobalFastSimulationManager.cc
337 G4VFastSimulationModel.cc 279 G4VFastSimulationModel.cc
338 280
339 Status: << 281 Status:
340 ------- 282 -------
341 Done, tested, system-tested on HP-aCC with exe 283 Done, tested, system-tested on HP-aCC with exemple N05.
342 284
343 2) Warning: 285 2) Warning:
344 ----------- 286 -----------
345 include/G4FastSimulationManager.hh:163 287 include/G4FastSimulationManager.hh:163
346 Public member functions shall always retur 288 Public member functions shall always return const handles to member data
347 Severe violation: Universal Coding Standar 289 Severe violation: Universal Coding Standards item 18
348 290
349 offending code: 291 offending code:
350 --------------- 292 ---------------
351 inline G4VParticleChange* G4FastSimulationMana 293 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange()
352 { 294 {
353 return &fFastStep; 295 return &fFastStep;
354 } 296 }
355 297
356 Diagnostic: 298 Diagnostic:
357 ---------- 299 ----------
358 300
359 Called by the G4FastSimulationManagerProcess << 301 Called by the G4FastSimulationManagerProcess to return it in the
360 PostStepDoIt call. << 302 PostStepDoIt call.
361 303
362 Action: 304 Action:
363 ------- 305 -------
364 The G4FastSimulationManager::GettheParticleCha 306 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any
365 more. The G4VParticleChange* is now returned d 307 more. The G4VParticleChange* is now returned directly when invoking the
366 G4FastSimulationManager::InvokePostStepDoIt() 308 G4FastSimulationManager::InvokePostStepDoIt() and
367 G4FastSimulationManager::InvokeAtRestDoIt() me 309 G4FastSimulationManager::InvokeAtRestDoIt() methodes.
368 310
369 Modified files: 311 Modified files:
370 --------------- 312 ---------------
371 G4FastSimulationManager.hh 313 G4FastSimulationManager.hh
372 G4FastSimulationManager.cc 314 G4FastSimulationManager.cc
373 G4FastSimulationManagerProcess.cc 315 G4FastSimulationManagerProcess.cc
374 316
375 Status: << 317 Status:
376 ------- 318 -------
377 Done, tested, system-tested on HP-aCC with exe 319 Done, tested, system-tested on HP-aCC with exemple N05.
378 320
379 3) Warning: 321 3) Warning:
380 ----------- 322 -----------
381 include/G4FastSimulationManagerProcess.hh:52 323 include/G4FastSimulationManagerProcess.hh:52
382 If a class has virtual functions it shall 324 If a class has virtual functions it shall have a virtual destructor
383 Severe violation: Universal Coding Standar 325 Severe violation: Universal Coding Standards item 17
384 class G4FastSimulationManagerProcess has v 326 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor.
385 327
386 offending code: 328 offending code:
387 --------------- 329 ---------------
388 ~G4FastSimulationManagerProcess(); 330 ~G4FastSimulationManagerProcess();
389 331
390 Diagnostic: 332 Diagnostic:
391 ---------- 333 ----------
392 Nobody should inherites from G4FastSimulatio << 334 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual
393 is added. 335 is added.
394 336
395 Action: 337 Action:
396 ------- 338 -------
397 virtual ~G4FastSimulationManagerProcess(); 339 virtual ~G4FastSimulationManagerProcess();
398 340
399 Modified files: 341 Modified files:
400 --------------- 342 ---------------
401 G4FastSimulationManagerProcess.hh 343 G4FastSimulationManagerProcess.hh
402 344
403 Status: << 345 Status:
404 ------- 346 -------
405 Done. 347 Done.
406 348
407 4) Warning: 349 4) Warning:
408 ----------- 350 -----------
409 include/G4FastSimulationMessenger.hh:36 351 include/G4FastSimulationMessenger.hh:36
410 If a class has virtual functions it shall 352 If a class has virtual functions it shall have a virtual destructor
411 Severe violation: Universal Coding Standar 353 Severe violation: Universal Coding Standards item 17
412 class G4FastSimulationMessenger has virtua 354 class G4FastSimulationMessenger has virtual functions without a virtual destructor.
413 355
414 356
415 offending code: 357 offending code:
416 --------------- 358 ---------------
417 ~G4FastSimulationMessenger(); 359 ~G4FastSimulationMessenger();
418 360
419 Diagnostic: 361 Diagnostic:
420 ---------- 362 ----------
421 Nobody should inherites from G4FastSimulatio << 363 Nobody should inherites from G4FastSimulationMessenger BUT for virtual
422 is added. 364 is added.
423 365
424 Action: 366 Action:
425 ------- 367 -------
426 virtual ~G4FastSimulationMessenger(); 368 virtual ~G4FastSimulationMessenger();
427 369
428 Modified files: 370 Modified files:
429 --------------- 371 ---------------
430 G4FastSimulationMessenger.hh 372 G4FastSimulationMessenger.hh
431 373
432 Status: << 374 Status:
433 ------- 375 -------
434 Done. 376 Done.
435 377
436 5) Warning: 378 5) Warning:
437 ----------- 379 -----------
438 include/G4FastStep.hh:224 380 include/G4FastStep.hh:224
439 Operator= should call base class operator= 381 Operator= should call base class operator=
440 Possible severe violation: Effective C++ i 382 Possible severe violation: Effective C++ item 16
441 operator= in class G4FastStep, should call 383 operator= in class G4FastStep, should call operator= in base class G4VParticleChange
442 384
443 offending code: 385 offending code:
444 --------------- 386 ---------------
445 G4FastStep & G4FastStep::operator=(const G4Fas 387 G4FastStep & G4FastStep::operator=(const G4FastStep &right)
446 { 388 {
447 if (this != &right) 389 if (this != &right)
448 { 390 {
449 theListOfSecondaries = right.th 391 theListOfSecondaries = right.theListOfSecondaries;
450 theSizeOftheListOfSecondaries = right.th 392 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries;
451 theNumberOfSecondaries = right.th 393 theNumberOfSecondaries = right.theNumberOfSecondaries;
452 theStatusChange = right.th 394 theStatusChange = right.theStatusChange;
453 theMomentumChange = right.th 395 theMomentumChange = right.theMomentumChange;
454 thePolarizationChange = right.th 396 thePolarizationChange = right.thePolarizationChange;
455 thePositionChange = right.th 397 thePositionChange = right.thePositionChange;
456 theTimeChange = right.th 398 theTimeChange = right.theTimeChange;
457 theEnergyChange = right.th 399 theEnergyChange = right.theEnergyChange;
458 theTrueStepLength = right.th 400 theTrueStepLength = right.theTrueStepLength;
459 theLocalEnergyDeposit = right.th 401 theLocalEnergyDeposit = right.theLocalEnergyDeposit;
460 theSteppingControlFlag = right.th 402 theSteppingControlFlag = right.theSteppingControlFlag;
461 theWeightChange = right.th 403 theWeightChange = right.theWeightChange;
462 } 404 }
463 return *this; 405 return *this;
464 } 406 }
465 407
466 Diagnostic: 408 Diagnostic:
467 ---------- 409 ----------
468 Bug detected. 410 Bug detected.
469 411
470 Action: 412 Action:
471 ------- 413 -------
472 Insert the call 414 Insert the call
473 G4VParticleChange::operator=(right); 415 G4VParticleChange::operator=(right);
474 416
475 Status: 417 Status:
476 ------- 418 -------
477 Done, tested, system-tested on HP-aCC with e 419 Done, tested, system-tested on HP-aCC with exemple N05.
478 420
479 Modified files: 421 Modified files:
480 --------------- 422 ---------------
481 G4FastStep.cc 423 G4FastStep.cc
482 424
483 6) Warning: 425 6) Warning:
484 ----------- 426 -----------
485 include/G4FastStep.hh:59 427 include/G4FastStep.hh:59
486 Avoid data members in the public interface 428 Avoid data members in the public interface
487 Violation: Effective C++ item 20 429 Violation: Effective C++ item 20
488 Public data members for class G4FastStep: 430 Public data members for class G4FastStep:
489 debugFlag 431 debugFlag
490 432
491 433
492 offending code: 434 offending code:
493 --------------- 435 ---------------
494 public: 436 public:
495 ... 437 ...
496 G4bool debugFlag; 438 G4bool debugFlag;
497 439
498 Diagnostic: 440 Diagnostic:
499 ---------- 441 ----------
500 Historical usage. 442 Historical usage.
501 443
502 Action: 444 Action:
503 ------- 445 -------
504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 446 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file.
505 447
506 Modified files: 448 Modified files:
507 --------------- 449 ---------------
508 G4FastStep.hh, G4FastStep.cc 450 G4FastStep.hh, G4FastStep.cc
509 451
510 Status: 452 Status:
511 ------- 453 -------
512 Done, tested, system-tested on HP-aCC with e 454 Done, tested, system-tested on HP-aCC with exemple N05.
513 455
514 7) Warning: 456 7) Warning:
515 ----------- 457 -----------
516 include/G4FastStep.hh:59 458 include/G4FastStep.hh:59
517 If a class has virtual functions it shall 459 If a class has virtual functions it shall have a virtual destructor
518 Severe violation: Universal Coding Standar 460 Severe violation: Universal Coding Standards item 17
519 class G4FastStep has virtual functions wit 461 class G4FastStep has virtual functions without a virtual destructor.
520 462
521 463
522 offending code: 464 offending code:
523 --------------- 465 ---------------
524 ~G4FastStep(); 466 ~G4FastStep();
525 467
526 Diagnostic: 468 Diagnostic:
527 ---------- 469 ----------
528 Nobody should inherites from G4FastStep BUT 470 Nobody should inherites from G4FastStep BUT virtual added.
529 471
530 Action: 472 Action:
531 ------- 473 -------
532 virtual ~G4FastStep(); 474 virtual ~G4FastStep();
533 475
534 Modified files: 476 Modified files:
535 --------------- 477 ---------------
536 G4FastStep.hh 478 G4FastStep.hh
537 479
538 Status: 480 Status:
539 ------- 481 -------
540 Done, tested, system-tested on HP-aCC with e 482 Done, tested, system-tested on HP-aCC with exemple N05.
541 483
542 484
543 December 7, 1998 M. Verderi 485 December 7, 1998 M. Verderi
544 G4FastSimulationManagerProcess class: 486 G4FastSimulationManagerProcess class:
545 Fixes made for ghost navigation with 487 Fixes made for ghost navigation with
546 mag-field: 488 mag-field:
547 LocateGlobalPointAndUpdateTouchable is 489 LocateGlobalPointAndUpdateTouchable is
548 always used (in not the Locate...Setup 490 always used (in not the Locate...Setup
549 method) 491 method)
550 In PostStepDoIt: correction of position and 492 In PostStepDoIt: correction of position and
551 direction of the track are made when << 493 direction of the track are made when
552 possible in case of mag-field. 494 possible in case of mag-field.
553 This correction comes from the fact that a 495 This correction comes from the fact that a
554 small discrepancy appears on those quantitie 496 small discrepancy appears on those quantities
555 because of the numerical integration along 497 because of the numerical integration along
556 the field on the track path: the G4FSMP 498 the field on the track path: the G4FSMP
557 proposes a curve-length, the transportation 499 proposes a curve-length, the transportation
558 moves the track along this curve, however 500 moves the track along this curve, however
559 the end point position and direction are 501 the end point position and direction are
560 slightly different from those expected by 502 slightly different from those expected by
561 the G4FSMP when it proposed the length. 503 the G4FSMP when it proposed the length.
562 504
563 November 20,1998 M. Verderi 505 November 20,1998 M. Verderi
564 G4FastStep class: 506 G4FastStep class:
565 Remove track/G4BiasingTag.hh dependancy (ob 507 Remove track/G4BiasingTag.hh dependancy (obsolete).
566 Adapted to new shceme of Event Biasing mech 508 Adapted to new shceme of Event Biasing mechanism,
567 consistently with track-00-04-01 tag. 509 consistently with track-00-04-01 tag.
568 510
569 November 11,1998 M. Verderi 511 November 11,1998 M. Verderi
570 Merge of param-00-03-02 & param-00-03-02a i 512 Merge of param-00-03-02 & param-00-03-02a into
571 param-00-03-04a (hopefully...) 513 param-00-03-04a (hopefully...)
572 The point is the chnage of signature in the 514 The point is the chnage of signature in the
573 LocateGlobalPointAndSetup(..) of the G4Navi 515 LocateGlobalPointAndSetup(..) of the G4Navigator making use now
574 of the track direction. The G4FastSimulatio 516 of the track direction. The G4FastSimulationManagerProcess is
575 changed accordingly: 517 changed accordingly:
576 fGhostNavigator.LocateGlobalPointAndSetup(t 518 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true);
577 519
578 520
579 November 6, 1998 M. Verderi 521 November 6, 1998 M. Verderi
580 - Extension of the G4FastStep to allow the 522 - Extension of the G4FastStep to allow the biasing technic.
581 Changes are made in: 523 Changes are made in:
582 - G4FastStep.hh/.icc: 524 - G4FastStep.hh/.icc:
583 new member G4BiasingTa 525 new member G4BiasingTag fBiasTag;
584 new method SetPrimaryT 526 new method SetPrimaryTrackFinalBiasingTag
585 ( G4BiasingTag 527 ( G4BiasingTag aTag );
586 - G4FastStep.cc: 528 - G4FastStep.cc:
587 Initialize(); 529 Initialize();
588 operator=; << 530 operator=;
589 UpdateForPostStep(); 531 UpdateForPostStep();
590 UpdateForAtRest(); << 532 UpdateForAtRest();
591 533
592 October 26, 1998 P.Mora de Freitas 534 October 26, 1998 P.Mora de Freitas
593 - G4FastSimulationManagerProcess and G4Fast 535 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal
594 with at rest parameterisations also when 536 with at rest parameterisations also when using parallel geometry.
595 537
596 October 8, 1998 P.Mora de Freitas 538 October 8, 1998 P.Mora de Freitas
597 - The G4VFastSimulationModel::IsApplicable( 539 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual
598 methode. 540 methode.
599 - G4FastSimulationManager optimisation: 541 - G4FastSimulationManager optimisation:
600 - New G4ParticleDefinition* fLastCrossedP 542 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps
601 the last particle type with touched the 543 the last particle type with touched the envelope;
602 - New G4RWTPtrOrderedVector<G4VFastSimula 544 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList
603 data member, keeps the model list of th << 545 data member, keeps the model list of the applicable models for
604 the actual fLastCrossedParticle particl 546 the actual fLastCrossedParticle particle type;
605 - Changes in the PostStepGetFastSimulatio << 547 - Changes in the PostStepGetFastSimulationManagerTrigger() and
606 AtRestGetFastSimulationManagerTrigger() << 548 AtRestGetFastSimulationManagerTrigger()methodes to update the
607 fApplicableModelList when needed (fLast 549 fApplicableModelList when needed (fLastCrossedParticle !=
608 the actual tracked particle); 550 the actual tracked particle);
609 - Changes in the << 551 - Changes in the
610 G4FastSimulationManager() (Constructor) 552 G4FastSimulationManager() (Constructor)
611 ActivateFastSimulationModel(), 553 ActivateFastSimulationModel(),
612 InActivateFastSimulationModel(), 554 InActivateFastSimulationModel(),
613 AtRestGetFastSimulationManagerTrigger(), 555 AtRestGetFastSimulationManagerTrigger(),
614 AddFastSimulationModel(), 556 AddFastSimulationModel(),
615 RemoveFastSimulationModel() 557 RemoveFastSimulationModel()
616 methodes to set the fLastCrossedParticle to 558 methodes to set the fLastCrossedParticle to NULL, forcing the
617 fApplicableModelList to be rebuilt. 559 fApplicableModelList to be rebuilt.
618 560
619 September 22, 1998 P.Mora de Freitas 561 September 22, 1998 P.Mora de Freitas
620 Fixed bug in parallel navigation. << 562 Fixed bug in parallel navigation.
621 File touched: G4FastSimulationManagerProces 563 File touched: G4FastSimulationManagerProcess.cc
622 Tested on HP-aCC. 564 Tested on HP-aCC.
623 565
624 September 17, 1998 P.Mora de Freitas 566 September 17, 1998 P.Mora de Freitas
625 G4FastSimulationManager::RemoveFastSimulati 567 G4FastSimulationManager::RemoveFastSimulationModel() updated to look
626 for also in the fInactivatedModels list. 568 for also in the fInactivatedModels list.
627 569
628 Tested on HP-aCC. 570 Tested on HP-aCC.
629 571
630 September 16, 1998 P.Mora de Freitas 572 September 16, 1998 P.Mora de Freitas
631 New /param/ control commands: 573 New /param/ control commands:
632 574
633 /param/ActivateModel <ModelName> 575 /param/ActivateModel <ModelName>
634 /param/InActivateModel <ModelName> 576 /param/InActivateModel <ModelName>
635 577
636 Activate or inactivate a given parameterisat 578 Activate or inactivate a given parameterisation model.
637 579
638 Tested on HP-aCC. 580 Tested on HP-aCC.
639 581
640 August 21, 1998 P.Mora de Freitas 582 August 21, 1998 P.Mora de Freitas
641 G4FastSimulationManagerProcess's G4ProcessTy 583 G4FastSimulationManagerProcess's G4ProcessType set to
642 fParameterisation, accordingly with procman-00 584 fParameterisation, accordingly with procman-00-02-03.
643 585
644 Tested on HP-aCC. 586 Tested on HP-aCC.
645 587
646 August 12, 1998 P.Mora de Freitas 588 August 12, 1998 P.Mora de Freitas
647 Improved the "close parameterisation control << 589 Improved the "close parameterisation control" to
648 590
649 1) avoid the close looping when unnecessary 591 1) avoid the close looping when unnecessary (mostly cases);
650 2) force re-close when necessary (insert/rem 592 2) force re-close when necessary (insert/remove ghosts).
651 593
652 Changes: 594 Changes:
653 595
654 1) the G4GlobalFastSimulationManager::fClose << 596 1) the G4GlobalFastSimulationManager::fClosed is now initialised
655 to true by the G4GlobalFastSimulationMana 597 to true by the G4GlobalFastSimulationManager constructor;
656 598
657 2) new method << 599 2) new method
658 600
659 void << 601 void
660 G4GlobalFastSimulationManager::FastSimula 602 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed();
661 603
662 called by the AddGhostPlacement and Remov << 604 called by the AddGhostPlacement and RemoveGhostPlacement
663 G4FastSimulationManager methods to set fa 605 G4FastSimulationManager methods to set false the fClosed flag;
664 606
665 3) changes in the G4GlobalFastSimulationMana 607 3) changes in the G4GlobalFastSimulationManager::Notify method
666 to deal with these changes. 608 to deal with these changes.
667 609
668 Tested on HP-aCC. 610 Tested on HP-aCC.
669 611
670 August 11, 1998 P.Mora de Freitas 612 August 11, 1998 P.Mora de Freitas
671 Fix to the G4FastStep::KillPrimaryTrack() me 613 Fix to the G4FastStep::KillPrimaryTrack() method to drop the
672 nonsense line 614 nonsense line
673 615
674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 616 SetMomentumChange(0.,0.,0.) ; /* necessary ? */
675 617
676 Tested on HP-aCC. 618 Tested on HP-aCC.
677 (Thanks to Willy Langeveld) 619 (Thanks to Willy Langeveld)
678 620
679 621
680 August 10, 1998 P.Mora de Freitas 622 August 10, 1998 P.Mora de Freitas
681 Fix to the SetPrimaryTrackFinalKineticEnergy 623 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method
682 from the G4FastStep class the SetMomentumChang 624 from the G4FastStep class the SetMomentumChange() call to insure that
683 the new momentum direction is a unit vector (a << 625 the new momentum direction is a unit vector (as asked by the
684 G4DynamicParticle::SetMomentumDirection method 626 G4DynamicParticle::SetMomentumDirection method).
685 627
686 Touched files: G4FastStep.hh (improved comme 628 Touched files: G4FastStep.hh (improved comments)
687 G4FastStep.cc (fixed) 629 G4FastStep.cc (fixed)
688 630
689 Tested on HP-aCC. 631 Tested on HP-aCC.
690 (Thanks to Willy Langeveld) 632 (Thanks to Willy Langeveld)
691 633
692 August 7, 1998 P.Mora de Freitas 634 August 7, 1998 P.Mora de Freitas
693 New /param/ commands directory with the comm 635 New /param/ commands directory with the commands:
694 636
695 /param/listEnvelopes [ParticleName] 637 /param/listEnvelopes [ParticleName]
696 638
697 - List all the envelope names for a given pa 639 - List all the envelope names for a given particle
698 (or for all particles if without parameter 640 (or for all particles if without parameters).
699 641
700 /param/listModels [EnvelopeName] 642 /param/listModels [EnvelopeName]
701 643
702 - List all the Model names for a given envel 644 - List all the Model names for a given envelope
703 (or for all envelopes if without parameter 645 (or for all envelopes if without parameters).
704 646
705 /param/listIsApplicable [ModelName] 647 /param/listIsApplicable [ModelName]
706 648
707 - List all the particle names a given model 649 - List all the particle names a given model is applicable
708 (or for all models if without parameters). 650 (or for all models if without parameters).
709 651
710 652
711 August 7, 1998 P.Mora de Freitas 653 August 7, 1998 P.Mora de Freitas
712 History file Created. 654 History file Created.