| Geant4 Cross Reference |
1 # Category param History << 1 $Id: History 101152 2016-11-08 08:07:39Z gcosmo $
2 << 2 -------------------------------------------------------------------
3 See `CONTRIBUTING.rst` for details of **requir <<
4 which **must** added in reverse chronological <<
5 It must **not** be used as a substitute for wr <<
6 <<
7 ---------------------------------------------- <<
8 <<
9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) <<
10 - In G4GlobalFastSimulationManager: <<
11 use G4ThreadLocalSingleton to avoid undelete <<
12 <<
13 ## 2023-10-18 Ben Morgan (param-V11-01-03) <<
14 - Apply standard and extended clang-tidy fixes <<
15 - Mark empty/obsolete functions as deprecated <<
16 <<
17 ## 2023-10-16 Ben Morgan (param-V11-01-02) <<
18 - Apply standard clang-format-ing. <<
19 - Normal order accessors and docstrings. <<
20 <<
21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) <<
22 - In G4FastTrack, removed references to G4Touc <<
23 which is now deprecated. <<
24 <<
25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 <<
26 - Added missing virtual destructor to G4VFastS <<
27 <<
28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) <<
29 - Fixed compilation warnings for implicit type <<
30 <<
31 ## 2022-10-27 Makoto Asai (param-V11-00-03) <<
32 - G4FastSimHitMaker - making compatible to com <<
33 <<
34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 <<
35 - G4FastStep - delete copy constructor and ope <<
36 <<
37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) <<
38 - Adding the 'flush' method to the fast simula <<
39 This method allows to process the input buff <<
40 the end of the G4 event. It is used when par <<
41 The 'flash' is triggered inside the event lo <<
42 The fast simulation model may add secondarie <<
43 by Geant4. <<
44 <<
45 ## 2021-12-10 Ben Morgan (param-V11-00-00) <<
46 - Change to new Markdown History format <<
47 <<
48 --- <<
49 <<
50 # History entries prior to 11.0 <<
51 <<
52 April 16, 2021 Ben Morgan (param-V10-07-00) <<
53 - Migrate build to modular CMake API <<
54 <<
55 October 5, 2020, A. Zaborowska (param-V10-06-0 <<
56 - Introduce general facilities based on GFlash <<
57 to facilitate multiple hit (energy & positio <<
58 from fast simulation models. <<
59 <<
60 September 9, 2020, G. Cosmo (param-V10-06-02) <<
61 - Fixed minor Coverity defect for uninitialise <<
62 <<
63 April 21, 2020, A. Zaborowska (param-V10-06-01 <<
64 - Sanity check for root logical volumes for re <<
65 UI command /param/showSetup works also if no <<
66 <<
67 March 26, 2020, I. Semeniouk (param-V10-06-00) <<
68 - G4FastSimulationHelper : merge ActivateFastS <<
69 - G4FastSimulationManager.hh, G4VFastSimulatio <<
70 redefinition of G4Envelope type <<
71 <<
72 October 30, 2019, A. Zaborowska (param-v10-05- <<
73 - Register G4FastSimulationManagerProcess with <<
74 G4FastSimulationManagerHelper to ensure it i <<
75 invoked for a given step (ExclusivelyForced) <<
76 StronglyForced processes will be considered. <<
77 <<
78 December 19, 2017, G. Cosmo (param-V10-04-00) <<
79 - Fixed self-consistency in G4FastSimulationVe <<
80 Thanks to Raphael Isemann for reporting this <<
81 3
>> 4 =========================================================
>> 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP
>> 6 =========================================================
>> 7
>> 8 Category History file
>> 9 ---------------------
>> 10 This file should be used by G4 developers and category coordinators
>> 11 to briefly summarize all major modifications introduced in the code
>> 12 and keep track of all category-tags.
>> 13 It DOES NOT substitute the CVS log-message one should put at every
>> 14 committal in the CVS repository !
>> 15
>> 16 ----------------------------------------------------------
>> 17 * Reverse chronological order (last date on top), please *
>> 18 ----------------------------------------------------------
>> 19
82 November 03, 2016, M. Verderi (param-V10-02-01 20 November 03, 2016, M. Verderi (param-V10-02-01)
83 - New G4FastSimulationManagerHelper utility fo 21 - New G4FastSimulationManagerHelper utility for
84 adding G4FastSimulationManagerProcess to a 22 adding G4FastSimulationManagerProcess to a
85 process manager. 23 process manager.
86 24
87 November 02, 2016, M. Verderi (param-V10-02-00 25 November 02, 2016, M. Verderi (param-V10-02-00)
88 - fix various Coverity defects. 26 - fix various Coverity defects.
89 27
90 March 27, 2013, M. Verderi (param-V09-06-00) 28 March 27, 2013, M. Verderi (param-V09-06-00)
91 - remove unused field 'fOnBoundary' in G4FastS 29 - remove unused field 'fOnBoundary' in G4FastSimulationManagerProcess.hh
92 as this was causing a warning from clang. 30 as this was causing a warning from clang.
93 31
94 July 10, 2012, G. Cosmo (param-V09-05-00) 32 July 10, 2012, G. Cosmo (param-V09-05-00)
95 - Explicitly use inclusion of headers for syst 33 - Explicitly use inclusion of headers for system of units and physical
96 constants, in plan to remove implicit inclus 34 constants, in plan to remove implicit inclusion from globals.hh.
97 35
98 September 30, 2011, M. Verderi (param-V09-04-0 36 September 30, 2011, M. Verderi (param-V09-04-03)
99 - Added missing new header file (G4FastSimulat 37 - Added missing new header file (G4FastSimulationProcessType.hh) in
100 sources.cmake. 38 sources.cmake.
101 39
102 September 30, 2011, M. Verderi (param-V09-04-0 40 September 30, 2011, M. Verderi (param-V09-04-02)
103 - Migration to new G4Exception scheme. 41 - Migration to new G4Exception scheme.
104 - what is V09-04-01 tag ? 42 - what is V09-04-01 tag ?
105 43
106 February 11, 2011, M. Verderi (param-V09-04-00 44 February 11, 2011, M. Verderi (param-V09-04-00)
107 - Implementation of method 45 - Implementation of method
108 void ProposePrimaryTrackFinalKineticEnergy ( 46 void ProposePrimaryTrackFinalKineticEnergy (G4double);
109 was missing : modified file G4FastStep.icc 47 was missing : modified file G4FastStep.icc
110 48
111 March 13, 2008, G. Cosmo (param-V09-01-00) 49 March 13, 2008, G. Cosmo (param-V09-01-00)
112 - Cleared compilation warnings in G4FastSimula 50 - Cleared compilation warnings in G4FastSimulationManagerProcess and
113 G4FastSimulationMessenger on gcc-4.3.0 for a 51 G4FastSimulationMessenger on gcc-4.3.0 for ambiguous use of
114 parentheses in nested if-else statements. 52 parentheses in nested if-else statements.
115 53
116 November 30, 2007, M. Verderi 54 November 30, 2007, M. Verderi
117 - Add Along methods to G4FSMP process 55 - Add Along methods to G4FSMP process
118 - tag as param-V09-00-01 56 - tag as param-V09-00-01
119 57
120 November 30, 2007, M. Verderi 58 November 30, 2007, M. Verderi
121 - minor corrections to G4FastSimulationManager << 59 - minor corrections to G4FastSimulationManagerProcess.hh/.cc :
122 * add call fPathFinder->prepareNewrack(...) 60 * add call fPathFinder->prepareNewrack(...)
123 * deactivate ghost navigator in EndOfTracki 61 * deactivate ghost navigator in EndOfTracking(..) method
124 - tag as param-V09-00-00 62 - tag as param-V09-00-00
125 63
126 May 18, 2007, M. Verderi 64 May 18, 2007, M. Verderi
127 - tag as param-V08-03-00 65 - tag as param-V08-03-00
128 66
129 May 11, 2007, M. Verderi 67 May 11, 2007, M. Verderi
130 - remove include/G4FastSimulationManagerProces 68 - remove include/G4FastSimulationManagerProcess81.hh
131 include/G4FlavoredParallelWorld.hh 69 include/G4FlavoredParallelWorld.hh
132 include/G4GFSManager81.hh 70 include/G4GFSManager81.hh
133 src/G4FastSimulationManagerProcess81. 71 src/G4FastSimulationManagerProcess81.cc
134 src/G4GFSManager81.cc 72 src/G4GFSManager81.cc
135 73
136 74
137 November 10, 2006, M. Verderi - param-V08-01-0 75 November 10, 2006, M. Verderi - param-V08-01-00
138 - Limited number of warning messages printed b 76 - Limited number of warning messages printed by the
139 G4GlobalFastSimulationManager. 77 G4GlobalFastSimulationManager.
140 - Renamed G4FastSimulationManagerProcess_forCo 78 - Renamed G4FastSimulationManagerProcess_forCoupledTransportation with
141 G4FastSimulationManagerProcess81. 79 G4FastSimulationManagerProcess81.
142 In addition, this class can now handle the c 80 In addition, this class can now handle the case of Navigator index=0,
143 i.e., the navigator for tracking, regardless 81 i.e., the navigator for tracking, regardless the G4Transportation or
144 G4CoupledTransportation is used. (For other 82 G4CoupledTransportation is used. (For other navigators, there is
145 of course no choice, and G4CoupledTransporta 83 of course no choice, and G4CoupledTransportation is necessary.)
146 84
147 November 3, 2006 M. Verderi 85 November 3, 2006 M. Verderi
148 - Introduced G4FastSimulationManagerProcess_fo 86 - Introduced G4FastSimulationManagerProcess_forCoupledTransportation class for
149 handling fast simulation in new parallel geo 87 handling fast simulation in new parallel geometry scheme. This requires
150 the G4CoupledTransportation to be active. 88 the G4CoupledTransportation to be active.
151 - Introduced G4GFSManager81 class that gathers 89 - Introduced G4GFSManager81 class that gathers the future code to become the
152 default at next major release in the G4Globa 90 default at next major release in the G4GlobalFastSimulationManager class.
153 - G4FastSimulationManager: adapted to new sche 91 - G4FastSimulationManager: adapted to new scheme. Still has old code for
154 backward compatibilty. 92 backward compatibilty.
155 - G4FastSimulationManagerProcess: mostly the s 93 - G4FastSimulationManagerProcess: mostly the same, apart from a small bug fix.
156 - G4FastSimulationMessenger: new command creat 94 - G4FastSimulationMessenger: new command created "/param/showSetup", useful
157 to show the fast simulation setup (region, m 95 to show the fast simulation setup (region, models, processes, etc...)
158 It is only valid for geometry closed state. 96 It is only valid for geometry closed state. Desirable to have interactive
159 command in the run manager for this. 97 command in the run manager for this.
160 98
161 November 25, 2005, M.Verderi - param-V07-01-0 99 November 25, 2005, M.Verderi - param-V07-01-04
162 - put back Makoto's change: StartTracking(G4Tr 100 - put back Makoto's change: StartTracking(G4Track*)
163 101
164 November 25, 2005, M Verderi - param-V07-01-03 102 November 25, 2005, M Verderi - param-V07-01-03
165 - Make ghost functionnality available with G4R 103 - Make ghost functionnality available with G4Region
166 - ** Note ** Change back StartTracking(G4Track 104 - ** Note ** Change back StartTracking(G4Track*) -> StartTracking() in G4FSMP
167 StartTracking(G4Track*) was intro 105 StartTracking(G4Track*) was introduced in param-V07-01-02
168 because (I guess) of procman-V07-01-01 106 because (I guess) of procman-V07-01-01
169 This is to make param-V07-01-03 compatible w 107 This is to make param-V07-01-03 compatible with geant4-07-01-ref-05
170 108
171 November 21, 2005 M.Asai - param-V07-01-02 109 November 21, 2005 M.Asai - param-V07-01-02
172 - Fix warning message. 110 - Fix warning message.
173 111
174 November 02, 2005 G.Cosmo - param-V07-01-01 112 November 02, 2005 G.Cosmo - param-V07-01-01
175 - Corrected setting of envelope volumes and so 113 - Corrected setting of envelope volumes and solid in G4FastTrack.
176 - Migrated old scheme for G4Exception and some 114 - Migrated old scheme for G4Exception and some cosmetics...
177 115
178 October 28, 2005 M.Asai - param-V07-01-00 116 October 28, 2005 M.Asai - param-V07-01-00
179 - Working tag for merging "envelope" to G4Regi 117 - Working tag for merging "envelope" to G4Region.
180 118
181 December 07, 2004 G. Cosmo - param-V06-02-01 119 December 07, 2004 G. Cosmo - param-V06-02-01
182 - Implemented migration to <cmath>. 120 - Implemented migration to <cmath>.
183 121
184 November 26, 2004 M. Verderi - param-V06-02-00 122 November 26, 2004 M. Verderi - param-V06-02-00
185 - Implemented migration to new G4VParticleChan 123 - Implemented migration to new G4VParticleChange interfaces.
186 124
187 December 12, 2003 G. Cosmo - param-V06-00-00 125 December 12, 2003 G. Cosmo - param-V06-00-00
188 - G4FastSimulationVector.icc: use std_pvector: 126 - G4FastSimulationVector.icc: use std_pvector:: scope for calls to
189 base class. Fixes compilation problem on Int 127 base class. Fixes compilation problem on Intel-icc compiler.
190 128
191 November 10, 2003 G. Cosmo - param-V05-02-01 129 November 10, 2003 G. Cosmo - param-V05-02-01
192 - G4FastTrack: use G4Navigator::CreateTouchabl 130 - G4FastTrack: use G4Navigator::CreateTouchableHistoryHandle() instead of
193 CreateTouchableHistory() in method FRecordsA 131 CreateTouchableHistory() in method FRecordsAffineTransformation().
194 132
195 October 4, 2003 G. Cosmo - param-V05-02-00 133 October 4, 2003 G. Cosmo - param-V05-02-00
196 - Modified GNUmakefile: 134 - Modified GNUmakefile:
197 o added dependency to new module "geometry/n 135 o added dependency to new module "geometry/navigation".
198 - Coworks with "geometry-V05-02-00" and "digit 136 - Coworks with "geometry-V05-02-00" and "digits_hits-V05-02-00".
199 137
200 May 21, 2003 G. Cosmo - param-V05-01-00 138 May 21, 2003 G. Cosmo - param-V05-01-00
201 o Fixed pedantic warnings on Linux-g++ 139 o Fixed pedantic warnings on Linux-g++.
202 o Call base class in copy-constructor 140 o Call base class in copy-constructor of G4FastStep.
203 141
204 Nov 20, 2002 G. Cosmo - param-V04-01-02 142 Nov 20, 2002 G. Cosmo - param-V04-01-02
205 o Patched access to public static data in G4 143 o Patched access to public static data in G4FastStep.cc
206 and G4GlobalFastSimulationManager.cc to al 144 and G4GlobalFastSimulationManager.cc to allow porting on
207 Windows DLLs. 145 Windows DLLs.
208 146
209 Nov 15, 2002 S. Sadilov - param-V04-01-01 147 Nov 15, 2002 S. Sadilov - param-V04-01-01
210 o Fixed compilation problems on Windows in 148 o Fixed compilation problems on Windows in
211 G4FastSimulationManager.cc and G4GlobalFas 149 G4FastSimulationManager.cc and G4GlobalFastSimulationManager.cc
212 150
213 Nov 02, 2002 M. Verderi - param-V04-01-00 151 Nov 02, 2002 M. Verderi - param-V04-01-00
214 o Add method to retrieve G4VFastSimulationMo 152 o Add method to retrieve G4VFastSimulationModel by name.
215 The user's method is in G4GlobalFastSimula 153 The user's method is in G4GlobalFastSimulationManager:
216 154
217 GetFastSimulationModel(); 155 GetFastSimulationModel();
218 156
219 it is accompagnied by same methods name in 157 it is accompagnied by same methods name in
220 G4FastSimulationManager class. 158 G4FastSimulationManager class.
221 159
222 o Add "test" directory, used to test above f 160 o Add "test" directory, used to test above feature.
223 161
224 Oct 26, 2001 M. Verderi - param-V03-02-00 162 Oct 26, 2001 M. Verderi - param-V03-02-00
225 Fixes to clear warnings produced with gcc-2. 163 Fixes to clear warnings produced with gcc-2.95.2:
226 - loop index, where comparison with method " 164 - loop index, where comparison with method "size()" of
227 G4std::vector<T>, changed: int -> size_t << 165 G4std::vector<T>, changed: int -> size_t
228 - change "if ( a=b ) {..}" by "if ( (a=b) ) 166 - change "if ( a=b ) {..}" by "if ( (a=b) ) {...}"
229 this makes the compiler sure you want to mak 167 this makes the compiler sure you want to make an
230 assignement in the "if" condition 168 assignement in the "if" condition
231 - re-order initialisations of a few variable 169 - re-order initialisations of a few variables in constructors
232 to match the declaration order. 170 to match the declaration order.
233 Some warnings still exist, but regard the G4 171 Some warnings still exist, but regard the G4Propagator of geometry.
234 172
235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 173 Apr 3, 2001 J. Apostolakis - param-V03-00-00
236 - Modified G4FastSimulationManagerProcess call 174 - Modified G4FastSimulationManagerProcess call to PropagatorInField ComputeStep
237 to use new interface with G4FieldTrack (in 175 to use new interface with G4FieldTrack (in place of now obsolete interface.)
238 176
239 Nov 14, 2000 G. Cosmo - param-V02-00-01 177 Nov 14, 2000 G. Cosmo - param-V02-00-01
240 - Moved specific parameterisation models to th 178 - Moved specific parameterisation models to the new top category
241 "parameterisations". Moved files: 179 "parameterisations". Moved files:
242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm 180 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRmodel[.hh.cc],
243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster 181 G4IrregularXrayTRmodel[.hh.cc], G4PAIclusterModel[.hh.cc],
244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr 182 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXrayTRmodel[.hh.cc],
245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode 183 G4RegularXrayTRmodel[.hh.cc], G4VClusterModel[.hh.cc],
246 G4VXrayTRmodel[.hh.cc]. 184 G4VXrayTRmodel[.hh.cc].
247 - Cleaned-up GNUmakefile of non necessary depe 185 - Cleaned-up GNUmakefile of non necessary dependencies.
248 186
249 Aug 03, 2000 G. Cosmo - param-V02-00-00r 187 Aug 03, 2000 G. Cosmo - param-V02-00-00r
250 - Changed RandGauss to G4RandGauss in G4Irregu 188 - Changed RandGauss to G4RandGauss in G4IrregularXrayTRmodel.cc and
251 G4VXrayTRmodel.cc to fix events' reproducibi 189 G4VXrayTRmodel.cc to fix events' reproducibility problem.
252 - G4VXrayTRmodel.cc: fix to class destructor ( 190 - G4VXrayTRmodel.cc: fix to class destructor (V.Grichine)
253 191
254 Jun 15, 2000 G. Cosmo - param-V01-01-04 192 Jun 15, 2000 G. Cosmo - param-V01-01-04
255 - The tag coworks with global-V01-01-04 and ma 193 - The tag coworks with global-V01-01-04 and materials-V01-01-00:
256 o Fixed usage of G4complex type for ISO and 194 o Fixed usage of G4complex type for ISO and non-ISO compilers.
257 Affected files: G4FoamXrayTRmodel.cc, G4Ga 195 Affected files: G4FoamXrayTRmodel.cc, G4GamDistrXrayTRmodel.cc, G4PlateIrrGasXrayTRmodel.cc
258 and G4RegularXrayTRmodel.c 196 and G4RegularXrayTRmodel.cc.
259 In case of G4complex types passed to mathe 197 In case of G4complex types passed to mathematical functions, use G4std:: prefix.
260 o Fixed usage of G4Integrator class, now cha 198 o Fixed usage of G4Integrator class, now changed to templated to allow porting of the
261 code on SUN-CC compiler which does not imp 199 code on SUN-CC compiler which does not implement templated member functions.
262 Affected files: G4VXrayTRmodel[.hh.cc] 200 Affected files: G4VXrayTRmodel[.hh.cc]
263 201
264 Jun 6, 2000 M. Verderi & P. Mora de Freitas 202 Jun 6, 2000 M. Verderi & P. Mora de Freitas
265 - fixed compilation errors with HP-aCC for the 203 - fixed compilation errors with HP-aCC for the files G4RegularXrayTRmodel.cc,
266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod 204 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmodel.cc.
267 205
268 May 30, 2000 M. Verderi & P. Mora de Freitas 206 May 30, 2000 M. Verderi & P. Mora de Freitas
269 207
270 - parameterisation category is now RW free. 208 - parameterisation category is now RW free.
271 209
272 September 16, 1999 M. Verderi & P. Mora de Fre 210 September 16, 1999 M. Verderi & P. Mora de Freitas
273 211
274 - Fixed bug in G4FastStep::CheckIt() method. 212 - Fixed bug in G4FastStep::CheckIt() method.
275 213
276 April 19, 1999 M. Verderi & P. Mora de Freitas 214 April 19, 1999 M. Verderi & P. Mora de Freitas
277 215
278 Changes in G4FastStep to co-work with track-01 216 Changes in G4FastStep to co-work with track-01-00-04:
279 217
280 1) The method void CheckIt(const G4Track&) bec << 218 1) The method void CheckIt(const G4Track&) becomes
281 G4bool CheckIt(const G4Track&); 219 G4bool CheckIt(const G4Track&);
282 2) The FAST_STEP_DEBUG compiling option disapp 220 2) The FAST_STEP_DEBUG compiling option disappears;
283 3) Call to CheckIt controled by the G4VParticl 221 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute.
284 222
285 Miscellaneous: the declaration "G4double mass 223 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh
286 corrected to G4double mass =...". 224 corrected to G4double mass =...".
287 225
288 April 15, 1999 M. Verderi & P. Mora de Freitas 226 April 15, 1999 M. Verderi & P. Mora de Freitas
289 227
290 Tasks to decouple visualization from processes 228 Tasks to decouple visualization from processes/parameterisation:
291 229
292 1) G4GlobalFastSimulationManager now inherites 230 1) G4GlobalFastSimulationManager now inherites from the intercoms/
293 G4VGlobalFastSimulationManager to allow visual << 231 G4VGlobalFastSimulationManager to allow visualisation to get a
294 concrete instance pointer to the G4GlobalFastS 232 concrete instance pointer to the G4GlobalFastSimulationManager,
295 if any. 233 if any.
296 234
297 2) G4FlavoredParallelWorld now inherites from 235 2) G4FlavoredParallelWorld now inherites from the intercoms/
298 G4VFlavoredParallelWorld, a pure virtual abstr 236 G4VFlavoredParallelWorld, a pure virtual abstract class to interface
299 parameterisation with visualization. 237 parameterisation with visualization.
300 238
301 Co-works with intercoms-01-00-01 tag 239 Co-works with intercoms-01-00-01 tag
302 240
303 Modified files: 241 Modified files:
304 --------------- 242 ---------------
305 G4FlavoredParallelWorld.hh 243 G4FlavoredParallelWorld.hh
306 G4GlobalFastSimulationManager.hh 244 G4GlobalFastSimulationManager.hh
307 G4GlobalFastSimulationManager.cc 245 G4GlobalFastSimulationManager.cc
308 246
309 Done, tested, system-tested on HP-aCC with exe 247 Done, tested, system-tested on HP-aCC with exemple N05.
310 248
311 April 14, 1999 M. Verderi & P. Mora de Freitas 249 April 14, 1999 M. Verderi & P. Mora de Freitas
312 250
313 Several consolidation tasks (thanks to G. Cosm 251 Several consolidation tasks (thanks to G. Cosmo):
314 252
315 1) Warning: << 253 1) Warning:
316 ----------- 254 -----------
317 255
318 Pointers usage 256 Pointers usage
319 257
320 - Setting pointers to 0 after delete: 258 - Setting pointers to 0 after delete:
321 259
322 delete pA; 260 delete pA;
323 pA = 0; 261 pA = 0;
324 262
325 - Avoid to use "NULL". 263 - Avoid to use "NULL".
326 264
327 Modified files: 265 Modified files:
328 --------------- 266 ---------------
329 G4FastSimulationManager.hh 267 G4FastSimulationManager.hh
330 G4FastTrack.hh 268 G4FastTrack.hh
331 G4FlavoredParallelWorld.hh 269 G4FlavoredParallelWorld.hh
332 G4FastSimulationManager.cc 270 G4FastSimulationManager.cc
333 G4FastSimulationMessenger.cc 271 G4FastSimulationMessenger.cc
334 G4FastSimulationManagerProcess.cc 272 G4FastSimulationManagerProcess.cc
335 G4FastTrack.cc 273 G4FastTrack.cc
336 G4GlobalFastSimulationManager.cc 274 G4GlobalFastSimulationManager.cc
337 G4VFastSimulationModel.cc 275 G4VFastSimulationModel.cc
338 276
339 Status: << 277 Status:
340 ------- 278 -------
341 Done, tested, system-tested on HP-aCC with exe 279 Done, tested, system-tested on HP-aCC with exemple N05.
342 280
343 2) Warning: 281 2) Warning:
344 ----------- 282 -----------
345 include/G4FastSimulationManager.hh:163 283 include/G4FastSimulationManager.hh:163
346 Public member functions shall always retur 284 Public member functions shall always return const handles to member data
347 Severe violation: Universal Coding Standar 285 Severe violation: Universal Coding Standards item 18
348 286
349 offending code: 287 offending code:
350 --------------- 288 ---------------
351 inline G4VParticleChange* G4FastSimulationMana 289 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange()
352 { 290 {
353 return &fFastStep; 291 return &fFastStep;
354 } 292 }
355 293
356 Diagnostic: 294 Diagnostic:
357 ---------- 295 ----------
358 296
359 Called by the G4FastSimulationManagerProcess << 297 Called by the G4FastSimulationManagerProcess to return it in the
360 PostStepDoIt call. << 298 PostStepDoIt call.
361 299
362 Action: 300 Action:
363 ------- 301 -------
364 The G4FastSimulationManager::GettheParticleCha 302 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any
365 more. The G4VParticleChange* is now returned d 303 more. The G4VParticleChange* is now returned directly when invoking the
366 G4FastSimulationManager::InvokePostStepDoIt() 304 G4FastSimulationManager::InvokePostStepDoIt() and
367 G4FastSimulationManager::InvokeAtRestDoIt() me 305 G4FastSimulationManager::InvokeAtRestDoIt() methodes.
368 306
369 Modified files: 307 Modified files:
370 --------------- 308 ---------------
371 G4FastSimulationManager.hh 309 G4FastSimulationManager.hh
372 G4FastSimulationManager.cc 310 G4FastSimulationManager.cc
373 G4FastSimulationManagerProcess.cc 311 G4FastSimulationManagerProcess.cc
374 312
375 Status: << 313 Status:
376 ------- 314 -------
377 Done, tested, system-tested on HP-aCC with exe 315 Done, tested, system-tested on HP-aCC with exemple N05.
378 316
379 3) Warning: 317 3) Warning:
380 ----------- 318 -----------
381 include/G4FastSimulationManagerProcess.hh:52 319 include/G4FastSimulationManagerProcess.hh:52
382 If a class has virtual functions it shall 320 If a class has virtual functions it shall have a virtual destructor
383 Severe violation: Universal Coding Standar 321 Severe violation: Universal Coding Standards item 17
384 class G4FastSimulationManagerProcess has v 322 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor.
385 323
386 offending code: 324 offending code:
387 --------------- 325 ---------------
388 ~G4FastSimulationManagerProcess(); 326 ~G4FastSimulationManagerProcess();
389 327
390 Diagnostic: 328 Diagnostic:
391 ---------- 329 ----------
392 Nobody should inherites from G4FastSimulatio << 330 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual
393 is added. 331 is added.
394 332
395 Action: 333 Action:
396 ------- 334 -------
397 virtual ~G4FastSimulationManagerProcess(); 335 virtual ~G4FastSimulationManagerProcess();
398 336
399 Modified files: 337 Modified files:
400 --------------- 338 ---------------
401 G4FastSimulationManagerProcess.hh 339 G4FastSimulationManagerProcess.hh
402 340
403 Status: << 341 Status:
404 ------- 342 -------
405 Done. 343 Done.
406 344
407 4) Warning: 345 4) Warning:
408 ----------- 346 -----------
409 include/G4FastSimulationMessenger.hh:36 347 include/G4FastSimulationMessenger.hh:36
410 If a class has virtual functions it shall 348 If a class has virtual functions it shall have a virtual destructor
411 Severe violation: Universal Coding Standar 349 Severe violation: Universal Coding Standards item 17
412 class G4FastSimulationMessenger has virtua 350 class G4FastSimulationMessenger has virtual functions without a virtual destructor.
413 351
414 352
415 offending code: 353 offending code:
416 --------------- 354 ---------------
417 ~G4FastSimulationMessenger(); 355 ~G4FastSimulationMessenger();
418 356
419 Diagnostic: 357 Diagnostic:
420 ---------- 358 ----------
421 Nobody should inherites from G4FastSimulatio << 359 Nobody should inherites from G4FastSimulationMessenger BUT for virtual
422 is added. 360 is added.
423 361
424 Action: 362 Action:
425 ------- 363 -------
426 virtual ~G4FastSimulationMessenger(); 364 virtual ~G4FastSimulationMessenger();
427 365
428 Modified files: 366 Modified files:
429 --------------- 367 ---------------
430 G4FastSimulationMessenger.hh 368 G4FastSimulationMessenger.hh
431 369
432 Status: << 370 Status:
433 ------- 371 -------
434 Done. 372 Done.
435 373
436 5) Warning: 374 5) Warning:
437 ----------- 375 -----------
438 include/G4FastStep.hh:224 376 include/G4FastStep.hh:224
439 Operator= should call base class operator= 377 Operator= should call base class operator=
440 Possible severe violation: Effective C++ i 378 Possible severe violation: Effective C++ item 16
441 operator= in class G4FastStep, should call 379 operator= in class G4FastStep, should call operator= in base class G4VParticleChange
442 380
443 offending code: 381 offending code:
444 --------------- 382 ---------------
445 G4FastStep & G4FastStep::operator=(const G4Fas 383 G4FastStep & G4FastStep::operator=(const G4FastStep &right)
446 { 384 {
447 if (this != &right) 385 if (this != &right)
448 { 386 {
449 theListOfSecondaries = right.th 387 theListOfSecondaries = right.theListOfSecondaries;
450 theSizeOftheListOfSecondaries = right.th 388 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries;
451 theNumberOfSecondaries = right.th 389 theNumberOfSecondaries = right.theNumberOfSecondaries;
452 theStatusChange = right.th 390 theStatusChange = right.theStatusChange;
453 theMomentumChange = right.th 391 theMomentumChange = right.theMomentumChange;
454 thePolarizationChange = right.th 392 thePolarizationChange = right.thePolarizationChange;
455 thePositionChange = right.th 393 thePositionChange = right.thePositionChange;
456 theTimeChange = right.th 394 theTimeChange = right.theTimeChange;
457 theEnergyChange = right.th 395 theEnergyChange = right.theEnergyChange;
458 theTrueStepLength = right.th 396 theTrueStepLength = right.theTrueStepLength;
459 theLocalEnergyDeposit = right.th 397 theLocalEnergyDeposit = right.theLocalEnergyDeposit;
460 theSteppingControlFlag = right.th 398 theSteppingControlFlag = right.theSteppingControlFlag;
461 theWeightChange = right.th 399 theWeightChange = right.theWeightChange;
462 } 400 }
463 return *this; 401 return *this;
464 } 402 }
465 403
466 Diagnostic: 404 Diagnostic:
467 ---------- 405 ----------
468 Bug detected. 406 Bug detected.
469 407
470 Action: 408 Action:
471 ------- 409 -------
472 Insert the call 410 Insert the call
473 G4VParticleChange::operator=(right); 411 G4VParticleChange::operator=(right);
474 412
475 Status: 413 Status:
476 ------- 414 -------
477 Done, tested, system-tested on HP-aCC with e 415 Done, tested, system-tested on HP-aCC with exemple N05.
478 416
479 Modified files: 417 Modified files:
480 --------------- 418 ---------------
481 G4FastStep.cc 419 G4FastStep.cc
482 420
483 6) Warning: 421 6) Warning:
484 ----------- 422 -----------
485 include/G4FastStep.hh:59 423 include/G4FastStep.hh:59
486 Avoid data members in the public interface 424 Avoid data members in the public interface
487 Violation: Effective C++ item 20 425 Violation: Effective C++ item 20
488 Public data members for class G4FastStep: 426 Public data members for class G4FastStep:
489 debugFlag 427 debugFlag
490 428
491 429
492 offending code: 430 offending code:
493 --------------- 431 ---------------
494 public: 432 public:
495 ... 433 ...
496 G4bool debugFlag; 434 G4bool debugFlag;
497 435
498 Diagnostic: 436 Diagnostic:
499 ---------- 437 ----------
500 Historical usage. 438 Historical usage.
501 439
502 Action: 440 Action:
503 ------- 441 -------
504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 442 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file.
505 443
506 Modified files: 444 Modified files:
507 --------------- 445 ---------------
508 G4FastStep.hh, G4FastStep.cc 446 G4FastStep.hh, G4FastStep.cc
509 447
510 Status: 448 Status:
511 ------- 449 -------
512 Done, tested, system-tested on HP-aCC with e 450 Done, tested, system-tested on HP-aCC with exemple N05.
513 451
514 7) Warning: 452 7) Warning:
515 ----------- 453 -----------
516 include/G4FastStep.hh:59 454 include/G4FastStep.hh:59
517 If a class has virtual functions it shall 455 If a class has virtual functions it shall have a virtual destructor
518 Severe violation: Universal Coding Standar 456 Severe violation: Universal Coding Standards item 17
519 class G4FastStep has virtual functions wit 457 class G4FastStep has virtual functions without a virtual destructor.
520 458
521 459
522 offending code: 460 offending code:
523 --------------- 461 ---------------
524 ~G4FastStep(); 462 ~G4FastStep();
525 463
526 Diagnostic: 464 Diagnostic:
527 ---------- 465 ----------
528 Nobody should inherites from G4FastStep BUT 466 Nobody should inherites from G4FastStep BUT virtual added.
529 467
530 Action: 468 Action:
531 ------- 469 -------
532 virtual ~G4FastStep(); 470 virtual ~G4FastStep();
533 471
534 Modified files: 472 Modified files:
535 --------------- 473 ---------------
536 G4FastStep.hh 474 G4FastStep.hh
537 475
538 Status: 476 Status:
539 ------- 477 -------
540 Done, tested, system-tested on HP-aCC with e 478 Done, tested, system-tested on HP-aCC with exemple N05.
541 479
542 480
543 December 7, 1998 M. Verderi 481 December 7, 1998 M. Verderi
544 G4FastSimulationManagerProcess class: 482 G4FastSimulationManagerProcess class:
545 Fixes made for ghost navigation with 483 Fixes made for ghost navigation with
546 mag-field: 484 mag-field:
547 LocateGlobalPointAndUpdateTouchable is 485 LocateGlobalPointAndUpdateTouchable is
548 always used (in not the Locate...Setup 486 always used (in not the Locate...Setup
549 method) 487 method)
550 In PostStepDoIt: correction of position and 488 In PostStepDoIt: correction of position and
551 direction of the track are made when << 489 direction of the track are made when
552 possible in case of mag-field. 490 possible in case of mag-field.
553 This correction comes from the fact that a 491 This correction comes from the fact that a
554 small discrepancy appears on those quantitie 492 small discrepancy appears on those quantities
555 because of the numerical integration along 493 because of the numerical integration along
556 the field on the track path: the G4FSMP 494 the field on the track path: the G4FSMP
557 proposes a curve-length, the transportation 495 proposes a curve-length, the transportation
558 moves the track along this curve, however 496 moves the track along this curve, however
559 the end point position and direction are 497 the end point position and direction are
560 slightly different from those expected by 498 slightly different from those expected by
561 the G4FSMP when it proposed the length. 499 the G4FSMP when it proposed the length.
562 500
563 November 20,1998 M. Verderi 501 November 20,1998 M. Verderi
564 G4FastStep class: 502 G4FastStep class:
565 Remove track/G4BiasingTag.hh dependancy (ob 503 Remove track/G4BiasingTag.hh dependancy (obsolete).
566 Adapted to new shceme of Event Biasing mech 504 Adapted to new shceme of Event Biasing mechanism,
567 consistently with track-00-04-01 tag. 505 consistently with track-00-04-01 tag.
568 506
569 November 11,1998 M. Verderi 507 November 11,1998 M. Verderi
570 Merge of param-00-03-02 & param-00-03-02a i 508 Merge of param-00-03-02 & param-00-03-02a into
571 param-00-03-04a (hopefully...) 509 param-00-03-04a (hopefully...)
572 The point is the chnage of signature in the 510 The point is the chnage of signature in the
573 LocateGlobalPointAndSetup(..) of the G4Navi 511 LocateGlobalPointAndSetup(..) of the G4Navigator making use now
574 of the track direction. The G4FastSimulatio 512 of the track direction. The G4FastSimulationManagerProcess is
575 changed accordingly: 513 changed accordingly:
576 fGhostNavigator.LocateGlobalPointAndSetup(t 514 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true);
577 515
578 516
579 November 6, 1998 M. Verderi 517 November 6, 1998 M. Verderi
580 - Extension of the G4FastStep to allow the 518 - Extension of the G4FastStep to allow the biasing technic.
581 Changes are made in: 519 Changes are made in:
582 - G4FastStep.hh/.icc: 520 - G4FastStep.hh/.icc:
583 new member G4BiasingTa 521 new member G4BiasingTag fBiasTag;
584 new method SetPrimaryT 522 new method SetPrimaryTrackFinalBiasingTag
585 ( G4BiasingTag 523 ( G4BiasingTag aTag );
586 - G4FastStep.cc: 524 - G4FastStep.cc:
587 Initialize(); 525 Initialize();
588 operator=; << 526 operator=;
589 UpdateForPostStep(); 527 UpdateForPostStep();
590 UpdateForAtRest(); << 528 UpdateForAtRest();
591 529
592 October 26, 1998 P.Mora de Freitas 530 October 26, 1998 P.Mora de Freitas
593 - G4FastSimulationManagerProcess and G4Fast 531 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal
594 with at rest parameterisations also when 532 with at rest parameterisations also when using parallel geometry.
595 533
596 October 8, 1998 P.Mora de Freitas 534 October 8, 1998 P.Mora de Freitas
597 - The G4VFastSimulationModel::IsApplicable( 535 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual
598 methode. 536 methode.
599 - G4FastSimulationManager optimisation: 537 - G4FastSimulationManager optimisation:
600 - New G4ParticleDefinition* fLastCrossedP 538 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps
601 the last particle type with touched the 539 the last particle type with touched the envelope;
602 - New G4RWTPtrOrderedVector<G4VFastSimula 540 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList
603 data member, keeps the model list of th << 541 data member, keeps the model list of the applicable models for
604 the actual fLastCrossedParticle particl 542 the actual fLastCrossedParticle particle type;
605 - Changes in the PostStepGetFastSimulatio << 543 - Changes in the PostStepGetFastSimulationManagerTrigger() and
606 AtRestGetFastSimulationManagerTrigger() << 544 AtRestGetFastSimulationManagerTrigger()methodes to update the
607 fApplicableModelList when needed (fLast 545 fApplicableModelList when needed (fLastCrossedParticle !=
608 the actual tracked particle); 546 the actual tracked particle);
609 - Changes in the << 547 - Changes in the
610 G4FastSimulationManager() (Constructor) 548 G4FastSimulationManager() (Constructor)
611 ActivateFastSimulationModel(), 549 ActivateFastSimulationModel(),
612 InActivateFastSimulationModel(), 550 InActivateFastSimulationModel(),
613 AtRestGetFastSimulationManagerTrigger(), 551 AtRestGetFastSimulationManagerTrigger(),
614 AddFastSimulationModel(), 552 AddFastSimulationModel(),
615 RemoveFastSimulationModel() 553 RemoveFastSimulationModel()
616 methodes to set the fLastCrossedParticle to 554 methodes to set the fLastCrossedParticle to NULL, forcing the
617 fApplicableModelList to be rebuilt. 555 fApplicableModelList to be rebuilt.
618 556
619 September 22, 1998 P.Mora de Freitas 557 September 22, 1998 P.Mora de Freitas
620 Fixed bug in parallel navigation. << 558 Fixed bug in parallel navigation.
621 File touched: G4FastSimulationManagerProces 559 File touched: G4FastSimulationManagerProcess.cc
622 Tested on HP-aCC. 560 Tested on HP-aCC.
623 561
624 September 17, 1998 P.Mora de Freitas 562 September 17, 1998 P.Mora de Freitas
625 G4FastSimulationManager::RemoveFastSimulati 563 G4FastSimulationManager::RemoveFastSimulationModel() updated to look
626 for also in the fInactivatedModels list. 564 for also in the fInactivatedModels list.
627 565
628 Tested on HP-aCC. 566 Tested on HP-aCC.
629 567
630 September 16, 1998 P.Mora de Freitas 568 September 16, 1998 P.Mora de Freitas
631 New /param/ control commands: 569 New /param/ control commands:
632 570
633 /param/ActivateModel <ModelName> 571 /param/ActivateModel <ModelName>
634 /param/InActivateModel <ModelName> 572 /param/InActivateModel <ModelName>
635 573
636 Activate or inactivate a given parameterisat 574 Activate or inactivate a given parameterisation model.
637 575
638 Tested on HP-aCC. 576 Tested on HP-aCC.
639 577
640 August 21, 1998 P.Mora de Freitas 578 August 21, 1998 P.Mora de Freitas
641 G4FastSimulationManagerProcess's G4ProcessTy 579 G4FastSimulationManagerProcess's G4ProcessType set to
642 fParameterisation, accordingly with procman-00 580 fParameterisation, accordingly with procman-00-02-03.
643 581
644 Tested on HP-aCC. 582 Tested on HP-aCC.
645 583
646 August 12, 1998 P.Mora de Freitas 584 August 12, 1998 P.Mora de Freitas
647 Improved the "close parameterisation control << 585 Improved the "close parameterisation control" to
648 586
649 1) avoid the close looping when unnecessary 587 1) avoid the close looping when unnecessary (mostly cases);
650 2) force re-close when necessary (insert/rem 588 2) force re-close when necessary (insert/remove ghosts).
651 589
652 Changes: 590 Changes:
653 591
654 1) the G4GlobalFastSimulationManager::fClose << 592 1) the G4GlobalFastSimulationManager::fClosed is now initialised
655 to true by the G4GlobalFastSimulationMana 593 to true by the G4GlobalFastSimulationManager constructor;
656 594
657 2) new method << 595 2) new method
658 596
659 void << 597 void
660 G4GlobalFastSimulationManager::FastSimula 598 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed();
661 599
662 called by the AddGhostPlacement and Remov << 600 called by the AddGhostPlacement and RemoveGhostPlacement
663 G4FastSimulationManager methods to set fa 601 G4FastSimulationManager methods to set false the fClosed flag;
664 602
665 3) changes in the G4GlobalFastSimulationMana 603 3) changes in the G4GlobalFastSimulationManager::Notify method
666 to deal with these changes. 604 to deal with these changes.
667 605
668 Tested on HP-aCC. 606 Tested on HP-aCC.
669 607
670 August 11, 1998 P.Mora de Freitas 608 August 11, 1998 P.Mora de Freitas
671 Fix to the G4FastStep::KillPrimaryTrack() me 609 Fix to the G4FastStep::KillPrimaryTrack() method to drop the
672 nonsense line 610 nonsense line
673 611
674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 612 SetMomentumChange(0.,0.,0.) ; /* necessary ? */
675 613
676 Tested on HP-aCC. 614 Tested on HP-aCC.
677 (Thanks to Willy Langeveld) 615 (Thanks to Willy Langeveld)
678 616
679 617
680 August 10, 1998 P.Mora de Freitas 618 August 10, 1998 P.Mora de Freitas
681 Fix to the SetPrimaryTrackFinalKineticEnergy 619 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method
682 from the G4FastStep class the SetMomentumChang 620 from the G4FastStep class the SetMomentumChange() call to insure that
683 the new momentum direction is a unit vector (a << 621 the new momentum direction is a unit vector (as asked by the
684 G4DynamicParticle::SetMomentumDirection method 622 G4DynamicParticle::SetMomentumDirection method).
685 623
686 Touched files: G4FastStep.hh (improved comme 624 Touched files: G4FastStep.hh (improved comments)
687 G4FastStep.cc (fixed) 625 G4FastStep.cc (fixed)
688 626
689 Tested on HP-aCC. 627 Tested on HP-aCC.
690 (Thanks to Willy Langeveld) 628 (Thanks to Willy Langeveld)
691 629
692 August 7, 1998 P.Mora de Freitas 630 August 7, 1998 P.Mora de Freitas
693 New /param/ commands directory with the comm 631 New /param/ commands directory with the commands:
694 632
695 /param/listEnvelopes [ParticleName] 633 /param/listEnvelopes [ParticleName]
696 634
697 - List all the envelope names for a given pa 635 - List all the envelope names for a given particle
698 (or for all particles if without parameter 636 (or for all particles if without parameters).
699 637
700 /param/listModels [EnvelopeName] 638 /param/listModels [EnvelopeName]
701 639
702 - List all the Model names for a given envel 640 - List all the Model names for a given envelope
703 (or for all envelopes if without parameter 641 (or for all envelopes if without parameters).
704 642
705 /param/listIsApplicable [ModelName] 643 /param/listIsApplicable [ModelName]
706 644
707 - List all the particle names a given model 645 - List all the particle names a given model is applicable
708 (or for all models if without parameters). 646 (or for all models if without parameters).
709 647
710 648
711 August 7, 1998 P.Mora de Freitas 649 August 7, 1998 P.Mora de Freitas
712 History file Created. 650 History file Created.