| Geant4 Cross Reference |
1 # Category param History << 1 $Id: History,v 1.5.4.1 1999/11/11 14:31:32 gunter Exp $
>> 2 -------------------------------------------------------------------
2 3
3 See `CONTRIBUTING.rst` for details of **requir << 4 =========================================================
4 which **must** added in reverse chronological << 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP
5 It must **not** be used as a substitute for wr << 6 =========================================================
6 << 7
7 ---------------------------------------------- << 8 Category History file
8 << 9 ---------------------
9 ## 2023-11-21 I. Hrivnacova (param-V11-01-04) << 10 This file should be used by G4 developers and category coordinators
10 - In G4GlobalFastSimulationManager: << 11 to briefly summarize all major modifications introduced in the code
11 use G4ThreadLocalSingleton to avoid undelete << 12 and keep track of all category-tags.
12 << 13 It DOES NOT substitute the CVS log-message one should put at every
13 ## 2023-10-18 Ben Morgan (param-V11-01-03) << 14 committal in the CVS repository !
14 - Apply standard and extended clang-tidy fixes << 15
15 - Mark empty/obsolete functions as deprecated << 16 ----------------------------------------------------------
16 << 17 * Reverse chronological order (last date on top), please *
17 ## 2023-10-16 Ben Morgan (param-V11-01-02) << 18 ----------------------------------------------------------
18 - Apply standard clang-format-ing. <<
19 - Normal order accessors and docstrings. <<
20 <<
21 ## 2023-09-04 Gabriele Cosmo (param-V11-01-01) <<
22 - In G4FastTrack, removed references to G4Touc <<
23 which is now deprecated. <<
24 <<
25 ## 2023-03-23 Anna Zaborowska (param-V11-01-00 <<
26 - Added missing virtual destructor to G4VFastS <<
27 <<
28 ## 2022-11-23 Gabriele Cosmo (param-V11-00-04) <<
29 - Fixed compilation warnings for implicit type <<
30 <<
31 ## 2022-10-27 Makoto Asai (param-V11-00-03) <<
32 - G4FastSimHitMaker - making compatible to com <<
33 <<
34 ## 2022-08-24 Vladimir Ivanchenko (param-V11-0 <<
35 - G4FastStep - delete copy constructor and ope <<
36 <<
37 ## 2022-01-19 Witek Pokorski (param-V11-00-01) <<
38 - Adding the 'flush' method to the fast simula <<
39 This method allows to process the input buff <<
40 the end of the G4 event. It is used when par <<
41 The 'flash' is triggered inside the event lo <<
42 The fast simulation model may add secondarie <<
43 by Geant4. <<
44 <<
45 ## 2021-12-10 Ben Morgan (param-V11-00-00) <<
46 - Change to new Markdown History format <<
47 <<
48 --- <<
49 <<
50 # History entries prior to 11.0 <<
51 <<
52 April 16, 2021 Ben Morgan (param-V10-07-00) <<
53 - Migrate build to modular CMake API <<
54 <<
55 October 5, 2020, A. Zaborowska (param-V10-06-0 <<
56 - Introduce general facilities based on GFlash <<
57 to facilitate multiple hit (energy & positio <<
58 from fast simulation models. <<
59 <<
60 September 9, 2020, G. Cosmo (param-V10-06-02) <<
61 - Fixed minor Coverity defect for uninitialise <<
62 <<
63 April 21, 2020, A. Zaborowska (param-V10-06-01 <<
64 - Sanity check for root logical volumes for re <<
65 UI command /param/showSetup works also if no <<
66 <<
67 March 26, 2020, I. Semeniouk (param-V10-06-00) <<
68 - G4FastSimulationHelper : merge ActivateFastS <<
69 - G4FastSimulationManager.hh, G4VFastSimulatio <<
70 redefinition of G4Envelope type <<
71 <<
72 October 30, 2019, A. Zaborowska (param-v10-05- <<
73 - Register G4FastSimulationManagerProcess with <<
74 G4FastSimulationManagerHelper to ensure it i <<
75 invoked for a given step (ExclusivelyForced) <<
76 StronglyForced processes will be considered. <<
77 <<
78 December 19, 2017, G. Cosmo (param-V10-04-00) <<
79 - Fixed self-consistency in G4FastSimulationVe <<
80 Thanks to Raphael Isemann for reporting this <<
81 <<
82 November 03, 2016, M. Verderi (param-V10-02-01 <<
83 - New G4FastSimulationManagerHelper utility fo <<
84 adding G4FastSimulationManagerProcess to a <<
85 process manager. <<
86 <<
87 November 02, 2016, M. Verderi (param-V10-02-00 <<
88 - fix various Coverity defects. <<
89 <<
90 March 27, 2013, M. Verderi (param-V09-06-00) <<
91 - remove unused field 'fOnBoundary' in G4FastS <<
92 as this was causing a warning from clang. <<
93 <<
94 July 10, 2012, G. Cosmo (param-V09-05-00) <<
95 - Explicitly use inclusion of headers for syst <<
96 constants, in plan to remove implicit inclus <<
97 <<
98 September 30, 2011, M. Verderi (param-V09-04-0 <<
99 - Added missing new header file (G4FastSimulat <<
100 sources.cmake. <<
101 <<
102 September 30, 2011, M. Verderi (param-V09-04-0 <<
103 - Migration to new G4Exception scheme. <<
104 - what is V09-04-01 tag ? <<
105 <<
106 February 11, 2011, M. Verderi (param-V09-04-00 <<
107 - Implementation of method <<
108 void ProposePrimaryTrackFinalKineticEnergy ( <<
109 was missing : modified file G4FastStep.icc <<
110 <<
111 March 13, 2008, G. Cosmo (param-V09-01-00) <<
112 - Cleared compilation warnings in G4FastSimula <<
113 G4FastSimulationMessenger on gcc-4.3.0 for a <<
114 parentheses in nested if-else statements. <<
115 <<
116 November 30, 2007, M. Verderi <<
117 - Add Along methods to G4FSMP process <<
118 - tag as param-V09-00-01 <<
119 <<
120 November 30, 2007, M. Verderi <<
121 - minor corrections to G4FastSimulationManager <<
122 * add call fPathFinder->prepareNewrack(...) <<
123 * deactivate ghost navigator in EndOfTracki <<
124 - tag as param-V09-00-00 <<
125 <<
126 May 18, 2007, M. Verderi <<
127 - tag as param-V08-03-00 <<
128 <<
129 May 11, 2007, M. Verderi <<
130 - remove include/G4FastSimulationManagerProces <<
131 include/G4FlavoredParallelWorld.hh <<
132 include/G4GFSManager81.hh <<
133 src/G4FastSimulationManagerProcess81. <<
134 src/G4GFSManager81.cc <<
135 <<
136 <<
137 November 10, 2006, M. Verderi - param-V08-01-0 <<
138 - Limited number of warning messages printed b <<
139 G4GlobalFastSimulationManager. <<
140 - Renamed G4FastSimulationManagerProcess_forCo <<
141 G4FastSimulationManagerProcess81. <<
142 In addition, this class can now handle the c <<
143 i.e., the navigator for tracking, regardless <<
144 G4CoupledTransportation is used. (For other <<
145 of course no choice, and G4CoupledTransporta <<
146 <<
147 November 3, 2006 M. Verderi <<
148 - Introduced G4FastSimulationManagerProcess_fo <<
149 handling fast simulation in new parallel geo <<
150 the G4CoupledTransportation to be active. <<
151 - Introduced G4GFSManager81 class that gathers <<
152 default at next major release in the G4Globa <<
153 - G4FastSimulationManager: adapted to new sche <<
154 backward compatibilty. <<
155 - G4FastSimulationManagerProcess: mostly the s <<
156 - G4FastSimulationMessenger: new command creat <<
157 to show the fast simulation setup (region, m <<
158 It is only valid for geometry closed state. <<
159 command in the run manager for this. <<
160 <<
161 November 25, 2005, M.Verderi - param-V07-01-0 <<
162 - put back Makoto's change: StartTracking(G4Tr <<
163 <<
164 November 25, 2005, M Verderi - param-V07-01-03 <<
165 - Make ghost functionnality available with G4R <<
166 - ** Note ** Change back StartTracking(G4Track <<
167 StartTracking(G4Track*) was intro <<
168 because (I guess) of procman-V07-01-01 <<
169 This is to make param-V07-01-03 compatible w <<
170 <<
171 November 21, 2005 M.Asai - param-V07-01-02 <<
172 - Fix warning message. <<
173 <<
174 November 02, 2005 G.Cosmo - param-V07-01-01 <<
175 - Corrected setting of envelope volumes and so <<
176 - Migrated old scheme for G4Exception and some <<
177 <<
178 October 28, 2005 M.Asai - param-V07-01-00 <<
179 - Working tag for merging "envelope" to G4Regi <<
180 <<
181 December 07, 2004 G. Cosmo - param-V06-02-01 <<
182 - Implemented migration to <cmath>. <<
183 <<
184 November 26, 2004 M. Verderi - param-V06-02-00 <<
185 - Implemented migration to new G4VParticleChan <<
186 <<
187 December 12, 2003 G. Cosmo - param-V06-00-00 <<
188 - G4FastSimulationVector.icc: use std_pvector: <<
189 base class. Fixes compilation problem on Int <<
190 <<
191 November 10, 2003 G. Cosmo - param-V05-02-01 <<
192 - G4FastTrack: use G4Navigator::CreateTouchabl <<
193 CreateTouchableHistory() in method FRecordsA <<
194 <<
195 October 4, 2003 G. Cosmo - param-V05-02-00 <<
196 - Modified GNUmakefile: <<
197 o added dependency to new module "geometry/n <<
198 - Coworks with "geometry-V05-02-00" and "digit <<
199 <<
200 May 21, 2003 G. Cosmo - param-V05-01-00 <<
201 o Fixed pedantic warnings on Linux-g++ <<
202 o Call base class in copy-constructor <<
203 <<
204 Nov 20, 2002 G. Cosmo - param-V04-01-02 <<
205 o Patched access to public static data in G4 <<
206 and G4GlobalFastSimulationManager.cc to al <<
207 Windows DLLs. <<
208 <<
209 Nov 15, 2002 S. Sadilov - param-V04-01-01 <<
210 o Fixed compilation problems on Windows in <<
211 G4FastSimulationManager.cc and G4GlobalFas <<
212 <<
213 Nov 02, 2002 M. Verderi - param-V04-01-00 <<
214 o Add method to retrieve G4VFastSimulationMo <<
215 The user's method is in G4GlobalFastSimula <<
216 <<
217 GetFastSimulationModel(); <<
218 <<
219 it is accompagnied by same methods name in <<
220 G4FastSimulationManager class. <<
221 <<
222 o Add "test" directory, used to test above f <<
223 <<
224 Oct 26, 2001 M. Verderi - param-V03-02-00 <<
225 Fixes to clear warnings produced with gcc-2. <<
226 - loop index, where comparison with method " <<
227 G4std::vector<T>, changed: int -> size_t <<
228 - change "if ( a=b ) {..}" by "if ( (a=b) ) <<
229 this makes the compiler sure you want to mak <<
230 assignement in the "if" condition <<
231 - re-order initialisations of a few variable <<
232 to match the declaration order. <<
233 Some warnings still exist, but regard the G4 <<
234 <<
235 Apr 3, 2001 J. Apostolakis - param-V03-00-00 <<
236 - Modified G4FastSimulationManagerProcess call <<
237 to use new interface with G4FieldTrack (in <<
238 <<
239 Nov 14, 2000 G. Cosmo - param-V02-00-01 <<
240 - Moved specific parameterisation models to th <<
241 "parameterisations". Moved files: <<
242 G4FoamXrayTRmodel[.hh.cc], G4GamDistrXrayTRm <<
243 G4IrregularXrayTRmodel[.hh.cc], G4PAIcluster <<
244 G4PhotoClusterModel[.hh.cc], G4PlateIrrGasXr <<
245 G4RegularXrayTRmodel[.hh.cc], G4VClusterMode <<
246 G4VXrayTRmodel[.hh.cc]. <<
247 - Cleaned-up GNUmakefile of non necessary depe <<
248 <<
249 Aug 03, 2000 G. Cosmo - param-V02-00-00r <<
250 - Changed RandGauss to G4RandGauss in G4Irregu <<
251 G4VXrayTRmodel.cc to fix events' reproducibi <<
252 - G4VXrayTRmodel.cc: fix to class destructor ( <<
253 <<
254 Jun 15, 2000 G. Cosmo - param-V01-01-04 <<
255 - The tag coworks with global-V01-01-04 and ma <<
256 o Fixed usage of G4complex type for ISO and <<
257 Affected files: G4FoamXrayTRmodel.cc, G4Ga <<
258 and G4RegularXrayTRmodel.c <<
259 In case of G4complex types passed to mathe <<
260 o Fixed usage of G4Integrator class, now cha <<
261 code on SUN-CC compiler which does not imp <<
262 Affected files: G4VXrayTRmodel[.hh.cc] <<
263 <<
264 Jun 6, 2000 M. Verderi & P. Mora de Freitas <<
265 - fixed compilation errors with HP-aCC for the <<
266 G4GamDistrXrayTRmodel.cc and G4FoamXrayTRmod <<
267 <<
268 May 30, 2000 M. Verderi & P. Mora de Freitas <<
269 <<
270 - parameterisation category is now RW free. <<
271 19
272 September 16, 1999 M. Verderi & P. Mora de Fre 20 September 16, 1999 M. Verderi & P. Mora de Freitas
273 21
274 - Fixed bug in G4FastStep::CheckIt() method. 22 - Fixed bug in G4FastStep::CheckIt() method.
275 23
276 April 19, 1999 M. Verderi & P. Mora de Freitas 24 April 19, 1999 M. Verderi & P. Mora de Freitas
277 25
278 Changes in G4FastStep to co-work with track-01 26 Changes in G4FastStep to co-work with track-01-00-04:
279 27
280 1) The method void CheckIt(const G4Track&) bec << 28 1) The method void CheckIt(const G4Track&) becomes
281 G4bool CheckIt(const G4Track&); 29 G4bool CheckIt(const G4Track&);
282 2) The FAST_STEP_DEBUG compiling option disapp 30 2) The FAST_STEP_DEBUG compiling option disappears;
283 3) Call to CheckIt controled by the G4VParticl 31 3) Call to CheckIt controled by the G4VParticleChange::debugFlag attribute.
284 32
285 Miscellaneous: the declaration "G4double mass 33 Miscellaneous: the declaration "G4double mass = masss =..." in G4FastStep.hh
286 corrected to G4double mass =...". 34 corrected to G4double mass =...".
287 35
288 April 15, 1999 M. Verderi & P. Mora de Freitas 36 April 15, 1999 M. Verderi & P. Mora de Freitas
289 37
290 Tasks to decouple visualization from processes 38 Tasks to decouple visualization from processes/parameterisation:
291 39
292 1) G4GlobalFastSimulationManager now inherites 40 1) G4GlobalFastSimulationManager now inherites from the intercoms/
293 G4VGlobalFastSimulationManager to allow visual << 41 G4VGlobalFastSimulationManager to allow visualisation to get a
294 concrete instance pointer to the G4GlobalFastS 42 concrete instance pointer to the G4GlobalFastSimulationManager,
295 if any. 43 if any.
296 44
297 2) G4FlavoredParallelWorld now inherites from 45 2) G4FlavoredParallelWorld now inherites from the intercoms/
298 G4VFlavoredParallelWorld, a pure virtual abstr 46 G4VFlavoredParallelWorld, a pure virtual abstract class to interface
299 parameterisation with visualization. 47 parameterisation with visualization.
300 48
301 Co-works with intercoms-01-00-01 tag 49 Co-works with intercoms-01-00-01 tag
302 50
303 Modified files: 51 Modified files:
304 --------------- 52 ---------------
305 G4FlavoredParallelWorld.hh 53 G4FlavoredParallelWorld.hh
306 G4GlobalFastSimulationManager.hh 54 G4GlobalFastSimulationManager.hh
307 G4GlobalFastSimulationManager.cc 55 G4GlobalFastSimulationManager.cc
308 56
309 Done, tested, system-tested on HP-aCC with exe 57 Done, tested, system-tested on HP-aCC with exemple N05.
310 58
311 April 14, 1999 M. Verderi & P. Mora de Freitas 59 April 14, 1999 M. Verderi & P. Mora de Freitas
312 60
313 Several consolidation tasks (thanks to G. Cosm 61 Several consolidation tasks (thanks to G. Cosmo):
314 62
315 1) Warning: << 63 1) Warning:
316 ----------- 64 -----------
317 65
318 Pointers usage 66 Pointers usage
319 67
320 - Setting pointers to 0 after delete: 68 - Setting pointers to 0 after delete:
321 69
322 delete pA; 70 delete pA;
323 pA = 0; 71 pA = 0;
324 72
325 - Avoid to use "NULL". 73 - Avoid to use "NULL".
326 74
327 Modified files: 75 Modified files:
328 --------------- 76 ---------------
329 G4FastSimulationManager.hh 77 G4FastSimulationManager.hh
330 G4FastTrack.hh 78 G4FastTrack.hh
331 G4FlavoredParallelWorld.hh 79 G4FlavoredParallelWorld.hh
332 G4FastSimulationManager.cc 80 G4FastSimulationManager.cc
333 G4FastSimulationMessenger.cc 81 G4FastSimulationMessenger.cc
334 G4FastSimulationManagerProcess.cc 82 G4FastSimulationManagerProcess.cc
335 G4FastTrack.cc 83 G4FastTrack.cc
336 G4GlobalFastSimulationManager.cc 84 G4GlobalFastSimulationManager.cc
337 G4VFastSimulationModel.cc 85 G4VFastSimulationModel.cc
338 86
339 Status: << 87 Status:
340 ------- 88 -------
341 Done, tested, system-tested on HP-aCC with exe 89 Done, tested, system-tested on HP-aCC with exemple N05.
342 90
343 2) Warning: 91 2) Warning:
344 ----------- 92 -----------
345 include/G4FastSimulationManager.hh:163 93 include/G4FastSimulationManager.hh:163
346 Public member functions shall always retur 94 Public member functions shall always return const handles to member data
347 Severe violation: Universal Coding Standar 95 Severe violation: Universal Coding Standards item 18
348 96
349 offending code: 97 offending code:
350 --------------- 98 ---------------
351 inline G4VParticleChange* G4FastSimulationMana 99 inline G4VParticleChange* G4FastSimulationManager::GettheParticleChange()
352 { 100 {
353 return &fFastStep; 101 return &fFastStep;
354 } 102 }
355 103
356 Diagnostic: 104 Diagnostic:
357 ---------- 105 ----------
358 106
359 Called by the G4FastSimulationManagerProcess << 107 Called by the G4FastSimulationManagerProcess to return it in the
360 PostStepDoIt call. << 108 PostStepDoIt call.
361 109
362 Action: 110 Action:
363 ------- 111 -------
364 The G4FastSimulationManager::GettheParticleCha 112 The G4FastSimulationManager::GettheParticleChange() method doesn't exist any
365 more. The G4VParticleChange* is now returned d 113 more. The G4VParticleChange* is now returned directly when invoking the
366 G4FastSimulationManager::InvokePostStepDoIt() 114 G4FastSimulationManager::InvokePostStepDoIt() and
367 G4FastSimulationManager::InvokeAtRestDoIt() me 115 G4FastSimulationManager::InvokeAtRestDoIt() methodes.
368 116
369 Modified files: 117 Modified files:
370 --------------- 118 ---------------
371 G4FastSimulationManager.hh 119 G4FastSimulationManager.hh
372 G4FastSimulationManager.cc 120 G4FastSimulationManager.cc
373 G4FastSimulationManagerProcess.cc 121 G4FastSimulationManagerProcess.cc
374 122
375 Status: << 123 Status:
376 ------- 124 -------
377 Done, tested, system-tested on HP-aCC with exe 125 Done, tested, system-tested on HP-aCC with exemple N05.
378 126
379 3) Warning: 127 3) Warning:
380 ----------- 128 -----------
381 include/G4FastSimulationManagerProcess.hh:52 129 include/G4FastSimulationManagerProcess.hh:52
382 If a class has virtual functions it shall 130 If a class has virtual functions it shall have a virtual destructor
383 Severe violation: Universal Coding Standar 131 Severe violation: Universal Coding Standards item 17
384 class G4FastSimulationManagerProcess has v 132 class G4FastSimulationManagerProcess has virtual functions without a virtual destructor.
385 133
386 offending code: 134 offending code:
387 --------------- 135 ---------------
388 ~G4FastSimulationManagerProcess(); 136 ~G4FastSimulationManagerProcess();
389 137
390 Diagnostic: 138 Diagnostic:
391 ---------- 139 ----------
392 Nobody should inherites from G4FastSimulatio << 140 Nobody should inherites from G4FastSimulationManagerProcess BUT for virtual
393 is added. 141 is added.
394 142
395 Action: 143 Action:
396 ------- 144 -------
397 virtual ~G4FastSimulationManagerProcess(); 145 virtual ~G4FastSimulationManagerProcess();
398 146
399 Modified files: 147 Modified files:
400 --------------- 148 ---------------
401 G4FastSimulationManagerProcess.hh 149 G4FastSimulationManagerProcess.hh
402 150
403 Status: << 151 Status:
404 ------- 152 -------
405 Done. 153 Done.
406 154
407 4) Warning: 155 4) Warning:
408 ----------- 156 -----------
409 include/G4FastSimulationMessenger.hh:36 157 include/G4FastSimulationMessenger.hh:36
410 If a class has virtual functions it shall 158 If a class has virtual functions it shall have a virtual destructor
411 Severe violation: Universal Coding Standar 159 Severe violation: Universal Coding Standards item 17
412 class G4FastSimulationMessenger has virtua 160 class G4FastSimulationMessenger has virtual functions without a virtual destructor.
413 161
414 162
415 offending code: 163 offending code:
416 --------------- 164 ---------------
417 ~G4FastSimulationMessenger(); 165 ~G4FastSimulationMessenger();
418 166
419 Diagnostic: 167 Diagnostic:
420 ---------- 168 ----------
421 Nobody should inherites from G4FastSimulatio << 169 Nobody should inherites from G4FastSimulationMessenger BUT for virtual
422 is added. 170 is added.
423 171
424 Action: 172 Action:
425 ------- 173 -------
426 virtual ~G4FastSimulationMessenger(); 174 virtual ~G4FastSimulationMessenger();
427 175
428 Modified files: 176 Modified files:
429 --------------- 177 ---------------
430 G4FastSimulationMessenger.hh 178 G4FastSimulationMessenger.hh
431 179
432 Status: << 180 Status:
433 ------- 181 -------
434 Done. 182 Done.
435 183
436 5) Warning: 184 5) Warning:
437 ----------- 185 -----------
438 include/G4FastStep.hh:224 186 include/G4FastStep.hh:224
439 Operator= should call base class operator= 187 Operator= should call base class operator=
440 Possible severe violation: Effective C++ i 188 Possible severe violation: Effective C++ item 16
441 operator= in class G4FastStep, should call 189 operator= in class G4FastStep, should call operator= in base class G4VParticleChange
442 190
443 offending code: 191 offending code:
444 --------------- 192 ---------------
445 G4FastStep & G4FastStep::operator=(const G4Fas 193 G4FastStep & G4FastStep::operator=(const G4FastStep &right)
446 { 194 {
447 if (this != &right) 195 if (this != &right)
448 { 196 {
449 theListOfSecondaries = right.th 197 theListOfSecondaries = right.theListOfSecondaries;
450 theSizeOftheListOfSecondaries = right.th 198 theSizeOftheListOfSecondaries = right.theSizeOftheListOfSecondaries;
451 theNumberOfSecondaries = right.th 199 theNumberOfSecondaries = right.theNumberOfSecondaries;
452 theStatusChange = right.th 200 theStatusChange = right.theStatusChange;
453 theMomentumChange = right.th 201 theMomentumChange = right.theMomentumChange;
454 thePolarizationChange = right.th 202 thePolarizationChange = right.thePolarizationChange;
455 thePositionChange = right.th 203 thePositionChange = right.thePositionChange;
456 theTimeChange = right.th 204 theTimeChange = right.theTimeChange;
457 theEnergyChange = right.th 205 theEnergyChange = right.theEnergyChange;
458 theTrueStepLength = right.th 206 theTrueStepLength = right.theTrueStepLength;
459 theLocalEnergyDeposit = right.th 207 theLocalEnergyDeposit = right.theLocalEnergyDeposit;
460 theSteppingControlFlag = right.th 208 theSteppingControlFlag = right.theSteppingControlFlag;
461 theWeightChange = right.th 209 theWeightChange = right.theWeightChange;
462 } 210 }
463 return *this; 211 return *this;
464 } 212 }
465 213
466 Diagnostic: 214 Diagnostic:
467 ---------- 215 ----------
468 Bug detected. 216 Bug detected.
469 217
470 Action: 218 Action:
471 ------- 219 -------
472 Insert the call 220 Insert the call
473 G4VParticleChange::operator=(right); 221 G4VParticleChange::operator=(right);
474 222
475 Status: 223 Status:
476 ------- 224 -------
477 Done, tested, system-tested on HP-aCC with e 225 Done, tested, system-tested on HP-aCC with exemple N05.
478 226
479 Modified files: 227 Modified files:
480 --------------- 228 ---------------
481 G4FastStep.cc 229 G4FastStep.cc
482 230
483 6) Warning: 231 6) Warning:
484 ----------- 232 -----------
485 include/G4FastStep.hh:59 233 include/G4FastStep.hh:59
486 Avoid data members in the public interface 234 Avoid data members in the public interface
487 Violation: Effective C++ item 20 235 Violation: Effective C++ item 20
488 Public data members for class G4FastStep: 236 Public data members for class G4FastStep:
489 debugFlag 237 debugFlag
490 238
491 239
492 offending code: 240 offending code:
493 --------------- 241 ---------------
494 public: 242 public:
495 ... 243 ...
496 G4bool debugFlag; 244 G4bool debugFlag;
497 245
498 Diagnostic: 246 Diagnostic:
499 ---------- 247 ----------
500 Historical usage. 248 Historical usage.
501 249
502 Action: 250 Action:
503 ------- 251 -------
504 Replaced by #ifdef FAST_STEP_DEBUG in the G4 252 Replaced by #ifdef FAST_STEP_DEBUG in the G4FastStep.cc file.
505 253
506 Modified files: 254 Modified files:
507 --------------- 255 ---------------
508 G4FastStep.hh, G4FastStep.cc 256 G4FastStep.hh, G4FastStep.cc
509 257
510 Status: 258 Status:
511 ------- 259 -------
512 Done, tested, system-tested on HP-aCC with e 260 Done, tested, system-tested on HP-aCC with exemple N05.
513 261
514 7) Warning: 262 7) Warning:
515 ----------- 263 -----------
516 include/G4FastStep.hh:59 264 include/G4FastStep.hh:59
517 If a class has virtual functions it shall 265 If a class has virtual functions it shall have a virtual destructor
518 Severe violation: Universal Coding Standar 266 Severe violation: Universal Coding Standards item 17
519 class G4FastStep has virtual functions wit 267 class G4FastStep has virtual functions without a virtual destructor.
520 268
521 269
522 offending code: 270 offending code:
523 --------------- 271 ---------------
524 ~G4FastStep(); 272 ~G4FastStep();
525 273
526 Diagnostic: 274 Diagnostic:
527 ---------- 275 ----------
528 Nobody should inherites from G4FastStep BUT 276 Nobody should inherites from G4FastStep BUT virtual added.
529 277
530 Action: 278 Action:
531 ------- 279 -------
532 virtual ~G4FastStep(); 280 virtual ~G4FastStep();
533 281
534 Modified files: 282 Modified files:
535 --------------- 283 ---------------
536 G4FastStep.hh 284 G4FastStep.hh
537 285
538 Status: 286 Status:
539 ------- 287 -------
540 Done, tested, system-tested on HP-aCC with e 288 Done, tested, system-tested on HP-aCC with exemple N05.
541 289
542 290
543 December 7, 1998 M. Verderi 291 December 7, 1998 M. Verderi
544 G4FastSimulationManagerProcess class: 292 G4FastSimulationManagerProcess class:
545 Fixes made for ghost navigation with 293 Fixes made for ghost navigation with
546 mag-field: 294 mag-field:
547 LocateGlobalPointAndUpdateTouchable is 295 LocateGlobalPointAndUpdateTouchable is
548 always used (in not the Locate...Setup 296 always used (in not the Locate...Setup
549 method) 297 method)
550 In PostStepDoIt: correction of position and 298 In PostStepDoIt: correction of position and
551 direction of the track are made when << 299 direction of the track are made when
552 possible in case of mag-field. 300 possible in case of mag-field.
553 This correction comes from the fact that a 301 This correction comes from the fact that a
554 small discrepancy appears on those quantitie 302 small discrepancy appears on those quantities
555 because of the numerical integration along 303 because of the numerical integration along
556 the field on the track path: the G4FSMP 304 the field on the track path: the G4FSMP
557 proposes a curve-length, the transportation 305 proposes a curve-length, the transportation
558 moves the track along this curve, however 306 moves the track along this curve, however
559 the end point position and direction are 307 the end point position and direction are
560 slightly different from those expected by 308 slightly different from those expected by
561 the G4FSMP when it proposed the length. 309 the G4FSMP when it proposed the length.
562 310
563 November 20,1998 M. Verderi 311 November 20,1998 M. Verderi
564 G4FastStep class: 312 G4FastStep class:
565 Remove track/G4BiasingTag.hh dependancy (ob 313 Remove track/G4BiasingTag.hh dependancy (obsolete).
566 Adapted to new shceme of Event Biasing mech 314 Adapted to new shceme of Event Biasing mechanism,
567 consistently with track-00-04-01 tag. 315 consistently with track-00-04-01 tag.
568 316
569 November 11,1998 M. Verderi 317 November 11,1998 M. Verderi
570 Merge of param-00-03-02 & param-00-03-02a i 318 Merge of param-00-03-02 & param-00-03-02a into
571 param-00-03-04a (hopefully...) 319 param-00-03-04a (hopefully...)
572 The point is the chnage of signature in the 320 The point is the chnage of signature in the
573 LocateGlobalPointAndSetup(..) of the G4Navi 321 LocateGlobalPointAndSetup(..) of the G4Navigator making use now
574 of the track direction. The G4FastSimulatio 322 of the track direction. The G4FastSimulationManagerProcess is
575 changed accordingly: 323 changed accordingly:
576 fGhostNavigator.LocateGlobalPointAndSetup(t 324 fGhostNavigator.LocateGlobalPointAndSetup(track.GetPosition(), &direction, true);
577 325
578 326
579 November 6, 1998 M. Verderi 327 November 6, 1998 M. Verderi
580 - Extension of the G4FastStep to allow the 328 - Extension of the G4FastStep to allow the biasing technic.
581 Changes are made in: 329 Changes are made in:
582 - G4FastStep.hh/.icc: 330 - G4FastStep.hh/.icc:
583 new member G4BiasingTa 331 new member G4BiasingTag fBiasTag;
584 new method SetPrimaryT 332 new method SetPrimaryTrackFinalBiasingTag
585 ( G4BiasingTag 333 ( G4BiasingTag aTag );
586 - G4FastStep.cc: 334 - G4FastStep.cc:
587 Initialize(); 335 Initialize();
588 operator=; << 336 operator=;
589 UpdateForPostStep(); 337 UpdateForPostStep();
590 UpdateForAtRest(); << 338 UpdateForAtRest();
591 339
592 October 26, 1998 P.Mora de Freitas 340 October 26, 1998 P.Mora de Freitas
593 - G4FastSimulationManagerProcess and G4Fast 341 - G4FastSimulationManagerProcess and G4FastSimulationManager adapted to deal
594 with at rest parameterisations also when 342 with at rest parameterisations also when using parallel geometry.
595 343
596 October 8, 1998 P.Mora de Freitas 344 October 8, 1998 P.Mora de Freitas
597 - The G4VFastSimulationModel::IsApplicable( 345 - The G4VFastSimulationModel::IsApplicable() becomes a pure virtual
598 methode. 346 methode.
599 - G4FastSimulationManager optimisation: 347 - G4FastSimulationManager optimisation:
600 - New G4ParticleDefinition* fLastCrossedP 348 - New G4ParticleDefinition* fLastCrossedParticle data member, keeps
601 the last particle type with touched the 349 the last particle type with touched the envelope;
602 - New G4RWTPtrOrderedVector<G4VFastSimula 350 - New G4RWTPtrOrderedVector<G4VFastSimulationModel> fApplicableModelList
603 data member, keeps the model list of th << 351 data member, keeps the model list of the applicable models for
604 the actual fLastCrossedParticle particl 352 the actual fLastCrossedParticle particle type;
605 - Changes in the PostStepGetFastSimulatio << 353 - Changes in the PostStepGetFastSimulationManagerTrigger() and
606 AtRestGetFastSimulationManagerTrigger() << 354 AtRestGetFastSimulationManagerTrigger()methodes to update the
607 fApplicableModelList when needed (fLast 355 fApplicableModelList when needed (fLastCrossedParticle !=
608 the actual tracked particle); 356 the actual tracked particle);
609 - Changes in the << 357 - Changes in the
610 G4FastSimulationManager() (Constructor) 358 G4FastSimulationManager() (Constructor)
611 ActivateFastSimulationModel(), 359 ActivateFastSimulationModel(),
612 InActivateFastSimulationModel(), 360 InActivateFastSimulationModel(),
613 AtRestGetFastSimulationManagerTrigger(), 361 AtRestGetFastSimulationManagerTrigger(),
614 AddFastSimulationModel(), 362 AddFastSimulationModel(),
615 RemoveFastSimulationModel() 363 RemoveFastSimulationModel()
616 methodes to set the fLastCrossedParticle to 364 methodes to set the fLastCrossedParticle to NULL, forcing the
617 fApplicableModelList to be rebuilt. 365 fApplicableModelList to be rebuilt.
618 366
619 September 22, 1998 P.Mora de Freitas 367 September 22, 1998 P.Mora de Freitas
620 Fixed bug in parallel navigation. << 368 Fixed bug in parallel navigation.
621 File touched: G4FastSimulationManagerProces 369 File touched: G4FastSimulationManagerProcess.cc
622 Tested on HP-aCC. 370 Tested on HP-aCC.
623 371
624 September 17, 1998 P.Mora de Freitas 372 September 17, 1998 P.Mora de Freitas
625 G4FastSimulationManager::RemoveFastSimulati 373 G4FastSimulationManager::RemoveFastSimulationModel() updated to look
626 for also in the fInactivatedModels list. 374 for also in the fInactivatedModels list.
627 375
628 Tested on HP-aCC. 376 Tested on HP-aCC.
629 377
630 September 16, 1998 P.Mora de Freitas 378 September 16, 1998 P.Mora de Freitas
631 New /param/ control commands: 379 New /param/ control commands:
632 380
633 /param/ActivateModel <ModelName> 381 /param/ActivateModel <ModelName>
634 /param/InActivateModel <ModelName> 382 /param/InActivateModel <ModelName>
635 383
636 Activate or inactivate a given parameterisat 384 Activate or inactivate a given parameterisation model.
637 385
638 Tested on HP-aCC. 386 Tested on HP-aCC.
639 387
640 August 21, 1998 P.Mora de Freitas 388 August 21, 1998 P.Mora de Freitas
641 G4FastSimulationManagerProcess's G4ProcessTy 389 G4FastSimulationManagerProcess's G4ProcessType set to
642 fParameterisation, accordingly with procman-00 390 fParameterisation, accordingly with procman-00-02-03.
643 391
644 Tested on HP-aCC. 392 Tested on HP-aCC.
645 393
646 August 12, 1998 P.Mora de Freitas 394 August 12, 1998 P.Mora de Freitas
647 Improved the "close parameterisation control << 395 Improved the "close parameterisation control" to
648 396
649 1) avoid the close looping when unnecessary 397 1) avoid the close looping when unnecessary (mostly cases);
650 2) force re-close when necessary (insert/rem 398 2) force re-close when necessary (insert/remove ghosts).
651 399
652 Changes: 400 Changes:
653 401
654 1) the G4GlobalFastSimulationManager::fClose << 402 1) the G4GlobalFastSimulationManager::fClosed is now initialised
655 to true by the G4GlobalFastSimulationMana 403 to true by the G4GlobalFastSimulationManager constructor;
656 404
657 2) new method << 405 2) new method
658 406
659 void << 407 void
660 G4GlobalFastSimulationManager::FastSimula 408 G4GlobalFastSimulationManager::FastSimulationNeedsToBeClosed();
661 409
662 called by the AddGhostPlacement and Remov << 410 called by the AddGhostPlacement and RemoveGhostPlacement
663 G4FastSimulationManager methods to set fa 411 G4FastSimulationManager methods to set false the fClosed flag;
664 412
665 3) changes in the G4GlobalFastSimulationMana 413 3) changes in the G4GlobalFastSimulationManager::Notify method
666 to deal with these changes. 414 to deal with these changes.
667 415
668 Tested on HP-aCC. 416 Tested on HP-aCC.
669 417
670 August 11, 1998 P.Mora de Freitas 418 August 11, 1998 P.Mora de Freitas
671 Fix to the G4FastStep::KillPrimaryTrack() me 419 Fix to the G4FastStep::KillPrimaryTrack() method to drop the
672 nonsense line 420 nonsense line
673 421
674 SetMomentumChange(0.,0.,0.) ; /* necessary ? 422 SetMomentumChange(0.,0.,0.) ; /* necessary ? */
675 423
676 Tested on HP-aCC. 424 Tested on HP-aCC.
677 (Thanks to Willy Langeveld) 425 (Thanks to Willy Langeveld)
678 426
679 427
680 August 10, 1998 P.Mora de Freitas 428 August 10, 1998 P.Mora de Freitas
681 Fix to the SetPrimaryTrackFinalKineticEnergy 429 Fix to the SetPrimaryTrackFinalKineticEnergyAndDirection() method
682 from the G4FastStep class the SetMomentumChang 430 from the G4FastStep class the SetMomentumChange() call to insure that
683 the new momentum direction is a unit vector (a << 431 the new momentum direction is a unit vector (as asked by the
684 G4DynamicParticle::SetMomentumDirection method 432 G4DynamicParticle::SetMomentumDirection method).
685 433
686 Touched files: G4FastStep.hh (improved comme 434 Touched files: G4FastStep.hh (improved comments)
687 G4FastStep.cc (fixed) 435 G4FastStep.cc (fixed)
688 436
689 Tested on HP-aCC. 437 Tested on HP-aCC.
690 (Thanks to Willy Langeveld) 438 (Thanks to Willy Langeveld)
691 439
692 August 7, 1998 P.Mora de Freitas 440 August 7, 1998 P.Mora de Freitas
693 New /param/ commands directory with the comm 441 New /param/ commands directory with the commands:
694 442
695 /param/listEnvelopes [ParticleName] 443 /param/listEnvelopes [ParticleName]
696 444
697 - List all the envelope names for a given pa 445 - List all the envelope names for a given particle
698 (or for all particles if without parameter 446 (or for all particles if without parameters).
699 447
700 /param/listModels [EnvelopeName] 448 /param/listModels [EnvelopeName]
701 449
702 - List all the Model names for a given envel 450 - List all the Model names for a given envelope
703 (or for all envelopes if without parameter 451 (or for all envelopes if without parameters).
704 452
705 /param/listIsApplicable [ModelName] 453 /param/listIsApplicable [ModelName]
706 454
707 - List all the particle names a given model 455 - List all the particle names a given model is applicable
708 (or for all models if without parameters). 456 (or for all models if without parameters).
709 457
710 458
711 August 7, 1998 P.Mora de Freitas 459 August 7, 1998 P.Mora de Freitas
712 History file Created. 460 History file Created.