Geant4 Cross Reference |
1 # Category geom-specific History << 1 $Id: History,v 1.186 2010-11-26 13:36:35 gcosmo Exp $ >> 2 ------------------------------------------------------------------- 2 3 3 See `CONTRIBUTING.rst` for details of **requir << 4 ========================================================= 4 which **must** added in reverse chronological << 5 Geant4 - an Object-Oriented Toolkit for Simulation in HEP 5 It must **not** be used as a substitute for wr << 6 ========================================================= 6 << 7 7 ---------------------------------------------- << 8 Sub-Category History file 8 << 9 ------------------------- 9 ## 2024-10-01 Evgueni Tcherniaev (geom-specifi << 10 This file should be used by G4 developers and category coordinators 10 - G4GenericTrap: Fixed minor defect reported b << 11 to briefly summarize all major modifications introduced in the code 11 << 12 and keep track of all directory-tags. 12 ## 2024-07-18 Alvaro Tolosa-Delgado (geom-spec << 13 It DOES NOT substitute the CVS log-message one should put at every 13 - Remove internal state of G4TwistedTubs and G << 14 committal in the CVS repository ! 14 << 15 15 ## 2024-07-10 Evgueni Tcherniaev (geom-specifi << 16 ---------------------------------------------------------- 16 - G4ExtrudedSolid: Fixed defects reported by C << 17 * Reverse chronological order (last date on top), please * 17 << 18 ---------------------------------------------------------- 18 ## 2024-07-08 Gabriele Cosmo (geom-specific-V1 << 19 - Fixed reported Coverity defect; in G4Voxeliz << 20 plain vector copy in methods BuildReduceVoxe << 21 BuildBoundaries() and CreateMiniVoxels(..). << 22 << 23 ## 2024-05-29 Evgueni Tcherniaev (geom-specifi << 24 - Added new methods GetNumOfConstituents() and << 25 << 26 ## 2024-05-27 Evgueni Tcherniaev (geom-specifi << 27 - Completely revised G4GeneriTrap, it addresse << 28 << 29 ## 2024-05-26 Evgueni Tcherniaev (geom-specifi << 30 - New testG4GenericTrap.cc << 31 << 32 ## 2024-04-02 Gabriele Cosmo (geom-specific-V1 << 33 - Applied trivial clang-tidy fixes to classes, << 34 'default' keywords. << 35 << 36 ## 2024-02-01 Gabriele Cosmo (geom-specific-V1 << 37 - Use std::size_t for array sizes in G4Polyhed << 38 << 39 ## 2023-07-10 Evgueni Tcherniaev (geom-specifi << 40 - Fixed bounding box calculation in G4VTwisted << 41 << 42 ## 2023-06-16 Stephan Hageboeck (geom-specific << 43 - Fix an uninitialised value in G4VCSGfaceted: << 44 << 45 ## 2023-06-12 Gabriele Cosmo (geom-specific-V1 << 46 - Use const iterator in G4Voxelizer::GetPointV << 47 - Fixed use of index in G4Tet::GetPointOnSurfa << 48 << 49 ## 2023-05-10 Gabriele Cosmo (geom-specific-V1 << 50 - Applied clang-tidy fixes (readability, moder << 51 << 52 ## 2023-03-20 Gabriele Cosmo (geom-specific-V1 << 53 - Fixed more potential uninitialised values in << 54 G4SolidExtentList and G4VTwistSurface. << 55 << 56 ## 2023-03-13 Gabriele Cosmo (geom-specific-V1 << 57 - Fixed potential uninitialised value for boun << 58 G4VTwistSurface::GetBoundaryAtPZ(). << 59 << 60 ## 2023-01-02 Evgueni Tcherniaev (geom-specifi << 61 - G4QuadrangularFacet: Fixed warning message << 62 << 63 ## 2022-11-10 Gabriele Cosmo (geom-specific-V1 << 64 - Fixed compilation warnings for implicit type << 65 << 66 ## 2022-10-05 Gabriele Cosmo (geom-specific-V1 << 67 - Fixed compilation warnings in Intel/icx comp << 68 but never used. << 69 << 70 ## 2022-04-03 Evgueni Tcherniaev (geom-specifi << 71 - G4GenericTrap.cc, G4UGenericTrap.cc, G4UExtr << 72 G4TessellatedSolid.cc, G4TessellatedSolid.cc << 73 revision of CreatePolyhedron() << 74 << 75 ## 2022-02-04 Evgueni Tcherniaev (geom-specifi << 76 - G4VTwistedFaceted: used numerical evaluation << 77 integral to calculate lateral face surface a << 78 << 79 ## 2022-02-01 Evgueni Tcherniaev (geom-specifi << 80 - G4ExtrudedSolid, G4UExtrudedSolid: added def << 81 parameters in the constructor with two z-sec << 82 - G4ExtrudedSolid::ZSection, G4UExtrudedSolid: << 83 added default constructor << 84 << 85 ## 2022-01-26 Evgueni Tcherniaev (geom-specifi << 86 - G4GenericTrap::GetCubicVolume(): calculation << 87 using analytical expression; removed private << 88 GetFaceCubicVolume(); << 89 - G4GenericTrap::GetSurfaceArea(): improved ca << 90 of the area of lateral faces; private functi << 91 GetFaceSurfaceArea(), GetTwistedFaceSurfaceA << 92 replaced with private function GetLateralFac << 93 << 94 ## 2022-01-21 Evgueni Tcherniaev (geom-specifi << 95 - G4Ellipsoid::LateralSurfaceArea(): Enhanced << 96 the lateral surface area << 97 << 98 ## 2022-01-11 Evgueni Tcherniaev (geom-specifi << 99 - G4VTwistedFaceted: fCubicVolume, fSurfaceAre << 100 GetCubicVolume(), GetSurfaceArea() moved to << 101 - G4VTwistedFaceted, G4TwistedBox, G4TwistedTr << 102 calculation of volume and surface area << 103 << 104 ## 2022-01-06 Evgueni Tcherniaev (geom-specifi << 105 - G4TwistedTubs: Implemented GetSurfaceArea() << 106 analytical expressions; added private functi << 107 GetLateralArea() and GetPhiCutArea() << 108 << 109 ## 2021-12-19 Evgueni Tcherniaev (geom-specifi << 110 - G4Hype: Used analytical expression in GetCub << 111 and GetSurfaceArea() << 112 << 113 ## 2021-12-10 Ben Morgan (geom-specific-V11-00 << 114 - Change to new Markdown History format << 115 << 116 --- << 117 << 118 # History entries prior to 11.0 << 119 << 120 03-December-2021 E.Tcherniaev (geom-speci << 121 - G4TwistedTubs: Accurate calculation of the b << 122 BoundingLimits() and GetExtent(), fixing mea << 123 penalty. Addressing problem report #2450. << 124 - G4TwistedTubs, G4VTwistedFaceted: Fixed GetC << 125 << 126 15-October-2021 E.Tcherniaev (geom-speci << 127 - G4Tet, G4UTet: Added SetBoundingLimits() << 128 << 129 06-October-2021 E.Tcherniaev (geom-speci << 130 - G4Tet: some changes in calculation of boundi << 131 - G4UTet: added CheckDegeneracy() and SetVerti << 132 << 133 27-September-2021 E.Tcherniaev (geom-speci << 134 - Added degeneracyFlag to the list of paramete << 135 it addresses first part of the problem repor << 136 << 137 24-September-2021 E.Tcherniaev (geom-speci << 138 - Implemented G4TesselatedSolid::GetFacetIndex << 139 << 140 10-September-2021 E.Tcherniaev (geom-speci << 141 - Implemented G4TesselatedSolid::CheckStructur << 142 - Optimisation in G4TessellatedSolid::SetExtre << 143 shuffle of vertices and checking of six extr << 144 << 145 21-July-2021 E.Tcherniaev (geom-speci << 146 - More accurate calculation of distance from p << 147 in G4TriangularFacet, it addresses problem r << 148 << 149 25-June-2021 G.Cosmo (geom-speci << 150 - Added missing accessor in G4UTet. << 151 << 152 12-May-2021 E.Tcherniaev (geom-speci << 153 - Reimplemented CreatePolyhedron() in << 154 G4Polyhedra, G4Polycone, G4GenericPolycone, << 155 G4UPolyhedra, G4UPolycone, G4UGenericPolycon << 156 << 157 30-April-2021 G.Cosmo (geom-speci << 158 - Fixed use of conversion factor in G4UPolyhed << 159 polyhedra constructs. << 160 << 161 19-April-2021 E.Tcherniaev (geom-speci << 162 - G4Polyhedra, G4Polycone: Fix calculation of << 163 of negative phiStart, it addresses also prob << 164 << 165 30-March-2021 B.Morgan (geom-speci << 166 - Migrate sources.cmake to modular build API << 167 << 168 18-March-2021 E.Tcherniaev (geom-speci << 169 - Fix calculation of bounding box position in << 170 it addresses problem report #2301 << 171 << 172 13-January-2021 G.Cosmo (geom-speci << 173 - Reduce cases of bad speculation in G4Polyhed << 174 G4PolyPhiFace::InsideEdges(), based on repor << 175 by G.Amadio. << 176 << 177 30-October-2020 E.Tcherniaev (geom-speci << 178 - G4Polycone: Revised GetPointOnSurface(); << 179 Added protected auxiliary method SetSurfaceE << 180 Removed GetPointOnCone(), GetPointOnTubs(), << 181 - G4GenericPolycone: Revised GetPointOnSurface << 182 Added protected auxiliary method SetSurfaceE << 183 - G4Polyhedra: Revised GetPointOnSurface(); << 184 Added protected auxiliary method SetSurfaceE << 185 Removed GetPointOnPlane(), GetPointOnTriangl << 186 << 187 01-October-2020 E.Tcherniaev (geom-speci << 188 - G4Polycone, G4GenericPolycone, G4Polyhedra: << 189 implemented GetSurfaceArea(), GetCubicVolume << 190 << 191 May 21, 2020 Guilherme Lima (geom-speci << 192 ---------------------------- << 193 - Fix constructor signatures in G4UExtrudedSol << 194 There were missing const and reference quali << 195 << 196 30-April-2020 G.Cosmo (geom-speci << 197 - Adopt new convention for location of headers << 198 << 199 09-April-2020 E.Tcherniaev (geom-speci << 200 - Added G4GenericTrap::GetTwistedFaceSurfaceAr << 201 - testG4GenericTrap.cc: fixed test for calcula << 202 - testG4ExtrudedSolid.cc: fixed assert stateme << 203 point flys along the surface (DistanceToIn() << 204 << 205 17-January-2020 E.Tcherniaev (geom-speci << 206 - Implemented G4Tet::SetVertices(), it address << 207 at Geant4 Technical Forum. << 208 << 209 14-January-2020 Gabriele Cosmo (geom-speci << 210 - Added protection in G4VFacet header for doub << 211 symbols from Windows Kits code. << 212 << 213 08-January-2020 E.Tcherniaev (geom-speci << 214 - Complete revision of G4Tet, speed up, new te << 215 It also fixes issues spotted by new unit tes << 216 << 217 16-December-2019 E.Tcherniaev (geom-speci << 218 - Complete revision of G4Ellipsoid, it fixes i << 219 implementation, in particular it addresses p << 220 30%-70% speed-up in all main methods. << 221 << 222 11-December-2019 B.Morgan (geom-speci << 223 - Cleanup CMake build, removing obsolete granu << 224 explicit include_directories. << 225 << 226 10-December-2019 G.Cosmo (geom-speci << 227 - Re-established parameterisation mechanism fo << 228 removed by mistake. Addressing problem repor << 229 << 230 26-November-2019 G.Cosmo (geom-speci << 231 - Fixed cases of implicit type conversions fro << 232 << 233 05-November-2019 E.Tcherniaev (geom-speci << 234 - G4TesselatedSolid.cc: fixed minor Coverity d << 235 << 236 07-October-2019 E.Tcherniaev (geom-speci << 237 - G4TesselatedSolid.cc: fixed minor Coverity d << 238 << 239 16-September-2019 G.Cosmo (geom-speci << 240 - Rationalise header inclusions for faceted so << 241 << 242 06-September-2019 G.Cosmo (geom-speci << 243 - Removed unnecessary forward declaration in G << 244 << 245 29-August-2019 G.Cosmo (geom-speci << 246 - Minor c++11 revision and headers cleanup. Co << 247 - Use pre-increment wherever possible. << 248 << 249 19-August-2019 G.Lima (geom-speci << 250 - G4ExtrudedSolid: fixed a bug in DistanceToOu << 251 defined off-center along the z-axis. << 252 << 253 19-August-2019 G.Cosmo (geom-speci << 254 - G4GenericTrap: fixed compilation warnings fo << 255 << 256 13-August-2019 G.Cosmo (geom-speci << 257 - Enabled wrappers for VecGeom implementation << 258 G4EllipticalCone and G4Ellipsoid. << 259 << 260 10-July-2019 E.Tcherniaev (geom-speci << 261 - Fixed G4UExtrudedSolid::CreatePolyhedron(). << 262 Addressing visualization part of the problem << 263 << 264 04-July-2019 G.Cosmo (geom-speci << 265 - Avoid defining kCarTolerance as 'static cons << 266 Addressing problem report #2172. << 267 << 268 11-June-2019 E.Tcherniaev (geom-speci << 269 - Use GetVertices() instead of GetParametersLi << 270 << 271 29-May-2019 G.Cosmo (geom-speci << 272 - Fixed minor Coverity defects. << 273 << 274 20-May-2019 G.Cosmo (geom-speci << 275 - Defined move constructor and move assignment << 276 << 277 14-May-2019 B.Morgan (geom-speci << 278 - Add inclusion of new G4GeomTypes.hh header t << 279 VecGeom replacement. << 280 - See also geommng-10-05-05 << 281 << 282 23-April-2019 G.Cosmo (geom-speci << 283 - Modified G4PolyconeSide and G4PolyhedraSide << 284 MT splitted data in G4PlSideData and G4PhSid << 285 << 286 16-April-2019 G.Cosmo (geom-speci << 287 - Protected check in G4TwistTubsSide::Distance << 288 << 289 4-April-2019 G.Cosmo (geom-speci << 290 - Enabled wrapper for VecGeom implementation o << 291 << 292 15-February-2019 E.Tcherniaev (geom-speci << 293 - Accurate calculation of radical in G4Interse << 294 It addresses the problem report #2111. << 295 << 296 4-February-2019 G.Cosmo (geom-speci << 297 - Fix in G4EllipticalTube::CheckParameters() f << 298 << 299 30-January-2019 G.Cosmo (geom-speci << 300 - Disabled precise computation of extent and u << 301 in CalculateExtent() for G4Tet and G4Tessell << 302 intialisation in setups with relatively comp << 303 - Apply bounding-box calculation for extent al << 304 VecGeom wrappers. << 305 << 306 24-January-2019 E.Tcherniaev (geom-speci << 307 - Completely revised, more robust and performa << 308 new exhaustive test/testEllipticalTube.cc ba << 309 << 310 20-September-2018 G.Cosmo (geom-speci << 311 - Make G4UPolycone wrapper inheriting from vec << 312 following the latest changes in VecGeom. << 313 << 314 13-September-2018 G.Cosmo (geom-speci << 315 - G4UTessellatedSolid, G4UExtrudedSolid: remov << 316 UVector3 and replaced with U3Vector. << 317 << 318 23-August-2018 G.Cosmo (geom-speci << 319 - Enabled VecGeom wrapper for G4Tet. << 320 << 321 10-August-2018 A.Gheata (geom-speci << 322 - Make G4UHype wrapper inheriting from vecgeom << 323 following the latest changes in VecGeom. << 324 << 325 12-July-2018 G.Cosmo (geom-speci << 326 - Removed G4SolidsWorkspacePool class. Adapted << 327 use templated class G4TWorkspacePool. << 328 - Coworks with tags in geometry/volumes, run a << 329 << 330 25-Jun-2018 G.Cosmo (geom-speci << 331 - Use dynamic_cast to attempt fix for spurious << 332 CentOS7/gcc-5.3 on G4UTessellatedSolid wrapp << 333 << 334 17-May-2018 J.Madsen (geom-speci << 335 - Updated "thread-local-static-var" model to << 336 "function-returning-thread-local-static-refe << 337 which fixes Windows DLL + MT << 338 << 339 11-April-2018 G.Cosmo (geom-speci << 340 - Replaced USOLIDS_LIBRARIES with VECGEOM_LIBR << 341 << 342 13-February-2018 E.Tcherniaev (geom-speci << 343 - Corrected conversion of input parameters to << 344 caching for adoption in GDML persistency) in << 345 wrappers. << 346 << 347 9-February-2018 G.Cosmo (geom-speci << 348 - Caching facets and vertices in G4UTessellate << 349 treating indexing in facets. << 350 << 351 31-January-2018 G.Cosmo (geom-speci << 352 - Corrected use of facets indeces in G4UTessel << 353 - Minor cleanup in G4TessellatedSolid::CreateP << 354 changes. << 355 << 356 15-January-2018 G.Cosmo (geom-speci << 357 - Added validity checks in G4UTessellatedSolid << 358 << 359 11-January-2018 G.Cosmo (geom-speci << 360 - Added and enabled VecGeom wrapper for G4Tess << 361 Requires tags cmake-V10-04-01 and config-V10 << 362 << 363 20-December-2017 G.Cosmo (geom-speci << 364 - Enabled VecGeom wrappers for G4ExtrudedSolid << 365 << 366 13-December-2017 E.Tcherniaev (geom-speci << 367 - Removed redundant data initialistion in G4Ex << 368 << 369 11-December-2017 E.Tcherniaev (geom-speci << 370 - Added missing initialisation of two data-mem << 371 assignment operator of G4ExtrudedSolid. Addr << 372 << 373 22-November-2017 G.Cosmo (geom-specif << 374 - Fix in SurfaceNormal() for G4ExtrudedSolid t << 375 counting of the surfaces where the point is << 376 << 377 2-November-2017 G.Cosmo (geom-specif << 378 - Fixed compilation warning introduced with la << 379 << 380 31-October-2017 E.Tcherniaev (geom-specif << 381 - Added specialised implementation for constru << 382 prism in G4ExtrudedSolid. << 383 << 384 20-October-2017 G.Cosmo (geom-specif << 385 - G4TessellatedSolid: print also solid's name << 386 << 387 17-October-2017 G.Cosmo (geom-specif << 388 - Added VecGeom wrapper G4UHype for G4Hype, no << 389 fixes in VecGeom. << 390 << 391 16-October-2017 G.Cosmo (geom-specif << 392 - Temporarly disabled wrappers for G4Tet and G << 393 their corresponding implementation in VecGeo << 394 << 395 28-September-2017 G.Cosmo (geom-specif << 396 - Corrected initialisation of polyhedra by ver << 397 following the changes in VecGeom. << 398 << 399 15-September-2017 G.Cosmo (geom-specif << 400 - G4SolidsWorkspacePool: use DLL export flag f << 401 symbol of the workspace. << 402 << 403 12-September-2017 G.Cosmo (geom-specif << 404 - G4Voxelizer: directly set components for bou << 405 recreating it in BuildBoundingBox(..). << 406 << 407 8-September-2017 E.Tcherniaev (geom-specif << 408 - Added specialised implementation for constru << 409 prism in G4ExtrudedSolid. << 410 << 411 4-September-2017 G.Cosmo (geom-specif << 412 - Temporarly disabled wrapper for extruded-sol << 413 of extruded-solid in VecGeom. << 414 << 415 16-August-2017 J.Allison (geom-specif << 416 - Twisted solids: Fixed bug in drawing polyhed << 417 Addressing problem report #1995. << 418 << 419 27-July-2017 E.Tcherniaev (geom-specif << 420 - G4EllipticalCone: corrected samping of rando << 421 function GetPointOnSurface(). << 422 << 423 24-July-2017 E.Tcherniaev (geom-specif << 424 - G4EllipticalCone: improved GetPointOnSurface << 425 points, using function G4RandomPointOnEllips << 426 << 427 20-July-2017 E.Tcherniaev (geom-specif << 428 - G4EllipticalCone: reviewed implementation of << 429 SurfaceNormal() and GetPointOnSurface(); mad << 430 Addressing problem report #1974. << 431 << 432 15-June-2017 G.Cosmo (geom-specif << 433 - Enabled adapter also in G4UPolycone wrapper. << 434 - Added check on open solid for G4UPolyhedra w << 435 << 436 6-June-2017 G.Cosmo (geom-specif << 437 - Enable adapter for VecGeom shapes in G4U* wr << 438 polyhedra and GenericTrap. From now on, wrap << 439 VecGeom shapes implementation. USolids API i << 440 supported. << 441 << 442 24-May-2017 G.Cosmo (geom-specif << 443 - Renamed ambiguous name Extent() in all solid << 444 BoundingLimits(). Change required in order t << 445 with VecGeom in G4U* wrappers. << 446 Requires tag geommng-V10-03-16. << 447 << 448 11-May-2017 G.Cosmo (geom-specif << 449 - Removed potential race condition in G4VTwist << 450 Addressing problem report #1972. << 451 << 452 7-April-2017 G.Cosmo (geom-specif << 453 - Renamed G4SurfaceVoxelizer to G4Voxelizer an << 454 voxelisation of shapes in 3D space. Adapted << 455 << 456 13-March-2017 G.Cosmo (geom-specif << 457 - G4SolidsWorkspacePool: implemented CleanUpAn << 458 to be called by worker threads. Removed decl << 459 of protected method ReleaseAndDestroyWorkspa << 460 << 461 2-March-2017 E.Tcherniaev (geom-specif << 462 - Fixed possible rounding off error in calcula << 463 for one step) in CalculateExtent() for G4Pol << 464 and related USolids wrappers. << 465 << 466 27-February-2017 E.Tcherniaev (geom-specif << 467 - Revised implementation of GetCubicVolume() a << 468 G4EllipticalTube, to return exact values. << 469 - Revised implementation of GetSurfaceArea() f << 470 return exact value; moved both GetCubicVolum << 471 be not inline. << 472 << 473 13-December-2016 G.Cosmo (geom-specif << 474 - Correction in G4UExtrudedSolid to signature << 475 Fixes issue of undefined symbol if extruded- << 476 list of VecGeom wrappers to activate. << 477 << 478 30-November-2016 E.Tcherniaev (geom-specif << 479 - Call RemoveRedundantVertices() from G4GeomTo << 480 for G4Polycone, G4Polyhedra and related USol << 481 - Fix in G4Parabolid and G4UParaboloid for cor << 482 << 483 18-November-2016 E.Tcherniaev (geom-specif << 484 - Added consistency checks for extent computat << 485 - Fix in cached parameters in G4UPolyhedra. << 486 << 487 10-November-2016 G.Cosmo (geom-specif << 488 - G4UPolyhedra re-introduced new implementatio << 489 G4BoundingEnvelope and extended wrapper to c << 490 Phi parameters, to overcome issues in VecGeo << 491 << 492 10-November-2016 E.Tcherniaev (geom-specif << 493 - Added caching of corners and implementation << 494 in order to assure correct translation. << 495 - Withdrawn changes in G4UPolyhedra introduced << 496 until understood proper conversion from VecG << 497 << 498 7-November-2016 E.Tcherniaev (geom-specifi << 499 - Correction in G4EllipticalCone::DistanceToOu << 500 - Added optional debug flag G4BBOX_EXTENT in G << 501 extent calculation by simply using bounding- << 502 << 503 3-November-2016 G.Cosmo (geom-specifi << 504 - Fix in G4PolyPhiFace for potential unitialis << 505 << 506 31-October-2016 E.Tcherniaev (geom-specifi << 507 - Re-implemented CalculateExtent() to make use << 508 removed no-longer used method CreateRotatedV << 509 G4EllipticalCone, G4Polycone, G4Paraboloid, << 510 G4GenericPolycone, G4TessellatedSolid, G4Twi << 511 wrappers. << 512 - Use G4RandFlat instead of RandFlat. << 513 << 514 21-October-2016 G.Cosmo (geom-specifi << 515 - Moved initialisation of G4GeomSplitter threa << 516 along with generic template type. << 517 Fixing compilation/linking errors on clang-3 << 518 << 519 19-October-2016 E.Tcherniaev (geom-speci << 520 - Reimplemented CalculateExtent() in G4Polycon << 521 and associated USolids wrappers, to make use << 522 << 523 5-October-2016 E.Tcherniaev (geom-speci << 524 - Reimplemented CalculateExtent() in G4Tet, G4 << 525 G4UGenericTrap, G4EllipticalTube and G4VTwis << 526 of G4BoundingEnvelope; removed no-longer use << 527 << 528 20-September-2016 G.Cosmo (geom-speci << 529 - Moved accessors/modifiers for splitter data << 530 G4PolyhedraSide and G4PolyconeSide. << 531 Explicitly initialise G4GeomSplitter data in << 532 translation unit. << 533 Fixing compilation/linking errors on clang-3 << 534 << 535 06-July-2016 E.Tcherniaev (geom-speci << 536 - Fixed monir typo in function Create() for G4 << 537 G4GenericPolycone. << 538 Fixed minor typos in G4GenericTrap::SurfaceN << 539 G4VTwistSurface::CurrentStatus::ResetfDone() << 540 Issues detected by PVS-Studio static code an << 541 Addressing problem report #1876. << 542 << 543 24-May-2016 G.Cosmo (geom-speci << 544 - Correction in G4UExtrudedSolid for definitio << 545 << 546 20-May-2016 G.Cosmo (geom-speci << 547 - Moved accessors and modifiers in USolids wra << 548 Required modification in order to allow corr << 549 types. << 550 << 551 15-Apr-2016 G.Cosmo (geom-speci << 552 - Added flag in USolids wrappers for partial u << 553 << 554 31-Mar-2016 G.Cosmo (geom-speci << 555 - Added overloaded CreatePolyhedron() method t << 556 It is now possible to visualize supported Ve << 557 - Added implementation of CreatePolyhedron() i << 558 << 559 10-Mar-2016 G.Cosmo (geom-speci << 560 - Added overloaded GetEntityType() method to U << 561 << 562 07-Mar-2016 E.Tcherniaev (geom-speci << 563 - Fix in G4IntersectingCone for smaller precis << 564 and LineHitsCone2(). Fixes issue observed in << 565 Addressing problem report #1794. << 566 << 567 03-Mar-2016 G.Cosmo (geom-speci << 568 - Fixed compilation warnings for potential uni << 569 G4ExtrudedSolid::CheckPolygon() function int << 570 << 571 03-Mar-2016 E.Tcherniaev (geom-speci << 572 - Added 'const' qualifier for methods in G4Ext << 573 Added CheckPolygon() to remove collinear and << 574 - G4QuadrangularFacet: added exhaustive tests << 575 problems with a quadrangular facet: collinea << 576 degenerate, concave or self intersecting qua << 577 - G4TriangularFacet: Improved test in construc << 578 small or too narrow) triangles. << 579 << 580 25-Feb-2016 E.Tcherniaev (geom-speci << 581 - Correction in G4ExtrudedSolid::AddGeneralPol << 582 treatment in construction of tessels to avoi << 583 and consequent degenerating triangles. << 584 Address problem report #1777. << 585 - Use pre-computed kCarToleranceHalf constant << 586 protected in G4TessellatedSolid. << 587 - Improved algorithms for computation of area << 588 G4QuadrangularFacet. Added post-const qualif << 589 << 590 16-Feb-2016 G.Cosmo (geom-speci << 591 - Revised implementation for GetSurfaceArea() << 592 G4GenericTrap (E.Tcherniaev). << 593 - Protected debug warning in G4GenericTrap::Su << 594 << 595 02-Feb-2016 E.Tcherniaev (geom-speci << 596 - Fix in G4GenericTrap for compuation of exten << 597 Addressing problem report #1809. << 598 - Use dot() in formula for computation of GetC << 599 G4TessellatedSolid. << 600 << 601 18-Nov-2015 G.Cosmo (geom-speci << 602 - Added specialised implementation for GetCubi << 603 G4TessellatedSolid (J.Allison). << 604 << 605 29-Oct-2015 G.Cosmo (geom-speci << 606 - Added debug printouts within G4SPECSDEBUG in << 607 DistanceToIn/Out(p,v) to identify potential << 608 << 609 26-Oct-2015 G.Cosmo (geom-speci << 610 - Removed redundant condition in G4Polyhedra a << 611 SetOriginalParameters() method. << 612 << 613 23-Oct-2015 G.Cosmo (geom-speci << 614 - G4PolyhedraSide: moved internal struct defin << 615 to overcome deficiencies in object-persisten << 616 << 617 07-Oct-2015 G.Cosmo (geom-speci << 618 - Protected compilation of USolid wrappers wit << 619 << 620 01-Sep-2015 G.Cosmo (geom-speci << 621 - Corrected conditional compilation flag in G4 << 622 << 623 31-Aug-2015 G.Cosmo (geom-speci << 624 - Added USolids/VecGeom wrapper for G4Parabolo << 625 Activated only for external USolids/VecGeom << 626 << 627 13-Aug-2015 G.Cosmo (geom-speci << 628 - Checked for potential never-ending loops. << 629 No issues found, only added annotations. << 630 << 631 05-Aug-2015 G.Cosmo (geom-speci << 632 - Minor code cleanup in G4SurfaceVoxelizer. << 633 << 634 03-Mar-2015 G.Cosmo (geom-speci << 635 - Use accessors x(), y() and z() from UVector3 << 636 its data-members. Co-work with tag "geom-uso << 637 << 638 23-Feb-2015 T.Nikitina (geom-speci << 639 - Fix in SetOriginalParameters() for G4Polycon << 640 of presence of 'rings' structures. Addressin << 641 << 642 26-Jan-2015 G.Cosmo (geom-speci << 643 - Renamed DistanceAwayForInside() to DistanceA << 644 << 645 26-Jan-2015 T.Nikitina (geom-speci << 646 - Added special method for Inside 'DistanceAwa << 647 precision problem of calculation of Distance << 648 << 649 21-Jan-2015 T.Nikitina (geom-speci << 650 - Fixed triangularisation method AddGeneralPOl << 651 G4ExtrudedSolid by avoiding flat triangles. << 652 - Added warning message to G4TriangularFacet c << 653 i.e., case of flat triangle. << 654 - Addressing problem report #1703. << 655 << 656 12-Dec-2014 G.Cosmo (geom-speci << 657 - Use canonical form for operator=() in G4Poly << 658 G4PolyhedraHistorical. << 659 << 660 17-Sep-2014 G.Cosmo (geom-speci << 661 - Added wrappers for UExtrudedSolid and UGener << 662 original G4 types accordingly. Requires tag << 663 << 664 01-Sep-2014 G.Cosmo (geom-speci << 665 - Fixed use of polyhedron pointer, to avoid ra << 666 when parameterised volumes are visualised. << 667 << 668 22-May-2014 G.Cosmo (geom-speci << 669 - Added protection in generic constructor of G << 670 improper number of sides is given as input. << 671 << 672 10-Apr-2014 G.Cosmo (geom-speci << 673 - Get rid of deprecated 'register' storage cla << 674 << 675 31-Mar-2014 G.Cosmo (geom-speci << 676 - Fixed signature of assignment operator to G4 << 677 << 678 31-Mar-2014 G.Cosmo (geom-speci << 679 - Fixed signature of assignment operator to G4 << 680 and G4GenericPolycone. << 681 << 682 05-Mar-2014 G.Cosmo (geom-speci << 683 - Fixed proper handling of polyhedron pointer << 684 leak for visualization of parameterised volu << 685 << 686 12-Feb-2014 G.Cosmo (geom-speci << 687 - Simply reset polyhedron pointer to zero for << 688 in parameterisation. Resolves crash in MT vi << 689 << 690 12-Feb-2014 G.Cosmo (geom-speci << 691 - Added correct cloning mechanism in G4U* wrap << 692 Addressing problem report #1553. << 693 << 694 18-Dec-2013 T.Nikitina (geom-speci << 695 - Fix in G4GenericTrap::InsidePolygone() to ch << 696 extremes of the segment. Addressing problem << 697 << 698 17-Dec-2013 G.Cosmo (geom-speci << 699 - Corrected left-over debug printout in G4Poly << 700 << 701 04-Dec-2013 G.Cosmo (geom-speci << 702 - Corrected left-over debug printout in G4Poly << 703 << 704 22-Nov-2013 G.Cosmo (geom-speci << 705 - Correction to USolids wrappers for proper se << 706 << 707 19-Nov-2013 J.Apostolakis (geom-speci << 708 - Fix for issue identified by Coverity: fixed << 709 G4SolidsWorkspacePool singleton. << 710 << 711 20-Nov-2013 T.Mikitina (geom-speci << 712 - Fixed Coverity defects to USolids wrappers. << 713 << 714 14-Nov-2013 G.Cosmo (geom-speci << 715 - Enabled use of Reset() in G4UPolycone. << 716 - Corrections to G4UPolycone and G4UPolyhedra << 717 of parameterisations on these solids. << 718 << 719 13-Nov-2013 G.Cosmo (geom-speci << 720 - Correction to G4UTet and G4UGenericPolycone << 721 symbols re-definitions from G4Tet and G4Gene << 722 << 723 12-Nov-2013 G.Cosmo (geom-speci << 724 - Added dummy method G4UPolycone::Reset(). << 725 NOTE: Required related implementation (curre << 726 << 727 12-Nov-2013 G.Cosmo (geom-speci << 728 - Correction to USolids switch mechanism for G << 729 << 730 08-Nov-2013 J.Apostolakis (geom-speci << 731 - G4SolidsWorkspace: cleanup of verbosity. << 732 Reduced verbosity by making it optional. << 733 Added Set/Get Verbose methods to toggle and << 734 Added parameter to constructor for verbosity << 735 << 736 07-Nov-2013 G.Cosmo (geom-specific-V09-06-26) << 737 - Moved wrappers from usolids module. << 738 Fixed internal dispatcher method for paramet << 739 - Added switching mechanism for G4GenericPolyc << 740 and G4Tet. << 741 << 742 06-Nov-2013 G.Cosmo (geom-specific-V09-06-25) << 743 - Added switch mechanism for USolids (G4Generi << 744 G4Polyhedra, G4Tet). Renamed related G4 type << 745 - Moved wrappers from USolids module. << 746 << 747 01-Nov-2013 G.Cosmo (geom-specific-V09-06-24) << 748 - Corrected CMake script. << 749 << 750 31-Oct-2013 G.Cosmo (geom-specific-V09-06-23) << 751 - Fix for in G4Polyhedra::SetOriginalParameter << 752 - Moved G4PolyconeHistorical and G4PolyhedraHi << 753 translation units. << 754 << 755 29-Oct-2013 T.Nikitina (geom-specific-V09-06- << 756 - Split G4Polycone for polycones with decreasi << 757 Introduced new class G4GenericPolycone. << 758 - Fixed conversion of generic construct for G4 << 759 << 760 17-Oct-2013 J.Apostolakis/A.Dotti (geom-speci << 761 - Cleanup of code for workspace. << 762 << 763 16-Oct-2013 J.Apostolakis/A.Dotti (geom-speci << 764 - Created G4SolidsWorkspacePool class, to mana << 765 Fixed Singleton G4SolidsWorkspacePool for th << 766 << 767 04-Oct-2013 J.Apostolakis (geom-specific-V09- << 768 - Retagged. << 769 NOTE: requires tag "geommng-V09-06-12" and c << 770 << 771 04-Oct-2013 J.Apostolakis (geom-specific-V09- << 772 - Created G4SolidsWorkspace class, to create, << 773 per-thread state of PolyCone Sides and PolyH << 774 << 775 27-Aug-2013 G.Cosmo (geom-specific-V09-06-17) << 776 - Enabled G4Ellipsoid for parameterisation. << 777 << 778 14-Aug-2013 G.Cosmo (geom-specific-V09-06-16) << 779 - Move function-scoped 'static const' values f << 780 data members of classes, to overcome false-p << 781 reported by Valgrind in MT mode. << 782 - Fix in G4TessellatedSolid::DistanceToIn(p,v) << 783 are located near surface (T.Nikitina). << 784 << 785 16-Jul-2013 M.Gayer (geom-specific-V09-06-15) << 786 - Fix in G4SurfaceVoxelizer affecting tessella << 787 for wrong computation of DistanceToIn(p,v) f << 788 optimisation is active. << 789 << 790 11-Jul-2013 G.Cosmo (geom-specific-V09-06-14) << 791 - Fixed compilation warning in G4Polycone on M << 792 << 793 09-Jul-2013 T.Nikitina (geom-specific-V09-06- << 794 - Extended method SetOriginalParameters() in G << 795 all possible cases of conversion of generic << 796 (Rmin,Rmaz,Z) parameters. << 797 Addressing problem report #1462. << 798 << 799 03-Jun-2013 G.Cosmo (geom-specific-V09-06-12) << 800 - Fixed minor Coverity defect in G4PolyhedraSi << 801 << 802 22-Apr-2013 J.Apostolakis (geom-specific-V09- << 803 - Revised G4ExtrudedSolid::IsSameLine to use t << 804 distance to a line when deciding - not the y << 805 ( Issue responsible for a problem in Subtrac << 806 Tatiana & Ivana contributed to debugging. << 807 - Changed GNUmakefile in test directory to wor << 808 builds. << 809 << 810 16-Apr-2013 T.Nikitina (geom-specific-V09-06- << 811 - Fix in calculation of normal in G4Tet::Dista << 812 SurfaceNormal(p). << 813 - Fix in G4Polycone::GetPointOnCone() for case << 814 Fixes cases of false report for overlaps det << 815 Added check with exception in constructor fo << 816 for the same Z. << 817 << 818 18-Mar-2013 G.Cosmo (geom-specific-V09-06-09) << 819 - G4TessellatedSolid: fixed problem with navig << 820 with concave surfaces. Addresses problem rep << 821 - More cleanup from MT changes in G4VTwistSurf << 822 << 823 12-Mar-2013 G.Cosmo (geom-specific-V09-06-08) << 824 - Added public accessors for MT data to G4Poly << 825 << 826 11-Mar-2013 G.Cosmo (geom-specific-V09-06-07) << 827 - Redefined G4DLL_API to G4GEOM_DLL to avoid c << 828 << 829 08-Mar-2013 G.Cosmo (geom-specific-V09-06-06) << 830 - Renamed G4MT macros to safer ID in G4Polycon << 831 << 832 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05) << 833 - Adopt G4GeomSplitter instead of G4MTTransito << 834 G4PolyhedraSide. Fixed import/export of stat << 835 << 836 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04) << 837 - Cleanup changes for multi-threading in G4Tet << 838 G4PolyconeSide and G4PolyhedraSide. << 839 - Removed unused private data member in G4Twis << 840 << 841 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05) << 842 - Adopt G4GeomSplitter instead of G4MTTransito << 843 G4PolyhedraSide. Fixed import/export of stat << 844 << 845 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04) << 846 - Cleanup changes for multi-threading in G4Tet << 847 G4PolyconeSide and G4PolyhedraSide. << 848 - Removed unused private data member in G4Twis << 849 << 850 11-Jan-2013 G.Cosmo (geom-specific-V09-06-03) << 851 - Fixed condition in G4VTwistSurface::GetBound << 852 Addressing problem report #1420. << 853 << 854 20-Dec-2012 M.Gayer (geom-specific-V09-06-02) << 855 - Fixed cases of hang-ups in G4ExtrudedSolid o << 856 G4TessellatedSolid and G4SurfVoxelizer, caus << 857 with negative indexes. The problem was relat << 858 which can be different even on same platform << 859 Assure same number of computed voxels on 32- << 860 Fixed error in SetVertexIndex() method, whic << 861 certain configurations even for 64-bit syste << 862 - Code cleanup for use of G4endl and tabs... << 863 << 864 14-Dec-2012 G.Cosmo (geom-specific-V09-06-01) << 865 - Restored SVN id headers. << 866 << 867 02-Dec-2012 J.Allison (geom-specific-V09-06-0 << 868 - Removed NURBS. << 869 << 870 29-Nov-2012 G.Cosmo (geom-specific-V09-05-24) << 871 - Remove inclusion of G4PhysicalConstants.hh f << 872 - Fixed unit test for compilation errors. << 873 << 874 28-Nov-2012 G.Cosmo (geom-specific-V09-05-23) << 875 - Fixed more cases of inclusion of constants h << 876 << 877 23-Nov-2012 G.Cosmo (geom-specific-V09-05-22) << 878 - Added 'const' qualifiers to signature in G4V << 879 for porting on AIX-xlC compiler. << 880 << 881 14-Nov-2012 P.Mato (geom-specific-V09-05-21) << 882 - Added #undef NDEBUG in unit tests to ensure << 883 full optimised mode. << 884 << 885 14-Nov-2012 P. Mato (geom-specific-V09-05-20) << 886 - Added #undef NDEBUG in unit tests to ensure << 887 << 888 13-Nov-2012 M.Gayer (geom-specific-V09-05-19) << 889 - More fixes for out-of-bound array accesses i << 890 << 891 12-Nov-2012 M.Gayer (geom-specific-V09-05-18) << 892 - Fixed out-of-bound array access in BuildRedu << 893 << 894 06-Nov-2012 G.Cosmo (geom-specific-V09-05-17) << 895 - Correction in sources.cmake script for missi << 896 << 897 06-Nov-2012 G.Cosmo (geom-specific-V09-05-16) << 898 - Fixed Coverity defects in new code (M.Gayer) << 899 - Minor fixes for porting on AIX. << 900 << 901 01-Nov-2012 G.Cosmo (geom-specific-V09-05-15) << 902 - Fixed compilation of debug code under G4SPEC << 903 << 904 01-Nov-2012 M.Gayer (geom-specific-V09-05-14) << 905 - Corrected signature for voxels count methods << 906 << 907 31-Oct-2012 M.Gayer (geom-specific-V09-05-13) << 908 - Added set/get methods for voxels count in G4 << 909 << 910 30-Oct-2012 M.Gayer (geom-specific-V09-05-12) << 911 - Fixed indexing of vertices in facets for tes << 912 << 913 27-Oct-2012 G.Cosmo (geom-specific-V09-05-11) << 914 - Fixed initialization of data in G4SurfaceVox << 915 - Added post-const qualifier to G4VertextCompa << 916 G4TessellatedSolid. << 917 - Fixed more compilation warnings on unused va << 918 << 919 26-Oct-2012 G.Cosmo (geom-specific-V09-05-10) << 920 - Corrected compilation problem on G4SurfBits << 921 - Polished comments in disclaimer in new updat << 922 << 923 25-Oct-2012 G.Cosmo (geom-specific-V09-05-09) << 924 - Corrected compilation warnings on Linux and << 925 << 926 25-Oct-2012 G.Cosmo (geom-specific-V09-05-08) << 927 - Correction to sources.cmake. << 928 << 929 19-Oct-2012 M.Gayer (geom-specific-V09-05-07) << 930 - Complete rewrite of G4TessellatedSolid resul << 931 requirements by 50%, and factor of tens or m << 932 of the order of thousands, thanks to ad-hoc << 933 Factor of thousands speedup when number of f << 934 thousand. New classes introduced, G4SurfBits << 935 << 936 12-Jun-2012 G.Cosmo (geom-specific-V09-05-06) << 937 - Explicitly use inclusion of headers for syst << 938 constants, in plan to remove implicit inclus << 939 << 940 14-May-2012 G.Cosmo (geom-specific-V09-05-05) << 941 - Fixed spurious cases of hidden variable visi << 942 '-Wshadow' compilation option on gcc compile << 943 << 944 06-Apr-2012 M.Kelsey (geom-specific-V09-05-04 << 945 - Modified GetPointOnSurface() to throw sqrt(r << 946 in G4Paraboloid, G4Polycone and G4TwistedTub << 947 19 948 13-Dec-2011 G.Cosmo (geom-specific-V09-05-03, << 20 13-Dec-2011 G.Cosmo (geom-specific-V09-04-10) 949 - Fixed trivial Coverity defects in G4TwistedT << 21 - Fixed trivial Coverity defects in G4TwistedTubs and G4VTwistedFaceted for 950 missing protection against self-assignment. 22 missing protection against self-assignment. 951 23 952 09-Dec-2011 T.Nikitina (geom-specific-V09-05- << 24 09-Dec-2011 T.Nikitina 953 - Fix in G4EllipticalCone in DistanceToIn(p,v) 25 - Fix in G4EllipticalCone in DistanceToIn(p,v) to exclude imaginary solution 954 (virtual cone) when distance is calculated. 26 (virtual cone) when distance is calculated. 955 27 956 10-Nov-2011 G.Cosmo (geom-specific-V09-04-09) 28 10-Nov-2011 G.Cosmo (geom-specific-V09-04-09) 957 - Fixed trivial Coverity defects on assignment 29 - Fixed trivial Coverity defects on assignment operators... 958 30 959 25-Oct-2011 G.Cosmo (geom-specific-V09-04-08) 31 25-Oct-2011 G.Cosmo (geom-specific-V09-04-08) 960 - Fixed logic in G4VTwistSurface::GetEdgeVisib 32 - Fixed logic in G4VTwistSurface::GetEdgeVisibility() in treatment of corners. 961 33 962 16-Sep-2011 G.Cosmo (geom-specific-V09-04-07) 34 16-Sep-2011 G.Cosmo (geom-specific-V09-04-07) 963 - Fix compilation error in code within G4SPECS 35 - Fix compilation error in code within G4SPECSDEBUG. No functional changes. 964 36 965 13-Sep-2011 I.Hrivnacova (geom-specific-V09-0 37 13-Sep-2011 I.Hrivnacova (geom-specific-V09-04-06) 966 - G4TriangularFacet: fixed tests where square 38 - G4TriangularFacet: fixed tests where square root was compared to 967 half Cartesian tolerance; now compared to kC 39 half Cartesian tolerance; now compared to kCarTolerance. 968 Addressing problem report #1242. 40 Addressing problem report #1242. 969 41 970 25-Aug-2011 G.Cosmo 42 25-Aug-2011 G.Cosmo 971 - Migrated to new G4Exception scheme for warni 43 - Migrated to new G4Exception scheme for warnings and errors. 972 - Defined scheme for warnings/errors coding: 44 - Defined scheme for warnings/errors coding: 973 + 1xxx for warnings, 0xxx for errors. 45 + 1xxx for warnings, 0xxx for errors. 974 Code numbering: 46 Code numbering: 975 + 0001: not supported or implemented feature 47 + 0001: not supported or implemented features; 976 + 0002: invalid setup/construct; 48 + 0002: invalid setup/construct; 977 + 0003: invalid run condition; 49 + 0003: invalid run condition; 978 + 1001: incorrect setup; automatically adapt 50 + 1001: incorrect setup; automatically adapted. 979 + 1002: notification. 51 + 1002: notification. 980 - Added unit test for G4ExtrudedSolid (J.Apost 52 - Added unit test for G4ExtrudedSolid (J.Apostolakis). 981 53 982 22-Aug-2011 I.Hrivnacova (geom-specific-V09-0 54 22-Aug-2011 I.Hrivnacova (geom-specific-V09-04-05) 983 - Fix in G4TriangularFacet::Intersect() to tak 55 - Fix in G4TriangularFacet::Intersect() to take into account geometrical 984 tolerance and cases of zero distance from su 56 tolerance and cases of zero distance from surface's facet. 985 - Fix in G4TessellatedSolid::DistanceToOut(p) 57 - Fix in G4TessellatedSolid::DistanceToOut(p) and DistanceToIn(p) to exactly 986 compute distance from facet avoiding use of 58 compute distance from facet avoiding use of 'outgoing' flag shortcut variant. 987 - Addressing problem report #1242. 59 - Addressing problem report #1242. 988 60 989 17-Aug-2011 T.Nikitina (geom-specific-V09-04- 61 17-Aug-2011 T.Nikitina (geom-specific-V09-04-04) 990 - Fix in G4Paraboloid::DistanceToIn(p,v) and D 62 - Fix in G4Paraboloid::DistanceToIn(p,v) and DistanceToIn(p) to properly 991 take into account tolerance and provide bett 63 take into account tolerance and provide better estimation of distance 992 respectively. Addresses problem report #1234 64 respectively. Addresses problem report #1234. 993 65 994 04-Aug-2011 T.Nikitina (geom-specific-V09-04- 66 04-Aug-2011 T.Nikitina (geom-specific-V09-04-03) 995 - Added SetReferences() and InvertFacets() to 67 - Added SetReferences() and InvertFacets() to G4GenericTrap::CreatePolyhedron() 996 for proper visualisation of Boolean composit 68 for proper visualisation of Boolean compositions with G4GenericTrap. 997 - Added SetReferences() to G4TessellatedSolid: 69 - Added SetReferences() to G4TessellatedSolid::CreatePolyhedron() 998 for proper visualisation of Boolean composit 70 for proper visualisation of Boolean compositions with G4TessellatedSolid. 999 - Requires tag "greps-V09-04-04", for addressi 71 - Requires tag "greps-V09-04-04", for addressing problem report #1235. 1000 72 1001 17-May-2011 I.Hrivnacova (geom-specific-V09- 73 17-May-2011 I.Hrivnacova (geom-specific-V09-04-02) 1002 - G4ExtrudedSolid: fix in Inside(p) for false 74 - G4ExtrudedSolid: fix in Inside(p) for false overlap reporting. 1003 Addressing problem report #1211. 75 Addressing problem report #1211. 1004 76 1005 12-May-2011 G.Cosmo (geom-specific-V09-04-01 77 12-May-2011 G.Cosmo (geom-specific-V09-04-01) 1006 - Fixed compilation warnings from gcc-4.6.0 f 78 - Fixed compilation warnings from gcc-4.6.0 for variables set but not used. 1007 79 1008 06-May-2011 G.Cosmo (geom-specific-V09-04-00 80 06-May-2011 G.Cosmo (geom-specific-V09-04-00) 1009 - Use G4 typedef for CLHEP types. 81 - Use G4 typedef for CLHEP types. 1010 82 1011 26-Nov-2010 T.Nikitina (geom-specific-V09-03 83 26-Nov-2010 T.Nikitina (geom-specific-V09-03-20) 1012 - Fixes in G4GenericTrap reported by SBT unit 84 - Fixes in G4GenericTrap reported by SBT unit test in SurfaceNormal(), 1013 DistanceToPlane() and VisExtent(). 85 DistanceToPlane() and VisExtent(). 1014 86 1015 16-Nov-2010 T.Nikitina (geom-specific-V09-03 87 16-Nov-2010 T.Nikitina (geom-specific-V09-03-19) 1016 - G4EllipticalCone: fixes in DistanceToIn(p,v 88 - G4EllipticalCone: fixes in DistanceToIn(p,v) and DistanceToOut(p,v) for 1017 correct handling of point on the surface. 89 correct handling of point on the surface. 1018 Corrected formula for SurfaceNormal(p). 90 Corrected formula for SurfaceNormal(p). 1019 91 1020 10-Nov-2010 T.Nikitina (geom-specific-V09-03 92 10-Nov-2010 T.Nikitina (geom-specific-V09-03-18) 1021 - Added checks on crossing of vertices and to 93 - Added checks on crossing of vertices and too big twisted angle in 1022 G4GenericTrap. 94 G4GenericTrap. 1023 - Fixed case of division by zero in G4Twisted 95 - Fixed case of division by zero in G4TwistedTubs. 1024 - Added unit test for G4Polyhedra. 96 - Added unit test for G4Polyhedra. 1025 97 1026 02-Nov-2010 G.Cosmo (geom-specific-V09-03-17 98 02-Nov-2010 G.Cosmo (geom-specific-V09-03-17) 1027 - More fixes on Coverity reports for G4Tessel 99 - More fixes on Coverity reports for G4TessellatedSolid and G4ReduciblePolygon. 1028 100 1029 20-Oct-2010 G.Cosmo (geom-specific-V09-03-16 101 20-Oct-2010 G.Cosmo (geom-specific-V09-03-16) 1030 - Implemented Clone() virtual method for all 102 - Implemented Clone() virtual method for all solids, returning a pointer 1031 to a dynamically allocated copy of the soli 103 to a dynamically allocated copy of the solid. To be used by Geant4-MT. 1032 104 1033 23-Sep-2010 G.Cosmo (geom-specific-V09-03-15 105 23-Sep-2010 G.Cosmo (geom-specific-V09-03-15) 1034 - Initialize fpPolyhedron to zero in copy-cto 106 - Initialize fpPolyhedron to zero in copy-ctor and operator=(). 1035 - Completed implementation of copy-ctor and o 107 - Completed implementation of copy-ctor and operator=() for facets. 1036 108 1037 20-Sep-2010 G.Cosmo (geom-specific-V09-03-14 109 20-Sep-2010 G.Cosmo (geom-specific-V09-03-14) 1038 - Implemented copy-constructor and assignment 110 - Implemented copy-constructor and assignment operator for all solids 1039 to facilitate conversion to Geant4-MT. 111 to facilitate conversion to Geant4-MT. 1040 112 1041 08-Sep-2010 G.Cosmo (geom-specific-V09-03-13 113 08-Sep-2010 G.Cosmo (geom-specific-V09-03-13) 1042 - Correction to previous fix in G4ReduciblePo 114 - Correction to previous fix in G4ReduciblePolygon to avoid deleting current 1043 'vertexHead' pointer. 115 'vertexHead' pointer. 1044 116 1045 07-Sep-2010 G.Cosmo (geom-specific-V09-03-12 117 07-Sep-2010 G.Cosmo (geom-specific-V09-03-12) 1046 - Fix within G4CSGDEBUG code for restoring co 118 - Fix within G4CSGDEBUG code for restoring cout precision. 1047 - Fix in G4ReduciblePolygon::RemoveRedundantV 119 - Fix in G4ReduciblePolygon::RemoveRedundantVertices() to avoid potential 1048 case of dereferencing freed pointer. 120 case of dereferencing freed pointer. 1049 121 1050 19-Aug-2010 T.Nikitina (geom-specific-V09-03 122 19-Aug-2010 T.Nikitina (geom-specific-V09-03-11) 1051 - G4EllipticalTube: extended implementation o 123 - G4EllipticalTube: extended implementation of SurfaceNormal(p) in agreement 1052 with canonical form. Added unit test testG4 124 with canonical form. Added unit test testG4EllipticalTube.cc. 1053 125 1054 16-Jul-2010 G.Cosmo (geom-specific-V09-03-10 126 16-Jul-2010 G.Cosmo (geom-specific-V09-03-10) 1055 - Fixed cases of division by zero in G4VTwist 127 - Fixed cases of division by zero in G4VTwistSurface and G4TwistBoxSide. 1056 - Use INT_MAX as initialisation for max limit 128 - Use INT_MAX as initialisation for max limits in G4SolidExtentList. 1057 129 1058 12-Jul-2010 G.Cosmo (geom-specific-V09-03-09 130 12-Jul-2010 G.Cosmo (geom-specific-V09-03-09) 1059 - Added dummy initialization to members in st << 131 - Added dummy initialization to members in struct 1060 G4PolyPhiFace::G4PolyPhiFaceEdge, struct G4 132 G4PolyPhiFace::G4PolyPhiFaceEdge, struct G4ReduciblePolygon::ABVertex. 1061 G4Ellipsoid, G4EllipticalTube, G4EnclosingC 133 G4Ellipsoid, G4EllipticalTube, G4EnclosingCylinder, G4ExtrudedSolid, G4Hype, 1062 G4IntersectingCone, G4Paraboloid, G4PolyPhi 134 G4IntersectingCone, G4Paraboloid, G4PolyPhiFace, G4Polycone, G4PolyconeSide, 1063 G4Polyhedra, G4PolyhedraSide, G4Quadrangula 135 G4Polyhedra, G4PolyhedraSide, G4QuadrangularFacet, G4ReduciblePolygon, 1064 G4TessellatedSolid, G4TriangularFacet, G4Tw 136 G4TessellatedSolid, G4TriangularFacet, G4TwistBoxSide, G4TwistTrapAlphaSide, 1065 G4TwistTrapFlatSide, G4TwistTrapParallelSid 137 G4TwistTrapFlatSide, G4TwistTrapParallelSide, G4TwistTubsFlatSide, 1066 G4TwistTubsHypeSide, G4TwistTubsSide, G4Twi 138 G4TwistTubsHypeSide, G4TwistTubsSide, G4TwistedTubs, G4VCSGfaceted, G4VFacet, 1067 G4VTwistSurface, G4VTwistedFaceted. 139 G4VTwistSurface, G4VTwistedFaceted. 1068 - Fixed case of dereferencing null pointer in 140 - Fixed case of dereferencing null pointer in methods 1069 G4EllipticalTube::DistanceToOut(p,v), G4VCS 141 G4EllipticalTube::DistanceToOut(p,v), G4VCSGfaceted::DistanceToIn(p,v) 1070 and G4VCSGfaceted::DistanceToOut(p,v). 142 and G4VCSGfaceted::DistanceToOut(p,v). 1071 - Fixed unecessary object copy as argument in 143 - Fixed unecessary object copy as argument in method 1072 G4PolyhedraSide::IntersectSidePlane(). 144 G4PolyhedraSide::IntersectSidePlane(). 1073 - Avoid possible case of derefencing null poi 145 - Avoid possible case of derefencing null pointer in G4ReduciblePolygon 1074 RemoveDuplicateVertices() and RemoveRedunda 146 RemoveDuplicateVertices() and RemoveRedundantVertices() methods. 1075 - Replaced calls to std::abs() with std::fabs 147 - Replaced calls to std::abs() with std::fabs() where suitable. 1076 148 1077 16-Jun-2010 G.Cosmo (geom-specific-V09-03-08 149 16-Jun-2010 G.Cosmo (geom-specific-V09-03-08) 1078 - Fixed deletion of internal arrays in Create 150 - Fixed deletion of internal arrays in CreatePolyhedron() for G4Polycone 1079 and G4Polyhedra. 151 and G4Polyhedra. 1080 152 1081 11-Jun-2010 T.Nikitina (geom-specific-V09-03 153 11-Jun-2010 T.Nikitina (geom-specific-V09-03-07) 1082 - G4GenericTrap: fixed cases of zero dToIn/sT 154 - G4GenericTrap: fixed cases of zero dToIn/sToOut when vertices are collapsed 1083 to triangle, line or point. Added new metho 155 to triangle, line or point. Added new methods handling those specific cases. 1084 - Added unit test for G4GenericTrap. 156 - Added unit test for G4GenericTrap. 1085 157 1086 10-Jun-2010 I.Hrivnacova 158 10-Jun-2010 I.Hrivnacova 1087 - G4GenericTrap: fixed parameter names in Cal 159 - G4GenericTrap: fixed parameter names in CalculateExtent() for the test 1088 case construction through tessellated facet 160 case construction through tessellated facets. 1089 161 1090 09-Jun-2010 G.Cosmo 162 09-Jun-2010 G.Cosmo 1091 - G4GenericTrap: moved internal methods to pr 163 - G4GenericTrap: moved internal methods to private section and reordered 1092 in source file. Added missing implementatio 164 in source file. Added missing implementation for IsTwisted() method. 1093 165 1094 03-Jun-2010 T.Nikitina, G.Cosmo (geom-specif 166 03-Jun-2010 T.Nikitina, G.Cosmo (geom-specific-V09-03-06) 1095 - G4GenericTrap: 167 - G4GenericTrap: 1096 o Fixed initialization of fSurfaceArea and 168 o Fixed initialization of fSurfaceArea and fCubicVolume and 1097 calculation of surface area. 169 calculation of surface area. 1098 o Fixed error in Inside(p) function, and co 170 o Fixed error in Inside(p) function, and corrected use std::fabs() instead 1099 of std::abs() for floating point values. 171 of std::abs() for floating point values. 1100 o Added missing initialisation of fpPolyhed 172 o Added missing initialisation of fpPolyhedron pointer. 1101 o More corrected signatures for use of non- 173 o More corrected signatures for use of non-const references for vectors 1102 passed as arguments to functions. 174 passed as arguments to functions. 1103 175 1104 02-Jun-2010 G.Cosmo (geom-specific-V09-03-05 176 02-Jun-2010 G.Cosmo (geom-specific-V09-03-05) 1105 - G4GenericTrap: use const reference for vect 177 - G4GenericTrap: use const reference for vector of vertices passed as argument 1106 in constructor and accessor. 178 in constructor and accessor. 1107 179 1108 27-May-2010 T.Nikitina (geom-specific-V09-03 180 27-May-2010 T.Nikitina (geom-specific-V09-03-04) 1109 - First implementation of G4GenericTrap shape 181 - First implementation of G4GenericTrap shape, a new solid representing an 1110 arbitrary trapezoid with up to 8 vertices s 182 arbitrary trapezoid with up to 8 vertices standing on two parallel planes 1111 perpendicular to the Z axis. 183 perpendicular to the Z axis. 1112 184 1113 28-Apr-2010 P.R.Truscott (geom-specific-V09- 185 28-Apr-2010 P.R.Truscott (geom-specific-V09-03-03) 1114 - Fix in G4TriangularFacet and G4TessellatedS 186 - Fix in G4TriangularFacet and G4TessellatedSolid to correct treatment of 1115 optical photon transport related to interna 187 optical photon transport related to internal reflection at surface. 1116 Addresses problem report #1103. 188 Addresses problem report #1103. 1117 189 1118 15-Apr-2010 I.Hrivnacova (geom-specific-V09- 190 15-Apr-2010 I.Hrivnacova (geom-specific-V09-03-02) 1119 - G4ExtrudedSolid: eliminated requirement for 191 - G4ExtrudedSolid: eliminated requirement for clockwise ordering of polygon 1120 vertices. Added a check for vertices orderi 192 vertices. Added a check for vertices ordering; if vertices are defined 1121 anti-clockwise their ordering is reverted. 193 anti-clockwise their ordering is reverted. 1122 Fix in polygon facet triangularization for 194 Fix in polygon facet triangularization for consequent concave vertices. 1123 195 1124 24-Feb-2010 G.Cosmo (geom-specific-V09-03-01 196 24-Feb-2010 G.Cosmo (geom-specific-V09-03-01) 1125 - Adopt caching of Phi in G4PolyconeSide and 197 - Adopt caching of Phi in G4PolyconeSide and G4PolyhedraSide to avoid 1126 unnecessary consecutive computations on the 198 unnecessary consecutive computations on the same point. 1127 199 1128 10-Feb-2010 G.Cosmo (geom-specific-V09-03-00 200 10-Feb-2010 G.Cosmo (geom-specific-V09-03-00) 1129 - Use kInfinity for initialising minimum and 201 - Use kInfinity for initialising minimum and maximum allowed extent for 1130 G4SolidExtentList of faceted solids. 202 G4SolidExtentList of faceted solids. 1131 203 1132 11-Nov-2009 G.Cosmo (geom-specific-V09-02-08 204 11-Nov-2009 G.Cosmo (geom-specific-V09-02-08) 1133 - Avoid fake (and redundant) assignment of va 205 - Avoid fake (and redundant) assignment of value to 3-vector in 1134 G4PolyconeSide and G4TwistTubsSide. 206 G4PolyconeSide and G4TwistTubsSide. 1135 207 1136 24-Sep-2009 T.Nikitina (geom-specific-V09-02 208 24-Sep-2009 T.Nikitina (geom-specific-V09-02-07) 1137 - G4Ellipsoid: refined fix in DistanceToIn(p, 209 - G4Ellipsoid: refined fix in DistanceToIn(p,v) for points located on the 1138 curved surface, and correct treatment of ge 210 curved surface, and correct treatment of geometrical tolerance. 1139 211 1140 09-Sep-2009 G.Cosmo (geom-specific-V09-02-06 212 09-Sep-2009 G.Cosmo (geom-specific-V09-02-06) 1141 - G4Ellipsoid: fixed usage of half-tolerances 213 - G4Ellipsoid: fixed usage of half-tolerances (radial and Cartesian) in 1142 DistanceToIn(p,v), based on incorrect assum 214 DistanceToIn(p,v), based on incorrect assumptions introduced in tag 1143 "geom-specific-V09-02-04", responsible for 215 "geom-specific-V09-02-04", responsible for zero steps on configurations 1144 with cut in Z. Addresses problem report #10 216 with cut in Z. Addresses problem report #1076. 1145 217 1146 04-Aug-2009 T.Nikitina (geom-specific-V09-02 218 04-Aug-2009 T.Nikitina (geom-specific-V09-02-05) 1147 - G4Ellipsoid: 219 - G4Ellipsoid: 1148 o Fixes in Inside(p) and in DistanceToIn(p, 220 o Fixes in Inside(p) and in DistanceToIn(p,v) for points 1149 located on the curved surface within tole 221 located on the curved surface within tolerance. Final fix for issue 1150 reported in problem report #1050 and conc 222 reported in problem report #1050 and concerning warnings reported by 1151 grid_test. 223 grid_test. 1152 o Adopt pre-computed half-tolerance values 224 o Adopt pre-computed half-tolerance values for optimisation. 1153 225 1154 23-Jul-2009 T.Nikitina (geom-specific-V09-02 226 23-Jul-2009 T.Nikitina (geom-specific-V09-02-04) 1155 - G4Ellipsoid: fix to DistanceToIn(p,v) in th 227 - G4Ellipsoid: fix to DistanceToIn(p,v) in the calculation of the roots of 1156 the quadratic equation and in DistanceToOut 228 the quadratic equation and in DistanceToOut(p,v) in the calculation of the 1157 normal on cut surfaces. Final fix for probl 229 normal on cut surfaces. Final fix for problem report #1022 and #1050. 1158 - G4PolyconeSide: added protection in method 230 - G4PolyconeSide: added protection in method Normal(), addressing problem 1159 report #1073. 231 report #1073. 1160 232 1161 30-Jun-2009 T.Nikitina (geom-specific-V09-02 233 30-Jun-2009 T.Nikitina (geom-specific-V09-02-03) 1162 - G4Ellipsoid: introduced to DistanceToIn(p,v 234 - G4Ellipsoid: introduced to DistanceToIn(p,v) splitting of the distance for 1163 point very far from intersection area and b 235 point very far from intersection area and big difference between solid 1164 dimensions and distance to it; resolves iss 236 dimensions and distance to it; resolves issue observed on 64 bits problem. 1165 Also addressing problem report #1022. 237 Also addressing problem report #1022. 1166 238 1167 08-May-2009, G.Cosmo (geom-specific-V09-02-02 239 08-May-2009, G.Cosmo (geom-specific-V09-02-02) 1168 - Corrected typo in base implementation of G4 240 - Corrected typo in base implementation of G4VCSGfaceted::GetSurfaceArea(), 1169 which was erroneously returning cubic volum 241 which was erroneously returning cubic volume estimation. 1170 Addresses problem report #1062. 242 Addresses problem report #1062. 1171 243 1172 27-Apr-2009, G.Cosmo (geom-specific-V09-02-01 244 27-Apr-2009, G.Cosmo (geom-specific-V09-02-01) 1173 - Relaxed error condition in G4TessellatedSol 245 - Relaxed error condition in G4TessellatedSolid::Inside(p) to warning, for 1174 excess of max trials and anomalous conditio 246 excess of max trials and anomalous conditions in distance calculation. 1175 Added more printout information when error 247 Added more printout information when error condition is detected. 1176 248 1177 27-Feb-2009, T.Nikitina (geom-specific-V09-02 249 27-Feb-2009, T.Nikitina (geom-specific-V09-02-00) 1178 - Fix in G4Paraboloid::DistanceToOut(p,v,..) 250 - Fix in G4Paraboloid::DistanceToOut(p,v,..) for the computation of normal 1179 to surface; added missing normalisation to 251 to surface; added missing normalisation to unit, following remark in the 1180 Geometry Forum Hypernews posting #953. 252 Geometry Forum Hypernews posting #953. 1181 253 1182 21-Nov-2008, G.Cosmo (geom-specific-V09-01-19 254 21-Nov-2008, G.Cosmo (geom-specific-V09-01-19) 1183 - Added missing accessors to G4EllipticalCone 255 - Added missing accessors to G4EllipticalCone, required for detector 1184 persistency. 256 persistency. 1185 257 1186 13-Nov-2008, G.Cosmo (geom-specific-V09-01-18 258 13-Nov-2008, G.Cosmo (geom-specific-V09-01-18) 1187 - Corrected initialisation of algorithm in G4 259 - Corrected initialisation of algorithm in G4TriangularFacet constructor. 1188 260 1189 30-Oct-2008, I.Hrivnacova (geom-specific-V09- 261 30-Oct-2008, I.Hrivnacova (geom-specific-V09-01-17) 1190 - G4ExtrudedSolid: fixed bug in the decomposi 262 - G4ExtrudedSolid: fixed bug in the decomposition of polygonal sides for 1191 quadrangular facets in MakeFacets(). Addres 263 quadrangular facets in MakeFacets(). Addresses problem report #1029. 1192 264 1193 23-Sep-2008, T.Nikitina (geom-specific-V09-01 265 23-Sep-2008, T.Nikitina (geom-specific-V09-01-16) 1194 - Corrected algorithm in G4TriangularFacet::G 266 - Corrected algorithm in G4TriangularFacet::GetPointOnFace() according to 1195 suggestion advanced in problem report #1025 267 suggestion advanced in problem report #1025. Fixes a problem of false 1196 overlaps detection related to G4ExtrudedSol 268 overlaps detection related to G4ExtrudedSolid and G4TessellatedSolid. 1197 269 1198 12-Sep-2008, G.Cosmo (geom-specific-V09-01-15 270 12-Sep-2008, G.Cosmo (geom-specific-V09-01-15) 1199 - G4VFacet: corrected increment of indeces in 271 - G4VFacet: corrected increment of indeces in operator==(), following 1200 problem report #1024. 272 problem report #1024. 1201 273 1202 25-Jul-2008, I.Hrivnacova (geom-specific-V09- 274 25-Jul-2008, I.Hrivnacova (geom-specific-V09-01-14) 1203 - G4ExtrudedSolid: fix in polygon decompositi 275 - G4ExtrudedSolid: fix in polygon decomposition; systematically use 1204 half kCarTolerance instead of kCarTolerance 276 half kCarTolerance instead of kCarTolerance; added solid name in the 1205 error messages coming from fatal exceptions 277 error messages coming from fatal exceptions. 1206 278 1207 16-Jul-2008, T.Nikitina (geom-specific-V09-01 279 16-Jul-2008, T.Nikitina (geom-specific-V09-01-13) 1208 - G4Paraboloid: revised DistanceToOut(p,v,... 280 - G4Paraboloid: revised DistanceToOut(p,v,...) in answer to problem report 1209 #1015. Fixed precision problem when solving 281 #1015. Fixed precision problem when solving quadratic equation; apply 1210 comparison with kCarTolerance and not with 282 comparison with kCarTolerance and not with zero; fixed logic problem in 1211 algoritm for points on surface and directio 283 algoritm for points on surface and direction inside, relative to directions 1212 along Z, (0,0,Vz). 284 along Z, (0,0,Vz). 1213 285 1214 22-May-2008, G.Cosmo (geom-specific-V09-01-12 286 22-May-2008, G.Cosmo (geom-specific-V09-01-12) 1215 - Removed left-over debug printout in G4VCSGF 287 - Removed left-over debug printout in G4VCSGFaceted::DistanceToIn(). 1216 288 1217 15-May-2008, T.Nikitina (geom-specific-V09-01 289 15-May-2008, T.Nikitina (geom-specific-V09-01-11) 1218 - Enhanced GetPointOnSurface() for generic G4 290 - Enhanced GetPointOnSurface() for generic G4Polycone and G4Polyhedra 1219 constructs; the method uses new triangulati 291 constructs; the method uses new triangulation algorithm for G4PolyPhiFace. 1220 - G4ExtrudedSolid: added missing 'std' namesp 292 - G4ExtrudedSolid: added missing 'std' namespace to standard mathematical 1221 function calls. 293 function calls. 1222 294 1223 28-Apr-2008, T.Nikitina (geom-specific-V09-01 295 28-Apr-2008, T.Nikitina (geom-specific-V09-01-10) 1224 - Added kCarTolerance in definition of "low" 296 - Added kCarTolerance in definition of "low" and "high" cone limits in R 1225 and in Z in order to protect against numeri 297 and in Z in order to protect against numerical errors. This fixes cases of 1226 DistanceToIn(p,v) returning 'kInfinity' whe 298 DistanceToIn(p,v) returning 'kInfinity' when p+t*v cross intersection 1227 between two cones. 299 between two cones. 1228 300 1229 25-Apr-2008, T.Nikitina (geom-specific-V09-01 301 25-Apr-2008, T.Nikitina (geom-specific-V09-01-09) 1230 - Added protection against NaN in G4Intersect 302 - Added protection against NaN in G4IntersectingCone::LineHitsCone1() in 1231 case of configuration where a conic section 303 case of configuration where a conic section becomes a tube. 1232 - G4EllipticalCone: removed some debug printo 304 - G4EllipticalCone: removed some debug printouts. 1233 305 1234 14-Apr-2008, T.Nikitina (geom-specific-V09-01 306 14-Apr-2008, T.Nikitina (geom-specific-V09-01-08) 1235 - G4Hype: refined polyhedron representation f 307 - G4Hype: refined polyhedron representation for correct visualization of 1236 the shape. Coworks with tag "greps-V09-01-0 308 the shape. Coworks with tag "greps-V09-01-04". 1237 309 1238 13-Mar-2008, G.Cosmo (geom-specific-V09-01-07 310 13-Mar-2008, G.Cosmo (geom-specific-V09-01-07) 1239 - Cleared compilation warnings in G4Paraboloi 311 - Cleared compilation warnings in G4Paraboloid and G4TessellatedSolid 1240 on gcc-4.3.0 for ambiguous use of parenthes 312 on gcc-4.3.0 for ambiguous use of parentheses in condition statements. 1241 313 1242 28-Feb-2008, I.Hrivnacova (geom-specific-V09- 314 28-Feb-2008, I.Hrivnacova (geom-specific-V09-01-06) 1243 - Correction to previous fix in G4ExtrudedSol 315 - Correction to previous fix in G4ExtrudedSolid: testing on the edges has 1244 to be limited to the line segment, for this 316 to be limited to the line segment, for this purpose a new internal method 1245 IsSameLineSegment() has been introduced for 317 IsSameLineSegment() has been introduced for use instead of IsSameLine(). 1246 - Updated and extended unit test testG4Extrud 318 - Updated and extended unit test testG4ExtrudedSolid.cc. 1247 319 1248 27-Feb-2008, I.Hrivnacova (geom-specific-V09- 320 27-Feb-2008, I.Hrivnacova (geom-specific-V09-01-05) 1249 - Fix in G4TessellatedSolid::DistanceToOut(p, 321 - Fix in G4TessellatedSolid::DistanceToOut(p,v,..) to compute normal only 1250 if specified by flag in input. 322 if specified by flag in input. 1251 - Fix in G4ExtrudedSolid::Inside(p) for corre 323 - Fix in G4ExtrudedSolid::Inside(p) for correctly handling the case of 1252 points located on the edges of triangles wh 324 points located on the edges of triangles which are not the outline edges 1253 of the polygon. 325 of the polygon. 1254 326 1255 21-Feb-2008, T.Nikitina (geom-specific-V09-01 327 21-Feb-2008, T.Nikitina (geom-specific-V09-01-04) 1256 - G4Polyhedra: fixed problem of out-of-bound 328 - G4Polyhedra: fixed problem of out-of-bound access to vectors in 1257 GetPointOnSurface(). 329 GetPointOnSurface(). 1258 330 1259 20-Feb-2008, I.Hrivnacova (geom-specific-V09- 331 20-Feb-2008, I.Hrivnacova (geom-specific-V09-01-03) 1260 - G4TessellatedSolid: fixed bug in copy-const 332 - G4TessellatedSolid: fixed bug in copy-constructor and internal method 1261 CopyObjects() for cloning of facets. 333 CopyObjects() for cloning of facets. 1262 334 1263 05-Feb-2008, I.Hrivnacova (geom-specific-V09- 335 05-Feb-2008, I.Hrivnacova (geom-specific-V09-01-02) 1264 - G4ExtrudedSolid: bug fix in MakeFacets() to 336 - G4ExtrudedSolid: bug fix in MakeFacets() to fill 'fTriangles' also in case 1265 of polygon with 3 or 4 vertices, as they ar 337 of polygon with 3 or 4 vertices, as they are needed for Inside(p). 1266 338 1267 02-Feb-2008, I.Hrivnacova (geom-specific-V09- 339 02-Feb-2008, I.Hrivnacova (geom-specific-V09-01-01) 1268 - Corrected triangularization of polygon, now 340 - Corrected triangularization of polygon, now correctly handling case 1269 of concave shapes. 341 of concave shapes. 1270 - Corrected order of arguments in G4Paraboloi << 342 - Corrected order of arguments in G4Paraboloid constructor. 1271 343 1272 16-Jan-2008, I.Hrivnacova (geom-specific-V09- 344 16-Jan-2008, I.Hrivnacova (geom-specific-V09-01-00) 1273 - In G4ExtrudedSolid::MakeFacets(), now addin 345 - In G4ExtrudedSolid::MakeFacets(), now adding triangular facets before quadrangular 1274 ones, following logic behind G4TessellatedS 346 ones, following logic behind G4TessellatedSolid. 1275 347 1276 12-Dec-2007, G.Cosmo (geom-specific-V09-00-08 348 12-Dec-2007, G.Cosmo (geom-specific-V09-00-08a) 1277 - Remove use of global static constant from s 349 - Remove use of global static constant from singleton initialisation in 1278 G4TessellatedGeometryAlgorithms class. Use 350 G4TessellatedGeometryAlgorithms class. Use 'sqrEpsilon' as local value. 1279 351 1280 15-Nov-2007, P.Truscott (geom-specific-V09-00 352 15-Nov-2007, P.Truscott (geom-specific-V09-00-08) 1281 - Reviewed implementation of G4TessellatedSol 353 - Reviewed implementation of G4TessellatedSolid::CalculateExtent() to 1282 make it more robust and precise, following 354 make it more robust and precise, following suggestion by S.Seibert 1283 addressed in problem report #983, now fixed 355 addressed in problem report #983, now fixed. 1284 356 1285 12-Oct-2007, G.Cosmo (geom-specific-V09-00-07 357 12-Oct-2007, G.Cosmo (geom-specific-V09-00-07) 1286 - Corrected wrong boolean condition in method 358 - Corrected wrong boolean condition in method IntersectLineAndTriangle2D() 1287 of G4TessellatedGeometryAlgorithms causing 359 of G4TessellatedGeometryAlgorithms causing compilation error on VC++8. 1288 360 1289 09-Oct-2007, G.Cosmo (geom-specific-V09-00-06 361 09-Oct-2007, G.Cosmo (geom-specific-V09-00-06) 1290 - Reviewed G4TessellatedSolid classes in orde 362 - Reviewed G4TessellatedSolid classes in order not to make use of random 1291 numbers for selection of direction (by P.Tr 363 numbers for selection of direction (by P.Truscott). 1292 364 1293 02-Oct-2007, G.Cosmo 365 02-Oct-2007, G.Cosmo 1294 - Removed debug printout in G4Polycone::GetPo 366 - Removed debug printout in G4Polycone::GetPointOnCone(). 1295 367 1296 23-Aug-2007, G.Cosmo (geom-specific-V09-00-05 368 23-Aug-2007, G.Cosmo (geom-specific-V09-00-05) 1297 - Revision of G4TessellatedSolid classes: 369 - Revision of G4TessellatedSolid classes: 1298 o Fixed problem report #931 by P.Truscott, 370 o Fixed problem report #931 by P.Truscott, based on suggestion of 1299 R.Holmberg. Modified classes G4Tessellate 371 R.Holmberg. Modified classes G4TessellatedSolid and G4TriangularFacet. 1300 o Modified data and accessor 'centroid' and 372 o Modified data and accessor 'centroid' and 'GetCentroid()' for G4VFacet; 1301 replaced by 'circumcentre' and 'GetCircum 373 replaced by 'circumcentre' and 'GetCircumcentre()' respectively. 1302 o Added utility class G4TessellatedGeometry 374 o Added utility class G4TessellatedGeometryAlgorithms. 1303 - Added formulas for calculating SemiAxis and 375 - Added formulas for calculating SemiAxis and Zheight in G4EllipticalCone 1304 (by T.Nikitina). 376 (by T.Nikitina). 1305 377 1306 20-Aug-2007, T.Nikitina & L.Lindroos (geom-sp 378 20-Aug-2007, T.Nikitina & L.Lindroos (geom-specific-V09-00-04) 1307 - Revision of G4EllipticalCone: 379 - Revision of G4EllipticalCone: 1308 o DistanceToIn(p): corrected answer for p.z 380 o DistanceToIn(p): corrected answer for p.z()<-zTopCut and for the point 1309 p on the surface. 381 p on the surface. 1310 o DistanceToOut(p,v): now returning positiv 382 o DistanceToOut(p,v): now returning positive solution or zero when crossing 1311 the elliptical surface. 383 the elliptical surface. 1312 o Fix in DistanceToOut(p) which was giving << 384 o Fix in DistanceToOut(p) which was giving always zero. 1313 o Corrected visualisation error of solid in 385 o Corrected visualisation error of solid in graphics_reps. 1314 o Added some formulas on how to pre-calcula 386 o Added some formulas on how to pre-calculate 'SemiAxis' and 'zheight'. 1315 o Added checkDistanceToOut() method to unit 387 o Added checkDistanceToOut() method to unit test. 1316 - Corrections to G4Paraboloid: 388 - Corrections to G4Paraboloid: 1317 o Fixed bug in CalculateSurfaceArea() metho 389 o Fixed bug in CalculateSurfaceArea() method 1318 o Added correct initialisation of 'fPolyhed 390 o Added correct initialisation of 'fPolyhedron' in constructor. 1319 o Added unit test testG4Paraboloid. 391 o Added unit test testG4Paraboloid. 1320 392 1321 13-Aug-2007, W.Pokorski (geom-specific-V09-00 393 13-Aug-2007, W.Pokorski (geom-specific-V09-00-03) 1322 - G4PolyconeSide: added workaround to initial 394 - G4PolyconeSide: added workaround to initialisation of 'corners' vector, 1323 to allow for object persistency with Root-I 395 to allow for object persistency with Root-I/O (W.Pokorski). 1324 396 1325 18-Jul-2007, G.Cosmo (geom-specific-V09-00-02 397 18-Jul-2007, G.Cosmo (geom-specific-V09-00-02) 1326 - New specific G4Paraboloid with cuts along t 398 - New specific G4Paraboloid with cuts along the Z axis (by L.Lindroos). 1327 - Fixed dummy constructors of G4Polycone and 399 - Fixed dummy constructors of G4Polycone and G4PolyPhiFace for initialisation 1328 of 'edges' and 'corners'. 400 of 'edges' and 'corners'. 1329 - Coworks with tag "greps-V09-00-01". 401 - Coworks with tag "greps-V09-00-01". 1330 402 1331 12-Jul-2007, T.Nikitina (geom-specific-V09-00 403 12-Jul-2007, T.Nikitina (geom-specific-V09-00-01) 1332 - Fix in G4Polyhedra::GetPointOnSurface() to 404 - Fix in G4Polyhedra::GetPointOnSurface() to correctly treat 'totalPhi' instead of 1333 'endPhi' for the case of open shapes and 't 405 'endPhi' for the case of open shapes and 'twopi' for not open shapes. 1334 406 1335 05-Jul-2007, T.Nikitina (geom-specific-V09-00 407 05-Jul-2007, T.Nikitina (geom-specific-V09-00-00) 1336 - Fix in G4Polyhedra::GetPointOnSurface() for 408 - Fix in G4Polyhedra::GetPointOnSurface() for the case when number of sectors 1337 (numSide) is equal to 1. At the origin of p 409 (numSide) is equal to 1. At the origin of problems observed when checking 1338 overlaps for polyhedra solids defined as su 410 overlaps for polyhedra solids defined as such. 1339 411 1340 31-May-2007, G.Cosmo (geom-specific-V08-03-03 412 31-May-2007, G.Cosmo (geom-specific-V08-03-03) 1341 - Fixed initialisation of constants in constr 413 - Fixed initialisation of constants in constructor for - G4VTwistSurface, 1342 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraS 414 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraSide - following latest changes 1343 for tunable tolerance. 415 for tunable tolerance. 1344 416 1345 25-May-2007, G.Cosmo (geom-specific-V08-03-02 417 25-May-2007, G.Cosmo (geom-specific-V08-03-02) 1346 - Fixed default response of DistToIn/DistToOu 418 - Fixed default response of DistToIn/DistToOut for twisted solids. 1347 - Use G4TWISTDEBUG instead of G4SPECSDEBUG as 419 - Use G4TWISTDEBUG instead of G4SPECSDEBUG as debug conditional flag 1348 for twisted solids. 420 for twisted solids. 1349 - Some cleanup in G4TwistTrapAlphaSide code. 421 - Some cleanup in G4TwistTrapAlphaSide code. 1350 422 1351 18-May-2007, G.Cosmo (geom-specific-V08-03-01 423 18-May-2007, G.Cosmo (geom-specific-V08-03-01) 1352 - Use kAngTolerance and kRadTolerance from G4 424 - Use kAngTolerance and kRadTolerance from G4GeometryTolerance class. 1353 - Coworks with tag "global-V08-03-03". 425 - Coworks with tag "global-V08-03-03". 1354 426 1355 11-May-2007, T.Nikitina (geom-specific-V08-03 427 11-May-2007, T.Nikitina (geom-specific-V08-03-00) 1356 - Use call to G4GeometryTolerance instead of 428 - Use call to G4GeometryTolerance instead of kCarTolerance where needed. 1357 - Requires tag "global-V08-03-00" and related 429 - Requires tag "global-V08-03-00" and related tag set. 1358 430 1359 26-Apr-2007, T.Nikitina (geom-specific-V08-02 431 26-Apr-2007, T.Nikitina (geom-specific-V08-02-05) 1360 - Fix in GetPointOnSurface() for G4Polycone t 432 - Fix in GetPointOnSurface() for G4Polycone to consider also points laying 1361 on rings when consecutive Z-sections are co 433 on rings when consecutive Z-sections are coincident. 1362 Added method GetPointOnRing(). 434 Added method GetPointOnRing(). 1363 - Added unit test testPointOnSurfacePoly.cc. 435 - Added unit test testPointOnSurfacePoly.cc. 1364 436 1365 27-Feb-2007, I.Hrivnacova (geom-specific-V08- 437 27-Feb-2007, I.Hrivnacova (geom-specific-V08-02-04) 1366 - Added specialised constructor for handling 438 - Added specialised constructor for handling Z-sections in G4ExtrudedSolid. 1367 - Cleared unecessary declaration of IsInside( 439 - Cleared unecessary declaration of IsInside() methods in G4TriangularFacet 1368 and G4QuadrangularFacet. 440 and G4QuadrangularFacet. 1369 - Updated unit test for G4ExtrudedSolid. 441 - Updated unit test for G4ExtrudedSolid. 1370 442 1371 26-Feb-2007, I.Hrivnacova (geom-specific-V08- 443 26-Feb-2007, I.Hrivnacova (geom-specific-V08-02-04) 1372 - Added specialised constructor for handling 444 - Added specialised constructor for handling Z-sections in G4ExtrudedSolid. 1373 - Cleared unecessary declaration of IsInside( 445 - Cleared unecessary declaration of IsInside() methods in G4TriangularFacet 1374 and G4QuadrangularFacet. 446 and G4QuadrangularFacet. 1375 - Updated unit test for G4ExtrudedSolid. 447 - Updated unit test for G4ExtrudedSolid. 1376 448 1377 15-Feb-2007, I.Hrivnacova (geom-specific-V08- 449 15-Feb-2007, I.Hrivnacova (geom-specific-V08-02-03) 1378 - Corrected caching of values in G4ExtrudedSo 450 - Corrected caching of values in G4ExtrudedSolid. 1379 - Bug fix in G4TriangularFacet::Intersect() t 451 - Bug fix in G4TriangularFacet::Intersect() to allow for correct update of 1380 'Distance' in condition. 452 'Distance' in condition. 1381 - Updated unit test for G4ExtrudedSolid. 453 - Updated unit test for G4ExtrudedSolid. 1382 454 1383 09-Feb-2007, G.Cosmo (geom-specific-V08-02-02 455 09-Feb-2007, G.Cosmo (geom-specific-V08-02-02) 1384 - Introduced new shape G4ExtrudedSolid, a sol 456 - Introduced new shape G4ExtrudedSolid, a solid representing the extrusion 1385 of an arbitrary polygon with fixed outline 457 of an arbitrary polygon with fixed outline in the two Z sections. 1386 New files: G4ExtrudedSolid[.hh.icc.cc] and 458 New files: G4ExtrudedSolid[.hh.icc.cc] and testG4ExtrudedSolid.cc 1387 by I.Hrivnacova. 459 by I.Hrivnacova. 1388 - G4TessellatedSolid: 460 - G4TessellatedSolid: 1389 o Made relevant solid's methods virtual, to 461 o Made relevant solid's methods virtual, to be used as base class. 1390 o Added implementation for GetSurfaceArea() 462 o Added implementation for GetSurfaceArea() and GetPointOnSurface() methods. 1391 o Added protection in SurfaceNormal() metho 463 o Added protection in SurfaceNormal() method in case of facet not found. 1392 o Check and return kOutside in Inside() if 464 o Check and return kOutside in Inside() if point out of solid's extent. 1393 465 1394 01-Feb-2007, G.Cosmo (geom-specific-V08-02-01 466 01-Feb-2007, G.Cosmo (geom-specific-V08-02-01) 1395 - Fix in G4PolyconeSide::DistanceAway() for c 467 - Fix in G4PolyconeSide::DistanceAway() for correct estimation of distance 1396 for the case of Phi sections (T.Nikitina). 468 for the case of Phi sections (T.Nikitina). 1397 Addresses problem report #598. 469 Addresses problem report #598. 1398 - Updated unit test for G4Polycone to conside 470 - Updated unit test for G4Polycone to consider new test case. 1399 471 1400 22-Jan-2007, G.Cosmo (geom-specific-V08-02-00 472 22-Jan-2007, G.Cosmo (geom-specific-V08-02-00) 1401 - Do not scale reducible-polygon in G4Polyhed 473 - Do not scale reducible-polygon in G4Polyhedra::Reset() method. 1402 The 'original_parameters' structure offered 474 The 'original_parameters' structure offered as input through the accessors 1403 are always assumed to be already scaled by 475 are always assumed to be already scaled by the 'cos(0.5*phiTotal/theNumSide)' 1404 factor. Addresses problem report #873. 476 factor. Addresses problem report #873. 1405 - Fixed warning printout in G4Polycone::Reset 477 - Fixed warning printout in G4Polycone::Reset(). 1406 478 1407 15-Nov-2006, J.Allison (geom-specific-V08-01- 479 15-Nov-2006, J.Allison (geom-specific-V08-01-04) 1408 - Fixed typo in G4Polycone::CreatePolyhedron( 480 - Fixed typo in G4Polycone::CreatePolyhedron() introduced by mistake in 1409 the last cleanup of the source code. 481 the last cleanup of the source code. 1410 482 1411 13-Nov-2006, G.Cosmo (geom-specific-V08-01-03 483 13-Nov-2006, G.Cosmo (geom-specific-V08-01-03) 1412 - Added concrete implementation of GetSurface 484 - Added concrete implementation of GetSurfaceArea() in G4Tet (M.H.Mendenhall). 1413 485 1414 08-Nov-2006, G.Cosmo (geom-specific-V08-01-02 486 08-Nov-2006, G.Cosmo (geom-specific-V08-01-02) 1415 - Cleared compilation warnings on SUN-CC for 487 - Cleared compilation warnings on SUN-CC for changes in the last tag. 1416 Fixed overloaded class variables in G4Polyh 488 Fixed overloaded class variables in G4Polyhedra and G4Polycone 1417 implementation of CreatePolyhedron(). 489 implementation of CreatePolyhedron(). 1418 490 1419 31-Oct-2006, J.Allison (geom-specific-V08-01- 491 31-Oct-2006, J.Allison (geom-specific-V08-01-01) 1420 - Implemented CreatePolyhedron() for G4Polyhe 492 - Implemented CreatePolyhedron() for G4Polyhedra and G4Polycone. 1421 493 1422 20-Oct-2006, G.Cosmo (geom-specific-V08-01-00 494 20-Oct-2006, G.Cosmo (geom-specific-V08-01-00) 1423 - Implemented caching mechanism for computati 495 - Implemented caching mechanism for computation of surface area in 1424 all solids and base classes, as done for th 496 all solids and base classes, as done for the geometrical volume 1425 computation. 497 computation. 1426 - Added missing fake constructor for object p 498 - Added missing fake constructor for object persistency to G4TessellatedSolid. 1427 499 1428 20-Jun-2006, G.Cosmo (geom-specific-V08-00-10 500 20-Jun-2006, G.Cosmo (geom-specific-V08-00-10) 1429 - Added accessor method GetVertices() in G4Te 501 - Added accessor method GetVertices() in G4Tet to return the list of 1430 vertices composing the solid. Required for 502 vertices composing the solid. Required for GDML persistency. 1431 503 1432 06-Jun-2006, G.Cosmo (geom-specific-V08-00-09 504 06-Jun-2006, G.Cosmo (geom-specific-V08-00-09) 1433 - Added protection against NaNs in G4Polycone 505 - Added protection against NaNs in G4PolyconeSide::Normal() for points at 1434 the origin. 506 the origin. 1435 507 1436 19-May-2006, G.Cosmo (geom-specific-V08-00-08 508 19-May-2006, G.Cosmo (geom-specific-V08-00-08) 1437 - Fix in G4Ellipsoid::SetZCuts() and G4Ellipt 509 - Fix in G4Ellipsoid::SetZCuts() and G4EllipticalTube::SetZCut() for usage 1438 of uninitialised variables. 510 of uninitialised variables. 1439 511 1440 08-May-2006, G.Cosmo (geom-specific-V08-00-07 512 08-May-2006, G.Cosmo (geom-specific-V08-00-07) 1441 - Cleared compilation warning on SUN-CC in G4 513 - Cleared compilation warning on SUN-CC in G4TriangularFacet.cc. 1442 514 1443 04-May-2006, G.Cosmo (geom-specific-V08-00-06 515 04-May-2006, G.Cosmo (geom-specific-V08-00-06) 1444 - Use different names for unit tests to avoid 516 - Use different names for unit tests to avoid confusing liblist ... 1445 517 1446 03-May-2006, G.Cosmo (geom-specific-V08-00-05 518 03-May-2006, G.Cosmo (geom-specific-V08-00-05) 1447 - Added four unit tests for G4TessellatedSoli 519 - Added four unit tests for G4TessellatedSolid. 1448 520 1449 24-Mar-2006, G.Cosmo (geom-specific-V08-00-04 521 24-Mar-2006, G.Cosmo (geom-specific-V08-00-04) 1450 - G4TwistedTubs: defined exact estimation for 522 - G4TwistedTubs: defined exact estimation for GetCubicVolume(), 1451 similar to the one adopted for G4Tubs. 523 similar to the one adopted for G4Tubs. 1452 524 1453 03-Mar-2006, G.Cosmo (geom-specific-V08-00-03 525 03-Mar-2006, G.Cosmo (geom-specific-V08-00-03) 1454 - Corrected boolean condition in G4Triangular 526 - Corrected boolean condition in G4TriangularFacet::Intersect(). 1455 Use '&&' operator in condition. Allows for 527 Use '&&' operator in condition. Allows for porting on WIN32-VC. 1456 528 1457 01-Mar-2006, G.Cosmo (geom-specific-V08-00-02 529 01-Mar-2006, G.Cosmo (geom-specific-V08-00-02) 1458 - Introducing first implementation of a tesse 530 - Introducing first implementation of a tessellated solid, contribution 1459 of P.R.Truscott (QinetiQ Ltd, UK). 531 of P.R.Truscott (QinetiQ Ltd, UK). 1460 New classes: G4QuadrangularFacet, G4Tessell 532 New classes: G4QuadrangularFacet, G4TessellatedSolid, G4TriangularFacet 1461 and G4VFacet. 533 and G4VFacet. 1462 - Requires tag "greps-V08-00-00". 534 - Requires tag "greps-V08-00-00". 1463 535 1464 12-Jan-2006, J.Allison (geom-specific-V08-00- 536 12-Jan-2006, J.Allison (geom-specific-V08-00-01) 1465 - G4TwistedTubs and G4VTwistedFaceted::Create 537 - G4TwistedTubs and G4VTwistedFaceted::CreatePolyhedron(): 1466 parameterised polyhedron mesh approximation 538 parameterised polyhedron mesh approximation in terms of 1467 G4Polyhedron::GetNumberOfRotationSteps(). 539 G4Polyhedron::GetNumberOfRotationSteps(). 1468 This is (a) more economical and (b) amenabl 540 This is (a) more economical and (b) amenable to user control. 1469 541 1470 19-Dec-2005, O.Link (geom-specific-V08-00-00) 542 19-Dec-2005, O.Link (geom-specific-V08-00-00) 1471 - Fixes in G4EllipticalCone: 543 - Fixes in G4EllipticalCone: 1472 o Changed GetPointOnSurface(), which was no 544 o Changed GetPointOnSurface(), which was not uniform in endcaps. 1473 o Bug fix in Inside(), which was not correc 545 o Bug fix in Inside(), which was not correct for the elliptic mantel. 1474 Made test similar as in G4EllipticTube. 546 Made test similar as in G4EllipticTube. 1475 o Several fixes in DistanceToIn/Out(): for 547 o Several fixes in DistanceToIn/Out(): for looping events (shortest 1476 distance was taken, even if 0); now compa 548 distance was taken, even if 0); now comparing the distance to the endcap 1477 and to the mantel and decide afterwards w 549 and to the mantel and decide afterwards which distance is shortest; 1478 added check n*v. 550 added check n*v. 1479 o The code is now "good" at 90%. Still 10% 551 o The code is now "good" at 90%. Still 10% wrong reconstructed events. 1480 e.g there is a problem is DistanceToOut() 552 e.g there is a problem is DistanceToOut(): missed the intersection 1481 (reconstruction took the encap instead of 553 (reconstruction took the encap instead of the mantel). 1482 554 1483 09-Dec-2005, O.Link 555 09-Dec-2005, O.Link 1484 - Fixed visibility of soft edges on the twist 556 - Fixed visibility of soft edges on the twisted solids. 1485 557 1486 08-Dec-2005, O.Link (geom-specific-V07-01-14) 558 08-Dec-2005, O.Link (geom-specific-V07-01-14) 1487 - Fixed bug in G4VTwistSurface::ComputeLocalP 559 - Fixed bug in G4VTwistSurface::ComputeLocalPoint(p) for point coordinate 1488 transformation. The bug affected only G4Twi 560 transformation. The bug affected only G4TwistTrapFlatSide. 1489 561 1490 06-Dec-2005, G.Cosmo (geom-specific-V07-01-13 562 06-Dec-2005, G.Cosmo (geom-specific-V07-01-13) 1491 - Fixed compilation errors on WIN32-VC for la 563 - Fixed compilation errors on WIN32-VC for last tag changes. 1492 564 1493 05-Dec-2005, O.Link (geom-specific-V07-01-12) 565 05-Dec-2005, O.Link (geom-specific-V07-01-12) 1494 - Added polyhedron definition for twisted sol 566 - Added polyhedron definition for twisted solids (G4TwistedTrap, 1495 G4TwistedTrd, G4TwistedBox, G4TwistedTubs) 567 G4TwistedTrd, G4TwistedBox, G4TwistedTubs) for visualization. 1496 568 1497 30-Nov-2005, G.Cosmo (geom-specific-V07-01-11 569 30-Nov-2005, G.Cosmo (geom-specific-V07-01-11) 1498 - Trivial fixes for porting on CLHEP-2.0.X se 570 - Trivial fixes for porting on CLHEP-2.0.X series. 1499 571 1500 18-Nov-2005, O.Link (geom-specific-V07-01-10) 572 18-Nov-2005, O.Link (geom-specific-V07-01-10) 1501 - Renamed classes for twisted solids set, to 573 - Renamed classes for twisted solids set, to identify them in the 1502 twisted framework. 574 twisted framework. 1503 575 1504 17-Nov-2005, O.Link 576 17-Nov-2005, O.Link 1505 - G4VTwistedFacted: 577 - G4VTwistedFacted: 1506 o corrected bug in DistanceToSurface() impl 578 o corrected bug in DistanceToSurface() implementation 1507 o added GetPointOnSurface() method 579 o added GetPointOnSurface() method 1508 - G4TwistedTubs: 580 - G4TwistedTubs: 1509 o added GetPointOnSurface() method 581 o added GetPointOnSurface() method 1510 - G4Hype: 582 - G4Hype: 1511 o corrected surface area calculation used i 583 o corrected surface area calculation used in GetPointOnSurface() 1512 << 584 1513 17-Nov-2005, G.Cosmo (geom-specific-V07-01-09 585 17-Nov-2005, G.Cosmo (geom-specific-V07-01-09) 1514 - More fixes required for direct object persi 586 - More fixes required for direct object persistency to G4Polycone, 1515 G4polyhedra and related utility classes. 587 G4polyhedra and related utility classes. 1516 588 1517 10-Nov-2005, J.Allison (geom-specific-V07-01- 589 10-Nov-2005, J.Allison (geom-specific-V07-01-08) 1518 - G4Tet: 590 - G4Tet: 1519 o Added implementation for GetPolyhedron() 591 o Added implementation for GetPolyhedron() and GetCubicVolume(). 1520 o Corrected order of specifying vertices in 592 o Corrected order of specifying vertices in CreatePolyhedron(). 1521 593 1522 09-Nov-2005, G.Cosmo (geom-specific-V07-01-07 594 09-Nov-2005, G.Cosmo (geom-specific-V07-01-07) 1523 - Added fake default constructor for all conc 595 - Added fake default constructor for all concrete solids and relevant 1524 utility classes, for usage of direct object 596 utility classes, for usage of direct object persistency. 1525 - Implemented changes to support CLHEP-2.0.X 597 - Implemented changes to support CLHEP-2.0.X for explicit usage of the 1526 CLHEP/HepGeom namespaces for CLHEP types. 598 CLHEP/HepGeom namespaces for CLHEP types. 1527 599 1528 07-Nov-2005, G.Cosmo (geom-specific-V07-01-06 600 07-Nov-2005, G.Cosmo (geom-specific-V07-01-06) 1529 - G4Ellipsoid: replaced call to hypot(x,y) wi 601 - G4Ellipsoid: replaced call to hypot(x,y) with std::sqrt(x*x+y*y) 1530 for porting to ISO standard. 602 for porting to ISO standard. 1531 603 1532 02-Nov-2005, G.Cosmo (geom-specific-V07-01-05 604 02-Nov-2005, G.Cosmo (geom-specific-V07-01-05) 1533 - G4Polyhedra, G4Polycone: 605 - G4Polyhedra, G4Polycone: 1534 o Protected case of generic construct for v 606 o Protected case of generic construct for visualization. 1535 o Introduced explicit flag and method IsGen 607 o Introduced explicit flag and method IsGeneric() to identify the kind 1536 of constructor used. 608 of constructor used. 1537 609 1538 29-Sep-2005, G.Cosmo (geom-specific-V07-01-04 610 29-Sep-2005, G.Cosmo (geom-specific-V07-01-04) 1539 - Fix in G4EllipticalCone methods DistanceToI 611 - Fix in G4EllipticalCone methods DistanceToIn() and DistanceToOut(). 1540 Added unit test for it (by D.Anninos). 612 Added unit test for it (by D.Anninos). 1541 - Coworks with tag "greps-V07-01-02". 613 - Coworks with tag "greps-V07-01-02". 1542 614 1543 10-Aug-2005, G.Cosmo (geom-specific-V07-01-03 615 10-Aug-2005, G.Cosmo (geom-specific-V07-01-03) 1544 - Introduced new solid G4EllipticalCone, a fu 616 - Introduced new solid G4EllipticalCone, a full cone with elliptical base 1545 that can be cut in Z (by D.Anninos). 617 that can be cut in Z (by D.Anninos). 1546 Coworks with tag "greps-V07-01-02". 618 Coworks with tag "greps-V07-01-02". 1547 619 1548 08-Aug-2005, D.Anninos (geom-specific-V07-01- 620 08-Aug-2005, D.Anninos (geom-specific-V07-01-02) 1549 - Added GetPointOnSurface() for all solids ex 621 - Added GetPointOnSurface() for all solids except twisted ones. 1550 The method returns a random point according 622 The method returns a random point according to a quasi-uniform 1551 distribution along the surface. 623 distribution along the surface. 1552 624 1553 18-Jul-2005, G.Cosmo (geom-specific-V07-01-01 625 18-Jul-2005, G.Cosmo (geom-specific-V07-01-01) 1554 - Fixed compilation warning on WIN32-VC for G 626 - Fixed compilation warning on WIN32-VC for G4VSurface.cc. 1555 - Not including G4Tet. 627 - Not including G4Tet. 1556 628 1557 06-Jul-2005, G.Cosmo (geom-specific-V07-01-00 629 06-Jul-2005, G.Cosmo (geom-specific-V07-01-00) 1558 - Added new shape G4Ellipsoid. Coworks with t 630 - Added new shape G4Ellipsoid. Coworks with tag "greps-V07-01-00". 1559 Contribution of G.Horton-Smith and G.Guerri 631 Contribution of G.Horton-Smith and G.Guerrieri. 1560 Code cleanup, and added default arguments f 632 Code cleanup, and added default arguments for cuts, added first 1561 implementation of unit test. 633 implementation of unit test. 1562 - Corrected unit tests for twisted-box/trap. 634 - Corrected unit tests for twisted-box/trap. 1563 - Not including G4Tet. 635 - Not including G4Tet. 1564 636 1565 15-Jun-2005, J.Apostolakis 637 15-Jun-2005, J.Apostolakis 1566 - Introduced new solid G4Tet, contribution of 638 - Introduced new solid G4Tet, contribution of M.H.Mendenhall 1567 and R.A.Weller, Vanderbilt University, USA. 639 and R.A.Weller, Vanderbilt University, USA. 1568 640 1569 29-Apr-2005, O.Link (geom-specific-V07-00-04) 641 29-Apr-2005, O.Link (geom-specific-V07-00-04) 1570 - G4TwistedSurface: fixed bug in GetAreaCode( 642 - G4TwistedSurface: fixed bug in GetAreaCode() affecting G4TwistedTubs. 1571 643 1572 04-Apr-2005, G.Cosmo (geom-specific-V07-00-03 644 04-Apr-2005, G.Cosmo (geom-specific-V07-00-03) 1573 - Added test for Number-Of-Rotation-Steps in 645 - Added test for Number-Of-Rotation-Steps in GetPolyhedron() for 1574 G4VCSGfaceted, G4Hype and G4EllipticalTube 646 G4VCSGfaceted, G4Hype and G4EllipticalTube (by J.Allison). 1575 Requires tag "greps-V07-00-02". 647 Requires tag "greps-V07-00-02". 1576 - Added elementary implementation of CreatePo 648 - Added elementary implementation of CreatePolyhedron() for G4Hype, 1577 G4TwistedBox, G4TwistedTubs, G4TwistedTrd, 649 G4TwistedBox, G4TwistedTubs, G4TwistedTrd, G4TwistedTrap. 1578 - Some code cleanup. 650 - Some code cleanup. 1579 651 1580 18-Mar-2005, O.Link (geom-specific-V07-00-02) 652 18-Mar-2005, O.Link (geom-specific-V07-00-02) 1581 - New generic framework for twisted solids G4 653 - New generic framework for twisted solids G4TwistedBox, G4TwistedTrd and 1582 G4TwistedTrap: inheriting now from the base 654 G4TwistedTrap: inheriting now from the base class G4VTwistedFaceted. 1583 - Extended G4TwistedTrap to support setups wi 655 - Extended G4TwistedTrap to support setups with different trapezoidal 1584 endcaps with centres not necessarily on a l 656 endcaps with centres not necessarily on a line parallel to the z axis. 1585 - Added G4TwistedTrd and general G4TwistedTra 657 - Added G4TwistedTrd and general G4TwistedTrap as test cases in test. 1586 658 1587 03-Mar-2005, J.Allison 659 03-Mar-2005, J.Allison 1588 - Changed AddThis() to AddSolid() for all sol 660 - Changed AddThis() to AddSolid() for all solids in the implementation 1589 of DescribeYourselfTo(G4VGraphicsScene&). 661 of DescribeYourselfTo(G4VGraphicsScene&). 1590 662 1591 01-Mar-2005, O.Link (geom-specific-V07-00-01) 663 01-Mar-2005, O.Link (geom-specific-V07-00-01) 1592 - Fixed compilation warnings on WIN32-VC for 664 - Fixed compilation warnings on WIN32-VC for G4VSurface.cc. 1593 665 1594 14-Feb-2005, O.Link (geom-specific-V07-00-00) 666 14-Feb-2005, O.Link (geom-specific-V07-00-00) 1595 - Use new polynom approximations based on new 667 - Use new polynom approximations based on new solver based on Jenkins-Traub 1596 algorithm, for twisted-box and twisted-trap 668 algorithm, for twisted-box and twisted-trap. 1597 - Fixed bug in the usage of 'fmod' and adopt 669 - Fixed bug in the usage of 'fmod' and adopt special treatment for 'parallel' 1598 events in G4TwistedBoxSide and G4TwistedTra 670 events in G4TwistedBoxSide and G4TwistedTrapSide. 1599 - Coworks with tag "global-V07-00-00". 671 - Coworks with tag "global-V07-00-00". 1600 672 1601 08-Dec-2004, O.Link (geom-specific-V06-02-07) 673 08-Dec-2004, O.Link (geom-specific-V06-02-07) 1602 - Extensions to twisted box/trap shapes to co 674 - Extensions to twisted box/trap shapes to consider all 4 solutions 1603 for determining correct intersections. 675 for determining correct intersections. 1604 676 1605 29-Nov-2004, O.Link (geom-specific-V06-02-06) 677 29-Nov-2004, O.Link (geom-specific-V06-02-06) 1606 - G4TwistedTrapSide, G4TwistedBoxSide: improv 678 - G4TwistedTrapSide, G4TwistedBoxSide: improved (analytical) version 1607 of GetPhiUAtX() method. 679 of GetPhiUAtX() method. 1608 680 1609 24-Nov-2004, O.Link (geom-specific-V06-02-05) 681 24-Nov-2004, O.Link (geom-specific-V06-02-05) 1610 - Fixed bug in description of twisted trapezo 682 - Fixed bug in description of twisted trapezoid side. 1611 683 1612 12-Nov-2004, O.Link (geom-specific-V06-02-04) 684 12-Nov-2004, O.Link (geom-specific-V06-02-04) 1613 - Added G4TwistedBox - a twisted box with tw 685 - Added G4TwistedBox - a twisted box with twist angle alpha, 1614 length a/2,b/2,L/2. 686 length a/2,b/2,L/2. 1615 - Added G4TwistedTrap - a twisted trapezoid ( 687 - Added G4TwistedTrap - a twisted trapezoid (still in debug state) 1616 - Changed in G4VSurface.icc: << 688 - Changed in G4VSurface.icc: 1617 - GetNeighbours(): corrected axiscode (wa 689 - GetNeighbours(): corrected axiscode (was returning the wrong neighbours) 1618 - SetNeighbours(): fixed problem #685 (in 690 - SetNeighbours(): fixed problem #685 (index out of range) 1619 - Added tests for G4TwistedBox and G4TwistedT 691 - Added tests for G4TwistedBox and G4TwistedTrap in specific/test. 1620 - Added G4TwistedBox and G4TwistedTrap in sys 692 - Added G4TwistedBox and G4TwistedTrap in system testing, test10. 1621 693 1622 22-Oct-2004, D.C.Williams (geom-specific-V06- 694 22-Oct-2004, D.C.Williams (geom-specific-V06-02-03) 1623 - Fix in G4PolyconeSide::Inside for points at 695 - Fix in G4PolyconeSide::Inside for points at radius = 0 for phi slides 1624 solids with an inner radius. Addresses prob 696 solids with an inner radius. Addresses problem report #598. 1625 697 1626 10-Oct-2004, J.Allison (geom-specific-V06-02- 698 10-Oct-2004, J.Allison (geom-specific-V06-02-02) 1627 - Added GetPolyhedron, a smart access functio 699 - Added GetPolyhedron, a smart access function that creates a G4Polyhedron 1628 on request and stores for future access. A 700 on request and stores for future access. A null pointer means "not 1629 available". 701 available". 1630 702 1631 22-Sep-2004, G.Cosmo (geom-specific-V06-02-01 703 22-Sep-2004, G.Cosmo (geom-specific-V06-02-01) 1632 - Added implementation of GetCubicVolume() wi 704 - Added implementation of GetCubicVolume() with cashing mechanism for 1633 solids: G4EllipticalTube, G4Hype, G4Polyhed 705 solids: G4EllipticalTube, G4Hype, G4Polyhedra, G4Polycone, G4TwistedTubs. 1634 706 1635 01-Sep-2004, D.C.Williams (geom-specific-V06- 707 01-Sep-2004, D.C.Williams (geom-specific-V06-02-00) 1636 - G4VCSGfaceted: fix for rare anomalous situa 708 - G4VCSGfaceted: fix for rare anomalous situation in which 1637 DistanceToOut(p,v,..) will report kInfinity 709 DistanceToOut(p,v,..) will report kInfinity, make an additional check 1638 for the point p on the surface, in which ca 710 for the point p on the surface, in which case will report zero. 1639 Addresses problem observed in G4Polyhedra a 711 Addresses problem observed in G4Polyhedra and reported in #650. 1640 712 1641 07-Jun-2004, G.Cosmo (geom-specific-V06-01-04 713 07-Jun-2004, G.Cosmo (geom-specific-V06-01-04) 1642 - Fixed compilation problem in G4TwistedSurfa 714 - Fixed compilation problem in G4TwistedSurface.cc on WIN32-VC. 1643 715 1644 28-May-2004, G.Cosmo (geom-specific-V06-01-03 716 28-May-2004, G.Cosmo (geom-specific-V06-01-03) 1645 - Fixed archiving problem on WIN32-VC7: repla 717 - Fixed archiving problem on WIN32-VC7: replaced structs with classes 1646 in G4VSurface. 718 in G4VSurface. 1647 - Replaced misleading names for masks in G4VS 719 - Replaced misleading names for masks in G4VSurface and moved inlined 1648 methods of nested classes to .cc. 720 methods of nested classes to .cc. 1649 721 1650 25-May-2004, G.Cosmo (geom-specific-V06-01-02 722 25-May-2004, G.Cosmo (geom-specific-V06-01-02) 1651 - Fixed compilation problem on SUN-CC. Made E 723 - Fixed compilation problem on SUN-CC. Made EValidate enum public in 1652 G4VSurface.hh. 724 G4VSurface.hh. 1653 725 1654 24-May-2004, G.Cosmo (geom-specific-V06-01-01 726 24-May-2004, G.Cosmo (geom-specific-V06-01-01) 1655 - Removed compilation warnings and minor clea 727 - Removed compilation warnings and minor cleanup... 1656 728 1657 19-May-2004, O.Link (geom-specific-V06-01-00) 729 19-May-2004, O.Link (geom-specific-V06-01-00) 1658 - First implementation of a framework for twi 730 - First implementation of a framework for twisted surfaces, integrated from 1659 the original version of Kotoyo Hoshina (hos 731 the original version of Kotoyo Hoshina (hoshina@hepburn.s.chiba-u.ac.jp) 1660 implemented in the 'Jupiter' application. 732 implemented in the 'Jupiter' application. 1661 o Includes new specific twisted shape: G4Tw 733 o Includes new specific twisted shape: G4TwistedTubs. 1662 o New classes: G4VSurface, G4TwistedSurface 734 o New classes: G4VSurface, G4TwistedSurface, G4HyperbolicSurface, 1663 G4FlatSurface, G4TwistedTubs 735 G4FlatSurface, G4TwistedTubs. 1664 o Cleanup of original code (debugging messa 736 o Cleanup of original code (debugging messages, compiler errors, migration 1665 of g4std to new convention...) 737 of g4std to new convention...) 1666 o New organisation of class G4TwistedTubs: 738 o New organisation of class G4TwistedTubs: now independent of XXXSurface; 1667 removed backpointer 'fSolid' from XXXSurf 739 removed backpointer 'fSolid' from XXXSurface to G4TwistedTubs. 1668 o New form of constructors in G4TwistedSurf 740 o New form of constructors in G4TwistedSurface, G4HyperbolicSurface and 1669 G4FlatSurface. 741 G4FlatSurface. 1670 o Change in G4TwistedSurface::DistanceToIn( 742 o Change in G4TwistedSurface::DistanceToIn(p,v,...): roundoff correction. 1671 743 1672 12-Jan-2004, G.Cosmo (geom-specific-V06-00-00 744 12-Jan-2004, G.Cosmo (geom-specific-V06-00-00) 1673 - G4PolyhedraSide.cc: fixed bug in which part 745 - G4PolyhedraSide.cc: fixed bug in which particles could "leak" out the 1674 center of a face if inner radius = 0. 746 center of a face if inner radius = 0. 1675 Fixes problem report #547. (D.Williams) 747 Fixes problem report #547. (D.Williams) 1676 748 1677 22-Nov-2003, G.Cosmo (geom-specific-V05-02-07 749 22-Nov-2003, G.Cosmo (geom-specific-V05-02-07) 1678 - Fixed upper bound for protection check intr 750 - Fixed upper bound for protection check introduced in G4Polycone and 1679 G4Polyhedra constructors. 751 G4Polyhedra constructors. 1680 752 1681 17-Nov-2003, G.Cosmo (geom-specific-V05-02-06 753 17-Nov-2003, G.Cosmo (geom-specific-V05-02-06) 1682 - Added protections in G4Polycone and G4Polyh 754 - Added protections in G4Polycone and G4Polyhedra constructors for 1683 invalid constructs with no contiguous segme 755 invalid constructs with no contiguous segments in Z planes as input. 1684 756 1685 04-Nov-2003, G.Cosmo (geom-specific-V05-02-05 757 04-Nov-2003, G.Cosmo (geom-specific-V05-02-05) 1686 - Added SetOriginalParameters() method to G4P 758 - Added SetOriginalParameters() method to G4Polycone and G4Polyhedra. 1687 759 1688 03-Nov-2003, G.Cosmo (geom-specific-V05-02-04 760 03-Nov-2003, G.Cosmo (geom-specific-V05-02-04) 1689 - Code cleanup and headers inclusion review 761 - Code cleanup and headers inclusion review 1690 (replaced by forward declarations where nec 762 (replaced by forward declarations where necessary). 1691 763 1692 28-Oct-2003, G.Cosmo (geom-specific-V05-02-03 764 28-Oct-2003, G.Cosmo (geom-specific-V05-02-03) 1693 - Migrated to new G4Exception scheme. 765 - Migrated to new G4Exception scheme. 1694 766 1695 20-Oct-2003, G.Cosmo (geom-specific-V05-02-02 767 20-Oct-2003, G.Cosmo (geom-specific-V05-02-02) 1696 - Added Reset() method in G4Polycone and G4Po 768 - Added Reset() method in G4Polycone and G4Polyhedra to allow 1697 recalculation and reshape of the solid if n 769 recalculation and reshape of the solid if new original_parameters 1698 are provided. 770 are provided. 1699 771 1700 30-Sep-2003, G.Cosmo (geom-specific-V05-02-01 772 30-Sep-2003, G.Cosmo (geom-specific-V05-02-01) 1701 - Updated GNUmakefile for unit tests, accordi 773 - Updated GNUmakefile for unit tests, according to new structure 1702 introduced in "geometry-V05-02-00". 774 introduced in "geometry-V05-02-00". 1703 775 1704 16-Jun-2003, G.Cosmo (geom-specific-V05-02-00 776 16-Jun-2003, G.Cosmo (geom-specific-V05-02-00) 1705 - Added accessors to original_parameters for 777 - Added accessors to original_parameters for G4Polycone and G4Polyhedra. 1706 Made G4PolyconeHistorical and G4PolyhedraHi 778 Made G4PolyconeHistorical and G4PolyhedraHistorical classes in global 1707 scope (temporary solution). 779 scope (temporary solution). 1708 780 1709 28-Mar-2003, G.Cosmo (geom-specific-V05-00-00 781 28-Mar-2003, G.Cosmo (geom-specific-V05-00-00) 1710 - Fixed initialisation of base class in copy 782 - Fixed initialisation of base class in copy contructor for: 1711 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraS 783 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraSide. 1712 - Fixed trivial pedantic warnings on G4Polyco 784 - Fixed trivial pedantic warnings on G4Polycone and G4Polyhedra. 1713 785 1714 30-Oct-2002, G.Cosmo (geom-specific-V04-01-01 786 30-Oct-2002, G.Cosmo (geom-specific-V04-01-01) 1715 - Fixed un-initialised data members in constr 787 - Fixed un-initialised data members in constructors of classes: 1716 G4ClippablePolygon, G4EnclosingCylinder, G4 788 G4ClippablePolygon, G4EnclosingCylinder, G4PolyconeSide, 1717 G4ReduciblePolygon, G4VCSGfaceted. 789 G4ReduciblePolygon, G4VCSGfaceted. 1718 790 1719 28-Oct-2002, G.Cosmo (geom-specific-V04-01-00 791 28-Oct-2002, G.Cosmo (geom-specific-V04-01-00) 1720 - Added implementation of StreamInfo() to com 792 - Added implementation of StreamInfo() to comply with new interface for 1721 G4VSolid in "geommng-V04-01-03". 793 G4VSolid in "geommng-V04-01-03". 1722 - Created .icc files for G4EllipticalTube, G4 794 - Created .icc files for G4EllipticalTube, G4Polyhedra and G4Polycone. 1723 - Some cosmetic changes to code formatting: r 795 - Some cosmetic changes to code formatting: removed <TAB> characters and adopt 1724 uniform code indentation. 796 uniform code indentation. 1725 797 1726 08-May-2002, J.Allison (geom-solids-specific- 798 08-May-2002, J.Allison (geom-solids-specific-V04-00-01) 1727 - Implemented G4EllipticalTube::CreatePolyhed 799 - Implemented G4EllipticalTube::CreatePolyhedron. 1728 800 1729 10-Jan-2002, G.Cosmo (geom-solids-specific-V0 801 10-Jan-2002, G.Cosmo (geom-solids-specific-V04-00-00) 1730 - Updated unit tests. 802 - Updated unit tests. 1731 803 1732 20-Apr-2001, G.Cosmo (geom-solids-specific-V0 804 20-Apr-2001, G.Cosmo (geom-solids-specific-V03-01-00) 1733 - Migration to STL vector: 805 - Migration to STL vector: 1734 o In G4ClippablePolygon, migrated G4ThreeVe 806 o In G4ClippablePolygon, migrated G4ThreeVectorList typedef and 1735 made private to class. 807 made private to class. 1736 << 808 1737 03-Apr-2001, D.Williams (geom-solids-specifi 809 03-Apr-2001, D.Williams (geom-solids-specific-V03-00-01) 1738 ----------------------- 810 ----------------------- 1739 - G4IntersectingCone.cc: make small adjustmen 811 - G4IntersectingCone.cc: make small adjustment to help with roundoff error 1740 in LineHitsCone1() and LineHitsCone2(). 812 in LineHitsCone1() and LineHitsCone2(). 1741 813 1742 08-Jan-2001, D.Williams (geom-solids-specifi 814 08-Jan-2001, D.Williams (geom-solids-specific-V03-00-00) 1743 ----------------------- 815 ----------------------- 1744 - G4Hype.cc: Added protecton against zero v.z 816 - G4Hype.cc: Added protecton against zero v.z in DistanceToOut. 1745 817 1746 20-Nov-2000, G.Cosmo (geom-solids-specifi 818 20-Nov-2000, G.Cosmo (geom-solids-specific-V02-00-04) 1747 --------------------- 819 --------------------- 1748 - Fixes to remove warnings from "-Wall -ansi 820 - Fixes to remove warnings from "-Wall -ansi -pedantic" g++ compiler options: 1749 o commented out variables declared and not 821 o commented out variables declared and not used. 1750 o fixed declaration of variables used befor 822 o fixed declaration of variables used before being initialised. 1751 o fixed order of initialisation of member d 823 o fixed order of initialisation of member data in constructors. 1752 o fixed usage of unsigned-int (size_t) for 824 o fixed usage of unsigned-int (size_t) for array indeces. 1753 825 1754 13-Nov-2000, G.Cosmo (geom-solids-specifi 826 13-Nov-2000, G.Cosmo (geom-solids-specific-V02-00-03) 1755 -------------------- 827 -------------------- 1756 - Added definition of empty constructor for G 828 - Added definition of empty constructor for G4ClippablePolygon which 1757 went lost by mistake... 829 went lost by mistake... 1758 830 1759 02-Nov-2000, G.Cosmo (geom-solids-specifi 831 02-Nov-2000, G.Cosmo (geom-solids-specific-V02-00-02) 1760 -------------------- 832 -------------------- 1761 - QA code revision and cleanup (+fixes from C 833 - QA code revision and cleanup (+fixes from CodeWizard filtering): 1762 o Avoid inline virtual methods. 834 o Avoid inline virtual methods. 1763 o General cosmetics for Software Reference 835 o General cosmetics for Software Reference Manual. 1764 836 1765 23-Oct-2000, D.Williams (geom-solids-specifi 837 23-Oct-2000, D.Williams (geom-solids-specific-V02-00-01) 1766 ----------------------- 838 ----------------------- 1767 - G4IntersectingCone.cc: the check for a zero 839 - G4IntersectingCone.cc: the check for a zero radical has been adjusted to be 1768 less sensitive to round off error in LineHi 840 less sensitive to round off error in LineHitsCone1(), LineHitsCone2(). 1769 This fixes a problem discovered in BaBar. 841 This fixes a problem discovered in BaBar. 1770 842 1771 12-Sep-2000, G.Cosmo (geom-solids-specific-V 843 12-Sep-2000, G.Cosmo (geom-solids-specific-V02-00-00) 1772 -------------------- 844 -------------------- 1773 - Organised comments to headers for Software 845 - Organised comments to headers for Software Reference Manual. 1774 846 1775 27-Jun-2000, G.Cosmo (geom-solids-specific-V 847 27-Jun-2000, G.Cosmo (geom-solids-specific-V01-01-02) 1776 -------------------- 848 -------------------- 1777 - G4Polycone[.hh.cc]: better fix for bug-repo 849 - G4Polycone[.hh.cc]: better fix for bug-report #110. 1778 Removed struct and replaced with class. 850 Removed struct and replaced with class. 1779 851 1780 26-Jun-2000, G.Cosmo (geom-solids-specific-V 852 26-Jun-2000, G.Cosmo (geom-solids-specific-V01-01-01) 1781 -------------------- 853 -------------------- 1782 - G4Polycone.cc: fixed memory leak by invokin 854 - G4Polycone.cc: fixed memory leak by invoking destruction of member 1783 enclosingCylinder, which was not cleaned up 855 enclosingCylinder, which was not cleaned up in the destructor. 1784 This fixes problem report #107. 856 This fixes problem report #107. 1785 - G4Polycone.hh: added forward declaration of 857 - G4Polycone.hh: added forward declaration of struct G4PolyconeHistorical 1786 and made it friend, for porting on KCC --st 858 and made it friend, for porting on KCC --strict. This fixes report #110. 1787 - G4Polyhedra.hh: fixed typo in method name. 859 - G4Polyhedra.hh: fixed typo in method name. Changed GetNumSIde() to 1788 GetNumSide(). This fixes problem report #10 860 GetNumSide(). This fixes problem report #105. 1789 861 1790 08-Jun-2000, G.Gracia 862 08-Jun-2000, G.Gracia 1791 --------------------- 863 --------------------- 1792 - G4VCSGfaceted.cc: fix for Win/NT in functio 864 - G4VCSGfaceted.cc: fix for Win/NT in function GetExtent(). 1793 865 1794 27-Apr-2000, G.Cosmo 866 27-Apr-2000, G.Cosmo 1795 -------------------- 867 -------------------- 1796 - Removed dependency over the CSG domain in G 868 - Removed dependency over the CSG domain in GNUmakefile. 1797 869 1798 18-Apr-2000, D.Williams 870 18-Apr-2000, D.Williams 1799 ----------------------- 871 ----------------------- 1800 - Removed meaningless "const" specifiers from 872 - Removed meaningless "const" specifiers from methods in G4ClippablePolygon, 1801 and G4EllipticalTube. 873 and G4EllipticalTube. 1802 - G4EllipticalTube, G4Hype and G4VCSGfaceted 874 - G4EllipticalTube, G4Hype and G4VCSGfaceted now inherit directly 1803 from G4VSolid (before was G4CSGSolid). 875 from G4VSolid (before was G4CSGSolid). 1804 - Reintroduced GetExtent() in G4EllipticalTub 876 - Reintroduced GetExtent() in G4EllipticalTube, G4Hype and G4VCSGfaceted 1805 (in principle, not needed). 877 (in principle, not needed). 1806 - Modified assertations in unit test testG4Hy 878 - Modified assertations in unit test testG4Hype.cc. 1807 879 1808 11-Apr-2000, J.Allison 880 11-Apr-2000, J.Allison 1809 ---------------------- 881 ---------------------- 1810 - Removed implementations of GetExtent in mos 882 - Removed implementations of GetExtent in most sub-classes of G4VSolid (a 1811 default implementation exists in G4VSolid). 883 default implementation exists in G4VSolid). 1812 - All implementations of DescribeYourselfTo ( 884 - All implementations of DescribeYourselfTo (G4VGraphicsScene& scene) const 1813 now correctly written: scene.AddThis(*this) 885 now correctly written: scene.AddThis(*this). 1814 886 1815 05-Apr-2000, G.Cosmo (geom-solids-specific- 887 05-Apr-2000, G.Cosmo (geom-solids-specific-V01-01-00) 1816 -------------------- 888 -------------------- 1817 - Restructured solids/CSG domain, by moving t 889 - Restructured solids/CSG domain, by moving to "specific" the following 1818 classes: G4ClippablePolygon, G4EnclosingCyl 890 classes: G4ClippablePolygon, G4EnclosingCylinder, G4Hype, G4PolyPhiFace, 1819 G4Polycone, G4PolyconeSide, G4Polyhedra, G4 891 G4Polycone, G4PolyconeSide, G4Polyhedra, G4PolyhedraSide, G4ReduciblePolygon, 1820 G4IntersectingCone, G4SolidExtentList, G4VC 892 G4IntersectingCone, G4SolidExtentList, G4VCSGface, G4VCSGfaceted. 1821 The new module's library for "specific" is 893 The new module's library for "specific" is now called 'G4specsolids'. 1822 - Created specific/test directory and moved t 894 - Created specific/test directory and moved testG4Hype.cc and testG4Polycone,cc 1823 from CSG/test. 895 from CSG/test. 1824 - Organised class description comments for th 896 - Organised class description comments for the Software Reference Manual 1825 and added CVS headers to files. 897 and added CVS headers to files. 1826 898 1827 29-Mar-2000, D.Williams 899 29-Mar-2000, D.Williams 1828 ----------------------- 900 ----------------------- 1829 - Added first implementation of G4EllipticalT 901 - Added first implementation of G4EllipticalTube. 1830 It defines a simple elliptical tube, as in 902 It defines a simple elliptical tube, as in geant3 "ELTU". 1831 Files introduced: G4EllipticalTube[.hh.cc]. 903 Files introduced: G4EllipticalTube[.hh.cc]. 1832 904 1833 25-Mar-2000, G.Cosmo 905 25-Mar-2000, G.Cosmo 1834 -------------------- 906 -------------------- 1835 - History file created. 907 - History file created.