| Geant4 Cross Reference |
1 # Category geom-specific History 1 # Category geom-specific History
2 2
3 See `CONTRIBUTING.rst` for details of **requir 3 See `CONTRIBUTING.rst` for details of **required** info/format for each entry,
4 which **must** added in reverse chronological 4 which **must** added in reverse chronological order (newest at the top).
5 It must **not** be used as a substitute for wr 5 It must **not** be used as a substitute for writing good git commit messages!
6 6
7 ---------------------------------------------- 7 -------------------------------------------------------------------------------
8 8
9 ## 2024-10-01 Evgueni Tcherniaev (geom-specifi << 9 ## 2024-02-01 Gabriele Cosmo (geom-specific-V11-01-07)
10 - G4GenericTrap: Fixed minor defect reported b <<
11 <<
12 ## 2024-07-18 Alvaro Tolosa-Delgado (geom-spec <<
13 - Remove internal state of G4TwistedTubs and G <<
14 <<
15 ## 2024-07-10 Evgueni Tcherniaev (geom-specifi <<
16 - G4ExtrudedSolid: Fixed defects reported by C <<
17 <<
18 ## 2024-07-08 Gabriele Cosmo (geom-specific-V1 <<
19 - Fixed reported Coverity defect; in G4Voxeliz <<
20 plain vector copy in methods BuildReduceVoxe <<
21 BuildBoundaries() and CreateMiniVoxels(..). <<
22 <<
23 ## 2024-05-29 Evgueni Tcherniaev (geom-specifi <<
24 - Added new methods GetNumOfConstituents() and <<
25 <<
26 ## 2024-05-27 Evgueni Tcherniaev (geom-specifi <<
27 - Completely revised G4GeneriTrap, it addresse <<
28 <<
29 ## 2024-05-26 Evgueni Tcherniaev (geom-specifi <<
30 - New testG4GenericTrap.cc <<
31 <<
32 ## 2024-04-02 Gabriele Cosmo (geom-specific-V1 <<
33 - Applied trivial clang-tidy fixes to classes, <<
34 'default' keywords. <<
35 <<
36 ## 2024-02-01 Gabriele Cosmo (geom-specific-V1 <<
37 - Use std::size_t for array sizes in G4Polyhed 10 - Use std::size_t for array sizes in G4PolyhedraSide and G4PolyPhiFace.
38 11
39 ## 2023-07-10 Evgueni Tcherniaev (geom-specifi 12 ## 2023-07-10 Evgueni Tcherniaev (geom-specific-V11-01-06)
40 - Fixed bounding box calculation in G4VTwisted 13 - Fixed bounding box calculation in G4VTwistedFaceted::BoundingLimits().
41 14
42 ## 2023-06-16 Stephan Hageboeck (geom-specific 15 ## 2023-06-16 Stephan Hageboeck (geom-specific-V11-01-05)
43 - Fix an uninitialised value in G4VCSGfaceted: 16 - Fix an uninitialised value in G4VCSGfaceted::SurfaceNormal().
44 17
45 ## 2023-06-12 Gabriele Cosmo (geom-specific-V1 18 ## 2023-06-12 Gabriele Cosmo (geom-specific-V11-01-04)
46 - Use const iterator in G4Voxelizer::GetPointV 19 - Use const iterator in G4Voxelizer::GetPointVoxel().
47 - Fixed use of index in G4Tet::GetPointOnSurfa 20 - Fixed use of index in G4Tet::GetPointOnSurface().
48 21
49 ## 2023-05-10 Gabriele Cosmo (geom-specific-V1 22 ## 2023-05-10 Gabriele Cosmo (geom-specific-V11-01-03)
50 - Applied clang-tidy fixes (readability, moder 23 - Applied clang-tidy fixes (readability, modernization, performance, ...).
51 24
52 ## 2023-03-20 Gabriele Cosmo (geom-specific-V1 25 ## 2023-03-20 Gabriele Cosmo (geom-specific-V11-01-02)
53 - Fixed more potential uninitialised values in 26 - Fixed more potential uninitialised values in G4PolyconeSide,
54 G4SolidExtentList and G4VTwistSurface. 27 G4SolidExtentList and G4VTwistSurface.
55 28
56 ## 2023-03-13 Gabriele Cosmo (geom-specific-V1 29 ## 2023-03-13 Gabriele Cosmo (geom-specific-V11-01-01)
57 - Fixed potential uninitialised value for boun 30 - Fixed potential uninitialised value for boundary type in
58 G4VTwistSurface::GetBoundaryAtPZ(). 31 G4VTwistSurface::GetBoundaryAtPZ().
59 32
60 ## 2023-01-02 Evgueni Tcherniaev (geom-specifi 33 ## 2023-01-02 Evgueni Tcherniaev (geom-specific-V11-01-00)
61 - G4QuadrangularFacet: Fixed warning message 34 - G4QuadrangularFacet: Fixed warning message
62 35
63 ## 2022-11-10 Gabriele Cosmo (geom-specific-V1 36 ## 2022-11-10 Gabriele Cosmo (geom-specific-V11-00-10)
64 - Fixed compilation warnings for implicit type 37 - Fixed compilation warnings for implicit type conversions on macOS/XCode 14.1.
65 38
66 ## 2022-10-05 Gabriele Cosmo (geom-specific-V1 39 ## 2022-10-05 Gabriele Cosmo (geom-specific-V11-00-09)
67 - Fixed compilation warnings in Intel/icx comp 40 - Fixed compilation warnings in Intel/icx compiler for variables set
68 but never used. 41 but never used.
69 42
70 ## 2022-04-03 Evgueni Tcherniaev (geom-specifi 43 ## 2022-04-03 Evgueni Tcherniaev (geom-specific-V11-00-08)
71 - G4GenericTrap.cc, G4UGenericTrap.cc, G4UExtr 44 - G4GenericTrap.cc, G4UGenericTrap.cc, G4UExtrudedSolid.cc,
72 G4TessellatedSolid.cc, G4TessellatedSolid.cc 45 G4TessellatedSolid.cc, G4TessellatedSolid.cc:
73 revision of CreatePolyhedron() 46 revision of CreatePolyhedron()
74 47
75 ## 2022-02-04 Evgueni Tcherniaev (geom-specifi 48 ## 2022-02-04 Evgueni Tcherniaev (geom-specific-V11-00-07)
76 - G4VTwistedFaceted: used numerical evaluation 49 - G4VTwistedFaceted: used numerical evaluation of a single
77 integral to calculate lateral face surface a 50 integral to calculate lateral face surface area
78 51
79 ## 2022-02-01 Evgueni Tcherniaev (geom-specifi 52 ## 2022-02-01 Evgueni Tcherniaev (geom-specific-V11-00-06)
80 - G4ExtrudedSolid, G4UExtrudedSolid: added def 53 - G4ExtrudedSolid, G4UExtrudedSolid: added default values for
81 parameters in the constructor with two z-sec 54 parameters in the constructor with two z-sections
82 - G4ExtrudedSolid::ZSection, G4UExtrudedSolid: 55 - G4ExtrudedSolid::ZSection, G4UExtrudedSolid::ZSection:
83 added default constructor 56 added default constructor
84 57
85 ## 2022-01-26 Evgueni Tcherniaev (geom-specifi 58 ## 2022-01-26 Evgueni Tcherniaev (geom-specific-V11-00-05)
86 - G4GenericTrap::GetCubicVolume(): calculation 59 - G4GenericTrap::GetCubicVolume(): calculation of volume
87 using analytical expression; removed private 60 using analytical expression; removed private function
88 GetFaceCubicVolume(); 61 GetFaceCubicVolume();
89 - G4GenericTrap::GetSurfaceArea(): improved ca 62 - G4GenericTrap::GetSurfaceArea(): improved calculation
90 of the area of lateral faces; private functi 63 of the area of lateral faces; private functions
91 GetFaceSurfaceArea(), GetTwistedFaceSurfaceA 64 GetFaceSurfaceArea(), GetTwistedFaceSurfaceArea()
92 replaced with private function GetLateralFac 65 replaced with private function GetLateralFaceArea()
93 66
94 ## 2022-01-21 Evgueni Tcherniaev (geom-specifi 67 ## 2022-01-21 Evgueni Tcherniaev (geom-specific-V11-00-04)
95 - G4Ellipsoid::LateralSurfaceArea(): Enhanced 68 - G4Ellipsoid::LateralSurfaceArea(): Enhanced calculation of
96 the lateral surface area 69 the lateral surface area
97 70
98 ## 2022-01-11 Evgueni Tcherniaev (geom-specifi 71 ## 2022-01-11 Evgueni Tcherniaev (geom-specific-V11-00-03)
99 - G4VTwistedFaceted: fCubicVolume, fSurfaceAre 72 - G4VTwistedFaceted: fCubicVolume, fSurfaceArea made protected,
100 GetCubicVolume(), GetSurfaceArea() moved to 73 GetCubicVolume(), GetSurfaceArea() moved to *.cc
101 - G4VTwistedFaceted, G4TwistedBox, G4TwistedTr 74 - G4VTwistedFaceted, G4TwistedBox, G4TwistedTrd: optimized
102 calculation of volume and surface area 75 calculation of volume and surface area
103 76
104 ## 2022-01-06 Evgueni Tcherniaev (geom-specifi 77 ## 2022-01-06 Evgueni Tcherniaev (geom-specific-V11-00-02)
105 - G4TwistedTubs: Implemented GetSurfaceArea() 78 - G4TwistedTubs: Implemented GetSurfaceArea() based on
106 analytical expressions; added private functi 79 analytical expressions; added private functions
107 GetLateralArea() and GetPhiCutArea() 80 GetLateralArea() and GetPhiCutArea()
108 81
109 ## 2021-12-19 Evgueni Tcherniaev (geom-specifi 82 ## 2021-12-19 Evgueni Tcherniaev (geom-specific-V11-00-01)
110 - G4Hype: Used analytical expression in GetCub 83 - G4Hype: Used analytical expression in GetCubicVolume()
111 and GetSurfaceArea() 84 and GetSurfaceArea()
112 85
113 ## 2021-12-10 Ben Morgan (geom-specific-V11-00 86 ## 2021-12-10 Ben Morgan (geom-specific-V11-00-00)
114 - Change to new Markdown History format 87 - Change to new Markdown History format
115 88
116 --- 89 ---
117 90
118 # History entries prior to 11.0 91 # History entries prior to 11.0
119 92
120 03-December-2021 E.Tcherniaev (geom-speci 93 03-December-2021 E.Tcherniaev (geom-specific-V10-07-13)
121 - G4TwistedTubs: Accurate calculation of the b 94 - G4TwistedTubs: Accurate calculation of the bounding box in
122 BoundingLimits() and GetExtent(), fixing mea 95 BoundingLimits() and GetExtent(), fixing measured performance
123 penalty. Addressing problem report #2450. 96 penalty. Addressing problem report #2450.
124 - G4TwistedTubs, G4VTwistedFaceted: Fixed GetC 97 - G4TwistedTubs, G4VTwistedFaceted: Fixed GetCubicVolume()
125 98
126 15-October-2021 E.Tcherniaev (geom-speci 99 15-October-2021 E.Tcherniaev (geom-specific-V10-07-12)
127 - G4Tet, G4UTet: Added SetBoundingLimits() 100 - G4Tet, G4UTet: Added SetBoundingLimits()
128 101
129 06-October-2021 E.Tcherniaev (geom-speci 102 06-October-2021 E.Tcherniaev (geom-specific-V10-07-11)
130 - G4Tet: some changes in calculation of boundi 103 - G4Tet: some changes in calculation of bounding box
131 - G4UTet: added CheckDegeneracy() and SetVerti 104 - G4UTet: added CheckDegeneracy() and SetVertices()
132 105
133 27-September-2021 E.Tcherniaev (geom-speci 106 27-September-2021 E.Tcherniaev (geom-specific-V10-07-10)
134 - Added degeneracyFlag to the list of paramete 107 - Added degeneracyFlag to the list of parameters of G4Tet::SetVertices(),
135 it addresses first part of the problem repor 108 it addresses first part of the problem report #2427
136 109
137 24-September-2021 E.Tcherniaev (geom-speci 110 24-September-2021 E.Tcherniaev (geom-specific-V10-07-09)
138 - Implemented G4TesselatedSolid::GetFacetIndex 111 - Implemented G4TesselatedSolid::GetFacetIndex(p)
139 112
140 10-September-2021 E.Tcherniaev (geom-speci 113 10-September-2021 E.Tcherniaev (geom-specific-V10-07-08)
141 - Implemented G4TesselatedSolid::CheckStructur 114 - Implemented G4TesselatedSolid::CheckStructure()
142 - Optimisation in G4TessellatedSolid::SetExtre 115 - Optimisation in G4TessellatedSolid::SetExtremeFacets():
143 shuffle of vertices and checking of six extr 116 shuffle of vertices and checking of six extreme vertices
144 117
145 21-July-2021 E.Tcherniaev (geom-speci 118 21-July-2021 E.Tcherniaev (geom-specific-V10-07-07)
146 - More accurate calculation of distance from p 119 - More accurate calculation of distance from point to triangle
147 in G4TriangularFacet, it addresses problem r 120 in G4TriangularFacet, it addresses problem report #2401
148 121
149 25-June-2021 G.Cosmo (geom-speci 122 25-June-2021 G.Cosmo (geom-specific-V10-07-06)
150 - Added missing accessor in G4UTet. 123 - Added missing accessor in G4UTet.
151 124
152 12-May-2021 E.Tcherniaev (geom-speci 125 12-May-2021 E.Tcherniaev (geom-specific-V10-07-05)
153 - Reimplemented CreatePolyhedron() in 126 - Reimplemented CreatePolyhedron() in
154 G4Polyhedra, G4Polycone, G4GenericPolycone, 127 G4Polyhedra, G4Polycone, G4GenericPolycone,
155 G4UPolyhedra, G4UPolycone, G4UGenericPolycon 128 G4UPolyhedra, G4UPolycone, G4UGenericPolycone
156 129
157 30-April-2021 G.Cosmo (geom-speci 130 30-April-2021 G.Cosmo (geom-specific-V10-07-04)
158 - Fixed use of conversion factor in G4UPolyhed 131 - Fixed use of conversion factor in G4UPolyhedra wrapper for "generic"
159 polyhedra constructs. 132 polyhedra constructs.
160 133
161 19-April-2021 E.Tcherniaev (geom-speci 134 19-April-2021 E.Tcherniaev (geom-specific-V10-07-03)
162 - G4Polyhedra, G4Polycone: Fix calculation of 135 - G4Polyhedra, G4Polycone: Fix calculation of endPhi for the case
163 of negative phiStart, it addresses also prob 136 of negative phiStart, it addresses also problem report #2362
164 137
165 30-March-2021 B.Morgan (geom-speci 138 30-March-2021 B.Morgan (geom-specific-V10-07-02)
166 - Migrate sources.cmake to modular build API 139 - Migrate sources.cmake to modular build API
167 140
168 18-March-2021 E.Tcherniaev (geom-speci 141 18-March-2021 E.Tcherniaev (geom-specific-V10-07-01)
169 - Fix calculation of bounding box position in 142 - Fix calculation of bounding box position in G4Voxelizer::BuildVoxelLimits(),
170 it addresses problem report #2301 143 it addresses problem report #2301
171 144
172 13-January-2021 G.Cosmo (geom-speci 145 13-January-2021 G.Cosmo (geom-specific-V10-07-00)
173 - Reduce cases of bad speculation in G4Polyhed 146 - Reduce cases of bad speculation in G4PolyhedraSide::Inside() and
174 G4PolyPhiFace::InsideEdges(), based on repor 147 G4PolyPhiFace::InsideEdges(), based on report in profiling analysis
175 by G.Amadio. 148 by G.Amadio.
176 149
177 30-October-2020 E.Tcherniaev (geom-speci 150 30-October-2020 E.Tcherniaev (geom-specific-V10-06-10)
178 - G4Polycone: Revised GetPointOnSurface(); 151 - G4Polycone: Revised GetPointOnSurface();
179 Added protected auxiliary method SetSurfaceE 152 Added protected auxiliary method SetSurfaceElements();
180 Removed GetPointOnCone(), GetPointOnTubs(), 153 Removed GetPointOnCone(), GetPointOnTubs(), GetPointOnCut(), GetPointOnRing();
181 - G4GenericPolycone: Revised GetPointOnSurface 154 - G4GenericPolycone: Revised GetPointOnSurface();
182 Added protected auxiliary method SetSurfaceE 155 Added protected auxiliary method SetSurfaceElements();
183 - G4Polyhedra: Revised GetPointOnSurface(); 156 - G4Polyhedra: Revised GetPointOnSurface();
184 Added protected auxiliary method SetSurfaceE 157 Added protected auxiliary method SetSurfaceElements();
185 Removed GetPointOnPlane(), GetPointOnTriangl 158 Removed GetPointOnPlane(), GetPointOnTriangle();
186 159
187 01-October-2020 E.Tcherniaev (geom-speci 160 01-October-2020 E.Tcherniaev (geom-specific-V10-06-09)
188 - G4Polycone, G4GenericPolycone, G4Polyhedra: 161 - G4Polycone, G4GenericPolycone, G4Polyhedra:
189 implemented GetSurfaceArea(), GetCubicVolume 162 implemented GetSurfaceArea(), GetCubicVolume().
190 163
191 May 21, 2020 Guilherme Lima (geom-speci 164 May 21, 2020 Guilherme Lima (geom-specific-V10-06-08)
192 ---------------------------- 165 ----------------------------
193 - Fix constructor signatures in G4UExtrudedSol 166 - Fix constructor signatures in G4UExtrudedSolid wrappers, to match those in G4 version.
194 There were missing const and reference quali 167 There were missing const and reference qualifiers in non-POD parameters.
195 168
196 30-April-2020 G.Cosmo (geom-speci 169 30-April-2020 G.Cosmo (geom-specific-V10-06-07)
197 - Adopt new convention for location of headers 170 - Adopt new convention for location of headers in VecGeom for all wrappers.
198 171
199 09-April-2020 E.Tcherniaev (geom-speci 172 09-April-2020 E.Tcherniaev (geom-specific-V10-06-06)
200 - Added G4GenericTrap::GetTwistedFaceSurfaceAr 173 - Added G4GenericTrap::GetTwistedFaceSurfaceArea().
201 - testG4GenericTrap.cc: fixed test for calcula 174 - testG4GenericTrap.cc: fixed test for calculation of surface area.
202 - testG4ExtrudedSolid.cc: fixed assert stateme 175 - testG4ExtrudedSolid.cc: fixed assert statements for cases where
203 point flys along the surface (DistanceToIn() 176 point flys along the surface (DistanceToIn() returns kInfinity).
204 177
205 17-January-2020 E.Tcherniaev (geom-speci 178 17-January-2020 E.Tcherniaev (geom-specific-V10-06-05)
206 - Implemented G4Tet::SetVertices(), it address 179 - Implemented G4Tet::SetVertices(), it addresses request made
207 at Geant4 Technical Forum. 180 at Geant4 Technical Forum.
208 181
209 14-January-2020 Gabriele Cosmo (geom-speci 182 14-January-2020 Gabriele Cosmo (geom-specific-V10-06-04)
210 - Added protection in G4VFacet header for doub 183 - Added protection in G4VFacet header for double definition of global
211 symbols from Windows Kits code. 184 symbols from Windows Kits code.
212 185
213 08-January-2020 E.Tcherniaev (geom-speci 186 08-January-2020 E.Tcherniaev (geom-specific-V10-06-03)
214 - Complete revision of G4Tet, speed up, new te 187 - Complete revision of G4Tet, speed up, new testG4Tet.cc.
215 It also fixes issues spotted by new unit tes 188 It also fixes issues spotted by new unit test.
216 189
217 16-December-2019 E.Tcherniaev (geom-speci 190 16-December-2019 E.Tcherniaev (geom-specific-V10-06-02)
218 - Complete revision of G4Ellipsoid, it fixes i 191 - Complete revision of G4Ellipsoid, it fixes issues with former
219 implementation, in particular it addresses p 192 implementation, in particular it addresses problem report #2206.
220 30%-70% speed-up in all main methods. 193 30%-70% speed-up in all main methods.
221 194
222 11-December-2019 B.Morgan (geom-speci 195 11-December-2019 B.Morgan (geom-specific-V10-06-01)
223 - Cleanup CMake build, removing obsolete granu 196 - Cleanup CMake build, removing obsolete granular library options and
224 explicit include_directories. 197 explicit include_directories.
225 198
226 10-December-2019 G.Cosmo (geom-speci 199 10-December-2019 G.Cosmo (geom-specific-V10-06-00)
227 - Re-established parameterisation mechanism fo 200 - Re-established parameterisation mechanism for G4Tet and G4UTet which was
228 removed by mistake. Addressing problem repor 201 removed by mistake. Addressing problem report #2209.
229 202
230 26-November-2019 G.Cosmo (geom-speci 203 26-November-2019 G.Cosmo (geom-specific-V10-05-21)
231 - Fixed cases of implicit type conversions fro 204 - Fixed cases of implicit type conversions from size_t to G4int.
232 205
233 05-November-2019 E.Tcherniaev (geom-speci 206 05-November-2019 E.Tcherniaev (geom-specific-V10-05-20)
234 - G4TesselatedSolid.cc: fixed minor Coverity d 207 - G4TesselatedSolid.cc: fixed minor Coverity defect (uninitialized array)
235 208
236 07-October-2019 E.Tcherniaev (geom-speci 209 07-October-2019 E.Tcherniaev (geom-specific-V10-05-19)
237 - G4TesselatedSolid.cc: fixed minor Coverity d 210 - G4TesselatedSolid.cc: fixed minor Coverity defect
238 211
239 16-September-2019 G.Cosmo (geom-speci 212 16-September-2019 G.Cosmo (geom-specific-V10-05-18)
240 - Rationalise header inclusions for faceted so 213 - Rationalise header inclusions for faceted solids.
241 214
242 06-September-2019 G.Cosmo (geom-speci 215 06-September-2019 G.Cosmo (geom-specific-V10-05-17)
243 - Removed unnecessary forward declaration in G 216 - Removed unnecessary forward declaration in G4VFacet header.
244 217
245 29-August-2019 G.Cosmo (geom-speci 218 29-August-2019 G.Cosmo (geom-specific-V10-05-16)
246 - Minor c++11 revision and headers cleanup. Co 219 - Minor c++11 revision and headers cleanup. Code formatting.
247 - Use pre-increment wherever possible. 220 - Use pre-increment wherever possible.
248 221
249 19-August-2019 G.Lima (geom-speci 222 19-August-2019 G.Lima (geom-specific-V10-05-15)
250 - G4ExtrudedSolid: fixed a bug in DistanceToOu 223 - G4ExtrudedSolid: fixed a bug in DistanceToOut(), affecting extruded solids
251 defined off-center along the z-axis. 224 defined off-center along the z-axis.
252 225
253 19-August-2019 G.Cosmo (geom-speci 226 19-August-2019 G.Cosmo (geom-specific-V10-05-14)
254 - G4GenericTrap: fixed compilation warnings fo 227 - G4GenericTrap: fixed compilation warnings for variable shadowing on clang-8.
255 228
256 13-August-2019 G.Cosmo (geom-speci 229 13-August-2019 G.Cosmo (geom-specific-V10-05-13)
257 - Enabled wrappers for VecGeom implementation 230 - Enabled wrappers for VecGeom implementation of G4EllipticalTube,
258 G4EllipticalCone and G4Ellipsoid. 231 G4EllipticalCone and G4Ellipsoid.
259 232
260 10-July-2019 E.Tcherniaev (geom-speci 233 10-July-2019 E.Tcherniaev (geom-specific-V10-05-12)
261 - Fixed G4UExtrudedSolid::CreatePolyhedron(). 234 - Fixed G4UExtrudedSolid::CreatePolyhedron().
262 Addressing visualization part of the problem 235 Addressing visualization part of the problem report #2171.
263 236
264 04-July-2019 G.Cosmo (geom-speci 237 04-July-2019 G.Cosmo (geom-specific-V10-05-11)
265 - Avoid defining kCarTolerance as 'static cons 238 - Avoid defining kCarTolerance as 'static const' in G4VFacet.
266 Addressing problem report #2172. 239 Addressing problem report #2172.
267 240
268 11-June-2019 E.Tcherniaev (geom-speci 241 11-June-2019 E.Tcherniaev (geom-specific-V10-05-10)
269 - Use GetVertices() instead of GetParametersLi 242 - Use GetVertices() instead of GetParametersList() in the wrapper G4UTet.
270 243
271 29-May-2019 G.Cosmo (geom-speci 244 29-May-2019 G.Cosmo (geom-specific-V10-05-09)
272 - Fixed minor Coverity defects. 245 - Fixed minor Coverity defects.
273 246
274 20-May-2019 G.Cosmo (geom-speci 247 20-May-2019 G.Cosmo (geom-specific-V10-05-08)
275 - Defined move constructor and move assignment 248 - Defined move constructor and move assignment operator for G4TriangularFacet.
276 249
277 14-May-2019 B.Morgan (geom-speci 250 14-May-2019 B.Morgan (geom-specific-V10-05-07)
278 - Add inclusion of new G4GeomTypes.hh header t 251 - Add inclusion of new G4GeomTypes.hh header to those headers allowing
279 VecGeom replacement. 252 VecGeom replacement.
280 - See also geommng-10-05-05 253 - See also geommng-10-05-05
281 254
282 23-April-2019 G.Cosmo (geom-speci 255 23-April-2019 G.Cosmo (geom-specific-V10-05-06)
283 - Modified G4PolyconeSide and G4PolyhedraSide 256 - Modified G4PolyconeSide and G4PolyhedraSide to use only trivial types for
284 MT splitted data in G4PlSideData and G4PhSid 257 MT splitted data in G4PlSideData and G4PhSideData respectively.
285 258
286 16-April-2019 G.Cosmo (geom-speci 259 16-April-2019 G.Cosmo (geom-specific-V10-05-05)
287 - Protected check in G4TwistTubsSide::Distance 260 - Protected check in G4TwistTubsSide::DistanceToPlane() withing debug flag.
288 261
289 4-April-2019 G.Cosmo (geom-speci 262 4-April-2019 G.Cosmo (geom-specific-V10-05-04)
290 - Enabled wrapper for VecGeom implementation o 263 - Enabled wrapper for VecGeom implementation of G4GenericPolycone.
291 264
292 15-February-2019 E.Tcherniaev (geom-speci 265 15-February-2019 E.Tcherniaev (geom-specific-V10-05-03)
293 - Accurate calculation of radical in G4Interse 266 - Accurate calculation of radical in G4IntersectingCone.
294 It addresses the problem report #2111. 267 It addresses the problem report #2111.
295 268
296 4-February-2019 G.Cosmo (geom-speci 269 4-February-2019 G.Cosmo (geom-specific-V10-05-02)
297 - Fix in G4EllipticalTube::CheckParameters() f 270 - Fix in G4EllipticalTube::CheckParameters() for typo in condition.
298 271
299 30-January-2019 G.Cosmo (geom-speci 272 30-January-2019 G.Cosmo (geom-specific-V10-05-01)
300 - Disabled precise computation of extent and u 273 - Disabled precise computation of extent and use simple bounding-box
301 in CalculateExtent() for G4Tet and G4Tessell 274 in CalculateExtent() for G4Tet and G4TessellatedSolid, to speed up
302 intialisation in setups with relatively comp 275 intialisation in setups with relatively complex meshes.
303 - Apply bounding-box calculation for extent al 276 - Apply bounding-box calculation for extent also for corresponding
304 VecGeom wrappers. 277 VecGeom wrappers.
305 278
306 24-January-2019 E.Tcherniaev (geom-speci 279 24-January-2019 E.Tcherniaev (geom-specific-V10-05-00)
307 - Completely revised, more robust and performa 280 - Completely revised, more robust and performant G4EllipticalTube;
308 new exhaustive test/testEllipticalTube.cc ba 281 new exhaustive test/testEllipticalTube.cc based on Shape Conventions.
309 282
310 20-September-2018 G.Cosmo (geom-speci 283 20-September-2018 G.Cosmo (geom-specific-V10-04-15)
311 - Make G4UPolycone wrapper inheriting from vec 284 - Make G4UPolycone wrapper inheriting from vecgeom::GenericUnplacedPolycone,
312 following the latest changes in VecGeom. 285 following the latest changes in VecGeom.
313 286
314 13-September-2018 G.Cosmo (geom-speci 287 13-September-2018 G.Cosmo (geom-specific-V10-04-14)
315 - G4UTessellatedSolid, G4UExtrudedSolid: remov 288 - G4UTessellatedSolid, G4UExtrudedSolid: removed leftover use of
316 UVector3 and replaced with U3Vector. 289 UVector3 and replaced with U3Vector.
317 290
318 23-August-2018 G.Cosmo (geom-speci 291 23-August-2018 G.Cosmo (geom-specific-V10-04-13)
319 - Enabled VecGeom wrapper for G4Tet. 292 - Enabled VecGeom wrapper for G4Tet.
320 293
321 10-August-2018 A.Gheata (geom-speci 294 10-August-2018 A.Gheata (geom-specific-V10-04-12)
322 - Make G4UHype wrapper inheriting from vecgeom 295 - Make G4UHype wrapper inheriting from vecgeom::GenericUnplacedHype,
323 following the latest changes in VecGeom. 296 following the latest changes in VecGeom.
324 297
325 12-July-2018 G.Cosmo (geom-speci 298 12-July-2018 G.Cosmo (geom-specific-V10-04-11)
326 - Removed G4SolidsWorkspacePool class. Adapted 299 - Removed G4SolidsWorkspacePool class. Adapted G4SolidsWorkspace to
327 use templated class G4TWorkspacePool. 300 use templated class G4TWorkspacePool.
328 - Coworks with tags in geometry/volumes, run a 301 - Coworks with tags in geometry/volumes, run and visualization/management.
329 302
330 25-Jun-2018 G.Cosmo (geom-speci 303 25-Jun-2018 G.Cosmo (geom-specific-V10-04-10)
331 - Use dynamic_cast to attempt fix for spurious 304 - Use dynamic_cast to attempt fix for spurious compilation warnings on
332 CentOS7/gcc-5.3 on G4UTessellatedSolid wrapp 305 CentOS7/gcc-5.3 on G4UTessellatedSolid wrapper.
333 306
334 17-May-2018 J.Madsen (geom-speci 307 17-May-2018 J.Madsen (geom-specific-V10-04-09)
335 - Updated "thread-local-static-var" model to 308 - Updated "thread-local-static-var" model to
336 "function-returning-thread-local-static-refe 309 "function-returning-thread-local-static-reference" model
337 which fixes Windows DLL + MT 310 which fixes Windows DLL + MT
338 311
339 11-April-2018 G.Cosmo (geom-speci 312 11-April-2018 G.Cosmo (geom-specific-V10-04-08)
340 - Replaced USOLIDS_LIBRARIES with VECGEOM_LIBR 313 - Replaced USOLIDS_LIBRARIES with VECGEOM_LIBRARIES in sources.cmake.
341 314
342 13-February-2018 E.Tcherniaev (geom-speci 315 13-February-2018 E.Tcherniaev (geom-specific-V10-04-07)
343 - Corrected conversion of input parameters to 316 - Corrected conversion of input parameters to internal structure (used for
344 caching for adoption in GDML persistency) in 317 caching for adoption in GDML persistency) in G4UPolycone and G4UPolyhedra
345 wrappers. 318 wrappers.
346 319
347 9-February-2018 G.Cosmo (geom-speci 320 9-February-2018 G.Cosmo (geom-specific-V10-04-06)
348 - Caching facets and vertices in G4UTessellate 321 - Caching facets and vertices in G4UTessellatedSolid wrapper for properly
349 treating indexing in facets. 322 treating indexing in facets.
350 323
351 31-January-2018 G.Cosmo (geom-speci 324 31-January-2018 G.Cosmo (geom-specific-V10-04-05)
352 - Corrected use of facets indeces in G4UTessel 325 - Corrected use of facets indeces in G4UTessellatedSolid for visualization.
353 - Minor cleanup in G4TessellatedSolid::CreateP 326 - Minor cleanup in G4TessellatedSolid::CreatePolyhedron(), no functional
354 changes. 327 changes.
355 328
356 15-January-2018 G.Cosmo (geom-speci 329 15-January-2018 G.Cosmo (geom-specific-V10-04-04)
357 - Added validity checks in G4UTessellatedSolid 330 - Added validity checks in G4UTessellatedSolid::AddFacet().
358 331
359 11-January-2018 G.Cosmo (geom-speci 332 11-January-2018 G.Cosmo (geom-specific-V10-04-03)
360 - Added and enabled VecGeom wrapper for G4Tess 333 - Added and enabled VecGeom wrapper for G4TessellatedSolid.
361 Requires tags cmake-V10-04-01 and config-V10 334 Requires tags cmake-V10-04-01 and config-V10-04-00.
362 335
363 20-December-2017 G.Cosmo (geom-speci 336 20-December-2017 G.Cosmo (geom-specific-V10-04-02)
364 - Enabled VecGeom wrappers for G4ExtrudedSolid 337 - Enabled VecGeom wrappers for G4ExtrudedSolid and G4Hype.
365 338
366 13-December-2017 E.Tcherniaev (geom-speci 339 13-December-2017 E.Tcherniaev (geom-specific-V10-04-01)
367 - Removed redundant data initialistion in G4Ex 340 - Removed redundant data initialistion in G4ExtrudedSolid constructors.
368 341
369 11-December-2017 E.Tcherniaev (geom-speci 342 11-December-2017 E.Tcherniaev (geom-specific-V10-04-00)
370 - Added missing initialisation of two data-mem 343 - Added missing initialisation of two data-members in copy-ctor and
371 assignment operator of G4ExtrudedSolid. Addr 344 assignment operator of G4ExtrudedSolid. Addressing problem report #2016.
372 345
373 22-November-2017 G.Cosmo (geom-specif 346 22-November-2017 G.Cosmo (geom-specific-V10-03-25)
374 - Fix in SurfaceNormal() for G4ExtrudedSolid t 347 - Fix in SurfaceNormal() for G4ExtrudedSolid to assure explicit
375 counting of the surfaces where the point is 348 counting of the surfaces where the point is placed on edg
376 349
377 2-November-2017 G.Cosmo (geom-specif 350 2-November-2017 G.Cosmo (geom-specific-V10-03-24)
378 - Fixed compilation warning introduced with la 351 - Fixed compilation warning introduced with last tag.
379 352
380 31-October-2017 E.Tcherniaev (geom-specif 353 31-October-2017 E.Tcherniaev (geom-specific-V10-03-23)
381 - Added specialised implementation for constru 354 - Added specialised implementation for constructs defining a non-convex right
382 prism in G4ExtrudedSolid. 355 prism in G4ExtrudedSolid.
383 356
384 20-October-2017 G.Cosmo (geom-specif 357 20-October-2017 G.Cosmo (geom-specific-V10-03-22)
385 - G4TessellatedSolid: print also solid's name 358 - G4TessellatedSolid: print also solid's name in StreamInfo().
386 359
387 17-October-2017 G.Cosmo (geom-specif 360 17-October-2017 G.Cosmo (geom-specific-V10-03-21)
388 - Added VecGeom wrapper G4UHype for G4Hype, no 361 - Added VecGeom wrapper G4UHype for G4Hype, not yet activated, pending
389 fixes in VecGeom. 362 fixes in VecGeom.
390 363
391 16-October-2017 G.Cosmo (geom-specif 364 16-October-2017 G.Cosmo (geom-specific-V10-03-20)
392 - Temporarly disabled wrappers for G4Tet and G 365 - Temporarly disabled wrappers for G4Tet and G4GenericPolycone, pending
393 their corresponding implementation in VecGeo 366 their corresponding implementation in VecGeom.
394 367
395 28-September-2017 G.Cosmo (geom-specif 368 28-September-2017 G.Cosmo (geom-specific-V10-03-19)
396 - Corrected initialisation of polyhedra by ver 369 - Corrected initialisation of polyhedra by vertices in G4UPolyhdra wrapper
397 following the changes in VecGeom. 370 following the changes in VecGeom.
398 371
399 15-September-2017 G.Cosmo (geom-specif 372 15-September-2017 G.Cosmo (geom-specific-V10-03-18)
400 - G4SolidsWorkspacePool: use DLL export flag f 373 - G4SolidsWorkspacePool: use DLL export flag for static thread-local
401 symbol of the workspace. 374 symbol of the workspace.
402 375
403 12-September-2017 G.Cosmo (geom-specif 376 12-September-2017 G.Cosmo (geom-specific-V10-03-17)
404 - G4Voxelizer: directly set components for bou 377 - G4Voxelizer: directly set components for bounding-box instead of
405 recreating it in BuildBoundingBox(..). 378 recreating it in BuildBoundingBox(..).
406 379
407 8-September-2017 E.Tcherniaev (geom-specif 380 8-September-2017 E.Tcherniaev (geom-specific-V10-03-16)
408 - Added specialised implementation for constru 381 - Added specialised implementation for constructs defining a convex right
409 prism in G4ExtrudedSolid. 382 prism in G4ExtrudedSolid.
410 383
411 4-September-2017 G.Cosmo (geom-specif 384 4-September-2017 G.Cosmo (geom-specific-V10-03-15, 14)
412 - Temporarly disabled wrapper for extruded-sol 385 - Temporarly disabled wrapper for extruded-solid, pending implementation
413 of extruded-solid in VecGeom. 386 of extruded-solid in VecGeom.
414 387
415 16-August-2017 J.Allison (geom-specif 388 16-August-2017 J.Allison (geom-specific-V10-03-13)
416 - Twisted solids: Fixed bug in drawing polyhed 389 - Twisted solids: Fixed bug in drawing polyhedra with negative twist angle.
417 Addressing problem report #1995. 390 Addressing problem report #1995.
418 391
419 27-July-2017 E.Tcherniaev (geom-specif 392 27-July-2017 E.Tcherniaev (geom-specific-V10-03-12)
420 - G4EllipticalCone: corrected samping of rando 393 - G4EllipticalCone: corrected samping of random points on lateral surface in
421 function GetPointOnSurface(). 394 function GetPointOnSurface().
422 395
423 24-July-2017 E.Tcherniaev (geom-specif 396 24-July-2017 E.Tcherniaev (geom-specific-V10-03-11)
424 - G4EllipticalCone: improved GetPointOnSurface 397 - G4EllipticalCone: improved GetPointOnSurface() to have uniform sampling of
425 points, using function G4RandomPointOnEllips 398 points, using function G4RandomPointOnEllipse().
426 399
427 20-July-2017 E.Tcherniaev (geom-specif 400 20-July-2017 E.Tcherniaev (geom-specific-V10-03-10, 09)
428 - G4EllipticalCone: reviewed implementation of 401 - G4EllipticalCone: reviewed implementation of Inside(), DistanceToIn/Out(p),
429 SurfaceNormal() and GetPointOnSurface(); mad 402 SurfaceNormal() and GetPointOnSurface(); made more compact and performant.
430 Addressing problem report #1974. 403 Addressing problem report #1974.
431 404
432 15-June-2017 G.Cosmo (geom-specif 405 15-June-2017 G.Cosmo (geom-specific-V10-03-08)
433 - Enabled adapter also in G4UPolycone wrapper. 406 - Enabled adapter also in G4UPolycone wrapper.
434 - Added check on open solid for G4UPolyhedra w 407 - Added check on open solid for G4UPolyhedra wrapper.
435 408
436 6-June-2017 G.Cosmo (geom-specif 409 6-June-2017 G.Cosmo (geom-specific-V10-03-07)
437 - Enable adapter for VecGeom shapes in G4U* wr 410 - Enable adapter for VecGeom shapes in G4U* wrappers for: paraboloid,
438 polyhedra and GenericTrap. From now on, wrap 411 polyhedra and GenericTrap. From now on, wrappers depends directly on
439 VecGeom shapes implementation. USolids API i 412 VecGeom shapes implementation. USolids API is deprecated and no longer
440 supported. 413 supported.
441 414
442 24-May-2017 G.Cosmo (geom-specif 415 24-May-2017 G.Cosmo (geom-specific-V10-03-06)
443 - Renamed ambiguous name Extent() in all solid 416 - Renamed ambiguous name Extent() in all solids and G4U* wrappers to
444 BoundingLimits(). Change required in order t 417 BoundingLimits(). Change required in order to avoid signature conflict
445 with VecGeom in G4U* wrappers. 418 with VecGeom in G4U* wrappers.
446 Requires tag geommng-V10-03-16. 419 Requires tag geommng-V10-03-16.
447 420
448 11-May-2017 G.Cosmo (geom-specif 421 11-May-2017 G.Cosmo (geom-specific-V10-03-05)
449 - Removed potential race condition in G4VTwist 422 - Removed potential race condition in G4VTwistSurface::AmIOnLeftSide().
450 Addressing problem report #1972. 423 Addressing problem report #1972.
451 424
452 7-April-2017 G.Cosmo (geom-specif 425 7-April-2017 G.Cosmo (geom-specific-V10-03-04)
453 - Renamed G4SurfaceVoxelizer to G4Voxelizer an 426 - Renamed G4SurfaceVoxelizer to G4Voxelizer and extended to support
454 voxelisation of shapes in 3D space. Adapted 427 voxelisation of shapes in 3D space. Adapted G4TessellatedSolid accordingly.
455 428
456 13-March-2017 G.Cosmo (geom-specif 429 13-March-2017 G.Cosmo (geom-specific-V10-03-03)
457 - G4SolidsWorkspacePool: implemented CleanUpAn 430 - G4SolidsWorkspacePool: implemented CleanUpAndDestroyAllWorkspaces(),
458 to be called by worker threads. Removed decl 431 to be called by worker threads. Removed declaration (i.e. not implemented)
459 of protected method ReleaseAndDestroyWorkspa 432 of protected method ReleaseAndDestroyWorkspace().
460 433
461 2-March-2017 E.Tcherniaev (geom-specif 434 2-March-2017 E.Tcherniaev (geom-specific-V10-03-02)
462 - Fixed possible rounding off error in calcula 435 - Fixed possible rounding off error in calculation of 'astep' (max angle
463 for one step) in CalculateExtent() for G4Pol 436 for one step) in CalculateExtent() for G4Polycone, G4GenericPolycone
464 and related USolids wrappers. 437 and related USolids wrappers.
465 438
466 27-February-2017 E.Tcherniaev (geom-specif 439 27-February-2017 E.Tcherniaev (geom-specific-V10-03-01)
467 - Revised implementation of GetCubicVolume() a 440 - Revised implementation of GetCubicVolume() and GetSurfaceArea() for
468 G4EllipticalTube, to return exact values. 441 G4EllipticalTube, to return exact values.
469 - Revised implementation of GetSurfaceArea() f 442 - Revised implementation of GetSurfaceArea() for G4EllipticalCone, to
470 return exact value; moved both GetCubicVolum 443 return exact value; moved both GetCubicVolume() and GetSurfaceArea() to
471 be not inline. 444 be not inline.
472 445
473 13-December-2016 G.Cosmo (geom-specif 446 13-December-2016 G.Cosmo (geom-specific-V10-03-00)
474 - Correction in G4UExtrudedSolid to signature 447 - Correction in G4UExtrudedSolid to signature for CalculateExtent().
475 Fixes issue of undefined symbol if extruded- 448 Fixes issue of undefined symbol if extruded-solid not included in the
476 list of VecGeom wrappers to activate. 449 list of VecGeom wrappers to activate.
477 450
478 30-November-2016 E.Tcherniaev (geom-specif 451 30-November-2016 E.Tcherniaev (geom-specific-V10-02-25)
479 - Call RemoveRedundantVertices() from G4GeomTo 452 - Call RemoveRedundantVertices() from G4GeomTools in CalculateExtent()
480 for G4Polycone, G4Polyhedra and related USol 453 for G4Polycone, G4Polyhedra and related USolids wrappers.
481 - Fix in G4Parabolid and G4UParaboloid for cor 454 - Fix in G4Parabolid and G4UParaboloid for correct computation of extent.
482 455
483 18-November-2016 E.Tcherniaev (geom-specif 456 18-November-2016 E.Tcherniaev (geom-specific-V10-02-24)
484 - Added consistency checks for extent computat 457 - Added consistency checks for extent computation in USolids wrappers.
485 - Fix in cached parameters in G4UPolyhedra. 458 - Fix in cached parameters in G4UPolyhedra.
486 459
487 10-November-2016 G.Cosmo (geom-specif 460 10-November-2016 G.Cosmo (geom-specific-V10-02-23)
488 - G4UPolyhedra re-introduced new implementatio 461 - G4UPolyhedra re-introduced new implementation of CalculateExtent() using
489 G4BoundingEnvelope and extended wrapper to c 462 G4BoundingEnvelope and extended wrapper to cache corners and start/end
490 Phi parameters, to overcome issues in VecGeo 463 Phi parameters, to overcome issues in VecGeom on treatment of angles.
491 464
492 10-November-2016 E.Tcherniaev (geom-specif 465 10-November-2016 E.Tcherniaev (geom-specific-V10-02-22)
493 - Added caching of corners and implementation 466 - Added caching of corners and implementation of GetCorner() in G4UPolycone
494 in order to assure correct translation. 467 in order to assure correct translation.
495 - Withdrawn changes in G4UPolyhedra introduced 468 - Withdrawn changes in G4UPolyhedra introduced in tag geom-specific-V10-02-16
496 until understood proper conversion from VecG 469 until understood proper conversion from VecGeom.
497 470
498 7-November-2016 E.Tcherniaev (geom-specifi 471 7-November-2016 E.Tcherniaev (geom-specific-V10-02-21)
499 - Correction in G4EllipticalCone::DistanceToOu 472 - Correction in G4EllipticalCone::DistanceToOut(p) to make it more accurate.
500 - Added optional debug flag G4BBOX_EXTENT in G 473 - Added optional debug flag G4BBOX_EXTENT in GNUMake build to compare
501 extent calculation by simply using bounding- 474 extent calculation by simply using bounding-box.
502 475
503 3-November-2016 G.Cosmo (geom-specifi 476 3-November-2016 G.Cosmo (geom-specific-V10-02-20, 19)
504 - Fix in G4PolyPhiFace for potential unitialis 477 - Fix in G4PolyPhiFace for potential unitialised data in Inside().
505 478
506 31-October-2016 E.Tcherniaev (geom-specifi 479 31-October-2016 E.Tcherniaev (geom-specific-V10-02-18)
507 - Re-implemented CalculateExtent() to make use 480 - Re-implemented CalculateExtent() to make use of G4BoundingEnvelope and
508 removed no-longer used method CreateRotatedV 481 removed no-longer used method CreateRotatedVertices() in G4Polyhedra,
509 G4EllipticalCone, G4Polycone, G4Paraboloid, 482 G4EllipticalCone, G4Polycone, G4Paraboloid, G4ExtrudedSolid, G4Hype,
510 G4GenericPolycone, G4TessellatedSolid, G4Twi 483 G4GenericPolycone, G4TessellatedSolid, G4TwistedTubs and related USolids
511 wrappers. 484 wrappers.
512 - Use G4RandFlat instead of RandFlat. 485 - Use G4RandFlat instead of RandFlat.
513 486
514 21-October-2016 G.Cosmo (geom-specifi 487 21-October-2016 G.Cosmo (geom-specific-V10-02-17)
515 - Moved initialisation of G4GeomSplitter threa 488 - Moved initialisation of G4GeomSplitter thread-local data to be inline
516 along with generic template type. 489 along with generic template type.
517 Fixing compilation/linking errors on clang-3 490 Fixing compilation/linking errors on clang-3.9 and XCode-8 on MacOS.
518 491
519 19-October-2016 E.Tcherniaev (geom-speci 492 19-October-2016 E.Tcherniaev (geom-specific-V10-02-16)
520 - Reimplemented CalculateExtent() in G4Polycon 493 - Reimplemented CalculateExtent() in G4Polycone, G4Polyhedra, G4GenericPolycone
521 and associated USolids wrappers, to make use 494 and associated USolids wrappers, to make use of G4BoundingEnvelope.
522 495
523 5-October-2016 E.Tcherniaev (geom-speci 496 5-October-2016 E.Tcherniaev (geom-specific-V10-02-15, 14)
524 - Reimplemented CalculateExtent() in G4Tet, G4 497 - Reimplemented CalculateExtent() in G4Tet, G4UTet, G4GenericTrap,
525 G4UGenericTrap, G4EllipticalTube and G4VTwis 498 G4UGenericTrap, G4EllipticalTube and G4VTwistedFaceted, to make use
526 of G4BoundingEnvelope; removed no-longer use 499 of G4BoundingEnvelope; removed no-longer used method CreateRotatedVertices().
527 500
528 20-September-2016 G.Cosmo (geom-speci 501 20-September-2016 G.Cosmo (geom-specific-V10-02-13)
529 - Moved accessors/modifiers for splitter data 502 - Moved accessors/modifiers for splitter data to non-inline in
530 G4PolyhedraSide and G4PolyconeSide. 503 G4PolyhedraSide and G4PolyconeSide.
531 Explicitly initialise G4GeomSplitter data in 504 Explicitly initialise G4GeomSplitter data in G4SolidsWorkspace
532 translation unit. 505 translation unit.
533 Fixing compilation/linking errors on clang-3 506 Fixing compilation/linking errors on clang-3.9 and XCode-8 on MacOS.
534 507
535 06-July-2016 E.Tcherniaev (geom-speci 508 06-July-2016 E.Tcherniaev (geom-specific-V10-02-12)
536 - Fixed monir typo in function Create() for G4 509 - Fixed monir typo in function Create() for G4Polycone, G4Polyhedra and
537 G4GenericPolycone. 510 G4GenericPolycone.
538 Fixed minor typos in G4GenericTrap::SurfaceN 511 Fixed minor typos in G4GenericTrap::SurfaceNormal() and
539 G4VTwistSurface::CurrentStatus::ResetfDone() 512 G4VTwistSurface::CurrentStatus::ResetfDone().
540 Issues detected by PVS-Studio static code an 513 Issues detected by PVS-Studio static code analyzer.
541 Addressing problem report #1876. 514 Addressing problem report #1876.
542 515
543 24-May-2016 G.Cosmo (geom-speci 516 24-May-2016 G.Cosmo (geom-specific-V10-02-11)
544 - Correction in G4UExtrudedSolid for definitio 517 - Correction in G4UExtrudedSolid for definition of CreatePolyhedron().
545 518
546 20-May-2016 G.Cosmo (geom-speci 519 20-May-2016 G.Cosmo (geom-specific-V10-02-10)
547 - Moved accessors and modifiers in USolids wra 520 - Moved accessors and modifiers in USolids wrappers to be not inlined.
548 Required modification in order to allow corr 521 Required modification in order to allow correct dispatching to VecGeom
549 types. 522 types.
550 523
551 15-Apr-2016 G.Cosmo (geom-speci 524 15-Apr-2016 G.Cosmo (geom-specific-V10-02-09)
552 - Added flag in USolids wrappers for partial u 525 - Added flag in USolids wrappers for partial use of USolids/VecGeom types.
553 526
554 31-Mar-2016 G.Cosmo (geom-speci 527 31-Mar-2016 G.Cosmo (geom-specific-V10-02-08, 07)
555 - Added overloaded CreatePolyhedron() method t 528 - Added overloaded CreatePolyhedron() method to USolids wrappers.
556 It is now possible to visualize supported Ve 529 It is now possible to visualize supported VecGeom shapes.
557 - Added implementation of CreatePolyhedron() i 530 - Added implementation of CreatePolyhedron() in UExtrudedSolid wrapper.
558 531
559 10-Mar-2016 G.Cosmo (geom-speci 532 10-Mar-2016 G.Cosmo (geom-specific-V10-02-06)
560 - Added overloaded GetEntityType() method to U 533 - Added overloaded GetEntityType() method to USolids wrappers.
561 534
562 07-Mar-2016 E.Tcherniaev (geom-speci 535 07-Mar-2016 E.Tcherniaev (geom-specific-V10-02-05)
563 - Fix in G4IntersectingCone for smaller precis 536 - Fix in G4IntersectingCone for smaller precision constant in LineHitsCone1()
564 and LineHitsCone2(). Fixes issue observed in 537 and LineHitsCone2(). Fixes issue observed in G4GenericPolycone.
565 Addressing problem report #1794. 538 Addressing problem report #1794.
566 539
567 03-Mar-2016 G.Cosmo (geom-speci 540 03-Mar-2016 G.Cosmo (geom-specific-V10-02-04)
568 - Fixed compilation warnings for potential uni 541 - Fixed compilation warnings for potential uninitialised values in
569 G4ExtrudedSolid::CheckPolygon() function int 542 G4ExtrudedSolid::CheckPolygon() function introduced in previous tag.
570 543
571 03-Mar-2016 E.Tcherniaev (geom-speci 544 03-Mar-2016 E.Tcherniaev (geom-specific-V10-02-03)
572 - Added 'const' qualifier for methods in G4Ext 545 - Added 'const' qualifier for methods in G4ExtrudedSolid.
573 Added CheckPolygon() to remove collinear and 546 Added CheckPolygon() to remove collinear and coincident points from polygons.
574 - G4QuadrangularFacet: added exhaustive tests 547 - G4QuadrangularFacet: added exhaustive tests in constructor to catch potential
575 problems with a quadrangular facet: collinea 548 problems with a quadrangular facet: collinear vertices, non planar surface,
576 degenerate, concave or self intersecting qua 549 degenerate, concave or self intersecting quadrilateral.
577 - G4TriangularFacet: Improved test in construc 550 - G4TriangularFacet: Improved test in constructor to detect degenerate (too
578 small or too narrow) triangles. 551 small or too narrow) triangles.
579 552
580 25-Feb-2016 E.Tcherniaev (geom-speci 553 25-Feb-2016 E.Tcherniaev (geom-specific-V10-02-02)
581 - Correction in G4ExtrudedSolid::AddGeneralPol 554 - Correction in G4ExtrudedSolid::AddGeneralPolygonFacets() for precision
582 treatment in construction of tessels to avoi 555 treatment in construction of tessels to avoid cases of collinear points
583 and consequent degenerating triangles. 556 and consequent degenerating triangles.
584 Address problem report #1777. 557 Address problem report #1777.
585 - Use pre-computed kCarToleranceHalf constant 558 - Use pre-computed kCarToleranceHalf constant in G4ExtrudedSolid, now
586 protected in G4TessellatedSolid. 559 protected in G4TessellatedSolid.
587 - Improved algorithms for computation of area 560 - Improved algorithms for computation of area in G4TriangularFacet and
588 G4QuadrangularFacet. Added post-const qualif 561 G4QuadrangularFacet. Added post-const qualifier to GetArea().
589 562
590 16-Feb-2016 G.Cosmo (geom-speci 563 16-Feb-2016 G.Cosmo (geom-specific-V10-02-01)
591 - Revised implementation for GetSurfaceArea() 564 - Revised implementation for GetSurfaceArea() and GetCubicVolume() in
592 G4GenericTrap (E.Tcherniaev). 565 G4GenericTrap (E.Tcherniaev).
593 - Protected debug warning in G4GenericTrap::Su 566 - Protected debug warning in G4GenericTrap::SurfaceNormal() within G4SPECSDEBUG.
594 567
595 02-Feb-2016 E.Tcherniaev (geom-speci 568 02-Feb-2016 E.Tcherniaev (geom-specific-V10-02-00)
596 - Fix in G4GenericTrap for compuation of exten 569 - Fix in G4GenericTrap for compuation of extent.
597 Addressing problem report #1809. 570 Addressing problem report #1809.
598 - Use dot() in formula for computation of GetC 571 - Use dot() in formula for computation of GetCubicVolume() in
599 G4TessellatedSolid. 572 G4TessellatedSolid.
600 573
601 18-Nov-2015 G.Cosmo (geom-speci 574 18-Nov-2015 G.Cosmo (geom-specific-V10-01-15)
602 - Added specialised implementation for GetCubi 575 - Added specialised implementation for GetCubicVolume() in
603 G4TessellatedSolid (J.Allison). 576 G4TessellatedSolid (J.Allison).
604 577
605 29-Oct-2015 G.Cosmo (geom-speci 578 29-Oct-2015 G.Cosmo (geom-specific-V10-01-14)
606 - Added debug printouts within G4SPECSDEBUG in 579 - Added debug printouts within G4SPECSDEBUG in G4TessellatedSolid for
607 DistanceToIn/Out(p,v) to identify potential 580 DistanceToIn/Out(p,v) to identify potential wrong responses.
608 581
609 26-Oct-2015 G.Cosmo (geom-speci 582 26-Oct-2015 G.Cosmo (geom-specific-V10-01-13)
610 - Removed redundant condition in G4Polyhedra a 583 - Removed redundant condition in G4Polyhedra and G4polycone
611 SetOriginalParameters() method. 584 SetOriginalParameters() method.
612 585
613 23-Oct-2015 G.Cosmo (geom-speci 586 23-Oct-2015 G.Cosmo (geom-specific-V10-01-12)
614 - G4PolyhedraSide: moved internal struct defin 587 - G4PolyhedraSide: moved internal struct definitions to public section
615 to overcome deficiencies in object-persisten 588 to overcome deficiencies in object-persistency class parsing.
616 589
617 07-Oct-2015 G.Cosmo (geom-speci 590 07-Oct-2015 G.Cosmo (geom-specific-V10-01-11)
618 - Protected compilation of USolid wrappers wit 591 - Protected compilation of USolid wrappers with G4GEOM_USE_USOLIDS flag.
619 592
620 01-Sep-2015 G.Cosmo (geom-speci 593 01-Sep-2015 G.Cosmo (geom-specific-V10-01-10)
621 - Corrected conditional compilation flag in G4 594 - Corrected conditional compilation flag in G4UParaboloid.cc.
622 595
623 31-Aug-2015 G.Cosmo (geom-speci 596 31-Aug-2015 G.Cosmo (geom-specific-V10-01-09)
624 - Added USolids/VecGeom wrapper for G4Parabolo 597 - Added USolids/VecGeom wrapper for G4Paraboloid (G.Lima/FNAL).
625 Activated only for external USolids/VecGeom 598 Activated only for external USolids/VecGeom installation.
626 599
627 13-Aug-2015 G.Cosmo (geom-speci 600 13-Aug-2015 G.Cosmo (geom-specific-V10-01-08)
628 - Checked for potential never-ending loops. 601 - Checked for potential never-ending loops.
629 No issues found, only added annotations. 602 No issues found, only added annotations.
630 603
631 05-Aug-2015 G.Cosmo (geom-speci 604 05-Aug-2015 G.Cosmo (geom-specific-V10-01-07)
632 - Minor code cleanup in G4SurfaceVoxelizer. 605 - Minor code cleanup in G4SurfaceVoxelizer.
633 606
634 03-Mar-2015 G.Cosmo (geom-speci 607 03-Mar-2015 G.Cosmo (geom-specific-V10-01-06)
635 - Use accessors x(), y() and z() from UVector3 608 - Use accessors x(), y() and z() from UVector3, instead of directly accessing
636 its data-members. Co-work with tag "geom-uso 609 its data-members. Co-work with tag "geom-usolids-V10-01-09".
637 610
638 23-Feb-2015 T.Nikitina (geom-speci 611 23-Feb-2015 T.Nikitina (geom-specific-V10-01-05)
639 - Fix in SetOriginalParameters() for G4Polycon 612 - Fix in SetOriginalParameters() for G4Polycone and G4Polyhedra, in case
640 of presence of 'rings' structures. Addressin 613 of presence of 'rings' structures. Addressing problem report #1705.
641 614
642 26-Jan-2015 G.Cosmo (geom-speci 615 26-Jan-2015 G.Cosmo (geom-specific-V10-01-04)
643 - Renamed DistanceAwayForInside() to DistanceA 616 - Renamed DistanceAwayForInside() to DistanceAway() and use polymorphism.
644 617
645 26-Jan-2015 T.Nikitina (geom-speci 618 26-Jan-2015 T.Nikitina (geom-specific-V10-01-03, 02)
646 - Added special method for Inside 'DistanceAwa 619 - Added special method for Inside 'DistanceAwayForInside()' in order to fix
647 precision problem of calculation of Distance 620 precision problem of calculation of DistanceToSide() in G4PolyconeSide.
648 621
649 21-Jan-2015 T.Nikitina (geom-speci 622 21-Jan-2015 T.Nikitina (geom-specific-V10-01-01)
650 - Fixed triangularisation method AddGeneralPOl 623 - Fixed triangularisation method AddGeneralPOlygoneFacets() in
651 G4ExtrudedSolid by avoiding flat triangles. 624 G4ExtrudedSolid by avoiding flat triangles.
652 - Added warning message to G4TriangularFacet c 625 - Added warning message to G4TriangularFacet constructor if Area is 0;
653 i.e., case of flat triangle. 626 i.e., case of flat triangle.
654 - Addressing problem report #1703. 627 - Addressing problem report #1703.
655 628
656 12-Dec-2014 G.Cosmo (geom-speci 629 12-Dec-2014 G.Cosmo (geom-specific-V10-01-00)
657 - Use canonical form for operator=() in G4Poly 630 - Use canonical form for operator=() in G4PolyconeHistorical and
658 G4PolyhedraHistorical. 631 G4PolyhedraHistorical.
659 632
660 17-Sep-2014 G.Cosmo (geom-speci 633 17-Sep-2014 G.Cosmo (geom-specific-V10-00-11)
661 - Added wrappers for UExtrudedSolid and UGener 634 - Added wrappers for UExtrudedSolid and UGenericTrap; adapted switches to
662 original G4 types accordingly. Requires tag 635 original G4 types accordingly. Requires tag "geom-usolids-V10-00-16".
663 636
664 01-Sep-2014 G.Cosmo (geom-speci 637 01-Sep-2014 G.Cosmo (geom-specific-V10-00-10)
665 - Fixed use of polyhedron pointer, to avoid ra 638 - Fixed use of polyhedron pointer, to avoid race condition in MT
666 when parameterised volumes are visualised. 639 when parameterised volumes are visualised.
667 640
668 22-May-2014 G.Cosmo (geom-speci 641 22-May-2014 G.Cosmo (geom-specific-V10-00-09)
669 - Added protection in generic constructor of G 642 - Added protection in generic constructor of G4Polyhedra for the case when
670 improper number of sides is given as input. 643 improper number of sides is given as input.
671 644
672 10-Apr-2014 G.Cosmo (geom-speci 645 10-Apr-2014 G.Cosmo (geom-specific-V10-00-08)
673 - Get rid of deprecated 'register' storage cla 646 - Get rid of deprecated 'register' storage class specifier in source files.
674 647
675 31-Mar-2014 G.Cosmo (geom-speci 648 31-Mar-2014 G.Cosmo (geom-specific-V10-00-07)
676 - Fixed signature of assignment operator to G4 649 - Fixed signature of assignment operator to G4VCSGfaceted.
677 650
678 31-Mar-2014 G.Cosmo (geom-speci 651 31-Mar-2014 G.Cosmo (geom-specific-V10-00-06)
679 - Fixed signature of assignment operator to G4 652 - Fixed signature of assignment operator to G4Polycone, G4Polyhedra and
680 and G4GenericPolycone. 653 and G4GenericPolycone.
681 654
682 05-Mar-2014 G.Cosmo (geom-speci 655 05-Mar-2014 G.Cosmo (geom-specific-V10-00-05)
683 - Fixed proper handling of polyhedron pointer 656 - Fixed proper handling of polyhedron pointer in solids, to avoid memory
684 leak for visualization of parameterised volu 657 leak for visualization of parameterised volumes.
685 658
686 12-Feb-2014 G.Cosmo (geom-speci 659 12-Feb-2014 G.Cosmo (geom-specific-V10-00-04)
687 - Simply reset polyhedron pointer to zero for 660 - Simply reset polyhedron pointer to zero for modifiers of G4U* wrappers
688 in parameterisation. Resolves crash in MT vi 661 in parameterisation. Resolves crash in MT visualization when using USolids.
689 662
690 12-Feb-2014 G.Cosmo (geom-speci 663 12-Feb-2014 G.Cosmo (geom-specific-V10-00-03 [and -02])
691 - Added correct cloning mechanism in G4U* wrap 664 - Added correct cloning mechanism in G4U* wrappers.
692 Addressing problem report #1553. 665 Addressing problem report #1553.
693 666
694 18-Dec-2013 T.Nikitina (geom-speci 667 18-Dec-2013 T.Nikitina (geom-specific-V10-00-01)
695 - Fix in G4GenericTrap::InsidePolygone() to ch 668 - Fix in G4GenericTrap::InsidePolygone() to check if p lies between the two
696 extremes of the segment. Addressing problem 669 extremes of the segment. Addressing problem report #1541.
697 670
698 17-Dec-2013 G.Cosmo (geom-speci 671 17-Dec-2013 G.Cosmo (geom-specific-V10-00-00)
699 - Corrected left-over debug printout in G4Poly 672 - Corrected left-over debug printout in G4Polycone::SetOriginalParameters().
700 673
701 04-Dec-2013 G.Cosmo (geom-speci 674 04-Dec-2013 G.Cosmo (geom-specific-V09-06-36)
702 - Corrected left-over debug printout in G4Poly 675 - Corrected left-over debug printout in G4Polyhedra::SetOriginalParameters().
703 676
704 22-Nov-2013 G.Cosmo (geom-speci 677 22-Nov-2013 G.Cosmo (geom-specific-V09-06-35)
705 - Correction to USolids wrappers for proper se 678 - Correction to USolids wrappers for proper setting of name to base class.
706 679
707 19-Nov-2013 J.Apostolakis (geom-speci 680 19-Nov-2013 J.Apostolakis (geom-specific-V09-06-34)
708 - Fix for issue identified by Coverity: fixed 681 - Fix for issue identified by Coverity: fixed implementation of
709 G4SolidsWorkspacePool singleton. 682 G4SolidsWorkspacePool singleton.
710 683
711 20-Nov-2013 T.Mikitina (geom-speci 684 20-Nov-2013 T.Mikitina (geom-specific-V09-06-33)
712 - Fixed Coverity defects to USolids wrappers. 685 - Fixed Coverity defects to USolids wrappers.
713 686
714 14-Nov-2013 G.Cosmo (geom-speci 687 14-Nov-2013 G.Cosmo (geom-specific-V09-06-32, 31)
715 - Enabled use of Reset() in G4UPolycone. 688 - Enabled use of Reset() in G4UPolycone.
716 - Corrections to G4UPolycone and G4UPolyhedra 689 - Corrections to G4UPolycone and G4UPolyhedra to allow for visualization
717 of parameterisations on these solids. 690 of parameterisations on these solids.
718 691
719 13-Nov-2013 G.Cosmo (geom-speci 692 13-Nov-2013 G.Cosmo (geom-specific-V09-06-30)
720 - Correction to G4UTet and G4UGenericPolycone 693 - Correction to G4UTet and G4UGenericPolycone to explicitly include
721 symbols re-definitions from G4Tet and G4Gene 694 symbols re-definitions from G4Tet and G4GenericPolycone respectively.
722 695
723 12-Nov-2013 G.Cosmo (geom-speci 696 12-Nov-2013 G.Cosmo (geom-specific-V09-06-29)
724 - Added dummy method G4UPolycone::Reset(). 697 - Added dummy method G4UPolycone::Reset().
725 NOTE: Required related implementation (curre 698 NOTE: Required related implementation (currently missing!) in UPolycone.
726 699
727 12-Nov-2013 G.Cosmo (geom-speci 700 12-Nov-2013 G.Cosmo (geom-specific-V09-06-28)
728 - Correction to USolids switch mechanism for G 701 - Correction to USolids switch mechanism for G4Polycone.
729 702
730 08-Nov-2013 J.Apostolakis (geom-speci 703 08-Nov-2013 J.Apostolakis (geom-specific-V09-06-27)
731 - G4SolidsWorkspace: cleanup of verbosity. 704 - G4SolidsWorkspace: cleanup of verbosity.
732 Reduced verbosity by making it optional. 705 Reduced verbosity by making it optional.
733 Added Set/Get Verbose methods to toggle and 706 Added Set/Get Verbose methods to toggle and view it.
734 Added parameter to constructor for verbosity 707 Added parameter to constructor for verbosity (default=off).
735 708
736 07-Nov-2013 G.Cosmo (geom-specific-V09-06-26) 709 07-Nov-2013 G.Cosmo (geom-specific-V09-06-26)
737 - Moved wrappers from usolids module. 710 - Moved wrappers from usolids module.
738 Fixed internal dispatcher method for paramet 711 Fixed internal dispatcher method for parameterisation in all wrappers.
739 - Added switching mechanism for G4GenericPolyc 712 - Added switching mechanism for G4GenericPolycone, G4Polycone, G4Polyhedra
740 and G4Tet. 713 and G4Tet.
741 714
742 06-Nov-2013 G.Cosmo (geom-specific-V09-06-25) 715 06-Nov-2013 G.Cosmo (geom-specific-V09-06-25)
743 - Added switch mechanism for USolids (G4Generi 716 - Added switch mechanism for USolids (G4GenericPolycone, G4Polycone,
744 G4Polyhedra, G4Tet). Renamed related G4 type 717 G4Polyhedra, G4Tet). Renamed related G4 types to 'G4O'.
745 - Moved wrappers from USolids module. 718 - Moved wrappers from USolids module.
746 719
747 01-Nov-2013 G.Cosmo (geom-specific-V09-06-24) 720 01-Nov-2013 G.Cosmo (geom-specific-V09-06-24)
748 - Corrected CMake script. 721 - Corrected CMake script.
749 722
750 31-Oct-2013 G.Cosmo (geom-specific-V09-06-23) 723 31-Oct-2013 G.Cosmo (geom-specific-V09-06-23)
751 - Fix for in G4Polyhedra::SetOriginalParameter 724 - Fix for in G4Polyhedra::SetOriginalParameters(). (T.Nikitina)
752 - Moved G4PolyconeHistorical and G4PolyhedraHi 725 - Moved G4PolyconeHistorical and G4PolyhedraHistorical in separate
753 translation units. 726 translation units.
754 727
755 29-Oct-2013 T.Nikitina (geom-specific-V09-06- 728 29-Oct-2013 T.Nikitina (geom-specific-V09-06-22)
756 - Split G4Polycone for polycones with decreasi 729 - Split G4Polycone for polycones with decreasing Z-sections.
757 Introduced new class G4GenericPolycone. 730 Introduced new class G4GenericPolycone.
758 - Fixed conversion of generic construct for G4 731 - Fixed conversion of generic construct for G4Polyhedra.
759 732
760 17-Oct-2013 J.Apostolakis/A.Dotti (geom-speci 733 17-Oct-2013 J.Apostolakis/A.Dotti (geom-specific-V09-06-21)
761 - Cleanup of code for workspace. 734 - Cleanup of code for workspace.
762 735
763 16-Oct-2013 J.Apostolakis/A.Dotti (geom-speci 736 16-Oct-2013 J.Apostolakis/A.Dotti (geom-specific-V09-06-20)
764 - Created G4SolidsWorkspacePool class, to mana 737 - Created G4SolidsWorkspacePool class, to manage Workspaces
765 Fixed Singleton G4SolidsWorkspacePool for th 738 Fixed Singleton G4SolidsWorkspacePool for thread safe creation of object.
766 739
767 04-Oct-2013 J.Apostolakis (geom-specific-V09- 740 04-Oct-2013 J.Apostolakis (geom-specific-V09-06-19)
768 - Retagged. 741 - Retagged.
769 NOTE: requires tag "geommng-V09-06-12" and c 742 NOTE: requires tag "geommng-V09-06-12" and co-works with "geomvol-V09-06-13".
770 743
771 04-Oct-2013 J.Apostolakis (geom-specific-V09- 744 04-Oct-2013 J.Apostolakis (geom-specific-V09-06-18)
772 - Created G4SolidsWorkspace class, to create, 745 - Created G4SolidsWorkspace class, to create, initialize and destroy
773 per-thread state of PolyCone Sides and PolyH 746 per-thread state of PolyCone Sides and PolyHedra Sides.
774 747
775 27-Aug-2013 G.Cosmo (geom-specific-V09-06-17) 748 27-Aug-2013 G.Cosmo (geom-specific-V09-06-17)
776 - Enabled G4Ellipsoid for parameterisation. 749 - Enabled G4Ellipsoid for parameterisation.
777 750
778 14-Aug-2013 G.Cosmo (geom-specific-V09-06-16) 751 14-Aug-2013 G.Cosmo (geom-specific-V09-06-16)
779 - Move function-scoped 'static const' values f 752 - Move function-scoped 'static const' values for half-tolerances to private
780 data members of classes, to overcome false-p 753 data members of classes, to overcome false-positive race-conditions defects
781 reported by Valgrind in MT mode. 754 reported by Valgrind in MT mode.
782 - Fix in G4TessellatedSolid::DistanceToIn(p,v) 755 - Fix in G4TessellatedSolid::DistanceToIn(p,v) for specific cases where points
783 are located near surface (T.Nikitina). 756 are located near surface (T.Nikitina).
784 757
785 16-Jul-2013 M.Gayer (geom-specific-V09-06-15) 758 16-Jul-2013 M.Gayer (geom-specific-V09-06-15)
786 - Fix in G4SurfaceVoxelizer affecting tessella 759 - Fix in G4SurfaceVoxelizer affecting tessellated-solid (and extruded-solid)
787 for wrong computation of DistanceToIn(p,v) f 760 for wrong computation of DistanceToIn(p,v) for points outside, when
788 optimisation is active. 761 optimisation is active.
789 762
790 11-Jul-2013 G.Cosmo (geom-specific-V09-06-14) 763 11-Jul-2013 G.Cosmo (geom-specific-V09-06-14)
791 - Fixed compilation warning in G4Polycone on M 764 - Fixed compilation warning in G4Polycone on MacOS/clang.
792 765
793 09-Jul-2013 T.Nikitina (geom-specific-V09-06- 766 09-Jul-2013 T.Nikitina (geom-specific-V09-06-13)
794 - Extended method SetOriginalParameters() in G 767 - Extended method SetOriginalParameters() in G4Polycone in order to handle
795 all possible cases of conversion of generic 768 all possible cases of conversion of generic polycone to polycone with
796 (Rmin,Rmaz,Z) parameters. 769 (Rmin,Rmaz,Z) parameters.
797 Addressing problem report #1462. 770 Addressing problem report #1462.
798 771
799 03-Jun-2013 G.Cosmo (geom-specific-V09-06-12) 772 03-Jun-2013 G.Cosmo (geom-specific-V09-06-12)
800 - Fixed minor Coverity defect in G4PolyhedraSi 773 - Fixed minor Coverity defect in G4PolyhedraSide and G4PolyconeSide.
801 774
802 22-Apr-2013 J.Apostolakis (geom-specific-V09- 775 22-Apr-2013 J.Apostolakis (geom-specific-V09-06-11)
803 - Revised G4ExtrudedSolid::IsSameLine to use t 776 - Revised G4ExtrudedSolid::IsSameLine to use the perpendicular
804 distance to a line when deciding - not the y 777 distance to a line when deciding - not the y-intercept difference.
805 ( Issue responsible for a problem in Subtrac 778 ( Issue responsible for a problem in Subtraction Solid in Atlas.
806 Tatiana & Ivana contributed to debugging. 779 Tatiana & Ivana contributed to debugging. )
807 - Changed GNUmakefile in test directory to wor 780 - Changed GNUmakefile in test directory to work with Cmake and granular
808 builds. 781 builds.
809 782
810 16-Apr-2013 T.Nikitina (geom-specific-V09-06- 783 16-Apr-2013 T.Nikitina (geom-specific-V09-06-10)
811 - Fix in calculation of normal in G4Tet::Dista 784 - Fix in calculation of normal in G4Tet::DistanceToOut(p,v,..) and
812 SurfaceNormal(p). 785 SurfaceNormal(p).
813 - Fix in G4Polycone::GetPointOnCone() for case 786 - Fix in G4Polycone::GetPointOnCone() for cases of shape with decreasing Z.
814 Fixes cases of false report for overlaps det 787 Fixes cases of false report for overlaps detection. Problem report #1462.
815 Added check with exception in constructor fo 788 Added check with exception in constructor for polycone with rInner > rOuter
816 for the same Z. 789 for the same Z.
817 790
818 18-Mar-2013 G.Cosmo (geom-specific-V09-06-09) 791 18-Mar-2013 G.Cosmo (geom-specific-V09-06-09)
819 - G4TessellatedSolid: fixed problem with navig 792 - G4TessellatedSolid: fixed problem with navigation in tessellated solids
820 with concave surfaces. Addresses problem rep 793 with concave surfaces. Addresses problem report #1456.
821 - More cleanup from MT changes in G4VTwistSurf 794 - More cleanup from MT changes in G4VTwistSurface and G4Tet.
822 795
823 12-Mar-2013 G.Cosmo (geom-specific-V09-06-08) 796 12-Mar-2013 G.Cosmo (geom-specific-V09-06-08)
824 - Added public accessors for MT data to G4Poly 797 - Added public accessors for MT data to G4PolyconeSide and G4PolyhedraSide.
825 798
826 11-Mar-2013 G.Cosmo (geom-specific-V09-06-07) 799 11-Mar-2013 G.Cosmo (geom-specific-V09-06-07)
827 - Redefined G4DLL_API to G4GEOM_DLL to avoid c 800 - Redefined G4DLL_API to G4GEOM_DLL to avoid cases of macro redefinition.
828 801
829 08-Mar-2013 G.Cosmo (geom-specific-V09-06-06) 802 08-Mar-2013 G.Cosmo (geom-specific-V09-06-06)
830 - Renamed G4MT macros to safer ID in G4Polycon 803 - Renamed G4MT macros to safer ID in G4PolyconeSide and G4PolyhedraSide.
831 804
832 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05) 805 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05)
833 - Adopt G4GeomSplitter instead of G4MTTransito 806 - Adopt G4GeomSplitter instead of G4MTTransitory in G4PolyconeSide and
834 G4PolyhedraSide. Fixed import/export of stat 807 G4PolyhedraSide. Fixed import/export of static symbols for WIN32 DLLs build.
835 808
836 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04) 809 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04)
837 - Cleanup changes for multi-threading in G4Tet 810 - Cleanup changes for multi-threading in G4Tet, G4VTwistSurface,
838 G4PolyconeSide and G4PolyhedraSide. 811 G4PolyconeSide and G4PolyhedraSide.
839 - Removed unused private data member in G4Twis 812 - Removed unused private data member in G4TwistTrapParallelSide.
840 813
841 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05) 814 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05)
842 - Adopt G4GeomSplitter instead of G4MTTransito 815 - Adopt G4GeomSplitter instead of G4MTTransitory in G4PolyconeSide and
843 G4PolyhedraSide. Fixed import/export of stat 816 G4PolyhedraSide. Fixed import/export of static symbols for WIN32 DLLs build.
844 817
845 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04) 818 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04)
846 - Cleanup changes for multi-threading in G4Tet 819 - Cleanup changes for multi-threading in G4Tet, G4VTwistSurface,
847 G4PolyconeSide and G4PolyhedraSide. 820 G4PolyconeSide and G4PolyhedraSide.
848 - Removed unused private data member in G4Twis 821 - Removed unused private data member in G4TwistTrapParallelSide.
849 822
850 11-Jan-2013 G.Cosmo (geom-specific-V09-06-03) 823 11-Jan-2013 G.Cosmo (geom-specific-V09-06-03)
851 - Fixed condition in G4VTwistSurface::GetBound 824 - Fixed condition in G4VTwistSurface::GetBoundaryLimit() for logical error.
852 Addressing problem report #1420. 825 Addressing problem report #1420.
853 826
854 20-Dec-2012 M.Gayer (geom-specific-V09-06-02) 827 20-Dec-2012 M.Gayer (geom-specific-V09-06-02)
855 - Fixed cases of hang-ups in G4ExtrudedSolid o 828 - Fixed cases of hang-ups in G4ExtrudedSolid on 32-bits platforms, due to
856 G4TessellatedSolid and G4SurfVoxelizer, caus 829 G4TessellatedSolid and G4SurfVoxelizer, caused by accessing bitmask arrays
857 with negative indexes. The problem was relat 830 with negative indexes. The problem was related to floating-point rounding,
858 which can be different even on same platform 831 which can be different even on same platform with debug/release version.
859 Assure same number of computed voxels on 32- 832 Assure same number of computed voxels on 32-bit/64-bit platforms.
860 Fixed error in SetVertexIndex() method, whic 833 Fixed error in SetVertexIndex() method, which might cause problems on
861 certain configurations even for 64-bit syste 834 certain configurations even for 64-bit systems. Fixed minor memory leaks.
862 - Code cleanup for use of G4endl and tabs... 835 - Code cleanup for use of G4endl and tabs...
863 836
864 14-Dec-2012 G.Cosmo (geom-specific-V09-06-01) 837 14-Dec-2012 G.Cosmo (geom-specific-V09-06-01)
865 - Restored SVN id headers. 838 - Restored SVN id headers.
866 839
867 02-Dec-2012 J.Allison (geom-specific-V09-06-0 840 02-Dec-2012 J.Allison (geom-specific-V09-06-00)
868 - Removed NURBS. 841 - Removed NURBS.
869 842
870 29-Nov-2012 G.Cosmo (geom-specific-V09-05-24) 843 29-Nov-2012 G.Cosmo (geom-specific-V09-05-24)
871 - Remove inclusion of G4PhysicalConstants.hh f 844 - Remove inclusion of G4PhysicalConstants.hh from G4SurfaceVoxelizer.hh.
872 - Fixed unit test for compilation errors. 845 - Fixed unit test for compilation errors.
873 846
874 28-Nov-2012 G.Cosmo (geom-specific-V09-05-23) 847 28-Nov-2012 G.Cosmo (geom-specific-V09-05-23)
875 - Fixed more cases of inclusion of constants h 848 - Fixed more cases of inclusion of constants header.
876 849
877 23-Nov-2012 G.Cosmo (geom-specific-V09-05-22) 850 23-Nov-2012 G.Cosmo (geom-specific-V09-05-22)
878 - Added 'const' qualifiers to signature in G4V 851 - Added 'const' qualifiers to signature in G4VoxelComparator::operator()
879 for porting on AIX-xlC compiler. 852 for porting on AIX-xlC compiler.
880 853
881 14-Nov-2012 P.Mato (geom-specific-V09-05-21) 854 14-Nov-2012 P.Mato (geom-specific-V09-05-21)
882 - Added #undef NDEBUG in unit tests to ensure 855 - Added #undef NDEBUG in unit tests to ensure assert works also in
883 full optimised mode. 856 full optimised mode.
884 857
885 14-Nov-2012 P. Mato (geom-specific-V09-05-20) 858 14-Nov-2012 P. Mato (geom-specific-V09-05-20)
886 - Added #undef NDEBUG in unit tests to ensure 859 - Added #undef NDEBUG in unit tests to ensure that assert always works
887 860
888 13-Nov-2012 M.Gayer (geom-specific-V09-05-19) 861 13-Nov-2012 M.Gayer (geom-specific-V09-05-19)
889 - More fixes for out-of-bound array accesses i 862 - More fixes for out-of-bound array accesses in G4SurfaceVoxelizer.
890 863
891 12-Nov-2012 M.Gayer (geom-specific-V09-05-18) 864 12-Nov-2012 M.Gayer (geom-specific-V09-05-18)
892 - Fixed out-of-bound array access in BuildRedu 865 - Fixed out-of-bound array access in BuildReduceVoxels2().
893 866
894 06-Nov-2012 G.Cosmo (geom-specific-V09-05-17) 867 06-Nov-2012 G.Cosmo (geom-specific-V09-05-17)
895 - Correction in sources.cmake script for missi 868 - Correction in sources.cmake script for missing .icc file.
896 869
897 06-Nov-2012 G.Cosmo (geom-specific-V09-05-16) 870 06-Nov-2012 G.Cosmo (geom-specific-V09-05-16)
898 - Fixed Coverity defects in new code (M.Gayer) 871 - Fixed Coverity defects in new code (M.Gayer).
899 - Minor fixes for porting on AIX. 872 - Minor fixes for porting on AIX.
900 873
901 01-Nov-2012 G.Cosmo (geom-specific-V09-05-15) 874 01-Nov-2012 G.Cosmo (geom-specific-V09-05-15)
902 - Fixed compilation of debug code under G4SPEC 875 - Fixed compilation of debug code under G4SPECSDEBUG.
903 876
904 01-Nov-2012 M.Gayer (geom-specific-V09-05-14) 877 01-Nov-2012 M.Gayer (geom-specific-V09-05-14)
905 - Corrected signature for voxels count methods 878 - Corrected signature for voxels count methods in G4SurfaceVoxelizer.
906 879
907 31-Oct-2012 M.Gayer (geom-specific-V09-05-13) 880 31-Oct-2012 M.Gayer (geom-specific-V09-05-13)
908 - Added set/get methods for voxels count in G4 881 - Added set/get methods for voxels count in G4SurfaceVoxelizer.
909 882
910 30-Oct-2012 M.Gayer (geom-specific-V09-05-12) 883 30-Oct-2012 M.Gayer (geom-specific-V09-05-12)
911 - Fixed indexing of vertices in facets for tes 884 - Fixed indexing of vertices in facets for tessellated-solid and some cleanup.
912 885
913 27-Oct-2012 G.Cosmo (geom-specific-V09-05-11) 886 27-Oct-2012 G.Cosmo (geom-specific-V09-05-11)
914 - Fixed initialization of data in G4SurfaceVox 887 - Fixed initialization of data in G4SurfaceVoxelizer (M.Gayer).
915 - Added post-const qualifier to G4VertextCompa 888 - Added post-const qualifier to G4VertextComparator::operator() in
916 G4TessellatedSolid. 889 G4TessellatedSolid.
917 - Fixed more compilation warnings on unused va 890 - Fixed more compilation warnings on unused variable.
918 891
919 26-Oct-2012 G.Cosmo (geom-specific-V09-05-10) 892 26-Oct-2012 G.Cosmo (geom-specific-V09-05-10)
920 - Corrected compilation problem on G4SurfBits 893 - Corrected compilation problem on G4SurfBits for use of fprint().
921 - Polished comments in disclaimer in new updat 894 - Polished comments in disclaimer in new updated classes.
922 895
923 25-Oct-2012 G.Cosmo (geom-specific-V09-05-09) 896 25-Oct-2012 G.Cosmo (geom-specific-V09-05-09)
924 - Corrected compilation warnings on Linux and 897 - Corrected compilation warnings on Linux and fixed use of memset/memcpy.
925 898
926 25-Oct-2012 G.Cosmo (geom-specific-V09-05-08) 899 25-Oct-2012 G.Cosmo (geom-specific-V09-05-08)
927 - Correction to sources.cmake. 900 - Correction to sources.cmake.
928 901
929 19-Oct-2012 M.Gayer (geom-specific-V09-05-07) 902 19-Oct-2012 M.Gayer (geom-specific-V09-05-07)
930 - Complete rewrite of G4TessellatedSolid resul 903 - Complete rewrite of G4TessellatedSolid resulting in reduced memory
931 requirements by 50%, and factor of tens or m 904 requirements by 50%, and factor of tens or more speedup for number of facets
932 of the order of thousands, thanks to ad-hoc 905 of the order of thousands, thanks to ad-hoc voxelization of the surface.
933 Factor of thousands speedup when number of f 906 Factor of thousands speedup when number of facets of the order of hundreds
934 thousand. New classes introduced, G4SurfBits 907 thousand. New classes introduced, G4SurfBits and G4SurfaceVoxelizer.
935 908
936 12-Jun-2012 G.Cosmo (geom-specific-V09-05-06) 909 12-Jun-2012 G.Cosmo (geom-specific-V09-05-06)
937 - Explicitly use inclusion of headers for syst 910 - Explicitly use inclusion of headers for system of units and physical
938 constants, in plan to remove implicit inclus 911 constants, in plan to remove implicit inclusion from globals.hh.
939 912
940 14-May-2012 G.Cosmo (geom-specific-V09-05-05) 913 14-May-2012 G.Cosmo (geom-specific-V09-05-05)
941 - Fixed spurious cases of hidden variable visi 914 - Fixed spurious cases of hidden variable visibility, detected with
942 '-Wshadow' compilation option on gcc compile 915 '-Wshadow' compilation option on gcc compiler.
943 916
944 06-Apr-2012 M.Kelsey (geom-specific-V09-05-04 917 06-Apr-2012 M.Kelsey (geom-specific-V09-05-04)
945 - Modified GetPointOnSurface() to throw sqrt(r 918 - Modified GetPointOnSurface() to throw sqrt(r) uniformly for disk surfaces,
946 in G4Paraboloid, G4Polycone and G4TwistedTub 919 in G4Paraboloid, G4Polycone and G4TwistedTubs.
947 920
948 13-Dec-2011 G.Cosmo (geom-specific-V09-05-03, 921 13-Dec-2011 G.Cosmo (geom-specific-V09-05-03, 02, 01)
949 - Fixed trivial Coverity defects in G4TwistedT 922 - Fixed trivial Coverity defects in G4TwistedTubs and G4VTwisteFaceted for
950 missing protection against self-assignment. 923 missing protection against self-assignment.
951 924
952 09-Dec-2011 T.Nikitina (geom-specific-V09-05- 925 09-Dec-2011 T.Nikitina (geom-specific-V09-05-00)
953 - Fix in G4EllipticalCone in DistanceToIn(p,v) 926 - Fix in G4EllipticalCone in DistanceToIn(p,v) to exclude imaginary solution
954 (virtual cone) when distance is calculated. 927 (virtual cone) when distance is calculated.
955 928
956 10-Nov-2011 G.Cosmo (geom-specific-V09-04-09) 929 10-Nov-2011 G.Cosmo (geom-specific-V09-04-09)
957 - Fixed trivial Coverity defects on assignment 930 - Fixed trivial Coverity defects on assignment operators...
958 931
959 25-Oct-2011 G.Cosmo (geom-specific-V09-04-08) 932 25-Oct-2011 G.Cosmo (geom-specific-V09-04-08)
960 - Fixed logic in G4VTwistSurface::GetEdgeVisib 933 - Fixed logic in G4VTwistSurface::GetEdgeVisibility() in treatment of corners.
961 934
962 16-Sep-2011 G.Cosmo (geom-specific-V09-04-07) 935 16-Sep-2011 G.Cosmo (geom-specific-V09-04-07)
963 - Fix compilation error in code within G4SPECS 936 - Fix compilation error in code within G4SPECSDEBUG. No functional changes.
964 937
965 13-Sep-2011 I.Hrivnacova (geom-specific-V09-0 938 13-Sep-2011 I.Hrivnacova (geom-specific-V09-04-06)
966 - G4TriangularFacet: fixed tests where square 939 - G4TriangularFacet: fixed tests where square root was compared to
967 half Cartesian tolerance; now compared to kC 940 half Cartesian tolerance; now compared to kCarTolerance.
968 Addressing problem report #1242. 941 Addressing problem report #1242.
969 942
970 25-Aug-2011 G.Cosmo 943 25-Aug-2011 G.Cosmo
971 - Migrated to new G4Exception scheme for warni 944 - Migrated to new G4Exception scheme for warnings and errors.
972 - Defined scheme for warnings/errors coding: 945 - Defined scheme for warnings/errors coding:
973 + 1xxx for warnings, 0xxx for errors. 946 + 1xxx for warnings, 0xxx for errors.
974 Code numbering: 947 Code numbering:
975 + 0001: not supported or implemented feature 948 + 0001: not supported or implemented features;
976 + 0002: invalid setup/construct; 949 + 0002: invalid setup/construct;
977 + 0003: invalid run condition; 950 + 0003: invalid run condition;
978 + 1001: incorrect setup; automatically adapt 951 + 1001: incorrect setup; automatically adapted.
979 + 1002: notification. 952 + 1002: notification.
980 - Added unit test for G4ExtrudedSolid (J.Apost 953 - Added unit test for G4ExtrudedSolid (J.Apostolakis).
981 954
982 22-Aug-2011 I.Hrivnacova (geom-specific-V09-0 955 22-Aug-2011 I.Hrivnacova (geom-specific-V09-04-05)
983 - Fix in G4TriangularFacet::Intersect() to tak 956 - Fix in G4TriangularFacet::Intersect() to take into account geometrical
984 tolerance and cases of zero distance from su 957 tolerance and cases of zero distance from surface's facet.
985 - Fix in G4TessellatedSolid::DistanceToOut(p) 958 - Fix in G4TessellatedSolid::DistanceToOut(p) and DistanceToIn(p) to exactly
986 compute distance from facet avoiding use of 959 compute distance from facet avoiding use of 'outgoing' flag shortcut variant.
987 - Addressing problem report #1242. 960 - Addressing problem report #1242.
988 961
989 17-Aug-2011 T.Nikitina (geom-specific-V09-04- 962 17-Aug-2011 T.Nikitina (geom-specific-V09-04-04)
990 - Fix in G4Paraboloid::DistanceToIn(p,v) and D 963 - Fix in G4Paraboloid::DistanceToIn(p,v) and DistanceToIn(p) to properly
991 take into account tolerance and provide bett 964 take into account tolerance and provide better estimation of distance
992 respectively. Addresses problem report #1234 965 respectively. Addresses problem report #1234.
993 966
994 04-Aug-2011 T.Nikitina (geom-specific-V09-04- 967 04-Aug-2011 T.Nikitina (geom-specific-V09-04-03)
995 - Added SetReferences() and InvertFacets() to 968 - Added SetReferences() and InvertFacets() to G4GenericTrap::CreatePolyhedron()
996 for proper visualisation of Boolean composit 969 for proper visualisation of Boolean compositions with G4GenericTrap.
997 - Added SetReferences() to G4TessellatedSolid: 970 - Added SetReferences() to G4TessellatedSolid::CreatePolyhedron()
998 for proper visualisation of Boolean composit 971 for proper visualisation of Boolean compositions with G4TessellatedSolid.
999 - Requires tag "greps-V09-04-04", for addressi 972 - Requires tag "greps-V09-04-04", for addressing problem report #1235.
1000 973
1001 17-May-2011 I.Hrivnacova (geom-specific-V09- 974 17-May-2011 I.Hrivnacova (geom-specific-V09-04-02)
1002 - G4ExtrudedSolid: fix in Inside(p) for false 975 - G4ExtrudedSolid: fix in Inside(p) for false overlap reporting.
1003 Addressing problem report #1211. 976 Addressing problem report #1211.
1004 977
1005 12-May-2011 G.Cosmo (geom-specific-V09-04-01 978 12-May-2011 G.Cosmo (geom-specific-V09-04-01)
1006 - Fixed compilation warnings from gcc-4.6.0 f 979 - Fixed compilation warnings from gcc-4.6.0 for variables set but not used.
1007 980
1008 06-May-2011 G.Cosmo (geom-specific-V09-04-00 981 06-May-2011 G.Cosmo (geom-specific-V09-04-00)
1009 - Use G4 typedef for CLHEP types. 982 - Use G4 typedef for CLHEP types.
1010 983
1011 26-Nov-2010 T.Nikitina (geom-specific-V09-03 984 26-Nov-2010 T.Nikitina (geom-specific-V09-03-20)
1012 - Fixes in G4GenericTrap reported by SBT unit 985 - Fixes in G4GenericTrap reported by SBT unit test in SurfaceNormal(),
1013 DistanceToPlane() and VisExtent(). 986 DistanceToPlane() and VisExtent().
1014 987
1015 16-Nov-2010 T.Nikitina (geom-specific-V09-03 988 16-Nov-2010 T.Nikitina (geom-specific-V09-03-19)
1016 - G4EllipticalCone: fixes in DistanceToIn(p,v 989 - G4EllipticalCone: fixes in DistanceToIn(p,v) and DistanceToOut(p,v) for
1017 correct handling of point on the surface. 990 correct handling of point on the surface.
1018 Corrected formula for SurfaceNormal(p). 991 Corrected formula for SurfaceNormal(p).
1019 992
1020 10-Nov-2010 T.Nikitina (geom-specific-V09-03 993 10-Nov-2010 T.Nikitina (geom-specific-V09-03-18)
1021 - Added checks on crossing of vertices and to 994 - Added checks on crossing of vertices and too big twisted angle in
1022 G4GenericTrap. 995 G4GenericTrap.
1023 - Fixed case of division by zero in G4Twisted 996 - Fixed case of division by zero in G4TwistedTubs.
1024 - Added unit test for G4Polyhedra. 997 - Added unit test for G4Polyhedra.
1025 998
1026 02-Nov-2010 G.Cosmo (geom-specific-V09-03-17 999 02-Nov-2010 G.Cosmo (geom-specific-V09-03-17)
1027 - More fixes on Coverity reports for G4Tessel 1000 - More fixes on Coverity reports for G4TessellatedSolid and G4ReduciblePolygon.
1028 1001
1029 20-Oct-2010 G.Cosmo (geom-specific-V09-03-16 1002 20-Oct-2010 G.Cosmo (geom-specific-V09-03-16)
1030 - Implemented Clone() virtual method for all 1003 - Implemented Clone() virtual method for all solids, returning a pointer
1031 to a dynamically allocated copy of the soli 1004 to a dynamically allocated copy of the solid. To be used by Geant4-MT.
1032 1005
1033 23-Sep-2010 G.Cosmo (geom-specific-V09-03-15 1006 23-Sep-2010 G.Cosmo (geom-specific-V09-03-15)
1034 - Initialize fpPolyhedron to zero in copy-cto 1007 - Initialize fpPolyhedron to zero in copy-ctor and operator=().
1035 - Completed implementation of copy-ctor and o 1008 - Completed implementation of copy-ctor and operator=() for facets.
1036 1009
1037 20-Sep-2010 G.Cosmo (geom-specific-V09-03-14 1010 20-Sep-2010 G.Cosmo (geom-specific-V09-03-14)
1038 - Implemented copy-constructor and assignment 1011 - Implemented copy-constructor and assignment operator for all solids
1039 to facilitate conversion to Geant4-MT. 1012 to facilitate conversion to Geant4-MT.
1040 1013
1041 08-Sep-2010 G.Cosmo (geom-specific-V09-03-13 1014 08-Sep-2010 G.Cosmo (geom-specific-V09-03-13)
1042 - Correction to previous fix in G4ReduciblePo 1015 - Correction to previous fix in G4ReduciblePolygon to avoid deleting current
1043 'vertexHead' pointer. 1016 'vertexHead' pointer.
1044 1017
1045 07-Sep-2010 G.Cosmo (geom-specific-V09-03-12 1018 07-Sep-2010 G.Cosmo (geom-specific-V09-03-12)
1046 - Fix within G4CSGDEBUG code for restoring co 1019 - Fix within G4CSGDEBUG code for restoring cout precision.
1047 - Fix in G4ReduciblePolygon::RemoveRedundantV 1020 - Fix in G4ReduciblePolygon::RemoveRedundantVertices() to avoid potential
1048 case of dereferencing freed pointer. 1021 case of dereferencing freed pointer.
1049 1022
1050 19-Aug-2010 T.Nikitina (geom-specific-V09-03 1023 19-Aug-2010 T.Nikitina (geom-specific-V09-03-11)
1051 - G4EllipticalTube: extended implementation o 1024 - G4EllipticalTube: extended implementation of SurfaceNormal(p) in agreement
1052 with canonical form. Added unit test testG4 1025 with canonical form. Added unit test testG4EllipticalTube.cc.
1053 1026
1054 16-Jul-2010 G.Cosmo (geom-specific-V09-03-10 1027 16-Jul-2010 G.Cosmo (geom-specific-V09-03-10)
1055 - Fixed cases of division by zero in G4VTwist 1028 - Fixed cases of division by zero in G4VTwistSurface and G4TwistBoxSide.
1056 - Use INT_MAX as initialisation for max limit 1029 - Use INT_MAX as initialisation for max limits in G4SolidExtentList.
1057 1030
1058 12-Jul-2010 G.Cosmo (geom-specific-V09-03-09 1031 12-Jul-2010 G.Cosmo (geom-specific-V09-03-09)
1059 - Added dummy initialization to members in st 1032 - Added dummy initialization to members in struct
1060 G4PolyPhiFace::G4PolyPhiFaceEdge, struct G4 1033 G4PolyPhiFace::G4PolyPhiFaceEdge, struct G4ReduciblePolygon::ABVertex.
1061 G4Ellipsoid, G4EllipticalTube, G4EnclosingC 1034 G4Ellipsoid, G4EllipticalTube, G4EnclosingCylinder, G4ExtrudedSolid, G4Hype,
1062 G4IntersectingCone, G4Paraboloid, G4PolyPhi 1035 G4IntersectingCone, G4Paraboloid, G4PolyPhiFace, G4Polycone, G4PolyconeSide,
1063 G4Polyhedra, G4PolyhedraSide, G4Quadrangula 1036 G4Polyhedra, G4PolyhedraSide, G4QuadrangularFacet, G4ReduciblePolygon,
1064 G4TessellatedSolid, G4TriangularFacet, G4Tw 1037 G4TessellatedSolid, G4TriangularFacet, G4TwistBoxSide, G4TwistTrapAlphaSide,
1065 G4TwistTrapFlatSide, G4TwistTrapParallelSid 1038 G4TwistTrapFlatSide, G4TwistTrapParallelSide, G4TwistTubsFlatSide,
1066 G4TwistTubsHypeSide, G4TwistTubsSide, G4Twi 1039 G4TwistTubsHypeSide, G4TwistTubsSide, G4TwistedTubs, G4VCSGfaceted, G4VFacet,
1067 G4VTwistSurface, G4VTwistedFaceted. 1040 G4VTwistSurface, G4VTwistedFaceted.
1068 - Fixed case of dereferencing null pointer in 1041 - Fixed case of dereferencing null pointer in methods
1069 G4EllipticalTube::DistanceToOut(p,v), G4VCS 1042 G4EllipticalTube::DistanceToOut(p,v), G4VCSGfaceted::DistanceToIn(p,v)
1070 and G4VCSGfaceted::DistanceToOut(p,v). 1043 and G4VCSGfaceted::DistanceToOut(p,v).
1071 - Fixed unecessary object copy as argument in 1044 - Fixed unecessary object copy as argument in method
1072 G4PolyhedraSide::IntersectSidePlane(). 1045 G4PolyhedraSide::IntersectSidePlane().
1073 - Avoid possible case of derefencing null poi 1046 - Avoid possible case of derefencing null pointer in G4ReduciblePolygon
1074 RemoveDuplicateVertices() and RemoveRedunda 1047 RemoveDuplicateVertices() and RemoveRedundantVertices() methods.
1075 - Replaced calls to std::abs() with std::fabs 1048 - Replaced calls to std::abs() with std::fabs() where suitable.
1076 1049
1077 16-Jun-2010 G.Cosmo (geom-specific-V09-03-08 1050 16-Jun-2010 G.Cosmo (geom-specific-V09-03-08)
1078 - Fixed deletion of internal arrays in Create 1051 - Fixed deletion of internal arrays in CreatePolyhedron() for G4Polycone
1079 and G4Polyhedra. 1052 and G4Polyhedra.
1080 1053
1081 11-Jun-2010 T.Nikitina (geom-specific-V09-03 1054 11-Jun-2010 T.Nikitina (geom-specific-V09-03-07)
1082 - G4GenericTrap: fixed cases of zero dToIn/sT 1055 - G4GenericTrap: fixed cases of zero dToIn/sToOut when vertices are collapsed
1083 to triangle, line or point. Added new metho 1056 to triangle, line or point. Added new methods handling those specific cases.
1084 - Added unit test for G4GenericTrap. 1057 - Added unit test for G4GenericTrap.
1085 1058
1086 10-Jun-2010 I.Hrivnacova 1059 10-Jun-2010 I.Hrivnacova
1087 - G4GenericTrap: fixed parameter names in Cal 1060 - G4GenericTrap: fixed parameter names in CalculateExtent() for the test
1088 case construction through tessellated facet 1061 case construction through tessellated facets.
1089 1062
1090 09-Jun-2010 G.Cosmo 1063 09-Jun-2010 G.Cosmo
1091 - G4GenericTrap: moved internal methods to pr 1064 - G4GenericTrap: moved internal methods to private section and reordered
1092 in source file. Added missing implementatio 1065 in source file. Added missing implementation for IsTwisted() method.
1093 1066
1094 03-Jun-2010 T.Nikitina, G.Cosmo (geom-specif 1067 03-Jun-2010 T.Nikitina, G.Cosmo (geom-specific-V09-03-06)
1095 - G4GenericTrap: 1068 - G4GenericTrap:
1096 o Fixed initialization of fSurfaceArea and 1069 o Fixed initialization of fSurfaceArea and fCubicVolume and
1097 calculation of surface area. 1070 calculation of surface area.
1098 o Fixed error in Inside(p) function, and co 1071 o Fixed error in Inside(p) function, and corrected use std::fabs() instead
1099 of std::abs() for floating point values. 1072 of std::abs() for floating point values.
1100 o Added missing initialisation of fpPolyhed 1073 o Added missing initialisation of fpPolyhedron pointer.
1101 o More corrected signatures for use of non- 1074 o More corrected signatures for use of non-const references for vectors
1102 passed as arguments to functions. 1075 passed as arguments to functions.
1103 1076
1104 02-Jun-2010 G.Cosmo (geom-specific-V09-03-05 1077 02-Jun-2010 G.Cosmo (geom-specific-V09-03-05)
1105 - G4GenericTrap: use const reference for vect 1078 - G4GenericTrap: use const reference for vector of vertices passed as argument
1106 in constructor and accessor. 1079 in constructor and accessor.
1107 1080
1108 27-May-2010 T.Nikitina (geom-specific-V09-03 1081 27-May-2010 T.Nikitina (geom-specific-V09-03-04)
1109 - First implementation of G4GenericTrap shape 1082 - First implementation of G4GenericTrap shape, a new solid representing an
1110 arbitrary trapezoid with up to 8 vertices s 1083 arbitrary trapezoid with up to 8 vertices standing on two parallel planes
1111 perpendicular to the Z axis. 1084 perpendicular to the Z axis.
1112 1085
1113 28-Apr-2010 P.R.Truscott (geom-specific-V09- 1086 28-Apr-2010 P.R.Truscott (geom-specific-V09-03-03)
1114 - Fix in G4TriangularFacet and G4TessellatedS 1087 - Fix in G4TriangularFacet and G4TessellatedSolid to correct treatment of
1115 optical photon transport related to interna 1088 optical photon transport related to internal reflection at surface.
1116 Addresses problem report #1103. 1089 Addresses problem report #1103.
1117 1090
1118 15-Apr-2010 I.Hrivnacova (geom-specific-V09- 1091 15-Apr-2010 I.Hrivnacova (geom-specific-V09-03-02)
1119 - G4ExtrudedSolid: eliminated requirement for 1092 - G4ExtrudedSolid: eliminated requirement for clockwise ordering of polygon
1120 vertices. Added a check for vertices orderi 1093 vertices. Added a check for vertices ordering; if vertices are defined
1121 anti-clockwise their ordering is reverted. 1094 anti-clockwise their ordering is reverted.
1122 Fix in polygon facet triangularization for 1095 Fix in polygon facet triangularization for consequent concave vertices.
1123 1096
1124 24-Feb-2010 G.Cosmo (geom-specific-V09-03-01 1097 24-Feb-2010 G.Cosmo (geom-specific-V09-03-01)
1125 - Adopt caching of Phi in G4PolyconeSide and 1098 - Adopt caching of Phi in G4PolyconeSide and G4PolyhedraSide to avoid
1126 unnecessary consecutive computations on the 1099 unnecessary consecutive computations on the same point.
1127 1100
1128 10-Feb-2010 G.Cosmo (geom-specific-V09-03-00 1101 10-Feb-2010 G.Cosmo (geom-specific-V09-03-00)
1129 - Use kInfinity for initialising minimum and 1102 - Use kInfinity for initialising minimum and maximum allowed extent for
1130 G4SolidExtentList of faceted solids. 1103 G4SolidExtentList of faceted solids.
1131 1104
1132 11-Nov-2009 G.Cosmo (geom-specific-V09-02-08 1105 11-Nov-2009 G.Cosmo (geom-specific-V09-02-08)
1133 - Avoid fake (and redundant) assignment of va 1106 - Avoid fake (and redundant) assignment of value to 3-vector in
1134 G4PolyconeSide and G4TwistTubsSide. 1107 G4PolyconeSide and G4TwistTubsSide.
1135 1108
1136 24-Sep-2009 T.Nikitina (geom-specific-V09-02 1109 24-Sep-2009 T.Nikitina (geom-specific-V09-02-07)
1137 - G4Ellipsoid: refined fix in DistanceToIn(p, 1110 - G4Ellipsoid: refined fix in DistanceToIn(p,v) for points located on the
1138 curved surface, and correct treatment of ge 1111 curved surface, and correct treatment of geometrical tolerance.
1139 1112
1140 09-Sep-2009 G.Cosmo (geom-specific-V09-02-06 1113 09-Sep-2009 G.Cosmo (geom-specific-V09-02-06)
1141 - G4Ellipsoid: fixed usage of half-tolerances 1114 - G4Ellipsoid: fixed usage of half-tolerances (radial and Cartesian) in
1142 DistanceToIn(p,v), based on incorrect assum 1115 DistanceToIn(p,v), based on incorrect assumptions introduced in tag
1143 "geom-specific-V09-02-04", responsible for 1116 "geom-specific-V09-02-04", responsible for zero steps on configurations
1144 with cut in Z. Addresses problem report #10 1117 with cut in Z. Addresses problem report #1076.
1145 1118
1146 04-Aug-2009 T.Nikitina (geom-specific-V09-02 1119 04-Aug-2009 T.Nikitina (geom-specific-V09-02-05)
1147 - G4Ellipsoid: 1120 - G4Ellipsoid:
1148 o Fixes in Inside(p) and in DistanceToIn(p, 1121 o Fixes in Inside(p) and in DistanceToIn(p,v) for points
1149 located on the curved surface within tole 1122 located on the curved surface within tolerance. Final fix for issue
1150 reported in problem report #1050 and conc 1123 reported in problem report #1050 and concerning warnings reported by
1151 grid_test. 1124 grid_test.
1152 o Adopt pre-computed half-tolerance values 1125 o Adopt pre-computed half-tolerance values for optimisation.
1153 1126
1154 23-Jul-2009 T.Nikitina (geom-specific-V09-02 1127 23-Jul-2009 T.Nikitina (geom-specific-V09-02-04)
1155 - G4Ellipsoid: fix to DistanceToIn(p,v) in th 1128 - G4Ellipsoid: fix to DistanceToIn(p,v) in the calculation of the roots of
1156 the quadratic equation and in DistanceToOut 1129 the quadratic equation and in DistanceToOut(p,v) in the calculation of the
1157 normal on cut surfaces. Final fix for probl 1130 normal on cut surfaces. Final fix for problem report #1022 and #1050.
1158 - G4PolyconeSide: added protection in method 1131 - G4PolyconeSide: added protection in method Normal(), addressing problem
1159 report #1073. 1132 report #1073.
1160 1133
1161 30-Jun-2009 T.Nikitina (geom-specific-V09-02 1134 30-Jun-2009 T.Nikitina (geom-specific-V09-02-03)
1162 - G4Ellipsoid: introduced to DistanceToIn(p,v 1135 - G4Ellipsoid: introduced to DistanceToIn(p,v) splitting of the distance for
1163 point very far from intersection area and b 1136 point very far from intersection area and big difference between solid
1164 dimensions and distance to it; resolves iss 1137 dimensions and distance to it; resolves issue observed on 64 bits problem.
1165 Also addressing problem report #1022. 1138 Also addressing problem report #1022.
1166 1139
1167 08-May-2009, G.Cosmo (geom-specific-V09-02-02 1140 08-May-2009, G.Cosmo (geom-specific-V09-02-02)
1168 - Corrected typo in base implementation of G4 1141 - Corrected typo in base implementation of G4VCSGfaceted::GetSurfaceArea(),
1169 which was erroneously returning cubic volum 1142 which was erroneously returning cubic volume estimation.
1170 Addresses problem report #1062. 1143 Addresses problem report #1062.
1171 1144
1172 27-Apr-2009, G.Cosmo (geom-specific-V09-02-01 1145 27-Apr-2009, G.Cosmo (geom-specific-V09-02-01)
1173 - Relaxed error condition in G4TessellatedSol 1146 - Relaxed error condition in G4TessellatedSolid::Inside(p) to warning, for
1174 excess of max trials and anomalous conditio 1147 excess of max trials and anomalous conditions in distance calculation.
1175 Added more printout information when error 1148 Added more printout information when error condition is detected.
1176 1149
1177 27-Feb-2009, T.Nikitina (geom-specific-V09-02 1150 27-Feb-2009, T.Nikitina (geom-specific-V09-02-00)
1178 - Fix in G4Paraboloid::DistanceToOut(p,v,..) 1151 - Fix in G4Paraboloid::DistanceToOut(p,v,..) for the computation of normal
1179 to surface; added missing normalisation to 1152 to surface; added missing normalisation to unit, following remark in the
1180 Geometry Forum Hypernews posting #953. 1153 Geometry Forum Hypernews posting #953.
1181 1154
1182 21-Nov-2008, G.Cosmo (geom-specific-V09-01-19 1155 21-Nov-2008, G.Cosmo (geom-specific-V09-01-19)
1183 - Added missing accessors to G4EllipticalCone 1156 - Added missing accessors to G4EllipticalCone, required for detector
1184 persistency. 1157 persistency.
1185 1158
1186 13-Nov-2008, G.Cosmo (geom-specific-V09-01-18 1159 13-Nov-2008, G.Cosmo (geom-specific-V09-01-18)
1187 - Corrected initialisation of algorithm in G4 1160 - Corrected initialisation of algorithm in G4TriangularFacet constructor.
1188 1161
1189 30-Oct-2008, I.Hrivnacova (geom-specific-V09- 1162 30-Oct-2008, I.Hrivnacova (geom-specific-V09-01-17)
1190 - G4ExtrudedSolid: fixed bug in the decomposi 1163 - G4ExtrudedSolid: fixed bug in the decomposition of polygonal sides for
1191 quadrangular facets in MakeFacets(). Addres 1164 quadrangular facets in MakeFacets(). Addresses problem report #1029.
1192 1165
1193 23-Sep-2008, T.Nikitina (geom-specific-V09-01 1166 23-Sep-2008, T.Nikitina (geom-specific-V09-01-16)
1194 - Corrected algorithm in G4TriangularFacet::G 1167 - Corrected algorithm in G4TriangularFacet::GetPointOnFace() according to
1195 suggestion advanced in problem report #1025 1168 suggestion advanced in problem report #1025. Fixes a problem of false
1196 overlaps detection related to G4ExtrudedSol 1169 overlaps detection related to G4ExtrudedSolid and G4TessellatedSolid.
1197 1170
1198 12-Sep-2008, G.Cosmo (geom-specific-V09-01-15 1171 12-Sep-2008, G.Cosmo (geom-specific-V09-01-15)
1199 - G4VFacet: corrected increment of indeces in 1172 - G4VFacet: corrected increment of indeces in operator==(), following
1200 problem report #1024. 1173 problem report #1024.
1201 1174
1202 25-Jul-2008, I.Hrivnacova (geom-specific-V09- 1175 25-Jul-2008, I.Hrivnacova (geom-specific-V09-01-14)
1203 - G4ExtrudedSolid: fix in polygon decompositi 1176 - G4ExtrudedSolid: fix in polygon decomposition; systematically use
1204 half kCarTolerance instead of kCarTolerance 1177 half kCarTolerance instead of kCarTolerance; added solid name in the
1205 error messages coming from fatal exceptions 1178 error messages coming from fatal exceptions.
1206 1179
1207 16-Jul-2008, T.Nikitina (geom-specific-V09-01 1180 16-Jul-2008, T.Nikitina (geom-specific-V09-01-13)
1208 - G4Paraboloid: revised DistanceToOut(p,v,... 1181 - G4Paraboloid: revised DistanceToOut(p,v,...) in answer to problem report
1209 #1015. Fixed precision problem when solving 1182 #1015. Fixed precision problem when solving quadratic equation; apply
1210 comparison with kCarTolerance and not with 1183 comparison with kCarTolerance and not with zero; fixed logic problem in
1211 algoritm for points on surface and directio 1184 algoritm for points on surface and direction inside, relative to directions
1212 along Z, (0,0,Vz). 1185 along Z, (0,0,Vz).
1213 1186
1214 22-May-2008, G.Cosmo (geom-specific-V09-01-12 1187 22-May-2008, G.Cosmo (geom-specific-V09-01-12)
1215 - Removed left-over debug printout in G4VCSGF 1188 - Removed left-over debug printout in G4VCSGFaceted::DistanceToIn().
1216 1189
1217 15-May-2008, T.Nikitina (geom-specific-V09-01 1190 15-May-2008, T.Nikitina (geom-specific-V09-01-11)
1218 - Enhanced GetPointOnSurface() for generic G4 1191 - Enhanced GetPointOnSurface() for generic G4Polycone and G4Polyhedra
1219 constructs; the method uses new triangulati 1192 constructs; the method uses new triangulation algorithm for G4PolyPhiFace.
1220 - G4ExtrudedSolid: added missing 'std' namesp 1193 - G4ExtrudedSolid: added missing 'std' namespace to standard mathematical
1221 function calls. 1194 function calls.
1222 1195
1223 28-Apr-2008, T.Nikitina (geom-specific-V09-01 1196 28-Apr-2008, T.Nikitina (geom-specific-V09-01-10)
1224 - Added kCarTolerance in definition of "low" 1197 - Added kCarTolerance in definition of "low" and "high" cone limits in R
1225 and in Z in order to protect against numeri 1198 and in Z in order to protect against numerical errors. This fixes cases of
1226 DistanceToIn(p,v) returning 'kInfinity' whe 1199 DistanceToIn(p,v) returning 'kInfinity' when p+t*v cross intersection
1227 between two cones. 1200 between two cones.
1228 1201
1229 25-Apr-2008, T.Nikitina (geom-specific-V09-01 1202 25-Apr-2008, T.Nikitina (geom-specific-V09-01-09)
1230 - Added protection against NaN in G4Intersect 1203 - Added protection against NaN in G4IntersectingCone::LineHitsCone1() in
1231 case of configuration where a conic section 1204 case of configuration where a conic section becomes a tube.
1232 - G4EllipticalCone: removed some debug printo 1205 - G4EllipticalCone: removed some debug printouts.
1233 1206
1234 14-Apr-2008, T.Nikitina (geom-specific-V09-01 1207 14-Apr-2008, T.Nikitina (geom-specific-V09-01-08)
1235 - G4Hype: refined polyhedron representation f 1208 - G4Hype: refined polyhedron representation for correct visualization of
1236 the shape. Coworks with tag "greps-V09-01-0 1209 the shape. Coworks with tag "greps-V09-01-04".
1237 1210
1238 13-Mar-2008, G.Cosmo (geom-specific-V09-01-07 1211 13-Mar-2008, G.Cosmo (geom-specific-V09-01-07)
1239 - Cleared compilation warnings in G4Paraboloi 1212 - Cleared compilation warnings in G4Paraboloid and G4TessellatedSolid
1240 on gcc-4.3.0 for ambiguous use of parenthes 1213 on gcc-4.3.0 for ambiguous use of parentheses in condition statements.
1241 1214
1242 28-Feb-2008, I.Hrivnacova (geom-specific-V09- 1215 28-Feb-2008, I.Hrivnacova (geom-specific-V09-01-06)
1243 - Correction to previous fix in G4ExtrudedSol 1216 - Correction to previous fix in G4ExtrudedSolid: testing on the edges has
1244 to be limited to the line segment, for this 1217 to be limited to the line segment, for this purpose a new internal method
1245 IsSameLineSegment() has been introduced for 1218 IsSameLineSegment() has been introduced for use instead of IsSameLine().
1246 - Updated and extended unit test testG4Extrud 1219 - Updated and extended unit test testG4ExtrudedSolid.cc.
1247 1220
1248 27-Feb-2008, I.Hrivnacova (geom-specific-V09- 1221 27-Feb-2008, I.Hrivnacova (geom-specific-V09-01-05)
1249 - Fix in G4TessellatedSolid::DistanceToOut(p, 1222 - Fix in G4TessellatedSolid::DistanceToOut(p,v,..) to compute normal only
1250 if specified by flag in input. 1223 if specified by flag in input.
1251 - Fix in G4ExtrudedSolid::Inside(p) for corre 1224 - Fix in G4ExtrudedSolid::Inside(p) for correctly handling the case of
1252 points located on the edges of triangles wh 1225 points located on the edges of triangles which are not the outline edges
1253 of the polygon. 1226 of the polygon.
1254 1227
1255 21-Feb-2008, T.Nikitina (geom-specific-V09-01 1228 21-Feb-2008, T.Nikitina (geom-specific-V09-01-04)
1256 - G4Polyhedra: fixed problem of out-of-bound 1229 - G4Polyhedra: fixed problem of out-of-bound access to vectors in
1257 GetPointOnSurface(). 1230 GetPointOnSurface().
1258 1231
1259 20-Feb-2008, I.Hrivnacova (geom-specific-V09- 1232 20-Feb-2008, I.Hrivnacova (geom-specific-V09-01-03)
1260 - G4TessellatedSolid: fixed bug in copy-const 1233 - G4TessellatedSolid: fixed bug in copy-constructor and internal method
1261 CopyObjects() for cloning of facets. 1234 CopyObjects() for cloning of facets.
1262 1235
1263 05-Feb-2008, I.Hrivnacova (geom-specific-V09- 1236 05-Feb-2008, I.Hrivnacova (geom-specific-V09-01-02)
1264 - G4ExtrudedSolid: bug fix in MakeFacets() to 1237 - G4ExtrudedSolid: bug fix in MakeFacets() to fill 'fTriangles' also in case
1265 of polygon with 3 or 4 vertices, as they ar 1238 of polygon with 3 or 4 vertices, as they are needed for Inside(p).
1266 1239
1267 02-Feb-2008, I.Hrivnacova (geom-specific-V09- 1240 02-Feb-2008, I.Hrivnacova (geom-specific-V09-01-01)
1268 - Corrected triangularization of polygon, now 1241 - Corrected triangularization of polygon, now correctly handling case
1269 of concave shapes. 1242 of concave shapes.
1270 - Corrected order of arguments in G4Paraboloi 1243 - Corrected order of arguments in G4Paraboloid constructor.
1271 1244
1272 16-Jan-2008, I.Hrivnacova (geom-specific-V09- 1245 16-Jan-2008, I.Hrivnacova (geom-specific-V09-01-00)
1273 - In G4ExtrudedSolid::MakeFacets(), now addin 1246 - In G4ExtrudedSolid::MakeFacets(), now adding triangular facets before quadrangular
1274 ones, following logic behind G4TessellatedS 1247 ones, following logic behind G4TessellatedSolid.
1275 1248
1276 12-Dec-2007, G.Cosmo (geom-specific-V09-00-08 1249 12-Dec-2007, G.Cosmo (geom-specific-V09-00-08a)
1277 - Remove use of global static constant from s 1250 - Remove use of global static constant from singleton initialisation in
1278 G4TessellatedGeometryAlgorithms class. Use 1251 G4TessellatedGeometryAlgorithms class. Use 'sqrEpsilon' as local value.
1279 1252
1280 15-Nov-2007, P.Truscott (geom-specific-V09-00 1253 15-Nov-2007, P.Truscott (geom-specific-V09-00-08)
1281 - Reviewed implementation of G4TessellatedSol 1254 - Reviewed implementation of G4TessellatedSolid::CalculateExtent() to
1282 make it more robust and precise, following 1255 make it more robust and precise, following suggestion by S.Seibert
1283 addressed in problem report #983, now fixed 1256 addressed in problem report #983, now fixed.
1284 1257
1285 12-Oct-2007, G.Cosmo (geom-specific-V09-00-07 1258 12-Oct-2007, G.Cosmo (geom-specific-V09-00-07)
1286 - Corrected wrong boolean condition in method 1259 - Corrected wrong boolean condition in method IntersectLineAndTriangle2D()
1287 of G4TessellatedGeometryAlgorithms causing 1260 of G4TessellatedGeometryAlgorithms causing compilation error on VC++8.
1288 1261
1289 09-Oct-2007, G.Cosmo (geom-specific-V09-00-06 1262 09-Oct-2007, G.Cosmo (geom-specific-V09-00-06)
1290 - Reviewed G4TessellatedSolid classes in orde 1263 - Reviewed G4TessellatedSolid classes in order not to make use of random
1291 numbers for selection of direction (by P.Tr 1264 numbers for selection of direction (by P.Truscott).
1292 1265
1293 02-Oct-2007, G.Cosmo 1266 02-Oct-2007, G.Cosmo
1294 - Removed debug printout in G4Polycone::GetPo 1267 - Removed debug printout in G4Polycone::GetPointOnCone().
1295 1268
1296 23-Aug-2007, G.Cosmo (geom-specific-V09-00-05 1269 23-Aug-2007, G.Cosmo (geom-specific-V09-00-05)
1297 - Revision of G4TessellatedSolid classes: 1270 - Revision of G4TessellatedSolid classes:
1298 o Fixed problem report #931 by P.Truscott, 1271 o Fixed problem report #931 by P.Truscott, based on suggestion of
1299 R.Holmberg. Modified classes G4Tessellate 1272 R.Holmberg. Modified classes G4TessellatedSolid and G4TriangularFacet.
1300 o Modified data and accessor 'centroid' and 1273 o Modified data and accessor 'centroid' and 'GetCentroid()' for G4VFacet;
1301 replaced by 'circumcentre' and 'GetCircum 1274 replaced by 'circumcentre' and 'GetCircumcentre()' respectively.
1302 o Added utility class G4TessellatedGeometry 1275 o Added utility class G4TessellatedGeometryAlgorithms.
1303 - Added formulas for calculating SemiAxis and 1276 - Added formulas for calculating SemiAxis and Zheight in G4EllipticalCone
1304 (by T.Nikitina). 1277 (by T.Nikitina).
1305 1278
1306 20-Aug-2007, T.Nikitina & L.Lindroos (geom-sp 1279 20-Aug-2007, T.Nikitina & L.Lindroos (geom-specific-V09-00-04)
1307 - Revision of G4EllipticalCone: 1280 - Revision of G4EllipticalCone:
1308 o DistanceToIn(p): corrected answer for p.z 1281 o DistanceToIn(p): corrected answer for p.z()<-zTopCut and for the point
1309 p on the surface. 1282 p on the surface.
1310 o DistanceToOut(p,v): now returning positiv 1283 o DistanceToOut(p,v): now returning positive solution or zero when crossing
1311 the elliptical surface. 1284 the elliptical surface.
1312 o Fix in DistanceToOut(p) which was giving 1285 o Fix in DistanceToOut(p) which was giving always zero.
1313 o Corrected visualisation error of solid in 1286 o Corrected visualisation error of solid in graphics_reps.
1314 o Added some formulas on how to pre-calcula 1287 o Added some formulas on how to pre-calculate 'SemiAxis' and 'zheight'.
1315 o Added checkDistanceToOut() method to unit 1288 o Added checkDistanceToOut() method to unit test.
1316 - Corrections to G4Paraboloid: 1289 - Corrections to G4Paraboloid:
1317 o Fixed bug in CalculateSurfaceArea() metho 1290 o Fixed bug in CalculateSurfaceArea() method
1318 o Added correct initialisation of 'fPolyhed 1291 o Added correct initialisation of 'fPolyhedron' in constructor.
1319 o Added unit test testG4Paraboloid. 1292 o Added unit test testG4Paraboloid.
1320 1293
1321 13-Aug-2007, W.Pokorski (geom-specific-V09-00 1294 13-Aug-2007, W.Pokorski (geom-specific-V09-00-03)
1322 - G4PolyconeSide: added workaround to initial 1295 - G4PolyconeSide: added workaround to initialisation of 'corners' vector,
1323 to allow for object persistency with Root-I 1296 to allow for object persistency with Root-I/O (W.Pokorski).
1324 1297
1325 18-Jul-2007, G.Cosmo (geom-specific-V09-00-02 1298 18-Jul-2007, G.Cosmo (geom-specific-V09-00-02)
1326 - New specific G4Paraboloid with cuts along t 1299 - New specific G4Paraboloid with cuts along the Z axis (by L.Lindroos).
1327 - Fixed dummy constructors of G4Polycone and 1300 - Fixed dummy constructors of G4Polycone and G4PolyPhiFace for initialisation
1328 of 'edges' and 'corners'. 1301 of 'edges' and 'corners'.
1329 - Coworks with tag "greps-V09-00-01". 1302 - Coworks with tag "greps-V09-00-01".
1330 1303
1331 12-Jul-2007, T.Nikitina (geom-specific-V09-00 1304 12-Jul-2007, T.Nikitina (geom-specific-V09-00-01)
1332 - Fix in G4Polyhedra::GetPointOnSurface() to 1305 - Fix in G4Polyhedra::GetPointOnSurface() to correctly treat 'totalPhi' instead of
1333 'endPhi' for the case of open shapes and 't 1306 'endPhi' for the case of open shapes and 'twopi' for not open shapes.
1334 1307
1335 05-Jul-2007, T.Nikitina (geom-specific-V09-00 1308 05-Jul-2007, T.Nikitina (geom-specific-V09-00-00)
1336 - Fix in G4Polyhedra::GetPointOnSurface() for 1309 - Fix in G4Polyhedra::GetPointOnSurface() for the case when number of sectors
1337 (numSide) is equal to 1. At the origin of p 1310 (numSide) is equal to 1. At the origin of problems observed when checking
1338 overlaps for polyhedra solids defined as su 1311 overlaps for polyhedra solids defined as such.
1339 1312
1340 31-May-2007, G.Cosmo (geom-specific-V08-03-03 1313 31-May-2007, G.Cosmo (geom-specific-V08-03-03)
1341 - Fixed initialisation of constants in constr 1314 - Fixed initialisation of constants in constructor for - G4VTwistSurface,
1342 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraS 1315 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraSide - following latest changes
1343 for tunable tolerance. 1316 for tunable tolerance.
1344 1317
1345 25-May-2007, G.Cosmo (geom-specific-V08-03-02 1318 25-May-2007, G.Cosmo (geom-specific-V08-03-02)
1346 - Fixed default response of DistToIn/DistToOu 1319 - Fixed default response of DistToIn/DistToOut for twisted solids.
1347 - Use G4TWISTDEBUG instead of G4SPECSDEBUG as 1320 - Use G4TWISTDEBUG instead of G4SPECSDEBUG as debug conditional flag
1348 for twisted solids. 1321 for twisted solids.
1349 - Some cleanup in G4TwistTrapAlphaSide code. 1322 - Some cleanup in G4TwistTrapAlphaSide code.
1350 1323
1351 18-May-2007, G.Cosmo (geom-specific-V08-03-01 1324 18-May-2007, G.Cosmo (geom-specific-V08-03-01)
1352 - Use kAngTolerance and kRadTolerance from G4 1325 - Use kAngTolerance and kRadTolerance from G4GeometryTolerance class.
1353 - Coworks with tag "global-V08-03-03". 1326 - Coworks with tag "global-V08-03-03".
1354 1327
1355 11-May-2007, T.Nikitina (geom-specific-V08-03 1328 11-May-2007, T.Nikitina (geom-specific-V08-03-00)
1356 - Use call to G4GeometryTolerance instead of 1329 - Use call to G4GeometryTolerance instead of kCarTolerance where needed.
1357 - Requires tag "global-V08-03-00" and related 1330 - Requires tag "global-V08-03-00" and related tag set.
1358 1331
1359 26-Apr-2007, T.Nikitina (geom-specific-V08-02 1332 26-Apr-2007, T.Nikitina (geom-specific-V08-02-05)
1360 - Fix in GetPointOnSurface() for G4Polycone t 1333 - Fix in GetPointOnSurface() for G4Polycone to consider also points laying
1361 on rings when consecutive Z-sections are co 1334 on rings when consecutive Z-sections are coincident.
1362 Added method GetPointOnRing(). 1335 Added method GetPointOnRing().
1363 - Added unit test testPointOnSurfacePoly.cc. 1336 - Added unit test testPointOnSurfacePoly.cc.
1364 1337
1365 27-Feb-2007, I.Hrivnacova (geom-specific-V08- 1338 27-Feb-2007, I.Hrivnacova (geom-specific-V08-02-04)
1366 - Added specialised constructor for handling 1339 - Added specialised constructor for handling Z-sections in G4ExtrudedSolid.
1367 - Cleared unecessary declaration of IsInside( 1340 - Cleared unecessary declaration of IsInside() methods in G4TriangularFacet
1368 and G4QuadrangularFacet. 1341 and G4QuadrangularFacet.
1369 - Updated unit test for G4ExtrudedSolid. 1342 - Updated unit test for G4ExtrudedSolid.
1370 1343
1371 26-Feb-2007, I.Hrivnacova (geom-specific-V08- 1344 26-Feb-2007, I.Hrivnacova (geom-specific-V08-02-04)
1372 - Added specialised constructor for handling 1345 - Added specialised constructor for handling Z-sections in G4ExtrudedSolid.
1373 - Cleared unecessary declaration of IsInside( 1346 - Cleared unecessary declaration of IsInside() methods in G4TriangularFacet
1374 and G4QuadrangularFacet. 1347 and G4QuadrangularFacet.
1375 - Updated unit test for G4ExtrudedSolid. 1348 - Updated unit test for G4ExtrudedSolid.
1376 1349
1377 15-Feb-2007, I.Hrivnacova (geom-specific-V08- 1350 15-Feb-2007, I.Hrivnacova (geom-specific-V08-02-03)
1378 - Corrected caching of values in G4ExtrudedSo 1351 - Corrected caching of values in G4ExtrudedSolid.
1379 - Bug fix in G4TriangularFacet::Intersect() t 1352 - Bug fix in G4TriangularFacet::Intersect() to allow for correct update of
1380 'Distance' in condition. 1353 'Distance' in condition.
1381 - Updated unit test for G4ExtrudedSolid. 1354 - Updated unit test for G4ExtrudedSolid.
1382 1355
1383 09-Feb-2007, G.Cosmo (geom-specific-V08-02-02 1356 09-Feb-2007, G.Cosmo (geom-specific-V08-02-02)
1384 - Introduced new shape G4ExtrudedSolid, a sol 1357 - Introduced new shape G4ExtrudedSolid, a solid representing the extrusion
1385 of an arbitrary polygon with fixed outline 1358 of an arbitrary polygon with fixed outline in the two Z sections.
1386 New files: G4ExtrudedSolid[.hh.icc.cc] and 1359 New files: G4ExtrudedSolid[.hh.icc.cc] and testG4ExtrudedSolid.cc
1387 by I.Hrivnacova. 1360 by I.Hrivnacova.
1388 - G4TessellatedSolid: 1361 - G4TessellatedSolid:
1389 o Made relevant solid's methods virtual, to 1362 o Made relevant solid's methods virtual, to be used as base class.
1390 o Added implementation for GetSurfaceArea() 1363 o Added implementation for GetSurfaceArea() and GetPointOnSurface() methods.
1391 o Added protection in SurfaceNormal() metho 1364 o Added protection in SurfaceNormal() method in case of facet not found.
1392 o Check and return kOutside in Inside() if 1365 o Check and return kOutside in Inside() if point out of solid's extent.
1393 1366
1394 01-Feb-2007, G.Cosmo (geom-specific-V08-02-01 1367 01-Feb-2007, G.Cosmo (geom-specific-V08-02-01)
1395 - Fix in G4PolyconeSide::DistanceAway() for c 1368 - Fix in G4PolyconeSide::DistanceAway() for correct estimation of distance
1396 for the case of Phi sections (T.Nikitina). 1369 for the case of Phi sections (T.Nikitina).
1397 Addresses problem report #598. 1370 Addresses problem report #598.
1398 - Updated unit test for G4Polycone to conside 1371 - Updated unit test for G4Polycone to consider new test case.
1399 1372
1400 22-Jan-2007, G.Cosmo (geom-specific-V08-02-00 1373 22-Jan-2007, G.Cosmo (geom-specific-V08-02-00)
1401 - Do not scale reducible-polygon in G4Polyhed 1374 - Do not scale reducible-polygon in G4Polyhedra::Reset() method.
1402 The 'original_parameters' structure offered 1375 The 'original_parameters' structure offered as input through the accessors
1403 are always assumed to be already scaled by 1376 are always assumed to be already scaled by the 'cos(0.5*phiTotal/theNumSide)'
1404 factor. Addresses problem report #873. 1377 factor. Addresses problem report #873.
1405 - Fixed warning printout in G4Polycone::Reset 1378 - Fixed warning printout in G4Polycone::Reset().
1406 1379
1407 15-Nov-2006, J.Allison (geom-specific-V08-01- 1380 15-Nov-2006, J.Allison (geom-specific-V08-01-04)
1408 - Fixed typo in G4Polycone::CreatePolyhedron( 1381 - Fixed typo in G4Polycone::CreatePolyhedron() introduced by mistake in
1409 the last cleanup of the source code. 1382 the last cleanup of the source code.
1410 1383
1411 13-Nov-2006, G.Cosmo (geom-specific-V08-01-03 1384 13-Nov-2006, G.Cosmo (geom-specific-V08-01-03)
1412 - Added concrete implementation of GetSurface 1385 - Added concrete implementation of GetSurfaceArea() in G4Tet (M.H.Mendenhall).
1413 1386
1414 08-Nov-2006, G.Cosmo (geom-specific-V08-01-02 1387 08-Nov-2006, G.Cosmo (geom-specific-V08-01-02)
1415 - Cleared compilation warnings on SUN-CC for 1388 - Cleared compilation warnings on SUN-CC for changes in the last tag.
1416 Fixed overloaded class variables in G4Polyh 1389 Fixed overloaded class variables in G4Polyhedra and G4Polycone
1417 implementation of CreatePolyhedron(). 1390 implementation of CreatePolyhedron().
1418 1391
1419 31-Oct-2006, J.Allison (geom-specific-V08-01- 1392 31-Oct-2006, J.Allison (geom-specific-V08-01-01)
1420 - Implemented CreatePolyhedron() for G4Polyhe 1393 - Implemented CreatePolyhedron() for G4Polyhedra and G4Polycone.
1421 1394
1422 20-Oct-2006, G.Cosmo (geom-specific-V08-01-00 1395 20-Oct-2006, G.Cosmo (geom-specific-V08-01-00)
1423 - Implemented caching mechanism for computati 1396 - Implemented caching mechanism for computation of surface area in
1424 all solids and base classes, as done for th 1397 all solids and base classes, as done for the geometrical volume
1425 computation. 1398 computation.
1426 - Added missing fake constructor for object p 1399 - Added missing fake constructor for object persistency to G4TessellatedSolid.
1427 1400
1428 20-Jun-2006, G.Cosmo (geom-specific-V08-00-10 1401 20-Jun-2006, G.Cosmo (geom-specific-V08-00-10)
1429 - Added accessor method GetVertices() in G4Te 1402 - Added accessor method GetVertices() in G4Tet to return the list of
1430 vertices composing the solid. Required for 1403 vertices composing the solid. Required for GDML persistency.
1431 1404
1432 06-Jun-2006, G.Cosmo (geom-specific-V08-00-09 1405 06-Jun-2006, G.Cosmo (geom-specific-V08-00-09)
1433 - Added protection against NaNs in G4Polycone 1406 - Added protection against NaNs in G4PolyconeSide::Normal() for points at
1434 the origin. 1407 the origin.
1435 1408
1436 19-May-2006, G.Cosmo (geom-specific-V08-00-08 1409 19-May-2006, G.Cosmo (geom-specific-V08-00-08)
1437 - Fix in G4Ellipsoid::SetZCuts() and G4Ellipt 1410 - Fix in G4Ellipsoid::SetZCuts() and G4EllipticalTube::SetZCut() for usage
1438 of uninitialised variables. 1411 of uninitialised variables.
1439 1412
1440 08-May-2006, G.Cosmo (geom-specific-V08-00-07 1413 08-May-2006, G.Cosmo (geom-specific-V08-00-07)
1441 - Cleared compilation warning on SUN-CC in G4 1414 - Cleared compilation warning on SUN-CC in G4TriangularFacet.cc.
1442 1415
1443 04-May-2006, G.Cosmo (geom-specific-V08-00-06 1416 04-May-2006, G.Cosmo (geom-specific-V08-00-06)
1444 - Use different names for unit tests to avoid 1417 - Use different names for unit tests to avoid confusing liblist ...
1445 1418
1446 03-May-2006, G.Cosmo (geom-specific-V08-00-05 1419 03-May-2006, G.Cosmo (geom-specific-V08-00-05)
1447 - Added four unit tests for G4TessellatedSoli 1420 - Added four unit tests for G4TessellatedSolid.
1448 1421
1449 24-Mar-2006, G.Cosmo (geom-specific-V08-00-04 1422 24-Mar-2006, G.Cosmo (geom-specific-V08-00-04)
1450 - G4TwistedTubs: defined exact estimation for 1423 - G4TwistedTubs: defined exact estimation for GetCubicVolume(),
1451 similar to the one adopted for G4Tubs. 1424 similar to the one adopted for G4Tubs.
1452 1425
1453 03-Mar-2006, G.Cosmo (geom-specific-V08-00-03 1426 03-Mar-2006, G.Cosmo (geom-specific-V08-00-03)
1454 - Corrected boolean condition in G4Triangular 1427 - Corrected boolean condition in G4TriangularFacet::Intersect().
1455 Use '&&' operator in condition. Allows for 1428 Use '&&' operator in condition. Allows for porting on WIN32-VC.
1456 1429
1457 01-Mar-2006, G.Cosmo (geom-specific-V08-00-02 1430 01-Mar-2006, G.Cosmo (geom-specific-V08-00-02)
1458 - Introducing first implementation of a tesse 1431 - Introducing first implementation of a tessellated solid, contribution
1459 of P.R.Truscott (QinetiQ Ltd, UK). 1432 of P.R.Truscott (QinetiQ Ltd, UK).
1460 New classes: G4QuadrangularFacet, G4Tessell 1433 New classes: G4QuadrangularFacet, G4TessellatedSolid, G4TriangularFacet
1461 and G4VFacet. 1434 and G4VFacet.
1462 - Requires tag "greps-V08-00-00". 1435 - Requires tag "greps-V08-00-00".
1463 1436
1464 12-Jan-2006, J.Allison (geom-specific-V08-00- 1437 12-Jan-2006, J.Allison (geom-specific-V08-00-01)
1465 - G4TwistedTubs and G4VTwistedFaceted::Create 1438 - G4TwistedTubs and G4VTwistedFaceted::CreatePolyhedron():
1466 parameterised polyhedron mesh approximation 1439 parameterised polyhedron mesh approximation in terms of
1467 G4Polyhedron::GetNumberOfRotationSteps(). 1440 G4Polyhedron::GetNumberOfRotationSteps().
1468 This is (a) more economical and (b) amenabl 1441 This is (a) more economical and (b) amenable to user control.
1469 1442
1470 19-Dec-2005, O.Link (geom-specific-V08-00-00) 1443 19-Dec-2005, O.Link (geom-specific-V08-00-00)
1471 - Fixes in G4EllipticalCone: 1444 - Fixes in G4EllipticalCone:
1472 o Changed GetPointOnSurface(), which was no 1445 o Changed GetPointOnSurface(), which was not uniform in endcaps.
1473 o Bug fix in Inside(), which was not correc 1446 o Bug fix in Inside(), which was not correct for the elliptic mantel.
1474 Made test similar as in G4EllipticTube. 1447 Made test similar as in G4EllipticTube.
1475 o Several fixes in DistanceToIn/Out(): for 1448 o Several fixes in DistanceToIn/Out(): for looping events (shortest
1476 distance was taken, even if 0); now compa 1449 distance was taken, even if 0); now comparing the distance to the endcap
1477 and to the mantel and decide afterwards w 1450 and to the mantel and decide afterwards which distance is shortest;
1478 added check n*v. 1451 added check n*v.
1479 o The code is now "good" at 90%. Still 10% 1452 o The code is now "good" at 90%. Still 10% wrong reconstructed events.
1480 e.g there is a problem is DistanceToOut() 1453 e.g there is a problem is DistanceToOut(): missed the intersection
1481 (reconstruction took the encap instead of 1454 (reconstruction took the encap instead of the mantel).
1482 1455
1483 09-Dec-2005, O.Link 1456 09-Dec-2005, O.Link
1484 - Fixed visibility of soft edges on the twist 1457 - Fixed visibility of soft edges on the twisted solids.
1485 1458
1486 08-Dec-2005, O.Link (geom-specific-V07-01-14) 1459 08-Dec-2005, O.Link (geom-specific-V07-01-14)
1487 - Fixed bug in G4VTwistSurface::ComputeLocalP 1460 - Fixed bug in G4VTwistSurface::ComputeLocalPoint(p) for point coordinate
1488 transformation. The bug affected only G4Twi 1461 transformation. The bug affected only G4TwistTrapFlatSide.
1489 1462
1490 06-Dec-2005, G.Cosmo (geom-specific-V07-01-13 1463 06-Dec-2005, G.Cosmo (geom-specific-V07-01-13)
1491 - Fixed compilation errors on WIN32-VC for la 1464 - Fixed compilation errors on WIN32-VC for last tag changes.
1492 1465
1493 05-Dec-2005, O.Link (geom-specific-V07-01-12) 1466 05-Dec-2005, O.Link (geom-specific-V07-01-12)
1494 - Added polyhedron definition for twisted sol 1467 - Added polyhedron definition for twisted solids (G4TwistedTrap,
1495 G4TwistedTrd, G4TwistedBox, G4TwistedTubs) 1468 G4TwistedTrd, G4TwistedBox, G4TwistedTubs) for visualization.
1496 1469
1497 30-Nov-2005, G.Cosmo (geom-specific-V07-01-11 1470 30-Nov-2005, G.Cosmo (geom-specific-V07-01-11)
1498 - Trivial fixes for porting on CLHEP-2.0.X se 1471 - Trivial fixes for porting on CLHEP-2.0.X series.
1499 1472
1500 18-Nov-2005, O.Link (geom-specific-V07-01-10) 1473 18-Nov-2005, O.Link (geom-specific-V07-01-10)
1501 - Renamed classes for twisted solids set, to 1474 - Renamed classes for twisted solids set, to identify them in the
1502 twisted framework. 1475 twisted framework.
1503 1476
1504 17-Nov-2005, O.Link 1477 17-Nov-2005, O.Link
1505 - G4VTwistedFacted: 1478 - G4VTwistedFacted:
1506 o corrected bug in DistanceToSurface() impl 1479 o corrected bug in DistanceToSurface() implementation
1507 o added GetPointOnSurface() method 1480 o added GetPointOnSurface() method
1508 - G4TwistedTubs: 1481 - G4TwistedTubs:
1509 o added GetPointOnSurface() method 1482 o added GetPointOnSurface() method
1510 - G4Hype: 1483 - G4Hype:
1511 o corrected surface area calculation used i 1484 o corrected surface area calculation used in GetPointOnSurface()
1512 1485
1513 17-Nov-2005, G.Cosmo (geom-specific-V07-01-09 1486 17-Nov-2005, G.Cosmo (geom-specific-V07-01-09)
1514 - More fixes required for direct object persi 1487 - More fixes required for direct object persistency to G4Polycone,
1515 G4polyhedra and related utility classes. 1488 G4polyhedra and related utility classes.
1516 1489
1517 10-Nov-2005, J.Allison (geom-specific-V07-01- 1490 10-Nov-2005, J.Allison (geom-specific-V07-01-08)
1518 - G4Tet: 1491 - G4Tet:
1519 o Added implementation for GetPolyhedron() 1492 o Added implementation for GetPolyhedron() and GetCubicVolume().
1520 o Corrected order of specifying vertices in 1493 o Corrected order of specifying vertices in CreatePolyhedron().
1521 1494
1522 09-Nov-2005, G.Cosmo (geom-specific-V07-01-07 1495 09-Nov-2005, G.Cosmo (geom-specific-V07-01-07)
1523 - Added fake default constructor for all conc 1496 - Added fake default constructor for all concrete solids and relevant
1524 utility classes, for usage of direct object 1497 utility classes, for usage of direct object persistency.
1525 - Implemented changes to support CLHEP-2.0.X 1498 - Implemented changes to support CLHEP-2.0.X for explicit usage of the
1526 CLHEP/HepGeom namespaces for CLHEP types. 1499 CLHEP/HepGeom namespaces for CLHEP types.
1527 1500
1528 07-Nov-2005, G.Cosmo (geom-specific-V07-01-06 1501 07-Nov-2005, G.Cosmo (geom-specific-V07-01-06)
1529 - G4Ellipsoid: replaced call to hypot(x,y) wi 1502 - G4Ellipsoid: replaced call to hypot(x,y) with std::sqrt(x*x+y*y)
1530 for porting to ISO standard. 1503 for porting to ISO standard.
1531 1504
1532 02-Nov-2005, G.Cosmo (geom-specific-V07-01-05 1505 02-Nov-2005, G.Cosmo (geom-specific-V07-01-05)
1533 - G4Polyhedra, G4Polycone: 1506 - G4Polyhedra, G4Polycone:
1534 o Protected case of generic construct for v 1507 o Protected case of generic construct for visualization.
1535 o Introduced explicit flag and method IsGen 1508 o Introduced explicit flag and method IsGeneric() to identify the kind
1536 of constructor used. 1509 of constructor used.
1537 1510
1538 29-Sep-2005, G.Cosmo (geom-specific-V07-01-04 1511 29-Sep-2005, G.Cosmo (geom-specific-V07-01-04)
1539 - Fix in G4EllipticalCone methods DistanceToI 1512 - Fix in G4EllipticalCone methods DistanceToIn() and DistanceToOut().
1540 Added unit test for it (by D.Anninos). 1513 Added unit test for it (by D.Anninos).
1541 - Coworks with tag "greps-V07-01-02". 1514 - Coworks with tag "greps-V07-01-02".
1542 1515
1543 10-Aug-2005, G.Cosmo (geom-specific-V07-01-03 1516 10-Aug-2005, G.Cosmo (geom-specific-V07-01-03)
1544 - Introduced new solid G4EllipticalCone, a fu 1517 - Introduced new solid G4EllipticalCone, a full cone with elliptical base
1545 that can be cut in Z (by D.Anninos). 1518 that can be cut in Z (by D.Anninos).
1546 Coworks with tag "greps-V07-01-02". 1519 Coworks with tag "greps-V07-01-02".
1547 1520
1548 08-Aug-2005, D.Anninos (geom-specific-V07-01- 1521 08-Aug-2005, D.Anninos (geom-specific-V07-01-02)
1549 - Added GetPointOnSurface() for all solids ex 1522 - Added GetPointOnSurface() for all solids except twisted ones.
1550 The method returns a random point according 1523 The method returns a random point according to a quasi-uniform
1551 distribution along the surface. 1524 distribution along the surface.
1552 1525
1553 18-Jul-2005, G.Cosmo (geom-specific-V07-01-01 1526 18-Jul-2005, G.Cosmo (geom-specific-V07-01-01)
1554 - Fixed compilation warning on WIN32-VC for G 1527 - Fixed compilation warning on WIN32-VC for G4VSurface.cc.
1555 - Not including G4Tet. 1528 - Not including G4Tet.
1556 1529
1557 06-Jul-2005, G.Cosmo (geom-specific-V07-01-00 1530 06-Jul-2005, G.Cosmo (geom-specific-V07-01-00)
1558 - Added new shape G4Ellipsoid. Coworks with t 1531 - Added new shape G4Ellipsoid. Coworks with tag "greps-V07-01-00".
1559 Contribution of G.Horton-Smith and G.Guerri 1532 Contribution of G.Horton-Smith and G.Guerrieri.
1560 Code cleanup, and added default arguments f 1533 Code cleanup, and added default arguments for cuts, added first
1561 implementation of unit test. 1534 implementation of unit test.
1562 - Corrected unit tests for twisted-box/trap. 1535 - Corrected unit tests for twisted-box/trap.
1563 - Not including G4Tet. 1536 - Not including G4Tet.
1564 1537
1565 15-Jun-2005, J.Apostolakis 1538 15-Jun-2005, J.Apostolakis
1566 - Introduced new solid G4Tet, contribution of 1539 - Introduced new solid G4Tet, contribution of M.H.Mendenhall
1567 and R.A.Weller, Vanderbilt University, USA. 1540 and R.A.Weller, Vanderbilt University, USA.
1568 1541
1569 29-Apr-2005, O.Link (geom-specific-V07-00-04) 1542 29-Apr-2005, O.Link (geom-specific-V07-00-04)
1570 - G4TwistedSurface: fixed bug in GetAreaCode( 1543 - G4TwistedSurface: fixed bug in GetAreaCode() affecting G4TwistedTubs.
1571 1544
1572 04-Apr-2005, G.Cosmo (geom-specific-V07-00-03 1545 04-Apr-2005, G.Cosmo (geom-specific-V07-00-03)
1573 - Added test for Number-Of-Rotation-Steps in 1546 - Added test for Number-Of-Rotation-Steps in GetPolyhedron() for
1574 G4VCSGfaceted, G4Hype and G4EllipticalTube 1547 G4VCSGfaceted, G4Hype and G4EllipticalTube (by J.Allison).
1575 Requires tag "greps-V07-00-02". 1548 Requires tag "greps-V07-00-02".
1576 - Added elementary implementation of CreatePo 1549 - Added elementary implementation of CreatePolyhedron() for G4Hype,
1577 G4TwistedBox, G4TwistedTubs, G4TwistedTrd, 1550 G4TwistedBox, G4TwistedTubs, G4TwistedTrd, G4TwistedTrap.
1578 - Some code cleanup. 1551 - Some code cleanup.
1579 1552
1580 18-Mar-2005, O.Link (geom-specific-V07-00-02) 1553 18-Mar-2005, O.Link (geom-specific-V07-00-02)
1581 - New generic framework for twisted solids G4 1554 - New generic framework for twisted solids G4TwistedBox, G4TwistedTrd and
1582 G4TwistedTrap: inheriting now from the base 1555 G4TwistedTrap: inheriting now from the base class G4VTwistedFaceted.
1583 - Extended G4TwistedTrap to support setups wi 1556 - Extended G4TwistedTrap to support setups with different trapezoidal
1584 endcaps with centres not necessarily on a l 1557 endcaps with centres not necessarily on a line parallel to the z axis.
1585 - Added G4TwistedTrd and general G4TwistedTra 1558 - Added G4TwistedTrd and general G4TwistedTrap as test cases in test.
1586 1559
1587 03-Mar-2005, J.Allison 1560 03-Mar-2005, J.Allison
1588 - Changed AddThis() to AddSolid() for all sol 1561 - Changed AddThis() to AddSolid() for all solids in the implementation
1589 of DescribeYourselfTo(G4VGraphicsScene&). 1562 of DescribeYourselfTo(G4VGraphicsScene&).
1590 1563
1591 01-Mar-2005, O.Link (geom-specific-V07-00-01) 1564 01-Mar-2005, O.Link (geom-specific-V07-00-01)
1592 - Fixed compilation warnings on WIN32-VC for 1565 - Fixed compilation warnings on WIN32-VC for G4VSurface.cc.
1593 1566
1594 14-Feb-2005, O.Link (geom-specific-V07-00-00) 1567 14-Feb-2005, O.Link (geom-specific-V07-00-00)
1595 - Use new polynom approximations based on new 1568 - Use new polynom approximations based on new solver based on Jenkins-Traub
1596 algorithm, for twisted-box and twisted-trap 1569 algorithm, for twisted-box and twisted-trap.
1597 - Fixed bug in the usage of 'fmod' and adopt 1570 - Fixed bug in the usage of 'fmod' and adopt special treatment for 'parallel'
1598 events in G4TwistedBoxSide and G4TwistedTra 1571 events in G4TwistedBoxSide and G4TwistedTrapSide.
1599 - Coworks with tag "global-V07-00-00". 1572 - Coworks with tag "global-V07-00-00".
1600 1573
1601 08-Dec-2004, O.Link (geom-specific-V06-02-07) 1574 08-Dec-2004, O.Link (geom-specific-V06-02-07)
1602 - Extensions to twisted box/trap shapes to co 1575 - Extensions to twisted box/trap shapes to consider all 4 solutions
1603 for determining correct intersections. 1576 for determining correct intersections.
1604 1577
1605 29-Nov-2004, O.Link (geom-specific-V06-02-06) 1578 29-Nov-2004, O.Link (geom-specific-V06-02-06)
1606 - G4TwistedTrapSide, G4TwistedBoxSide: improv 1579 - G4TwistedTrapSide, G4TwistedBoxSide: improved (analytical) version
1607 of GetPhiUAtX() method. 1580 of GetPhiUAtX() method.
1608 1581
1609 24-Nov-2004, O.Link (geom-specific-V06-02-05) 1582 24-Nov-2004, O.Link (geom-specific-V06-02-05)
1610 - Fixed bug in description of twisted trapezo 1583 - Fixed bug in description of twisted trapezoid side.
1611 1584
1612 12-Nov-2004, O.Link (geom-specific-V06-02-04) 1585 12-Nov-2004, O.Link (geom-specific-V06-02-04)
1613 - Added G4TwistedBox - a twisted box with tw 1586 - Added G4TwistedBox - a twisted box with twist angle alpha,
1614 length a/2,b/2,L/2. 1587 length a/2,b/2,L/2.
1615 - Added G4TwistedTrap - a twisted trapezoid ( 1588 - Added G4TwistedTrap - a twisted trapezoid (still in debug state)
1616 - Changed in G4VSurface.icc: 1589 - Changed in G4VSurface.icc:
1617 - GetNeighbours(): corrected axiscode (wa 1590 - GetNeighbours(): corrected axiscode (was returning the wrong neighbours)
1618 - SetNeighbours(): fixed problem #685 (in 1591 - SetNeighbours(): fixed problem #685 (index out of range)
1619 - Added tests for G4TwistedBox and G4TwistedT 1592 - Added tests for G4TwistedBox and G4TwistedTrap in specific/test.
1620 - Added G4TwistedBox and G4TwistedTrap in sys 1593 - Added G4TwistedBox and G4TwistedTrap in system testing, test10.
1621 1594
1622 22-Oct-2004, D.C.Williams (geom-specific-V06- 1595 22-Oct-2004, D.C.Williams (geom-specific-V06-02-03)
1623 - Fix in G4PolyconeSide::Inside for points at 1596 - Fix in G4PolyconeSide::Inside for points at radius = 0 for phi slides
1624 solids with an inner radius. Addresses prob 1597 solids with an inner radius. Addresses problem report #598.
1625 1598
1626 10-Oct-2004, J.Allison (geom-specific-V06-02- 1599 10-Oct-2004, J.Allison (geom-specific-V06-02-02)
1627 - Added GetPolyhedron, a smart access functio 1600 - Added GetPolyhedron, a smart access function that creates a G4Polyhedron
1628 on request and stores for future access. A 1601 on request and stores for future access. A null pointer means "not
1629 available". 1602 available".
1630 1603
1631 22-Sep-2004, G.Cosmo (geom-specific-V06-02-01 1604 22-Sep-2004, G.Cosmo (geom-specific-V06-02-01)
1632 - Added implementation of GetCubicVolume() wi 1605 - Added implementation of GetCubicVolume() with cashing mechanism for
1633 solids: G4EllipticalTube, G4Hype, G4Polyhed 1606 solids: G4EllipticalTube, G4Hype, G4Polyhedra, G4Polycone, G4TwistedTubs.
1634 1607
1635 01-Sep-2004, D.C.Williams (geom-specific-V06- 1608 01-Sep-2004, D.C.Williams (geom-specific-V06-02-00)
1636 - G4VCSGfaceted: fix for rare anomalous situa 1609 - G4VCSGfaceted: fix for rare anomalous situation in which
1637 DistanceToOut(p,v,..) will report kInfinity 1610 DistanceToOut(p,v,..) will report kInfinity, make an additional check
1638 for the point p on the surface, in which ca 1611 for the point p on the surface, in which case will report zero.
1639 Addresses problem observed in G4Polyhedra a 1612 Addresses problem observed in G4Polyhedra and reported in #650.
1640 1613
1641 07-Jun-2004, G.Cosmo (geom-specific-V06-01-04 1614 07-Jun-2004, G.Cosmo (geom-specific-V06-01-04)
1642 - Fixed compilation problem in G4TwistedSurfa 1615 - Fixed compilation problem in G4TwistedSurface.cc on WIN32-VC.
1643 1616
1644 28-May-2004, G.Cosmo (geom-specific-V06-01-03 1617 28-May-2004, G.Cosmo (geom-specific-V06-01-03)
1645 - Fixed archiving problem on WIN32-VC7: repla 1618 - Fixed archiving problem on WIN32-VC7: replaced structs with classes
1646 in G4VSurface. 1619 in G4VSurface.
1647 - Replaced misleading names for masks in G4VS 1620 - Replaced misleading names for masks in G4VSurface and moved inlined
1648 methods of nested classes to .cc. 1621 methods of nested classes to .cc.
1649 1622
1650 25-May-2004, G.Cosmo (geom-specific-V06-01-02 1623 25-May-2004, G.Cosmo (geom-specific-V06-01-02)
1651 - Fixed compilation problem on SUN-CC. Made E 1624 - Fixed compilation problem on SUN-CC. Made EValidate enum public in
1652 G4VSurface.hh. 1625 G4VSurface.hh.
1653 1626
1654 24-May-2004, G.Cosmo (geom-specific-V06-01-01 1627 24-May-2004, G.Cosmo (geom-specific-V06-01-01)
1655 - Removed compilation warnings and minor clea 1628 - Removed compilation warnings and minor cleanup...
1656 1629
1657 19-May-2004, O.Link (geom-specific-V06-01-00) 1630 19-May-2004, O.Link (geom-specific-V06-01-00)
1658 - First implementation of a framework for twi 1631 - First implementation of a framework for twisted surfaces, integrated from
1659 the original version of Kotoyo Hoshina (hos 1632 the original version of Kotoyo Hoshina (hoshina@hepburn.s.chiba-u.ac.jp)
1660 implemented in the 'Jupiter' application. 1633 implemented in the 'Jupiter' application.
1661 o Includes new specific twisted shape: G4Tw 1634 o Includes new specific twisted shape: G4TwistedTubs.
1662 o New classes: G4VSurface, G4TwistedSurface 1635 o New classes: G4VSurface, G4TwistedSurface, G4HyperbolicSurface,
1663 G4FlatSurface, G4TwistedTubs 1636 G4FlatSurface, G4TwistedTubs.
1664 o Cleanup of original code (debugging messa 1637 o Cleanup of original code (debugging messages, compiler errors, migration
1665 of g4std to new convention...) 1638 of g4std to new convention...)
1666 o New organisation of class G4TwistedTubs: 1639 o New organisation of class G4TwistedTubs: now independent of XXXSurface;
1667 removed backpointer 'fSolid' from XXXSurf 1640 removed backpointer 'fSolid' from XXXSurface to G4TwistedTubs.
1668 o New form of constructors in G4TwistedSurf 1641 o New form of constructors in G4TwistedSurface, G4HyperbolicSurface and
1669 G4FlatSurface. 1642 G4FlatSurface.
1670 o Change in G4TwistedSurface::DistanceToIn( 1643 o Change in G4TwistedSurface::DistanceToIn(p,v,...): roundoff correction.
1671 1644
1672 12-Jan-2004, G.Cosmo (geom-specific-V06-00-00 1645 12-Jan-2004, G.Cosmo (geom-specific-V06-00-00)
1673 - G4PolyhedraSide.cc: fixed bug in which part 1646 - G4PolyhedraSide.cc: fixed bug in which particles could "leak" out the
1674 center of a face if inner radius = 0. 1647 center of a face if inner radius = 0.
1675 Fixes problem report #547. (D.Williams) 1648 Fixes problem report #547. (D.Williams)
1676 1649
1677 22-Nov-2003, G.Cosmo (geom-specific-V05-02-07 1650 22-Nov-2003, G.Cosmo (geom-specific-V05-02-07)
1678 - Fixed upper bound for protection check intr 1651 - Fixed upper bound for protection check introduced in G4Polycone and
1679 G4Polyhedra constructors. 1652 G4Polyhedra constructors.
1680 1653
1681 17-Nov-2003, G.Cosmo (geom-specific-V05-02-06 1654 17-Nov-2003, G.Cosmo (geom-specific-V05-02-06)
1682 - Added protections in G4Polycone and G4Polyh 1655 - Added protections in G4Polycone and G4Polyhedra constructors for
1683 invalid constructs with no contiguous segme 1656 invalid constructs with no contiguous segments in Z planes as input.
1684 1657
1685 04-Nov-2003, G.Cosmo (geom-specific-V05-02-05 1658 04-Nov-2003, G.Cosmo (geom-specific-V05-02-05)
1686 - Added SetOriginalParameters() method to G4P 1659 - Added SetOriginalParameters() method to G4Polycone and G4Polyhedra.
1687 1660
1688 03-Nov-2003, G.Cosmo (geom-specific-V05-02-04 1661 03-Nov-2003, G.Cosmo (geom-specific-V05-02-04)
1689 - Code cleanup and headers inclusion review 1662 - Code cleanup and headers inclusion review
1690 (replaced by forward declarations where nec 1663 (replaced by forward declarations where necessary).
1691 1664
1692 28-Oct-2003, G.Cosmo (geom-specific-V05-02-03 1665 28-Oct-2003, G.Cosmo (geom-specific-V05-02-03)
1693 - Migrated to new G4Exception scheme. 1666 - Migrated to new G4Exception scheme.
1694 1667
1695 20-Oct-2003, G.Cosmo (geom-specific-V05-02-02 1668 20-Oct-2003, G.Cosmo (geom-specific-V05-02-02)
1696 - Added Reset() method in G4Polycone and G4Po 1669 - Added Reset() method in G4Polycone and G4Polyhedra to allow
1697 recalculation and reshape of the solid if n 1670 recalculation and reshape of the solid if new original_parameters
1698 are provided. 1671 are provided.
1699 1672
1700 30-Sep-2003, G.Cosmo (geom-specific-V05-02-01 1673 30-Sep-2003, G.Cosmo (geom-specific-V05-02-01)
1701 - Updated GNUmakefile for unit tests, accordi 1674 - Updated GNUmakefile for unit tests, according to new structure
1702 introduced in "geometry-V05-02-00". 1675 introduced in "geometry-V05-02-00".
1703 1676
1704 16-Jun-2003, G.Cosmo (geom-specific-V05-02-00 1677 16-Jun-2003, G.Cosmo (geom-specific-V05-02-00)
1705 - Added accessors to original_parameters for 1678 - Added accessors to original_parameters for G4Polycone and G4Polyhedra.
1706 Made G4PolyconeHistorical and G4PolyhedraHi 1679 Made G4PolyconeHistorical and G4PolyhedraHistorical classes in global
1707 scope (temporary solution). 1680 scope (temporary solution).
1708 1681
1709 28-Mar-2003, G.Cosmo (geom-specific-V05-00-00 1682 28-Mar-2003, G.Cosmo (geom-specific-V05-00-00)
1710 - Fixed initialisation of base class in copy 1683 - Fixed initialisation of base class in copy contructor for:
1711 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraS 1684 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraSide.
1712 - Fixed trivial pedantic warnings on G4Polyco 1685 - Fixed trivial pedantic warnings on G4Polycone and G4Polyhedra.
1713 1686
1714 30-Oct-2002, G.Cosmo (geom-specific-V04-01-01 1687 30-Oct-2002, G.Cosmo (geom-specific-V04-01-01)
1715 - Fixed un-initialised data members in constr 1688 - Fixed un-initialised data members in constructors of classes:
1716 G4ClippablePolygon, G4EnclosingCylinder, G4 1689 G4ClippablePolygon, G4EnclosingCylinder, G4PolyconeSide,
1717 G4ReduciblePolygon, G4VCSGfaceted. 1690 G4ReduciblePolygon, G4VCSGfaceted.
1718 1691
1719 28-Oct-2002, G.Cosmo (geom-specific-V04-01-00 1692 28-Oct-2002, G.Cosmo (geom-specific-V04-01-00)
1720 - Added implementation of StreamInfo() to com 1693 - Added implementation of StreamInfo() to comply with new interface for
1721 G4VSolid in "geommng-V04-01-03". 1694 G4VSolid in "geommng-V04-01-03".
1722 - Created .icc files for G4EllipticalTube, G4 1695 - Created .icc files for G4EllipticalTube, G4Polyhedra and G4Polycone.
1723 - Some cosmetic changes to code formatting: r 1696 - Some cosmetic changes to code formatting: removed <TAB> characters and adopt
1724 uniform code indentation. 1697 uniform code indentation.
1725 1698
1726 08-May-2002, J.Allison (geom-solids-specific- 1699 08-May-2002, J.Allison (geom-solids-specific-V04-00-01)
1727 - Implemented G4EllipticalTube::CreatePolyhed 1700 - Implemented G4EllipticalTube::CreatePolyhedron.
1728 1701
1729 10-Jan-2002, G.Cosmo (geom-solids-specific-V0 1702 10-Jan-2002, G.Cosmo (geom-solids-specific-V04-00-00)
1730 - Updated unit tests. 1703 - Updated unit tests.
1731 1704
1732 20-Apr-2001, G.Cosmo (geom-solids-specific-V0 1705 20-Apr-2001, G.Cosmo (geom-solids-specific-V03-01-00)
1733 - Migration to STL vector: 1706 - Migration to STL vector:
1734 o In G4ClippablePolygon, migrated G4ThreeVe 1707 o In G4ClippablePolygon, migrated G4ThreeVectorList typedef and
1735 made private to class. 1708 made private to class.
1736 1709
1737 03-Apr-2001, D.Williams (geom-solids-specifi 1710 03-Apr-2001, D.Williams (geom-solids-specific-V03-00-01)
1738 ----------------------- 1711 -----------------------
1739 - G4IntersectingCone.cc: make small adjustmen 1712 - G4IntersectingCone.cc: make small adjustment to help with roundoff error
1740 in LineHitsCone1() and LineHitsCone2(). 1713 in LineHitsCone1() and LineHitsCone2().
1741 1714
1742 08-Jan-2001, D.Williams (geom-solids-specifi 1715 08-Jan-2001, D.Williams (geom-solids-specific-V03-00-00)
1743 ----------------------- 1716 -----------------------
1744 - G4Hype.cc: Added protecton against zero v.z 1717 - G4Hype.cc: Added protecton against zero v.z in DistanceToOut.
1745 1718
1746 20-Nov-2000, G.Cosmo (geom-solids-specifi 1719 20-Nov-2000, G.Cosmo (geom-solids-specific-V02-00-04)
1747 --------------------- 1720 ---------------------
1748 - Fixes to remove warnings from "-Wall -ansi 1721 - Fixes to remove warnings from "-Wall -ansi -pedantic" g++ compiler options:
1749 o commented out variables declared and not 1722 o commented out variables declared and not used.
1750 o fixed declaration of variables used befor 1723 o fixed declaration of variables used before being initialised.
1751 o fixed order of initialisation of member d 1724 o fixed order of initialisation of member data in constructors.
1752 o fixed usage of unsigned-int (size_t) for 1725 o fixed usage of unsigned-int (size_t) for array indeces.
1753 1726
1754 13-Nov-2000, G.Cosmo (geom-solids-specifi 1727 13-Nov-2000, G.Cosmo (geom-solids-specific-V02-00-03)
1755 -------------------- 1728 --------------------
1756 - Added definition of empty constructor for G 1729 - Added definition of empty constructor for G4ClippablePolygon which
1757 went lost by mistake... 1730 went lost by mistake...
1758 1731
1759 02-Nov-2000, G.Cosmo (geom-solids-specifi 1732 02-Nov-2000, G.Cosmo (geom-solids-specific-V02-00-02)
1760 -------------------- 1733 --------------------
1761 - QA code revision and cleanup (+fixes from C 1734 - QA code revision and cleanup (+fixes from CodeWizard filtering):
1762 o Avoid inline virtual methods. 1735 o Avoid inline virtual methods.
1763 o General cosmetics for Software Reference 1736 o General cosmetics for Software Reference Manual.
1764 1737
1765 23-Oct-2000, D.Williams (geom-solids-specifi 1738 23-Oct-2000, D.Williams (geom-solids-specific-V02-00-01)
1766 ----------------------- 1739 -----------------------
1767 - G4IntersectingCone.cc: the check for a zero 1740 - G4IntersectingCone.cc: the check for a zero radical has been adjusted to be
1768 less sensitive to round off error in LineHi 1741 less sensitive to round off error in LineHitsCone1(), LineHitsCone2().
1769 This fixes a problem discovered in BaBar. 1742 This fixes a problem discovered in BaBar.
1770 1743
1771 12-Sep-2000, G.Cosmo (geom-solids-specific-V 1744 12-Sep-2000, G.Cosmo (geom-solids-specific-V02-00-00)
1772 -------------------- 1745 --------------------
1773 - Organised comments to headers for Software 1746 - Organised comments to headers for Software Reference Manual.
1774 1747
1775 27-Jun-2000, G.Cosmo (geom-solids-specific-V 1748 27-Jun-2000, G.Cosmo (geom-solids-specific-V01-01-02)
1776 -------------------- 1749 --------------------
1777 - G4Polycone[.hh.cc]: better fix for bug-repo 1750 - G4Polycone[.hh.cc]: better fix for bug-report #110.
1778 Removed struct and replaced with class. 1751 Removed struct and replaced with class.
1779 1752
1780 26-Jun-2000, G.Cosmo (geom-solids-specific-V 1753 26-Jun-2000, G.Cosmo (geom-solids-specific-V01-01-01)
1781 -------------------- 1754 --------------------
1782 - G4Polycone.cc: fixed memory leak by invokin 1755 - G4Polycone.cc: fixed memory leak by invoking destruction of member
1783 enclosingCylinder, which was not cleaned up 1756 enclosingCylinder, which was not cleaned up in the destructor.
1784 This fixes problem report #107. 1757 This fixes problem report #107.
1785 - G4Polycone.hh: added forward declaration of 1758 - G4Polycone.hh: added forward declaration of struct G4PolyconeHistorical
1786 and made it friend, for porting on KCC --st 1759 and made it friend, for porting on KCC --strict. This fixes report #110.
1787 - G4Polyhedra.hh: fixed typo in method name. 1760 - G4Polyhedra.hh: fixed typo in method name. Changed GetNumSIde() to
1788 GetNumSide(). This fixes problem report #10 1761 GetNumSide(). This fixes problem report #105.
1789 1762
1790 08-Jun-2000, G.Gracia 1763 08-Jun-2000, G.Gracia
1791 --------------------- 1764 ---------------------
1792 - G4VCSGfaceted.cc: fix for Win/NT in functio 1765 - G4VCSGfaceted.cc: fix for Win/NT in function GetExtent().
1793 1766
1794 27-Apr-2000, G.Cosmo 1767 27-Apr-2000, G.Cosmo
1795 -------------------- 1768 --------------------
1796 - Removed dependency over the CSG domain in G 1769 - Removed dependency over the CSG domain in GNUmakefile.
1797 1770
1798 18-Apr-2000, D.Williams 1771 18-Apr-2000, D.Williams
1799 ----------------------- 1772 -----------------------
1800 - Removed meaningless "const" specifiers from 1773 - Removed meaningless "const" specifiers from methods in G4ClippablePolygon,
1801 and G4EllipticalTube. 1774 and G4EllipticalTube.
1802 - G4EllipticalTube, G4Hype and G4VCSGfaceted 1775 - G4EllipticalTube, G4Hype and G4VCSGfaceted now inherit directly
1803 from G4VSolid (before was G4CSGSolid). 1776 from G4VSolid (before was G4CSGSolid).
1804 - Reintroduced GetExtent() in G4EllipticalTub 1777 - Reintroduced GetExtent() in G4EllipticalTube, G4Hype and G4VCSGfaceted
1805 (in principle, not needed). 1778 (in principle, not needed).
1806 - Modified assertations in unit test testG4Hy 1779 - Modified assertations in unit test testG4Hype.cc.
1807 1780
1808 11-Apr-2000, J.Allison 1781 11-Apr-2000, J.Allison
1809 ---------------------- 1782 ----------------------
1810 - Removed implementations of GetExtent in mos 1783 - Removed implementations of GetExtent in most sub-classes of G4VSolid (a
1811 default implementation exists in G4VSolid). 1784 default implementation exists in G4VSolid).
1812 - All implementations of DescribeYourselfTo ( 1785 - All implementations of DescribeYourselfTo (G4VGraphicsScene& scene) const
1813 now correctly written: scene.AddThis(*this) 1786 now correctly written: scene.AddThis(*this).
1814 1787
1815 05-Apr-2000, G.Cosmo (geom-solids-specific- 1788 05-Apr-2000, G.Cosmo (geom-solids-specific-V01-01-00)
1816 -------------------- 1789 --------------------
1817 - Restructured solids/CSG domain, by moving t 1790 - Restructured solids/CSG domain, by moving to "specific" the following
1818 classes: G4ClippablePolygon, G4EnclosingCyl 1791 classes: G4ClippablePolygon, G4EnclosingCylinder, G4Hype, G4PolyPhiFace,
1819 G4Polycone, G4PolyconeSide, G4Polyhedra, G4 1792 G4Polycone, G4PolyconeSide, G4Polyhedra, G4PolyhedraSide, G4ReduciblePolygon,
1820 G4IntersectingCone, G4SolidExtentList, G4VC 1793 G4IntersectingCone, G4SolidExtentList, G4VCSGface, G4VCSGfaceted.
1821 The new module's library for "specific" is 1794 The new module's library for "specific" is now called 'G4specsolids'.
1822 - Created specific/test directory and moved t 1795 - Created specific/test directory and moved testG4Hype.cc and testG4Polycone,cc
1823 from CSG/test. 1796 from CSG/test.
1824 - Organised class description comments for th 1797 - Organised class description comments for the Software Reference Manual
1825 and added CVS headers to files. 1798 and added CVS headers to files.
1826 1799
1827 29-Mar-2000, D.Williams 1800 29-Mar-2000, D.Williams
1828 ----------------------- 1801 -----------------------
1829 - Added first implementation of G4EllipticalT 1802 - Added first implementation of G4EllipticalTube.
1830 It defines a simple elliptical tube, as in 1803 It defines a simple elliptical tube, as in geant3 "ELTU".
1831 Files introduced: G4EllipticalTube[.hh.cc]. 1804 Files introduced: G4EllipticalTube[.hh.cc].
1832 1805
1833 25-Mar-2000, G.Cosmo 1806 25-Mar-2000, G.Cosmo
1834 -------------------- 1807 --------------------
1835 - History file created. 1808 - History file created.