Geant4 Cross Reference |
1 # Category geom-specific History 1 # Category geom-specific History 2 2 3 See `CONTRIBUTING.rst` for details of **requir 3 See `CONTRIBUTING.rst` for details of **required** info/format for each entry, 4 which **must** added in reverse chronological 4 which **must** added in reverse chronological order (newest at the top). 5 It must **not** be used as a substitute for wr 5 It must **not** be used as a substitute for writing good git commit messages! 6 6 7 ---------------------------------------------- 7 ------------------------------------------------------------------------------- 8 8 9 ## 2024-10-01 Evgueni Tcherniaev (geom-specifi << 9 ## 2023-01-02 Evgueni Tcherniaev (geom-specific-V11-00-11) 10 - G4GenericTrap: Fixed minor defect reported b << 10 - G4QuadrangularFacet: fixed warning message. 11 << 12 ## 2024-07-18 Alvaro Tolosa-Delgado (geom-spec << 13 - Remove internal state of G4TwistedTubs and G << 14 << 15 ## 2024-07-10 Evgueni Tcherniaev (geom-specifi << 16 - G4ExtrudedSolid: Fixed defects reported by C << 17 << 18 ## 2024-07-08 Gabriele Cosmo (geom-specific-V1 << 19 - Fixed reported Coverity defect; in G4Voxeliz << 20 plain vector copy in methods BuildReduceVoxe << 21 BuildBoundaries() and CreateMiniVoxels(..). << 22 << 23 ## 2024-05-29 Evgueni Tcherniaev (geom-specifi << 24 - Added new methods GetNumOfConstituents() and << 25 << 26 ## 2024-05-27 Evgueni Tcherniaev (geom-specifi << 27 - Completely revised G4GeneriTrap, it addresse << 28 << 29 ## 2024-05-26 Evgueni Tcherniaev (geom-specifi << 30 - New testG4GenericTrap.cc << 31 << 32 ## 2024-04-02 Gabriele Cosmo (geom-specific-V1 << 33 - Applied trivial clang-tidy fixes to classes, << 34 'default' keywords. << 35 << 36 ## 2024-02-01 Gabriele Cosmo (geom-specific-V1 << 37 - Use std::size_t for array sizes in G4Polyhed << 38 << 39 ## 2023-07-10 Evgueni Tcherniaev (geom-specifi << 40 - Fixed bounding box calculation in G4VTwisted << 41 << 42 ## 2023-06-16 Stephan Hageboeck (geom-specific << 43 - Fix an uninitialised value in G4VCSGfaceted: << 44 << 45 ## 2023-06-12 Gabriele Cosmo (geom-specific-V1 << 46 - Use const iterator in G4Voxelizer::GetPointV << 47 - Fixed use of index in G4Tet::GetPointOnSurfa << 48 << 49 ## 2023-05-10 Gabriele Cosmo (geom-specific-V1 << 50 - Applied clang-tidy fixes (readability, moder << 51 << 52 ## 2023-03-20 Gabriele Cosmo (geom-specific-V1 << 53 - Fixed more potential uninitialised values in << 54 G4SolidExtentList and G4VTwistSurface. << 55 << 56 ## 2023-03-13 Gabriele Cosmo (geom-specific-V1 << 57 - Fixed potential uninitialised value for boun << 58 G4VTwistSurface::GetBoundaryAtPZ(). << 59 << 60 ## 2023-01-02 Evgueni Tcherniaev (geom-specifi << 61 - G4QuadrangularFacet: Fixed warning message << 62 11 63 ## 2022-11-10 Gabriele Cosmo (geom-specific-V1 12 ## 2022-11-10 Gabriele Cosmo (geom-specific-V11-00-10) 64 - Fixed compilation warnings for implicit type 13 - Fixed compilation warnings for implicit type conversions on macOS/XCode 14.1. 65 14 66 ## 2022-10-05 Gabriele Cosmo (geom-specific-V1 15 ## 2022-10-05 Gabriele Cosmo (geom-specific-V11-00-09) 67 - Fixed compilation warnings in Intel/icx comp 16 - Fixed compilation warnings in Intel/icx compiler for variables set 68 but never used. 17 but never used. 69 18 70 ## 2022-04-03 Evgueni Tcherniaev (geom-specifi 19 ## 2022-04-03 Evgueni Tcherniaev (geom-specific-V11-00-08) 71 - G4GenericTrap.cc, G4UGenericTrap.cc, G4UExtr 20 - G4GenericTrap.cc, G4UGenericTrap.cc, G4UExtrudedSolid.cc, 72 G4TessellatedSolid.cc, G4TessellatedSolid.cc 21 G4TessellatedSolid.cc, G4TessellatedSolid.cc: 73 revision of CreatePolyhedron() 22 revision of CreatePolyhedron() 74 23 75 ## 2022-02-04 Evgueni Tcherniaev (geom-specifi 24 ## 2022-02-04 Evgueni Tcherniaev (geom-specific-V11-00-07) 76 - G4VTwistedFaceted: used numerical evaluation 25 - G4VTwistedFaceted: used numerical evaluation of a single 77 integral to calculate lateral face surface a 26 integral to calculate lateral face surface area 78 27 79 ## 2022-02-01 Evgueni Tcherniaev (geom-specifi 28 ## 2022-02-01 Evgueni Tcherniaev (geom-specific-V11-00-06) 80 - G4ExtrudedSolid, G4UExtrudedSolid: added def 29 - G4ExtrudedSolid, G4UExtrudedSolid: added default values for 81 parameters in the constructor with two z-sec 30 parameters in the constructor with two z-sections 82 - G4ExtrudedSolid::ZSection, G4UExtrudedSolid: 31 - G4ExtrudedSolid::ZSection, G4UExtrudedSolid::ZSection: 83 added default constructor 32 added default constructor 84 33 85 ## 2022-01-26 Evgueni Tcherniaev (geom-specifi 34 ## 2022-01-26 Evgueni Tcherniaev (geom-specific-V11-00-05) 86 - G4GenericTrap::GetCubicVolume(): calculation 35 - G4GenericTrap::GetCubicVolume(): calculation of volume 87 using analytical expression; removed private 36 using analytical expression; removed private function 88 GetFaceCubicVolume(); 37 GetFaceCubicVolume(); 89 - G4GenericTrap::GetSurfaceArea(): improved ca 38 - G4GenericTrap::GetSurfaceArea(): improved calculation 90 of the area of lateral faces; private functi 39 of the area of lateral faces; private functions 91 GetFaceSurfaceArea(), GetTwistedFaceSurfaceA 40 GetFaceSurfaceArea(), GetTwistedFaceSurfaceArea() 92 replaced with private function GetLateralFac 41 replaced with private function GetLateralFaceArea() 93 42 94 ## 2022-01-21 Evgueni Tcherniaev (geom-specifi 43 ## 2022-01-21 Evgueni Tcherniaev (geom-specific-V11-00-04) 95 - G4Ellipsoid::LateralSurfaceArea(): Enhanced 44 - G4Ellipsoid::LateralSurfaceArea(): Enhanced calculation of 96 the lateral surface area 45 the lateral surface area 97 46 98 ## 2022-01-11 Evgueni Tcherniaev (geom-specifi 47 ## 2022-01-11 Evgueni Tcherniaev (geom-specific-V11-00-03) 99 - G4VTwistedFaceted: fCubicVolume, fSurfaceAre 48 - G4VTwistedFaceted: fCubicVolume, fSurfaceArea made protected, 100 GetCubicVolume(), GetSurfaceArea() moved to 49 GetCubicVolume(), GetSurfaceArea() moved to *.cc 101 - G4VTwistedFaceted, G4TwistedBox, G4TwistedTr 50 - G4VTwistedFaceted, G4TwistedBox, G4TwistedTrd: optimized 102 calculation of volume and surface area 51 calculation of volume and surface area 103 52 104 ## 2022-01-06 Evgueni Tcherniaev (geom-specifi 53 ## 2022-01-06 Evgueni Tcherniaev (geom-specific-V11-00-02) 105 - G4TwistedTubs: Implemented GetSurfaceArea() 54 - G4TwistedTubs: Implemented GetSurfaceArea() based on 106 analytical expressions; added private functi 55 analytical expressions; added private functions 107 GetLateralArea() and GetPhiCutArea() 56 GetLateralArea() and GetPhiCutArea() 108 57 109 ## 2021-12-19 Evgueni Tcherniaev (geom-specifi 58 ## 2021-12-19 Evgueni Tcherniaev (geom-specific-V11-00-01) 110 - G4Hype: Used analytical expression in GetCub 59 - G4Hype: Used analytical expression in GetCubicVolume() 111 and GetSurfaceArea() 60 and GetSurfaceArea() 112 61 113 ## 2021-12-10 Ben Morgan (geom-specific-V11-00 62 ## 2021-12-10 Ben Morgan (geom-specific-V11-00-00) 114 - Change to new Markdown History format 63 - Change to new Markdown History format 115 64 116 --- 65 --- 117 66 118 # History entries prior to 11.0 67 # History entries prior to 11.0 119 68 120 03-December-2021 E.Tcherniaev (geom-speci 69 03-December-2021 E.Tcherniaev (geom-specific-V10-07-13) 121 - G4TwistedTubs: Accurate calculation of the b 70 - G4TwistedTubs: Accurate calculation of the bounding box in 122 BoundingLimits() and GetExtent(), fixing mea 71 BoundingLimits() and GetExtent(), fixing measured performance 123 penalty. Addressing problem report #2450. 72 penalty. Addressing problem report #2450. 124 - G4TwistedTubs, G4VTwistedFaceted: Fixed GetC 73 - G4TwistedTubs, G4VTwistedFaceted: Fixed GetCubicVolume() 125 74 126 15-October-2021 E.Tcherniaev (geom-speci 75 15-October-2021 E.Tcherniaev (geom-specific-V10-07-12) 127 - G4Tet, G4UTet: Added SetBoundingLimits() 76 - G4Tet, G4UTet: Added SetBoundingLimits() 128 77 129 06-October-2021 E.Tcherniaev (geom-speci 78 06-October-2021 E.Tcherniaev (geom-specific-V10-07-11) 130 - G4Tet: some changes in calculation of boundi 79 - G4Tet: some changes in calculation of bounding box 131 - G4UTet: added CheckDegeneracy() and SetVerti 80 - G4UTet: added CheckDegeneracy() and SetVertices() 132 81 133 27-September-2021 E.Tcherniaev (geom-speci 82 27-September-2021 E.Tcherniaev (geom-specific-V10-07-10) 134 - Added degeneracyFlag to the list of paramete 83 - Added degeneracyFlag to the list of parameters of G4Tet::SetVertices(), 135 it addresses first part of the problem repor 84 it addresses first part of the problem report #2427 136 85 137 24-September-2021 E.Tcherniaev (geom-speci 86 24-September-2021 E.Tcherniaev (geom-specific-V10-07-09) 138 - Implemented G4TesselatedSolid::GetFacetIndex 87 - Implemented G4TesselatedSolid::GetFacetIndex(p) 139 88 140 10-September-2021 E.Tcherniaev (geom-speci 89 10-September-2021 E.Tcherniaev (geom-specific-V10-07-08) 141 - Implemented G4TesselatedSolid::CheckStructur 90 - Implemented G4TesselatedSolid::CheckStructure() 142 - Optimisation in G4TessellatedSolid::SetExtre 91 - Optimisation in G4TessellatedSolid::SetExtremeFacets(): 143 shuffle of vertices and checking of six extr 92 shuffle of vertices and checking of six extreme vertices 144 93 145 21-July-2021 E.Tcherniaev (geom-speci 94 21-July-2021 E.Tcherniaev (geom-specific-V10-07-07) 146 - More accurate calculation of distance from p 95 - More accurate calculation of distance from point to triangle 147 in G4TriangularFacet, it addresses problem r 96 in G4TriangularFacet, it addresses problem report #2401 148 97 149 25-June-2021 G.Cosmo (geom-speci 98 25-June-2021 G.Cosmo (geom-specific-V10-07-06) 150 - Added missing accessor in G4UTet. 99 - Added missing accessor in G4UTet. 151 100 152 12-May-2021 E.Tcherniaev (geom-speci 101 12-May-2021 E.Tcherniaev (geom-specific-V10-07-05) 153 - Reimplemented CreatePolyhedron() in 102 - Reimplemented CreatePolyhedron() in 154 G4Polyhedra, G4Polycone, G4GenericPolycone, 103 G4Polyhedra, G4Polycone, G4GenericPolycone, 155 G4UPolyhedra, G4UPolycone, G4UGenericPolycon 104 G4UPolyhedra, G4UPolycone, G4UGenericPolycone 156 105 157 30-April-2021 G.Cosmo (geom-speci 106 30-April-2021 G.Cosmo (geom-specific-V10-07-04) 158 - Fixed use of conversion factor in G4UPolyhed 107 - Fixed use of conversion factor in G4UPolyhedra wrapper for "generic" 159 polyhedra constructs. 108 polyhedra constructs. 160 109 161 19-April-2021 E.Tcherniaev (geom-speci 110 19-April-2021 E.Tcherniaev (geom-specific-V10-07-03) 162 - G4Polyhedra, G4Polycone: Fix calculation of 111 - G4Polyhedra, G4Polycone: Fix calculation of endPhi for the case 163 of negative phiStart, it addresses also prob 112 of negative phiStart, it addresses also problem report #2362 164 113 165 30-March-2021 B.Morgan (geom-speci 114 30-March-2021 B.Morgan (geom-specific-V10-07-02) 166 - Migrate sources.cmake to modular build API 115 - Migrate sources.cmake to modular build API 167 116 168 18-March-2021 E.Tcherniaev (geom-speci 117 18-March-2021 E.Tcherniaev (geom-specific-V10-07-01) 169 - Fix calculation of bounding box position in 118 - Fix calculation of bounding box position in G4Voxelizer::BuildVoxelLimits(), 170 it addresses problem report #2301 119 it addresses problem report #2301 171 120 172 13-January-2021 G.Cosmo (geom-speci 121 13-January-2021 G.Cosmo (geom-specific-V10-07-00) 173 - Reduce cases of bad speculation in G4Polyhed 122 - Reduce cases of bad speculation in G4PolyhedraSide::Inside() and 174 G4PolyPhiFace::InsideEdges(), based on repor 123 G4PolyPhiFace::InsideEdges(), based on report in profiling analysis 175 by G.Amadio. 124 by G.Amadio. 176 125 177 30-October-2020 E.Tcherniaev (geom-speci 126 30-October-2020 E.Tcherniaev (geom-specific-V10-06-10) 178 - G4Polycone: Revised GetPointOnSurface(); 127 - G4Polycone: Revised GetPointOnSurface(); 179 Added protected auxiliary method SetSurfaceE 128 Added protected auxiliary method SetSurfaceElements(); 180 Removed GetPointOnCone(), GetPointOnTubs(), 129 Removed GetPointOnCone(), GetPointOnTubs(), GetPointOnCut(), GetPointOnRing(); 181 - G4GenericPolycone: Revised GetPointOnSurface 130 - G4GenericPolycone: Revised GetPointOnSurface(); 182 Added protected auxiliary method SetSurfaceE 131 Added protected auxiliary method SetSurfaceElements(); 183 - G4Polyhedra: Revised GetPointOnSurface(); 132 - G4Polyhedra: Revised GetPointOnSurface(); 184 Added protected auxiliary method SetSurfaceE 133 Added protected auxiliary method SetSurfaceElements(); 185 Removed GetPointOnPlane(), GetPointOnTriangl 134 Removed GetPointOnPlane(), GetPointOnTriangle(); 186 135 187 01-October-2020 E.Tcherniaev (geom-speci 136 01-October-2020 E.Tcherniaev (geom-specific-V10-06-09) 188 - G4Polycone, G4GenericPolycone, G4Polyhedra: 137 - G4Polycone, G4GenericPolycone, G4Polyhedra: 189 implemented GetSurfaceArea(), GetCubicVolume 138 implemented GetSurfaceArea(), GetCubicVolume(). 190 139 191 May 21, 2020 Guilherme Lima (geom-speci 140 May 21, 2020 Guilherme Lima (geom-specific-V10-06-08) 192 ---------------------------- 141 ---------------------------- 193 - Fix constructor signatures in G4UExtrudedSol 142 - Fix constructor signatures in G4UExtrudedSolid wrappers, to match those in G4 version. 194 There were missing const and reference quali 143 There were missing const and reference qualifiers in non-POD parameters. 195 144 196 30-April-2020 G.Cosmo (geom-speci 145 30-April-2020 G.Cosmo (geom-specific-V10-06-07) 197 - Adopt new convention for location of headers 146 - Adopt new convention for location of headers in VecGeom for all wrappers. 198 147 199 09-April-2020 E.Tcherniaev (geom-speci 148 09-April-2020 E.Tcherniaev (geom-specific-V10-06-06) 200 - Added G4GenericTrap::GetTwistedFaceSurfaceAr 149 - Added G4GenericTrap::GetTwistedFaceSurfaceArea(). 201 - testG4GenericTrap.cc: fixed test for calcula 150 - testG4GenericTrap.cc: fixed test for calculation of surface area. 202 - testG4ExtrudedSolid.cc: fixed assert stateme 151 - testG4ExtrudedSolid.cc: fixed assert statements for cases where 203 point flys along the surface (DistanceToIn() 152 point flys along the surface (DistanceToIn() returns kInfinity). 204 153 205 17-January-2020 E.Tcherniaev (geom-speci 154 17-January-2020 E.Tcherniaev (geom-specific-V10-06-05) 206 - Implemented G4Tet::SetVertices(), it address 155 - Implemented G4Tet::SetVertices(), it addresses request made 207 at Geant4 Technical Forum. 156 at Geant4 Technical Forum. 208 157 209 14-January-2020 Gabriele Cosmo (geom-speci 158 14-January-2020 Gabriele Cosmo (geom-specific-V10-06-04) 210 - Added protection in G4VFacet header for doub 159 - Added protection in G4VFacet header for double definition of global 211 symbols from Windows Kits code. 160 symbols from Windows Kits code. 212 161 213 08-January-2020 E.Tcherniaev (geom-speci 162 08-January-2020 E.Tcherniaev (geom-specific-V10-06-03) 214 - Complete revision of G4Tet, speed up, new te 163 - Complete revision of G4Tet, speed up, new testG4Tet.cc. 215 It also fixes issues spotted by new unit tes 164 It also fixes issues spotted by new unit test. 216 165 217 16-December-2019 E.Tcherniaev (geom-speci 166 16-December-2019 E.Tcherniaev (geom-specific-V10-06-02) 218 - Complete revision of G4Ellipsoid, it fixes i 167 - Complete revision of G4Ellipsoid, it fixes issues with former 219 implementation, in particular it addresses p 168 implementation, in particular it addresses problem report #2206. 220 30%-70% speed-up in all main methods. 169 30%-70% speed-up in all main methods. 221 170 222 11-December-2019 B.Morgan (geom-speci 171 11-December-2019 B.Morgan (geom-specific-V10-06-01) 223 - Cleanup CMake build, removing obsolete granu 172 - Cleanup CMake build, removing obsolete granular library options and 224 explicit include_directories. 173 explicit include_directories. 225 174 226 10-December-2019 G.Cosmo (geom-speci 175 10-December-2019 G.Cosmo (geom-specific-V10-06-00) 227 - Re-established parameterisation mechanism fo 176 - Re-established parameterisation mechanism for G4Tet and G4UTet which was 228 removed by mistake. Addressing problem repor 177 removed by mistake. Addressing problem report #2209. 229 178 230 26-November-2019 G.Cosmo (geom-speci 179 26-November-2019 G.Cosmo (geom-specific-V10-05-21) 231 - Fixed cases of implicit type conversions fro 180 - Fixed cases of implicit type conversions from size_t to G4int. 232 181 233 05-November-2019 E.Tcherniaev (geom-speci 182 05-November-2019 E.Tcherniaev (geom-specific-V10-05-20) 234 - G4TesselatedSolid.cc: fixed minor Coverity d 183 - G4TesselatedSolid.cc: fixed minor Coverity defect (uninitialized array) 235 184 236 07-October-2019 E.Tcherniaev (geom-speci 185 07-October-2019 E.Tcherniaev (geom-specific-V10-05-19) 237 - G4TesselatedSolid.cc: fixed minor Coverity d 186 - G4TesselatedSolid.cc: fixed minor Coverity defect 238 187 239 16-September-2019 G.Cosmo (geom-speci 188 16-September-2019 G.Cosmo (geom-specific-V10-05-18) 240 - Rationalise header inclusions for faceted so 189 - Rationalise header inclusions for faceted solids. 241 190 242 06-September-2019 G.Cosmo (geom-speci 191 06-September-2019 G.Cosmo (geom-specific-V10-05-17) 243 - Removed unnecessary forward declaration in G 192 - Removed unnecessary forward declaration in G4VFacet header. 244 193 245 29-August-2019 G.Cosmo (geom-speci 194 29-August-2019 G.Cosmo (geom-specific-V10-05-16) 246 - Minor c++11 revision and headers cleanup. Co 195 - Minor c++11 revision and headers cleanup. Code formatting. 247 - Use pre-increment wherever possible. 196 - Use pre-increment wherever possible. 248 197 249 19-August-2019 G.Lima (geom-speci 198 19-August-2019 G.Lima (geom-specific-V10-05-15) 250 - G4ExtrudedSolid: fixed a bug in DistanceToOu 199 - G4ExtrudedSolid: fixed a bug in DistanceToOut(), affecting extruded solids 251 defined off-center along the z-axis. 200 defined off-center along the z-axis. 252 201 253 19-August-2019 G.Cosmo (geom-speci 202 19-August-2019 G.Cosmo (geom-specific-V10-05-14) 254 - G4GenericTrap: fixed compilation warnings fo 203 - G4GenericTrap: fixed compilation warnings for variable shadowing on clang-8. 255 204 256 13-August-2019 G.Cosmo (geom-speci 205 13-August-2019 G.Cosmo (geom-specific-V10-05-13) 257 - Enabled wrappers for VecGeom implementation 206 - Enabled wrappers for VecGeom implementation of G4EllipticalTube, 258 G4EllipticalCone and G4Ellipsoid. 207 G4EllipticalCone and G4Ellipsoid. 259 208 260 10-July-2019 E.Tcherniaev (geom-speci 209 10-July-2019 E.Tcherniaev (geom-specific-V10-05-12) 261 - Fixed G4UExtrudedSolid::CreatePolyhedron(). 210 - Fixed G4UExtrudedSolid::CreatePolyhedron(). 262 Addressing visualization part of the problem 211 Addressing visualization part of the problem report #2171. 263 212 264 04-July-2019 G.Cosmo (geom-speci 213 04-July-2019 G.Cosmo (geom-specific-V10-05-11) 265 - Avoid defining kCarTolerance as 'static cons 214 - Avoid defining kCarTolerance as 'static const' in G4VFacet. 266 Addressing problem report #2172. 215 Addressing problem report #2172. 267 216 268 11-June-2019 E.Tcherniaev (geom-speci 217 11-June-2019 E.Tcherniaev (geom-specific-V10-05-10) 269 - Use GetVertices() instead of GetParametersLi 218 - Use GetVertices() instead of GetParametersList() in the wrapper G4UTet. 270 219 271 29-May-2019 G.Cosmo (geom-speci 220 29-May-2019 G.Cosmo (geom-specific-V10-05-09) 272 - Fixed minor Coverity defects. 221 - Fixed minor Coverity defects. 273 222 274 20-May-2019 G.Cosmo (geom-speci 223 20-May-2019 G.Cosmo (geom-specific-V10-05-08) 275 - Defined move constructor and move assignment 224 - Defined move constructor and move assignment operator for G4TriangularFacet. 276 225 277 14-May-2019 B.Morgan (geom-speci 226 14-May-2019 B.Morgan (geom-specific-V10-05-07) 278 - Add inclusion of new G4GeomTypes.hh header t 227 - Add inclusion of new G4GeomTypes.hh header to those headers allowing 279 VecGeom replacement. 228 VecGeom replacement. 280 - See also geommng-10-05-05 229 - See also geommng-10-05-05 281 230 282 23-April-2019 G.Cosmo (geom-speci 231 23-April-2019 G.Cosmo (geom-specific-V10-05-06) 283 - Modified G4PolyconeSide and G4PolyhedraSide 232 - Modified G4PolyconeSide and G4PolyhedraSide to use only trivial types for 284 MT splitted data in G4PlSideData and G4PhSid 233 MT splitted data in G4PlSideData and G4PhSideData respectively. 285 234 286 16-April-2019 G.Cosmo (geom-speci 235 16-April-2019 G.Cosmo (geom-specific-V10-05-05) 287 - Protected check in G4TwistTubsSide::Distance 236 - Protected check in G4TwistTubsSide::DistanceToPlane() withing debug flag. 288 237 289 4-April-2019 G.Cosmo (geom-speci 238 4-April-2019 G.Cosmo (geom-specific-V10-05-04) 290 - Enabled wrapper for VecGeom implementation o 239 - Enabled wrapper for VecGeom implementation of G4GenericPolycone. 291 240 292 15-February-2019 E.Tcherniaev (geom-speci 241 15-February-2019 E.Tcherniaev (geom-specific-V10-05-03) 293 - Accurate calculation of radical in G4Interse 242 - Accurate calculation of radical in G4IntersectingCone. 294 It addresses the problem report #2111. 243 It addresses the problem report #2111. 295 244 296 4-February-2019 G.Cosmo (geom-speci 245 4-February-2019 G.Cosmo (geom-specific-V10-05-02) 297 - Fix in G4EllipticalTube::CheckParameters() f 246 - Fix in G4EllipticalTube::CheckParameters() for typo in condition. 298 247 299 30-January-2019 G.Cosmo (geom-speci 248 30-January-2019 G.Cosmo (geom-specific-V10-05-01) 300 - Disabled precise computation of extent and u 249 - Disabled precise computation of extent and use simple bounding-box 301 in CalculateExtent() for G4Tet and G4Tessell 250 in CalculateExtent() for G4Tet and G4TessellatedSolid, to speed up 302 intialisation in setups with relatively comp 251 intialisation in setups with relatively complex meshes. 303 - Apply bounding-box calculation for extent al 252 - Apply bounding-box calculation for extent also for corresponding 304 VecGeom wrappers. 253 VecGeom wrappers. 305 254 306 24-January-2019 E.Tcherniaev (geom-speci 255 24-January-2019 E.Tcherniaev (geom-specific-V10-05-00) 307 - Completely revised, more robust and performa 256 - Completely revised, more robust and performant G4EllipticalTube; 308 new exhaustive test/testEllipticalTube.cc ba 257 new exhaustive test/testEllipticalTube.cc based on Shape Conventions. 309 258 310 20-September-2018 G.Cosmo (geom-speci 259 20-September-2018 G.Cosmo (geom-specific-V10-04-15) 311 - Make G4UPolycone wrapper inheriting from vec 260 - Make G4UPolycone wrapper inheriting from vecgeom::GenericUnplacedPolycone, 312 following the latest changes in VecGeom. 261 following the latest changes in VecGeom. 313 262 314 13-September-2018 G.Cosmo (geom-speci 263 13-September-2018 G.Cosmo (geom-specific-V10-04-14) 315 - G4UTessellatedSolid, G4UExtrudedSolid: remov 264 - G4UTessellatedSolid, G4UExtrudedSolid: removed leftover use of 316 UVector3 and replaced with U3Vector. 265 UVector3 and replaced with U3Vector. 317 266 318 23-August-2018 G.Cosmo (geom-speci 267 23-August-2018 G.Cosmo (geom-specific-V10-04-13) 319 - Enabled VecGeom wrapper for G4Tet. 268 - Enabled VecGeom wrapper for G4Tet. 320 269 321 10-August-2018 A.Gheata (geom-speci 270 10-August-2018 A.Gheata (geom-specific-V10-04-12) 322 - Make G4UHype wrapper inheriting from vecgeom 271 - Make G4UHype wrapper inheriting from vecgeom::GenericUnplacedHype, 323 following the latest changes in VecGeom. 272 following the latest changes in VecGeom. 324 273 325 12-July-2018 G.Cosmo (geom-speci 274 12-July-2018 G.Cosmo (geom-specific-V10-04-11) 326 - Removed G4SolidsWorkspacePool class. Adapted 275 - Removed G4SolidsWorkspacePool class. Adapted G4SolidsWorkspace to 327 use templated class G4TWorkspacePool. 276 use templated class G4TWorkspacePool. 328 - Coworks with tags in geometry/volumes, run a 277 - Coworks with tags in geometry/volumes, run and visualization/management. 329 278 330 25-Jun-2018 G.Cosmo (geom-speci 279 25-Jun-2018 G.Cosmo (geom-specific-V10-04-10) 331 - Use dynamic_cast to attempt fix for spurious 280 - Use dynamic_cast to attempt fix for spurious compilation warnings on 332 CentOS7/gcc-5.3 on G4UTessellatedSolid wrapp 281 CentOS7/gcc-5.3 on G4UTessellatedSolid wrapper. 333 282 334 17-May-2018 J.Madsen (geom-speci 283 17-May-2018 J.Madsen (geom-specific-V10-04-09) 335 - Updated "thread-local-static-var" model to 284 - Updated "thread-local-static-var" model to 336 "function-returning-thread-local-static-refe 285 "function-returning-thread-local-static-reference" model 337 which fixes Windows DLL + MT 286 which fixes Windows DLL + MT 338 287 339 11-April-2018 G.Cosmo (geom-speci 288 11-April-2018 G.Cosmo (geom-specific-V10-04-08) 340 - Replaced USOLIDS_LIBRARIES with VECGEOM_LIBR 289 - Replaced USOLIDS_LIBRARIES with VECGEOM_LIBRARIES in sources.cmake. 341 290 342 13-February-2018 E.Tcherniaev (geom-speci 291 13-February-2018 E.Tcherniaev (geom-specific-V10-04-07) 343 - Corrected conversion of input parameters to 292 - Corrected conversion of input parameters to internal structure (used for 344 caching for adoption in GDML persistency) in 293 caching for adoption in GDML persistency) in G4UPolycone and G4UPolyhedra 345 wrappers. 294 wrappers. 346 295 347 9-February-2018 G.Cosmo (geom-speci 296 9-February-2018 G.Cosmo (geom-specific-V10-04-06) 348 - Caching facets and vertices in G4UTessellate 297 - Caching facets and vertices in G4UTessellatedSolid wrapper for properly 349 treating indexing in facets. 298 treating indexing in facets. 350 299 351 31-January-2018 G.Cosmo (geom-speci 300 31-January-2018 G.Cosmo (geom-specific-V10-04-05) 352 - Corrected use of facets indeces in G4UTessel 301 - Corrected use of facets indeces in G4UTessellatedSolid for visualization. 353 - Minor cleanup in G4TessellatedSolid::CreateP 302 - Minor cleanup in G4TessellatedSolid::CreatePolyhedron(), no functional 354 changes. 303 changes. 355 304 356 15-January-2018 G.Cosmo (geom-speci 305 15-January-2018 G.Cosmo (geom-specific-V10-04-04) 357 - Added validity checks in G4UTessellatedSolid 306 - Added validity checks in G4UTessellatedSolid::AddFacet(). 358 307 359 11-January-2018 G.Cosmo (geom-speci 308 11-January-2018 G.Cosmo (geom-specific-V10-04-03) 360 - Added and enabled VecGeom wrapper for G4Tess 309 - Added and enabled VecGeom wrapper for G4TessellatedSolid. 361 Requires tags cmake-V10-04-01 and config-V10 310 Requires tags cmake-V10-04-01 and config-V10-04-00. 362 311 363 20-December-2017 G.Cosmo (geom-speci 312 20-December-2017 G.Cosmo (geom-specific-V10-04-02) 364 - Enabled VecGeom wrappers for G4ExtrudedSolid 313 - Enabled VecGeom wrappers for G4ExtrudedSolid and G4Hype. 365 314 366 13-December-2017 E.Tcherniaev (geom-speci 315 13-December-2017 E.Tcherniaev (geom-specific-V10-04-01) 367 - Removed redundant data initialistion in G4Ex 316 - Removed redundant data initialistion in G4ExtrudedSolid constructors. 368 317 369 11-December-2017 E.Tcherniaev (geom-speci 318 11-December-2017 E.Tcherniaev (geom-specific-V10-04-00) 370 - Added missing initialisation of two data-mem 319 - Added missing initialisation of two data-members in copy-ctor and 371 assignment operator of G4ExtrudedSolid. Addr 320 assignment operator of G4ExtrudedSolid. Addressing problem report #2016. 372 321 373 22-November-2017 G.Cosmo (geom-specif 322 22-November-2017 G.Cosmo (geom-specific-V10-03-25) 374 - Fix in SurfaceNormal() for G4ExtrudedSolid t 323 - Fix in SurfaceNormal() for G4ExtrudedSolid to assure explicit 375 counting of the surfaces where the point is 324 counting of the surfaces where the point is placed on edg 376 325 377 2-November-2017 G.Cosmo (geom-specif 326 2-November-2017 G.Cosmo (geom-specific-V10-03-24) 378 - Fixed compilation warning introduced with la 327 - Fixed compilation warning introduced with last tag. 379 328 380 31-October-2017 E.Tcherniaev (geom-specif 329 31-October-2017 E.Tcherniaev (geom-specific-V10-03-23) 381 - Added specialised implementation for constru 330 - Added specialised implementation for constructs defining a non-convex right 382 prism in G4ExtrudedSolid. 331 prism in G4ExtrudedSolid. 383 332 384 20-October-2017 G.Cosmo (geom-specif 333 20-October-2017 G.Cosmo (geom-specific-V10-03-22) 385 - G4TessellatedSolid: print also solid's name 334 - G4TessellatedSolid: print also solid's name in StreamInfo(). 386 335 387 17-October-2017 G.Cosmo (geom-specif 336 17-October-2017 G.Cosmo (geom-specific-V10-03-21) 388 - Added VecGeom wrapper G4UHype for G4Hype, no 337 - Added VecGeom wrapper G4UHype for G4Hype, not yet activated, pending 389 fixes in VecGeom. 338 fixes in VecGeom. 390 339 391 16-October-2017 G.Cosmo (geom-specif 340 16-October-2017 G.Cosmo (geom-specific-V10-03-20) 392 - Temporarly disabled wrappers for G4Tet and G 341 - Temporarly disabled wrappers for G4Tet and G4GenericPolycone, pending 393 their corresponding implementation in VecGeo 342 their corresponding implementation in VecGeom. 394 343 395 28-September-2017 G.Cosmo (geom-specif 344 28-September-2017 G.Cosmo (geom-specific-V10-03-19) 396 - Corrected initialisation of polyhedra by ver 345 - Corrected initialisation of polyhedra by vertices in G4UPolyhdra wrapper 397 following the changes in VecGeom. 346 following the changes in VecGeom. 398 347 399 15-September-2017 G.Cosmo (geom-specif 348 15-September-2017 G.Cosmo (geom-specific-V10-03-18) 400 - G4SolidsWorkspacePool: use DLL export flag f 349 - G4SolidsWorkspacePool: use DLL export flag for static thread-local 401 symbol of the workspace. 350 symbol of the workspace. 402 351 403 12-September-2017 G.Cosmo (geom-specif 352 12-September-2017 G.Cosmo (geom-specific-V10-03-17) 404 - G4Voxelizer: directly set components for bou 353 - G4Voxelizer: directly set components for bounding-box instead of 405 recreating it in BuildBoundingBox(..). 354 recreating it in BuildBoundingBox(..). 406 355 407 8-September-2017 E.Tcherniaev (geom-specif 356 8-September-2017 E.Tcherniaev (geom-specific-V10-03-16) 408 - Added specialised implementation for constru 357 - Added specialised implementation for constructs defining a convex right 409 prism in G4ExtrudedSolid. 358 prism in G4ExtrudedSolid. 410 359 411 4-September-2017 G.Cosmo (geom-specif 360 4-September-2017 G.Cosmo (geom-specific-V10-03-15, 14) 412 - Temporarly disabled wrapper for extruded-sol 361 - Temporarly disabled wrapper for extruded-solid, pending implementation 413 of extruded-solid in VecGeom. 362 of extruded-solid in VecGeom. 414 363 415 16-August-2017 J.Allison (geom-specif 364 16-August-2017 J.Allison (geom-specific-V10-03-13) 416 - Twisted solids: Fixed bug in drawing polyhed 365 - Twisted solids: Fixed bug in drawing polyhedra with negative twist angle. 417 Addressing problem report #1995. 366 Addressing problem report #1995. 418 367 419 27-July-2017 E.Tcherniaev (geom-specif 368 27-July-2017 E.Tcherniaev (geom-specific-V10-03-12) 420 - G4EllipticalCone: corrected samping of rando 369 - G4EllipticalCone: corrected samping of random points on lateral surface in 421 function GetPointOnSurface(). 370 function GetPointOnSurface(). 422 371 423 24-July-2017 E.Tcherniaev (geom-specif 372 24-July-2017 E.Tcherniaev (geom-specific-V10-03-11) 424 - G4EllipticalCone: improved GetPointOnSurface 373 - G4EllipticalCone: improved GetPointOnSurface() to have uniform sampling of 425 points, using function G4RandomPointOnEllips 374 points, using function G4RandomPointOnEllipse(). 426 375 427 20-July-2017 E.Tcherniaev (geom-specif 376 20-July-2017 E.Tcherniaev (geom-specific-V10-03-10, 09) 428 - G4EllipticalCone: reviewed implementation of 377 - G4EllipticalCone: reviewed implementation of Inside(), DistanceToIn/Out(p), 429 SurfaceNormal() and GetPointOnSurface(); mad 378 SurfaceNormal() and GetPointOnSurface(); made more compact and performant. 430 Addressing problem report #1974. 379 Addressing problem report #1974. 431 380 432 15-June-2017 G.Cosmo (geom-specif 381 15-June-2017 G.Cosmo (geom-specific-V10-03-08) 433 - Enabled adapter also in G4UPolycone wrapper. 382 - Enabled adapter also in G4UPolycone wrapper. 434 - Added check on open solid for G4UPolyhedra w 383 - Added check on open solid for G4UPolyhedra wrapper. 435 384 436 6-June-2017 G.Cosmo (geom-specif 385 6-June-2017 G.Cosmo (geom-specific-V10-03-07) 437 - Enable adapter for VecGeom shapes in G4U* wr 386 - Enable adapter for VecGeom shapes in G4U* wrappers for: paraboloid, 438 polyhedra and GenericTrap. From now on, wrap 387 polyhedra and GenericTrap. From now on, wrappers depends directly on 439 VecGeom shapes implementation. USolids API i 388 VecGeom shapes implementation. USolids API is deprecated and no longer 440 supported. 389 supported. 441 390 442 24-May-2017 G.Cosmo (geom-specif 391 24-May-2017 G.Cosmo (geom-specific-V10-03-06) 443 - Renamed ambiguous name Extent() in all solid 392 - Renamed ambiguous name Extent() in all solids and G4U* wrappers to 444 BoundingLimits(). Change required in order t 393 BoundingLimits(). Change required in order to avoid signature conflict 445 with VecGeom in G4U* wrappers. 394 with VecGeom in G4U* wrappers. 446 Requires tag geommng-V10-03-16. 395 Requires tag geommng-V10-03-16. 447 396 448 11-May-2017 G.Cosmo (geom-specif 397 11-May-2017 G.Cosmo (geom-specific-V10-03-05) 449 - Removed potential race condition in G4VTwist 398 - Removed potential race condition in G4VTwistSurface::AmIOnLeftSide(). 450 Addressing problem report #1972. 399 Addressing problem report #1972. 451 400 452 7-April-2017 G.Cosmo (geom-specif 401 7-April-2017 G.Cosmo (geom-specific-V10-03-04) 453 - Renamed G4SurfaceVoxelizer to G4Voxelizer an 402 - Renamed G4SurfaceVoxelizer to G4Voxelizer and extended to support 454 voxelisation of shapes in 3D space. Adapted 403 voxelisation of shapes in 3D space. Adapted G4TessellatedSolid accordingly. 455 404 456 13-March-2017 G.Cosmo (geom-specif 405 13-March-2017 G.Cosmo (geom-specific-V10-03-03) 457 - G4SolidsWorkspacePool: implemented CleanUpAn 406 - G4SolidsWorkspacePool: implemented CleanUpAndDestroyAllWorkspaces(), 458 to be called by worker threads. Removed decl 407 to be called by worker threads. Removed declaration (i.e. not implemented) 459 of protected method ReleaseAndDestroyWorkspa 408 of protected method ReleaseAndDestroyWorkspace(). 460 409 461 2-March-2017 E.Tcherniaev (geom-specif 410 2-March-2017 E.Tcherniaev (geom-specific-V10-03-02) 462 - Fixed possible rounding off error in calcula 411 - Fixed possible rounding off error in calculation of 'astep' (max angle 463 for one step) in CalculateExtent() for G4Pol 412 for one step) in CalculateExtent() for G4Polycone, G4GenericPolycone 464 and related USolids wrappers. 413 and related USolids wrappers. 465 414 466 27-February-2017 E.Tcherniaev (geom-specif 415 27-February-2017 E.Tcherniaev (geom-specific-V10-03-01) 467 - Revised implementation of GetCubicVolume() a 416 - Revised implementation of GetCubicVolume() and GetSurfaceArea() for 468 G4EllipticalTube, to return exact values. 417 G4EllipticalTube, to return exact values. 469 - Revised implementation of GetSurfaceArea() f 418 - Revised implementation of GetSurfaceArea() for G4EllipticalCone, to 470 return exact value; moved both GetCubicVolum 419 return exact value; moved both GetCubicVolume() and GetSurfaceArea() to 471 be not inline. 420 be not inline. 472 421 473 13-December-2016 G.Cosmo (geom-specif 422 13-December-2016 G.Cosmo (geom-specific-V10-03-00) 474 - Correction in G4UExtrudedSolid to signature 423 - Correction in G4UExtrudedSolid to signature for CalculateExtent(). 475 Fixes issue of undefined symbol if extruded- 424 Fixes issue of undefined symbol if extruded-solid not included in the 476 list of VecGeom wrappers to activate. 425 list of VecGeom wrappers to activate. 477 426 478 30-November-2016 E.Tcherniaev (geom-specif 427 30-November-2016 E.Tcherniaev (geom-specific-V10-02-25) 479 - Call RemoveRedundantVertices() from G4GeomTo 428 - Call RemoveRedundantVertices() from G4GeomTools in CalculateExtent() 480 for G4Polycone, G4Polyhedra and related USol 429 for G4Polycone, G4Polyhedra and related USolids wrappers. 481 - Fix in G4Parabolid and G4UParaboloid for cor 430 - Fix in G4Parabolid and G4UParaboloid for correct computation of extent. 482 431 483 18-November-2016 E.Tcherniaev (geom-specif 432 18-November-2016 E.Tcherniaev (geom-specific-V10-02-24) 484 - Added consistency checks for extent computat 433 - Added consistency checks for extent computation in USolids wrappers. 485 - Fix in cached parameters in G4UPolyhedra. 434 - Fix in cached parameters in G4UPolyhedra. 486 435 487 10-November-2016 G.Cosmo (geom-specif 436 10-November-2016 G.Cosmo (geom-specific-V10-02-23) 488 - G4UPolyhedra re-introduced new implementatio 437 - G4UPolyhedra re-introduced new implementation of CalculateExtent() using 489 G4BoundingEnvelope and extended wrapper to c 438 G4BoundingEnvelope and extended wrapper to cache corners and start/end 490 Phi parameters, to overcome issues in VecGeo 439 Phi parameters, to overcome issues in VecGeom on treatment of angles. 491 440 492 10-November-2016 E.Tcherniaev (geom-specif 441 10-November-2016 E.Tcherniaev (geom-specific-V10-02-22) 493 - Added caching of corners and implementation 442 - Added caching of corners and implementation of GetCorner() in G4UPolycone 494 in order to assure correct translation. 443 in order to assure correct translation. 495 - Withdrawn changes in G4UPolyhedra introduced 444 - Withdrawn changes in G4UPolyhedra introduced in tag geom-specific-V10-02-16 496 until understood proper conversion from VecG 445 until understood proper conversion from VecGeom. 497 446 498 7-November-2016 E.Tcherniaev (geom-specifi 447 7-November-2016 E.Tcherniaev (geom-specific-V10-02-21) 499 - Correction in G4EllipticalCone::DistanceToOu 448 - Correction in G4EllipticalCone::DistanceToOut(p) to make it more accurate. 500 - Added optional debug flag G4BBOX_EXTENT in G 449 - Added optional debug flag G4BBOX_EXTENT in GNUMake build to compare 501 extent calculation by simply using bounding- 450 extent calculation by simply using bounding-box. 502 451 503 3-November-2016 G.Cosmo (geom-specifi 452 3-November-2016 G.Cosmo (geom-specific-V10-02-20, 19) 504 - Fix in G4PolyPhiFace for potential unitialis 453 - Fix in G4PolyPhiFace for potential unitialised data in Inside(). 505 454 506 31-October-2016 E.Tcherniaev (geom-specifi 455 31-October-2016 E.Tcherniaev (geom-specific-V10-02-18) 507 - Re-implemented CalculateExtent() to make use 456 - Re-implemented CalculateExtent() to make use of G4BoundingEnvelope and 508 removed no-longer used method CreateRotatedV 457 removed no-longer used method CreateRotatedVertices() in G4Polyhedra, 509 G4EllipticalCone, G4Polycone, G4Paraboloid, 458 G4EllipticalCone, G4Polycone, G4Paraboloid, G4ExtrudedSolid, G4Hype, 510 G4GenericPolycone, G4TessellatedSolid, G4Twi 459 G4GenericPolycone, G4TessellatedSolid, G4TwistedTubs and related USolids 511 wrappers. 460 wrappers. 512 - Use G4RandFlat instead of RandFlat. 461 - Use G4RandFlat instead of RandFlat. 513 462 514 21-October-2016 G.Cosmo (geom-specifi 463 21-October-2016 G.Cosmo (geom-specific-V10-02-17) 515 - Moved initialisation of G4GeomSplitter threa 464 - Moved initialisation of G4GeomSplitter thread-local data to be inline 516 along with generic template type. 465 along with generic template type. 517 Fixing compilation/linking errors on clang-3 466 Fixing compilation/linking errors on clang-3.9 and XCode-8 on MacOS. 518 467 519 19-October-2016 E.Tcherniaev (geom-speci 468 19-October-2016 E.Tcherniaev (geom-specific-V10-02-16) 520 - Reimplemented CalculateExtent() in G4Polycon 469 - Reimplemented CalculateExtent() in G4Polycone, G4Polyhedra, G4GenericPolycone 521 and associated USolids wrappers, to make use 470 and associated USolids wrappers, to make use of G4BoundingEnvelope. 522 471 523 5-October-2016 E.Tcherniaev (geom-speci 472 5-October-2016 E.Tcherniaev (geom-specific-V10-02-15, 14) 524 - Reimplemented CalculateExtent() in G4Tet, G4 473 - Reimplemented CalculateExtent() in G4Tet, G4UTet, G4GenericTrap, 525 G4UGenericTrap, G4EllipticalTube and G4VTwis 474 G4UGenericTrap, G4EllipticalTube and G4VTwistedFaceted, to make use 526 of G4BoundingEnvelope; removed no-longer use 475 of G4BoundingEnvelope; removed no-longer used method CreateRotatedVertices(). 527 476 528 20-September-2016 G.Cosmo (geom-speci 477 20-September-2016 G.Cosmo (geom-specific-V10-02-13) 529 - Moved accessors/modifiers for splitter data 478 - Moved accessors/modifiers for splitter data to non-inline in 530 G4PolyhedraSide and G4PolyconeSide. 479 G4PolyhedraSide and G4PolyconeSide. 531 Explicitly initialise G4GeomSplitter data in 480 Explicitly initialise G4GeomSplitter data in G4SolidsWorkspace 532 translation unit. 481 translation unit. 533 Fixing compilation/linking errors on clang-3 482 Fixing compilation/linking errors on clang-3.9 and XCode-8 on MacOS. 534 483 535 06-July-2016 E.Tcherniaev (geom-speci 484 06-July-2016 E.Tcherniaev (geom-specific-V10-02-12) 536 - Fixed monir typo in function Create() for G4 485 - Fixed monir typo in function Create() for G4Polycone, G4Polyhedra and 537 G4GenericPolycone. 486 G4GenericPolycone. 538 Fixed minor typos in G4GenericTrap::SurfaceN 487 Fixed minor typos in G4GenericTrap::SurfaceNormal() and 539 G4VTwistSurface::CurrentStatus::ResetfDone() 488 G4VTwistSurface::CurrentStatus::ResetfDone(). 540 Issues detected by PVS-Studio static code an 489 Issues detected by PVS-Studio static code analyzer. 541 Addressing problem report #1876. 490 Addressing problem report #1876. 542 491 543 24-May-2016 G.Cosmo (geom-speci 492 24-May-2016 G.Cosmo (geom-specific-V10-02-11) 544 - Correction in G4UExtrudedSolid for definitio 493 - Correction in G4UExtrudedSolid for definition of CreatePolyhedron(). 545 494 546 20-May-2016 G.Cosmo (geom-speci 495 20-May-2016 G.Cosmo (geom-specific-V10-02-10) 547 - Moved accessors and modifiers in USolids wra 496 - Moved accessors and modifiers in USolids wrappers to be not inlined. 548 Required modification in order to allow corr 497 Required modification in order to allow correct dispatching to VecGeom 549 types. 498 types. 550 499 551 15-Apr-2016 G.Cosmo (geom-speci 500 15-Apr-2016 G.Cosmo (geom-specific-V10-02-09) 552 - Added flag in USolids wrappers for partial u 501 - Added flag in USolids wrappers for partial use of USolids/VecGeom types. 553 502 554 31-Mar-2016 G.Cosmo (geom-speci 503 31-Mar-2016 G.Cosmo (geom-specific-V10-02-08, 07) 555 - Added overloaded CreatePolyhedron() method t 504 - Added overloaded CreatePolyhedron() method to USolids wrappers. 556 It is now possible to visualize supported Ve 505 It is now possible to visualize supported VecGeom shapes. 557 - Added implementation of CreatePolyhedron() i 506 - Added implementation of CreatePolyhedron() in UExtrudedSolid wrapper. 558 507 559 10-Mar-2016 G.Cosmo (geom-speci 508 10-Mar-2016 G.Cosmo (geom-specific-V10-02-06) 560 - Added overloaded GetEntityType() method to U 509 - Added overloaded GetEntityType() method to USolids wrappers. 561 510 562 07-Mar-2016 E.Tcherniaev (geom-speci 511 07-Mar-2016 E.Tcherniaev (geom-specific-V10-02-05) 563 - Fix in G4IntersectingCone for smaller precis 512 - Fix in G4IntersectingCone for smaller precision constant in LineHitsCone1() 564 and LineHitsCone2(). Fixes issue observed in 513 and LineHitsCone2(). Fixes issue observed in G4GenericPolycone. 565 Addressing problem report #1794. 514 Addressing problem report #1794. 566 515 567 03-Mar-2016 G.Cosmo (geom-speci 516 03-Mar-2016 G.Cosmo (geom-specific-V10-02-04) 568 - Fixed compilation warnings for potential uni 517 - Fixed compilation warnings for potential uninitialised values in 569 G4ExtrudedSolid::CheckPolygon() function int 518 G4ExtrudedSolid::CheckPolygon() function introduced in previous tag. 570 519 571 03-Mar-2016 E.Tcherniaev (geom-speci 520 03-Mar-2016 E.Tcherniaev (geom-specific-V10-02-03) 572 - Added 'const' qualifier for methods in G4Ext 521 - Added 'const' qualifier for methods in G4ExtrudedSolid. 573 Added CheckPolygon() to remove collinear and 522 Added CheckPolygon() to remove collinear and coincident points from polygons. 574 - G4QuadrangularFacet: added exhaustive tests 523 - G4QuadrangularFacet: added exhaustive tests in constructor to catch potential 575 problems with a quadrangular facet: collinea 524 problems with a quadrangular facet: collinear vertices, non planar surface, 576 degenerate, concave or self intersecting qua 525 degenerate, concave or self intersecting quadrilateral. 577 - G4TriangularFacet: Improved test in construc 526 - G4TriangularFacet: Improved test in constructor to detect degenerate (too 578 small or too narrow) triangles. 527 small or too narrow) triangles. 579 528 580 25-Feb-2016 E.Tcherniaev (geom-speci 529 25-Feb-2016 E.Tcherniaev (geom-specific-V10-02-02) 581 - Correction in G4ExtrudedSolid::AddGeneralPol 530 - Correction in G4ExtrudedSolid::AddGeneralPolygonFacets() for precision 582 treatment in construction of tessels to avoi 531 treatment in construction of tessels to avoid cases of collinear points 583 and consequent degenerating triangles. 532 and consequent degenerating triangles. 584 Address problem report #1777. 533 Address problem report #1777. 585 - Use pre-computed kCarToleranceHalf constant 534 - Use pre-computed kCarToleranceHalf constant in G4ExtrudedSolid, now 586 protected in G4TessellatedSolid. 535 protected in G4TessellatedSolid. 587 - Improved algorithms for computation of area 536 - Improved algorithms for computation of area in G4TriangularFacet and 588 G4QuadrangularFacet. Added post-const qualif 537 G4QuadrangularFacet. Added post-const qualifier to GetArea(). 589 538 590 16-Feb-2016 G.Cosmo (geom-speci 539 16-Feb-2016 G.Cosmo (geom-specific-V10-02-01) 591 - Revised implementation for GetSurfaceArea() 540 - Revised implementation for GetSurfaceArea() and GetCubicVolume() in 592 G4GenericTrap (E.Tcherniaev). 541 G4GenericTrap (E.Tcherniaev). 593 - Protected debug warning in G4GenericTrap::Su 542 - Protected debug warning in G4GenericTrap::SurfaceNormal() within G4SPECSDEBUG. 594 543 595 02-Feb-2016 E.Tcherniaev (geom-speci 544 02-Feb-2016 E.Tcherniaev (geom-specific-V10-02-00) 596 - Fix in G4GenericTrap for compuation of exten 545 - Fix in G4GenericTrap for compuation of extent. 597 Addressing problem report #1809. 546 Addressing problem report #1809. 598 - Use dot() in formula for computation of GetC 547 - Use dot() in formula for computation of GetCubicVolume() in 599 G4TessellatedSolid. 548 G4TessellatedSolid. 600 549 601 18-Nov-2015 G.Cosmo (geom-speci 550 18-Nov-2015 G.Cosmo (geom-specific-V10-01-15) 602 - Added specialised implementation for GetCubi 551 - Added specialised implementation for GetCubicVolume() in 603 G4TessellatedSolid (J.Allison). 552 G4TessellatedSolid (J.Allison). 604 553 605 29-Oct-2015 G.Cosmo (geom-speci 554 29-Oct-2015 G.Cosmo (geom-specific-V10-01-14) 606 - Added debug printouts within G4SPECSDEBUG in 555 - Added debug printouts within G4SPECSDEBUG in G4TessellatedSolid for 607 DistanceToIn/Out(p,v) to identify potential 556 DistanceToIn/Out(p,v) to identify potential wrong responses. 608 557 609 26-Oct-2015 G.Cosmo (geom-speci 558 26-Oct-2015 G.Cosmo (geom-specific-V10-01-13) 610 - Removed redundant condition in G4Polyhedra a 559 - Removed redundant condition in G4Polyhedra and G4polycone 611 SetOriginalParameters() method. 560 SetOriginalParameters() method. 612 561 613 23-Oct-2015 G.Cosmo (geom-speci 562 23-Oct-2015 G.Cosmo (geom-specific-V10-01-12) 614 - G4PolyhedraSide: moved internal struct defin 563 - G4PolyhedraSide: moved internal struct definitions to public section 615 to overcome deficiencies in object-persisten 564 to overcome deficiencies in object-persistency class parsing. 616 565 617 07-Oct-2015 G.Cosmo (geom-speci 566 07-Oct-2015 G.Cosmo (geom-specific-V10-01-11) 618 - Protected compilation of USolid wrappers wit 567 - Protected compilation of USolid wrappers with G4GEOM_USE_USOLIDS flag. 619 568 620 01-Sep-2015 G.Cosmo (geom-speci 569 01-Sep-2015 G.Cosmo (geom-specific-V10-01-10) 621 - Corrected conditional compilation flag in G4 570 - Corrected conditional compilation flag in G4UParaboloid.cc. 622 571 623 31-Aug-2015 G.Cosmo (geom-speci 572 31-Aug-2015 G.Cosmo (geom-specific-V10-01-09) 624 - Added USolids/VecGeom wrapper for G4Parabolo 573 - Added USolids/VecGeom wrapper for G4Paraboloid (G.Lima/FNAL). 625 Activated only for external USolids/VecGeom 574 Activated only for external USolids/VecGeom installation. 626 575 627 13-Aug-2015 G.Cosmo (geom-speci 576 13-Aug-2015 G.Cosmo (geom-specific-V10-01-08) 628 - Checked for potential never-ending loops. 577 - Checked for potential never-ending loops. 629 No issues found, only added annotations. 578 No issues found, only added annotations. 630 579 631 05-Aug-2015 G.Cosmo (geom-speci 580 05-Aug-2015 G.Cosmo (geom-specific-V10-01-07) 632 - Minor code cleanup in G4SurfaceVoxelizer. 581 - Minor code cleanup in G4SurfaceVoxelizer. 633 582 634 03-Mar-2015 G.Cosmo (geom-speci 583 03-Mar-2015 G.Cosmo (geom-specific-V10-01-06) 635 - Use accessors x(), y() and z() from UVector3 584 - Use accessors x(), y() and z() from UVector3, instead of directly accessing 636 its data-members. Co-work with tag "geom-uso 585 its data-members. Co-work with tag "geom-usolids-V10-01-09". 637 586 638 23-Feb-2015 T.Nikitina (geom-speci 587 23-Feb-2015 T.Nikitina (geom-specific-V10-01-05) 639 - Fix in SetOriginalParameters() for G4Polycon 588 - Fix in SetOriginalParameters() for G4Polycone and G4Polyhedra, in case 640 of presence of 'rings' structures. Addressin 589 of presence of 'rings' structures. Addressing problem report #1705. 641 590 642 26-Jan-2015 G.Cosmo (geom-speci 591 26-Jan-2015 G.Cosmo (geom-specific-V10-01-04) 643 - Renamed DistanceAwayForInside() to DistanceA 592 - Renamed DistanceAwayForInside() to DistanceAway() and use polymorphism. 644 593 645 26-Jan-2015 T.Nikitina (geom-speci 594 26-Jan-2015 T.Nikitina (geom-specific-V10-01-03, 02) 646 - Added special method for Inside 'DistanceAwa 595 - Added special method for Inside 'DistanceAwayForInside()' in order to fix 647 precision problem of calculation of Distance 596 precision problem of calculation of DistanceToSide() in G4PolyconeSide. 648 597 649 21-Jan-2015 T.Nikitina (geom-speci 598 21-Jan-2015 T.Nikitina (geom-specific-V10-01-01) 650 - Fixed triangularisation method AddGeneralPOl 599 - Fixed triangularisation method AddGeneralPOlygoneFacets() in 651 G4ExtrudedSolid by avoiding flat triangles. 600 G4ExtrudedSolid by avoiding flat triangles. 652 - Added warning message to G4TriangularFacet c 601 - Added warning message to G4TriangularFacet constructor if Area is 0; 653 i.e., case of flat triangle. 602 i.e., case of flat triangle. 654 - Addressing problem report #1703. 603 - Addressing problem report #1703. 655 604 656 12-Dec-2014 G.Cosmo (geom-speci 605 12-Dec-2014 G.Cosmo (geom-specific-V10-01-00) 657 - Use canonical form for operator=() in G4Poly 606 - Use canonical form for operator=() in G4PolyconeHistorical and 658 G4PolyhedraHistorical. 607 G4PolyhedraHistorical. 659 608 660 17-Sep-2014 G.Cosmo (geom-speci 609 17-Sep-2014 G.Cosmo (geom-specific-V10-00-11) 661 - Added wrappers for UExtrudedSolid and UGener 610 - Added wrappers for UExtrudedSolid and UGenericTrap; adapted switches to 662 original G4 types accordingly. Requires tag 611 original G4 types accordingly. Requires tag "geom-usolids-V10-00-16". 663 612 664 01-Sep-2014 G.Cosmo (geom-speci 613 01-Sep-2014 G.Cosmo (geom-specific-V10-00-10) 665 - Fixed use of polyhedron pointer, to avoid ra 614 - Fixed use of polyhedron pointer, to avoid race condition in MT 666 when parameterised volumes are visualised. 615 when parameterised volumes are visualised. 667 616 668 22-May-2014 G.Cosmo (geom-speci 617 22-May-2014 G.Cosmo (geom-specific-V10-00-09) 669 - Added protection in generic constructor of G 618 - Added protection in generic constructor of G4Polyhedra for the case when 670 improper number of sides is given as input. 619 improper number of sides is given as input. 671 620 672 10-Apr-2014 G.Cosmo (geom-speci 621 10-Apr-2014 G.Cosmo (geom-specific-V10-00-08) 673 - Get rid of deprecated 'register' storage cla 622 - Get rid of deprecated 'register' storage class specifier in source files. 674 623 675 31-Mar-2014 G.Cosmo (geom-speci 624 31-Mar-2014 G.Cosmo (geom-specific-V10-00-07) 676 - Fixed signature of assignment operator to G4 625 - Fixed signature of assignment operator to G4VCSGfaceted. 677 626 678 31-Mar-2014 G.Cosmo (geom-speci 627 31-Mar-2014 G.Cosmo (geom-specific-V10-00-06) 679 - Fixed signature of assignment operator to G4 628 - Fixed signature of assignment operator to G4Polycone, G4Polyhedra and 680 and G4GenericPolycone. 629 and G4GenericPolycone. 681 630 682 05-Mar-2014 G.Cosmo (geom-speci 631 05-Mar-2014 G.Cosmo (geom-specific-V10-00-05) 683 - Fixed proper handling of polyhedron pointer 632 - Fixed proper handling of polyhedron pointer in solids, to avoid memory 684 leak for visualization of parameterised volu 633 leak for visualization of parameterised volumes. 685 634 686 12-Feb-2014 G.Cosmo (geom-speci 635 12-Feb-2014 G.Cosmo (geom-specific-V10-00-04) 687 - Simply reset polyhedron pointer to zero for 636 - Simply reset polyhedron pointer to zero for modifiers of G4U* wrappers 688 in parameterisation. Resolves crash in MT vi 637 in parameterisation. Resolves crash in MT visualization when using USolids. 689 638 690 12-Feb-2014 G.Cosmo (geom-speci 639 12-Feb-2014 G.Cosmo (geom-specific-V10-00-03 [and -02]) 691 - Added correct cloning mechanism in G4U* wrap 640 - Added correct cloning mechanism in G4U* wrappers. 692 Addressing problem report #1553. 641 Addressing problem report #1553. 693 642 694 18-Dec-2013 T.Nikitina (geom-speci 643 18-Dec-2013 T.Nikitina (geom-specific-V10-00-01) 695 - Fix in G4GenericTrap::InsidePolygone() to ch 644 - Fix in G4GenericTrap::InsidePolygone() to check if p lies between the two 696 extremes of the segment. Addressing problem 645 extremes of the segment. Addressing problem report #1541. 697 646 698 17-Dec-2013 G.Cosmo (geom-speci 647 17-Dec-2013 G.Cosmo (geom-specific-V10-00-00) 699 - Corrected left-over debug printout in G4Poly 648 - Corrected left-over debug printout in G4Polycone::SetOriginalParameters(). 700 649 701 04-Dec-2013 G.Cosmo (geom-speci 650 04-Dec-2013 G.Cosmo (geom-specific-V09-06-36) 702 - Corrected left-over debug printout in G4Poly 651 - Corrected left-over debug printout in G4Polyhedra::SetOriginalParameters(). 703 652 704 22-Nov-2013 G.Cosmo (geom-speci 653 22-Nov-2013 G.Cosmo (geom-specific-V09-06-35) 705 - Correction to USolids wrappers for proper se 654 - Correction to USolids wrappers for proper setting of name to base class. 706 655 707 19-Nov-2013 J.Apostolakis (geom-speci 656 19-Nov-2013 J.Apostolakis (geom-specific-V09-06-34) 708 - Fix for issue identified by Coverity: fixed 657 - Fix for issue identified by Coverity: fixed implementation of 709 G4SolidsWorkspacePool singleton. 658 G4SolidsWorkspacePool singleton. 710 659 711 20-Nov-2013 T.Mikitina (geom-speci 660 20-Nov-2013 T.Mikitina (geom-specific-V09-06-33) 712 - Fixed Coverity defects to USolids wrappers. 661 - Fixed Coverity defects to USolids wrappers. 713 662 714 14-Nov-2013 G.Cosmo (geom-speci 663 14-Nov-2013 G.Cosmo (geom-specific-V09-06-32, 31) 715 - Enabled use of Reset() in G4UPolycone. 664 - Enabled use of Reset() in G4UPolycone. 716 - Corrections to G4UPolycone and G4UPolyhedra 665 - Corrections to G4UPolycone and G4UPolyhedra to allow for visualization 717 of parameterisations on these solids. 666 of parameterisations on these solids. 718 667 719 13-Nov-2013 G.Cosmo (geom-speci 668 13-Nov-2013 G.Cosmo (geom-specific-V09-06-30) 720 - Correction to G4UTet and G4UGenericPolycone 669 - Correction to G4UTet and G4UGenericPolycone to explicitly include 721 symbols re-definitions from G4Tet and G4Gene 670 symbols re-definitions from G4Tet and G4GenericPolycone respectively. 722 671 723 12-Nov-2013 G.Cosmo (geom-speci 672 12-Nov-2013 G.Cosmo (geom-specific-V09-06-29) 724 - Added dummy method G4UPolycone::Reset(). 673 - Added dummy method G4UPolycone::Reset(). 725 NOTE: Required related implementation (curre 674 NOTE: Required related implementation (currently missing!) in UPolycone. 726 675 727 12-Nov-2013 G.Cosmo (geom-speci 676 12-Nov-2013 G.Cosmo (geom-specific-V09-06-28) 728 - Correction to USolids switch mechanism for G 677 - Correction to USolids switch mechanism for G4Polycone. 729 678 730 08-Nov-2013 J.Apostolakis (geom-speci 679 08-Nov-2013 J.Apostolakis (geom-specific-V09-06-27) 731 - G4SolidsWorkspace: cleanup of verbosity. 680 - G4SolidsWorkspace: cleanup of verbosity. 732 Reduced verbosity by making it optional. 681 Reduced verbosity by making it optional. 733 Added Set/Get Verbose methods to toggle and 682 Added Set/Get Verbose methods to toggle and view it. 734 Added parameter to constructor for verbosity 683 Added parameter to constructor for verbosity (default=off). 735 684 736 07-Nov-2013 G.Cosmo (geom-specific-V09-06-26) 685 07-Nov-2013 G.Cosmo (geom-specific-V09-06-26) 737 - Moved wrappers from usolids module. 686 - Moved wrappers from usolids module. 738 Fixed internal dispatcher method for paramet 687 Fixed internal dispatcher method for parameterisation in all wrappers. 739 - Added switching mechanism for G4GenericPolyc 688 - Added switching mechanism for G4GenericPolycone, G4Polycone, G4Polyhedra 740 and G4Tet. 689 and G4Tet. 741 690 742 06-Nov-2013 G.Cosmo (geom-specific-V09-06-25) 691 06-Nov-2013 G.Cosmo (geom-specific-V09-06-25) 743 - Added switch mechanism for USolids (G4Generi 692 - Added switch mechanism for USolids (G4GenericPolycone, G4Polycone, 744 G4Polyhedra, G4Tet). Renamed related G4 type 693 G4Polyhedra, G4Tet). Renamed related G4 types to 'G4O'. 745 - Moved wrappers from USolids module. 694 - Moved wrappers from USolids module. 746 695 747 01-Nov-2013 G.Cosmo (geom-specific-V09-06-24) 696 01-Nov-2013 G.Cosmo (geom-specific-V09-06-24) 748 - Corrected CMake script. 697 - Corrected CMake script. 749 698 750 31-Oct-2013 G.Cosmo (geom-specific-V09-06-23) 699 31-Oct-2013 G.Cosmo (geom-specific-V09-06-23) 751 - Fix for in G4Polyhedra::SetOriginalParameter 700 - Fix for in G4Polyhedra::SetOriginalParameters(). (T.Nikitina) 752 - Moved G4PolyconeHistorical and G4PolyhedraHi 701 - Moved G4PolyconeHistorical and G4PolyhedraHistorical in separate 753 translation units. 702 translation units. 754 703 755 29-Oct-2013 T.Nikitina (geom-specific-V09-06- 704 29-Oct-2013 T.Nikitina (geom-specific-V09-06-22) 756 - Split G4Polycone for polycones with decreasi 705 - Split G4Polycone for polycones with decreasing Z-sections. 757 Introduced new class G4GenericPolycone. 706 Introduced new class G4GenericPolycone. 758 - Fixed conversion of generic construct for G4 707 - Fixed conversion of generic construct for G4Polyhedra. 759 708 760 17-Oct-2013 J.Apostolakis/A.Dotti (geom-speci 709 17-Oct-2013 J.Apostolakis/A.Dotti (geom-specific-V09-06-21) 761 - Cleanup of code for workspace. 710 - Cleanup of code for workspace. 762 711 763 16-Oct-2013 J.Apostolakis/A.Dotti (geom-speci 712 16-Oct-2013 J.Apostolakis/A.Dotti (geom-specific-V09-06-20) 764 - Created G4SolidsWorkspacePool class, to mana 713 - Created G4SolidsWorkspacePool class, to manage Workspaces 765 Fixed Singleton G4SolidsWorkspacePool for th 714 Fixed Singleton G4SolidsWorkspacePool for thread safe creation of object. 766 715 767 04-Oct-2013 J.Apostolakis (geom-specific-V09- 716 04-Oct-2013 J.Apostolakis (geom-specific-V09-06-19) 768 - Retagged. 717 - Retagged. 769 NOTE: requires tag "geommng-V09-06-12" and c 718 NOTE: requires tag "geommng-V09-06-12" and co-works with "geomvol-V09-06-13". 770 719 771 04-Oct-2013 J.Apostolakis (geom-specific-V09- 720 04-Oct-2013 J.Apostolakis (geom-specific-V09-06-18) 772 - Created G4SolidsWorkspace class, to create, 721 - Created G4SolidsWorkspace class, to create, initialize and destroy 773 per-thread state of PolyCone Sides and PolyH 722 per-thread state of PolyCone Sides and PolyHedra Sides. 774 723 775 27-Aug-2013 G.Cosmo (geom-specific-V09-06-17) 724 27-Aug-2013 G.Cosmo (geom-specific-V09-06-17) 776 - Enabled G4Ellipsoid for parameterisation. 725 - Enabled G4Ellipsoid for parameterisation. 777 726 778 14-Aug-2013 G.Cosmo (geom-specific-V09-06-16) 727 14-Aug-2013 G.Cosmo (geom-specific-V09-06-16) 779 - Move function-scoped 'static const' values f 728 - Move function-scoped 'static const' values for half-tolerances to private 780 data members of classes, to overcome false-p 729 data members of classes, to overcome false-positive race-conditions defects 781 reported by Valgrind in MT mode. 730 reported by Valgrind in MT mode. 782 - Fix in G4TessellatedSolid::DistanceToIn(p,v) 731 - Fix in G4TessellatedSolid::DistanceToIn(p,v) for specific cases where points 783 are located near surface (T.Nikitina). 732 are located near surface (T.Nikitina). 784 733 785 16-Jul-2013 M.Gayer (geom-specific-V09-06-15) 734 16-Jul-2013 M.Gayer (geom-specific-V09-06-15) 786 - Fix in G4SurfaceVoxelizer affecting tessella 735 - Fix in G4SurfaceVoxelizer affecting tessellated-solid (and extruded-solid) 787 for wrong computation of DistanceToIn(p,v) f 736 for wrong computation of DistanceToIn(p,v) for points outside, when 788 optimisation is active. 737 optimisation is active. 789 738 790 11-Jul-2013 G.Cosmo (geom-specific-V09-06-14) 739 11-Jul-2013 G.Cosmo (geom-specific-V09-06-14) 791 - Fixed compilation warning in G4Polycone on M 740 - Fixed compilation warning in G4Polycone on MacOS/clang. 792 741 793 09-Jul-2013 T.Nikitina (geom-specific-V09-06- 742 09-Jul-2013 T.Nikitina (geom-specific-V09-06-13) 794 - Extended method SetOriginalParameters() in G 743 - Extended method SetOriginalParameters() in G4Polycone in order to handle 795 all possible cases of conversion of generic 744 all possible cases of conversion of generic polycone to polycone with 796 (Rmin,Rmaz,Z) parameters. 745 (Rmin,Rmaz,Z) parameters. 797 Addressing problem report #1462. 746 Addressing problem report #1462. 798 747 799 03-Jun-2013 G.Cosmo (geom-specific-V09-06-12) 748 03-Jun-2013 G.Cosmo (geom-specific-V09-06-12) 800 - Fixed minor Coverity defect in G4PolyhedraSi 749 - Fixed minor Coverity defect in G4PolyhedraSide and G4PolyconeSide. 801 750 802 22-Apr-2013 J.Apostolakis (geom-specific-V09- 751 22-Apr-2013 J.Apostolakis (geom-specific-V09-06-11) 803 - Revised G4ExtrudedSolid::IsSameLine to use t 752 - Revised G4ExtrudedSolid::IsSameLine to use the perpendicular 804 distance to a line when deciding - not the y 753 distance to a line when deciding - not the y-intercept difference. 805 ( Issue responsible for a problem in Subtrac 754 ( Issue responsible for a problem in Subtraction Solid in Atlas. 806 Tatiana & Ivana contributed to debugging. 755 Tatiana & Ivana contributed to debugging. ) 807 - Changed GNUmakefile in test directory to wor 756 - Changed GNUmakefile in test directory to work with Cmake and granular 808 builds. 757 builds. 809 758 810 16-Apr-2013 T.Nikitina (geom-specific-V09-06- 759 16-Apr-2013 T.Nikitina (geom-specific-V09-06-10) 811 - Fix in calculation of normal in G4Tet::Dista 760 - Fix in calculation of normal in G4Tet::DistanceToOut(p,v,..) and 812 SurfaceNormal(p). 761 SurfaceNormal(p). 813 - Fix in G4Polycone::GetPointOnCone() for case 762 - Fix in G4Polycone::GetPointOnCone() for cases of shape with decreasing Z. 814 Fixes cases of false report for overlaps det 763 Fixes cases of false report for overlaps detection. Problem report #1462. 815 Added check with exception in constructor fo 764 Added check with exception in constructor for polycone with rInner > rOuter 816 for the same Z. 765 for the same Z. 817 766 818 18-Mar-2013 G.Cosmo (geom-specific-V09-06-09) 767 18-Mar-2013 G.Cosmo (geom-specific-V09-06-09) 819 - G4TessellatedSolid: fixed problem with navig 768 - G4TessellatedSolid: fixed problem with navigation in tessellated solids 820 with concave surfaces. Addresses problem rep 769 with concave surfaces. Addresses problem report #1456. 821 - More cleanup from MT changes in G4VTwistSurf 770 - More cleanup from MT changes in G4VTwistSurface and G4Tet. 822 771 823 12-Mar-2013 G.Cosmo (geom-specific-V09-06-08) 772 12-Mar-2013 G.Cosmo (geom-specific-V09-06-08) 824 - Added public accessors for MT data to G4Poly 773 - Added public accessors for MT data to G4PolyconeSide and G4PolyhedraSide. 825 774 826 11-Mar-2013 G.Cosmo (geom-specific-V09-06-07) 775 11-Mar-2013 G.Cosmo (geom-specific-V09-06-07) 827 - Redefined G4DLL_API to G4GEOM_DLL to avoid c 776 - Redefined G4DLL_API to G4GEOM_DLL to avoid cases of macro redefinition. 828 777 829 08-Mar-2013 G.Cosmo (geom-specific-V09-06-06) 778 08-Mar-2013 G.Cosmo (geom-specific-V09-06-06) 830 - Renamed G4MT macros to safer ID in G4Polycon 779 - Renamed G4MT macros to safer ID in G4PolyconeSide and G4PolyhedraSide. 831 780 832 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05) 781 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05) 833 - Adopt G4GeomSplitter instead of G4MTTransito 782 - Adopt G4GeomSplitter instead of G4MTTransitory in G4PolyconeSide and 834 G4PolyhedraSide. Fixed import/export of stat 783 G4PolyhedraSide. Fixed import/export of static symbols for WIN32 DLLs build. 835 784 836 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04) 785 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04) 837 - Cleanup changes for multi-threading in G4Tet 786 - Cleanup changes for multi-threading in G4Tet, G4VTwistSurface, 838 G4PolyconeSide and G4PolyhedraSide. 787 G4PolyconeSide and G4PolyhedraSide. 839 - Removed unused private data member in G4Twis 788 - Removed unused private data member in G4TwistTrapParallelSide. 840 789 841 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05) 790 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05) 842 - Adopt G4GeomSplitter instead of G4MTTransito 791 - Adopt G4GeomSplitter instead of G4MTTransitory in G4PolyconeSide and 843 G4PolyhedraSide. Fixed import/export of stat 792 G4PolyhedraSide. Fixed import/export of static symbols for WIN32 DLLs build. 844 793 845 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04) 794 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04) 846 - Cleanup changes for multi-threading in G4Tet 795 - Cleanup changes for multi-threading in G4Tet, G4VTwistSurface, 847 G4PolyconeSide and G4PolyhedraSide. 796 G4PolyconeSide and G4PolyhedraSide. 848 - Removed unused private data member in G4Twis 797 - Removed unused private data member in G4TwistTrapParallelSide. 849 798 850 11-Jan-2013 G.Cosmo (geom-specific-V09-06-03) 799 11-Jan-2013 G.Cosmo (geom-specific-V09-06-03) 851 - Fixed condition in G4VTwistSurface::GetBound 800 - Fixed condition in G4VTwistSurface::GetBoundaryLimit() for logical error. 852 Addressing problem report #1420. 801 Addressing problem report #1420. 853 802 854 20-Dec-2012 M.Gayer (geom-specific-V09-06-02) 803 20-Dec-2012 M.Gayer (geom-specific-V09-06-02) 855 - Fixed cases of hang-ups in G4ExtrudedSolid o 804 - Fixed cases of hang-ups in G4ExtrudedSolid on 32-bits platforms, due to 856 G4TessellatedSolid and G4SurfVoxelizer, caus 805 G4TessellatedSolid and G4SurfVoxelizer, caused by accessing bitmask arrays 857 with negative indexes. The problem was relat 806 with negative indexes. The problem was related to floating-point rounding, 858 which can be different even on same platform 807 which can be different even on same platform with debug/release version. 859 Assure same number of computed voxels on 32- 808 Assure same number of computed voxels on 32-bit/64-bit platforms. 860 Fixed error in SetVertexIndex() method, whic 809 Fixed error in SetVertexIndex() method, which might cause problems on 861 certain configurations even for 64-bit syste 810 certain configurations even for 64-bit systems. Fixed minor memory leaks. 862 - Code cleanup for use of G4endl and tabs... 811 - Code cleanup for use of G4endl and tabs... 863 812 864 14-Dec-2012 G.Cosmo (geom-specific-V09-06-01) 813 14-Dec-2012 G.Cosmo (geom-specific-V09-06-01) 865 - Restored SVN id headers. 814 - Restored SVN id headers. 866 815 867 02-Dec-2012 J.Allison (geom-specific-V09-06-0 816 02-Dec-2012 J.Allison (geom-specific-V09-06-00) 868 - Removed NURBS. 817 - Removed NURBS. 869 818 870 29-Nov-2012 G.Cosmo (geom-specific-V09-05-24) 819 29-Nov-2012 G.Cosmo (geom-specific-V09-05-24) 871 - Remove inclusion of G4PhysicalConstants.hh f 820 - Remove inclusion of G4PhysicalConstants.hh from G4SurfaceVoxelizer.hh. 872 - Fixed unit test for compilation errors. 821 - Fixed unit test for compilation errors. 873 822 874 28-Nov-2012 G.Cosmo (geom-specific-V09-05-23) 823 28-Nov-2012 G.Cosmo (geom-specific-V09-05-23) 875 - Fixed more cases of inclusion of constants h 824 - Fixed more cases of inclusion of constants header. 876 825 877 23-Nov-2012 G.Cosmo (geom-specific-V09-05-22) 826 23-Nov-2012 G.Cosmo (geom-specific-V09-05-22) 878 - Added 'const' qualifiers to signature in G4V 827 - Added 'const' qualifiers to signature in G4VoxelComparator::operator() 879 for porting on AIX-xlC compiler. 828 for porting on AIX-xlC compiler. 880 829 881 14-Nov-2012 P.Mato (geom-specific-V09-05-21) 830 14-Nov-2012 P.Mato (geom-specific-V09-05-21) 882 - Added #undef NDEBUG in unit tests to ensure 831 - Added #undef NDEBUG in unit tests to ensure assert works also in 883 full optimised mode. 832 full optimised mode. 884 833 885 14-Nov-2012 P. Mato (geom-specific-V09-05-20) 834 14-Nov-2012 P. Mato (geom-specific-V09-05-20) 886 - Added #undef NDEBUG in unit tests to ensure 835 - Added #undef NDEBUG in unit tests to ensure that assert always works 887 836 888 13-Nov-2012 M.Gayer (geom-specific-V09-05-19) 837 13-Nov-2012 M.Gayer (geom-specific-V09-05-19) 889 - More fixes for out-of-bound array accesses i 838 - More fixes for out-of-bound array accesses in G4SurfaceVoxelizer. 890 839 891 12-Nov-2012 M.Gayer (geom-specific-V09-05-18) 840 12-Nov-2012 M.Gayer (geom-specific-V09-05-18) 892 - Fixed out-of-bound array access in BuildRedu 841 - Fixed out-of-bound array access in BuildReduceVoxels2(). 893 842 894 06-Nov-2012 G.Cosmo (geom-specific-V09-05-17) 843 06-Nov-2012 G.Cosmo (geom-specific-V09-05-17) 895 - Correction in sources.cmake script for missi 844 - Correction in sources.cmake script for missing .icc file. 896 845 897 06-Nov-2012 G.Cosmo (geom-specific-V09-05-16) 846 06-Nov-2012 G.Cosmo (geom-specific-V09-05-16) 898 - Fixed Coverity defects in new code (M.Gayer) 847 - Fixed Coverity defects in new code (M.Gayer). 899 - Minor fixes for porting on AIX. 848 - Minor fixes for porting on AIX. 900 849 901 01-Nov-2012 G.Cosmo (geom-specific-V09-05-15) 850 01-Nov-2012 G.Cosmo (geom-specific-V09-05-15) 902 - Fixed compilation of debug code under G4SPEC 851 - Fixed compilation of debug code under G4SPECSDEBUG. 903 852 904 01-Nov-2012 M.Gayer (geom-specific-V09-05-14) 853 01-Nov-2012 M.Gayer (geom-specific-V09-05-14) 905 - Corrected signature for voxels count methods 854 - Corrected signature for voxels count methods in G4SurfaceVoxelizer. 906 855 907 31-Oct-2012 M.Gayer (geom-specific-V09-05-13) 856 31-Oct-2012 M.Gayer (geom-specific-V09-05-13) 908 - Added set/get methods for voxels count in G4 857 - Added set/get methods for voxels count in G4SurfaceVoxelizer. 909 858 910 30-Oct-2012 M.Gayer (geom-specific-V09-05-12) 859 30-Oct-2012 M.Gayer (geom-specific-V09-05-12) 911 - Fixed indexing of vertices in facets for tes 860 - Fixed indexing of vertices in facets for tessellated-solid and some cleanup. 912 861 913 27-Oct-2012 G.Cosmo (geom-specific-V09-05-11) 862 27-Oct-2012 G.Cosmo (geom-specific-V09-05-11) 914 - Fixed initialization of data in G4SurfaceVox 863 - Fixed initialization of data in G4SurfaceVoxelizer (M.Gayer). 915 - Added post-const qualifier to G4VertextCompa 864 - Added post-const qualifier to G4VertextComparator::operator() in 916 G4TessellatedSolid. 865 G4TessellatedSolid. 917 - Fixed more compilation warnings on unused va 866 - Fixed more compilation warnings on unused variable. 918 867 919 26-Oct-2012 G.Cosmo (geom-specific-V09-05-10) 868 26-Oct-2012 G.Cosmo (geom-specific-V09-05-10) 920 - Corrected compilation problem on G4SurfBits 869 - Corrected compilation problem on G4SurfBits for use of fprint(). 921 - Polished comments in disclaimer in new updat 870 - Polished comments in disclaimer in new updated classes. 922 871 923 25-Oct-2012 G.Cosmo (geom-specific-V09-05-09) 872 25-Oct-2012 G.Cosmo (geom-specific-V09-05-09) 924 - Corrected compilation warnings on Linux and 873 - Corrected compilation warnings on Linux and fixed use of memset/memcpy. 925 874 926 25-Oct-2012 G.Cosmo (geom-specific-V09-05-08) 875 25-Oct-2012 G.Cosmo (geom-specific-V09-05-08) 927 - Correction to sources.cmake. 876 - Correction to sources.cmake. 928 877 929 19-Oct-2012 M.Gayer (geom-specific-V09-05-07) 878 19-Oct-2012 M.Gayer (geom-specific-V09-05-07) 930 - Complete rewrite of G4TessellatedSolid resul 879 - Complete rewrite of G4TessellatedSolid resulting in reduced memory 931 requirements by 50%, and factor of tens or m 880 requirements by 50%, and factor of tens or more speedup for number of facets 932 of the order of thousands, thanks to ad-hoc 881 of the order of thousands, thanks to ad-hoc voxelization of the surface. 933 Factor of thousands speedup when number of f 882 Factor of thousands speedup when number of facets of the order of hundreds 934 thousand. New classes introduced, G4SurfBits 883 thousand. New classes introduced, G4SurfBits and G4SurfaceVoxelizer. 935 884 936 12-Jun-2012 G.Cosmo (geom-specific-V09-05-06) 885 12-Jun-2012 G.Cosmo (geom-specific-V09-05-06) 937 - Explicitly use inclusion of headers for syst 886 - Explicitly use inclusion of headers for system of units and physical 938 constants, in plan to remove implicit inclus 887 constants, in plan to remove implicit inclusion from globals.hh. 939 888 940 14-May-2012 G.Cosmo (geom-specific-V09-05-05) 889 14-May-2012 G.Cosmo (geom-specific-V09-05-05) 941 - Fixed spurious cases of hidden variable visi 890 - Fixed spurious cases of hidden variable visibility, detected with 942 '-Wshadow' compilation option on gcc compile 891 '-Wshadow' compilation option on gcc compiler. 943 892 944 06-Apr-2012 M.Kelsey (geom-specific-V09-05-04 893 06-Apr-2012 M.Kelsey (geom-specific-V09-05-04) 945 - Modified GetPointOnSurface() to throw sqrt(r 894 - Modified GetPointOnSurface() to throw sqrt(r) uniformly for disk surfaces, 946 in G4Paraboloid, G4Polycone and G4TwistedTub 895 in G4Paraboloid, G4Polycone and G4TwistedTubs. 947 896 948 13-Dec-2011 G.Cosmo (geom-specific-V09-05-03, 897 13-Dec-2011 G.Cosmo (geom-specific-V09-05-03, 02, 01) 949 - Fixed trivial Coverity defects in G4TwistedT 898 - Fixed trivial Coverity defects in G4TwistedTubs and G4VTwisteFaceted for 950 missing protection against self-assignment. 899 missing protection against self-assignment. 951 900 952 09-Dec-2011 T.Nikitina (geom-specific-V09-05- 901 09-Dec-2011 T.Nikitina (geom-specific-V09-05-00) 953 - Fix in G4EllipticalCone in DistanceToIn(p,v) 902 - Fix in G4EllipticalCone in DistanceToIn(p,v) to exclude imaginary solution 954 (virtual cone) when distance is calculated. 903 (virtual cone) when distance is calculated. 955 904 956 10-Nov-2011 G.Cosmo (geom-specific-V09-04-09) 905 10-Nov-2011 G.Cosmo (geom-specific-V09-04-09) 957 - Fixed trivial Coverity defects on assignment 906 - Fixed trivial Coverity defects on assignment operators... 958 907 959 25-Oct-2011 G.Cosmo (geom-specific-V09-04-08) 908 25-Oct-2011 G.Cosmo (geom-specific-V09-04-08) 960 - Fixed logic in G4VTwistSurface::GetEdgeVisib 909 - Fixed logic in G4VTwistSurface::GetEdgeVisibility() in treatment of corners. 961 910 962 16-Sep-2011 G.Cosmo (geom-specific-V09-04-07) 911 16-Sep-2011 G.Cosmo (geom-specific-V09-04-07) 963 - Fix compilation error in code within G4SPECS 912 - Fix compilation error in code within G4SPECSDEBUG. No functional changes. 964 913 965 13-Sep-2011 I.Hrivnacova (geom-specific-V09-0 914 13-Sep-2011 I.Hrivnacova (geom-specific-V09-04-06) 966 - G4TriangularFacet: fixed tests where square 915 - G4TriangularFacet: fixed tests where square root was compared to 967 half Cartesian tolerance; now compared to kC 916 half Cartesian tolerance; now compared to kCarTolerance. 968 Addressing problem report #1242. 917 Addressing problem report #1242. 969 918 970 25-Aug-2011 G.Cosmo 919 25-Aug-2011 G.Cosmo 971 - Migrated to new G4Exception scheme for warni 920 - Migrated to new G4Exception scheme for warnings and errors. 972 - Defined scheme for warnings/errors coding: 921 - Defined scheme for warnings/errors coding: 973 + 1xxx for warnings, 0xxx for errors. 922 + 1xxx for warnings, 0xxx for errors. 974 Code numbering: 923 Code numbering: 975 + 0001: not supported or implemented feature 924 + 0001: not supported or implemented features; 976 + 0002: invalid setup/construct; 925 + 0002: invalid setup/construct; 977 + 0003: invalid run condition; 926 + 0003: invalid run condition; 978 + 1001: incorrect setup; automatically adapt 927 + 1001: incorrect setup; automatically adapted. 979 + 1002: notification. 928 + 1002: notification. 980 - Added unit test for G4ExtrudedSolid (J.Apost 929 - Added unit test for G4ExtrudedSolid (J.Apostolakis). 981 930 982 22-Aug-2011 I.Hrivnacova (geom-specific-V09-0 931 22-Aug-2011 I.Hrivnacova (geom-specific-V09-04-05) 983 - Fix in G4TriangularFacet::Intersect() to tak 932 - Fix in G4TriangularFacet::Intersect() to take into account geometrical 984 tolerance and cases of zero distance from su 933 tolerance and cases of zero distance from surface's facet. 985 - Fix in G4TessellatedSolid::DistanceToOut(p) 934 - Fix in G4TessellatedSolid::DistanceToOut(p) and DistanceToIn(p) to exactly 986 compute distance from facet avoiding use of 935 compute distance from facet avoiding use of 'outgoing' flag shortcut variant. 987 - Addressing problem report #1242. 936 - Addressing problem report #1242. 988 937 989 17-Aug-2011 T.Nikitina (geom-specific-V09-04- 938 17-Aug-2011 T.Nikitina (geom-specific-V09-04-04) 990 - Fix in G4Paraboloid::DistanceToIn(p,v) and D 939 - Fix in G4Paraboloid::DistanceToIn(p,v) and DistanceToIn(p) to properly 991 take into account tolerance and provide bett 940 take into account tolerance and provide better estimation of distance 992 respectively. Addresses problem report #1234 941 respectively. Addresses problem report #1234. 993 942 994 04-Aug-2011 T.Nikitina (geom-specific-V09-04- 943 04-Aug-2011 T.Nikitina (geom-specific-V09-04-03) 995 - Added SetReferences() and InvertFacets() to 944 - Added SetReferences() and InvertFacets() to G4GenericTrap::CreatePolyhedron() 996 for proper visualisation of Boolean composit 945 for proper visualisation of Boolean compositions with G4GenericTrap. 997 - Added SetReferences() to G4TessellatedSolid: 946 - Added SetReferences() to G4TessellatedSolid::CreatePolyhedron() 998 for proper visualisation of Boolean composit 947 for proper visualisation of Boolean compositions with G4TessellatedSolid. 999 - Requires tag "greps-V09-04-04", for addressi 948 - Requires tag "greps-V09-04-04", for addressing problem report #1235. 1000 949 1001 17-May-2011 I.Hrivnacova (geom-specific-V09- 950 17-May-2011 I.Hrivnacova (geom-specific-V09-04-02) 1002 - G4ExtrudedSolid: fix in Inside(p) for false 951 - G4ExtrudedSolid: fix in Inside(p) for false overlap reporting. 1003 Addressing problem report #1211. 952 Addressing problem report #1211. 1004 953 1005 12-May-2011 G.Cosmo (geom-specific-V09-04-01 954 12-May-2011 G.Cosmo (geom-specific-V09-04-01) 1006 - Fixed compilation warnings from gcc-4.6.0 f 955 - Fixed compilation warnings from gcc-4.6.0 for variables set but not used. 1007 956 1008 06-May-2011 G.Cosmo (geom-specific-V09-04-00 957 06-May-2011 G.Cosmo (geom-specific-V09-04-00) 1009 - Use G4 typedef for CLHEP types. 958 - Use G4 typedef for CLHEP types. 1010 959 1011 26-Nov-2010 T.Nikitina (geom-specific-V09-03 960 26-Nov-2010 T.Nikitina (geom-specific-V09-03-20) 1012 - Fixes in G4GenericTrap reported by SBT unit 961 - Fixes in G4GenericTrap reported by SBT unit test in SurfaceNormal(), 1013 DistanceToPlane() and VisExtent(). 962 DistanceToPlane() and VisExtent(). 1014 963 1015 16-Nov-2010 T.Nikitina (geom-specific-V09-03 964 16-Nov-2010 T.Nikitina (geom-specific-V09-03-19) 1016 - G4EllipticalCone: fixes in DistanceToIn(p,v 965 - G4EllipticalCone: fixes in DistanceToIn(p,v) and DistanceToOut(p,v) for 1017 correct handling of point on the surface. 966 correct handling of point on the surface. 1018 Corrected formula for SurfaceNormal(p). 967 Corrected formula for SurfaceNormal(p). 1019 968 1020 10-Nov-2010 T.Nikitina (geom-specific-V09-03 969 10-Nov-2010 T.Nikitina (geom-specific-V09-03-18) 1021 - Added checks on crossing of vertices and to 970 - Added checks on crossing of vertices and too big twisted angle in 1022 G4GenericTrap. 971 G4GenericTrap. 1023 - Fixed case of division by zero in G4Twisted 972 - Fixed case of division by zero in G4TwistedTubs. 1024 - Added unit test for G4Polyhedra. 973 - Added unit test for G4Polyhedra. 1025 974 1026 02-Nov-2010 G.Cosmo (geom-specific-V09-03-17 975 02-Nov-2010 G.Cosmo (geom-specific-V09-03-17) 1027 - More fixes on Coverity reports for G4Tessel 976 - More fixes on Coverity reports for G4TessellatedSolid and G4ReduciblePolygon. 1028 977 1029 20-Oct-2010 G.Cosmo (geom-specific-V09-03-16 978 20-Oct-2010 G.Cosmo (geom-specific-V09-03-16) 1030 - Implemented Clone() virtual method for all 979 - Implemented Clone() virtual method for all solids, returning a pointer 1031 to a dynamically allocated copy of the soli 980 to a dynamically allocated copy of the solid. To be used by Geant4-MT. 1032 981 1033 23-Sep-2010 G.Cosmo (geom-specific-V09-03-15 982 23-Sep-2010 G.Cosmo (geom-specific-V09-03-15) 1034 - Initialize fpPolyhedron to zero in copy-cto 983 - Initialize fpPolyhedron to zero in copy-ctor and operator=(). 1035 - Completed implementation of copy-ctor and o 984 - Completed implementation of copy-ctor and operator=() for facets. 1036 985 1037 20-Sep-2010 G.Cosmo (geom-specific-V09-03-14 986 20-Sep-2010 G.Cosmo (geom-specific-V09-03-14) 1038 - Implemented copy-constructor and assignment 987 - Implemented copy-constructor and assignment operator for all solids 1039 to facilitate conversion to Geant4-MT. 988 to facilitate conversion to Geant4-MT. 1040 989 1041 08-Sep-2010 G.Cosmo (geom-specific-V09-03-13 990 08-Sep-2010 G.Cosmo (geom-specific-V09-03-13) 1042 - Correction to previous fix in G4ReduciblePo 991 - Correction to previous fix in G4ReduciblePolygon to avoid deleting current 1043 'vertexHead' pointer. 992 'vertexHead' pointer. 1044 993 1045 07-Sep-2010 G.Cosmo (geom-specific-V09-03-12 994 07-Sep-2010 G.Cosmo (geom-specific-V09-03-12) 1046 - Fix within G4CSGDEBUG code for restoring co 995 - Fix within G4CSGDEBUG code for restoring cout precision. 1047 - Fix in G4ReduciblePolygon::RemoveRedundantV 996 - Fix in G4ReduciblePolygon::RemoveRedundantVertices() to avoid potential 1048 case of dereferencing freed pointer. 997 case of dereferencing freed pointer. 1049 998 1050 19-Aug-2010 T.Nikitina (geom-specific-V09-03 999 19-Aug-2010 T.Nikitina (geom-specific-V09-03-11) 1051 - G4EllipticalTube: extended implementation o 1000 - G4EllipticalTube: extended implementation of SurfaceNormal(p) in agreement 1052 with canonical form. Added unit test testG4 1001 with canonical form. Added unit test testG4EllipticalTube.cc. 1053 1002 1054 16-Jul-2010 G.Cosmo (geom-specific-V09-03-10 1003 16-Jul-2010 G.Cosmo (geom-specific-V09-03-10) 1055 - Fixed cases of division by zero in G4VTwist 1004 - Fixed cases of division by zero in G4VTwistSurface and G4TwistBoxSide. 1056 - Use INT_MAX as initialisation for max limit 1005 - Use INT_MAX as initialisation for max limits in G4SolidExtentList. 1057 1006 1058 12-Jul-2010 G.Cosmo (geom-specific-V09-03-09 1007 12-Jul-2010 G.Cosmo (geom-specific-V09-03-09) 1059 - Added dummy initialization to members in st 1008 - Added dummy initialization to members in struct 1060 G4PolyPhiFace::G4PolyPhiFaceEdge, struct G4 1009 G4PolyPhiFace::G4PolyPhiFaceEdge, struct G4ReduciblePolygon::ABVertex. 1061 G4Ellipsoid, G4EllipticalTube, G4EnclosingC 1010 G4Ellipsoid, G4EllipticalTube, G4EnclosingCylinder, G4ExtrudedSolid, G4Hype, 1062 G4IntersectingCone, G4Paraboloid, G4PolyPhi 1011 G4IntersectingCone, G4Paraboloid, G4PolyPhiFace, G4Polycone, G4PolyconeSide, 1063 G4Polyhedra, G4PolyhedraSide, G4Quadrangula 1012 G4Polyhedra, G4PolyhedraSide, G4QuadrangularFacet, G4ReduciblePolygon, 1064 G4TessellatedSolid, G4TriangularFacet, G4Tw 1013 G4TessellatedSolid, G4TriangularFacet, G4TwistBoxSide, G4TwistTrapAlphaSide, 1065 G4TwistTrapFlatSide, G4TwistTrapParallelSid 1014 G4TwistTrapFlatSide, G4TwistTrapParallelSide, G4TwistTubsFlatSide, 1066 G4TwistTubsHypeSide, G4TwistTubsSide, G4Twi 1015 G4TwistTubsHypeSide, G4TwistTubsSide, G4TwistedTubs, G4VCSGfaceted, G4VFacet, 1067 G4VTwistSurface, G4VTwistedFaceted. 1016 G4VTwistSurface, G4VTwistedFaceted. 1068 - Fixed case of dereferencing null pointer in 1017 - Fixed case of dereferencing null pointer in methods 1069 G4EllipticalTube::DistanceToOut(p,v), G4VCS 1018 G4EllipticalTube::DistanceToOut(p,v), G4VCSGfaceted::DistanceToIn(p,v) 1070 and G4VCSGfaceted::DistanceToOut(p,v). 1019 and G4VCSGfaceted::DistanceToOut(p,v). 1071 - Fixed unecessary object copy as argument in 1020 - Fixed unecessary object copy as argument in method 1072 G4PolyhedraSide::IntersectSidePlane(). 1021 G4PolyhedraSide::IntersectSidePlane(). 1073 - Avoid possible case of derefencing null poi 1022 - Avoid possible case of derefencing null pointer in G4ReduciblePolygon 1074 RemoveDuplicateVertices() and RemoveRedunda 1023 RemoveDuplicateVertices() and RemoveRedundantVertices() methods. 1075 - Replaced calls to std::abs() with std::fabs 1024 - Replaced calls to std::abs() with std::fabs() where suitable. 1076 1025 1077 16-Jun-2010 G.Cosmo (geom-specific-V09-03-08 1026 16-Jun-2010 G.Cosmo (geom-specific-V09-03-08) 1078 - Fixed deletion of internal arrays in Create 1027 - Fixed deletion of internal arrays in CreatePolyhedron() for G4Polycone 1079 and G4Polyhedra. 1028 and G4Polyhedra. 1080 1029 1081 11-Jun-2010 T.Nikitina (geom-specific-V09-03 1030 11-Jun-2010 T.Nikitina (geom-specific-V09-03-07) 1082 - G4GenericTrap: fixed cases of zero dToIn/sT 1031 - G4GenericTrap: fixed cases of zero dToIn/sToOut when vertices are collapsed 1083 to triangle, line or point. Added new metho 1032 to triangle, line or point. Added new methods handling those specific cases. 1084 - Added unit test for G4GenericTrap. 1033 - Added unit test for G4GenericTrap. 1085 1034 1086 10-Jun-2010 I.Hrivnacova 1035 10-Jun-2010 I.Hrivnacova 1087 - G4GenericTrap: fixed parameter names in Cal 1036 - G4GenericTrap: fixed parameter names in CalculateExtent() for the test 1088 case construction through tessellated facet 1037 case construction through tessellated facets. 1089 1038 1090 09-Jun-2010 G.Cosmo 1039 09-Jun-2010 G.Cosmo 1091 - G4GenericTrap: moved internal methods to pr 1040 - G4GenericTrap: moved internal methods to private section and reordered 1092 in source file. Added missing implementatio 1041 in source file. Added missing implementation for IsTwisted() method. 1093 1042 1094 03-Jun-2010 T.Nikitina, G.Cosmo (geom-specif 1043 03-Jun-2010 T.Nikitina, G.Cosmo (geom-specific-V09-03-06) 1095 - G4GenericTrap: 1044 - G4GenericTrap: 1096 o Fixed initialization of fSurfaceArea and 1045 o Fixed initialization of fSurfaceArea and fCubicVolume and 1097 calculation of surface area. 1046 calculation of surface area. 1098 o Fixed error in Inside(p) function, and co 1047 o Fixed error in Inside(p) function, and corrected use std::fabs() instead 1099 of std::abs() for floating point values. 1048 of std::abs() for floating point values. 1100 o Added missing initialisation of fpPolyhed 1049 o Added missing initialisation of fpPolyhedron pointer. 1101 o More corrected signatures for use of non- 1050 o More corrected signatures for use of non-const references for vectors 1102 passed as arguments to functions. 1051 passed as arguments to functions. 1103 1052 1104 02-Jun-2010 G.Cosmo (geom-specific-V09-03-05 1053 02-Jun-2010 G.Cosmo (geom-specific-V09-03-05) 1105 - G4GenericTrap: use const reference for vect 1054 - G4GenericTrap: use const reference for vector of vertices passed as argument 1106 in constructor and accessor. 1055 in constructor and accessor. 1107 1056 1108 27-May-2010 T.Nikitina (geom-specific-V09-03 1057 27-May-2010 T.Nikitina (geom-specific-V09-03-04) 1109 - First implementation of G4GenericTrap shape 1058 - First implementation of G4GenericTrap shape, a new solid representing an 1110 arbitrary trapezoid with up to 8 vertices s 1059 arbitrary trapezoid with up to 8 vertices standing on two parallel planes 1111 perpendicular to the Z axis. 1060 perpendicular to the Z axis. 1112 1061 1113 28-Apr-2010 P.R.Truscott (geom-specific-V09- 1062 28-Apr-2010 P.R.Truscott (geom-specific-V09-03-03) 1114 - Fix in G4TriangularFacet and G4TessellatedS 1063 - Fix in G4TriangularFacet and G4TessellatedSolid to correct treatment of 1115 optical photon transport related to interna 1064 optical photon transport related to internal reflection at surface. 1116 Addresses problem report #1103. 1065 Addresses problem report #1103. 1117 1066 1118 15-Apr-2010 I.Hrivnacova (geom-specific-V09- 1067 15-Apr-2010 I.Hrivnacova (geom-specific-V09-03-02) 1119 - G4ExtrudedSolid: eliminated requirement for 1068 - G4ExtrudedSolid: eliminated requirement for clockwise ordering of polygon 1120 vertices. Added a check for vertices orderi 1069 vertices. Added a check for vertices ordering; if vertices are defined 1121 anti-clockwise their ordering is reverted. 1070 anti-clockwise their ordering is reverted. 1122 Fix in polygon facet triangularization for 1071 Fix in polygon facet triangularization for consequent concave vertices. 1123 1072 1124 24-Feb-2010 G.Cosmo (geom-specific-V09-03-01 1073 24-Feb-2010 G.Cosmo (geom-specific-V09-03-01) 1125 - Adopt caching of Phi in G4PolyconeSide and 1074 - Adopt caching of Phi in G4PolyconeSide and G4PolyhedraSide to avoid 1126 unnecessary consecutive computations on the 1075 unnecessary consecutive computations on the same point. 1127 1076 1128 10-Feb-2010 G.Cosmo (geom-specific-V09-03-00 1077 10-Feb-2010 G.Cosmo (geom-specific-V09-03-00) 1129 - Use kInfinity for initialising minimum and 1078 - Use kInfinity for initialising minimum and maximum allowed extent for 1130 G4SolidExtentList of faceted solids. 1079 G4SolidExtentList of faceted solids. 1131 1080 1132 11-Nov-2009 G.Cosmo (geom-specific-V09-02-08 1081 11-Nov-2009 G.Cosmo (geom-specific-V09-02-08) 1133 - Avoid fake (and redundant) assignment of va 1082 - Avoid fake (and redundant) assignment of value to 3-vector in 1134 G4PolyconeSide and G4TwistTubsSide. 1083 G4PolyconeSide and G4TwistTubsSide. 1135 1084 1136 24-Sep-2009 T.Nikitina (geom-specific-V09-02 1085 24-Sep-2009 T.Nikitina (geom-specific-V09-02-07) 1137 - G4Ellipsoid: refined fix in DistanceToIn(p, 1086 - G4Ellipsoid: refined fix in DistanceToIn(p,v) for points located on the 1138 curved surface, and correct treatment of ge 1087 curved surface, and correct treatment of geometrical tolerance. 1139 1088 1140 09-Sep-2009 G.Cosmo (geom-specific-V09-02-06 1089 09-Sep-2009 G.Cosmo (geom-specific-V09-02-06) 1141 - G4Ellipsoid: fixed usage of half-tolerances 1090 - G4Ellipsoid: fixed usage of half-tolerances (radial and Cartesian) in 1142 DistanceToIn(p,v), based on incorrect assum 1091 DistanceToIn(p,v), based on incorrect assumptions introduced in tag 1143 "geom-specific-V09-02-04", responsible for 1092 "geom-specific-V09-02-04", responsible for zero steps on configurations 1144 with cut in Z. Addresses problem report #10 1093 with cut in Z. Addresses problem report #1076. 1145 1094 1146 04-Aug-2009 T.Nikitina (geom-specific-V09-02 1095 04-Aug-2009 T.Nikitina (geom-specific-V09-02-05) 1147 - G4Ellipsoid: 1096 - G4Ellipsoid: 1148 o Fixes in Inside(p) and in DistanceToIn(p, 1097 o Fixes in Inside(p) and in DistanceToIn(p,v) for points 1149 located on the curved surface within tole 1098 located on the curved surface within tolerance. Final fix for issue 1150 reported in problem report #1050 and conc 1099 reported in problem report #1050 and concerning warnings reported by 1151 grid_test. 1100 grid_test. 1152 o Adopt pre-computed half-tolerance values 1101 o Adopt pre-computed half-tolerance values for optimisation. 1153 1102 1154 23-Jul-2009 T.Nikitina (geom-specific-V09-02 1103 23-Jul-2009 T.Nikitina (geom-specific-V09-02-04) 1155 - G4Ellipsoid: fix to DistanceToIn(p,v) in th 1104 - G4Ellipsoid: fix to DistanceToIn(p,v) in the calculation of the roots of 1156 the quadratic equation and in DistanceToOut 1105 the quadratic equation and in DistanceToOut(p,v) in the calculation of the 1157 normal on cut surfaces. Final fix for probl 1106 normal on cut surfaces. Final fix for problem report #1022 and #1050. 1158 - G4PolyconeSide: added protection in method 1107 - G4PolyconeSide: added protection in method Normal(), addressing problem 1159 report #1073. 1108 report #1073. 1160 1109 1161 30-Jun-2009 T.Nikitina (geom-specific-V09-02 1110 30-Jun-2009 T.Nikitina (geom-specific-V09-02-03) 1162 - G4Ellipsoid: introduced to DistanceToIn(p,v 1111 - G4Ellipsoid: introduced to DistanceToIn(p,v) splitting of the distance for 1163 point very far from intersection area and b 1112 point very far from intersection area and big difference between solid 1164 dimensions and distance to it; resolves iss 1113 dimensions and distance to it; resolves issue observed on 64 bits problem. 1165 Also addressing problem report #1022. 1114 Also addressing problem report #1022. 1166 1115 1167 08-May-2009, G.Cosmo (geom-specific-V09-02-02 1116 08-May-2009, G.Cosmo (geom-specific-V09-02-02) 1168 - Corrected typo in base implementation of G4 1117 - Corrected typo in base implementation of G4VCSGfaceted::GetSurfaceArea(), 1169 which was erroneously returning cubic volum 1118 which was erroneously returning cubic volume estimation. 1170 Addresses problem report #1062. 1119 Addresses problem report #1062. 1171 1120 1172 27-Apr-2009, G.Cosmo (geom-specific-V09-02-01 1121 27-Apr-2009, G.Cosmo (geom-specific-V09-02-01) 1173 - Relaxed error condition in G4TessellatedSol 1122 - Relaxed error condition in G4TessellatedSolid::Inside(p) to warning, for 1174 excess of max trials and anomalous conditio 1123 excess of max trials and anomalous conditions in distance calculation. 1175 Added more printout information when error 1124 Added more printout information when error condition is detected. 1176 1125 1177 27-Feb-2009, T.Nikitina (geom-specific-V09-02 1126 27-Feb-2009, T.Nikitina (geom-specific-V09-02-00) 1178 - Fix in G4Paraboloid::DistanceToOut(p,v,..) 1127 - Fix in G4Paraboloid::DistanceToOut(p,v,..) for the computation of normal 1179 to surface; added missing normalisation to 1128 to surface; added missing normalisation to unit, following remark in the 1180 Geometry Forum Hypernews posting #953. 1129 Geometry Forum Hypernews posting #953. 1181 1130 1182 21-Nov-2008, G.Cosmo (geom-specific-V09-01-19 1131 21-Nov-2008, G.Cosmo (geom-specific-V09-01-19) 1183 - Added missing accessors to G4EllipticalCone 1132 - Added missing accessors to G4EllipticalCone, required for detector 1184 persistency. 1133 persistency. 1185 1134 1186 13-Nov-2008, G.Cosmo (geom-specific-V09-01-18 1135 13-Nov-2008, G.Cosmo (geom-specific-V09-01-18) 1187 - Corrected initialisation of algorithm in G4 1136 - Corrected initialisation of algorithm in G4TriangularFacet constructor. 1188 1137 1189 30-Oct-2008, I.Hrivnacova (geom-specific-V09- 1138 30-Oct-2008, I.Hrivnacova (geom-specific-V09-01-17) 1190 - G4ExtrudedSolid: fixed bug in the decomposi 1139 - G4ExtrudedSolid: fixed bug in the decomposition of polygonal sides for 1191 quadrangular facets in MakeFacets(). Addres 1140 quadrangular facets in MakeFacets(). Addresses problem report #1029. 1192 1141 1193 23-Sep-2008, T.Nikitina (geom-specific-V09-01 1142 23-Sep-2008, T.Nikitina (geom-specific-V09-01-16) 1194 - Corrected algorithm in G4TriangularFacet::G 1143 - Corrected algorithm in G4TriangularFacet::GetPointOnFace() according to 1195 suggestion advanced in problem report #1025 1144 suggestion advanced in problem report #1025. Fixes a problem of false 1196 overlaps detection related to G4ExtrudedSol 1145 overlaps detection related to G4ExtrudedSolid and G4TessellatedSolid. 1197 1146 1198 12-Sep-2008, G.Cosmo (geom-specific-V09-01-15 1147 12-Sep-2008, G.Cosmo (geom-specific-V09-01-15) 1199 - G4VFacet: corrected increment of indeces in 1148 - G4VFacet: corrected increment of indeces in operator==(), following 1200 problem report #1024. 1149 problem report #1024. 1201 1150 1202 25-Jul-2008, I.Hrivnacova (geom-specific-V09- 1151 25-Jul-2008, I.Hrivnacova (geom-specific-V09-01-14) 1203 - G4ExtrudedSolid: fix in polygon decompositi 1152 - G4ExtrudedSolid: fix in polygon decomposition; systematically use 1204 half kCarTolerance instead of kCarTolerance 1153 half kCarTolerance instead of kCarTolerance; added solid name in the 1205 error messages coming from fatal exceptions 1154 error messages coming from fatal exceptions. 1206 1155 1207 16-Jul-2008, T.Nikitina (geom-specific-V09-01 1156 16-Jul-2008, T.Nikitina (geom-specific-V09-01-13) 1208 - G4Paraboloid: revised DistanceToOut(p,v,... 1157 - G4Paraboloid: revised DistanceToOut(p,v,...) in answer to problem report 1209 #1015. Fixed precision problem when solving 1158 #1015. Fixed precision problem when solving quadratic equation; apply 1210 comparison with kCarTolerance and not with 1159 comparison with kCarTolerance and not with zero; fixed logic problem in 1211 algoritm for points on surface and directio 1160 algoritm for points on surface and direction inside, relative to directions 1212 along Z, (0,0,Vz). 1161 along Z, (0,0,Vz). 1213 1162 1214 22-May-2008, G.Cosmo (geom-specific-V09-01-12 1163 22-May-2008, G.Cosmo (geom-specific-V09-01-12) 1215 - Removed left-over debug printout in G4VCSGF 1164 - Removed left-over debug printout in G4VCSGFaceted::DistanceToIn(). 1216 1165 1217 15-May-2008, T.Nikitina (geom-specific-V09-01 1166 15-May-2008, T.Nikitina (geom-specific-V09-01-11) 1218 - Enhanced GetPointOnSurface() for generic G4 1167 - Enhanced GetPointOnSurface() for generic G4Polycone and G4Polyhedra 1219 constructs; the method uses new triangulati 1168 constructs; the method uses new triangulation algorithm for G4PolyPhiFace. 1220 - G4ExtrudedSolid: added missing 'std' namesp 1169 - G4ExtrudedSolid: added missing 'std' namespace to standard mathematical 1221 function calls. 1170 function calls. 1222 1171 1223 28-Apr-2008, T.Nikitina (geom-specific-V09-01 1172 28-Apr-2008, T.Nikitina (geom-specific-V09-01-10) 1224 - Added kCarTolerance in definition of "low" 1173 - Added kCarTolerance in definition of "low" and "high" cone limits in R 1225 and in Z in order to protect against numeri 1174 and in Z in order to protect against numerical errors. This fixes cases of 1226 DistanceToIn(p,v) returning 'kInfinity' whe 1175 DistanceToIn(p,v) returning 'kInfinity' when p+t*v cross intersection 1227 between two cones. 1176 between two cones. 1228 1177 1229 25-Apr-2008, T.Nikitina (geom-specific-V09-01 1178 25-Apr-2008, T.Nikitina (geom-specific-V09-01-09) 1230 - Added protection against NaN in G4Intersect 1179 - Added protection against NaN in G4IntersectingCone::LineHitsCone1() in 1231 case of configuration where a conic section 1180 case of configuration where a conic section becomes a tube. 1232 - G4EllipticalCone: removed some debug printo 1181 - G4EllipticalCone: removed some debug printouts. 1233 1182 1234 14-Apr-2008, T.Nikitina (geom-specific-V09-01 1183 14-Apr-2008, T.Nikitina (geom-specific-V09-01-08) 1235 - G4Hype: refined polyhedron representation f 1184 - G4Hype: refined polyhedron representation for correct visualization of 1236 the shape. Coworks with tag "greps-V09-01-0 1185 the shape. Coworks with tag "greps-V09-01-04". 1237 1186 1238 13-Mar-2008, G.Cosmo (geom-specific-V09-01-07 1187 13-Mar-2008, G.Cosmo (geom-specific-V09-01-07) 1239 - Cleared compilation warnings in G4Paraboloi 1188 - Cleared compilation warnings in G4Paraboloid and G4TessellatedSolid 1240 on gcc-4.3.0 for ambiguous use of parenthes 1189 on gcc-4.3.0 for ambiguous use of parentheses in condition statements. 1241 1190 1242 28-Feb-2008, I.Hrivnacova (geom-specific-V09- 1191 28-Feb-2008, I.Hrivnacova (geom-specific-V09-01-06) 1243 - Correction to previous fix in G4ExtrudedSol 1192 - Correction to previous fix in G4ExtrudedSolid: testing on the edges has 1244 to be limited to the line segment, for this 1193 to be limited to the line segment, for this purpose a new internal method 1245 IsSameLineSegment() has been introduced for 1194 IsSameLineSegment() has been introduced for use instead of IsSameLine(). 1246 - Updated and extended unit test testG4Extrud 1195 - Updated and extended unit test testG4ExtrudedSolid.cc. 1247 1196 1248 27-Feb-2008, I.Hrivnacova (geom-specific-V09- 1197 27-Feb-2008, I.Hrivnacova (geom-specific-V09-01-05) 1249 - Fix in G4TessellatedSolid::DistanceToOut(p, 1198 - Fix in G4TessellatedSolid::DistanceToOut(p,v,..) to compute normal only 1250 if specified by flag in input. 1199 if specified by flag in input. 1251 - Fix in G4ExtrudedSolid::Inside(p) for corre 1200 - Fix in G4ExtrudedSolid::Inside(p) for correctly handling the case of 1252 points located on the edges of triangles wh 1201 points located on the edges of triangles which are not the outline edges 1253 of the polygon. 1202 of the polygon. 1254 1203 1255 21-Feb-2008, T.Nikitina (geom-specific-V09-01 1204 21-Feb-2008, T.Nikitina (geom-specific-V09-01-04) 1256 - G4Polyhedra: fixed problem of out-of-bound 1205 - G4Polyhedra: fixed problem of out-of-bound access to vectors in 1257 GetPointOnSurface(). 1206 GetPointOnSurface(). 1258 1207 1259 20-Feb-2008, I.Hrivnacova (geom-specific-V09- 1208 20-Feb-2008, I.Hrivnacova (geom-specific-V09-01-03) 1260 - G4TessellatedSolid: fixed bug in copy-const 1209 - G4TessellatedSolid: fixed bug in copy-constructor and internal method 1261 CopyObjects() for cloning of facets. 1210 CopyObjects() for cloning of facets. 1262 1211 1263 05-Feb-2008, I.Hrivnacova (geom-specific-V09- 1212 05-Feb-2008, I.Hrivnacova (geom-specific-V09-01-02) 1264 - G4ExtrudedSolid: bug fix in MakeFacets() to 1213 - G4ExtrudedSolid: bug fix in MakeFacets() to fill 'fTriangles' also in case 1265 of polygon with 3 or 4 vertices, as they ar 1214 of polygon with 3 or 4 vertices, as they are needed for Inside(p). 1266 1215 1267 02-Feb-2008, I.Hrivnacova (geom-specific-V09- 1216 02-Feb-2008, I.Hrivnacova (geom-specific-V09-01-01) 1268 - Corrected triangularization of polygon, now 1217 - Corrected triangularization of polygon, now correctly handling case 1269 of concave shapes. 1218 of concave shapes. 1270 - Corrected order of arguments in G4Paraboloi 1219 - Corrected order of arguments in G4Paraboloid constructor. 1271 1220 1272 16-Jan-2008, I.Hrivnacova (geom-specific-V09- 1221 16-Jan-2008, I.Hrivnacova (geom-specific-V09-01-00) 1273 - In G4ExtrudedSolid::MakeFacets(), now addin 1222 - In G4ExtrudedSolid::MakeFacets(), now adding triangular facets before quadrangular 1274 ones, following logic behind G4TessellatedS 1223 ones, following logic behind G4TessellatedSolid. 1275 1224 1276 12-Dec-2007, G.Cosmo (geom-specific-V09-00-08 1225 12-Dec-2007, G.Cosmo (geom-specific-V09-00-08a) 1277 - Remove use of global static constant from s 1226 - Remove use of global static constant from singleton initialisation in 1278 G4TessellatedGeometryAlgorithms class. Use 1227 G4TessellatedGeometryAlgorithms class. Use 'sqrEpsilon' as local value. 1279 1228 1280 15-Nov-2007, P.Truscott (geom-specific-V09-00 1229 15-Nov-2007, P.Truscott (geom-specific-V09-00-08) 1281 - Reviewed implementation of G4TessellatedSol 1230 - Reviewed implementation of G4TessellatedSolid::CalculateExtent() to 1282 make it more robust and precise, following 1231 make it more robust and precise, following suggestion by S.Seibert 1283 addressed in problem report #983, now fixed 1232 addressed in problem report #983, now fixed. 1284 1233 1285 12-Oct-2007, G.Cosmo (geom-specific-V09-00-07 1234 12-Oct-2007, G.Cosmo (geom-specific-V09-00-07) 1286 - Corrected wrong boolean condition in method 1235 - Corrected wrong boolean condition in method IntersectLineAndTriangle2D() 1287 of G4TessellatedGeometryAlgorithms causing 1236 of G4TessellatedGeometryAlgorithms causing compilation error on VC++8. 1288 1237 1289 09-Oct-2007, G.Cosmo (geom-specific-V09-00-06 1238 09-Oct-2007, G.Cosmo (geom-specific-V09-00-06) 1290 - Reviewed G4TessellatedSolid classes in orde 1239 - Reviewed G4TessellatedSolid classes in order not to make use of random 1291 numbers for selection of direction (by P.Tr 1240 numbers for selection of direction (by P.Truscott). 1292 1241 1293 02-Oct-2007, G.Cosmo 1242 02-Oct-2007, G.Cosmo 1294 - Removed debug printout in G4Polycone::GetPo 1243 - Removed debug printout in G4Polycone::GetPointOnCone(). 1295 1244 1296 23-Aug-2007, G.Cosmo (geom-specific-V09-00-05 1245 23-Aug-2007, G.Cosmo (geom-specific-V09-00-05) 1297 - Revision of G4TessellatedSolid classes: 1246 - Revision of G4TessellatedSolid classes: 1298 o Fixed problem report #931 by P.Truscott, 1247 o Fixed problem report #931 by P.Truscott, based on suggestion of 1299 R.Holmberg. Modified classes G4Tessellate 1248 R.Holmberg. Modified classes G4TessellatedSolid and G4TriangularFacet. 1300 o Modified data and accessor 'centroid' and 1249 o Modified data and accessor 'centroid' and 'GetCentroid()' for G4VFacet; 1301 replaced by 'circumcentre' and 'GetCircum 1250 replaced by 'circumcentre' and 'GetCircumcentre()' respectively. 1302 o Added utility class G4TessellatedGeometry 1251 o Added utility class G4TessellatedGeometryAlgorithms. 1303 - Added formulas for calculating SemiAxis and 1252 - Added formulas for calculating SemiAxis and Zheight in G4EllipticalCone 1304 (by T.Nikitina). 1253 (by T.Nikitina). 1305 1254 1306 20-Aug-2007, T.Nikitina & L.Lindroos (geom-sp 1255 20-Aug-2007, T.Nikitina & L.Lindroos (geom-specific-V09-00-04) 1307 - Revision of G4EllipticalCone: 1256 - Revision of G4EllipticalCone: 1308 o DistanceToIn(p): corrected answer for p.z 1257 o DistanceToIn(p): corrected answer for p.z()<-zTopCut and for the point 1309 p on the surface. 1258 p on the surface. 1310 o DistanceToOut(p,v): now returning positiv 1259 o DistanceToOut(p,v): now returning positive solution or zero when crossing 1311 the elliptical surface. 1260 the elliptical surface. 1312 o Fix in DistanceToOut(p) which was giving 1261 o Fix in DistanceToOut(p) which was giving always zero. 1313 o Corrected visualisation error of solid in 1262 o Corrected visualisation error of solid in graphics_reps. 1314 o Added some formulas on how to pre-calcula 1263 o Added some formulas on how to pre-calculate 'SemiAxis' and 'zheight'. 1315 o Added checkDistanceToOut() method to unit 1264 o Added checkDistanceToOut() method to unit test. 1316 - Corrections to G4Paraboloid: 1265 - Corrections to G4Paraboloid: 1317 o Fixed bug in CalculateSurfaceArea() metho 1266 o Fixed bug in CalculateSurfaceArea() method 1318 o Added correct initialisation of 'fPolyhed 1267 o Added correct initialisation of 'fPolyhedron' in constructor. 1319 o Added unit test testG4Paraboloid. 1268 o Added unit test testG4Paraboloid. 1320 1269 1321 13-Aug-2007, W.Pokorski (geom-specific-V09-00 1270 13-Aug-2007, W.Pokorski (geom-specific-V09-00-03) 1322 - G4PolyconeSide: added workaround to initial 1271 - G4PolyconeSide: added workaround to initialisation of 'corners' vector, 1323 to allow for object persistency with Root-I 1272 to allow for object persistency with Root-I/O (W.Pokorski). 1324 1273 1325 18-Jul-2007, G.Cosmo (geom-specific-V09-00-02 1274 18-Jul-2007, G.Cosmo (geom-specific-V09-00-02) 1326 - New specific G4Paraboloid with cuts along t 1275 - New specific G4Paraboloid with cuts along the Z axis (by L.Lindroos). 1327 - Fixed dummy constructors of G4Polycone and 1276 - Fixed dummy constructors of G4Polycone and G4PolyPhiFace for initialisation 1328 of 'edges' and 'corners'. 1277 of 'edges' and 'corners'. 1329 - Coworks with tag "greps-V09-00-01". 1278 - Coworks with tag "greps-V09-00-01". 1330 1279 1331 12-Jul-2007, T.Nikitina (geom-specific-V09-00 1280 12-Jul-2007, T.Nikitina (geom-specific-V09-00-01) 1332 - Fix in G4Polyhedra::GetPointOnSurface() to 1281 - Fix in G4Polyhedra::GetPointOnSurface() to correctly treat 'totalPhi' instead of 1333 'endPhi' for the case of open shapes and 't 1282 'endPhi' for the case of open shapes and 'twopi' for not open shapes. 1334 1283 1335 05-Jul-2007, T.Nikitina (geom-specific-V09-00 1284 05-Jul-2007, T.Nikitina (geom-specific-V09-00-00) 1336 - Fix in G4Polyhedra::GetPointOnSurface() for 1285 - Fix in G4Polyhedra::GetPointOnSurface() for the case when number of sectors 1337 (numSide) is equal to 1. At the origin of p 1286 (numSide) is equal to 1. At the origin of problems observed when checking 1338 overlaps for polyhedra solids defined as su 1287 overlaps for polyhedra solids defined as such. 1339 1288 1340 31-May-2007, G.Cosmo (geom-specific-V08-03-03 1289 31-May-2007, G.Cosmo (geom-specific-V08-03-03) 1341 - Fixed initialisation of constants in constr 1290 - Fixed initialisation of constants in constructor for - G4VTwistSurface, 1342 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraS 1291 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraSide - following latest changes 1343 for tunable tolerance. 1292 for tunable tolerance. 1344 1293 1345 25-May-2007, G.Cosmo (geom-specific-V08-03-02 1294 25-May-2007, G.Cosmo (geom-specific-V08-03-02) 1346 - Fixed default response of DistToIn/DistToOu 1295 - Fixed default response of DistToIn/DistToOut for twisted solids. 1347 - Use G4TWISTDEBUG instead of G4SPECSDEBUG as 1296 - Use G4TWISTDEBUG instead of G4SPECSDEBUG as debug conditional flag 1348 for twisted solids. 1297 for twisted solids. 1349 - Some cleanup in G4TwistTrapAlphaSide code. 1298 - Some cleanup in G4TwistTrapAlphaSide code. 1350 1299 1351 18-May-2007, G.Cosmo (geom-specific-V08-03-01 1300 18-May-2007, G.Cosmo (geom-specific-V08-03-01) 1352 - Use kAngTolerance and kRadTolerance from G4 1301 - Use kAngTolerance and kRadTolerance from G4GeometryTolerance class. 1353 - Coworks with tag "global-V08-03-03". 1302 - Coworks with tag "global-V08-03-03". 1354 1303 1355 11-May-2007, T.Nikitina (geom-specific-V08-03 1304 11-May-2007, T.Nikitina (geom-specific-V08-03-00) 1356 - Use call to G4GeometryTolerance instead of 1305 - Use call to G4GeometryTolerance instead of kCarTolerance where needed. 1357 - Requires tag "global-V08-03-00" and related 1306 - Requires tag "global-V08-03-00" and related tag set. 1358 1307 1359 26-Apr-2007, T.Nikitina (geom-specific-V08-02 1308 26-Apr-2007, T.Nikitina (geom-specific-V08-02-05) 1360 - Fix in GetPointOnSurface() for G4Polycone t 1309 - Fix in GetPointOnSurface() for G4Polycone to consider also points laying 1361 on rings when consecutive Z-sections are co 1310 on rings when consecutive Z-sections are coincident. 1362 Added method GetPointOnRing(). 1311 Added method GetPointOnRing(). 1363 - Added unit test testPointOnSurfacePoly.cc. 1312 - Added unit test testPointOnSurfacePoly.cc. 1364 1313 1365 27-Feb-2007, I.Hrivnacova (geom-specific-V08- 1314 27-Feb-2007, I.Hrivnacova (geom-specific-V08-02-04) 1366 - Added specialised constructor for handling 1315 - Added specialised constructor for handling Z-sections in G4ExtrudedSolid. 1367 - Cleared unecessary declaration of IsInside( 1316 - Cleared unecessary declaration of IsInside() methods in G4TriangularFacet 1368 and G4QuadrangularFacet. 1317 and G4QuadrangularFacet. 1369 - Updated unit test for G4ExtrudedSolid. 1318 - Updated unit test for G4ExtrudedSolid. 1370 1319 1371 26-Feb-2007, I.Hrivnacova (geom-specific-V08- 1320 26-Feb-2007, I.Hrivnacova (geom-specific-V08-02-04) 1372 - Added specialised constructor for handling 1321 - Added specialised constructor for handling Z-sections in G4ExtrudedSolid. 1373 - Cleared unecessary declaration of IsInside( 1322 - Cleared unecessary declaration of IsInside() methods in G4TriangularFacet 1374 and G4QuadrangularFacet. 1323 and G4QuadrangularFacet. 1375 - Updated unit test for G4ExtrudedSolid. 1324 - Updated unit test for G4ExtrudedSolid. 1376 1325 1377 15-Feb-2007, I.Hrivnacova (geom-specific-V08- 1326 15-Feb-2007, I.Hrivnacova (geom-specific-V08-02-03) 1378 - Corrected caching of values in G4ExtrudedSo 1327 - Corrected caching of values in G4ExtrudedSolid. 1379 - Bug fix in G4TriangularFacet::Intersect() t 1328 - Bug fix in G4TriangularFacet::Intersect() to allow for correct update of 1380 'Distance' in condition. 1329 'Distance' in condition. 1381 - Updated unit test for G4ExtrudedSolid. 1330 - Updated unit test for G4ExtrudedSolid. 1382 1331 1383 09-Feb-2007, G.Cosmo (geom-specific-V08-02-02 1332 09-Feb-2007, G.Cosmo (geom-specific-V08-02-02) 1384 - Introduced new shape G4ExtrudedSolid, a sol 1333 - Introduced new shape G4ExtrudedSolid, a solid representing the extrusion 1385 of an arbitrary polygon with fixed outline 1334 of an arbitrary polygon with fixed outline in the two Z sections. 1386 New files: G4ExtrudedSolid[.hh.icc.cc] and 1335 New files: G4ExtrudedSolid[.hh.icc.cc] and testG4ExtrudedSolid.cc 1387 by I.Hrivnacova. 1336 by I.Hrivnacova. 1388 - G4TessellatedSolid: 1337 - G4TessellatedSolid: 1389 o Made relevant solid's methods virtual, to 1338 o Made relevant solid's methods virtual, to be used as base class. 1390 o Added implementation for GetSurfaceArea() 1339 o Added implementation for GetSurfaceArea() and GetPointOnSurface() methods. 1391 o Added protection in SurfaceNormal() metho 1340 o Added protection in SurfaceNormal() method in case of facet not found. 1392 o Check and return kOutside in Inside() if 1341 o Check and return kOutside in Inside() if point out of solid's extent. 1393 1342 1394 01-Feb-2007, G.Cosmo (geom-specific-V08-02-01 1343 01-Feb-2007, G.Cosmo (geom-specific-V08-02-01) 1395 - Fix in G4PolyconeSide::DistanceAway() for c 1344 - Fix in G4PolyconeSide::DistanceAway() for correct estimation of distance 1396 for the case of Phi sections (T.Nikitina). 1345 for the case of Phi sections (T.Nikitina). 1397 Addresses problem report #598. 1346 Addresses problem report #598. 1398 - Updated unit test for G4Polycone to conside 1347 - Updated unit test for G4Polycone to consider new test case. 1399 1348 1400 22-Jan-2007, G.Cosmo (geom-specific-V08-02-00 1349 22-Jan-2007, G.Cosmo (geom-specific-V08-02-00) 1401 - Do not scale reducible-polygon in G4Polyhed 1350 - Do not scale reducible-polygon in G4Polyhedra::Reset() method. 1402 The 'original_parameters' structure offered 1351 The 'original_parameters' structure offered as input through the accessors 1403 are always assumed to be already scaled by 1352 are always assumed to be already scaled by the 'cos(0.5*phiTotal/theNumSide)' 1404 factor. Addresses problem report #873. 1353 factor. Addresses problem report #873. 1405 - Fixed warning printout in G4Polycone::Reset 1354 - Fixed warning printout in G4Polycone::Reset(). 1406 1355 1407 15-Nov-2006, J.Allison (geom-specific-V08-01- 1356 15-Nov-2006, J.Allison (geom-specific-V08-01-04) 1408 - Fixed typo in G4Polycone::CreatePolyhedron( 1357 - Fixed typo in G4Polycone::CreatePolyhedron() introduced by mistake in 1409 the last cleanup of the source code. 1358 the last cleanup of the source code. 1410 1359 1411 13-Nov-2006, G.Cosmo (geom-specific-V08-01-03 1360 13-Nov-2006, G.Cosmo (geom-specific-V08-01-03) 1412 - Added concrete implementation of GetSurface 1361 - Added concrete implementation of GetSurfaceArea() in G4Tet (M.H.Mendenhall). 1413 1362 1414 08-Nov-2006, G.Cosmo (geom-specific-V08-01-02 1363 08-Nov-2006, G.Cosmo (geom-specific-V08-01-02) 1415 - Cleared compilation warnings on SUN-CC for 1364 - Cleared compilation warnings on SUN-CC for changes in the last tag. 1416 Fixed overloaded class variables in G4Polyh 1365 Fixed overloaded class variables in G4Polyhedra and G4Polycone 1417 implementation of CreatePolyhedron(). 1366 implementation of CreatePolyhedron(). 1418 1367 1419 31-Oct-2006, J.Allison (geom-specific-V08-01- 1368 31-Oct-2006, J.Allison (geom-specific-V08-01-01) 1420 - Implemented CreatePolyhedron() for G4Polyhe 1369 - Implemented CreatePolyhedron() for G4Polyhedra and G4Polycone. 1421 1370 1422 20-Oct-2006, G.Cosmo (geom-specific-V08-01-00 1371 20-Oct-2006, G.Cosmo (geom-specific-V08-01-00) 1423 - Implemented caching mechanism for computati 1372 - Implemented caching mechanism for computation of surface area in 1424 all solids and base classes, as done for th 1373 all solids and base classes, as done for the geometrical volume 1425 computation. 1374 computation. 1426 - Added missing fake constructor for object p 1375 - Added missing fake constructor for object persistency to G4TessellatedSolid. 1427 1376 1428 20-Jun-2006, G.Cosmo (geom-specific-V08-00-10 1377 20-Jun-2006, G.Cosmo (geom-specific-V08-00-10) 1429 - Added accessor method GetVertices() in G4Te 1378 - Added accessor method GetVertices() in G4Tet to return the list of 1430 vertices composing the solid. Required for 1379 vertices composing the solid. Required for GDML persistency. 1431 1380 1432 06-Jun-2006, G.Cosmo (geom-specific-V08-00-09 1381 06-Jun-2006, G.Cosmo (geom-specific-V08-00-09) 1433 - Added protection against NaNs in G4Polycone 1382 - Added protection against NaNs in G4PolyconeSide::Normal() for points at 1434 the origin. 1383 the origin. 1435 1384 1436 19-May-2006, G.Cosmo (geom-specific-V08-00-08 1385 19-May-2006, G.Cosmo (geom-specific-V08-00-08) 1437 - Fix in G4Ellipsoid::SetZCuts() and G4Ellipt 1386 - Fix in G4Ellipsoid::SetZCuts() and G4EllipticalTube::SetZCut() for usage 1438 of uninitialised variables. 1387 of uninitialised variables. 1439 1388 1440 08-May-2006, G.Cosmo (geom-specific-V08-00-07 1389 08-May-2006, G.Cosmo (geom-specific-V08-00-07) 1441 - Cleared compilation warning on SUN-CC in G4 1390 - Cleared compilation warning on SUN-CC in G4TriangularFacet.cc. 1442 1391 1443 04-May-2006, G.Cosmo (geom-specific-V08-00-06 1392 04-May-2006, G.Cosmo (geom-specific-V08-00-06) 1444 - Use different names for unit tests to avoid 1393 - Use different names for unit tests to avoid confusing liblist ... 1445 1394 1446 03-May-2006, G.Cosmo (geom-specific-V08-00-05 1395 03-May-2006, G.Cosmo (geom-specific-V08-00-05) 1447 - Added four unit tests for G4TessellatedSoli 1396 - Added four unit tests for G4TessellatedSolid. 1448 1397 1449 24-Mar-2006, G.Cosmo (geom-specific-V08-00-04 1398 24-Mar-2006, G.Cosmo (geom-specific-V08-00-04) 1450 - G4TwistedTubs: defined exact estimation for 1399 - G4TwistedTubs: defined exact estimation for GetCubicVolume(), 1451 similar to the one adopted for G4Tubs. 1400 similar to the one adopted for G4Tubs. 1452 1401 1453 03-Mar-2006, G.Cosmo (geom-specific-V08-00-03 1402 03-Mar-2006, G.Cosmo (geom-specific-V08-00-03) 1454 - Corrected boolean condition in G4Triangular 1403 - Corrected boolean condition in G4TriangularFacet::Intersect(). 1455 Use '&&' operator in condition. Allows for 1404 Use '&&' operator in condition. Allows for porting on WIN32-VC. 1456 1405 1457 01-Mar-2006, G.Cosmo (geom-specific-V08-00-02 1406 01-Mar-2006, G.Cosmo (geom-specific-V08-00-02) 1458 - Introducing first implementation of a tesse 1407 - Introducing first implementation of a tessellated solid, contribution 1459 of P.R.Truscott (QinetiQ Ltd, UK). 1408 of P.R.Truscott (QinetiQ Ltd, UK). 1460 New classes: G4QuadrangularFacet, G4Tessell 1409 New classes: G4QuadrangularFacet, G4TessellatedSolid, G4TriangularFacet 1461 and G4VFacet. 1410 and G4VFacet. 1462 - Requires tag "greps-V08-00-00". 1411 - Requires tag "greps-V08-00-00". 1463 1412 1464 12-Jan-2006, J.Allison (geom-specific-V08-00- 1413 12-Jan-2006, J.Allison (geom-specific-V08-00-01) 1465 - G4TwistedTubs and G4VTwistedFaceted::Create 1414 - G4TwistedTubs and G4VTwistedFaceted::CreatePolyhedron(): 1466 parameterised polyhedron mesh approximation 1415 parameterised polyhedron mesh approximation in terms of 1467 G4Polyhedron::GetNumberOfRotationSteps(). 1416 G4Polyhedron::GetNumberOfRotationSteps(). 1468 This is (a) more economical and (b) amenabl 1417 This is (a) more economical and (b) amenable to user control. 1469 1418 1470 19-Dec-2005, O.Link (geom-specific-V08-00-00) 1419 19-Dec-2005, O.Link (geom-specific-V08-00-00) 1471 - Fixes in G4EllipticalCone: 1420 - Fixes in G4EllipticalCone: 1472 o Changed GetPointOnSurface(), which was no 1421 o Changed GetPointOnSurface(), which was not uniform in endcaps. 1473 o Bug fix in Inside(), which was not correc 1422 o Bug fix in Inside(), which was not correct for the elliptic mantel. 1474 Made test similar as in G4EllipticTube. 1423 Made test similar as in G4EllipticTube. 1475 o Several fixes in DistanceToIn/Out(): for 1424 o Several fixes in DistanceToIn/Out(): for looping events (shortest 1476 distance was taken, even if 0); now compa 1425 distance was taken, even if 0); now comparing the distance to the endcap 1477 and to the mantel and decide afterwards w 1426 and to the mantel and decide afterwards which distance is shortest; 1478 added check n*v. 1427 added check n*v. 1479 o The code is now "good" at 90%. Still 10% 1428 o The code is now "good" at 90%. Still 10% wrong reconstructed events. 1480 e.g there is a problem is DistanceToOut() 1429 e.g there is a problem is DistanceToOut(): missed the intersection 1481 (reconstruction took the encap instead of 1430 (reconstruction took the encap instead of the mantel). 1482 1431 1483 09-Dec-2005, O.Link 1432 09-Dec-2005, O.Link 1484 - Fixed visibility of soft edges on the twist 1433 - Fixed visibility of soft edges on the twisted solids. 1485 1434 1486 08-Dec-2005, O.Link (geom-specific-V07-01-14) 1435 08-Dec-2005, O.Link (geom-specific-V07-01-14) 1487 - Fixed bug in G4VTwistSurface::ComputeLocalP 1436 - Fixed bug in G4VTwistSurface::ComputeLocalPoint(p) for point coordinate 1488 transformation. The bug affected only G4Twi 1437 transformation. The bug affected only G4TwistTrapFlatSide. 1489 1438 1490 06-Dec-2005, G.Cosmo (geom-specific-V07-01-13 1439 06-Dec-2005, G.Cosmo (geom-specific-V07-01-13) 1491 - Fixed compilation errors on WIN32-VC for la 1440 - Fixed compilation errors on WIN32-VC for last tag changes. 1492 1441 1493 05-Dec-2005, O.Link (geom-specific-V07-01-12) 1442 05-Dec-2005, O.Link (geom-specific-V07-01-12) 1494 - Added polyhedron definition for twisted sol 1443 - Added polyhedron definition for twisted solids (G4TwistedTrap, 1495 G4TwistedTrd, G4TwistedBox, G4TwistedTubs) 1444 G4TwistedTrd, G4TwistedBox, G4TwistedTubs) for visualization. 1496 1445 1497 30-Nov-2005, G.Cosmo (geom-specific-V07-01-11 1446 30-Nov-2005, G.Cosmo (geom-specific-V07-01-11) 1498 - Trivial fixes for porting on CLHEP-2.0.X se 1447 - Trivial fixes for porting on CLHEP-2.0.X series. 1499 1448 1500 18-Nov-2005, O.Link (geom-specific-V07-01-10) 1449 18-Nov-2005, O.Link (geom-specific-V07-01-10) 1501 - Renamed classes for twisted solids set, to 1450 - Renamed classes for twisted solids set, to identify them in the 1502 twisted framework. 1451 twisted framework. 1503 1452 1504 17-Nov-2005, O.Link 1453 17-Nov-2005, O.Link 1505 - G4VTwistedFacted: 1454 - G4VTwistedFacted: 1506 o corrected bug in DistanceToSurface() impl 1455 o corrected bug in DistanceToSurface() implementation 1507 o added GetPointOnSurface() method 1456 o added GetPointOnSurface() method 1508 - G4TwistedTubs: 1457 - G4TwistedTubs: 1509 o added GetPointOnSurface() method 1458 o added GetPointOnSurface() method 1510 - G4Hype: 1459 - G4Hype: 1511 o corrected surface area calculation used i 1460 o corrected surface area calculation used in GetPointOnSurface() 1512 1461 1513 17-Nov-2005, G.Cosmo (geom-specific-V07-01-09 1462 17-Nov-2005, G.Cosmo (geom-specific-V07-01-09) 1514 - More fixes required for direct object persi 1463 - More fixes required for direct object persistency to G4Polycone, 1515 G4polyhedra and related utility classes. 1464 G4polyhedra and related utility classes. 1516 1465 1517 10-Nov-2005, J.Allison (geom-specific-V07-01- 1466 10-Nov-2005, J.Allison (geom-specific-V07-01-08) 1518 - G4Tet: 1467 - G4Tet: 1519 o Added implementation for GetPolyhedron() 1468 o Added implementation for GetPolyhedron() and GetCubicVolume(). 1520 o Corrected order of specifying vertices in 1469 o Corrected order of specifying vertices in CreatePolyhedron(). 1521 1470 1522 09-Nov-2005, G.Cosmo (geom-specific-V07-01-07 1471 09-Nov-2005, G.Cosmo (geom-specific-V07-01-07) 1523 - Added fake default constructor for all conc 1472 - Added fake default constructor for all concrete solids and relevant 1524 utility classes, for usage of direct object 1473 utility classes, for usage of direct object persistency. 1525 - Implemented changes to support CLHEP-2.0.X 1474 - Implemented changes to support CLHEP-2.0.X for explicit usage of the 1526 CLHEP/HepGeom namespaces for CLHEP types. 1475 CLHEP/HepGeom namespaces for CLHEP types. 1527 1476 1528 07-Nov-2005, G.Cosmo (geom-specific-V07-01-06 1477 07-Nov-2005, G.Cosmo (geom-specific-V07-01-06) 1529 - G4Ellipsoid: replaced call to hypot(x,y) wi 1478 - G4Ellipsoid: replaced call to hypot(x,y) with std::sqrt(x*x+y*y) 1530 for porting to ISO standard. 1479 for porting to ISO standard. 1531 1480 1532 02-Nov-2005, G.Cosmo (geom-specific-V07-01-05 1481 02-Nov-2005, G.Cosmo (geom-specific-V07-01-05) 1533 - G4Polyhedra, G4Polycone: 1482 - G4Polyhedra, G4Polycone: 1534 o Protected case of generic construct for v 1483 o Protected case of generic construct for visualization. 1535 o Introduced explicit flag and method IsGen 1484 o Introduced explicit flag and method IsGeneric() to identify the kind 1536 of constructor used. 1485 of constructor used. 1537 1486 1538 29-Sep-2005, G.Cosmo (geom-specific-V07-01-04 1487 29-Sep-2005, G.Cosmo (geom-specific-V07-01-04) 1539 - Fix in G4EllipticalCone methods DistanceToI 1488 - Fix in G4EllipticalCone methods DistanceToIn() and DistanceToOut(). 1540 Added unit test for it (by D.Anninos). 1489 Added unit test for it (by D.Anninos). 1541 - Coworks with tag "greps-V07-01-02". 1490 - Coworks with tag "greps-V07-01-02". 1542 1491 1543 10-Aug-2005, G.Cosmo (geom-specific-V07-01-03 1492 10-Aug-2005, G.Cosmo (geom-specific-V07-01-03) 1544 - Introduced new solid G4EllipticalCone, a fu 1493 - Introduced new solid G4EllipticalCone, a full cone with elliptical base 1545 that can be cut in Z (by D.Anninos). 1494 that can be cut in Z (by D.Anninos). 1546 Coworks with tag "greps-V07-01-02". 1495 Coworks with tag "greps-V07-01-02". 1547 1496 1548 08-Aug-2005, D.Anninos (geom-specific-V07-01- 1497 08-Aug-2005, D.Anninos (geom-specific-V07-01-02) 1549 - Added GetPointOnSurface() for all solids ex 1498 - Added GetPointOnSurface() for all solids except twisted ones. 1550 The method returns a random point according 1499 The method returns a random point according to a quasi-uniform 1551 distribution along the surface. 1500 distribution along the surface. 1552 1501 1553 18-Jul-2005, G.Cosmo (geom-specific-V07-01-01 1502 18-Jul-2005, G.Cosmo (geom-specific-V07-01-01) 1554 - Fixed compilation warning on WIN32-VC for G 1503 - Fixed compilation warning on WIN32-VC for G4VSurface.cc. 1555 - Not including G4Tet. 1504 - Not including G4Tet. 1556 1505 1557 06-Jul-2005, G.Cosmo (geom-specific-V07-01-00 1506 06-Jul-2005, G.Cosmo (geom-specific-V07-01-00) 1558 - Added new shape G4Ellipsoid. Coworks with t 1507 - Added new shape G4Ellipsoid. Coworks with tag "greps-V07-01-00". 1559 Contribution of G.Horton-Smith and G.Guerri 1508 Contribution of G.Horton-Smith and G.Guerrieri. 1560 Code cleanup, and added default arguments f 1509 Code cleanup, and added default arguments for cuts, added first 1561 implementation of unit test. 1510 implementation of unit test. 1562 - Corrected unit tests for twisted-box/trap. 1511 - Corrected unit tests for twisted-box/trap. 1563 - Not including G4Tet. 1512 - Not including G4Tet. 1564 1513 1565 15-Jun-2005, J.Apostolakis 1514 15-Jun-2005, J.Apostolakis 1566 - Introduced new solid G4Tet, contribution of 1515 - Introduced new solid G4Tet, contribution of M.H.Mendenhall 1567 and R.A.Weller, Vanderbilt University, USA. 1516 and R.A.Weller, Vanderbilt University, USA. 1568 1517 1569 29-Apr-2005, O.Link (geom-specific-V07-00-04) 1518 29-Apr-2005, O.Link (geom-specific-V07-00-04) 1570 - G4TwistedSurface: fixed bug in GetAreaCode( 1519 - G4TwistedSurface: fixed bug in GetAreaCode() affecting G4TwistedTubs. 1571 1520 1572 04-Apr-2005, G.Cosmo (geom-specific-V07-00-03 1521 04-Apr-2005, G.Cosmo (geom-specific-V07-00-03) 1573 - Added test for Number-Of-Rotation-Steps in 1522 - Added test for Number-Of-Rotation-Steps in GetPolyhedron() for 1574 G4VCSGfaceted, G4Hype and G4EllipticalTube 1523 G4VCSGfaceted, G4Hype and G4EllipticalTube (by J.Allison). 1575 Requires tag "greps-V07-00-02". 1524 Requires tag "greps-V07-00-02". 1576 - Added elementary implementation of CreatePo 1525 - Added elementary implementation of CreatePolyhedron() for G4Hype, 1577 G4TwistedBox, G4TwistedTubs, G4TwistedTrd, 1526 G4TwistedBox, G4TwistedTubs, G4TwistedTrd, G4TwistedTrap. 1578 - Some code cleanup. 1527 - Some code cleanup. 1579 1528 1580 18-Mar-2005, O.Link (geom-specific-V07-00-02) 1529 18-Mar-2005, O.Link (geom-specific-V07-00-02) 1581 - New generic framework for twisted solids G4 1530 - New generic framework for twisted solids G4TwistedBox, G4TwistedTrd and 1582 G4TwistedTrap: inheriting now from the base 1531 G4TwistedTrap: inheriting now from the base class G4VTwistedFaceted. 1583 - Extended G4TwistedTrap to support setups wi 1532 - Extended G4TwistedTrap to support setups with different trapezoidal 1584 endcaps with centres not necessarily on a l 1533 endcaps with centres not necessarily on a line parallel to the z axis. 1585 - Added G4TwistedTrd and general G4TwistedTra 1534 - Added G4TwistedTrd and general G4TwistedTrap as test cases in test. 1586 1535 1587 03-Mar-2005, J.Allison 1536 03-Mar-2005, J.Allison 1588 - Changed AddThis() to AddSolid() for all sol 1537 - Changed AddThis() to AddSolid() for all solids in the implementation 1589 of DescribeYourselfTo(G4VGraphicsScene&). 1538 of DescribeYourselfTo(G4VGraphicsScene&). 1590 1539 1591 01-Mar-2005, O.Link (geom-specific-V07-00-01) 1540 01-Mar-2005, O.Link (geom-specific-V07-00-01) 1592 - Fixed compilation warnings on WIN32-VC for 1541 - Fixed compilation warnings on WIN32-VC for G4VSurface.cc. 1593 1542 1594 14-Feb-2005, O.Link (geom-specific-V07-00-00) 1543 14-Feb-2005, O.Link (geom-specific-V07-00-00) 1595 - Use new polynom approximations based on new 1544 - Use new polynom approximations based on new solver based on Jenkins-Traub 1596 algorithm, for twisted-box and twisted-trap 1545 algorithm, for twisted-box and twisted-trap. 1597 - Fixed bug in the usage of 'fmod' and adopt 1546 - Fixed bug in the usage of 'fmod' and adopt special treatment for 'parallel' 1598 events in G4TwistedBoxSide and G4TwistedTra 1547 events in G4TwistedBoxSide and G4TwistedTrapSide. 1599 - Coworks with tag "global-V07-00-00". 1548 - Coworks with tag "global-V07-00-00". 1600 1549 1601 08-Dec-2004, O.Link (geom-specific-V06-02-07) 1550 08-Dec-2004, O.Link (geom-specific-V06-02-07) 1602 - Extensions to twisted box/trap shapes to co 1551 - Extensions to twisted box/trap shapes to consider all 4 solutions 1603 for determining correct intersections. 1552 for determining correct intersections. 1604 1553 1605 29-Nov-2004, O.Link (geom-specific-V06-02-06) 1554 29-Nov-2004, O.Link (geom-specific-V06-02-06) 1606 - G4TwistedTrapSide, G4TwistedBoxSide: improv 1555 - G4TwistedTrapSide, G4TwistedBoxSide: improved (analytical) version 1607 of GetPhiUAtX() method. 1556 of GetPhiUAtX() method. 1608 1557 1609 24-Nov-2004, O.Link (geom-specific-V06-02-05) 1558 24-Nov-2004, O.Link (geom-specific-V06-02-05) 1610 - Fixed bug in description of twisted trapezo 1559 - Fixed bug in description of twisted trapezoid side. 1611 1560 1612 12-Nov-2004, O.Link (geom-specific-V06-02-04) 1561 12-Nov-2004, O.Link (geom-specific-V06-02-04) 1613 - Added G4TwistedBox - a twisted box with tw 1562 - Added G4TwistedBox - a twisted box with twist angle alpha, 1614 length a/2,b/2,L/2. 1563 length a/2,b/2,L/2. 1615 - Added G4TwistedTrap - a twisted trapezoid ( 1564 - Added G4TwistedTrap - a twisted trapezoid (still in debug state) 1616 - Changed in G4VSurface.icc: 1565 - Changed in G4VSurface.icc: 1617 - GetNeighbours(): corrected axiscode (wa 1566 - GetNeighbours(): corrected axiscode (was returning the wrong neighbours) 1618 - SetNeighbours(): fixed problem #685 (in 1567 - SetNeighbours(): fixed problem #685 (index out of range) 1619 - Added tests for G4TwistedBox and G4TwistedT 1568 - Added tests for G4TwistedBox and G4TwistedTrap in specific/test. 1620 - Added G4TwistedBox and G4TwistedTrap in sys 1569 - Added G4TwistedBox and G4TwistedTrap in system testing, test10. 1621 1570 1622 22-Oct-2004, D.C.Williams (geom-specific-V06- 1571 22-Oct-2004, D.C.Williams (geom-specific-V06-02-03) 1623 - Fix in G4PolyconeSide::Inside for points at 1572 - Fix in G4PolyconeSide::Inside for points at radius = 0 for phi slides 1624 solids with an inner radius. Addresses prob 1573 solids with an inner radius. Addresses problem report #598. 1625 1574 1626 10-Oct-2004, J.Allison (geom-specific-V06-02- 1575 10-Oct-2004, J.Allison (geom-specific-V06-02-02) 1627 - Added GetPolyhedron, a smart access functio 1576 - Added GetPolyhedron, a smart access function that creates a G4Polyhedron 1628 on request and stores for future access. A 1577 on request and stores for future access. A null pointer means "not 1629 available". 1578 available". 1630 1579 1631 22-Sep-2004, G.Cosmo (geom-specific-V06-02-01 1580 22-Sep-2004, G.Cosmo (geom-specific-V06-02-01) 1632 - Added implementation of GetCubicVolume() wi 1581 - Added implementation of GetCubicVolume() with cashing mechanism for 1633 solids: G4EllipticalTube, G4Hype, G4Polyhed 1582 solids: G4EllipticalTube, G4Hype, G4Polyhedra, G4Polycone, G4TwistedTubs. 1634 1583 1635 01-Sep-2004, D.C.Williams (geom-specific-V06- 1584 01-Sep-2004, D.C.Williams (geom-specific-V06-02-00) 1636 - G4VCSGfaceted: fix for rare anomalous situa 1585 - G4VCSGfaceted: fix for rare anomalous situation in which 1637 DistanceToOut(p,v,..) will report kInfinity 1586 DistanceToOut(p,v,..) will report kInfinity, make an additional check 1638 for the point p on the surface, in which ca 1587 for the point p on the surface, in which case will report zero. 1639 Addresses problem observed in G4Polyhedra a 1588 Addresses problem observed in G4Polyhedra and reported in #650. 1640 1589 1641 07-Jun-2004, G.Cosmo (geom-specific-V06-01-04 1590 07-Jun-2004, G.Cosmo (geom-specific-V06-01-04) 1642 - Fixed compilation problem in G4TwistedSurfa 1591 - Fixed compilation problem in G4TwistedSurface.cc on WIN32-VC. 1643 1592 1644 28-May-2004, G.Cosmo (geom-specific-V06-01-03 1593 28-May-2004, G.Cosmo (geom-specific-V06-01-03) 1645 - Fixed archiving problem on WIN32-VC7: repla 1594 - Fixed archiving problem on WIN32-VC7: replaced structs with classes 1646 in G4VSurface. 1595 in G4VSurface. 1647 - Replaced misleading names for masks in G4VS 1596 - Replaced misleading names for masks in G4VSurface and moved inlined 1648 methods of nested classes to .cc. 1597 methods of nested classes to .cc. 1649 1598 1650 25-May-2004, G.Cosmo (geom-specific-V06-01-02 1599 25-May-2004, G.Cosmo (geom-specific-V06-01-02) 1651 - Fixed compilation problem on SUN-CC. Made E 1600 - Fixed compilation problem on SUN-CC. Made EValidate enum public in 1652 G4VSurface.hh. 1601 G4VSurface.hh. 1653 1602 1654 24-May-2004, G.Cosmo (geom-specific-V06-01-01 1603 24-May-2004, G.Cosmo (geom-specific-V06-01-01) 1655 - Removed compilation warnings and minor clea 1604 - Removed compilation warnings and minor cleanup... 1656 1605 1657 19-May-2004, O.Link (geom-specific-V06-01-00) 1606 19-May-2004, O.Link (geom-specific-V06-01-00) 1658 - First implementation of a framework for twi 1607 - First implementation of a framework for twisted surfaces, integrated from 1659 the original version of Kotoyo Hoshina (hos 1608 the original version of Kotoyo Hoshina (hoshina@hepburn.s.chiba-u.ac.jp) 1660 implemented in the 'Jupiter' application. 1609 implemented in the 'Jupiter' application. 1661 o Includes new specific twisted shape: G4Tw 1610 o Includes new specific twisted shape: G4TwistedTubs. 1662 o New classes: G4VSurface, G4TwistedSurface 1611 o New classes: G4VSurface, G4TwistedSurface, G4HyperbolicSurface, 1663 G4FlatSurface, G4TwistedTubs 1612 G4FlatSurface, G4TwistedTubs. 1664 o Cleanup of original code (debugging messa 1613 o Cleanup of original code (debugging messages, compiler errors, migration 1665 of g4std to new convention...) 1614 of g4std to new convention...) 1666 o New organisation of class G4TwistedTubs: 1615 o New organisation of class G4TwistedTubs: now independent of XXXSurface; 1667 removed backpointer 'fSolid' from XXXSurf 1616 removed backpointer 'fSolid' from XXXSurface to G4TwistedTubs. 1668 o New form of constructors in G4TwistedSurf 1617 o New form of constructors in G4TwistedSurface, G4HyperbolicSurface and 1669 G4FlatSurface. 1618 G4FlatSurface. 1670 o Change in G4TwistedSurface::DistanceToIn( 1619 o Change in G4TwistedSurface::DistanceToIn(p,v,...): roundoff correction. 1671 1620 1672 12-Jan-2004, G.Cosmo (geom-specific-V06-00-00 1621 12-Jan-2004, G.Cosmo (geom-specific-V06-00-00) 1673 - G4PolyhedraSide.cc: fixed bug in which part 1622 - G4PolyhedraSide.cc: fixed bug in which particles could "leak" out the 1674 center of a face if inner radius = 0. 1623 center of a face if inner radius = 0. 1675 Fixes problem report #547. (D.Williams) 1624 Fixes problem report #547. (D.Williams) 1676 1625 1677 22-Nov-2003, G.Cosmo (geom-specific-V05-02-07 1626 22-Nov-2003, G.Cosmo (geom-specific-V05-02-07) 1678 - Fixed upper bound for protection check intr 1627 - Fixed upper bound for protection check introduced in G4Polycone and 1679 G4Polyhedra constructors. 1628 G4Polyhedra constructors. 1680 1629 1681 17-Nov-2003, G.Cosmo (geom-specific-V05-02-06 1630 17-Nov-2003, G.Cosmo (geom-specific-V05-02-06) 1682 - Added protections in G4Polycone and G4Polyh 1631 - Added protections in G4Polycone and G4Polyhedra constructors for 1683 invalid constructs with no contiguous segme 1632 invalid constructs with no contiguous segments in Z planes as input. 1684 1633 1685 04-Nov-2003, G.Cosmo (geom-specific-V05-02-05 1634 04-Nov-2003, G.Cosmo (geom-specific-V05-02-05) 1686 - Added SetOriginalParameters() method to G4P 1635 - Added SetOriginalParameters() method to G4Polycone and G4Polyhedra. 1687 1636 1688 03-Nov-2003, G.Cosmo (geom-specific-V05-02-04 1637 03-Nov-2003, G.Cosmo (geom-specific-V05-02-04) 1689 - Code cleanup and headers inclusion review 1638 - Code cleanup and headers inclusion review 1690 (replaced by forward declarations where nec 1639 (replaced by forward declarations where necessary). 1691 1640 1692 28-Oct-2003, G.Cosmo (geom-specific-V05-02-03 1641 28-Oct-2003, G.Cosmo (geom-specific-V05-02-03) 1693 - Migrated to new G4Exception scheme. 1642 - Migrated to new G4Exception scheme. 1694 1643 1695 20-Oct-2003, G.Cosmo (geom-specific-V05-02-02 1644 20-Oct-2003, G.Cosmo (geom-specific-V05-02-02) 1696 - Added Reset() method in G4Polycone and G4Po 1645 - Added Reset() method in G4Polycone and G4Polyhedra to allow 1697 recalculation and reshape of the solid if n 1646 recalculation and reshape of the solid if new original_parameters 1698 are provided. 1647 are provided. 1699 1648 1700 30-Sep-2003, G.Cosmo (geom-specific-V05-02-01 1649 30-Sep-2003, G.Cosmo (geom-specific-V05-02-01) 1701 - Updated GNUmakefile for unit tests, accordi 1650 - Updated GNUmakefile for unit tests, according to new structure 1702 introduced in "geometry-V05-02-00". 1651 introduced in "geometry-V05-02-00". 1703 1652 1704 16-Jun-2003, G.Cosmo (geom-specific-V05-02-00 1653 16-Jun-2003, G.Cosmo (geom-specific-V05-02-00) 1705 - Added accessors to original_parameters for 1654 - Added accessors to original_parameters for G4Polycone and G4Polyhedra. 1706 Made G4PolyconeHistorical and G4PolyhedraHi 1655 Made G4PolyconeHistorical and G4PolyhedraHistorical classes in global 1707 scope (temporary solution). 1656 scope (temporary solution). 1708 1657 1709 28-Mar-2003, G.Cosmo (geom-specific-V05-00-00 1658 28-Mar-2003, G.Cosmo (geom-specific-V05-00-00) 1710 - Fixed initialisation of base class in copy 1659 - Fixed initialisation of base class in copy contructor for: 1711 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraS 1660 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraSide. 1712 - Fixed trivial pedantic warnings on G4Polyco 1661 - Fixed trivial pedantic warnings on G4Polycone and G4Polyhedra. 1713 1662 1714 30-Oct-2002, G.Cosmo (geom-specific-V04-01-01 1663 30-Oct-2002, G.Cosmo (geom-specific-V04-01-01) 1715 - Fixed un-initialised data members in constr 1664 - Fixed un-initialised data members in constructors of classes: 1716 G4ClippablePolygon, G4EnclosingCylinder, G4 1665 G4ClippablePolygon, G4EnclosingCylinder, G4PolyconeSide, 1717 G4ReduciblePolygon, G4VCSGfaceted. 1666 G4ReduciblePolygon, G4VCSGfaceted. 1718 1667 1719 28-Oct-2002, G.Cosmo (geom-specific-V04-01-00 1668 28-Oct-2002, G.Cosmo (geom-specific-V04-01-00) 1720 - Added implementation of StreamInfo() to com 1669 - Added implementation of StreamInfo() to comply with new interface for 1721 G4VSolid in "geommng-V04-01-03". 1670 G4VSolid in "geommng-V04-01-03". 1722 - Created .icc files for G4EllipticalTube, G4 1671 - Created .icc files for G4EllipticalTube, G4Polyhedra and G4Polycone. 1723 - Some cosmetic changes to code formatting: r 1672 - Some cosmetic changes to code formatting: removed <TAB> characters and adopt 1724 uniform code indentation. 1673 uniform code indentation. 1725 1674 1726 08-May-2002, J.Allison (geom-solids-specific- 1675 08-May-2002, J.Allison (geom-solids-specific-V04-00-01) 1727 - Implemented G4EllipticalTube::CreatePolyhed 1676 - Implemented G4EllipticalTube::CreatePolyhedron. 1728 1677 1729 10-Jan-2002, G.Cosmo (geom-solids-specific-V0 1678 10-Jan-2002, G.Cosmo (geom-solids-specific-V04-00-00) 1730 - Updated unit tests. 1679 - Updated unit tests. 1731 1680 1732 20-Apr-2001, G.Cosmo (geom-solids-specific-V0 1681 20-Apr-2001, G.Cosmo (geom-solids-specific-V03-01-00) 1733 - Migration to STL vector: 1682 - Migration to STL vector: 1734 o In G4ClippablePolygon, migrated G4ThreeVe 1683 o In G4ClippablePolygon, migrated G4ThreeVectorList typedef and 1735 made private to class. 1684 made private to class. 1736 1685 1737 03-Apr-2001, D.Williams (geom-solids-specifi 1686 03-Apr-2001, D.Williams (geom-solids-specific-V03-00-01) 1738 ----------------------- 1687 ----------------------- 1739 - G4IntersectingCone.cc: make small adjustmen 1688 - G4IntersectingCone.cc: make small adjustment to help with roundoff error 1740 in LineHitsCone1() and LineHitsCone2(). 1689 in LineHitsCone1() and LineHitsCone2(). 1741 1690 1742 08-Jan-2001, D.Williams (geom-solids-specifi 1691 08-Jan-2001, D.Williams (geom-solids-specific-V03-00-00) 1743 ----------------------- 1692 ----------------------- 1744 - G4Hype.cc: Added protecton against zero v.z 1693 - G4Hype.cc: Added protecton against zero v.z in DistanceToOut. 1745 1694 1746 20-Nov-2000, G.Cosmo (geom-solids-specifi 1695 20-Nov-2000, G.Cosmo (geom-solids-specific-V02-00-04) 1747 --------------------- 1696 --------------------- 1748 - Fixes to remove warnings from "-Wall -ansi 1697 - Fixes to remove warnings from "-Wall -ansi -pedantic" g++ compiler options: 1749 o commented out variables declared and not 1698 o commented out variables declared and not used. 1750 o fixed declaration of variables used befor 1699 o fixed declaration of variables used before being initialised. 1751 o fixed order of initialisation of member d 1700 o fixed order of initialisation of member data in constructors. 1752 o fixed usage of unsigned-int (size_t) for 1701 o fixed usage of unsigned-int (size_t) for array indeces. 1753 1702 1754 13-Nov-2000, G.Cosmo (geom-solids-specifi 1703 13-Nov-2000, G.Cosmo (geom-solids-specific-V02-00-03) 1755 -------------------- 1704 -------------------- 1756 - Added definition of empty constructor for G 1705 - Added definition of empty constructor for G4ClippablePolygon which 1757 went lost by mistake... 1706 went lost by mistake... 1758 1707 1759 02-Nov-2000, G.Cosmo (geom-solids-specifi 1708 02-Nov-2000, G.Cosmo (geom-solids-specific-V02-00-02) 1760 -------------------- 1709 -------------------- 1761 - QA code revision and cleanup (+fixes from C 1710 - QA code revision and cleanup (+fixes from CodeWizard filtering): 1762 o Avoid inline virtual methods. 1711 o Avoid inline virtual methods. 1763 o General cosmetics for Software Reference 1712 o General cosmetics for Software Reference Manual. 1764 1713 1765 23-Oct-2000, D.Williams (geom-solids-specifi 1714 23-Oct-2000, D.Williams (geom-solids-specific-V02-00-01) 1766 ----------------------- 1715 ----------------------- 1767 - G4IntersectingCone.cc: the check for a zero 1716 - G4IntersectingCone.cc: the check for a zero radical has been adjusted to be 1768 less sensitive to round off error in LineHi 1717 less sensitive to round off error in LineHitsCone1(), LineHitsCone2(). 1769 This fixes a problem discovered in BaBar. 1718 This fixes a problem discovered in BaBar. 1770 1719 1771 12-Sep-2000, G.Cosmo (geom-solids-specific-V 1720 12-Sep-2000, G.Cosmo (geom-solids-specific-V02-00-00) 1772 -------------------- 1721 -------------------- 1773 - Organised comments to headers for Software 1722 - Organised comments to headers for Software Reference Manual. 1774 1723 1775 27-Jun-2000, G.Cosmo (geom-solids-specific-V 1724 27-Jun-2000, G.Cosmo (geom-solids-specific-V01-01-02) 1776 -------------------- 1725 -------------------- 1777 - G4Polycone[.hh.cc]: better fix for bug-repo 1726 - G4Polycone[.hh.cc]: better fix for bug-report #110. 1778 Removed struct and replaced with class. 1727 Removed struct and replaced with class. 1779 1728 1780 26-Jun-2000, G.Cosmo (geom-solids-specific-V 1729 26-Jun-2000, G.Cosmo (geom-solids-specific-V01-01-01) 1781 -------------------- 1730 -------------------- 1782 - G4Polycone.cc: fixed memory leak by invokin 1731 - G4Polycone.cc: fixed memory leak by invoking destruction of member 1783 enclosingCylinder, which was not cleaned up 1732 enclosingCylinder, which was not cleaned up in the destructor. 1784 This fixes problem report #107. 1733 This fixes problem report #107. 1785 - G4Polycone.hh: added forward declaration of 1734 - G4Polycone.hh: added forward declaration of struct G4PolyconeHistorical 1786 and made it friend, for porting on KCC --st 1735 and made it friend, for porting on KCC --strict. This fixes report #110. 1787 - G4Polyhedra.hh: fixed typo in method name. 1736 - G4Polyhedra.hh: fixed typo in method name. Changed GetNumSIde() to 1788 GetNumSide(). This fixes problem report #10 1737 GetNumSide(). This fixes problem report #105. 1789 1738 1790 08-Jun-2000, G.Gracia 1739 08-Jun-2000, G.Gracia 1791 --------------------- 1740 --------------------- 1792 - G4VCSGfaceted.cc: fix for Win/NT in functio 1741 - G4VCSGfaceted.cc: fix for Win/NT in function GetExtent(). 1793 1742 1794 27-Apr-2000, G.Cosmo 1743 27-Apr-2000, G.Cosmo 1795 -------------------- 1744 -------------------- 1796 - Removed dependency over the CSG domain in G 1745 - Removed dependency over the CSG domain in GNUmakefile. 1797 1746 1798 18-Apr-2000, D.Williams 1747 18-Apr-2000, D.Williams 1799 ----------------------- 1748 ----------------------- 1800 - Removed meaningless "const" specifiers from 1749 - Removed meaningless "const" specifiers from methods in G4ClippablePolygon, 1801 and G4EllipticalTube. 1750 and G4EllipticalTube. 1802 - G4EllipticalTube, G4Hype and G4VCSGfaceted 1751 - G4EllipticalTube, G4Hype and G4VCSGfaceted now inherit directly 1803 from G4VSolid (before was G4CSGSolid). 1752 from G4VSolid (before was G4CSGSolid). 1804 - Reintroduced GetExtent() in G4EllipticalTub 1753 - Reintroduced GetExtent() in G4EllipticalTube, G4Hype and G4VCSGfaceted 1805 (in principle, not needed). 1754 (in principle, not needed). 1806 - Modified assertations in unit test testG4Hy 1755 - Modified assertations in unit test testG4Hype.cc. 1807 1756 1808 11-Apr-2000, J.Allison 1757 11-Apr-2000, J.Allison 1809 ---------------------- 1758 ---------------------- 1810 - Removed implementations of GetExtent in mos 1759 - Removed implementations of GetExtent in most sub-classes of G4VSolid (a 1811 default implementation exists in G4VSolid). 1760 default implementation exists in G4VSolid). 1812 - All implementations of DescribeYourselfTo ( 1761 - All implementations of DescribeYourselfTo (G4VGraphicsScene& scene) const 1813 now correctly written: scene.AddThis(*this) 1762 now correctly written: scene.AddThis(*this). 1814 1763 1815 05-Apr-2000, G.Cosmo (geom-solids-specific- 1764 05-Apr-2000, G.Cosmo (geom-solids-specific-V01-01-00) 1816 -------------------- 1765 -------------------- 1817 - Restructured solids/CSG domain, by moving t 1766 - Restructured solids/CSG domain, by moving to "specific" the following 1818 classes: G4ClippablePolygon, G4EnclosingCyl 1767 classes: G4ClippablePolygon, G4EnclosingCylinder, G4Hype, G4PolyPhiFace, 1819 G4Polycone, G4PolyconeSide, G4Polyhedra, G4 1768 G4Polycone, G4PolyconeSide, G4Polyhedra, G4PolyhedraSide, G4ReduciblePolygon, 1820 G4IntersectingCone, G4SolidExtentList, G4VC 1769 G4IntersectingCone, G4SolidExtentList, G4VCSGface, G4VCSGfaceted. 1821 The new module's library for "specific" is 1770 The new module's library for "specific" is now called 'G4specsolids'. 1822 - Created specific/test directory and moved t 1771 - Created specific/test directory and moved testG4Hype.cc and testG4Polycone,cc 1823 from CSG/test. 1772 from CSG/test. 1824 - Organised class description comments for th 1773 - Organised class description comments for the Software Reference Manual 1825 and added CVS headers to files. 1774 and added CVS headers to files. 1826 1775 1827 29-Mar-2000, D.Williams 1776 29-Mar-2000, D.Williams 1828 ----------------------- 1777 ----------------------- 1829 - Added first implementation of G4EllipticalT 1778 - Added first implementation of G4EllipticalTube. 1830 It defines a simple elliptical tube, as in 1779 It defines a simple elliptical tube, as in geant3 "ELTU". 1831 Files introduced: G4EllipticalTube[.hh.cc]. 1780 Files introduced: G4EllipticalTube[.hh.cc]. 1832 1781 1833 25-Mar-2000, G.Cosmo 1782 25-Mar-2000, G.Cosmo 1834 -------------------- 1783 -------------------- 1835 - History file created. 1784 - History file created.