| Geant4 Cross Reference |
1 # Category geom-specific History << 1 -------------------------------------------------------------------
2 2
3 See `CONTRIBUTING.rst` for details of **requir << 3 =========================================================
4 which **must** added in reverse chronological << 4 Geant4 - an Object-Oriented Toolkit for Simulation in HEP
5 It must **not** be used as a substitute for wr << 5 =========================================================
6 << 6
7 ---------------------------------------------- << 7 Sub-Category History file
8 << 8 -------------------------
9 ## 2024-10-01 Evgueni Tcherniaev (geom-specifi << 9 This file should be used by G4 developers and category coordinators
10 - G4GenericTrap: Fixed minor defect reported b << 10 to briefly summarize all major modifications introduced in the code
11 << 11 and keep track of all directory-tags.
12 ## 2024-07-18 Alvaro Tolosa-Delgado (geom-spec << 12 It DOES NOT substitute the log-message one should put at every
13 - Remove internal state of G4TwistedTubs and G << 13 committal in the source repository !
14 << 14
15 ## 2024-07-10 Evgueni Tcherniaev (geom-specifi << 15 ----------------------------------------------------------
16 - G4ExtrudedSolid: Fixed defects reported by C << 16 * Reverse chronological order (last date on top), please *
17 << 17 ----------------------------------------------------------
18 ## 2024-07-08 Gabriele Cosmo (geom-specific-V1 <<
19 - Fixed reported Coverity defect; in G4Voxeliz <<
20 plain vector copy in methods BuildReduceVoxe <<
21 BuildBoundaries() and CreateMiniVoxels(..). <<
22 <<
23 ## 2024-05-29 Evgueni Tcherniaev (geom-specifi <<
24 - Added new methods GetNumOfConstituents() and <<
25 <<
26 ## 2024-05-27 Evgueni Tcherniaev (geom-specifi <<
27 - Completely revised G4GeneriTrap, it addresse <<
28 <<
29 ## 2024-05-26 Evgueni Tcherniaev (geom-specifi <<
30 - New testG4GenericTrap.cc <<
31 <<
32 ## 2024-04-02 Gabriele Cosmo (geom-specific-V1 <<
33 - Applied trivial clang-tidy fixes to classes, <<
34 'default' keywords. <<
35 <<
36 ## 2024-02-01 Gabriele Cosmo (geom-specific-V1 <<
37 - Use std::size_t for array sizes in G4Polyhed <<
38 <<
39 ## 2023-07-10 Evgueni Tcherniaev (geom-specifi <<
40 - Fixed bounding box calculation in G4VTwisted <<
41 <<
42 ## 2023-06-16 Stephan Hageboeck (geom-specific <<
43 - Fix an uninitialised value in G4VCSGfaceted: <<
44 <<
45 ## 2023-06-12 Gabriele Cosmo (geom-specific-V1 <<
46 - Use const iterator in G4Voxelizer::GetPointV <<
47 - Fixed use of index in G4Tet::GetPointOnSurfa <<
48 <<
49 ## 2023-05-10 Gabriele Cosmo (geom-specific-V1 <<
50 - Applied clang-tidy fixes (readability, moder <<
51 <<
52 ## 2023-03-20 Gabriele Cosmo (geom-specific-V1 <<
53 - Fixed more potential uninitialised values in <<
54 G4SolidExtentList and G4VTwistSurface. <<
55 <<
56 ## 2023-03-13 Gabriele Cosmo (geom-specific-V1 <<
57 - Fixed potential uninitialised value for boun <<
58 G4VTwistSurface::GetBoundaryAtPZ(). <<
59 <<
60 ## 2023-01-02 Evgueni Tcherniaev (geom-specifi <<
61 - G4QuadrangularFacet: Fixed warning message <<
62 <<
63 ## 2022-11-10 Gabriele Cosmo (geom-specific-V1 <<
64 - Fixed compilation warnings for implicit type <<
65 <<
66 ## 2022-10-05 Gabriele Cosmo (geom-specific-V1 <<
67 - Fixed compilation warnings in Intel/icx comp <<
68 but never used. <<
69 <<
70 ## 2022-04-03 Evgueni Tcherniaev (geom-specifi <<
71 - G4GenericTrap.cc, G4UGenericTrap.cc, G4UExtr <<
72 G4TessellatedSolid.cc, G4TessellatedSolid.cc <<
73 revision of CreatePolyhedron() <<
74 <<
75 ## 2022-02-04 Evgueni Tcherniaev (geom-specifi <<
76 - G4VTwistedFaceted: used numerical evaluation <<
77 integral to calculate lateral face surface a <<
78 <<
79 ## 2022-02-01 Evgueni Tcherniaev (geom-specifi <<
80 - G4ExtrudedSolid, G4UExtrudedSolid: added def <<
81 parameters in the constructor with two z-sec <<
82 - G4ExtrudedSolid::ZSection, G4UExtrudedSolid: <<
83 added default constructor <<
84 <<
85 ## 2022-01-26 Evgueni Tcherniaev (geom-specifi <<
86 - G4GenericTrap::GetCubicVolume(): calculation <<
87 using analytical expression; removed private <<
88 GetFaceCubicVolume(); <<
89 - G4GenericTrap::GetSurfaceArea(): improved ca <<
90 of the area of lateral faces; private functi <<
91 GetFaceSurfaceArea(), GetTwistedFaceSurfaceA <<
92 replaced with private function GetLateralFac <<
93 <<
94 ## 2022-01-21 Evgueni Tcherniaev (geom-specifi <<
95 - G4Ellipsoid::LateralSurfaceArea(): Enhanced <<
96 the lateral surface area <<
97 <<
98 ## 2022-01-11 Evgueni Tcherniaev (geom-specifi <<
99 - G4VTwistedFaceted: fCubicVolume, fSurfaceAre <<
100 GetCubicVolume(), GetSurfaceArea() moved to <<
101 - G4VTwistedFaceted, G4TwistedBox, G4TwistedTr <<
102 calculation of volume and surface area <<
103 <<
104 ## 2022-01-06 Evgueni Tcherniaev (geom-specifi <<
105 - G4TwistedTubs: Implemented GetSurfaceArea() <<
106 analytical expressions; added private functi <<
107 GetLateralArea() and GetPhiCutArea() <<
108 <<
109 ## 2021-12-19 Evgueni Tcherniaev (geom-specifi <<
110 - G4Hype: Used analytical expression in GetCub <<
111 and GetSurfaceArea() <<
112 <<
113 ## 2021-12-10 Ben Morgan (geom-specific-V11-00 <<
114 - Change to new Markdown History format <<
115 <<
116 --- <<
117 <<
118 # History entries prior to 11.0 <<
119 <<
120 03-December-2021 E.Tcherniaev (geom-speci <<
121 - G4TwistedTubs: Accurate calculation of the b <<
122 BoundingLimits() and GetExtent(), fixing mea <<
123 penalty. Addressing problem report #2450. <<
124 - G4TwistedTubs, G4VTwistedFaceted: Fixed GetC <<
125 <<
126 15-October-2021 E.Tcherniaev (geom-speci <<
127 - G4Tet, G4UTet: Added SetBoundingLimits() <<
128 <<
129 06-October-2021 E.Tcherniaev (geom-speci <<
130 - G4Tet: some changes in calculation of boundi <<
131 - G4UTet: added CheckDegeneracy() and SetVerti <<
132 <<
133 27-September-2021 E.Tcherniaev (geom-speci <<
134 - Added degeneracyFlag to the list of paramete <<
135 it addresses first part of the problem repor <<
136 <<
137 24-September-2021 E.Tcherniaev (geom-speci <<
138 - Implemented G4TesselatedSolid::GetFacetIndex <<
139 <<
140 10-September-2021 E.Tcherniaev (geom-speci <<
141 - Implemented G4TesselatedSolid::CheckStructur <<
142 - Optimisation in G4TessellatedSolid::SetExtre <<
143 shuffle of vertices and checking of six extr <<
144 <<
145 21-July-2021 E.Tcherniaev (geom-speci <<
146 - More accurate calculation of distance from p <<
147 in G4TriangularFacet, it addresses problem r <<
148 <<
149 25-June-2021 G.Cosmo (geom-speci <<
150 - Added missing accessor in G4UTet. <<
151 <<
152 12-May-2021 E.Tcherniaev (geom-speci <<
153 - Reimplemented CreatePolyhedron() in <<
154 G4Polyhedra, G4Polycone, G4GenericPolycone, <<
155 G4UPolyhedra, G4UPolycone, G4UGenericPolycon <<
156 <<
157 30-April-2021 G.Cosmo (geom-speci <<
158 - Fixed use of conversion factor in G4UPolyhed <<
159 polyhedra constructs. <<
160 <<
161 19-April-2021 E.Tcherniaev (geom-speci <<
162 - G4Polyhedra, G4Polycone: Fix calculation of <<
163 of negative phiStart, it addresses also prob <<
164 <<
165 30-March-2021 B.Morgan (geom-speci <<
166 - Migrate sources.cmake to modular build API <<
167 <<
168 18-March-2021 E.Tcherniaev (geom-speci <<
169 - Fix calculation of bounding box position in <<
170 it addresses problem report #2301 <<
171 <<
172 13-January-2021 G.Cosmo (geom-speci <<
173 - Reduce cases of bad speculation in G4Polyhed <<
174 G4PolyPhiFace::InsideEdges(), based on repor <<
175 by G.Amadio. <<
176 18
177 30-October-2020 E.Tcherniaev (geom-speci 19 30-October-2020 E.Tcherniaev (geom-specific-V10-06-10)
178 - G4Polycone: Revised GetPointOnSurface(); 20 - G4Polycone: Revised GetPointOnSurface();
179 Added protected auxiliary method SetSurfaceE 21 Added protected auxiliary method SetSurfaceElements();
180 Removed GetPointOnCone(), GetPointOnTubs(), 22 Removed GetPointOnCone(), GetPointOnTubs(), GetPointOnCut(), GetPointOnRing();
181 - G4GenericPolycone: Revised GetPointOnSurface 23 - G4GenericPolycone: Revised GetPointOnSurface();
182 Added protected auxiliary method SetSurfaceE 24 Added protected auxiliary method SetSurfaceElements();
183 - G4Polyhedra: Revised GetPointOnSurface(); 25 - G4Polyhedra: Revised GetPointOnSurface();
184 Added protected auxiliary method SetSurfaceE 26 Added protected auxiliary method SetSurfaceElements();
185 Removed GetPointOnPlane(), GetPointOnTriangl 27 Removed GetPointOnPlane(), GetPointOnTriangle();
186 28
187 01-October-2020 E.Tcherniaev (geom-speci 29 01-October-2020 E.Tcherniaev (geom-specific-V10-06-09)
188 - G4Polycone, G4GenericPolycone, G4Polyhedra: 30 - G4Polycone, G4GenericPolycone, G4Polyhedra:
189 implemented GetSurfaceArea(), GetCubicVolume 31 implemented GetSurfaceArea(), GetCubicVolume().
190 32
191 May 21, 2020 Guilherme Lima (geom-speci 33 May 21, 2020 Guilherme Lima (geom-specific-V10-06-08)
192 ---------------------------- 34 ----------------------------
193 - Fix constructor signatures in G4UExtrudedSol 35 - Fix constructor signatures in G4UExtrudedSolid wrappers, to match those in G4 version.
194 There were missing const and reference quali 36 There were missing const and reference qualifiers in non-POD parameters.
195 37
196 30-April-2020 G.Cosmo (geom-speci 38 30-April-2020 G.Cosmo (geom-specific-V10-06-07)
197 - Adopt new convention for location of headers 39 - Adopt new convention for location of headers in VecGeom for all wrappers.
198 40
199 09-April-2020 E.Tcherniaev (geom-speci 41 09-April-2020 E.Tcherniaev (geom-specific-V10-06-06)
200 - Added G4GenericTrap::GetTwistedFaceSurfaceAr 42 - Added G4GenericTrap::GetTwistedFaceSurfaceArea().
201 - testG4GenericTrap.cc: fixed test for calcula 43 - testG4GenericTrap.cc: fixed test for calculation of surface area.
202 - testG4ExtrudedSolid.cc: fixed assert stateme 44 - testG4ExtrudedSolid.cc: fixed assert statements for cases where
203 point flys along the surface (DistanceToIn() 45 point flys along the surface (DistanceToIn() returns kInfinity).
204 46
205 17-January-2020 E.Tcherniaev (geom-speci 47 17-January-2020 E.Tcherniaev (geom-specific-V10-06-05)
206 - Implemented G4Tet::SetVertices(), it address 48 - Implemented G4Tet::SetVertices(), it addresses request made
207 at Geant4 Technical Forum. 49 at Geant4 Technical Forum.
208 50
209 14-January-2020 Gabriele Cosmo (geom-speci 51 14-January-2020 Gabriele Cosmo (geom-specific-V10-06-04)
210 - Added protection in G4VFacet header for doub 52 - Added protection in G4VFacet header for double definition of global
211 symbols from Windows Kits code. 53 symbols from Windows Kits code.
212 54
213 08-January-2020 E.Tcherniaev (geom-speci 55 08-January-2020 E.Tcherniaev (geom-specific-V10-06-03)
214 - Complete revision of G4Tet, speed up, new te 56 - Complete revision of G4Tet, speed up, new testG4Tet.cc.
215 It also fixes issues spotted by new unit tes 57 It also fixes issues spotted by new unit test.
216 58
217 16-December-2019 E.Tcherniaev (geom-speci 59 16-December-2019 E.Tcherniaev (geom-specific-V10-06-02)
218 - Complete revision of G4Ellipsoid, it fixes i 60 - Complete revision of G4Ellipsoid, it fixes issues with former
219 implementation, in particular it addresses p 61 implementation, in particular it addresses problem report #2206.
220 30%-70% speed-up in all main methods. << 62 30%-70% speed-up in all main methods.
221 63
222 11-December-2019 B.Morgan (geom-speci 64 11-December-2019 B.Morgan (geom-specific-V10-06-01)
223 - Cleanup CMake build, removing obsolete granu 65 - Cleanup CMake build, removing obsolete granular library options and
224 explicit include_directories. 66 explicit include_directories.
225 67
226 10-December-2019 G.Cosmo (geom-speci 68 10-December-2019 G.Cosmo (geom-specific-V10-06-00)
227 - Re-established parameterisation mechanism fo 69 - Re-established parameterisation mechanism for G4Tet and G4UTet which was
228 removed by mistake. Addressing problem repor 70 removed by mistake. Addressing problem report #2209.
229 71
230 26-November-2019 G.Cosmo (geom-speci 72 26-November-2019 G.Cosmo (geom-specific-V10-05-21)
231 - Fixed cases of implicit type conversions fro 73 - Fixed cases of implicit type conversions from size_t to G4int.
232 74
233 05-November-2019 E.Tcherniaev (geom-speci 75 05-November-2019 E.Tcherniaev (geom-specific-V10-05-20)
234 - G4TesselatedSolid.cc: fixed minor Coverity d 76 - G4TesselatedSolid.cc: fixed minor Coverity defect (uninitialized array)
235 77
236 07-October-2019 E.Tcherniaev (geom-speci 78 07-October-2019 E.Tcherniaev (geom-specific-V10-05-19)
237 - G4TesselatedSolid.cc: fixed minor Coverity d 79 - G4TesselatedSolid.cc: fixed minor Coverity defect
238 80
239 16-September-2019 G.Cosmo (geom-speci 81 16-September-2019 G.Cosmo (geom-specific-V10-05-18)
240 - Rationalise header inclusions for faceted so 82 - Rationalise header inclusions for faceted solids.
241 83
242 06-September-2019 G.Cosmo (geom-speci 84 06-September-2019 G.Cosmo (geom-specific-V10-05-17)
243 - Removed unnecessary forward declaration in G 85 - Removed unnecessary forward declaration in G4VFacet header.
244 86
245 29-August-2019 G.Cosmo (geom-speci 87 29-August-2019 G.Cosmo (geom-specific-V10-05-16)
246 - Minor c++11 revision and headers cleanup. Co 88 - Minor c++11 revision and headers cleanup. Code formatting.
247 - Use pre-increment wherever possible. 89 - Use pre-increment wherever possible.
248 90
249 19-August-2019 G.Lima (geom-speci 91 19-August-2019 G.Lima (geom-specific-V10-05-15)
250 - G4ExtrudedSolid: fixed a bug in DistanceToOu 92 - G4ExtrudedSolid: fixed a bug in DistanceToOut(), affecting extruded solids
251 defined off-center along the z-axis. 93 defined off-center along the z-axis.
252 94
253 19-August-2019 G.Cosmo (geom-speci 95 19-August-2019 G.Cosmo (geom-specific-V10-05-14)
254 - G4GenericTrap: fixed compilation warnings fo 96 - G4GenericTrap: fixed compilation warnings for variable shadowing on clang-8.
255 97
256 13-August-2019 G.Cosmo (geom-speci 98 13-August-2019 G.Cosmo (geom-specific-V10-05-13)
257 - Enabled wrappers for VecGeom implementation 99 - Enabled wrappers for VecGeom implementation of G4EllipticalTube,
258 G4EllipticalCone and G4Ellipsoid. 100 G4EllipticalCone and G4Ellipsoid.
259 101
260 10-July-2019 E.Tcherniaev (geom-speci 102 10-July-2019 E.Tcherniaev (geom-specific-V10-05-12)
261 - Fixed G4UExtrudedSolid::CreatePolyhedron(). 103 - Fixed G4UExtrudedSolid::CreatePolyhedron().
262 Addressing visualization part of the problem 104 Addressing visualization part of the problem report #2171.
263 105
264 04-July-2019 G.Cosmo (geom-speci 106 04-July-2019 G.Cosmo (geom-specific-V10-05-11)
265 - Avoid defining kCarTolerance as 'static cons 107 - Avoid defining kCarTolerance as 'static const' in G4VFacet.
266 Addressing problem report #2172. 108 Addressing problem report #2172.
267 109
268 11-June-2019 E.Tcherniaev (geom-speci 110 11-June-2019 E.Tcherniaev (geom-specific-V10-05-10)
269 - Use GetVertices() instead of GetParametersLi 111 - Use GetVertices() instead of GetParametersList() in the wrapper G4UTet.
270 112
271 29-May-2019 G.Cosmo (geom-speci 113 29-May-2019 G.Cosmo (geom-specific-V10-05-09)
272 - Fixed minor Coverity defects. 114 - Fixed minor Coverity defects.
273 115
274 20-May-2019 G.Cosmo (geom-speci 116 20-May-2019 G.Cosmo (geom-specific-V10-05-08)
275 - Defined move constructor and move assignment 117 - Defined move constructor and move assignment operator for G4TriangularFacet.
276 118
277 14-May-2019 B.Morgan (geom-speci 119 14-May-2019 B.Morgan (geom-specific-V10-05-07)
278 - Add inclusion of new G4GeomTypes.hh header t 120 - Add inclusion of new G4GeomTypes.hh header to those headers allowing
279 VecGeom replacement. 121 VecGeom replacement.
280 - See also geommng-10-05-05 122 - See also geommng-10-05-05
281 123
282 23-April-2019 G.Cosmo (geom-speci 124 23-April-2019 G.Cosmo (geom-specific-V10-05-06)
283 - Modified G4PolyconeSide and G4PolyhedraSide 125 - Modified G4PolyconeSide and G4PolyhedraSide to use only trivial types for
284 MT splitted data in G4PlSideData and G4PhSid 126 MT splitted data in G4PlSideData and G4PhSideData respectively.
285 127
286 16-April-2019 G.Cosmo (geom-speci 128 16-April-2019 G.Cosmo (geom-specific-V10-05-05)
287 - Protected check in G4TwistTubsSide::Distance 129 - Protected check in G4TwistTubsSide::DistanceToPlane() withing debug flag.
288 130
289 4-April-2019 G.Cosmo (geom-speci 131 4-April-2019 G.Cosmo (geom-specific-V10-05-04)
290 - Enabled wrapper for VecGeom implementation o 132 - Enabled wrapper for VecGeom implementation of G4GenericPolycone.
291 133
292 15-February-2019 E.Tcherniaev (geom-speci 134 15-February-2019 E.Tcherniaev (geom-specific-V10-05-03)
293 - Accurate calculation of radical in G4Interse 135 - Accurate calculation of radical in G4IntersectingCone.
294 It addresses the problem report #2111. 136 It addresses the problem report #2111.
295 137
296 4-February-2019 G.Cosmo (geom-speci 138 4-February-2019 G.Cosmo (geom-specific-V10-05-02)
297 - Fix in G4EllipticalTube::CheckParameters() f 139 - Fix in G4EllipticalTube::CheckParameters() for typo in condition.
298 140
299 30-January-2019 G.Cosmo (geom-speci 141 30-January-2019 G.Cosmo (geom-specific-V10-05-01)
300 - Disabled precise computation of extent and u 142 - Disabled precise computation of extent and use simple bounding-box
301 in CalculateExtent() for G4Tet and G4Tessell 143 in CalculateExtent() for G4Tet and G4TessellatedSolid, to speed up
302 intialisation in setups with relatively comp 144 intialisation in setups with relatively complex meshes.
303 - Apply bounding-box calculation for extent al 145 - Apply bounding-box calculation for extent also for corresponding
304 VecGeom wrappers. 146 VecGeom wrappers.
305 147
306 24-January-2019 E.Tcherniaev (geom-speci 148 24-January-2019 E.Tcherniaev (geom-specific-V10-05-00)
307 - Completely revised, more robust and performa 149 - Completely revised, more robust and performant G4EllipticalTube;
308 new exhaustive test/testEllipticalTube.cc ba 150 new exhaustive test/testEllipticalTube.cc based on Shape Conventions.
309 151
310 20-September-2018 G.Cosmo (geom-speci 152 20-September-2018 G.Cosmo (geom-specific-V10-04-15)
311 - Make G4UPolycone wrapper inheriting from vec 153 - Make G4UPolycone wrapper inheriting from vecgeom::GenericUnplacedPolycone,
312 following the latest changes in VecGeom. 154 following the latest changes in VecGeom.
313 155
314 13-September-2018 G.Cosmo (geom-speci 156 13-September-2018 G.Cosmo (geom-specific-V10-04-14)
315 - G4UTessellatedSolid, G4UExtrudedSolid: remov 157 - G4UTessellatedSolid, G4UExtrudedSolid: removed leftover use of
316 UVector3 and replaced with U3Vector. 158 UVector3 and replaced with U3Vector.
317 159
318 23-August-2018 G.Cosmo (geom-speci 160 23-August-2018 G.Cosmo (geom-specific-V10-04-13)
319 - Enabled VecGeom wrapper for G4Tet. 161 - Enabled VecGeom wrapper for G4Tet.
320 162
321 10-August-2018 A.Gheata (geom-speci 163 10-August-2018 A.Gheata (geom-specific-V10-04-12)
322 - Make G4UHype wrapper inheriting from vecgeom 164 - Make G4UHype wrapper inheriting from vecgeom::GenericUnplacedHype,
323 following the latest changes in VecGeom. 165 following the latest changes in VecGeom.
324 166
325 12-July-2018 G.Cosmo (geom-speci 167 12-July-2018 G.Cosmo (geom-specific-V10-04-11)
326 - Removed G4SolidsWorkspacePool class. Adapted 168 - Removed G4SolidsWorkspacePool class. Adapted G4SolidsWorkspace to
327 use templated class G4TWorkspacePool. 169 use templated class G4TWorkspacePool.
328 - Coworks with tags in geometry/volumes, run a 170 - Coworks with tags in geometry/volumes, run and visualization/management.
329 171
330 25-Jun-2018 G.Cosmo (geom-speci 172 25-Jun-2018 G.Cosmo (geom-specific-V10-04-10)
331 - Use dynamic_cast to attempt fix for spurious 173 - Use dynamic_cast to attempt fix for spurious compilation warnings on
332 CentOS7/gcc-5.3 on G4UTessellatedSolid wrapp 174 CentOS7/gcc-5.3 on G4UTessellatedSolid wrapper.
333 175
334 17-May-2018 J.Madsen (geom-speci 176 17-May-2018 J.Madsen (geom-specific-V10-04-09)
335 - Updated "thread-local-static-var" model to 177 - Updated "thread-local-static-var" model to
336 "function-returning-thread-local-static-refe 178 "function-returning-thread-local-static-reference" model
337 which fixes Windows DLL + MT 179 which fixes Windows DLL + MT
338 180
339 11-April-2018 G.Cosmo (geom-speci 181 11-April-2018 G.Cosmo (geom-specific-V10-04-08)
340 - Replaced USOLIDS_LIBRARIES with VECGEOM_LIBR 182 - Replaced USOLIDS_LIBRARIES with VECGEOM_LIBRARIES in sources.cmake.
341 183
342 13-February-2018 E.Tcherniaev (geom-speci 184 13-February-2018 E.Tcherniaev (geom-specific-V10-04-07)
343 - Corrected conversion of input parameters to 185 - Corrected conversion of input parameters to internal structure (used for
344 caching for adoption in GDML persistency) in 186 caching for adoption in GDML persistency) in G4UPolycone and G4UPolyhedra
345 wrappers. 187 wrappers.
346 188
347 9-February-2018 G.Cosmo (geom-speci 189 9-February-2018 G.Cosmo (geom-specific-V10-04-06)
348 - Caching facets and vertices in G4UTessellate 190 - Caching facets and vertices in G4UTessellatedSolid wrapper for properly
349 treating indexing in facets. 191 treating indexing in facets.
350 192
351 31-January-2018 G.Cosmo (geom-speci 193 31-January-2018 G.Cosmo (geom-specific-V10-04-05)
352 - Corrected use of facets indeces in G4UTessel 194 - Corrected use of facets indeces in G4UTessellatedSolid for visualization.
353 - Minor cleanup in G4TessellatedSolid::CreateP 195 - Minor cleanup in G4TessellatedSolid::CreatePolyhedron(), no functional
354 changes. 196 changes.
355 197
356 15-January-2018 G.Cosmo (geom-speci 198 15-January-2018 G.Cosmo (geom-specific-V10-04-04)
357 - Added validity checks in G4UTessellatedSolid 199 - Added validity checks in G4UTessellatedSolid::AddFacet().
358 200
359 11-January-2018 G.Cosmo (geom-speci 201 11-January-2018 G.Cosmo (geom-specific-V10-04-03)
360 - Added and enabled VecGeom wrapper for G4Tess 202 - Added and enabled VecGeom wrapper for G4TessellatedSolid.
361 Requires tags cmake-V10-04-01 and config-V10 203 Requires tags cmake-V10-04-01 and config-V10-04-00.
362 204
363 20-December-2017 G.Cosmo (geom-speci 205 20-December-2017 G.Cosmo (geom-specific-V10-04-02)
364 - Enabled VecGeom wrappers for G4ExtrudedSolid 206 - Enabled VecGeom wrappers for G4ExtrudedSolid and G4Hype.
365 207
366 13-December-2017 E.Tcherniaev (geom-speci 208 13-December-2017 E.Tcherniaev (geom-specific-V10-04-01)
367 - Removed redundant data initialistion in G4Ex << 209 - Removed redundant data initialistion in G4ExtrudedSolid constructors.
368 210
369 11-December-2017 E.Tcherniaev (geom-speci 211 11-December-2017 E.Tcherniaev (geom-specific-V10-04-00)
370 - Added missing initialisation of two data-mem 212 - Added missing initialisation of two data-members in copy-ctor and
371 assignment operator of G4ExtrudedSolid. Addr 213 assignment operator of G4ExtrudedSolid. Addressing problem report #2016.
372 214
373 22-November-2017 G.Cosmo (geom-specif 215 22-November-2017 G.Cosmo (geom-specific-V10-03-25)
374 - Fix in SurfaceNormal() for G4ExtrudedSolid t 216 - Fix in SurfaceNormal() for G4ExtrudedSolid to assure explicit
375 counting of the surfaces where the point is 217 counting of the surfaces where the point is placed on edg
376 218
377 2-November-2017 G.Cosmo (geom-specif 219 2-November-2017 G.Cosmo (geom-specific-V10-03-24)
378 - Fixed compilation warning introduced with la 220 - Fixed compilation warning introduced with last tag.
379 221
380 31-October-2017 E.Tcherniaev (geom-specif 222 31-October-2017 E.Tcherniaev (geom-specific-V10-03-23)
381 - Added specialised implementation for constru 223 - Added specialised implementation for constructs defining a non-convex right
382 prism in G4ExtrudedSolid. 224 prism in G4ExtrudedSolid.
383 225
384 20-October-2017 G.Cosmo (geom-specif 226 20-October-2017 G.Cosmo (geom-specific-V10-03-22)
385 - G4TessellatedSolid: print also solid's name 227 - G4TessellatedSolid: print also solid's name in StreamInfo().
386 228
387 17-October-2017 G.Cosmo (geom-specif 229 17-October-2017 G.Cosmo (geom-specific-V10-03-21)
388 - Added VecGeom wrapper G4UHype for G4Hype, no 230 - Added VecGeom wrapper G4UHype for G4Hype, not yet activated, pending
389 fixes in VecGeom. 231 fixes in VecGeom.
390 232
391 16-October-2017 G.Cosmo (geom-specif 233 16-October-2017 G.Cosmo (geom-specific-V10-03-20)
392 - Temporarly disabled wrappers for G4Tet and G 234 - Temporarly disabled wrappers for G4Tet and G4GenericPolycone, pending
393 their corresponding implementation in VecGeo 235 their corresponding implementation in VecGeom.
394 236
395 28-September-2017 G.Cosmo (geom-specif 237 28-September-2017 G.Cosmo (geom-specific-V10-03-19)
396 - Corrected initialisation of polyhedra by ver 238 - Corrected initialisation of polyhedra by vertices in G4UPolyhdra wrapper
397 following the changes in VecGeom. 239 following the changes in VecGeom.
398 240
399 15-September-2017 G.Cosmo (geom-specif 241 15-September-2017 G.Cosmo (geom-specific-V10-03-18)
400 - G4SolidsWorkspacePool: use DLL export flag f 242 - G4SolidsWorkspacePool: use DLL export flag for static thread-local
401 symbol of the workspace. 243 symbol of the workspace.
402 244
403 12-September-2017 G.Cosmo (geom-specif 245 12-September-2017 G.Cosmo (geom-specific-V10-03-17)
404 - G4Voxelizer: directly set components for bou 246 - G4Voxelizer: directly set components for bounding-box instead of
405 recreating it in BuildBoundingBox(..). 247 recreating it in BuildBoundingBox(..).
406 248
407 8-September-2017 E.Tcherniaev (geom-specif 249 8-September-2017 E.Tcherniaev (geom-specific-V10-03-16)
408 - Added specialised implementation for constru 250 - Added specialised implementation for constructs defining a convex right
409 prism in G4ExtrudedSolid. 251 prism in G4ExtrudedSolid.
410 252
411 4-September-2017 G.Cosmo (geom-specif 253 4-September-2017 G.Cosmo (geom-specific-V10-03-15, 14)
412 - Temporarly disabled wrapper for extruded-sol 254 - Temporarly disabled wrapper for extruded-solid, pending implementation
413 of extruded-solid in VecGeom. 255 of extruded-solid in VecGeom.
414 256
415 16-August-2017 J.Allison (geom-specif 257 16-August-2017 J.Allison (geom-specific-V10-03-13)
416 - Twisted solids: Fixed bug in drawing polyhed 258 - Twisted solids: Fixed bug in drawing polyhedra with negative twist angle.
417 Addressing problem report #1995. 259 Addressing problem report #1995.
418 260
419 27-July-2017 E.Tcherniaev (geom-specif 261 27-July-2017 E.Tcherniaev (geom-specific-V10-03-12)
420 - G4EllipticalCone: corrected samping of rando 262 - G4EllipticalCone: corrected samping of random points on lateral surface in
421 function GetPointOnSurface(). 263 function GetPointOnSurface().
422 264
423 24-July-2017 E.Tcherniaev (geom-specif 265 24-July-2017 E.Tcherniaev (geom-specific-V10-03-11)
424 - G4EllipticalCone: improved GetPointOnSurface 266 - G4EllipticalCone: improved GetPointOnSurface() to have uniform sampling of
425 points, using function G4RandomPointOnEllips 267 points, using function G4RandomPointOnEllipse().
426 268
427 20-July-2017 E.Tcherniaev (geom-specif 269 20-July-2017 E.Tcherniaev (geom-specific-V10-03-10, 09)
428 - G4EllipticalCone: reviewed implementation of 270 - G4EllipticalCone: reviewed implementation of Inside(), DistanceToIn/Out(p),
429 SurfaceNormal() and GetPointOnSurface(); mad 271 SurfaceNormal() and GetPointOnSurface(); made more compact and performant.
430 Addressing problem report #1974. 272 Addressing problem report #1974.
431 273
432 15-June-2017 G.Cosmo (geom-specif 274 15-June-2017 G.Cosmo (geom-specific-V10-03-08)
433 - Enabled adapter also in G4UPolycone wrapper. 275 - Enabled adapter also in G4UPolycone wrapper.
434 - Added check on open solid for G4UPolyhedra w 276 - Added check on open solid for G4UPolyhedra wrapper.
435 277
436 6-June-2017 G.Cosmo (geom-specif 278 6-June-2017 G.Cosmo (geom-specific-V10-03-07)
437 - Enable adapter for VecGeom shapes in G4U* wr 279 - Enable adapter for VecGeom shapes in G4U* wrappers for: paraboloid,
438 polyhedra and GenericTrap. From now on, wrap 280 polyhedra and GenericTrap. From now on, wrappers depends directly on
439 VecGeom shapes implementation. USolids API i 281 VecGeom shapes implementation. USolids API is deprecated and no longer
440 supported. 282 supported.
441 283
442 24-May-2017 G.Cosmo (geom-specif 284 24-May-2017 G.Cosmo (geom-specific-V10-03-06)
443 - Renamed ambiguous name Extent() in all solid 285 - Renamed ambiguous name Extent() in all solids and G4U* wrappers to
444 BoundingLimits(). Change required in order t 286 BoundingLimits(). Change required in order to avoid signature conflict
445 with VecGeom in G4U* wrappers. 287 with VecGeom in G4U* wrappers.
446 Requires tag geommng-V10-03-16. 288 Requires tag geommng-V10-03-16.
447 289
448 11-May-2017 G.Cosmo (geom-specif 290 11-May-2017 G.Cosmo (geom-specific-V10-03-05)
449 - Removed potential race condition in G4VTwist 291 - Removed potential race condition in G4VTwistSurface::AmIOnLeftSide().
450 Addressing problem report #1972. 292 Addressing problem report #1972.
451 293
452 7-April-2017 G.Cosmo (geom-specif 294 7-April-2017 G.Cosmo (geom-specific-V10-03-04)
453 - Renamed G4SurfaceVoxelizer to G4Voxelizer an 295 - Renamed G4SurfaceVoxelizer to G4Voxelizer and extended to support
454 voxelisation of shapes in 3D space. Adapted 296 voxelisation of shapes in 3D space. Adapted G4TessellatedSolid accordingly.
455 297
456 13-March-2017 G.Cosmo (geom-specif 298 13-March-2017 G.Cosmo (geom-specific-V10-03-03)
457 - G4SolidsWorkspacePool: implemented CleanUpAn 299 - G4SolidsWorkspacePool: implemented CleanUpAndDestroyAllWorkspaces(),
458 to be called by worker threads. Removed decl 300 to be called by worker threads. Removed declaration (i.e. not implemented)
459 of protected method ReleaseAndDestroyWorkspa 301 of protected method ReleaseAndDestroyWorkspace().
460 302
461 2-March-2017 E.Tcherniaev (geom-specif 303 2-March-2017 E.Tcherniaev (geom-specific-V10-03-02)
462 - Fixed possible rounding off error in calcula 304 - Fixed possible rounding off error in calculation of 'astep' (max angle
463 for one step) in CalculateExtent() for G4Pol 305 for one step) in CalculateExtent() for G4Polycone, G4GenericPolycone
464 and related USolids wrappers. 306 and related USolids wrappers.
465 307
466 27-February-2017 E.Tcherniaev (geom-specif 308 27-February-2017 E.Tcherniaev (geom-specific-V10-03-01)
467 - Revised implementation of GetCubicVolume() a 309 - Revised implementation of GetCubicVolume() and GetSurfaceArea() for
468 G4EllipticalTube, to return exact values. 310 G4EllipticalTube, to return exact values.
469 - Revised implementation of GetSurfaceArea() f 311 - Revised implementation of GetSurfaceArea() for G4EllipticalCone, to
470 return exact value; moved both GetCubicVolum 312 return exact value; moved both GetCubicVolume() and GetSurfaceArea() to
471 be not inline. 313 be not inline.
472 314
473 13-December-2016 G.Cosmo (geom-specif 315 13-December-2016 G.Cosmo (geom-specific-V10-03-00)
474 - Correction in G4UExtrudedSolid to signature 316 - Correction in G4UExtrudedSolid to signature for CalculateExtent().
475 Fixes issue of undefined symbol if extruded- 317 Fixes issue of undefined symbol if extruded-solid not included in the
476 list of VecGeom wrappers to activate. 318 list of VecGeom wrappers to activate.
477 319
478 30-November-2016 E.Tcherniaev (geom-specif 320 30-November-2016 E.Tcherniaev (geom-specific-V10-02-25)
479 - Call RemoveRedundantVertices() from G4GeomTo 321 - Call RemoveRedundantVertices() from G4GeomTools in CalculateExtent()
480 for G4Polycone, G4Polyhedra and related USol 322 for G4Polycone, G4Polyhedra and related USolids wrappers.
481 - Fix in G4Parabolid and G4UParaboloid for cor 323 - Fix in G4Parabolid and G4UParaboloid for correct computation of extent.
482 324
483 18-November-2016 E.Tcherniaev (geom-specif 325 18-November-2016 E.Tcherniaev (geom-specific-V10-02-24)
484 - Added consistency checks for extent computat 326 - Added consistency checks for extent computation in USolids wrappers.
485 - Fix in cached parameters in G4UPolyhedra. 327 - Fix in cached parameters in G4UPolyhedra.
486 328
487 10-November-2016 G.Cosmo (geom-specif 329 10-November-2016 G.Cosmo (geom-specific-V10-02-23)
488 - G4UPolyhedra re-introduced new implementatio 330 - G4UPolyhedra re-introduced new implementation of CalculateExtent() using
489 G4BoundingEnvelope and extended wrapper to c 331 G4BoundingEnvelope and extended wrapper to cache corners and start/end
490 Phi parameters, to overcome issues in VecGeo 332 Phi parameters, to overcome issues in VecGeom on treatment of angles.
491 333
492 10-November-2016 E.Tcherniaev (geom-specif 334 10-November-2016 E.Tcherniaev (geom-specific-V10-02-22)
493 - Added caching of corners and implementation 335 - Added caching of corners and implementation of GetCorner() in G4UPolycone
494 in order to assure correct translation. 336 in order to assure correct translation.
495 - Withdrawn changes in G4UPolyhedra introduced 337 - Withdrawn changes in G4UPolyhedra introduced in tag geom-specific-V10-02-16
496 until understood proper conversion from VecG 338 until understood proper conversion from VecGeom.
497 339
498 7-November-2016 E.Tcherniaev (geom-specifi 340 7-November-2016 E.Tcherniaev (geom-specific-V10-02-21)
499 - Correction in G4EllipticalCone::DistanceToOu 341 - Correction in G4EllipticalCone::DistanceToOut(p) to make it more accurate.
500 - Added optional debug flag G4BBOX_EXTENT in G 342 - Added optional debug flag G4BBOX_EXTENT in GNUMake build to compare
501 extent calculation by simply using bounding- 343 extent calculation by simply using bounding-box.
502 344
503 3-November-2016 G.Cosmo (geom-specifi 345 3-November-2016 G.Cosmo (geom-specific-V10-02-20, 19)
504 - Fix in G4PolyPhiFace for potential unitialis 346 - Fix in G4PolyPhiFace for potential unitialised data in Inside().
505 347
506 31-October-2016 E.Tcherniaev (geom-specifi 348 31-October-2016 E.Tcherniaev (geom-specific-V10-02-18)
507 - Re-implemented CalculateExtent() to make use 349 - Re-implemented CalculateExtent() to make use of G4BoundingEnvelope and
508 removed no-longer used method CreateRotatedV 350 removed no-longer used method CreateRotatedVertices() in G4Polyhedra,
509 G4EllipticalCone, G4Polycone, G4Paraboloid, 351 G4EllipticalCone, G4Polycone, G4Paraboloid, G4ExtrudedSolid, G4Hype,
510 G4GenericPolycone, G4TessellatedSolid, G4Twi 352 G4GenericPolycone, G4TessellatedSolid, G4TwistedTubs and related USolids
511 wrappers. 353 wrappers.
512 - Use G4RandFlat instead of RandFlat. 354 - Use G4RandFlat instead of RandFlat.
513 355
514 21-October-2016 G.Cosmo (geom-specifi 356 21-October-2016 G.Cosmo (geom-specific-V10-02-17)
515 - Moved initialisation of G4GeomSplitter threa 357 - Moved initialisation of G4GeomSplitter thread-local data to be inline
516 along with generic template type. 358 along with generic template type.
517 Fixing compilation/linking errors on clang-3 359 Fixing compilation/linking errors on clang-3.9 and XCode-8 on MacOS.
518 360
519 19-October-2016 E.Tcherniaev (geom-speci 361 19-October-2016 E.Tcherniaev (geom-specific-V10-02-16)
520 - Reimplemented CalculateExtent() in G4Polycon 362 - Reimplemented CalculateExtent() in G4Polycone, G4Polyhedra, G4GenericPolycone
521 and associated USolids wrappers, to make use 363 and associated USolids wrappers, to make use of G4BoundingEnvelope.
522 364
523 5-October-2016 E.Tcherniaev (geom-speci 365 5-October-2016 E.Tcherniaev (geom-specific-V10-02-15, 14)
524 - Reimplemented CalculateExtent() in G4Tet, G4 366 - Reimplemented CalculateExtent() in G4Tet, G4UTet, G4GenericTrap,
525 G4UGenericTrap, G4EllipticalTube and G4VTwis 367 G4UGenericTrap, G4EllipticalTube and G4VTwistedFaceted, to make use
526 of G4BoundingEnvelope; removed no-longer use 368 of G4BoundingEnvelope; removed no-longer used method CreateRotatedVertices().
527 369
528 20-September-2016 G.Cosmo (geom-speci 370 20-September-2016 G.Cosmo (geom-specific-V10-02-13)
529 - Moved accessors/modifiers for splitter data 371 - Moved accessors/modifiers for splitter data to non-inline in
530 G4PolyhedraSide and G4PolyconeSide. 372 G4PolyhedraSide and G4PolyconeSide.
531 Explicitly initialise G4GeomSplitter data in 373 Explicitly initialise G4GeomSplitter data in G4SolidsWorkspace
532 translation unit. 374 translation unit.
533 Fixing compilation/linking errors on clang-3 375 Fixing compilation/linking errors on clang-3.9 and XCode-8 on MacOS.
534 376
535 06-July-2016 E.Tcherniaev (geom-speci 377 06-July-2016 E.Tcherniaev (geom-specific-V10-02-12)
536 - Fixed monir typo in function Create() for G4 378 - Fixed monir typo in function Create() for G4Polycone, G4Polyhedra and
537 G4GenericPolycone. 379 G4GenericPolycone.
538 Fixed minor typos in G4GenericTrap::SurfaceN 380 Fixed minor typos in G4GenericTrap::SurfaceNormal() and
539 G4VTwistSurface::CurrentStatus::ResetfDone() 381 G4VTwistSurface::CurrentStatus::ResetfDone().
540 Issues detected by PVS-Studio static code an 382 Issues detected by PVS-Studio static code analyzer.
541 Addressing problem report #1876. 383 Addressing problem report #1876.
542 384
543 24-May-2016 G.Cosmo (geom-speci 385 24-May-2016 G.Cosmo (geom-specific-V10-02-11)
544 - Correction in G4UExtrudedSolid for definitio 386 - Correction in G4UExtrudedSolid for definition of CreatePolyhedron().
545 387
546 20-May-2016 G.Cosmo (geom-speci 388 20-May-2016 G.Cosmo (geom-specific-V10-02-10)
547 - Moved accessors and modifiers in USolids wra 389 - Moved accessors and modifiers in USolids wrappers to be not inlined.
548 Required modification in order to allow corr 390 Required modification in order to allow correct dispatching to VecGeom
549 types. 391 types.
550 392
551 15-Apr-2016 G.Cosmo (geom-speci 393 15-Apr-2016 G.Cosmo (geom-specific-V10-02-09)
552 - Added flag in USolids wrappers for partial u 394 - Added flag in USolids wrappers for partial use of USolids/VecGeom types.
553 395
554 31-Mar-2016 G.Cosmo (geom-speci 396 31-Mar-2016 G.Cosmo (geom-specific-V10-02-08, 07)
555 - Added overloaded CreatePolyhedron() method t 397 - Added overloaded CreatePolyhedron() method to USolids wrappers.
556 It is now possible to visualize supported Ve 398 It is now possible to visualize supported VecGeom shapes.
557 - Added implementation of CreatePolyhedron() i 399 - Added implementation of CreatePolyhedron() in UExtrudedSolid wrapper.
558 400
559 10-Mar-2016 G.Cosmo (geom-speci 401 10-Mar-2016 G.Cosmo (geom-specific-V10-02-06)
560 - Added overloaded GetEntityType() method to U 402 - Added overloaded GetEntityType() method to USolids wrappers.
561 403
562 07-Mar-2016 E.Tcherniaev (geom-speci 404 07-Mar-2016 E.Tcherniaev (geom-specific-V10-02-05)
563 - Fix in G4IntersectingCone for smaller precis 405 - Fix in G4IntersectingCone for smaller precision constant in LineHitsCone1()
564 and LineHitsCone2(). Fixes issue observed in 406 and LineHitsCone2(). Fixes issue observed in G4GenericPolycone.
565 Addressing problem report #1794. 407 Addressing problem report #1794.
566 408
567 03-Mar-2016 G.Cosmo (geom-speci 409 03-Mar-2016 G.Cosmo (geom-specific-V10-02-04)
568 - Fixed compilation warnings for potential uni 410 - Fixed compilation warnings for potential uninitialised values in
569 G4ExtrudedSolid::CheckPolygon() function int 411 G4ExtrudedSolid::CheckPolygon() function introduced in previous tag.
570 412
571 03-Mar-2016 E.Tcherniaev (geom-speci 413 03-Mar-2016 E.Tcherniaev (geom-specific-V10-02-03)
572 - Added 'const' qualifier for methods in G4Ext 414 - Added 'const' qualifier for methods in G4ExtrudedSolid.
573 Added CheckPolygon() to remove collinear and 415 Added CheckPolygon() to remove collinear and coincident points from polygons.
574 - G4QuadrangularFacet: added exhaustive tests 416 - G4QuadrangularFacet: added exhaustive tests in constructor to catch potential
575 problems with a quadrangular facet: collinea 417 problems with a quadrangular facet: collinear vertices, non planar surface,
576 degenerate, concave or self intersecting qua 418 degenerate, concave or self intersecting quadrilateral.
577 - G4TriangularFacet: Improved test in construc 419 - G4TriangularFacet: Improved test in constructor to detect degenerate (too
578 small or too narrow) triangles. 420 small or too narrow) triangles.
579 421
580 25-Feb-2016 E.Tcherniaev (geom-speci 422 25-Feb-2016 E.Tcherniaev (geom-specific-V10-02-02)
581 - Correction in G4ExtrudedSolid::AddGeneralPol 423 - Correction in G4ExtrudedSolid::AddGeneralPolygonFacets() for precision
582 treatment in construction of tessels to avoi 424 treatment in construction of tessels to avoid cases of collinear points
583 and consequent degenerating triangles. 425 and consequent degenerating triangles.
584 Address problem report #1777. 426 Address problem report #1777.
585 - Use pre-computed kCarToleranceHalf constant 427 - Use pre-computed kCarToleranceHalf constant in G4ExtrudedSolid, now
586 protected in G4TessellatedSolid. 428 protected in G4TessellatedSolid.
587 - Improved algorithms for computation of area 429 - Improved algorithms for computation of area in G4TriangularFacet and
588 G4QuadrangularFacet. Added post-const qualif 430 G4QuadrangularFacet. Added post-const qualifier to GetArea().
589 431
590 16-Feb-2016 G.Cosmo (geom-speci 432 16-Feb-2016 G.Cosmo (geom-specific-V10-02-01)
591 - Revised implementation for GetSurfaceArea() 433 - Revised implementation for GetSurfaceArea() and GetCubicVolume() in
592 G4GenericTrap (E.Tcherniaev). 434 G4GenericTrap (E.Tcherniaev).
593 - Protected debug warning in G4GenericTrap::Su 435 - Protected debug warning in G4GenericTrap::SurfaceNormal() within G4SPECSDEBUG.
594 436
595 02-Feb-2016 E.Tcherniaev (geom-speci 437 02-Feb-2016 E.Tcherniaev (geom-specific-V10-02-00)
596 - Fix in G4GenericTrap for compuation of exten 438 - Fix in G4GenericTrap for compuation of extent.
597 Addressing problem report #1809. 439 Addressing problem report #1809.
598 - Use dot() in formula for computation of GetC 440 - Use dot() in formula for computation of GetCubicVolume() in
599 G4TessellatedSolid. 441 G4TessellatedSolid.
600 442
601 18-Nov-2015 G.Cosmo (geom-speci 443 18-Nov-2015 G.Cosmo (geom-specific-V10-01-15)
602 - Added specialised implementation for GetCubi 444 - Added specialised implementation for GetCubicVolume() in
603 G4TessellatedSolid (J.Allison). 445 G4TessellatedSolid (J.Allison).
604 446
605 29-Oct-2015 G.Cosmo (geom-speci 447 29-Oct-2015 G.Cosmo (geom-specific-V10-01-14)
606 - Added debug printouts within G4SPECSDEBUG in 448 - Added debug printouts within G4SPECSDEBUG in G4TessellatedSolid for
607 DistanceToIn/Out(p,v) to identify potential 449 DistanceToIn/Out(p,v) to identify potential wrong responses.
608 450
609 26-Oct-2015 G.Cosmo (geom-speci 451 26-Oct-2015 G.Cosmo (geom-specific-V10-01-13)
610 - Removed redundant condition in G4Polyhedra a 452 - Removed redundant condition in G4Polyhedra and G4polycone
611 SetOriginalParameters() method. 453 SetOriginalParameters() method.
612 454
613 23-Oct-2015 G.Cosmo (geom-speci 455 23-Oct-2015 G.Cosmo (geom-specific-V10-01-12)
614 - G4PolyhedraSide: moved internal struct defin 456 - G4PolyhedraSide: moved internal struct definitions to public section
615 to overcome deficiencies in object-persisten 457 to overcome deficiencies in object-persistency class parsing.
616 458
617 07-Oct-2015 G.Cosmo (geom-speci 459 07-Oct-2015 G.Cosmo (geom-specific-V10-01-11)
618 - Protected compilation of USolid wrappers wit 460 - Protected compilation of USolid wrappers with G4GEOM_USE_USOLIDS flag.
619 461
620 01-Sep-2015 G.Cosmo (geom-speci 462 01-Sep-2015 G.Cosmo (geom-specific-V10-01-10)
621 - Corrected conditional compilation flag in G4 463 - Corrected conditional compilation flag in G4UParaboloid.cc.
622 464
623 31-Aug-2015 G.Cosmo (geom-speci 465 31-Aug-2015 G.Cosmo (geom-specific-V10-01-09)
624 - Added USolids/VecGeom wrapper for G4Parabolo 466 - Added USolids/VecGeom wrapper for G4Paraboloid (G.Lima/FNAL).
625 Activated only for external USolids/VecGeom 467 Activated only for external USolids/VecGeom installation.
626 468
627 13-Aug-2015 G.Cosmo (geom-speci 469 13-Aug-2015 G.Cosmo (geom-specific-V10-01-08)
628 - Checked for potential never-ending loops. 470 - Checked for potential never-ending loops.
629 No issues found, only added annotations. 471 No issues found, only added annotations.
630 472
631 05-Aug-2015 G.Cosmo (geom-speci 473 05-Aug-2015 G.Cosmo (geom-specific-V10-01-07)
632 - Minor code cleanup in G4SurfaceVoxelizer. 474 - Minor code cleanup in G4SurfaceVoxelizer.
633 475
634 03-Mar-2015 G.Cosmo (geom-speci 476 03-Mar-2015 G.Cosmo (geom-specific-V10-01-06)
635 - Use accessors x(), y() and z() from UVector3 477 - Use accessors x(), y() and z() from UVector3, instead of directly accessing
636 its data-members. Co-work with tag "geom-uso 478 its data-members. Co-work with tag "geom-usolids-V10-01-09".
637 479
638 23-Feb-2015 T.Nikitina (geom-speci 480 23-Feb-2015 T.Nikitina (geom-specific-V10-01-05)
639 - Fix in SetOriginalParameters() for G4Polycon 481 - Fix in SetOriginalParameters() for G4Polycone and G4Polyhedra, in case
640 of presence of 'rings' structures. Addressin 482 of presence of 'rings' structures. Addressing problem report #1705.
641 483
642 26-Jan-2015 G.Cosmo (geom-speci 484 26-Jan-2015 G.Cosmo (geom-specific-V10-01-04)
643 - Renamed DistanceAwayForInside() to DistanceA 485 - Renamed DistanceAwayForInside() to DistanceAway() and use polymorphism.
644 486
645 26-Jan-2015 T.Nikitina (geom-speci 487 26-Jan-2015 T.Nikitina (geom-specific-V10-01-03, 02)
646 - Added special method for Inside 'DistanceAwa << 488 - Added special method for Inside 'DistanceAwayForInside()' in order to fix
647 precision problem of calculation of Distance << 489 precision problem of calculation of DistanceToSide() in G4PolyconeSide.
648 490
649 21-Jan-2015 T.Nikitina (geom-speci 491 21-Jan-2015 T.Nikitina (geom-specific-V10-01-01)
650 - Fixed triangularisation method AddGeneralPOl 492 - Fixed triangularisation method AddGeneralPOlygoneFacets() in
651 G4ExtrudedSolid by avoiding flat triangles. 493 G4ExtrudedSolid by avoiding flat triangles.
652 - Added warning message to G4TriangularFacet c 494 - Added warning message to G4TriangularFacet constructor if Area is 0;
653 i.e., case of flat triangle. 495 i.e., case of flat triangle.
654 - Addressing problem report #1703. 496 - Addressing problem report #1703.
655 497
656 12-Dec-2014 G.Cosmo (geom-speci 498 12-Dec-2014 G.Cosmo (geom-specific-V10-01-00)
657 - Use canonical form for operator=() in G4Poly 499 - Use canonical form for operator=() in G4PolyconeHistorical and
658 G4PolyhedraHistorical. 500 G4PolyhedraHistorical.
659 501
660 17-Sep-2014 G.Cosmo (geom-speci 502 17-Sep-2014 G.Cosmo (geom-specific-V10-00-11)
661 - Added wrappers for UExtrudedSolid and UGener 503 - Added wrappers for UExtrudedSolid and UGenericTrap; adapted switches to
662 original G4 types accordingly. Requires tag 504 original G4 types accordingly. Requires tag "geom-usolids-V10-00-16".
663 505
664 01-Sep-2014 G.Cosmo (geom-speci 506 01-Sep-2014 G.Cosmo (geom-specific-V10-00-10)
665 - Fixed use of polyhedron pointer, to avoid ra 507 - Fixed use of polyhedron pointer, to avoid race condition in MT
666 when parameterised volumes are visualised. 508 when parameterised volumes are visualised.
667 509
668 22-May-2014 G.Cosmo (geom-speci 510 22-May-2014 G.Cosmo (geom-specific-V10-00-09)
669 - Added protection in generic constructor of G 511 - Added protection in generic constructor of G4Polyhedra for the case when
670 improper number of sides is given as input. 512 improper number of sides is given as input.
671 513
672 10-Apr-2014 G.Cosmo (geom-speci 514 10-Apr-2014 G.Cosmo (geom-specific-V10-00-08)
673 - Get rid of deprecated 'register' storage cla 515 - Get rid of deprecated 'register' storage class specifier in source files.
674 516
675 31-Mar-2014 G.Cosmo (geom-speci 517 31-Mar-2014 G.Cosmo (geom-specific-V10-00-07)
676 - Fixed signature of assignment operator to G4 518 - Fixed signature of assignment operator to G4VCSGfaceted.
677 519
678 31-Mar-2014 G.Cosmo (geom-speci 520 31-Mar-2014 G.Cosmo (geom-specific-V10-00-06)
679 - Fixed signature of assignment operator to G4 521 - Fixed signature of assignment operator to G4Polycone, G4Polyhedra and
680 and G4GenericPolycone. 522 and G4GenericPolycone.
681 523
682 05-Mar-2014 G.Cosmo (geom-speci 524 05-Mar-2014 G.Cosmo (geom-specific-V10-00-05)
683 - Fixed proper handling of polyhedron pointer 525 - Fixed proper handling of polyhedron pointer in solids, to avoid memory
684 leak for visualization of parameterised volu 526 leak for visualization of parameterised volumes.
685 527
686 12-Feb-2014 G.Cosmo (geom-speci 528 12-Feb-2014 G.Cosmo (geom-specific-V10-00-04)
687 - Simply reset polyhedron pointer to zero for 529 - Simply reset polyhedron pointer to zero for modifiers of G4U* wrappers
688 in parameterisation. Resolves crash in MT vi << 530 in parameterisation. Resolves crash in MT visualization when using USolids.
689 531
690 12-Feb-2014 G.Cosmo (geom-speci 532 12-Feb-2014 G.Cosmo (geom-specific-V10-00-03 [and -02])
691 - Added correct cloning mechanism in G4U* wrap 533 - Added correct cloning mechanism in G4U* wrappers.
692 Addressing problem report #1553. 534 Addressing problem report #1553.
693 535
694 18-Dec-2013 T.Nikitina (geom-speci 536 18-Dec-2013 T.Nikitina (geom-specific-V10-00-01)
695 - Fix in G4GenericTrap::InsidePolygone() to ch 537 - Fix in G4GenericTrap::InsidePolygone() to check if p lies between the two
696 extremes of the segment. Addressing problem 538 extremes of the segment. Addressing problem report #1541.
697 539
698 17-Dec-2013 G.Cosmo (geom-speci 540 17-Dec-2013 G.Cosmo (geom-specific-V10-00-00)
699 - Corrected left-over debug printout in G4Poly 541 - Corrected left-over debug printout in G4Polycone::SetOriginalParameters().
700 542
701 04-Dec-2013 G.Cosmo (geom-speci 543 04-Dec-2013 G.Cosmo (geom-specific-V09-06-36)
702 - Corrected left-over debug printout in G4Poly 544 - Corrected left-over debug printout in G4Polyhedra::SetOriginalParameters().
703 545
704 22-Nov-2013 G.Cosmo (geom-speci 546 22-Nov-2013 G.Cosmo (geom-specific-V09-06-35)
705 - Correction to USolids wrappers for proper se 547 - Correction to USolids wrappers for proper setting of name to base class.
706 548
707 19-Nov-2013 J.Apostolakis (geom-speci 549 19-Nov-2013 J.Apostolakis (geom-specific-V09-06-34)
708 - Fix for issue identified by Coverity: fixed 550 - Fix for issue identified by Coverity: fixed implementation of
709 G4SolidsWorkspacePool singleton. 551 G4SolidsWorkspacePool singleton.
710 552
711 20-Nov-2013 T.Mikitina (geom-speci 553 20-Nov-2013 T.Mikitina (geom-specific-V09-06-33)
712 - Fixed Coverity defects to USolids wrappers. 554 - Fixed Coverity defects to USolids wrappers.
713 555
714 14-Nov-2013 G.Cosmo (geom-speci 556 14-Nov-2013 G.Cosmo (geom-specific-V09-06-32, 31)
715 - Enabled use of Reset() in G4UPolycone. 557 - Enabled use of Reset() in G4UPolycone.
716 - Corrections to G4UPolycone and G4UPolyhedra 558 - Corrections to G4UPolycone and G4UPolyhedra to allow for visualization
717 of parameterisations on these solids. 559 of parameterisations on these solids.
718 560
719 13-Nov-2013 G.Cosmo (geom-speci 561 13-Nov-2013 G.Cosmo (geom-specific-V09-06-30)
720 - Correction to G4UTet and G4UGenericPolycone 562 - Correction to G4UTet and G4UGenericPolycone to explicitly include
721 symbols re-definitions from G4Tet and G4Gene 563 symbols re-definitions from G4Tet and G4GenericPolycone respectively.
722 564
723 12-Nov-2013 G.Cosmo (geom-speci 565 12-Nov-2013 G.Cosmo (geom-specific-V09-06-29)
724 - Added dummy method G4UPolycone::Reset(). 566 - Added dummy method G4UPolycone::Reset().
725 NOTE: Required related implementation (curre 567 NOTE: Required related implementation (currently missing!) in UPolycone.
726 568
727 12-Nov-2013 G.Cosmo (geom-speci 569 12-Nov-2013 G.Cosmo (geom-specific-V09-06-28)
728 - Correction to USolids switch mechanism for G 570 - Correction to USolids switch mechanism for G4Polycone.
729 << 571
730 08-Nov-2013 J.Apostolakis (geom-speci 572 08-Nov-2013 J.Apostolakis (geom-specific-V09-06-27)
731 - G4SolidsWorkspace: cleanup of verbosity. 573 - G4SolidsWorkspace: cleanup of verbosity.
732 Reduced verbosity by making it optional. << 574 Reduced verbosity by making it optional.
733 Added Set/Get Verbose methods to toggle and 575 Added Set/Get Verbose methods to toggle and view it.
734 Added parameter to constructor for verbosity 576 Added parameter to constructor for verbosity (default=off).
735 577
736 07-Nov-2013 G.Cosmo (geom-specific-V09-06-26) 578 07-Nov-2013 G.Cosmo (geom-specific-V09-06-26)
737 - Moved wrappers from usolids module. 579 - Moved wrappers from usolids module.
738 Fixed internal dispatcher method for paramet 580 Fixed internal dispatcher method for parameterisation in all wrappers.
739 - Added switching mechanism for G4GenericPolyc 581 - Added switching mechanism for G4GenericPolycone, G4Polycone, G4Polyhedra
740 and G4Tet. 582 and G4Tet.
741 583
742 06-Nov-2013 G.Cosmo (geom-specific-V09-06-25) 584 06-Nov-2013 G.Cosmo (geom-specific-V09-06-25)
743 - Added switch mechanism for USolids (G4Generi 585 - Added switch mechanism for USolids (G4GenericPolycone, G4Polycone,
744 G4Polyhedra, G4Tet). Renamed related G4 type 586 G4Polyhedra, G4Tet). Renamed related G4 types to 'G4O'.
745 - Moved wrappers from USolids module. 587 - Moved wrappers from USolids module.
746 588
747 01-Nov-2013 G.Cosmo (geom-specific-V09-06-24) 589 01-Nov-2013 G.Cosmo (geom-specific-V09-06-24)
748 - Corrected CMake script. 590 - Corrected CMake script.
749 591
750 31-Oct-2013 G.Cosmo (geom-specific-V09-06-23) 592 31-Oct-2013 G.Cosmo (geom-specific-V09-06-23)
751 - Fix for in G4Polyhedra::SetOriginalParameter 593 - Fix for in G4Polyhedra::SetOriginalParameters(). (T.Nikitina)
752 - Moved G4PolyconeHistorical and G4PolyhedraHi 594 - Moved G4PolyconeHistorical and G4PolyhedraHistorical in separate
753 translation units. 595 translation units.
754 596
755 29-Oct-2013 T.Nikitina (geom-specific-V09-06- 597 29-Oct-2013 T.Nikitina (geom-specific-V09-06-22)
756 - Split G4Polycone for polycones with decreasi 598 - Split G4Polycone for polycones with decreasing Z-sections.
757 Introduced new class G4GenericPolycone. 599 Introduced new class G4GenericPolycone.
758 - Fixed conversion of generic construct for G4 600 - Fixed conversion of generic construct for G4Polyhedra.
759 601
760 17-Oct-2013 J.Apostolakis/A.Dotti (geom-speci 602 17-Oct-2013 J.Apostolakis/A.Dotti (geom-specific-V09-06-21)
761 - Cleanup of code for workspace. 603 - Cleanup of code for workspace.
762 604
763 16-Oct-2013 J.Apostolakis/A.Dotti (geom-speci 605 16-Oct-2013 J.Apostolakis/A.Dotti (geom-specific-V09-06-20)
764 - Created G4SolidsWorkspacePool class, to mana 606 - Created G4SolidsWorkspacePool class, to manage Workspaces
765 Fixed Singleton G4SolidsWorkspacePool for th << 607 Fixed Singleton G4SolidsWorkspacePool for thread safe creation of object.
766 608
767 04-Oct-2013 J.Apostolakis (geom-specific-V09- 609 04-Oct-2013 J.Apostolakis (geom-specific-V09-06-19)
768 - Retagged. 610 - Retagged.
769 NOTE: requires tag "geommng-V09-06-12" and c 611 NOTE: requires tag "geommng-V09-06-12" and co-works with "geomvol-V09-06-13".
770 612
771 04-Oct-2013 J.Apostolakis (geom-specific-V09- 613 04-Oct-2013 J.Apostolakis (geom-specific-V09-06-18)
772 - Created G4SolidsWorkspace class, to create, 614 - Created G4SolidsWorkspace class, to create, initialize and destroy
773 per-thread state of PolyCone Sides and PolyH 615 per-thread state of PolyCone Sides and PolyHedra Sides.
774 616
775 27-Aug-2013 G.Cosmo (geom-specific-V09-06-17) 617 27-Aug-2013 G.Cosmo (geom-specific-V09-06-17)
776 - Enabled G4Ellipsoid for parameterisation. 618 - Enabled G4Ellipsoid for parameterisation.
777 619
778 14-Aug-2013 G.Cosmo (geom-specific-V09-06-16) 620 14-Aug-2013 G.Cosmo (geom-specific-V09-06-16)
779 - Move function-scoped 'static const' values f 621 - Move function-scoped 'static const' values for half-tolerances to private
780 data members of classes, to overcome false-p 622 data members of classes, to overcome false-positive race-conditions defects
781 reported by Valgrind in MT mode. 623 reported by Valgrind in MT mode.
782 - Fix in G4TessellatedSolid::DistanceToIn(p,v) 624 - Fix in G4TessellatedSolid::DistanceToIn(p,v) for specific cases where points
783 are located near surface (T.Nikitina). 625 are located near surface (T.Nikitina).
784 626
785 16-Jul-2013 M.Gayer (geom-specific-V09-06-15) 627 16-Jul-2013 M.Gayer (geom-specific-V09-06-15)
786 - Fix in G4SurfaceVoxelizer affecting tessella 628 - Fix in G4SurfaceVoxelizer affecting tessellated-solid (and extruded-solid)
787 for wrong computation of DistanceToIn(p,v) f 629 for wrong computation of DistanceToIn(p,v) for points outside, when
788 optimisation is active. 630 optimisation is active.
789 631
790 11-Jul-2013 G.Cosmo (geom-specific-V09-06-14) 632 11-Jul-2013 G.Cosmo (geom-specific-V09-06-14)
791 - Fixed compilation warning in G4Polycone on M 633 - Fixed compilation warning in G4Polycone on MacOS/clang.
792 634
793 09-Jul-2013 T.Nikitina (geom-specific-V09-06- 635 09-Jul-2013 T.Nikitina (geom-specific-V09-06-13)
794 - Extended method SetOriginalParameters() in G 636 - Extended method SetOriginalParameters() in G4Polycone in order to handle
795 all possible cases of conversion of generic 637 all possible cases of conversion of generic polycone to polycone with
796 (Rmin,Rmaz,Z) parameters. 638 (Rmin,Rmaz,Z) parameters.
797 Addressing problem report #1462. 639 Addressing problem report #1462.
798 640
799 03-Jun-2013 G.Cosmo (geom-specific-V09-06-12) 641 03-Jun-2013 G.Cosmo (geom-specific-V09-06-12)
800 - Fixed minor Coverity defect in G4PolyhedraSi 642 - Fixed minor Coverity defect in G4PolyhedraSide and G4PolyconeSide.
801 643
802 22-Apr-2013 J.Apostolakis (geom-specific-V09- 644 22-Apr-2013 J.Apostolakis (geom-specific-V09-06-11)
803 - Revised G4ExtrudedSolid::IsSameLine to use t 645 - Revised G4ExtrudedSolid::IsSameLine to use the perpendicular
804 distance to a line when deciding - not the y 646 distance to a line when deciding - not the y-intercept difference.
805 ( Issue responsible for a problem in Subtrac << 647 ( Issue responsible for a problem in Subtraction Solid in Atlas.
806 Tatiana & Ivana contributed to debugging. 648 Tatiana & Ivana contributed to debugging. )
807 - Changed GNUmakefile in test directory to wor << 649 - Changed GNUmakefile in test directory to work with Cmake and granular
808 builds. 650 builds.
809 651
810 16-Apr-2013 T.Nikitina (geom-specific-V09-06- 652 16-Apr-2013 T.Nikitina (geom-specific-V09-06-10)
811 - Fix in calculation of normal in G4Tet::Dista 653 - Fix in calculation of normal in G4Tet::DistanceToOut(p,v,..) and
812 SurfaceNormal(p). 654 SurfaceNormal(p).
813 - Fix in G4Polycone::GetPointOnCone() for case 655 - Fix in G4Polycone::GetPointOnCone() for cases of shape with decreasing Z.
814 Fixes cases of false report for overlaps det 656 Fixes cases of false report for overlaps detection. Problem report #1462.
815 Added check with exception in constructor fo 657 Added check with exception in constructor for polycone with rInner > rOuter
816 for the same Z. 658 for the same Z.
817 659
818 18-Mar-2013 G.Cosmo (geom-specific-V09-06-09) 660 18-Mar-2013 G.Cosmo (geom-specific-V09-06-09)
819 - G4TessellatedSolid: fixed problem with navig 661 - G4TessellatedSolid: fixed problem with navigation in tessellated solids
820 with concave surfaces. Addresses problem rep 662 with concave surfaces. Addresses problem report #1456.
821 - More cleanup from MT changes in G4VTwistSurf 663 - More cleanup from MT changes in G4VTwistSurface and G4Tet.
822 664
823 12-Mar-2013 G.Cosmo (geom-specific-V09-06-08) 665 12-Mar-2013 G.Cosmo (geom-specific-V09-06-08)
824 - Added public accessors for MT data to G4Poly 666 - Added public accessors for MT data to G4PolyconeSide and G4PolyhedraSide.
825 667
826 11-Mar-2013 G.Cosmo (geom-specific-V09-06-07) 668 11-Mar-2013 G.Cosmo (geom-specific-V09-06-07)
827 - Redefined G4DLL_API to G4GEOM_DLL to avoid c 669 - Redefined G4DLL_API to G4GEOM_DLL to avoid cases of macro redefinition.
828 670
829 08-Mar-2013 G.Cosmo (geom-specific-V09-06-06) 671 08-Mar-2013 G.Cosmo (geom-specific-V09-06-06)
830 - Renamed G4MT macros to safer ID in G4Polycon 672 - Renamed G4MT macros to safer ID in G4PolyconeSide and G4PolyhedraSide.
831 673
832 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05) 674 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05)
833 - Adopt G4GeomSplitter instead of G4MTTransito 675 - Adopt G4GeomSplitter instead of G4MTTransitory in G4PolyconeSide and
834 G4PolyhedraSide. Fixed import/export of stat 676 G4PolyhedraSide. Fixed import/export of static symbols for WIN32 DLLs build.
835 677
836 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04) 678 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04)
837 - Cleanup changes for multi-threading in G4Tet 679 - Cleanup changes for multi-threading in G4Tet, G4VTwistSurface,
838 G4PolyconeSide and G4PolyhedraSide. 680 G4PolyconeSide and G4PolyhedraSide.
839 - Removed unused private data member in G4Twis 681 - Removed unused private data member in G4TwistTrapParallelSide.
840 682
841 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05) 683 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05)
842 - Adopt G4GeomSplitter instead of G4MTTransito 684 - Adopt G4GeomSplitter instead of G4MTTransitory in G4PolyconeSide and
843 G4PolyhedraSide. Fixed import/export of stat 685 G4PolyhedraSide. Fixed import/export of static symbols for WIN32 DLLs build.
844 686
845 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04) 687 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04)
846 - Cleanup changes for multi-threading in G4Tet 688 - Cleanup changes for multi-threading in G4Tet, G4VTwistSurface,
847 G4PolyconeSide and G4PolyhedraSide. 689 G4PolyconeSide and G4PolyhedraSide.
848 - Removed unused private data member in G4Twis 690 - Removed unused private data member in G4TwistTrapParallelSide.
849 691
850 11-Jan-2013 G.Cosmo (geom-specific-V09-06-03) 692 11-Jan-2013 G.Cosmo (geom-specific-V09-06-03)
851 - Fixed condition in G4VTwistSurface::GetBound 693 - Fixed condition in G4VTwistSurface::GetBoundaryLimit() for logical error.
852 Addressing problem report #1420. 694 Addressing problem report #1420.
853 695
854 20-Dec-2012 M.Gayer (geom-specific-V09-06-02) 696 20-Dec-2012 M.Gayer (geom-specific-V09-06-02)
855 - Fixed cases of hang-ups in G4ExtrudedSolid o 697 - Fixed cases of hang-ups in G4ExtrudedSolid on 32-bits platforms, due to
856 G4TessellatedSolid and G4SurfVoxelizer, caus 698 G4TessellatedSolid and G4SurfVoxelizer, caused by accessing bitmask arrays
857 with negative indexes. The problem was relat 699 with negative indexes. The problem was related to floating-point rounding,
858 which can be different even on same platform 700 which can be different even on same platform with debug/release version.
859 Assure same number of computed voxels on 32- 701 Assure same number of computed voxels on 32-bit/64-bit platforms.
860 Fixed error in SetVertexIndex() method, whic 702 Fixed error in SetVertexIndex() method, which might cause problems on
861 certain configurations even for 64-bit syste 703 certain configurations even for 64-bit systems. Fixed minor memory leaks.
862 - Code cleanup for use of G4endl and tabs... 704 - Code cleanup for use of G4endl and tabs...
863 705
864 14-Dec-2012 G.Cosmo (geom-specific-V09-06-01) 706 14-Dec-2012 G.Cosmo (geom-specific-V09-06-01)
865 - Restored SVN id headers. 707 - Restored SVN id headers.
866 708
867 02-Dec-2012 J.Allison (geom-specific-V09-06-0 709 02-Dec-2012 J.Allison (geom-specific-V09-06-00)
868 - Removed NURBS. 710 - Removed NURBS.
869 711
870 29-Nov-2012 G.Cosmo (geom-specific-V09-05-24) 712 29-Nov-2012 G.Cosmo (geom-specific-V09-05-24)
871 - Remove inclusion of G4PhysicalConstants.hh f 713 - Remove inclusion of G4PhysicalConstants.hh from G4SurfaceVoxelizer.hh.
872 - Fixed unit test for compilation errors. 714 - Fixed unit test for compilation errors.
873 715
874 28-Nov-2012 G.Cosmo (geom-specific-V09-05-23) 716 28-Nov-2012 G.Cosmo (geom-specific-V09-05-23)
875 - Fixed more cases of inclusion of constants h 717 - Fixed more cases of inclusion of constants header.
876 718
877 23-Nov-2012 G.Cosmo (geom-specific-V09-05-22) 719 23-Nov-2012 G.Cosmo (geom-specific-V09-05-22)
878 - Added 'const' qualifiers to signature in G4V 720 - Added 'const' qualifiers to signature in G4VoxelComparator::operator()
879 for porting on AIX-xlC compiler. 721 for porting on AIX-xlC compiler.
880 722
881 14-Nov-2012 P.Mato (geom-specific-V09-05-21) 723 14-Nov-2012 P.Mato (geom-specific-V09-05-21)
882 - Added #undef NDEBUG in unit tests to ensure 724 - Added #undef NDEBUG in unit tests to ensure assert works also in
883 full optimised mode. 725 full optimised mode.
884 726
885 14-Nov-2012 P. Mato (geom-specific-V09-05-20) 727 14-Nov-2012 P. Mato (geom-specific-V09-05-20)
886 - Added #undef NDEBUG in unit tests to ensure 728 - Added #undef NDEBUG in unit tests to ensure that assert always works
887 729
888 13-Nov-2012 M.Gayer (geom-specific-V09-05-19) 730 13-Nov-2012 M.Gayer (geom-specific-V09-05-19)
889 - More fixes for out-of-bound array accesses i 731 - More fixes for out-of-bound array accesses in G4SurfaceVoxelizer.
890 732
891 12-Nov-2012 M.Gayer (geom-specific-V09-05-18) 733 12-Nov-2012 M.Gayer (geom-specific-V09-05-18)
892 - Fixed out-of-bound array access in BuildRedu 734 - Fixed out-of-bound array access in BuildReduceVoxels2().
893 735
894 06-Nov-2012 G.Cosmo (geom-specific-V09-05-17) 736 06-Nov-2012 G.Cosmo (geom-specific-V09-05-17)
895 - Correction in sources.cmake script for missi 737 - Correction in sources.cmake script for missing .icc file.
896 738
897 06-Nov-2012 G.Cosmo (geom-specific-V09-05-16) 739 06-Nov-2012 G.Cosmo (geom-specific-V09-05-16)
898 - Fixed Coverity defects in new code (M.Gayer) 740 - Fixed Coverity defects in new code (M.Gayer).
899 - Minor fixes for porting on AIX. 741 - Minor fixes for porting on AIX.
900 742
901 01-Nov-2012 G.Cosmo (geom-specific-V09-05-15) 743 01-Nov-2012 G.Cosmo (geom-specific-V09-05-15)
902 - Fixed compilation of debug code under G4SPEC 744 - Fixed compilation of debug code under G4SPECSDEBUG.
903 745
904 01-Nov-2012 M.Gayer (geom-specific-V09-05-14) 746 01-Nov-2012 M.Gayer (geom-specific-V09-05-14)
905 - Corrected signature for voxels count methods 747 - Corrected signature for voxels count methods in G4SurfaceVoxelizer.
906 748
907 31-Oct-2012 M.Gayer (geom-specific-V09-05-13) 749 31-Oct-2012 M.Gayer (geom-specific-V09-05-13)
908 - Added set/get methods for voxels count in G4 750 - Added set/get methods for voxels count in G4SurfaceVoxelizer.
909 751
910 30-Oct-2012 M.Gayer (geom-specific-V09-05-12) 752 30-Oct-2012 M.Gayer (geom-specific-V09-05-12)
911 - Fixed indexing of vertices in facets for tes 753 - Fixed indexing of vertices in facets for tessellated-solid and some cleanup.
912 754
913 27-Oct-2012 G.Cosmo (geom-specific-V09-05-11) 755 27-Oct-2012 G.Cosmo (geom-specific-V09-05-11)
914 - Fixed initialization of data in G4SurfaceVox 756 - Fixed initialization of data in G4SurfaceVoxelizer (M.Gayer).
915 - Added post-const qualifier to G4VertextCompa 757 - Added post-const qualifier to G4VertextComparator::operator() in
916 G4TessellatedSolid. 758 G4TessellatedSolid.
917 - Fixed more compilation warnings on unused va 759 - Fixed more compilation warnings on unused variable.
918 760
919 26-Oct-2012 G.Cosmo (geom-specific-V09-05-10) 761 26-Oct-2012 G.Cosmo (geom-specific-V09-05-10)
920 - Corrected compilation problem on G4SurfBits 762 - Corrected compilation problem on G4SurfBits for use of fprint().
921 - Polished comments in disclaimer in new updat 763 - Polished comments in disclaimer in new updated classes.
922 764
923 25-Oct-2012 G.Cosmo (geom-specific-V09-05-09) 765 25-Oct-2012 G.Cosmo (geom-specific-V09-05-09)
924 - Corrected compilation warnings on Linux and 766 - Corrected compilation warnings on Linux and fixed use of memset/memcpy.
925 767
926 25-Oct-2012 G.Cosmo (geom-specific-V09-05-08) 768 25-Oct-2012 G.Cosmo (geom-specific-V09-05-08)
927 - Correction to sources.cmake. 769 - Correction to sources.cmake.
928 770
929 19-Oct-2012 M.Gayer (geom-specific-V09-05-07) 771 19-Oct-2012 M.Gayer (geom-specific-V09-05-07)
930 - Complete rewrite of G4TessellatedSolid resul 772 - Complete rewrite of G4TessellatedSolid resulting in reduced memory
931 requirements by 50%, and factor of tens or m 773 requirements by 50%, and factor of tens or more speedup for number of facets
932 of the order of thousands, thanks to ad-hoc 774 of the order of thousands, thanks to ad-hoc voxelization of the surface.
933 Factor of thousands speedup when number of f 775 Factor of thousands speedup when number of facets of the order of hundreds
934 thousand. New classes introduced, G4SurfBits 776 thousand. New classes introduced, G4SurfBits and G4SurfaceVoxelizer.
935 777
936 12-Jun-2012 G.Cosmo (geom-specific-V09-05-06) 778 12-Jun-2012 G.Cosmo (geom-specific-V09-05-06)
937 - Explicitly use inclusion of headers for syst 779 - Explicitly use inclusion of headers for system of units and physical
938 constants, in plan to remove implicit inclus 780 constants, in plan to remove implicit inclusion from globals.hh.
939 781
940 14-May-2012 G.Cosmo (geom-specific-V09-05-05) 782 14-May-2012 G.Cosmo (geom-specific-V09-05-05)
941 - Fixed spurious cases of hidden variable visi 783 - Fixed spurious cases of hidden variable visibility, detected with
942 '-Wshadow' compilation option on gcc compile 784 '-Wshadow' compilation option on gcc compiler.
943 785
944 06-Apr-2012 M.Kelsey (geom-specific-V09-05-04 786 06-Apr-2012 M.Kelsey (geom-specific-V09-05-04)
945 - Modified GetPointOnSurface() to throw sqrt(r 787 - Modified GetPointOnSurface() to throw sqrt(r) uniformly for disk surfaces,
946 in G4Paraboloid, G4Polycone and G4TwistedTub 788 in G4Paraboloid, G4Polycone and G4TwistedTubs.
947 789
948 13-Dec-2011 G.Cosmo (geom-specific-V09-05-03, 790 13-Dec-2011 G.Cosmo (geom-specific-V09-05-03, 02, 01)
949 - Fixed trivial Coverity defects in G4TwistedT 791 - Fixed trivial Coverity defects in G4TwistedTubs and G4VTwisteFaceted for
950 missing protection against self-assignment. 792 missing protection against self-assignment.
951 793
952 09-Dec-2011 T.Nikitina (geom-specific-V09-05- 794 09-Dec-2011 T.Nikitina (geom-specific-V09-05-00)
953 - Fix in G4EllipticalCone in DistanceToIn(p,v) 795 - Fix in G4EllipticalCone in DistanceToIn(p,v) to exclude imaginary solution
954 (virtual cone) when distance is calculated. 796 (virtual cone) when distance is calculated.
955 797
956 10-Nov-2011 G.Cosmo (geom-specific-V09-04-09) 798 10-Nov-2011 G.Cosmo (geom-specific-V09-04-09)
957 - Fixed trivial Coverity defects on assignment 799 - Fixed trivial Coverity defects on assignment operators...
958 800
959 25-Oct-2011 G.Cosmo (geom-specific-V09-04-08) 801 25-Oct-2011 G.Cosmo (geom-specific-V09-04-08)
960 - Fixed logic in G4VTwistSurface::GetEdgeVisib 802 - Fixed logic in G4VTwistSurface::GetEdgeVisibility() in treatment of corners.
961 803
962 16-Sep-2011 G.Cosmo (geom-specific-V09-04-07) 804 16-Sep-2011 G.Cosmo (geom-specific-V09-04-07)
963 - Fix compilation error in code within G4SPECS 805 - Fix compilation error in code within G4SPECSDEBUG. No functional changes.
964 806
965 13-Sep-2011 I.Hrivnacova (geom-specific-V09-0 807 13-Sep-2011 I.Hrivnacova (geom-specific-V09-04-06)
966 - G4TriangularFacet: fixed tests where square 808 - G4TriangularFacet: fixed tests where square root was compared to
967 half Cartesian tolerance; now compared to kC 809 half Cartesian tolerance; now compared to kCarTolerance.
968 Addressing problem report #1242. 810 Addressing problem report #1242.
969 811
970 25-Aug-2011 G.Cosmo 812 25-Aug-2011 G.Cosmo
971 - Migrated to new G4Exception scheme for warni 813 - Migrated to new G4Exception scheme for warnings and errors.
972 - Defined scheme for warnings/errors coding: 814 - Defined scheme for warnings/errors coding:
973 + 1xxx for warnings, 0xxx for errors. 815 + 1xxx for warnings, 0xxx for errors.
974 Code numbering: 816 Code numbering:
975 + 0001: not supported or implemented feature 817 + 0001: not supported or implemented features;
976 + 0002: invalid setup/construct; 818 + 0002: invalid setup/construct;
977 + 0003: invalid run condition; 819 + 0003: invalid run condition;
978 + 1001: incorrect setup; automatically adapt 820 + 1001: incorrect setup; automatically adapted.
979 + 1002: notification. 821 + 1002: notification.
980 - Added unit test for G4ExtrudedSolid (J.Apost 822 - Added unit test for G4ExtrudedSolid (J.Apostolakis).
981 823
982 22-Aug-2011 I.Hrivnacova (geom-specific-V09-0 824 22-Aug-2011 I.Hrivnacova (geom-specific-V09-04-05)
983 - Fix in G4TriangularFacet::Intersect() to tak 825 - Fix in G4TriangularFacet::Intersect() to take into account geometrical
984 tolerance and cases of zero distance from su 826 tolerance and cases of zero distance from surface's facet.
985 - Fix in G4TessellatedSolid::DistanceToOut(p) 827 - Fix in G4TessellatedSolid::DistanceToOut(p) and DistanceToIn(p) to exactly
986 compute distance from facet avoiding use of 828 compute distance from facet avoiding use of 'outgoing' flag shortcut variant.
987 - Addressing problem report #1242. 829 - Addressing problem report #1242.
988 830
989 17-Aug-2011 T.Nikitina (geom-specific-V09-04- 831 17-Aug-2011 T.Nikitina (geom-specific-V09-04-04)
990 - Fix in G4Paraboloid::DistanceToIn(p,v) and D 832 - Fix in G4Paraboloid::DistanceToIn(p,v) and DistanceToIn(p) to properly
991 take into account tolerance and provide bett 833 take into account tolerance and provide better estimation of distance
992 respectively. Addresses problem report #1234 834 respectively. Addresses problem report #1234.
993 835
994 04-Aug-2011 T.Nikitina (geom-specific-V09-04- 836 04-Aug-2011 T.Nikitina (geom-specific-V09-04-03)
995 - Added SetReferences() and InvertFacets() to 837 - Added SetReferences() and InvertFacets() to G4GenericTrap::CreatePolyhedron()
996 for proper visualisation of Boolean composit 838 for proper visualisation of Boolean compositions with G4GenericTrap.
997 - Added SetReferences() to G4TessellatedSolid: 839 - Added SetReferences() to G4TessellatedSolid::CreatePolyhedron()
998 for proper visualisation of Boolean composit 840 for proper visualisation of Boolean compositions with G4TessellatedSolid.
999 - Requires tag "greps-V09-04-04", for addressi 841 - Requires tag "greps-V09-04-04", for addressing problem report #1235.
1000 842
1001 17-May-2011 I.Hrivnacova (geom-specific-V09- 843 17-May-2011 I.Hrivnacova (geom-specific-V09-04-02)
1002 - G4ExtrudedSolid: fix in Inside(p) for false 844 - G4ExtrudedSolid: fix in Inside(p) for false overlap reporting.
1003 Addressing problem report #1211. 845 Addressing problem report #1211.
1004 846
1005 12-May-2011 G.Cosmo (geom-specific-V09-04-01 847 12-May-2011 G.Cosmo (geom-specific-V09-04-01)
1006 - Fixed compilation warnings from gcc-4.6.0 f 848 - Fixed compilation warnings from gcc-4.6.0 for variables set but not used.
1007 849
1008 06-May-2011 G.Cosmo (geom-specific-V09-04-00 850 06-May-2011 G.Cosmo (geom-specific-V09-04-00)
1009 - Use G4 typedef for CLHEP types. 851 - Use G4 typedef for CLHEP types.
1010 852
1011 26-Nov-2010 T.Nikitina (geom-specific-V09-03 853 26-Nov-2010 T.Nikitina (geom-specific-V09-03-20)
1012 - Fixes in G4GenericTrap reported by SBT unit 854 - Fixes in G4GenericTrap reported by SBT unit test in SurfaceNormal(),
1013 DistanceToPlane() and VisExtent(). 855 DistanceToPlane() and VisExtent().
1014 856
1015 16-Nov-2010 T.Nikitina (geom-specific-V09-03 857 16-Nov-2010 T.Nikitina (geom-specific-V09-03-19)
1016 - G4EllipticalCone: fixes in DistanceToIn(p,v 858 - G4EllipticalCone: fixes in DistanceToIn(p,v) and DistanceToOut(p,v) for
1017 correct handling of point on the surface. 859 correct handling of point on the surface.
1018 Corrected formula for SurfaceNormal(p). 860 Corrected formula for SurfaceNormal(p).
1019 861
1020 10-Nov-2010 T.Nikitina (geom-specific-V09-03 862 10-Nov-2010 T.Nikitina (geom-specific-V09-03-18)
1021 - Added checks on crossing of vertices and to 863 - Added checks on crossing of vertices and too big twisted angle in
1022 G4GenericTrap. 864 G4GenericTrap.
1023 - Fixed case of division by zero in G4Twisted 865 - Fixed case of division by zero in G4TwistedTubs.
1024 - Added unit test for G4Polyhedra. 866 - Added unit test for G4Polyhedra.
1025 867
1026 02-Nov-2010 G.Cosmo (geom-specific-V09-03-17 868 02-Nov-2010 G.Cosmo (geom-specific-V09-03-17)
1027 - More fixes on Coverity reports for G4Tessel 869 - More fixes on Coverity reports for G4TessellatedSolid and G4ReduciblePolygon.
1028 870
1029 20-Oct-2010 G.Cosmo (geom-specific-V09-03-16 871 20-Oct-2010 G.Cosmo (geom-specific-V09-03-16)
1030 - Implemented Clone() virtual method for all 872 - Implemented Clone() virtual method for all solids, returning a pointer
1031 to a dynamically allocated copy of the soli 873 to a dynamically allocated copy of the solid. To be used by Geant4-MT.
1032 874
1033 23-Sep-2010 G.Cosmo (geom-specific-V09-03-15 875 23-Sep-2010 G.Cosmo (geom-specific-V09-03-15)
1034 - Initialize fpPolyhedron to zero in copy-cto 876 - Initialize fpPolyhedron to zero in copy-ctor and operator=().
1035 - Completed implementation of copy-ctor and o 877 - Completed implementation of copy-ctor and operator=() for facets.
1036 878
1037 20-Sep-2010 G.Cosmo (geom-specific-V09-03-14 879 20-Sep-2010 G.Cosmo (geom-specific-V09-03-14)
1038 - Implemented copy-constructor and assignment 880 - Implemented copy-constructor and assignment operator for all solids
1039 to facilitate conversion to Geant4-MT. 881 to facilitate conversion to Geant4-MT.
1040 882
1041 08-Sep-2010 G.Cosmo (geom-specific-V09-03-13 883 08-Sep-2010 G.Cosmo (geom-specific-V09-03-13)
1042 - Correction to previous fix in G4ReduciblePo 884 - Correction to previous fix in G4ReduciblePolygon to avoid deleting current
1043 'vertexHead' pointer. 885 'vertexHead' pointer.
1044 886
1045 07-Sep-2010 G.Cosmo (geom-specific-V09-03-12 887 07-Sep-2010 G.Cosmo (geom-specific-V09-03-12)
1046 - Fix within G4CSGDEBUG code for restoring co 888 - Fix within G4CSGDEBUG code for restoring cout precision.
1047 - Fix in G4ReduciblePolygon::RemoveRedundantV 889 - Fix in G4ReduciblePolygon::RemoveRedundantVertices() to avoid potential
1048 case of dereferencing freed pointer. 890 case of dereferencing freed pointer.
1049 891
1050 19-Aug-2010 T.Nikitina (geom-specific-V09-03 892 19-Aug-2010 T.Nikitina (geom-specific-V09-03-11)
1051 - G4EllipticalTube: extended implementation o 893 - G4EllipticalTube: extended implementation of SurfaceNormal(p) in agreement
1052 with canonical form. Added unit test testG4 894 with canonical form. Added unit test testG4EllipticalTube.cc.
1053 895
1054 16-Jul-2010 G.Cosmo (geom-specific-V09-03-10 896 16-Jul-2010 G.Cosmo (geom-specific-V09-03-10)
1055 - Fixed cases of division by zero in G4VTwist 897 - Fixed cases of division by zero in G4VTwistSurface and G4TwistBoxSide.
1056 - Use INT_MAX as initialisation for max limit 898 - Use INT_MAX as initialisation for max limits in G4SolidExtentList.
1057 899
1058 12-Jul-2010 G.Cosmo (geom-specific-V09-03-09 900 12-Jul-2010 G.Cosmo (geom-specific-V09-03-09)
1059 - Added dummy initialization to members in st << 901 - Added dummy initialization to members in struct
1060 G4PolyPhiFace::G4PolyPhiFaceEdge, struct G4 902 G4PolyPhiFace::G4PolyPhiFaceEdge, struct G4ReduciblePolygon::ABVertex.
1061 G4Ellipsoid, G4EllipticalTube, G4EnclosingC 903 G4Ellipsoid, G4EllipticalTube, G4EnclosingCylinder, G4ExtrudedSolid, G4Hype,
1062 G4IntersectingCone, G4Paraboloid, G4PolyPhi 904 G4IntersectingCone, G4Paraboloid, G4PolyPhiFace, G4Polycone, G4PolyconeSide,
1063 G4Polyhedra, G4PolyhedraSide, G4Quadrangula 905 G4Polyhedra, G4PolyhedraSide, G4QuadrangularFacet, G4ReduciblePolygon,
1064 G4TessellatedSolid, G4TriangularFacet, G4Tw 906 G4TessellatedSolid, G4TriangularFacet, G4TwistBoxSide, G4TwistTrapAlphaSide,
1065 G4TwistTrapFlatSide, G4TwistTrapParallelSid 907 G4TwistTrapFlatSide, G4TwistTrapParallelSide, G4TwistTubsFlatSide,
1066 G4TwistTubsHypeSide, G4TwistTubsSide, G4Twi 908 G4TwistTubsHypeSide, G4TwistTubsSide, G4TwistedTubs, G4VCSGfaceted, G4VFacet,
1067 G4VTwistSurface, G4VTwistedFaceted. 909 G4VTwistSurface, G4VTwistedFaceted.
1068 - Fixed case of dereferencing null pointer in 910 - Fixed case of dereferencing null pointer in methods
1069 G4EllipticalTube::DistanceToOut(p,v), G4VCS 911 G4EllipticalTube::DistanceToOut(p,v), G4VCSGfaceted::DistanceToIn(p,v)
1070 and G4VCSGfaceted::DistanceToOut(p,v). 912 and G4VCSGfaceted::DistanceToOut(p,v).
1071 - Fixed unecessary object copy as argument in 913 - Fixed unecessary object copy as argument in method
1072 G4PolyhedraSide::IntersectSidePlane(). 914 G4PolyhedraSide::IntersectSidePlane().
1073 - Avoid possible case of derefencing null poi 915 - Avoid possible case of derefencing null pointer in G4ReduciblePolygon
1074 RemoveDuplicateVertices() and RemoveRedunda 916 RemoveDuplicateVertices() and RemoveRedundantVertices() methods.
1075 - Replaced calls to std::abs() with std::fabs 917 - Replaced calls to std::abs() with std::fabs() where suitable.
1076 918
1077 16-Jun-2010 G.Cosmo (geom-specific-V09-03-08 919 16-Jun-2010 G.Cosmo (geom-specific-V09-03-08)
1078 - Fixed deletion of internal arrays in Create 920 - Fixed deletion of internal arrays in CreatePolyhedron() for G4Polycone
1079 and G4Polyhedra. 921 and G4Polyhedra.
1080 922
1081 11-Jun-2010 T.Nikitina (geom-specific-V09-03 923 11-Jun-2010 T.Nikitina (geom-specific-V09-03-07)
1082 - G4GenericTrap: fixed cases of zero dToIn/sT 924 - G4GenericTrap: fixed cases of zero dToIn/sToOut when vertices are collapsed
1083 to triangle, line or point. Added new metho 925 to triangle, line or point. Added new methods handling those specific cases.
1084 - Added unit test for G4GenericTrap. 926 - Added unit test for G4GenericTrap.
1085 927
1086 10-Jun-2010 I.Hrivnacova 928 10-Jun-2010 I.Hrivnacova
1087 - G4GenericTrap: fixed parameter names in Cal 929 - G4GenericTrap: fixed parameter names in CalculateExtent() for the test
1088 case construction through tessellated facet 930 case construction through tessellated facets.
1089 931
1090 09-Jun-2010 G.Cosmo 932 09-Jun-2010 G.Cosmo
1091 - G4GenericTrap: moved internal methods to pr 933 - G4GenericTrap: moved internal methods to private section and reordered
1092 in source file. Added missing implementatio 934 in source file. Added missing implementation for IsTwisted() method.
1093 935
1094 03-Jun-2010 T.Nikitina, G.Cosmo (geom-specif 936 03-Jun-2010 T.Nikitina, G.Cosmo (geom-specific-V09-03-06)
1095 - G4GenericTrap: 937 - G4GenericTrap:
1096 o Fixed initialization of fSurfaceArea and 938 o Fixed initialization of fSurfaceArea and fCubicVolume and
1097 calculation of surface area. 939 calculation of surface area.
1098 o Fixed error in Inside(p) function, and co 940 o Fixed error in Inside(p) function, and corrected use std::fabs() instead
1099 of std::abs() for floating point values. 941 of std::abs() for floating point values.
1100 o Added missing initialisation of fpPolyhed 942 o Added missing initialisation of fpPolyhedron pointer.
1101 o More corrected signatures for use of non- 943 o More corrected signatures for use of non-const references for vectors
1102 passed as arguments to functions. 944 passed as arguments to functions.
1103 945
1104 02-Jun-2010 G.Cosmo (geom-specific-V09-03-05 946 02-Jun-2010 G.Cosmo (geom-specific-V09-03-05)
1105 - G4GenericTrap: use const reference for vect 947 - G4GenericTrap: use const reference for vector of vertices passed as argument
1106 in constructor and accessor. 948 in constructor and accessor.
1107 949
1108 27-May-2010 T.Nikitina (geom-specific-V09-03 950 27-May-2010 T.Nikitina (geom-specific-V09-03-04)
1109 - First implementation of G4GenericTrap shape 951 - First implementation of G4GenericTrap shape, a new solid representing an
1110 arbitrary trapezoid with up to 8 vertices s 952 arbitrary trapezoid with up to 8 vertices standing on two parallel planes
1111 perpendicular to the Z axis. 953 perpendicular to the Z axis.
1112 954
1113 28-Apr-2010 P.R.Truscott (geom-specific-V09- 955 28-Apr-2010 P.R.Truscott (geom-specific-V09-03-03)
1114 - Fix in G4TriangularFacet and G4TessellatedS 956 - Fix in G4TriangularFacet and G4TessellatedSolid to correct treatment of
1115 optical photon transport related to interna 957 optical photon transport related to internal reflection at surface.
1116 Addresses problem report #1103. 958 Addresses problem report #1103.
1117 959
1118 15-Apr-2010 I.Hrivnacova (geom-specific-V09- 960 15-Apr-2010 I.Hrivnacova (geom-specific-V09-03-02)
1119 - G4ExtrudedSolid: eliminated requirement for 961 - G4ExtrudedSolid: eliminated requirement for clockwise ordering of polygon
1120 vertices. Added a check for vertices orderi 962 vertices. Added a check for vertices ordering; if vertices are defined
1121 anti-clockwise their ordering is reverted. 963 anti-clockwise their ordering is reverted.
1122 Fix in polygon facet triangularization for 964 Fix in polygon facet triangularization for consequent concave vertices.
1123 965
1124 24-Feb-2010 G.Cosmo (geom-specific-V09-03-01 966 24-Feb-2010 G.Cosmo (geom-specific-V09-03-01)
1125 - Adopt caching of Phi in G4PolyconeSide and 967 - Adopt caching of Phi in G4PolyconeSide and G4PolyhedraSide to avoid
1126 unnecessary consecutive computations on the 968 unnecessary consecutive computations on the same point.
1127 969
1128 10-Feb-2010 G.Cosmo (geom-specific-V09-03-00 970 10-Feb-2010 G.Cosmo (geom-specific-V09-03-00)
1129 - Use kInfinity for initialising minimum and 971 - Use kInfinity for initialising minimum and maximum allowed extent for
1130 G4SolidExtentList of faceted solids. 972 G4SolidExtentList of faceted solids.
1131 973
1132 11-Nov-2009 G.Cosmo (geom-specific-V09-02-08 974 11-Nov-2009 G.Cosmo (geom-specific-V09-02-08)
1133 - Avoid fake (and redundant) assignment of va 975 - Avoid fake (and redundant) assignment of value to 3-vector in
1134 G4PolyconeSide and G4TwistTubsSide. 976 G4PolyconeSide and G4TwistTubsSide.
1135 977
1136 24-Sep-2009 T.Nikitina (geom-specific-V09-02 978 24-Sep-2009 T.Nikitina (geom-specific-V09-02-07)
1137 - G4Ellipsoid: refined fix in DistanceToIn(p, 979 - G4Ellipsoid: refined fix in DistanceToIn(p,v) for points located on the
1138 curved surface, and correct treatment of ge 980 curved surface, and correct treatment of geometrical tolerance.
1139 981
1140 09-Sep-2009 G.Cosmo (geom-specific-V09-02-06 982 09-Sep-2009 G.Cosmo (geom-specific-V09-02-06)
1141 - G4Ellipsoid: fixed usage of half-tolerances 983 - G4Ellipsoid: fixed usage of half-tolerances (radial and Cartesian) in
1142 DistanceToIn(p,v), based on incorrect assum 984 DistanceToIn(p,v), based on incorrect assumptions introduced in tag
1143 "geom-specific-V09-02-04", responsible for 985 "geom-specific-V09-02-04", responsible for zero steps on configurations
1144 with cut in Z. Addresses problem report #10 986 with cut in Z. Addresses problem report #1076.
1145 987
1146 04-Aug-2009 T.Nikitina (geom-specific-V09-02 988 04-Aug-2009 T.Nikitina (geom-specific-V09-02-05)
1147 - G4Ellipsoid: 989 - G4Ellipsoid:
1148 o Fixes in Inside(p) and in DistanceToIn(p, 990 o Fixes in Inside(p) and in DistanceToIn(p,v) for points
1149 located on the curved surface within tole 991 located on the curved surface within tolerance. Final fix for issue
1150 reported in problem report #1050 and conc 992 reported in problem report #1050 and concerning warnings reported by
1151 grid_test. 993 grid_test.
1152 o Adopt pre-computed half-tolerance values 994 o Adopt pre-computed half-tolerance values for optimisation.
1153 995
1154 23-Jul-2009 T.Nikitina (geom-specific-V09-02 996 23-Jul-2009 T.Nikitina (geom-specific-V09-02-04)
1155 - G4Ellipsoid: fix to DistanceToIn(p,v) in th 997 - G4Ellipsoid: fix to DistanceToIn(p,v) in the calculation of the roots of
1156 the quadratic equation and in DistanceToOut 998 the quadratic equation and in DistanceToOut(p,v) in the calculation of the
1157 normal on cut surfaces. Final fix for probl 999 normal on cut surfaces. Final fix for problem report #1022 and #1050.
1158 - G4PolyconeSide: added protection in method 1000 - G4PolyconeSide: added protection in method Normal(), addressing problem
1159 report #1073. 1001 report #1073.
1160 1002
1161 30-Jun-2009 T.Nikitina (geom-specific-V09-02 1003 30-Jun-2009 T.Nikitina (geom-specific-V09-02-03)
1162 - G4Ellipsoid: introduced to DistanceToIn(p,v 1004 - G4Ellipsoid: introduced to DistanceToIn(p,v) splitting of the distance for
1163 point very far from intersection area and b 1005 point very far from intersection area and big difference between solid
1164 dimensions and distance to it; resolves iss 1006 dimensions and distance to it; resolves issue observed on 64 bits problem.
1165 Also addressing problem report #1022. 1007 Also addressing problem report #1022.
1166 1008
1167 08-May-2009, G.Cosmo (geom-specific-V09-02-02 1009 08-May-2009, G.Cosmo (geom-specific-V09-02-02)
1168 - Corrected typo in base implementation of G4 1010 - Corrected typo in base implementation of G4VCSGfaceted::GetSurfaceArea(),
1169 which was erroneously returning cubic volum 1011 which was erroneously returning cubic volume estimation.
1170 Addresses problem report #1062. 1012 Addresses problem report #1062.
1171 1013
1172 27-Apr-2009, G.Cosmo (geom-specific-V09-02-01 1014 27-Apr-2009, G.Cosmo (geom-specific-V09-02-01)
1173 - Relaxed error condition in G4TessellatedSol 1015 - Relaxed error condition in G4TessellatedSolid::Inside(p) to warning, for
1174 excess of max trials and anomalous conditio 1016 excess of max trials and anomalous conditions in distance calculation.
1175 Added more printout information when error 1017 Added more printout information when error condition is detected.
1176 1018
1177 27-Feb-2009, T.Nikitina (geom-specific-V09-02 1019 27-Feb-2009, T.Nikitina (geom-specific-V09-02-00)
1178 - Fix in G4Paraboloid::DistanceToOut(p,v,..) 1020 - Fix in G4Paraboloid::DistanceToOut(p,v,..) for the computation of normal
1179 to surface; added missing normalisation to 1021 to surface; added missing normalisation to unit, following remark in the
1180 Geometry Forum Hypernews posting #953. 1022 Geometry Forum Hypernews posting #953.
1181 1023
1182 21-Nov-2008, G.Cosmo (geom-specific-V09-01-19 1024 21-Nov-2008, G.Cosmo (geom-specific-V09-01-19)
1183 - Added missing accessors to G4EllipticalCone 1025 - Added missing accessors to G4EllipticalCone, required for detector
1184 persistency. 1026 persistency.
1185 1027
1186 13-Nov-2008, G.Cosmo (geom-specific-V09-01-18 1028 13-Nov-2008, G.Cosmo (geom-specific-V09-01-18)
1187 - Corrected initialisation of algorithm in G4 1029 - Corrected initialisation of algorithm in G4TriangularFacet constructor.
1188 1030
1189 30-Oct-2008, I.Hrivnacova (geom-specific-V09- 1031 30-Oct-2008, I.Hrivnacova (geom-specific-V09-01-17)
1190 - G4ExtrudedSolid: fixed bug in the decomposi 1032 - G4ExtrudedSolid: fixed bug in the decomposition of polygonal sides for
1191 quadrangular facets in MakeFacets(). Addres 1033 quadrangular facets in MakeFacets(). Addresses problem report #1029.
1192 1034
1193 23-Sep-2008, T.Nikitina (geom-specific-V09-01 1035 23-Sep-2008, T.Nikitina (geom-specific-V09-01-16)
1194 - Corrected algorithm in G4TriangularFacet::G 1036 - Corrected algorithm in G4TriangularFacet::GetPointOnFace() according to
1195 suggestion advanced in problem report #1025 1037 suggestion advanced in problem report #1025. Fixes a problem of false
1196 overlaps detection related to G4ExtrudedSol 1038 overlaps detection related to G4ExtrudedSolid and G4TessellatedSolid.
1197 1039
1198 12-Sep-2008, G.Cosmo (geom-specific-V09-01-15 1040 12-Sep-2008, G.Cosmo (geom-specific-V09-01-15)
1199 - G4VFacet: corrected increment of indeces in 1041 - G4VFacet: corrected increment of indeces in operator==(), following
1200 problem report #1024. 1042 problem report #1024.
1201 1043
1202 25-Jul-2008, I.Hrivnacova (geom-specific-V09- 1044 25-Jul-2008, I.Hrivnacova (geom-specific-V09-01-14)
1203 - G4ExtrudedSolid: fix in polygon decompositi 1045 - G4ExtrudedSolid: fix in polygon decomposition; systematically use
1204 half kCarTolerance instead of kCarTolerance 1046 half kCarTolerance instead of kCarTolerance; added solid name in the
1205 error messages coming from fatal exceptions 1047 error messages coming from fatal exceptions.
1206 1048
1207 16-Jul-2008, T.Nikitina (geom-specific-V09-01 1049 16-Jul-2008, T.Nikitina (geom-specific-V09-01-13)
1208 - G4Paraboloid: revised DistanceToOut(p,v,... 1050 - G4Paraboloid: revised DistanceToOut(p,v,...) in answer to problem report
1209 #1015. Fixed precision problem when solving 1051 #1015. Fixed precision problem when solving quadratic equation; apply
1210 comparison with kCarTolerance and not with 1052 comparison with kCarTolerance and not with zero; fixed logic problem in
1211 algoritm for points on surface and directio 1053 algoritm for points on surface and direction inside, relative to directions
1212 along Z, (0,0,Vz). 1054 along Z, (0,0,Vz).
1213 1055
1214 22-May-2008, G.Cosmo (geom-specific-V09-01-12 1056 22-May-2008, G.Cosmo (geom-specific-V09-01-12)
1215 - Removed left-over debug printout in G4VCSGF 1057 - Removed left-over debug printout in G4VCSGFaceted::DistanceToIn().
1216 1058
1217 15-May-2008, T.Nikitina (geom-specific-V09-01 1059 15-May-2008, T.Nikitina (geom-specific-V09-01-11)
1218 - Enhanced GetPointOnSurface() for generic G4 1060 - Enhanced GetPointOnSurface() for generic G4Polycone and G4Polyhedra
1219 constructs; the method uses new triangulati 1061 constructs; the method uses new triangulation algorithm for G4PolyPhiFace.
1220 - G4ExtrudedSolid: added missing 'std' namesp 1062 - G4ExtrudedSolid: added missing 'std' namespace to standard mathematical
1221 function calls. 1063 function calls.
1222 1064
1223 28-Apr-2008, T.Nikitina (geom-specific-V09-01 1065 28-Apr-2008, T.Nikitina (geom-specific-V09-01-10)
1224 - Added kCarTolerance in definition of "low" 1066 - Added kCarTolerance in definition of "low" and "high" cone limits in R
1225 and in Z in order to protect against numeri 1067 and in Z in order to protect against numerical errors. This fixes cases of
1226 DistanceToIn(p,v) returning 'kInfinity' whe 1068 DistanceToIn(p,v) returning 'kInfinity' when p+t*v cross intersection
1227 between two cones. 1069 between two cones.
1228 1070
1229 25-Apr-2008, T.Nikitina (geom-specific-V09-01 1071 25-Apr-2008, T.Nikitina (geom-specific-V09-01-09)
1230 - Added protection against NaN in G4Intersect 1072 - Added protection against NaN in G4IntersectingCone::LineHitsCone1() in
1231 case of configuration where a conic section 1073 case of configuration where a conic section becomes a tube.
1232 - G4EllipticalCone: removed some debug printo 1074 - G4EllipticalCone: removed some debug printouts.
1233 1075
1234 14-Apr-2008, T.Nikitina (geom-specific-V09-01 1076 14-Apr-2008, T.Nikitina (geom-specific-V09-01-08)
1235 - G4Hype: refined polyhedron representation f 1077 - G4Hype: refined polyhedron representation for correct visualization of
1236 the shape. Coworks with tag "greps-V09-01-0 1078 the shape. Coworks with tag "greps-V09-01-04".
1237 1079
1238 13-Mar-2008, G.Cosmo (geom-specific-V09-01-07 1080 13-Mar-2008, G.Cosmo (geom-specific-V09-01-07)
1239 - Cleared compilation warnings in G4Paraboloi 1081 - Cleared compilation warnings in G4Paraboloid and G4TessellatedSolid
1240 on gcc-4.3.0 for ambiguous use of parenthes 1082 on gcc-4.3.0 for ambiguous use of parentheses in condition statements.
1241 1083
1242 28-Feb-2008, I.Hrivnacova (geom-specific-V09- 1084 28-Feb-2008, I.Hrivnacova (geom-specific-V09-01-06)
1243 - Correction to previous fix in G4ExtrudedSol 1085 - Correction to previous fix in G4ExtrudedSolid: testing on the edges has
1244 to be limited to the line segment, for this 1086 to be limited to the line segment, for this purpose a new internal method
1245 IsSameLineSegment() has been introduced for 1087 IsSameLineSegment() has been introduced for use instead of IsSameLine().
1246 - Updated and extended unit test testG4Extrud 1088 - Updated and extended unit test testG4ExtrudedSolid.cc.
1247 1089
1248 27-Feb-2008, I.Hrivnacova (geom-specific-V09- 1090 27-Feb-2008, I.Hrivnacova (geom-specific-V09-01-05)
1249 - Fix in G4TessellatedSolid::DistanceToOut(p, 1091 - Fix in G4TessellatedSolid::DistanceToOut(p,v,..) to compute normal only
1250 if specified by flag in input. 1092 if specified by flag in input.
1251 - Fix in G4ExtrudedSolid::Inside(p) for corre 1093 - Fix in G4ExtrudedSolid::Inside(p) for correctly handling the case of
1252 points located on the edges of triangles wh 1094 points located on the edges of triangles which are not the outline edges
1253 of the polygon. 1095 of the polygon.
1254 1096
1255 21-Feb-2008, T.Nikitina (geom-specific-V09-01 1097 21-Feb-2008, T.Nikitina (geom-specific-V09-01-04)
1256 - G4Polyhedra: fixed problem of out-of-bound 1098 - G4Polyhedra: fixed problem of out-of-bound access to vectors in
1257 GetPointOnSurface(). 1099 GetPointOnSurface().
1258 1100
1259 20-Feb-2008, I.Hrivnacova (geom-specific-V09- 1101 20-Feb-2008, I.Hrivnacova (geom-specific-V09-01-03)
1260 - G4TessellatedSolid: fixed bug in copy-const 1102 - G4TessellatedSolid: fixed bug in copy-constructor and internal method
1261 CopyObjects() for cloning of facets. 1103 CopyObjects() for cloning of facets.
1262 1104
1263 05-Feb-2008, I.Hrivnacova (geom-specific-V09- 1105 05-Feb-2008, I.Hrivnacova (geom-specific-V09-01-02)
1264 - G4ExtrudedSolid: bug fix in MakeFacets() to 1106 - G4ExtrudedSolid: bug fix in MakeFacets() to fill 'fTriangles' also in case
1265 of polygon with 3 or 4 vertices, as they ar 1107 of polygon with 3 or 4 vertices, as they are needed for Inside(p).
1266 1108
1267 02-Feb-2008, I.Hrivnacova (geom-specific-V09- 1109 02-Feb-2008, I.Hrivnacova (geom-specific-V09-01-01)
1268 - Corrected triangularization of polygon, now 1110 - Corrected triangularization of polygon, now correctly handling case
1269 of concave shapes. 1111 of concave shapes.
1270 - Corrected order of arguments in G4Paraboloi << 1112 - Corrected order of arguments in G4Paraboloid constructor.
1271 1113
1272 16-Jan-2008, I.Hrivnacova (geom-specific-V09- 1114 16-Jan-2008, I.Hrivnacova (geom-specific-V09-01-00)
1273 - In G4ExtrudedSolid::MakeFacets(), now addin 1115 - In G4ExtrudedSolid::MakeFacets(), now adding triangular facets before quadrangular
1274 ones, following logic behind G4TessellatedS 1116 ones, following logic behind G4TessellatedSolid.
1275 1117
1276 12-Dec-2007, G.Cosmo (geom-specific-V09-00-08 1118 12-Dec-2007, G.Cosmo (geom-specific-V09-00-08a)
1277 - Remove use of global static constant from s 1119 - Remove use of global static constant from singleton initialisation in
1278 G4TessellatedGeometryAlgorithms class. Use 1120 G4TessellatedGeometryAlgorithms class. Use 'sqrEpsilon' as local value.
1279 1121
1280 15-Nov-2007, P.Truscott (geom-specific-V09-00 1122 15-Nov-2007, P.Truscott (geom-specific-V09-00-08)
1281 - Reviewed implementation of G4TessellatedSol 1123 - Reviewed implementation of G4TessellatedSolid::CalculateExtent() to
1282 make it more robust and precise, following 1124 make it more robust and precise, following suggestion by S.Seibert
1283 addressed in problem report #983, now fixed 1125 addressed in problem report #983, now fixed.
1284 1126
1285 12-Oct-2007, G.Cosmo (geom-specific-V09-00-07 1127 12-Oct-2007, G.Cosmo (geom-specific-V09-00-07)
1286 - Corrected wrong boolean condition in method 1128 - Corrected wrong boolean condition in method IntersectLineAndTriangle2D()
1287 of G4TessellatedGeometryAlgorithms causing 1129 of G4TessellatedGeometryAlgorithms causing compilation error on VC++8.
1288 1130
1289 09-Oct-2007, G.Cosmo (geom-specific-V09-00-06 1131 09-Oct-2007, G.Cosmo (geom-specific-V09-00-06)
1290 - Reviewed G4TessellatedSolid classes in orde 1132 - Reviewed G4TessellatedSolid classes in order not to make use of random
1291 numbers for selection of direction (by P.Tr 1133 numbers for selection of direction (by P.Truscott).
1292 1134
1293 02-Oct-2007, G.Cosmo 1135 02-Oct-2007, G.Cosmo
1294 - Removed debug printout in G4Polycone::GetPo 1136 - Removed debug printout in G4Polycone::GetPointOnCone().
1295 1137
1296 23-Aug-2007, G.Cosmo (geom-specific-V09-00-05 1138 23-Aug-2007, G.Cosmo (geom-specific-V09-00-05)
1297 - Revision of G4TessellatedSolid classes: 1139 - Revision of G4TessellatedSolid classes:
1298 o Fixed problem report #931 by P.Truscott, 1140 o Fixed problem report #931 by P.Truscott, based on suggestion of
1299 R.Holmberg. Modified classes G4Tessellate 1141 R.Holmberg. Modified classes G4TessellatedSolid and G4TriangularFacet.
1300 o Modified data and accessor 'centroid' and 1142 o Modified data and accessor 'centroid' and 'GetCentroid()' for G4VFacet;
1301 replaced by 'circumcentre' and 'GetCircum 1143 replaced by 'circumcentre' and 'GetCircumcentre()' respectively.
1302 o Added utility class G4TessellatedGeometry 1144 o Added utility class G4TessellatedGeometryAlgorithms.
1303 - Added formulas for calculating SemiAxis and 1145 - Added formulas for calculating SemiAxis and Zheight in G4EllipticalCone
1304 (by T.Nikitina). 1146 (by T.Nikitina).
1305 1147
1306 20-Aug-2007, T.Nikitina & L.Lindroos (geom-sp 1148 20-Aug-2007, T.Nikitina & L.Lindroos (geom-specific-V09-00-04)
1307 - Revision of G4EllipticalCone: 1149 - Revision of G4EllipticalCone:
1308 o DistanceToIn(p): corrected answer for p.z 1150 o DistanceToIn(p): corrected answer for p.z()<-zTopCut and for the point
1309 p on the surface. 1151 p on the surface.
1310 o DistanceToOut(p,v): now returning positiv 1152 o DistanceToOut(p,v): now returning positive solution or zero when crossing
1311 the elliptical surface. 1153 the elliptical surface.
1312 o Fix in DistanceToOut(p) which was giving << 1154 o Fix in DistanceToOut(p) which was giving always zero.
1313 o Corrected visualisation error of solid in 1155 o Corrected visualisation error of solid in graphics_reps.
1314 o Added some formulas on how to pre-calcula 1156 o Added some formulas on how to pre-calculate 'SemiAxis' and 'zheight'.
1315 o Added checkDistanceToOut() method to unit 1157 o Added checkDistanceToOut() method to unit test.
1316 - Corrections to G4Paraboloid: 1158 - Corrections to G4Paraboloid:
1317 o Fixed bug in CalculateSurfaceArea() metho 1159 o Fixed bug in CalculateSurfaceArea() method
1318 o Added correct initialisation of 'fPolyhed 1160 o Added correct initialisation of 'fPolyhedron' in constructor.
1319 o Added unit test testG4Paraboloid. 1161 o Added unit test testG4Paraboloid.
1320 1162
1321 13-Aug-2007, W.Pokorski (geom-specific-V09-00 1163 13-Aug-2007, W.Pokorski (geom-specific-V09-00-03)
1322 - G4PolyconeSide: added workaround to initial 1164 - G4PolyconeSide: added workaround to initialisation of 'corners' vector,
1323 to allow for object persistency with Root-I 1165 to allow for object persistency with Root-I/O (W.Pokorski).
1324 1166
1325 18-Jul-2007, G.Cosmo (geom-specific-V09-00-02 1167 18-Jul-2007, G.Cosmo (geom-specific-V09-00-02)
1326 - New specific G4Paraboloid with cuts along t 1168 - New specific G4Paraboloid with cuts along the Z axis (by L.Lindroos).
1327 - Fixed dummy constructors of G4Polycone and 1169 - Fixed dummy constructors of G4Polycone and G4PolyPhiFace for initialisation
1328 of 'edges' and 'corners'. 1170 of 'edges' and 'corners'.
1329 - Coworks with tag "greps-V09-00-01". 1171 - Coworks with tag "greps-V09-00-01".
1330 1172
1331 12-Jul-2007, T.Nikitina (geom-specific-V09-00 1173 12-Jul-2007, T.Nikitina (geom-specific-V09-00-01)
1332 - Fix in G4Polyhedra::GetPointOnSurface() to 1174 - Fix in G4Polyhedra::GetPointOnSurface() to correctly treat 'totalPhi' instead of
1333 'endPhi' for the case of open shapes and 't 1175 'endPhi' for the case of open shapes and 'twopi' for not open shapes.
1334 1176
1335 05-Jul-2007, T.Nikitina (geom-specific-V09-00 1177 05-Jul-2007, T.Nikitina (geom-specific-V09-00-00)
1336 - Fix in G4Polyhedra::GetPointOnSurface() for 1178 - Fix in G4Polyhedra::GetPointOnSurface() for the case when number of sectors
1337 (numSide) is equal to 1. At the origin of p 1179 (numSide) is equal to 1. At the origin of problems observed when checking
1338 overlaps for polyhedra solids defined as su 1180 overlaps for polyhedra solids defined as such.
1339 1181
1340 31-May-2007, G.Cosmo (geom-specific-V08-03-03 1182 31-May-2007, G.Cosmo (geom-specific-V08-03-03)
1341 - Fixed initialisation of constants in constr 1183 - Fixed initialisation of constants in constructor for - G4VTwistSurface,
1342 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraS 1184 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraSide - following latest changes
1343 for tunable tolerance. 1185 for tunable tolerance.
1344 1186
1345 25-May-2007, G.Cosmo (geom-specific-V08-03-02 1187 25-May-2007, G.Cosmo (geom-specific-V08-03-02)
1346 - Fixed default response of DistToIn/DistToOu 1188 - Fixed default response of DistToIn/DistToOut for twisted solids.
1347 - Use G4TWISTDEBUG instead of G4SPECSDEBUG as 1189 - Use G4TWISTDEBUG instead of G4SPECSDEBUG as debug conditional flag
1348 for twisted solids. 1190 for twisted solids.
1349 - Some cleanup in G4TwistTrapAlphaSide code. 1191 - Some cleanup in G4TwistTrapAlphaSide code.
1350 1192
1351 18-May-2007, G.Cosmo (geom-specific-V08-03-01 1193 18-May-2007, G.Cosmo (geom-specific-V08-03-01)
1352 - Use kAngTolerance and kRadTolerance from G4 1194 - Use kAngTolerance and kRadTolerance from G4GeometryTolerance class.
1353 - Coworks with tag "global-V08-03-03". 1195 - Coworks with tag "global-V08-03-03".
1354 1196
1355 11-May-2007, T.Nikitina (geom-specific-V08-03 1197 11-May-2007, T.Nikitina (geom-specific-V08-03-00)
1356 - Use call to G4GeometryTolerance instead of 1198 - Use call to G4GeometryTolerance instead of kCarTolerance where needed.
1357 - Requires tag "global-V08-03-00" and related 1199 - Requires tag "global-V08-03-00" and related tag set.
1358 1200
1359 26-Apr-2007, T.Nikitina (geom-specific-V08-02 1201 26-Apr-2007, T.Nikitina (geom-specific-V08-02-05)
1360 - Fix in GetPointOnSurface() for G4Polycone t 1202 - Fix in GetPointOnSurface() for G4Polycone to consider also points laying
1361 on rings when consecutive Z-sections are co 1203 on rings when consecutive Z-sections are coincident.
1362 Added method GetPointOnRing(). 1204 Added method GetPointOnRing().
1363 - Added unit test testPointOnSurfacePoly.cc. 1205 - Added unit test testPointOnSurfacePoly.cc.
1364 1206
1365 27-Feb-2007, I.Hrivnacova (geom-specific-V08- 1207 27-Feb-2007, I.Hrivnacova (geom-specific-V08-02-04)
1366 - Added specialised constructor for handling 1208 - Added specialised constructor for handling Z-sections in G4ExtrudedSolid.
1367 - Cleared unecessary declaration of IsInside( 1209 - Cleared unecessary declaration of IsInside() methods in G4TriangularFacet
1368 and G4QuadrangularFacet. 1210 and G4QuadrangularFacet.
1369 - Updated unit test for G4ExtrudedSolid. 1211 - Updated unit test for G4ExtrudedSolid.
1370 1212
1371 26-Feb-2007, I.Hrivnacova (geom-specific-V08- 1213 26-Feb-2007, I.Hrivnacova (geom-specific-V08-02-04)
1372 - Added specialised constructor for handling 1214 - Added specialised constructor for handling Z-sections in G4ExtrudedSolid.
1373 - Cleared unecessary declaration of IsInside( 1215 - Cleared unecessary declaration of IsInside() methods in G4TriangularFacet
1374 and G4QuadrangularFacet. 1216 and G4QuadrangularFacet.
1375 - Updated unit test for G4ExtrudedSolid. 1217 - Updated unit test for G4ExtrudedSolid.
1376 1218
1377 15-Feb-2007, I.Hrivnacova (geom-specific-V08- 1219 15-Feb-2007, I.Hrivnacova (geom-specific-V08-02-03)
1378 - Corrected caching of values in G4ExtrudedSo 1220 - Corrected caching of values in G4ExtrudedSolid.
1379 - Bug fix in G4TriangularFacet::Intersect() t 1221 - Bug fix in G4TriangularFacet::Intersect() to allow for correct update of
1380 'Distance' in condition. 1222 'Distance' in condition.
1381 - Updated unit test for G4ExtrudedSolid. 1223 - Updated unit test for G4ExtrudedSolid.
1382 1224
1383 09-Feb-2007, G.Cosmo (geom-specific-V08-02-02 1225 09-Feb-2007, G.Cosmo (geom-specific-V08-02-02)
1384 - Introduced new shape G4ExtrudedSolid, a sol 1226 - Introduced new shape G4ExtrudedSolid, a solid representing the extrusion
1385 of an arbitrary polygon with fixed outline 1227 of an arbitrary polygon with fixed outline in the two Z sections.
1386 New files: G4ExtrudedSolid[.hh.icc.cc] and 1228 New files: G4ExtrudedSolid[.hh.icc.cc] and testG4ExtrudedSolid.cc
1387 by I.Hrivnacova. 1229 by I.Hrivnacova.
1388 - G4TessellatedSolid: 1230 - G4TessellatedSolid:
1389 o Made relevant solid's methods virtual, to 1231 o Made relevant solid's methods virtual, to be used as base class.
1390 o Added implementation for GetSurfaceArea() 1232 o Added implementation for GetSurfaceArea() and GetPointOnSurface() methods.
1391 o Added protection in SurfaceNormal() metho 1233 o Added protection in SurfaceNormal() method in case of facet not found.
1392 o Check and return kOutside in Inside() if 1234 o Check and return kOutside in Inside() if point out of solid's extent.
1393 1235
1394 01-Feb-2007, G.Cosmo (geom-specific-V08-02-01 1236 01-Feb-2007, G.Cosmo (geom-specific-V08-02-01)
1395 - Fix in G4PolyconeSide::DistanceAway() for c 1237 - Fix in G4PolyconeSide::DistanceAway() for correct estimation of distance
1396 for the case of Phi sections (T.Nikitina). 1238 for the case of Phi sections (T.Nikitina).
1397 Addresses problem report #598. 1239 Addresses problem report #598.
1398 - Updated unit test for G4Polycone to conside 1240 - Updated unit test for G4Polycone to consider new test case.
1399 1241
1400 22-Jan-2007, G.Cosmo (geom-specific-V08-02-00 1242 22-Jan-2007, G.Cosmo (geom-specific-V08-02-00)
1401 - Do not scale reducible-polygon in G4Polyhed 1243 - Do not scale reducible-polygon in G4Polyhedra::Reset() method.
1402 The 'original_parameters' structure offered 1244 The 'original_parameters' structure offered as input through the accessors
1403 are always assumed to be already scaled by 1245 are always assumed to be already scaled by the 'cos(0.5*phiTotal/theNumSide)'
1404 factor. Addresses problem report #873. 1246 factor. Addresses problem report #873.
1405 - Fixed warning printout in G4Polycone::Reset 1247 - Fixed warning printout in G4Polycone::Reset().
1406 1248
1407 15-Nov-2006, J.Allison (geom-specific-V08-01- 1249 15-Nov-2006, J.Allison (geom-specific-V08-01-04)
1408 - Fixed typo in G4Polycone::CreatePolyhedron( 1250 - Fixed typo in G4Polycone::CreatePolyhedron() introduced by mistake in
1409 the last cleanup of the source code. 1251 the last cleanup of the source code.
1410 1252
1411 13-Nov-2006, G.Cosmo (geom-specific-V08-01-03 1253 13-Nov-2006, G.Cosmo (geom-specific-V08-01-03)
1412 - Added concrete implementation of GetSurface 1254 - Added concrete implementation of GetSurfaceArea() in G4Tet (M.H.Mendenhall).
1413 1255
1414 08-Nov-2006, G.Cosmo (geom-specific-V08-01-02 1256 08-Nov-2006, G.Cosmo (geom-specific-V08-01-02)
1415 - Cleared compilation warnings on SUN-CC for 1257 - Cleared compilation warnings on SUN-CC for changes in the last tag.
1416 Fixed overloaded class variables in G4Polyh 1258 Fixed overloaded class variables in G4Polyhedra and G4Polycone
1417 implementation of CreatePolyhedron(). 1259 implementation of CreatePolyhedron().
1418 1260
1419 31-Oct-2006, J.Allison (geom-specific-V08-01- 1261 31-Oct-2006, J.Allison (geom-specific-V08-01-01)
1420 - Implemented CreatePolyhedron() for G4Polyhe 1262 - Implemented CreatePolyhedron() for G4Polyhedra and G4Polycone.
1421 1263
1422 20-Oct-2006, G.Cosmo (geom-specific-V08-01-00 1264 20-Oct-2006, G.Cosmo (geom-specific-V08-01-00)
1423 - Implemented caching mechanism for computati 1265 - Implemented caching mechanism for computation of surface area in
1424 all solids and base classes, as done for th 1266 all solids and base classes, as done for the geometrical volume
1425 computation. 1267 computation.
1426 - Added missing fake constructor for object p 1268 - Added missing fake constructor for object persistency to G4TessellatedSolid.
1427 1269
1428 20-Jun-2006, G.Cosmo (geom-specific-V08-00-10 1270 20-Jun-2006, G.Cosmo (geom-specific-V08-00-10)
1429 - Added accessor method GetVertices() in G4Te 1271 - Added accessor method GetVertices() in G4Tet to return the list of
1430 vertices composing the solid. Required for 1272 vertices composing the solid. Required for GDML persistency.
1431 1273
1432 06-Jun-2006, G.Cosmo (geom-specific-V08-00-09 1274 06-Jun-2006, G.Cosmo (geom-specific-V08-00-09)
1433 - Added protection against NaNs in G4Polycone 1275 - Added protection against NaNs in G4PolyconeSide::Normal() for points at
1434 the origin. 1276 the origin.
1435 1277
1436 19-May-2006, G.Cosmo (geom-specific-V08-00-08 1278 19-May-2006, G.Cosmo (geom-specific-V08-00-08)
1437 - Fix in G4Ellipsoid::SetZCuts() and G4Ellipt 1279 - Fix in G4Ellipsoid::SetZCuts() and G4EllipticalTube::SetZCut() for usage
1438 of uninitialised variables. 1280 of uninitialised variables.
1439 1281
1440 08-May-2006, G.Cosmo (geom-specific-V08-00-07 1282 08-May-2006, G.Cosmo (geom-specific-V08-00-07)
1441 - Cleared compilation warning on SUN-CC in G4 1283 - Cleared compilation warning on SUN-CC in G4TriangularFacet.cc.
1442 1284
1443 04-May-2006, G.Cosmo (geom-specific-V08-00-06 1285 04-May-2006, G.Cosmo (geom-specific-V08-00-06)
1444 - Use different names for unit tests to avoid 1286 - Use different names for unit tests to avoid confusing liblist ...
1445 1287
1446 03-May-2006, G.Cosmo (geom-specific-V08-00-05 1288 03-May-2006, G.Cosmo (geom-specific-V08-00-05)
1447 - Added four unit tests for G4TessellatedSoli 1289 - Added four unit tests for G4TessellatedSolid.
1448 1290
1449 24-Mar-2006, G.Cosmo (geom-specific-V08-00-04 1291 24-Mar-2006, G.Cosmo (geom-specific-V08-00-04)
1450 - G4TwistedTubs: defined exact estimation for 1292 - G4TwistedTubs: defined exact estimation for GetCubicVolume(),
1451 similar to the one adopted for G4Tubs. 1293 similar to the one adopted for G4Tubs.
1452 1294
1453 03-Mar-2006, G.Cosmo (geom-specific-V08-00-03 1295 03-Mar-2006, G.Cosmo (geom-specific-V08-00-03)
1454 - Corrected boolean condition in G4Triangular 1296 - Corrected boolean condition in G4TriangularFacet::Intersect().
1455 Use '&&' operator in condition. Allows for 1297 Use '&&' operator in condition. Allows for porting on WIN32-VC.
1456 1298
1457 01-Mar-2006, G.Cosmo (geom-specific-V08-00-02 1299 01-Mar-2006, G.Cosmo (geom-specific-V08-00-02)
1458 - Introducing first implementation of a tesse 1300 - Introducing first implementation of a tessellated solid, contribution
1459 of P.R.Truscott (QinetiQ Ltd, UK). 1301 of P.R.Truscott (QinetiQ Ltd, UK).
1460 New classes: G4QuadrangularFacet, G4Tessell 1302 New classes: G4QuadrangularFacet, G4TessellatedSolid, G4TriangularFacet
1461 and G4VFacet. 1303 and G4VFacet.
1462 - Requires tag "greps-V08-00-00". 1304 - Requires tag "greps-V08-00-00".
1463 1305
1464 12-Jan-2006, J.Allison (geom-specific-V08-00- 1306 12-Jan-2006, J.Allison (geom-specific-V08-00-01)
1465 - G4TwistedTubs and G4VTwistedFaceted::Create 1307 - G4TwistedTubs and G4VTwistedFaceted::CreatePolyhedron():
1466 parameterised polyhedron mesh approximation 1308 parameterised polyhedron mesh approximation in terms of
1467 G4Polyhedron::GetNumberOfRotationSteps(). 1309 G4Polyhedron::GetNumberOfRotationSteps().
1468 This is (a) more economical and (b) amenabl 1310 This is (a) more economical and (b) amenable to user control.
1469 1311
1470 19-Dec-2005, O.Link (geom-specific-V08-00-00) 1312 19-Dec-2005, O.Link (geom-specific-V08-00-00)
1471 - Fixes in G4EllipticalCone: 1313 - Fixes in G4EllipticalCone:
1472 o Changed GetPointOnSurface(), which was no 1314 o Changed GetPointOnSurface(), which was not uniform in endcaps.
1473 o Bug fix in Inside(), which was not correc 1315 o Bug fix in Inside(), which was not correct for the elliptic mantel.
1474 Made test similar as in G4EllipticTube. 1316 Made test similar as in G4EllipticTube.
1475 o Several fixes in DistanceToIn/Out(): for 1317 o Several fixes in DistanceToIn/Out(): for looping events (shortest
1476 distance was taken, even if 0); now compa 1318 distance was taken, even if 0); now comparing the distance to the endcap
1477 and to the mantel and decide afterwards w 1319 and to the mantel and decide afterwards which distance is shortest;
1478 added check n*v. 1320 added check n*v.
1479 o The code is now "good" at 90%. Still 10% 1321 o The code is now "good" at 90%. Still 10% wrong reconstructed events.
1480 e.g there is a problem is DistanceToOut() 1322 e.g there is a problem is DistanceToOut(): missed the intersection
1481 (reconstruction took the encap instead of 1323 (reconstruction took the encap instead of the mantel).
1482 1324
1483 09-Dec-2005, O.Link 1325 09-Dec-2005, O.Link
1484 - Fixed visibility of soft edges on the twist 1326 - Fixed visibility of soft edges on the twisted solids.
1485 1327
1486 08-Dec-2005, O.Link (geom-specific-V07-01-14) 1328 08-Dec-2005, O.Link (geom-specific-V07-01-14)
1487 - Fixed bug in G4VTwistSurface::ComputeLocalP 1329 - Fixed bug in G4VTwistSurface::ComputeLocalPoint(p) for point coordinate
1488 transformation. The bug affected only G4Twi 1330 transformation. The bug affected only G4TwistTrapFlatSide.
1489 1331
1490 06-Dec-2005, G.Cosmo (geom-specific-V07-01-13 1332 06-Dec-2005, G.Cosmo (geom-specific-V07-01-13)
1491 - Fixed compilation errors on WIN32-VC for la 1333 - Fixed compilation errors on WIN32-VC for last tag changes.
1492 1334
1493 05-Dec-2005, O.Link (geom-specific-V07-01-12) 1335 05-Dec-2005, O.Link (geom-specific-V07-01-12)
1494 - Added polyhedron definition for twisted sol 1336 - Added polyhedron definition for twisted solids (G4TwistedTrap,
1495 G4TwistedTrd, G4TwistedBox, G4TwistedTubs) 1337 G4TwistedTrd, G4TwistedBox, G4TwistedTubs) for visualization.
1496 1338
1497 30-Nov-2005, G.Cosmo (geom-specific-V07-01-11 1339 30-Nov-2005, G.Cosmo (geom-specific-V07-01-11)
1498 - Trivial fixes for porting on CLHEP-2.0.X se 1340 - Trivial fixes for porting on CLHEP-2.0.X series.
1499 1341
1500 18-Nov-2005, O.Link (geom-specific-V07-01-10) 1342 18-Nov-2005, O.Link (geom-specific-V07-01-10)
1501 - Renamed classes for twisted solids set, to 1343 - Renamed classes for twisted solids set, to identify them in the
1502 twisted framework. 1344 twisted framework.
1503 1345
1504 17-Nov-2005, O.Link 1346 17-Nov-2005, O.Link
1505 - G4VTwistedFacted: 1347 - G4VTwistedFacted:
1506 o corrected bug in DistanceToSurface() impl 1348 o corrected bug in DistanceToSurface() implementation
1507 o added GetPointOnSurface() method 1349 o added GetPointOnSurface() method
1508 - G4TwistedTubs: 1350 - G4TwistedTubs:
1509 o added GetPointOnSurface() method 1351 o added GetPointOnSurface() method
1510 - G4Hype: 1352 - G4Hype:
1511 o corrected surface area calculation used i 1353 o corrected surface area calculation used in GetPointOnSurface()
1512 << 1354
1513 17-Nov-2005, G.Cosmo (geom-specific-V07-01-09 1355 17-Nov-2005, G.Cosmo (geom-specific-V07-01-09)
1514 - More fixes required for direct object persi 1356 - More fixes required for direct object persistency to G4Polycone,
1515 G4polyhedra and related utility classes. 1357 G4polyhedra and related utility classes.
1516 1358
1517 10-Nov-2005, J.Allison (geom-specific-V07-01- 1359 10-Nov-2005, J.Allison (geom-specific-V07-01-08)
1518 - G4Tet: 1360 - G4Tet:
1519 o Added implementation for GetPolyhedron() 1361 o Added implementation for GetPolyhedron() and GetCubicVolume().
1520 o Corrected order of specifying vertices in 1362 o Corrected order of specifying vertices in CreatePolyhedron().
1521 1363
1522 09-Nov-2005, G.Cosmo (geom-specific-V07-01-07 1364 09-Nov-2005, G.Cosmo (geom-specific-V07-01-07)
1523 - Added fake default constructor for all conc 1365 - Added fake default constructor for all concrete solids and relevant
1524 utility classes, for usage of direct object 1366 utility classes, for usage of direct object persistency.
1525 - Implemented changes to support CLHEP-2.0.X 1367 - Implemented changes to support CLHEP-2.0.X for explicit usage of the
1526 CLHEP/HepGeom namespaces for CLHEP types. 1368 CLHEP/HepGeom namespaces for CLHEP types.
1527 1369
1528 07-Nov-2005, G.Cosmo (geom-specific-V07-01-06 1370 07-Nov-2005, G.Cosmo (geom-specific-V07-01-06)
1529 - G4Ellipsoid: replaced call to hypot(x,y) wi 1371 - G4Ellipsoid: replaced call to hypot(x,y) with std::sqrt(x*x+y*y)
1530 for porting to ISO standard. 1372 for porting to ISO standard.
1531 1373
1532 02-Nov-2005, G.Cosmo (geom-specific-V07-01-05 1374 02-Nov-2005, G.Cosmo (geom-specific-V07-01-05)
1533 - G4Polyhedra, G4Polycone: 1375 - G4Polyhedra, G4Polycone:
1534 o Protected case of generic construct for v 1376 o Protected case of generic construct for visualization.
1535 o Introduced explicit flag and method IsGen 1377 o Introduced explicit flag and method IsGeneric() to identify the kind
1536 of constructor used. 1378 of constructor used.
1537 1379
1538 29-Sep-2005, G.Cosmo (geom-specific-V07-01-04 1380 29-Sep-2005, G.Cosmo (geom-specific-V07-01-04)
1539 - Fix in G4EllipticalCone methods DistanceToI 1381 - Fix in G4EllipticalCone methods DistanceToIn() and DistanceToOut().
1540 Added unit test for it (by D.Anninos). 1382 Added unit test for it (by D.Anninos).
1541 - Coworks with tag "greps-V07-01-02". 1383 - Coworks with tag "greps-V07-01-02".
1542 1384
1543 10-Aug-2005, G.Cosmo (geom-specific-V07-01-03 1385 10-Aug-2005, G.Cosmo (geom-specific-V07-01-03)
1544 - Introduced new solid G4EllipticalCone, a fu 1386 - Introduced new solid G4EllipticalCone, a full cone with elliptical base
1545 that can be cut in Z (by D.Anninos). 1387 that can be cut in Z (by D.Anninos).
1546 Coworks with tag "greps-V07-01-02". 1388 Coworks with tag "greps-V07-01-02".
1547 1389
1548 08-Aug-2005, D.Anninos (geom-specific-V07-01- 1390 08-Aug-2005, D.Anninos (geom-specific-V07-01-02)
1549 - Added GetPointOnSurface() for all solids ex 1391 - Added GetPointOnSurface() for all solids except twisted ones.
1550 The method returns a random point according 1392 The method returns a random point according to a quasi-uniform
1551 distribution along the surface. 1393 distribution along the surface.
1552 1394
1553 18-Jul-2005, G.Cosmo (geom-specific-V07-01-01 1395 18-Jul-2005, G.Cosmo (geom-specific-V07-01-01)
1554 - Fixed compilation warning on WIN32-VC for G 1396 - Fixed compilation warning on WIN32-VC for G4VSurface.cc.
1555 - Not including G4Tet. 1397 - Not including G4Tet.
1556 1398
1557 06-Jul-2005, G.Cosmo (geom-specific-V07-01-00 1399 06-Jul-2005, G.Cosmo (geom-specific-V07-01-00)
1558 - Added new shape G4Ellipsoid. Coworks with t 1400 - Added new shape G4Ellipsoid. Coworks with tag "greps-V07-01-00".
1559 Contribution of G.Horton-Smith and G.Guerri 1401 Contribution of G.Horton-Smith and G.Guerrieri.
1560 Code cleanup, and added default arguments f 1402 Code cleanup, and added default arguments for cuts, added first
1561 implementation of unit test. 1403 implementation of unit test.
1562 - Corrected unit tests for twisted-box/trap. 1404 - Corrected unit tests for twisted-box/trap.
1563 - Not including G4Tet. 1405 - Not including G4Tet.
1564 1406
1565 15-Jun-2005, J.Apostolakis 1407 15-Jun-2005, J.Apostolakis
1566 - Introduced new solid G4Tet, contribution of 1408 - Introduced new solid G4Tet, contribution of M.H.Mendenhall
1567 and R.A.Weller, Vanderbilt University, USA. 1409 and R.A.Weller, Vanderbilt University, USA.
1568 1410
1569 29-Apr-2005, O.Link (geom-specific-V07-00-04) 1411 29-Apr-2005, O.Link (geom-specific-V07-00-04)
1570 - G4TwistedSurface: fixed bug in GetAreaCode( 1412 - G4TwistedSurface: fixed bug in GetAreaCode() affecting G4TwistedTubs.
1571 1413
1572 04-Apr-2005, G.Cosmo (geom-specific-V07-00-03 1414 04-Apr-2005, G.Cosmo (geom-specific-V07-00-03)
1573 - Added test for Number-Of-Rotation-Steps in 1415 - Added test for Number-Of-Rotation-Steps in GetPolyhedron() for
1574 G4VCSGfaceted, G4Hype and G4EllipticalTube 1416 G4VCSGfaceted, G4Hype and G4EllipticalTube (by J.Allison).
1575 Requires tag "greps-V07-00-02". 1417 Requires tag "greps-V07-00-02".
1576 - Added elementary implementation of CreatePo 1418 - Added elementary implementation of CreatePolyhedron() for G4Hype,
1577 G4TwistedBox, G4TwistedTubs, G4TwistedTrd, 1419 G4TwistedBox, G4TwistedTubs, G4TwistedTrd, G4TwistedTrap.
1578 - Some code cleanup. 1420 - Some code cleanup.
1579 1421
1580 18-Mar-2005, O.Link (geom-specific-V07-00-02) 1422 18-Mar-2005, O.Link (geom-specific-V07-00-02)
1581 - New generic framework for twisted solids G4 1423 - New generic framework for twisted solids G4TwistedBox, G4TwistedTrd and
1582 G4TwistedTrap: inheriting now from the base 1424 G4TwistedTrap: inheriting now from the base class G4VTwistedFaceted.
1583 - Extended G4TwistedTrap to support setups wi 1425 - Extended G4TwistedTrap to support setups with different trapezoidal
1584 endcaps with centres not necessarily on a l 1426 endcaps with centres not necessarily on a line parallel to the z axis.
1585 - Added G4TwistedTrd and general G4TwistedTra 1427 - Added G4TwistedTrd and general G4TwistedTrap as test cases in test.
1586 1428
1587 03-Mar-2005, J.Allison 1429 03-Mar-2005, J.Allison
1588 - Changed AddThis() to AddSolid() for all sol 1430 - Changed AddThis() to AddSolid() for all solids in the implementation
1589 of DescribeYourselfTo(G4VGraphicsScene&). 1431 of DescribeYourselfTo(G4VGraphicsScene&).
1590 1432
1591 01-Mar-2005, O.Link (geom-specific-V07-00-01) 1433 01-Mar-2005, O.Link (geom-specific-V07-00-01)
1592 - Fixed compilation warnings on WIN32-VC for 1434 - Fixed compilation warnings on WIN32-VC for G4VSurface.cc.
1593 1435
1594 14-Feb-2005, O.Link (geom-specific-V07-00-00) 1436 14-Feb-2005, O.Link (geom-specific-V07-00-00)
1595 - Use new polynom approximations based on new 1437 - Use new polynom approximations based on new solver based on Jenkins-Traub
1596 algorithm, for twisted-box and twisted-trap 1438 algorithm, for twisted-box and twisted-trap.
1597 - Fixed bug in the usage of 'fmod' and adopt 1439 - Fixed bug in the usage of 'fmod' and adopt special treatment for 'parallel'
1598 events in G4TwistedBoxSide and G4TwistedTra 1440 events in G4TwistedBoxSide and G4TwistedTrapSide.
1599 - Coworks with tag "global-V07-00-00". 1441 - Coworks with tag "global-V07-00-00".
1600 1442
1601 08-Dec-2004, O.Link (geom-specific-V06-02-07) 1443 08-Dec-2004, O.Link (geom-specific-V06-02-07)
1602 - Extensions to twisted box/trap shapes to co 1444 - Extensions to twisted box/trap shapes to consider all 4 solutions
1603 for determining correct intersections. 1445 for determining correct intersections.
1604 1446
1605 29-Nov-2004, O.Link (geom-specific-V06-02-06) 1447 29-Nov-2004, O.Link (geom-specific-V06-02-06)
1606 - G4TwistedTrapSide, G4TwistedBoxSide: improv 1448 - G4TwistedTrapSide, G4TwistedBoxSide: improved (analytical) version
1607 of GetPhiUAtX() method. 1449 of GetPhiUAtX() method.
1608 1450
1609 24-Nov-2004, O.Link (geom-specific-V06-02-05) 1451 24-Nov-2004, O.Link (geom-specific-V06-02-05)
1610 - Fixed bug in description of twisted trapezo 1452 - Fixed bug in description of twisted trapezoid side.
1611 1453
1612 12-Nov-2004, O.Link (geom-specific-V06-02-04) 1454 12-Nov-2004, O.Link (geom-specific-V06-02-04)
1613 - Added G4TwistedBox - a twisted box with tw 1455 - Added G4TwistedBox - a twisted box with twist angle alpha,
1614 length a/2,b/2,L/2. 1456 length a/2,b/2,L/2.
1615 - Added G4TwistedTrap - a twisted trapezoid ( 1457 - Added G4TwistedTrap - a twisted trapezoid (still in debug state)
1616 - Changed in G4VSurface.icc: << 1458 - Changed in G4VSurface.icc:
1617 - GetNeighbours(): corrected axiscode (wa 1459 - GetNeighbours(): corrected axiscode (was returning the wrong neighbours)
1618 - SetNeighbours(): fixed problem #685 (in 1460 - SetNeighbours(): fixed problem #685 (index out of range)
1619 - Added tests for G4TwistedBox and G4TwistedT 1461 - Added tests for G4TwistedBox and G4TwistedTrap in specific/test.
1620 - Added G4TwistedBox and G4TwistedTrap in sys 1462 - Added G4TwistedBox and G4TwistedTrap in system testing, test10.
1621 1463
1622 22-Oct-2004, D.C.Williams (geom-specific-V06- 1464 22-Oct-2004, D.C.Williams (geom-specific-V06-02-03)
1623 - Fix in G4PolyconeSide::Inside for points at 1465 - Fix in G4PolyconeSide::Inside for points at radius = 0 for phi slides
1624 solids with an inner radius. Addresses prob 1466 solids with an inner radius. Addresses problem report #598.
1625 1467
1626 10-Oct-2004, J.Allison (geom-specific-V06-02- 1468 10-Oct-2004, J.Allison (geom-specific-V06-02-02)
1627 - Added GetPolyhedron, a smart access functio 1469 - Added GetPolyhedron, a smart access function that creates a G4Polyhedron
1628 on request and stores for future access. A 1470 on request and stores for future access. A null pointer means "not
1629 available". 1471 available".
1630 1472
1631 22-Sep-2004, G.Cosmo (geom-specific-V06-02-01 1473 22-Sep-2004, G.Cosmo (geom-specific-V06-02-01)
1632 - Added implementation of GetCubicVolume() wi 1474 - Added implementation of GetCubicVolume() with cashing mechanism for
1633 solids: G4EllipticalTube, G4Hype, G4Polyhed 1475 solids: G4EllipticalTube, G4Hype, G4Polyhedra, G4Polycone, G4TwistedTubs.
1634 1476
1635 01-Sep-2004, D.C.Williams (geom-specific-V06- 1477 01-Sep-2004, D.C.Williams (geom-specific-V06-02-00)
1636 - G4VCSGfaceted: fix for rare anomalous situa 1478 - G4VCSGfaceted: fix for rare anomalous situation in which
1637 DistanceToOut(p,v,..) will report kInfinity 1479 DistanceToOut(p,v,..) will report kInfinity, make an additional check
1638 for the point p on the surface, in which ca 1480 for the point p on the surface, in which case will report zero.
1639 Addresses problem observed in G4Polyhedra a 1481 Addresses problem observed in G4Polyhedra and reported in #650.
1640 1482
1641 07-Jun-2004, G.Cosmo (geom-specific-V06-01-04 1483 07-Jun-2004, G.Cosmo (geom-specific-V06-01-04)
1642 - Fixed compilation problem in G4TwistedSurfa 1484 - Fixed compilation problem in G4TwistedSurface.cc on WIN32-VC.
1643 1485
1644 28-May-2004, G.Cosmo (geom-specific-V06-01-03 1486 28-May-2004, G.Cosmo (geom-specific-V06-01-03)
1645 - Fixed archiving problem on WIN32-VC7: repla 1487 - Fixed archiving problem on WIN32-VC7: replaced structs with classes
1646 in G4VSurface. 1488 in G4VSurface.
1647 - Replaced misleading names for masks in G4VS 1489 - Replaced misleading names for masks in G4VSurface and moved inlined
1648 methods of nested classes to .cc. 1490 methods of nested classes to .cc.
1649 1491
1650 25-May-2004, G.Cosmo (geom-specific-V06-01-02 1492 25-May-2004, G.Cosmo (geom-specific-V06-01-02)
1651 - Fixed compilation problem on SUN-CC. Made E 1493 - Fixed compilation problem on SUN-CC. Made EValidate enum public in
1652 G4VSurface.hh. 1494 G4VSurface.hh.
1653 1495
1654 24-May-2004, G.Cosmo (geom-specific-V06-01-01 1496 24-May-2004, G.Cosmo (geom-specific-V06-01-01)
1655 - Removed compilation warnings and minor clea 1497 - Removed compilation warnings and minor cleanup...
1656 1498
1657 19-May-2004, O.Link (geom-specific-V06-01-00) 1499 19-May-2004, O.Link (geom-specific-V06-01-00)
1658 - First implementation of a framework for twi 1500 - First implementation of a framework for twisted surfaces, integrated from
1659 the original version of Kotoyo Hoshina (hos 1501 the original version of Kotoyo Hoshina (hoshina@hepburn.s.chiba-u.ac.jp)
1660 implemented in the 'Jupiter' application. 1502 implemented in the 'Jupiter' application.
1661 o Includes new specific twisted shape: G4Tw 1503 o Includes new specific twisted shape: G4TwistedTubs.
1662 o New classes: G4VSurface, G4TwistedSurface 1504 o New classes: G4VSurface, G4TwistedSurface, G4HyperbolicSurface,
1663 G4FlatSurface, G4TwistedTubs 1505 G4FlatSurface, G4TwistedTubs.
1664 o Cleanup of original code (debugging messa 1506 o Cleanup of original code (debugging messages, compiler errors, migration
1665 of g4std to new convention...) 1507 of g4std to new convention...)
1666 o New organisation of class G4TwistedTubs: 1508 o New organisation of class G4TwistedTubs: now independent of XXXSurface;
1667 removed backpointer 'fSolid' from XXXSurf 1509 removed backpointer 'fSolid' from XXXSurface to G4TwistedTubs.
1668 o New form of constructors in G4TwistedSurf 1510 o New form of constructors in G4TwistedSurface, G4HyperbolicSurface and
1669 G4FlatSurface. 1511 G4FlatSurface.
1670 o Change in G4TwistedSurface::DistanceToIn( 1512 o Change in G4TwistedSurface::DistanceToIn(p,v,...): roundoff correction.
1671 1513
1672 12-Jan-2004, G.Cosmo (geom-specific-V06-00-00 1514 12-Jan-2004, G.Cosmo (geom-specific-V06-00-00)
1673 - G4PolyhedraSide.cc: fixed bug in which part 1515 - G4PolyhedraSide.cc: fixed bug in which particles could "leak" out the
1674 center of a face if inner radius = 0. 1516 center of a face if inner radius = 0.
1675 Fixes problem report #547. (D.Williams) 1517 Fixes problem report #547. (D.Williams)
1676 1518
1677 22-Nov-2003, G.Cosmo (geom-specific-V05-02-07 1519 22-Nov-2003, G.Cosmo (geom-specific-V05-02-07)
1678 - Fixed upper bound for protection check intr 1520 - Fixed upper bound for protection check introduced in G4Polycone and
1679 G4Polyhedra constructors. 1521 G4Polyhedra constructors.
1680 1522
1681 17-Nov-2003, G.Cosmo (geom-specific-V05-02-06 1523 17-Nov-2003, G.Cosmo (geom-specific-V05-02-06)
1682 - Added protections in G4Polycone and G4Polyh 1524 - Added protections in G4Polycone and G4Polyhedra constructors for
1683 invalid constructs with no contiguous segme 1525 invalid constructs with no contiguous segments in Z planes as input.
1684 1526
1685 04-Nov-2003, G.Cosmo (geom-specific-V05-02-05 1527 04-Nov-2003, G.Cosmo (geom-specific-V05-02-05)
1686 - Added SetOriginalParameters() method to G4P 1528 - Added SetOriginalParameters() method to G4Polycone and G4Polyhedra.
1687 1529
1688 03-Nov-2003, G.Cosmo (geom-specific-V05-02-04 1530 03-Nov-2003, G.Cosmo (geom-specific-V05-02-04)
1689 - Code cleanup and headers inclusion review 1531 - Code cleanup and headers inclusion review
1690 (replaced by forward declarations where nec 1532 (replaced by forward declarations where necessary).
1691 1533
1692 28-Oct-2003, G.Cosmo (geom-specific-V05-02-03 1534 28-Oct-2003, G.Cosmo (geom-specific-V05-02-03)
1693 - Migrated to new G4Exception scheme. 1535 - Migrated to new G4Exception scheme.
1694 1536
1695 20-Oct-2003, G.Cosmo (geom-specific-V05-02-02 1537 20-Oct-2003, G.Cosmo (geom-specific-V05-02-02)
1696 - Added Reset() method in G4Polycone and G4Po 1538 - Added Reset() method in G4Polycone and G4Polyhedra to allow
1697 recalculation and reshape of the solid if n 1539 recalculation and reshape of the solid if new original_parameters
1698 are provided. 1540 are provided.
1699 1541
1700 30-Sep-2003, G.Cosmo (geom-specific-V05-02-01 1542 30-Sep-2003, G.Cosmo (geom-specific-V05-02-01)
1701 - Updated GNUmakefile for unit tests, accordi 1543 - Updated GNUmakefile for unit tests, according to new structure
1702 introduced in "geometry-V05-02-00". 1544 introduced in "geometry-V05-02-00".
1703 1545
1704 16-Jun-2003, G.Cosmo (geom-specific-V05-02-00 1546 16-Jun-2003, G.Cosmo (geom-specific-V05-02-00)
1705 - Added accessors to original_parameters for 1547 - Added accessors to original_parameters for G4Polycone and G4Polyhedra.
1706 Made G4PolyconeHistorical and G4PolyhedraHi 1548 Made G4PolyconeHistorical and G4PolyhedraHistorical classes in global
1707 scope (temporary solution). 1549 scope (temporary solution).
1708 1550
1709 28-Mar-2003, G.Cosmo (geom-specific-V05-00-00 1551 28-Mar-2003, G.Cosmo (geom-specific-V05-00-00)
1710 - Fixed initialisation of base class in copy 1552 - Fixed initialisation of base class in copy contructor for:
1711 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraS 1553 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraSide.
1712 - Fixed trivial pedantic warnings on G4Polyco 1554 - Fixed trivial pedantic warnings on G4Polycone and G4Polyhedra.
1713 1555
1714 30-Oct-2002, G.Cosmo (geom-specific-V04-01-01 1556 30-Oct-2002, G.Cosmo (geom-specific-V04-01-01)
1715 - Fixed un-initialised data members in constr 1557 - Fixed un-initialised data members in constructors of classes:
1716 G4ClippablePolygon, G4EnclosingCylinder, G4 1558 G4ClippablePolygon, G4EnclosingCylinder, G4PolyconeSide,
1717 G4ReduciblePolygon, G4VCSGfaceted. 1559 G4ReduciblePolygon, G4VCSGfaceted.
1718 1560
1719 28-Oct-2002, G.Cosmo (geom-specific-V04-01-00 1561 28-Oct-2002, G.Cosmo (geom-specific-V04-01-00)
1720 - Added implementation of StreamInfo() to com 1562 - Added implementation of StreamInfo() to comply with new interface for
1721 G4VSolid in "geommng-V04-01-03". 1563 G4VSolid in "geommng-V04-01-03".
1722 - Created .icc files for G4EllipticalTube, G4 1564 - Created .icc files for G4EllipticalTube, G4Polyhedra and G4Polycone.
1723 - Some cosmetic changes to code formatting: r 1565 - Some cosmetic changes to code formatting: removed <TAB> characters and adopt
1724 uniform code indentation. 1566 uniform code indentation.
1725 1567
1726 08-May-2002, J.Allison (geom-solids-specific- 1568 08-May-2002, J.Allison (geom-solids-specific-V04-00-01)
1727 - Implemented G4EllipticalTube::CreatePolyhed 1569 - Implemented G4EllipticalTube::CreatePolyhedron.
1728 1570
1729 10-Jan-2002, G.Cosmo (geom-solids-specific-V0 1571 10-Jan-2002, G.Cosmo (geom-solids-specific-V04-00-00)
1730 - Updated unit tests. 1572 - Updated unit tests.
1731 1573
1732 20-Apr-2001, G.Cosmo (geom-solids-specific-V0 1574 20-Apr-2001, G.Cosmo (geom-solids-specific-V03-01-00)
1733 - Migration to STL vector: 1575 - Migration to STL vector:
1734 o In G4ClippablePolygon, migrated G4ThreeVe 1576 o In G4ClippablePolygon, migrated G4ThreeVectorList typedef and
1735 made private to class. 1577 made private to class.
1736 << 1578
1737 03-Apr-2001, D.Williams (geom-solids-specifi 1579 03-Apr-2001, D.Williams (geom-solids-specific-V03-00-01)
1738 ----------------------- 1580 -----------------------
1739 - G4IntersectingCone.cc: make small adjustmen 1581 - G4IntersectingCone.cc: make small adjustment to help with roundoff error
1740 in LineHitsCone1() and LineHitsCone2(). 1582 in LineHitsCone1() and LineHitsCone2().
1741 1583
1742 08-Jan-2001, D.Williams (geom-solids-specifi 1584 08-Jan-2001, D.Williams (geom-solids-specific-V03-00-00)
1743 ----------------------- 1585 -----------------------
1744 - G4Hype.cc: Added protecton against zero v.z 1586 - G4Hype.cc: Added protecton against zero v.z in DistanceToOut.
1745 1587
1746 20-Nov-2000, G.Cosmo (geom-solids-specifi 1588 20-Nov-2000, G.Cosmo (geom-solids-specific-V02-00-04)
1747 --------------------- 1589 ---------------------
1748 - Fixes to remove warnings from "-Wall -ansi 1590 - Fixes to remove warnings from "-Wall -ansi -pedantic" g++ compiler options:
1749 o commented out variables declared and not 1591 o commented out variables declared and not used.
1750 o fixed declaration of variables used befor 1592 o fixed declaration of variables used before being initialised.
1751 o fixed order of initialisation of member d 1593 o fixed order of initialisation of member data in constructors.
1752 o fixed usage of unsigned-int (size_t) for 1594 o fixed usage of unsigned-int (size_t) for array indeces.
1753 1595
1754 13-Nov-2000, G.Cosmo (geom-solids-specifi 1596 13-Nov-2000, G.Cosmo (geom-solids-specific-V02-00-03)
1755 -------------------- 1597 --------------------
1756 - Added definition of empty constructor for G 1598 - Added definition of empty constructor for G4ClippablePolygon which
1757 went lost by mistake... 1599 went lost by mistake...
1758 1600
1759 02-Nov-2000, G.Cosmo (geom-solids-specifi 1601 02-Nov-2000, G.Cosmo (geom-solids-specific-V02-00-02)
1760 -------------------- 1602 --------------------
1761 - QA code revision and cleanup (+fixes from C 1603 - QA code revision and cleanup (+fixes from CodeWizard filtering):
1762 o Avoid inline virtual methods. 1604 o Avoid inline virtual methods.
1763 o General cosmetics for Software Reference 1605 o General cosmetics for Software Reference Manual.
1764 1606
1765 23-Oct-2000, D.Williams (geom-solids-specifi 1607 23-Oct-2000, D.Williams (geom-solids-specific-V02-00-01)
1766 ----------------------- 1608 -----------------------
1767 - G4IntersectingCone.cc: the check for a zero 1609 - G4IntersectingCone.cc: the check for a zero radical has been adjusted to be
1768 less sensitive to round off error in LineHi 1610 less sensitive to round off error in LineHitsCone1(), LineHitsCone2().
1769 This fixes a problem discovered in BaBar. 1611 This fixes a problem discovered in BaBar.
1770 1612
1771 12-Sep-2000, G.Cosmo (geom-solids-specific-V 1613 12-Sep-2000, G.Cosmo (geom-solids-specific-V02-00-00)
1772 -------------------- 1614 --------------------
1773 - Organised comments to headers for Software 1615 - Organised comments to headers for Software Reference Manual.
1774 1616
1775 27-Jun-2000, G.Cosmo (geom-solids-specific-V 1617 27-Jun-2000, G.Cosmo (geom-solids-specific-V01-01-02)
1776 -------------------- 1618 --------------------
1777 - G4Polycone[.hh.cc]: better fix for bug-repo 1619 - G4Polycone[.hh.cc]: better fix for bug-report #110.
1778 Removed struct and replaced with class. 1620 Removed struct and replaced with class.
1779 1621
1780 26-Jun-2000, G.Cosmo (geom-solids-specific-V 1622 26-Jun-2000, G.Cosmo (geom-solids-specific-V01-01-01)
1781 -------------------- 1623 --------------------
1782 - G4Polycone.cc: fixed memory leak by invokin 1624 - G4Polycone.cc: fixed memory leak by invoking destruction of member
1783 enclosingCylinder, which was not cleaned up 1625 enclosingCylinder, which was not cleaned up in the destructor.
1784 This fixes problem report #107. 1626 This fixes problem report #107.
1785 - G4Polycone.hh: added forward declaration of 1627 - G4Polycone.hh: added forward declaration of struct G4PolyconeHistorical
1786 and made it friend, for porting on KCC --st 1628 and made it friend, for porting on KCC --strict. This fixes report #110.
1787 - G4Polyhedra.hh: fixed typo in method name. 1629 - G4Polyhedra.hh: fixed typo in method name. Changed GetNumSIde() to
1788 GetNumSide(). This fixes problem report #10 1630 GetNumSide(). This fixes problem report #105.
1789 1631
1790 08-Jun-2000, G.Gracia 1632 08-Jun-2000, G.Gracia
1791 --------------------- 1633 ---------------------
1792 - G4VCSGfaceted.cc: fix for Win/NT in functio 1634 - G4VCSGfaceted.cc: fix for Win/NT in function GetExtent().
1793 1635
1794 27-Apr-2000, G.Cosmo 1636 27-Apr-2000, G.Cosmo
1795 -------------------- 1637 --------------------
1796 - Removed dependency over the CSG domain in G 1638 - Removed dependency over the CSG domain in GNUmakefile.
1797 1639
1798 18-Apr-2000, D.Williams 1640 18-Apr-2000, D.Williams
1799 ----------------------- 1641 -----------------------
1800 - Removed meaningless "const" specifiers from 1642 - Removed meaningless "const" specifiers from methods in G4ClippablePolygon,
1801 and G4EllipticalTube. 1643 and G4EllipticalTube.
1802 - G4EllipticalTube, G4Hype and G4VCSGfaceted 1644 - G4EllipticalTube, G4Hype and G4VCSGfaceted now inherit directly
1803 from G4VSolid (before was G4CSGSolid). 1645 from G4VSolid (before was G4CSGSolid).
1804 - Reintroduced GetExtent() in G4EllipticalTub 1646 - Reintroduced GetExtent() in G4EllipticalTube, G4Hype and G4VCSGfaceted
1805 (in principle, not needed). 1647 (in principle, not needed).
1806 - Modified assertations in unit test testG4Hy 1648 - Modified assertations in unit test testG4Hype.cc.
1807 1649
1808 11-Apr-2000, J.Allison 1650 11-Apr-2000, J.Allison
1809 ---------------------- 1651 ----------------------
1810 - Removed implementations of GetExtent in mos 1652 - Removed implementations of GetExtent in most sub-classes of G4VSolid (a
1811 default implementation exists in G4VSolid). 1653 default implementation exists in G4VSolid).
1812 - All implementations of DescribeYourselfTo ( 1654 - All implementations of DescribeYourselfTo (G4VGraphicsScene& scene) const
1813 now correctly written: scene.AddThis(*this) 1655 now correctly written: scene.AddThis(*this).
1814 1656
1815 05-Apr-2000, G.Cosmo (geom-solids-specific- 1657 05-Apr-2000, G.Cosmo (geom-solids-specific-V01-01-00)
1816 -------------------- 1658 --------------------
1817 - Restructured solids/CSG domain, by moving t 1659 - Restructured solids/CSG domain, by moving to "specific" the following
1818 classes: G4ClippablePolygon, G4EnclosingCyl 1660 classes: G4ClippablePolygon, G4EnclosingCylinder, G4Hype, G4PolyPhiFace,
1819 G4Polycone, G4PolyconeSide, G4Polyhedra, G4 1661 G4Polycone, G4PolyconeSide, G4Polyhedra, G4PolyhedraSide, G4ReduciblePolygon,
1820 G4IntersectingCone, G4SolidExtentList, G4VC 1662 G4IntersectingCone, G4SolidExtentList, G4VCSGface, G4VCSGfaceted.
1821 The new module's library for "specific" is 1663 The new module's library for "specific" is now called 'G4specsolids'.
1822 - Created specific/test directory and moved t 1664 - Created specific/test directory and moved testG4Hype.cc and testG4Polycone,cc
1823 from CSG/test. 1665 from CSG/test.
1824 - Organised class description comments for th 1666 - Organised class description comments for the Software Reference Manual
1825 and added CVS headers to files. 1667 and added CVS headers to files.
1826 1668
1827 29-Mar-2000, D.Williams 1669 29-Mar-2000, D.Williams
1828 ----------------------- 1670 -----------------------
1829 - Added first implementation of G4EllipticalT 1671 - Added first implementation of G4EllipticalTube.
1830 It defines a simple elliptical tube, as in 1672 It defines a simple elliptical tube, as in geant3 "ELTU".
1831 Files introduced: G4EllipticalTube[.hh.cc]. 1673 Files introduced: G4EllipticalTube[.hh.cc].
1832 1674
1833 25-Mar-2000, G.Cosmo 1675 25-Mar-2000, G.Cosmo
1834 -------------------- 1676 --------------------
1835 - History file created. 1677 - History file created.