Geant4 Cross Reference |
1 # Category geom-specific History << 1 ------------------------------------------------------------------- 2 2 3 See `CONTRIBUTING.rst` for details of **requir << 3 ========================================================= 4 which **must** added in reverse chronological << 4 Geant4 - an Object-Oriented Toolkit for Simulation in HEP 5 It must **not** be used as a substitute for wr << 5 ========================================================= 6 << 6 7 ---------------------------------------------- << 7 Sub-Category History file 8 << 8 ------------------------- 9 ## 2024-10-01 Evgueni Tcherniaev (geom-specifi << 9 This file should be used by G4 developers and category coordinators 10 - G4GenericTrap: Fixed minor defect reported b << 10 to briefly summarize all major modifications introduced in the code 11 << 11 and keep track of all directory-tags. 12 ## 2024-07-18 Alvaro Tolosa-Delgado (geom-spec << 12 It DOES NOT substitute the log-message one should put at every 13 - Remove internal state of G4TwistedTubs and G << 13 committal in the source repository ! 14 << 14 15 ## 2024-07-10 Evgueni Tcherniaev (geom-specifi << 15 ---------------------------------------------------------- 16 - G4ExtrudedSolid: Fixed defects reported by C << 16 * Reverse chronological order (last date on top), please * 17 << 17 ---------------------------------------------------------- 18 ## 2024-07-08 Gabriele Cosmo (geom-specific-V1 << 19 - Fixed reported Coverity defect; in G4Voxeliz << 20 plain vector copy in methods BuildReduceVoxe << 21 BuildBoundaries() and CreateMiniVoxels(..). << 22 << 23 ## 2024-05-29 Evgueni Tcherniaev (geom-specifi << 24 - Added new methods GetNumOfConstituents() and << 25 << 26 ## 2024-05-27 Evgueni Tcherniaev (geom-specifi << 27 - Completely revised G4GeneriTrap, it addresse << 28 << 29 ## 2024-05-26 Evgueni Tcherniaev (geom-specifi << 30 - New testG4GenericTrap.cc << 31 << 32 ## 2024-04-02 Gabriele Cosmo (geom-specific-V1 << 33 - Applied trivial clang-tidy fixes to classes, << 34 'default' keywords. << 35 << 36 ## 2024-02-01 Gabriele Cosmo (geom-specific-V1 << 37 - Use std::size_t for array sizes in G4Polyhed << 38 << 39 ## 2023-07-10 Evgueni Tcherniaev (geom-specifi << 40 - Fixed bounding box calculation in G4VTwisted << 41 << 42 ## 2023-06-16 Stephan Hageboeck (geom-specific << 43 - Fix an uninitialised value in G4VCSGfaceted: << 44 << 45 ## 2023-06-12 Gabriele Cosmo (geom-specific-V1 << 46 - Use const iterator in G4Voxelizer::GetPointV << 47 - Fixed use of index in G4Tet::GetPointOnSurfa << 48 << 49 ## 2023-05-10 Gabriele Cosmo (geom-specific-V1 << 50 - Applied clang-tidy fixes (readability, moder << 51 << 52 ## 2023-03-20 Gabriele Cosmo (geom-specific-V1 << 53 - Fixed more potential uninitialised values in << 54 G4SolidExtentList and G4VTwistSurface. << 55 << 56 ## 2023-03-13 Gabriele Cosmo (geom-specific-V1 << 57 - Fixed potential uninitialised value for boun << 58 G4VTwistSurface::GetBoundaryAtPZ(). << 59 << 60 ## 2023-01-02 Evgueni Tcherniaev (geom-specifi << 61 - G4QuadrangularFacet: Fixed warning message << 62 << 63 ## 2022-11-10 Gabriele Cosmo (geom-specific-V1 << 64 - Fixed compilation warnings for implicit type << 65 << 66 ## 2022-10-05 Gabriele Cosmo (geom-specific-V1 << 67 - Fixed compilation warnings in Intel/icx comp << 68 but never used. << 69 << 70 ## 2022-04-03 Evgueni Tcherniaev (geom-specifi << 71 - G4GenericTrap.cc, G4UGenericTrap.cc, G4UExtr << 72 G4TessellatedSolid.cc, G4TessellatedSolid.cc << 73 revision of CreatePolyhedron() << 74 << 75 ## 2022-02-04 Evgueni Tcherniaev (geom-specifi << 76 - G4VTwistedFaceted: used numerical evaluation << 77 integral to calculate lateral face surface a << 78 << 79 ## 2022-02-01 Evgueni Tcherniaev (geom-specifi << 80 - G4ExtrudedSolid, G4UExtrudedSolid: added def << 81 parameters in the constructor with two z-sec << 82 - G4ExtrudedSolid::ZSection, G4UExtrudedSolid: << 83 added default constructor << 84 << 85 ## 2022-01-26 Evgueni Tcherniaev (geom-specifi << 86 - G4GenericTrap::GetCubicVolume(): calculation << 87 using analytical expression; removed private << 88 GetFaceCubicVolume(); << 89 - G4GenericTrap::GetSurfaceArea(): improved ca << 90 of the area of lateral faces; private functi << 91 GetFaceSurfaceArea(), GetTwistedFaceSurfaceA << 92 replaced with private function GetLateralFac << 93 << 94 ## 2022-01-21 Evgueni Tcherniaev (geom-specifi << 95 - G4Ellipsoid::LateralSurfaceArea(): Enhanced << 96 the lateral surface area << 97 << 98 ## 2022-01-11 Evgueni Tcherniaev (geom-specifi << 99 - G4VTwistedFaceted: fCubicVolume, fSurfaceAre << 100 GetCubicVolume(), GetSurfaceArea() moved to << 101 - G4VTwistedFaceted, G4TwistedBox, G4TwistedTr << 102 calculation of volume and surface area << 103 << 104 ## 2022-01-06 Evgueni Tcherniaev (geom-specifi << 105 - G4TwistedTubs: Implemented GetSurfaceArea() << 106 analytical expressions; added private functi << 107 GetLateralArea() and GetPhiCutArea() << 108 << 109 ## 2021-12-19 Evgueni Tcherniaev (geom-specifi << 110 - G4Hype: Used analytical expression in GetCub << 111 and GetSurfaceArea() << 112 << 113 ## 2021-12-10 Ben Morgan (geom-specific-V11-00 << 114 - Change to new Markdown History format << 115 << 116 --- << 117 << 118 # History entries prior to 11.0 << 119 << 120 03-December-2021 E.Tcherniaev (geom-speci << 121 - G4TwistedTubs: Accurate calculation of the b << 122 BoundingLimits() and GetExtent(), fixing mea << 123 penalty. Addressing problem report #2450. << 124 - G4TwistedTubs, G4VTwistedFaceted: Fixed GetC << 125 << 126 15-October-2021 E.Tcherniaev (geom-speci << 127 - G4Tet, G4UTet: Added SetBoundingLimits() << 128 << 129 06-October-2021 E.Tcherniaev (geom-speci << 130 - G4Tet: some changes in calculation of boundi << 131 - G4UTet: added CheckDegeneracy() and SetVerti << 132 << 133 27-September-2021 E.Tcherniaev (geom-speci << 134 - Added degeneracyFlag to the list of paramete << 135 it addresses first part of the problem repor << 136 << 137 24-September-2021 E.Tcherniaev (geom-speci << 138 - Implemented G4TesselatedSolid::GetFacetIndex << 139 << 140 10-September-2021 E.Tcherniaev (geom-speci << 141 - Implemented G4TesselatedSolid::CheckStructur << 142 - Optimisation in G4TessellatedSolid::SetExtre << 143 shuffle of vertices and checking of six extr << 144 << 145 21-July-2021 E.Tcherniaev (geom-speci << 146 - More accurate calculation of distance from p << 147 in G4TriangularFacet, it addresses problem r << 148 << 149 25-June-2021 G.Cosmo (geom-speci << 150 - Added missing accessor in G4UTet. << 151 << 152 12-May-2021 E.Tcherniaev (geom-speci << 153 - Reimplemented CreatePolyhedron() in << 154 G4Polyhedra, G4Polycone, G4GenericPolycone, << 155 G4UPolyhedra, G4UPolycone, G4UGenericPolycon << 156 << 157 30-April-2021 G.Cosmo (geom-speci << 158 - Fixed use of conversion factor in G4UPolyhed << 159 polyhedra constructs. << 160 << 161 19-April-2021 E.Tcherniaev (geom-speci << 162 - G4Polyhedra, G4Polycone: Fix calculation of << 163 of negative phiStart, it addresses also prob << 164 << 165 30-March-2021 B.Morgan (geom-speci << 166 - Migrate sources.cmake to modular build API << 167 << 168 18-March-2021 E.Tcherniaev (geom-speci << 169 - Fix calculation of bounding box position in << 170 it addresses problem report #2301 << 171 << 172 13-January-2021 G.Cosmo (geom-speci << 173 - Reduce cases of bad speculation in G4Polyhed << 174 G4PolyPhiFace::InsideEdges(), based on repor << 175 by G.Amadio. << 176 << 177 30-October-2020 E.Tcherniaev (geom-speci << 178 - G4Polycone: Revised GetPointOnSurface(); << 179 Added protected auxiliary method SetSurfaceE << 180 Removed GetPointOnCone(), GetPointOnTubs(), << 181 - G4GenericPolycone: Revised GetPointOnSurface << 182 Added protected auxiliary method SetSurfaceE << 183 - G4Polyhedra: Revised GetPointOnSurface(); << 184 Added protected auxiliary method SetSurfaceE << 185 Removed GetPointOnPlane(), GetPointOnTriangl << 186 << 187 01-October-2020 E.Tcherniaev (geom-speci << 188 - G4Polycone, G4GenericPolycone, G4Polyhedra: << 189 implemented GetSurfaceArea(), GetCubicVolume << 190 << 191 May 21, 2020 Guilherme Lima (geom-speci << 192 ---------------------------- << 193 - Fix constructor signatures in G4UExtrudedSol << 194 There were missing const and reference quali << 195 << 196 30-April-2020 G.Cosmo (geom-speci << 197 - Adopt new convention for location of headers << 198 << 199 09-April-2020 E.Tcherniaev (geom-speci << 200 - Added G4GenericTrap::GetTwistedFaceSurfaceAr << 201 - testG4GenericTrap.cc: fixed test for calcula << 202 - testG4ExtrudedSolid.cc: fixed assert stateme << 203 point flys along the surface (DistanceToIn() << 204 << 205 17-January-2020 E.Tcherniaev (geom-speci << 206 - Implemented G4Tet::SetVertices(), it address << 207 at Geant4 Technical Forum. << 208 << 209 14-January-2020 Gabriele Cosmo (geom-speci << 210 - Added protection in G4VFacet header for doub << 211 symbols from Windows Kits code. << 212 << 213 08-January-2020 E.Tcherniaev (geom-speci << 214 - Complete revision of G4Tet, speed up, new te << 215 It also fixes issues spotted by new unit tes << 216 << 217 16-December-2019 E.Tcherniaev (geom-speci << 218 - Complete revision of G4Ellipsoid, it fixes i << 219 implementation, in particular it addresses p << 220 30%-70% speed-up in all main methods. << 221 << 222 11-December-2019 B.Morgan (geom-speci << 223 - Cleanup CMake build, removing obsolete granu << 224 explicit include_directories. << 225 << 226 10-December-2019 G.Cosmo (geom-speci << 227 - Re-established parameterisation mechanism fo << 228 removed by mistake. Addressing problem repor << 229 << 230 26-November-2019 G.Cosmo (geom-speci << 231 - Fixed cases of implicit type conversions fro << 232 << 233 05-November-2019 E.Tcherniaev (geom-speci << 234 - G4TesselatedSolid.cc: fixed minor Coverity d << 235 << 236 07-October-2019 E.Tcherniaev (geom-speci << 237 - G4TesselatedSolid.cc: fixed minor Coverity d << 238 << 239 16-September-2019 G.Cosmo (geom-speci << 240 - Rationalise header inclusions for faceted so << 241 << 242 06-September-2019 G.Cosmo (geom-speci << 243 - Removed unnecessary forward declaration in G << 244 << 245 29-August-2019 G.Cosmo (geom-speci << 246 - Minor c++11 revision and headers cleanup. Co << 247 - Use pre-increment wherever possible. << 248 << 249 19-August-2019 G.Lima (geom-speci << 250 - G4ExtrudedSolid: fixed a bug in DistanceToOu << 251 defined off-center along the z-axis. << 252 << 253 19-August-2019 G.Cosmo (geom-speci << 254 - G4GenericTrap: fixed compilation warnings fo << 255 << 256 13-August-2019 G.Cosmo (geom-speci << 257 - Enabled wrappers for VecGeom implementation << 258 G4EllipticalCone and G4Ellipsoid. << 259 << 260 10-July-2019 E.Tcherniaev (geom-speci << 261 - Fixed G4UExtrudedSolid::CreatePolyhedron(). << 262 Addressing visualization part of the problem << 263 << 264 04-July-2019 G.Cosmo (geom-speci << 265 - Avoid defining kCarTolerance as 'static cons << 266 Addressing problem report #2172. << 267 << 268 11-June-2019 E.Tcherniaev (geom-speci << 269 - Use GetVertices() instead of GetParametersLi << 270 << 271 29-May-2019 G.Cosmo (geom-speci << 272 - Fixed minor Coverity defects. << 273 << 274 20-May-2019 G.Cosmo (geom-speci << 275 - Defined move constructor and move assignment << 276 << 277 14-May-2019 B.Morgan (geom-speci << 278 - Add inclusion of new G4GeomTypes.hh header t << 279 VecGeom replacement. << 280 - See also geommng-10-05-05 << 281 << 282 23-April-2019 G.Cosmo (geom-speci << 283 - Modified G4PolyconeSide and G4PolyhedraSide << 284 MT splitted data in G4PlSideData and G4PhSid << 285 << 286 16-April-2019 G.Cosmo (geom-speci << 287 - Protected check in G4TwistTubsSide::Distance << 288 << 289 4-April-2019 G.Cosmo (geom-speci << 290 - Enabled wrapper for VecGeom implementation o << 291 << 292 15-February-2019 E.Tcherniaev (geom-speci << 293 - Accurate calculation of radical in G4Interse << 294 It addresses the problem report #2111. << 295 << 296 4-February-2019 G.Cosmo (geom-speci << 297 - Fix in G4EllipticalTube::CheckParameters() f << 298 << 299 30-January-2019 G.Cosmo (geom-speci << 300 - Disabled precise computation of extent and u << 301 in CalculateExtent() for G4Tet and G4Tessell << 302 intialisation in setups with relatively comp << 303 - Apply bounding-box calculation for extent al << 304 VecGeom wrappers. << 305 << 306 24-January-2019 E.Tcherniaev (geom-speci << 307 - Completely revised, more robust and performa << 308 new exhaustive test/testEllipticalTube.cc ba << 309 18 310 20-September-2018 G.Cosmo (geom-speci 19 20-September-2018 G.Cosmo (geom-specific-V10-04-15) 311 - Make G4UPolycone wrapper inheriting from vec 20 - Make G4UPolycone wrapper inheriting from vecgeom::GenericUnplacedPolycone, 312 following the latest changes in VecGeom. 21 following the latest changes in VecGeom. 313 22 314 13-September-2018 G.Cosmo (geom-speci 23 13-September-2018 G.Cosmo (geom-specific-V10-04-14) 315 - G4UTessellatedSolid, G4UExtrudedSolid: remov 24 - G4UTessellatedSolid, G4UExtrudedSolid: removed leftover use of 316 UVector3 and replaced with U3Vector. 25 UVector3 and replaced with U3Vector. 317 26 318 23-August-2018 G.Cosmo (geom-speci 27 23-August-2018 G.Cosmo (geom-specific-V10-04-13) 319 - Enabled VecGeom wrapper for G4Tet. 28 - Enabled VecGeom wrapper for G4Tet. 320 29 321 10-August-2018 A.Gheata (geom-speci 30 10-August-2018 A.Gheata (geom-specific-V10-04-12) 322 - Make G4UHype wrapper inheriting from vecgeom 31 - Make G4UHype wrapper inheriting from vecgeom::GenericUnplacedHype, 323 following the latest changes in VecGeom. 32 following the latest changes in VecGeom. 324 33 325 12-July-2018 G.Cosmo (geom-speci 34 12-July-2018 G.Cosmo (geom-specific-V10-04-11) 326 - Removed G4SolidsWorkspacePool class. Adapted 35 - Removed G4SolidsWorkspacePool class. Adapted G4SolidsWorkspace to 327 use templated class G4TWorkspacePool. 36 use templated class G4TWorkspacePool. 328 - Coworks with tags in geometry/volumes, run a 37 - Coworks with tags in geometry/volumes, run and visualization/management. 329 38 330 25-Jun-2018 G.Cosmo (geom-speci 39 25-Jun-2018 G.Cosmo (geom-specific-V10-04-10) 331 - Use dynamic_cast to attempt fix for spurious 40 - Use dynamic_cast to attempt fix for spurious compilation warnings on 332 CentOS7/gcc-5.3 on G4UTessellatedSolid wrapp 41 CentOS7/gcc-5.3 on G4UTessellatedSolid wrapper. 333 42 334 17-May-2018 J.Madsen (geom-speci 43 17-May-2018 J.Madsen (geom-specific-V10-04-09) 335 - Updated "thread-local-static-var" model to 44 - Updated "thread-local-static-var" model to 336 "function-returning-thread-local-static-refe 45 "function-returning-thread-local-static-reference" model 337 which fixes Windows DLL + MT 46 which fixes Windows DLL + MT 338 47 339 11-April-2018 G.Cosmo (geom-speci 48 11-April-2018 G.Cosmo (geom-specific-V10-04-08) 340 - Replaced USOLIDS_LIBRARIES with VECGEOM_LIBR 49 - Replaced USOLIDS_LIBRARIES with VECGEOM_LIBRARIES in sources.cmake. 341 50 342 13-February-2018 E.Tcherniaev (geom-speci 51 13-February-2018 E.Tcherniaev (geom-specific-V10-04-07) 343 - Corrected conversion of input parameters to 52 - Corrected conversion of input parameters to internal structure (used for 344 caching for adoption in GDML persistency) in 53 caching for adoption in GDML persistency) in G4UPolycone and G4UPolyhedra 345 wrappers. 54 wrappers. 346 55 347 9-February-2018 G.Cosmo (geom-speci 56 9-February-2018 G.Cosmo (geom-specific-V10-04-06) 348 - Caching facets and vertices in G4UTessellate 57 - Caching facets and vertices in G4UTessellatedSolid wrapper for properly 349 treating indexing in facets. 58 treating indexing in facets. 350 59 351 31-January-2018 G.Cosmo (geom-speci 60 31-January-2018 G.Cosmo (geom-specific-V10-04-05) 352 - Corrected use of facets indeces in G4UTessel 61 - Corrected use of facets indeces in G4UTessellatedSolid for visualization. 353 - Minor cleanup in G4TessellatedSolid::CreateP 62 - Minor cleanup in G4TessellatedSolid::CreatePolyhedron(), no functional 354 changes. 63 changes. 355 64 356 15-January-2018 G.Cosmo (geom-speci 65 15-January-2018 G.Cosmo (geom-specific-V10-04-04) 357 - Added validity checks in G4UTessellatedSolid 66 - Added validity checks in G4UTessellatedSolid::AddFacet(). 358 67 359 11-January-2018 G.Cosmo (geom-speci 68 11-January-2018 G.Cosmo (geom-specific-V10-04-03) 360 - Added and enabled VecGeom wrapper for G4Tess 69 - Added and enabled VecGeom wrapper for G4TessellatedSolid. 361 Requires tags cmake-V10-04-01 and config-V10 70 Requires tags cmake-V10-04-01 and config-V10-04-00. 362 71 363 20-December-2017 G.Cosmo (geom-speci 72 20-December-2017 G.Cosmo (geom-specific-V10-04-02) 364 - Enabled VecGeom wrappers for G4ExtrudedSolid 73 - Enabled VecGeom wrappers for G4ExtrudedSolid and G4Hype. 365 74 366 13-December-2017 E.Tcherniaev (geom-speci 75 13-December-2017 E.Tcherniaev (geom-specific-V10-04-01) 367 - Removed redundant data initialistion in G4Ex << 76 - Removed redundant data initialistion in G4ExtrudedSolid constructors. 368 77 369 11-December-2017 E.Tcherniaev (geom-speci 78 11-December-2017 E.Tcherniaev (geom-specific-V10-04-00) 370 - Added missing initialisation of two data-mem 79 - Added missing initialisation of two data-members in copy-ctor and 371 assignment operator of G4ExtrudedSolid. Addr 80 assignment operator of G4ExtrudedSolid. Addressing problem report #2016. 372 81 373 22-November-2017 G.Cosmo (geom-specif 82 22-November-2017 G.Cosmo (geom-specific-V10-03-25) 374 - Fix in SurfaceNormal() for G4ExtrudedSolid t 83 - Fix in SurfaceNormal() for G4ExtrudedSolid to assure explicit 375 counting of the surfaces where the point is 84 counting of the surfaces where the point is placed on edg 376 85 377 2-November-2017 G.Cosmo (geom-specif 86 2-November-2017 G.Cosmo (geom-specific-V10-03-24) 378 - Fixed compilation warning introduced with la 87 - Fixed compilation warning introduced with last tag. 379 88 380 31-October-2017 E.Tcherniaev (geom-specif 89 31-October-2017 E.Tcherniaev (geom-specific-V10-03-23) 381 - Added specialised implementation for constru 90 - Added specialised implementation for constructs defining a non-convex right 382 prism in G4ExtrudedSolid. 91 prism in G4ExtrudedSolid. 383 92 384 20-October-2017 G.Cosmo (geom-specif 93 20-October-2017 G.Cosmo (geom-specific-V10-03-22) 385 - G4TessellatedSolid: print also solid's name 94 - G4TessellatedSolid: print also solid's name in StreamInfo(). 386 95 387 17-October-2017 G.Cosmo (geom-specif 96 17-October-2017 G.Cosmo (geom-specific-V10-03-21) 388 - Added VecGeom wrapper G4UHype for G4Hype, no 97 - Added VecGeom wrapper G4UHype for G4Hype, not yet activated, pending 389 fixes in VecGeom. 98 fixes in VecGeom. 390 99 391 16-October-2017 G.Cosmo (geom-specif 100 16-October-2017 G.Cosmo (geom-specific-V10-03-20) 392 - Temporarly disabled wrappers for G4Tet and G 101 - Temporarly disabled wrappers for G4Tet and G4GenericPolycone, pending 393 their corresponding implementation in VecGeo 102 their corresponding implementation in VecGeom. 394 103 395 28-September-2017 G.Cosmo (geom-specif 104 28-September-2017 G.Cosmo (geom-specific-V10-03-19) 396 - Corrected initialisation of polyhedra by ver 105 - Corrected initialisation of polyhedra by vertices in G4UPolyhdra wrapper 397 following the changes in VecGeom. 106 following the changes in VecGeom. 398 107 399 15-September-2017 G.Cosmo (geom-specif 108 15-September-2017 G.Cosmo (geom-specific-V10-03-18) 400 - G4SolidsWorkspacePool: use DLL export flag f 109 - G4SolidsWorkspacePool: use DLL export flag for static thread-local 401 symbol of the workspace. 110 symbol of the workspace. 402 111 403 12-September-2017 G.Cosmo (geom-specif 112 12-September-2017 G.Cosmo (geom-specific-V10-03-17) 404 - G4Voxelizer: directly set components for bou 113 - G4Voxelizer: directly set components for bounding-box instead of 405 recreating it in BuildBoundingBox(..). 114 recreating it in BuildBoundingBox(..). 406 115 407 8-September-2017 E.Tcherniaev (geom-specif 116 8-September-2017 E.Tcherniaev (geom-specific-V10-03-16) 408 - Added specialised implementation for constru 117 - Added specialised implementation for constructs defining a convex right 409 prism in G4ExtrudedSolid. 118 prism in G4ExtrudedSolid. 410 119 411 4-September-2017 G.Cosmo (geom-specif 120 4-September-2017 G.Cosmo (geom-specific-V10-03-15, 14) 412 - Temporarly disabled wrapper for extruded-sol 121 - Temporarly disabled wrapper for extruded-solid, pending implementation 413 of extruded-solid in VecGeom. 122 of extruded-solid in VecGeom. 414 123 415 16-August-2017 J.Allison (geom-specif 124 16-August-2017 J.Allison (geom-specific-V10-03-13) 416 - Twisted solids: Fixed bug in drawing polyhed 125 - Twisted solids: Fixed bug in drawing polyhedra with negative twist angle. 417 Addressing problem report #1995. 126 Addressing problem report #1995. 418 127 419 27-July-2017 E.Tcherniaev (geom-specif 128 27-July-2017 E.Tcherniaev (geom-specific-V10-03-12) 420 - G4EllipticalCone: corrected samping of rando 129 - G4EllipticalCone: corrected samping of random points on lateral surface in 421 function GetPointOnSurface(). 130 function GetPointOnSurface(). 422 131 423 24-July-2017 E.Tcherniaev (geom-specif 132 24-July-2017 E.Tcherniaev (geom-specific-V10-03-11) 424 - G4EllipticalCone: improved GetPointOnSurface 133 - G4EllipticalCone: improved GetPointOnSurface() to have uniform sampling of 425 points, using function G4RandomPointOnEllips 134 points, using function G4RandomPointOnEllipse(). 426 135 427 20-July-2017 E.Tcherniaev (geom-specif 136 20-July-2017 E.Tcherniaev (geom-specific-V10-03-10, 09) 428 - G4EllipticalCone: reviewed implementation of 137 - G4EllipticalCone: reviewed implementation of Inside(), DistanceToIn/Out(p), 429 SurfaceNormal() and GetPointOnSurface(); mad 138 SurfaceNormal() and GetPointOnSurface(); made more compact and performant. 430 Addressing problem report #1974. 139 Addressing problem report #1974. 431 140 432 15-June-2017 G.Cosmo (geom-specif 141 15-June-2017 G.Cosmo (geom-specific-V10-03-08) 433 - Enabled adapter also in G4UPolycone wrapper. 142 - Enabled adapter also in G4UPolycone wrapper. 434 - Added check on open solid for G4UPolyhedra w 143 - Added check on open solid for G4UPolyhedra wrapper. 435 144 436 6-June-2017 G.Cosmo (geom-specif 145 6-June-2017 G.Cosmo (geom-specific-V10-03-07) 437 - Enable adapter for VecGeom shapes in G4U* wr 146 - Enable adapter for VecGeom shapes in G4U* wrappers for: paraboloid, 438 polyhedra and GenericTrap. From now on, wrap 147 polyhedra and GenericTrap. From now on, wrappers depends directly on 439 VecGeom shapes implementation. USolids API i 148 VecGeom shapes implementation. USolids API is deprecated and no longer 440 supported. 149 supported. 441 150 442 24-May-2017 G.Cosmo (geom-specif 151 24-May-2017 G.Cosmo (geom-specific-V10-03-06) 443 - Renamed ambiguous name Extent() in all solid 152 - Renamed ambiguous name Extent() in all solids and G4U* wrappers to 444 BoundingLimits(). Change required in order t 153 BoundingLimits(). Change required in order to avoid signature conflict 445 with VecGeom in G4U* wrappers. 154 with VecGeom in G4U* wrappers. 446 Requires tag geommng-V10-03-16. 155 Requires tag geommng-V10-03-16. 447 156 448 11-May-2017 G.Cosmo (geom-specif 157 11-May-2017 G.Cosmo (geom-specific-V10-03-05) 449 - Removed potential race condition in G4VTwist 158 - Removed potential race condition in G4VTwistSurface::AmIOnLeftSide(). 450 Addressing problem report #1972. 159 Addressing problem report #1972. 451 160 452 7-April-2017 G.Cosmo (geom-specif 161 7-April-2017 G.Cosmo (geom-specific-V10-03-04) 453 - Renamed G4SurfaceVoxelizer to G4Voxelizer an 162 - Renamed G4SurfaceVoxelizer to G4Voxelizer and extended to support 454 voxelisation of shapes in 3D space. Adapted 163 voxelisation of shapes in 3D space. Adapted G4TessellatedSolid accordingly. 455 164 456 13-March-2017 G.Cosmo (geom-specif 165 13-March-2017 G.Cosmo (geom-specific-V10-03-03) 457 - G4SolidsWorkspacePool: implemented CleanUpAn 166 - G4SolidsWorkspacePool: implemented CleanUpAndDestroyAllWorkspaces(), 458 to be called by worker threads. Removed decl 167 to be called by worker threads. Removed declaration (i.e. not implemented) 459 of protected method ReleaseAndDestroyWorkspa 168 of protected method ReleaseAndDestroyWorkspace(). 460 169 461 2-March-2017 E.Tcherniaev (geom-specif 170 2-March-2017 E.Tcherniaev (geom-specific-V10-03-02) 462 - Fixed possible rounding off error in calcula 171 - Fixed possible rounding off error in calculation of 'astep' (max angle 463 for one step) in CalculateExtent() for G4Pol 172 for one step) in CalculateExtent() for G4Polycone, G4GenericPolycone 464 and related USolids wrappers. 173 and related USolids wrappers. 465 174 466 27-February-2017 E.Tcherniaev (geom-specif 175 27-February-2017 E.Tcherniaev (geom-specific-V10-03-01) 467 - Revised implementation of GetCubicVolume() a 176 - Revised implementation of GetCubicVolume() and GetSurfaceArea() for 468 G4EllipticalTube, to return exact values. 177 G4EllipticalTube, to return exact values. 469 - Revised implementation of GetSurfaceArea() f 178 - Revised implementation of GetSurfaceArea() for G4EllipticalCone, to 470 return exact value; moved both GetCubicVolum 179 return exact value; moved both GetCubicVolume() and GetSurfaceArea() to 471 be not inline. 180 be not inline. 472 181 473 13-December-2016 G.Cosmo (geom-specif 182 13-December-2016 G.Cosmo (geom-specific-V10-03-00) 474 - Correction in G4UExtrudedSolid to signature 183 - Correction in G4UExtrudedSolid to signature for CalculateExtent(). 475 Fixes issue of undefined symbol if extruded- 184 Fixes issue of undefined symbol if extruded-solid not included in the 476 list of VecGeom wrappers to activate. 185 list of VecGeom wrappers to activate. 477 186 478 30-November-2016 E.Tcherniaev (geom-specif 187 30-November-2016 E.Tcherniaev (geom-specific-V10-02-25) 479 - Call RemoveRedundantVertices() from G4GeomTo 188 - Call RemoveRedundantVertices() from G4GeomTools in CalculateExtent() 480 for G4Polycone, G4Polyhedra and related USol 189 for G4Polycone, G4Polyhedra and related USolids wrappers. 481 - Fix in G4Parabolid and G4UParaboloid for cor 190 - Fix in G4Parabolid and G4UParaboloid for correct computation of extent. 482 191 483 18-November-2016 E.Tcherniaev (geom-specif 192 18-November-2016 E.Tcherniaev (geom-specific-V10-02-24) 484 - Added consistency checks for extent computat 193 - Added consistency checks for extent computation in USolids wrappers. 485 - Fix in cached parameters in G4UPolyhedra. 194 - Fix in cached parameters in G4UPolyhedra. 486 195 487 10-November-2016 G.Cosmo (geom-specif 196 10-November-2016 G.Cosmo (geom-specific-V10-02-23) 488 - G4UPolyhedra re-introduced new implementatio 197 - G4UPolyhedra re-introduced new implementation of CalculateExtent() using 489 G4BoundingEnvelope and extended wrapper to c 198 G4BoundingEnvelope and extended wrapper to cache corners and start/end 490 Phi parameters, to overcome issues in VecGeo 199 Phi parameters, to overcome issues in VecGeom on treatment of angles. 491 200 492 10-November-2016 E.Tcherniaev (geom-specif 201 10-November-2016 E.Tcherniaev (geom-specific-V10-02-22) 493 - Added caching of corners and implementation 202 - Added caching of corners and implementation of GetCorner() in G4UPolycone 494 in order to assure correct translation. 203 in order to assure correct translation. 495 - Withdrawn changes in G4UPolyhedra introduced 204 - Withdrawn changes in G4UPolyhedra introduced in tag geom-specific-V10-02-16 496 until understood proper conversion from VecG 205 until understood proper conversion from VecGeom. 497 206 498 7-November-2016 E.Tcherniaev (geom-specifi 207 7-November-2016 E.Tcherniaev (geom-specific-V10-02-21) 499 - Correction in G4EllipticalCone::DistanceToOu 208 - Correction in G4EllipticalCone::DistanceToOut(p) to make it more accurate. 500 - Added optional debug flag G4BBOX_EXTENT in G 209 - Added optional debug flag G4BBOX_EXTENT in GNUMake build to compare 501 extent calculation by simply using bounding- 210 extent calculation by simply using bounding-box. 502 211 503 3-November-2016 G.Cosmo (geom-specifi 212 3-November-2016 G.Cosmo (geom-specific-V10-02-20, 19) 504 - Fix in G4PolyPhiFace for potential unitialis 213 - Fix in G4PolyPhiFace for potential unitialised data in Inside(). 505 214 506 31-October-2016 E.Tcherniaev (geom-specifi 215 31-October-2016 E.Tcherniaev (geom-specific-V10-02-18) 507 - Re-implemented CalculateExtent() to make use 216 - Re-implemented CalculateExtent() to make use of G4BoundingEnvelope and 508 removed no-longer used method CreateRotatedV 217 removed no-longer used method CreateRotatedVertices() in G4Polyhedra, 509 G4EllipticalCone, G4Polycone, G4Paraboloid, 218 G4EllipticalCone, G4Polycone, G4Paraboloid, G4ExtrudedSolid, G4Hype, 510 G4GenericPolycone, G4TessellatedSolid, G4Twi 219 G4GenericPolycone, G4TessellatedSolid, G4TwistedTubs and related USolids 511 wrappers. 220 wrappers. 512 - Use G4RandFlat instead of RandFlat. 221 - Use G4RandFlat instead of RandFlat. 513 222 514 21-October-2016 G.Cosmo (geom-specifi 223 21-October-2016 G.Cosmo (geom-specific-V10-02-17) 515 - Moved initialisation of G4GeomSplitter threa 224 - Moved initialisation of G4GeomSplitter thread-local data to be inline 516 along with generic template type. 225 along with generic template type. 517 Fixing compilation/linking errors on clang-3 226 Fixing compilation/linking errors on clang-3.9 and XCode-8 on MacOS. 518 227 519 19-October-2016 E.Tcherniaev (geom-speci 228 19-October-2016 E.Tcherniaev (geom-specific-V10-02-16) 520 - Reimplemented CalculateExtent() in G4Polycon 229 - Reimplemented CalculateExtent() in G4Polycone, G4Polyhedra, G4GenericPolycone 521 and associated USolids wrappers, to make use 230 and associated USolids wrappers, to make use of G4BoundingEnvelope. 522 231 523 5-October-2016 E.Tcherniaev (geom-speci 232 5-October-2016 E.Tcherniaev (geom-specific-V10-02-15, 14) 524 - Reimplemented CalculateExtent() in G4Tet, G4 233 - Reimplemented CalculateExtent() in G4Tet, G4UTet, G4GenericTrap, 525 G4UGenericTrap, G4EllipticalTube and G4VTwis 234 G4UGenericTrap, G4EllipticalTube and G4VTwistedFaceted, to make use 526 of G4BoundingEnvelope; removed no-longer use 235 of G4BoundingEnvelope; removed no-longer used method CreateRotatedVertices(). 527 236 528 20-September-2016 G.Cosmo (geom-speci 237 20-September-2016 G.Cosmo (geom-specific-V10-02-13) 529 - Moved accessors/modifiers for splitter data 238 - Moved accessors/modifiers for splitter data to non-inline in 530 G4PolyhedraSide and G4PolyconeSide. 239 G4PolyhedraSide and G4PolyconeSide. 531 Explicitly initialise G4GeomSplitter data in 240 Explicitly initialise G4GeomSplitter data in G4SolidsWorkspace 532 translation unit. 241 translation unit. 533 Fixing compilation/linking errors on clang-3 242 Fixing compilation/linking errors on clang-3.9 and XCode-8 on MacOS. 534 243 535 06-July-2016 E.Tcherniaev (geom-speci 244 06-July-2016 E.Tcherniaev (geom-specific-V10-02-12) 536 - Fixed monir typo in function Create() for G4 245 - Fixed monir typo in function Create() for G4Polycone, G4Polyhedra and 537 G4GenericPolycone. 246 G4GenericPolycone. 538 Fixed minor typos in G4GenericTrap::SurfaceN 247 Fixed minor typos in G4GenericTrap::SurfaceNormal() and 539 G4VTwistSurface::CurrentStatus::ResetfDone() 248 G4VTwistSurface::CurrentStatus::ResetfDone(). 540 Issues detected by PVS-Studio static code an 249 Issues detected by PVS-Studio static code analyzer. 541 Addressing problem report #1876. 250 Addressing problem report #1876. 542 251 543 24-May-2016 G.Cosmo (geom-speci 252 24-May-2016 G.Cosmo (geom-specific-V10-02-11) 544 - Correction in G4UExtrudedSolid for definitio 253 - Correction in G4UExtrudedSolid for definition of CreatePolyhedron(). 545 254 546 20-May-2016 G.Cosmo (geom-speci 255 20-May-2016 G.Cosmo (geom-specific-V10-02-10) 547 - Moved accessors and modifiers in USolids wra 256 - Moved accessors and modifiers in USolids wrappers to be not inlined. 548 Required modification in order to allow corr 257 Required modification in order to allow correct dispatching to VecGeom 549 types. 258 types. 550 259 551 15-Apr-2016 G.Cosmo (geom-speci 260 15-Apr-2016 G.Cosmo (geom-specific-V10-02-09) 552 - Added flag in USolids wrappers for partial u 261 - Added flag in USolids wrappers for partial use of USolids/VecGeom types. 553 262 554 31-Mar-2016 G.Cosmo (geom-speci 263 31-Mar-2016 G.Cosmo (geom-specific-V10-02-08, 07) 555 - Added overloaded CreatePolyhedron() method t 264 - Added overloaded CreatePolyhedron() method to USolids wrappers. 556 It is now possible to visualize supported Ve 265 It is now possible to visualize supported VecGeom shapes. 557 - Added implementation of CreatePolyhedron() i 266 - Added implementation of CreatePolyhedron() in UExtrudedSolid wrapper. 558 267 559 10-Mar-2016 G.Cosmo (geom-speci 268 10-Mar-2016 G.Cosmo (geom-specific-V10-02-06) 560 - Added overloaded GetEntityType() method to U 269 - Added overloaded GetEntityType() method to USolids wrappers. 561 270 562 07-Mar-2016 E.Tcherniaev (geom-speci 271 07-Mar-2016 E.Tcherniaev (geom-specific-V10-02-05) 563 - Fix in G4IntersectingCone for smaller precis 272 - Fix in G4IntersectingCone for smaller precision constant in LineHitsCone1() 564 and LineHitsCone2(). Fixes issue observed in 273 and LineHitsCone2(). Fixes issue observed in G4GenericPolycone. 565 Addressing problem report #1794. 274 Addressing problem report #1794. 566 275 567 03-Mar-2016 G.Cosmo (geom-speci 276 03-Mar-2016 G.Cosmo (geom-specific-V10-02-04) 568 - Fixed compilation warnings for potential uni 277 - Fixed compilation warnings for potential uninitialised values in 569 G4ExtrudedSolid::CheckPolygon() function int 278 G4ExtrudedSolid::CheckPolygon() function introduced in previous tag. 570 279 571 03-Mar-2016 E.Tcherniaev (geom-speci 280 03-Mar-2016 E.Tcherniaev (geom-specific-V10-02-03) 572 - Added 'const' qualifier for methods in G4Ext 281 - Added 'const' qualifier for methods in G4ExtrudedSolid. 573 Added CheckPolygon() to remove collinear and 282 Added CheckPolygon() to remove collinear and coincident points from polygons. 574 - G4QuadrangularFacet: added exhaustive tests 283 - G4QuadrangularFacet: added exhaustive tests in constructor to catch potential 575 problems with a quadrangular facet: collinea 284 problems with a quadrangular facet: collinear vertices, non planar surface, 576 degenerate, concave or self intersecting qua 285 degenerate, concave or self intersecting quadrilateral. 577 - G4TriangularFacet: Improved test in construc 286 - G4TriangularFacet: Improved test in constructor to detect degenerate (too 578 small or too narrow) triangles. 287 small or too narrow) triangles. 579 288 580 25-Feb-2016 E.Tcherniaev (geom-speci 289 25-Feb-2016 E.Tcherniaev (geom-specific-V10-02-02) 581 - Correction in G4ExtrudedSolid::AddGeneralPol 290 - Correction in G4ExtrudedSolid::AddGeneralPolygonFacets() for precision 582 treatment in construction of tessels to avoi 291 treatment in construction of tessels to avoid cases of collinear points 583 and consequent degenerating triangles. 292 and consequent degenerating triangles. 584 Address problem report #1777. 293 Address problem report #1777. 585 - Use pre-computed kCarToleranceHalf constant 294 - Use pre-computed kCarToleranceHalf constant in G4ExtrudedSolid, now 586 protected in G4TessellatedSolid. 295 protected in G4TessellatedSolid. 587 - Improved algorithms for computation of area 296 - Improved algorithms for computation of area in G4TriangularFacet and 588 G4QuadrangularFacet. Added post-const qualif 297 G4QuadrangularFacet. Added post-const qualifier to GetArea(). 589 298 590 16-Feb-2016 G.Cosmo (geom-speci 299 16-Feb-2016 G.Cosmo (geom-specific-V10-02-01) 591 - Revised implementation for GetSurfaceArea() 300 - Revised implementation for GetSurfaceArea() and GetCubicVolume() in 592 G4GenericTrap (E.Tcherniaev). 301 G4GenericTrap (E.Tcherniaev). 593 - Protected debug warning in G4GenericTrap::Su 302 - Protected debug warning in G4GenericTrap::SurfaceNormal() within G4SPECSDEBUG. 594 303 595 02-Feb-2016 E.Tcherniaev (geom-speci 304 02-Feb-2016 E.Tcherniaev (geom-specific-V10-02-00) 596 - Fix in G4GenericTrap for compuation of exten 305 - Fix in G4GenericTrap for compuation of extent. 597 Addressing problem report #1809. 306 Addressing problem report #1809. 598 - Use dot() in formula for computation of GetC 307 - Use dot() in formula for computation of GetCubicVolume() in 599 G4TessellatedSolid. 308 G4TessellatedSolid. 600 309 601 18-Nov-2015 G.Cosmo (geom-speci 310 18-Nov-2015 G.Cosmo (geom-specific-V10-01-15) 602 - Added specialised implementation for GetCubi 311 - Added specialised implementation for GetCubicVolume() in 603 G4TessellatedSolid (J.Allison). 312 G4TessellatedSolid (J.Allison). 604 313 605 29-Oct-2015 G.Cosmo (geom-speci 314 29-Oct-2015 G.Cosmo (geom-specific-V10-01-14) 606 - Added debug printouts within G4SPECSDEBUG in 315 - Added debug printouts within G4SPECSDEBUG in G4TessellatedSolid for 607 DistanceToIn/Out(p,v) to identify potential 316 DistanceToIn/Out(p,v) to identify potential wrong responses. 608 317 609 26-Oct-2015 G.Cosmo (geom-speci 318 26-Oct-2015 G.Cosmo (geom-specific-V10-01-13) 610 - Removed redundant condition in G4Polyhedra a 319 - Removed redundant condition in G4Polyhedra and G4polycone 611 SetOriginalParameters() method. 320 SetOriginalParameters() method. 612 321 613 23-Oct-2015 G.Cosmo (geom-speci 322 23-Oct-2015 G.Cosmo (geom-specific-V10-01-12) 614 - G4PolyhedraSide: moved internal struct defin 323 - G4PolyhedraSide: moved internal struct definitions to public section 615 to overcome deficiencies in object-persisten 324 to overcome deficiencies in object-persistency class parsing. 616 325 617 07-Oct-2015 G.Cosmo (geom-speci 326 07-Oct-2015 G.Cosmo (geom-specific-V10-01-11) 618 - Protected compilation of USolid wrappers wit 327 - Protected compilation of USolid wrappers with G4GEOM_USE_USOLIDS flag. 619 328 620 01-Sep-2015 G.Cosmo (geom-speci 329 01-Sep-2015 G.Cosmo (geom-specific-V10-01-10) 621 - Corrected conditional compilation flag in G4 330 - Corrected conditional compilation flag in G4UParaboloid.cc. 622 331 623 31-Aug-2015 G.Cosmo (geom-speci 332 31-Aug-2015 G.Cosmo (geom-specific-V10-01-09) 624 - Added USolids/VecGeom wrapper for G4Parabolo 333 - Added USolids/VecGeom wrapper for G4Paraboloid (G.Lima/FNAL). 625 Activated only for external USolids/VecGeom 334 Activated only for external USolids/VecGeom installation. 626 335 627 13-Aug-2015 G.Cosmo (geom-speci 336 13-Aug-2015 G.Cosmo (geom-specific-V10-01-08) 628 - Checked for potential never-ending loops. 337 - Checked for potential never-ending loops. 629 No issues found, only added annotations. 338 No issues found, only added annotations. 630 339 631 05-Aug-2015 G.Cosmo (geom-speci 340 05-Aug-2015 G.Cosmo (geom-specific-V10-01-07) 632 - Minor code cleanup in G4SurfaceVoxelizer. 341 - Minor code cleanup in G4SurfaceVoxelizer. 633 342 634 03-Mar-2015 G.Cosmo (geom-speci 343 03-Mar-2015 G.Cosmo (geom-specific-V10-01-06) 635 - Use accessors x(), y() and z() from UVector3 344 - Use accessors x(), y() and z() from UVector3, instead of directly accessing 636 its data-members. Co-work with tag "geom-uso 345 its data-members. Co-work with tag "geom-usolids-V10-01-09". 637 346 638 23-Feb-2015 T.Nikitina (geom-speci 347 23-Feb-2015 T.Nikitina (geom-specific-V10-01-05) 639 - Fix in SetOriginalParameters() for G4Polycon 348 - Fix in SetOriginalParameters() for G4Polycone and G4Polyhedra, in case 640 of presence of 'rings' structures. Addressin 349 of presence of 'rings' structures. Addressing problem report #1705. 641 350 642 26-Jan-2015 G.Cosmo (geom-speci 351 26-Jan-2015 G.Cosmo (geom-specific-V10-01-04) 643 - Renamed DistanceAwayForInside() to DistanceA 352 - Renamed DistanceAwayForInside() to DistanceAway() and use polymorphism. 644 353 645 26-Jan-2015 T.Nikitina (geom-speci 354 26-Jan-2015 T.Nikitina (geom-specific-V10-01-03, 02) 646 - Added special method for Inside 'DistanceAwa << 355 - Added special method for Inside 'DistanceAwayForInside()' in order to fix 647 precision problem of calculation of Distance << 356 precision problem of calculation of DistanceToSide() in G4PolyconeSide. 648 357 649 21-Jan-2015 T.Nikitina (geom-speci 358 21-Jan-2015 T.Nikitina (geom-specific-V10-01-01) 650 - Fixed triangularisation method AddGeneralPOl 359 - Fixed triangularisation method AddGeneralPOlygoneFacets() in 651 G4ExtrudedSolid by avoiding flat triangles. 360 G4ExtrudedSolid by avoiding flat triangles. 652 - Added warning message to G4TriangularFacet c 361 - Added warning message to G4TriangularFacet constructor if Area is 0; 653 i.e., case of flat triangle. 362 i.e., case of flat triangle. 654 - Addressing problem report #1703. 363 - Addressing problem report #1703. 655 364 656 12-Dec-2014 G.Cosmo (geom-speci 365 12-Dec-2014 G.Cosmo (geom-specific-V10-01-00) 657 - Use canonical form for operator=() in G4Poly 366 - Use canonical form for operator=() in G4PolyconeHistorical and 658 G4PolyhedraHistorical. 367 G4PolyhedraHistorical. 659 368 660 17-Sep-2014 G.Cosmo (geom-speci 369 17-Sep-2014 G.Cosmo (geom-specific-V10-00-11) 661 - Added wrappers for UExtrudedSolid and UGener 370 - Added wrappers for UExtrudedSolid and UGenericTrap; adapted switches to 662 original G4 types accordingly. Requires tag 371 original G4 types accordingly. Requires tag "geom-usolids-V10-00-16". 663 372 664 01-Sep-2014 G.Cosmo (geom-speci 373 01-Sep-2014 G.Cosmo (geom-specific-V10-00-10) 665 - Fixed use of polyhedron pointer, to avoid ra 374 - Fixed use of polyhedron pointer, to avoid race condition in MT 666 when parameterised volumes are visualised. 375 when parameterised volumes are visualised. 667 376 668 22-May-2014 G.Cosmo (geom-speci 377 22-May-2014 G.Cosmo (geom-specific-V10-00-09) 669 - Added protection in generic constructor of G 378 - Added protection in generic constructor of G4Polyhedra for the case when 670 improper number of sides is given as input. 379 improper number of sides is given as input. 671 380 672 10-Apr-2014 G.Cosmo (geom-speci 381 10-Apr-2014 G.Cosmo (geom-specific-V10-00-08) 673 - Get rid of deprecated 'register' storage cla 382 - Get rid of deprecated 'register' storage class specifier in source files. 674 383 675 31-Mar-2014 G.Cosmo (geom-speci 384 31-Mar-2014 G.Cosmo (geom-specific-V10-00-07) 676 - Fixed signature of assignment operator to G4 385 - Fixed signature of assignment operator to G4VCSGfaceted. 677 386 678 31-Mar-2014 G.Cosmo (geom-speci 387 31-Mar-2014 G.Cosmo (geom-specific-V10-00-06) 679 - Fixed signature of assignment operator to G4 388 - Fixed signature of assignment operator to G4Polycone, G4Polyhedra and 680 and G4GenericPolycone. 389 and G4GenericPolycone. 681 390 682 05-Mar-2014 G.Cosmo (geom-speci 391 05-Mar-2014 G.Cosmo (geom-specific-V10-00-05) 683 - Fixed proper handling of polyhedron pointer 392 - Fixed proper handling of polyhedron pointer in solids, to avoid memory 684 leak for visualization of parameterised volu 393 leak for visualization of parameterised volumes. 685 394 686 12-Feb-2014 G.Cosmo (geom-speci 395 12-Feb-2014 G.Cosmo (geom-specific-V10-00-04) 687 - Simply reset polyhedron pointer to zero for 396 - Simply reset polyhedron pointer to zero for modifiers of G4U* wrappers 688 in parameterisation. Resolves crash in MT vi << 397 in parameterisation. Resolves crash in MT visualization when using USolids. 689 398 690 12-Feb-2014 G.Cosmo (geom-speci 399 12-Feb-2014 G.Cosmo (geom-specific-V10-00-03 [and -02]) 691 - Added correct cloning mechanism in G4U* wrap 400 - Added correct cloning mechanism in G4U* wrappers. 692 Addressing problem report #1553. 401 Addressing problem report #1553. 693 402 694 18-Dec-2013 T.Nikitina (geom-speci 403 18-Dec-2013 T.Nikitina (geom-specific-V10-00-01) 695 - Fix in G4GenericTrap::InsidePolygone() to ch 404 - Fix in G4GenericTrap::InsidePolygone() to check if p lies between the two 696 extremes of the segment. Addressing problem 405 extremes of the segment. Addressing problem report #1541. 697 406 698 17-Dec-2013 G.Cosmo (geom-speci 407 17-Dec-2013 G.Cosmo (geom-specific-V10-00-00) 699 - Corrected left-over debug printout in G4Poly 408 - Corrected left-over debug printout in G4Polycone::SetOriginalParameters(). 700 409 701 04-Dec-2013 G.Cosmo (geom-speci 410 04-Dec-2013 G.Cosmo (geom-specific-V09-06-36) 702 - Corrected left-over debug printout in G4Poly 411 - Corrected left-over debug printout in G4Polyhedra::SetOriginalParameters(). 703 412 704 22-Nov-2013 G.Cosmo (geom-speci 413 22-Nov-2013 G.Cosmo (geom-specific-V09-06-35) 705 - Correction to USolids wrappers for proper se 414 - Correction to USolids wrappers for proper setting of name to base class. 706 415 707 19-Nov-2013 J.Apostolakis (geom-speci 416 19-Nov-2013 J.Apostolakis (geom-specific-V09-06-34) 708 - Fix for issue identified by Coverity: fixed 417 - Fix for issue identified by Coverity: fixed implementation of 709 G4SolidsWorkspacePool singleton. 418 G4SolidsWorkspacePool singleton. 710 419 711 20-Nov-2013 T.Mikitina (geom-speci 420 20-Nov-2013 T.Mikitina (geom-specific-V09-06-33) 712 - Fixed Coverity defects to USolids wrappers. 421 - Fixed Coverity defects to USolids wrappers. 713 422 714 14-Nov-2013 G.Cosmo (geom-speci 423 14-Nov-2013 G.Cosmo (geom-specific-V09-06-32, 31) 715 - Enabled use of Reset() in G4UPolycone. 424 - Enabled use of Reset() in G4UPolycone. 716 - Corrections to G4UPolycone and G4UPolyhedra 425 - Corrections to G4UPolycone and G4UPolyhedra to allow for visualization 717 of parameterisations on these solids. 426 of parameterisations on these solids. 718 427 719 13-Nov-2013 G.Cosmo (geom-speci 428 13-Nov-2013 G.Cosmo (geom-specific-V09-06-30) 720 - Correction to G4UTet and G4UGenericPolycone 429 - Correction to G4UTet and G4UGenericPolycone to explicitly include 721 symbols re-definitions from G4Tet and G4Gene 430 symbols re-definitions from G4Tet and G4GenericPolycone respectively. 722 431 723 12-Nov-2013 G.Cosmo (geom-speci 432 12-Nov-2013 G.Cosmo (geom-specific-V09-06-29) 724 - Added dummy method G4UPolycone::Reset(). 433 - Added dummy method G4UPolycone::Reset(). 725 NOTE: Required related implementation (curre 434 NOTE: Required related implementation (currently missing!) in UPolycone. 726 435 727 12-Nov-2013 G.Cosmo (geom-speci 436 12-Nov-2013 G.Cosmo (geom-specific-V09-06-28) 728 - Correction to USolids switch mechanism for G 437 - Correction to USolids switch mechanism for G4Polycone. 729 << 438 730 08-Nov-2013 J.Apostolakis (geom-speci 439 08-Nov-2013 J.Apostolakis (geom-specific-V09-06-27) 731 - G4SolidsWorkspace: cleanup of verbosity. 440 - G4SolidsWorkspace: cleanup of verbosity. 732 Reduced verbosity by making it optional. << 441 Reduced verbosity by making it optional. 733 Added Set/Get Verbose methods to toggle and 442 Added Set/Get Verbose methods to toggle and view it. 734 Added parameter to constructor for verbosity 443 Added parameter to constructor for verbosity (default=off). 735 444 736 07-Nov-2013 G.Cosmo (geom-specific-V09-06-26) 445 07-Nov-2013 G.Cosmo (geom-specific-V09-06-26) 737 - Moved wrappers from usolids module. 446 - Moved wrappers from usolids module. 738 Fixed internal dispatcher method for paramet 447 Fixed internal dispatcher method for parameterisation in all wrappers. 739 - Added switching mechanism for G4GenericPolyc 448 - Added switching mechanism for G4GenericPolycone, G4Polycone, G4Polyhedra 740 and G4Tet. 449 and G4Tet. 741 450 742 06-Nov-2013 G.Cosmo (geom-specific-V09-06-25) 451 06-Nov-2013 G.Cosmo (geom-specific-V09-06-25) 743 - Added switch mechanism for USolids (G4Generi 452 - Added switch mechanism for USolids (G4GenericPolycone, G4Polycone, 744 G4Polyhedra, G4Tet). Renamed related G4 type 453 G4Polyhedra, G4Tet). Renamed related G4 types to 'G4O'. 745 - Moved wrappers from USolids module. 454 - Moved wrappers from USolids module. 746 455 747 01-Nov-2013 G.Cosmo (geom-specific-V09-06-24) 456 01-Nov-2013 G.Cosmo (geom-specific-V09-06-24) 748 - Corrected CMake script. 457 - Corrected CMake script. 749 458 750 31-Oct-2013 G.Cosmo (geom-specific-V09-06-23) 459 31-Oct-2013 G.Cosmo (geom-specific-V09-06-23) 751 - Fix for in G4Polyhedra::SetOriginalParameter 460 - Fix for in G4Polyhedra::SetOriginalParameters(). (T.Nikitina) 752 - Moved G4PolyconeHistorical and G4PolyhedraHi 461 - Moved G4PolyconeHistorical and G4PolyhedraHistorical in separate 753 translation units. 462 translation units. 754 463 755 29-Oct-2013 T.Nikitina (geom-specific-V09-06- 464 29-Oct-2013 T.Nikitina (geom-specific-V09-06-22) 756 - Split G4Polycone for polycones with decreasi 465 - Split G4Polycone for polycones with decreasing Z-sections. 757 Introduced new class G4GenericPolycone. 466 Introduced new class G4GenericPolycone. 758 - Fixed conversion of generic construct for G4 467 - Fixed conversion of generic construct for G4Polyhedra. 759 468 760 17-Oct-2013 J.Apostolakis/A.Dotti (geom-speci 469 17-Oct-2013 J.Apostolakis/A.Dotti (geom-specific-V09-06-21) 761 - Cleanup of code for workspace. 470 - Cleanup of code for workspace. 762 471 763 16-Oct-2013 J.Apostolakis/A.Dotti (geom-speci 472 16-Oct-2013 J.Apostolakis/A.Dotti (geom-specific-V09-06-20) 764 - Created G4SolidsWorkspacePool class, to mana 473 - Created G4SolidsWorkspacePool class, to manage Workspaces 765 Fixed Singleton G4SolidsWorkspacePool for th << 474 Fixed Singleton G4SolidsWorkspacePool for thread safe creation of object. 766 475 767 04-Oct-2013 J.Apostolakis (geom-specific-V09- 476 04-Oct-2013 J.Apostolakis (geom-specific-V09-06-19) 768 - Retagged. 477 - Retagged. 769 NOTE: requires tag "geommng-V09-06-12" and c 478 NOTE: requires tag "geommng-V09-06-12" and co-works with "geomvol-V09-06-13". 770 479 771 04-Oct-2013 J.Apostolakis (geom-specific-V09- 480 04-Oct-2013 J.Apostolakis (geom-specific-V09-06-18) 772 - Created G4SolidsWorkspace class, to create, 481 - Created G4SolidsWorkspace class, to create, initialize and destroy 773 per-thread state of PolyCone Sides and PolyH 482 per-thread state of PolyCone Sides and PolyHedra Sides. 774 483 775 27-Aug-2013 G.Cosmo (geom-specific-V09-06-17) 484 27-Aug-2013 G.Cosmo (geom-specific-V09-06-17) 776 - Enabled G4Ellipsoid for parameterisation. 485 - Enabled G4Ellipsoid for parameterisation. 777 486 778 14-Aug-2013 G.Cosmo (geom-specific-V09-06-16) 487 14-Aug-2013 G.Cosmo (geom-specific-V09-06-16) 779 - Move function-scoped 'static const' values f 488 - Move function-scoped 'static const' values for half-tolerances to private 780 data members of classes, to overcome false-p 489 data members of classes, to overcome false-positive race-conditions defects 781 reported by Valgrind in MT mode. 490 reported by Valgrind in MT mode. 782 - Fix in G4TessellatedSolid::DistanceToIn(p,v) 491 - Fix in G4TessellatedSolid::DistanceToIn(p,v) for specific cases where points 783 are located near surface (T.Nikitina). 492 are located near surface (T.Nikitina). 784 493 785 16-Jul-2013 M.Gayer (geom-specific-V09-06-15) 494 16-Jul-2013 M.Gayer (geom-specific-V09-06-15) 786 - Fix in G4SurfaceVoxelizer affecting tessella 495 - Fix in G4SurfaceVoxelizer affecting tessellated-solid (and extruded-solid) 787 for wrong computation of DistanceToIn(p,v) f 496 for wrong computation of DistanceToIn(p,v) for points outside, when 788 optimisation is active. 497 optimisation is active. 789 498 790 11-Jul-2013 G.Cosmo (geom-specific-V09-06-14) 499 11-Jul-2013 G.Cosmo (geom-specific-V09-06-14) 791 - Fixed compilation warning in G4Polycone on M 500 - Fixed compilation warning in G4Polycone on MacOS/clang. 792 501 793 09-Jul-2013 T.Nikitina (geom-specific-V09-06- 502 09-Jul-2013 T.Nikitina (geom-specific-V09-06-13) 794 - Extended method SetOriginalParameters() in G 503 - Extended method SetOriginalParameters() in G4Polycone in order to handle 795 all possible cases of conversion of generic 504 all possible cases of conversion of generic polycone to polycone with 796 (Rmin,Rmaz,Z) parameters. 505 (Rmin,Rmaz,Z) parameters. 797 Addressing problem report #1462. 506 Addressing problem report #1462. 798 507 799 03-Jun-2013 G.Cosmo (geom-specific-V09-06-12) 508 03-Jun-2013 G.Cosmo (geom-specific-V09-06-12) 800 - Fixed minor Coverity defect in G4PolyhedraSi 509 - Fixed minor Coverity defect in G4PolyhedraSide and G4PolyconeSide. 801 510 802 22-Apr-2013 J.Apostolakis (geom-specific-V09- 511 22-Apr-2013 J.Apostolakis (geom-specific-V09-06-11) 803 - Revised G4ExtrudedSolid::IsSameLine to use t 512 - Revised G4ExtrudedSolid::IsSameLine to use the perpendicular 804 distance to a line when deciding - not the y 513 distance to a line when deciding - not the y-intercept difference. 805 ( Issue responsible for a problem in Subtrac << 514 ( Issue responsible for a problem in Subtraction Solid in Atlas. 806 Tatiana & Ivana contributed to debugging. 515 Tatiana & Ivana contributed to debugging. ) 807 - Changed GNUmakefile in test directory to wor << 516 - Changed GNUmakefile in test directory to work with Cmake and granular 808 builds. 517 builds. 809 518 810 16-Apr-2013 T.Nikitina (geom-specific-V09-06- 519 16-Apr-2013 T.Nikitina (geom-specific-V09-06-10) 811 - Fix in calculation of normal in G4Tet::Dista 520 - Fix in calculation of normal in G4Tet::DistanceToOut(p,v,..) and 812 SurfaceNormal(p). 521 SurfaceNormal(p). 813 - Fix in G4Polycone::GetPointOnCone() for case 522 - Fix in G4Polycone::GetPointOnCone() for cases of shape with decreasing Z. 814 Fixes cases of false report for overlaps det 523 Fixes cases of false report for overlaps detection. Problem report #1462. 815 Added check with exception in constructor fo 524 Added check with exception in constructor for polycone with rInner > rOuter 816 for the same Z. 525 for the same Z. 817 526 818 18-Mar-2013 G.Cosmo (geom-specific-V09-06-09) 527 18-Mar-2013 G.Cosmo (geom-specific-V09-06-09) 819 - G4TessellatedSolid: fixed problem with navig 528 - G4TessellatedSolid: fixed problem with navigation in tessellated solids 820 with concave surfaces. Addresses problem rep 529 with concave surfaces. Addresses problem report #1456. 821 - More cleanup from MT changes in G4VTwistSurf 530 - More cleanup from MT changes in G4VTwistSurface and G4Tet. 822 531 823 12-Mar-2013 G.Cosmo (geom-specific-V09-06-08) 532 12-Mar-2013 G.Cosmo (geom-specific-V09-06-08) 824 - Added public accessors for MT data to G4Poly 533 - Added public accessors for MT data to G4PolyconeSide and G4PolyhedraSide. 825 534 826 11-Mar-2013 G.Cosmo (geom-specific-V09-06-07) 535 11-Mar-2013 G.Cosmo (geom-specific-V09-06-07) 827 - Redefined G4DLL_API to G4GEOM_DLL to avoid c 536 - Redefined G4DLL_API to G4GEOM_DLL to avoid cases of macro redefinition. 828 537 829 08-Mar-2013 G.Cosmo (geom-specific-V09-06-06) 538 08-Mar-2013 G.Cosmo (geom-specific-V09-06-06) 830 - Renamed G4MT macros to safer ID in G4Polycon 539 - Renamed G4MT macros to safer ID in G4PolyconeSide and G4PolyhedraSide. 831 540 832 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05) 541 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05) 833 - Adopt G4GeomSplitter instead of G4MTTransito 542 - Adopt G4GeomSplitter instead of G4MTTransitory in G4PolyconeSide and 834 G4PolyhedraSide. Fixed import/export of stat 543 G4PolyhedraSide. Fixed import/export of static symbols for WIN32 DLLs build. 835 544 836 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04) 545 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04) 837 - Cleanup changes for multi-threading in G4Tet 546 - Cleanup changes for multi-threading in G4Tet, G4VTwistSurface, 838 G4PolyconeSide and G4PolyhedraSide. 547 G4PolyconeSide and G4PolyhedraSide. 839 - Removed unused private data member in G4Twis 548 - Removed unused private data member in G4TwistTrapParallelSide. 840 549 841 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05) 550 07-Mar-2013 G.Cosmo (geom-specific-V09-06-05) 842 - Adopt G4GeomSplitter instead of G4MTTransito 551 - Adopt G4GeomSplitter instead of G4MTTransitory in G4PolyconeSide and 843 G4PolyhedraSide. Fixed import/export of stat 552 G4PolyhedraSide. Fixed import/export of static symbols for WIN32 DLLs build. 844 553 845 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04) 554 22-Feb-2013 G.Cosmo (geom-specific-V09-06-04) 846 - Cleanup changes for multi-threading in G4Tet 555 - Cleanup changes for multi-threading in G4Tet, G4VTwistSurface, 847 G4PolyconeSide and G4PolyhedraSide. 556 G4PolyconeSide and G4PolyhedraSide. 848 - Removed unused private data member in G4Twis 557 - Removed unused private data member in G4TwistTrapParallelSide. 849 558 850 11-Jan-2013 G.Cosmo (geom-specific-V09-06-03) 559 11-Jan-2013 G.Cosmo (geom-specific-V09-06-03) 851 - Fixed condition in G4VTwistSurface::GetBound 560 - Fixed condition in G4VTwistSurface::GetBoundaryLimit() for logical error. 852 Addressing problem report #1420. 561 Addressing problem report #1420. 853 562 854 20-Dec-2012 M.Gayer (geom-specific-V09-06-02) 563 20-Dec-2012 M.Gayer (geom-specific-V09-06-02) 855 - Fixed cases of hang-ups in G4ExtrudedSolid o 564 - Fixed cases of hang-ups in G4ExtrudedSolid on 32-bits platforms, due to 856 G4TessellatedSolid and G4SurfVoxelizer, caus 565 G4TessellatedSolid and G4SurfVoxelizer, caused by accessing bitmask arrays 857 with negative indexes. The problem was relat 566 with negative indexes. The problem was related to floating-point rounding, 858 which can be different even on same platform 567 which can be different even on same platform with debug/release version. 859 Assure same number of computed voxels on 32- 568 Assure same number of computed voxels on 32-bit/64-bit platforms. 860 Fixed error in SetVertexIndex() method, whic 569 Fixed error in SetVertexIndex() method, which might cause problems on 861 certain configurations even for 64-bit syste 570 certain configurations even for 64-bit systems. Fixed minor memory leaks. 862 - Code cleanup for use of G4endl and tabs... 571 - Code cleanup for use of G4endl and tabs... 863 572 864 14-Dec-2012 G.Cosmo (geom-specific-V09-06-01) 573 14-Dec-2012 G.Cosmo (geom-specific-V09-06-01) 865 - Restored SVN id headers. 574 - Restored SVN id headers. 866 575 867 02-Dec-2012 J.Allison (geom-specific-V09-06-0 576 02-Dec-2012 J.Allison (geom-specific-V09-06-00) 868 - Removed NURBS. 577 - Removed NURBS. 869 578 870 29-Nov-2012 G.Cosmo (geom-specific-V09-05-24) 579 29-Nov-2012 G.Cosmo (geom-specific-V09-05-24) 871 - Remove inclusion of G4PhysicalConstants.hh f 580 - Remove inclusion of G4PhysicalConstants.hh from G4SurfaceVoxelizer.hh. 872 - Fixed unit test for compilation errors. 581 - Fixed unit test for compilation errors. 873 582 874 28-Nov-2012 G.Cosmo (geom-specific-V09-05-23) 583 28-Nov-2012 G.Cosmo (geom-specific-V09-05-23) 875 - Fixed more cases of inclusion of constants h 584 - Fixed more cases of inclusion of constants header. 876 585 877 23-Nov-2012 G.Cosmo (geom-specific-V09-05-22) 586 23-Nov-2012 G.Cosmo (geom-specific-V09-05-22) 878 - Added 'const' qualifiers to signature in G4V 587 - Added 'const' qualifiers to signature in G4VoxelComparator::operator() 879 for porting on AIX-xlC compiler. 588 for porting on AIX-xlC compiler. 880 589 881 14-Nov-2012 P.Mato (geom-specific-V09-05-21) 590 14-Nov-2012 P.Mato (geom-specific-V09-05-21) 882 - Added #undef NDEBUG in unit tests to ensure 591 - Added #undef NDEBUG in unit tests to ensure assert works also in 883 full optimised mode. 592 full optimised mode. 884 593 885 14-Nov-2012 P. Mato (geom-specific-V09-05-20) 594 14-Nov-2012 P. Mato (geom-specific-V09-05-20) 886 - Added #undef NDEBUG in unit tests to ensure 595 - Added #undef NDEBUG in unit tests to ensure that assert always works 887 596 888 13-Nov-2012 M.Gayer (geom-specific-V09-05-19) 597 13-Nov-2012 M.Gayer (geom-specific-V09-05-19) 889 - More fixes for out-of-bound array accesses i 598 - More fixes for out-of-bound array accesses in G4SurfaceVoxelizer. 890 599 891 12-Nov-2012 M.Gayer (geom-specific-V09-05-18) 600 12-Nov-2012 M.Gayer (geom-specific-V09-05-18) 892 - Fixed out-of-bound array access in BuildRedu 601 - Fixed out-of-bound array access in BuildReduceVoxels2(). 893 602 894 06-Nov-2012 G.Cosmo (geom-specific-V09-05-17) 603 06-Nov-2012 G.Cosmo (geom-specific-V09-05-17) 895 - Correction in sources.cmake script for missi 604 - Correction in sources.cmake script for missing .icc file. 896 605 897 06-Nov-2012 G.Cosmo (geom-specific-V09-05-16) 606 06-Nov-2012 G.Cosmo (geom-specific-V09-05-16) 898 - Fixed Coverity defects in new code (M.Gayer) 607 - Fixed Coverity defects in new code (M.Gayer). 899 - Minor fixes for porting on AIX. 608 - Minor fixes for porting on AIX. 900 609 901 01-Nov-2012 G.Cosmo (geom-specific-V09-05-15) 610 01-Nov-2012 G.Cosmo (geom-specific-V09-05-15) 902 - Fixed compilation of debug code under G4SPEC 611 - Fixed compilation of debug code under G4SPECSDEBUG. 903 612 904 01-Nov-2012 M.Gayer (geom-specific-V09-05-14) 613 01-Nov-2012 M.Gayer (geom-specific-V09-05-14) 905 - Corrected signature for voxels count methods 614 - Corrected signature for voxels count methods in G4SurfaceVoxelizer. 906 615 907 31-Oct-2012 M.Gayer (geom-specific-V09-05-13) 616 31-Oct-2012 M.Gayer (geom-specific-V09-05-13) 908 - Added set/get methods for voxels count in G4 617 - Added set/get methods for voxels count in G4SurfaceVoxelizer. 909 618 910 30-Oct-2012 M.Gayer (geom-specific-V09-05-12) 619 30-Oct-2012 M.Gayer (geom-specific-V09-05-12) 911 - Fixed indexing of vertices in facets for tes 620 - Fixed indexing of vertices in facets for tessellated-solid and some cleanup. 912 621 913 27-Oct-2012 G.Cosmo (geom-specific-V09-05-11) 622 27-Oct-2012 G.Cosmo (geom-specific-V09-05-11) 914 - Fixed initialization of data in G4SurfaceVox 623 - Fixed initialization of data in G4SurfaceVoxelizer (M.Gayer). 915 - Added post-const qualifier to G4VertextCompa 624 - Added post-const qualifier to G4VertextComparator::operator() in 916 G4TessellatedSolid. 625 G4TessellatedSolid. 917 - Fixed more compilation warnings on unused va 626 - Fixed more compilation warnings on unused variable. 918 627 919 26-Oct-2012 G.Cosmo (geom-specific-V09-05-10) 628 26-Oct-2012 G.Cosmo (geom-specific-V09-05-10) 920 - Corrected compilation problem on G4SurfBits 629 - Corrected compilation problem on G4SurfBits for use of fprint(). 921 - Polished comments in disclaimer in new updat 630 - Polished comments in disclaimer in new updated classes. 922 631 923 25-Oct-2012 G.Cosmo (geom-specific-V09-05-09) 632 25-Oct-2012 G.Cosmo (geom-specific-V09-05-09) 924 - Corrected compilation warnings on Linux and 633 - Corrected compilation warnings on Linux and fixed use of memset/memcpy. 925 634 926 25-Oct-2012 G.Cosmo (geom-specific-V09-05-08) 635 25-Oct-2012 G.Cosmo (geom-specific-V09-05-08) 927 - Correction to sources.cmake. 636 - Correction to sources.cmake. 928 637 929 19-Oct-2012 M.Gayer (geom-specific-V09-05-07) 638 19-Oct-2012 M.Gayer (geom-specific-V09-05-07) 930 - Complete rewrite of G4TessellatedSolid resul 639 - Complete rewrite of G4TessellatedSolid resulting in reduced memory 931 requirements by 50%, and factor of tens or m 640 requirements by 50%, and factor of tens or more speedup for number of facets 932 of the order of thousands, thanks to ad-hoc 641 of the order of thousands, thanks to ad-hoc voxelization of the surface. 933 Factor of thousands speedup when number of f 642 Factor of thousands speedup when number of facets of the order of hundreds 934 thousand. New classes introduced, G4SurfBits 643 thousand. New classes introduced, G4SurfBits and G4SurfaceVoxelizer. 935 644 936 12-Jun-2012 G.Cosmo (geom-specific-V09-05-06) 645 12-Jun-2012 G.Cosmo (geom-specific-V09-05-06) 937 - Explicitly use inclusion of headers for syst 646 - Explicitly use inclusion of headers for system of units and physical 938 constants, in plan to remove implicit inclus 647 constants, in plan to remove implicit inclusion from globals.hh. 939 648 940 14-May-2012 G.Cosmo (geom-specific-V09-05-05) 649 14-May-2012 G.Cosmo (geom-specific-V09-05-05) 941 - Fixed spurious cases of hidden variable visi 650 - Fixed spurious cases of hidden variable visibility, detected with 942 '-Wshadow' compilation option on gcc compile 651 '-Wshadow' compilation option on gcc compiler. 943 652 944 06-Apr-2012 M.Kelsey (geom-specific-V09-05-04 653 06-Apr-2012 M.Kelsey (geom-specific-V09-05-04) 945 - Modified GetPointOnSurface() to throw sqrt(r 654 - Modified GetPointOnSurface() to throw sqrt(r) uniformly for disk surfaces, 946 in G4Paraboloid, G4Polycone and G4TwistedTub 655 in G4Paraboloid, G4Polycone and G4TwistedTubs. 947 656 948 13-Dec-2011 G.Cosmo (geom-specific-V09-05-03, 657 13-Dec-2011 G.Cosmo (geom-specific-V09-05-03, 02, 01) 949 - Fixed trivial Coverity defects in G4TwistedT 658 - Fixed trivial Coverity defects in G4TwistedTubs and G4VTwisteFaceted for 950 missing protection against self-assignment. 659 missing protection against self-assignment. 951 660 952 09-Dec-2011 T.Nikitina (geom-specific-V09-05- 661 09-Dec-2011 T.Nikitina (geom-specific-V09-05-00) 953 - Fix in G4EllipticalCone in DistanceToIn(p,v) 662 - Fix in G4EllipticalCone in DistanceToIn(p,v) to exclude imaginary solution 954 (virtual cone) when distance is calculated. 663 (virtual cone) when distance is calculated. 955 664 956 10-Nov-2011 G.Cosmo (geom-specific-V09-04-09) 665 10-Nov-2011 G.Cosmo (geom-specific-V09-04-09) 957 - Fixed trivial Coverity defects on assignment 666 - Fixed trivial Coverity defects on assignment operators... 958 667 959 25-Oct-2011 G.Cosmo (geom-specific-V09-04-08) 668 25-Oct-2011 G.Cosmo (geom-specific-V09-04-08) 960 - Fixed logic in G4VTwistSurface::GetEdgeVisib 669 - Fixed logic in G4VTwistSurface::GetEdgeVisibility() in treatment of corners. 961 670 962 16-Sep-2011 G.Cosmo (geom-specific-V09-04-07) 671 16-Sep-2011 G.Cosmo (geom-specific-V09-04-07) 963 - Fix compilation error in code within G4SPECS 672 - Fix compilation error in code within G4SPECSDEBUG. No functional changes. 964 673 965 13-Sep-2011 I.Hrivnacova (geom-specific-V09-0 674 13-Sep-2011 I.Hrivnacova (geom-specific-V09-04-06) 966 - G4TriangularFacet: fixed tests where square 675 - G4TriangularFacet: fixed tests where square root was compared to 967 half Cartesian tolerance; now compared to kC 676 half Cartesian tolerance; now compared to kCarTolerance. 968 Addressing problem report #1242. 677 Addressing problem report #1242. 969 678 970 25-Aug-2011 G.Cosmo 679 25-Aug-2011 G.Cosmo 971 - Migrated to new G4Exception scheme for warni 680 - Migrated to new G4Exception scheme for warnings and errors. 972 - Defined scheme for warnings/errors coding: 681 - Defined scheme for warnings/errors coding: 973 + 1xxx for warnings, 0xxx for errors. 682 + 1xxx for warnings, 0xxx for errors. 974 Code numbering: 683 Code numbering: 975 + 0001: not supported or implemented feature 684 + 0001: not supported or implemented features; 976 + 0002: invalid setup/construct; 685 + 0002: invalid setup/construct; 977 + 0003: invalid run condition; 686 + 0003: invalid run condition; 978 + 1001: incorrect setup; automatically adapt 687 + 1001: incorrect setup; automatically adapted. 979 + 1002: notification. 688 + 1002: notification. 980 - Added unit test for G4ExtrudedSolid (J.Apost 689 - Added unit test for G4ExtrudedSolid (J.Apostolakis). 981 690 982 22-Aug-2011 I.Hrivnacova (geom-specific-V09-0 691 22-Aug-2011 I.Hrivnacova (geom-specific-V09-04-05) 983 - Fix in G4TriangularFacet::Intersect() to tak 692 - Fix in G4TriangularFacet::Intersect() to take into account geometrical 984 tolerance and cases of zero distance from su 693 tolerance and cases of zero distance from surface's facet. 985 - Fix in G4TessellatedSolid::DistanceToOut(p) 694 - Fix in G4TessellatedSolid::DistanceToOut(p) and DistanceToIn(p) to exactly 986 compute distance from facet avoiding use of 695 compute distance from facet avoiding use of 'outgoing' flag shortcut variant. 987 - Addressing problem report #1242. 696 - Addressing problem report #1242. 988 697 989 17-Aug-2011 T.Nikitina (geom-specific-V09-04- 698 17-Aug-2011 T.Nikitina (geom-specific-V09-04-04) 990 - Fix in G4Paraboloid::DistanceToIn(p,v) and D 699 - Fix in G4Paraboloid::DistanceToIn(p,v) and DistanceToIn(p) to properly 991 take into account tolerance and provide bett 700 take into account tolerance and provide better estimation of distance 992 respectively. Addresses problem report #1234 701 respectively. Addresses problem report #1234. 993 702 994 04-Aug-2011 T.Nikitina (geom-specific-V09-04- 703 04-Aug-2011 T.Nikitina (geom-specific-V09-04-03) 995 - Added SetReferences() and InvertFacets() to 704 - Added SetReferences() and InvertFacets() to G4GenericTrap::CreatePolyhedron() 996 for proper visualisation of Boolean composit 705 for proper visualisation of Boolean compositions with G4GenericTrap. 997 - Added SetReferences() to G4TessellatedSolid: 706 - Added SetReferences() to G4TessellatedSolid::CreatePolyhedron() 998 for proper visualisation of Boolean composit 707 for proper visualisation of Boolean compositions with G4TessellatedSolid. 999 - Requires tag "greps-V09-04-04", for addressi 708 - Requires tag "greps-V09-04-04", for addressing problem report #1235. 1000 709 1001 17-May-2011 I.Hrivnacova (geom-specific-V09- 710 17-May-2011 I.Hrivnacova (geom-specific-V09-04-02) 1002 - G4ExtrudedSolid: fix in Inside(p) for false 711 - G4ExtrudedSolid: fix in Inside(p) for false overlap reporting. 1003 Addressing problem report #1211. 712 Addressing problem report #1211. 1004 713 1005 12-May-2011 G.Cosmo (geom-specific-V09-04-01 714 12-May-2011 G.Cosmo (geom-specific-V09-04-01) 1006 - Fixed compilation warnings from gcc-4.6.0 f 715 - Fixed compilation warnings from gcc-4.6.0 for variables set but not used. 1007 716 1008 06-May-2011 G.Cosmo (geom-specific-V09-04-00 717 06-May-2011 G.Cosmo (geom-specific-V09-04-00) 1009 - Use G4 typedef for CLHEP types. 718 - Use G4 typedef for CLHEP types. 1010 719 1011 26-Nov-2010 T.Nikitina (geom-specific-V09-03 720 26-Nov-2010 T.Nikitina (geom-specific-V09-03-20) 1012 - Fixes in G4GenericTrap reported by SBT unit 721 - Fixes in G4GenericTrap reported by SBT unit test in SurfaceNormal(), 1013 DistanceToPlane() and VisExtent(). 722 DistanceToPlane() and VisExtent(). 1014 723 1015 16-Nov-2010 T.Nikitina (geom-specific-V09-03 724 16-Nov-2010 T.Nikitina (geom-specific-V09-03-19) 1016 - G4EllipticalCone: fixes in DistanceToIn(p,v 725 - G4EllipticalCone: fixes in DistanceToIn(p,v) and DistanceToOut(p,v) for 1017 correct handling of point on the surface. 726 correct handling of point on the surface. 1018 Corrected formula for SurfaceNormal(p). 727 Corrected formula for SurfaceNormal(p). 1019 728 1020 10-Nov-2010 T.Nikitina (geom-specific-V09-03 729 10-Nov-2010 T.Nikitina (geom-specific-V09-03-18) 1021 - Added checks on crossing of vertices and to 730 - Added checks on crossing of vertices and too big twisted angle in 1022 G4GenericTrap. 731 G4GenericTrap. 1023 - Fixed case of division by zero in G4Twisted 732 - Fixed case of division by zero in G4TwistedTubs. 1024 - Added unit test for G4Polyhedra. 733 - Added unit test for G4Polyhedra. 1025 734 1026 02-Nov-2010 G.Cosmo (geom-specific-V09-03-17 735 02-Nov-2010 G.Cosmo (geom-specific-V09-03-17) 1027 - More fixes on Coverity reports for G4Tessel 736 - More fixes on Coverity reports for G4TessellatedSolid and G4ReduciblePolygon. 1028 737 1029 20-Oct-2010 G.Cosmo (geom-specific-V09-03-16 738 20-Oct-2010 G.Cosmo (geom-specific-V09-03-16) 1030 - Implemented Clone() virtual method for all 739 - Implemented Clone() virtual method for all solids, returning a pointer 1031 to a dynamically allocated copy of the soli 740 to a dynamically allocated copy of the solid. To be used by Geant4-MT. 1032 741 1033 23-Sep-2010 G.Cosmo (geom-specific-V09-03-15 742 23-Sep-2010 G.Cosmo (geom-specific-V09-03-15) 1034 - Initialize fpPolyhedron to zero in copy-cto 743 - Initialize fpPolyhedron to zero in copy-ctor and operator=(). 1035 - Completed implementation of copy-ctor and o 744 - Completed implementation of copy-ctor and operator=() for facets. 1036 745 1037 20-Sep-2010 G.Cosmo (geom-specific-V09-03-14 746 20-Sep-2010 G.Cosmo (geom-specific-V09-03-14) 1038 - Implemented copy-constructor and assignment 747 - Implemented copy-constructor and assignment operator for all solids 1039 to facilitate conversion to Geant4-MT. 748 to facilitate conversion to Geant4-MT. 1040 749 1041 08-Sep-2010 G.Cosmo (geom-specific-V09-03-13 750 08-Sep-2010 G.Cosmo (geom-specific-V09-03-13) 1042 - Correction to previous fix in G4ReduciblePo 751 - Correction to previous fix in G4ReduciblePolygon to avoid deleting current 1043 'vertexHead' pointer. 752 'vertexHead' pointer. 1044 753 1045 07-Sep-2010 G.Cosmo (geom-specific-V09-03-12 754 07-Sep-2010 G.Cosmo (geom-specific-V09-03-12) 1046 - Fix within G4CSGDEBUG code for restoring co 755 - Fix within G4CSGDEBUG code for restoring cout precision. 1047 - Fix in G4ReduciblePolygon::RemoveRedundantV 756 - Fix in G4ReduciblePolygon::RemoveRedundantVertices() to avoid potential 1048 case of dereferencing freed pointer. 757 case of dereferencing freed pointer. 1049 758 1050 19-Aug-2010 T.Nikitina (geom-specific-V09-03 759 19-Aug-2010 T.Nikitina (geom-specific-V09-03-11) 1051 - G4EllipticalTube: extended implementation o 760 - G4EllipticalTube: extended implementation of SurfaceNormal(p) in agreement 1052 with canonical form. Added unit test testG4 761 with canonical form. Added unit test testG4EllipticalTube.cc. 1053 762 1054 16-Jul-2010 G.Cosmo (geom-specific-V09-03-10 763 16-Jul-2010 G.Cosmo (geom-specific-V09-03-10) 1055 - Fixed cases of division by zero in G4VTwist 764 - Fixed cases of division by zero in G4VTwistSurface and G4TwistBoxSide. 1056 - Use INT_MAX as initialisation for max limit 765 - Use INT_MAX as initialisation for max limits in G4SolidExtentList. 1057 766 1058 12-Jul-2010 G.Cosmo (geom-specific-V09-03-09 767 12-Jul-2010 G.Cosmo (geom-specific-V09-03-09) 1059 - Added dummy initialization to members in st << 768 - Added dummy initialization to members in struct 1060 G4PolyPhiFace::G4PolyPhiFaceEdge, struct G4 769 G4PolyPhiFace::G4PolyPhiFaceEdge, struct G4ReduciblePolygon::ABVertex. 1061 G4Ellipsoid, G4EllipticalTube, G4EnclosingC 770 G4Ellipsoid, G4EllipticalTube, G4EnclosingCylinder, G4ExtrudedSolid, G4Hype, 1062 G4IntersectingCone, G4Paraboloid, G4PolyPhi 771 G4IntersectingCone, G4Paraboloid, G4PolyPhiFace, G4Polycone, G4PolyconeSide, 1063 G4Polyhedra, G4PolyhedraSide, G4Quadrangula 772 G4Polyhedra, G4PolyhedraSide, G4QuadrangularFacet, G4ReduciblePolygon, 1064 G4TessellatedSolid, G4TriangularFacet, G4Tw 773 G4TessellatedSolid, G4TriangularFacet, G4TwistBoxSide, G4TwistTrapAlphaSide, 1065 G4TwistTrapFlatSide, G4TwistTrapParallelSid 774 G4TwistTrapFlatSide, G4TwistTrapParallelSide, G4TwistTubsFlatSide, 1066 G4TwistTubsHypeSide, G4TwistTubsSide, G4Twi 775 G4TwistTubsHypeSide, G4TwistTubsSide, G4TwistedTubs, G4VCSGfaceted, G4VFacet, 1067 G4VTwistSurface, G4VTwistedFaceted. 776 G4VTwistSurface, G4VTwistedFaceted. 1068 - Fixed case of dereferencing null pointer in 777 - Fixed case of dereferencing null pointer in methods 1069 G4EllipticalTube::DistanceToOut(p,v), G4VCS 778 G4EllipticalTube::DistanceToOut(p,v), G4VCSGfaceted::DistanceToIn(p,v) 1070 and G4VCSGfaceted::DistanceToOut(p,v). 779 and G4VCSGfaceted::DistanceToOut(p,v). 1071 - Fixed unecessary object copy as argument in 780 - Fixed unecessary object copy as argument in method 1072 G4PolyhedraSide::IntersectSidePlane(). 781 G4PolyhedraSide::IntersectSidePlane(). 1073 - Avoid possible case of derefencing null poi 782 - Avoid possible case of derefencing null pointer in G4ReduciblePolygon 1074 RemoveDuplicateVertices() and RemoveRedunda 783 RemoveDuplicateVertices() and RemoveRedundantVertices() methods. 1075 - Replaced calls to std::abs() with std::fabs 784 - Replaced calls to std::abs() with std::fabs() where suitable. 1076 785 1077 16-Jun-2010 G.Cosmo (geom-specific-V09-03-08 786 16-Jun-2010 G.Cosmo (geom-specific-V09-03-08) 1078 - Fixed deletion of internal arrays in Create 787 - Fixed deletion of internal arrays in CreatePolyhedron() for G4Polycone 1079 and G4Polyhedra. 788 and G4Polyhedra. 1080 789 1081 11-Jun-2010 T.Nikitina (geom-specific-V09-03 790 11-Jun-2010 T.Nikitina (geom-specific-V09-03-07) 1082 - G4GenericTrap: fixed cases of zero dToIn/sT 791 - G4GenericTrap: fixed cases of zero dToIn/sToOut when vertices are collapsed 1083 to triangle, line or point. Added new metho 792 to triangle, line or point. Added new methods handling those specific cases. 1084 - Added unit test for G4GenericTrap. 793 - Added unit test for G4GenericTrap. 1085 794 1086 10-Jun-2010 I.Hrivnacova 795 10-Jun-2010 I.Hrivnacova 1087 - G4GenericTrap: fixed parameter names in Cal 796 - G4GenericTrap: fixed parameter names in CalculateExtent() for the test 1088 case construction through tessellated facet 797 case construction through tessellated facets. 1089 798 1090 09-Jun-2010 G.Cosmo 799 09-Jun-2010 G.Cosmo 1091 - G4GenericTrap: moved internal methods to pr 800 - G4GenericTrap: moved internal methods to private section and reordered 1092 in source file. Added missing implementatio 801 in source file. Added missing implementation for IsTwisted() method. 1093 802 1094 03-Jun-2010 T.Nikitina, G.Cosmo (geom-specif 803 03-Jun-2010 T.Nikitina, G.Cosmo (geom-specific-V09-03-06) 1095 - G4GenericTrap: 804 - G4GenericTrap: 1096 o Fixed initialization of fSurfaceArea and 805 o Fixed initialization of fSurfaceArea and fCubicVolume and 1097 calculation of surface area. 806 calculation of surface area. 1098 o Fixed error in Inside(p) function, and co 807 o Fixed error in Inside(p) function, and corrected use std::fabs() instead 1099 of std::abs() for floating point values. 808 of std::abs() for floating point values. 1100 o Added missing initialisation of fpPolyhed 809 o Added missing initialisation of fpPolyhedron pointer. 1101 o More corrected signatures for use of non- 810 o More corrected signatures for use of non-const references for vectors 1102 passed as arguments to functions. 811 passed as arguments to functions. 1103 812 1104 02-Jun-2010 G.Cosmo (geom-specific-V09-03-05 813 02-Jun-2010 G.Cosmo (geom-specific-V09-03-05) 1105 - G4GenericTrap: use const reference for vect 814 - G4GenericTrap: use const reference for vector of vertices passed as argument 1106 in constructor and accessor. 815 in constructor and accessor. 1107 816 1108 27-May-2010 T.Nikitina (geom-specific-V09-03 817 27-May-2010 T.Nikitina (geom-specific-V09-03-04) 1109 - First implementation of G4GenericTrap shape 818 - First implementation of G4GenericTrap shape, a new solid representing an 1110 arbitrary trapezoid with up to 8 vertices s 819 arbitrary trapezoid with up to 8 vertices standing on two parallel planes 1111 perpendicular to the Z axis. 820 perpendicular to the Z axis. 1112 821 1113 28-Apr-2010 P.R.Truscott (geom-specific-V09- 822 28-Apr-2010 P.R.Truscott (geom-specific-V09-03-03) 1114 - Fix in G4TriangularFacet and G4TessellatedS 823 - Fix in G4TriangularFacet and G4TessellatedSolid to correct treatment of 1115 optical photon transport related to interna 824 optical photon transport related to internal reflection at surface. 1116 Addresses problem report #1103. 825 Addresses problem report #1103. 1117 826 1118 15-Apr-2010 I.Hrivnacova (geom-specific-V09- 827 15-Apr-2010 I.Hrivnacova (geom-specific-V09-03-02) 1119 - G4ExtrudedSolid: eliminated requirement for 828 - G4ExtrudedSolid: eliminated requirement for clockwise ordering of polygon 1120 vertices. Added a check for vertices orderi 829 vertices. Added a check for vertices ordering; if vertices are defined 1121 anti-clockwise their ordering is reverted. 830 anti-clockwise their ordering is reverted. 1122 Fix in polygon facet triangularization for 831 Fix in polygon facet triangularization for consequent concave vertices. 1123 832 1124 24-Feb-2010 G.Cosmo (geom-specific-V09-03-01 833 24-Feb-2010 G.Cosmo (geom-specific-V09-03-01) 1125 - Adopt caching of Phi in G4PolyconeSide and 834 - Adopt caching of Phi in G4PolyconeSide and G4PolyhedraSide to avoid 1126 unnecessary consecutive computations on the 835 unnecessary consecutive computations on the same point. 1127 836 1128 10-Feb-2010 G.Cosmo (geom-specific-V09-03-00 837 10-Feb-2010 G.Cosmo (geom-specific-V09-03-00) 1129 - Use kInfinity for initialising minimum and 838 - Use kInfinity for initialising minimum and maximum allowed extent for 1130 G4SolidExtentList of faceted solids. 839 G4SolidExtentList of faceted solids. 1131 840 1132 11-Nov-2009 G.Cosmo (geom-specific-V09-02-08 841 11-Nov-2009 G.Cosmo (geom-specific-V09-02-08) 1133 - Avoid fake (and redundant) assignment of va 842 - Avoid fake (and redundant) assignment of value to 3-vector in 1134 G4PolyconeSide and G4TwistTubsSide. 843 G4PolyconeSide and G4TwistTubsSide. 1135 844 1136 24-Sep-2009 T.Nikitina (geom-specific-V09-02 845 24-Sep-2009 T.Nikitina (geom-specific-V09-02-07) 1137 - G4Ellipsoid: refined fix in DistanceToIn(p, 846 - G4Ellipsoid: refined fix in DistanceToIn(p,v) for points located on the 1138 curved surface, and correct treatment of ge 847 curved surface, and correct treatment of geometrical tolerance. 1139 848 1140 09-Sep-2009 G.Cosmo (geom-specific-V09-02-06 849 09-Sep-2009 G.Cosmo (geom-specific-V09-02-06) 1141 - G4Ellipsoid: fixed usage of half-tolerances 850 - G4Ellipsoid: fixed usage of half-tolerances (radial and Cartesian) in 1142 DistanceToIn(p,v), based on incorrect assum 851 DistanceToIn(p,v), based on incorrect assumptions introduced in tag 1143 "geom-specific-V09-02-04", responsible for 852 "geom-specific-V09-02-04", responsible for zero steps on configurations 1144 with cut in Z. Addresses problem report #10 853 with cut in Z. Addresses problem report #1076. 1145 854 1146 04-Aug-2009 T.Nikitina (geom-specific-V09-02 855 04-Aug-2009 T.Nikitina (geom-specific-V09-02-05) 1147 - G4Ellipsoid: 856 - G4Ellipsoid: 1148 o Fixes in Inside(p) and in DistanceToIn(p, 857 o Fixes in Inside(p) and in DistanceToIn(p,v) for points 1149 located on the curved surface within tole 858 located on the curved surface within tolerance. Final fix for issue 1150 reported in problem report #1050 and conc 859 reported in problem report #1050 and concerning warnings reported by 1151 grid_test. 860 grid_test. 1152 o Adopt pre-computed half-tolerance values 861 o Adopt pre-computed half-tolerance values for optimisation. 1153 862 1154 23-Jul-2009 T.Nikitina (geom-specific-V09-02 863 23-Jul-2009 T.Nikitina (geom-specific-V09-02-04) 1155 - G4Ellipsoid: fix to DistanceToIn(p,v) in th 864 - G4Ellipsoid: fix to DistanceToIn(p,v) in the calculation of the roots of 1156 the quadratic equation and in DistanceToOut 865 the quadratic equation and in DistanceToOut(p,v) in the calculation of the 1157 normal on cut surfaces. Final fix for probl 866 normal on cut surfaces. Final fix for problem report #1022 and #1050. 1158 - G4PolyconeSide: added protection in method 867 - G4PolyconeSide: added protection in method Normal(), addressing problem 1159 report #1073. 868 report #1073. 1160 869 1161 30-Jun-2009 T.Nikitina (geom-specific-V09-02 870 30-Jun-2009 T.Nikitina (geom-specific-V09-02-03) 1162 - G4Ellipsoid: introduced to DistanceToIn(p,v 871 - G4Ellipsoid: introduced to DistanceToIn(p,v) splitting of the distance for 1163 point very far from intersection area and b 872 point very far from intersection area and big difference between solid 1164 dimensions and distance to it; resolves iss 873 dimensions and distance to it; resolves issue observed on 64 bits problem. 1165 Also addressing problem report #1022. 874 Also addressing problem report #1022. 1166 875 1167 08-May-2009, G.Cosmo (geom-specific-V09-02-02 876 08-May-2009, G.Cosmo (geom-specific-V09-02-02) 1168 - Corrected typo in base implementation of G4 877 - Corrected typo in base implementation of G4VCSGfaceted::GetSurfaceArea(), 1169 which was erroneously returning cubic volum 878 which was erroneously returning cubic volume estimation. 1170 Addresses problem report #1062. 879 Addresses problem report #1062. 1171 880 1172 27-Apr-2009, G.Cosmo (geom-specific-V09-02-01 881 27-Apr-2009, G.Cosmo (geom-specific-V09-02-01) 1173 - Relaxed error condition in G4TessellatedSol 882 - Relaxed error condition in G4TessellatedSolid::Inside(p) to warning, for 1174 excess of max trials and anomalous conditio 883 excess of max trials and anomalous conditions in distance calculation. 1175 Added more printout information when error 884 Added more printout information when error condition is detected. 1176 885 1177 27-Feb-2009, T.Nikitina (geom-specific-V09-02 886 27-Feb-2009, T.Nikitina (geom-specific-V09-02-00) 1178 - Fix in G4Paraboloid::DistanceToOut(p,v,..) 887 - Fix in G4Paraboloid::DistanceToOut(p,v,..) for the computation of normal 1179 to surface; added missing normalisation to 888 to surface; added missing normalisation to unit, following remark in the 1180 Geometry Forum Hypernews posting #953. 889 Geometry Forum Hypernews posting #953. 1181 890 1182 21-Nov-2008, G.Cosmo (geom-specific-V09-01-19 891 21-Nov-2008, G.Cosmo (geom-specific-V09-01-19) 1183 - Added missing accessors to G4EllipticalCone 892 - Added missing accessors to G4EllipticalCone, required for detector 1184 persistency. 893 persistency. 1185 894 1186 13-Nov-2008, G.Cosmo (geom-specific-V09-01-18 895 13-Nov-2008, G.Cosmo (geom-specific-V09-01-18) 1187 - Corrected initialisation of algorithm in G4 896 - Corrected initialisation of algorithm in G4TriangularFacet constructor. 1188 897 1189 30-Oct-2008, I.Hrivnacova (geom-specific-V09- 898 30-Oct-2008, I.Hrivnacova (geom-specific-V09-01-17) 1190 - G4ExtrudedSolid: fixed bug in the decomposi 899 - G4ExtrudedSolid: fixed bug in the decomposition of polygonal sides for 1191 quadrangular facets in MakeFacets(). Addres 900 quadrangular facets in MakeFacets(). Addresses problem report #1029. 1192 901 1193 23-Sep-2008, T.Nikitina (geom-specific-V09-01 902 23-Sep-2008, T.Nikitina (geom-specific-V09-01-16) 1194 - Corrected algorithm in G4TriangularFacet::G 903 - Corrected algorithm in G4TriangularFacet::GetPointOnFace() according to 1195 suggestion advanced in problem report #1025 904 suggestion advanced in problem report #1025. Fixes a problem of false 1196 overlaps detection related to G4ExtrudedSol 905 overlaps detection related to G4ExtrudedSolid and G4TessellatedSolid. 1197 906 1198 12-Sep-2008, G.Cosmo (geom-specific-V09-01-15 907 12-Sep-2008, G.Cosmo (geom-specific-V09-01-15) 1199 - G4VFacet: corrected increment of indeces in 908 - G4VFacet: corrected increment of indeces in operator==(), following 1200 problem report #1024. 909 problem report #1024. 1201 910 1202 25-Jul-2008, I.Hrivnacova (geom-specific-V09- 911 25-Jul-2008, I.Hrivnacova (geom-specific-V09-01-14) 1203 - G4ExtrudedSolid: fix in polygon decompositi 912 - G4ExtrudedSolid: fix in polygon decomposition; systematically use 1204 half kCarTolerance instead of kCarTolerance 913 half kCarTolerance instead of kCarTolerance; added solid name in the 1205 error messages coming from fatal exceptions 914 error messages coming from fatal exceptions. 1206 915 1207 16-Jul-2008, T.Nikitina (geom-specific-V09-01 916 16-Jul-2008, T.Nikitina (geom-specific-V09-01-13) 1208 - G4Paraboloid: revised DistanceToOut(p,v,... 917 - G4Paraboloid: revised DistanceToOut(p,v,...) in answer to problem report 1209 #1015. Fixed precision problem when solving 918 #1015. Fixed precision problem when solving quadratic equation; apply 1210 comparison with kCarTolerance and not with 919 comparison with kCarTolerance and not with zero; fixed logic problem in 1211 algoritm for points on surface and directio 920 algoritm for points on surface and direction inside, relative to directions 1212 along Z, (0,0,Vz). 921 along Z, (0,0,Vz). 1213 922 1214 22-May-2008, G.Cosmo (geom-specific-V09-01-12 923 22-May-2008, G.Cosmo (geom-specific-V09-01-12) 1215 - Removed left-over debug printout in G4VCSGF 924 - Removed left-over debug printout in G4VCSGFaceted::DistanceToIn(). 1216 925 1217 15-May-2008, T.Nikitina (geom-specific-V09-01 926 15-May-2008, T.Nikitina (geom-specific-V09-01-11) 1218 - Enhanced GetPointOnSurface() for generic G4 927 - Enhanced GetPointOnSurface() for generic G4Polycone and G4Polyhedra 1219 constructs; the method uses new triangulati 928 constructs; the method uses new triangulation algorithm for G4PolyPhiFace. 1220 - G4ExtrudedSolid: added missing 'std' namesp 929 - G4ExtrudedSolid: added missing 'std' namespace to standard mathematical 1221 function calls. 930 function calls. 1222 931 1223 28-Apr-2008, T.Nikitina (geom-specific-V09-01 932 28-Apr-2008, T.Nikitina (geom-specific-V09-01-10) 1224 - Added kCarTolerance in definition of "low" 933 - Added kCarTolerance in definition of "low" and "high" cone limits in R 1225 and in Z in order to protect against numeri 934 and in Z in order to protect against numerical errors. This fixes cases of 1226 DistanceToIn(p,v) returning 'kInfinity' whe 935 DistanceToIn(p,v) returning 'kInfinity' when p+t*v cross intersection 1227 between two cones. 936 between two cones. 1228 937 1229 25-Apr-2008, T.Nikitina (geom-specific-V09-01 938 25-Apr-2008, T.Nikitina (geom-specific-V09-01-09) 1230 - Added protection against NaN in G4Intersect 939 - Added protection against NaN in G4IntersectingCone::LineHitsCone1() in 1231 case of configuration where a conic section 940 case of configuration where a conic section becomes a tube. 1232 - G4EllipticalCone: removed some debug printo 941 - G4EllipticalCone: removed some debug printouts. 1233 942 1234 14-Apr-2008, T.Nikitina (geom-specific-V09-01 943 14-Apr-2008, T.Nikitina (geom-specific-V09-01-08) 1235 - G4Hype: refined polyhedron representation f 944 - G4Hype: refined polyhedron representation for correct visualization of 1236 the shape. Coworks with tag "greps-V09-01-0 945 the shape. Coworks with tag "greps-V09-01-04". 1237 946 1238 13-Mar-2008, G.Cosmo (geom-specific-V09-01-07 947 13-Mar-2008, G.Cosmo (geom-specific-V09-01-07) 1239 - Cleared compilation warnings in G4Paraboloi 948 - Cleared compilation warnings in G4Paraboloid and G4TessellatedSolid 1240 on gcc-4.3.0 for ambiguous use of parenthes 949 on gcc-4.3.0 for ambiguous use of parentheses in condition statements. 1241 950 1242 28-Feb-2008, I.Hrivnacova (geom-specific-V09- 951 28-Feb-2008, I.Hrivnacova (geom-specific-V09-01-06) 1243 - Correction to previous fix in G4ExtrudedSol 952 - Correction to previous fix in G4ExtrudedSolid: testing on the edges has 1244 to be limited to the line segment, for this 953 to be limited to the line segment, for this purpose a new internal method 1245 IsSameLineSegment() has been introduced for 954 IsSameLineSegment() has been introduced for use instead of IsSameLine(). 1246 - Updated and extended unit test testG4Extrud 955 - Updated and extended unit test testG4ExtrudedSolid.cc. 1247 956 1248 27-Feb-2008, I.Hrivnacova (geom-specific-V09- 957 27-Feb-2008, I.Hrivnacova (geom-specific-V09-01-05) 1249 - Fix in G4TessellatedSolid::DistanceToOut(p, 958 - Fix in G4TessellatedSolid::DistanceToOut(p,v,..) to compute normal only 1250 if specified by flag in input. 959 if specified by flag in input. 1251 - Fix in G4ExtrudedSolid::Inside(p) for corre 960 - Fix in G4ExtrudedSolid::Inside(p) for correctly handling the case of 1252 points located on the edges of triangles wh 961 points located on the edges of triangles which are not the outline edges 1253 of the polygon. 962 of the polygon. 1254 963 1255 21-Feb-2008, T.Nikitina (geom-specific-V09-01 964 21-Feb-2008, T.Nikitina (geom-specific-V09-01-04) 1256 - G4Polyhedra: fixed problem of out-of-bound 965 - G4Polyhedra: fixed problem of out-of-bound access to vectors in 1257 GetPointOnSurface(). 966 GetPointOnSurface(). 1258 967 1259 20-Feb-2008, I.Hrivnacova (geom-specific-V09- 968 20-Feb-2008, I.Hrivnacova (geom-specific-V09-01-03) 1260 - G4TessellatedSolid: fixed bug in copy-const 969 - G4TessellatedSolid: fixed bug in copy-constructor and internal method 1261 CopyObjects() for cloning of facets. 970 CopyObjects() for cloning of facets. 1262 971 1263 05-Feb-2008, I.Hrivnacova (geom-specific-V09- 972 05-Feb-2008, I.Hrivnacova (geom-specific-V09-01-02) 1264 - G4ExtrudedSolid: bug fix in MakeFacets() to 973 - G4ExtrudedSolid: bug fix in MakeFacets() to fill 'fTriangles' also in case 1265 of polygon with 3 or 4 vertices, as they ar 974 of polygon with 3 or 4 vertices, as they are needed for Inside(p). 1266 975 1267 02-Feb-2008, I.Hrivnacova (geom-specific-V09- 976 02-Feb-2008, I.Hrivnacova (geom-specific-V09-01-01) 1268 - Corrected triangularization of polygon, now 977 - Corrected triangularization of polygon, now correctly handling case 1269 of concave shapes. 978 of concave shapes. 1270 - Corrected order of arguments in G4Paraboloi << 979 - Corrected order of arguments in G4Paraboloid constructor. 1271 980 1272 16-Jan-2008, I.Hrivnacova (geom-specific-V09- 981 16-Jan-2008, I.Hrivnacova (geom-specific-V09-01-00) 1273 - In G4ExtrudedSolid::MakeFacets(), now addin 982 - In G4ExtrudedSolid::MakeFacets(), now adding triangular facets before quadrangular 1274 ones, following logic behind G4TessellatedS 983 ones, following logic behind G4TessellatedSolid. 1275 984 1276 12-Dec-2007, G.Cosmo (geom-specific-V09-00-08 985 12-Dec-2007, G.Cosmo (geom-specific-V09-00-08a) 1277 - Remove use of global static constant from s 986 - Remove use of global static constant from singleton initialisation in 1278 G4TessellatedGeometryAlgorithms class. Use 987 G4TessellatedGeometryAlgorithms class. Use 'sqrEpsilon' as local value. 1279 988 1280 15-Nov-2007, P.Truscott (geom-specific-V09-00 989 15-Nov-2007, P.Truscott (geom-specific-V09-00-08) 1281 - Reviewed implementation of G4TessellatedSol 990 - Reviewed implementation of G4TessellatedSolid::CalculateExtent() to 1282 make it more robust and precise, following 991 make it more robust and precise, following suggestion by S.Seibert 1283 addressed in problem report #983, now fixed 992 addressed in problem report #983, now fixed. 1284 993 1285 12-Oct-2007, G.Cosmo (geom-specific-V09-00-07 994 12-Oct-2007, G.Cosmo (geom-specific-V09-00-07) 1286 - Corrected wrong boolean condition in method 995 - Corrected wrong boolean condition in method IntersectLineAndTriangle2D() 1287 of G4TessellatedGeometryAlgorithms causing 996 of G4TessellatedGeometryAlgorithms causing compilation error on VC++8. 1288 997 1289 09-Oct-2007, G.Cosmo (geom-specific-V09-00-06 998 09-Oct-2007, G.Cosmo (geom-specific-V09-00-06) 1290 - Reviewed G4TessellatedSolid classes in orde 999 - Reviewed G4TessellatedSolid classes in order not to make use of random 1291 numbers for selection of direction (by P.Tr 1000 numbers for selection of direction (by P.Truscott). 1292 1001 1293 02-Oct-2007, G.Cosmo 1002 02-Oct-2007, G.Cosmo 1294 - Removed debug printout in G4Polycone::GetPo 1003 - Removed debug printout in G4Polycone::GetPointOnCone(). 1295 1004 1296 23-Aug-2007, G.Cosmo (geom-specific-V09-00-05 1005 23-Aug-2007, G.Cosmo (geom-specific-V09-00-05) 1297 - Revision of G4TessellatedSolid classes: 1006 - Revision of G4TessellatedSolid classes: 1298 o Fixed problem report #931 by P.Truscott, 1007 o Fixed problem report #931 by P.Truscott, based on suggestion of 1299 R.Holmberg. Modified classes G4Tessellate 1008 R.Holmberg. Modified classes G4TessellatedSolid and G4TriangularFacet. 1300 o Modified data and accessor 'centroid' and 1009 o Modified data and accessor 'centroid' and 'GetCentroid()' for G4VFacet; 1301 replaced by 'circumcentre' and 'GetCircum 1010 replaced by 'circumcentre' and 'GetCircumcentre()' respectively. 1302 o Added utility class G4TessellatedGeometry 1011 o Added utility class G4TessellatedGeometryAlgorithms. 1303 - Added formulas for calculating SemiAxis and 1012 - Added formulas for calculating SemiAxis and Zheight in G4EllipticalCone 1304 (by T.Nikitina). 1013 (by T.Nikitina). 1305 1014 1306 20-Aug-2007, T.Nikitina & L.Lindroos (geom-sp 1015 20-Aug-2007, T.Nikitina & L.Lindroos (geom-specific-V09-00-04) 1307 - Revision of G4EllipticalCone: 1016 - Revision of G4EllipticalCone: 1308 o DistanceToIn(p): corrected answer for p.z 1017 o DistanceToIn(p): corrected answer for p.z()<-zTopCut and for the point 1309 p on the surface. 1018 p on the surface. 1310 o DistanceToOut(p,v): now returning positiv 1019 o DistanceToOut(p,v): now returning positive solution or zero when crossing 1311 the elliptical surface. 1020 the elliptical surface. 1312 o Fix in DistanceToOut(p) which was giving << 1021 o Fix in DistanceToOut(p) which was giving always zero. 1313 o Corrected visualisation error of solid in 1022 o Corrected visualisation error of solid in graphics_reps. 1314 o Added some formulas on how to pre-calcula 1023 o Added some formulas on how to pre-calculate 'SemiAxis' and 'zheight'. 1315 o Added checkDistanceToOut() method to unit 1024 o Added checkDistanceToOut() method to unit test. 1316 - Corrections to G4Paraboloid: 1025 - Corrections to G4Paraboloid: 1317 o Fixed bug in CalculateSurfaceArea() metho 1026 o Fixed bug in CalculateSurfaceArea() method 1318 o Added correct initialisation of 'fPolyhed 1027 o Added correct initialisation of 'fPolyhedron' in constructor. 1319 o Added unit test testG4Paraboloid. 1028 o Added unit test testG4Paraboloid. 1320 1029 1321 13-Aug-2007, W.Pokorski (geom-specific-V09-00 1030 13-Aug-2007, W.Pokorski (geom-specific-V09-00-03) 1322 - G4PolyconeSide: added workaround to initial 1031 - G4PolyconeSide: added workaround to initialisation of 'corners' vector, 1323 to allow for object persistency with Root-I 1032 to allow for object persistency with Root-I/O (W.Pokorski). 1324 1033 1325 18-Jul-2007, G.Cosmo (geom-specific-V09-00-02 1034 18-Jul-2007, G.Cosmo (geom-specific-V09-00-02) 1326 - New specific G4Paraboloid with cuts along t 1035 - New specific G4Paraboloid with cuts along the Z axis (by L.Lindroos). 1327 - Fixed dummy constructors of G4Polycone and 1036 - Fixed dummy constructors of G4Polycone and G4PolyPhiFace for initialisation 1328 of 'edges' and 'corners'. 1037 of 'edges' and 'corners'. 1329 - Coworks with tag "greps-V09-00-01". 1038 - Coworks with tag "greps-V09-00-01". 1330 1039 1331 12-Jul-2007, T.Nikitina (geom-specific-V09-00 1040 12-Jul-2007, T.Nikitina (geom-specific-V09-00-01) 1332 - Fix in G4Polyhedra::GetPointOnSurface() to 1041 - Fix in G4Polyhedra::GetPointOnSurface() to correctly treat 'totalPhi' instead of 1333 'endPhi' for the case of open shapes and 't 1042 'endPhi' for the case of open shapes and 'twopi' for not open shapes. 1334 1043 1335 05-Jul-2007, T.Nikitina (geom-specific-V09-00 1044 05-Jul-2007, T.Nikitina (geom-specific-V09-00-00) 1336 - Fix in G4Polyhedra::GetPointOnSurface() for 1045 - Fix in G4Polyhedra::GetPointOnSurface() for the case when number of sectors 1337 (numSide) is equal to 1. At the origin of p 1046 (numSide) is equal to 1. At the origin of problems observed when checking 1338 overlaps for polyhedra solids defined as su 1047 overlaps for polyhedra solids defined as such. 1339 1048 1340 31-May-2007, G.Cosmo (geom-specific-V08-03-03 1049 31-May-2007, G.Cosmo (geom-specific-V08-03-03) 1341 - Fixed initialisation of constants in constr 1050 - Fixed initialisation of constants in constructor for - G4VTwistSurface, 1342 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraS 1051 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraSide - following latest changes 1343 for tunable tolerance. 1052 for tunable tolerance. 1344 1053 1345 25-May-2007, G.Cosmo (geom-specific-V08-03-02 1054 25-May-2007, G.Cosmo (geom-specific-V08-03-02) 1346 - Fixed default response of DistToIn/DistToOu 1055 - Fixed default response of DistToIn/DistToOut for twisted solids. 1347 - Use G4TWISTDEBUG instead of G4SPECSDEBUG as 1056 - Use G4TWISTDEBUG instead of G4SPECSDEBUG as debug conditional flag 1348 for twisted solids. 1057 for twisted solids. 1349 - Some cleanup in G4TwistTrapAlphaSide code. 1058 - Some cleanup in G4TwistTrapAlphaSide code. 1350 1059 1351 18-May-2007, G.Cosmo (geom-specific-V08-03-01 1060 18-May-2007, G.Cosmo (geom-specific-V08-03-01) 1352 - Use kAngTolerance and kRadTolerance from G4 1061 - Use kAngTolerance and kRadTolerance from G4GeometryTolerance class. 1353 - Coworks with tag "global-V08-03-03". 1062 - Coworks with tag "global-V08-03-03". 1354 1063 1355 11-May-2007, T.Nikitina (geom-specific-V08-03 1064 11-May-2007, T.Nikitina (geom-specific-V08-03-00) 1356 - Use call to G4GeometryTolerance instead of 1065 - Use call to G4GeometryTolerance instead of kCarTolerance where needed. 1357 - Requires tag "global-V08-03-00" and related 1066 - Requires tag "global-V08-03-00" and related tag set. 1358 1067 1359 26-Apr-2007, T.Nikitina (geom-specific-V08-02 1068 26-Apr-2007, T.Nikitina (geom-specific-V08-02-05) 1360 - Fix in GetPointOnSurface() for G4Polycone t 1069 - Fix in GetPointOnSurface() for G4Polycone to consider also points laying 1361 on rings when consecutive Z-sections are co 1070 on rings when consecutive Z-sections are coincident. 1362 Added method GetPointOnRing(). 1071 Added method GetPointOnRing(). 1363 - Added unit test testPointOnSurfacePoly.cc. 1072 - Added unit test testPointOnSurfacePoly.cc. 1364 1073 1365 27-Feb-2007, I.Hrivnacova (geom-specific-V08- 1074 27-Feb-2007, I.Hrivnacova (geom-specific-V08-02-04) 1366 - Added specialised constructor for handling 1075 - Added specialised constructor for handling Z-sections in G4ExtrudedSolid. 1367 - Cleared unecessary declaration of IsInside( 1076 - Cleared unecessary declaration of IsInside() methods in G4TriangularFacet 1368 and G4QuadrangularFacet. 1077 and G4QuadrangularFacet. 1369 - Updated unit test for G4ExtrudedSolid. 1078 - Updated unit test for G4ExtrudedSolid. 1370 1079 1371 26-Feb-2007, I.Hrivnacova (geom-specific-V08- 1080 26-Feb-2007, I.Hrivnacova (geom-specific-V08-02-04) 1372 - Added specialised constructor for handling 1081 - Added specialised constructor for handling Z-sections in G4ExtrudedSolid. 1373 - Cleared unecessary declaration of IsInside( 1082 - Cleared unecessary declaration of IsInside() methods in G4TriangularFacet 1374 and G4QuadrangularFacet. 1083 and G4QuadrangularFacet. 1375 - Updated unit test for G4ExtrudedSolid. 1084 - Updated unit test for G4ExtrudedSolid. 1376 1085 1377 15-Feb-2007, I.Hrivnacova (geom-specific-V08- 1086 15-Feb-2007, I.Hrivnacova (geom-specific-V08-02-03) 1378 - Corrected caching of values in G4ExtrudedSo 1087 - Corrected caching of values in G4ExtrudedSolid. 1379 - Bug fix in G4TriangularFacet::Intersect() t 1088 - Bug fix in G4TriangularFacet::Intersect() to allow for correct update of 1380 'Distance' in condition. 1089 'Distance' in condition. 1381 - Updated unit test for G4ExtrudedSolid. 1090 - Updated unit test for G4ExtrudedSolid. 1382 1091 1383 09-Feb-2007, G.Cosmo (geom-specific-V08-02-02 1092 09-Feb-2007, G.Cosmo (geom-specific-V08-02-02) 1384 - Introduced new shape G4ExtrudedSolid, a sol 1093 - Introduced new shape G4ExtrudedSolid, a solid representing the extrusion 1385 of an arbitrary polygon with fixed outline 1094 of an arbitrary polygon with fixed outline in the two Z sections. 1386 New files: G4ExtrudedSolid[.hh.icc.cc] and 1095 New files: G4ExtrudedSolid[.hh.icc.cc] and testG4ExtrudedSolid.cc 1387 by I.Hrivnacova. 1096 by I.Hrivnacova. 1388 - G4TessellatedSolid: 1097 - G4TessellatedSolid: 1389 o Made relevant solid's methods virtual, to 1098 o Made relevant solid's methods virtual, to be used as base class. 1390 o Added implementation for GetSurfaceArea() 1099 o Added implementation for GetSurfaceArea() and GetPointOnSurface() methods. 1391 o Added protection in SurfaceNormal() metho 1100 o Added protection in SurfaceNormal() method in case of facet not found. 1392 o Check and return kOutside in Inside() if 1101 o Check and return kOutside in Inside() if point out of solid's extent. 1393 1102 1394 01-Feb-2007, G.Cosmo (geom-specific-V08-02-01 1103 01-Feb-2007, G.Cosmo (geom-specific-V08-02-01) 1395 - Fix in G4PolyconeSide::DistanceAway() for c 1104 - Fix in G4PolyconeSide::DistanceAway() for correct estimation of distance 1396 for the case of Phi sections (T.Nikitina). 1105 for the case of Phi sections (T.Nikitina). 1397 Addresses problem report #598. 1106 Addresses problem report #598. 1398 - Updated unit test for G4Polycone to conside 1107 - Updated unit test for G4Polycone to consider new test case. 1399 1108 1400 22-Jan-2007, G.Cosmo (geom-specific-V08-02-00 1109 22-Jan-2007, G.Cosmo (geom-specific-V08-02-00) 1401 - Do not scale reducible-polygon in G4Polyhed 1110 - Do not scale reducible-polygon in G4Polyhedra::Reset() method. 1402 The 'original_parameters' structure offered 1111 The 'original_parameters' structure offered as input through the accessors 1403 are always assumed to be already scaled by 1112 are always assumed to be already scaled by the 'cos(0.5*phiTotal/theNumSide)' 1404 factor. Addresses problem report #873. 1113 factor. Addresses problem report #873. 1405 - Fixed warning printout in G4Polycone::Reset 1114 - Fixed warning printout in G4Polycone::Reset(). 1406 1115 1407 15-Nov-2006, J.Allison (geom-specific-V08-01- 1116 15-Nov-2006, J.Allison (geom-specific-V08-01-04) 1408 - Fixed typo in G4Polycone::CreatePolyhedron( 1117 - Fixed typo in G4Polycone::CreatePolyhedron() introduced by mistake in 1409 the last cleanup of the source code. 1118 the last cleanup of the source code. 1410 1119 1411 13-Nov-2006, G.Cosmo (geom-specific-V08-01-03 1120 13-Nov-2006, G.Cosmo (geom-specific-V08-01-03) 1412 - Added concrete implementation of GetSurface 1121 - Added concrete implementation of GetSurfaceArea() in G4Tet (M.H.Mendenhall). 1413 1122 1414 08-Nov-2006, G.Cosmo (geom-specific-V08-01-02 1123 08-Nov-2006, G.Cosmo (geom-specific-V08-01-02) 1415 - Cleared compilation warnings on SUN-CC for 1124 - Cleared compilation warnings on SUN-CC for changes in the last tag. 1416 Fixed overloaded class variables in G4Polyh 1125 Fixed overloaded class variables in G4Polyhedra and G4Polycone 1417 implementation of CreatePolyhedron(). 1126 implementation of CreatePolyhedron(). 1418 1127 1419 31-Oct-2006, J.Allison (geom-specific-V08-01- 1128 31-Oct-2006, J.Allison (geom-specific-V08-01-01) 1420 - Implemented CreatePolyhedron() for G4Polyhe 1129 - Implemented CreatePolyhedron() for G4Polyhedra and G4Polycone. 1421 1130 1422 20-Oct-2006, G.Cosmo (geom-specific-V08-01-00 1131 20-Oct-2006, G.Cosmo (geom-specific-V08-01-00) 1423 - Implemented caching mechanism for computati 1132 - Implemented caching mechanism for computation of surface area in 1424 all solids and base classes, as done for th 1133 all solids and base classes, as done for the geometrical volume 1425 computation. 1134 computation. 1426 - Added missing fake constructor for object p 1135 - Added missing fake constructor for object persistency to G4TessellatedSolid. 1427 1136 1428 20-Jun-2006, G.Cosmo (geom-specific-V08-00-10 1137 20-Jun-2006, G.Cosmo (geom-specific-V08-00-10) 1429 - Added accessor method GetVertices() in G4Te 1138 - Added accessor method GetVertices() in G4Tet to return the list of 1430 vertices composing the solid. Required for 1139 vertices composing the solid. Required for GDML persistency. 1431 1140 1432 06-Jun-2006, G.Cosmo (geom-specific-V08-00-09 1141 06-Jun-2006, G.Cosmo (geom-specific-V08-00-09) 1433 - Added protection against NaNs in G4Polycone 1142 - Added protection against NaNs in G4PolyconeSide::Normal() for points at 1434 the origin. 1143 the origin. 1435 1144 1436 19-May-2006, G.Cosmo (geom-specific-V08-00-08 1145 19-May-2006, G.Cosmo (geom-specific-V08-00-08) 1437 - Fix in G4Ellipsoid::SetZCuts() and G4Ellipt 1146 - Fix in G4Ellipsoid::SetZCuts() and G4EllipticalTube::SetZCut() for usage 1438 of uninitialised variables. 1147 of uninitialised variables. 1439 1148 1440 08-May-2006, G.Cosmo (geom-specific-V08-00-07 1149 08-May-2006, G.Cosmo (geom-specific-V08-00-07) 1441 - Cleared compilation warning on SUN-CC in G4 1150 - Cleared compilation warning on SUN-CC in G4TriangularFacet.cc. 1442 1151 1443 04-May-2006, G.Cosmo (geom-specific-V08-00-06 1152 04-May-2006, G.Cosmo (geom-specific-V08-00-06) 1444 - Use different names for unit tests to avoid 1153 - Use different names for unit tests to avoid confusing liblist ... 1445 1154 1446 03-May-2006, G.Cosmo (geom-specific-V08-00-05 1155 03-May-2006, G.Cosmo (geom-specific-V08-00-05) 1447 - Added four unit tests for G4TessellatedSoli 1156 - Added four unit tests for G4TessellatedSolid. 1448 1157 1449 24-Mar-2006, G.Cosmo (geom-specific-V08-00-04 1158 24-Mar-2006, G.Cosmo (geom-specific-V08-00-04) 1450 - G4TwistedTubs: defined exact estimation for 1159 - G4TwistedTubs: defined exact estimation for GetCubicVolume(), 1451 similar to the one adopted for G4Tubs. 1160 similar to the one adopted for G4Tubs. 1452 1161 1453 03-Mar-2006, G.Cosmo (geom-specific-V08-00-03 1162 03-Mar-2006, G.Cosmo (geom-specific-V08-00-03) 1454 - Corrected boolean condition in G4Triangular 1163 - Corrected boolean condition in G4TriangularFacet::Intersect(). 1455 Use '&&' operator in condition. Allows for 1164 Use '&&' operator in condition. Allows for porting on WIN32-VC. 1456 1165 1457 01-Mar-2006, G.Cosmo (geom-specific-V08-00-02 1166 01-Mar-2006, G.Cosmo (geom-specific-V08-00-02) 1458 - Introducing first implementation of a tesse 1167 - Introducing first implementation of a tessellated solid, contribution 1459 of P.R.Truscott (QinetiQ Ltd, UK). 1168 of P.R.Truscott (QinetiQ Ltd, UK). 1460 New classes: G4QuadrangularFacet, G4Tessell 1169 New classes: G4QuadrangularFacet, G4TessellatedSolid, G4TriangularFacet 1461 and G4VFacet. 1170 and G4VFacet. 1462 - Requires tag "greps-V08-00-00". 1171 - Requires tag "greps-V08-00-00". 1463 1172 1464 12-Jan-2006, J.Allison (geom-specific-V08-00- 1173 12-Jan-2006, J.Allison (geom-specific-V08-00-01) 1465 - G4TwistedTubs and G4VTwistedFaceted::Create 1174 - G4TwistedTubs and G4VTwistedFaceted::CreatePolyhedron(): 1466 parameterised polyhedron mesh approximation 1175 parameterised polyhedron mesh approximation in terms of 1467 G4Polyhedron::GetNumberOfRotationSteps(). 1176 G4Polyhedron::GetNumberOfRotationSteps(). 1468 This is (a) more economical and (b) amenabl 1177 This is (a) more economical and (b) amenable to user control. 1469 1178 1470 19-Dec-2005, O.Link (geom-specific-V08-00-00) 1179 19-Dec-2005, O.Link (geom-specific-V08-00-00) 1471 - Fixes in G4EllipticalCone: 1180 - Fixes in G4EllipticalCone: 1472 o Changed GetPointOnSurface(), which was no 1181 o Changed GetPointOnSurface(), which was not uniform in endcaps. 1473 o Bug fix in Inside(), which was not correc 1182 o Bug fix in Inside(), which was not correct for the elliptic mantel. 1474 Made test similar as in G4EllipticTube. 1183 Made test similar as in G4EllipticTube. 1475 o Several fixes in DistanceToIn/Out(): for 1184 o Several fixes in DistanceToIn/Out(): for looping events (shortest 1476 distance was taken, even if 0); now compa 1185 distance was taken, even if 0); now comparing the distance to the endcap 1477 and to the mantel and decide afterwards w 1186 and to the mantel and decide afterwards which distance is shortest; 1478 added check n*v. 1187 added check n*v. 1479 o The code is now "good" at 90%. Still 10% 1188 o The code is now "good" at 90%. Still 10% wrong reconstructed events. 1480 e.g there is a problem is DistanceToOut() 1189 e.g there is a problem is DistanceToOut(): missed the intersection 1481 (reconstruction took the encap instead of 1190 (reconstruction took the encap instead of the mantel). 1482 1191 1483 09-Dec-2005, O.Link 1192 09-Dec-2005, O.Link 1484 - Fixed visibility of soft edges on the twist 1193 - Fixed visibility of soft edges on the twisted solids. 1485 1194 1486 08-Dec-2005, O.Link (geom-specific-V07-01-14) 1195 08-Dec-2005, O.Link (geom-specific-V07-01-14) 1487 - Fixed bug in G4VTwistSurface::ComputeLocalP 1196 - Fixed bug in G4VTwistSurface::ComputeLocalPoint(p) for point coordinate 1488 transformation. The bug affected only G4Twi 1197 transformation. The bug affected only G4TwistTrapFlatSide. 1489 1198 1490 06-Dec-2005, G.Cosmo (geom-specific-V07-01-13 1199 06-Dec-2005, G.Cosmo (geom-specific-V07-01-13) 1491 - Fixed compilation errors on WIN32-VC for la 1200 - Fixed compilation errors on WIN32-VC for last tag changes. 1492 1201 1493 05-Dec-2005, O.Link (geom-specific-V07-01-12) 1202 05-Dec-2005, O.Link (geom-specific-V07-01-12) 1494 - Added polyhedron definition for twisted sol 1203 - Added polyhedron definition for twisted solids (G4TwistedTrap, 1495 G4TwistedTrd, G4TwistedBox, G4TwistedTubs) 1204 G4TwistedTrd, G4TwistedBox, G4TwistedTubs) for visualization. 1496 1205 1497 30-Nov-2005, G.Cosmo (geom-specific-V07-01-11 1206 30-Nov-2005, G.Cosmo (geom-specific-V07-01-11) 1498 - Trivial fixes for porting on CLHEP-2.0.X se 1207 - Trivial fixes for porting on CLHEP-2.0.X series. 1499 1208 1500 18-Nov-2005, O.Link (geom-specific-V07-01-10) 1209 18-Nov-2005, O.Link (geom-specific-V07-01-10) 1501 - Renamed classes for twisted solids set, to 1210 - Renamed classes for twisted solids set, to identify them in the 1502 twisted framework. 1211 twisted framework. 1503 1212 1504 17-Nov-2005, O.Link 1213 17-Nov-2005, O.Link 1505 - G4VTwistedFacted: 1214 - G4VTwistedFacted: 1506 o corrected bug in DistanceToSurface() impl 1215 o corrected bug in DistanceToSurface() implementation 1507 o added GetPointOnSurface() method 1216 o added GetPointOnSurface() method 1508 - G4TwistedTubs: 1217 - G4TwistedTubs: 1509 o added GetPointOnSurface() method 1218 o added GetPointOnSurface() method 1510 - G4Hype: 1219 - G4Hype: 1511 o corrected surface area calculation used i 1220 o corrected surface area calculation used in GetPointOnSurface() 1512 << 1221 1513 17-Nov-2005, G.Cosmo (geom-specific-V07-01-09 1222 17-Nov-2005, G.Cosmo (geom-specific-V07-01-09) 1514 - More fixes required for direct object persi 1223 - More fixes required for direct object persistency to G4Polycone, 1515 G4polyhedra and related utility classes. 1224 G4polyhedra and related utility classes. 1516 1225 1517 10-Nov-2005, J.Allison (geom-specific-V07-01- 1226 10-Nov-2005, J.Allison (geom-specific-V07-01-08) 1518 - G4Tet: 1227 - G4Tet: 1519 o Added implementation for GetPolyhedron() 1228 o Added implementation for GetPolyhedron() and GetCubicVolume(). 1520 o Corrected order of specifying vertices in 1229 o Corrected order of specifying vertices in CreatePolyhedron(). 1521 1230 1522 09-Nov-2005, G.Cosmo (geom-specific-V07-01-07 1231 09-Nov-2005, G.Cosmo (geom-specific-V07-01-07) 1523 - Added fake default constructor for all conc 1232 - Added fake default constructor for all concrete solids and relevant 1524 utility classes, for usage of direct object 1233 utility classes, for usage of direct object persistency. 1525 - Implemented changes to support CLHEP-2.0.X 1234 - Implemented changes to support CLHEP-2.0.X for explicit usage of the 1526 CLHEP/HepGeom namespaces for CLHEP types. 1235 CLHEP/HepGeom namespaces for CLHEP types. 1527 1236 1528 07-Nov-2005, G.Cosmo (geom-specific-V07-01-06 1237 07-Nov-2005, G.Cosmo (geom-specific-V07-01-06) 1529 - G4Ellipsoid: replaced call to hypot(x,y) wi 1238 - G4Ellipsoid: replaced call to hypot(x,y) with std::sqrt(x*x+y*y) 1530 for porting to ISO standard. 1239 for porting to ISO standard. 1531 1240 1532 02-Nov-2005, G.Cosmo (geom-specific-V07-01-05 1241 02-Nov-2005, G.Cosmo (geom-specific-V07-01-05) 1533 - G4Polyhedra, G4Polycone: 1242 - G4Polyhedra, G4Polycone: 1534 o Protected case of generic construct for v 1243 o Protected case of generic construct for visualization. 1535 o Introduced explicit flag and method IsGen 1244 o Introduced explicit flag and method IsGeneric() to identify the kind 1536 of constructor used. 1245 of constructor used. 1537 1246 1538 29-Sep-2005, G.Cosmo (geom-specific-V07-01-04 1247 29-Sep-2005, G.Cosmo (geom-specific-V07-01-04) 1539 - Fix in G4EllipticalCone methods DistanceToI 1248 - Fix in G4EllipticalCone methods DistanceToIn() and DistanceToOut(). 1540 Added unit test for it (by D.Anninos). 1249 Added unit test for it (by D.Anninos). 1541 - Coworks with tag "greps-V07-01-02". 1250 - Coworks with tag "greps-V07-01-02". 1542 1251 1543 10-Aug-2005, G.Cosmo (geom-specific-V07-01-03 1252 10-Aug-2005, G.Cosmo (geom-specific-V07-01-03) 1544 - Introduced new solid G4EllipticalCone, a fu 1253 - Introduced new solid G4EllipticalCone, a full cone with elliptical base 1545 that can be cut in Z (by D.Anninos). 1254 that can be cut in Z (by D.Anninos). 1546 Coworks with tag "greps-V07-01-02". 1255 Coworks with tag "greps-V07-01-02". 1547 1256 1548 08-Aug-2005, D.Anninos (geom-specific-V07-01- 1257 08-Aug-2005, D.Anninos (geom-specific-V07-01-02) 1549 - Added GetPointOnSurface() for all solids ex 1258 - Added GetPointOnSurface() for all solids except twisted ones. 1550 The method returns a random point according 1259 The method returns a random point according to a quasi-uniform 1551 distribution along the surface. 1260 distribution along the surface. 1552 1261 1553 18-Jul-2005, G.Cosmo (geom-specific-V07-01-01 1262 18-Jul-2005, G.Cosmo (geom-specific-V07-01-01) 1554 - Fixed compilation warning on WIN32-VC for G 1263 - Fixed compilation warning on WIN32-VC for G4VSurface.cc. 1555 - Not including G4Tet. 1264 - Not including G4Tet. 1556 1265 1557 06-Jul-2005, G.Cosmo (geom-specific-V07-01-00 1266 06-Jul-2005, G.Cosmo (geom-specific-V07-01-00) 1558 - Added new shape G4Ellipsoid. Coworks with t 1267 - Added new shape G4Ellipsoid. Coworks with tag "greps-V07-01-00". 1559 Contribution of G.Horton-Smith and G.Guerri 1268 Contribution of G.Horton-Smith and G.Guerrieri. 1560 Code cleanup, and added default arguments f 1269 Code cleanup, and added default arguments for cuts, added first 1561 implementation of unit test. 1270 implementation of unit test. 1562 - Corrected unit tests for twisted-box/trap. 1271 - Corrected unit tests for twisted-box/trap. 1563 - Not including G4Tet. 1272 - Not including G4Tet. 1564 1273 1565 15-Jun-2005, J.Apostolakis 1274 15-Jun-2005, J.Apostolakis 1566 - Introduced new solid G4Tet, contribution of 1275 - Introduced new solid G4Tet, contribution of M.H.Mendenhall 1567 and R.A.Weller, Vanderbilt University, USA. 1276 and R.A.Weller, Vanderbilt University, USA. 1568 1277 1569 29-Apr-2005, O.Link (geom-specific-V07-00-04) 1278 29-Apr-2005, O.Link (geom-specific-V07-00-04) 1570 - G4TwistedSurface: fixed bug in GetAreaCode( 1279 - G4TwistedSurface: fixed bug in GetAreaCode() affecting G4TwistedTubs. 1571 1280 1572 04-Apr-2005, G.Cosmo (geom-specific-V07-00-03 1281 04-Apr-2005, G.Cosmo (geom-specific-V07-00-03) 1573 - Added test for Number-Of-Rotation-Steps in 1282 - Added test for Number-Of-Rotation-Steps in GetPolyhedron() for 1574 G4VCSGfaceted, G4Hype and G4EllipticalTube 1283 G4VCSGfaceted, G4Hype and G4EllipticalTube (by J.Allison). 1575 Requires tag "greps-V07-00-02". 1284 Requires tag "greps-V07-00-02". 1576 - Added elementary implementation of CreatePo 1285 - Added elementary implementation of CreatePolyhedron() for G4Hype, 1577 G4TwistedBox, G4TwistedTubs, G4TwistedTrd, 1286 G4TwistedBox, G4TwistedTubs, G4TwistedTrd, G4TwistedTrap. 1578 - Some code cleanup. 1287 - Some code cleanup. 1579 1288 1580 18-Mar-2005, O.Link (geom-specific-V07-00-02) 1289 18-Mar-2005, O.Link (geom-specific-V07-00-02) 1581 - New generic framework for twisted solids G4 1290 - New generic framework for twisted solids G4TwistedBox, G4TwistedTrd and 1582 G4TwistedTrap: inheriting now from the base 1291 G4TwistedTrap: inheriting now from the base class G4VTwistedFaceted. 1583 - Extended G4TwistedTrap to support setups wi 1292 - Extended G4TwistedTrap to support setups with different trapezoidal 1584 endcaps with centres not necessarily on a l 1293 endcaps with centres not necessarily on a line parallel to the z axis. 1585 - Added G4TwistedTrd and general G4TwistedTra 1294 - Added G4TwistedTrd and general G4TwistedTrap as test cases in test. 1586 1295 1587 03-Mar-2005, J.Allison 1296 03-Mar-2005, J.Allison 1588 - Changed AddThis() to AddSolid() for all sol 1297 - Changed AddThis() to AddSolid() for all solids in the implementation 1589 of DescribeYourselfTo(G4VGraphicsScene&). 1298 of DescribeYourselfTo(G4VGraphicsScene&). 1590 1299 1591 01-Mar-2005, O.Link (geom-specific-V07-00-01) 1300 01-Mar-2005, O.Link (geom-specific-V07-00-01) 1592 - Fixed compilation warnings on WIN32-VC for 1301 - Fixed compilation warnings on WIN32-VC for G4VSurface.cc. 1593 1302 1594 14-Feb-2005, O.Link (geom-specific-V07-00-00) 1303 14-Feb-2005, O.Link (geom-specific-V07-00-00) 1595 - Use new polynom approximations based on new 1304 - Use new polynom approximations based on new solver based on Jenkins-Traub 1596 algorithm, for twisted-box and twisted-trap 1305 algorithm, for twisted-box and twisted-trap. 1597 - Fixed bug in the usage of 'fmod' and adopt 1306 - Fixed bug in the usage of 'fmod' and adopt special treatment for 'parallel' 1598 events in G4TwistedBoxSide and G4TwistedTra 1307 events in G4TwistedBoxSide and G4TwistedTrapSide. 1599 - Coworks with tag "global-V07-00-00". 1308 - Coworks with tag "global-V07-00-00". 1600 1309 1601 08-Dec-2004, O.Link (geom-specific-V06-02-07) 1310 08-Dec-2004, O.Link (geom-specific-V06-02-07) 1602 - Extensions to twisted box/trap shapes to co 1311 - Extensions to twisted box/trap shapes to consider all 4 solutions 1603 for determining correct intersections. 1312 for determining correct intersections. 1604 1313 1605 29-Nov-2004, O.Link (geom-specific-V06-02-06) 1314 29-Nov-2004, O.Link (geom-specific-V06-02-06) 1606 - G4TwistedTrapSide, G4TwistedBoxSide: improv 1315 - G4TwistedTrapSide, G4TwistedBoxSide: improved (analytical) version 1607 of GetPhiUAtX() method. 1316 of GetPhiUAtX() method. 1608 1317 1609 24-Nov-2004, O.Link (geom-specific-V06-02-05) 1318 24-Nov-2004, O.Link (geom-specific-V06-02-05) 1610 - Fixed bug in description of twisted trapezo 1319 - Fixed bug in description of twisted trapezoid side. 1611 1320 1612 12-Nov-2004, O.Link (geom-specific-V06-02-04) 1321 12-Nov-2004, O.Link (geom-specific-V06-02-04) 1613 - Added G4TwistedBox - a twisted box with tw 1322 - Added G4TwistedBox - a twisted box with twist angle alpha, 1614 length a/2,b/2,L/2. 1323 length a/2,b/2,L/2. 1615 - Added G4TwistedTrap - a twisted trapezoid ( 1324 - Added G4TwistedTrap - a twisted trapezoid (still in debug state) 1616 - Changed in G4VSurface.icc: << 1325 - Changed in G4VSurface.icc: 1617 - GetNeighbours(): corrected axiscode (wa 1326 - GetNeighbours(): corrected axiscode (was returning the wrong neighbours) 1618 - SetNeighbours(): fixed problem #685 (in 1327 - SetNeighbours(): fixed problem #685 (index out of range) 1619 - Added tests for G4TwistedBox and G4TwistedT 1328 - Added tests for G4TwistedBox and G4TwistedTrap in specific/test. 1620 - Added G4TwistedBox and G4TwistedTrap in sys 1329 - Added G4TwistedBox and G4TwistedTrap in system testing, test10. 1621 1330 1622 22-Oct-2004, D.C.Williams (geom-specific-V06- 1331 22-Oct-2004, D.C.Williams (geom-specific-V06-02-03) 1623 - Fix in G4PolyconeSide::Inside for points at 1332 - Fix in G4PolyconeSide::Inside for points at radius = 0 for phi slides 1624 solids with an inner radius. Addresses prob 1333 solids with an inner radius. Addresses problem report #598. 1625 1334 1626 10-Oct-2004, J.Allison (geom-specific-V06-02- 1335 10-Oct-2004, J.Allison (geom-specific-V06-02-02) 1627 - Added GetPolyhedron, a smart access functio 1336 - Added GetPolyhedron, a smart access function that creates a G4Polyhedron 1628 on request and stores for future access. A 1337 on request and stores for future access. A null pointer means "not 1629 available". 1338 available". 1630 1339 1631 22-Sep-2004, G.Cosmo (geom-specific-V06-02-01 1340 22-Sep-2004, G.Cosmo (geom-specific-V06-02-01) 1632 - Added implementation of GetCubicVolume() wi 1341 - Added implementation of GetCubicVolume() with cashing mechanism for 1633 solids: G4EllipticalTube, G4Hype, G4Polyhed 1342 solids: G4EllipticalTube, G4Hype, G4Polyhedra, G4Polycone, G4TwistedTubs. 1634 1343 1635 01-Sep-2004, D.C.Williams (geom-specific-V06- 1344 01-Sep-2004, D.C.Williams (geom-specific-V06-02-00) 1636 - G4VCSGfaceted: fix for rare anomalous situa 1345 - G4VCSGfaceted: fix for rare anomalous situation in which 1637 DistanceToOut(p,v,..) will report kInfinity 1346 DistanceToOut(p,v,..) will report kInfinity, make an additional check 1638 for the point p on the surface, in which ca 1347 for the point p on the surface, in which case will report zero. 1639 Addresses problem observed in G4Polyhedra a 1348 Addresses problem observed in G4Polyhedra and reported in #650. 1640 1349 1641 07-Jun-2004, G.Cosmo (geom-specific-V06-01-04 1350 07-Jun-2004, G.Cosmo (geom-specific-V06-01-04) 1642 - Fixed compilation problem in G4TwistedSurfa 1351 - Fixed compilation problem in G4TwistedSurface.cc on WIN32-VC. 1643 1352 1644 28-May-2004, G.Cosmo (geom-specific-V06-01-03 1353 28-May-2004, G.Cosmo (geom-specific-V06-01-03) 1645 - Fixed archiving problem on WIN32-VC7: repla 1354 - Fixed archiving problem on WIN32-VC7: replaced structs with classes 1646 in G4VSurface. 1355 in G4VSurface. 1647 - Replaced misleading names for masks in G4VS 1356 - Replaced misleading names for masks in G4VSurface and moved inlined 1648 methods of nested classes to .cc. 1357 methods of nested classes to .cc. 1649 1358 1650 25-May-2004, G.Cosmo (geom-specific-V06-01-02 1359 25-May-2004, G.Cosmo (geom-specific-V06-01-02) 1651 - Fixed compilation problem on SUN-CC. Made E 1360 - Fixed compilation problem on SUN-CC. Made EValidate enum public in 1652 G4VSurface.hh. 1361 G4VSurface.hh. 1653 1362 1654 24-May-2004, G.Cosmo (geom-specific-V06-01-01 1363 24-May-2004, G.Cosmo (geom-specific-V06-01-01) 1655 - Removed compilation warnings and minor clea 1364 - Removed compilation warnings and minor cleanup... 1656 1365 1657 19-May-2004, O.Link (geom-specific-V06-01-00) 1366 19-May-2004, O.Link (geom-specific-V06-01-00) 1658 - First implementation of a framework for twi 1367 - First implementation of a framework for twisted surfaces, integrated from 1659 the original version of Kotoyo Hoshina (hos 1368 the original version of Kotoyo Hoshina (hoshina@hepburn.s.chiba-u.ac.jp) 1660 implemented in the 'Jupiter' application. 1369 implemented in the 'Jupiter' application. 1661 o Includes new specific twisted shape: G4Tw 1370 o Includes new specific twisted shape: G4TwistedTubs. 1662 o New classes: G4VSurface, G4TwistedSurface 1371 o New classes: G4VSurface, G4TwistedSurface, G4HyperbolicSurface, 1663 G4FlatSurface, G4TwistedTubs 1372 G4FlatSurface, G4TwistedTubs. 1664 o Cleanup of original code (debugging messa 1373 o Cleanup of original code (debugging messages, compiler errors, migration 1665 of g4std to new convention...) 1374 of g4std to new convention...) 1666 o New organisation of class G4TwistedTubs: 1375 o New organisation of class G4TwistedTubs: now independent of XXXSurface; 1667 removed backpointer 'fSolid' from XXXSurf 1376 removed backpointer 'fSolid' from XXXSurface to G4TwistedTubs. 1668 o New form of constructors in G4TwistedSurf 1377 o New form of constructors in G4TwistedSurface, G4HyperbolicSurface and 1669 G4FlatSurface. 1378 G4FlatSurface. 1670 o Change in G4TwistedSurface::DistanceToIn( 1379 o Change in G4TwistedSurface::DistanceToIn(p,v,...): roundoff correction. 1671 1380 1672 12-Jan-2004, G.Cosmo (geom-specific-V06-00-00 1381 12-Jan-2004, G.Cosmo (geom-specific-V06-00-00) 1673 - G4PolyhedraSide.cc: fixed bug in which part 1382 - G4PolyhedraSide.cc: fixed bug in which particles could "leak" out the 1674 center of a face if inner radius = 0. 1383 center of a face if inner radius = 0. 1675 Fixes problem report #547. (D.Williams) 1384 Fixes problem report #547. (D.Williams) 1676 1385 1677 22-Nov-2003, G.Cosmo (geom-specific-V05-02-07 1386 22-Nov-2003, G.Cosmo (geom-specific-V05-02-07) 1678 - Fixed upper bound for protection check intr 1387 - Fixed upper bound for protection check introduced in G4Polycone and 1679 G4Polyhedra constructors. 1388 G4Polyhedra constructors. 1680 1389 1681 17-Nov-2003, G.Cosmo (geom-specific-V05-02-06 1390 17-Nov-2003, G.Cosmo (geom-specific-V05-02-06) 1682 - Added protections in G4Polycone and G4Polyh 1391 - Added protections in G4Polycone and G4Polyhedra constructors for 1683 invalid constructs with no contiguous segme 1392 invalid constructs with no contiguous segments in Z planes as input. 1684 1393 1685 04-Nov-2003, G.Cosmo (geom-specific-V05-02-05 1394 04-Nov-2003, G.Cosmo (geom-specific-V05-02-05) 1686 - Added SetOriginalParameters() method to G4P 1395 - Added SetOriginalParameters() method to G4Polycone and G4Polyhedra. 1687 1396 1688 03-Nov-2003, G.Cosmo (geom-specific-V05-02-04 1397 03-Nov-2003, G.Cosmo (geom-specific-V05-02-04) 1689 - Code cleanup and headers inclusion review 1398 - Code cleanup and headers inclusion review 1690 (replaced by forward declarations where nec 1399 (replaced by forward declarations where necessary). 1691 1400 1692 28-Oct-2003, G.Cosmo (geom-specific-V05-02-03 1401 28-Oct-2003, G.Cosmo (geom-specific-V05-02-03) 1693 - Migrated to new G4Exception scheme. 1402 - Migrated to new G4Exception scheme. 1694 1403 1695 20-Oct-2003, G.Cosmo (geom-specific-V05-02-02 1404 20-Oct-2003, G.Cosmo (geom-specific-V05-02-02) 1696 - Added Reset() method in G4Polycone and G4Po 1405 - Added Reset() method in G4Polycone and G4Polyhedra to allow 1697 recalculation and reshape of the solid if n 1406 recalculation and reshape of the solid if new original_parameters 1698 are provided. 1407 are provided. 1699 1408 1700 30-Sep-2003, G.Cosmo (geom-specific-V05-02-01 1409 30-Sep-2003, G.Cosmo (geom-specific-V05-02-01) 1701 - Updated GNUmakefile for unit tests, accordi 1410 - Updated GNUmakefile for unit tests, according to new structure 1702 introduced in "geometry-V05-02-00". 1411 introduced in "geometry-V05-02-00". 1703 1412 1704 16-Jun-2003, G.Cosmo (geom-specific-V05-02-00 1413 16-Jun-2003, G.Cosmo (geom-specific-V05-02-00) 1705 - Added accessors to original_parameters for 1414 - Added accessors to original_parameters for G4Polycone and G4Polyhedra. 1706 Made G4PolyconeHistorical and G4PolyhedraHi 1415 Made G4PolyconeHistorical and G4PolyhedraHistorical classes in global 1707 scope (temporary solution). 1416 scope (temporary solution). 1708 1417 1709 28-Mar-2003, G.Cosmo (geom-specific-V05-00-00 1418 28-Mar-2003, G.Cosmo (geom-specific-V05-00-00) 1710 - Fixed initialisation of base class in copy 1419 - Fixed initialisation of base class in copy contructor for: 1711 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraS 1420 G4PolyPhiFace, G4PolyconeSide, G4PolyhedraSide. 1712 - Fixed trivial pedantic warnings on G4Polyco 1421 - Fixed trivial pedantic warnings on G4Polycone and G4Polyhedra. 1713 1422 1714 30-Oct-2002, G.Cosmo (geom-specific-V04-01-01 1423 30-Oct-2002, G.Cosmo (geom-specific-V04-01-01) 1715 - Fixed un-initialised data members in constr 1424 - Fixed un-initialised data members in constructors of classes: 1716 G4ClippablePolygon, G4EnclosingCylinder, G4 1425 G4ClippablePolygon, G4EnclosingCylinder, G4PolyconeSide, 1717 G4ReduciblePolygon, G4VCSGfaceted. 1426 G4ReduciblePolygon, G4VCSGfaceted. 1718 1427 1719 28-Oct-2002, G.Cosmo (geom-specific-V04-01-00 1428 28-Oct-2002, G.Cosmo (geom-specific-V04-01-00) 1720 - Added implementation of StreamInfo() to com 1429 - Added implementation of StreamInfo() to comply with new interface for 1721 G4VSolid in "geommng-V04-01-03". 1430 G4VSolid in "geommng-V04-01-03". 1722 - Created .icc files for G4EllipticalTube, G4 1431 - Created .icc files for G4EllipticalTube, G4Polyhedra and G4Polycone. 1723 - Some cosmetic changes to code formatting: r 1432 - Some cosmetic changes to code formatting: removed <TAB> characters and adopt 1724 uniform code indentation. 1433 uniform code indentation. 1725 1434 1726 08-May-2002, J.Allison (geom-solids-specific- 1435 08-May-2002, J.Allison (geom-solids-specific-V04-00-01) 1727 - Implemented G4EllipticalTube::CreatePolyhed 1436 - Implemented G4EllipticalTube::CreatePolyhedron. 1728 1437 1729 10-Jan-2002, G.Cosmo (geom-solids-specific-V0 1438 10-Jan-2002, G.Cosmo (geom-solids-specific-V04-00-00) 1730 - Updated unit tests. 1439 - Updated unit tests. 1731 1440 1732 20-Apr-2001, G.Cosmo (geom-solids-specific-V0 1441 20-Apr-2001, G.Cosmo (geom-solids-specific-V03-01-00) 1733 - Migration to STL vector: 1442 - Migration to STL vector: 1734 o In G4ClippablePolygon, migrated G4ThreeVe 1443 o In G4ClippablePolygon, migrated G4ThreeVectorList typedef and 1735 made private to class. 1444 made private to class. 1736 << 1445 1737 03-Apr-2001, D.Williams (geom-solids-specifi 1446 03-Apr-2001, D.Williams (geom-solids-specific-V03-00-01) 1738 ----------------------- 1447 ----------------------- 1739 - G4IntersectingCone.cc: make small adjustmen 1448 - G4IntersectingCone.cc: make small adjustment to help with roundoff error 1740 in LineHitsCone1() and LineHitsCone2(). 1449 in LineHitsCone1() and LineHitsCone2(). 1741 1450 1742 08-Jan-2001, D.Williams (geom-solids-specifi 1451 08-Jan-2001, D.Williams (geom-solids-specific-V03-00-00) 1743 ----------------------- 1452 ----------------------- 1744 - G4Hype.cc: Added protecton against zero v.z 1453 - G4Hype.cc: Added protecton against zero v.z in DistanceToOut. 1745 1454 1746 20-Nov-2000, G.Cosmo (geom-solids-specifi 1455 20-Nov-2000, G.Cosmo (geom-solids-specific-V02-00-04) 1747 --------------------- 1456 --------------------- 1748 - Fixes to remove warnings from "-Wall -ansi 1457 - Fixes to remove warnings from "-Wall -ansi -pedantic" g++ compiler options: 1749 o commented out variables declared and not 1458 o commented out variables declared and not used. 1750 o fixed declaration of variables used befor 1459 o fixed declaration of variables used before being initialised. 1751 o fixed order of initialisation of member d 1460 o fixed order of initialisation of member data in constructors. 1752 o fixed usage of unsigned-int (size_t) for 1461 o fixed usage of unsigned-int (size_t) for array indeces. 1753 1462 1754 13-Nov-2000, G.Cosmo (geom-solids-specifi 1463 13-Nov-2000, G.Cosmo (geom-solids-specific-V02-00-03) 1755 -------------------- 1464 -------------------- 1756 - Added definition of empty constructor for G 1465 - Added definition of empty constructor for G4ClippablePolygon which 1757 went lost by mistake... 1466 went lost by mistake... 1758 1467 1759 02-Nov-2000, G.Cosmo (geom-solids-specifi 1468 02-Nov-2000, G.Cosmo (geom-solids-specific-V02-00-02) 1760 -------------------- 1469 -------------------- 1761 - QA code revision and cleanup (+fixes from C 1470 - QA code revision and cleanup (+fixes from CodeWizard filtering): 1762 o Avoid inline virtual methods. 1471 o Avoid inline virtual methods. 1763 o General cosmetics for Software Reference 1472 o General cosmetics for Software Reference Manual. 1764 1473 1765 23-Oct-2000, D.Williams (geom-solids-specifi 1474 23-Oct-2000, D.Williams (geom-solids-specific-V02-00-01) 1766 ----------------------- 1475 ----------------------- 1767 - G4IntersectingCone.cc: the check for a zero 1476 - G4IntersectingCone.cc: the check for a zero radical has been adjusted to be 1768 less sensitive to round off error in LineHi 1477 less sensitive to round off error in LineHitsCone1(), LineHitsCone2(). 1769 This fixes a problem discovered in BaBar. 1478 This fixes a problem discovered in BaBar. 1770 1479 1771 12-Sep-2000, G.Cosmo (geom-solids-specific-V 1480 12-Sep-2000, G.Cosmo (geom-solids-specific-V02-00-00) 1772 -------------------- 1481 -------------------- 1773 - Organised comments to headers for Software 1482 - Organised comments to headers for Software Reference Manual. 1774 1483 1775 27-Jun-2000, G.Cosmo (geom-solids-specific-V 1484 27-Jun-2000, G.Cosmo (geom-solids-specific-V01-01-02) 1776 -------------------- 1485 -------------------- 1777 - G4Polycone[.hh.cc]: better fix for bug-repo 1486 - G4Polycone[.hh.cc]: better fix for bug-report #110. 1778 Removed struct and replaced with class. 1487 Removed struct and replaced with class. 1779 1488 1780 26-Jun-2000, G.Cosmo (geom-solids-specific-V 1489 26-Jun-2000, G.Cosmo (geom-solids-specific-V01-01-01) 1781 -------------------- 1490 -------------------- 1782 - G4Polycone.cc: fixed memory leak by invokin 1491 - G4Polycone.cc: fixed memory leak by invoking destruction of member 1783 enclosingCylinder, which was not cleaned up 1492 enclosingCylinder, which was not cleaned up in the destructor. 1784 This fixes problem report #107. 1493 This fixes problem report #107. 1785 - G4Polycone.hh: added forward declaration of 1494 - G4Polycone.hh: added forward declaration of struct G4PolyconeHistorical 1786 and made it friend, for porting on KCC --st 1495 and made it friend, for porting on KCC --strict. This fixes report #110. 1787 - G4Polyhedra.hh: fixed typo in method name. 1496 - G4Polyhedra.hh: fixed typo in method name. Changed GetNumSIde() to 1788 GetNumSide(). This fixes problem report #10 1497 GetNumSide(). This fixes problem report #105. 1789 1498 1790 08-Jun-2000, G.Gracia 1499 08-Jun-2000, G.Gracia 1791 --------------------- 1500 --------------------- 1792 - G4VCSGfaceted.cc: fix for Win/NT in functio 1501 - G4VCSGfaceted.cc: fix for Win/NT in function GetExtent(). 1793 1502 1794 27-Apr-2000, G.Cosmo 1503 27-Apr-2000, G.Cosmo 1795 -------------------- 1504 -------------------- 1796 - Removed dependency over the CSG domain in G 1505 - Removed dependency over the CSG domain in GNUmakefile. 1797 1506 1798 18-Apr-2000, D.Williams 1507 18-Apr-2000, D.Williams 1799 ----------------------- 1508 ----------------------- 1800 - Removed meaningless "const" specifiers from 1509 - Removed meaningless "const" specifiers from methods in G4ClippablePolygon, 1801 and G4EllipticalTube. 1510 and G4EllipticalTube. 1802 - G4EllipticalTube, G4Hype and G4VCSGfaceted 1511 - G4EllipticalTube, G4Hype and G4VCSGfaceted now inherit directly 1803 from G4VSolid (before was G4CSGSolid). 1512 from G4VSolid (before was G4CSGSolid). 1804 - Reintroduced GetExtent() in G4EllipticalTub 1513 - Reintroduced GetExtent() in G4EllipticalTube, G4Hype and G4VCSGfaceted 1805 (in principle, not needed). 1514 (in principle, not needed). 1806 - Modified assertations in unit test testG4Hy 1515 - Modified assertations in unit test testG4Hype.cc. 1807 1516 1808 11-Apr-2000, J.Allison 1517 11-Apr-2000, J.Allison 1809 ---------------------- 1518 ---------------------- 1810 - Removed implementations of GetExtent in mos 1519 - Removed implementations of GetExtent in most sub-classes of G4VSolid (a 1811 default implementation exists in G4VSolid). 1520 default implementation exists in G4VSolid). 1812 - All implementations of DescribeYourselfTo ( 1521 - All implementations of DescribeYourselfTo (G4VGraphicsScene& scene) const 1813 now correctly written: scene.AddThis(*this) 1522 now correctly written: scene.AddThis(*this). 1814 1523 1815 05-Apr-2000, G.Cosmo (geom-solids-specific- 1524 05-Apr-2000, G.Cosmo (geom-solids-specific-V01-01-00) 1816 -------------------- 1525 -------------------- 1817 - Restructured solids/CSG domain, by moving t 1526 - Restructured solids/CSG domain, by moving to "specific" the following 1818 classes: G4ClippablePolygon, G4EnclosingCyl 1527 classes: G4ClippablePolygon, G4EnclosingCylinder, G4Hype, G4PolyPhiFace, 1819 G4Polycone, G4PolyconeSide, G4Polyhedra, G4 1528 G4Polycone, G4PolyconeSide, G4Polyhedra, G4PolyhedraSide, G4ReduciblePolygon, 1820 G4IntersectingCone, G4SolidExtentList, G4VC 1529 G4IntersectingCone, G4SolidExtentList, G4VCSGface, G4VCSGfaceted. 1821 The new module's library for "specific" is 1530 The new module's library for "specific" is now called 'G4specsolids'. 1822 - Created specific/test directory and moved t 1531 - Created specific/test directory and moved testG4Hype.cc and testG4Polycone,cc 1823 from CSG/test. 1532 from CSG/test. 1824 - Organised class description comments for th 1533 - Organised class description comments for the Software Reference Manual 1825 and added CVS headers to files. 1534 and added CVS headers to files. 1826 1535 1827 29-Mar-2000, D.Williams 1536 29-Mar-2000, D.Williams 1828 ----------------------- 1537 ----------------------- 1829 - Added first implementation of G4EllipticalT 1538 - Added first implementation of G4EllipticalTube. 1830 It defines a simple elliptical tube, as in 1539 It defines a simple elliptical tube, as in geant3 "ELTU". 1831 Files introduced: G4EllipticalTube[.hh.cc]. 1540 Files introduced: G4EllipticalTube[.hh.cc]. 1832 1541 1833 25-Mar-2000, G.Cosmo 1542 25-Mar-2000, G.Cosmo 1834 -------------------- 1543 -------------------- 1835 - History file created. 1544 - History file created.