Geant4 Cross Reference |
1 # Category field History 1 # Category field History 2 2 3 See `CONTRIBUTING.rst` for details of **requir 3 See `CONTRIBUTING.rst` for details of **required** info/format for each entry, 4 which **must** added in reverse chronological 4 which **must** added in reverse chronological order (newest at the top). 5 It must **not** be used as a substitute for wr 5 It must **not** be used as a substitute for writing good git commit messages! 6 6 7 ---------------------------------------------- 7 ------------------------------------------------------------------------------- 8 8 9 ## 2024-11-26 Ivana Hrivnacova (field-V11-02-0 << 9 ## 2024-04-17 Ben Morgan (field-V11-01-07) 10 - Better names for the G4EquationType enum con << 11 << 12 ## 2024-11-04 Philippe Canal (field-V11-02-05) << 13 - Improve stability of static initialization f << 14 StepperDescription() in G4DormandPrince745. << 15 << 16 ## 2024-09-10 Ivana Hrivnacova (field-V11-02-0 << 17 - Coverity fixes: << 18 - Use std::move, const auto& instead of auto << 19 << 20 ## 2024-06-20 Ivana Hrivnacova (field-V11-02-0 << 21 - Fix in G4FieldBuilder for local fields: << 22 apply the local fields in the order of user << 23 << 24 ## 2024-04-29 Ivana Hrivnacova (field-V11-02-0 << 25 - Added classes for automatic field constructi << 26 - G4FieldBuilder[Messenger], G4FieldParamete << 27 - No changes in other Geant4 classes << 28 << 29 ## 2024-04-17 Ben Morgan (field-V11-02-01) << 30 - Fix maybe-uninitialized warnings found in AT 10 - Fix maybe-uninitialized warnings found in ATLAS builds 31 - Reported in internal ATLASSIM-6058 ticket. 11 - Reported in internal ATLASSIM-6058 ticket. 32 << 33 ## 2024-04-02 Gabriele Cosmo (field-V11-02-00) << 34 - Applied trivial clang-tidy fixes to classes, << 35 constructor/destructor, auto and using state << 36 - Minor cleanup in QSS classes. << 37 12 38 ## 2023-11-03 Gabriele Cosmo (field-V11-01-06) 13 ## 2023-11-03 Gabriele Cosmo (field-V11-01-06) 39 - Reinstated default DormandPrince745 stepper. 14 - Reinstated default DormandPrince745 stepper. 40 15 41 ## 2023-10-27 Lucio Santi (field-V11-01-05) 16 ## 2023-10-27 Lucio Santi (field-V11-01-05) 42 - Improvements on the QSS Stepper 17 - Improvements on the QSS Stepper 43 The main QSS integration loop is interrupted 18 The main QSS integration loop is interrupted when the number of substeps 44 exceeds a predefined threshold (set to 1000 19 exceeds a predefined threshold (set to 1000 by default). 45 20 46 ## 2023-06-14 Gabriele Cosmo (field-V11-01-04) 21 ## 2023-06-14 Gabriele Cosmo (field-V11-01-04) 47 - Applied clang-tidy fixes (readability, moder 22 - Applied clang-tidy fixes (readability, modernization, performance, ...). 48 23 49 ## 2023-06-12 John Apostolakis (field-V11-01-0 24 ## 2023-06-12 John Apostolakis (field-V11-01-03) 50 - Inclusion of QSS integration method. 25 - Inclusion of QSS integration method. 51 Most recent changes: 26 Most recent changes: 52 * Fixes for issue with SetPrecision (used un 27 * Fixes for issue with SetPrecision (used unitialised values of simulator->x) 53 * Updated values of parameters in G4Propagat 28 * Updated values of parameters in G4PropagatorInField to conservative values. 54 * Withdrew interim changes that made QSS the 29 * Withdrew interim changes that made QSS the default method for full testing. 55 30 56 ## 2023-05-26 Lucio Santi 31 ## 2023-05-26 Lucio Santi 57 - Fixes for open issues: 32 - Fixes for open issues: 58 * default values for QSS made stricter dQRel 33 * default values for QSS made stricter dQRel=0.001, dQMin=0.0001 (QSSDriver.icc) 59 to improve behaviour in full experiment te 34 to improve behaviour in full experiment test 60 * implemented missing DistChord method -- ne 35 * implemented missing DistChord method -- needed to enable stepping with Chord limit 61 36 62 ## 2023-01-31 John Apostolakis 37 ## 2023-01-31 John Apostolakis 63 - Initial inclusion of QSS integration method. 38 - Initial inclusion of QSS integration method. 64 Renamed classes to include 'G4' prefix, and 39 Renamed classes to include 'G4' prefix, and moved them from qss/ subdirectory. 65 Added Geant4 disclaimer / license to files. 40 Added Geant4 disclaimer / license to files. 66 Removed QSSmessenger from RunManager and G4P 41 Removed QSSmessenger from RunManager and G4PropagatorInField 67 - Temporarily made QSS the default method for 42 - Temporarily made QSS the default method for full testing. 68 43 69 ## 2023-01-30 Rodrigo Castro, Lucio Santi & Le 44 ## 2023-01-30 Rodrigo Castro, Lucio Santi & Leandro Gomez Vidal 70 - Included Quantum State Simulation (QSS) inte 45 - Included Quantum State Simulation (QSS) integration method 71 Alternative method of integration which crea 46 Alternative method of integration which creates approximation 72 functions for each coordinate (x,p) - changi 47 functions for each coordinate (x,p) - changing the interpolation 73 polynomials when the deviation from exact so 48 polynomials when the deviation from exact solution is larger than 74 a threshold value. 49 a threshold value. 75 Offers built-in interpolation capability - e 50 Offers built-in interpolation capability - enabling faster finding 76 of the intersection of the trajectory with s 51 of the intersection of the trajectory with surfaces. 77 Currently restricted to using only with a pu 52 Currently restricted to using only with a pure magnetic field. 78 Created by Rodrigo Castro and Lucio Santi, w 53 Created by Rodrigo Castro and Lucio Santi, with contributions 79 by Leandro A. Gómez Vidal (and others?) 54 by Leandro A. Gómez Vidal (and others?) 80 55 81 ## 2023-03-16 Ben Morgan (field-V11-01-02) 56 ## 2023-03-16 Ben Morgan (field-V11-01-02) 82 - Fixed compilation warnings on clang-15 for m 57 - Fixed compilation warnings on clang-15 for mismatched bounds declarations 83 in input parameters for steppers. 58 in input parameters for steppers. 84 59 85 ## 2023-01-09 Ben Morgan (field-V11-01-01) 60 ## 2023-01-09 Ben Morgan (field-V11-01-01) 86 - Use PROJECT_ scoped _SOURCE/BINARY_DIR varia 61 - Use PROJECT_ scoped _SOURCE/BINARY_DIR variables in place of CMAKE_ 87 scope version to ease use of Geant4 as a CMa 62 scope version to ease use of Geant4 as a CMake subproject. 88 - Fixes [GitHub PR #52](https://github.com/G 63 - Fixes [GitHub PR #52](https://github.com/Geant4/geant4/pull/52) 89 64 90 ## 2022-12-09 Laurie Nevay (field- 65 ## 2022-12-09 Laurie Nevay (field-V11-01-00) 91 - Reduced printout for setting any valid value 66 - Reduced printout for setting any valid value for epsilon_min / _max in 92 G4FieldManager. 67 G4FieldManager. 93 68 94 ## 2022-11-28 Gabriele Cosmo (field- 69 ## 2022-11-28 Gabriele Cosmo (field-V11-00-05) 95 - Fixed restore of stream precision in G4Field 70 - Fixed restore of stream precision in G4FieldManager::ReportBadEpsilonValue(). 96 71 97 ## 2022-11-14 John Apostolakis (field- 72 ## 2022-11-14 John Apostolakis (field-V11-00-04) 98 - Revised G4FieldManager to ensure that epsilo 73 - Revised G4FieldManager to ensure that epsilon_min / _max parameters 99 are less than a 'maximum accepted' accuracy 74 are less than a 'maximum accepted' accuracy (now=0.02) to ensure robust 100 behaviour of the integration. Improved their 75 behaviour of the integration. Improved their Set methods, adding 101 - warnings if min > max, with corrective be 76 - warnings if min > max, with corrective behaviour, and 102 - a fatal exception in case of values outsi 77 - a fatal exception in case of values outside the accepted range. 103 78 104 To cope with needs of legacy applications or 79 To cope with needs of legacy applications or existing needs for performance, 105 the value of the 'ceiling' maximum accepted 80 the value of the 'ceiling' maximum accepted accuracy can be modified using 106 the new static method 81 the new static method 107 G4FieldManager::SetMaxAcceptedEpsilon( 82 G4FieldManager::SetMaxAcceptedEpsilon( maxAccept, softFail); 108 but must remain under or equal to a final ce 83 but must remain under or equal to a final ceiling currently of 109 fMaxFinalEpsilon=0.03 84 fMaxFinalEpsilon=0.03 110 85 111 ## 2022-11-10 Gabriele Cosmo (field-V11-00-03) 86 ## 2022-11-10 Gabriele Cosmo (field-V11-00-03) 112 - Fixed compilation warnings for implicit type 87 - Fixed compilation warnings for implicit type conversions on macOS/XCode 14.1. 113 88 114 ## 2022-11-05 Divyansh Tiwari, John Apostolaki 89 ## 2022-11-05 Divyansh Tiwari, John Apostolakis (field-V11-00-02) 115 90 116 - Introduced G4BorisScheme and G4BorisDriver, 91 - Introduced G4BorisScheme and G4BorisDriver, a 2nd order symplectic 117 integration method, created as part of GSoC 92 integration method, created as part of GSoC 2022. 118 93 119 ## 2022-10-05 Gabriele Cosmo (field-V11-00-01) 94 ## 2022-10-05 Gabriele Cosmo (field-V11-00-01) 120 - Fixed compilation warnings on Intel/icx comp 95 - Fixed compilation warnings on Intel/icx compiler for variables set 121 but not used. 96 but not used. 122 97 123 ## 2021-12-10 Ben Morgan (field-V11-00-00) 98 ## 2021-12-10 Ben Morgan (field-V11-00-00) 124 - Change to new Markdown History format 99 - Change to new Markdown History format 125 100 126 --- 101 --- 127 102 128 # History entries prior to 11.0 103 # History entries prior to 11.0 129 104 130 March 30, 2021 B.Morgan 105 March 30, 2021 B.Morgan - field-V10-07-00 131 ----------------------- 106 ----------------------- 132 - Migrate sources.cmake to modular build API 107 - Migrate sources.cmake to modular build API 133 108 134 November 26, 2020 J.Apostolakis 109 November 26, 2020 J.Apostolakis - field-V10-06-09 135 ------------------------------- 110 ------------------------------- 136 - Fix to enable G4TDormandPrince45 to be used 111 - Fix to enable G4TDormandPrince45 to be used with G4InterpolationDriver. 137 112 138 This fix was needed because G4Interpolation 113 This fix was needed because G4Interpolation driver creates additional 139 copies of the stepper class. Due to this it 114 copies of the stepper class. Due to this it must obtain the equation 140 with the type of the templated stepper. 115 with the type of the templated stepper. 141 116 142 For a stepper to be used with 'G4Interpolati 117 For a stepper to be used with 'G4InterpolationDriver', it must 143 implement the method 118 implement the method 144 Equation_type GetSpecificEquation() 119 Equation_type GetSpecificEquation() 145 Templated steppers must ensure that the retu 120 Templated steppers must ensure that the return type 'Equation_type' 146 is the specific equation type of the templat 121 is the specific equation type of the template. 147 122 148 This method was added to G4DormandPrince745 123 This method was added to G4DormandPrince745 and G4TDormandPrince745. 149 124 150 October 12, 2020 J.Apostolakis 125 October 12, 2020 J.Apostolakis - field-V10-06-08 151 ------------------------------ 126 ------------------------------ 152 - Fixes & refinements - mostly in templated cl 127 - Fixes & refinements - mostly in templated classes, tests. 153 Compilation fixes, e.g. missing include <cas 128 Compilation fixes, e.g. missing include <cassert>. 154 Refinements, e.g. int -> unsigned int in tem 129 Refinements, e.g. int -> unsigned int in templates 155 130 156 October 9, 2020 J.Apostolakis 131 October 9, 2020 J.Apostolakis - field-V10-06-07 157 ----------------------------- 132 ----------------------------- 158 - Configure G4ChordFinder to use templated G4T 133 - Configure G4ChordFinder to use templated G4TDormandPrince45 as the 159 default stepper for magnetic fields (when on 134 default stepper for magnetic fields (when one is not chosen 160 explicitly by the application.) 135 explicitly by the application.) 161 136 162 October 9, 2020 J.Apostolakis & J. Xie 137 October 9, 2020 J.Apostolakis & J. Xie - field-V10-06-06 163 -------------------------------------- 138 -------------------------------------- 164 - Adapted classes that avoid virtual calls for 139 - Adapted classes that avoid virtual calls for field, equation, stepper 165 created by Josh Xie (Google Summer of Code 2 140 created by Josh Xie (Google Summer of Code 2014), supervised by 166 S. Wenzel & J.A. 141 S. Wenzel & J.A. 167 142 168 The revised design and implementations inclu 143 The revised design and implementations include: 169 * equation of motion templated on the field 144 * equation of motion templated on the field type; 170 * steppers templated on the type of equatio 145 * steppers templated on the type of equation and the number of integration 171 variables. 146 variables. 172 In addition the key methods are marked as 'i 147 In addition the key methods are marked as 'inline' to enable compilers, where 173 they judge possible, to embed them and avoid 148 they judge possible, to embed them and avoid any function calls. 174 149 175 These classes can be combined also with the 150 These classes can be combined also with the templated drivers 176 (G4IntegrationStepper, G4FSALIntegrationStep 151 (G4IntegrationStepper, G4FSALIntegrationStepper and/or G4InterpolationDriver 177 to avoid virtual calls in all the levels up 152 to avoid virtual calls in all the levels up to the chord finder's call to 178 the integration driver. ] 153 the integration driver. ] 179 154 180 The types of stepper currently available are 155 The types of stepper currently available are 181 i) the originally developed intermediate ord 156 i) the originally developed intermediate order stepper: 182 157 183 - Name (templated) - original -- Order/ 158 - Name (templated) - original -- Order/ - Comments 184 / E 159 / Embdedded 185 =========================================== 160 ============================================================================== 186 G4TClassicalRK4: G4ClassicalRK4 4th / 161 G4TClassicalRK4: G4ClassicalRK4 4th / no robust, old default 187 G4TCashKarpRKF45: G4CashKarpRKF45 5th / 162 G4TCashKarpRKF45: G4CashKarpRKF45 5th / yes first embedded RK in G4 188 163 189 ii) the original low order steppers (for spe 164 ii) the original low order steppers (for specialised uses) 190 G4TSimpleHeum: G4SimpleHeum 3rd / 165 G4TSimpleHeum: G4SimpleHeum 3rd / no lower order alternative 191 G4TSimpleRunge: G4SimpleRunge 2nd / 166 G4TSimpleRunge: G4SimpleRunge 2nd / no very low order 192 G4TExplicitEuler: G4ExplicitEuler 1st / 167 G4TExplicitEuler: G4ExplicitEuler 1st / no lowest order - for checks only 193 168 194 and 169 and 195 iii) some newly adapted stepper(s) / ( J.A. 170 iii) some newly adapted stepper(s) / ( J.A. Oct 2020 ) 196 G4TDormandPrince45 G4DormandPrince745 5th/ 171 G4TDormandPrince45 G4DormandPrince745 5th/ yes default / preferred 197 =========================================== 172 ============================================================================== 198 173 199 Note: Additional lower-order steppers are no 174 Note: Additional lower-order steppers are not yet available. 200 'Vector' steppers (using blaze) are no 175 'Vector' steppers (using blaze) are not supported. 201 176 202 Experimental versions of fields with inline 177 Experimental versions of fields with inline methods: 203 G4TUniformMagField, G4TQuadrupoleMagFiel 178 G4TUniformMagField, G4TQuadrupoleMagField 204 are included to show how the field evaluatio 179 are included to show how the field evaluation GetFieldValue can also be inlined. 205 180 206 Note 2: 181 Note 2: 207 Steppers which are not embedded obtain their 182 Steppers which are not embedded obtain their error estimates by 208 breaking the step into two halves, then comp 183 breaking the step into two halves, then comparing with the whole step. 209 As a result many more field / derivative eva 184 As a result many more field / derivative evaluations are needed than 210 embedded steppers of the same order, but the 185 embedded steppers of the same order, but the reliability of their error 211 estimation has different properties; so it m 186 estimation has different properties; so it may be more robust in some cases. ) 212 187 213 June 15, 2020 G.Cosmo 188 June 15, 2020 G.Cosmo - field-V10-06-05 214 --------------------- 189 --------------------- 215 - Implemented move constructor and operator fo 190 - Implemented move constructor and operator for G4FieldTrack. 216 191 217 March 24, 2020 J.Apostolakis 192 March 24, 2020 J.Apostolakis - field-V10-06-04 218 ---------------------------- 193 ---------------------------- 219 - New class G4DriverReporter to print progress 194 - New class G4DriverReporter to print progress of drivers. 220 Used for debugging differences between Old 195 Used for debugging differences between Old & fixed MagIntDriver 221 - Revisions in testing CMake config file and s 196 - Revisions in testing CMake config file and stepper/driver test 222 for magnetic field. 197 for magnetic field. 223 198 224 March 13, 2020 J.Apostolakis 199 March 13, 2020 J.Apostolakis - field-V10-06-03 225 ---------------------------- 200 ---------------------------- 226 - G4VIntegrationDriver & dependent driver clas 201 - G4VIntegrationDriver & dependent driver classes: 227 Added new virtual StreamInfo() method, 202 Added new virtual StreamInfo() method, 228 & used it to implement operator << for 203 & used it to implement operator << for G4VIntegrationDriver 229 Made (virtual) DoesReIntegrate() const. 204 Made (virtual) DoesReIntegrate() const. 230 - G4MagInt_Driver: Fixed max iterations & clar 205 - G4MagInt_Driver: Fixed max iterations & clarified that its 231 ComputeNewStepSize does NOT (yet) respect 206 ComputeNewStepSize does NOT (yet) respect maximum reduction factor (0.1). 232 ( Done to enable comparisons with new G4Inte 207 ( Done to enable comparisons with new G4IntegrationDriver<> implementation.) 233 - G4OldMagIntDriver maintains all old behaviou 208 - G4OldMagIntDriver maintains all old behaviour of G4MagInt_Driver. 234 209 235 210 236 January 22, 2020 G.Cosmo 211 January 22, 2020 G.Cosmo - field-V10-06-02 237 ------------------------ 212 ------------------------ 238 - Fixed compilation errors and configuration f 213 - Fixed compilation errors and configuration for field07 unit test. 239 214 240 January 13, 2020 G.Cosmo 215 January 13, 2020 G.Cosmo - field-V10-06-01 241 ------------------------ 216 ------------------------ 242 - Turn off verbosity flags by default in G4Int 217 - Turn off verbosity flags by default in G4IntegratorDriver, 243 G4InterpolationDriver and G4MagIntegratorDri 218 G4InterpolationDriver and G4MagIntegratorDriver. 244 219 245 December 10, 2019 B.Morgan 220 December 10, 2019 B.Morgan - field-V10-06-00 246 -------------------------- 221 -------------------------- 247 - Cleanup CMake build, removing obsolete granu 222 - Cleanup CMake build, removing obsolete granular library options and 248 explicit include_directories. 223 explicit include_directories. 249 224 250 November 14, 2019 J.Apostolakis 225 November 14, 2019 J.Apostolakis - field-V10-05-17 251 ------------------------------- 226 ------------------------------- 252 - Added method / attribute to G4VIntegrationDr 227 - Added method / attribute to G4VIntegrationDriver DoesReIntegrate() 253 to inform whether the driver recomputes seg 228 to inform whether the driver recomputes segment when 254 AccurateAdvance is called. 229 AccurateAdvance is called. 255 230 256 October 27, 2019 D.Sorokin 231 October 27, 2019 D.Sorokin - field-V10-05-16 257 ---------------------------- 232 ---------------------------- 258 - Remove statistics printouts from destructor 233 - Remove statistics printouts from destructor of G4BFieldIntegrationDriver 259 234 260 October 24, 2019 H.Burkhardt 235 October 24, 2019 H.Burkhardt - field-V10-05-15 261 ---------------------------- 236 ---------------------------- 262 - Standard sextupole magnet first implementati 237 - Standard sextupole magnet first implementation G4SextupoleMagField.cc,.hh 263 238 264 October 18, 2019 D. Sorokin 239 October 18, 2019 D. Sorokin - field-V10-05-14 265 ----------------------------------------- 240 ----------------------------------------- 266 - Fix floating point exception in G4BFieldInte 241 - Fix floating point exception in G4BFieldIntegrationDriver. 267 242 268 October 1, 2019 G. Cosmo 243 October 1, 2019 G. Cosmo - field-V10-05-13 269 ----------------------------------------- 244 ----------------------------------------- 270 - Fixed unitialised data in G4EqMagElectricFie 245 - Fixed unitialised data in G4EqMagElectricField and G4EqGravityField, 271 reported by Coverity. 246 reported by Coverity. 272 247 273 September 12, 2019 G. Cosmo 248 September 12, 2019 G. Cosmo - field-V10-05-12 274 ----------------------------------------- 249 ----------------------------------------- 275 - Minor C++11 revision. Code formatting and cl 250 - Minor C++11 revision. Code formatting and cleanup. 276 251 277 July 8, 2019 D. Sorokin 252 July 8, 2019 D. Sorokin - field-V10-05-11 278 ----------------------------------------- 253 ----------------------------------------- 279 - G4BFieldIntegrationDriver: an attempt to sol 254 - G4BFieldIntegrationDriver: an attempt to solve looping particle issue. 280 255 281 July 3, 2019 D. Sorokin 256 July 3, 2019 D. Sorokin - field-V10-05-10 282 ----------------------------------------- 257 ----------------------------------------- 283 - Make G4InterpolationDriver default for perfo 258 - Make G4InterpolationDriver default for performance assessments. 284 259 285 June 25, 2019 D. Sorokin 260 June 25, 2019 D. Sorokin - field-V10-05-09 286 ----------------------------------------- 261 ----------------------------------------- 287 - Fix Dormand-Prince 5th order interpolation m 262 - Fix Dormand-Prince 5th order interpolation method 288 263 289 June 20, 2019 D. Sorokin 264 June 20, 2019 D. Sorokin - field-V10-05-08 290 ----------------------------------------- 265 ----------------------------------------- 291 - New version of G4InterpolationDriver with mu 266 - New version of G4InterpolationDriver with multiple steppers for each substep. 292 267 293 June 12, 2019 D. Sorokin & J. Apostolakis 268 June 12, 2019 D. Sorokin & J. Apostolakis - field-V10-05-07 294 ----------------------------------------- 269 ----------------------------------------- 295 - Revert to use G4IntegrationDriver as default 270 - Revert to use G4IntegrationDriver as default in G4ChordFinder 296 ( c-tor for magnetic field. ). 271 ( c-tor for magnetic field. ). 297 Change to use concrete type of Stepper as te 272 Change to use concrete type of Stepper as template parameter 298 273 299 June 10, 2019 Dmitry Sorokin 274 June 10, 2019 Dmitry Sorokin - field-V10-05-06 300 ------------------------- 275 ------------------------- 301 - Remove division in G4DormandPrince745::Inter 276 - Remove division in G4DormandPrince745::Interpolate4thOrder. 302 277 303 June 7, 2019 Dmitry Sorokin 278 June 7, 2019 Dmitry Sorokin - field-V10-05-05 304 ------------------------- 279 ------------------------- 305 - Switch to original chord finding algorithm i 280 - Switch to original chord finding algorithm in G4InterpolationDriver 306 - Reset step estimate in G4MagInt_Driver only 281 - Reset step estimate in G4MagInt_Driver only at the beginning of a track 307 - Change G4VERBOSE to G4FIELD_DEBUG in G4Inter 282 - Change G4VERBOSE to G4FIELD_DEBUG in G4InterpolationDriver to speed-up 308 283 309 June 4, 2019 Dmitry Sorokin 284 June 4, 2019 Dmitry Sorokin - field-V10-05-04 310 ------------------------- 285 ------------------------- 311 - Use FSAL property of G4DormandPrince745 in G 286 - Use FSAL property of G4DormandPrince745 in G4InterpolationDriver. 312 287 313 June 3, 2019 Dmitry Sorokin 288 June 3, 2019 Dmitry Sorokin - field-V10-05-03 314 ------------------------- 289 ------------------------- 315 - Fix memory churn in G4InterpolationDriver. 290 - Fix memory churn in G4InterpolationDriver. 316 291 317 May 20, 2019 Dmitry Sorokin 292 May 20, 2019 Dmitry Sorokin - field-V10-05-02 318 ------------------------- 293 ------------------------- 319 - Make interpolation driver default for immedi 294 - Make interpolation driver default for immediate testing. 320 295 321 April 8, 2019 H.Burkhardt 296 April 8, 2019 H.Burkhardt - field-V10-05-01 322 ------------------------- 297 ------------------------- 323 - Correcting transformation to local system in 298 - Correcting transformation to local system in G4QuadrupoleMagField.cc 324 299 325 March 20, 2019 G.Cosmo 300 March 20, 2019 G.Cosmo - field-V10-05-00 326 ---------------------- 301 ---------------------- 327 - Corrected 'RegularStepperName' in G4ChordFin 302 - Corrected 'RegularStepperName' in G4ChordFinder to refer to the actual 328 default stepper G4DormandPrince745 rather th 303 default stepper G4DormandPrince745 rather than G4NystromRK4... 329 304 330 November 9, 2018 J.Apostolakis 305 November 9, 2018 J.Apostolakis - field-V10-04-17 331 ------------------------------ 306 ------------------------------ 332 - Small fixes for warnings in compilation. 307 - Small fixes for warnings in compilation. 333 - Revisions of descriptions of recent tags (fo 308 - Revisions of descriptions of recent tags (for clarification.) 334 309 335 September 26, 2018 D.Sorokin 310 September 26, 2018 D.Sorokin - field-V10-04-15, -16 336 ---------------------------- 311 ---------------------------- 337 - Implemented G4InterpolationDriver. This driv 312 - Implemented G4InterpolationDriver. This driver uses a Runge-Kutta 338 stepper with interpolation property to integ 313 stepper with interpolation property to integrate EoM with error control. 339 The field evaluations used to calculate the 314 The field evaluations used to calculate the enpoint of an 'advance' can 340 be reused to obtain one or multiple internal 315 be reused to obtain one or multiple internal points on the curve (x,p). 341 So in steps in which an intersection is foun 316 So in steps in which an intersection is found, the number of field 342 evaluations are expected to be reduced subst 317 evaluations are expected to be reduced substantially. 343 318 344 September 13, 2018 D.Sorokin 319 September 13, 2018 D.Sorokin - field-V10-04-13, -14 345 ---------------------------- 320 ---------------------------- 346 - G4NystromRK4 creates G4CachedMagneticField i 321 - G4NystromRK4 creates G4CachedMagneticField if it was not provided. 347 - Removed G4MagIntegratorStepper::ComputeRight 322 - Removed G4MagIntegratorStepper::ComputeRightHandSide() method 348 (all calls now use non-virtual RightHandSide 323 (all calls now use non-virtual RightHandSide() method instead). 349 - Reversed declaration of final for the class 324 - Reversed declaration of final for the class G4UniformMagField. 350 Returned to previous status: only GetFieldVa 325 Returned to previous status: only GetFieldValue method is final. 351 ( This avoid need to change examples/tests a 326 ( This avoid need to change examples/tests and potentially migrate 352 users' code. ) 327 users' code. ) 353 328 354 September 12, 2018 D.Sorokin 329 September 12, 2018 D.Sorokin - field-V10-04-11, -12 355 ---------------------------- 330 ---------------------------- 356 - Created new experimental driver G4BFieldInte 331 - Created new experimental driver G4BFieldIntegrationDriver for pure 357 magnetic fields. In QuickAdvance it uses he 332 magnetic fields. In QuickAdvance it uses helix stepper when the 358 estimated 'helix' rotation angle is larger t 333 estimated 'helix' rotation angle is larger than pi/3. 359 - G4NystromRK4 uses G4CachedMagneticField for 334 - G4NystromRK4 uses G4CachedMagneticField for caching values. 360 NOTE: It now the user's responsibility to cr 335 NOTE: It now the user's responsibility to create G4CachedMagneticField. 361 ( The alternative is to create G4CachedMagne 336 ( The alternative is to create G4CachedMagneticField inside G4NystromRK4. 362 But this would have several disadvantages: 337 But this would have several disadvantages: 363 * It would change the field in the user's 338 * It would change the field in the user's equation of motion; 364 * G4NystromRK4 is not able to check whethe 339 * G4NystromRK4 is not able to check whether the user calls the method 365 that changes the equation using SetEquat 340 that changes the equation using SetEquationOfMotion method. ) 366 341 367 July 10, 2018 D. Sorokin - field- 342 July 10, 2018 D. Sorokin - field-V10-04-08, -09, -10 368 ------------------------ Tags by J. Apostolaki 343 ------------------------ Tags by J. Apostolakis 369 - Corrections in calculation of chord distance 344 - Corrections in calculation of chord distance in G4DormandPrince745 370 ( use 4th order interpolation from Shampine 345 ( use 4th order interpolation from Shampine 1986 for mid-point. ) 371 - Revised G4FieldUtils: moved copy() method fr 346 - Revised G4FieldUtils: moved copy() method from steppers, 372 added 2 new setValue: simple & variadic meth 347 added 2 new setValue: simple & variadic methods. 373 - Fixes to copy input time in ModifiedMidpoint 348 - Fixes to copy input time in ModifiedMidpoint, CashKarp, G4RK547FEq1/2/3 374 Bogacki-Shampine 4/5 and 2/3 (note: B-S 2/3 349 Bogacki-Shampine 4/5 and 2/3 (note: B-S 2/3 largely rewritten ) 375 Dormand Prince 4/5, 5/6 and 7/8, and Tsitou 350 Dormand Prince 4/5, 5/6 and 7/8, and Tsitouras steppers. 376 - Trial revision in G4BulirschStoer to reduce 351 - Trial revision in G4BulirschStoer to reduce number of division 377 operations (J.A.) 352 operations (J.A.) 378 - Fix for unitialised pIntStepper pointer in G 353 - Fix for unitialised pIntStepper pointer in G4FSALIntegrationDriver 379 constructor. Revision of data member variab 354 constructor. Revision of data member variable names. ( J.A. ) 380 355 381 June 15, 2018 G.Cosmo - fiel 356 June 15, 2018 G.Cosmo - field-V10-04-07 382 --------------------- 357 --------------------- 383 - Fixed minor Coverity defects in G4BurlischSt 358 - Fixed minor Coverity defects in G4BurlischStoer and G4ModifiedMidPoint. 384 Code cleanup. 359 Code cleanup. 385 360 386 June 13, 2018 G.Cosmo - fiel 361 June 13, 2018 G.Cosmo - field-V10-04-06 387 --------------------- 362 --------------------- 388 - Leave override final only for clone() method 363 - Leave override final only for clone() method in G4UniformMagField, 389 not in destructor... 364 not in destructor... 390 365 391 June 12, 2018 G.Cosmo - fiel 366 June 12, 2018 G.Cosmo - field-V10-04-05 392 --------------------- 367 --------------------- 393 - Use G4Exception warnings instead of streamin 368 - Use G4Exception warnings instead of streaming to cerr. 394 - Added override final for virtual methods in 369 - Added override final for virtual methods in G4UniformMagField (J.Apostolakis). 395 - Some code cleanup. 370 - Some code cleanup. 396 371 397 Apr 30, 2018 J. Apostolakis - fiel 372 Apr 30, 2018 J. Apostolakis - field-V10-04-04 398 --------------------------- 373 --------------------------- 399 - G4VIntegrationDriver and derived classes 374 - G4VIntegrationDriver and derived classes 400 375 401 Added new virtual method in G4VIntegrationDr 376 Added new virtual method in G4VIntegrationDriver : 402 void RenewStepperAndAdjust(G4MagIntegrat 377 void RenewStepperAndAdjust(G4MagIntegratorStepper *pItsStepper) 403 which used to exist in G4MagInt_Driver. 378 which used to exist in G4MagInt_Driver. 404 ( Its absence caused a problem in some exist 379 ( Its absence caused a problem in some existing user code since 10.4. ) 405 380 406 This method must be defined in those derived 381 This method must be defined in those derived driver classes which accept 407 a Runge Kutta stepper ( i.e. some or any typ 382 a Runge Kutta stepper ( i.e. some or any type of G4MagIntegratorStepper ) 408 383 409 - G4IntegrationDriver, G4FSALIntegrationDriver 384 - G4IntegrationDriver, G4FSALIntegrationDriver 410 Defined default implementation (which throws 385 Defined default implementation (which throws a Fatal G4Exception), and 411 implementations in the templated classes G4I 386 implementations in the templated classes G4IntegrationDriver and 412 G4FSALIntegrationDriver which check the type 387 G4FSALIntegrationDriver which check the type (via dynamic cast) and 413 change the stepper if it is appropriate. 388 change the stepper if it is appropriate. 414 389 415 Feb 13, 2018 J. Apostolakis - fiel 390 Feb 13, 2018 J. Apostolakis - field-V10-04-03 416 --------------------------- 391 --------------------------- 417 - Change in G4FieldManager::CreateChordFinder 392 - Change in G4FieldManager::CreateChordFinder to cope 418 better with case that field argument is null 393 better with case that field argument is null. 419 394 420 Feb 13, 2018 D. Sorokin - fiel 395 Feb 13, 2018 D. Sorokin - field-V10-04-01 421 ----------------------- - fiel 396 ----------------------- - field-V10-04-02 (comp. fix) 422 - Introduced Bulirsch-Stoer method of integrat 397 - Introduced Bulirsch-Stoer method of integration, an alternative 423 to Runge-Kutta based on the mid-point method 398 to Runge-Kutta based on the mid-point method. 424 Separate driver derived G4VIntegrationDriver 399 Separate driver derived G4VIntegrationDriver and implemented 425 using specialisation of G4IntegrationDriver 400 using specialisation of G4IntegrationDriver template class. 426 Note: this method does not have a RK 'Steppe 401 Note: this method does not have a RK 'Stepper' ! 427 402 428 Jan 31, 2018 J. Apostolakis 403 Jan 31, 2018 J. Apostolakis 429 --------------------------- 404 --------------------------- 430 - G4MagneticField no longer inherits from G4El 405 - G4MagneticField no longer inherits from G4ElectroMagneticField 431 This was incorrect, and allowed a user to pr 406 This was incorrect, and allowed a user to provide a full EM 432 field, but obtain the force only from the B- 407 field, but obtain the force only from the B-field when using 433 the equation created in the G4ChordFinder co 408 the equation created in the G4ChordFinder constructor. 434 => potential interface change. 409 => potential interface change. 435 410 436 Result: It is no longer possible to use the 411 Result: It is no longer possible to use the equation of motion for a 437 pure magnetic field for the case of a mix 412 pure magnetic field for the case of a mixed electromagnetic field. 438 This change is desired, and is a *protect 413 This change is desired, and is a *protection* as that inadvertent 439 use led to incorrect results. 414 use led to incorrect results. 440 Instead the full chain of classes for equati 415 Instead the full chain of classes for equation of full EM field, 441 steppers and driver must be used for the 416 steppers and driver must be used for the case of the 'full' EM field. 442 417 443 Feb 9, 2017 G.Cosmo - fiel 418 Feb 9, 2017 G.Cosmo - field-V10-04-00 444 ------------------- 419 ------------------- 445 - Removed static data from G4FSALIntegrationDr 420 - Removed static data from G4FSALIntegrationDriver, G4IntegrationDriver and 446 G4MagIntegratorDriver and moved to base clas 421 G4MagIntegratorDriver and moved to base class as normal data members. 447 Fix required for allowing proper symbol expo 422 Fix required for allowing proper symbol exporting on Windows DLLs. 448 423 449 Nov 17, 2017 J. Apostolakis - fiel 424 Nov 17, 2017 J. Apostolakis - field-V10-03-30 450 --------------------------- 425 --------------------------- 451 - G4ChordFinder: Reinstated old driver G4MagIn 426 - G4ChordFinder: Reinstated old driver G4MagInt_Drv, for use 452 with G4DormandPrince745 (5th order) in G4C 427 with G4DormandPrince745 (5th order) in G4ChordFinder's 453 2nd constructor (with magnetic field.) 428 2nd constructor (with magnetic field.) 454 ( Reverses change made in field-V10-03-27 ) 429 ( Reverses change made in field-V10-03-27 ) 455 430 456 Nov 16, 2017 J. Apostolakis - fiel 431 Nov 16, 2017 J. Apostolakis - field-V10-03-29 457 --------------------------- 432 --------------------------- 458 - Suppressed statistics printing in G4ChordFin 433 - Suppressed statistics printing in G4ChordFinder and new drivers 459 ( G4IntegrationDriver and G4FSALIntegration 434 ( G4IntegrationDriver and G4FSALIntegrationDriver ) 460 protecting them by verbosity flags. 435 protecting them by verbosity flags. 461 436 462 - Minor fix to initialise scalar data member i 437 - Minor fix to initialise scalar data member in new steppers 463 G4RK547FEq1, G4RK547FEq2 and G4RK547FEq3. 438 G4RK547FEq1, G4RK547FEq2 and G4RK547FEq3. 464 Fixes coverity issues 97886, 97888 and 97889 439 Fixes coverity issues 97886, 97888 and 97889. 465 440 466 441 467 Nov 14, 2017 J. Apostolakis - fiel 442 Nov 14, 2017 J. Apostolakis - field-V10-03-28 468 --------------------------- 443 --------------------------- 469 - Suppressed extra verbosity in G4ChordFinder. 444 - Suppressed extra verbosity in G4ChordFinder. 470 - Fix in G4FSALDormandPrince745 for unitialise 445 - Fix in G4FSALDormandPrince745 for unitialised variables. 471 Initialise ak8[], ak9[] in constructor. This 446 Initialise ak8[], ak9[] in constructor. This avoids repeated 472 memory allocation, without deletion - i.e. a 447 memory allocation, without deletion - i.e. a memory leak. 473 - Initialise fLastStepLength and/or fAuxSteppe 448 - Initialise fLastStepLength and/or fAuxStepper data members in 474 in constructors of G4DormandPrince745 and G4 449 in constructors of G4DormandPrince745 and G4FSALDormandPrince745. 475 Coverity issues: 67394 (G4FSALDormandPrince7 450 Coverity issues: 67394 (G4FSALDormandPrince745) 476 67391 (G4DormandPrince7 451 67391 (G4DormandPrince745) 477 452 478 Nov 14, 2017 J. Apostolakis - fiel 453 Nov 14, 2017 J. Apostolakis - field-V10-03-27 (fixed) 479 --------------------------- - fiel 454 --------------------------- - field-V10-03-26 480 - G4ChordFinder: changes in default stepper & 455 - G4ChordFinder: changes in default stepper & driver in 2nd constructor. 481 in which only a magnetic field is provided ( 456 in which only a magnetic field is provided (used widely) : 482 457 483 * Reinstated G4DormandPrince745 (5th order) 458 * Reinstated G4DormandPrince745 (5th order) as default in G4ChordFinder. 484 (corrected -23, which missed to initialise 459 (corrected -23, which missed to initialise driver.) 485 460 486 * New templated driver G4IntegrationDriver i 461 * New templated driver G4IntegrationDriver is chosen for the 487 the simple constuctors of G4ChordFinder an 462 the simple constuctors of G4ChordFinder and G4FieldManager 488 which only require a (pure) magnetic field 463 which only require a (pure) magnetic field. ( Details below.) 489 464 490 Additional information and details: 465 Additional information and details: 491 * New optional parameter to constructor of G 466 * New optional parameter to constructor of G4ChordFinder which 492 allow to create an FSAL stepper and corres 467 allow to create an FSAL stepper and corresponding driver instead. 493 This aims to reuse some derivatives, thus 468 This aims to reuse some derivatives, thus reducing computations 494 of derivatives and thus field evaluations. 469 of derivatives and thus field evaluations. ) 495 470 496 * The templated 'driver' classes, available 471 * The templated 'driver' classes, available and now chosen in 497 G4ChordFinder's 2nd constructor, are used 472 G4ChordFinder's 2nd constructor, are used per type of stepper 498 class: 473 class: 499 - G4IntegrationDriver for non-FSAL 474 - G4IntegrationDriver for non-FSAL steppers 500 - G4FSALIntegrationDriver for FSAL-capab 475 - G4FSALIntegrationDriver for FSAL-capable steppers 501 These make non-virtual calls to the steppe 476 These make non-virtual calls to the stepper, as they know its type. 502 477 503 - First fix in G4FSALDormandPrince745 for memo 478 - First fix in G4FSALDormandPrince745 for memory leak, missing 504 delete[] fInitialDyDx in destructor. Coverit 479 delete[] fInitialDyDx in destructor. Coverity issue: 96383. 505 480 506 ---------------------------------------------- 481 ---------------------------------------------------------------------- 507 Multiple tags (below) were to better test step 482 Multiple tags (below) were to better test stepper/driver combinations: 508 Date Tagger Tag name Stepper 483 Date Tagger Tag name Stepper Driver 509 ============================================== 484 ====================================================================== 510 Nov 3, D. Sorokin field-V10-03-25 G4FSALBo 485 Nov 3, D. Sorokin field-V10-03-25 G4FSALBogackiShampine45 FSAL 511 Nov 3, J. Apostolakis field-V10-03-24 G4FSALDo 486 Nov 3, J. Apostolakis field-V10-03-24 G4FSALDormandPrince745 FSAL ok 512 Nov 2, J. Apostolakis field-V10-03-23 G4Dorman 487 Nov 2, J. Apostolakis field-V10-03-23 G4DormandPrince745 new 513 Nov 2, J. Apostolakis field-V10-03-22 G4RK547F 488 Nov 2, J. Apostolakis field-V10-03-22 G4RK547FEq1 FSAL ok 514 ---------------------------------------------- 489 ---------------------------------------------------------------------- 515 Glossary of drivers: 490 Glossary of drivers: 516 the FSAL driver = using G4FSALIntegrationDr 491 the FSAL driver = using G4FSALIntegrationDriver (templated) 517 the new driver = using G4IntegrationDriver 492 the new driver = using G4IntegrationDriver (templated) 518 ============================================== 493 =================================================================== 519 494 520 Nov 2, 2017 D. Sorokin - fiel 495 Nov 2, 2017 D. Sorokin - field-V10-03-21 521 --------------------------------------- 496 --------------------------------------- 522 - Added new steppers G4RK547FEq{1,2,3} which i 497 - Added new steppers G4RK547FEq{1,2,3} which implement 7 stage embedded 523 Runge-Kutta 4,5 pairs with: 498 Runge-Kutta 4,5 pairs with: 524 - FSAL property (return derivative at end 499 - FSAL property (return derivative at endpoint for use in next step), 525 - stable equilibrium states ( improved ha 500 - stable equilibrium states ( improved handling of difficulties in 526 integration: better stability in choo 501 integration: better stability in choosing step size. ) 527 Each one can be used with all existing Runge 502 Each one can be used with all existing Runge-Kutta drivers: 528 - G4FSALIntegrationDriver, using its FSAL 503 - G4FSALIntegrationDriver, using its FSAL property; 529 - G4IntegrationDriver without its FSAL 504 - G4IntegrationDriver without its FSAL property. 530 - the original G4MagInt_Driver, also igno 505 - the original G4MagInt_Driver, also ignoring FSAL. 531 506 532 - Reinstated G4DormandPrince745 ( known widel 507 - Reinstated G4DormandPrince745 ( known widely as DOPRI5 ) as 533 the default RK method in G4ChordFinder for p 508 the default RK method in G4ChordFinder for pure magnetic fields. 534 ( Withdrew G4BogackiShampine45. ) J. Apos 509 ( Withdrew G4BogackiShampine45. ) J. Apostolakis 535 510 536 Nov 1, 2017 J. Apostolakis - fiel 511 Nov 1, 2017 J. Apostolakis - field-V10-03-20 537 --------------------------- 512 --------------------------- 538 - Made G4BogackiShampine45 the default RK meth 513 - Made G4BogackiShampine45 the default RK method in G4ChordFinder 539 for pure magnetic fields. 514 for pure magnetic fields. 540 515 541 Oct 30, 2017 D. Sorokin/J.Apostolakis - fiel 516 Oct 30, 2017 D. Sorokin/J.Apostolakis - field-V10-03-19 542 --------------------------------------- 517 --------------------------------------- 543 - add GetStepper method to G4VIntegrationDrive 518 - add GetStepper method to G4VIntegrationDriver for backward compatibility 544 519 545 Oct 20, 2017 D. Sorokin - fiel 520 Oct 20, 2017 D. Sorokin - field-V10-03-18 546 --------------------------------------- 521 --------------------------------------- 547 Introduced base class for any driver algorithm 522 Introduced base class for any driver algorithm (G4VIntegrationDriver) 548 New concrete classes added: 523 New concrete classes added: 549 - G4IntegrationDriver: implementation of templ 524 - G4IntegrationDriver: implementation of templated driver algorithm 550 for non-fsal explicit Runge-Kutta steppers 525 for non-fsal explicit Runge-Kutta steppers 551 - G4FSALIntegrationDriver: implementation of d 526 - G4FSALIntegrationDriver: implementation of driver algorithm for 552 FSAL explicit Runge-Kutta steppers. 527 FSAL explicit Runge-Kutta steppers. 553 Existing class G4MagInt_Drv remains, deriving 528 Existing class G4MagInt_Drv remains, deriving from base class. 554 529 555 - Expanded testing in testProElectroMagField ( 530 - Expanded testing in testProElectroMagField (higher precision, new driver) 556 ( J. Apostolakis) 531 ( J. Apostolakis) 557 532 558 Oct 13, 2017 D. Sorokin - fiel 533 Oct 13, 2017 D. Sorokin - field-V10-03-17 559 --------------------------------------- 534 --------------------------------------- 560 - add G4FieldUtils.hh, G4FieldUtils.icc, G4Fie 535 - add G4FieldUtils.hh, G4FieldUtils.icc, G4FieldUtils.cc: 561 utilities to extract data from arrays in con 536 utilities to extract data from arrays in conventions of the 562 magneticfield integration. 537 magneticfield integration. 563 538 564 Oct 13, 2017 G. Cosmo - fiel 539 Oct 13, 2017 G. Cosmo - field-V10-03-16 565 --------------------------------------- 540 --------------------------------------- 566 - G4NystromRK4: use consistenly G4 types for d 541 - G4NystromRK4: use consistenly G4 types for double and bool in G4NystromRK4. 567 542 568 Aug 31, 2017 J. Apostolakis - fiel 543 Aug 31, 2017 J. Apostolakis - field-V10-03-15 569 --------------------------------------- 544 --------------------------------------- 570 - Made G4DormandPrince457 the default Stepper 545 - Made G4DormandPrince457 the default Stepper for magnetic fields in 571 G4ChordFinder - when a driver/stepper is not 546 G4ChordFinder - when a driver/stepper is not specified. 572 547 573 Aug 31, 2017 J. Apostolakis - fiel 548 Aug 31, 2017 J. Apostolakis - field-V10-03-14 574 --------------------------------------- 549 --------------------------------------- 575 - G4NystromRK4: used caching of momentum magni 550 - G4NystromRK4: used caching of momentum magnitude ( & its inverse) 576 to reduce overhead of fix in field-V10-03-10 551 to reduce overhead of fix in field-V10-03-10. 577 552 578 Aug 25, 2017 J. Apostolakis - fiel 553 Aug 25, 2017 J. Apostolakis - field-V10-03-12, 13 579 --------------------------------------- 554 --------------------------------------- 580 - G4MagInt_Driver: added GetEquationOfMotion m 555 - G4MagInt_Driver: added GetEquationOfMotion method for enabling common 581 code with future develoment. 556 code with future develoment. 582 557 583 Aug 24, 2017 D.Sorokin & J. Apostolakis - fiel 558 Aug 24, 2017 D.Sorokin & J. Apostolakis - field-V10-03-11 584 --------------------------------------- 559 --------------------------------------- 585 - G4NystromRK4: correction in call to getField 560 - G4NystromRK4: correction in call to getField: needs p[4], not p[3] 586 ( Spotted by D. Sorokin ) 561 ( Spotted by D. Sorokin ) 587 Also small cleanup of testing code into 2 sm 562 Also small cleanup of testing code into 2 small new methods. 588 ( J. Apostolakis ) 563 ( J. Apostolakis ) 589 564 590 Aug 23, 2017 J.Apostolakis - fiel 565 Aug 23, 2017 J.Apostolakis - field-V10-03-10 591 -------------------------- 566 -------------------------- 592 - G4NystromRK4 - Fix the caching of momentum, 567 - G4NystromRK4 - Fix the caching of momentum, field location & value. 593 Fixes issue reported by ALICE ( problem repo 568 Fixes issue reported by ALICE ( problem report #1996 ). 594 Thanks to Ruben Shahoyan for identifying and 569 Thanks to Ruben Shahoyan for identifying and reporting the issue! 595 - Temporarly made G4NystromRK4 the default Ste 570 - Temporarly made G4NystromRK4 the default Stepper in G4ChordFinder's 2nd 596 constructor (to ensure adequate testing). 571 constructor (to ensure adequate testing). 597 572 598 Jul 04, 2017 J.Apostolakis - field 573 Jul 04, 2017 J.Apostolakis - field-V10-03-09 599 -------------------------- 574 -------------------------- 600 - G4DormandPrinceRK78: initialise fLastStepLen 575 - G4DormandPrinceRK78: initialise fLastStepLength and/or fAuxStepper data 601 members in constructor. Coverity issue: 6739 576 members in constructor. Coverity issue: 67398, 602 Improved description and reference to origin 577 Improved description and reference to original 1981 DP paper. 603 - G4MagIntegratorDriver: initialised fNoCalls 578 - G4MagIntegratorDriver: initialised fNoCalls in c-tor. Coverity #15158. 604 579 605 Jul 03, 2017 J.Apostolakis - field 580 Jul 03, 2017 J.Apostolakis - field-V10-03-08 606 -------------------------- 581 -------------------------- 607 - G4FSALBogackiShampline45: initialise 'bi[][] 582 - G4FSALBogackiShampline45: initialise 'bi[][]' const coefficients only 1 time 608 in method PrepareConstants() called by const 583 in method PrepareConstants() called by constructor. 609 ( Similar to G4BogackiShampine => seek con 584 ( Similar to G4BogackiShampine => seek consolidation ) 610 Small fix: initialise fAuxStepper to nullptr 585 Small fix: initialise fAuxStepper to nullptr, if not primary. 611 ( Part of Coverity issue 67394 ) 586 ( Part of Coverity issue 67394 ) 612 - G4DormandPrinceRK56: fix for significant mem 587 - G4DormandPrinceRK56: fix for significant memory leak of ak10_low buffer 613 space in SetupInterpolate_low(), apparently 588 space in SetupInterpolate_low(), apparently not seen by Coverity 614 because it was initialised in each use, not 589 because it was initialised in each use, not in constructor! 615 Improved initialisation of ak10, 11, 12 (mov 590 Improved initialisation of ak10, 11, 12 (moved to constructor) 616 and fixed small memory leak (added deletion 591 and fixed small memory leak (added deletion in destructor). 617 - G4MagIntegratorStepper: initialise fNoRHSCal 592 - G4MagIntegratorStepper: initialise fNoRHSCalls & fIntegrationOrder in c-tor. 618 ( fIntegrationOrder is not yet used widely - 593 ( fIntegrationOrder is not yet used widely - future migration ) 619 Coverity issue 67392. 594 Coverity issue 67392. 620 - G4VFSALIntegrationStepper: initialise counte 595 - G4VFSALIntegrationStepper: initialise counter in c-tor. Coverity issue 67396. 621 - G4BogackiShampine23: initialised fIsFSAL, fI 596 - G4BogackiShampine23: initialised fIsFSAL, fIntegrationOrder in c-tor. 622 Suppressed obsolete virtual method isFSAL, 597 Suppressed obsolete virtual method isFSAL, 623 Deleted duplicate virtual method 'isFSAL()'. 598 Deleted duplicate virtual method 'isFSAL()'. Non-virtual method IsFSAL() 624 now exists in base class G4MagIntegratorStep 599 now exists in base class G4MagIntegratorStepper. 625 Made copy constructor and equal operator pri 600 Made copy constructor and equal operator private and not unimplemented. 626 Added explanatory comments in source file; c 601 Added explanatory comments in source file; can make this method FSAL easily 627 (it calculates derivative @ endpoint. ) 602 (it calculates derivative @ endpoint. ) 628 - Several steppers ( G4DoLoMcPriRK34, G4FSALBo 603 - Several steppers ( G4DoLoMcPriRK34, G4FSALBogackiShampine45, 629 G4DormandPrince745, G4BogackiShampine45 ): i 604 G4DormandPrince745, G4BogackiShampine45 ): initialise fLastStepLength and/or 630 fAuxStepper data members in constructor. 605 fAuxStepper data members in constructor. 631 Coverity issues: 67393, 67394, 67391, 67390, 606 Coverity issues: 67393, 67394, 67391, 67390, 67363 632 607 633 Jul 03, 2017 J.Apostolakis - field 608 Jul 03, 2017 J.Apostolakis - field-V10-03-05, -06, -07 634 -------------------------- 609 -------------------------- 635 - fix for memory leak in Stepper() in two step 610 - fix for memory leak in Stepper() in two steppers: 636 G4FSALBogackiShampline45 ( Coverity issue 611 G4FSALBogackiShampline45 ( Coverity issue 67389 ) 637 G4FSALDormandPrince745 ( Coverity issue 612 G4FSALDormandPrince745 ( Coverity issue 67397 ) 638 - G4BogackiShampline23: fix for memory leak in 613 - G4BogackiShampline23: fix for memory leak in destructor 639 ( Coverity issue 67355 ) 614 ( Coverity issue 67355 ) 640 615 641 May 17, 2017 J.Apostolakis - field 616 May 17, 2017 J.Apostolakis - field-V10-03-03, -04 (resubmit) 642 -------------------------- 617 -------------------------- 643 - G4FieldManager::SetDetectorField 618 - G4FieldManager::SetDetectorField 644 Fixed default of 'fail mode' parameter in 619 Fixed default of 'fail mode' parameter in 645 to 0 (silent) - not 1 which was used for 620 to 0 (silent) - not 1 which was used for debugging. 646 In case of existing G4ChordFinder, use 'max' 621 In case of existing G4ChordFinder, use 'max' (1, failMode) not min. 647 622 648 623 649 May 11, 2017 J.Apostolakis - field 624 May 11, 2017 J.Apostolakis - field-V10-03-02 650 -------------------------- 625 -------------------------- 651 - Reintroduced changes of field-V10-01-05, 06 626 - Reintroduced changes of field-V10-01-05, 06 and 07 to address 652 issue recalled by ATLAS. 627 issue recalled by ATLAS. 653 - New fixes/refinements (since field-V10-01-07 628 - New fixes/refinements (since field-V10-01-07) 654 o Extra check for missing equation. (Fix) 629 o Extra check for missing equation. (Fix) 655 o Renamed G4FieldManager::SetFieldChangesEne 630 o Renamed G4FieldManager::SetFieldChangesEnergy() method to 656 InitialiseFieldChangesEnergy() to clarify 631 InitialiseFieldChangesEnergy() to clarify its utility. 657 - Original functionality change (copied from f 632 - Original functionality change (copied from field-V10-01-05, & -07) : 658 o G4FieldManager.cc : Revised behaviour of S 633 o G4FieldManager.cc : Revised behaviour of SetDetector - it now 659 passes the Field to the Equation, as is th 634 passes the Field to the Equation, as is the natural user expectation 660 The previous behaviour is possible, using 635 The previous behaviour is possible, using extra argument 'failMode' flag. 661 Values: 0 = silent ; 636 Values: 0 = silent ; 662 1 (default) = warning; 637 1 (default) = warning; 663 2 or other = fatal except 638 2 or other = fatal exception. 664 639 665 This change is to ensure that user expecta 640 This change is to ensure that user expectation is met: 666 if the field is changed for an existing, w 641 if the field is changed for an existing, working stepper it must 667 be propagated to the equation of motion. 642 be propagated to the equation of motion. 668 Note: this causes potential conflict betwe 643 Note: this causes potential conflict between the type of the equation 669 and the field, which will need to be 644 and the field, which will need to be solved in the future. 670 Old behaviour (just set our own pointer) i 645 Old behaviour (just set our own pointer) is still available in new method: 671 ProposeDetectorField(G4Field *detectorFiel 646 ProposeDetectorField(G4Field *detectorField) 672 Note: Error reporting behaviour of SetDete 647 Note: Error reporting behaviour of SetDetector is 'soft'. It does not 673 complain by default if ChordFinder i 648 complain by default if ChordFinder is not (yet) set. 674 ( The default values of failMode = 0 649 ( The default values of failMode = 0 i.e. quiet. ) 675 If a chord-finder exists, it will still wa 650 If a chord-finder exists, it will still warn for other errors. 676 To obtain have noisy extra checks call Set 651 To obtain have noisy extra checks call SetDetectorField with failMode > 0 677 or by using the new method for an existing 652 or by using the new method for an existing field: 678 ChangeDetectorField(G4Field *detectorField 653 ChangeDetectorField(G4Field *detectorField) 679 OLD: Co-works and requires new tag in geomet 654 OLD: Co-works and requires new tag in geometry/navigation: geomnav-V10-01-24. 680 655 681 Mar 22, 2017 G.Cosmo - fiel 656 Mar 22, 2017 G.Cosmo - field-V10-03-01 682 --------------------- 657 --------------------- 683 - Revert change made in previous tag and add s 658 - Revert change made in previous tag and add simple accessor to return 684 singleton pointer. 659 singleton pointer. 685 660 686 Mar 17, 2017 G.Cosmo - fiel 661 Mar 17, 2017 G.Cosmo - field-V10-03-00 687 --------------------- 662 --------------------- 688 - Define G4FieldManagerStore as normal singlet 663 - Define G4FieldManagerStore as normal singleton and corrected destructor. 689 664 690 Oct 7, 2016 J.Apostolakis - fiel 665 Oct 7, 2016 J.Apostolakis - field-V10-02-24, 25 691 --------------------------- 666 --------------------------- 692 - Checked loops for termination for infinite l 667 - Checked loops for termination for infinite loops and annotated 693 them with "Loop checking" comment 668 them with "Loop checking" comment 694 669 695 Oct 7, 2016 D.Sorokin - fiel 670 Oct 7, 2016 D.Sorokin - field-V10-02-23 696 ----------------------- Commit: J. Apostolaki 671 ----------------------- Commit: J. Apostolakis 697 - Protection for multiple inclusion of G4Class 672 - Protection for multiple inclusion of G4ClassicalRK4 698 (thanks to Dmitrii Sorokin, GSoC 2016 stude 673 (thanks to Dmitrii Sorokin, GSoC 2016 student. ) 699 674 700 Aug 16, 2016 J.Apostolakis - fiel 675 Aug 16, 2016 J.Apostolakis - field-V10-02-22 701 --------------------------- 676 --------------------------- 702 - Added initialization of fAuxStepper in const 677 - Added initialization of fAuxStepper in constructor of 703 G4DoLoMcPriRK34, G4DormandPrince745 & G4Dorm 678 G4DoLoMcPriRK34, G4DormandPrince745 & G4DormandPrinceRK56. 704 679 705 June 11, 2016 J.Apostolakis - fiel 680 June 11, 2016 J.Apostolakis - field-V10-02-21 706 --------------------------- 681 --------------------------- 707 - Restored G4ClassicalRK4 as default stepper f 682 - Restored G4ClassicalRK4 as default stepper for B-field, 708 (due to performance issues reported in bench 683 (due to performance issues reported in benchmarking.) 709 684 710 June 10, 2016 G.Cosmo - fiel 685 June 10, 2016 G.Cosmo - field-V10-02-20 711 --------------------- 686 --------------------- 712 - Fixed code indentation in G4HelixMixedSteppe 687 - Fixed code indentation in G4HelixMixedStepper; 713 fixes compilation warnings on gcc-6.1. 688 fixes compilation warnings on gcc-6.1. 714 689 715 June 1, 2016 J.Apostolakis - fiel 690 June 1, 2016 J.Apostolakis - field-V10-02-19, 18, 17 716 -------------------------- 691 -------------------------- 717 - Fix in multiple steppers for the size of two 692 - Fix in multiple steppers for the size of two C-arrays which hold 718 intermediate values; they must be at least 693 intermediate values; they must be at least 8 and at least 719 'fNumberOfStateVariables' long. 694 'fNumberOfStateVariables' long. 720 Changed: G4CashKarp, 695 Changed: G4CashKarp, 721 G4BogackiShampine 23 & 34 696 G4BogackiShampine 23 & 34 722 G4DormandPrince 745, RK56 & RK78 697 G4DormandPrince 745, RK56 & RK78 723 G4DoLoMcPriRK34 698 G4DoLoMcPriRK34 724 G4FSALBogackiShampine45, G4FSALDorm 699 G4FSALBogackiShampine45, G4FSALDormandPrince745 725 - Made G4CashKarp the default stepper in G4Cho 700 - Made G4CashKarp the default stepper in G4ChordFinder. 726 - Deleted trial class G4NewChordFinder. 701 - Deleted trial class G4NewChordFinder. 727 702 728 June 1, 2016 J.Apostolakis - fiel 703 June 1, 2016 J.Apostolakis - field-V10-02-16 729 -------------------------- 704 -------------------------- 730 - Deleted test code (RkTestRun) due to cmake i 705 - Deleted test code (RkTestRun) due to cmake issues 731 706 732 June 1, 2016 J.Apostolakis - fiel 707 June 1, 2016 J.Apostolakis - field-V10-02-15 (also -14) 733 -------------------------- 708 -------------------------- 734 - Made G4ClassicalRK4 the default stepper agai 709 - Made G4ClassicalRK4 the default stepper again in G4ChordFinder 735 - Fixes in test code (RkTestRun) for new names 710 - Fixes in test code (RkTestRun) for new names of classes. 736 711 737 May 31, 2016 J.Apostolakis - fiel 712 May 31, 2016 J.Apostolakis - field-V10-02-13 (also -12) 738 -------------------------- 713 -------------------------- 739 - New class G4NewChordFinder, that uses old G4 714 - New class G4NewChordFinder, that uses old G4MagIntegratorDriver or 740 the newer G4FSALIntegratorDriver -- first 715 the newer G4FSALIntegratorDriver -- first try, for testing FSAL. 741 Created new test testNewChordFinder.cc to ch 716 Created new test testNewChordFinder.cc to checks this. 742 717 743 - Renamed new Stepper classes to use 'G4' pref 718 - Renamed new Stepper classes to use 'G4' prefix, including 744 DormandPrince{745,RK56,RK67} TsitourasRK45 719 DormandPrince{745,RK56,RK67} TsitourasRK45 and DoLoMcPriRK34 745 720 746 - Renamed FSAL base classes to use 'G4' prefix 721 - Renamed FSAL base classes to use 'G4' prefix & 'Integrat-ion' 747 FSALMagIntegratorStepper to G4VFSALIntegr 722 FSALMagIntegratorStepper to G4VFSALIntegrationStepper 748 FSALIntegratorDriver to G4FSALIntegr 723 FSALIntegratorDriver to G4FSALIntegrationDriver 749 and the experimental FSAL versions of steppe 724 and the experimental FSAL versions of steppers, 750 FBogackiShampine45.hh to G4FSALBogackiS 725 FBogackiShampine45.hh to G4FSALBogackiShampine45.hh 751 FDormandPrince745.hh to G4FSALDormandP 726 FDormandPrince745.hh to G4FSALDormandPrince745.hh 752 ( Note: FSAL steppers remain 'behind' the impr 727 ( Note: FSAL steppers remain 'behind' the improved non-FSAL versions.) 753 728 754 - Made DormandPrince745 (DP45) the default ste 729 - Made DormandPrince745 (DP45) the default stepper (in G4ChordFinder). 755 730 756 May 26, 2016 J.Apostolakis & Som. Banerjee - 731 May 26, 2016 J.Apostolakis & Som. Banerjee - field-V10-02-11 757 ------------------------------------------ 732 ------------------------------------------ 758 - First version of FSAL classes (as additional 733 - First version of FSAL classes (as additional classes) 759 FSAL Integrator Driver : New *concrete*, 734 FSAL Integrator Driver : New *concrete*, stand-alone driver 760 FSAL Integrator Stepper : New base class ( 735 FSAL Integrator Stepper : New base class (separate from G4MagIntegratorStepper) 761 FBogackiShampine45: FSAL-version of Bogac 736 FBogackiShampine45: FSAL-version of BogackiShampine45 stepper 762 FDormandPrince745: FSAL-version of FDorm 737 FDormandPrince745: FSAL-version of FDormandPrince745 stepper 763 Developed by Somnath Banerjee in GSoC 2015 738 Developed by Somnath Banerjee in GSoC 2015 764 739 765 Context: 740 Context: 766 * FSAL Stepper's key 'Stepper()' method for St 741 * FSAL Stepper's key 'Stepper()' method for Stepping has additional 767 argument to return the derivative at the e 742 argument to return the derivative at the end of a step. 768 If the step was successful, this estimate 743 If the step was successful, this estimate has the same order of 769 accuracy as the stepper (i.e. 5th order fo 744 accuracy as the stepper (i.e. 5th order for a 5th order stepper.) 770 745 771 - FSAL Driver method uses the revised Stepper 746 - FSAL Driver method uses the revised Stepper interface, using 772 the final (endpoint) derivative for succes 747 the final (endpoint) derivative for successful steps 773 as the start derivative for the next step, 748 as the start derivative for the next step, in case of 774 continuing of integration. 749 continuing of integration. 775 750 776 - New test (RkTestRun.cc) covering FSAL method 751 - New test (RkTestRun.cc) covering FSAL methods, integration 777 Developed by Somnath Banerjee in GSoC 2015 752 Developed by Somnath Banerjee in GSoC 2015 778 753 779 May 26, 2016 J.Apostolakis - 754 May 26, 2016 J.Apostolakis - field-V10-02-10 780 -------------------------- 755 -------------------------- 781 Preparation for addition of FSAL steppers (& d 756 Preparation for addition of FSAL steppers (& driver) 782 - G4MagIntegratorStepper: Added counter for ca 757 - G4MagIntegratorStepper: Added counter for calls to equation RHS, 783 with Get/Reset methods. 758 with Get/Reset methods. 784 - Cosmetic fixes in sources.cmake (tabs to spa 759 - Cosmetic fixes in sources.cmake (tabs to spaces) 785 760 786 May 25, 2016 J.Apostolakis & Som. Banerjee - 761 May 25, 2016 J.Apostolakis & Som. Banerjee - field-V10-02-09 787 ------------------------------------------ 762 ------------------------------------------ 788 - Added new stepper classes embedded RK method 763 - Added new stepper classes embedded RK method: 789 * DoLoMcPriRK34, 6-stage 3/4 RK (interp 764 * DoLoMcPriRK34, 6-stage 3/4 RK (interpolation) 790 * DormandPrinceRK56, 9-stage 5/6 RK (interp 765 * DormandPrinceRK56, 9-stage 5/6 RK (interpolation, FSAL-able) "6(5)" 791 * DormandPrinceRK78, 13-stage 7/8 RK (interp 766 * DormandPrinceRK78, 13-stage 7/8 RK (interpolation) "8(7) 13M" 792 created by Somnath Banerjee as part of GSoC 767 created by Somnath Banerjee as part of GSoC 2015. 793 768 794 May 25, 2016 J.Apostolakis - field 769 May 25, 2016 J.Apostolakis - field-V10-02-08 795 -------------------------- 770 -------------------------- 796 - Revised testPropagateMagField, to reduce err 771 - Revised testPropagateMagField, to reduce error severity for over-long 797 steps. An error message is still written 772 steps. An error message is still written if move > (1.+1.0e-9) * step, 798 but test does not stop. 773 but test does not stop. 799 774 800 - G4HelixMixedStepper: Fixes & added new (5th 775 - G4HelixMixedStepper: Fixes & added new (5th order) stepper choices. 801 Included (G4)Bogacki-Shampine 23/45 , Dor 776 Included (G4)Bogacki-Shampine 23/45 , DormandPrince745, 802 and newest TsitourasRK45. 777 and newest TsitourasRK45. 803 778 804 May 24, 2016 J.Apostolakis - field 779 May 24, 2016 J.Apostolakis - field-V10-02-06, 07 805 -------------------------- 780 -------------------------- 806 - Added TsitourasRK45 stepper. 781 - Added TsitourasRK45 stepper. 807 - Made Cash-Karp the default stepper (in G4Cho 782 - Made Cash-Karp the default stepper (in G4ChordFinder). 808 783 809 May 23, 2016 J.Apostolakis - field 784 May 23, 2016 J.Apostolakis - field-V10-02-05 810 -------------------------- 785 -------------------------- 811 - Made DormandPrince745 (DP45) the default ste 786 - Made DormandPrince745 (DP45) the default stepper (in G4ChordFinder). 812 787 813 May 20, 2016 J.Apostolakis - field 788 May 20, 2016 J.Apostolakis - field-V10-02-04 814 ------------------------- 789 ------------------------- 815 - Added steppers created by Somnath Banerjee a 790 - Added steppers created by Somnath Banerjee as part of GSoC 2015, 816 G4BogackiShampine23 (BS23 below), G4Bogack 791 G4BogackiShampine23 (BS23 below), G4BogackiShampine45 (BS45) and 817 DormandPrince745 (DP45). 792 DormandPrince745 (DP45). 818 These implement third order (BS23) and fifth 793 These implement third order (BS23) and fifth order (BS45, DP45) 819 embedded RK tableaus. 794 embedded RK tableaus. 820 - DP45 includes interpolation method, to evalu 795 - DP45 includes interpolation method, to evaluate the interpolant 821 ('y') at intermediate points of a successf 796 ('y') at intermediate points of a successful step. 822 BS45's interpolation method exists, but is n 797 BS45's interpolation method exists, but is not validated (fails). 823 798 824 References: 799 References: 825 - BS45 is embedded pair from paper by P. Bog 800 - BS45 is embedded pair from paper by P. Bogacki and L. F. Shampine: 826 “An efficient Runge-Kutta (4,5) pair, 801 “An efficient Runge-Kutta (4,5) pair,” 827 Comput. Math. with Appl., vol. 32, no. 6 802 Comput. Math. with Appl., vol. 32, no. 6, pp. 15–28, Sep. 1996. 828 - BS23 is four stage RK method from the pape 803 - BS23 is four stage RK method from the paper of P. Bogacki and L. F. Shampine, 829 “A 3(2) pair of Runge - Kutta formulas 804 “A 3(2) pair of Runge - Kutta formulas,” 830 Appl. Math. Lett., vol 2, no 4, p.321 (1 805 Appl. Math. Lett., vol 2, no 4, p.321 (1989). 831 - DP45 are from Table 2 of J. R. Dormand an 806 - DP45 are from Table 2 of J. R. Dormand and P. J. Prince's 832 “A family of embedded Runge-Kutta form 807 “A family of embedded Runge-Kutta formulae,” 833 Journal of comput. and applied Math., vo 808 Journal of comput. and applied Math., vol. 6, no. 1, pp. 19–26, 1980. 834 809 835 May 4, 2016 G.Cosmo - field- 810 May 4, 2016 G.Cosmo - field-V10-02-03 836 ------------------- 811 ------------------- 837 - Fixed Clone() signatures in derived Field cl 812 - Fixed Clone() signatures in derived Field classes. 838 More corrections on implementations of opera 813 More corrections on implementations of operator=() and copy-ctors. 839 814 840 Apr 29, 2016 G.Cosmo - field- 815 Apr 29, 2016 G.Cosmo - field-V10-02-02 841 -------------------- 816 -------------------- 842 - Corrected implementation of operator=() and 817 - Corrected implementation of operator=() and copy-ctor for G4Field, 843 G4ElectroMagneticField, G4ElectricField and 818 G4ElectroMagneticField, G4ElectricField and G4CachedMagneticField. 844 819 845 Feb 25, 2016 P.Gumplinger - field- 820 Feb 25, 2016 P.Gumplinger - field-V10-02-01 846 ------------------------- 821 ------------------------- 847 - address Problem Report: 1831 822 - address Problem Report: 1831 848 change: G4Mag_SpinEqRhs, G4EqEMFieldWithSpin 823 change: G4Mag_SpinEqRhs, G4EqEMFieldWithSpin, G4EqEMFieldWithEDM and 849 G4RepleteEofM.cc from g_BMT = (magMo 824 G4RepleteEofM.cc from g_BMT = (magMoment/muB)/spin 850 to g_BMT = (std:: 825 to g_BMT = (std::abs(magMoment)/muB)/spin 851 826 852 827 853 Dec 11, 2015 A.Dotti - field-V10-02-0 828 Dec 11, 2015 A.Dotti - field-V10-02-00 854 -------------------------- 829 -------------------------- 855 Fixing typo in tests/CMakeList.txt file: subdi 830 Fixing typo in tests/CMakeList.txt file: subdirecotry() 856 instead of add_subdirectory() 831 instead of add_subdirectory() 857 832 858 Nov 2, 2015 J.Apostolakis - field 833 Nov 2, 2015 J.Apostolakis - field-V10-01-15 (fixed) 859 Oct 22, 2015 J.Apostolakis - field 834 Oct 22, 2015 J.Apostolakis - field-V10-01-14 860 -------------------------- 835 -------------------------- 861 - Reverted changes in G4FieldManager from tag 836 - Reverted changes in G4FieldManager from tags field-V10-01-05 to -07 862 inadvertently reintroduced in tag field-V10 837 inadvertently reintroduced in tag field-V10-01-13 863 (fixed in tag -15: committed new copy from 838 (fixed in tag -15: committed new copy from tag -04 'on top') 864 839 865 - Added explanation comment in G4MagHelicalSte 840 - Added explanation comment in G4MagHelicalSteper. 866 841 867 Oct 13, 2015 J.Apostolakis - field 842 Oct 13, 2015 J.Apostolakis - field-V10-01-13 868 -------------------------- 843 -------------------------- 869 - G4ChordFinder::FindNextChord: Added check ag 844 - G4ChordFinder::FindNextChord: Added check against number of iterations, 870 to identify potential issue of lack of conve 845 to identify potential issue of lack of convergence. 871 - test: fixed testProElectricMagField.cc 846 - test: fixed testProElectricMagField.cc 872 847 873 - Note: tag-13 inadvertently reintroduced chan 848 - Note: tag-13 inadvertently reintroduced changes from tags field-V10-01-05 to -07 874 849 875 Jun 26, 2015 P.Gumplinger - field 850 Jun 26, 2015 P.Gumplinger - field-V10-01-12, 11 876 ------------------------- 851 ------------------------- 877 - Include 'NumberOfVariables' in G4RepleteEofM 852 - Include 'NumberOfVariables' in G4RepleteEofM constructor argument list. 878 853 879 Jun 22, 2015 G.Cosmo - field 854 Jun 22, 2015 G.Cosmo - field-V10-01-10 880 -------------------- 855 -------------------- 881 - Withdrawn also changes introduced in tag "fi 856 - Withdrawn also changes introduced in tag "field-V10-01-08", as 882 responsible for memory violation errors in V 857 responsible for memory violation errors in Valgrind. 883 Now corresponding to tag "field-V10-01-04". 858 Now corresponding to tag "field-V10-01-04". 884 859 885 Jun 18, 2015 G.Cosmo - field 860 Jun 18, 2015 G.Cosmo - field-V10-01-09 886 -------------------- 861 -------------------- 887 - Withdrawn changes introduced from tag "field 862 - Withdrawn changes introduced from tag "field-V10-01-05" to tag 888 "field-V10-01-07" included, responsible for 863 "field-V10-01-07" included, responsible for failures on SLC6 and 889 run-time errors on Valgrind checks. 864 run-time errors on Valgrind checks. 890 865 891 Jun 10, 2015 P.Gumplinger - field 866 Jun 10, 2015 P.Gumplinger - field-V10-01-08 892 ------------------------- 867 ------------------------- 893 - initialize all elements of dydx[] in G4Reple 868 - initialize all elements of dydx[] in G4RepleteEofM::EvaluateRhsGivenB 894 Thanks to Tatsuya Kikawa (Osaka Univ.) 869 Thanks to Tatsuya Kikawa (Osaka Univ.) 895 870 896 Jun 10, 2015 J.Apostolakis - field 871 Jun 10, 2015 J.Apostolakis - field-V10-01-07 897 -------------------------- 872 -------------------------- 898 - G4FieldManager.cc : Made behaviour of SetDet 873 - G4FieldManager.cc : Made behaviour of SetDetector 'softer'. No 899 longer complains by default if ChordFinder 874 longer complains by default if ChordFinder is not (yet) set. 900 ( The default values of failMode = 0 i.e. 875 ( The default values of failMode = 0 i.e. quiet. ) 901 If a chord-finder exists, it will still war 876 If a chord-finder exists, it will still warn for other errors. 902 877 903 It is still possible to have louder/extra c 878 It is still possible to have louder/extra checks done calling 904 SetDetectorField with failMode > 0 879 SetDetectorField with failMode > 0 905 or by using a new method, which expects an 880 or by using a new method, which expects an existing field: 906 ChangeDetectorField(G4Field *detectorFiel 881 ChangeDetectorField(G4Field *detectorField) 907 882 908 Jun 8, 2015 J.Apostolakis - field 883 Jun 8, 2015 J.Apostolakis - field-V10-01-05, (-06 fixed) 909 -------------------------- 884 -------------------------- 910 - G4FieldManager.cc : Revised behaviour of Set 885 - G4FieldManager.cc : Revised behaviour of SetDetector - it now 911 passes the Field to the Equation, as is the 886 passes the Field to the Equation, as is the natural user expectation 912 The previous behaviour is possible, using e 887 The previous behaviour is possible, using extra argument 'failMode' 913 flag. Values: 0 = silent ; 888 flag. Values: 0 = silent ; 914 1 (default) = warning; 889 1 (default) = warning; 915 2 or other = fatal except 890 2 or other = fatal exception. 916 Or can use alternative (new) suggestion met 891 Or can use alternative (new) suggestion method ProposeDetectorField(); 917 892 918 This change is to ensure that user expectat 893 This change is to ensure that user expectation is met: 919 if the field is changed for an existing, 894 if the field is changed for an existing, working stepper it must 920 be propagated to the equation of motion. 895 be propagated to the equation of motion. 921 Note: this causes potential conflict betwee 896 Note: this causes potential conflict between the type of the equation 922 and the field, which will need to be 897 and the field, which will need to be solved in the future. 923 898 924 Old behaviour (just set our own pointer) is 899 Old behaviour (just set our own pointer) is still available in new method: 925 ProposeDetectorField(G4Field *detectorFie 900 ProposeDetectorField(G4Field *detectorField) 926 901 927 Co-works and requires new tag in geometry/n 902 Co-works and requires new tag in geometry/navigation: geomnav-V10-01-24. 928 903 929 Jun 4, 2015 P. Gumplinger - field 904 Jun 4, 2015 P. Gumplinger - field-V10-01-04 930 ------------------------- 905 ------------------------- 931 - change assignment to field instead of Field 906 - change assignment to field instead of Field array in G4RepleteEofM.cc 932 907 933 Jan 28, 2015 J.Apostolakis - field 908 Jan 28, 2015 J.Apostolakis - field-V10-01-01 (-02,03 fixed) 934 -------------------------- 909 -------------------------- ( History ) 935 - Revert unintended inclusion of changes in G4 910 - Revert unintended inclusion of changes in G4MagIntegratorDriver 936 911 937 Jan 15, 2015 J.Apostolakis - field 912 Jan 15, 2015 J.Apostolakis - field-V10-01-00 938 -------------------------- 913 -------------------------- 939 - Small refinements in G4FieldTrack - access r 914 - Small refinements in G4FieldTrack - access rest mass, avoid div by 0 940 Avoid division by zero for Unit direction 915 Avoid division by zero for Unit direction in FieldTrack 941 Added method to get Rest Mass. 916 Added method to get Rest Mass. 942 Needed for fixes related to Problem report 1 917 Needed for fixes related to Problem report 1696. 943 Thanks to Nathan S. Froemming <nfroemm@uw.ed 918 Thanks to Nathan S. Froemming <nfroemm@uw.edu> who reported the issue 944 and created dedicated test to demonstrate i 919 and created dedicated test to demonstrate it. 945 920 946 Nov 03, 2014 G.Cosmo - field 921 Nov 03, 2014 G.Cosmo - field-V10-00-04 947 -------------------- 922 -------------------- 948 - Moved constructors and simple methods to in 923 - Moved constructors and simple methods to in line in G4ChargeState and 949 G4LineSection for CPU speedup (courtesy of S 924 G4LineSection for CPU speedup (courtesy of S.Wenzel). 950 925 951 May 21, 2014 J.Apostolakis - field 926 May 21, 2014 J.Apostolakis - field-V10-00-03 952 -------------------------- 927 -------------------------- 953 - G4FieldTrack: 928 - G4FieldTrack: 954 * Fixed SetChargeAndMoments() to use the new 929 * Fixed SetChargeAndMoments() to use the new method 955 G4ChargeState::SetChargesAndMoments(); it 930 G4ChargeState::SetChargesAndMoments(); it was changing spin, because of 956 erroneous change in G4ChargeState::SetChar 931 erroneous change in G4ChargeState::SetChargesAndMoments(), that method 957 is now renamed SetChargeSpinMoments() to s 932 is now renamed SetChargeSpinMoments() to show what it does; 958 * Added pdg-spin as argument to constructors 933 * Added pdg-spin as argument to constructors (needed to track polarization); 959 * Renamed 'spin' to 'Polarization' in method 934 * Renamed 'spin' to 'Polarization' in method, arguments, data member to 960 avoid confusion; 935 avoid confusion; 961 * Revised constructors to add pdg-spin as la 936 * Revised constructors to add pdg-spin as last argument (with default -1). 962 - G4ChargeState: 937 - G4ChargeState: 963 - Addressed Coverity issue #56281 'Arguments 938 - Addressed Coverity issue #56281 'Arguments in wrong order' 964 G4ChargeState::SetChargeMoments() when use 939 G4ChargeState::SetChargeMoments() when used in 965 G4FieldTrack::SetChargeMoments() from addi 940 G4FieldTrack::SetChargeMoments() from addition of spin to arguments, 966 without revising name of method to reflect 941 without revising name of method to reflect it; 967 - Changed order of arguments in constructor, 942 - Changed order of arguments in constructor, making spin 3rd argument 968 (was 2nd) and making all arguments mandato 943 (was 2nd) and making all arguments mandatory; 969 - Renamed SetChargeAndMoments() method with 944 - Renamed SetChargeAndMoments() method with 5 arguments including spin (2nd) 970 to SetChargeSpinMoments(); 945 to SetChargeSpinMoments(); 971 - Added new methods including SetChargesAndM 946 - Added new methods including SetChargesAndMoments(), SetChargeMdm(), 972 SetChargeDipoleMoments() (no spin), and al 947 SetChargeDipoleMoments() (no spin), and also SetChargeSpin(), 973 SetChargeMdmSpin() (which includes spin) t 948 SetChargeMdmSpin() (which includes spin) to provide most/all potential 974 combinations. 949 combinations. 975 - G4MagIntegratorDriver::OneGoodStep(): 950 - G4MagIntegratorDriver::OneGoodStep(): 976 * Trial changes to address Valgrind issue, a 951 * Trial changes to address Valgrind issue, about value used before being set. 977 952 978 Apr 01, 2014 J.Apostolakis - fi 953 Apr 01, 2014 J.Apostolakis - field-V10-00-02 979 -------------------------- 954 -------------------------- 980 - Moved G4FieldTrack::LoadFromArray() to .cc a 955 - Moved G4FieldTrack::LoadFromArray() to .cc and removed non-necessary 981 thread-local static data local to the functi 956 thread-local static data local to the function. 982 957 983 Mar 14, 2014 J.Apostolakis - fi 958 Mar 14, 2014 J.Apostolakis - field-V10-00-01 984 -------------------------- 959 -------------------------- 985 - Fix assignment operator for G4FieldTrack. (C 960 - Fix assignment operator for G4FieldTrack. (Copied Rest Mass) 986 - Improve printing of G4FieldTrack 961 - Improve printing of G4FieldTrack 987 962 988 Jan 17, 2014 P.Gumplinger - fi 963 Jan 17, 2014 P.Gumplinger - field-V10-00-00 989 ------------------------- 964 ------------------------- 990 - add G4Mag_EqRhs::SetChargeMomentumMass( part 965 - add G4Mag_EqRhs::SetChargeMomentumMass( particleCharge, MomentumXc, mass) 991 to G4Mag_SpinEqRhs::SetChargeMomentumMass, s 966 to G4Mag_SpinEqRhs::SetChargeMomentumMass, see bug reported at: 992 http://hypernews.slac.stanford.edu/HyperNews 967 http://hypernews.slac.stanford.edu/HyperNews/geant4/get/emfields/210.html 993 968 994 Nov 18, 2013 P.Gumplinger - fi 969 Nov 18, 2013 P.Gumplinger - field-V09-06-13/12 995 ------------------------- 970 ------------------------- 996 - fix Coverity warning in G4RepleteEofM 971 - fix Coverity warning in G4RepleteEofM 997 972 998 Nov 17, 2013 J.Apostolakis 973 Nov 17, 2013 J.Apostolakis 999 -------------------------- 974 -------------------------- 1000 - Fixed and improved HelixMixed Stepper: 975 - Fixed and improved HelixMixed Stepper: 1001 Corrected the default stepper for small s 976 Corrected the default stepper for small steps to be ClassicalRK4. 1002 Added Angle-threshold parameter. (Default 977 Added Angle-threshold parameter. (Default remains 0.33 radians.) 1003 Added more Steppers, including G4NystromR 978 Added more Steppers, including G4NystromRK4. 1004 Revised Id numbers of Steppers, to make t 979 Revised Id numbers of Steppers, to make the best more visible. 1005 More comments in Stepper(). 980 More comments in Stepper(). 1006 981 1007 Nov 05, 2013 P.Gumplinger - f 982 Nov 05, 2013 P.Gumplinger - field-V09-06-11 1008 ------------------------- 983 ------------------------- 1009 - remove writing out-of-bounds dydx[8] = 0. i 984 - remove writing out-of-bounds dydx[8] = 0. in G4RepleteEofM.cc 1010 985 1011 Nov 04, 2013 P.Gumplinger - f 986 Nov 04, 2013 P.Gumplinger - field-V09-06-10 1012 ------------------------- 987 ------------------------- 1013 - add G4RepleteEofM to sources.cmake 988 - add G4RepleteEofM to sources.cmake 1014 f 989 field-V09-06-09 - same as 1015 Nov 01st, 2013 P.Gumplinger - f 990 Nov 01st, 2013 P.Gumplinger - field-V09-06-08 1016 --------------------------- 991 --------------------------- 1017 - add G4RepleteEofM: EofM that includes force 992 - add G4RepleteEofM: EofM that includes force due to B, E, and gravity field 1018 as well as mu*grad(B) and spin tracking. 993 as well as mu*grad(B) and spin tracking. 1019 994 1020 May 10th, 2013 P.Gumplinger/J.Apostolakis - f 995 May 10th, 2013 P.Gumplinger/J.Apostolakis - field-V09-06-07 1021 ----------------------------------------- 996 ----------------------------------------- 1022 - Revised number of field components (to allo 997 - Revised number of field components (to allow up to 24). 1023 18 are required for new applications (B, E 998 18 are required for new applications (B, E, Gravity, B-gradients) 1024 - Fixes for initialisation errors found by Co 999 - Fixes for initialisation errors found by Coverity. 1025 1000 1026 May 10th, 2013 P.Gumplinger - field-V09-06-06 1001 May 10th, 2013 P.Gumplinger - field-V09-06-06 1027 --------------------------- 1002 --------------------------- 1028 - prevent divided by zero and shortcut spin t 1003 - prevent divided by zero and shortcut spin tracking for spin == 0 1029 particles: G4Mag_SpinEqRhs.cc, G4EqEMFieldW 1004 particles: G4Mag_SpinEqRhs.cc, G4EqEMFieldWithSpin.cc and 1030 G4EqEMFieldWithEDM.cc 1005 G4EqEMFieldWithEDM.cc 1031 f 1006 field-V09-06-05 - same 1032 May 8th, 2013 P.Gumplinger/J.Apostolakis - f 1007 May 8th, 2013 P.Gumplinger/J.Apostolakis - field-V09-06-04 1033 ----------------------------------------- 1008 ----------------------------------------- 1034 - Introduced new class G4ChargeState to hold 1009 - Introduced new class G4ChargeState to hold charge, spin, magnetic moment 1035 (promoted from internal class of G4Field 1010 (promoted from internal class of G4FieldTrack). 1036 - Changed the signature of EquationOfMotion:: 1011 - Changed the signature of EquationOfMotion::SetChargeMomentumMass to 1037 take G4ChargeState in place of G4double (cha 1012 take G4ChargeState in place of G4double (charge) as first argument. 1038 - Deleted SetChargeMomentumMass from G4ChordF 1013 - Deleted SetChargeMomentumMass from G4ChordFinder, G4PropagatorInField, 1039 G4MagInt_Driver 1014 G4MagInt_Driver 1040 1015 1041 - Migrated testPropagateMagField and testProp 1016 - Migrated testPropagateMagField and testPropagateSpin. 1042 1017 1043 March 19th, 2013 G.Cosmo - field-V09-06-03, f 1018 March 19th, 2013 G.Cosmo - field-V09-06-03, field-V09-06-02 1044 ------------------------- 1019 ------------------------- 1045 - Cleanup of MT changes in G4FieldManagerStor 1020 - Cleanup of MT changes in G4FieldManagerStore. 1046 1021 1047 February 26th, 2013 A.Dotti - field-V09-06-01 1022 February 26th, 2013 A.Dotti - field-V09-06-01 1048 --------------------------- 1023 --------------------------- 1049 - First implementation of Cloning mechanism ( 1024 - First implementation of Cloning mechanism (needed for MT) 1050 1025 1051 February 22nd, 2013 G.Cosmo - field-V09-06-00 1026 February 22nd, 2013 G.Cosmo - field-V09-06-00 1052 --------------------------- 1027 --------------------------- 1053 - Cleanup of unnecessary changes for multi-th 1028 - Cleanup of unnecessary changes for multi-threading in G4QuadrupoleMagField. 1054 - Removed unused private data-members in G4Ma 1029 - Removed unused private data-members in G4Mag_UsualEqRhs and G4RKG3_Stepper. 1055 1030 1056 November 14th, 2012 P.Mato - field-V09-05-07 1031 November 14th, 2012 P.Mato - field-V09-05-07 1057 -------------------------- 1032 -------------------------- 1058 - G4QuadrupoleMagField: allow displaced origi 1033 - G4QuadrupoleMagField: allow displaced origin and rotation (Björn Riese) 1059 - Added G4SystemOfUnits.hh in unit tests 1034 - Added G4SystemOfUnits.hh in unit tests 1060 1035 1061 August 30th, 2012 P.Mato - field-V09-05-06 1036 August 30th, 2012 P.Mato - field-V09-05-06 1062 ------------------------ 1037 ------------------------ 1063 - Adapted CMakeLists.txt files to new unit te 1038 - Adapted CMakeLists.txt files to new unit tests 1064 1039 1065 June 11th, 2012 G.Cosmo - field-V09-05-05 1040 June 11th, 2012 G.Cosmo - field-V09-05-05 1066 ----------------------- 1041 ----------------------- 1067 - Explicitly use inclusion of headers for sys 1042 - Explicitly use inclusion of headers for system of units and physical 1068 constants, in plan to remove implicit inclu 1043 constants, in plan to remove implicit inclusion from globals.hh. 1069 1044 1070 May 14th, 2012 G.Cosmo - field-V09-05-04 1045 May 14th, 2012 G.Cosmo - field-V09-05-04 1071 ---------------------- 1046 ---------------------- 1072 - Fixed spurious case of hidden variable visi 1047 - Fixed spurious case of hidden variable visibility in G4NystromRK4, 1073 detected with '-Wshadow' compilation option 1048 detected with '-Wshadow' compilation option on gcc compiler. 1074 1049 1075 February 3rd, 2012 J.Apostolakis - field-V09 1050 February 3rd, 2012 J.Apostolakis - field-V09-05-03 1076 --------------------------------- 1051 --------------------------------- 1077 - G4FieldTrack: 1052 - G4FieldTrack: 1078 Added new (inline) method to set the Rest 1053 Added new (inline) method to set the Rest Mass. Needed in order to 1079 reset this - and keep reuse the same G 1054 reset this - and keep reuse the same G4FieldTrack in a client 1080 (across tracks.) 1055 (across tracks.) 1081 Made SetCurvePnt() method private. 1056 Made SetCurvePnt() method private. 1082 Simplified implementation of constructors 1057 Simplified implementation of constructors. Gain of 1 square root and 1083 1 division per call. 1058 1 division per call. 1084 1059 1085 February 3rd, 2012 G.Cosmo - field-V09-05-0 1060 February 3rd, 2012 G.Cosmo - field-V09-05-02 1086 ---------------------------- 1061 ---------------------------- 1087 - Removed tests in CMakeLists.txt causing cat 1062 - Removed tests in CMakeLists.txt causing catastrophic failure in system 1088 testing! 1063 testing! 1089 1064 1090 February 2nd, 2012 J.Apostolakis - field-V0 1065 February 2nd, 2012 J.Apostolakis - field-V09-05-01 1091 ---------------------------------- 1066 ---------------------------------- 1092 - G4Mag_UsualEqRhs: in SetChargeMomentumMass( 1067 - G4Mag_UsualEqRhs: in SetChargeMomentumMass() method, fixed problem with 1093 division by zero; stopped updating 'fInvCur 1068 division by zero; stopped updating 'fInvCurrentMomentumXc' (data member 1094 is obsolete). 1069 is obsolete). 1095 - Added tests in CMakeLists.txt 1070 - Added tests in CMakeLists.txt 1096 1071 1097 December 13th, 2011 G.Cosmo - field-V09-05-0 1072 December 13th, 2011 G.Cosmo - field-V09-05-00 1098 ---------------------------- 1073 ---------------------------- 1099 - Fixed Coverity defects in G4SimpleRunge (re 1074 - Fixed Coverity defects in G4SimpleRunge (removed spurious pointer 1100 data member) and G4FieldTrack (missing G4Ch 1075 data member) and G4FieldTrack (missing G4ChargeState::operator=()). 1101 - Synchronised unit tests to trunk (new test 1076 - Synchronised unit tests to trunk (new test field07 and minor updates). 1102 1077 1103 November 11th, 2011 J.Apostolakis - field-V0 1078 November 11th, 2011 J.Apostolakis - field-V09-04-06 1104 ---------------------------------- 1079 ---------------------------------- 1105 - Added G4Field.cc to list of files in source 1080 - Added G4Field.cc to list of files in sources.cmake 1106 1081 1107 November 4th, 2011 J.Apostolakis - field-V0 1082 November 4th, 2011 J.Apostolakis - field-V09-04-05 1108 ---------------------------------- 1083 ---------------------------------- 1109 - G4Field: revised to improve ability to dete 1084 - G4Field: revised to improve ability to detect gravity field: 1110 Added new data member to identify gravity f 1085 Added new data member to identify gravity field; 1111 Added new method IsGravityActive() to acces 1086 Added new method IsGravityActive() to access this data member; 1112 Created new source file: moving constructor 1087 Created new source file: moving constructors to it. 1113 - Changed G4UniformGravityField and G4Electro 1088 - Changed G4UniformGravityField and G4ElectroMagneticField 1114 to accomodate this refinement. 1089 to accomodate this refinement. 1115 1090 1116 November 2nd, 2011 P.Gumplinger - field-V09- 1091 November 2nd, 2011 P.Gumplinger - field-V09-04-04 1117 -------------------------------- 1092 -------------------------------- 1118 - update list of files in sources.cmake 1093 - update list of files in sources.cmake 1119 1094 1120 October 28th, 2011 P.Gumplinger - field-V09- 1095 October 28th, 2011 P.Gumplinger - field-V09-04-03 1121 -------------------------------- 1096 -------------------------------- 1122 - Added (uniform) gravity field capability. 1097 - Added (uniform) gravity field capability. 1123 New classes G4EqGravityField, G4UniformGrav 1098 New classes G4EqGravityField, G4UniformGravityField. 1124 1099 1125 *Required* for co-working tag in Transporta 1100 *Required* for co-working tag in Transportation 1126 1101 1127 October 12th, 2011 P.Gumplinger - field-V09- 1102 October 12th, 2011 P.Gumplinger - field-V09-04-02 1128 -------------------------------- 1103 -------------------------------- 1129 - replaced: omegac = 0.105658387*GeV/mass * 2 1104 - replaced: omegac = 0.105658387*GeV/mass * 2.837374841e-3*(rad/cm/kilogauss) 1130 with: omegac = (eplus/particleMass)*c_l 1105 with: omegac = (eplus/particleMass)*c_light 1131 in G4EqEMFieldWithEDM.cc, G4Mag_SpinEqRhs.c 1106 in G4EqEMFieldWithEDM.cc, G4Mag_SpinEqRhs.cc, G4EqEMFieldWithSpin.cc 1132 changed calculation: 1107 changed calculation: 1133 std::sqrt(kineticEnergy*kineticEnergy + 1108 std::sqrt(kineticEnergy*kineticEnergy + 2.0*restMass_c2*kineticEnergy); 1134 to: 1109 to: 1135 std::sqrt(kineticEnergy*(kineticEnergy+2 1110 std::sqrt(kineticEnergy*(kineticEnergy+2.0*restMass_c2)) 1136 in G4FieldTrack.cc 1111 in G4FieldTrack.cc 1137 1112 1138 August 11th, 2011 G.Cosmo - field-V09-04-01 1113 August 11th, 2011 G.Cosmo - field-V09-04-01 1139 -------------------------- 1114 -------------------------- 1140 - Migrated to new G4Exception scheme for warn 1115 - Migrated to new G4Exception scheme for warnings and errors. 1141 - Defined scheme for warnings/errors coding: 1116 - Defined scheme for warnings/errors coding: 1142 + 1xxx for warnings, 0xxx for errors. 1117 + 1xxx for warnings, 0xxx for errors. 1143 Code numbering: 1118 Code numbering: 1144 + 0001: not supported or implemented featur 1119 + 0001: not supported or implemented features; 1145 + 0002: invalid setup/construct; 1120 + 0002: invalid setup/construct; 1146 + 0003: invalid run condition; 1121 + 0003: invalid run condition; 1147 + 1001: incorrect setup; automatically adap 1122 + 1001: incorrect setup; automatically adapted. 1148 + 1002: notification. 1123 + 1002: notification. 1149 1124 1150 May 13th, 2011 J.Apostolakis 1125 May 13th, 2011 J.Apostolakis 1151 ---------------------------- 1126 ---------------------------- 1152 - Added new class G4TrialsCounter for keeping 1127 - Added new class G4TrialsCounter for keeping statistics of trials. 1153 - Avoid printing out pointer in G4CachedMagne 1128 - Avoid printing out pointer in G4CachedMagneticField::ReportStatistics(). 1154 - Updated unit tests. 1129 - Updated unit tests. 1155 1130 1156 May 12th, 2011 G.Cosmo - field-V09-04-00 1131 May 12th, 2011 G.Cosmo - field-V09-04-00 1157 ----------------------- 1132 ----------------------- 1158 - Fixed compilation warnings from gcc-4.6.0 f 1133 - Fixed compilation warnings from gcc-4.6.0 for variables set but not used. 1159 1134 1160 May 5th, 2011 J.Apostolakis 1135 May 5th, 2011 J.Apostolakis 1161 ---------------------------- 1136 ---------------------------- 1162 - Reordered data members to group invariants, 1137 - Reordered data members to group invariants, field parameters, etc... 1163 1138 1164 Sep 10th, 2010 J.Apostolakis - field-V09-03- 1139 Sep 10th, 2010 J.Apostolakis - field-V09-03-03 1165 ----------------------------- 1140 ----------------------------- 1166 - Revised constructor of G4MagErrorStepper to 1141 - Revised constructor of G4MagErrorStepper to add number of State variables 1167 - Corrected MagErrorStepper to copy State Var 1142 - Corrected MagErrorStepper to copy State Variable to output 1168 - Enable G4ConstRK4 to copy remaining State V 1143 - Enable G4ConstRK4 to copy remaining State Variables (must integrate 6) 1169 1144 1170 Sep 10th, 2010 J.Apostolakis - field-V09-03- 1145 Sep 10th, 2010 J.Apostolakis - field-V09-03-02 1171 ----------------------------- 1146 ----------------------------- 1172 - New class G4MonopoleEq for rhs of d(pc)/ds 1147 - New class G4MonopoleEq for rhs of d(pc)/ds propagation in field 1173 in SI units (V.Grichine). 1148 in SI units (V.Grichine). 1174 - Fixed passing of time in G4NystromRK4 1149 - Fixed passing of time in G4NystromRK4 1175 1150 1176 Jul 21st, 2010 T.Nikitina - field-V09-03-01 1151 Jul 21st, 2010 T.Nikitina - field-V09-03-01 1177 -------------------------- 1152 -------------------------- 1178 - Fixed cases of memory corruption in G4RKG3_ 1153 - Fixed cases of memory corruption in G4RKG3_Stepper. 1179 - Fixed case of unused array data member in G 1154 - Fixed case of unused array data member in G4ExactHelixStepper. 1180 - Removed useless code never executed in G4Co 1155 - Removed useless code never executed in G4ConstRK4::Stepper(). 1181 - Fixed initialization in G4NystromRK4 constr 1156 - Fixed initialization in G4NystromRK4 constructor. 1182 1157 1183 Jul 14th, 2010 G.Cosmo - field-V09-03-00 1158 Jul 14th, 2010 G.Cosmo - field-V09-03-00 1184 ----------------------- 1159 ----------------------- 1185 - Added dummy initialization of members in co 1160 - Added dummy initialization of members in constructors for G4CashKarpRKF45, 1186 G4ConstRK4, G4EqEMFieldWithEDM, G4EqEMField 1161 G4ConstRK4, G4EqEMFieldWithEDM, G4EqEMFieldWithSpin, G4ExactHelixStepper, 1187 G4FieldTrack, G4MagHelicalStepper, G4MagInt 1162 G4FieldTrack, G4MagHelicalStepper, G4MagInt_Driver, G4Mag_EqRhs, 1188 G4Mag_SpinEqRhs, G4Mag_UsualEqRhs, G4Nystro 1163 G4Mag_SpinEqRhs, G4Mag_UsualEqRhs, G4NystromRK4, G4RKG3_Stepper, 1189 G4UniformElectricField, G4UniformElectricFi 1164 G4UniformElectricField, G4UniformElectricField. 1190 1165 1191 Nov 12th, 2009 J.Apostolakis - field-V09-02- 1166 Nov 12th, 2009 J.Apostolakis - field-V09-02-09 1192 ----------------------------- 1167 ----------------------------- 1193 - G4MagIntegratorDriver: activate check on i 1168 - G4MagIntegratorDriver: activate check on integration error for spin. 1194 1169 1195 Nov 12th, 2009 J.Apostolakis - field-V09-02- 1170 Nov 12th, 2009 J.Apostolakis - field-V09-02-08 1196 ----------------------------- (fix only) 1171 ----------------------------- (fix only) 1197 - G4Nystrom: Corrected interface method getF 1172 - G4Nystrom: Corrected interface method getField: array now has explicit dimension[4] 1198 (Problem found by gcc 4.3 - i 1173 (Problem found by gcc 4.3 - it checked indices used in inline method! ) 1199 1174 1200 Nov 6th, 2009 P.Gumplinger - field-V09-02-07 1175 Nov 6th, 2009 P.Gumplinger - field-V09-02-07 1201 --------------------------- 1176 --------------------------- 1202 - bug fix in G4EqEMFieldWithSpin and G4EqEMFi 1177 - bug fix in G4EqEMFieldWithSpin and G4EqEMFieldWithEDM 1203 thanks to Hiromi Iinuma (KEK) see: 1178 thanks to Hiromi Iinuma (KEK) see: 1204 http://hypernews.slac.stanford.edu/HyperNew 1179 http://hypernews.slac.stanford.edu/HyperNews/geant4/get/emfields/161.html 1205 1180 1206 Nov 5th, 2009 J.Apostolakis - field-V09-02-0 1181 Nov 5th, 2009 J.Apostolakis - field-V09-02-06 1207 ---------------------------- 1182 ---------------------------- 1208 - G4MagIntegratorDriver.cc : Enabled call to 1183 - G4MagIntegratorDriver.cc : Enabled call to ComputeRightHandSide 1209 - G4NystromRK4.cc : Disabled auxilia 1184 - G4NystromRK4.cc : Disabled auxiliary code in Stepper (needed if 1210 ComputeRightHan 1185 ComputeRightHandSide is not called.) 1211 1186 1212 Nov 5th, 2009 J.Apostolakis - field-V09-02-0 1187 Nov 5th, 2009 J.Apostolakis - field-V09-02-05 1213 ---------------------------- 1188 ---------------------------- 1214 - Added new virtual method CalculateRightHand 1189 - Added new virtual method CalculateRightHandSide to G4MagIntegratorStepper for use 1215 in caching momentum (and field value) b 1190 in caching momentum (and field value) by G4NystromRK4 1216 Default implementation in G4MagIntegrat 1191 Default implementation in G4MagIntegratorStepper calls RightHandSide inline method. 1217 - G4Nystrom: New Set/Get method for cache di 1192 - G4Nystrom: New Set/Get method for cache distance. 1218 Changed private data members in 1193 Changed private data members in G4NystromRK4. 1219 - G4MagIntegratorDriver: alternative call to 1194 - G4MagIntegratorDriver: alternative call to ComputeRightHandSide is not used (in comment) 1220 As a result G4NystromRK4 operat 1195 As a result G4NystromRK4 operates without reusing 1221 1196 1222 Nov 5th, 2009 J.Apostolakis - field-V09-02-0 1197 Nov 5th, 2009 J.Apostolakis - field-V09-02-04 1223 ---------------------------- 1198 ---------------------------- 1224 - G4CachedMagneticField: New Simple class to 1199 - G4CachedMagneticField: New Simple class to cache value of Magnetic Field. 1225 Speeds up code when calculation of field 1200 Speeds up code when calculation of field value is complex. 1226 - G4NystromRK4 : New Stepper with Nys 1201 - G4NystromRK4 : New Stepper with Nystrom for magnetic field 1227 with analytic estimation of integration 1202 with analytic estimation of integration error. 1228 Greatly reduces number of field value pe 1203 Greatly reduces number of field value per step. 1229 - Revised testPropagateMagField to use Cached 1204 - Revised testPropagateMagField to use Cached Quadrupole field, 1230 and to cover G4NystromRK4 and G4ConstRK4 1205 and to cover G4NystromRK4 and G4ConstRK4. 1231 1206 1232 Nov 4th, 2009 P.Gumplinger - field-V09-02-03 1207 Nov 4th, 2009 P.Gumplinger - field-V09-02-03 1233 --------------------------- 1208 --------------------------- 1234 - (minor change) remove comment from G4EqEMFi 1209 - (minor change) remove comment from G4EqEMFieldWithSpin.cc 1235 add G4EqEMFieldWithEDM class: this is the R 1210 add G4EqEMFieldWithEDM class: this is the RHS of EofM in a combined 1236 electric and magnetic field, with spin trac 1211 electric and magnetic field, with spin tracking for both MDM and EDM terms. 1237 Thanks to Kevin Lynch, Phys. Dept. at Bosto 1212 Thanks to Kevin Lynch, Phys. Dept. at Boston University. 1238 1213 1239 May 18th, 2009 T.Nikitina - field-V09-02-02 1214 May 18th, 2009 T.Nikitina - field-V09-02-02 1240 ------------------------- 1215 ------------------------- 1241 - Enhanced algorithm G4ChordFinder::ApproxCur 1216 - Enhanced algorithm G4ChordFinder::ApproxCurvePointS() in order to speedup 1242 BrentLocator. 1217 BrentLocator. 1243 1218 1244 March 25th, 2009 G.Cosmo - field-V09-02-01 1219 March 25th, 2009 G.Cosmo - field-V09-02-01 1245 ------------------------ 1220 ------------------------ 1246 - Some code cleanup and formatting... 1221 - Some code cleanup and formatting... 1247 1222 1248 March 6th, 2009 P.Gumplinger - field-V09-02-0 1223 March 6th, 2009 P.Gumplinger - field-V09-02-00 1249 ---------------------------- 1224 ---------------------------- 1250 - Added 3rd term of BMT equation (Spin x Beta 1225 - Added 3rd term of BMT equation (Spin x Beta x Efield) to G4EqEMFieldWithSpin, 1251 addresses emfields forum posting #155 (bug 1226 addresses emfields forum posting #155 (bug report). Thanks to Kevin Lynch, 1252 Phys. Dept. at Boston University. 1227 Phys. Dept. at Boston University. 1253 - Moved renormalization of spin from G4EqEMFi 1228 - Moved renormalization of spin from G4EqEMFieldWithSpin and G4Mag_SpinEqRhs to 1254 G4ClassicalRK4 and G4SimpleHeum. 1229 G4ClassicalRK4 and G4SimpleHeum. 1255 - Added Spin propagation errors to the criter 1230 - Added Spin propagation errors to the criteria for 'OneGoodStep' in 1256 G4MagIntegratorDriver but actually don't ad 1231 G4MagIntegratorDriver but actually don't add it (yet) to the decision logic. 1257 1232 1258 November, 19th, 2008 P.Gumplinger - field-V0 1233 November, 19th, 2008 P.Gumplinger - field-V09-01-05 1259 ---------------------------------- 1234 ---------------------------------- 1260 - Renormalized the spin to 1 in G4EqEMFieldWi 1235 - Renormalized the spin to 1 in G4EqEMFieldWithSpin and G4Mag_SpinEqRhs. 1261 1236 1262 November, 7th, 2008 P.Gumplinger - field-V0 1237 November, 7th, 2008 P.Gumplinger - field-V09-01-04 1263 ---------------------------------- 1238 ---------------------------------- 1264 - Added SetAnomaly() and GetAnomaly() accesso 1239 - Added SetAnomaly() and GetAnomaly() accessors to G4EqEMFieldWithSpin. 1265 1240 1266 October, 28th, 2008 T.Nikitina - field-V09- 1241 October, 28th, 2008 T.Nikitina - field-V09-01-03 1267 -------------------------------- 1242 -------------------------------- 1268 - Added 'ApproxCurveV' to method G4ChordFinde 1243 - Added 'ApproxCurveV' to method G4ChordFinder::ApproxCurvePointS() in 1269 order to better calculate the curve length. 1244 order to better calculate the curve length. 1270 - Some code cleanup. 1245 - Some code cleanup. 1271 1246 1272 September, 18th, 2008 T.Nikitina 1247 September, 18th, 2008 T.Nikitina 1273 ---------------------------------- 1248 ---------------------------------- 1274 - Added new stepper class G4ConstRK4, perform 1249 - Added new stepper class G4ConstRK4, performing integration of one step 1275 with error calculation in constant magnetic 1250 with error calculation in constant magnetic field; implementation derived 1276 from G4ClassicalRK4. 1251 from G4ClassicalRK4. 1277 1252 1278 July, 15th, 2008 J.Apostolakis - field-V09- 1253 July, 15th, 2008 J.Apostolakis - field-V09-01-02 1279 -------------------------------- 1254 -------------------------------- 1280 - Revised signature of G4ChordFinder::FinderN 1255 - Revised signature of G4ChordFinder::FinderNextChord(), making 'FieldTrack' 1281 argument passed a reference. 1256 argument passed a reference. 1282 1257 1283 May, 28th, 2008 T.Nikitina 1258 May, 28th, 2008 T.Nikitina 1284 ---------------------------- 1259 ---------------------------- 1285 - G4ChordFinder: added new method ApproxCurve 1260 - G4ChordFinder: added new method ApproxCurvePointS() using Brent second order 1286 location mechanism. 1261 location mechanism. 1287 1262 1288 April 24th, 2008 T.Nikitina - field-V09-01- 1263 April 24th, 2008 T.Nikitina - field-V09-01-01 1289 ----------------------------- 1264 ----------------------------- 1290 - Fix 'unused' non-initialized values of dydx 1265 - Fix 'unused' non-initialized values of dydx in G4EqMagElectricField 1291 and G4EqEMFieldWithSpin. 1266 and G4EqEMFieldWithSpin. 1292 1267 1293 January 17th, 2008 G.Cosmo - field-V09-01-0 1268 January 17th, 2008 G.Cosmo - field-V09-01-00 1294 ---------------------------- 1269 ---------------------------- 1295 - G4CashKarpRKF45: deleted un-needed duplicat 1270 - G4CashKarpRKF45: deleted un-needed duplicate (and unused) instance variable 1296 'fNumberOfVariables', already defined in G4M 1271 'fNumberOfVariables', already defined in G4MagIntegratorStepper. (J.Ap.) 1297 - Some code cleanup. 1272 - Some code cleanup. 1298 1273 1299 December 7th, 2007 J.Apostolakis & T.Nikiti 1274 December 7th, 2007 J.Apostolakis & T.Nikitina - field-V09-00-03 1300 --------------------------------------------- 1275 ----------------------------------------------- 1301 - New class G4FieldManagerStore. It enables r 1276 - New class G4FieldManagerStore. It enables resetting of all chord 1302 finders' state. Needed to address problem r 1277 finders' state. Needed to address problem reported by user. 1303 1278 1304 September 9th, 2007 G.Cosmo - field-V09-00-0 1279 September 9th, 2007 G.Cosmo - field-V09-00-02a 1305 ---------------------------- 1280 ---------------------------- 1306 - Some code cleanup in G4MagHelicalStepper.cc 1281 - Some code cleanup in G4MagHelicalStepper.cc. 1307 1282 1308 August 30th, 2007 P.Gumplinger - field-V09 1283 August 30th, 2007 P.Gumplinger - field-V09-00-02 1309 --------------------------------- 1284 --------------------------------- 1310 - Add G4EqEMFieldWithSpin class to allow trac 1285 - Add G4EqEMFieldWithSpin class to allow tracking of spin also in 1311 G4ElectroMagneticFields 1286 G4ElectroMagneticFields 1312 1287 1313 August 21st, 2007 T.Nikitina - field-V09-0 1288 August 21st, 2007 T.Nikitina - field-V09-00-01 1314 ------------------------------- 1289 ------------------------------- 1315 - Fix to DistChord() method for Helical Stepp 1290 - Fix to DistChord() method for Helical Steppers: adopt 'special' case 1316 also for Ang<2pi not only for Ang<pi; use c 1291 also for Ang<2pi not only for Ang<pi; use cos() in place of tan(), to 1317 improve CPU performance. 1292 improve CPU performance. 1318 - Improved AdvanceHelix() to be able to make 1293 - Improved AdvanceHelix() to be able to make half step and full step 1319 in one call. 1294 in one call. 1320 - In G4HelixMixedStepper added possibility to 1295 - In G4HelixMixedStepper added possibility to call different steppers for 1321 small steps and add some statistics how off 1296 small steps and add some statistics how offen different steppers are called. 1322 - G4RKG3_Stepper: improved internal algorithm 1297 - G4RKG3_Stepper: improved internal algorithm to use pre-computed values; 1323 the stepper now gives comparable CPU perfor 1298 the stepper now gives comparable CPU performance as ClassicalRK4. 1324 - Updated unit tests. 1299 - Updated unit tests. 1325 1300 1326 August 17th, 2007 G.Cosmo - field-V09-00-0 1301 August 17th, 2007 G.Cosmo - field-V09-00-00 1327 ---------------------------- 1302 ---------------------------- 1328 - Changed FatalException to EventMustBeAborte 1303 - Changed FatalException to EventMustBeAborted in AccurateAdvance() 1329 if proposed integration step is negative. 1304 if proposed integration step is negative. 1330 1305 1331 June 8th, 2007 T.Nikitina - field-V08-03-0 1306 June 8th, 2007 T.Nikitina - field-V08-03-03 1332 ---------------------------- 1307 ---------------------------- 1333 - Relaxed FatalException to Warning in G4MagI 1308 - Relaxed FatalException to Warning in G4MagIntegratorDriver::AccurateAdvance() 1334 for case of step zero and return previous v 1309 for case of step zero and return previous value. This fixes problem 1335 observed by ATLAS in release 8.3 when requi 1310 observed by ATLAS in release 8.3 when requiring very accurate propagation 1336 -- ie using very small values for acceptabl 1311 -- ie using very small values for acceptable integration error. 1337 1312 1338 May 18th, 2007 T.Nikitina - field-V08-03-0 1313 May 18th, 2007 T.Nikitina - field-V08-03-02 1339 ---------------------------- 1314 ---------------------------- 1340 - New class G4HelixMixedStepper, mixing helic 1315 - New class G4HelixMixedStepper, mixing helical stepper and RK 1341 G4MagHelicalStepper 1316 G4MagHelicalStepper 1342 - Keep values of inverse Radius, .. 1317 - Keep values of inverse Radius, .. 1343 - New calculation of DistChord for SteppingAn 1318 - New calculation of DistChord for SteppingAngle > pi 1344 G4RKG3Stepper 1319 G4RKG3Stepper 1345 - New calculation of DistChord for SteppingAn 1320 - New calculation of DistChord for SteppingAngle > pi 1346 1321 1347 May 16th, 2007 G.Cosmo - field-V08-03-01 1322 May 16th, 2007 G.Cosmo - field-V08-03-01 1348 ------------------------- 1323 ------------------------- 1349 - Introduced new class G4ErrorMag_UsualEqRhs 1324 - Introduced new class G4ErrorMag_UsualEqRhs used to reverse the magnetic 1350 field when propagation is backwards for err 1325 field when propagation is backwards for error propagation (by P.Arce). 1351 - Coworks with tag "global-V08-03-02". 1326 - Coworks with tag "global-V08-03-02". 1352 1327 1353 May 11th, 2007 G.Cosmo - field-V08-03-00 1328 May 11th, 2007 G.Cosmo - field-V08-03-00 1354 ------------------------- 1329 ------------------------- 1355 - Use call to G4GeometryTolerance instead of 1330 - Use call to G4GeometryTolerance instead of kCarTolerance constant in 1356 G4MagIntegratorDriver. 1331 G4MagIntegratorDriver. 1357 - Requires tag "global-V08-03-00" and related 1332 - Requires tag "global-V08-03-00" and related tag set. 1358 1333 1359 May 10th, 2007 J.Apostolakis - field-V08-0 1334 May 10th, 2007 J.Apostolakis - field-V08-02-01 1360 ------------------------------- 1335 ------------------------------- 1361 - G4MagIntegratorDriver: 1336 - G4MagIntegratorDriver: 1362 * added protections against zero initial 1337 * added protections against zero initial or internal step h=0, (exceptions) 1363 * revised (re)calculation of h, and quit 1338 * revised (re)calculation of h, and quit loop if h/length < smallest-fraction (~ 10^-12) 1364 1339 1365 April 26th, 2007 T.Nikitina - field-V08-02-0 1340 April 26th, 2007 T.Nikitina - field-V08-02-00 1366 ---------------------------- 1341 ---------------------------- 1367 - Corrected integration constants in G4MagHel 1342 - Corrected integration constants in G4MagHelicalStepper 1368 - Added implementation of G4RKG3_Stepper, ste 1343 - Added implementation of G4RKG3_Stepper, stepper derived from Geant3. 1369 - Updated NTST unit test. New unit test "fiel 1344 - Updated NTST unit test. New unit test "field06" for comparison of steppers. 1370 1345 1371 November 14th, 2006 J.Apostolakis - field-V0 1346 November 14th, 2006 J.Apostolakis - field-V08-01-02 1372 ---------------------------------- 1347 ---------------------------------- 1373 - G4MagIntegratorDriver 1348 - G4MagIntegratorDriver 1374 * Made first argument of GetDerivatives a r 1349 * Made first argument of GetDerivatives a reference - avoid copy 1375 - G4MagIntegratorStepper 1350 - G4MagIntegratorStepper 1376 * Include the SetEquationOfMotion() method 1351 * Include the SetEquationOfMotion() method in G4MagIntegratorStepper 1377 (for Geant4e, as in field-V08-01-00) 1352 (for Geant4e, as in field-V08-01-00) 1378 * Update of disclaimers. 1353 * Update of disclaimers. 1379 1354 1380 November 13th, 2006 G.Cosmo - field-V08-01-0 1355 November 13th, 2006 G.Cosmo - field-V08-01-01 1381 ---------------------------- 1356 ---------------------------- 1382 - G4FieldTrack: 1357 - G4FieldTrack: 1383 o Implemented missing definition for GetCha 1358 o Implemented missing definition for GetCharge(). 1384 o Corrected 'const' qualifier for accessors 1359 o Corrected 'const' qualifier for accessors in the subclass. 1385 o Cleanup ... 1360 o Cleanup ... 1386 - NOTE: this tag is NOT including the change 1361 - NOTE: this tag is NOT including the change below in G4MagIntegratorStepper. 1387 1362 1388 June 21st, 2006 J.Apostolakis - field-V08-01 1363 June 21st, 2006 J.Apostolakis - field-V08-01-00 1389 ------------------------------ 1364 ------------------------------ 1390 - Including the SetEquationOfMotion() method 1365 - Including the SetEquationOfMotion() method in G4MagIntegratorStepper 1391 1366 1392 June 22nd, 2006 J.Apostolakis - field-V08-00 1367 June 22nd, 2006 J.Apostolakis - field-V08-00-07 1393 ----------------------------- 1368 ----------------------------- 1394 - G4ExactHelixStepper: reintroduced corrected 1369 - G4ExactHelixStepper: reintroduced corrected class 1395 --> testPropagateMagField now tests it al 1370 --> testPropagateMagField now tests it also (added) 1396 - G4MagHelicalStepper: made Stepper virtual ( 1371 - G4MagHelicalStepper: made Stepper virtual (for now) 1397 to enable G4ExactHelixStepper to 1372 to enable G4ExactHelixStepper to override it 1398 1373 1399 June 21st, 2006 J.Apostolakis - field-V08-00 1374 June 21st, 2006 J.Apostolakis - field-V08-00-06 1400 ----------------------------- 1375 ----------------------------- 1401 - G4ExactHelixStepper: taking out class 1376 - G4ExactHelixStepper: taking out class 1402 (provisional tag in case of difficulties w 1377 (provisional tag in case of difficulties with class, revisions) 1403 1378 1404 --- The field-V08-00-0x , x > 6, tags do not 1379 --- The field-V08-00-0x , x > 6, tags do not include the change below 1405 1380 1406 May 27th, 2006 J.Apostolakis - field-V08-00- 1381 May 27th, 2006 J.Apostolakis - field-V08-00-05 1407 ----------------------------- 1382 ----------------------------- 1408 - G4FieldTrack: Fix for simple compilation er 1383 - G4FieldTrack: Fix for simple compilation error on Sun. 1409 1384 1410 May 23rd, 2006 J.Apostolakis - field-V08-00- 1385 May 23rd, 2006 J.Apostolakis - field-V08-00-04 1411 ----------------------------- 1386 ----------------------------- 1412 - G4FieldTrack: Fix for memory leak for Charg 1387 - G4FieldTrack: Fix for memory leak for ChargeState 1413 Made G4ChargeState a data member (has an i 1388 Made G4ChargeState a data member (has an instance) 1414 1389 1415 May 18th, 2006 J.Apostolakis - field-V08-00- 1390 May 18th, 2006 J.Apostolakis - field-V08-00-03 1416 ----------------------------- 1391 ----------------------------- 1417 - G4FieldTrack: Fix for issue with gcc 4.0 ( 1392 - G4FieldTrack: Fix for issue with gcc 4.0 (mac) 1418 1393 1419 May 16th, 2006 J.Apostolakis - field-V08-00- 1394 May 16th, 2006 J.Apostolakis - field-V08-00-02 1420 ----------------------------- 1395 ----------------------------- 1421 - G4ExactHelixStepper 1396 - G4ExactHelixStepper 1422 Taken out alpha version - it was included 1397 Taken out alpha version - it was included in error 1423 1398 1424 May 11th, 2006 J.Apostolakis - field-V08-00- 1399 May 11th, 2006 J.Apostolakis - field-V08-00-01 1425 ----------------------------- 1400 ----------------------------- 1426 - G4FieldTrack 1401 - G4FieldTrack 1427 Significant, provisional change: 1402 Significant, provisional change: 1428 * Added charge and moments to FieldTrack 1403 * Added charge and moments to FieldTrack 1429 (SetMethods, and pointer to embedde 1404 (SetMethods, and pointer to embedded class G4ChargeState) 1430 Technical revisions: 1405 Technical revisions: 1431 * New constructor, with charge and witho 1406 * New constructor, with charge and without velocity 1432 * New almost-default constructor (taking 1407 * New almost-default constructor (taking a character) 1433 Also: 1408 Also: 1434 * New constructor to take const referenc 1409 * New constructor to take const reference to Spin 1435 * New implementation method UpdateFourMo 1410 * New implementation method UpdateFourMomentum 1436 * Streaming operator takes const referen 1411 * Streaming operator takes const reference, 1437 and outputs momentum magnitude & dir 1412 and outputs momentum magnitude & direction magn. 1438 1413 1439 - G4ExactHelixStepper 1414 - G4ExactHelixStepper 1440 Included in error 1415 Included in error 1441 1416 1442 Apr 6th, 2006 J.Apostolakis - field-V08-00-0 1417 Apr 6th, 2006 J.Apostolakis - field-V08-00-00 1443 ---------------------------- 1418 ---------------------------- 1444 - In G4FieldManager 1419 - In G4FieldManager 1445 Added missing const GetChordFinder() method 1420 Added missing const GetChordFinder() method -- Problem report #847 1446 Corrected description (at top of include fil 1421 Corrected description (at top of include file hh): 1447 - It is possible to set the field manager o 1422 - It is possible to set the field manager of a logical volume (since long) 1448 1423 1449 1424 1450 Nov 9th, 2005 G.Cosmo - field-V07-01-00 1425 Nov 9th, 2005 G.Cosmo - field-V07-01-00 1451 ---------------------- 1426 ---------------------- 1452 - Archived source code of field01 unit test, 1427 - Archived source code of field01 unit test, now moved to examples/extended. 1453 - Migrated unit test NTST to use <sstream> an 1428 - Migrated unit test NTST to use <sstream> and std:: namespace. Up-to-date 1454 with G4VParticleChange new interface. 1429 with G4VParticleChange new interface. 1455 1430 1456 Dec 2nd, 2004 G.Cosmo - field-V06-02-02 1431 Dec 2nd, 2004 G.Cosmo - field-V06-02-02 1457 ---------------------- 1432 ---------------------- 1458 - Implemented migration to <cmath> for standa 1433 - Implemented migration to <cmath> for standard mathematical functions. 1459 1434 1460 Dec 2nd, 2004 J.Apostolakis - field-V06-02-0 1435 Dec 2nd, 2004 J.Apostolakis - field-V06-02-01 1461 ---------------------------- 1436 ---------------------------- 1462 - Improvements to comments in key Field class 1437 - Improvements to comments in key Field classes 1463 - Changes to test/NTST, renaming 'main()' fil 1438 - Changes to test/NTST, renaming 'main()' file & modifying input files 1464 - Several improvements to test files 1439 - Several improvements to test files 1465 testProElectroMagField.cc 1440 testProElectroMagField.cc 1466 * updating for new Electric Field inheri 1441 * updating for new Electric Field inheritance (& need for 1467 different ChordFinder creation ) 1442 different ChordFinder creation ) 1468 * adding columns to print-outs in spin c 1443 * adding columns to print-outs in spin case for better diagnosis 1469 testPropagateMagField.cc 1444 testPropagateMagField.cc 1470 * Added verbosity level 1 to field Propa 1445 * Added verbosity level 1 to field Propagator, relabelled old method. 1471 testPropagateSpin.cc 1446 testPropagateSpin.cc 1472 * Added more printout of parameters (sta 1447 * Added more printout of parameters (state) of G4PropagatorInField 1473 and G4FieldManager before running each 1448 and G4FieldManager before running each test. 1474 test/NTST 1449 test/NTST 1475 * Renamed main() file to testNTST.cc and 1450 * Renamed main() file to testNTST.cc and added G4UItcsh terminal. 1476 1451 1477 1452 1478 Oct 20th, 2004 P.Gumplinger - field-V06-02-0 1453 Oct 20th, 2004 P.Gumplinger - field-V06-02-00 1479 ---------------------------- 1454 ---------------------------- 1480 - Added Set/GetAnomaly() methods in G4Mag_Spi 1455 - Added Set/GetAnomaly() methods in G4Mag_SpinEqRhs. 1481 1456 1482 Feb 9th, 2004 G.Cosmo - field-V06-00-00 1457 Feb 9th, 2004 G.Cosmo - field-V06-00-00 1483 ---------------------- 1458 ---------------------- 1484 - G4UniformMagField.cc: added missing impleme 1459 - G4UniformMagField.cc: added missing implementation for 1485 GetConstantFieldValue(). Fixes bug report # 1460 GetConstantFieldValue(). Fixes bug report #575. 1486 1461 1487 Nov 13th, 2003 J.Apostolakis - field-V05-02- 1462 Nov 13th, 2003 J.Apostolakis - field-V05-02-08 1488 ----------------------------- 1463 ----------------------------- 1489 - G4ChordFinder: 1464 - G4ChordFinder: 1490 o extended the arguments of AdvanceChordLim 1465 o extended the arguments of AdvanceChordLimited and FindNextChord 1491 adding the current safety sphere (origin, 1466 adding the current safety sphere (origin, radius), for use in optimising. 1492 o fixed set functions which had side effect 1467 o fixed set functions which had side effect (on first fraction.) 1493 - Added new class G4ChordFinderSaf (using abo 1468 - Added new class G4ChordFinderSaf (using above) 1494 o which uses safety to create longer chords 1469 o which uses safety to create longer chords, so enabling 1495 propagation in fewer steps --> performa 1470 propagation in fewer steps --> performance optimisation 1496 - G4FieldManager: 1471 - G4FieldManager: 1497 Changed default accuracy parameters to mu 1472 Changed default accuracy parameters to much better values: 1498 Epsilon Min Default to 5.0e-5 from 1473 Epsilon Min Default to 5.0e-5 from 5.0e-7 (too small) 1499 Epsilon Max Default to 0.001 from 1474 Epsilon Max Default to 0.001 from 0.05 (far too big) 1500 1475 1501 Nov 7th, 2003 J.Apostolakis - field-V05-02- 1476 Nov 7th, 2003 J.Apostolakis - field-V05-02-07 1502 ----------------------------- 1477 ----------------------------- 1503 - G4ChordFinder 1478 - G4ChordFinder 1504 o Made this a base class 1479 o Made this a base class 1505 * to enable specialised implementations 1480 * to enable specialised implementations 1506 * virtual methods: FindNextChord, PrintSt 1481 * virtual methods: FindNextChord, PrintStatistics) 1507 * new method AccumulateStatistics to aid 1482 * new method AccumulateStatistics to aid in this 1508 1483 1509 o New default value of 1484 o New default value of Accuracy!! 1510 Delta Chord to 0.25 mm (from 1485 Delta Chord to 0.25 mm (from 3.00 mm) <----- 1511 1486 1512 - G4FieldManager 1487 - G4FieldManager 1513 o Changed default values of 1488 o Changed default values of 1514 Delta One Step to 0.010 mm (from 1489 Delta One Step to 0.010 mm (from 0.25 mm) <----- 1515 Delta Intersection to 0.001 mm (from 1490 Delta Intersection to 0.001 mm (from 0.10 mm) <----- 1516 for increased default accuracy 1491 for increased default accuracy 1517 o Use field's DoesFieldChangesEnergy method 1492 o Use field's DoesFieldChangesEnergy method to set relevant member variable 1518 1493 1519 Nov 7th, 2003 J.Apostolakis - field-V05-02-0 1494 Nov 7th, 2003 J.Apostolakis - field-V05-02-06 1520 ---------------------------- 1495 ---------------------------- 1521 - G4ChordFinder 1496 - G4ChordFinder 1522 Created new class members for parameters u 1497 Created new class members for parameters used in heuristics: 1523 fFirstFraction for first st 1498 fFirstFraction for first step 1524 fFractionLast fraction of 1499 fFractionLast fraction of last step, if redoing 1525 fFractionNextEstimate confidence i 1500 fFractionNextEstimate confidence in step est from chord 1526 fMultipleRadius for small ra 1501 fMultipleRadius for small radii of curve 1527 New method to Print Statistics. 1502 New method to Print Statistics. 1528 Verbosity to enable optional printing of s 1503 Verbosity to enable optional printing of stats in destructor. 1529 1504 1530 Nov 7th, 2003 J.Apostolakis - field-V05-02-0 1505 Nov 7th, 2003 J.Apostolakis - field-V05-02-05 1531 ---------------------------- 1506 ---------------------------- 1532 - G4ChordFinder 1507 - G4ChordFinder 1533 o Added simple statistics (with access meth 1508 o Added simple statistics (with access methods) 1534 - test/NTST 1509 - test/NTST 1535 o Added new test, taken from D. Williams' e 1510 o Added new test, taken from D. Williams' exampleNTST 1536 modified and maintained by J. Apostolaki 1511 modified and maintained by J. Apostolakis 1537 1512 1538 Nov 5th, 2003 J.Apostolakis - field-V05-02-0 1513 Nov 5th, 2003 J.Apostolakis - field-V05-02-04 1539 ---------------------------- 1514 ---------------------------- 1540 - G4FieldManager 1515 - G4FieldManager 1541 o Added Get/Set Min/Max imumEpsilonStep 1516 o Added Get/Set Min/Max imumEpsilonStep 1542 o Added fEpsilonMin fEpsilonMax & default t 1517 o Added fEpsilonMin fEpsilonMax & default to member variables. 1543 >> Now these can be tailored for different 1518 >> Now these can be tailored for different parts of a detector or setup 1544 1519 1545 - G4Field G4ElectroMagneticField G4MagneticFi 1520 - G4Field G4ElectroMagneticField G4MagneticField 1546 o Adding the virtual method DoesFieldChan 1521 o Adding the virtual method DoesFieldChangeEnergy() [to be used later] 1547 o So that G4ElectroMagneticField derives fr 1522 o So that G4ElectroMagneticField derives from G4Field 1548 and G4MagneticField derives from G4Electr 1523 and G4MagneticField derives from G4ElectroMagneticField 1549 1524 1550 - G4MagErrorStepper and derived classes 1525 - G4MagErrorStepper and derived classes 1551 (G4ClassicalRK4 G4SimpleRunge G4ExplicitE 1526 (G4ClassicalRK4 G4SimpleRunge G4ExplicitEuler G4ImplicitEuler G4SimpleHeum) 1552 o the constructors take G4EquationOfMotion 1527 o the constructors take G4EquationOfMotion in place of a G4Mag_EqRhs 1553 as it these applicable to all types of eq 1528 as it these applicable to all types of equations 1554 (not just ones for Magnetic field) 1529 (not just ones for Magnetic field) 1555 1530 1556 - G4EqMagElectricField 1531 - G4EqMagElectricField 1557 o derives from G4EquationOfMotion 1532 o derives from G4EquationOfMotion 1558 1533 1559 - G4ChordFinder 1534 - G4ChordFinder 1560 o Moved simple constructor to .cc file (tog 1535 o Moved simple constructor to .cc file (together with 'complex' one) 1561 o Changed fDefaultDeltaChord to a constant 1536 o Changed fDefaultDeltaChord to a constant member variable (from class var.) 1562 1537 1563 Nov 4th, 2003 G.Cosmo - field-V05-02-03 1538 Nov 4th, 2003 G.Cosmo - field-V05-02-03 1564 ---------------------- 1539 ---------------------- 1565 Undocumented. 1540 Undocumented. 1566 1541 1567 Nov 4th, 2003 G.Cosmo - field-V05-02-02 1542 Nov 4th, 2003 G.Cosmo - field-V05-02-02 1568 ---------------------- 1543 ---------------------- 1569 - G4ChordFinder.cc: 1544 - G4ChordFinder.cc: 1570 o Fixed compilation problem occuring when G 1545 o Fixed compilation problem occuring when G4DEBUG_FIELD was set. 1571 1546 1572 Oct 31st, 2003 G.Cosmo - field-V05-02-01 1547 Oct 31st, 2003 G.Cosmo - field-V05-02-01 1573 ----------------------- 1548 ----------------------- 1574 - Code cleanup and removal of redundant heade 1549 - Code cleanup and removal of redundant header includes, replaced 1575 where necessary by forward declarations. 1550 where necessary by forward declarations. 1576 1551 1577 Oct 24th, 2003 G.Cosmo - field-V05-02-00 1552 Oct 24th, 2003 G.Cosmo - field-V05-02-00 1578 ----------------------- 1553 ----------------------- 1579 - Migrated to use new G4Exception scheme. 1554 - Migrated to use new G4Exception scheme. 1580 - Updated outputs of unit tests. 1555 - Updated outputs of unit tests. 1581 1556 1582 Jun 25th, 2003 J.Apostolakis - field-V05-01- 1557 Jun 25th, 2003 J.Apostolakis - field-V05-01-06 1583 ----------------------------- 1558 ----------------------------- 1584 - Suppressed printing of statistics (by defau 1559 - Suppressed printing of statistics (by default) in MagIntegrationDriver. 1585 - Fix for unused variables warning in ChordFi 1560 - Fix for unused variables warning in ChordFinder. 1586 1561 1587 Jun 24th, 2003 J.Apostolakis - field-V05-01- 1562 Jun 24th, 2003 J.Apostolakis - field-V05-01-05 1588 ----------------------------- 1563 ----------------------------- 1589 - Fix for problems introduced in field-V05-01 1564 - Fix for problems introduced in field-V05-01-03: 1590 o G4ChordFinder: 1565 o G4ChordFinder: 1591 - Fixed unitialised variable for next ste 1566 - Fixed unitialised variable for next step (now used for optimisation). 1592 - Protected assignment of 'fLastStepEstim 1567 - Protected assignment of 'fLastStepEstimate_Unconstrained' in case of 1593 unitialised value. 1568 unitialised value. 1594 1569 1595 Jun 21st, 2003 J.Apostolakis - field-V05-01- 1570 Jun 21st, 2003 J.Apostolakis - field-V05-01-04 1596 ----------------------------- 1571 ----------------------------- 1597 - G4FieldManager: 1572 - G4FieldManager: 1598 o Revised into 'slightly' abstract class wi 1573 o Revised into 'slightly' abstract class with one (new) virtual method: 1599 ConfigureForTrack( const G4Track *) 1574 ConfigureForTrack( const G4Track *) 1600 to enable the user to configure it with d 1575 to enable the user to configure it with different accuracy parameters 1601 depending on energy, particle id, volume, 1576 depending on energy, particle id, volume, or other track state. 1602 Currently by default, no such configurati 1577 Currently by default, no such configuration action is undertaken. 1603 1578 1604 Jun 21st, 2003 J.Apostolakis - field-V05-01- 1579 Jun 21st, 2003 J.Apostolakis - field-V05-01-03 1605 ----------------------------- 1580 ----------------------------- 1606 - Revised G4ChordFinder: 1581 - Revised G4ChordFinder: 1607 * FindNextChord now provides next Step esti 1582 * FindNextChord now provides next Step estimate (for accuracy in Integr.) 1608 * AdvanceChordLimited to use 1583 * AdvanceChordLimited to use 1609 - above extra argument to FindNextChord 1584 - above extra argument to FindNextChord 1610 - the next Step argument as initial-step 1585 - the next Step argument as initial-step suggested to Accurate Advance 1611 - G4MagIntegratorDriver: 1586 - G4MagIntegratorDriver: 1612 * Added extra argument to Accurate Advance: 1587 * Added extra argument to Accurate Advance: 1613 hinitial: suggested initial step size 1588 hinitial: suggested initial step size 1614 - Note: 1589 - Note: 1615 * Purpose: performance boost with small/li 1590 * Purpose: performance boost with small/limited changes, 1616 including minor revisions of interfaces. 1591 including minor revisions of interfaces. 1617 1592 1618 Jun 20th, 2003 J.Apostolakis - field-V05-01- 1593 Jun 20th, 2003 J.Apostolakis - field-V05-01-02 1619 ----------------------------- 1594 ----------------------------- 1620 - G4MagIntegratorDriver Quick Advance: 1595 - G4MagIntegratorDriver Quick Advance: 1621 o Took out two unneccessary square roots an 1596 o Took out two unneccessary square roots and two divisions. 1622 - Notes: 1597 - Notes: 1623 1) Pure magnetic, electric, spin field test 1598 1) Pure magnetic, electric, spin field test are completed. 1624 2) Purpose: performance boost with small c 1599 2) Purpose: performance boost with small changes. 1625 1600 1626 Jun 20th, 2003 J.Apostolakis - field-V05-01- 1601 Jun 20th, 2003 J.Apostolakis - field-V05-01-01 1627 ----------------------------- 1602 ----------------------------- 1628 - G4MagIntegratorDriver: 1603 - G4MagIntegratorDriver: 1629 o Corrected neglected conversion to <std> f 1604 o Corrected neglected conversion to <std> from "G4std". 1630 - Migrated unit tests to <std>. 1605 - Migrated unit tests to <std>. 1631 1606 1632 Jun 19th, 2003 J.Apostolakis - field-V05-01- 1607 Jun 19th, 2003 J.Apostolakis - field-V05-01-00 1633 ----------------------------- 1608 ----------------------------- 1634 - G4ChordFinder: 1609 - G4ChordFinder: 1635 o Corrected simple constructor to initialis 1610 o Corrected simple constructor to initialise several member variables 1636 including LastStepEstimate_Unconstrained. 1611 including LastStepEstimate_Unconstrained. 1637 - G4MagIntegratorDriver: 1612 - G4MagIntegratorDriver: 1638 o Keep simple statistics on number of steps 1613 o Keep simple statistics on number of steps, total error and step size. 1639 o Took out an unneccessary square root (in 1614 o Took out an unneccessary square root (in loop). 1640 - NOTE: tests field0X are to be migrated. 1615 - NOTE: tests field0X are to be migrated. 1641 Purpose: fixes, small performance boost, si 1616 Purpose: fixes, small performance boost, simple statistics. 1642 1617 1643 Apr 2nd, 2003 G. Cosmo - field-V05-00-01 1618 Apr 2nd, 2003 G. Cosmo - field-V05-00-01 1644 --------------------------- 1619 --------------------------- 1645 - Created .cc files for G4MagneticField and G 1620 - Created .cc files for G4MagneticField and G4ElecroMagneticField. 1646 - Fixed definition of copy constructors in fi 1621 - Fixed definition of copy constructors in fields inheritance chain. 1647 - Moved obsolete method StepWithEst() to priv 1622 - Moved obsolete method StepWithEst() to private in G4RKG3_Stepper, 1648 G4CashKarpRKF45 and G4ClassicalRK4. 1623 G4CashKarpRKF45 and G4ClassicalRK4. 1649 - Cleared strict pedantic warnings. 1624 - Cleared strict pedantic warnings. 1650 1625 1651 Feb 5th, 2003 G. Cosmo - field-V05-00-00 1626 Feb 5th, 2003 G. Cosmo - field-V05-00-00 1652 --------------------------- 1627 --------------------------- 1653 - Removed redundant inclusions of PhysicalCon 1628 - Removed redundant inclusions of PhysicalConstants.h or SystemOfUnits.h. 1654 Now using directly CLHEP's headers. 1629 Now using directly CLHEP's headers. 1655 1630 1656 Dec 12th, 2002 G. Cosmo - field-V04-01-06 1631 Dec 12th, 2002 G. Cosmo - field-V04-01-06 1657 --------------------------- 1632 --------------------------- 1658 - Moved unused variable 'nStpPr' to debug sec 1633 - Moved unused variable 'nStpPr' to debug section in G4MagIntegratorDriver.cc, 1659 method AccurateAdvance(). 1634 method AccurateAdvance(). 1660 1635 1661 Dec 06th, 2002 G. Cosmo - field-V04-01-05 1636 Dec 06th, 2002 G. Cosmo - field-V04-01-05 1662 --------------------------- 1637 --------------------------- 1663 - Merged changes by Makoto for migration to n 1638 - Merged changes by Makoto for migration to new G4ApplicationState in 1664 messengers of unit tests. 1639 messengers of unit tests. 1665 1640 1666 Nov 29th, 2002 J. Apostolakis - field-V04 1641 Nov 29th, 2002 J. Apostolakis - field-V04-01-04 1667 --------------------------------- 1642 --------------------------------- 1668 Further fixes for unitialised variable - in o 1643 Further fixes for unitialised variable - in other steppers: 1669 G4ExplicitEuler, G4ImplicitEuler, G4ImplicitE 1644 G4ExplicitEuler, G4ImplicitEuler, G4ImplicitEuler 1670 1645 1671 Large memory leak fix for G4ImplicitEuler, sm 1646 Large memory leak fix for G4ImplicitEuler, small for ExplicitEuler. 1672 Test accuracy requirements for spin adjusted. 1647 Test accuracy requirements for spin adjusted. 1673 1648 1674 Nov 20th, 2002 J. Apostolakis - field-V04 1649 Nov 20th, 2002 J. Apostolakis - field-V04-01-03 1675 --------------------------------- 1650 --------------------------------- 1676 Further fixes for unitialised variables: 1651 Further fixes for unitialised variables: 1677 1652 1678 * G4MagIntegratorStepper 1653 * G4MagIntegratorStepper 1679 - Created instance variables for number of 1654 - Created instance variables for number of Integration, State variables 1680 1655 1681 * G4MagErrorStepper 1656 * G4MagErrorStepper 1682 - Utilise number of State variables to ini 1657 - Utilise number of State variables to initialise full state of Output. 1683 1658 1684 * G4Mag_SpinEqRhs 1659 * G4Mag_SpinEqRhs 1685 - Initialise the values of dydx that we do 1660 - Initialise the values of dydx that we do not update. 1686 1661 1687 Note: Undoing these changes and the ones belo 1662 Note: Undoing these changes and the ones below would enable the user to see 1688 if undefined values are used in varia 1663 if undefined values are used in variables that he/she expects to 1689 have integrated. 1664 have integrated. 1690 BUT the fix assists us to find truly un 1665 BUT the fix assists us to find truly undefined values elsewhere 1691 -- if they exist -- using valgrind. 1666 -- if they exist -- using valgrind. 1692 1667 1693 Nov 9th, 2002 J. Apostolakis - field-V04 1668 Nov 9th, 2002 J. Apostolakis - field-V04-01-02 1694 --------------------------------- 1669 --------------------------------- 1695 Fixes to address use of uninitialised variabl 1670 Fixes to address use of uninitialised variable in seting values of FieldTrack 1696 (this was done by design, but was neither ide 1671 (this was done by design, but was neither ideal or always well-behaved.) 1697 Changed: 1672 Changed: 1698 1673 1699 * G4MagIntegratorDriver 1674 * G4MagIntegratorDriver 1700 - Added instance variables for number of In 1675 - Added instance variables for number of Integration, State variables 1701 - Initialise all State variables of Output 1676 - Initialise all State variables of Output with values from initial variables. 1702 - Only the Integration variables will be in 1677 - Only the Integration variables will be integrated 1703 1678 1704 * G4ClassicalRK4 and G4MagErrorStepper 1679 * G4ClassicalRK4 and G4MagErrorStepper 1705 - Copy the initial time to intermediate and 1680 - Copy the initial time to intermediate and output C-vectors, 1706 in order to provide a zero-eth estimate 1681 in order to provide a zero-eth estimate value. 1707 Note1: Should clean-up this fix, making it 1682 Note1: Should clean-up this fix, making it similar to Driver (above) 1708 Note2: Should *not* be used for time varyin 1683 Note2: Should *not* be used for time varying field unless created 1709 with at least 8 integration variab 1684 with at least 8 integration variables 1710 --------------------------------- 1685 --------------------------------- 1711 G4ChordFinder.cc 1686 G4ChordFinder.cc 1712 - Correction from zero dChord 1687 - Correction from zero dChord 1713 which is does not update the Unconstrai 1688 which is does not update the Unconstrained step estimate (state) 1714 - Added instance variables to store number 1689 - Added instance variables to store number of calls and chord-trials 1715 and new print method for 'debugging' 1690 and new print method for 'debugging' 1716 1691 1717 G4Mag_UsualEqRhs.cc 1692 G4Mag_UsualEqRhs.cc 1718 - Attempted approximations for speedup *ov 1693 - Attempted approximations for speedup *overwritten* by full inverse sqrt. 1719 1694 1720 1695 1721 Oct 29th, 2002 J. Apostolakis - test-V04-0 1696 Oct 29th, 2002 J. Apostolakis - test-V04-01-02 1722 -------------------------------- 1697 -------------------------------- 1723 - Changed output of tests for small output ch 1698 - Changed output of tests for small output change (GeV->MeV) 1724 1699 1725 Oct 29th, 2002 J. Apostolakis - test-V04-0 1700 Oct 29th, 2002 J. Apostolakis - test-V04-01-02 1726 -------------------------------- 1701 -------------------------------- 1727 - (Only changed and tagged test subdirectory) 1702 - (Only changed and tagged test subdirectory) 1728 Changed tests to use the new method SetChar 1703 Changed tests to use the new method SetChargeMomentumMass of 1729 PropagatorInField in order to be ready for 1704 PropagatorInField in order to be ready for its full use in 1730 G4PropagatorInField. 1705 G4PropagatorInField. 1731 (A key problem at end-July was this non-pre 1706 (A key problem at end-July was this non-preparedness of the unit tests.) 1732 1707 1733 Jul 24th, 2002 G. Cosmo - field-V04-01-01 1708 Jul 24th, 2002 G. Cosmo - field-V04-01-01 1734 -------------------------- 1709 -------------------------- 1735 - G4FieldManager[.hh.cc]: made fDefault_Delta 1710 - G4FieldManager[.hh.cc]: made fDefault_Delta_One_Step_Value and 1736 fDefault_Delta_Intersection_Val normal cons 1711 fDefault_Delta_Intersection_Val normal constants (not static) to 1737 resolve initialisation problems. Coworks wi 1712 resolve initialisation problems. Coworks with tag "geomvol-V04-01-01". 1738 Fixes problem report #383. 1713 Fixes problem report #383. 1739 1714 1740 Jul 23rd, 2002 G. Cosmo - field-V04-01-00 1715 Jul 23rd, 2002 G. Cosmo - field-V04-01-00 1741 -------------------------- 1716 -------------------------- 1742 - G4MagIntegratorDriver.cc: cleared warning o 1717 - G4MagIntegratorDriver.cc: cleared warning of unused variable. 1743 Protected variable 'nStpPr' with G4DEBUG_FI 1718 Protected variable 'nStpPr' with G4DEBUG_FIELD. 1744 - Updated reference outputs and some other up 1719 - Updated reference outputs and some other updates to unit tests. 1745 1720 1746 Jun 25th, 2002 J. Apostolakis - field-V04- 1721 Jun 25th, 2002 J. Apostolakis - field-V04-00-05 1747 -------------------------------- 1722 -------------------------------- 1748 - G4ChordFinder.cc 1723 - G4ChordFinder.cc 1749 In NewStep: fixed case of stepTrial >> ste 1724 In NewStep: fixed case of stepTrial >> stepTrialOld, to take large multiple - not small; 1750 (it was treated the same as stepTrial 1725 (it was treated the same as stepTrial << old) 1751 Added guard for stepTrial==0.0 in FindNextC 1726 Added guard for stepTrial==0.0 in FindNextChord 1752 - G4MagIntegratorDriver.cc 1727 - G4MagIntegratorDriver.cc 1753 Added protection against error of 0.0 in Co 1728 Added protection against error of 0.0 in ComputeNewStepSize. 1754 1729 1755 - G4EquationOfMotion 1730 - G4EquationOfMotion 1756 Made RightHandSide an inline method 1731 Made RightHandSide an inline method 1757 In GetFieldValue signature of Point is doub 1732 In GetFieldValue signature of Point is double[4], instead of double[3] 1758 Defined G4maximum_number_of_field_component 1733 Defined G4maximum_number_of_field_components as enum 1759 1734 1760 Jun 7th, 2002 J. Apostolakis - field-V04- 1735 Jun 7th, 2002 J. Apostolakis - field-V04-00-04 1761 -------------------------------- 1736 -------------------------------- 1762 - G4Mag_SpinEqRhs.cc 1737 - G4Mag_SpinEqRhs.cc 1763 o Fix to momentum component of Rhs. 1738 o Fix to momentum component of Rhs. 1764 1739 1765 May 31st, 2002 J. Apostolakis - field-V04- 1740 May 31st, 2002 J. Apostolakis - field-V04-00-03 1766 -------------------------------- 1741 -------------------------------- 1767 - G4MagHelicalStepper.icc 1742 - G4MagHelicalStepper.icc 1768 o Fix to LinearStep (correcting previous 1743 o Fix to LinearStep (correcting previous fix/cosmetic) 1769 - G4ChordFinder.cc 1744 - G4ChordFinder.cc 1770 o Corrective behaviour for very small or 1745 o Corrective behaviour for very small or large changes of 'new step' 1771 [observed in complex 3-d fields (purgi 1746 [observed in complex 3-d fields (purging magnet), or 1772 approximate equations of 1747 approximate equations of motion ] 1773 - G4MagIntegratorDriver 1748 - G4MagIntegratorDriver 1774 o More information in debug printing (tan 1749 o More information in debug printing (tangent cosine, norm) 1775 1750 1776 May 7th, 2002 J. Apostolakis 1751 May 7th, 2002 J. Apostolakis 1777 -------------------------------- 1752 -------------------------------- 1778 - G4MagIntegratorDriver - ( on trunk ) 1753 - G4MagIntegratorDriver - ( on trunk ) 1779 * Fix to update the field track for steps s 1754 * Fix to update the field track for steps smaller than the chord finder's 1780 minstep. 1755 minstep. 1781 1756 1782 1757 1783 April 19th, 2002 J. Apostolakis (not inclu 1758 April 19th, 2002 J. Apostolakis (not included in tag field-V04-00-02) 1784 -------------------------------- 1759 -------------------------------- 1785 - G4MagIntegratorDriver.hh,cc (on trunk) 1760 - G4MagIntegratorDriver.hh,cc (on trunk) 1786 * Bug fix: last step can now only be trigg 1761 * Bug fix: last step can now only be triggerred if x+h > x2. 1787 * Debugging methods improved. 1762 * Debugging methods improved. 1788 1763 1789 May 7th, 2002 J. Apostolakis - field-V04- 1764 May 7th, 2002 J. Apostolakis - field-V04-00-02 1790 -------------------------------- 1765 -------------------------------- 1791 Tag including only two changes below: 1766 Tag including only two changes below: 1792 - Putting aside the other fixes/changes (as 1767 - Putting aside the other fixes/changes (as the one above) to 1793 G4MagIntegratorDriver, tagging only the fix t 1768 G4MagIntegratorDriver, tagging only the fix to update the field track 1794 for steps smaller than the chord finder's min 1769 for steps smaller than the chord finder's minstep. 1795 1770 1796 May 7th, 2002 J. Apostolakis 1771 May 7th, 2002 J. Apostolakis 1797 -------------------------------- 1772 -------------------------------- 1798 - G4MagIntegratorDriver - ** branch ** on 1773 - G4MagIntegratorDriver - ** branch ** on 1.20 ** 1799 * Fix to update the field track for steps s 1774 * Fix to update the field track for steps smaller than the chord finder's 1800 minstep. 1775 minstep. 1801 1776 1802 May 7th, 2002 J. Apostolakis 1777 May 7th, 2002 J. Apostolakis 1803 -------------------------------- 1778 -------------------------------- 1804 - G4MagIntegratorStepper 1779 - G4MagIntegratorStepper 1805 * Changed RightHandSide from a virtual meth 1780 * Changed RightHandSide from a virtual method to an inline (non-virtual) 1806 method -- it is not and should not be c 1781 method -- it is not and should not be changed by derived classes. 1807 1782 1808 Mar 28th, 2002 J. Apostolakis - field-V04-00 1783 Mar 28th, 2002 J. Apostolakis - field-V04-00-01 1809 ----------------------- 1784 ----------------------- 1810 - Fixed LinearStep in G4MagHelicalStepper (ex 1785 - Fixed LinearStep in G4MagHelicalStepper (expected unit direction), 1811 that had not been updated for new integra 1786 that had not been updated for new integration variable (momentum). 1812 --> found in testing helical steppers in 1787 --> found in testing helical steppers in BaBar setup, 1813 in region of negligible field. 1788 in region of negligible field. 1814 1789 1815 - Changed maximum number of steps in driver, 1790 - Changed maximum number of steps in driver, 1816 halving from 500/order to 250/order. 1791 halving from 500/order to 250/order. 1817 1792 1818 Mar 28th, 2002 J. Apostolakis 1793 Mar 28th, 2002 J. Apostolakis 1819 ----------------------- 1794 ----------------------- 1820 - Committed directory "OtherField" with examp 1795 - Committed directory "OtherField" with examples of fields, 1821 Delphi, Quadropole etc. 1796 Delphi, Quadropole etc. 1822 1797 1823 - Updated outputs of testPropagateMagField fo 1798 - Updated outputs of testPropagateMagField for new version of source, 1824 that has 3rd test case. 1799 that has 3rd test case. 1825 1800 1826 - Added new runs and outputs for testProElect 1801 - Added new runs and outputs for testProElectroMagField, with 1827 several steppers, and modified test scrip 1802 several steppers, and modified test script test.sh accordingly. 1828 1803 1829 1804 1830 Feb 2nd, 2002 V. Grichine 1805 Feb 2nd, 2002 V. Grichine 1831 ------------------------ 1806 ------------------------ 1832 Update of test/field02 to utilise new feature 1807 Update of test/field02 to utilise new features 1833 - for Electric Field, to signal that a fiel 1808 - for Electric Field, to signal that a field modifies the energy; 1834 - updating of time by integration, for time 1809 - updating of time by integration, for time dependent fields. 1835 1810 1836 Jan 10th, 2002 G. Cosmo - field-V04-00-00 1811 Jan 10th, 2002 G. Cosmo - field-V04-00-00 1837 ------------------------ 1812 ------------------------ 1838 - Activated G4DEBUG_FIELD in GNUmakefile. 1813 - Activated G4DEBUG_FIELD in GNUmakefile. 1839 1814 1840 Jan 7th, 2002 J. Apostolakis 1815 Jan 7th, 2002 J. Apostolakis 1841 ----------------------------- 1816 ----------------------------- 1842 - G4MagHelicalStepper.cc: renamed local varia 1817 - G4MagHelicalStepper.cc: renamed local variables "*Momentum*" to "*Velocity*". 1843 1818 1844 Dec 4th, 2001 G. Cosmo - field-V03-02-08 1819 Dec 4th, 2001 G. Cosmo - field-V03-02-08 1845 ----------------------- 1820 ----------------------- 1846 - Fixed interface to virtual functions in the 1821 - Fixed interface to virtual functions in the inheritance chain. 1847 Added 'virtual' qualifier to destructor and 1822 Added 'virtual' qualifier to destructor and GetFieldValue() for subclasses 1848 of G4Field which may act as base class for 1823 of G4Field which may act as base class for user-defined fields. 1849 Modified files: G4MagneticField.hh, G4Unifo 1824 Modified files: G4MagneticField.hh, G4UniformElectricField[.hh.cc], 1850 G4UniformMagField.hh. 1825 G4UniformMagField.hh. 1851 - G4ChordFinder.cc: the unphysical curve leng 1826 - G4ChordFinder.cc: the unphysical curve length exception has been moved to 1852 inside #ifdef G4DEBUG_FIELD. Other #ifdef r 1827 inside #ifdef G4DEBUG_FIELD. Other #ifdef renamed to G4DEBUG_FIELD. 1853 - G4LineSection[.hh.cc]: correction for A=B w 1828 - G4LineSection[.hh.cc]: correction for A=B when the distance from P to A 1854 is returned (V.Grichine). 1829 is returned (V.Grichine). 1855 1830 1856 Nov 28th, 2001 J. Apostolakis - field-V03-02 1831 Nov 28th, 2001 J. Apostolakis - field-V03-02-07 1857 ------------------------------ 1832 ------------------------------ 1858 G4FieldManager 1833 G4FieldManager 1859 - Added fFieldChangesEnergy data member and g 1834 - Added fFieldChangesEnergy data member and get/set methods 1860 ( required to allow transportation to know h 1835 ( required to allow transportation to know how to calculate end-time, 1861 enabling the integration of time only for 1836 enabling the integration of time only for electric fields. ) 1862 1837 1863 Nov 28th, 2001 J. Apostolakis - field-V03-02 1838 Nov 28th, 2001 J. Apostolakis - field-V03-02-06 1864 ------------------------------ 1839 ------------------------------ 1865 Small fixes only: 1840 Small fixes only: 1866 1841 1867 G4CashKarpRKF45 1842 G4CashKarpRKF45 1868 - fixed deletion of unassigned pointer/array 1843 - fixed deletion of unassigned pointer/array in destructor. (-> Volodya Velev) 1869 1844 1870 G4EqMagElectricField 1845 G4EqMagElectricField 1871 - bug fixed in the formula for inverse veloci 1846 - bug fixed in the formula for inverse velocity (-> V. Grichine) 1872 1847 1873 Nov 21st, 2001 G. Cosmo - field-V03-02-05 1848 Nov 21st, 2001 G. Cosmo - field-V03-02-05 1874 ------------------------ 1849 ------------------------ 1875 - Protected verbose warnings with G4FIELD_DEB 1850 - Protected verbose warnings with G4FIELD_DEBUG flag in G4ChordFinder.cc 1876 (V.Grichine). 1851 (V.Grichine). 1877 - Replaced G4DEBUG with G4DEBUG_FIELD in G4Ma 1852 - Replaced G4DEBUG with G4DEBUG_FIELD in G4MagIntegratorDriver.cc. 1878 - Updates to unit test field02. 1853 - Updates to unit test field02. 1879 1854 1880 Nov 13th, 2001 G. Cosmo - field-V03-02-04 1855 Nov 13th, 2001 G. Cosmo - field-V03-02-04 1881 ------------------------ 1856 ------------------------ 1882 - Removed warnings on gcc-2.95.2. 1857 - Removed warnings on gcc-2.95.2. 1883 - Included unit tests field01, field02, field 1858 - Included unit tests field01, field02, field03. 1884 1859 1885 Nov 9th, 2001 J. Apostolakis - field-V03-02- 1860 Nov 9th, 2001 J. Apostolakis - field-V03-02-03 1886 ----------------------------- 1861 ----------------------------- 1887 Motivated by the use case of an Electric Fiel 1862 Motivated by the use case of an Electric Field, 1888 - in order to achieve reasonable accuracy in 1863 - in order to achieve reasonable accuracy in time integration, 1889 - and to enable fields that vary with the gl 1864 - and to enable fields that vary with the global time) 1890 we (John Ap. and V. Grichine) changed the fol 1865 we (John Ap. and V. Grichine) changed the following: 1891 1866 1892 - Modified G4Field to allow the time in the G 1867 - Modified G4Field to allow the time in the GetFieldValue method 1893 - as 4th component of the "position" arr 1868 - as 4th component of the "position" array. 1894 1869 1895 - Modified EquationOfMotion to provide the ti 1870 - Modified EquationOfMotion to provide the time to the GetFieldValue method 1896 of G4Field 1871 of G4Field 1897 * as the 4th component of a position / 1872 * as the 4th component of a position / time 4-array 1898 * in place of only position as a 3-arry 1873 * in place of only position as a 3-arry 1899 1874 1900 - Added the global time as variable to be int 1875 - Added the global time as variable to be integrated over in the 1901 case of an Electric Field 1876 case of an Electric Field 1902 1877 1903 Support for these modifications is required i 1878 Support for these modifications is required in G4Transportation. 1904 1879 1905 (Better support will require either 1880 (Better support will require either 1906 - a modification in G4FieldTrack to indicate 1881 - a modification in G4FieldTrack to indicate whether the time has been 1907 integrated or not. 1882 integrated or not. 1908 - or additionally making the time calculatio 1883 - or additionally making the time calculation a property of G4FieldTrack, 1909 bring in code to do it in from G4Transpor 1884 bring in code to do it in from G4Transportation.) 1910 1885 1911 1886 1912 Nov 8th, 2001 J. Apostolakis - field-V03-02 1887 Nov 8th, 2001 J. Apostolakis - field-V03-02-02 1913 ------------------------ 1888 ------------------------ 1914 - Introduced several changes in G4MagIntegrat 1889 - Introduced several changes in G4MagIntegratorDriver. 1915 1890 1916 It now respects its minimum driver step si 1891 It now respects its minimum driver step size in AccurateAdvance. 1917 * whereas before it did not. 1892 * whereas before it did not. 1918 1893 1919 Modified maximum number of steps, lowering 1894 Modified maximum number of steps, lowering by factor of 10. 1920 -> it should reduce the time spent integ 1895 -> it should reduce the time spent integrating low energy particles, 1921 in some cases where it is unneccessary. 1896 in some cases where it is unneccessary. 1922 1897 1923 Protected printing of (nearly?) all warnin 1898 Protected printing of (nearly?) all warnings with a G4DEBUG_FIELD #ifdef. 1924 1899 1925 1900 1926 Nov 05th, 2001 G. Cosmo - field-V03-02-01 1901 Nov 05th, 2001 G. Cosmo - field-V03-02-01 1927 ------------------------ 1902 ------------------------ 1928 - Fixed trivial warnings on Linux-g++. 1903 - Fixed trivial warnings on Linux-g++. 1929 1904 1930 Aug 27th, 2001 J. Apostolakis - field-V03-02 1905 Aug 27th, 2001 J. Apostolakis - field-V03-02-00 1931 ------------------------------ 1906 ------------------------------ 1932 Tagged last change. 1907 Tagged last change. 1933 This tag is utilised in transport-V03-02-01 ( 1908 This tag is utilised in transport-V03-02-01 (which requires it). 1934 1909 1935 Aug 16th, 2001 J. Apostolakis 1910 Aug 16th, 2001 J. Apostolakis 1936 ------------------------------ 1911 ------------------------------ 1937 G4ChordFinder: 1912 G4ChordFinder: 1938 Added method to erase/reset the state of the 1913 Added method to erase/reset the state of the StepEstimate. 1939 This is unwanted internal state that was car 1914 This is unwanted internal state that was carried between tracks and 1940 events as a side effect. 1915 events as a side effect. 1941 1916 1942 Calling this at the start of each track, it 1917 Calling this at the start of each track, it is now possible to 1943 eliminate a non-repeatability that was possi 1918 eliminate a non-repeatability that was possible due to this. 1944 ( It has been observed in particular in v 1919 ( It has been observed in particular in vaccuum. ) 1945 1920 1946 May 23rd, 2001 J. Apostolakis - field-V03-01 1921 May 23rd, 2001 J. Apostolakis - field-V03-01-02 1947 ------------------------------ 1922 ------------------------------ 1948 - Added Exception to G4RKG3Stepper constructo 1923 - Added Exception to G4RKG3Stepper constructor: the class does not work 1949 1924 1950 May 23rd, 2001 J. Apostolakis - field-V03-01 1925 May 23rd, 2001 J. Apostolakis - field-V03-01-01 1951 ------------------------------ 1926 ------------------------------ 1952 - Fixed G4FieldManager constructors to give d 1927 - Fixed G4FieldManager constructors to give default values to delta 1953 parameters. 1928 parameters. 1954 1929 1955 - Updated testPropagateSpin (it now compiles) 1930 - Updated testPropagateSpin (it now compiles), 1956 and some outputs of testPropagateMagField 1931 and some outputs of testPropagateMagField (1 to 5) 1957 1932 1958 1933 1959 Apr 12th, 2001 P. Gumplinger - field-V03-01- 1934 Apr 12th, 2001 P. Gumplinger - field-V03-01-00 1960 ----------------------------- 1935 ----------------------------- 1961 - Updated G4Mag_SpinEqRhs.hh and G4Mag_SpinEq 1936 - Updated G4Mag_SpinEqRhs.hh and G4Mag_SpinEqRhs.cc for correction 1962 to spin tracking. 1937 to spin tracking. 1963 1938 1964 Apr 04th, 2001 G. Cosmo - field-V03-00-05 1939 Apr 04th, 2001 G. Cosmo - field-V03-00-05 1965 ------------------------ 1940 ------------------------ 1966 - G4FieldTrack.icc: fixed pedantic warnings o 1941 - G4FieldTrack.icc: fixed pedantic warnings on Linux-g++. 1967 1942 1968 Mar 23rd, 2001 J. Apostolakis - field-V03-00 1943 Mar 23rd, 2001 J. Apostolakis - field-V03-00-04 1969 ------------------------------ 1944 ------------------------------ 1970 - Electric Field unit test now works: test ru 1945 - Electric Field unit test now works: test runs until completion. 1971 Test outputs saved (on Linux). 1946 Test outputs saved (on Linux). 1972 1947 1973 - Fixed src/G4UniformElectricField.cc to set 1948 - Fixed src/G4UniformElectricField.cc to set correct field components 1974 (compat 1949 (compatible with Equation of Motion 1975 G4EqMa 1950 G4EqMagElectricField ) 1976 1951 1977 - Tidied G4FieldTrack 1952 - Tidied G4FieldTrack 1978 * deleted obsolete methods Set/Get Momentu 1953 * deleted obsolete methods Set/Get MomentumModulus() and its data member. 1979 * in constructor to set the value of the s 1954 * in constructor to set the value of the spin to (0.0, 0.0, 0.0) 1980 if pSpin is null. (It was undefine 1955 if pSpin is null. (It was undefined.) 1981 1956 1982 Mar 23rd, 2001 J. Apostolakis - field-V03-00 1957 Mar 23rd, 2001 J. Apostolakis - field-V03-00-03 1983 ------------------------------ 1958 ------------------------------ 1984 - Fixed (hacked) CashKarp to work using Auxil 1959 - Fixed (hacked) CashKarp to work using Auxiliary Stepper. 1985 1960 1986 - Modified G4MagIntegratorStepper 1961 - Modified G4MagIntegratorStepper 1987 to use pointer to G4EquationOfMotion 1962 to use pointer to G4EquationOfMotion 1988 instead of G4Mag_EqRhs 1963 instead of G4Mag_EqRhs 1989 1964 1990 - Design iteration appears neccessary 1965 - Design iteration appears neccessary 1991 1966 1992 Mar 23rd, 2001 J. Apostolakis - field-V03-00 1967 Mar 23rd, 2001 J. Apostolakis - field-V03-00-02 1993 ------------------------------ 1968 ------------------------------ 1994 - Fixed G4MagHelicalStepper::AdvanceHelix for 1969 - Fixed G4MagHelicalStepper::AdvanceHelix for momentum, allowing 1995 the possibility of (correct) use of all H 1970 the possibility of (correct) use of all Helical Steppers. 1996 1971 1997 - test/testProElectroMagField.cc updated for 1972 - test/testProElectroMagField.cc updated for momentum. 1998 (Not yet updated: Spin tests) 1973 (Not yet updated: Spin tests) 1999 1974 2000 1975 2001 Mar 19th, 2001 J. Apostolakis - field-V03-00 1976 Mar 19th, 2001 J. Apostolakis - field-V03-00-01 2002 ------------------------------ 1977 ------------------------------ 2003 - Tagging the modification of several classes 1978 - Tagging the modification of several classes to integrate in momentum*c_light 2004 instead of velocity. 1979 instead of velocity. 2005 Reason for change: Velocity integration ca 1980 Reason for change: Velocity integration can result in superluminar 2006 velocities, due to arithmetic inaccuraci 1981 velocities, due to arithmetic inaccuracies. 2007 Classes modified: 1982 Classes modified: 2008 G4FieldTrack, (Changed components 3,4,5 1983 G4FieldTrack, (Changed components 3,4,5 of SixVector to Momentum, 2009 G4Mag_EqRhs, G4Mag_UsualEqRhs, G4EqMagEle 1984 G4Mag_EqRhs, G4Mag_UsualEqRhs, G4EqMagElectricField 2010 1985 2011 Feb 20th, 2001 J. Apostolakis 1986 Feb 20th, 2001 J. Apostolakis 2012 1987 2013 - Modified several classes to integrate in mo 1988 - Modified several classes to integrate in momentum instead of velocity. 2014 1989 2015 G4FieldTrack: 1990 G4FieldTrack: 2016 Changed components 3,4,5 of SixVector to 1991 Changed components 3,4,5 of SixVector to Momentum, 2017 Modified constructor 1992 Modified constructor 2018 Added energy calculation to "LoadFromArr 1993 Added energy calculation to "LoadFromArray" method 2019 GetEnergy method is now implemented. 1994 GetEnergy method is now implemented. 2020 Deleted obsolete (old) method names for 1995 Deleted obsolete (old) method names for Curve and Position. New have "Get" 2021 1996 2022 G4ChordFinder 1997 G4ChordFinder 2023 Renamed old-method names of Field Track 1998 Renamed old-method names of Field Track to new ones. 2024 1999 2025 Jan 29th, 2001 G. Cosmo - field-V03-00-00 2000 Jan 29th, 2001 G. Cosmo - field-V03-00-00 2026 ------------------------- 2001 ------------------------- 2027 2002 2028 - Minor fix to G4MagneticField.hh: added expl 2003 - Minor fix to G4MagneticField.hh: added explicit call to G4Field() in 2029 copy constructor. Fixes report #205. 2004 copy constructor. Fixes report #205. 2030 2005 2031 Nov 20th, 2000 G. Cosmo - field-V02-00-02 2006 Nov 20th, 2000 G. Cosmo - field-V02-00-02 2032 2007 2033 - Fixes to remove warnings from "-Wall -ansi 2008 - Fixes to remove warnings from "-Wall -ansi -pedantic" g++ compiler options: 2034 o commented out variables declared and not 2009 o commented out variables declared and not used. 2035 o fixed declaration of variables used befor 2010 o fixed declaration of variables used before being initialised. 2036 o fixed order of initialisation of member d 2011 o fixed order of initialisation of member data in constructors. 2037 o fixed usage of unsigned-int (size_t) for 2012 o fixed usage of unsigned-int (size_t) for array indeces. 2038 2013 2039 Nov 9th, 2000 G. Cosmo - field-V02-00-01 2014 Nov 9th, 2000 G. Cosmo - field-V02-00-01 2040 2015 2041 - G4FieldManager: added check on existence of 2016 - G4FieldManager: added check on existence of allocated fChordFinder 2042 in CreateChordFinder(G4MagneticField*) meth 2017 in CreateChordFinder(G4MagneticField*) method. 2043 2018 2044 Nov 1st, 2000 G. Cosmo - field-V02-00-00 2019 Nov 1st, 2000 G. Cosmo - field-V02-00-00 2045 2020 2046 - QA code revision and cleanup (+fixes from C 2021 - QA code revision and cleanup (+fixes from CodeWizard filtering): 2047 o Added (private) declarations of copy cons 2022 o Added (private) declarations of copy constructor and assignment operator 2048 where needed. 2023 where needed. 2049 o Added "const" qualifier to accessor metho 2024 o Added "const" qualifier to accessor methods, wherever needed. 2050 o Added equality check on operator= where n 2025 o Added equality check on operator= where needed. 2051 o Made destructor "virtual" for classes hav 2026 o Made destructor "virtual" for classes having virtual methods, 2052 wherever missing. 2027 wherever missing. 2053 o Changed virtual functions to non-inline w 2028 o Changed virtual functions to non-inline wherever's the case. 2054 o Changed return value to be "const" pointe 2029 o Changed return value to be "const" pointer to functions: 2055 - G4EquationOfMotion::GetFieldObj() 2030 - G4EquationOfMotion::GetFieldObj() 2056 - G4FieldManager::GetDetectorField() 2031 - G4FieldManager::GetDetectorField() 2057 - G4MagIntegratorDriver::GetStepper() 2032 - G4MagIntegratorDriver::GetStepper() 2058 o Fixed and corrected signature to G4MagInt 2033 o Fixed and corrected signature to G4MagIntegratorDriver::SetHmin(). 2059 o Added "inline" qualifier to methods' decl 2034 o Added "inline" qualifier to methods' declarations. 2060 o General cosmetics 2035 o General cosmetics 2061 2036 2062 Jun 2nd, 2000 J. Apostolakis 2037 Jun 2nd, 2000 J. Apostolakis 2063 - G4FieldManager[.hh.icc] 2038 - G4FieldManager[.hh.icc] 2064 o Added DeltaIntersection and DeltaOneStep 2039 o Added DeltaIntersection and DeltaOneStep to FieldManager: added 2065 Get/Set methods and SetAccuraciesWithDelt 2040 Get/Set methods and SetAccuraciesWithDeltaOneStep(). 2066 2041 2067 May 31st, 2000 J. Apostolakis - field-V01-01 2042 May 31st, 2000 J. Apostolakis - field-V01-01-03 2068 2043 2069 include/G4FieldManager.hh,icc 2044 include/G4FieldManager.hh,icc 2070 o Moved Delta Intersection and Delta One St 2045 o Moved Delta Intersection and Delta One Step to FieldManager 2071 (from Propagator in Field), to allow th 2046 (from Propagator in Field), to allow them to differ over the detector. 2072 2047 2073 May 11th, 2000 J. Apostolakis - field-V01-01 2048 May 11th, 2000 J. Apostolakis - field-V01-01-02 2074 2049 2075 - G4ChordFinder[.hh.cc] 2050 - G4ChordFinder[.hh.cc] 2076 o Modified method for finding new trial ste 2051 o Modified method for finding new trial step. 2077 New method assumes a quadratic relationsh 2052 New method assumes a quadratic relationship between step-length and d_chord: 2078 d_chord proportional to step-l 2053 d_chord proportional to step-lenght ^ 2 2079 o Added two small refinement in order to av 2054 o Added two small refinement in order to avoid unneccesary extra step due to 2080 small numerical inaccuracies in estimatio 2055 small numerical inaccuracies in estimation: 2081 FindNextChord 2056 FindNextChord 2082 to first step use (1-0.001) 2057 to first step use (1-0.001) * last-step-estimate 2083 New Step: 2058 New Step: 2084 to subsequent step use trial_st 2059 to subsequent step use trial_step = 0.98 * estimate 2085 2060 2086 May 10th, 2000 G. Cosmo 2061 May 10th, 2000 G. Cosmo 2087 2062 2088 - G4MagneticField.hh: minor fix to dummy impl 2063 - G4MagneticField.hh: minor fix to dummy implementation of assignment 2089 operator. 2064 operator. 2090 2065 2091 May 9th, 2000 J. Apostolakis - field-V01 2066 May 9th, 2000 J. Apostolakis - field-V01-01-01 2092 2067 2093 - G4MagErrorStepper: 2068 - G4MagErrorStepper: 2094 Modified DistChord to check whether the c 2069 Modified DistChord to check whether the chord endpoint are the same point. 2095 2070 2096 - G4RKG3_Stepper: 2071 - G4RKG3_Stepper: 2097 Deleted error message from StepNoErr, as 2072 Deleted error message from StepNoErr, as it is used in Stepper. 2098 2073 2099 - G4MagIntegratorDriver: 2074 - G4MagIntegratorDriver: 2100 Changed the condition for the debug outpu 2075 Changed the condition for the debug output (~cosmetic) 2101 2076 2102 2077 2103 April 27th, 2000 G. Cosmo 2078 April 27th, 2000 G. Cosmo 2104 2079 2105 - Reorganised comments for the Software Refer 2080 - Reorganised comments for the Software Reference Manual. 2106 - Moved inlined definition to .icc files, whe 2081 - Moved inlined definition to .icc files, where needed. 2107 Created: G4ChordFinder.icc and G4FieldManag 2082 Created: G4ChordFinder.icc and G4FieldManager.icc. 2108 2083 2109 April 13th, 2000 J. Apostolakis - field-V01 2084 April 13th, 2000 J. Apostolakis - field-V01-01-00 2110 2085 2111 - Modified signature to function DumbStepper( 2086 - Modified signature to function DumbStepper() in classes: 2112 G4HelixExplicitEuler, G4HelixHeum, G4HelixI 2087 G4HelixExplicitEuler, G4HelixHeum, G4HelixImplicitEuler, 2113 G4HelixSimpleRunge and G4MagHelicalStepper. 2088 G4HelixSimpleRunge and G4MagHelicalStepper. 2114 - Modified signature and implementation of fu 2089 - Modified signature and implementation of function MagFieldEvaluate() 2115 in G4MagHelicalStepper, to use Field (as Th 2090 in G4MagHelicalStepper, to use Field (as ThreeVector) in place of dydx. 2116 - Made Richardson extrapolation optional (it 2091 - Made Richardson extrapolation optional (it is unclear if 2117 it offers benefit) in G4MagHelicalStepper. 2092 it offers benefit) in G4MagHelicalStepper. 2118 - Updated unit test testPropagateMagField and 2093 - Updated unit test testPropagateMagField and reference output. 2119 - G4LineSection: fixes to prevent divisions b 2094 - G4LineSection: fixes to prevent divisions by 0. and sqrt(<0) 2120 (V.Grichine). 2095 (V.Grichine). 2121 2096 2122 January 19th, 2000 G. Cosmo - field-V01-00 2097 January 19th, 2000 G. Cosmo - field-V01-00-00 2123 2098 2124 Syncronized versioning of files with HEAD aft 2099 Syncronized versioning of files with HEAD after ISO-C++ migration 2125 (essentially CVS header changes). 2100 (essentially CVS header changes). 2126 2101 2127 December 7th, 1999 J. Apostolakis - field- 2102 December 7th, 1999 J. Apostolakis - field-V00-01-01a 2128 2103 2129 For negative or very small curve lengths (h) 2104 For negative or very small curve lengths (h) we suppress writing an error 2130 (about the distance of endpoints being furthe 2105 (about the distance of endpoints being further than the curve length), 2131 as it is meaningless. 2106 as it is meaningless. 2132 2107 2133 November 23rd, 1999 J. Apostolakis - field- 2108 November 23rd, 1999 J. Apostolakis - field-V00-01-01 2134 2109 2135 Tagged this sub-category's state in geometry- 2110 Tagged this sub-category's state in geometry-V00-01-01 2136 2111 2137 2112 2138 July 6th, 1999 J. Apostolakis - field- 2113 July 6th, 1999 J. Apostolakis - field-01-00-07 2139 2114 2140 These fixes and those in field-01-00-06 and f 2115 These fixes and those in field-01-00-06 and field-01-00-06a all come 2141 from the need to cope with the imprecision of 2116 from the need to cope with the imprecision of the integration, and its 2142 interaction with paths that are rather straig 2117 interaction with paths that are rather straight. 2143 2118 2144 G4MagIntegrationDriver: 2119 G4MagIntegrationDriver: 2145 i) AccurateAdvance now that the chord distan 2120 i) AccurateAdvance now that the chord distance is smaller than the curve len- 2146 gth (times 1+epsilon). 2121 gth (times 1+epsilon). 2147 2122 2148 ii) OneGoodStep and QuickAdvance considers th 2123 ii) OneGoodStep and QuickAdvance considers the error of the velocity as well as 2149 the error of the position - and ensure that b 2124 the error of the position - and ensure that both relative errors are within 2150 the "eps" maximum given. 2125 the "eps" maximum given. 2151 2126 2152 G4ChordFinder: 2127 G4ChordFinder: 2153 Having found that the curve_length vs ABdis 2128 Having found that the curve_length vs ABdist disrepancy has its basis in 2154 the imprecision of the integration: 2129 the imprecision of the integration: 2155 i) Modified the exception in this case to h 2130 i) Modified the exception in this case to happen only for very large 2156 relative disrepancies ( 10 * eps ). 2131 relative disrepancies ( 10 * eps ). 2157 ii) Undertaken a default corrective action i 2132 ii) Undertaken a default corrective action in all other cases 2158 Note that this disrepancy only happens for ve 2133 Note that this disrepancy only happens for very straight sections of track - 2159 ie step lengths much smaller than the curvatu 2134 ie step lengths much smaller than the curvature of the track. 2160 2135 2161 July 1st, 1999 J. Apostolakis - field- 2136 July 1st, 1999 J. Apostolakis - field-01-00-06a 2162 2137 2163 In order to cope with the anomalous condition 2138 In order to cope with the anomalous condition created by candidate fix 2164 in G4PropagatorInField, we ensure that the f 2139 in G4PropagatorInField, we ensure that the fraction_AE is always between 2165 0 and 1.0. (giving it a default value of 0.5 2140 0 and 1.0. (giving it a default value of 0.5 whenever it is wrong). 2166 ( in G4ChordFinder::ApproxCurvePointV ) 2141 ( in G4ChordFinder::ApproxCurvePointV ) 2167 2142 2168 June 29th, 1999 J. Apostolakis - field- 2143 June 29th, 1999 J. Apostolakis - field-01-00-06 2169 2144 2170 I re-instated a check on whether the input 2145 I re-instated a check on whether the input distance along the curve between 2171 the two input curve points is truly greater t 2146 the two input curve points is truly greater than their linear distance. 2172 ( in G4ChordFinder::ApproxCurvePointV ) 2147 ( in G4ChordFinder::ApproxCurvePointV ) 2173 2148 2174 The condition that prints out a warning messa 2149 The condition that prints out a warning message has been altered to 2175 take into account the case of a very small fi 2150 take into account the case of a very small final interval. 2176 ( in G4MagInt_Driver::AccurateAdvance ) 2151 ( in G4MagInt_Driver::AccurateAdvance ) 2177 2152 2178 June ??th, 1999 J. Apostolakis - field- 2153 June ??th, 1999 J. Apostolakis - field-01-00-05 2179 2154 2180 The condition that prints out a warning messa 2155 The condition that prints out a warning message was changed to delete 2181 an incorrect comparison. 2156 an incorrect comparison. 2182 ( in G4MagInt_Driver::AccurateAdvance ) 2157 ( in G4MagInt_Driver::AccurateAdvance ) 2183 2158 2184 April 19th, 1999 J. Apostolakis - field- 2159 April 19th, 1999 J. Apostolakis - field-01-00-04 2185 2160 2186 G4MagErrorStepper: Cosmetic changes to name o 2161 G4MagErrorStepper: Cosmetic changes to name of data members 2187 2162 2188 March 4th, 1999 J. Apostolakis - field- 2163 March 4th, 1999 J. Apostolakis - field-01-00-03 2189 2164 2190 Corrected delete statement of arrays to use ' 2165 Corrected delete statement of arrays to use 'delete[]' instead of simple delete 2191 in destructors of 2 steppers (G4CashKarpRKF45 2166 in destructors of 2 steppers (G4CashKarpRKF45, G4SimpleHeum) 2192 2167 2193 February 17th, 1999 J. Apostolakis - field 2168 February 17th, 1999 J. Apostolakis - field-01-00-02 2194 2169 2195 Moved G4PropagatorInField files to geometry/ 2170 Moved G4PropagatorInField files to geometry/volumes. 2196 Updated GNUmakefile not to depend on geometr 2171 Updated GNUmakefile not to depend on geometry/volumes anymore. 2197 -> the known circular dependency is remove 2172 -> the known circular dependency is removed 2198 2173 2199 2174 2200 February 12th, 1999 J. Apostolakis - field 2175 February 12th, 1999 J. Apostolakis - field-spin1-works1 (act Feb17) 2201 2176 2202 A tag that contains the first version that 2177 A tag that contains the first version that worked with spin (in Peter G.'s 2203 directory). G4PropagateInSpin is still in t 2178 directory). G4PropagateInSpin is still in this version. A small change 2204 in a branch of the header file was needed. 2179 in a branch of the header file was needed. 2205 2180 2206 2181 2207 February 10th, 1999 J. Apostolakis 2182 February 10th, 1999 J. Apostolakis 2208 2183 2209 All the following changes are needed for ener 2184 All the following changes are needed for energy integration also: 2210 2185 2211 G4ChordFinder now passes to the constructed d 2186 G4ChordFinder now passes to the constructed driver the number of variables. 2212 Because of the need for the stepper to know a 2187 Because of the need for the stepper to know about it in its Abstract interface 2213 2188 2214 -> Moved theNumberOfVariables from derived c 2189 -> Moved theNumberOfVariables from derived class G4MagErrorStepper 2215 to base class 2190 to base class G4MagIntegratorStepper 2216 2191 2217 As a consequense the classes that derived fro 2192 As a consequense the classes that derived from G4MagIntegratorStepper directly 2218 were changed: G4CashKarpRKF45, G4MagHelicalSt 2193 were changed: G4CashKarpRKF45, G4MagHelicalStepper, 2219 2194 2220 2195 2221 February 9th, 1999 J. Apostolakis 2196 February 9th, 1999 J. Apostolakis 2222 2197 2223 Equation of Motion: 2198 Equation of Motion: 2224 G4MagEqRhs.hh Made SetChargeMomentumMass vir 2199 G4MagEqRhs.hh Made SetChargeMomentumMass virtual, so that G4Mag_SpinEqRhs 2225 can initialise its constants 2200 can initialise its constants too. 2226 2201 2227 2202 2228 February 9th, 1999 P. Gumplinger 2203 February 9th, 1999 P. Gumplinger 2229 2204 2230 Added Equation of Motion for Spin in Magnetic 2205 Added Equation of Motion for Spin in Magnetic Field. 2231 2206 2232 2207 2233 February 17th, 1999 J. Apostolakis - fiel 2208 February 17th, 1999 J. Apostolakis - field-01-00-01 2234 ---> date is correct, made sure that tag d 2209 ---> date is correct, made sure that tag does not include above fixes! 2235 2210 2236 Moved G4PropagatorInField files to geometry/ 2211 Moved G4PropagatorInField files to geometry/volumes. 2237 Updated GNUmakefile not to depend on geometr 2212 Updated GNUmakefile not to depend on geometry/volumes anymore. 2238 -> the known circular dependency is remove 2213 -> the known circular dependency is removed 2239 2214 2240 2215 2241 --------------------------------------------- 2216 --------------------------------------------------------------------------- 2242 ------ Geant 4 Production Release - 2217 ------ Geant 4 Production Release ------------ 2243 --------------------------------------------- 2218 -------------------------------------------------------------------------- 2244 Nov 19th, 1998 J. Apostolakis - field-0 2219 Nov 19th, 1998 J. Apostolakis - field-00-04-01head ===> R+D version only 2245 2220 2246 G4PropagatorInField files modified: 2221 G4PropagatorInField files modified: 2247 2222 2248 - to store the last safety computed and it 2223 - to store the last safety computed and its origin. 2249 - to give them to a requester 2224 - to give them to a requester 2250 --------------------------------------------- 2225 ------------------------------------------------------------------ 2251 2226 2252 Nov 19th, 1998 J. Apostolakis - field-0 2227 Nov 19th, 1998 J. Apostolakis - field-00-03-03b 2253 2228 2254 Subtle fix to interface of G4UniformMagField 2229 Subtle fix to interface of G4UniformMagField::GetFieldValue 2255 ( that tripped Visual C++ ) 2230 ( that tripped Visual C++ ) 2256 2231 2257 G4PropagatorInField: added printing method 2232 G4PropagatorInField: added printing method for verboseness. 2258 2233 2259 Nov 19th, 1998 J. Apostolakis - field-0 2234 Nov 19th, 1998 J. Apostolakis - field-00-03-03a 2260 2235 2261 Steppers: Fixed instance variables constr 2236 Steppers: Fixed instance variables construction (SimpleRunge) 2262 and clash of names in CashKarp: 2237 and clash of names in CashKarp::StepWithEstimate 2263 2238 2264 Added post-const to all Field classes for 2239 Added post-const to all Field classes for 2265 void GetFieldValue(const G4double 2240 void GetFieldValue(const G4double yTrack[] , 2266 G4double B[] 2241 G4double B[] ) const ; 2267 2242 2268 Added SetFieldValue methods to UniformMagF 2243 Added SetFieldValue methods to UniformMagField 2269 2244 2270 Added GetConstantFieldValue() methods to U 2245 Added GetConstantFieldValue() methods to Uniform Mag & Electric Fields 2271 2246 2272 2247 2273 Nov 19th, 1998 J. Apostolakis - field-0 2248 Nov 19th, 1998 J. Apostolakis - field-00-03-03 2274 2249 2275 Fixes to Propagate and Steppers 2250 Fixes to Propagate and Steppers 2276 2251 2277 Nov 19th, 1998 J. Apostolakis - field-0 2252 Nov 19th, 1998 J. Apostolakis - field-00-03-02 2278 2253 2279 Minor corrections (???) 2254 Minor corrections (???) 2280 2255 2281 Nov 19th, 1998 J. Apostolakis - field-0 2256 Nov 19th, 1998 J. Apostolakis - field-00-03-02 2282 2257 2283 Major development to allow Electric Field 2258 Major development to allow Electric Field 2284 2259 2285 2260 2286 2261 2287 June 17th, 1998 J. Apostolakis - magfiel 2262 June 17th, 1998 J. Apostolakis - magfield-06-03 2288 2263 2289 Modified Files: 2264 Modified Files: 2290 include/G4PropagatorInField.hh 2265 include/G4PropagatorInField.hh 2291 src/G4PropagatorInField.cc 2266 src/G4PropagatorInField.cc 2292 test/testPropagateInField.cc 2267 test/testPropagateInField.cc 2293 --------------------------------------------- 2268 ---------------------------------------------------------------------- 2294 2269 2295 1) Added an assertion after each call to Lo 2270 1) Added an assertion after each call to LocateGlobalPointAndSetup. 2296 It checks that the located volume is equ 2271 It checks that the located volume is equal to the current volume. 2297 If this check fails, the Propagator does 2272 If this check fails, the Propagator does not know how to continue. 2298 2273 2299 2) Added an argument to ComputeStep method 2274 2) Added an argument to ComputeStep method of G4PropagatorInField. 2300 The new volume argument is used to check th 2275 The new volume argument is used to check the current volume during the step. 2301 2276 2302 3) When G4Navigator's ComputeStep returned 2277 3) When G4Navigator's ComputeStep returned stepLength==stepRequested, this 2303 used to be treated as a failure to intersect. 2278 used to be treated as a failure to intersect. This is incorrect. 2304 2279 2305 stepLength==stepRequested is an intersect 2280 stepLength==stepRequested is an intersection, 2306 so I am now treating it as such in each 2281 so I am now treating it as such in each comparison (of 3). 2307 Ignoring it causes problems, including 2282 Ignoring it causes problems, including volume being skipped. 2308 --> but treating it as an intersection 2283 --> but treating it as an intersection used to cause problems too ?? 2309 2284 2310 2285 2311 May 7th, 1998 J. Apostolakis - magfie 2286 May 7th, 1998 J. Apostolakis - magfield-06-02-helix01 2312 2287 2313 - Tag includes new version of G4ChordFinder ( 2288 - Tag includes new version of G4ChordFinder (not used by W.Wander). 2314 2289 2315 2290 2316 May 7th, 1998 W. Wander (recorded/c 2291 May 7th, 1998 W. Wander (recorded/commited by J. Apostolakis) 2317 2292 2318 - New "helical" RK steppers that move in heli 2293 - New "helical" RK steppers that move in helical segments, not linear. 2319 * Several changes to add steppers 2294 * Several changes to add steppers 2320 2295 2321 Modified Files: 2296 Modified Files: 2322 G4MagErrorStepper.hh 2297 G4MagErrorStepper.hh 2323 G4MagErrorStepper.cc 2298 G4MagErrorStepper.cc 2324 added Helical stepping methods to 2299 added Helical stepping methods to this general ABC. 2325 2300 2326 G4MagIntegratorStepper.hh 2301 G4MagIntegratorStepper.hh 2327 made RightHandSide virtual (this 2302 made RightHandSide virtual (this will be reversed very soon) 2328 2303 2329 testPropagateMagField.cc 2304 testPropagateMagField.cc 2330 Test of Helical stepping functiona 2305 Test of Helical stepping functionality added. 2331 2306 2332 Added Files for new Helical RK steppers, der 2307 Added Files for new Helical RK steppers, deriving from G4MagErrorStepper: 2333 G4HelixExplicitEuler.cc ( and .hh ) 2308 G4HelixExplicitEuler.cc ( and .hh ) 2334 G4HelixHeum.cc 2309 G4HelixHeum.cc 2335 G4HelixImplicitEuler.cc 2310 G4HelixImplicitEuler.cc 2336 G4HelixSimpleRunge.cc 2311 G4HelixSimpleRunge.cc 2337 2312 2338 Added File for implementation: 2313 Added File for implementation: 2339 G4MagErrorStepper.icc 2314 G4MagErrorStepper.icc 2340 2315 2341 2316 2342 May 7th, 1998 J. Apostolakis - magfi 2317 May 7th, 1998 J. Apostolakis - magfield-06-01 2343 2318 2344 - added small changes to 2319 - added small changes to 2345 * G4ChordFinder: methods to get 2320 * G4ChordFinder: methods to get/set IntegratorDriver 2346 * G4MagIntegratorDriver: made OneGoodSt 2321 * G4MagIntegratorDriver: made OneGoodStep method public 2347 - created the file. 2322 - created the file.